[Koha-bugs] [Bug 12261] Staff client next/previous links lead to unknown record

2014-06-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12261

--- Comment #13 from Juhani Seppälä jsep...@student.uef.fi ---
I can reproduce what you've described - a bit embarassing for a first submit.
I'm sorry for the headache this gives to anyone.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12478] New: Elasticsearch support for Koha

2014-06-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478

Bug ID: 12478
   Summary: Elasticsearch support for Koha
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Searching
  Assignee: gmcha...@gmail.com
  Reporter: ro...@catalyst.net.nz
QA Contact: testo...@bugs.koha-community.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12478] Elasticsearch support for Koha

2014-06-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478

Robin Sheat ro...@catalyst.net.nz changed:

   What|Removed |Added

   Patch complexity|--- |Large patch
  Change sponsored?|--- |Sponsored
   Assignee|gmcha...@gmail.com  |ro...@catalyst.net.nz

--- Comment #1 from Robin Sheat ro...@catalyst.net.nz ---
Information and large patch dumps will go here periodically, so people can see
what's happening.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12478] Elasticsearch support for Koha

2014-06-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478

David Cook dc...@prosentient.com.au changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12478] Elasticsearch support for Koha

2014-06-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478

--- Comment #2 from Robin Sheat ro...@catalyst.net.nz ---
Active development is happening here:

http://git.catalyst.net.nz/gw?p=koha.git;a=shortlog;h=refs/heads/elastic_search

you can add this to your own repo if you like (be aware it'll be periodically
rebased to keep up with master.)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12478] Elasticsearch support for Koha

2014-06-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478

--- Comment #3 from Robin Sheat ro...@catalyst.net.nz ---
Created attachment 29204
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29204action=edit
Bug 12478 - an almagamation of all the Elasticsearch code so far

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12478] Elasticsearch support for Koha

2014-06-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478

--- Comment #4 from Robin Sheat ro...@catalyst.net.nz ---
This won't work straight off, to make it work you need to:
* set the system preference 'SearchEngine' to 'Elasticsearch'
* load installer/data/mysql/elasticsearch_mapping.sql into your database
* add something like:

 elasticsearch
 serveres-server:9200/server
 index_namekoha_instance/index_name
 /elasticsearch

to the config section of koha-conf.xml

Perhaps some other things I forgot.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12478] Elasticsearch support for Koha

2014-06-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478

--- Comment #5 from Robin Sheat ro...@catalyst.net.nz ---
(In reply to Robin Sheat from comment #4)
  elasticsearch
  serveres-server:9200/server

server can be repeated to point to each server in your cluster, too.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12478] Elasticsearch support for Koha

2014-06-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478

--- Comment #6 from Robin Sheat ro...@catalyst.net.nz ---
Perl dependencies are needed to run Catmandu. Packages aimed at Debian Testing
are here:

http://www.kallisti.net.nz/~robin/catmandu-deps.tar.gz

they might work on Wheezy if you're lucky, but they haven't been tested there.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12478] Elasticsearch support for Koha

2014-06-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478

Magnus Enger mag...@enger.priv.no changed:

   What|Removed |Added

 CC||mag...@enger.priv.no

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12479] New: Update mailmap for master

2014-06-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12479

Bug ID: 12479
   Summary: Update mailmap for master
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: trivial
  Priority: P5 - low
 Component: Developer documentation
  Assignee: gmcha...@gmail.com
  Reporter: dc...@prosentient.com.au
QA Contact: testo...@bugs.koha-community.org

Just adding a mailmap entry for myself to fix GitStats so it can merge together
the commits I made as David vs David Cook.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12479] Update mailmap for master

2014-06-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12479

David Cook dc...@prosentient.com.au changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |dc...@prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12479] Update mailmap for master

2014-06-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12479

David Cook dc...@prosentient.com.au changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12479] Update mailmap for master

2014-06-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12479

--- Comment #1 from David Cook dc...@prosentient.com.au ---
Created attachment 29205
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29205action=edit
Bug 12479 - Update mailmap for master

Just wanted to add a mailmap entry so that GitStats merges together
the commits I made as David dc...@prosentient.com.au versus
David Cook dc...@prosentient.com.au.

Also increases accuracy if myself or others does a git shortlog...

_TEST PLAN_

Before applying:

1) Run 'git shortlog --author=dc...@prosentient.com.au'
2) Note two entries: one for David and one for David Cook.

3) Apply patch

4) Repeat step 1
5) Note only one entry for David Cook

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12479] Update mailmap for master

2014-06-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12479

Magnus Enger mag...@enger.priv.no changed:

   What|Removed |Added

  Attachment #29205|0   |1
is obsolete||

--- Comment #2 from Magnus Enger mag...@enger.priv.no ---
Created attachment 29206
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29206action=edit
Bug 12479 - [SIGNED-OFF] Update mailmap for master

Just wanted to add a mailmap entry so that GitStats merges together
the commits I made as David dc...@prosentient.com.au versus
David Cook dc...@prosentient.com.au.

Also increases accuracy if myself or others does a git shortlog...

_TEST PLAN_

Before applying:

1) Run 'git shortlog --author=dc...@prosentient.com.au'
2) Note two entries: one for David and one for David Cook.

3) Apply patch

4) Repeat step 1
5) Note only one entry for David Cook

Signed-off-by: Magnus Enger digitalutvikl...@gmail.com
Works as advertised.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12479] Update mailmap for master

2014-06-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12479

Magnus Enger mag...@enger.priv.no changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12480] New: Encoding problem with New patron -button categories when no patron found

2014-06-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12480

Bug ID: 12480
   Summary: Encoding problem with New patron -button categories
when no patron found
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Patrons
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: pasi.kalli...@pttk.fi
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

Circulation - Check out - Enter a non-existent patron number or name that
cannot be found - The New patron -button shows the patron category names
with faulty UTF8 encoding

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12261] Staff client next/previous links lead to unknown record

2014-06-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12261

--- Comment #14 from Jonathan Druart jonathan.dru...@biblibre.com ---
(In reply to Galen Charlton from comment #12)
 While evaluating this for inclusion in 3.16.x, I ran into an apparent
 regression.
 
 Consider a search that spans multiple pages in the results list.  When I go
 to last hit in the first page, the next link is disabled.  It should instead
 be active and clicking on it should permit traveling to the first hit on the
 second page of results.

Yep, sorry no to catch that before. I have just retested and recreated the
issue.
It seems that the me.searchCookie.total variable is always undefined, maybe a
lead.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12478] Elasticsearch support for Koha

2014-06-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478

Jacek Ablewicz a...@biblos.pk.edu.pl changed:

   What|Removed |Added

 CC||a...@biblos.pk.edu.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10855] Additional fields for subscriptions

2014-06-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Failed QA   |BLOCKED
 Depends on||11944

--- Comment #166 from Jonathan Druart jonathan.dru...@biblibre.com ---
Hello Paola,
Thanks for testing and for your patience, but I don't manage to retest this
development every time I rebase it.
I would prefer to see bug 11944 pushed before continuing here.
I mark this enh blocked by 11944.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11944] Cleanup Koha UTF-8

2014-06-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Blocks||10855

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12261] Staff client next/previous links lead to unknown record

2014-06-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12261

--- Comment #15 from Juhani Seppälä jsep...@student.uef.fi ---
Created attachment 29207
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29207action=edit
Staff client next/previous links lead to unknown record

When using Staff client next/previous links after a search :
If the current record is the last of the results, clicking on next will lead
to the page of an unknown record with message :

The record you requested does not exist (NaN).

To test:
1) Do an intranet catalog search that has more than 1 results.
2) Click on the last search result and then click the Next-button from the
top-left navigation.
3) Confirm that you get thrown to a page with the message: The record you
requested does not exist (NaN)..
4) Apply patch.
5) Do an intranet search with more than 1 but less results than fit on a single
page.
6) Click on the last result on the page and confirm that the Next navigation
button is greyd out.
6) Do an intranet search with multi-page search results.
7) Click on the last result of a page that's not the final page of the results
 confirm that Next is not grey out.
8) Navigate to the last page of the results and click on the final result 
confirm that Next is greyd out.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12479] Update mailmap for master

2014-06-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12479

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12479] Update mailmap for master

2014-06-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12479

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

  Attachment #29206|0   |1
is obsolete||

--- Comment #3 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 29208
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29208action=edit
[PASSED QA] Bug 12479 - [SIGNED-OFF] Update mailmap for master

Just wanted to add a mailmap entry so that GitStats merges together
the commits I made as David dc...@prosentient.com.au versus
David Cook dc...@prosentient.com.au.

Also increases accuracy if myself or others does a git shortlog...

_TEST PLAN_

Before applying:

1) Run 'git shortlog --author=dc...@prosentient.com.au'
2) Note two entries: one for David and one for David Cook.

3) Apply patch

4) Repeat step 1
5) Note only one entry for David Cook

Signed-off-by: Magnus Enger digitalutvikl...@gmail.com
Works as advertised.

Signed-off-by: Katrin Fischer katrin.fischer...@web.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12261] Staff client next/previous links lead to unknown record

2014-06-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12261

--- Comment #16 from Jonathan Druart jonathan.dru...@biblibre.com ---
(In reply to Juhani Seppälä from comment #15)
 Created attachment 29207 [details] [review]

Please reopen a new bug report and link it to this one.

 When using Staff client next/previous links after a search :
 If the current record is the last of the results, clicking on next will
 lead to the page of an unknown record with message :
 
 The record you requested does not exist (NaN).

This commit message is wrong, it is not the behavior on master since the patch
from this bug report is pushed :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12478] Elasticsearch support for Koha

2014-06-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478

Zeno Tajoli z.taj...@cineca.it changed:

   What|Removed |Added

 CC||z.taj...@cineca.it

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12438] Bad encoding in acquisition basket

2014-06-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12438

Paola Rossi paola.ro...@cineca.it changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #4 from Paola Rossi paola.ro...@cineca.it ---
Thanks, Fridolin

I've applied against master 3.17.00.008

Everything's OK.

So I've passed tha patch to Signed Off status.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12438] Bad encoding in acquisition basket

2014-06-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12438

Paola Rossi paola.ro...@cineca.it changed:

   What|Removed |Added

  Attachment #28911|0   |1
is obsolete||

--- Comment #5 from Paola Rossi paola.ro...@cineca.it ---
Created attachment 29209
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29209action=edit
28911: Bug 12438 - Bad encoding in acquisition basket

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12261] Staff client next/previous links lead to unknown record

2014-06-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12261

--- Comment #17 from Juhani Seppälä jsep...@student.uef.fi ---
(In reply to Jonathan Druart from comment #16)
 (In reply to Juhani Seppälä from comment #15)
  Created attachment 29207 [details] [review] [review]
 
 Please reopen a new bug report and link it to this one.
 
  When using Staff client next/previous links after a search :
  If the current record is the last of the results, clicking on next will
  lead to the page of an unknown record with message :
  
  The record you requested does not exist (NaN).
 
 This commit message is wrong, it is not the behavior on master since the
 patch from this bug report is pushed :)

Will open a new one for it - thanks for your patience.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12261] Staff client next/previous links lead to unknown record

2014-06-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12261

Juhani Seppälä jsep...@student.uef.fi changed:

   What|Removed |Added

 Depends on||12481

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12481] New: Staff client detail-view next link is greyed out when the last search result of any results page is clicked or navigated into

2014-06-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12481

Bug ID: 12481
   Summary: Staff client detail-view next link is greyed out
when the last search result of any results page is
clicked or navigated into
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Templates
  Assignee: jsep...@student.uef.fi
  Reporter: jsep...@student.uef.fi
QA Contact: testo...@bugs.koha-community.org
CC: jonathan.dru...@biblibre.com
Blocks: 12261

When doing a staff client catalog search with more than 1 page of results and
clicking the last result on any search result page, the top-left navigation
button for next is greyed out.

The expected behaviour would be to move into the next page of results. The
next navigation should only be prevented when the very last search result is
selected in the detail-view. 

As suggested in the linked bug 12261, this is a regression from my attempt to
fix the issue with the navigation letting the user moving out of bound in
relation to the result array. As suggested in bug 12261, the original cause was
in part due to the total number of results not being carried in the search
cookie. Secondly, the offset value that was being used in the navigation checks
shouldn't be used in there (the checks for allowing movement within the
results) because the cookie value is only updated upon a result click and not
when the user is navigating using the detail-view.

I wrongly submitted a patch to bug 12261 since it was already pushed. The patch
brings the total number of search results available (as I think it was
orignally planned, since the non-existing value was being used) to the
browser.js which handles the navigation and makes use of that.

I marked this as blocking 12261 - not sure if this is right...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11385] C4::SQLHelper should be removed

2014-06-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11385

Yohann Dufour yohann.duf...@biblibre.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||yohann.duf...@biblibre.com
   Assignee|gmcha...@gmail.com  |yohann.duf...@biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6473] Test bug for Git-bz

2014-06-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473

Yohann Dufour yohann.duf...@biblibre.com changed:

   What|Removed |Added

 CC||yohann.duf...@biblibre.com
   Assignee|wizzy...@gmail.com  |yohann.duf...@biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6473] Test bug for Git-bz

2014-06-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473

Yohann Dufour yohann.duf...@biblibre.com changed:

   What|Removed |Added

 CC|yohann.duf...@biblibre.com  |
   Assignee|yohann.duf...@biblibre.com  |wizzy...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11385] C4::SQLHelper should be removed

2014-06-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11385

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 CC||jonathan.dru...@biblibre.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8438] Users should only claim for serials related to their branch.

2014-06-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8438

--- Comment #21 from Jonathan Druart jonathan.dru...@biblibre.com ---
(In reply to Koha Team Lyon 3 from comment #20)
 It's OK now for superlibrarians and users with superserials permissions, but
 it doesn't work any more for simple users : they are not restricted any more
 to the login branch...

Yes sorry, I changed the behavior without notifying the change.
But actually I am not sure. I decided to use the same method as on editing a
subscription, but it's wrong!
I will submit another patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12481] Staff client detail-view next link is greyed out when the last search result of any results page is clicked or navigated into

2014-06-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12481

--- Comment #1 from Juhani Seppälä jsep...@student.uef.fi ---
Created attachment 29210
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29210action=edit
Bug 12481: Staff client detail-view next link is greyed out when the last
search result of any results page is clicked or navigated into

When doing a staff client catalog search with more than 1 page of results
and clicking the last result on any search result page, the top-left navigation
button for next is greyed out.

To test:
1) Do an intranet catalog search that has more than 1 page of results.
2) Click on the last result on a page that is not the last one  confirm that
the navigation button next is greyed out.
4) Apply patch.
5) Do an intranet search with more than 1 but less results than fit on a single
page.
6) Click on the last result on the page and confirm that the Next navigation
button is greyed out.
6) Do an intranet search with more than 1 page of results.
7) Click on the last result of a page that's not the final page of the results
 confirm that Next is not grey out.
8) Navigate to the last page of the results and click on the final result 
confirm that Next is greyd out.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8438] Users should only claim for serials related to their branch.

2014-06-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8438

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8438] Users should only claim for serials related to their branch.

2014-06-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8438

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #29191|0   |1
is obsolete||
  Attachment #29192|0   |1
is obsolete||

--- Comment #22 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 29211
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29211action=edit
Bug 8438: Users can only claim for serials related to their branch.

Only superlibrarian users and users with superserials permission
can override this limitation.

This patch adds a new subroutine C4::Serials::can_claim_subscription.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8438] Users should only claim for serials related to their branch.

2014-06-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8438

--- Comment #24 from Jonathan Druart jonathan.dru...@biblibre.com ---
I didn't test all cases but the unit tests told me that should work! :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8438] Users should only claim for serials related to their branch.

2014-06-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8438

--- Comment #23 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 29212
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29212action=edit
Bug 8438: Followup Set the superserials permission for all users with the
claim_serials permission

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12481] Staff client detail-view next link is greyed out when the last search result of any results page is clicked or navigated into

2014-06-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12481

--- Comment #2 from Jonathan Druart jonathan.dru...@biblibre.com ---
Does this patch needs signoff?
If yes, you missed to change the status :)
And if yes, I will change the status to failed QA, because the patch does not
work if you get more than 1 page of results.
me.curPos is the position of the result on the current page, not the position
on the total number of results.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7143] Bug for tracking changes to the about page

2014-06-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7143] Bug for tracking changes to the about page

2014-06-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

  Attachment #29200|0   |1
is obsolete||

--- Comment #143 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 29213
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29213action=edit
[PASSED QA] Bug 7143: Updating new developers

Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com
No errors

Signed-off-by: Katrin Fischer katrin.fischer...@web.de
Edit: Switched from spaces to tabs in history.txt.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9805] Lost items are un-lost if returned, but not if renewed.

2014-06-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9805

--- Comment #10 from Kyle M Hall k...@bywatersolutions.com ---
*** Bug 8560 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8560] renewing lost items

2014-06-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8560

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 CC||k...@bywatersolutions.com
 Resolution|--- |DUPLICATE

--- Comment #2 from Kyle M Hall k...@bywatersolutions.com ---


*** This bug has been marked as a duplicate of bug 9805 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9805] Lost items are un-lost if returned, but not if renewed.

2014-06-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9805

--- Comment #11 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 29214
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29214action=edit
Bug 9805 [QA Followup] - Add system preference

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9805] Lost items are un-lost if returned, but not if renewed.

2014-06-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9805

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Failed QA   |Passed QA

--- Comment #12 from Kyle M Hall k...@bywatersolutions.com ---
Setting to passed qa on the assumption that the system preference was the only
blocker for this. Adding system preference has not affected the behavior of the
patch. Please set to 'needs signoff' if you feel otherwise.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12481] Staff client detail-view next link is greyed out when the last search result of any results page is clicked or navigated into

2014-06-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12481

--- Comment #3 from Juhani Seppälä jsep...@student.uef.fi ---
(In reply to Jonathan Druart from comment #2)
 Does this patch needs signoff?
 If yes, you missed to change the status :)
 And if yes, I will change the status to failed QA, because the patch does
 not work if you get more than 1 page of results.
 me.curPos is the position of the result on the current page, not the
 position on the total number of results.

You're right, I'm obviously a bit confused with regards to the fundamental
purpose of some of the js I'm looking at. However, think that making the total
results available to the navigation js is a starting point.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12482] New: C4::Budgets : Replacement of subroutine calls of C4::SQLHelper by DBIx::Class

2014-06-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12482

Bug ID: 12482
   Summary: C4::Budgets : Replacement of subroutine calls of
C4::SQLHelper by DBIx::Class
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: gmcha...@gmail.com
  Reporter: yohann.duf...@biblibre.com
QA Contact: testo...@bugs.koha-community.org

The module C4::Budgets.pm depends on module C4::SQLHelper.pm. However, the
module C4::Helper.pm is obsolete, so the calls for InsertInTable, UpdateInTable
and SearchIntable has to be replaced by the use of the module DBIx::Class.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12482] C4::Budgets : Replacement of subroutine calls of C4::SQLHelper by DBIx::Class

2014-06-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12482

Yohann Dufour yohann.duf...@biblibre.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|gmcha...@gmail.com  |yohann.duf...@biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12482] C4::Budgets : Replacement of subroutine calls of C4::SQLHelper by DBIx::Class

2014-06-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12482

Yohann Dufour yohann.duf...@biblibre.com changed:

   What|Removed |Added

 Blocks||11385

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11385] C4::SQLHelper should be removed

2014-06-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11385

Yohann Dufour yohann.duf...@biblibre.com changed:

   What|Removed |Added

 Depends on||12482

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9303] relative's checkouts in the opac

2014-06-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #29172|0   |1
is obsolete||

--- Comment #107 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 29215
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29215action=edit
Bug 9303 [4] [QA Followup]

* Set AUTO_INCREMENT value for issues.issue_id
* Undo changes to GetReserve
* Add borrowerRelationship syspref check
* Syspref the feature for staff
* Show setting on patron details page
* Allow patrons to set visibility from your personal details
* Add system preference to control ability to set visibility from your
personal details
* Show only guarantee's checkouts to guarantor, not visa-versa
* Only show relatives' checkouts if either new system preference is enabled

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item

2014-06-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #50 from Kyle M Hall k...@bywatersolutions.com ---
This bug depends on bug 9303, the patches for that bug must be applied prior to
testing this patch set.

(In reply to Christopher Brannon from comment #49)
 On master when I turn on the AnonymousPatron preference, I can check items
 in.  With patch applied and AnonymousPatron on, I get Error 500 screens on
 check in.  Items won't check in with patch.  This is true checking in from
 moremember.pl or circulation.pl from the list of items checked out, or from
 returns.pl.
 
 Christopher

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10904] would like to limit patron update request management by branch

2014-06-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10904

--- Comment #24 from Kyle M Hall k...@bywatersolutions.com ---
I must respectfully disagree with your assertions. The primary complain I
receive about IndependentBranches is the lack of finer control with the system
preference. It's all or nothing. I see no advantage to the default with a
pulldown you propose. In fact, if a librarian needs the ability to see and
approve changes for multiple libraries, this only slows them down, as he or she
will need to select each library in turn. This if fine for a system with 3
branches, but what about one with 20?

Setting back to passed qa so the current RM can make this call.

 That's not to say that there won't be other occasion for making
 finer-grained visibility distinctions, but this really needs a broader
 discussion.  For one thing, it's currently being done differently in serials
 with the superserials permission, and I am very concerned about the
 prospect of letting a pile of slightly different approaches occur.

If this is a concern, then it should be put in the Koha coding guidelines so
it's no longer a decision that hinges on personal preference of one of more
persons. I can agree with this in general. Koha has extremely varied
implementations of the same generic pattern in many, many areas. This only
further reinforces my point though.

Kyle

(In reply to Galen Charlton from comment #23)
 (In reply to Kyle M Hall from comment #8)
  I think this behavior should be controlled by a new system preference
  IndependentBranchesPatronModifications. I also agree, IndependentBranches
  behaviors need to be broken up into smaller sets in the future. This would
  be a good place to start. Any new modules such as this one that need an
  IndependentBranches behavior should have a separate preference.
 
 I disagree that a new system preference is needed.  I think it is sufficient
 to make this behave like similar interface with regards to library selection:
 
 * If IndependentBranches is on, you see only your libraries' stuff unless
 you're a superlibrarian
 * If IndependentBranches is off, it *defaults* to showing your library, but
 there's a selector available on the form to switch to another library.
 
 In the later case, it can be coupled with notifications on the main page and
 patron home page that look like
 
 Patrons requesting modifications: X at my library, Y in the entire system
 
 That's not to say that there won't be other occasion for making
 finer-grained visibility distinctions, but this really needs a broader
 discussion.  For one thing, it's currently being done differently in serials
 with the superserials permission, and I am very concerned about the
 prospect of letting a pile of slightly different approaches occur.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10904] would like to limit patron update request management by branch

2014-06-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10904

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|In Discussion   |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10594] ability to annotate lists

2014-06-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10594

Nicole C. Engard neng...@gmail.com changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #2 from Nicole C. Engard neng...@gmail.com ---


*** This bug has been marked as a duplicate of bug 813 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 813] OPAC virtual shelves should store comments

2014-06-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=813

Nicole C. Engard neng...@gmail.com changed:

   What|Removed |Added

 CC||neng...@gmail.com

--- Comment #1 from Nicole C. Engard neng...@gmail.com ---
*** Bug 10594 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 813] OPAC virtual shelves should store comments

2014-06-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=813

--- Comment #2 from Nicole C. Engard neng...@gmail.com ---
I got asked for this kind of thing last summer and then again yesterday. Would
be an awesome enhancement even though this is a super-old bug :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12483] New: Add a geo service checker to the patron registration form

2014-06-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12483

Bug ID: 12483
   Summary: Add a geo service checker to the patron registration
form
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Patrons
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: neng...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

I got a cool idea from a library yesterday for the patron self registration
form. Add a geo service checker in so that in addition to the info the patron
enters you get their location for verification purposes.  Of course this would
need a sys pref for those libraries that don't want/can't ask for that info.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11023] Toggle new status for items

2014-06-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #26817|0   |1
is obsolete||

--- Comment #40 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 29216
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29216action=edit
Bug 11023: Toggle new status

This patch adds:
- a new DB field items.new.
- a new page to configure this new status
  (tools/toggle_new_status.pl).
- a new cronjob script (misc/cronjob/toggle_new_status.pl).

Why this status is useful for some libraries ?
The use cases are:
- to know easily what are the new items (with a simple sql query).
- to display an icon in the search results.
- issuing rules can be adapt for new items. Automatically (using the
  cronjob script), the status change (depending the configuration) and
  the item can be issued, for example.
- a RSS/Atom feeds can be created on these new items.

Test plan:
- log in with a librarian having the tools  items_batchmod permission.
- navigate to Home  Tools  Toggle new status
- click on the edit button
- there are 3 blocks:
  * duration: the duration during an item is considered as new.
  * conditions: the status will change only if the conditions are meet.
  * substitutions: if there is no substitution, no action will be done.
You can add some change to apply to the matching items.
E.g. ccode=3
 new=''
If the value is an empty string (in other words, the input does not
contain anything), the field will be deleted.
  You can create as many rules as you want.
- test the interface : add/remove rule, conditions, substitutions,
  submit the form, edit, etc.
  (There is a looot of JS everywhere, so certainly a looot of bugs...).
- when you have your rules defined, you can now launch the cronjob
  script without any parameter.
  A report will be displayed with the matching itemnumber and the
  substitutions to apply. Verify results are consistent.
- launch the script with the -c argument and verify values have been
  modified depending the substitution rules.

Signed-off-by: juliette et rémy juliette.lev...@iepg.fr

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 813] OPAC virtual shelves should store comments

2014-06-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=813

--- Comment #3 from Paul Poulain paul.poul...@biblibre.com ---
I think we all agree that we could add many fields in shelves.
For example : opening date / closing date (non mandatory).

Sponsoring welcomed ;-)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11023] Toggle new status for items

2014-06-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #26818|0   |1
is obsolete||

--- Comment #41 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 29217
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29217action=edit
Bug 11023: Add the ability to specify fields from biblioitems table.

Test plan:
Same as before but try with fields from the biblioitems table.

Signed-off-by: juliette et rémy juliette.lev...@iepg.fr

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11023] Toggle new status for items

2014-06-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #26820|0   |1
is obsolete||

--- Comment #43 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 29219
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29219action=edit
Bug 11023: FIX - condition on biblioitems table does not work

If a rule contains a condition on the biblioitems table, the match won't
work. This patch fixes this issue.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11023] Toggle new status for items

2014-06-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #26819|0   |1
is obsolete||

--- Comment #42 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 29218
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29218action=edit
Bug 11023: Add UT for C4::Items::ToggleNewStatus

Test plan:
prove t/db_dependent/Items/ToggleNewStatus.t

Signed-off-by: juliette et rémy juliette.lev...@iepg.fr

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11023] Toggle new status for items

2014-06-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #26821|0   |1
is obsolete||

--- Comment #44 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 29220
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29220action=edit
Bug 11023: Use DBIx-Class to retrieve column names

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11023] Toggle new status for items

2014-06-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #27810|0   |1
is obsolete||

--- Comment #45 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 29221
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29221action=edit
Bug 11023: Don't use the biblioitems fields for the subtitution

It's dangerous to allow a change on the biblioitems fields with this
feature.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11023] Toggle new status for items

2014-06-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #26855|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11023] Toggle new status for items

2014-06-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023

--- Comment #46 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 29222
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29222action=edit
Bug 11023: DB changes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11023] Toggle new status for items

2014-06-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023

--- Comment #47 from Jonathan Druart jonathan.dru...@biblibre.com ---
I extracted the DB changes in a new patch. I also added the DBIx changes to it.
It fixes a bug: the items.new field was not list in the field list.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11023] Toggle new status for items

2014-06-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023

--- Comment #48 from Jonathan Druart jonathan.dru...@biblibre.com ---
(In reply to Jonathan Druart from comment #46)
 Created attachment 29222 [details] [review]
 Bug 11023: DB changes

Note: I don't know why this change has been generated:
-on_delete = CASCADE,
+on_delete = RESTRICT,

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10904] would like to limit patron update request management by branch

2014-06-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10904

--- Comment #25 from Jonathan Druart jonathan.dru...@biblibre.com ---
(In reply to Galen Charlton from comment #23)
 That's not to say that there won't be other occasion for making
 finer-grained visibility distinctions, but this really needs a broader
 discussion.

(In reply to Kyle M Hall from comment #24)
 Setting back to passed qa so the current RM can make this call.

Kyle, Maybe we should have this discussion during the next dev meeting?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12471] Create patron card batch from from patron list or patron search

2014-06-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12471

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

Version|3.14|master
Summary|Facility needed to create   |Create patron card batch
   |batch from patron list or   |from from patron list or
   |query   |patron search

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10402] Add multiple contacts for vendors

2014-06-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10402] Add multiple contacts for vendors

2014-06-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

  Attachment #24561|0   |1
is obsolete||

--- Comment #58 from Jared Camins-Esakov jcam...@cpbibliography.com ---
Created attachment 29223
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29223action=edit
Bug 10402: Use an object for contacts

In preparation for adding the ability to handle multiple contacts, this
patch moves booksellers' contacts into their own class,
C4::Bookseller::Contact.

To test:
1) Apply patch.
2) Run database update.
3) Edit a bookseller, making sure to add a contact.
4) View the bookseller's information, making sure the contact
   information is there.
5) Run the unit test:
 prove t/db_dependent/Bookseller.t

Signed-off-by: Owen Leonard oleon...@myacpl.org
Signed-off-by: Jared Camins-Esakov jcam...@cpbibliography.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10402] Add multiple contacts for vendors

2014-06-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

  Attachment #24563|0   |1
is obsolete||

--- Comment #60 from Jared Camins-Esakov jcam...@cpbibliography.com ---
Created attachment 29225
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29225action=edit
Bug 10402: Add ability to enter multiple contacts

Some vendors may have more than one contact. For example, a technical
contact and a billing contact, or a contact for journals and a contact
for monographs. Rather than require that each contact be either made
into a separate vendor or recorded somewhere outside of Koha, it would
be really useful of Koha had the ability to add multiple additional
contacts to vendors in the Acquisitions module.

To test:
1) Apply patch.
2) Edit a bookseller, making sure to add a contact.
3) View the bookseller's information, making sure the contact
   information is there.
4) Run the unit test:
 prove t/db_dependent/Bookseller.t
5) Add multiple contacts to a vendor, see that they show up.
6) Delete one contact from a vendor with multiple contacts,
   see that the result is correct.
7) Sign off.

Note: This test plan can supersede that on the previous two patches,
as all functionality of the previous two patches is required by this
one.

Signed-off-by: Owen Leonard oleon...@myacpl.org
Signed-off-by: Jared Camins-Esakov jcam...@cpbibliography.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10402] Add multiple contacts for vendors

2014-06-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

  Attachment #24562|0   |1
is obsolete||

--- Comment #59 from Jared Camins-Esakov jcam...@cpbibliography.com ---
Created attachment 29224
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29224action=edit
Bug 10402: Move contacts to separate table

This patch normalizes the data structures used for bookseller
contacts.

To test:
1) Repeat tests described on previous patch.

Signed-off-by: Owen Leonard oleon...@myacpl.org
Signed-off-by: Jared Camins-Esakov jcam...@cpbibliography.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10402] Add multiple contacts for vendors

2014-06-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

  Attachment #24564|0   |1
is obsolete||

--- Comment #61 from Jared Camins-Esakov jcam...@cpbibliography.com ---
Created attachment 29226
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29226action=edit
Bug 10402 [Template follow-up] Add multiple contacts for vendors

This template-only follow-up tweaks the button labels and restructures
the vendor view layout a little bit to make it more amenable to multiple
contacts:

- Add spaces after button icons
- Change Add contact to Add another contact in hopes of making it
  less ambiguous whether clicking it will submit the whole form.
- Eliminate duplicate headers on the vendor view page by making the
  contact name the subheading for each individual contact.

To test, view details for vendors with one or more contacts, and try
editing to add additional contacts. Everything should look good and work
correctly.

Signed-off-by: Jared Camins-Esakov jcam...@cpbibliography.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10402] Add multiple contacts for vendors

2014-06-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

  Attachment #24565|0   |1
is obsolete||
  Attachment #24566|0   |1
is obsolete||
  Attachment #24567|0   |1
is obsolete||
  Attachment #24568|0   |1
is obsolete||

--- Comment #62 from Jared Camins-Esakov jcam...@cpbibliography.com ---
Created attachment 29227
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29227action=edit
Bug 10402 follow-up: choose contacts for claims

This patch makes it possible to choose a particular contact for
acquisitions and serials claims. To test:

1) Select a contact to use for claiming late orders and a contact
   to use for claiming late issues.
2) Send a claim for a late order and a claim for a late issue.
3) Note that the claims went out to the proper people.
4) Run the unit test with:
 prove t/db_dependent/Letters.t
5) Sign off.

Note: the claim messages are recorded in the logs in the *Acquisitions*
module, not the Letters module as you might expect

This patch also fixes several perlcritic violations and centralizes
contact-related unit testing in Bookseller.t.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item

2014-06-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011

--- Comment #51 from Nick Clemens n...@quecheelibrary.org ---
After applying both patches and updating the database the feature seems to work
as expected, however, when I log in to any patron account on the opac and click
the 'immediate deletion' button under 'your privacy' I get the error:
The deletion of your reading history failed, because there is a problem with
the configuration of this feature. Please help to fix the system by informing
your library of this error.

I double checked my system settings without the patches and immediate deletion
works.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11872] Lost overdue items should not generate fines

2014-06-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11872

--- Comment #5 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 29228
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29228action=edit
Bug 11872 [QA Followup] - Unit Tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11872] Lost overdue items should not generate fines

2014-06-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11872

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12220] bootstrap not responsive on all devices

2014-06-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12220

Aaron Sakovich asakov...@hmcpl.org changed:

   What|Removed |Added

 CC||asakov...@hmcpl.org

--- Comment #3 from Aaron Sakovich asakov...@hmcpl.org ---
FYI, I wrote the original comment Nicole quoted above in a query to her.

Viktor, in retrospect, I don't think the problem is so much iPads, as it is
phones. If the responsive design has flipped into phone mode, then I know some
designers want to prevent zooming. Unfortunately, this meta-tag doesn't
discriminate between a narrow-screened phone-mode and a wide-screened
iPad-mode.

Perhaps a 'maximum-scale=2' or '...=4' would be more appropriate than saying
Nein! Ist verboten!!? Or is there another way to programmatically determine
if the responsive display is in a narrow-screen phone-mode and then enforce the
restriction, leaving the larger-screen iPads unimpeded?

(I've always been averse to having a server tell users what they can't do on
their device's UI, so we were dismayed when we discovered we couldn't
pinch-to-zoom on iPads. Personally, I'd remove it completely if it were left to
me -- which I know it's not. Fortunately.)

Open to suggestions!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12220] bootstrap not responsive on all devices

2014-06-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12220

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12220] bootstrap not responsive on all devices

2014-06-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12220

--- Comment #4 from Owen Leonard oleon...@myacpl.org ---
Created attachment 29229
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29229action=edit
Bug 12220 - bootstrap not responsive on all devices

The bootstrap theme includes a meta tag attribute which disables zooming
on some devices. This was unintentional and not desirable. This patch
removes the problematic attribute.

See:
http://blog.javierusobiaga.com/stop-using-the-viewport-tag-until-you-know-ho

To test: Apply the patch and view the OPAC on a device with a touch
interface. Attempt to zoom in on any OPAC page. Zooming should work.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12220] bootstrap not responsive on all devices

2014-06-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12220

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
Version|3.14|master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6427] Rewrite of the accounts system

2014-06-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #389 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 29231
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29231action=edit
Bug 6427 [Part 2] - Add new accounts related modules

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6427] Rewrite of the accounts system

2014-06-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #28795|0   |1
is obsolete||
  Attachment #28796|0   |1
is obsolete||
  Attachment #28797|0   |1
is obsolete||
  Attachment #28798|0   |1
is obsolete||
  Attachment #28799|0   |1
is obsolete||
  Attachment #28800|0   |1
is obsolete||
  Attachment #28801|0   |1
is obsolete||
  Attachment #28802|0   |1
is obsolete||
  Attachment #28803|0   |1
is obsolete||
  Attachment #28804|0   |1
is obsolete||
  Attachment #28805|0   |1
is obsolete||
  Attachment #28806|0   |1
is obsolete||
  Attachment #28807|0   |1
is obsolete||
  Attachment #28808|0   |1
is obsolete||
  Attachment #28809|0   |1
is obsolete||
  Attachment #28810|0   |1
is obsolete||
  Attachment #28811|0   |1
is obsolete||
  Attachment #28812|0   |1
is obsolete||
  Attachment #28813|0   |1
is obsolete||
  Attachment #28814|0   |1
is obsolete||
  Attachment #28815|0   |1
is obsolete||
  Attachment #28816|0   |1
is obsolete||
  Attachment #28817|0   |1
is obsolete||
  Attachment #28818|0   |1
is obsolete||
  Attachment #28819|0   |1
is obsolete||
  Attachment #28820|0   |1
is obsolete||
  Attachment #28821|0   |1
is obsolete||
  Attachment #28822|0   |1
is obsolete||
  Attachment #28887|0   |1
is obsolete||
  Attachment #2|0   |1
is obsolete||
  Attachment #28889|0   |1
is obsolete||
  Attachment #28890|0   |1
is obsolete||
  Attachment #28909|0   |1
is obsolete||
  Attachment #29176|0   |1
is obsolete||

--- Comment #388 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 29230
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29230action=edit
Bug 6427 [Part 1] - Update schema files

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6427] Rewrite of the accounts system

2014-06-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #391 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 29233
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29233action=edit
Bug 6427 [Part 4] - Add new staff-side scripts for viewing/creating fees and
payments

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6427] Rewrite of the accounts system

2014-06-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #390 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 29232
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29232action=edit
Bug 6427 [Part 3] - Add new TT plugin to deal with currency

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6427] Rewrite of the accounts system

2014-06-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #394 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 29236
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29236action=edit
Bug 6427 [Part 7] - Update cron scripts

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6427] Rewrite of the accounts system

2014-06-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #393 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 29235
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29235action=edit
Bug 6427 [Part 6] - Make existing scripts point to the new accounting scripts

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6427] Rewrite of the accounts system

2014-06-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #392 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 29234
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29234action=edit
Bug 6427 [Part 5] - Implement new accounting system in the opac

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6427] Rewrite of the accounts system

2014-06-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #395 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 29237
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29237action=edit
Bug 6427 [Part 8] - Update existing intranet scripts

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6427] Rewrite of the accounts system

2014-06-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #396 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 29238
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29238action=edit
Bug 6427 [Part 9] - Update existing perl modules to support new accounting
system

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6427] Rewrite of the accounts system

2014-06-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #397 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 29239
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29239action=edit
Bug 6427 [Part 10] - Update reports wizard

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6427] Rewrite of the accounts system

2014-06-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #398 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 29240
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29240action=edit
Bug 6427 [Part 11] - Add new utility functions

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6427] Rewrite of the accounts system

2014-06-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #399 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 29241
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29241action=edit
Bug 6427 [Part 12] - Add and update unit tests

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6427] Rewrite of the accounts system

2014-06-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

--- Comment #400 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 29242
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29242action=edit
Bug 6427 [Part 13] - Add database updates

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >