[Koha-bugs] [Bug 12164] Rollover outstanding orders not yet received
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12164 --- Comment #28 from Katrin Fischer --- Hi Jonathan, I am still testing this, so far no bigger problems found. Some small issues and a question: 1) Some small typos found during code review: +There is no unreceived orders for this budget. There are no unreceived oreders for this budget. + Move unreceived orders +Informations Information, Details +There was no unreceived orders for this fund. There were no... 2) The report shown after moving funds shows the amounts with quite a ot of zeros :) 99 200.00 3) Question: If you decide to roll over the funds with the orders into the next year - should the funds be removed from last year's budget? I am not sure about this, so it's really a question to libraries I think. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12481] Staff client detail-view "next" link is greyed out when the last search result of any results page is clicked or navigated into
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12481
--- Comment #9 from Juhani Seppälä ---
(In reply to Marc Véron from comment #8)
> I suppose that the first patch is obsolete? Seems to be the same code.
>
> I applied the second patch, did a search wit a couple of pages as result,
> went to the first detail from one of the result pages and clicked "Next"
> until the end of this page. Then it seems that I am "trapped" on this result
> page, after the last entry the first entry of the same result page is
> displayed (should be the first entry of the next page).
This is not the only interesting behaviour I've come across with the
navigation. There's another issue where the results of the page get
concatenated infinitely on page reload, which originally led me to believe the
results-array in the cookie was the whole results set. These should probably be
reported separately? The behaviour you're describing should be unrelated to my
patch and I've come across it before doing any changes. Can't be 100%,
obviously.
Related js (which I have not touched):
var browseRecords = function (movement) {
var newSearchPos = me.curPos + movement;
if (newSearchPos > me.searchCookie.results.length - 1) {
window.location = '/cgi-bin/koha/catalogue/search.pl?' +
decodeURIComponent(me.searchCookie.query) + '&limit=' +
decodeURIComponent(me.searchCookie.limit) + '&sort=' + me.searchCookie.sort +
'&gotoPage=detail.pl&gotoNumber=first&searchid=' + me.searchid + '&offset=' +
newSearchPos;
} else if (newSearchPos < 0) {
window.location = '/cgi-bin/koha/catalogue/search.pl?' +
decodeURIComponent(me.searchCookie.query) + '&limit=' +
decodeURIComponent(me.searchCookie.limit) + '&sort=' + me.searchCookie.sort +
'&gotoPage=detail.pl&gotoNumber=last&searchid=' + me.searchid + '&offset=' +
(me.offset - me.searchCookie.pagelen);
} else {
window.location = window.location.href.replace('biblionumber=' +
biblionumber, 'biblionumber=' + me.searchCookie.results[newSearchPos]);
}
}
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11213] GetItemsInfo() called twice
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 --- Comment #34 from M. Tompsett --- I'd start at comment 25. :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4137] OPACViewOthersSuggestions does not work
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4137 Bob Birchall changed: What|Removed |Added CC||b...@calyx.net.au --- Comment #4 from Bob Birchall --- I have just tested this (against 3.14.6) in the context of annonymous suggestions. The functionality appears correct, that is, when the sys pref is set to 'Show' and the Purchase Suggestion link on the opac is clicked, existing suggestions are displayed, when it is set to 'Don't show' they don't. So all good. I have not tested as a logged in user. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11213] GetItemsInfo() called twice
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213 --- Comment #33 from Srdjan Jankovic --- (In reply to Bernardo Gonzalez Kriegel from comment #32) > First two are signed. > Test plan for the remaining? I'm sorry, I totally lost account for this fix. Which one is missing tests please? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12464] Bootstrap XSLT view no longer displaying 505 correctly formatted
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12464 Chris Cormack changed: What|Removed |Added Status|Passed QA |Pushed by Module Maintainer CC||ch...@bigballofwax.co.nz --- Comment #6 from Chris Cormack --- Pushed to MM-OPAC/12464 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12473] Overdue notices listing wrong items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12473 Katrin Fischer changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7441] search results showing wrong branch?
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 Katrin Fischer changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #68 from Katrin Fischer --- Hi Nicole, we already have some features that work only with the XSLT view, so I think this probably should not block the feature. But I am not sure if my tests showed a problem in the non-XSLT views that was caused by the patches. I think we need to retest. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999
Nick Clemens changed:
What|Removed |Added
CC||n...@quecheelibrary.org
--- Comment #6 from Nick Clemens ---
Pardon if I am confused, but CanBooksBeReserved can return three different
reasons [alreadyreserved, maxreseres, noholdableitems]
But the check in request.pl checks for alreadyreserved and assumes maxreserves
otherwise
my $alreadyreserved = 0;
190$maxreserves = 1;
191my ($can_book_be_reserved, $reasons) =
192 CanBookBeReserved( $borrowerinfo->{borrowernumber}, $biblionumber
);
193
194unless ($can_book_be_reserved) {
195if ($reasons->{alreadyreserved}) {
196$alreadyreserved = 1;
197$biblioloopiter{warn} = 1;
198$biblioloopiter{alreadyres} = 1;
199} else {
200$maxreserves = 1;
201}
This seems to be the same issue as Bug 10912
To my mind, maxreserves shouldn't be flagged unless the patron is over their
number of reserves.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11548] notice when card about to expire
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11548 Katrin Fischer changed: What|Removed |Added Status|NEW |RESOLVED CC||katrin.fisc...@bsz-bw.de Resolution|--- |DUPLICATE --- Comment #2 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 6810 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12496] Notify patrons by email before their account expires
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12496 Katrin Fischer changed: What|Removed |Added Status|NEW |RESOLVED CC||katrin.fisc...@bsz-bw.de Resolution|--- |DUPLICATE --- Comment #1 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 6810 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6810] Send membership expiry reminder notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 Katrin Fischer changed: What|Removed |Added CC||yha...@yhager.com --- Comment #18 from Katrin Fischer --- *** Bug 12496 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6810] Send membership expiry reminder notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 --- Comment #17 from Katrin Fischer --- *** Bug 11548 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10912] Streamline hold error messages in staff interface
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10912
--- Comment #8 from Nick Clemens ---
I suspect the error we are seeing is from this check in request.pl:
unless ( CanBookBeReserved($borrowerinfo->{borrowernumber}, $biblionumber)
) {
$maxreserves = 1;
}
It isn't checking against maxreserves or the number of reserves a patron has,
just setting the maxreserves error flag when none of the items can be held.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11916] Borrower Imports Refactor/Rewrite
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11916 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
