[Koha-bugs] [Bug 12164] Rollover outstanding orders not yet received

2014-07-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12164

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #29355|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12164] Rollover outstanding orders not yet received

2014-07-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12164

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #28707|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12164] Rollover outstanding orders not yet received

2014-07-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12164

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #28708|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12164] Rollover outstanding orders not yet received

2014-07-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12164

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #29356|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12164] Rollover outstanding orders not yet received

2014-07-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12164

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #28703|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12164] Rollover outstanding orders not yet received

2014-07-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12164

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #28702|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12164] Rollover outstanding orders not yet received

2014-07-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12164

--- Comment #43 from Katrin Fischer  ---
Nice new feature!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12443] Initial re-factoring of buildQuery

2014-07-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12443

--- Comment #14 from David Cook  ---
More thoughts on  C4::Search::buildQuery and Koha::QueryParser...


C4::Search::buildQuery:

PRO: Right/left/right&&left truncation, QueryFuzzy appears to work,
QueryWeightFields works (except when QueryAutoTruncate is on), QueryStemming
works with wordlists.

CON: No support for phrases, lots of ugly spaghetti code which is mutually
exclusive, incorrectly defines variables, etc.

FUTURE:
Planning to integrate "QueryWeightFields", "QueryFuzzy", "QueryAutoTruncate",
and "QueryStemming" into _build_initial_query().
"QueryWeightFields" and "QueryFuzzy" could be improved.

"QueryStemming" is a tough one...as it really is only useful for Word
Lists...so we'll have to check the structure and make sure there are no
quotation marks sneaking in as they'll cause problems. That should work all
right.

--


Koha::QueryParser:

PRO: Automatically detects phrases, automatically detects right truncation.

"Koha::QueryParser::Driver::PQF::query_plan::node" already uses
"QueryAutoTruncate", some "QueryWeightFields"-like functionality (which needs a
more configuration and possibly some code tweaks).

CON: No left truncation, no left && right truncation, no easy way to designate
a phrase (except by wrapping in quotes or by providing an alias)

FUTURE: "Koha::QueryParser::Driver::PQF::query_plan::node" could make it easy
to add "QueryStemming" and "QueryFuzzy". We could also add support for left
truncation and left && right truncation using that same module. 

Improve relevance bumps (aka QueryWeightFields functionality) in
queryparser.yaml.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12499] The module C4::Letters.t needs more unit tests

2014-07-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12499

Yohann Dufour  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12499] The module C4::Letters.t needs more unit tests

2014-07-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12499

--- Comment #1 from Yohann Dufour  ---
Created attachment 29431
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29431&action=edit
Bug 12499: adding units tests for C4::Letters

The tests for the subroutines : GetMessageTransportType, EnqueueLetter,
SendQueuedMessages, GetQueuedMessages, GetLetters, getletter, addalert,
getalert, delalert and GetPreparedLetter of the module C4::Letters have been
added.

Test plan:
1) Apply the patch
2) Execute the unit tests by launching :
prove t/db_dependent/Letters.t
3) The result has to be a success without error or warning :
t/db_dependent/Letters.t .. ok
All tests successful.
Files=1, Tests=45,  2 wallclock secs ( 0.04 usr  0.01 sys +  1.44 cusr  0.08
csys =  1.57 CPU)
Result: PASS

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7518] searches with quotation marks don't work

2014-07-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7518

--- Comment #44 from Fridolin SOMERS  ---
All this needs to be considered in the QueryParser.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12516] New: The module C4::Tags needs more unit tests

2014-07-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12516

Bug ID: 12516
   Summary: The module C4::Tags needs more unit tests
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Test Suite
  Assignee: ch...@bigballofwax.co.nz
  Reporter: yohann.duf...@biblibre.com
QA Contact: gmcha...@gmail.com

Some subroutines of the module C4::Tags are not tested.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12516] The module C4::Tags needs more unit tests

2014-07-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12516

Yohann Dufour  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|ch...@bigballofwax.co.nz|yohann.duf...@biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable

2014-07-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Needs Signoff

--- Comment #147 from Jonathan Druart  ---
Last 2 patches need a signoff, I'm changing the status according that.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable

2014-07-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable

2014-07-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #29419|0   |1
is obsolete||
  Attachment #29420|0   |1
is obsolete||

--- Comment #148 from Katrin Fischer  ---
Created attachment 29432
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29432&action=edit
[SIGNED OFF] Bug 11703 [QA Followup] - Stop IE from caching ajax request

Signed-off-by: Britta Cramer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable

2014-07-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703

--- Comment #149 from Katrin Fischer  ---
Created attachment 29433
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29433&action=edit
[SIGNED OFF] Bug 11703 [QA Followup] - Allow keyboard navigation of tabs

Signed-off-by: Britta Cramer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11677] Limit to Only items currently available for loan or reference not working!

2014-07-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11677

Barton Chittenden  changed:

   What|Removed |Added

 CC||bar...@bywatersolutions.com

--- Comment #3 from Barton Chittenden  ---
I have replicated this issue at a partner's library, in this case the full
search showed both books and audio disks available. When the 'limit to
available' facet is selected, only available audio books are returned by the
search.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11677] Limit to Only items currently available for loan or reference not working!

2014-07-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11677

--- Comment #4 from Barton Chittenden  ---
Examples from OPAC:

Search for "Alex+Rider+Horowitz" shows records of type "book" and "sound", both
available and un-available.

http://catalog.losgatosca.gov/cgi-bin/koha/opac-search.pl?q=Alex+Rider+Horowitz

Clicking "Limit to currently available items."

Shows only available items of type "sound".

http://catalog.losgatosca.gov/cgi-bin/koha/opac-search.pl?idx=kw&q=Alex%20Rider%20Horowitz&sort_by=relevance_dsc&limit=available

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable

2014-07-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703

--- Comment #150 from Kyle M Hall  ---
Created attachment 29434
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29434&action=edit
Bug 11703 [QA Followup] - Change "No data available in table" to "Loading..."

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable

2014-07-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703

--- Comment #151 from Kyle M Hall  ---
(In reply to Christopher Brannon from comment #146)
> When the checkout tab is being loaded, the table reads: "No data available
> in table"
> 
> When the holds tab is being loaded, it reads: "Loading..."
> 
> I like the "Loading...".  Could you do that for any other tables?

I have added a followup for this.

> Also, I notice that printing a slip prints current, up-to-date information,
> despite what the table might be currently showing (i.e. someone checked in
> an item from the book drop in the back room).  Do you think this might lead
> to confusion?  I'm wondering if the tables should be updated if information
> is being printed, for more consistency.  Just a thought.

This is no less in issue with Koha currently than it is with these patches.
This is definitely outside the scope of this bug.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12505] Variable aqorders.listprice from 'Tools' - 'Notices and Slips' Does not work

2014-07-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12505

simith.dolive...@inlibro.com changed:

   What|Removed |Added

 CC||simith.dolive...@inlibro.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12468] copyright symbol not translating right

2014-07-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12468

--- Comment #4 from Owen Leonard  ---
(In reply to Nicole C. Engard from comment #2)
> For testing you can use ISBN: 9781451695182

That ISBN will return a variety of records depending on the Z39.50 source.

I've run into what looks like the same issue though. I'm seeing stuff like this
in some MARC records we get from OCLC:

=264  \4$c�2001

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12505] Variable aqorders.listprice from 'Tools' - 'Notices and Slips' Does not work

2014-07-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12505

simith.dolive...@inlibro.com changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #2 from simith.dolive...@inlibro.com ---
*** Bug 10618 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10618] Acq claim email not formatting correctly and missing information

2014-07-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10618

simith.dolive...@inlibro.com changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 CC||simith.dolive...@inlibro.co
   ||m
 Resolution|--- |DUPLICATE

--- Comment #3 from simith.dolive...@inlibro.com ---


*** This bug has been marked as a duplicate of bug 12505 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10912] Streamline hold error messages in staff interface

2014-07-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10912

Kyle M Hall  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

--- Comment #9 from Kyle M Hall  ---
The issue is that the extra message is incorrect! However, I think maybe my
first patch was too aggressive. I'm going to file a new patch that only affects
the "Too many holds" and "No items are available" sections.

(In reply to Katrin Fischer from comment #7)
> I am not sure about this patch - if there are multiple reasons why a hold is
> not possible, should we not display all of them instead of giving one reason
> preference of another? It seems like this patch will make the error message
> less accurate (elsif instead of if)?
> 
> +[% ELSIF ( maxreserves ) %]
> +  Too many holds:   href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% borrowernumber
> %]">[% borrowerfirstname %] [% borrowersurname %]  has too many
> holds.
> +[% ELSIF ( alreadyreserved ) %]
> +   href="/cgi-bin/koha/members/moremember.pl?borrowernumber=[% borrowernumber
> %]">[% borrowerfirstname %] [% borrowersurname %] already has a
> hold on this item 
> +[% ELSIF ( alreadypossession ) %]

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10912] Streamline hold error messages in staff interface

2014-07-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10912

Kyle M Hall  changed:

   What|Removed |Added

 Status|Signed Off  |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10912] Streamline hold error messages in staff interface

2014-07-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10912

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #29342|0   |1
is obsolete||

--- Comment #10 from Kyle M Hall  ---
Created attachment 29435
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29435&action=edit
Bug 10912 - Streamline hold error messages in staff interface

Right now, if a patron cannot place a hold on any items on a record, the
error in the staff intranet looks like this:

Cannot place hold
Too Many Holds: Kyle Hall has too many holds.
No copies are available to be placed on hold

This can confuse some librarians, because the reason the patron cannot
place the hold is not because the patron has too many holds, but only
because there are no copies available.

Test Plan:
1) Apply this patch
2) Set the number of holds allowed to 1
3) Disable AllowOnShelfHolds
4) Place a hold for a patron
5) Attempt to place a second hold for the patron
6) You should see the "Too many holds" message
7) Set the number of holds allowed to 2
8) Repeat 5, you should be allowed to place the hold, but don't
9) Attempt to place a hold on a record with only checked in items
10) You should get a "No items are available" message

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12517] New: Download and send list popups broken in bootstrap OPAC

2014-07-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12517

Bug ID: 12517
   Summary: Download and send list popups broken in bootstrap OPAC
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: major
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org

In the bootstrap OPAC the download list and send list links do not trigger the
correct popups because of a JavaScript error.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10912] Streamline hold error messages in staff interface

2014-07-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10912

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #29435|0   |1
is obsolete||

--- Comment #11 from Kyle M Hall  ---
Created attachment 29436
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29436&action=edit
Bug 10912 - Streamline hold error messages in staff interface

Right now, if a patron cannot place a hold on any items on a record, the
error in the staff intranet looks like this:

Cannot place hold
Too Many Holds: Kyle Hall has too many holds.
No copies are available to be placed on hold

This can confuse some librarians, because the reason the patron cannot
place the hold is not because the patron has too many holds, but only
because there are no copies available.

Test Plan:
1) Apply this patch
2) Set the number of holds allowed to 1
3) Disable AllowOnShelfHolds
4) Place a hold for a patron
5) Attempt to place a second hold for the patron
6) You should see the "Too many holds" message
7) Set the number of holds allowed to 2
8) Repeat 5, you should be allowed to place the hold, but don't
9) Attempt to place a hold on a record with only checked in items
10) You should get a "No items are available" message

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12517] Download and send list popups broken in bootstrap OPAC

2014-07-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12517

Owen Leonard  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12517] Download and send list popups broken in bootstrap OPAC

2014-07-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12517

--- Comment #1 from Owen Leonard  ---
Created attachment 29437
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29437&action=edit
Bug 12517 - Download and send list popups broken in bootstrap OPAC

A JavaScript error prevents the download list and send list links in the
bootstrap OPAC from functioning correctly. A variable declaration was
removed from basket.js during the creation of the theme but
opac-shelves.tt was not changed accordingly. This patch corrects it.

To test, view an existing shelf in the bootstrap OPAC and test the
"download list" and "send list" links. They should each trigger popups
without any errors.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12489] Ajax checkout table: no "loading..." popup

2014-07-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12489

--- Comment #1 from Jonathan Druart  ---
Actually it's not "Loading..." but "Processing...".

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable

2014-07-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable

2014-07-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703

--- Comment #152 from Jonathan Druart  ---
Created attachment 29438
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29438&action=edit
Bug 11703 [QA Followup] - Stop IE from caching ajax request

Signed-off-by: Britta Cramer 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable

2014-07-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703

--- Comment #153 from Jonathan Druart  ---
Created attachment 29439
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29439&action=edit
Bug 11703 [QA Followup] - Allow keyboard navigation of tabs

Signed-off-by: Britta Cramer 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable

2014-07-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #29434|0   |1
is obsolete||

--- Comment #154 from Jonathan Druart  ---
Created attachment 29440
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29440&action=edit
Bug 11703 [QA Followup] - Change "No data available in table" to "Loading..."

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable

2014-07-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703

--- Comment #155 from Jonathan Druart  ---
I did not found any regression with the 3 last patches (using FF).
I don't have any IE versions to test if they fix the described issues.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12518] New: gather_print_notices.pl doesn't respect hold/reserve pickup location

2014-07-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12518

Bug ID: 12518
   Summary: gather_print_notices.pl doesn't respect hold/reserve
pickup location
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Notices
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: olli-antti.kivila...@jns.fi
QA Contact: testo...@bugs.koha-community.org

Created attachment 29441
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29441&action=edit
Initial commit from our issue tracker.

gather_print_notices.pl gathers HOLD-letters based on the borrowers'
homebranch.
Our librarians find it hard to send hold notices for Items present in other
branches.

This patch gathers print notices for HOLD-letter_code to the Items'
reserves.branchcode (pickup location) instead.

This is achieved by using a customizable regexp in the
gather_print_notices-script, which picks the barcode from the letter content.

---
-- TEST PLAN --
---
0. Have a HOLD-letter template with each Items' barcodes somewhere, for ex.
Barcode: <>
1. Create a reservation for a borrower with no other message delivery option
than printing. Set the pickup location to other (branch P) than the borrowers
homebranch (branch H).
2. Check the item in and confirm reservation. This enques a letter in the
message_queue-table.
3. run the gather_print_notices.pl -cronjobs with the following parameters
gather_print_notices.pl  --split --holdbarcode
'Barcode: (\S+)'
You will find the letter generated to the branch P, instead of the branch H if
you hadn't used the --holdbarcode -parameter.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9811] Patrons search improvements

2014-07-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811

--- Comment #134 from Kyle M Hall  ---
Created attachment 29442
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29442&action=edit
Bug 9811 [QA Followup] - Enable bProcessing

It's a bit disconcerting to not have any feedback while paging
through the patrons. Enabling bProcessing helps resolve that.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12517] Download and send list popups broken in bootstrap OPAC

2014-07-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12517

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

  Attachment #29437|0   |1
is obsolete||

--- Comment #2 from Bernardo Gonzalez Kriegel  ---
Created attachment 29443
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29443&action=edit
[SIGNED-OFF] Bug 12517 - Download and send list popups broken in bootstrap OPAC

A JavaScript error prevents the download list and send list links in the
bootstrap OPAC from functioning correctly. A variable declaration was
removed from basket.js during the creation of the theme but
opac-shelves.tt was not changed accordingly. This patch corrects it.

To test, view an existing shelf in the bootstrap OPAC and test the
"download list" and "send list" links. They should each trigger popups
without any errors.

Signed-off-by: Bernardo Gonzalez Kriegel 
Popups pops again, no koha-qa errors

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12517] Download and send list popups broken in bootstrap OPAC

2014-07-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12517

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||bgkrie...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable

2014-07-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703

sandbo...@biblibre.com  changed:

   What|Removed |Added

 Status|Passed QA   |Signed Off
 CC||sandbo...@biblibre.com

--- Comment #156 from sandbo...@biblibre.com  ---
Patch tested with a sandbox, by Christopher Brannon 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable

2014-07-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703

sandbo...@biblibre.com  changed:

   What|Removed |Added

  Attachment #29279|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable

2014-07-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703

sandbo...@biblibre.com  changed:

   What|Removed |Added

  Attachment #29280|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable

2014-07-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703

sandbo...@biblibre.com  changed:

   What|Removed |Added

  Attachment #29281|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable

2014-07-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703

sandbo...@biblibre.com  changed:

   What|Removed |Added

  Attachment #29282|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable

2014-07-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703

sandbo...@biblibre.com  changed:

   What|Removed |Added

  Attachment #29283|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable

2014-07-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703

sandbo...@biblibre.com  changed:

   What|Removed |Added

  Attachment #29284|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable

2014-07-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703

sandbo...@biblibre.com  changed:

   What|Removed |Added

  Attachment #29438|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable

2014-07-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703

sandbo...@biblibre.com  changed:

   What|Removed |Added

  Attachment #29432|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable

2014-07-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703

sandbo...@biblibre.com  changed:

   What|Removed |Added

  Attachment #29433|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable

2014-07-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703

sandbo...@biblibre.com  changed:

   What|Removed |Added

  Attachment #29439|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable

2014-07-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703

sandbo...@biblibre.com  changed:

   What|Removed |Added

  Attachment #29440|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable

2014-07-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703

--- Comment #158 from sandbo...@biblibre.com  ---
Created attachment 29445
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29445&action=edit
Bug 11810: (followup) regenerate CSS due to conflict

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: Christopher Brannon 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable

2014-07-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703

--- Comment #157 from sandbo...@biblibre.com  ---
Created attachment 29444
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29444&action=edit
Bug 11810: Input fields in OPAC suggestion form are a bit short (Bootstrap)

The default Bootstrap input size (absent any specific input size or
class) is too short for the suggestion form. This patch adds a Bootstrap
class to fields which need more room and adjusts the OPAC CSS to allow
for better handling of input width at lower screen widths.

To test apply the patch and clear your browser cache if necessary. Open
the "new suggestion" form in the OPAC and confirm that the entry fields
for title, author, publisher, and collection title are sized well.

Adjust the width of your browser window up and down to confirm that the
field sizes adjust well at various screen widths.

Followed test plan. Works as expected.
Signed-off-by: Marc Véron 

Signed-off-by: Katrin Fischer 
Works nicely, no problems found.

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: Christopher Brannon 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable

2014-07-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703

--- Comment #163 from sandbo...@biblibre.com  ---
Created attachment 29450
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29450&action=edit
Bug 11703 [QA Followup] - Restore showing earliest renewal date for 'too early'
renewals

Signed-off-by: Jonathan Druart 

Signed-off-by: Christopher Brannon 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable

2014-07-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703

--- Comment #164 from sandbo...@biblibre.com  ---
Created attachment 29451
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29451&action=edit
Bug 11703: (qa-followup) fix update database entry

Signed-off-by: Jonathan Druart 

Signed-off-by: Christopher Brannon 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable

2014-07-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703

--- Comment #162 from sandbo...@biblibre.com  ---
Created attachment 29449
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29449&action=edit
Bug 11703 [QA Followup] - Use interface instead of themelang for checkboxes
plugin

Signed-off-by: Jonathan Druart 

Signed-off-by: Christopher Brannon 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable

2014-07-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703

--- Comment #159 from sandbo...@biblibre.com  ---
Created attachment 29446
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29446&action=edit
Bug 11703 - Convert checkouts table to ajax datatable

When a patron has many checked out items, circulation.pl can take a very
long time to load ( on the order of minutes in some cases ). This is
primarily due to the processing of the previous checkouts list. If we
convert to this table to a datatable that fetches its data via ajax, we
can make circulation.pl far more responsive. The same should be done
with relative's checkouts as well.

Test Plan:
1) Apply this patch
2) Observe that the checkouts and relatives' checkouts tables
   are now loaded asynchronously
3) Observe and verify the renew and return actions are now
   ajax based and function in a manner equivilent to how they
   used to.

This bug had quite a few followups, so I squashed all of them into one
change so that code is easier to follow. Original commit messages are below:

Bug 11703 - Use the ajax datatables on patron details page

Bug 11703 - Convert holds tables to ajax datatables

Bug 11703 [QA Followup 1] - Center bProcessing message over table

Bug 11703 [QA Followup 2] - Remove icons from checkout and clear buttons

Bug 11703 [QA Followup 3] - Remove references to UseTablesortForCirc

Bug 11703 [QA Followup 4] - Add back in Today's checkouts/Previous checkouts
rows

Bug 11703 [QA Followup 5]

Bug 11703 [QA Followup 6] - Move strings to an include file for translation
purposes

Bug 11703 [QA Followup 7] - Fix issues spotted by koha-qa.pl

Bug 11703 [QA Followup 8] - Speed up api/checkouts.pl as much as possible

Bug 11703 [QA Followup 9] - Move scripts from api directory to svc directory

Bug 11703 [QA Followup 10] - Fix errors caused by rebase

Bug 11703 [QA Followup 11] - Prevent multiple fetchs from ajax source

Bug 11703 [QA Followup 12] - Fix problem detected by koha-qa.pl

Bug 11703 [QA Followup 13] - Removed uneccessary data from renewal box during
renewal

Bug 11703 [QA Followup 14] - Fix table column span

Signed-off-by: Dobrica Pavlinusic 
Signed-off-by: Katrin Fischer 
Passes all tests and QA script.
Test plan on bug report:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703#c98

Signed-off-by: Jonathan Druart 

Signed-off-by: Christopher Brannon 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable

2014-07-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703

--- Comment #165 from sandbo...@biblibre.com  ---
Created attachment 29452
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29452&action=edit
Bug 11703 [QA Followup] - Stop IE from caching ajax request

Signed-off-by: Britta Cramer 

Signed-off-by: Christopher Brannon 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable

2014-07-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703

--- Comment #160 from sandbo...@biblibre.com  ---
Created attachment 29447
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29447&action=edit
Bug 11703 [QA Followup]

* Bold record title, fix table width
* Change output_pref_due to output_pref
* Retain functionality of IssuesDefaultSortOrder system preferences
* Use datatables.inc in circulation.tt
* Fix up holds table details
* Add plugin to about
* fix relatives' checkouts
* add too_many string
* remove dead syspref from db
* Sort relatives' checkouts and holds tables client side
* Provide context for translation of strings
* Fix unterminated string literal, add missing paren
* Add replacement of _AUTHOR_ with title's author for holds
* Format prices correctly
* Format checkout dates correctly

Signed-off-by: Katrin Fischer 

Signed-off-by: Jonathan Druart 

Signed-off-by: Christopher Brannon 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable

2014-07-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703

--- Comment #167 from sandbo...@biblibre.com  ---
Created attachment 29454
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29454&action=edit
Bug 11703 [QA Followup] - Change "No data available in table" to "Loading..."

Signed-off-by: Jonathan Druart 

Signed-off-by: Christopher Brannon 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable

2014-07-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703

--- Comment #166 from sandbo...@biblibre.com  ---
Created attachment 29453
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29453&action=edit
Bug 11703 [QA Followup] - Allow keyboard navigation of tabs

Signed-off-by: Britta Cramer 

Signed-off-by: Christopher Brannon 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6815] Capture member photo via webcam

2014-07-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6815

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com
Version|unspecified |master
   Assignee|kohapa...@gmail.com |tomasco...@gmail.com

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable

2014-07-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703

--- Comment #161 from sandbo...@biblibre.com  ---
Created attachment 29448
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29448&action=edit
Bug 11703 [QA Followup] - Use format instead of replace for string translation

Signed-off-by: Jonathan Druart 

Signed-off-by: Christopher Brannon 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12499] The module C4::Letters.t needs more unit tests

2014-07-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12499

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

  Attachment #29431|0   |1
is obsolete||

--- Comment #2 from Bernardo Gonzalez Kriegel  ---
Created attachment 29455
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29455&action=edit
[SIGNED-OFF] Bug 12499: adding units tests for C4::Letters

The tests for the subroutines : GetMessageTransportType, EnqueueLetter,
SendQueuedMessages, GetQueuedMessages, GetLetters, getletter, addalert,
getalert, delalert and GetPreparedLetter of the module C4::Letters have been
added.

Test plan:
1) Apply the patch
2) Execute the unit tests by launching :
prove t/db_dependent/Letters.t
3) The result has to be a success without error or warning :
t/db_dependent/Letters.t .. ok
All tests successful.
Files=1, Tests=45,  2 wallclock secs ( 0.04 usr  0.01 sys +  1.44 cusr  0.08
csys =  1.57 CPU)
Result: PASS

Signed-off-by: Bernardo Gonzalez Kriegel 
All test pass, no errors.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12499] The module C4::Letters.t needs more unit tests

2014-07-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12499

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||bgkrie...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11904] Proposal for a uniform way to send messages to user interface

2014-07-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904

Julian Maurice  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #13 from Julian Maurice  ---
By "both translated", you mean you have translated the string in
fr-FR-messages.po and es-ES-messages.po ?
I just retried, applying patches on current master, and the translation works
for me.
Can you look at the log file ? Maybe there's a clue in it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10912] Streamline hold error messages in staff interface

2014-07-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10912

--- Comment #12 from Nick Clemens  ---
Hi Kyle,

I want to test this but I cannot produce the original error in master.

If I try to place a hold on an item with no defined rules I can get the "Too
many/no available" message, adding a rule that states number of allowed holds
gets rid of the 'Too Many'

With this patch I do see only one message, but the 'too many' seems valid if I
don't have any rules defined.

Can you let me know if you can reproduce this?

Thanks,
Nick

Tangent: I thought this was related to us seeing "Too many holds" in VOKAL,
however we only get that one message even though rules are defined for all
categories but playing in master, I cannot get any warning boxes if I turn on
'AllowHoldsOverride' and our system has that on so I don't know if something
changed there too.  Been puzzling over recreating the error we see but I am
guessing it was already fixed in master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12519] New: Convert list download pop-up to modal dialog

2014-07-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12519

Bug ID: 12519
   Summary: Convert list download pop-up to modal dialog
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: enhancement
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: oleon...@myacpl.org
QA Contact: testo...@bugs.koha-community.org

The list download process could happen inside a modal dialog instead of in a
popup. This would make it a smoother process especially on mobile devices.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12519] Convert OPAC list download pop-up to modal dialog

2014-07-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12519

Owen Leonard  changed:

   What|Removed |Added

Summary|Convert list download   |Convert OPAC list download
   |pop-up to modal dialog  |pop-up to modal dialog

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12520] New: Add DBIx::Class::ResultClass::HashRefInflator to list of Koha dependencies

2014-07-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12520

Bug ID: 12520
   Summary: Add DBIx::Class::ResultClass::HashRefInflator to list
of Koha dependencies
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: gmcha...@gmail.com
  Reporter: k...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

DBIx::Class::ResultClass::HashRefInflator is a nice stopgap for out move from
DBI to DBIx::Class. It allows us to return hashrefs like DBI, rather then DBIC
objects.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12520] Add DBIx::Class::ResultClass::HashRefInflator to list of Koha dependencies

2014-07-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12520

Kyle M Hall  changed:

   What|Removed |Added

 Blocks||12482, 12487

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12487] C4::Contract.pm : Replacement of subroutine calls of C4::SQLHelper by DBIx::Class

2014-07-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12487

Kyle M Hall  changed:

   What|Removed |Added

 Depends on||12520

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12482] C4::Budgets : Replacement of subroutine calls of C4::SQLHelper by DBIx::Class

2014-07-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12482

Kyle M Hall  changed:

   What|Removed |Added

 Depends on||12520

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12482] C4::Budgets : Replacement of subroutine calls of C4::SQLHelper by DBIx::Class

2014-07-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12482
Bug 12482 depends on bug 12520, which changed state.

Bug 12520 Summary: Add DBIx::Class::ResultClass::HashRefInflator to list of 
Koha dependencies
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12520

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |INVALID

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12487] C4::Contract.pm : Replacement of subroutine calls of C4::SQLHelper by DBIx::Class

2014-07-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12487
Bug 12487 depends on bug 12520, which changed state.

Bug 12520 Summary: Add DBIx::Class::ResultClass::HashRefInflator to list of 
Koha dependencies
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12520

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |INVALID

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12482] C4::Budgets : Replacement of subroutine calls of C4::SQLHelper by DBIx::Class

2014-07-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12482

Kyle M Hall  changed:

   What|Removed |Added

 Depends on|12520   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12520] Add DBIx::Class::ResultClass::HashRefInflator to list of Koha dependencies

2014-07-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12520

Kyle M Hall  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |INVALID

--- Comment #1 from Kyle M Hall  ---
Looks like I was mistaken. It's already part of the DBIx module set. No need to
install it separately.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12520] Add DBIx::Class::ResultClass::HashRefInflator to list of Koha dependencies

2014-07-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12520

Kyle M Hall  changed:

   What|Removed |Added

 Blocks|12482, 12487|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12487] C4::Contract.pm : Replacement of subroutine calls of C4::SQLHelper by DBIx::Class

2014-07-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12487

Kyle M Hall  changed:

   What|Removed |Added

 Depends on|12520   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10314] CanItemBeReserved does not respect the holds policies

2014-07-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10314

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@quecheelibrary.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7021] patron category in the statistics table

2014-07-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7021

Olli-Antti Kivilahti  changed:

   What|Removed |Added

 CC||olli-antti.kivila...@jns.fi

--- Comment #14 from Olli-Antti Kivilahti  ---
lol

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7021] patron category in the statistics table

2014-07-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7021

--- Comment #15 from Olli-Antti Kivilahti  ---
Created attachment 29456
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29456&action=edit
Bug_7021-Add_borrowers_category_to_statistics_usercode

Stumbled upon this issue and thought it would be nice to improve it a bit.
Hope it helps.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7021] patron category in the statistics table

2014-07-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7021

--- Comment #16 from Olli-Antti Kivilahti  ---
BTW.
I am not very keen on adding lots of content to statistics-table.
Because it already is gettting very large.
I am not looking forward to it getting larger than absolutely necessary.

We already have old_issues and deleted* to keep as history.

Our SSD for the DB is only 100GB ;)


However I have no data to back up anything. It is possible that suggested
modifications won't enlargen the statistics table significantly.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12337] Multi-clicking the renewal buttons on circulation.pl can trigger "renewal failed" message.

2014-07-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12337

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||tomasco...@gmail.com

--- Comment #5 from Tomás Cohen Arazi  ---
Patch pushed to master.

Thanks Kyle!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9811] Patrons search improvements

2014-07-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||tomasco...@gmail.com

--- Comment #135 from Tomás Cohen Arazi  ---
Patches pushed to master.

Thanks Jonathan and everyone involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12304] Creating a user via LDAP doesn't populate message preferences

2014-07-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12304

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||tomasco...@gmail.com

--- Comment #10 from Tomás Cohen Arazi  ---
Patch pushed to master.

Thanks Martin!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12456] The file C4/Maintainance.pm can be removed

2014-07-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12456

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||tomasco...@gmail.com

--- Comment #5 from Tomás Cohen Arazi  ---
Patch pushed to master.

Thanks Yohann!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable

2014-07-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703

Kyle M Hall  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12482] C4::Budgets : Replacement of subroutine calls of C4::SQLHelper by DBIx::Class

2014-07-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12482

--- Comment #3 from Kyle M Hall  ---
Created attachment 29457
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29457&action=edit
Bug 12482 [QA Followup]

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8566] Enable koha-foreach to insert the instancename into commands

2014-07-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8566

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||tomasco...@gmail.com

--- Comment #6 from Tomás Cohen Arazi  ---
Patch pushed to master.

Thanks Reed!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12386] 'Days in advance' pull down in bootstrap OPAC is huge

2014-07-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12386

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||tomasco...@gmail.com

--- Comment #9 from Tomás Cohen Arazi  ---
Patch pushed to master.

Thanks Owen!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11857] Number of patrons on a patron list not accurate

2014-07-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11857

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||tomasco...@gmail.com

--- Comment #7 from Tomás Cohen Arazi  ---
Patch pushed to master.

Thanks Fridolin!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12463] Capitalization: Calendar tool, headings for different types of holidays

2014-07-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12463

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||tomasco...@gmail.com

--- Comment #5 from Tomás Cohen Arazi  ---
Patch pushed to master.

Thanks Owen!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12482] C4::Budgets : Replacement of subroutine calls of C4::SQLHelper by DBIx::Class

2014-07-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12482

--- Comment #4 from Kyle M Hall  ---
Created attachment 29458
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29458&action=edit
[PASSED QA] Bug 12482: removing the use of the module C4::SQLHelper.pm, it is
replaced by DBIx::Class

This patch includes:
- removing the use of subroutines InsertInTable, UpdateInTable, SearchInTable
replaced by subroutines of DBIx::Class in the subroutines AddBudget, ModBudget,
GetBudgets, AddBudgetPeriods, ModBudgetPeriod and GetBudgetPeriods and
admin/aqbudgetperiods.pl
- removing old database fields in OrderFromSubscription.t, Bookseller.t,
Budgets.t, Serials.t, Serials_2.t
- improvement of unit tests in t/db_dependent/Budgets.t
- adaptation of calls to the subroutines AddBudget, ModBudget, GetBudgets,
AddBudgetPeriods, ModBudgetPeriod and GetBudgetPeriods in order to match with
the use of DBIx::Class

Test plan:

1) Execute the UT of all of files wich uses AddBudget, ModBudget, GetBudgets,
AddBudgetPeriods, ModBudgetPeriod or GetBudgetPeriods by launching the command
:
prove t/Budgets/ t/Budgets.t t/db_dependent/Budgets.t
t/db_dependent/Acquisition.t t/db_dependent/Acquisition/
t/db_dependent/Bookseller.t t/db_dependent/Serials.t t/db_dependent/Serials_2.t

2) The result has to be a success :
t/Budgets/CanUserModifyBudget.t ... ok
t/Budgets/CanUserUseBudget.t .. ok
t/Budgets.t ... ok
t/db_dependent/Budgets.t .. ok
t/db_dependent/Acquisition.t .. ok
t/db_dependent/Acquisition/GetBasketsInfosByBookseller.t .. ok
t/db_dependent/Acquisition/GetOrdersByBiblionumber.t .. ok
t/db_dependent/Acquisition/Invoices.t . ok
t/db_dependent/Acquisition/OrderFromSubscription.t  ok
t/db_dependent/Acquisition/TransferOrder.t  1/11 # Transfering
order to basket2
t/db_dependent/Acquisition/TransferOrder.t  ok
t/db_dependent/Acquisition/close_reopen_basket.t .. ok
t/db_dependent/Bookseller.t ... 16/72 WARNING:
GetBooksellerWithLateOrders is called with a negative value at
/home/yohann/koha/C4/Bookseller.pm line 135.
t/db_dependent/Bookseller.t ... ok
t/db_dependent/Serials.t .. ok
t/db_dependent/Serials_2.t  ok
All tests successful.
Files=14, Tests=571, 22 wallclock secs ( 0.17 usr  0.03 sys + 20.26 cusr  1.10
csys = 21.56 CPU)
Result: PASS

3) Go on the page admin/aqbudgetperiods.pl : Koha Administration > Budgets
4) Click on the button "New Budget" and record a new budget with a "nonzero
amount" and "make budget active"
5) Click on the button "New Budget" and record another budget without "make
budget active"
6) Verify there is the firt budget displayed in "Active budgets" and the second
budget in "Inactive budgets"
7) Edit a budget and verify the new values are updated
8) Click on the budget active name in order to go on the page
admin/aqbudgets.pl
9) Click on the button "New fund for ..." and record a new fund
10) Click on the button "Edit" then "Duplicate budget ..." in order to
duplicate the budget
11) Verify there are two budgets in "Active Budgets" and one in "Inactive
Budgets"
12) Click on "Funds" in the menu and verify there are two identical funds and
each is associated to a different budget.

Signed-off-by: Chris Cormack 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12482] C4::Budgets : Replacement of subroutine calls of C4::SQLHelper by DBIx::Class

2014-07-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12482

--- Comment #5 from Kyle M Hall  ---
Created attachment 29459
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29459&action=edit
[PASSED QA] Bug 12482 [QA Followup]

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12482] C4::Budgets : Replacement of subroutine calls of C4::SQLHelper by DBIx::Class

2014-07-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12482

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #29314|0   |1
is obsolete||
 CC||k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12482] C4::Budgets : Replacement of subroutine calls of C4::SQLHelper by DBIx::Class

2014-07-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12482

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #29457|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >