[Koha-bugs] [Bug 12494] Remove yuipath system preference

2014-07-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12494

--- Comment #7 from Jonathan Druart  ---
git grep yuipath returns:

koha-tmpl/opac-tmpl/ccsr/en/includes/doc-head-close.inc:
koha-tmpl/opac-tmpl/ccsr/en/includes/doc-head-close.inc:
koha-tmpl/opac-tmpl/ccsr/en/includes/doc-head-close.inc:
koha-tmpl/opac-tmpl/prog/en/includes/doc-head-close.inc: 
koha-tmpl/opac-tmpl/prog/en/includes/doc-head-close.inc: 
koha-tmpl/opac-tmpl/prog/en/includes/doc-head-close.inc: 
koha-tmpl/opac-tmpl/prog/en/modules/sco/sco-main.tt:
koha-tmpl/opac-tmpl/prog/en/modules/sco/sco-main.tt:
koha-tmpl/opac-tmpl/prog/en/modules/sco/sco-main.tt:

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11230] Refactor C4::Stats::UpdateStats and add UT

2014-07-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11230

mathieu saby  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11229] Payments wrongly saved in Statistics table by C4::Accounts::makepartialpayment and makepayment

2014-07-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11229

mathieu saby  changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=11230

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11230] Refactor C4::Stats::UpdateStats and add UT

2014-07-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11230

mathieu saby  changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=11229

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11230] Refactor C4::Stats::UpdateStats and add UT

2014-07-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11230

--- Comment #8 from mathieu saby  ---
In fact I already made a bug for this issue in 2013 : 
Bug 11229

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11213] GetItemsInfo() called twice

2014-07-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213

--- Comment #44 from Srdjan Jankovic  ---
(In reply to Bernardo Gonzalez Kriegel from comment #35)
> (In reply to M. Tompsett from comment #34)
> > I'd start at comment 25. :)

* GetItemsInfo() is getting called in t/db_dependent/Items.t: bug_11213:
GetItemsInfo() test
* searchResults() is already being called from t/db_dependent/Search.t;
XSLTResultsDisplay pref handling in the test should make sure the code is
visited: bug_11213: Include XSLT processing for searchResults() test
* shelfpage() did not have a test, and I can add one
* XSLTParse4Display() is being explicitly called in t/db_dependent/Items.t


> 
> Mmmm, I can finish right now.
> 
> My friends, what I expect is a clear list of what needs to be tested,
> or run, and what to expect as result. In that way it's easier.
> In it's current state is discouraging.

Clear list of what is expected is impossible, at least for me, to give. I
cannot even imagine in what different ways particular configs can affect XSLT
display. The best I can do is:
* Create tests that should pass. In this case we have (in t/db_dependent):
  Items.t
  Search.t
  VirtualShelves_Page.t (will add shelfpage() call)
* Ask for XSLT display on OPAC and Intranet related pages to be checked, which
includes:
- search results
- individual biblio + items display
- virtual shelves

> 
> Anyway,
> 1) In it's current state patch doesn't apply. Some patches have been pushed
> that gave conflicts. I solved all but I prefer the author have the last word
> on this

Rebased

> 
> 2) prove t/db_dependent/VirtualShelves_Page.t
> t/db_dependent/VirtualShelves_Page.t .. 1/3 
> #   Failed test 'opac items XSLT'
> #   at t/db_dependent/VirtualShelves_Page.t line 48.
> Please fix and resubmit.

That one worked for me after rebase. Can you please try again.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12538] Solr removal

2014-07-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12538

--- Comment #4 from Zeno Tajoli  ---
Yes, for example bug 12478 uses the system preference 'SearchEngine'

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11213] GetItemsInfo() called twice

2014-07-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213

Srdjan Jankovic  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11213] GetItemsInfo() called twice

2014-07-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213

Srdjan Jankovic  changed:

   What|Removed |Added

  Attachment #26721|0   |1
is obsolete||

--- Comment #43 from Srdjan Jankovic  ---
Created attachment 29564
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29564&action=edit
bug_11213: Check for $item->{itype} presence to avoid warning

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11213] GetItemsInfo() called twice

2014-07-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213

Srdjan Jankovic  changed:

   What|Removed |Added

  Attachment #26720|0   |1
is obsolete||

--- Comment #42 from Srdjan Jankovic  ---
Created attachment 29563
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29563&action=edit
bug_11213: Added XSLTParse4Display() to Items test

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11213] GetItemsInfo() called twice

2014-07-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213

Srdjan Jankovic  changed:

   What|Removed |Added

  Attachment #26719|0   |1
is obsolete||

--- Comment #41 from Srdjan Jankovic  ---
Created attachment 29562
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29562&action=edit
bug_11213: GetItemsInfo() test

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11213] GetItemsInfo() called twice

2014-07-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213

Srdjan Jankovic  changed:

   What|Removed |Added

  Attachment #26718|0   |1
is obsolete||

--- Comment #40 from Srdjan Jankovic  ---
Created attachment 29561
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29561&action=edit
bug_11213: Use branch codes from the database rather than hardcoded CPL and MPL

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11213] GetItemsInfo() called twice

2014-07-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213

Srdjan Jankovic  changed:

   What|Removed |Added

  Attachment #26500|0   |1
is obsolete||

--- Comment #37 from Srdjan Jankovic  ---
Created attachment 29558
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29558&action=edit
bug_11213: whitespace correction

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11213] GetItemsInfo() called twice

2014-07-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213

Srdjan Jankovic  changed:

   What|Removed |Added

  Attachment #26713|0   |1
is obsolete||

--- Comment #39 from Srdjan Jankovic  ---
Created attachment 29560
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29560&action=edit
bug_11213: C4::VirtualShelves::Page::shelf_contents()

* Extracted shelf items processing from shelfpage() into a separate sub
  shelf_contents() in order to be able to test it
* Added tests for shelf_contents() with XSLT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11213] GetItemsInfo() called twice

2014-07-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213

Srdjan Jankovic  changed:

   What|Removed |Added

  Attachment #26695|0   |1
is obsolete||

--- Comment #38 from Srdjan Jankovic  ---
Created attachment 29559
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29559&action=edit
bug_11213: Include XSLT processing for searchResults() test

* Added template paths to temp test dir, so XSLT templates can be picked
  up

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11213] GetItemsInfo() called twice

2014-07-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11213

Srdjan Jankovic  changed:

   What|Removed |Added

  Attachment #26499|0   |1
is obsolete||

--- Comment #36 from Srdjan Jankovic  ---
Created attachment 29557
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29557&action=edit
bug_11213: Changed XSLTParse4Display() interface

The list of biblio items is passed on now, instead of GetItemsInfo() being
called. This is because the callers already have the list ready, so the
GetItemsInfo() call is being duplicated unnecessarily.
Search::searchResults() builds items list from XML, and that one is
passed instead.

* XSLT::XSLTParse4Display()
- supply the items list as input param
- removed hidden items list param - hidden should not be in the items
  list
- changed buildKohaItemsNamespace() accordingly

* Items
- removed GetItemsLocationInfo()
- added sort_by input param to GetItemsInfo()
- VirtualShelves::Page::shelfpage() - replaced GetItemsLocationInfo() call
  with GetItemsInfo() call, passing order_by "cn_sort"

* catalogue/detail.pl, opac/opac-detail.pl, shelfpage()
- added items list to the XSLTParse4Display() call

* Search::searchResults()
- include all available info when building items lists
- added combined items list (available, on loan, other) to the
  XSLTParse4Display() call

To test:
This change is a noop, so following screens need to be checked against
any changes:
* Intranet:
- catalogue/search.pl (results)
- catalogue/detail.pl
- virtualshelves/shelves.pl
* Opac
- opac-search.pl (results, hidelostitems syspref on and off)
- opac-detail.pl
- opac-shelves.pl

The display should stay the same before and after patch. The speed
should increase though.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12538] Solr removal

2014-07-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12538

Chris Cormack  changed:

   What|Removed |Added

 CC||ch...@bigballofwax.co.nz

--- Comment #3 from Chris Cormack  ---
I think it will need to take 12478 into consideration, the code for which is in
a public branch already. But I dont think this is contigent on that, it just
should make sure that removing the Solr code doesnt break the Elasticsearch
stuff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12538] Solr removal

2014-07-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12538

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12539] PROG/CCSR deprecation: Remove hardcoded theme from C4/Templates.pm

2014-07-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12539

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Assignee|gmcha...@gmail.com  |bgkrie...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12539] PROG/CCSR deprecation: Remove hardcoded theme from C4/Templates.pm

2014-07-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12539

--- Comment #1 from Bernardo Gonzalez Kriegel  ---
Created attachment 29556
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29556&action=edit
Bug 12539: PROG/CCSR deprecation: Remove hardcoded theme from C4/Templates.pm

This patch removes hardcoded 'prog' from themelanguage
on C4/Templates.pm

Now that function only provides a fallback to 'en'
on active theme (opac & intranet)
Also removes a test already done on themelanguage

This also breaks definitely CCSR

To test:
1) Apply the patch
2) CCSR is now broken, prog & bootstrap must work as usual
3) Need to test language fallback
 a) translate for your preferred language (xx-YY)
 b) enable language on opac
 c) go to opac, select that language
 d) login on opac, go to personal details
 e) remove koha-tmpl/opac-tmpl/bootstrap/xx-YY/modules/opac-memberentry.tt
 d) reload page, must load in English
 f) click other member options, must load on translated language
(can use other pages, prog or bootstrap)
4) Do a similar test but for a staff page, enable lang, switch to it,
rm koha-tmpl/intranet-tmpl/prog/xx-YY/modules/admin/admin-home.tt,
any page must be translated except for admin home.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12539] New: PROG/CCSR deprecation: Remove hardcoded theme from C4/Templates.pm

2014-07-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12539

Bug ID: 12539
   Summary: PROG/CCSR deprecation: Remove hardcoded theme from
C4/Templates.pm
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: gmcha...@gmail.com
  Reporter: bgkrie...@gmail.com
QA Contact: testo...@bugs.koha-community.org

C4/Templates.pm has hardcoded theme

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12494] Remove yuipath system preference

2014-07-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12494

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #6 from Katrin Fischer  ---
Oh, what did I miss? I had tested a few pages in staff, are we still using yui
in OPAC?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9245] Visual Bug under fines tab

2014-07-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9245

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||tomasco...@gmail.com

--- Comment #10 from Tomás Cohen Arazi  ---
Patch pushed to master.

Thanks Viktor!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11030] Add 359, 947 and 969 fields in french unimarc_complete framework

2014-07-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11030

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||tomasco...@gmail.com

--- Comment #12 from Tomás Cohen Arazi  ---
Patches pushed to master.

Thanks Mathieu!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12534] PROG/CCSR deprecation: Make getlanguages() theme independent for opac

2014-07-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12534

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

  Attachment #29533|0   |1
is obsolete||

--- Comment #2 from Bernardo Gonzalez Kriegel  ---
Created attachment 29555
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29555&action=edit
Bug 12534 - PROG/CCSR deprecation: Make getlanguages() theme independent for
opac

This patch removes a reference to prog theme on getlanguages()
when ENV var HTTP_ACCEPT_LANGUAGE is checked.

Changed to use sysprefs to find theme for opac and intranet

To test:
1) Apply the patch
2) Translate for a couple of languages: de-DE, fr-FR, es-ES, etc
3) Enable those languages for OPAC on I18N prefs
4) Using Firefox, clean all history/cookies
5) Change variable intl.accept_languages (will do several times)
 a) got to about:config
 b) search 'lang'
 c) look for the variable, double click, change to 'de-DE'
6) Go to opac page, must load in german
7) Repeat for each translated lang: clean > change val > reload opac
   On each case opac must load on configured language
8) Just to test, set variable on untranslated lang, opac page
must load on first value of list of enabled languages
9) prove t/Languages.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11395] Batch modifications for records

2014-07-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395

Paola Rossi  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA
 CC||paola.ro...@cineca.it

--- Comment #33 from Paola Rossi  ---
Today I've tried to test the patches against master 3.17.00.009

I've applied:
5 patches of 11319,
3 patches of 11914,
and the 8 patches of the current 11395.

I've found three errors.

1) ERROR on MARC modification templates: unavailable "Every" option:

I've edited this action:
Copy field 650$x to 650$y if 650$x matches RegEx m/ ^second 650 / 

Then I've changed all the 650-s into 750-s. I see "All" becoming "Every" (I
have not understood why it has happened). I've saved, and I've editing the
action again: now "All" is shown.
I've not been able to set "Every" option. 
I think that showing "Every" is an error, or there's a lack in managing that
option (see C) below).

So I've passed the patch to "Failed QA" status.

2) On Batch record modification [and on cart Action Modify too], I've cleared
all the listed records.
I've selected "Modify the selected records". Instead of "No record was
selected", the program has started, and then has ended showing:
"All records have successfully been modified! ".


3) ERROR on batch_record_modification.pl [I've checked only "Preview MARC"]:
case of repeteable subfield [x] in repeteable fields [650]:

My biblio record had 3 fields 650, each one had 3 $x:
650  0 ..
   _x1-650 x 1 Digital techniques 1
   _xfirst 650, second $x
   _x1-650 x 3 Digital techniques 3
650  0 
   _x2-650 x 1 Digital techniques 1
   _xsecond 650, second $x
   _x2-650 x 3 Digital techniques 3
650  0 ..
   _x3-650 x 1 Digital techniques 1
   _xthird 650, second $x
   _x3-650 x 3 Digital techniques 3

I wanted to delete only the second occurrence of $x, only in the second
occurrence of 650 field. So my action was:
(A) Delete field 650$x if 650$x matches RegEx m/ ^second 650 / 

On preview MARC the result is not what I wanted, but:
650  0 ...
   _x1-650 x 1 Digital techniques 1
   _xfirst 650, second $x
   _x1-650 x 3 Digital techniques 3
650  0 
650  0 
   _x3-650 x 1 Digital techniques 1
   _xthird 650, second $x
   _x3-650 x 3 Digital techniques 3

Then I've tried another action, selecting the "first" option:
B) Delete 1st field 650$x if 650$x matches RegEx m/ ^second 650 / 
but the result remained the same as for "All" (A).

Neither the 2 negative forms gave me what I wanted:
C) Delete field 650$x unless 650$x does not match RegEx m/ ^second 650 /
D) Delete 1st field 650$x unless 650$x does not match RegEx m/ ^second 650 /

Similar behaviours occurred in Copy, Update and Move cases.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12403] Batch record deletion

2014-07-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12403

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA
 CC||bgkrie...@gmail.com

--- Comment #8 from Bernardo Gonzalez Kriegel  ---
Hi Jonathan,

 FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/tools/batch_delete_records.tt
   FAIL   forbidden patterns
forbidden pattern: To include datatables files, please use the
include file (see bug 10868) (line 6)

Captured by your own code :)
[http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10868#c4]

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11650] multiplicated authorities after link_bibs_to_authorities.pl

2014-07-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11650

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||tomasco...@gmail.com

--- Comment #5 from Tomás Cohen Arazi  ---
Patch pushed to master.

Thanks Janusz!

Note: we need unit tests for this kind of patches. The change looks simple and
easy to spot. I pushed it because it was simple, and noticed we don't have the
glue to write tests for this in t/db_dependent/Biblio.t (yet :-D)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12429] patron seeing fines codes

2014-07-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12429

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||tomasco...@gmail.com

--- Comment #10 from Tomás Cohen Arazi  ---
Patches pushed to master.

Thanks Owen!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12538] Solr removal

2014-07-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12538

Jonathan Druart  changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=12478

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12478] Elasticsearch support for Koha

2014-07-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478

Jonathan Druart  changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=12538

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12538] Solr removal

2014-07-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12538

Zeno Tajoli  changed:

   What|Removed |Added

 Status|Needs Signoff   |In Discussion
 CC||z.taj...@cineca.it

--- Comment #2 from Zeno Tajoli  ---
Hi,

it is not to coordinate this bug with 12478 ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11904] Proposal for a uniform way to send messages to user interface

2014-07-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11904] Proposal for a uniform way to send messages to user interface

2014-07-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

  Attachment #29545|0   |1
is obsolete||

--- Comment #19 from Bernardo Gonzalez Kriegel  ---
Created attachment 29552
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29552&action=edit
[SIGNED-OFF] Bug 11904: New module Koha::Messages

This patch provides a uniform way to send messages to user interface.
It uses CGI::Session to store messages and allow to render them thanks
to a Template::Toolkit plugin (Koha::Template::Plugin::Messages)
and a template include file (messages.inc)

This patch doesn't introduce the new template include file anywhere. It
will require additional patches to make it work.

To use it, simply call messages_set() in a Perl script or module, then
put [% INCLUDE 'messages.inc' %] at the right place in the right
template file.

See POD documentation of Koha::Messages for more information.

Signed-off-by: Bernardo Gonzalez Kriegel 
Originally there was a conflict on bootstrap less/opac.less and
css/opac.css, not now, but can't access git at this moment.

No errors.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11904] Proposal for a uniform way to send messages to user interface

2014-07-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

  Attachment #29547|0   |1
is obsolete||

--- Comment #21 from Bernardo Gonzalez Kriegel  ---
Created attachment 29554
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29554&action=edit
[SIGNED-OFF] Bug 11904: Example usage of new module Koha::Messages

Test plan:
1/ Go to members/moremember.pl
2/ Click on "More" -> "Renew patron" and confirm
3/ A message should appear "Patron's account has been renewed until ..."
4/ In a shell, go to misc/translator and run
  ./translate create fr-FR (or ./translate update fr-FR)
  ./translate install fr-FR
  (you can use your own language of course)
5/ Edit po/fr-FR-messages.po and translate the string "Patron's account
   has been renewed until ..."
6/ In staff interface change language to French and renew patron once
again.
7/ The translated message should appear.

Needs patches from bugs 8044 and 11848 for string translation

Signed-off-by: Bernardo Gonzalez Kriegel 
Bugs 8044 and 11484 already in master
Tested using es-ES, works as described.
No errors

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11904] Proposal for a uniform way to send messages to user interface

2014-07-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

  Attachment #29546|0   |1
is obsolete||

--- Comment #20 from Bernardo Gonzalez Kriegel  ---
Created attachment 29553
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29553&action=edit
[SIGNED-OFF] Bug 11904: Unit tests for Koha::Messages

Signed-off-by: Bernardo Gonzalez Kriegel 
Test pass, no errors.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12538] Solr removal

2014-07-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12538

--- Comment #1 from Jonathan Druart  ---
Created attachment 29551
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29551&action=edit
Bug 12538: Remove Solr without breaking anything else

Since nobody is currently working on the zebra layer introduced by bug
8233, Solr won't never work.
Some code has been introduced in 3.10 to prove several search engines
can cohabit into Koha but no help/fund has been found to go ahead.
It is useless to keep this code and to maintain an ambiguous situation.

I think the indexes configuration page could be restore later if someone
else introduces a new search engine into Koha.

Test plan:
Look at the code introduced by bug 8233 and verify all is removed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12538] Solr removal

2014-07-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12538

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12538] Solr removal

2014-07-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12538

Jonathan Druart  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 Depends on||8233
   Assignee|gmcha...@gmail.com  |jonathan.dru...@biblibre.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12538] New: Solr removal

2014-07-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12538

Bug ID: 12538
   Summary: Solr removal
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Searching
  Assignee: gmcha...@gmail.com
  Reporter: jonathan.dru...@biblibre.com
QA Contact: testo...@bugs.koha-community.org

Since nobody is currently working on the zebra layer introduced by bug 8233,
Solr won't never work.
Some code has been introduced in 3.10 to prove several search engines can
cohabit into Koha but no help/fund has been found to go ahead.
It is useless to keep this code and to maintain an ambiguous situation.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8233] New search engine layer - introduce solr without breaking anything else

2014-07-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8233

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||12538

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8462] OpacHiddenItems and hidelostitems hide items, but query result count is off

2014-07-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8462

--- Comment #39 from M. Tompsett  ---
I haven't tested, so I can't say whether or not I am right or wrong. I'm just
providing a test case in which I think it will fail.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7673] New patron permissions

2014-07-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673

--- Comment #70 from Jonathan Druart  ---
Created attachment 29550
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29550&action=edit
Bug 7673: DB changes - (follow-up) Add permissions

Add permissions for ru-RU and uk-UA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7673] New patron permissions

2014-07-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673

Jonathan Druart  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12537] New: editions tab showing on bibs with more than one ISBN

2014-07-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12537

Bug ID: 12537
   Summary: editions tab showing on bibs with more than one ISBN
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: neng...@gmail.com
QA Contact: testo...@bugs.koha-community.org

Created attachment 29549
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29549&action=edit
editions tab showing

When a record has more than one ISBN it shows the Editions tab in the OPAC and
it links to the exact same record. It's not a different edition.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9180] Default rules are not always used for overdues

2014-07-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9180

Jonathan Druart  changed:

   What|Removed |Added

 QA Contact|m.de.r...@rijksmuseum.nl|

--- Comment #25 from Jonathan Druart  ---
(In reply to Katrin Fischer from comment #23)
> Doing some first tests on this, noticing a few things:
> 
> 1) The unit tests (yay!) are in a new file Overdues.pl - I think they need
> to be integrated into Overdues.t or the file should be renamed to be a .t
> file.

I really don't understand what I did...
I squashed the patches, rename the unit tests file and added a "sort" on
comparing the array (this fixes the test failures).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12062] Untranslatable "Reserve not found"

2014-07-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12062

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||tomasco...@gmail.com

--- Comment #18 from Tomás Cohen Arazi  ---
Patches pushed to master.

Thanks Bernardo and Katrina!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9180] Default rules are not always used for overdues

2014-07-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9180

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #25947|0   |1
is obsolete||
  Attachment #27427|0   |1
is obsolete||

--- Comment #24 from Jonathan Druart  ---
Created attachment 29548
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29548&action=edit
Bug 9180: All branches should be returned if a default rule exists

The C4::Overdues::GetBranchcodesWithOverdueRules routine has a bug.
If a default rule *and* a specific rule exist, only the branchcode for
the specific rule is returned.

Test plan:
prove t/db_dependent/Overdues.t
and verify the unit tests are consistent.

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12511] Novelist Select not using https in bootstrap

2014-07-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12511

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||tomasco...@gmail.com

--- Comment #4 from Tomás Cohen Arazi  ---
Patch pushed to master.

Thanks Kyle!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12495] Street number missing from hold alert on checkin page

2014-07-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12495

--- Comment #8 from Tomás Cohen Arazi  ---
Patch pushed to master.

Thanks, and congratulations David!

Note: a discussion on how to compose addresses with different naming schemas
(a.k.a. 'localized') is in place, but belongs to another bug.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9180] Default rules are not always used for overdues

2014-07-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9180

Jonathan Druart  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12495] Street number missing from hold alert on checkin page

2014-07-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12495

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11904] Proposal for a uniform way to send messages to user interface

2014-07-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904

--- Comment #18 from Jonathan Druart  ---
(In reply to Bernardo Gonzalez Kriegel from comment #14)
> But... you are touching some opac prog files
> As we are on PROG/CCSR deprecation, and this is a new feature,
> those will never be included.
> 
> Could you reset those files?

Done.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11904] Proposal for a uniform way to send messages to user interface

2014-07-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904

--- Comment #16 from Jonathan Druart  ---
Created attachment 29546
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29546&action=edit
Bug 11904: Unit tests for Koha::Messages

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11904] Proposal for a uniform way to send messages to user interface

2014-07-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904

--- Comment #17 from Jonathan Druart  ---
Created attachment 29547
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29547&action=edit
Bug 11904: Example usage of new module Koha::Messages

Test plan:
1/ Go to members/moremember.pl
2/ Click on "More" -> "Renew patron" and confirm
3/ A message should appear "Patron's account has been renewed until ..."
4/ In a shell, go to misc/translator and run
  ./translate create fr-FR (or ./translate update fr-FR)
  ./translate install fr-FR
  (you can use your own language of course)
5/ Edit po/fr-FR-messages.po and translate the string "Patron's account
   has been renewed until ..."
6/ In staff interface change language to French and renew patron once
again.
7/ The translated message should appear.

Needs patches from bugs 8044 and 11848 for string translation

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11904] Proposal for a uniform way to send messages to user interface

2014-07-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #27940|0   |1
is obsolete||
  Attachment #27941|0   |1
is obsolete||
  Attachment #27942|0   |1
is obsolete||

--- Comment #15 from Jonathan Druart  ---
Created attachment 29545
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29545&action=edit
Bug 11904: New module Koha::Messages

This patch provides a uniform way to send messages to user interface.
It uses CGI::Session to store messages and allow to render them thanks
to a Template::Toolkit plugin (Koha::Template::Plugin::Messages)
and a template include file (messages.inc)

This patch doesn't introduce the new template include file anywhere. It
will require additional patches to make it work.

To use it, simply call messages_set() in a Perl script or module, then
put [% INCLUDE 'messages.inc' %] at the right place in the right
template file.

See POD documentation of Koha::Messages for more information.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12409] The test t/db_dependent/Record.t fails with Perl 5.18.2

2014-07-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12409

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #7 from Tomás Cohen Arazi  ---
Patch pushed to master.

Thanks Yohann!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12151] remove remaining uses of the Perl smartmatch operator

2014-07-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12151

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #22 from Tomás Cohen Arazi  ---
Patches pushed to master.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12499] The module C4::Letters.t needs more unit tests

2014-07-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12499

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||tomasco...@gmail.com

--- Comment #4 from Tomás Cohen Arazi  ---
Patch pushed to master.

Thanks Yohann!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11904] Proposal for a uniform way to send messages to user interface

2014-07-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904

--- Comment #14 from Bernardo Gonzalez Kriegel  ---
(In reply to Julian Maurice from comment #13)
> Can you look at the log file ? Maybe there's a clue in it.

Julian, tested and works well. Test pass and no koha-qa errors.
(was a problem on my side)

But... you are touching some opac prog files
As we are on PROG/CCSR deprecation, and this is a new feature,
those will never be included.

Could you reset those files?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11518] Add new method to Koha::Schema::Result::Item that will always return the correct itemtype

2014-07-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11518

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #29544|Bug 11518: WIP - Remove |[NOT-PUSHED]Bug 11518: WIP
description|useless constraints |- Remove useless
   |previously added|constraints previously
   ||added

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11518] Add new method to Koha::Schema::Result::Item that will always return the correct itemtype

2014-07-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11518

--- Comment #24 from Jonathan Druart  ---
Created attachment 29544
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29544&action=edit
Bug 11518: WIP - Remove useless constraints previously added

This patch removes the 3 constraints added by patch from bug 11518.
Having 1-n + 1-1 relations for the same field is a non-sense.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11518] Add new method to Koha::Schema::Result::Item that will always return the correct itemtype

2014-07-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11518

Jonathan Druart  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11518] Add new method to Koha::Schema::Result::Item that will always return the correct itemtype

2014-07-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11518

--- Comment #23 from Jonathan Druart  ---
I really don't understand the complexity of this patch.

Why do we want to add extra constraints? In my opinion, the fk constraints
exist in DB and we don't want to add more.

If we keep the constraints introduced by these patch, we get a 1-n and a 1-1
relations for the same field.
I know the current structure (biblio/biblioitems/items) has a lack but I don't
think it is the good way to solve it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12448] Ask for confirmation when checking out an item with rental fees

2014-07-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12448

Maxime Beaulieu  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12448] Ask for confirmation when checking out an item with rental fees

2014-07-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12448

--- Comment #33 from Maxime Beaulieu  ---
Created attachment 29543
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29543&action=edit
Bug 12448 - Follow-up to Comment 32.

In C4/Circulation.pm, 'GetIssuingCharges' is now called after the syspref is
checked.
The text for the system preference now reads "When checking out an item with
rental fees [ask/don't ask] for confirmation.

modified:   C4/Circulation.pm
modified:  
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12403] Batch record deletion

2014-07-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12403

--- Comment #7 from Olli-Antti Kivilahti  ---
Error encapsulation is important logic. :)

Just automatically make a Z39.50 search to find all component parts for a
record, then ask does the user want to remove all of them, then remove all of
them + parent record.

But I got it covered. Component parts don't have items so there are no
different states to check for.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12532] Redirect guarantee email to guarantor

2014-07-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12532

Blou  changed:

   What|Removed |Added

 CC||francois.charbonnier@inlibr
   ||o.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12536] Incorrect number of irregularity issues

2014-07-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12536

simith.dolive...@inlibro.com changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
 CC||philippe.blo...@inlibro.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12536] Incorrect number of irregularity issues

2014-07-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12536

--- Comment #1 from simith.dolive...@inlibro.com ---
Created attachment 29542
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29542&action=edit
Bug 12536 - Incorrect number of irregularity issues

Modified:

serials/subscription-detail.pl  - fix split command


Testing:

I Apply the patch

0) Select a serial subscription;
1) Click Edit -> Edit subscription;
2) Click Next;
3) Click Test prediction pattern;
4) Select 3 Vols;
5) Save subscription;
6) Select Planing tab;
7) Valide "Irregularity: 3 issues".

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12536] New: Incorrect number of irregularity issues

2014-07-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12536

Bug ID: 12536
   Summary: Incorrect number of irregularity issues
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Serials
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: simith.dolive...@inlibro.com
QA Contact: testo...@bugs.koha-community.org
CC: colin.campb...@ptfs-europe.com

In Serials -> Planning tab, irregularity is always 1 issue.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12403] Batch record deletion

2014-07-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12403

--- Comment #6 from Jonathan Druart  ---
(In reply to Olli-Antti Kivilahti from comment #5)
> Could you make a C4/Koha-module out of ($op eq 'delete') feature in
> batch_delete_records.pl?
> 
> So it would be easier to reuse that.

Hi Olli,
There is no important logic in the pl file.
Most of the code is error encapsulation.
Where do you want to reuse this part of code?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10212] Columns configuration for tables

2014-07-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10212

Jonathan Druart  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

--- Comment #58 from Jonathan Druart  ---
I add some significant changes in the last patch set :
1/ Use DBIC
2/ Reorganize patches for a better readability
3/ Remove changes in circ/circulation.pl|tt. I now use admin/currency.tt.
Hopefully, this will be easier to maintain (less conflict).

This new patch set needs a (quick?) new signoff please.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10212] Columns configuration for tables

2014-07-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10212

--- Comment #57 from Jonathan Druart  ---
Created attachment 29541
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29541&action=edit
Bug 10212: Columns configuration for tables - POC

This patch proves that this feature is useful with a concret use case.

Test plan:
1/ Execute the updatedatabase in order to create the new table.
2/ Take a look to the yml structure.
3/ Go on the admin currency page (admin/currency.pl).
4/ Check that you cannot hide the 2 first columns on the table.
5/ Try to hide/show columns.
6/ Go on the columns configuration page (admin/columns_settings.pl).
7/ Only the admin tab are filled with data. Check/uncheck checkboxes and
save.
8/ Go on the admin currency page and check that the behavior is what
you expected.
9/ Give me some feedback :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10212] Columns configuration for tables

2014-07-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10212

--- Comment #56 from Jonathan Druart  ---
Created attachment 29540
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29540&action=edit
Bug 10212: Columns configuration for tables - Add Colvis files

This patch only adds Colvis js and css files.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10212] Columns configuration for tables

2014-07-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10212

--- Comment #55 from Jonathan Druart  ---
Created attachment 29539
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29539&action=edit
Bug 10212: Columns configuration for tables - Unit tests

test plan:
Verify the
  prove t/db_dependent/ColumnsSettings.t
returns green.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10212] Columns configuration for tables

2014-07-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10212

--- Comment #54 from Jonathan Druart  ---
Created attachment 29538
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29538&action=edit
Bug 10212: Columns configuration for tables - DB changes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10212] Columns configuration for tables

2014-07-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10212

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #29075|0   |1
is obsolete||
  Attachment #29076|0   |1
is obsolete||
  Attachment #29077|0   |1
is obsolete||
  Attachment #29078|0   |1
is obsolete||
  Attachment #29079|0   |1
is obsolete||
  Attachment #29080|0   |1
is obsolete||

--- Comment #53 from Jonathan Druart  ---
Created attachment 29537
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29537&action=edit
Bug 10212: Columns configuration for tables

This development introduces ColVis into Koha and provides a configuration
page for columns visibility.

ColVis is a plugin for DataTables. It allows to change the visibility of
the columns in the table.

* This development adds:
  - the js and css file for ColVis
  - a new DB table 'columns_settings'
  - a new template plugin 'ColumnsSettings'
  - a new package C4::Utils::DataTables::ColumnsSettings
  - a new admin page admin/columns_settings.pl

* How it works:
A yaml file is created (admin/columns_settings.yml) in order to take an
inventory of all tables where ColVis is implemented. This file is read
to create the list of modules, pages and tables in the configuration
page.
There are 3 possible keys in the yml:
 - is_hidden: default is 0
The column will be hidden.
 - cannot_be_toggled: default is 0.
ColVis will allow to hide/show the column.
 - cannot_be_modified: default is 0
Default values (in the yml) won't be modifiable.

When a user changes (or saves) the configuration for one module, all
columns are added to the DB table. The values in the DB get the upper hand
on the yaml values.

* Humm, strange?
It seems weird to have 2 storages for the same values. But I
think it will be easy to add an entry and maintain the yaml rather than
adding a new row (and new entry in updatedatabase script) in the DB.

* To go further: We can imagine that the configuration is saved for each
user (and not globally like it is made with this patch).

This patch cannot be tested as it, you need to apply the "POC" patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12403] Batch record deletion

2014-07-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12403

--- Comment #5 from Olli-Antti Kivilahti  ---
Could you make a C4/Koha-module out of ($op eq 'delete') feature in
batch_delete_records.pl?

So it would be easier to reuse that.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12403] Batch record deletion

2014-07-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12403

Olli-Antti Kivilahti  changed:

   What|Removed |Added

 CC||olli-antti.kivila...@jns.fi

--- Comment #4 from Olli-Antti Kivilahti  ---
Hi there Jonathan!
Great to be signing off your patches again!

I am building batch removal of component parts on top of this feature.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7162] Factorize code for order cancellation

2014-07-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7162

Julian Maurice  changed:

   What|Removed |Added

  Attachment #29535|0   |1
is obsolete||

--- Comment #71 from Julian Maurice  ---
Created attachment 29536
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29536&action=edit
Bug 7162: Factorize code for order cancellation (QA fixes)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7162] Factorize code for order cancellation

2014-07-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7162

Julian Maurice  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7162] Factorize code for order cancellation

2014-07-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7162

--- Comment #70 from Julian Maurice  ---
Created attachment 29535
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29535&action=edit
Bug 7162: Factorize code for order cancellation (QA fixes)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12494] Remove yuipath system preference

2014-07-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12494

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@biblibre.co
   ||m

--- Comment #5 from Jonathan Druart  ---
In my opinion, this patch should not be pushed before bug 12233. It will break
ccsr and prog themes.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11607] items.content does not contain any formatting when HTML message is selected.

2014-07-07 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11607

Derryn  changed:

   What|Removed |Added

 CC||derr...@gmail.com

--- Comment #1 from Derryn  ---
I was just about to file a bug for this when I saw you had already done so.
Just in case anyone needs clarification:
To reproduce
1. Tools -> Notices
2. Edit 'Item Due Reminder (Digest)'
3. Tick 'HTML message'
4. Enter <> in the message body.
5. Save
6. Borrow 2 items on an account set up to receive item due email notifications
and set the due date as today.
7. Run advance_notices.pl
8. Run process_message_queue.pl
9. Check your email - there will be 2 items on one line, rather than a line
break between them.

If you repeat the above steps without checking 'HTML message' it does include
line breaks.

This issue is still present in 3.16

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/