[Koha-bugs] [Bug 12494] Remove yuipath system preference

2014-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12494

--- Comment #8 from Katrin Fischer  ---
I need to get better with grep - thx for catching this!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12403] Batch record deletion

2014-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12403

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #28764|0   |1
is obsolete||

--- Comment #9 from Jonathan Druart  ---
Created attachment 29565
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29565&action=edit
Bug 12403: Add a batch record deletion

This patch offers a new tool for deleting records.
Biblios and authorities will can to be deleted with a simple list of
biblionumber or authid.

This feature adds:
- a new pl/tt files tools/batch_delete_records
- a new permission: tools > records_batchdel

Test plan for biblios:
1/ There are two ways to generate a list of biblionumbers:
- using the basket: do a search, add some biblio to your basket, open
  the basket and click on the "Action" button > "Delete"
- generating a list from a report
2/ On the "Batch record deletion" tool verify:
- biblios with issues cannot be deleted (checkbox disabled and line in
  red).
- information is correct.
- sort functions work on each columns.
- the items, reserves and issues values are correct.
3/ After clicking on the "Delete selected recors" button, verify:
- reserves, items and biblio have successful been deleted.
- if an error occurs, the tool display an error message.

Test plan for authority:
1/ Generate a list of authid using a report:
2/ On the "Batch record deletion" tool verify:
- authorities are display with the summary.
- the count usage (used in X biblios) is correct.
3/ After clicking on the "Delete selected recors" button, verify:
- The authorities have successful been deleted.
- if an error occurs, the tool display an error message.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12403] Batch record deletion

2014-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12403

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #28766|0   |1
is obsolete||

--- Comment #11 from Jonathan Druart  ---
Created attachment 29567
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29567&action=edit
Bug 12403: Don't check disabled checkboxes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12403] Batch record deletion

2014-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12403

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #28765|0   |1
is obsolete||

--- Comment #10 from Jonathan Druart  ---
Created attachment 29566
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29566&action=edit
Bug 12403: Add the new permission tools_records_batchdelitem

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12403] Batch record deletion

2014-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12403

Jonathan Druart  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #12 from Jonathan Druart  ---
(In reply to Bernardo Gonzalez Kriegel from comment #8)
> Captured by your own code :)
> [http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10868#c4]

Ooops :)
Actually I rebased this patch from an old version and I forgot to launch the qa
script.

Note that the qa script still raises an error:

 FAIL   tools/batch_delete_records.pl
   FAIL   valid
Smartmatch is experimental 
Useless use of '\'; doesn't escape metacharacter '(' 

But it is not relevant, it's just because the script uses C4::Authorities
(which raises this warning).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12493] The module C4::Acquisition.pm contains subroutines which belong to C4::Contract.pm

2014-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12493

--- Comment #8 from Yohann Dufour  ---
Created attachment 29568
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29568&action=edit
[FOLLOW UP] Bug 12493 : moving the subroutines GetContract and GetContracts
from C4::Acquisition.pm to C4::Contract.pm

Fix in order to respect the coding guidelines

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12493] The module C4::Acquisition.pm contains subroutines which belong to C4::Contract.pm

2014-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12493

Yohann Dufour  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12493] The module C4::Acquisition.pm contains subroutines which belong to C4::Contract.pm

2014-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12493

--- Comment #9 from Yohann Dufour  ---
Katrin, I've tested my commit with the tools koha-qa.pl but it doesn't detect
tabs or spaces, and I've not found the mixup you said.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12493] The module C4::Acquisition.pm contains subroutines which belong to C4::Contract.pm

2014-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12493

--- Comment #10 from Katrin Fischer  ---
Hi Yohann, you are right, I thought Contract.pm was new, but it isn't - sorry
for that and thx for your follow-up!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11395] Batch modifications for records

2014-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395

--- Comment #34 from Jonathan Druart  ---
(In reply to Paola Rossi from comment #33)
> Today I've tried to test the patches against master 3.17.00.009

Paola,
Thank you for testing!

> 1) ERROR on MARC modification templates: unavailable "Every" option:

Yes, maybe it's is not obvious.
Actually if the condition is on the same field, the tool won't process "all"
field, but only the ones matching the condition.
I preferred to change to "all" value with something clearer.
I consider what you described as a very minor issue (it's just ergonomic).
So I prefer not to fix it for now but I keep it in my mind.

> 2) On Batch record modification [and on cart Action Modify too], I've
> cleared all the listed records.
> I've selected "Modify the selected records". Instead of "No record was
> selected", the program has started, and then has ended showing:
> "All records have successfully been modified! ".

It's definitely an issue for this bug report, patch coming...

> 3) ERROR on batch_record_modification.pl [I've checked only "Preview MARC"]:
> case of repeteable subfield [x] in repeteable fields [650]:

I will have a look at this but it's not for this bug report. I will open a new
bug for that (linked to bug 11413 and bug 11319).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11395] Batch modifications for records

2014-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395

Jonathan Druart  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11395] Batch modifications for records

2014-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395

--- Comment #35 from Jonathan Druart  ---
Created attachment 29569
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29569&action=edit
Bug 11395: prevent processing no record

If no record is selected, the modification should not be launched.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12540] New: Batch modifications for records - unavailable "Every" option

2014-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12540

Bug ID: 12540
   Summary: Batch modifications for records - unavailable "Every"
option
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Tools
  Assignee: gmcha...@gmail.com
  Reporter: jonathan.dru...@biblibre.com
QA Contact: testo...@bugs.koha-community.org

Paola found the following error on testing bug 11395 comment 33:

ERROR on MARC modification templates: unavailable "Every" option:

I've edited this action:
Copy field 650$x to 650$y if 650$x matches RegEx m/ ^second 650 / 

Then I've changed all the 650-s into 750-s. I see "All" becoming "Every" (I
have not understood why it has happened). I've saved, and I've editing the
action again: now "All" is shown.
I've not been able to set "Every" option. 
I think that showing "Every" is an error, or there's a lack in managing that
option (see C) below).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12540] Batch modifications for records - unavailable "Every" option

2014-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12540

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||11395
   Assignee|gmcha...@gmail.com  |jonathan.dru...@biblibre.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11395] Batch modifications for records

2014-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||12540

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12541] New: Marc modification template - empty field

2014-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12541

Bug ID: 12541
   Summary: Marc modification template - empty field
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Tools
  Assignee: gmcha...@gmail.com
  Reporter: jonathan.dru...@biblibre.com
QA Contact: testo...@bugs.koha-community.org

Paola found the following bug on testing bug 11395 comment 33:

ERROR on batch_record_modification.pl [I've checked only "Preview MARC"]:
case of repeteable subfield [x] in repeteable fields [650]:

My biblio record had 3 fields 650, each one had 3 $x:
650  0 ..
   _x1-650 x 1 Digital techniques 1
   _xfirst 650, second $x
   _x1-650 x 3 Digital techniques 3
650  0 
   _x2-650 x 1 Digital techniques 1
   _xsecond 650, second $x
   _x2-650 x 3 Digital techniques 3
650  0 ..
   _x3-650 x 1 Digital techniques 1
   _xthird 650, second $x
   _x3-650 x 3 Digital techniques 3

I wanted to delete only the second occurrence of $x, only in the second
occurrence of 650 field. So my action was:
(A) Delete field 650$x if 650$x matches RegEx m/ ^second 650 / 

On preview MARC the result is not what I wanted, but:
650  0 ...
   _x1-650 x 1 Digital techniques 1
   _xfirst 650, second $x
   _x1-650 x 3 Digital techniques 3
650  0 
650  0 
   _x3-650 x 1 Digital techniques 1
   _xthird 650, second $x
   _x3-650 x 3 Digital techniques 3

Then I've tried another action, selecting the "first" option:
B) Delete 1st field 650$x if 650$x matches RegEx m/ ^second 650 / 
but the result remained the same as for "All" (A).

Neither the 2 negative forms gave me what I wanted:
C) Delete field 650$x unless 650$x does not match RegEx m/ ^second 650 /
D) Delete 1st field 650$x unless 650$x does not match RegEx m/ ^second 650 /

Similar behaviours occurred in Copy, Update and Move cases.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12541] Marc modification template - empty field

2014-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12541

Jonathan Druart  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 Depends on||11413, 11319

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11319] Marc modification templates improvements

2014-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11319

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||12541

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11413] Marc modification template has not the expected behavior if the condition and source fields are on the same field

2014-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11413

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||12541

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12541] Marc modification template - empty field

2014-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12541

Jonathan Druart  changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |jonathan.dru...@biblibre.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12541] Marc modification template - multivalued subfields

2014-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12541

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 CC||paola.ro...@cineca.it
 Resolution|--- |LATER
Summary|Marc modification template  |Marc modification template
   |- empty field   |- multivalued subfields

--- Comment #1 from Jonathan Druart  ---
Paola,
This is the expected behavior.
In master (without bug 11319 and bug 11413), your action will delete *all*
650$x if at least one 650$x matches the condition (even 650$x from other 650
fields).

What you try to do is a special case (at least for the code), you want to
delete/update/move a multivalued subfield containing a specific value.

This special could be take into account later, but it is not in my todo list
for now.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10402] Add multiple contacts for vendors

2014-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402

Paola Rossi  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #67 from Paola Rossi  ---
I've tried to apply against master 3.17.00.009

Applying: Bug 10402 follow-up: choose contacts for claims
Using index info to reconstruct a base tree...
Falling back to patching base and 3-way merge...
Auto-merging t/db_dependent/Letters.t
CONFLICT (content): Merge conflict in t/db_dependent/Letters.t
Auto-merging t/db_dependent/Bookseller.t
Auto-merging installer/data/mysql/updatedatabase.pl
CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl
Failed to merge in the changes.

So I've passed the patch to "Failed QA" status.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10402] Add multiple contacts for vendors

2014-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10402

Paola Rossi  changed:

   What|Removed |Added

 Status|Failed QA   |Patch doesn't apply

--- Comment #68 from Paola Rossi  ---
[I beg your pardon.]

I've tried to apply against master 3.17.00.009

Applying: Bug 10402 follow-up: choose contacts for claims
Using index info to reconstruct a base tree...
Falling back to patching base and 3-way merge...
Auto-merging t/db_dependent/Letters.t
CONFLICT (content): Merge conflict in t/db_dependent/Letters.t
Auto-merging t/db_dependent/Bookseller.t
Auto-merging installer/data/mysql/updatedatabase.pl
CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl
Failed to merge in the changes.

I've passed the patch to "Patch doesn't apply" status.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving

2014-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #28951|0   |1
is obsolete||

--- Comment #34 from Jonathan Druart  ---
Created attachment 29570
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29570&action=edit
BZ7677: New areas in subscriptions and new functions when receiving.

When enabling the makePreviousSerialAvailable syspref, the previously
 received serial's itemtype is set as defined in the subscription.
 (Please note that the item-level_itypes syspref must be set to specific item.)
 It is also made available.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving

2014-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #28952|0   |1
is obsolete||

--- Comment #35 from Jonathan Druart  ---
Created attachment 29571
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29571&action=edit
Bug 7677: FIX QA issues

FAILC4/Serials.pm
   FAIL  forbidden patterns
forbidden pattern: trailing space char (line 1501)
forbidden pattern: trailing space char (line 921)

 FAILserials/serials-edit.pl
   FAIL  valid
"my" variable $dbh masks earlier declaration in same scope

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving

2014-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #28953|0   |1
is obsolete||

--- Comment #36 from Jonathan Druart  ---
Created attachment 29572
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29572&action=edit
BZ7677 [Follow-up]: New areas in subscriptions and new functions when
receiving.

- Make the newly received serial gets its default itemtype from the
subscription.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving

2014-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677

--- Comment #37 from Jonathan Druart  ---
rebased patches (updatedatabase conflict).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12494] Remove yuipath system preference

2014-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12494

--- Comment #9 from Owen Leonard  ---
This patch doesn't touch the prog and ccsr templates because it is dependent on
their removal.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11575] OPACBaseURL sometimes set by ENV variable and not system preference

2014-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11575

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
 CC||jonathan.dru...@biblibre.co
   ||m

--- Comment #13 from Jonathan Druart  ---
(In reply to David Cook from comment #12)
> Should this be marked as Passed QA now?

Yes, sorry.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12542] New: Tabs inconsistency in different circ-menu.inc uses

2014-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12542

Bug ID: 12542
   Summary: Tabs inconsistency in different circ-menu.inc uses
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: tomasco...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

There is a high degree of inconsistency in the circulation tabs. Pick anyone
and some new will appear or dissapear.

To reproduce:
- Go to a user's detail page
- Change tab (the vertical ones).
- Notice that each time you choose another tab, some dissapear, some show.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12542] Tabs inconsistency in different circ-menu.inc uses

2014-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12542

Tomás Cohen Arazi  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |tomasco...@gmail.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12332] purchase-suggestions.pl tabs do not show selected

2014-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12332

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||tomasco...@gmail.com
Version|unspecified |master

--- Comment #9 from Tomás Cohen Arazi  ---
Patch pushed to master.

Thanks Viktor!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 1861] Unique patrons logins not (totally) enforced

2014-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1861

--- Comment #2 from Kyle M Hall  ---
Created attachment 29573
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29573&action=edit
Bug 1861 - Unique patrons logins not (totally) enforced

The Koha 3.0 patron admin page will prevent you from creating a user who
has an identical OPAC login as someone else (though I would change the
error message from "Login/password already exists." to "Login
already exists.", since it's not the password that's the
problem).

However, there's nothing enforced in the MySQL database to prevent
patrons from being imported or manually inserted with duplicate logins.
Would it be better to change the MySQL spec from this:
KEY `userid` (`userid`)
to this:
UNIQUE KEY `userid` (`userid`)

Test plan:
1) Enter mysql console
2) Attempt to create two borrowers with identical user id's
3) Note you are able to do so
4) Delete these bororwers
5) Apply this patch
6) Run updatedatabase.pl
7) Repeat step 2
8) Note you are now unable to do so

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 1861] Unique patrons logins not (totally) enforced

2014-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1861

Kyle M Hall  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
 CC||k...@bywatersolutions.com
   Assignee|gmcha...@gmail.com  |k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11575] OPACBaseURL sometimes set by ENV variable and not system preference

2014-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11575

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com

--- Comment #14 from Tomás Cohen Arazi  ---
Are we introducing problems for Plack?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12543] New: Add userid as matchpoint for "Import patrons" tool

2014-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12543

Bug ID: 12543
   Summary: Add userid as matchpoint for "Import patrons" tool
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Tools
  Assignee: gmcha...@gmail.com
  Reporter: k...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

The a patron's userid should be a matchpoint in the same manner as cardnumber.
Though not enforced as a unique key by the database yet ( pending bug 1861 ),
this field is effectively unique as uniqueness is enforced by Koha itself.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 1861] Unique patrons logins not (totally) enforced

2014-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1861

Kyle M Hall  changed:

   What|Removed |Added

 Blocks||12543

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12543] Add userid as matchpoint for "Import patrons" tool

2014-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12543

Kyle M Hall  changed:

   What|Removed |Added

 Depends on||1861

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12543] Add userid as matchpoint for "Import patrons" tool

2014-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12543

Kyle M Hall  changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11349] PROG/CCSR deprecation: Remove .tmpl -> .tt translation

2014-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11349

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com
   Assignee|oleon...@myacpl.org |tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11349] PROG/CCSR deprecation: Remove .tmpl -> .tt translation

2014-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11349

Tomás Cohen Arazi  changed:

   What|Removed |Added

Version|unspecified |master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12543] Add userid as matchpoint for "Import patrons" tool

2014-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12543

--- Comment #1 from Kyle M Hall  ---
Created attachment 29574
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29574&action=edit
Bug 12543 - Add userid as matchpoint for "Import patrons" tool

The a patron's userid should be a matchpoint in the same manner as
cardnumber. Though not enforced as a unique key by the database yet
( pending bug 1861 ), this field is effectively unique as uniqueness
is enforced by Koha itself.

Test Plan:
1) Apply this patch
2) Browse to tools/import_borrowers.pl
3) Download the starter CSV file
4) Edit the csv file to include 1 or more patrons
   * Make sure to leave the borrowernumber field empty
   * Make sure the userid field matches the patrons you wish to overwrite
5) From import_borrowers.pl, upload your file
   * Set "Field to use for record matching" to "Username"
   * Set "If matching record is already in the borrowers table" to "Overwrite
the existing one with this"
6) Click "Import"
7) Verify the patrons in your file have been updated in Koha

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12543] Add userid as matchpoint for "Import patrons" tool

2014-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12543

Kyle M Hall  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12541] Marc modification template - multivalued subfields

2014-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12541

--- Comment #2 from Paola Rossi  ---
Tx, Jonathan. 

For later works I add the following question about the form.
And in the end I add some cases.

I've applied the following actions (case of 'All" option):
--Delete field 650$x if 650$x matches RegEx m/ ^second 650 /
--Copy field 650$x to 650$y if 650$x matches RegEx m/ ^second 650 /
--Move field 650$x to 650$y if 650$x matches RegEx m/ ^second 650 /

and the following actions (case of "First" option):
--Delete 1st field 650$x if 650$x matches RegEx m/ ^second 650 /
--Copy 1st field 650$x to 650$y if 650$x matches RegEx m/ ^second 650 /
--Move 1st field 650$x to 650$y if 650$x matches RegEx m/ ^second 650 /

to my test biblio record.

No difference has appeared in the results between the corresponding "All/First"
actions.

The action "Add/Update" has no "All/First" option. [For example:
--Update field 650$x with value new-value-updated if 650$x matches RegEx m/
^second 650 / ]. 

So, no difference for all the 4 actions applying "All" or "First" option.

Is the "All/First" option not usefull? 
Is the form wrong?

In the action "Add/Update" the subfield before the "if" is mandatory.

It could be that the "All/First" option be not concerning the subfields [it
seemes so at least in cases of rep fields/rep subfields]

The "All/First" option is surely usefull for the fields. 

I think the page is not very friendly in some cases.

Perhaps, as for "Add/Update":

*** in case the user fills the subfield before the "if", the option "All/First"
could be hidden in COPY/MOVE/DELETE actions

*** otherwise, in case the user doesn't fill the subfield before the "if", the
option "All/First" is shown, concerning the fields only.

-
Another way could be change the order of the input fields in the form:

Delete/Copy/Add subfield ? of "All/First" field ? 
-
Or, perhaps, the fields could be shown in the form as mandatory
---
The 4 actions, run to my test biblio record, give the following results:

Delete field 650$x if 650$x matches RegEx m/ ^second 650 /

650  0 .
   _x1-650 x 1 Digital techniques 1
   _xfirst 650, second $x
   _x1-650 x 3 Digital techniques 3
650  0 _
650  0 _
_x3-650 x 1 Digital techniques 1
   _xthird 650, second $x
   _x3-650 x 3 Digital techniques 3

Copy field 650$x to 650$y if 650$x matches RegEx m/ ^second 650 /

650  0 _aSignal processing
   _x1-650 x 1 Digital techniques 1
   _xfirst 650, second $x
   _x1-650 x 3 Digital techniques 3
   _yfirst 650, second $x
650  0 _aImage processing
   _x2-650 x 1 Digital techniques 1
   _xsecond 650, second $x
   _x2-650 x 3 Digital techniques 3
   _yfirst 650, second $x
650  0 _x3-650 x 1 Digital techniques 1
   _xthird 650, second $x
   _x3-650 x 3 Digital techniques 3
   _yfirst 650, second $x

Update field 650$x with value new-value-updated if 650$x matches RegEx
m/ ^second 650 /

650  0 _aSignal processing
   _x1-650 x 1 Digital techniques 1
   _xfirst 650, second $x
   _x1-650 x 3 Digital techniques 3
650  0 _aImage processing
   _xnew-value-updated
   _xsecond 650, second $x
   _x2-650 x 3 Digital techniques 3
650  0 _x3-650 x 1 Digital techniques 1
   _xthird 650, second $x
   _x3-650 x 3 Digital techniques 3

Move field 650$x to 650$y if 650$x matches RegEx m/ ^second 650 / 

650  0 _aSignal processing
   _x1-650 x 1 Digital techniques 1
   _xfirst 650, second $x
   _x1-650 x 3 Digital techniques 3
   _yfirst 650, second $x
650  0 _aImage processing
   _yfirst 650, second $x
650  0 _x3-650 x 1 Digital techniques 1
   _xthird 650, second $x
   _x3-650 x 3 Digital techniques 3
   _yfirst 650, second $x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8773] Add per-instance koha-index-daemon in .deb setup

2014-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8773

--- Comment #45 from Martin Renvoize  ---
Created attachment 29575
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29575&action=edit
[SIGNED OFF] Bug 8773 - Start per-instance koha-index-daemon in .deb setup

Short:

Launch an indexing daemon (rebuild_zebra.pl -daemon) process for each
enabled instance. Enabling/disabling the use of the indexer is handled
by global configuration variables in /etc/default/koha-common.

Also provides command line tools to manage the running indexer daemons
for your instances.

Long:

Using an indexing daemon avoids launching a new interpreter each time
the cron triggers the indexing, and also allows sub-minute incremental
reindexing, a requirement from our librarians.[1]

Using the indexer daemon could remain "experimental" until it gets more
testing; so is disabled by default initially. To enable the use of the
indexer the user has to tweak the /etc/default/koha-common config file.
Specifically the USE_INDEXER_DAEMON variable, which is clearly explained
in the file.

Frecquency defaults to 5 sec, and can be changed by tweaking the
/etc/default/koha-common config file too.

This patch uses rebuild_zebra.pl in daemon mode, but it is crafted to
allow changing the indexing daemon and passing specific option switches
it might need.

Regards
To+

[1] This is the .deb version of
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8519

Sponsored-by: Universidad Nacional de Cordoba
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8773] Add per-instance koha-index-daemon in .deb setup

2014-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8773

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #29194|0   |1
is obsolete||

--- Comment #46 from Martin Renvoize  ---
Comment on attachment 29194
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29194
Bug 8773 - Start per-instance koha-index-daemon in .deb setup

Fantastic work Tomas, so glad to see this working it's way in!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8773] Add per-instance koha-index-daemon in .deb setup

2014-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8773

Martin Renvoize  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12287] Hold priority for new hold incorrect if record has holds in transit

2014-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12287

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@biblibre.co
   ||m

--- Comment #4 from Jonathan Druart  ---
Don't you think it's safer to test the 'T' value?
Something like

if ( defined $res->{found}
and ( $res->{found} eq 'W' or $res->{found} eq 'T' ) ) 
{   
$count--;
}

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10726] Default Unimarc framework in accordance with new edition of the Unimarc manual

2014-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10726

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

--- Comment #11 from Bernardo Gonzalez Kriegel  ---
Hi,
some conflicts :(

Auto-merging
installer/data/mysql/fr-FR/marcflavour/unimarc_complet/Obligatoire/framework_DEFAULT.sql
CONFLICT (content): Merge conflict in
installer/data/mysql/fr-FR/marcflavour/unimarc_complet/Obligatoire/framework_DEFAULT.sql
Auto-merging
installer/data/mysql/en/marcflavour/unimarc/mandatory/unimarc_framework_DEFAULT.sql
CONFLICT (content): Merge conflict in
installer/data/mysql/en/marcflavour/unimarc/mandatory/unimarc_framework_DEFAULT.sql

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8133] hourly loans doesn't know when library closed

2014-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8133

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com

--- Comment #11 from Kyle M Hall  ---
Maxime,

Is the patch a followup to Jesse's patches? Or an alternative solution? If it
is the latter, does it depend on bug 11211? I'm having a hard time applying
your patch to test!

Kyle

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12470] C4::Circulations.pm needs more unit tests

2014-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12470

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA
 CC||bgkrie...@gmail.com

--- Comment #4 from Bernardo Gonzalez Kriegel  ---
Yohann,
you need to swap this two lines on the two files.

$dbh->do(q|DELETE FROM items|);
$dbh->do(q|DELETE FROM issues|);

Both tests fails.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8133] hourly loans doesn't know when library closed

2014-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8133

--- Comment #12 from Blou  ---
I can help there.  I asked Maxime to provide an alternative solution to
Jesse's.
We've had this solution ready for over a year now, but put it aside with the
objective to use the community's instead (at that point Jesse had started
working on it)

Our solution is not as ambitious as Jesse's, and does not offer the same amount
of flexibility.  But it's available.  

And it was required for use to push our "minute loans" patch (see #11055).

I see that the old patches are still there, so this creates confusion. 
Maxime's patch is "standalone".  This provides a calendar, and the overdue
calculation function are modified to use the hours to determines the fines.

In short.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8133] hourly loans doesn't know when library closed

2014-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8133

--- Comment #13 from Blou  ---
And to be clear (after being short) I was not aware that #11211 had moved
forward (although still not through).

I suppose that long term, there is more benefit to go ahead with Jesse's
complete solution.  But some ETA would be nice...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12544] New: Send scheduled reports as an attachment

2014-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12544

Bug ID: 12544
   Summary: Send scheduled reports as an attachment
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Reports
  Assignee: gmcha...@gmail.com
  Reporter: p.thras...@dover.nh.gov
QA Contact: testo...@bugs.koha-community.org

Currently, a scheduled report is emailed with the report in the body of the
email.  If an option was added to allow the report to be sent as a .csv
attachment, then these reports could be more easily used in automated ways.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6427] Rewrite of the accounts system

2014-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427

Jesse Maseto  changed:

   What|Removed |Added

 CC||je...@bywatersolutions.com

--- Comment #425 from Jesse Maseto  ---
Kyle,

I think these patches need to be rebased.

-Jesse

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10877] Add "Order Record" processing

2014-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10877

Aaron Sakovich  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||asakov...@hmcpl.org

--- Comment #16 from Aaron Sakovich  ---
We've tested this extensively and have seen no problems with the upload and
automatic order generation.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11575] OPACBaseURL sometimes set by ENV variable and not system preference

2014-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11575

--- Comment #15 from Robin Sheat  ---
(In reply to Tomás Cohen Arazi from comment #14)
> Are we introducing problems for Plack?

Probably not. Really, OPACBaseURL should include the method so there's no need
for any of that $using_https crap. But that's a story for another day.

Also, as this promotes the use of the syspref over the envvar, it's probably
better for plack.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11575] OPACBaseURL sometimes set by ENV variable and not system preference

2014-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11575

--- Comment #16 from David Cook  ---
(In reply to Tomás Cohen Arazi from comment #14)
> Are we introducing problems for Plack?

I don't think so. Rather, we're highlighting an existing problem that Marcel
noted in bug 8952. (Marcel added the FIXME in bug 8952 and I'm just copying it
over to some relevant areas.)

I imagine that most people are using proxies in front of Plack so this might be
relevant for fixing this issue:
https://github.com/plack/Plack/wiki/How-to-detect-reverse-proxy-and-SSL-frontend

Plack::Middleware::ReverseProxy seems to just reset environmental variables
depending on the headers it gets from the reverse proxy (so long as they're
configured).

http://cpansearch.perl.org/src/MIYAGAWA/Plack-Middleware-ReverseProxy-0.15/lib/Plack/Middleware/ReverseProxy.pm

I suppose another alternative might be just to set the environmental variable
explicitly in the vhost (if you're using Apache) or whatever else you need to
with another proxy.

This may or may not be relevant: 

http://httpd.apache.org/docs/2.2/mod/mod_ssl.html

We don't use Apache for our proxy server, so I'm not really sure, but this info
might give other people (who are using Plack and a front end proxy) some ideas.

I haven't played with Plack yet but I've done a fair bit of reading.

By the way, here is the CGI->https() method from 5.16:

 Method: https
# Return the value of HTTPS, or
# the value of an HTTPS variable, or
# the list of variables

'https' => <<'END_OF_FUNC',
sub https {
my ($self,$parameter) = self_or_CGI(@_);
if ( defined($parameter) ) {
$parameter =~ tr/-a-z/_A-Z/;
if ( $parameter =~ /^HTTPS(?:_|$)/ ) {
return $ENV{$parameter};
}
return $ENV{"HTTPS_$parameter"};
}
return wantarray
? grep { /^HTTPS(?:_|$)/ } keys %ENV
: $ENV{'HTTPS'};
}
END_OF_FUNC

It looks like it's just looking for a HTTPS environmental variable, which
Plack::Middleware::ReverseProxy can provide. Otherwise, I suppose it depends on
how you've configured Plack?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12538] Solr removal

2014-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12538

--- Comment #5 from David Cook  ---
I wonder if Moose should be removed from C4/Installer/PerlDependencies.pm as
well? Was it used anywhere else but in the Solr stuff?

As for removing Solr code breaking ElasticSearch stuff, I'd love to hear Robin
weigh in. I imagine it might be an idea to keep the system preference (while
removing the Solr reference) and perhaps that's it. I imagine the search engine
switching in the current ES code could be updated to use a new model.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12538] Solr removal

2014-07-08 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12538

--- Comment #6 from Robin Sheat  ---
There's very little overlap between them really, I'd be more inclined to have
Jonathan remove everything, and I'll go through and un-revert the bits I want
to keep.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/