[Koha-bugs] [Bug 12111] Improving templates regarding order notes

2014-07-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12111

--- Comment #10 from Yohann Dufour  ---
Created attachment 29576
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29576&action=edit
Bug 12111: (follow-up) fix breadcrumbs wording for vendor note

As asked by QAer,
this followup fixes wording in modordernotes.tt for vendor note
(Change order vendor note vendor note => Change order vendor note)
It also uses [%- and -%] to make code more readable

Test plan :
try to edit a vendor note, check the wording is correct in breadcrumbs

Signed-off-by: Katrin Fischer 
Works as described, should be nicely translatable now.

Signed-off-by: Galen Charlton 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12470] C4::Circulations.pm needs more unit tests

2014-07-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12470

Yohann Dufour  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12470] C4::Circulations.pm needs more unit tests

2014-07-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12470

--- Comment #5 from Yohann Dufour  ---
Created attachment 29577
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29577&action=edit
Bug 12470: Allow execution of UTs on a DB with items (fix the order)

Fix of the order of the removal of items and issues

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12111] Improving templates regarding order notes

2014-07-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12111

Yohann Dufour  changed:

   What|Removed |Added

  Attachment #29576|1   |0
   is patch||
  Attachment #29576|0   |1
is obsolete||
 CC||yohann.duf...@biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12111] Improving templates regarding order notes

2014-07-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12111

--- Comment #11 from Yohann Dufour  ---
I'm sorry for the last comment, I've done a mistake with git bz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11226] Working with serials now requires admin (parameters) permission

2014-07-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11226

Fridolin SOMERS  changed:

   What|Removed |Added

 CC||fridolyn.som...@biblibre.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11226] Working with serials now requires admin (parameters) permission

2014-07-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11226

Jonathan Druart  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11226] Working with serials now requires admin (parameters) permission

2014-07-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11226

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #22878|0   |1
is obsolete||

--- Comment #4 from Jonathan Druart  ---
Created attachment 29578
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29578&action=edit
Bug 11226: subscription frequencies and numbering patterns should be editable
with serials permissions

Bug 7688 does now allow patrons with serials permissions to edit
 subscription frequencies/numbering patterns.

 Test plan:
 Try to access to serials/subscription-frequencies.pl and
 serials/subscription-numberpatterns.pl with the "serials" permissions.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11226] Working with serials now requires admin (parameters) permission

2014-07-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11226

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@biblibre.co
   ||m

--- Comment #5 from Jonathan Druart  ---
Sorry, I completely forgot this patch.
I resubmitted without the po changes.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11226] Working with serials now requires admin (parameters) permission

2014-07-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11226

Jonathan Druart  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |jonathan.dru...@biblibre.co
   |ity.org |m

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7149] authorized values for indicators don't work

2014-07-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7149

Josef Moravec  changed:

   What|Removed |Added

 CC||josef.mora...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12043] Popup when reserved item checked in at wrong branch should generate transfer slip

2014-07-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12043

M. de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12398] CAS authentication not working

2014-07-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12398

M. de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8735] Expire holds waiting only on days the library is open

2014-07-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8735

M. de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12395] Save order line's creator

2014-07-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

M. de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12294] Revert BZ9372

2014-07-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12294

M. de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12263] SIPServer does not respond correctly to signals

2014-07-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12263

M. de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl
   Patch complexity|--- |Small patch

--- Comment #4 from M. de Rooy  ---
Should the status of this report be already Passed QA?
Looking at the attachment name and two sign-offs..

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10308] Authorities linker should handle the "local subject added entry" fields.

2014-07-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10308

M. de Rooy  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11023] Toggle new status for items

2014-07-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11023

M. de Rooy  changed:

   What|Removed |Added

   Patch complexity|--- |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12407] phone label or data switched

2014-07-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12407

M. de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11904] Proposal for a uniform way to send messages to user interface

2014-07-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904

M. de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl
   Patch complexity|--- |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11319] Marc modification templates improvements

2014-07-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11319

M. de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl
   Patch complexity|--- |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11413] Marc modification template has not the expected behavior if the condition and source fields are on the same field

2014-07-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11413

M. de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl
   Patch complexity|--- |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10877] Add "Order Record" processing

2014-07-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10877

M. de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl
   Patch complexity|--- |Small patch
   Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9810] Search limit 'available' does not hide damaged or withdrawn items

2014-07-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9810

M. de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl
 QA Contact||m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11453] Update EN default UNIMARC bibliographic framework

2014-07-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11453

Fridolin SOMERS  changed:

   What|Removed |Added

 Blocks||10726

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10726] Default Unimarc framework in accordance with new edition of the Unimarc manual

2014-07-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10726

Fridolin SOMERS  changed:

   What|Removed |Added

 Depends on||11453

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7667] add a koha-setenv or an improved koha-foreach

2014-07-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7667

MJ Ray (software.coop)  changed:

   What|Removed |Added

 Resolution|WORKSFORME  |DUPLICATE

--- Comment #3 from MJ Ray (software.coop)  ---
koha-shell was added on 2012-12-20 (9 months after this report) for Bug 8878,
but thanks for tidying this up. Changing the resolution to match.

*** This bug has been marked as a duplicate of bug 8878 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8878] koha-shell: a command to make using koha commands easier

2014-07-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8878

MJ Ray (software.coop)  changed:

   What|Removed |Added

 CC||m...@software.coop

--- Comment #16 from MJ Ray (software.coop)  ---
*** Bug 7667 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9810] Search limit 'available' does not hide damaged or withdrawn items

2014-07-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9810

M. de Rooy  changed:

   What|Removed |Added

  Attachment #16402|0   |1
is obsolete||
  Attachment #28526|0   |1
is obsolete||

--- Comment #12 from M. de Rooy  ---
Created attachment 29579
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29579&action=edit
Bug 9810 - Search limit 'available' does not hide damaged or withdrawn items

Test Plan:
1) Perform a search that will return an a damaged item and a withdrawn item
   ( for simplicity, have those items be the only one on each record,
respectively )
2) Run the same search but limit to available items only
3) Note those items still appear in the search results
4) Apply this patch
5) Run the search again
6) Note the items no longer appear in the search results

Signed-off-by: Matthias Meusburger 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9810] Search limit 'available' does not hide damaged or withdrawn items

2014-07-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9810

--- Comment #13 from M. de Rooy  ---
Created attachment 29580
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29580&action=edit
Bug 9810 [Followup] - Hide items with notforloan < 0 when limiting to available
items

Not for loan statuses of less then 0 are considered 'unavailable' in
Koha parlance, whereas items with a not for loan status greater than 0
are considered available, but not checkout-able ( i.g. reference items ).

This should be taken into account by the availability filter.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9810] Search limit 'available' does not hide damaged or withdrawn items

2014-07-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9810

M. de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #14 from M. de Rooy  ---
Both patches work fine for me. But I wonder if the second patch will work for
UNIMARC. (I do not find notforloan in the record.abs of UNIMARC)
Could a UNIMARC user confirm this please?
No problems for qa tools.

Changing status to Failed QA for need of clarification.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10648] In records merge greatest field can not be added

2014-07-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10648

M. de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #24 from M. de Rooy  ---
Interesting: Status is Signed off, but all patches are obsolete.
Changing status to Failed QA.
Author or signer: Please correct.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9810] Search limit 'available' does not hide damaged or withdrawn items

2014-07-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9810

--- Comment #15 from M. de Rooy  ---
Small additional remark (apparently outside the scope of this report but
observed while testing it):
If I toggle the status of Available items and All items, the first time it
works but the second time it does no longer work. As you can see below, the
query contains kw: the second time, resulting in 0 hits.

First URL for limiting to available:
/cgi-bin/koha/catalogue/search.pl?q=london%20india%20%23relevance_dsc&sort_by=relevance_dsc&limit=available

Second URL:
/cgi-bin/koha/catalogue/search.pl?q=kw%3Alondon%20india%20%23relevance_dsc&sort_by=relevance_dsc&limit=available

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10648] In records merge greatest field can not be added

2014-07-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10648

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #23877|1   |0
is obsolete||
 CC||jonathan.dru...@biblibre.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12470] C4::Circulations.pm needs more unit tests

2014-07-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12470

--- Comment #6 from Bernardo Gonzalez Kriegel  ---
Hi Yohan, ready to be signed, works well :)

But... can you squash and resubmit?
Or add your fixes to first patch and obsolete last two.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10648] In records merge greatest field can not be added

2014-07-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10648

Jonathan Druart  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10648] In records merge greatest field can not be added

2014-07-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10648

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #23877|0   |1
is obsolete||

--- Comment #25 from Jonathan Druart  ---
Created attachment 29581
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29581&action=edit
Bug 10648 - In records merge greatest field can not be added

When merging 2 records (/cgi-bin/koha/cataloguing/merge.pl), the destination
record is build using the fields and subfields checked in source records.
When a field is checked, the javascript code searches in destination record a
field with a greater tag number to insert new field before.
When the new field tag number is greater than all existing field tag numbers,
the field is not added.

This patch corrects this by adding at end if no greater field tag number
exists. Also adds a sort of fields by tag number because all mergo code is
based on this.

Test plan :
- Add to a framework a repeatable field with the greater non existing tag
number. For example 998.
- Edit 2 records with this framework and add them a value in this tag.
- Put those records is a list
- Go to this list and check the two records
- Click on "Merge selected"
- Click on next
- Go to second source record
- Click on the greatest tag number. for example 998.
=> The field is added at the end of destination record

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10648] In records merge greatest field can not be added

2014-07-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10648

--- Comment #26 from Jonathan Druart  ---
(In reply to M. de Rooy from comment #24)
> Interesting: Status is Signed off, but all patches are obsolete.
> Changing status to Failed QA.
> Author or signer: Please correct.

The git-bz on sandboxes were not up-to-date, they were not able to sent
patches.
I added the signoff line on the last patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 4045] No check for maximum number of allowed holds from OPAC.

2014-07-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4045

--- Comment #68 from Kyle M Hall  ---
I see now that it did work for multi-holds in the past. Considering I started
this patch 2 years ago I'm not surprised I forgot ; )

(In reply to Christopher Brannon from comment #67)
> (In reply to Kyle M Hall from comment #66)
> > I don't think this should fail qa for not being a complete fix. A partial
> > fix is better than no fix at all!
> > 
> > Kyle
> > 
> > (In reply to Christopher Brannon from comment #65)
> > > Got the sandbox to work this time around.
> > > 
> > > The limit works great for individually placed holds, but still gives no
> > > warning and places holds over limit if holding multiple items.
> > > 
> > > Christopher
> 
> I respectfully disagree.  You placed the multi-hold as a test condition.
> 
> > 9) Attempt to place 3 or more holds as a multi-hold
> 
> The patch does not pass your test.  If the patch is only to test items
> placed on hold one at a time, then it works just fine.  I don't think this
> should pass, based on your parameters.
> 
> Christopher

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9810] Search limit 'available' does not hide damaged or withdrawn items

2014-07-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9810

--- Comment #16 from Jonathan Druart  ---
(In reply to M. de Rooy from comment #14)
> Both patches work fine for me. But I wonder if the second patch will work
> for UNIMARC. (I do not find notforloan in the record.abs of UNIMARC)
> Could a UNIMARC user confirm this please?

The notforloan index does not seem to exist, I confirm.
I added a patch for withdrawn and damaged indexes (see comment 6).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11349] PROG/CCSR deprecation: Remove .tmpl -> .tt translation

2014-07-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11349

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11349] PROG/CCSR deprecation: Remove .tmpl -> .tt translation

2014-07-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11349

--- Comment #1 from Tomás Cohen Arazi  ---
Created attachment 29582
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29582&action=edit
Bug 11349: Change .tmpl -> .tt in scripts using templates

Since we switched to Template Toolkit we don't need to stick with the
sufix we used for HTML::Template::Pro.

This patch changes the occurences of '.tmpl' in favour of '.tt'.

To test:
- Apply the patch
- Install koha, and verify that every page can be accesed

Regards
To+

P.S. a followup will remove the glue code.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11349] PROG/CCSR deprecation: Remove .tmpl -> .tt translation

2014-07-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11349

--- Comment #3 from Tomás Cohen Arazi  ---
Created attachment 29584
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29584&action=edit
Bug 11349: Make the QA script happy

This patch just adjusts several POD stuff, and in a few cases
reorganizes a hash definition in order to use spaces instead of tabs
for the QA script to be happy.

Nothing important, really. This patch series just changes '.tmpl' for
'.tt'.

Regards
To+

PS beware that running the koha-qa.pl script can take lots of time on this one
:-D

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11349] PROG/CCSR deprecation: Remove .tmpl -> .tt translation

2014-07-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11349

--- Comment #2 from Tomás Cohen Arazi  ---
Created attachment 29583
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29583&action=edit
Bug 11349: Remove unnecesary name translation

Since all scripts use the '.tt' sufix for template names
there's no need for and regexp that changes from '.tmpl'
to '.tt'.

Regards
To+

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12330] hide item types, collections, locations on advanced search if hidden by opachiddenitems

2014-07-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12330

M. de Rooy  changed:

   What|Removed |Added

  Attachment #28570|0   |1
is obsolete||
 CC||m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12330] hide item types, collections, locations on advanced search if hidden by opachiddenitems

2014-07-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12330

M. de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12330] hide item types, collections, locations on advanced search if hidden by opachiddenitems

2014-07-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12330

M. de Rooy  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12330] hide item types, collections, locations on advanced search if hidden by opachiddenitems

2014-07-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12330

--- Comment #13 from M. de Rooy  ---
Created attachment 29586
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29586&action=edit
Bug 12330: [QA Follow-up] Consistency between opac-search and staff client

In opac-search two regexes are added for the results of splitting the
pref AdvancedSearchTypes, allowing spaces before and after the names.
The same regexes should be added to catalogue/search.pl to have the
same behavior there.

Test plan:
Set AdvancedSearchTypes to "itemtypes  |  ccode |  loc " (no quotes).
Check OPAC and staff with and without this patch.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12330] hide item types, collections, locations on advanced search if hidden by opachiddenitems

2014-07-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12330

--- Comment #12 from M. de Rooy  ---
Created attachment 29585
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29585&action=edit
Bug 12330: OpacHiddenItems not affecting Advanced Search

This patch affects only the area displayed on Advanced Search
by setting the AdvancedSearchTypes OPAC system preference
accordingly. Prior to this patch, no filtering based on
OpacHiddenItems was done. This patch determines if itemtypes,
collections, or shelving locations are hidden and prevents
them from being shown.

TEST PLAN
-
 1) Back up your DB (always handy)
 2) Set the Searching system preference AdvancedSearchTypes to:
'itemtypes|ccode|loc' (without the single quotes).
 3) Set the OPAC system preference OpacHiddenItems to include the
lines:
 itype: [{list of itemtype codes separated by commas}]
 location: [{list of comma delimited shelving location codes}]
 ccode: [{list of comma delimited collection codes}]
Make sure to exclude one value for each, so there will be at
least one known thing on each tab.
 4) Open the OPAC.
 5) Click on 'Advanced Search'
-- three tabs appear: Itemtypes, Collection, Shelving location
-- Everything is visible
 6) Set the Searching system preference AdvancedSearchTypes to:
'itemtypes | ccode | loc' (without the single quotes).
 7) Refresh the OPAC.
-- There will be three tabs, but ugliness ensues.
 8) Apply the patch
 9) Refresh the OPAC.
-- You will see: Itemtypes, Collection, Shelving location
-- Only excluded values from OpacHiddenItems will be seen.
10) Run koha qa test tools

Signed-off-by: Nicole C. Engard 
All tests pass

Signed-off-by: Marcel de Rooy 
Small rewording in comment only.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12545] New: Add EditorConfig file to the source tree

2014-07-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12545

Bug ID: 12545
   Summary: Add EditorConfig file to the source tree
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Developer documentation
  Assignee: gmcha...@gmail.com
  Reporter: tomasco...@gmail.com
QA Contact: testo...@bugs.koha-community.org

It'd be usefull to have a .editorconfig [1] file, that enforces some of our
coding guidelines, in the source tree top level.

Those developers that have their editors configured to honour the file, will
benefit. Those that wouldn't use it, won't get bothered by the addition. So, a
harmless addition that would benefit those that are interested.

There are plugins for several major editors:
- Emacs
- Vim
- SublimeText
- and so on...

[1] http://editorconfig.org/

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12545] Add EditorConfig file to the source tree

2014-07-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12545

Tomás Cohen Arazi  changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12031] Task Scheduler not sending mail

2014-07-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12031

M. de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #25 from M. de Rooy  ---
QA Comment:
Supportdir does not exist in the standard koha-conf.xml. Referring to it in the
codebase does not look good.
I also see the hardcoded /usr/share/koha/bin. This is a package related
fallback, but will not work in other installs.

Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9810] Search limit 'available' does not hide damaged or withdrawn items

2014-07-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9810

--- Comment #17 from Kyle M Hall  ---
Jonathan, with no notforloan index, does the feature fail gracefully for
unimarc? That is, it may not resolve the issue, but it doesn't break anything.
If so, I think we can push the patch and file a separate bug to add the
notforloan index for unimarc users.

(In reply to Jonathan Druart from comment #16)
> (In reply to M. de Rooy from comment #14)
> > Both patches work fine for me. But I wonder if the second patch will work
> > for UNIMARC. (I do not find notforloan in the record.abs of UNIMARC)
> > Could a UNIMARC user confirm this please?
> 
> The notforloan index does not seem to exist, I confirm.
> I added a patch for withdrawn and damaged indexes (see comment 6).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9810] Search limit 'available' does not hide damaged or withdrawn items

2014-07-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9810

Kyle M Hall  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10877] Add "Order Record" processing

2014-07-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10877

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10877] Add "Order Record" processing

2014-07-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10877

--- Comment #17 from Jonathan Druart  ---
Comment on attachment 29406
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29406
Bug 10877 - Add "Order Record" processing

Review of attachment 29406:
 --> 
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=10877&attachment=29406)
-

::: C4/ImportBatch.pm
@@ +967,3 @@
>  =cut
>  
>  sub GetImportBatchRangeDesc {

You should provide unit test here, but it seems to be quite difficult here (no
test exists for this module).

::: acqui/addorderiso2709.pl
@@ +270,5 @@
>  my @serials  = $input->param('serial');
>  my @ind_tag   = $input->param('ind_tag');
>  my @indicator = $input->param('indicator');
> +
> +if ($is_order) {

Could you detail why you process these 4 fields?

@@ +295,5 @@
> +  GetMarcFromKohaField('items.itype');
> +push( @tags, $itype_field );
> +push( @subfields,$itype_subfield );
> +push( @field_values, $infos->{itype} );
> +warn "ITYPE: " . $infos->{itype};

useless warn

@@ +359,1 @@
>  

hum, good candidate for an hashref param.

@@ +450,5 @@
>  item_action => $item_action
>  );
>  batch_info($template, $batch);
> +
> +return \@list;

Why did you change this return?

::: installer/data/mysql/updatedatabase.pl
@@ +8565,5 @@
> +$dbh->do("ALTER TABLE import_batches ADD is_order BOOLEAN NOT NULL 
> DEFAULT '0' AFTER comments");
> +   print "Upgrade to $DBversion done (Bug 10877 - Add 'Order Record' 
> processing)\n";
> +   SetVersion ($DBversion);
> +
> +}

FAIL   pod
*** WARNING: =head2 without preceding higher level  in file
installer/data/mysql/updatedatabase.pl

Just add an blank line before =head1

::: koha-tmpl/intranet-tmpl/prog/en/includes/acquisitions-add-to-basket.inc
@@ +18,4 @@
>  From an external source
>   From a staged file
>  [% IF ( CAN_user_circulate ) %] href="/cgi-bin/koha/circ/reserveratios.pl?booksellerid=[% booksellerid 
> %]&basketno=[% basketno %]">From titles with highest hold 
> ratios[% END %]
> + From a staged 
> order file

Maybe should be put just after "from a staged file"?

::: koha-tmpl/intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt
@@ +145,5 @@
> +$("#checkAll").click();
> +
> +$("#all_budget_id").hide();
> +$('label[for="all_budget_id"]').hide();
> +[% END %]

I don't understand the trick here.
Please check because the behavior is buggy (try to check/uncheck "Show all
fund", the fund list will become empty).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12545] Add EditorConfig file to the source tree

2014-07-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12545

--- Comment #1 from Tomás Cohen Arazi  ---
Created attachment 29587
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29587&action=edit
Bug 12545: Add EditorConfig.org file to the source tree

This patch adds a .editorconfig file to the source tree, that
enforces some of our coding guidelines.

Some editors try to detect the desired configurations from the currently
opened file. As we have tons of old code that doesn't follow our current
coding guidelines, this can lead to unintended QA problmes.

To test:
- Apply the patch
- Verify the .editorconfig file is in the top-level directory
- See the .editorconfig file expresses our coding guidelines

Regards
To+

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12545] Add EditorConfig file to the source tree

2014-07-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12545

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10519] Suggestions: 'Organize by' and correct display of tab descriptions broken

2014-07-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10519

M. de Rooy  changed:

   What|Removed |Added

 QA Contact||m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12031] Task Scheduler not sending mail

2014-07-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12031

M. de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl
   Assignee|gmcha...@gmail.com  |l...@catalyst.net.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10519] Suggestions: 'Organize by' and correct display of tab descriptions broken

2014-07-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10519

M. de Rooy  changed:

   What|Removed |Added

   Assignee|katrin.fisc...@bsz-bw.de|a...@biblos.pk.edu.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9810] Search limit 'available' does not hide damaged or withdrawn items

2014-07-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9810

--- Comment #18 from Jonathan Druart  ---
(In reply to Kyle M Hall from comment #17)
> Jonathan, with no notforloan index, does the feature fail gracefully for
> unimarc?

I don't get an "internal server error", but the result list is empty.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10519] Suggestions: 'Organize by' and correct display of tab descriptions broken

2014-07-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10519

--- Comment #37 from M. de Rooy  ---
Will finish this QA soon.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12417] Koha::Borrower::Files.pm needs unit tests

2014-07-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12417

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

  Attachment #29152|0   |1
is obsolete||

--- Comment #5 from Bernardo Gonzalez Kriegel  ---
Created attachment 29588
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29588&action=edit
[SIGNED-OFF] Bug 12417: adding the units tests of the module
Koha::Borrower::Files.pm

The module Koha::Borrower::Files.pm was not tested

To test:
1/ Execute the command: prove t/db_dependent/Borrower_Files.t
2/ The command has to print:
t/db_dependent/Borrower_Files.t .. ok
All tests successful.
Files=1, Tests=23,  2 wallclock secs ( 0.04 usr  0.01 sys +  1.47 cusr  0.08
csys =  1.60 CPU)
Result: PASS

Signed-off-by: Bernardo Gonzalez Kriegel 
Squashed patches.
Now test pass
No koha-qa errors

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12417] Koha::Borrower::Files.pm needs unit tests

2014-07-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12417

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12417] Koha::Borrower::Files.pm needs unit tests

2014-07-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12417

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

  Attachment #29188|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12472] Unit Tests failing with "MySQL server has gone away"

2014-07-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12472

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@biblibre.co
   ||m

--- Comment #2 from Jonathan Druart  ---
I don't reproduce the error.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12457] The module C4::Members.pm needs more unit tests

2014-07-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12457

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||bgkrie...@gmail.com

--- Comment #3 from Bernardo Gonzalez Kriegel  ---
Second patch does not apply

fatal: sha1 information is lacking or useless (t/db_dependent/Members.t).
Repository lacks necessary blobs to fall back on 3-way merge.
Cannot fall back to three-way merge.
Patch failed at 0001 Bug 12457: Adding unit tests for the routines AddMessage,
GetMessages, GetMessagesCount, DeleteMessage, GetPendingIssues, GetAllIssues of
the module C4/Members.pm and modification of the routine GetAllIssues

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12470] C4::Circulations.pm needs more unit tests

2014-07-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12470

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

  Attachment #29189|0   |1
is obsolete||

--- Comment #7 from Bernardo Gonzalez Kriegel  ---
Created attachment 29589
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29589&action=edit
[SIGNED-OFF] Bug 12470: adding unit tests for the routines CheckValidBarCode
and CheckIfIssuedToPatron of the module C4::Circulation.pm

The routines CheckValidBarcode and CheckIfIssuedToPatron were not tested

Test plan:
1/ Apply the patch
2/ Execute : prove t/db_dependent/Circulation/CheckValidBarcode.t
t/db_dependent/Circulation/CheckIfIssuedToPatron.t
3/ The result of the command has to be a success without error or warning :
t/db_dependent/Circulation/CheckValidBarcode.t .. ok
t/db_dependent/Circulation/CheckIfIssuedToPatron.t .. ok
All tests successful.
Files=2, Tests=32,  3 wallclock secs ( 0.04 usr  0.01 sys +  2.88 cusr  0.17
csys =  3.10 CPU)
Result: PASS

Signed-off-by: Bernardo Gonzalez Kriegel 
Patches squashed
Tests pass, no koha-qa errors

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12470] C4::Circulations.pm needs more unit tests

2014-07-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12470

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

  Attachment #29577|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12470] C4::Circulations.pm needs more unit tests

2014-07-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12470

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12537] editions tab showing on bibs with more than one ISBN

2014-07-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12537

--- Comment #1 from Owen Leonard  ---
Correction: When a record has more than one ISBN it *sometimes* shows the
Editions tab and links to the same record. The reason why it only happens
sometimes is probably significant.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12470] C4::Circulations.pm needs more unit tests

2014-07-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12470

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

  Attachment #29321|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12522] Fatal database error when viewing Holds for Bib with no Items

2014-07-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12522

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

  Attachment #29464|0   |1
is obsolete||

--- Comment #4 from Bernardo Gonzalez Kriegel  ---
Created attachment 29590
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29590&action=edit
[SIGNED-OFF] Bug 12522 - Fatal database error when viewing Holds for Bib with
no Items

This patch fixes some potential SQL syntax errors, which can cause
fatal software errors in Koha when the environmental variable DEBUG
is on.

_TEST PLAN_

Before applying:

0) Ensure that you don't have "SetEnv DEBUG 1" in your Apache config
1) Create a new bib record
2) Click on the "Holds" tab before creating any items
3) Note the message "Cannot place hold: this record has no
items attached."

4) Add "SetEnv DEBUG 1" to your Apache config
5) Restart Apache
6) Refresh your page
7) Note the following Software Error: "DBD::mysql::st execute failed:
You have an error in your SQL syntax; check the manual that
corresponds to your MariaDB server version for the right syntax to
use near ')' at line 3 at /koha/lib/C4/Koha.pm line 835.

8) Apply the patch

9) Refresh your page
10) Note the message from Step 3

Thorough tester:

11) Remove "SetEnv DEBUG 1" from your Apache config, restart Apache,
and refresh your page. You should see the message from Step 3.

Signed-off-by: Bernardo Gonzalez Kriegel 
Error reproduced, patch fixes it.
Tested following test plan, no koha-qa errors.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12522] Fatal database error when viewing Holds for Bib with no Items

2014-07-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12522

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||bgkrie...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12420] syndetics content broken in bootstrap

2014-07-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12420

--- Comment #10 from Owen Leonard  ---
> Is that what this boils down to?

It boils down to I can't reproduce the problem with any of the ISBNs provided.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6499] OCLC # Indexing & Matching

2014-07-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6499

--- Comment #1 from Barton Chittenden  ---
Created attachment 29591
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29591&action=edit
Bug 6499 - OCLC # Indexing & Matching

etc/zebradb/marc_defs/marc21/biblios/record.abs
  Add 035$a, 035$z and 035 as zebra index 'OCLC-Number'

etc/zebradb/marc_defs/marc21/biblios/biblio-koha-indexdefs.xml
  Add 035$a, 035$z and 035 as zebra index 'OCLC-Number'

  Note that all changes were made via make_zebra_dom_cfg_from_record_abs;
  these changes were merged with the existing
  biblio-koha-indexdefs.xml. All changes in the file are a) logic
  adding OCLC-Number as a zebra index or b) Updates to line numbers
  in comments reflecting the current record.abs. All other changes
  made by make_zebra_dom_cfg_from_record_abs were discarded. See
  http://wiki.koha-community.org/wiki/MRenvoize/zebra#DOM_indexing.

etc/zebradb/marc_defs/marc21/biblios/biblio-zebra-indexdefs.xsl
  Reflects changes made by applying koha-indexdefs-to-zebra.xsl to
  biblio-koha-indexdefs.xml.

C4/Search.pm
  Add OCLC-Number to getIndexes()

etc/zebradb/ccl.properties
  Set OCLC-Number 1=1211

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6499] OCLC # Indexing & Matching

2014-07-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6499

Barton Chittenden  changed:

   What|Removed |Added

 CC||bar...@bywatersolutions.com

--- Comment #2 from Barton Chittenden  ---
Testing:

1) Make sure that you have a bib that has MARC21 035$a (and possibly also
035$z) populated.
2) Rebuild zebra: misc/migration_tools/rebuild_zebra.pl -x -b -z
3) Add the following to the intranetuserjs syspref:

$(document).ready(function(){
// Add OCLC Number to advanced search
if (window.location.href.indexOf("catalogue/search.pl") > -1) {
$(".advsearch").append('OCLC
Number');
}
}  

Do an advanced search, select OCLC Number from the search menu, then add the
OCLC Number in 035$a for the bib specified in step 1.

The advanced search should return that biblio record.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12546] New: Add 'OCLC Number' as search item for staff client and OPAC advanced search pages

2014-07-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12546

Bug ID: 12546
   Summary: Add 'OCLC Number' as search item for staff client and
OPAC advanced search pages
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Searching
  Assignee: gmcha...@gmail.com
  Reporter: bar...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

Zebra search index was added in Bug 6499. Need to modify

./koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-advsearch.tt
./koha-tmpl/opac-tmpl/prog/en/modules/opac-advsearch.tt
./koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/advsearch.tt

In order to add 'OCLC Number' as an option in advanced search in the OPAC and
staff client.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6499] OCLC # Indexing & Matching

2014-07-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6499

Barton Chittenden  changed:

   What|Removed |Added

 Blocks||12546

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12546] Add 'OCLC Number' as search item for staff client and OPAC advanced search pages

2014-07-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12546

Barton Chittenden  changed:

   What|Removed |Added

 Depends on||6499

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12546] Add 'OCLC Number' as search item for staff client and OPAC advanced search pages

2014-07-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12546

--- Comment #1 from Barton Chittenden  ---
Don't need to update

./koha-tmpl/opac-tmpl/prog/en/modules/opac-advsearch.tt

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11430] Search history: Delete selected lines

2014-07-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430

--- Comment #53 from Owen Leonard  ---
Created attachment 29592
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29592&action=edit
Bug 11430 [Follow-up] Search history: Delete selected lines

This follow-up for Bug 11430 makes some changes to the template to make
it more useful when JavaScript is turned off:

- Hide the toolbar containing select all/clear all links if JS is off
- Add buttons to submit the forms if the delete link in the toolbar is
  unavailable (or if the user has scrolled all the way to the bottom of
  a long list)

Also changed: Corrected indentation from 2-space to 4-space, added
comments to the markup to help document page structure; changed the
class of the delete link to match other similar interfaces.

Note: This patch contains whitespace changes. Please diff accordingly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11430] Search history: Delete selected lines

2014-07-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11430

Owen Leonard  changed:

   What|Removed |Added

 Status|Passed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10900] Incorrect calling conventions accessing C4::Context

2014-07-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10900

--- Comment #29 from M. Tompsett  ---
Even if 10589 and 10895 don't make it into Koha, I think this refactor/clean up
is still useful to do. There are some "works by mistake" changes in here.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11909] Fix hidelostitems, OpacHiddenItems total count, prog them facet display

2014-07-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11909

M. Tompsett  changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=8462

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8462] OpacHiddenItems and hidelostitems hide items, but query result count is off

2014-07-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8462

M. Tompsett  changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=11909

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6499] OCLC # Indexing & Matching

2014-07-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6499

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #3 from Katrin Fischer  ---
Hm, I am not happy with naming this index oclc-number - 035 is not only the
OCLC number, although it can contain one. For example in our database one 035
always contains the PPN - the unique identifier from our union catalog SWB.

035
A control number of a system other than the one whose control number is
contained in field 001 (Control Number), field 010 (Library of Congress Control
Number) or field 016 (National Bibliographic Agency Control Number).
(Repeatable) [a,z,6,8]

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6499] OCLC # Indexing & Matching

2014-07-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6499

--- Comment #4 from Katrin Fischer  ---
I think a better name might be other-control-number?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12538] Solr removal

2014-07-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12538

--- Comment #7 from David Cook  ---
(In reply to Robin Sheat from comment #6)
> There's very little overlap between them really, I'd be more inclined to
> have Jonathan remove everything, and I'll go through and un-revert the bits
> I want to keep.

+1

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12031] Task Scheduler not sending mail

2014-07-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12031

--- Comment #26 from Liz Rea  ---
Created attachment 29593
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29593&action=edit
QA followup 12031 - adding supportdir to koha-conf.xml

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12031] Task Scheduler not sending mail

2014-07-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12031

Liz Rea  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 3237] OpenID patron authentication

2014-07-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3237

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #4 from David Cook  ---
I was going to say that I'm doing work on OpenID...but I realized that I'm
actually working on "OpenID Connect Core 1.0" which is a veneer over OAuth2.0
rather than being an implementation of "OpenID Authentication 2.0".

I assume that you're talking about "OpenID Authentication 2.0".

In any case, I think that Koha needs a better API for handling external
authentication...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12547] New: Create better API for handling external authentication

2014-07-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12547

Bug ID: 12547
   Summary: Create better API for handling external authentication
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Authentication
  Assignee: gmcha...@gmail.com
  Reporter: dc...@prosentient.com.au
QA Contact: testo...@bugs.koha-community.org
CC: dpav...@rot13.org

At the moment, authentication is really handled all that consistently.

There is Auth_with_cas.pm, Auth_with_ldap.pm, and perhaps one day
Auth_with_Shibboleth.pm.

There is also Persona which relies on a DOM API and Javascript on some OPAC
pages. 

All of these different methods also hook into Auth.pm.

They all work but it's not really that easy to see how they work nor is it
straightforward to add new forms of external authentication.

I don't have a plan of how to improve C4::Auth::checkauth() or C4::Auth, but I
think it's worth thinking about. 

Obviously, it would require a ton of testing, but perhaps we could have
incremental improvements.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12031] Task Scheduler not sending mail

2014-07-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12031

--- Comment #27 from Liz Rea  ---
Should probably add that the last patch will only add the supportdir
configuration option for new installs.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12547] Create better API for handling external authentication

2014-07-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12547

David Cook  changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=3237

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 3237] OpenID patron authentication

2014-07-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3237

David Cook  changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=12547

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12547] Create better API for handling external authentication

2014-07-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12547

David Cook  changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=8446

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8446] Shibboleth authentication patch

2014-07-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446

David Cook  changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=12547

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >