[Koha-bugs] [Bug 12617] Koha should let admins to configure automatically generated password complexity/difficulty
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12617 Marc Véron changed: What|Removed |Added CC||ve...@veron.ch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11888] Random password suggestion does not work twice
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11888 --- Comment #10 from Juhani Seppälä --- (In reply to Katrin Fischer from comment #8) > Hi Juhani, thx for the patch. :) > > Just a note: Sometimes the length of the generated password is > minPasswordLength+1. It never seems to be shorter or longer and it happens > before and after the patch. Hi, I noticed this behaviour as well while looking at creating this small fix. As mentioned here: Bug 12617 (shameless ad), we've had some discussion at our library about being able to have more configuration choices with regards to patron passwords and I've done some preliminary work on changing the current custom password generation to use a cpan library for easy configurability and so forth. We also have a damning limitation with some of the appliances used by customers where the devices only have numeric keys for password input... Things I'm looking at: - Making generated password complexity configurable - Allow admins to enforce a separate password policy for regular patrons and employees (for example) I would be interested in hearing any thoughts related to this and whether any of this would be useful in the community (we have some specific requirements here after all). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043 --- Comment #60 from Katrin Fischer --- Created attachment 30186 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30186&action=edit [PASSED QA] Bug 9043: Add the dropdown check list jquery plugin in the license list. Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer Passes all tests and QA scipt. Note: - We might want to rename "Itemtypes" as it could also be locations or collections for a library. But I am not sure what would be a better name. - The font size and script of the new plugin created pull down seems a bit off and some styling to make it fit better into the page would be nice. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043 --- Comment #59 from Katrin Fischer --- Created attachment 30185 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30185&action=edit [PASSED QA] Bug 9043: [SIGNED-OFF] Changes to the advanced search page This patch adds 2 new sysprefs: OpacAdvSearchOptions and OpacAdvSearchMoreOptions. These sysprefs are multivalued and you can add or remove some elements on the adv search page. This patch allows to display/hide some entries in the advanced search page at the OPAC. On this way, it is possible to configure the search options to display. Test plan: 1/ Fill OpacAdvSearchOptions with Item types and Languages. Fill OpacAdvSearchMoreOptions with Item types, Languages and Location. On the advanced search page, verify the Location is only displayed for the "More options" view. 2/ Try different settings for these prefs 3/ Remove all entries for the OpacAdvSearchMoreOptions and verify that the "More options" does not displayed additional options. 4/ Remove all entries for the OpacAdvSearchOptions and verify that the "normal view" does not displayed any options. Note that this patch only affects the bootstrap theme. Signed-off-by: Koha Team Lyon 3 Signed-off-by: Jacek Ablewicz Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043 --- Comment #58 from Katrin Fischer --- Created attachment 30184 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30184&action=edit [PASSED QA] Bug 9043: [SIGNED-OFF] Add the dropdown check list jquery plugin Signed-off-by: Koha Team Lyon 3 Signed-off-by: Jacek Ablewicz Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043 Katrin Fischer changed: What|Removed |Added Attachment #29914|0 |1 is obsolete|| Attachment #29915|0 |1 is obsolete|| Attachment #29945|0 |1 is obsolete|| Attachment #29946|0 |1 is obsolete|| --- Comment #57 from Katrin Fischer --- Created attachment 30183 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30183&action=edit [PASSED QA] Bug 9043: [SIGNED OFF] Syspref improvement: add new type "multiple" This patch adds a new type "multiple" for syspref. This new type allows to select several values for one syspref. Signed-off-by: Koha Team Lyon 3 Signed-off-by: Jacek Ablewicz Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043 --- Comment #56 from Katrin Fischer --- There are 2 small things: - we might want to rename "Itemtypes" as it could also be locations or collections for a library. But I am not sure what would be a better name :( - the font size and script of the new plugin created pull down seems a bit off and some styling to make it fit better into the page would be nice. Overall this works as it should and I think those 2 small things could be resolved in a follow-up. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7560] SIP Self Checkout Ignoring Fines Thresholds for Not Being able to Check Out Books
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7560 Katrin Fischer changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com |ity.org | QA Contact|katrin.fisc...@bsz-bw.de|testo...@bugs.koha-communit ||y.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7560] SIP Self Checkout Ignoring Fines Thresholds for Not Being able to Check Out Books
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7560 Katrin Fischer changed: What|Removed |Added Assignee|k...@bywatersolutions.com |koha-b...@lists.koha-commun ||ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12568] Improve visibility of successful renewal via opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12568 --- Comment #14 from Katrin Fischer --- Created attachment 30182 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30182&action=edit [PASSED QA] Bug 12568 [QA Followup] - Use ':' as separator instead of '|' Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12568] Improve visibility of successful renewal via opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12568 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12568] Improve visibility of successful renewal via opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12568 Katrin Fischer changed: What|Removed |Added Attachment #30008|0 |1 is obsolete|| Attachment #30085|0 |1 is obsolete|| --- Comment #13 from Katrin Fischer --- Created attachment 30181 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30181&action=edit [PASSED QA] Bug 12568 - Improve visibility of successful renewal via opac Currently, when a patron renews an item via the opac, the only feedback the patron receives when a renewal is successful is an updated value for the due date of the item. This subtle indication of success may go unnoticed by some patrons. We should add a more prominent way to indicate an item was renewed successfully. Test Plan: 1) Apply this patch 2) From the OPAC, renew some items 3) Note the "Renewed!" message in the "Renew" column of the checkouts table Signed-off-by: Cathi Wiggins Signed-off-by: Katrin Fischer Passes tests and QA script. Makes successful renewals more visible to the user in the OPAC. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12613] Remove CGI::scrolling_list from koha2marclinks.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12613 Katrin Fischer changed: What|Removed |Added Attachment #30122|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 30180 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30180&action=edit [PASSED QA] Bug 12613: Remove CGI::scrolling_list from koha2marclinks.pl This patch removes all (2) instances from koha2marclinks.pl. Also changes dropdowns width on mapping editor, from an ugly ragged right to a fixed width view. To test: 1. Apply the patch 2. Go to Administration > Koha to MARC mapping 3. Pulldown in this view has been replaced, check for regressions: change table type and press Ok, verify you get Koha fields and tag/subfield appropriate for each table. 4. Now press 'Edit' on any field, go into mapping editor 5. Check that all pulldowns show tag/subtags relevant for each group ( 000s ... 900s ) 6. Check that current mapping is displayed correctly 7. Check for regressions: unmap, remap, press Ok, verify, change again. 8. If you can, check display of mapping editor on several browsers, just in case. Signed-off-by: Jonathan Druart I have tested with Firefox/Iceweasel only. Signed-off-by: Katrin Fischer Passes all tests and QA script. Also tested in Chromium. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12613] Remove CGI::scrolling_list from koha2marclinks.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12613 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12642] SMS.t requires a database
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12642 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12642] SMS.t requires a database
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12642 Katrin Fischer changed: What|Removed |Added Attachment #30177|0 |1 is obsolete|| --- Comment #7 from Katrin Fischer --- Created attachment 30179 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30179&action=edit [PASSED QA] Bug 12642: t/SMS.t should not be db dependent SMS.t should not dependent on the DB. Test plan: verify that prove t/SMS.t returns green even if the DB is not there. Signed-off-by: Robin Sheat Signed-off-by: Katrin Fischer Turned off MySQL, tests still pass. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12642] SMS.t requires a database
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12642 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Assignee|ch...@bigballofwax.co.nz|jonathan.dru...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12657] PROG/CCSR deprecation: Remove hard-coded theme from debian/* scripts
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12657 Robin Sheat changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12657] PROG/CCSR deprecation: Remove hard-coded theme from debian/* scripts
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12657 Robin Sheat changed: What|Removed |Added Attachment #30070|0 |1 is obsolete|| --- Comment #3 from Robin Sheat --- Created attachment 30178 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30178&action=edit Bug 12657 - remove references to prog and ccsr from the packages To test: * Build a package and install it, and verify that there are no errors. * Play around with koha-translate, listing, adding, and removing languages. Note: one reference to prog and ccsr remains in koha-translate. This is to allow it to remove any pre-existing translations on an upgrade. Note 2: prog translations are still being installed, I think this is due to the underlying translation system doing it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12443] Initial re-factoring of buildQuery
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12443 --- Comment #19 from Robin Sheat --- FYI, it fails in my squeeze chroot, but it passes in testing. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12642] SMS.t requires a database
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12642 Robin Sheat changed: What|Removed |Added Attachment #30076|0 |1 is obsolete|| --- Comment #5 from Robin Sheat --- Created attachment 30177 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30177&action=edit Bug 12642: t/SMS.t should not be db dependent SMS.t should not dependent on the DB. Test plan: verify that prove t/SMS.t returns green even if the DB is not there. Signed-off-by: Robin Sheat -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12642] SMS.t requires a database
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12642 Robin Sheat changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #6 from Robin Sheat --- Looks good to me, and a better solution than mine. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12167] datetime type casting issue regarding bug 7567
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12167 M. Tompsett changed: What|Removed |Added Attachment #30172|0 |1 is obsolete|| --- Comment #12 from M. Tompsett --- Created attachment 30175 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30175&action=edit Bug 12167 - Bad expected results and condition check for GetNewsToDisplay This corrected the results expected to a single array reference. It then determines that it is defined and an array reference. And lastly, correct the logic that was supposed to check for valid results. TEST PLAN - 1) Apply patch 1 and 2. 2) prove -v t/db_dependent/NewsChannels.t -- all tests should pass -- note the test changes to verify correctly what should be tested for. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12167] datetime type casting issue regarding bug 7567
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12167 M. Tompsett changed: What|Removed |Added Attachment #30173|0 |1 is obsolete|| --- Comment #13 from M. Tompsett --- Created attachment 30176 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30176&action=edit Bug 12167 - Clean up GetNewsToDisplay This bug started out as a result of busting while in transitions of MySQL were happening in Ubuntu. However, I figured this fix should remove backtick MySQLisms as per http://wiki.koha-community.org/wiki/Coding_Guidelines#SQL6:_Backticks And clean up GetNewsToDisplay a bit. TEST PLAN - 1) News should function fine before applying any patches. 2) Apply all patches. 3) prove -v t/db_dependent/NewsChannels.t -- expecting all happy results. -- note the removal of backticks and the assumed typecasting of a timestamp to date. -- specified opac_news.timestamp to make sure that it would more likely parse as a fieldname and not as a keyword. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12167] datetime type casting issue regarding bug 7567
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12167 M. Tompsett changed: What|Removed |Added Attachment #30171|0 |1 is obsolete|| --- Comment #11 from M. Tompsett --- Created attachment 30174 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30174&action=edit Bug 12167 - Invalid results check for opac_news test C4/NewsChannels.pm has a function GetNewsToDisplay at the end of the file. It returns an array reference (i.e. one result). t/db_dependent/NewsChannels.t has a test which expects two values. This is likely a cut and paste error on my part. Notice get_opac_news returns an array of two things. TEST PLAN - 1) prove -v t/db_dependent/NewsChannels.t -- magically the wrong condition still passes. 2) apply this first patch only. 3) prove -v t/db_dependent/NewsChannels.t -- notice the second result value is UNDEFINED. -- notice the first result is an array reference. -- and the last test passes, because unless somehow the array reference was less than 2, it will pass. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12167] datetime type casting issue regarding bug 7567
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12167 M. Tompsett changed: What|Removed |Added Attachment #27826|0 |1 is obsolete|| --- Comment #10 from M. Tompsett --- Created attachment 30173 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30173&action=edit Bug 12167 - Clean up GetNewsToDisplay This bug started out as a result of busting while in transitions of MySQL were happening in Ubuntu. However, I figured this fix should remove backtick MySQLisms as per http://wiki.koha-community.org/wiki/Coding_Guidelines#SQL6:_Backticks And clean up GetNewsToDisplay a bit. TEST PLAN - 1) News should function fine before applying any patches. 2) Apply all patches. 3) prove -v t/db_dependent/NewsChannels.t -- expecting all happy results. -- note the removal of backticks and the assumed typecasting of a timestamp to date. -- specified opac_news.timestamp to make sure that it would more likely parse as a fieldname and not as a keyword. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12167] datetime type casting issue regarding bug 7567
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12167 M. Tompsett changed: What|Removed |Added Attachment #27825|0 |1 is obsolete|| --- Comment #9 from M. Tompsett --- Created attachment 30172 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30172&action=edit Bug 12167 - Bad expected results and condition check for GetNewsToDisplay This corrected the results expected to a single array reference. It then determines that it is defined and an array reference. And lastly, correct the logic that was supposed to check for valid results. TEST PLAN - 1) Apply patch 1 and 2. 2) prove -v t/db_dependent/NewsChannels.t -- all tests should pass -- note the test changes to verify correctly what should be tested for. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12167] datetime type casting issue regarding bug 7567
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12167 --- Comment #8 from M. Tompsett --- Created attachment 30171 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30171&action=edit Bug 12167 - Invalid results check for opac_news test C4/NewsChannels.pm has a function GetNewsToDisplay at the end of the file. It returns an array reference (i.e. one result). t/db_dependent/NewsChannels.t has a test which expects two values. This is likely a cut and paste error on my part. Notice get_opac_news returns an array of two things. TEST PLAN - 1) prove -v t/db_dependent/NewsChannels.t -- magically the wrong condition still passes. 2) apply this first patch only. 3) prove -v t/db_dependent/NewsChannels.t -- notice the second result value is UNDEFINED. -- notice the first result is an array reference. -- and the last test passes, because unless somehow the array reference was less than 2, it will pass. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11230] Refactor C4::Stats::UpdateStats and add UT
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11230 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||tomasco...@gmail.com --- Comment #14 from Tomás Cohen Arazi --- Patches pushed to master. Thanks Mathieu! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12457] The module C4::Members.pm needs more unit tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12457 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA CC||katrin.fisc...@bsz-bw.de --- Comment #11 from Katrin Fischer --- I am sorry, but GetPendingIssues.t still fails for me: $ perl t/db_dependent/Members/GetPendingIssues.t 1..20 DBD::mysql::db do failed: Cannot delete or update a parent row: a foreign key constraint fails (`koha`.`items`, CONSTRAINT `items_ibfk_3` FOREIGN KEY (`holdingbranch`) REFERENCES `branches` (`branchcode`) ON UPDATE CASCADE) at t/db_dependent/Members/GetPendingIssues.t line 21. DBD::mysql::db do failed: Cannot delete or update a parent row: a foreign key constraint fails (`koha`.`items`, CONSTRAINT `items_ibfk_3` FOREIGN KEY (`holdingbranch`) REFERENCES `branches` (`branchcode`) ON UPDATE CASCADE) at t/db_dependent/Members/GetPendingIssues.t line 21. # Looks like your test exited with 255 before it could output anything. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12554] C4::Biblio GetMarcPrice does not handle NORMARC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12554 Katrin Fischer changed: What|Removed |Added Attachment #30152|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 30170 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30170&action=edit [PASSED QA] Bug 12554: Fix GetMarcPrice for NORMARC When doing aquisitions and ordering from external z3950 targes, the item price is not inferred from the MARC record when the NORMARC framework is set. This patch makes GetMarcPrice treat NORMARC the same as MARC21. Test plan * Setup Koha with NORMARC framework * Add a norwegian z3950 search target (ex: z3950.bibsys.no:2100, database=BIBSYS) * Create a new basket, and add order to basket from external source * Search for a tile (ex: ISBN 8205341834) from the bibsys z3950 server * Click to order the title * Observe that vendor price is not set * Apply patch, repeat search for same book * Order, and observe the vendor price is filled in from the MARC record http://bugs.koha-community.org/show_bug.cgi?id=12554 Signed-off-by: Bernardo Gonzalez Kriegel Works as described. No errors. Tested changing marcflavour syspref to NORMARC, and following test plan, bug exist and is fixed. Changed bug description on patch, too long :) Signed-off-by: Katrin Fischer Patch adds a check for NORMARC to provide the same functionality as for MARC21. No regressions found. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12554] C4::Biblio GetMarcPrice does not handle NORMARC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12554 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12570] Warnings in t/Biblio.t could be tested
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12570 Katrin Fischer changed: What|Removed |Added Attachment #30150|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 30169 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30169&action=edit [PASSED QA] Bug 12570: test for carped warnings in t/Biblio.t To test: - Run $ prove t/Biblio.t => Warnings printed to STDOUT - Apply patch - Run $ prove t/Biblio.t => No warnings Signed-off-by: Bernardo Gonzalez Kriegel No more warnings. No koha-qa errors Signed-off-by: Katrin Fischer Works as described. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12570] Warnings in t/Biblio.t could be tested
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12570 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12570] Warnings in t/Biblio.t could be tested
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12570 Tomás Cohen Arazi changed: What|Removed |Added Assignee|ch...@bigballofwax.co.nz|tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12445] C4::Suggestions.pm needs more unit tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12445 --- Comment #22 from Katrin Fischer --- Created attachment 30168 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30168&action=edit [PASSED QA] Bug 12445 [QA Followup] - Clear issues table before clearing borrrowers table Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer All tests pass, even more now than before. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12445] C4::Suggestions.pm needs more unit tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12445 --- Comment #21 from Katrin Fischer --- Created attachment 30167 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30167&action=edit [PASSED QA] Bug 12445: ading unit tests to test the routines : CountSuggestion, ConnectSuggestionAndBiblio, SearchSuggestion, GetSuggestionInfo, DelSuggestion, GetSuggestionByStatus These routines were not tested Test plan: 1/ Execute the command : prove t/db_dependent/Suggestions.t 2/ The result has to be a success without error or warning : t/db_dependent/Suggestions.t .. ok All tests successful. Files=1, Tests=89, 1 wallclock secs ( 0.05 usr 0.01 sys + 1.52 cusr 0.08 csys = 1.66 CPU) Result: PASS Signed-off-by: Paola Rossi Signed-off-by: Bernardo Gonzalez Kriegel Test pass, no koha-qa errors But now there are 91! prove t/db_dependent/Suggestions.t t/db_dependent/Suggestions.t .. ok All tests successful. Files=1, Tests=91, 2 wallclock secs ( 0.05 usr 0.00 sys + 1.77 cusr 0.10 csys = 1.92 CPU) Result: PASS Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12445] C4::Suggestions.pm needs more unit tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12445 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12445] C4::Suggestions.pm needs more unit tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12445 Katrin Fischer changed: What|Removed |Added Attachment #30096|0 |1 is obsolete|| Attachment #30097|0 |1 is obsolete|| Attachment #30098|0 |1 is obsolete|| --- Comment #20 from Katrin Fischer --- Created attachment 30166 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30166&action=edit [PASSED QA] Bug 12445: Improving unit tests for C4::Suggestions.pm Now, the tests used 'is' instead of 'ok', the tests are wrapped in a transaction, adding tests for the routines NewSuggestion, GetSuggestion, ModSuggestion, GetSuggestionFromBiblionumber and GetInfoFromBiblionumber. The tests for the routines DelSuggestionsOlderThan, CountSuggestion, ConnectSuggestionAndBiblio, SearchSuggestion, GetSuggestionInfo, DelSuggestion and GetSuggestionByStatus will be arrived in another patch. Test plan: 1/ Execute the command : prove t/db_dependent/Suggestions.t 2/ The result has to be a success without warning or error : t/db_dependent/Suggestions.t .. ok All tests successful. Files=1, Tests=32, 2 wallclock secs ( 0.03 usr 0.01 sys + 1.49 cusr 0.08 csys = 1.61 CPU) Result: PASS Signed-off-by: Paola Rossi Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7237] duplicating patron not using patron's branch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7237 Katrin Fischer changed: What|Removed |Added Attachment #30109|0 |1 is obsolete|| --- Comment #5 from Katrin Fischer --- Created attachment 30165 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30165&action=edit [PASSED QA] Bug 7237 - duplicating patron not using patron's branch When duplicating a patron the original patron's library should be preselected. To test, apply the patch and choose a patron to duplicate, noting which library is set as their home library. Click the "Duplicate" button and cnofirm that the patron's library is preselected on the patron entry form. Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer Works as described, no problems found. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7237] duplicating patron not using patron's branch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7237 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9221] contact note not showing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9221 Katrin Fischer changed: What|Removed |Added Attachment #30107|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 30164 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30164&action=edit [PASSED QA] Bug 9221 - contact note not showing The contents of the contact note field are not displayed on the patron detail page in the staff client. This patch corrects this. This patch also corrects the case of the "Contact note" label in the OPAC patron details form (Log in -> Your personal details). To test, apply the patch and edit a patron to add data to the contact note field. Save and view the detail page for that patron. The contents of the contact note field should appear under the alternate address data. In the OPAC the contact note field label should have correct capitalization. Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer Works as described. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9221] contact note not showing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9221 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4013] road type missing on search results
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4013 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA CC||katrin.fisc...@bsz-bw.de --- Comment #4 from Katrin Fischer --- Hm I think this isn't quite right. My AV ROADTYPE entry looks like this: STR Straße Straße The form allows me to select "Straße". So far so good. But then in the patron result list, STR is displayed. From the old database update I think that displaying the code is wrong here, as it should be a migrated numeric(?) id for older installations. +my $av_added = $dbh->do(q| +INSERT INTO authorised_values(category, authorised_value, lib, lib_opac) +SELECT 'ROADTYPE', roadtypeid, road_type, road_type +FROM roadtype; +|); The patron detail page displays the description. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11888] Random password suggestion does not work twice
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11888 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11888] Random password suggestion does not work twice
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11888 Katrin Fischer changed: What|Removed |Added Attachment #30146|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11888] Random password suggestion does not work twice
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11888 --- Comment #9 from Katrin Fischer --- Created attachment 30163 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30163&action=edit [PASSED QA] Bug 11888: Random password suggestion does not work twice This patch adds a simple ajax-call to pull a new suggested password from the same perl script. To test: 1) Search for a patron and select "Change password" from the moremember-view. 2) In the member-password-view, click on "Click to fill with a randomly generated suggestion". 3) Confirm that you get a new suggested password and click the same link again. 4) Note that you do not get another suggested password - nothing is happening. 5) Apply patch. 6) Repeat steps 1-3 and confirm that you can keep clicking for a new suggested password. Patch works as expected. Signed-off-by: Marc Véron Signed-off-by: Katrin Fischer Passes all tests and QA script. Works as desribed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11888] Random password suggestion does not work twice
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11888 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #8 from Katrin Fischer --- Hi Juhani, thx for the patch. :) Just a note: Sometimes the length of the generated password is minPasswordLength+1. It never seems to be shorter or longer and it happens before and after the patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7462] duplicate patron shows flags
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7462 Katrin Fischer changed: What|Removed |Added Attachment #30154|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 30162 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30162&action=edit [PASSED QA] Bug 7462 - duplicate patron shows flags When duplicating a patron the form fields for setting patron account flags and restrictions should be hidden as it is when adding a patron. This patch adds the correct logic to the template. To test, duplicate an existing patron: - Confirm that the "Patron account flags" and "Patron restrictions" sections are not visible. - Confirm that saving a duplicated patron works correctly. - Confirm that the edit and new patron entry forms are unaffected. Signed-off-by: Bernardo Gonzalez Kriegel Works ok, all three points confirmed No koha-qa errors Signed-off-by: Katrin Fischer Works as described, small template change. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7462] duplicate patron shows flags
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7462 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12600] Duplicated use statement in Search.pm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12600 Katrin Fischer changed: What|Removed |Added Attachment #30153|0 |1 is obsolete|| --- Comment #4 from Katrin Fischer --- Created attachment 30161 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30161&action=edit [PASSED QA] Bug 12600: remove duplicate use statement from code A use C4::Charset was added deep in the body of the code we have already imported it at the top of the file (the by convention normal place) As use is executed at compile time specifying it in the code body does not serve a useful purpose and detracts from the readability of an already overly complex subroutine. Remove the superfluous statement also removed the tabs introduced to the surrounding lines by the same commit Signed-off-by: Bernardo Gonzalez Kriegel Search still works, no errors. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12600] Duplicated use statement in Search.pm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12600 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12521] Arrangement of divs on opac-advsearch.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12521 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de, ||oleon...@myacpl.org Assignee|oleon...@myacpl.org |l...@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12660] Mispelling of Accomodation in two tools templates - in comments
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12660 --- Comment #3 from Katrin Fischer --- Created attachment 30160 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30160&action=edit [PASSED QA] Bug 12660:Correct mispelling of accomodate in comments View the file in your git checkout to see the misspelling of accomodate do the patch view the files again to see the correct spelling accommodate Patch behaves as expected. Signed-off-by: Marc Véron Signed-off-by: Katrin Fischer Fixes typos to correct spelling. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12660] Mispelling of Accomodation in two tools templates - in comments
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12660 Katrin Fischer changed: What|Removed |Added Attachment #30147|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12660] Mispelling of Accomodation in two tools templates - in comments
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12660 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA CC||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12560] Wrong capitalization on acquisition statistics page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12560 Katrin Fischer changed: What|Removed |Added Attachment #30132|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 30159 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30159&action=edit [PASSED QA] Bug 12560: Fixing capitalisation of Item Type To test: Go to reports>Statistics Wizard>Acquisition Notice item type has incorrect capitalisation Apply Patch Refresh page Notice it is now fixed Signed-off-by: Bernardo Gonzalez Kriegel Work as described koha-qa complains for a tab on line 220, fixed. Natali, don't forget to assign the bug to yourself :) Signed-off-by: Katrin Fischer Small change, no problems found :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12560] Wrong capitalization on acquisition statistics page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12560 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12562] Capitalization: 'Save Report' when saving a new SQL report
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12562 Katrin Fischer changed: What|Removed |Added Attachment #30133|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 30158 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30158&action=edit [PASSED QA] Bug 12562: fix capitalisation of Save Report button Test: go to reports and then create report from SQL the Save button has wrong capitalisaion of Report add patch refresh should see button being Saved report Signed-off-by: Bernardo Gonzalez Kriegel Work as described, no koha-qa errors Brian, don't forget to assign the bug to yourself and set patch complexity :) Signed-off-by: Katrin Fischer Small template change, no regressions found. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12562] Capitalization: 'Save Report' when saving a new SQL report
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12562 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12521] Arrangement of divs on opac-advsearch.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12521 --- Comment #4 from Liz Rea --- Not that I am aware of. Generally, a UX survey of the OPAC would be a good thing to do. Liz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12563] Capitalization: 'Set Status' on detail pages item's tab
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12563 Katrin Fischer changed: What|Removed |Added Attachment #30134|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 30157 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30157&action=edit [PASSED QA] Bug 12563: capitalisation on detail pages item's tab Test: go to a record in the catalog, go to detail page, switch to 'items' tab, look for the 2 'Set status' buttons, check capitalisation should be lower case for second word. Signed-off-by: Bernardo Gonzalez Kriegel Works as described, no koha-qa errors Evonne, assign the patch to yourself :) Signed-off-by: Katrin Fischer Small template change, no regressions found. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12563] Capitalization: 'Set Status' on detail pages item's tab
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12563 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12564] Capitalization: Buttons in inventory tool
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12564 Katrin Fischer changed: What|Removed |Added Attachment #30135|0 |1 is obsolete|| --- Comment #4 from Katrin Fischer --- Created attachment 30156 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30156&action=edit [PASSED QA] Bug 12564: Fixing capitalisation buttons in inventory tool To Test 1/ Do a search in the inventory tool - view capitalisation errors in lower Buttons 2/ Apply patch 3/ Redo search in the inventory tool 4/ Confirm capitalisation errors are fixed Signed-off-by: Bernardo Gonzalez Kriegel Work as described, no koha-qa errors Fixed capitalization (and typo) on patch bug description :) Karl, don't forget to assign the bug to yourself :) Signed-off-by: Katrin Fischer Small template change, no regressions found. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12564] Capitalization: Buttons in inventory tool
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12564 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7143] Bug for tracking changes to the about page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Katrin Fischer changed: What|Removed |Added Attachment #30151|0 |1 is obsolete|| --- Comment #149 from Katrin Fischer --- Created attachment 30155 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30155&action=edit [PASSED QA] Bug 7143: Add Prosentient Systems to contributing companies Better late than never to add the company name to the list of contributing companies. Signed-off-by: Bernardo Gonzalez Kriegel Entry added. No errors Signed-off-by: Katrin Fischer Tiny template addition, no problems. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7143] Bug for tracking changes to the about page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11140] Centralize all sending of email to one subroutine
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11140 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12167] datetime type casting issue regarding bug 7567
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12167 --- Comment #7 from Bernardo Gonzalez Kriegel --- Ok then. Would you mind to change test plan on both patches? I can sign them, but only as they change for good some code. But I see nothing as described in current test plan. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12635] Course reserves item list should use "Checked out" instead of "On Loan"
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12635 Katrin Fischer changed: What|Removed |Added Status|ASSIGNED|NEW -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12635] Course reserves item list should use "Checked out" instead of "On Loan"
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12635 Katrin Fischer changed: What|Removed |Added Status|In Discussion |ASSIGNED CC||katrin.fisc...@bsz-bw.de --- Comment #2 from Katrin Fischer --- I think the problem is a missing step-by-step that would be helpful for testers without knowledge of the course reserves module. I am switching back to new - in discussion is more for general disagreements about the approach of a fix or similar. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12634] JavaScript error in Bootstrap OPAC detail page if OPACPopupAuthorsSearch is enabled
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12634 Katrin Fischer changed: What|Removed |Added Status|ASSIGNED|NEW -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12634] JavaScript error in Bootstrap OPAC detail page if OPACPopupAuthorsSearch is enabled
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12634 Katrin Fischer changed: What|Removed |Added Status|In Discussion |ASSIGNED CC||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12294] Revert BZ9372
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12294 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||tomasco...@gmail.com --- Comment #6 from Tomás Cohen Arazi --- Patch pushed to master. Thanks Sophie! Note: I'll add a reference to this in the release notes as Kyle proposed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
