[Koha-bugs] [Bug 12453] Do not use by default Host-Item-Number in UNIMARC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12453 Chris Cormack changed: What|Removed |Added Attachment #29040|0 |1 is obsolete|| --- Comment #2 from Chris Cormack --- Created attachment 30261 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30261&action=edit Bug 12453 - Do not use by default Host-Item-Number in UNIMARC Actually, in default UNIMARC install, 461$9 is indexed as Host-Item-Number, meaning it is used for analytical itemnumber. But most UNIMARC catalog use the analytical relation using unimarc_field_4XX.pl plugin on 461$a. In fact, this plugin is defined in default UNIMARC frameworks. If Host-Item-Number is defined but 461$9 is used for something else, it will lead to odd bugs. For example, records containing analytical items can not be deleted. This patch comments the 461$9 indexing in UNIMARC zebra config. Test plan : - Create a fresh UNIMARC install - Create a record with 461$9 containing a value - Index the record - Perform a search on Host-Item-Number : ccl=Host-Item-Number,alwaysmatches='' => Without the patch you get a result => With the patch you get no result Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12453] Do not use by default Host-Item-Number in UNIMARC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12453 Chris Cormack changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12615] Remove CGI::scrolling_list from marc_subfields_structure.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12615 Chris Cormack changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12615] Remove CGI::scrolling_list from marc_subfields_structure.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12615 Chris Cormack changed: What|Removed |Added Attachment #30131|0 |1 is obsolete|| --- Comment #5 from Chris Cormack --- Created attachment 30260 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30260&action=edit Bug 12615: Remove CGI::scrolling_list from marc_subfields_structure.pl This patch removes all instances on this file. Also re-enable editor feature to show/change kohafield value, can't find when or why it was removed. Up to QA or RM for consideration, simply to remove. But is strange to have a non editable field on auth frameworks. To test: 1. Apply the patch 2. Go to Administration > MARC frameworks 3. Clic MARC structure of any auth fw 4. Clic subfield on any tag, e.g. 020 5. Clic 'Edit subfields' button Now the tests proper 6. On any subfield, check pulldown 'Managed in tab', was replaced, so test if it works and search for regressions Change, save, load, change again 7. Clic on 'Advanced constraints' (2) scrolling list removed At the bottom, check 'Koha link', was changed Check assign/remove/save/load values, search for regressions 8. Clic on 'Other options' box Eight(6) scrolling_list removed, they use to feed three pulldowns, so check each one 'Authorised value', 'Thesaurus' 'Plugin' Check assign/remove/save/load values, search for regressions Check adding a new subfield Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12136] Problem in opac-topissues.pl if AdvancedSearchTypes has multiple values (separated by pipes)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12136 Marc Véron changed: What|Removed |Added Assignee|ve...@veron.ch |oleon...@myacpl.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9805] Lost items are un-lost if returned, but not if renewed.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9805 Marc Véron changed: What|Removed |Added CC||ve...@veron.ch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12528] Enable staff to deny message setting access to patrons on the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 Marc Véron changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||ve...@veron.ch Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12528] Enable staff to deny message setting access to patrons on the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 Marc Véron changed: What|Removed |Added Attachment #29505|0 |1 is obsolete|| -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12528] Enable staff to deny message setting access to patrons on the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12528 --- Comment #2 from Marc Véron --- Created attachment 30259 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30259&action=edit [Signed-off] Bug 12528 - Enable staff to deny message setting access to patrons on the OPAC This fix permits the staff to pull apart the access to patron message setting. Modified: installer/data/mysql/sysprefs.sql -OPACEnhancedMessagingPreferences preference added koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref -OPACEnhancedMessagingPreferences preference added koha-tmpl/opac-tmpl/bootstrap/en/includes/usermenu.inc -access to message setting changed Testing: I Apply the patch II Run updatedatabase.pl 0) Search OPACEnhancedMessagingPreferences preference; 1) Validate "OPACEnhancedMessagingPreferences show patron messaging setting on the OPAC (NOTE: EnhancedMessagingPreferences must be enabled)."; 2) Disable OPACEnhancedMessagingPreferences preference; 3) Enable EnhancedMessagingPreferences preference; 4) On the OPAC -> user's settings, validate "your messaging" is not showed. Patch behaves as expected Signed-off-by: Marc Véron -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12630] Prioritizing "Hold starts on date" -holds causes all other holds to be prioritized as well!
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12630
--- Comment #4 from Chris Cormack ---
Comment on attachment 29962
--> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29962
Bug 12630 - Prioritizing "Hold starts on date" -holds causes all other holds to
be prioritized as well!
Review of attachment 29962:
-->
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=12630&attachment=29962)
-
::: C4/Reserves.pm
@@ +1982,3 @@
> =cut
>
> sub _ShiftPriorityByDateAndPriority {
Doesn't make a lot of sense to leave this function name as it is, since it's
not doing anything with the date any more.
Also the POD is now wrong.
This also means that a hold with a newer date, will not be placed before older
date. Which is changing the functionality.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11577] [ENH] Automatic renewal feature
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 Chris Cormack changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11577] [ENH] Automatic renewal feature
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 --- Comment #55 from Chris Cormack --- Created attachment 30258 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30258&action=edit Bug 11577 : Fixing a tiny typo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11577] [ENH] Automatic renewal feature
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 Chris Cormack changed: What|Removed |Added Attachment #29974|0 |1 is obsolete|| --- Comment #53 from Chris Cormack --- Created attachment 30256 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30256&action=edit Bug 11577: Unit tests This patch fixes a few unit tests that broke because of the new feature. To test: 1) prove t/db_dependent/Circulation.t 2) prove t/db_dependent/Circulation_Issuingrule.t 3) prove t/db_dependent/Circulation_issue.t Sponsored-by: Hochschule für Gesundheit (hsg), Germany Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11577] [ENH] Automatic renewal feature
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 --- Comment #54 from Chris Cormack --- Created attachment 30257 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30257&action=edit Bug 11577: Add Hochschule für Gesundheit to contributing institutions Automatic renewal is the second feature sponsored by the hsg. Sponsored-by: Hochschule für Gesundheit (hsg), Germany Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11577] [ENH] Automatic renewal feature
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 Chris Cormack changed: What|Removed |Added Attachment #29973|0 |1 is obsolete|| --- Comment #52 from Chris Cormack --- Created attachment 30255 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30255&action=edit Bug 11577: Add an automatic renewal cronjob This patch adds a new cron script automatic_renewals.pl and a new entry in crontab.example. To test: 1) You need a few issues, some with automatic renewal and some without. 2) Confirm that each time you run misc/cronjobs/automatic_renewals.pl those issues are renewed that meet all of the following criteria: - automatic renewal has been scheduled either by issuing rule or by checkbox on the checkout page - the number of allowed renewals isn't exceeded - renewal isn't premature (No renewal before) 3) Confirm that all other issues are not affected. Sponsored-by: Hochschule für Gesundheit (hsg), Germany Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11577] [ENH] Automatic renewal feature
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 Chris Cormack changed: What|Removed |Added Attachment #29971|0 |1 is obsolete|| --- Comment #50 from Chris Cormack --- Created attachment 30253 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30253&action=edit Bug 11577: OPAC bootstrap theme changes This patch makes opac-user.pl and the bootstrap version of opac-user.tt handle the new renewal errors "auto_renew" and "auto_too_soon". To test: 1) Set global syspref "opacthemes" to bootstrap. 2) Set global syspref "OpacRenewalAllowed" to Allow. 3) Test the same things as in previous patch, this time for the OPAC summary page. Sponsored-by: Hochschule für Gesundheit (hsg), Germany Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11577] [ENH] Automatic renewal feature
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 Chris Cormack changed: What|Removed |Added Attachment #29970|0 |1 is obsolete|| --- Comment #49 from Chris Cormack --- Created attachment 30252 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30252&action=edit Bug 11577: Expand description of AllowRenewalLimitOverride With the introduction of the new automatic renewal feature global syspref AllowRenewalLimitOverride is expanded in meaning. It now gives the option to override blocks if: - the number of allowed renewals is exceeded - the renewal is premature (No renewal before) - the item is scheduled for automatic renewal - the renewal is premature and the item is scheduled for automatic renewal Sponsored-by: Hochschule für Gesundheit (hsg), Germany Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11577] [ENH] Automatic renewal feature
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 Chris Cormack changed: What|Removed |Added Attachment #29969|0 |1 is obsolete|| --- Comment #48 from Chris Cormack --- Created attachment 30251 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30251&action=edit Bug 11577: Add 'auto_renew' and 'auto_too_soon' to renewal page This patch adds the new renewal errors 'auto_renew' and 'auto_too_soon' to the renewal interface. To test: 1) Issue two items: - one with automatic renewal and no value for "No renewal before" - another with automatic renewal and a value for "No renewal before" 2) Try to renew: Home > Circulation > Renew 3) Confirm there are error messages explaining that the items have been scheduled for automatic renewal and that one of the renewals is also premature. 4) If global syspref AllowRenewalLimitOverride is set to "Allow" you should be given the option to override. Sponsored-by: Hochschule für Gesundheit (hsg), Germany Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11577] [ENH] Automatic renewal feature
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 Chris Cormack changed: What|Removed |Added Attachment #29972|0 |1 is obsolete|| --- Comment #51 from Chris Cormack --- Created attachment 30254 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30254&action=edit Bug 11577: OPAC prog theme changes This patch makes the prog version of opac-user.tt handle the new renewal errors "auto_renew" and "auto_too_soon". To test: 1) Set global syspref "opacthemes" to prog. 2) Test the same things as in previous patch. Sponsored-by: Hochschule für Gesundheit (hsg), Germany Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11577] [ENH] Automatic renewal feature
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 Chris Cormack changed: What|Removed |Added Attachment #29968|0 |1 is obsolete|| --- Comment #47 from Chris Cormack --- Created attachment 30250 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30250&action=edit Bug 11577: Code and intranet template changes This patch adds a checkbox for "Automatic renewal" to the checkout page. CanBookBeRenewed is modified to include two new errors: - auto_renew (renewal shouldn't be done manually) - auto_too_soon (renewal is premature and shouldn't be done manually) To test: 1) Add or edit an issuing rule with "Automatic renewal" and another one without it. 2) Issue at least three items: - automatic renewal by issuing rule - automatic renewal by Checkbox on the checkout page - no automatic renewal 3) Test the following steps for both: Home > Circulation > Checkouts Home > Patrons > Patron details 4) Confirm that issues with automatic renewal cannot be renewed manually, even if there are still renewals left and it's not too soon to renew. 5) Confirm that "Scheduled for automatic renewal" and the remaining renewals are displayed. If no renewals are left "Not renewable" should be displayed. 6) Confirm that issues without automatic renewal behave as usual. Sponsored-by: Hochschule für Gesundheit (hsg), Germany Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11577] [ENH] Automatic renewal feature
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 Chris Cormack changed: What|Removed |Added Attachment #29967|0 |1 is obsolete|| --- Comment #46 from Chris Cormack --- Created attachment 30249 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30249&action=edit Bug 11577: Add "Automatic renewal" to the circulation and fine rules This patch adds a column "Automatic renewal" to the circulation and fine rules table. To test: 1) Add or edit some issuing rules. 2) Confirm that "Automatic Renewal" is set to "No" by default and can be switched to "Yes". Sponsored-by: Hochschule für Gesundheit (hsg), Germany Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11577] [ENH] Automatic renewal feature
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11577 Chris Cormack changed: What|Removed |Added Attachment #29966|0 |1 is obsolete|| --- Comment #45 from Chris Cormack --- Created attachment 30248 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30248&action=edit Bug 11577: Add auto_renew flags to the database - issues.auto_renew - old_issues.auto_renew - issuingrules.auto_renew Default value is zero. To test: 1) Run installer/data/mysql/updatedatabase.pl 2) Create SQL reports like: SELECT * FROM issues LIMIT 0,1 3) Confirm that a column auto_renew was added to each of the three tables. Sponsored-by: Hochschule für Gesundheit (hsg), Germany Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12568] Improve visibility of successful renewal via opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12568 Chris Cormack changed: What|Removed |Added Status|Passed QA |Pushed by Module Maintainer CC||ch...@bigballofwax.co.nz --- Comment #15 from Chris Cormack --- Pushed to MM_OPAC/bug_12568 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12661] Capitalisation error for "Item Type" in prog/en/modules/help/reports/manager.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12661 --- Comment #4 from sandbo...@biblibre.com --- Created attachment 30247 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30247&action=edit Bug 12661: Fixing capitalisation from "Item Type" to "Item type" To fix go to help>reports>manager Find capitalisation error "Item Type" Change to "Item type" Signed-off-by: Aleisha -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12661] Capitalisation error for "Item Type" in prog/en/modules/help/reports/manager.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12661 sandbo...@biblibre.com changed: What|Removed |Added Attachment #30068|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12661] Capitalisation error for "Item Type" in prog/en/modules/help/reports/manager.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12661 sandbo...@biblibre.com changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||sandbo...@biblibre.com --- Comment #3 from sandbo...@biblibre.com --- Patch tested with a sandbox, by Aleisha -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12587] Improve output of filter information on patrons with the most checkouts report
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12587 --- Comment #3 from sandbo...@biblibre.com --- Created attachment 30246 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30246&action=edit Bug 12587 - Improve output of filter information on patrons with the most checkouts report This patch makes some changes to the way filter information is displayed after running the patrons with the most checkouts report. Before this patch several untranslatable English strings would be displayed, and library and item type codes would be shown instead of descriptions. To test, go to Reports -> Patrons checking out the most. Enter values for all the filter options: - Checkout date from - Checkout date to - Checkin date from - Checkin date to - Library - Item type - Patron category When you submit the form and view the results you should see your date submissions formatted according to your selected dateformat system preference. The library name and item type names should be shown instead of codes. Signed-off-by: Aleisha -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12587] Improve output of filter information on patrons with the most checkouts report
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12587 sandbo...@biblibre.com changed: What|Removed |Added Attachment #29762|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12587] Improve output of filter information on patrons with the most checkouts report
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12587 sandbo...@biblibre.com changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||sandbo...@biblibre.com --- Comment #2 from sandbo...@biblibre.com --- Patch tested with a sandbox, by Aleisha -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12619] Shipment date gets lost on finishing the invoice
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12619 sandbo...@biblibre.com changed: What|Removed |Added Attachment #29957|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12619] Shipment date gets lost on finishing the invoice
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12619 sandbo...@biblibre.com changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||sandbo...@biblibre.com --- Comment #3 from sandbo...@biblibre.com --- Patch tested with a sandbox, by Aleisha -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12619] Shipment date gets lost on finishing the invoice
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12619 --- Comment #4 from sandbo...@biblibre.com --- Created attachment 30245 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30245&action=edit Bug 12619 - Shipment date gets lost on finishing and/or editing the invoice To reproduce: - Create a new shipment, make sure to add a shipment date - Receive or not receive orders - Finish receiving with the button at the bottom of the page - Verify that shipment date is now empty To test: - reproduce the aforementioned issue - apply patch - confirm that the issue is no longer rerpoductible (= shipment date is not getting lost any longer), and that there are no apparent regresssions of any kind involving invoice shipment date entering and/or editing - sign off Signed-off-by: Aleisha -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10498] Place Hold on Order
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10498 Amit changed: What|Removed |Added Status|Failed QA |ASSIGNED --- Comment #10 from Amit --- Hi Tompsett, I am working on same will rebase patch and send. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937 M. Tompsett changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #35 from M. Tompsett --- Sorry, doesn't apply cleanly. Please rebase. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10900] Incorrect calling conventions accessing C4::Context
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10900 M. Tompsett changed: What|Removed |Added Attachment #27729|0 |1 is obsolete|| --- Comment #30 from M. Tompsett --- Created attachment 30243 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30243&action=edit Bug 10900 - Incorrect calling conventions accessing C4::Context There were multiple calling conventions for C4::Context's set_userenv routine. So the following commands were used to find discrepancies: grep "::set_userenv" `find .` grep "\->set_userenv" `find .` The first grep demonstrated that the smaller change is from :: to -> as only C4/Auth.pm, installer/InstallAuth.pm, and t/db_dependent/Circulation.t would need to be modified. This patch corrects C4::Context's set_userenv routine to be object call based (use ->) by using a shift to ignore the first parameter, and modify the three files found with :: calls. As the result of trying to roll a distribution, t/Circulation_barcodedecode.t was discovered to be faulty. The cause being incorrect parameters! This was hidden when there was no shift in the set_userenv routine. However, with its correction, the test broke. This led me to read the POD documentation for the function set_userenv in C4::Context and realize it was outdated as well. It has been revised to match the current version of the function. Then intentionally bad parameters passed to the set_userenv routine in C4::Context were hunted down. The biggest problems were missing surnames or branch names. REBASED Signed-off-by: Kyle M Hall Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10900] Incorrect calling conventions accessing C4::Context
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10900 M. Tompsett changed: What|Removed |Added Attachment #28183|0 |1 is obsolete|| --- Comment #31 from M. Tompsett --- Created attachment 30244 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30244&action=edit Bug 10900 - Follow up, since more has been added to master Booksellers.t and Koha_template_plugin_Branches.t both had function calls to ::set_userenv added to them. This patch handles those additions. TEST PLAN - 1) Branch a new git branch 2) prove -v t/db_dependent/Bookseller.t -- It should work. 3) prove -v t/db_dependent/Koha_template_plugin_Branches.t -- It should work. 4) Apply only the first patch. 5) Repeat steps 2 and 3. -- They should both FAIL! 6) Apply the second patch as well. 7) Repeat steps 2 and 3. -- The should both work. REBASED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12432] Saved reports tabs not working
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12432 sandbo...@biblibre.com changed: What|Removed |Added Attachment #30214|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12432] Saved reports tabs not working
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12432 --- Comment #5 from sandbo...@biblibre.com --- Created attachment 30242 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30242&action=edit Bug 12432 - Saved reports tabs not working In release 3.14.05.000 the tabs on the Saved Reports page worked correctly but after upgrading to 3.16.00.000 the tabs stop working. Visually the tabs change but the table of reports is not filtered. There are no errors reported in the browser console. Test Plan: 1) Attempt to filter saved reports by group tabs 2) Note no matter the tab you select, all reports appear 3) Apply this patch 4) Repeat step 1 5) Note the reports are now filtered correctly Signed-off-by: Christopher Brannon -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12432] Saved reports tabs not working
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12432 sandbo...@biblibre.com changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||sandbo...@biblibre.com --- Comment #4 from sandbo...@biblibre.com --- Patch tested with a sandbox, by Christopher Brannon -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10498] Place Hold on Order
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10498 M. Tompsett changed: What|Removed |Added CC||mtomp...@hotmail.com --- Comment #9 from M. Tompsett --- This needs a rebase/rework, because this no longer applies cleanly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10446] System preference maxoutstanding is poorly named
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10446 --- Comment #15 from M. Tompsett --- Sorry for an incomplete test plan, but I'm not sure how to use the offline circulation. But it should be similar to steps 2-6 elsewhere. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10446] System preference maxoutstanding is poorly named
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10446 M. Tompsett changed: What|Removed |Added Attachment #26618|0 |1 is obsolete|| CC||mtomp...@hotmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10446] System preference maxoutstanding is poorly named
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10446 M. Tompsett changed: What|Removed |Added Attachment #30239|0 |1 is obsolete|| --- Comment #14 from M. Tompsett --- Created attachment 30241 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30241&action=edit Bug 10446 - Follow up fix As per comment #11 by Jonathan Druart, I just fixed the items in question. Plus, I noted a typographical error in the updatedatabase.pl message (10466 vs. 10446) TEST PLAN - 1) Apply the patch 2) Ensure the Circulation system preference, AllowOfflineCirculation, is enabled. 3) Home -> Circulation -> Built-in offline circulation interface -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10446] System preference maxoutstanding is poorly named
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10446 --- Comment #13 from M. Tompsett --- Created attachment 30240 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30240&action=edit Bug 10446 - System preference maxoutstanding is poorly named The system preference 'maxoutstanding' is defined as the maximum amount of fees owed by the patron before Koha should block placing holds, but the name does not describe its behavior very well. String changes only, no functional changes made. Test Plan: 1) Apply patch 2) Run updatedatabase.pl 3) Verify the new system preference FeesBlockHoldsAmount's value matches the previous value of maxoutstanding. 4) Set FeesBlockHoldsAmount to $10 5) Attempt to place an OPAC hold for a patron owing less than $10 This attempt should succeed. 6) Attempt to place an OPAC hold for a patron owing more than $10 This attempt should fail Rebased by Mark Tompsett Signed-off-by: Srdjan -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10446] System preference maxoutstanding is poorly named
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10446 --- Comment #12 from M. Tompsett --- Created attachment 30239 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30239&action=edit Bug 10446 - Follow up fix As per comment #11 by Jonathan Druart, I just fixed the items in question. Plus, I noted a typographical error in the updatedatabase.pl message (10466 vs. 10446) TEST PLAN - 1) Apply the patch 2) Ensure the Circulation system preference, AllowOfflineCirculation, is enabled. 3) Home -> Circulation -> Built-in offline circulation interface -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12666] Offline Circulation has poor HTML
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12666 M. Tompsett changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12666] Offline Circulation has poor HTML
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12666 --- Comment #1 from M. Tompsett --- Created attachment 30238 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30238&action=edit Bug 12666 - Fix poor HTML from circ/offline.tt In koha-tmpl/intranet-tmpl/prog/en/modules/circ/offline.tt - Cleaned up the HTML's missing 's - Corrected the autobuffer attribute to the newer preload one - Added into empty title, since it will get replaced TEST PLAN - 1) Run the circ/offline.pl page source through an HTML validator -- should get a few warnings 2) Apply patch 3) Recheck page source (confirm your page isn't cached!) -- should be clean -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12666] New: Offline Circulation has poor HTML
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12666 Bug ID: 12666 Summary: Offline Circulation has poor HTML Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: mtomp...@hotmail.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com While attempting to generate a test plan for a patch for bug 10446 related to offline circulation, I noticed the HTML was poor. This cleans it up. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12627] SQLHelper replacement - C4::Suggestions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12627 Katrin Fischer changed: What|Removed |Added Status|Passed QA |Failed QA CC||katrin.fisc...@bsz-bw.de --- Comment #4 from Katrin Fischer --- I am sorry, but running the tests proved to be not enough. This patch breaks adding a suggestion from the staff interface (didn't test OPAC). DBIx::Class::Row::new(): No such column 'EUR' on Koha::Schema::Result::Suggestion at /home/katrin/kohaclone/C4/Suggestions.pm line 435 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12627] SQLHelper replacement - C4::Suggestions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12627 Katrin Fischer changed: What|Removed |Added Attachment #30095|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 30237 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30237&action=edit [PASSED QA] Bug 12627: SQLHelper replacement - C4::Suggestions With this patch, the subroutines NewSuggestion and ModSuggestion uses DBIx::Class instead of C4::SQLHelper. Moreover, the tests has been adapted to the values returned by DBIx::Class. Test plan: 1) Apply the patch 12445 in order to get the last unit tests for Suggestions 2) Apply the patch 3) Execute the unit tests by launching : prove t/db_dependent/Suggestions.t 4) The result has to be a success without error or warning : t/db_dependent/Suggestions.t .. ok All tests successful. Files=1, Tests=91, 2 wallclock secs ( 0.05 usr 0.01 sys + 1.65 cusr 0.09 csys = 1.80 CPU) Result: PASS Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer Tests pass, no problems found. Patch applies on top of bug 12445. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12627] SQLHelper replacement - C4::Suggestions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12627 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12597] Give better visual indication of currently-selected language in the staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12597 Marc Véron changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12597] Give better visual indication of currently-selected language in the staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12597 Marc Véron changed: What|Removed |Added Attachment #30224|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12597] Give better visual indication of currently-selected language in the staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12597 --- Comment #4 from Marc Véron --- Created attachment 30236 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30236&action=edit [Signed-off] Bug 12597 - Give better visual indication of currently-selected language in the staff client There is currently no visual feedback to the user reflecting which of multiple installed translations is currently selected. I think some necessary styling didn't make it into the conversion to Bootstrap menus. This patch attempts to improve things. Most of the changes are to bring back the previous style of highlighting the currently selected language. A new change is the addition of the sub-language code to the display of the menu label if one of that menu item's sub-languages is selected. This patch also removes some obsolete CSS which referred to the old menu system. To test, apply the patch and install or update multiple languages, including at least two sub-languages. In my test I used en, en-GB and de-DE. Clear your browser cache if necessary. Enable all these languages and test the functionality of the language selection menu in the footer. - Non-enabled languages should appear as non-bold links. - When a single language (with no sub-languages) is enabled it should appear as bold text. - When one of multiple sub-languages is enabled that selection in the pop-up menu should appear as bold text. The menu label should show in bold the language code of the selected sub-language. Tested with de-DE and de-CH, works as expected Signed-off-by: Marc Véron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12612] Remove CGI::scrolling_list from auth_tag_structure.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12612 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12612] Remove CGI::scrolling_list from auth_tag_structure.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12612 Katrin Fischer changed: What|Removed |Added Attachment #30125|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 30235 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30235&action=edit [PASSED QA] Bug 12612: Remove CGI::scrolling_list from auth_tag_structure.pl This patch removes the only instance in this file. Don't know if the feature is of some utility, seems that does not work (no use of auth values as indicators on MARC authority editor) To test: 1. Apply the patch 2. Go to Administration > Authority types 3. Clic on MARC structure of any fw 4. Clic Edit on any tag 5. On tag editor check the pulldown 'Authorised value', that was replaced 6. Check for regressions: select a value, save, verify the value, change again, etc. Note: removed a SELECT, using now C4::Koha::GetAuthorisedValueCategories Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer Works as expected, no regressions found. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12429] patron seeing fines codes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12429 Barton Chittenden changed: What|Removed |Added CC||bar...@bywatersolutions.com --- Comment #12 from Barton Chittenden --- Couple of small issues still need to be addressed: * The code 'FFOR' is still not expanded. * There is a space between the fine decription and the following comma, so Fine , To kill a mockingbird / 10/23/2013 23:59 View item To kill a mockingbird / should read Fine, To kill a mockingbird / 10/23/2013 23:59 View item To kill a mockingbird / -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12614] Remove CGI::scrolling_list from auth_subfields_structure.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12614 Katrin Fischer changed: What|Removed |Added Attachment #30130|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 30234 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30234&action=edit [PASSED QA] Bug 12614: Remove CGI::scrolling_list from auth_subfields_structure.pl This patch removes all instances on this file. Even removes some commented out instances. Also re-enable editor feature to show/change kohafield value, can't find when or why it was removed. Up to QA or RM for consideration, simply to remove. But is strange to have a non editable field on auth frameworks. To test: 1. Apply the patch 2. Go to Administration > Authority types 3. Clic MARC structure of any auth fw 4. Clic subfield on any tag, e.g. 031 5. Clic 'Edit subfields' button Now the tests proper 6. 'Help input' box (editor bottom): Eight(8) scrolling_list removed, they use to feed the four pulldowns, so check each one 'Koha field' is new (for me at last) 'Authorised value', 'Thesaurus' (is this valid/useful here?) 'Plugin' There is a difference between existing subtags and a new subtag, the 'id' of the pulldowns (so the 8 scrolling list removed) Check assign/remove/save/load values, search for regressions If you edit subtag 942, it has a value on kohafield (default fw) I think that this box could be prettified with fixed width for pulldowns. 7. No more functional tests, there are 4 scrolling_list removed that are commented (removed also commented code on tt file), and two instances that are similar to previously removed instances, evidently with no effect. Signed-off-by: Jonathan Druart Not sure about the new Koha field entry... All works as expected. Signed-off-by: Katrin Fischer All works as expected. About Koha field: I think it makes sense to have it in the form, so you can configure the fields for new authority types. In my database I have mappings on authtypecode and authid. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12614] Remove CGI::scrolling_list from auth_subfields_structure.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12614 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12457] The module C4::Members.pm needs more unit tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12457 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #13 from Katrin Fischer --- I am sorry Yohann, but this still fails for me: $ perl t/db_dependent/Members/GetAllIssues.t 1..16 DBD::mysql::db do failed: Cannot delete or update a parent row: a foreign key constraint fails (`koha`.`issues`, CONSTRAINT `issues_ibfk_1` FOREIGN KEY (`borrowernumber`) REFERENCES `borrowers` (`borrowernumber`) ON UPDATE CASCADE) at t/db_dependent/Members/GetAllIssues.t line 20. DBD::mysql::db do failed: Cannot delete or update a parent row: a foreign key constraint fails (`koha`.`issues`, CONSTRAINT `issues_ibfk_1` FOREIGN KEY (`borrowernumber`) REFERENCES `borrowers` (`borrowernumber`) ON UPDATE CASCADE) at t/db_dependent/Members/GetAllIssues.t line 20. # Looks like your test exited with 255 before it could output anything. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10276] Extend IndependentBranches to support groups of libraries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 --- Comment #60 from M. Tompsett --- Also, it fails to apply cleanly now. Make sure to rebase. :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8126] Funkiness with Patrons w/ Most Checkouts Report
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8126 Agnes Rivers-Moore changed: What|Removed |Added CC||a...@hanover.ca --- Comment #1 from Agnes Rivers-Moore --- Hanover Library (Ontario) - single library site. Confirming we get more than the requested number of responses from this report. Usually twice as many or close to twice as many rows in the report as expected. The later rows have very low checkout numbers, people with 1 to 4 checkouts only, so this is not simply the limit to x rows failing - it is including patrons that are not near the "top" users, and could possibly be the lowest users. I hope this may help figure out what is going on. Agnes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12630] Prioritizing "Hold starts on date" -holds causes all other holds to be prioritized as well!
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12630 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com --- Comment #3 from Kyle M Hall --- Is this the same as bug 10883? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043 --- Comment #63 from Katrin Fischer --- Hi Owen, thx for taking a look and finding this. I hope we find a solution that won't block the update. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9000] misc/cronjobs/rss/rss.pl uses HTP
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9000 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #29 from Martin Renvoize --- Happy to pass QA on this.. thanks so much for getting to this Kyle, and beating my team to sign-off Bernardo meaning I could QA. I took the initiative of taking Bernardo's patch straight to QA as it was simply a white-space fix to make git not complain ;) Go forth and push fair RM ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9000] misc/cronjobs/rss/rss.pl uses HTP
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9000 Martin Renvoize changed: What|Removed |Added Attachment #30221|0 |1 is obsolete|| --- Comment #26 from Martin Renvoize --- Created attachment 30231 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30231&action=edit [PASSED QA] Bug 9000 [3] - Change conf key from tmpl to template Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9000] misc/cronjobs/rss/rss.pl uses HTP
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9000 Martin Renvoize changed: What|Removed |Added Attachment #30222|0 |1 is obsolete|| --- Comment #27 from Martin Renvoize --- Created attachment 30232 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30232&action=edit [PASSED QA] Bug 9000 [4] - Update to GPL v3 Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9000] misc/cronjobs/rss/rss.pl uses HTP
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9000 Martin Renvoize changed: What|Removed |Added Attachment #30223|0 |1 is obsolete|| --- Comment #28 from Martin Renvoize --- Created attachment 30233 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30233&action=edit [PASSED QA] Bug 9000: Followup to fix tabs & closing TT directive Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9000] misc/cronjobs/rss/rss.pl uses HTP
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9000 Martin Renvoize changed: What|Removed |Added Attachment #30220|0 |1 is obsolete|| --- Comment #25 from Martin Renvoize --- Created attachment 30230 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30230&action=edit [PASSED QA] Bug 9000 [2] - Update included examples Signed-off-by: Bernardo Gonzalez Kriegel Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11703] Convert checkouts table to ajax datatable
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703 Kyle M Hall changed: What|Removed |Added Attachment #29472|0 |1 is obsolete|| Attachment #29473|0 |1 is obsolete|| Attachment #29474|0 |1 is obsolete|| Attachment #29475|0 |1 is obsolete|| Attachment #29476|0 |1 is obsolete|| Attachment #29477|0 |1 is obsolete|| Attachment #29478|0 |1 is obsolete|| Attachment #29479|0 |1 is obsolete|| Attachment #29480|0 |1 is obsolete|| Attachment #29493|0 |1 is obsolete|| --- Comment #183 from Kyle M Hall --- Created attachment 30228 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30228&action=edit Bug 11703 - Convert checkouts table to ajax datatable [3.16.x] When a patron has many checked out items, circulation.pl can take a very long time to load ( on the order of minutes in some cases ). This is primarily due to the processing of the previous checkouts list. If we convert to this table to a datatable that fetches its data via ajax, we can make circulation.pl far more responsive. The same should be done with relative's checkouts as well. Test Plan: 1) Apply this patch 2) Observe that the checkouts and relatives' checkouts tables are now loaded asynchronously 3) Observe and verify the renew and return actions are now ajax based and function in a manner equivilent to how they used to. This bug had quite a few followups, so I squashed all of them into one change so that code is easier to follow. Original commit messages are below: Bug 11703 - Use the ajax datatables on patron details page Bug 11703 - Convert holds tables to ajax datatables Bug 11703 [QA Followup 1] - Center bProcessing message over table Bug 11703 [QA Followup 2] - Remove icons from checkout and clear buttons Bug 11703 [QA Followup 3] - Remove references to UseTablesortForCirc Bug 11703 [QA Followup 4] - Add back in Today's checkouts/Previous checkouts rows Bug 11703 [QA Followup 5] Bug 11703 [QA Followup 6] - Move strings to an include file for translation purposes Bug 11703 [QA Followup 7] - Fix issues spotted by koha-qa.pl Bug 11703 [QA Followup 8] - Speed up api/checkouts.pl as much as possible Bug 11703 [QA Followup 9] - Move scripts from api directory to svc directory Bug 11703 [QA Followup 10] - Fix errors caused by rebase Bug 11703 [QA Followup 11] - Prevent multiple fetchs from ajax source Bug 11703 [QA Followup 12] - Fix problem detected by koha-qa.pl Bug 11703 [QA Followup 13] - Removed uneccessary data from renewal box during renewal Bug 11703 [QA Followup 14] - Fix table column span Signed-off-by: Dobrica Pavlinusic Signed-off-by: Katrin Fischer Passes all tests and QA script. Test plan on bug report: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11703#c98 Signed-off-by: Jonathan Druart Signed-off-by: Christopher Brannon Bug 11703 [QA Followup] * Bold record title, fix table width * Change output_pref_due to output_pref * Retain functionality of IssuesDefaultSortOrder system preferences * Use datatables.inc in circulation.tt * Fix up holds table details * Add plugin to about * fix relatives' checkouts * add too_many string * remove dead syspref from db * Sort relatives' checkouts and holds tables client side * Provide context for translation of strings * Fix unterminated string literal, add missing paren * Add replacement of _AUTHOR_ with title's author for holds * Format prices correctly * Format checkout dates correctly Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart Signed-off-by: Christopher Brannon Bug 11703 [QA Followup] - Use format instead of replace for string translation Signed-off-by: Jonathan Druart Signed-off-by: Christopher Brannon Bug 11703 [QA Followup] - Use interface instead of themelang for checkboxes plugin Signed-off-by: Jonathan Druart Signed-off-by: Christopher Brannon Bug 11703 [QA Followup] - Restore showing earliest renewal date for 'too early' renewals Signed-off-by: Jonathan Druart Signed-off-by: Christopher Brannon Bug 11703: (qa-followup) fix update database entry Signed-off-by: Jonathan Druart Signed-off-by: Christopher Brannon Bug 11703 [QA Followup] - Stop IE from caching ajax request Signed-off-by: Britta Cramer Signed-off-by: Christopher Brannon
[Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043 --- Comment #62 from Owen Leonard --- I haven't tested it but this looks interesting: http://wenzhixin.net.cn/p/multiple-select/docs/ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12529] Overdue notices do not respect holidays
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12529 --- Comment #8 from Kyle M Hall --- Created attachment 30227 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30227&action=edit Bug 12529 [QA Followup] - Remove trailing whitespace -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12529] Overdue notices do not respect holidays
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12529 Kyle M Hall changed: What|Removed |Added Attachment #30225|0 |1 is obsolete|| --- Comment #7 from Kyle M Hall --- Created attachment 30226 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30226&action=edit Bug 12529: Add a syspref to make overdue notices respect holidays Test Plan Set up some overdue triggers, for example 5,10,15 Set up some holidays Create some items that are past due (one due 5 days, 10 days ago etc) Run the overdue notices script (misc/cronjobs/overdue_notices.pl) Notice holidays are ignored Apply the patch, Switch the OverdueNoticeCalendar syspref to Use calendar Run the overdue notices again Notice holidays are now taken into account Sponsored-by: BSZ -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12529] Overdue notices do not respect holidays
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12529 Kyle M Hall changed: What|Removed |Added Attachment #29507|0 |1 is obsolete|| --- Comment #6 from Kyle M Hall --- Created attachment 30225 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30225&action=edit Bug 12529: Add a syspref to make overdue notices respect holidays Test Plan Set up some overdue triggers, for example 5,10,15 Set up some holidays Create some items that are past due (one due 5 days, 10 days ago etc) Run the overdue notices script (misc/cronjobs/overdue_notices.pl) Notice holidays are ignored Apply the patch, Switch the OverdueNoticeCalendar syspref to Use calendar Run the overdue notices again Notice holidays are now taken into account Sponsored-by: BSZ -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12194] Some fonts don't work on printing label
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12194 --- Comment #3 from Dobrica Pavlinusic --- After reading comments on bug 8375, I see what the problem is, so I will prepare patch for it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12597] Give better visual indication of currently-selected language in the staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12597 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12597] Give better visual indication of currently-selected language in the staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12597 --- Comment #3 from Owen Leonard --- Created attachment 30224 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30224&action=edit Bug 12597 - Give better visual indication of currently-selected language in the staff client There is currently no visual feedback to the user reflecting which of multiple installed translations is currently selected. I think some necessary styling didn't make it into the conversion to Bootstrap menus. This patch attempts to improve things. Most of the changes are to bring back the previous style of highlighting the currently selected language. A new change is the addition of the sub-language code to the display of the menu label if one of that menu item's sub-languages is selected. This patch also removes some obsolete CSS which referred to the old menu system. To test, apply the patch and install or update multiple languages, including at least two sub-languages. In my test I used en, en-GB and de-DE. Clear your browser cache if necessary. Enable all these languages and test the functionality of the language selection menu in the footer. - Non-enabled languages should appear as non-bold links. - When a single language (with no sub-languages) is enabled it should appear as bold text. - When one of multiple sub-languages is enabled that selection in the pop-up menu should appear as bold text. The menu label should show in bold the language code of the selected sub-language. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12597] Give better visual indication of currently-selected language in the staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12597 Owen Leonard changed: What|Removed |Added Status|Patch doesn't apply |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12597] Give better visual indication of currently-selected language in the staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12597 Owen Leonard changed: What|Removed |Added Attachment #29856|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9000] misc/cronjobs/rss/rss.pl uses HTP
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9000 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #30202|0 |1 is obsolete|| --- Comment #19 from Bernardo Gonzalez Kriegel --- Created attachment 30219 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30219&action=edit [SIGNED-OFF] Bug 9000 [1] - Update rss.pl to use Template Toolkit Signed-off-by: Bernardo Gonzalez Kriegel Tested using script with sample conf files RSS feeds generated are 'well formed' xml Some koha-qa errors fixed in followup -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9000] misc/cronjobs/rss/rss.pl uses HTP
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9000 Bernardo Gonzalez Kriegel changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9000] misc/cronjobs/rss/rss.pl uses HTP
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9000 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #30206|0 |1 is obsolete|| --- Comment #21 from Bernardo Gonzalez Kriegel --- Created attachment 30221 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30221&action=edit [SIGNED-OFF] Bug 9000 [3] - Change conf key from tmpl to template Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9000] misc/cronjobs/rss/rss.pl uses HTP
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9000 --- Comment #23 from Bernardo Gonzalez Kriegel --- Created attachment 30223 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30223&action=edit Bug 9000: Followup to fix tabs & closing TT directive -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9000] misc/cronjobs/rss/rss.pl uses HTP
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9000 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #30207|0 |1 is obsolete|| --- Comment #22 from Bernardo Gonzalez Kriegel --- Created attachment 30222 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30222&action=edit [SIGNED-OFF] Bug 9000 [4] - Update to GPL v3 Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9000] misc/cronjobs/rss/rss.pl uses HTP
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9000 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #30203|0 |1 is obsolete|| --- Comment #20 from Bernardo Gonzalez Kriegel --- Created attachment 30220 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30220&action=edit [SIGNED-OFF] Bug 9000 [2] - Update included examples Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9043] Adding system preferences to control the visibility of the content on the Advanced Search page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9043 Owen Leonard changed: What|Removed |Added Status|Passed QA |In Discussion --- Comment #61 from Owen Leonard --- I'm concerned about adding a jQuery plugin dependency that comes with this disclaimer: "DDCL IS NO LONGER ACTIVELY SUPPORTED It has not been rebuilt in over 2 years and is stuck on jQuery release 1.7. However, if anybody feels they can devote time to maintaining and developing DDCL, then feel free to get in contact." We are still in the process of updating or replacing existing plugins which block an upgrade of jQuery in Koha. I don't think it's a good idea to add another one. Are there any alternatives we could consider? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12398] CAS authentication not working
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12398 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com --- Comment #12 from Martin Renvoize --- Hmm.. bug 8952 and bug 11575, both pushed the master are doing 'stuff' to the prefix in opacbaseurl.. I think it worth looking at those here. For Shibboleth, it is recognised practice to throw away not https requests at the IdP end for security reasons.. so for this reason I've forced https in my patches there.. I don't know if that's the case for CAS but maybe worth considering. As for the bigger problem.. the two bugs above seem to come close at least to fixing that mentioned in bug 7770. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7710] multiple holds per title
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7710 Kyle M Hall changed: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7710] multiple holds per title
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7710 --- Comment #63 from Kyle M Hall --- That is correct, multiple bib-level holds, or multiple item-level holds on different items, but not multiple item-level holds on the same item. (In reply to David Cook from comment #58) > One quick question... > > The premise that that this patch will allow multiple holds per record per > borrower. > > Does that mean that they can place multiple item-level holds or multiple > bib-level holds or both? > > I assume it would just be multiple item-level holds, but I figured I would > ask anyway. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7710] multiple holds per title
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7710 Kyle M Hall changed: What|Removed |Added Attachment #27429|0 |1 is obsolete|| --- Comment #64 from Kyle M Hall --- Created attachment 30218 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30218&action=edit Bug 7710 - multiple holds per title Adds the ability to allow multiple holds on the same record for the same borrower. Adds new system preference MaxHoldsPerRecord, which controls how many holds one person can have on items for the same record. Test Plan: 1) Apply patch for Bug 9394 2) Apply this patch 3) Run updatedatabase.pl 4) Attempt to place 2 holds for the same patron on the same record, you should not be able to ( default is 1 per record ) 5) Set MaxHoldsPerRecord to 3 6) Attempt to place multiple holds for one patron on one record, you should be able to place 3 holds for one patron on a given record. A 4th hold should result in a message stating the patron has placed the max number of holds allowed on this record. Signed-off-by: Maxime Pelletier -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12194] Some fonts don't work on printing label
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12194 Dobrica Pavlinusic changed: What|Removed |Added Status|NEW |In Discussion --- Comment #2 from Dobrica Pavlinusic --- I can't reproduce this. I can only suspect that you are really missing all ttf definitions in koha-conf.xml, so I expanded this test to verify that all fonts are available on system. Can you give it a try? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12194] Some fonts don't work on printing label
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12194 --- Comment #1 from Dobrica Pavlinusic --- Created attachment 30217 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30217&action=edit Bug 12194 - add more tests for pdf creation When run with KEEP_PDF enviroment variable it will keep test.pdf for manual inspection. This can be used to verify that ttf font configuration is complete like: KEEP_PDF=1 KOHA_CONF=/etc/koha/sites/srvgit/koha-conf.xml prove t/Creators.t sample of utf-8 text, font name and type will be on bottom of second page -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12194] Some fonts don't work on printing label
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12194 Dobrica Pavlinusic changed: What|Removed |Added Assignee|cnighswon...@foundations.ed |dpav...@rot13.org |u | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11126] Make the holds system optionally give precedence to local holds
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11126 Kyle M Hall changed: What|Removed |Added Attachment #28181|0 |1 is obsolete|| --- Comment #19 from Kyle M Hall --- Created attachment 30215 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30215&action=edit Bug 11126 - Make the holds system optionally give precedence to local holds This feature will allow libraries to specify that, when an item is returned, a local hold may be given priority for fulfillment even though it is of lower priority in the list of unfilled holds. This feature has three settings: * LocalHoldsPriority, which enables the feature * LocalHoldsPriorityPatronControl, which selects for either tha patron's home library, or the patron's pickup library for the hold * LocalHoldsPriorityItemControl, which selects for either the item's holding library, or home library. So, this feature can "give priority for filling holds to patrons whose (home library|pickup library) matches the item's (home library|holding library)" Test Plan: 1) Apply this patch 2) Run t/db_dependent/Holds/LocalHoldsPriority.t Signed-off-by: Joel Sasse -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11126] Make the holds system optionally give precedence to local holds
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11126 Kyle M Hall changed: What|Removed |Added Attachment #28182|0 |1 is obsolete|| --- Comment #20 from Kyle M Hall --- Created attachment 30216 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30216&action=edit Bug 11126 [QA Followup] - Make reserves returned by _Findgroupreserve sorted by priority -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9000] misc/cronjobs/rss/rss.pl uses HTP
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9000 --- Comment #18 from Martin Renvoize --- Cheers for this Kyle, I've raised it with our guys to test and go forth and sign-off. Martin -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12432] Saved reports tabs not working
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12432 Kyle M Hall changed: What|Removed |Added Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12432] Saved reports tabs not working
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12432 Kyle M Hall changed: What|Removed |Added Hardware|PC |All Version|unspecified |master OS|Windows |All -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12432] Saved reports tabs not working
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12432 --- Comment #3 from Kyle M Hall --- Created attachment 30214 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30214&action=edit Bug 12432 - Saved reports tabs not working In release 3.14.05.000 the tabs on the Saved Reports page worked correctly but after upgrading to 3.16.00.000 the tabs stop working. Visually the tabs change but the table of reports is not filtered. There are no errors reported in the browser console. Test Plan: 1) Attempt to filter saved reports by group tabs 2) Note no matter the tab you select, all reports appear 3) Apply this patch 4) Repeat step 1 5) Note the reports are now filtered correctly -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12432] Saved reports tabs not working
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12432 Kyle M Hall changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
