[Koha-bugs] [Bug 12829] 020z not showing

2014-09-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12829

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@quecheelibrary.org

--- Comment #5 from Nick Clemens  ---
I am still getting a ";" if a field with 020$a is followed by a field with
020$z

Adding another field with 020$a does not add a doubled semicolon, and neither
does a second 020$z

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12790] Perl modules: Display required version numbers on about page

2014-09-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12790

Nick Clemens  changed:

   What|Removed |Added

  Attachment #31006|0   |1
is obsolete||

--- Comment #2 from Nick Clemens  ---
Created attachment 31331
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31331&action=edit
[SIGNED OFF] Bug 12790 - Perl modules: Display required version numbers on
about page

This patch adds information about required perl module versions to the 'About'
page.

To test:
Apply patch
In staff client, go to 'About', tab 'Perl modules'
The required version numbers should display in small print underneath the
module names.

Signed-off-by: Nick Clemens 

I might personally like the numbers better next to the installed version but in
parentheses or something similar, but this patch does add useful info

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12790] Perl modules: Display required version numbers on about page

2014-09-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12790

Nick Clemens  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12574] BiblioDefaultView doesn't affect XSLT results view

2014-09-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12574

Nick Clemens  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12574] BiblioDefaultView doesn't affect XSLT results view

2014-09-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12574

Nick Clemens  changed:

   What|Removed |Added

  Attachment #29684|0   |1
is obsolete||

--- Comment #7 from Nick Clemens  ---
Created attachment 31330
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31330&action=edit
[SIGNED OFF] Bug 12574 - BiblioDefaultView doesn't affect XSLT results view

The OPAC's XSLT results view does not respect the choice set in the
BiblioDefaultView system preference. This patch adds a check of the
preference to the OPAC's results view for MARC21.

To test you must have the OPAC configured to use the XSLT view for
search results. Perform any search and test the link to a title's detail
page. Switching the values of the BiblioDefaultView should be correctly
reflected in the search results links.

Signed-off-by: Nick Clemens 

Worked for me, search results did not respect setting before patch and did
after applying

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12845] C4::Output::FormatData is unused

2014-09-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12845

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@quecheelibrary.org

--- Comment #2 from Nick Clemens  ---
I am still getting one result:

nick@debian:~/koha$ git grep FormatData
C4/Output.pm:&output_html_with_http_headers
&output_ajax_with_http_headers &output_with_http_headers FormatData
FormatNumber

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12850] C4::Serials::GetLateIssues is not used

2014-09-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12850

Nick Clemens  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12850] C4::Serials::GetLateIssues is not used

2014-09-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12850

Nick Clemens  changed:

   What|Removed |Added

  Attachment #31274|0   |1
is obsolete||

--- Comment #2 from Nick Clemens  ---
Created attachment 31329
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31329&action=edit
[SIGNED OFF] Bug 12850: C4::Serials::GetLateIssues can be removed

This routine is not used and can be removed.

Test plan:
  git grep GetLateIssues
should not return any result

Signed-off-by: Nick Clemens 

Switched to a new branch 'bug_12850'
nick@debian:~/koha$ git grep GetLateIssues
C4/Serials.pm:  &ReNewSubscription  &GetLateIssues 
&GetLateOrMissingIss
C4/Serials.pm:=head2 GetLateIssues
C4/Serials.pm:@issuelist = GetLateIssues($supplierid)
C4/Serials.pm:sub GetLateIssues {
t/db_dependent/Serials.t:is(C4::Serials::GetLateIssues(), undef, 'test getting
l
nick@debian:~/koha$ git bz apply 12850
Bug 12850 - C4::Serials::GetLateIssues is not used

31274 - Bug 12850: C4::Serials::GetLateIssues can be removed

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 12850: C4::Serials::GetLateIssues can be removed
nick@debian:~/koha$ git grep GetLateIssues
nick@debian:~/koha$

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12833] Patron search no longer searches extended attributes

2014-09-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12833

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@quecheelibrary.org

--- Comment #5 from Nick Clemens  ---
I wasn't sure if you were redoing the patch after Kyle's comment or not,
current patch doesn't seem to change behavior, I can test again with new patch
when ready

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12632] Hold limits ignored for record level holds with item level itemtypes

2014-09-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12632

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@quecheelibrary.org

--- Comment #4 from Nick Clemens  ---
I tried testing but still seem to be able to place multiple record level holds.
 If I place an item level hold I can no longer place any more holds.


Test steps:
 - set item-level_itypes to "specific item" : AllowHoldPolicyOverride to 'Don't
Allow' : AllowOnShelfHolds to 'Allow'
 - created two records (of type music) each with one item (of type music)
 - added a circulation rule for all patrons of all libraries for item type
music to allow 1 hold
 - place a 'next available' hold on the first record for patron
 - attempt to place a hold on second record, no warning
 - apply patch
 - attempt to place a hold on second record, no warning
 - placed hold with no error
 - deleted both holds
 - place an item level hold on first record
 - attempt to place a hold on second record, "too many holds" warning and 'no
items available' warning and cannot place record or item specific hold.

Anything I am missing?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12849] Sending a list has malformed links

2014-09-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12849

Nick Clemens  changed:

   What|Removed |Added

  Attachment #31272|0   |1
is obsolete||

--- Comment #2 from Nick Clemens  ---
Created attachment 31328
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31328&action=edit
[SIGNED OFF] Bug 12849 - fix URLs in sent lists

This brings back the http(s) to the URLs in sent lists.

Test plan:
* make a list
* send it to yourself
* see that the URLs aren't clickable
* apply the patch
* repeat, except now the URLs are better

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12849] Sending a list has malformed links

2014-09-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12849

Nick Clemens  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12862] HTML fixes triggered by cleaning up language="javascript"

2014-09-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12862

--- Comment #4 from M. Tompsett  ---
I split up the prog and ccsr from the boot strap, so that this could
potentially be included as a backport.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12862] HTML fixes triggered by cleaning up language="javascript"

2014-09-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12862

M. Tompsett  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12862] HTML fixes triggered by cleaning up language="javascript"

2014-09-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12862

--- Comment #1 from M. Tompsett  ---
Created attachment 31325
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31325&action=edit
Bug 12862: Staff client tweaks related to obsolete language="javascript"

As a result, this patch removed the deprecated tag from the
intranet templates.

And since there was just 1 other tiny error in the same template
file, the checked="checked" was removed from a text box.

TEST PLAN
-
1) Install the HTML Validator 0.9.5.8 for FireFox.
2) Open Intranet to Home -> Tools -> News
3) View Page Source
   -- you'll notice the message about language="javascript" being
  one of the error messages.
4) Click Edit beside one of the news items.
5) View Page Source
   -- you'll notice the message about language="javascript" being
  one of the error messages.
6) Apply patch
7) Repeat steps 2 to 5 without "language="javascript" related
   error messages.
8) Run koha QA test tools.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12862] HTML fixes triggered by cleaning up language="javascript"

2014-09-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12862

--- Comment #3 from M. Tompsett  ---
Created attachment 31327
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31327&action=edit
Bug 12862: CCSR and Prog - language="javascript" is obsolete.

Corrected/removed the obsolete HTML.
Fixed a hard coded opac-tmpl, as per koha-qa's demand.

Trigger all the templates and check of the language="javascript"
error is listed in the validation done by the HTML Validator
plugin for FireFox that Owen pointed me at.

TEST PLAN
-
1) Test with opactheme set to ccsr. Any opac page with
   opac-bottom.inc will do.
2) Test with opactheme set to prog.
   - Any opac page with opac-bottom.inc
   - Any opac page with doc-head-close.inc
   - Advanced search
   - Authority search -> Submit -> View full heading -> MARC View
   - staff client, home, serials, submit by the title text box,
 click one of the subscriptions
 (you don't have subscriptions?! can't help you),
 determine the biblionumber, opac,
 search for the biblio number and get to an opac details page,
 click on more details
3) Test the self-checkout printslip, just like the bootstrap
   one previously.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12862] HTML fixes triggered by cleaning up language="javascript"

2014-09-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12862

--- Comment #2 from M. Tompsett  ---
Created attachment 31326
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31326&action=edit
Bug 12862: OPAC bootstrap - clean up language="javascript"

There was a 

[Koha-bugs] [Bug 12862] New: HTML fixes triggered by cleaning up language="javascript"

2014-09-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12862

Bug ID: 12862
   Summary: HTML fixes triggered by cleaning up
language="javascript"
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: trivial
  Priority: P5 - low
 Component: Browser compatibility
  Assignee: oleon...@myacpl.org
  Reporter: mtomp...@hotmail.com
QA Contact: testo...@bugs.koha-community.org

Tweak the 

[Koha-bugs] [Bug 6810] Send membership expiry reminder notices

2014-09-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810

--- Comment #22 from David Cook  ---
If you process the message queue, you'll notice that the to_address in the
database is updated after the email is sent.
C4::Letters::_send_message_by_email() and
C4::Letters::_update_message_to_address() take care of that.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6810] Send membership expiry reminder notices

2014-09-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810

David Cook  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #21 from David Cook  ---
(In reply to Owen Leonard from comment #20)
> > 5) Go to your koha database and check message_queue table you see some
> > results.
> 
> I confirm that the correct message has been added to the queue, but it
> doesn't contain an email address in the to_address column. Checking
> membership_expiry.pl it looks like it doesn't pass a "to_address" at all:
> 
> C4::Letters::EnqueueLetter( {  letter   => $letter,
> borrowernumber   =>  $recent->{'borrowernumber'},
> from_address   => $from_address,
> message_transport_type => 'email',
> } );

If I recall correctly, queued messages don't need a "to_address". When the
message is being sent via process_message_queue.pl, it will lookup the email
address using the borrowernumber and the "AutoEmailPrimaryAddress" system
preference.

Relevant subs are C4::Letters::SendQueuedMessages (in
process_message_queue.pl), and C4::Members::GetNoticeEmailAddress (within the
C4::Letters function calls).

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9352] Zebra indexes useless subfields in UNIMARC 7XX

2014-09-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9352

mathieu saby  changed:

   What|Removed |Added

 Status|Needs Signoff   |In Discussion

--- Comment #46 from mathieu saby  ---
The last patch is broken somewhere, please don't test

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12861] Noisy warns in C4/AuthoritiesMarc.pm

2014-09-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12861

Chris Cormack  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12861] Noisy warns in C4/AuthoritiesMarc.pm

2014-09-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12861

--- Comment #1 from Chris Cormack  ---
Created attachment 31324
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31324&action=edit
Bug 12861 : Noisy warn in the error logs

To test
Hit a url like
cgi-bin/koha/opac-authorities-home.pl?op=do_search&type=opac&operatorc=contains&marclistc=mainentry&and_orc=and&orderby=HeadingAsc&value=FIRECLAY

Notice the warns in the error log
Apply patch
Reload the url
Still works but no warns

(cherry picked from commit c98d805e490a82b2ea9f3d4e0f7278640942ba6d)
Signed-off-by: Chris Cormack 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12861] New: Noisy warns in C4/AuthoritiesMarc.pm

2014-09-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12861

Bug ID: 12861
   Summary: Noisy warns in C4/AuthoritiesMarc.pm
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: ch...@bigballofwax.co.nz
QA Contact: testo...@bugs.koha-community.org

If you hit a url like 
cgi-bin/koha/opac-authorities-home.pl?op=do_search&type=opac&operatorc=contains&marclistc=mainentry&and_orc=and&orderby=HeadingAsc&value=FIRECLAY

You will see a lot of this

opac-authorities-home.pl: Use of uninitialized value in string eq at
/usr/share/koha/lib/C4/AuthoritiesMarc.pm line 146,  line 522.

In the error logs

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12539] PROG/CCSR deprecation: Remove hardcoded theme from C4/Templates.pm

2014-09-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12539

Chris Cormack  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed by Module Maintainer

--- Comment #20 from Chris Cormack  ---
Pushed to MM_OPAC/theme_dep

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12860] New: Tools > Data export : "Don't export fields" option doesn't work

2014-09-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12860

Bug ID: 12860
   Summary: Tools > Data export : "Don't export fields" option
doesn't work
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Tools
  Assignee: gmcha...@gmail.com
  Reporter: francois.charbonn...@inlibro.com
QA Contact: testo...@bugs.koha-community.org

I have just tested the data export tool on master.

The option "Don't export fields" doesn't work for a field tag (ie 650) but
works for a subfield tag (ie 650a).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6810] Send membership expiry reminder notices

2014-09-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #20 from Owen Leonard  ---
> 5) Go to your koha database and check message_queue table you see some
> results.

I confirm that the correct message has been added to the queue, but it doesn't
contain an email address in the to_address column. Checking
membership_expiry.pl it looks like it doesn't pass a "to_address" at all:

C4::Letters::EnqueueLetter( {  letter   => $letter,
borrowernumber   =>  $recent->{'borrowernumber'},
from_address   => $from_address,
message_transport_type => 'email',
} );

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6810] Send membership expiry reminder notices

2014-09-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810

Owen Leonard  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #19 from Owen Leonard  ---
(In reply to David Cook from comment #16)
> (In reply to nicolas from comment #13)
> > The SysPref is present in the database (we looked for
> > MembershipExpiryDaysNotice in PHPMyAdmin), but not in the Administration
> > interface...
> 
> Are you sure? Again, I haven't applied the actual patch, but it looks like
> it should be in the Patrons tab in the Global System Preferences.

It is. Setting this back to "Needs signoff."

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11944] Cleanup Koha UTF-8

2014-09-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944

Martin Renvoize  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||martin.renvoize@ptfs-europe
   ||.com

--- Comment #246 from Martin Renvoize  ---
Agreed in Dev Meeting of 02/09/2014 to set status to Signed off..

Branch still maintained by Jonathan is the most up to date patch set.  We will
add Zeno and Paula's signoff attribute at the last minute ;)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12669] "Template process failed: undef error - Invalid local time for date in time zone"

2014-09-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12669

--- Comment #10 from Rolando Isidoro  ---
Hi Jonathan,

at first I also thought of the solution you proposed, but it seemed like a
small workaround that wouldn't address the real issue. In the cases I pointed
in this bug the dates didn't include time information (hours, minutes and
seconds), so why should koha validate them using timezones?

As Colin puts it: "floating should be default for day granularity". The
solution I presented fixes the issue and introduces this minor improvement.

Best regards,
Rolando Isidoro

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11926] Render community koha statistic usages

2014-09-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11926

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@biblibre.co
   ||m
   Assignee|julian.maur...@biblibre.com |jonathan.dru...@biblibre.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11887] Add script for collections agency reports

2014-09-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11887

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #31322|0   |1
is obsolete||

--- Comment #6 from Kyle M Hall  ---
Created attachment 31323
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31323&action=edit
Bug 11887 - Add script for collections agency reports

Some libraries use collections agencies such as Unique Management
Services to collection large unpaid balances owed to the library. It
would be helpful if Koha had a standard script to generate these
reports, rather than forcing each library to create their own solution.

This script is written following the guidelines for Unique Management
Systems. However, the reports it outputs should be useable by any
collections agency.

Test Plan:
1) Create the four required patron attributes
2) Create a patron who owes more then 5.00 in fees
3) Run the submission report
   account_collections.pl -r submission
   \ -mb 3 -bd $yesterday_iso -ed $tomorrow_iso -f 10
   \ -ft $fee_type -fd $fee_desc -c $can-collect-attribute-code
   \ -i $in-collections-attribute-code -l $last-updated-attribute-code
   \ -p previous-balance-attribute-code
4) Note the patron is now marked as in collections and has had the
   collections fee of 10.00 applied
5) Add a new fee to the patron's account
6) Run the update report with the same additional parameters
7) Verify the csv file generated contains that patron
8) Run the sync report with the same additional parameters
9) Note the csv file generated contains that patron

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11887] Add script for collections agency reports

2014-09-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11887

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #30208|0   |1
is obsolete||

--- Comment #5 from Kyle M Hall  ---
Created attachment 31322
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31322&action=edit
Bug 11887 - Add script for collections agency reports

Some libraries use collections agencies such as Unique Management
Services to collection large unpaid balances owed to the library. It
would be helpful if Koha had a standard script to generate these
reports, rather than forcing each library to create their own solution.

This script is written following the guidelines for Unique Management
Systems. However, the reports it outputs should be useable by any
collections agency.

Test Plan:
1) Create the four required patron attributes
2) Create a patron who owes more then 5.00 in fees
3) Run the submission report
   account_collections.pl -r submission
   \ -mb 3 -bd $yesterday_iso -ed $tomorrow_iso -f 10
   \ -ft $fee_type -fd $fee_desc -c $can-collect-attribute-code
   \ -i $in-collections-attribute-code -l $last-updated-attribute-code
   \ -p previous-balance-attribute-code
4) Note the patron is now marked as in collections and has had the
   collections fee of 10.00 applied
5) Add a new fee to the patron's account
6) Run the update report with the same additional parameters
7) Verify the csv file generated contains that patron
8) Run the sync report with the same additional parameters
9) Note the csv file generated contains that patron

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5342] Serial claiming improvements

2014-09-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5342

Paola Rossi  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA
 CC||paola.ro...@cineca.it

--- Comment #69 from Paola Rossi  ---
I've applied the patch against 3.17.00.017

At point:
4/ Verify the vendor list is correct ... You should not get any changes here.

After selecting "Download selected claims", the file had the right numbers of
rows, but no data filled the 4 fields SUPPLIER,TITLE,ISSUE NUMBER,LATE SINCE.
On the contrary the master is OK.

So I pass tha patch to "Failed QA" status.

NB.1) At points 10/ and 13/ the same error occurred: after selecting "Download
selected claims" no data filled the 4 fields SUPPLIER,TITLE,ISSUE NUMBER,LATE
SINCE of the file. Moreover, the increasing number in "Claims count" seemed
strange to me.

NB.2) The vendor can have multiple contacts details, then many different
emails: one of these might be set especially for "Contacts about late issues".
At point 9/ the message sent now by the patch is:
"This vendor has no email" 
But perhaps a message like this one could be used:
"This vendor has no email contacts about late issues"

NB.3) At point 10/ the patch sends the message:
"No email is configured for this account."
instead of the required:
"no email defined for your user". 
I don't know if this difference can bring any translation problem or any
difficulty to the users.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5572] refinements to function merge sub merge in C4::AuthoritiesMarc

2014-09-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5572

--- Comment #26 from Jacek Ablewicz  ---
Nice patch, quite usefull for our library particular needs as well..

Would it be possible to make this feature controllable by e.g. some system
preference (= disabled by default)? I have a feeling that chances for reaching
any agreement whenever such change would be "universally" good, or not good,
are close to nil; there are way too many different habits, approaches etc. in
various libraries regarding authority editing nad maintaining. But, I believe
that as long as this patch:

- does not by default introduce any changes to the existing behaviour,
- libraries willing to use it are made aware (e.g. by some kind of remark in
syspref description) that they should carefully review their existing authority
frameworks before enabling this feature, to prevent any possible "data loss" in
authority-controlled biblio fields,

all concerns indicated in previous comments will be sufficiently (?) addressed,
so it could hopefully get a promotion from "In Discussion" to "Needs Signoff"
;).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12205] It should be possible for Holds charges to count towards blocking checkout

2014-09-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12205

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||tomasco...@gmail.com

--- Comment #14 from Tomás Cohen Arazi  ---
Patch pushed to master.

Thanks Chris!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12705] News not possible for one sublanguage if two sublanguages are installed

2014-09-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12705

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||tomasco...@gmail.com

--- Comment #10 from Tomás Cohen Arazi  ---
Patch pushed to master.

Thanks Marc!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12205] It should be possible for Holds charges to count towards blocking checkout

2014-09-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12205

--- Comment #13 from Tomás Cohen Arazi  ---
Created attachment 31321
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31321&action=edit
Bug 12205: (regression tests) HoldsInNoissuesCharge controls
GetMemberAccountBalance behaviour regarding hold charges

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5572] refinements to function merge sub merge in C4::AuthoritiesMarc

2014-09-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5572

Jacek Ablewicz  changed:

   What|Removed |Added

 CC||a...@biblos.pk.edu.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.

2014-09-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

simith.dolive...@inlibro.com changed:

   What|Removed |Added

  Attachment #31301|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.

2014-09-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

--- Comment #9 from simith.dolive...@inlibro.com ---
Created attachment 31320
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31320&action=edit
Version rebased on current master - fixed columm name

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11566] Fixing accessibility on OPAC

2014-09-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11566

--- Comment #16 from Owen Leonard  ---
(In reply to Marc Véron from comment #14)

> So in my opinion it is better to be very careful about removing tags and
> rather to add a legend where the validator complains about missing legends

I think we need to use our best judgement in situations where a validator
complains. Is the lack of a legend on the fieldset around a submit button
really an accessibility problem, or is it just an item on a checklist?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5572] refinements to function merge sub merge in C4::AuthoritiesMarc

2014-09-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5572

Rafal Kopaczka  changed:

   What|Removed |Added

 CC||rkopac...@afm.edu.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12716] Import patrons form should have drop-downs for some values

2014-09-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12716

--- Comment #14 from Tomás Cohen Arazi  ---
(In reply to Jacek Ablewicz from comment #13)
>
> This script (tools/import_patrons.pl) is not exactly the easiest one to
> analyze comprehensivelly, but it seems that 'patron_attributes' was
> artifically added to @columnkeys as pseudo-colum name (= a kludge, as there
> is no such column in borrowers table); when that pseudo column is no longer
> in @columnkeys, apparently extended attributes are not being picked up at
> all from the relevant CSV field (?).
> 
> Follow up & proposed patch: in Bug 12859.

Well done Jaceck! Thanks a lot!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12716] Import patrons form should have drop-downs for some values

2014-09-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12716

Jacek Ablewicz  changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=12859

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12859] Patron import tool doesn't import extened attributes values any longer

2014-09-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12859

Jacek Ablewicz  changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=12716

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12716] Import patrons form should have drop-downs for some values

2014-09-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12716

--- Comment #13 from Jacek Ablewicz  ---
(In reply to Katrin Fischer from comment #12)
> Jacek, could you add an example line with the syntax you used in the import
> file too?

While I encountered this when trying to import patrons with somewhat more
complex entries in 'patron_attibutes' CSV field, eg.:

"""DPCODE:PK-B"",""HISCHANNR:B/000123; E/000123;
^/000123"",""KNTPAP:BPK"",""KNTPAP:BWM"",""PESEL:1234567890"",""SHOW_BCODE:1"""

extended atributes import seems to be broken as well for more trivial cases - I
did some tests in clean master with simpler 'patron_attributes'; same outcome.

Also, on the practical side, re-adding aforementioned 'if' solved the problem,
at least for me ;).

This script (tools/import_patrons.pl) is not exactly the easiest one to analyze
comprehensivelly, but it seems that 'patron_attributes' was artifically added
to @columnkeys as pseudo-colum name (= a kludge, as there is no such column in
borrowers table); when that pseudo column is no longer in @columnkeys,
apparently extended attributes are not being picked up at all from the relevant
CSV field (?).

Follow up & proposed patch: in Bug 12859.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12859] Patron import tool doesn't import extened attributes values any longer

2014-09-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12859

Jacek Ablewicz  changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |a...@biblos.pk.edu.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12859] Patron import tool doesn't import extened attributes values any longer

2014-09-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12859

--- Comment #1 from Jacek Ablewicz  ---
Created attachment 31319
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31319&action=edit
Bug 12859 - Patron import tool doesn't import extened attributes values any
longer

To reproduce:

1/ define/set up extended pattron attribute in administration module,
2/ using "Tools -> Import patrons", try to import some sample patron
record[s], having some arbitrary (non-empty) value assigned in
'pattron_attributes' CSV column for attribute defined in step 1/,
3/ observe that extended attribute defined in step 1/ was not imported
(not added to the database), without any warnings.

This patch restores a small code chunk which went AWOL somewhere around
commit b4158f2d2485c9e57bd7f14362b210732bef9d35.

To test:

1/ apply patch & retest,
3/ ensure that this issue is no longer reproductible, and there are no
apparent regressions of any kind,
4/ make sure that the ability to specify default value for extended
attributes added in bug Bug 12716 is still working as intended
(= follow up the test plan for bug 12716).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12859] Patron import tool doesn't import extened attributes values any longer

2014-09-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12859

Jacek Ablewicz  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

2014-09-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

--- Comment #28 from Alessandra Carassiti  ---
I tried to test this patch with the sandbox system, it does not work, here is
the result & paste what is written: 'Some problems occurred applying patches
from bug 11708:
Something went wrong !Applying: Bug 11708: Add
aqbasketgroups.closeddate
Using index info to reconstruct a base tree...
Falling back to patching base and 3-way merge...
Warning: commit message does not conform to UTF-8.
You may want to amend it after fixing the message, or set the config
variable i18n.commitencoding to the encoding your project uses.
Applying: Bug 11708: Unit tests for aqbasketgroups.closeddate
Warning: commit message does not conform to UTF-8.
You may want to amend it after fixing the message, or set the config
variable i18n.commitencoding to the encoding your project uses.
Applying: Bug 11708: basketgroup.pl can now display basketgroups for all
suppliers
Using index info to reconstruct a base tree...
Falling back to patching base and 3-way merge...
Renaming intranet-tmpl/prog/en/css/datatables.css =>
koha-tmpl/opac-tmpl/prog/en/css/datatables.css
Auto-merging koha-tmpl/opac-tmpl/prog/en/css/datatables.css
CONFLICT (rename/modify): Merge conflict in
koha-tmpl/opac-tmpl/prog/en/css/datatables.css
Failed to merge in the changes.
Patch failed at 0001 Bug 11708: basketgroup.pl can now display basketgroups for
all suppliers
When you have resolved this problem run git bz apply --continue.
If you would prefer to skip this patch, instead run git bz apply --skip.
To restore the original branch and stop patching run git bz apply --abort.
Bug 11708 - Display all basketgroups on one page, and new column
aqbasketgroups.closeddate

31305 - Bug 11708: Add aqbasketgroups.closeddate
31306 - Bug 11708: Unit tests for aqbasketgroups.closeddate
31307 - Bug 11708: basketgroup.pl can now display basketgroups for all
suppliers
31308 - Bug 11708: explicitly remove pagination
31309 - Bug 11708: All basketgroups on one page - several fixes

Apply? [(y)es, (n)o, (i)nteractive] Patch left in
/tmp/Bug-11708-basketgrouppl-can-now-display-basketgrou-rdAn9M.patch .'

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate

2014-09-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708

Alessandra Carassiti  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||a.carass...@cineca.it

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12859] Patron import tool doesn't import extened attributes values any longer

2014-09-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12859

Jacek Ablewicz  changed:

   What|Removed |Added

Summary|Patron import tool doent|Patron import tool doesn't
   |importing extened   |import extened attributes
   |attributes values   |values any longer

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12859] New: Patron import tool doent importing extened attributes values

2014-09-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12859

Bug ID: 12859
   Summary: Patron import tool doent  importing extened attributes
values
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Tools
  Assignee: gmcha...@gmail.com
  Reporter: a...@biblos.pk.edu.pl
QA Contact: testo...@bugs.koha-community.org

To reproduce:

1/ define/set up extended pattron attribute in administration module,
2/ using "Tools -> Import patrons", try to import some sample patron record[s],
having some arbitrary (non-empty) value assigned in 'pattron_attributes' CSV
column for attribute defined in step 1/,
3/ observe that extended attribute defined in step 1/ was not imported (not
added to the database), without any warnings.

Ad. 1: Note that it's also strictly necessary to have all possible extended
attributes types which may be present in CSV import file defined in the
administration, before performing an import; if even one of them is not
defined, all other extended attributes for a given patron are being silently
skipped as well. But that's outside of the scope of this particular bug.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12858] Syndetics index apreciably slow page load for items without result at Syndetics

2014-09-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12858

Martin Renvoize  changed:

   What|Removed |Added

   Assignee|oleon...@myacpl.org |martin.renvoize@ptfs-europe
   ||.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12858] Syndetics index apreciably slow page load for items without result at Syndetics

2014-09-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12858

--- Comment #1 from Martin Renvoize  ---
Created attachment 31318
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31318&action=edit
Bug 12858: Add error handling to Syndetics Index

* Syndetics routines include a statement to check that the returned
  content from Syndetics is xml. The get_syndetics_index routine was
  missing this check and so when a 'not found' html page was returned
  the opac-detail page would take a long time to load whilst xml::simple
  attempted to parse the large html document.

  Test Plan
  1. Enable Syndetics indexes on opac.
  2. Head over to an opac-detail page on the opac.
  3. Remove the ISBN from the same item in the staff client.
  4. Reload the opac-detail page for the item noticeing a much slower
  page load.
  5. Apply the patch
  6. Reload the opac-detail page for the item and note that it now laods
  in a reasonable timescale again.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12858] Syndetics index apreciably slow page load for items without result at Syndetics

2014-09-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12858

Martin Renvoize  changed:

   What|Removed |Added

 Depends on|12420   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12420] syndetics content broken in bootstrap

2014-09-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12420

Martin Renvoize  changed:

   What|Removed |Added

 Blocks||12858

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12420] syndetics content broken in bootstrap

2014-09-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12420

Martin Renvoize  changed:

   What|Removed |Added

 Blocks|12858   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12858] New: Syndetics index apreciably slow page load for items without result at Syndetics

2014-09-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12858

Bug ID: 12858
   Summary: Syndetics index apreciably slow page load for items
without result at Syndetics
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: major
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: martin.renvo...@ptfs-europe.com
QA Contact: testo...@bugs.koha-community.org
CC: neng...@gmail.com
Depends on: 12420

get_syndetics_index is missing the error handling code that is present in the
other routines. Thereofre, if an idnex is not found for the particular item,
then XML::Simple attempts to parse the large html document that is returned.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12420] syndetics content broken in bootstrap

2014-09-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12420

Martin Renvoize  changed:

   What|Removed |Added

 Blocks||12857

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12857] New: Syndetics index apreciably slow page load for items without result at Syndetics

2014-09-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12857

Bug ID: 12857
   Summary: Syndetics index apreciably slow page load for items
without result at Syndetics
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: major
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: martin.renvo...@ptfs-europe.com
QA Contact: testo...@bugs.koha-community.org
CC: neng...@gmail.com
Depends on: 12420

get_syndetics_index is missing the error handling code that is present in the
other routines. Thereofre, if an idnex is not found for the particular item,
then XML::Simple attempts to parse the large html document that is returned.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 3340] Enhancement for borrower loading command line

2014-09-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3340

Magnus Enger  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 CC||mag...@enger.priv.no
 Resolution|--- |DUPLICATE

--- Comment #4 from Magnus Enger  ---
As far as I can tell, this is similar to bug 12598, which has a patch.

*** This bug has been marked as a duplicate of bug 12598 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool

2014-09-02 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

Magnus Enger  changed:

   What|Removed |Added

 CC||dschu...@gmail.com

--- Comment #16 from Magnus Enger  ---
*** Bug 3340 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/