[Koha-bugs] [Bug 12849] Sending a list has malformed links

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12849

Robin Sheat  changed:

   What|Removed |Added

   Priority|P5 - low|P3

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12849] Sending a list has malformed links

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12849

Galen Charlton  changed:

   What|Removed |Added

   Keywords||rel_3_16_5_candidate
 CC||gmcha...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12873] Reserve can be cancelled by any logged in user

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12873

Galen Charlton  changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable
  Group|Koha security   |
 CC||gmcha...@gmail.com
  Component|Koha|Hold requests
Version|unspecified |master
Product|Koha security   |Koha
 QA Contact||testo...@bugs.koha-communit
   ||y.org

--- Comment #12 from Galen Charlton  ---
Pushed to 3.16.x for inclusion in 3.16.4.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12876] Reserve in waiting/transfer status may be cancelled by user

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12876

Galen Charlton  changed:

   What|Removed |Added

  Group|Koha security   |
  Component|Koha|Hold requests
Version|unspecified |master
Product|Koha security   |Koha
 QA Contact||testo...@bugs.koha-communit
   ||y.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 1807] search () give odd results

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1807

Jesse Maseto  changed:

   What|Removed |Added

 CC||je...@bywatersolutions.com

--- Comment #8 from Jesse Maseto  ---


//Fix subject search by striping parenthesis from url links
$('#catalogue_detail_biblio a[href*="su:"]').attr('href', function(_,v){
return v.replace(/(\(|\))/g,'')
});

This works for both the staff search and OPAC.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367

Agnes Rivers-Moore  changed:

   What|Removed |Added

 CC||a...@hanover.ca

--- Comment #76 from Agnes Rivers-Moore  ---
We would like the option to have a shorter pickup period for some item types.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12656] add a notice that tells patrons when their hold was cancelled because it wasn't picked up in time

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12656

Agnes Rivers-Moore  changed:

   What|Removed |Added

 CC||a...@hanover.ca

--- Comment #1 from Agnes Rivers-Moore  ---
I agree. I am disappointed that Koha leaves no trace for staff or borrower when
a hold is cancelled. 
Perhaps there could be a preference choice whether to send a notice for all
cancelled holds, or just for those cancelled after waiting too long for pickup.
Having that notice show up in the borrower messages tab would be really useful!
Agnes

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11944] Cleanup Koha UTF-8

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944

Heather Braum  changed:

   What|Removed |Added

 CC||hbr...@nekls.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8604] Patron cards made for patrons which don't have patron images use preceding card's image

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604

--- Comment #5 from Chris Nighswonger  ---
(In reply to lightpurpledye from comment #4)
> Oops, I did mean create-pdf.pl, well spotted.
> 
> I don't think I've misunderstood where images should be stored, however. I
> only have one image in the creator_images table in the db, which I wish to
> be displayed on every card.
> 
> The patron images are all in the patronimage table (uploaded using the bulk
> Upload Patron Images tool). It's just that some patrons do not have images
> set, but creating a card for them still displays an image, but of a
> different patron.

So it sounds like your images are in the correct location. However, that only
makes it a bit more confusing as to why commenting out code which inserts the
image for every card would "fix" the duplicate patron image issue. So I'll just
have to find time to duplicate the bug and look at what's going on there.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8604] Patron cards made for patrons which don't have patron images use preceding card's image

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604

--- Comment #4 from lightpurple...@gmail.com ---
Oops, I did mean create-pdf.pl, well spotted.

I don't think I've misunderstood where images should be stored, however. I only
have one image in the creator_images table in the db, which I wish to be
displayed on every card.

The patron images are all in the patronimage table (uploaded using the bulk
Upload Patron Images tool). It's just that some patrons do not have images set,
but creating a card for them still displays an image, but of a different
patron.

N.B. The self-checkout module does not display any images for these patrons,
and there is no image set for them in the patronimage table, so I am fairly
sure it's a bug in the Patron Card Creator module rather than anything else.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13019] Add base classes on which to build Koha objects

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13019

--- Comment #3 from Kyle M Hall  ---
> 1/ Type and ObjectClass could be attributes, instead of methods

Could write a followup? I tried to do that but had issues with getting the base
class to know about the package variable. I was properly implementing it wrong.

> 2/ I really would like to see method name without capital letters (and
> underscore '_' to separate words)

I have no strong preference here as long as we stick to one convention. My only
concern would be a convention conflict where a table has the same name as a
field in the table. That would lead to ambiguity, but I'm not sure if we even
have an instance of this. For example, let's say a table has the field borrower
which is actually a borrowernumber. I'd like to have $row->borrower return the
borrowernumber, but $row->Borrower return the Koha::Borrower object. That way
we know when we are getting back a scalar, and when we are getting back an
Object. It would be silly to fetch the Koha::Borrower in a case where we just
need the borrowernumber, which we would already have.

> 3/ "Bad setter returns undef" => not sure about that. Bad setter should croak

Agreed.

> 4/ What about using Class::Accessor?

I don't see the advantage to this. Can you give an example. This implementation
uses a DBIC object as a place to store the data, so there is no need to have
separate properties. Please note the this should not conflict this unit testing
on a database-less system. t/Object.t should demonstrate this.

> 5/ t/db_dependent/Objects.t should be t/db_dependent/Borrowers.t

I can see your point, but the tests are really testing the base classes, and
not the Borrower classes per se. However, I have no strong opinion so that's
fine by me.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8604] Patron cards made for patrons which don't have patron images use preceding card's image

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604

--- Comment #3 from Chris Nighswonger  ---
(In reply to lightpurpledye from comment #2)
> This problem goes away if you comment out lines 152 - 159 of
> /usr/share/koha/intranet/cgi-bin/patroncards (lines beginning "elsif
> ($images->{$_}->{'data_source'}->[0]->{'image_source'} eq 'creator_images')
> {" ).
> 
> However, doing this also breaks the display of any "Other Image"s
> (non-patron photo images) on the card layout.
> 

The file in question is create-pdf.pl

Your test indicates that at least on your system there may be patron images
stored where "creator_images" should be. This entire block of code
(PROCESS_IMAGES [1]) is prefaced on layout xml like this:

  

  

It looks at the data_source key in particular for the "source" of the image.
"creator_images" are stored in a table by the same name in the db. This is a
different source than patron images which are stored in the patronimage table.

The fact that commenting out the condition which allows for retrieval of
creator_images "fixes" the problem would seem to indicate a misunderstanding of
what images should be stored where. An image stored in the creator_images table
and used in a patroncard layout will appear on every card in any batch using
that layout. Images stored in the patronimage table will (should) appear only
on cards which include that patron.

I have not had time to try this bug out, but what you describe seems to be more
related to misunderstanding what images should be stored where. Hopefully that
clarifies things a bit. If I've not understood, feel free to let me know.

[1] http://tinyurl.com/kfh5vbn

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8604] Patron cards made for patrons which don't have patron images use preceding card's image

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8604

lightpurple...@gmail.com changed:

   What|Removed |Added

 CC||lightpurple...@gmail.com

--- Comment #2 from lightpurple...@gmail.com ---
This problem goes away if you comment out lines 152 - 159 of
/usr/share/koha/intranet/cgi-bin/patroncards (lines beginning "elsif
($images->{$_}->{'data_source'}->[0]->{'image_source'} eq 'creator_images') {"
).

However, doing this also breaks the display of any "Other Image"s (non-patron
photo images) on the card layout.

I have tried adding "$image_data = undef" to the beginning of the foreach loop,
and between lines 152 and 153, under the assumption that $image_data still
contains the image data from the previous iteration until it is reassigned, but
this had no effect.

I think that for some reason the elsif condition on line 152 is matching users
which don't have a photo assigned, but I still don't know why that would result
in the behaviour observed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||12648

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12648] Link patrons to an order

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||12633

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633

Jonathan Druart  changed:

   What|Removed |Added

 Status|Failed QA   |ASSIGNED
 CC||jonathan.dru...@biblibre.co
   ||m
   Assignee|yohann.duf...@biblibre.com  |jonathan.dru...@biblibre.co
   ||m

--- Comment #9 from Jonathan Druart  ---
If I am not wrong, there are 3 occurrences of C4::Members::Search:
1/ acqui/aqbasketuser_search.pl
2/ members/guarantor_search.pl
3/ patroncards/members-search.pl

1 is removed by 12648, I have a patch for 2.
3 is todo.

When done, I will completely remove the C4::Members::Search subroutine.
Some code should be move from C4::Utils::DT::Members to C4::Members (or
Koha::Members).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12892] Holds Waiting: not showing from check out screen

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12892

Heather Braum  changed:

   What|Removed |Added

 CC||hbr...@nekls.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12550] Add ability to delay loading of patron's checkouts in circulation and patron details

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12550

--- Comment #13 from Kyle M Hall  ---
Created attachment 31968
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31968&action=edit
Bug 12550 [QA Followup] - Make checking the checkbox load the table of
checkouts

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13018] Static fine should apply only once for a given borrower

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13018

Sophie MEYNIEUX  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12550] Add ability to delay loading of patron's checkouts in circulation and patron details

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12550

Kyle M Hall  changed:

   What|Removed |Added

 Blocks||13020

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13020] Checkouts table default ordering is incorrect

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13020

Kyle M Hall  changed:

   What|Removed |Added

 Depends on||12550

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13018] Static fine should apply only once for a given borrower

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13018

--- Comment #1 from Sophie MEYNIEUX  ---
Created attachment 31967
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31967&action=edit
Bug 13018 : Static fine should be charged only once

Test plan (see Bug 6858 for using staticfine.pl) :

For a user (of a given category and library) with several overdues, launch the
script :

staticfines.pl --category CAT,AMOUNT --library LIB --delay DELAY

Then, check that the user has been charged of AMOUNT if the due date of the
most late item plus the delay is *before* today.

One day later, re-execute the script with the same parameters and check that
the fine has not been charged twice.

Without patch, the fine is charged twice, with patch the user already charged
is skipped (see output in debug mode)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13020] Checkouts table default ordering is incorrect

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13020

Kyle M Hall  changed:

   What|Removed |Added

   Severity|normal  |minor

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13020] Checkouts table default ordering is incorrect

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13020

Kyle M Hall  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com
   |ity.org |
   Severity|minor   |normal

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13020] Checkouts table default ordering is incorrect

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13020

--- Comment #1 from Kyle M Hall  ---
Created attachment 31966
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31966&action=edit
Bug 13020 - Checkouts table default ordering is incorrect

The checkouts table is no longer keeping "today's checkouts" in the
order they were scanned.

Test Plan:
1) Create 3 records "Test 1", "Test 2" and "Test 3" each with one item
2) Check out the items to a patron in the order "Test 2", "Test 1", "Test 3".
3) Note the order is incorrect.
4) Apply this patch
5) Refresh the page
6) Note the order is now correct

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13020] Checkouts table default ordering is incorrect

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13020

Kyle M Hall  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13020] New: Checkouts table default ordering is incorrect

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13020

Bug ID: 13020
   Summary: Checkouts table default ordering is incorrect
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: k...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

The checkouts table is no longer keeping "today's checkouts" in the order they
were scanned.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12986] Upgrade the DataTables jQuery plugin to the latest version

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12986

--- Comment #9 from Jonathan Druart  ---
(In reply to Paola Rossi from comment #6)
> (In reply to Jonathan Druart from comment #4)
> 
> Zeno and I thank you, Jonathan.
> 
> > Zeno, you can try to apply patches from bug 12897, 12988 and 12989 without
> > this one.
> 
> 1) I think the first bug was 12987, wasn't it? 

Yes of course, sorry.


> 2) Before trying to apply tha patch, I'm in doubt about 12987.

Yes, the graph is correct!
I updated the dependencies on bugzilla.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12987] Update table footer with the visible rows

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12987

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||12988

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12986] Upgrade the DataTables jQuery plugin to the latest version

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12986

Jonathan Druart  changed:

   What|Removed |Added

 Blocks|12988   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12989] Update table footer with the visible rows - acqui-home

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12989

Jonathan Druart  changed:

   What|Removed |Added

 Depends on|12986   |12987

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12986] Upgrade the DataTables jQuery plugin to the latest version

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12986

Jonathan Druart  changed:

   What|Removed |Added

 Blocks|12989   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12988] Update table footer with the visible rows - budgets

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12988

Jonathan Druart  changed:

   What|Removed |Added

 Depends on|12986   |12987

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12987] Update table footer with the visible rows

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12987

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||12989

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12986] Upgrade the DataTables jQuery plugin to the latest version

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12986

--- Comment #8 from Owen Leonard  ---
I haven't tested this patch at all so I don't know if the upgrade causes any
problems. However, I think we should always try to keep up to date with the
libraries Koha uses unless there is some specific reason not to.

In my opinion the possibility that it may cause problems for IE6/7 is not
enough of an issue to block an upgrade to the plugin.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12986] Upgrade the DataTables jQuery plugin to the latest version

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12986

--- Comment #7 from Zeno Tajoli  ---
(In reply to Owen Leonard from comment #5)
> Zeno are you finding errors when testing this patch or do you question
> whether we should be upgrading DataTables at all?

In fact the question is more "Should we upgrade DataTables".
- I don't have a PC with IE6/IE7 so I can't test if we have a problem with
version 10.x of DataTables

> Is it continued support for IE6/7 which is at issue here?

I think yes.

The other problem are any plugin that use  API of DataTables plugin.
Do you know our situation about this ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13019] Add base classes on which to build Koha objects

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13019

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@biblibre.co
   ||m

--- Comment #2 from Jonathan Druart  ---
First thoughts (already sent on #koha):

1/ Type and ObjectClass could be attributes, instead of methods
2/ I really would like to see method name without capital letters (and
underscore '_' to separate words)
3/ "Bad setter returns undef" => not sure about that. Bad setter should croak
4/ What about using Class::Accessor?
5/ t/db_dependent/Objects.t should be t/db_dependent/Borrowers.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12550] Add ability to delay loading of patron's checkouts in circulation and patron details

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12550

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #31160|0   |1
is obsolete||

--- Comment #12 from Kyle M Hall  ---
Created attachment 31965
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31965&action=edit
Bug 12550 - Add ability to delay loading of patron's checkouts in circulation
and patron details

Rebased patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12986] Upgrade the DataTables jQuery plugin to the latest version

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12986

Paola Rossi  changed:

   What|Removed |Added

 CC||paola.ro...@cineca.it

--- Comment #6 from Paola Rossi  ---
(In reply to Jonathan Druart from comment #4)

Zeno and I thank you, Jonathan.

> Zeno, you can try to apply patches from bug 12897, 12988 and 12989 without
> this one.

1) I think the first bug was 12987, wasn't it? 

2) Before trying to apply tha patch, I'm in doubt about 12987.

A) On the graph at  kindly prepared
at bug-12825, the two bugs 12988 and 12989 depend on 12987, and 12987 depends
on this current bug 12986.
So the "blocks" set of this bug 12986 should be limited to 12987.
And the bug 12988 would depend on bug 12987, instead of bug 12986 presently
shown. 
And the bug 12989 would depend on bug 12987, instead of bug 12986 presently
shown. 

B) Otherwise, in the graph the two bugs 12988 and 12989 would point directly to
12986, instead of pointing to 12987.
The "blocks" set of this bug 12986 should remain the same: 7,8 and 9.
And the bug 12988 keeps on depending on the bug 12986 presently shown. 
And the bug 12989 keeps on depending on the bug 12986 presently shown. 

Thank you in advance.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13019] Add base classes on which to build Koha objects

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13019

M. de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12669] "Template process failed: undef error - Invalid local time for date in time zone"

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12669

--- Comment #14 from Colin Campbell  ---
(In reply to Jonathan Druart from comment #12)
> (In reply to Jonathan Druart from comment #11)
> > Created attachment 31623 [details] [review] [review]
> 
> Rolando and Colin, could it be possible to get your point of view on this
> patch please?

(In reply to Rolando Isidoro from comment #13)
> Hey Johnathan, your patch complexity and range greatly exceeds my knowledge
> of Koha's source code. Colin, what's your take on this?
> 
> Rolando

This changes behaviour in an undocumented way if I pass a tz other than
C4::Context's it seems in some strings (need more test cases) to be changing to
the system tz but not correctly converting the date ... It also adds processing
to a frequently used routine which is not efficient e.g. the evals are
unnecessary if anything failes the date parse returns undef flagging the error.

I'll try testing some more inputs to this

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12986] Upgrade the DataTables jQuery plugin to the latest version

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12986

--- Comment #5 from Owen Leonard  ---
Zeno are you finding errors when testing this patch or do you question whether
we should be upgrading DataTables at all?

Is it continued support for IE6/7 which is at issue here?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12892] Holds Waiting: not showing from check out screen

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12892

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #31962|0   |1
is obsolete||

--- Comment #26 from Kyle M Hall  ---
Comment on attachment 31962
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31962
Bug 12892 - Add Koha::Object, Koha::Objects and unit tests

Moving the base class patch to it's own bug. Bug 13019.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13019] Add base classes on which to build Koha objects

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13019

Kyle M Hall  changed:

   What|Removed |Added

 Blocks||12892

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12892] Holds Waiting: not showing from check out screen

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12892

Kyle M Hall  changed:

   What|Removed |Added

 Depends on||13019

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13019] Add base classes on which to build Koha objects

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13019

--- Comment #1 from Kyle M Hall  ---
Created attachment 31964
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31964&action=edit
Bug 13019 - Add base classes on which to build Koha objects

The idea behind this is to have a pair of base classes on which to build
our new generation of Koha objects. Koha::Object is a base class, which
in it's most basic form, is to represent a row in a table. For example,
Koha::Borrower inherits from Koha::Object. So too could Koha::Biblio
and Koha::Item for example.

Koha::Objects is to represent a way to fetch and manipulate sets of
objects. For example, Koha::Borrowers has a method to get a
Koha::Borrower object by id and a method to search for an get a list
of Koha::Borrower objects. Right now Koha::Objects has only the
essentials but can easily be extended and those enhancements will be
passed down to all the child classes based on it.

By using these classes as a base, we will add consistency to our
code, allow us to keep our code DRY, reduce bugs, and encapsulate our
database access among other benefits.

Test Plan:
1) Apply this patch
2) prove t/Object.t t/db_dependent/Object.t t/db_dependent/Objects.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13019] Add base classes on which to build Koha objects

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13019

Kyle M Hall  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13019] Add base classes on which to build Koha objects

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13019

Kyle M Hall  changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13019] New: Add base classes on which to build Koha objects

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13019

Bug ID: 13019
   Summary: Add base classes on which to build Koha objects
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: gmcha...@gmail.com
  Reporter: k...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

The idea behind this is to have a pair of base classes on which to build our
new generation of Koha objects. Koha::Object is a base class, which in it's
most basic form, is to represent a row in a table. For example, Koha::Borrower
inherits from Koha::Object. So too could Koha::Biblio and Koha::Item for
example.

Koha::Objects is to represent a way to fetch and manipulate sets of objects.
For example, Koha::Borrowers has a method to get a Koha::Borrower object by id
and a method to search for an get a list of Koha::Borrower objects. Right now
Koha::Objects has only the essentials but can easily be extended and those
enhancements will be passed down to all the child classes based on it.

By using these classes as a base, we will add consistency to our code, allow us
to keep our code DRY, reduce bugs, and encapsulate our database access among
other benefits.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9530] Allow separate 'Reply To' and 'From' email address for notices

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9530

--- Comment #39 from Martin Renvoize  ---
This wiki snippet I did may be useful to anyone documenting this feature.

I'll be happy to explain further upon request

http://wiki.koha-community.org/wiki/MRenvoize/Email

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6858] Adds staticfines.pl for static fines processing

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6858

Sophie MEYNIEUX  changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=13018

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13018] Static fine should apply only once for a given borrower

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13018

Sophie MEYNIEUX  changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=6858

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13018] New: Static fine should apply only once for a given borrower

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13018

Bug ID: 13018
   Summary: Static fine should apply only once for a given
borrower
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: major
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: sophie.meyni...@biblibre.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

Once a borrower is charged for overdues, staticfine.pl execution should not add
a new fine each time.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12986] Upgrade the DataTables jQuery plugin to the latest version

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12986

--- Comment #4 from Jonathan Druart  ---
Zeno, you can try to apply patches from bug 12897, 12988 and 12989 without this
one.
The behavior was broken without updating the DT plugin.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12892] Holds Waiting: not showing from check out screen

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12892

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #31670|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12892] Holds Waiting: not showing from check out screen

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12892

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #31472|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12892] Holds Waiting: not showing from check out screen

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12892

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #31471|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12892] Holds Waiting: not showing from check out screen

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12892

--- Comment #25 from Kyle M Hall  ---
Created attachment 31963
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31963&action=edit
Bug 12892 - Holds Waiting: not showing from check out screen

When a patron has holds waiting to be pick up, they used to show in the
check out screen. These notifications are no longer showing in 3.16.

Test Plan:
1) Apply this patch
2) Create a hold, set to waiting
3) Browse to circulation.pl for that patron
4) Note you see the list of waiting holds
5) Switch you logged in branch to a different branch
6) Note the "Waiting at" line is no longer emphasized.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12892] Holds Waiting: not showing from check out screen

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12892

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #31605|0   |1
is obsolete||
  Attachment #31607|0   |1
is obsolete||
  Attachment #31672|0   |1
is obsolete||

--- Comment #24 from Kyle M Hall  ---
Created attachment 31962
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31962&action=edit
Bug 12892 - Add Koha::Object, Koha::Objects and unit tests

This patch adds the base classes upon which we can build
new Koha classes to give us smarter, simpler code.

Test Plan:
1) Apply this patch
2) prove t/Object.t t/db_dependent/Object.t t/db_dependent/Objects.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12892] Holds Waiting: not showing from check out screen

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12892

Kyle M Hall  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12986] Upgrade the DataTables jQuery plugin to the latest version

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12986

Zeno Tajoli  changed:

   What|Removed |Added

 CC||oleon...@myacpl.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12986] Upgrade the DataTables jQuery plugin to the latest version

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12986

Zeno Tajoli  changed:

   What|Removed |Added

 Status|Needs Signoff   |In Discussion
 CC||z.taj...@cineca.it

--- Comment #3 from Zeno Tajoli  ---
Hi Jonathan,

we have problem to test this patch.
Could you tell us where footerCallback function doesn't work with present
version
and it needs 1.10.2 of  DataTables jQuery plugin ?

About the change of 1.10 (reading http://datatables.net/upgrade/1.10):
-- Pagination (two_button), is present only in datatables.css,a css that came
with the plugin. So is not used by us

-- function fnRender: we don't use it.

-- function bScrollInfinite: we don't use it

-- Could be problems with IE6/IE7: from 1.10.2 of  DataTables jQuery plugin
cookie based state saving has been replaced with localStorage based state
saving.
This function is not availabe in IE6/IE7 there are same way to live with this
[The stateLoadCallbackDT and stateSaveCallbackDT parameters can be used to
provide a suitable function if you wish to use cookies.]

-- Question: Do we use API plug-ins of ataTables jQuery plugin ?
A real question, I don't know the answer.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12648] Link patrons to an order

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648

--- Comment #16 from Jonathan Druart  ---
Created attachment 31961
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31961&action=edit
Bug 12648: Hide the result search on load

When no search has been done yet, it's not necessary to display the
result list.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12648] Link patrons to an order

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648

--- Comment #15 from Jonathan Druart  ---
Created attachment 31960
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31960&action=edit
Bug 12648: Fix conflict with bug 12833

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12648] Link patrons to an order

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12833] Patron search no longer searches extended attributes

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12833

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||12648

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12648] Link patrons to an order

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12648

Jonathan Druart  changed:

   What|Removed |Added

 Status|Needs Signoff   |ASSIGNED
 Depends on||12833

--- Comment #14 from Jonathan Druart  ---
Bug 12833 breaks this enh.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8137] Checkout limit by patron category for all libraries

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8137

Kyle M Hall  changed:

   What|Removed |Added

 Status|In Discussion   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12516] The module C4::Tags needs more unit tests

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12516

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|NEW
 CC||jonathan.dru...@biblibre.co
   ||m
   Assignee|yohann.duf...@biblibre.com  |ch...@bigballofwax.co.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/