[Koha-bugs] [Bug 13001] Refactor VAT and price calculation - parcel page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13001 Paola Rossi paola.ro...@cineca.it changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||paola.ro...@cineca.it -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13001] Refactor VAT and price calculation - parcel page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13001 Paola Rossi paola.ro...@cineca.it changed: What|Removed |Added Attachment #31901|0 |1 is obsolete|| --- Comment #2 from Paola Rossi paola.ro...@cineca.it --- Created attachment 31982 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31982action=edit Bug 13001: Refactor VAT and price calculation - parcel page I've applied te patch against master 3.17.00.025 Firstly I've applied: 5342 (2), 12852 (3), 12844 (4), 12830 (2), 12896 (1), 12969 (2) I've tested setting pref currencyformat either on FR or US. The tested steps in file-doc at bug 12964 are about parcel.pl: STEP 5) STEP 10) Either on 1-0 or 1-1 I've seen, as required: before: 140.57 + 7.03 = 147.60 now:140.58 + 7.02 = 147.60 So I pass the patch to Signed Off status. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12976] Refactor VAT and price calculation - invoice page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12976 Paola Rossi paola.ro...@cineca.it changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||paola.ro...@cineca.it -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12976] Refactor VAT and price calculation - invoice page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12976 Paola Rossi paola.ro...@cineca.it changed: What|Removed |Added Attachment #31880|0 |1 is obsolete|| --- Comment #4 from Paola Rossi paola.ro...@cineca.it --- Created attachment 31983 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31983action=edit Bug 12976: Use the centralize VAT and prices calculation - invoice.pl I've applied the patch against master 3.17.00.025 Firstly I've applied: 5342 (2), 12852 (3), 12844 (4), 12830 (2), 12896 (1), 12969 (2) I've tested setting pref currencyformat either on FR or US. As required, I've seen on invoice.pl: CONF I 0-0 10B) invoice after receiving (invoice.pl) gst_rate = 0.05 gstvalue = 7.38 total_tax_exc = 147.60 total_tax_inc = 154.98 -- CONF II 1-1 10B) invoice after receiving (invoice.pl) gst_rate = 0.05 gstvalue = 7.02 total_tax_exc = 140.58 total_tax_inc = 147.60 -- CONF III 1-0 10B) invoice after receiving (invoice.pl) gst_rate = 0.05 gstvalue = 7.02 total_tax_exc = 140.58 total_tax_inc = 147.60 --- CONF IV 0-1 10B) invoice after receiving (invoice.pl) gst_rate = 0.05 gstvalue = 7.38 total_tax_exc = 147.60 total_tax_inc = 154.98 --- I pass the patch to Signed Off status. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10632] Enable datatables for courses and course details in the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10632 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #3 from Kyle M Hall k...@bywatersolutions.com --- Owen, what did I do here differently from bug 10634? Can you describe what I need to do? Is there an existing example in Koha I can use as a pattern? Thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12980] GetHistory does useless processing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12980 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #31900|0 |1 is obsolete|| --- Comment #3 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 31984 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31984action=edit [PASSED QA] Bug 12980: GetHistory does useless processing GetHistory iterated on the orders to calculate the quantity and price. These values are never used by the called. It can be removed. Test plan: Verify there is no regression on acqui/histsearch.pl and catalogue/detail.pl Actually you just have to check that the total quantity and price are not displayed on these views. QA: note that 'count' and 'toggle' are never used in the template. Signed-off-by: Paola Rossi paola.ro...@cineca.it Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12980] GetHistory does useless processing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12980 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12985] All basketgroups are not listed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12985 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #31868|0 |1 is obsolete|| --- Comment #3 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 31985 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31985action=edit [PASSED QA] Bug 12985: All basketgroups should be listed Only 20 first are listed, others are hidden. Test plan: - Create at least 21 basketgroups - verify you can see it on the open tab - close all of them - verify you can see it on the close tab There is no restriction to hide datables functions here. Signed-off-by: Paola Rossi paola.ro...@cineca.it Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12985] All basketgroups are not listed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12985 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12992] Fund planning does not display actual values
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12992 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12992] Fund planning does not display actual values
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12992 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #31904|0 |1 is obsolete|| --- Comment #3 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 31986 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31986action=edit [PASSED QA] Bug 12992: Fund planning should display actual values The 'show_actual' variable is not correctly manage in the template. This has certainly been introduced by the migration to TT. Test plan: 1/ Go on a bugdet planning view (admin/aqplan.pl) 2/ Check the Show actual/estimated values checkbox on the left (Filters box) 3/ Go 4/ Verify the actual values are now displayed (i.e. the columns contain 2 values). Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12929] bug 12716 introduces a regression on the patron import tools
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12929 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Signed Off |Patch doesn't apply CC||k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12944] There is no way to search orders by creator
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12944 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12944] There is no way to search orders by creator
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12944 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #31824|0 |1 is obsolete|| Attachment #31825|0 |1 is obsolete|| --- Comment #5 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 31987 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31987action=edit [PASSED QA] Bug 12944: Refactor the patron autocomplete The patron list feature uses an autocomplete field to search patron. This will be reused in the next patch. This patch should not introduce any behavior change. Signed-off-by: Paola Rossi paola.ro...@cineca.it Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12944] There is no way to search orders by creator
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12944 --- Comment #6 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 31988 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31988action=edit [PASSED QA] Bug 12944: Search orders by basket creator This patch adds the ability to search orders using the basket creator. Test plan: - go on the order advanced search form (acqui/histsearch.pl) - use the autocomplete input to search patrons - launch the search and verify the results are consistent with the values you have filled. Signed-off-by: Paola Rossi paola.ro...@cineca.it Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12944] There is no way to search orders by creator
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12944 --- Comment #7 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 31989 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31989action=edit [PASSED QA] Bug 12944 [QA Followup] - Rename patrons.pl to patrons.js Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10632] Enable datatables for courses and course details in the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10632 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #4 from Owen Leonard oleon...@myacpl.org --- I can see a couple of things offhand which need to be addressed: - Apply to the Bootstrap theme - Use the new DataTables include file DataTables won't be styled correctly without changes to the CSS and the addition of DataTables-related images. That needs to be taken care of before this patch goes in. This patch doesn't work properly for me anymore in master (missing datatables-strings.inc file), so I can't say for sure but it sounds like the existing CSS file in the OPAC doesn't (fully?) handle the pagination menu controls. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12956] Users are not linked to a fund
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12956 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12956] Users are not linked to a fund
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12956 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #31779|0 |1 is obsolete|| --- Comment #4 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 31990 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31990action=edit [PASSED QA] Bug 12956: Users are not linked to a fund When creating a fund, if you add some users, they are not linked to the fund. Note that it works if you link them when editing the fund. Test plan: - Try to link users to a fund on creating it. - On editing, you should see the linked user list. Signed-off-by: Nick Clemens n...@quecheelibrary.org Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12831] local only logins should still work when ldap authentication is enabled
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12831 --- Comment #7 from Dobrica Pavlinusic dpav...@rot13.org --- Sorry for delay, I wanted to test things before submitting more code. I can't really get LDAP_NO_SUCH_OBJECT error on bind. My guess is that this error would appear if I was searching for object which wasn't defined in LDAP schema as opposed to bind call. Did you manage to get this error from LDAP server on bind? I wouldn't like to insert code there just because it seems right, since LDAP code in Koha is already black magic to almost everyone and accumulating cruft doesn't seem like a good idea. Regarding LDAP_INVALID_CREDENTIALS, it's already handled by else part of if statement and I did test with invalid password and it works as-is. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12646] Only top 20 rows visible in invoices search result
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12646 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12646] Only top 20 rows visible in invoices search result
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12646 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #31857|0 |1 is obsolete|| --- Comment #6 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 31991 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31991action=edit [PASSED QA] Bug 12646: Display all invoices on the same page Only first 20 invoices were displayed on the page. Without pagination, DT did not allow to show others. This page explicitely removes the pagination option in order to display all invoices on the page. Test plan: 1/ Create 21+ invoices 2/ Go on acqui/invoices 3/ Verify all invoices are displayed. Signed-off-by: Paola Rossi paola.ro...@cineca.it Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12831] local only logins should still work when ldap authentication is enabled
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12831 Dobrica Pavlinusic dpav...@rot13.org changed: What|Removed |Added Attachment #31619|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12831] local only logins should still work when ldap authentication is enabled
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12831 Dobrica Pavlinusic dpav...@rot13.org changed: What|Removed |Added Status|Signed Off |In Discussion -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12986] Upgrade the DataTables jQuery plugin to the latest version
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12986 --- Comment #13 from Paola Rossi paola.ro...@cineca.it --- (In reply to Jonathan Druart from comment #11) Hello Paola, I found 2 bugs. I submitted 2 patches, 1 on bug 12987 (The new format_price include file should be include on using datatables) and 1 on bug 12989 (Fix JS error). I hope that will fixed your issues. Thanks, Jonathan. Sorry, it's not yet OK: I've applied these patches against master 3.17.00.025 : 12986, 12987 (2), 12955, 12988, 12984, 12989 (2) but no numbers neither in the Total row of acqui-home, nor in the Period allocated row of funds in /admin/aqbudgets.pl. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12831] local only logins should still work when ldap authentication is enabled
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12831 --- Comment #8 from Dobrica Pavlinusic dpav...@rot13.org --- Upon further investigation, I decided to obsolete my patch because I suspect that if fixes problem only for our particular installation instead of providing general solution to problem. Let me explain... Problem comes from the fact that in LDAP bind we can't distinguish between users which doesn't exist in LDAP and invalid passwords. Both of those return LDAP_INVALID_CREDENTIALS (in our installation we have a bit of LDAP software in between which creates invalid DN for users which are not in LDAP, but that is not generally applicable). This means that we have to know (somehow) weather users should use LDAP passwords or not. Currently we don't have that information. One possibility is to do LDAP search (anonymous or via some account) and if user does exist in LDAP force him to provide proper LDAP password. However, this might not be practical because it creates additional load on LDAP server on one hand, and on another anonymous searches might be disabled (that's probably why we are using auth_by_bind in the first place) or there might not be special user which can search whole LDAP (or library might not have permissions to add such user which is our case). Another possibility is to track locally in Koha if users should use LDAP or local passwords. This might be implemented simply by invalidating local password (with word LDAP for example :-) which would prevent local fallback from working if user is logged in using LDAP. I'm biased towards second solution but I would love to hear some feedback about it before producing code. However, in any case we don't have clear migration path for existing installations because they do have local LDAP passwords in database (like we do). After first LDAP login users will have local password invalidated, but users which never login with correct LDAP password (or who are already disabled) we still be able to login using cached password. To be quite honest, I did use that side-effect of old code which allowed our patrons to login while LDAP wasn't available, so it might even make sense to have that behavior again (as LDAP configuration option perhaps). But if that is the case, we again don't have ability to expire users just in LDAP and expect them to be disabled in Koha also. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11271] Serials table off the screen in smaller viewports
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11271 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|NEW |ASSIGNED Summary|serials table off the |Serials table off the |screen on low resolutions |screen in smaller viewports -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13020] Checkouts table default ordering is incorrect
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13020 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Severity|minor |normal -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13019] Add base classes on which to build Koha objects
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13019
--- Comment #5 from Kyle M Hall k...@bywatersolutions.com ---
(In reply to Jonathan Druart from comment #4)
I tried to make Koha::Borrower extends Koha::Schema::Result::Borrower, but I
get an error.
The idea was to remove the AUTOLOAD and avoid the IsStored, IsChanged, Id,
etc. methods.
[the error was: Unable to perform storage-dependent operations with a
detached result source (source '_unnamed_' is not associated with a schema)]
I suppose I tried to do something very bad :)
So, some additional remarks on the patch:
- result and columns should be _result and _columns to avoid collisions
later, don't you think?
Good idea
- Are you sure it is useful to test if the row is stored and has been
changed (Store method)? Not sure about the perf, maybe DBIC does that (?).
Yeah, I'd have to check the DBIC code, but that seems entirely likely.
- IsStored should be InStorage or completely removed, if useless.
Again, your probably right. I can't see a use for this right now and we can
always add an InStorage method at a later date if it *is* needed for something.
- Delete could call delete in an eval, to avoid a call to in_storage
Do you think that will improve efficiency? in_storage has already been
calculated and is just a dbic property. It seems like using eval would take
more time.
- what about 2 constructors? new and new_from_rs? The ResultSet should not
be create if not used later
For Koha::Object? That's a good idea.
- what about a _result method? It would return -{_result} if already
exists, otherwise create it. All occurrences to -{result} will be replaced
by -_result
Also a good idea.
I'll see if I can't make some time next week to implement these changes.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12775] Only suggestion manager can order from accepted suggestion
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12775 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #31891|0 |1 is obsolete|| --- Comment #7 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 31992 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31992action=edit [PASSED QA] Bug 12775: Suggestions should be ordered by anyone Currently only the suggestion manager can order from accepted suggestion. This patch set to default the ability to show all suggestions when ordering from a suggestion. 2 links show only mine and show all permits to filter/show all permissions. Test plan: Create an order from a suggestion and verify you are able to see all suggestions by default. Verify the show only mine link works as expected. Signed-off-by: Paola Rossi paola.ro...@cineca.it Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12775] Only suggestion manager can order from accepted suggestion
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12775 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12538] Solr removal
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12538 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #31817|0 |1 is obsolete|| Attachment #31819|0 |1 is obsolete|| --- Comment #12 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 31993 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31993action=edit [PASSED QA] Bug 12538: Remove Solr without breaking anything else Since nobody is currently working on the zebra layer introduced by bug 8233, Solr won't never work. Some code has been introduced in 3.10 to prove several search engines can cohabit into Koha but no help/fund has been found to go ahead. It is useless to keep this code and to maintain an ambiguous situation. I think the indexes configuration page could be restore later if someone else introduces a new search engine into Koha. Test plan: Look at the code introduced by bug 8233 and verify all is removed. Signed-off-by: Chris Cormack chr...@catalyst.net.nz Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12538] Solr removal
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12538 --- Comment #13 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 31994 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31994action=edit [PASSED QA] Bug 12538 : FOLLOW UP Remove Moose from the list of dependencies Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12538] Solr removal
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12538 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11271] Serials table off the screen in smaller viewports
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11271 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11271] Serials table off the screen in smaller viewports
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11271 --- Comment #3 from Owen Leonard oleon...@myacpl.org --- Created attachment 31995 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31995action=edit Bug 11271 - Serials table off the screen in smaller viewports When you search for serials in the Serials module the results table is often too wide for the screen (depending on your browser window size). This is partly due to the fixed width of the search fields in the table footer. This patch applies a flexible width to those inputs and reduces the font size of their text. This patch also moves the action links for each table row into an action menu (similar to the change made by Bug 10615 in Reports) to further conserve screen space. This patch also revises the page's DataTables configuration to use table header classes for sorting configuration. To test you should be able to perform a search which returns multiple open and closed subscriptions. - Test that table sorting works correctly, including for titles with articles and for dates. - Test that the Action menu items work correctly and that they correctly reflect the permissions of the logged-in user with regard to receive_serials and routing. - Perform these tests on both the Open and Closed tabs. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12986] Upgrade the DataTables jQuery plugin to the latest version
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12986 Zeno Tajoli z.taj...@cineca.it changed: What|Removed |Added Status|In Discussion |Patch doesn't apply Patch complexity|--- |Medium patch --- Comment #14 from Zeno Tajoli z.taj...@cineca.it --- Hi to all, I think to have finish the basic check asked comment #2. There are two points that emerge as important: -- Support of IE6/IE7 -- Interaction with plugins of this plugin. a)Support of IE6/IE7 Discussions on chat and mailing list give as answer: we can drop support of IE6/IE7; http://lists.katipo.co.nz/pipermail/koha/2014-October/040960.html, http://lists.koha-community.org/pipermail/koha-devel/2014-October/040836.html, http://irc.koha-community.org/koha/2014-10-01#i_1575703, http://irc.koha-community.org/koha/2014-10-02#i_1575984 b)Interaction with plugins of this plugin. There three plugin of DataTables in Koha, they are in intranet-tmpl/lib/jquery/plugins/ 1) jquery.dataTables.colvis.js Written from the same firm that write DataTables, update to new version of DataTables. 2) jquery.dataTables.rowGrouping.js We use the last version, there are same minir problems,the best option is to use old 1.9 API when you is plugin, see https://code.google.com/p/jquery-datatables-row-grouping/issues/detail?id=75sort=-id 3) jquery.dataTables.columnFilter.js We don't use the last version, there is a patch to improve compatibility with v.1.10, https://code.google.com/p/jquery-datatables-column-filter/issues/detail?id=158sort=-id So my idea is that: -- We can update -- We need to update also plugins. So, now for me 'Patch doesn't apply' because you don't update plugin. I think that a patch to test needs: 1) update DataTables to v 1.10 2) update query.dataTables.colvis.js 3) evalute if update or not query.dataTables.columnFilter.js and insert or not the patch linked. Bye -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9495] split NotesBlacklist in to two prefs for staff and OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9495 bondiurbano cost...@gmail.com changed: What|Removed |Added CC||cost...@gmail.com --- Comment #1 from bondiurbano cost...@gmail.com --- It would be very nice...3.16.4 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
