[Koha-bugs] [Bug 11563] Class noEnterSubmit no longer functioning
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11563
--- Comment #42 from bondiurbano ---
(In reply to Katrin Fischer from comment #41)
> Hi Bondiurbano, can you please open a separate bug (linking to this) with a
> problem description?
>
> I think if the problem is in 3.16.4 it's likely also in master, so this
> version should be used.
DONE! See bug 13080 addClass('noEnterSubmit') no longer functioning for 5xx
tags while cataloging
Thank you Katrin!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13080] addClass('noEnterSubmit') no longer functioning for 5xx tags while cataloging
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13080 bondiurbano changed: What|Removed |Added Priority|P5 - low|P2 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13080] New: addClass('noEnterSubmit') no longer functioning for 5xx tags while cataloging
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13080
Bug ID: 13080
Summary: addClass('noEnterSubmit') no longer functioning for
5xx tags while cataloging
Change sponsored?: ---
Product: Koha
Version: 3.16
Hardware: All
OS: All
Status: NEW
Severity: major
Priority: P5 - low
Component: Cataloging
Assignee: gmcha...@gmail.com
Reporter: cost...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl
Created attachment 32293
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32293&action=edit
noEnterSubmit
Tested in koha-common 3.16.4.
When trying to input text in a textarea html tag while cataloging the "intro"
key does not funcion.
Needs to fix file intranet-tmpl/prog/*LANG*/js/cataloging.js
In LINE 486 erase 'noEnterSubmit' parameter in function addClass.
So:
-$(".input_marceditor, .indicator").addClass('noEnterSubmit');
+$(".input_marceditor, .indicator").addClass('');
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13031] create_koc_db.pl shows error Can't locate C4/Context.pm in @INC on execution
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13031 Katrin Fischer changed: What|Removed |Added Status|NEW |RESOLVED CC||katrin.fisc...@bsz-bw.de Resolution|--- |INVALID --- Comment #1 from Katrin Fischer --- Hi, this looks like you were running the script without the environment variables being set. If you are using packages, you can use the koha shell that will set them correctly for the instance you want to run the script for. If you need more help, please try the mailing list, thx! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12888] ODT not exporting all results
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12888 Katrin Fischer changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #4 from Katrin Fischer --- *** This bug has been marked as a duplicate of bug 12622 *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12622] Exporting report as Open Document Spreadsheet results in Perl error when report has no results
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12622 Katrin Fischer changed: What|Removed |Added CC||neng...@gmail.com --- Comment #8 from Katrin Fischer --- *** Bug 12888 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12622] Exporting report as Open Document Spreadsheet results in Perl error when report has no results
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12622 Katrin Fischer changed: What|Removed |Added CC||karamqu...@gmail.com --- Comment #7 from Katrin Fischer --- *** Bug 13010 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13010] last row missing in exported report if it is (Open document spreadsheet)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13010 Katrin Fischer changed: What|Removed |Added Status|NEW |RESOLVED CC||katrin.fisc...@bsz-bw.de Resolution|--- |DUPLICATE --- Comment #1 from Katrin Fischer --- This should be fixed in 3.16.4 by bug 12622, please reopen the bug if you can still see the problem there. *** This bug has been marked as a duplicate of bug 12622 *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11563] Class noEnterSubmit no longer functioning
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11563 --- Comment #41 from Katrin Fischer --- Hi Bondiurbano, can you please open a separate bug (linking to this) with a problem description? I think if the problem is in 3.16.4 it's likely also in master, so this version should be used. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9495] split NotesBlacklist in to two prefs for staff and OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9495 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Version|3.16|master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12862] HTML fixes triggered by cleaning up language="javascript"
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12862 --- Comment #12 from M. Tompsett --- (In reply to M. Tompsett from comment #0) > Tweak the
[Koha-bugs] [Bug 12364] Useless use of '\'; doesn't escape metacharacter '('
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12364
Marco Moreno changed:
What|Removed |Added
Priority|P5 - low|P3
CC||mmor...@pobox.com
--- Comment #1 from Marco Moreno ---
This is due to unnecessary escapes inside a bracketed character class.
Locate C4/AuthoritiesMarc.pm (for me it was in /usr/share/koha/lib) and replace
line 856 containing this:
my
$filtervalues=qr([\001-\040\!\'\"\`\#\$\%\&\*\+,\-\./:;<=>\?\@\(\)\{\[\]\}_\|\~]);
with this:
my $filtervalues=qr([\001-\040!'"`#$%&*+,\-.:;<=>?@(){}\[\]_|~]);
(See 'man perlrecharclass' under the section 'Special Characters Inside a
Bracketed Character Class'.)
I raised this to medium importance due to getting flooded with cron emails
every 5 minutes. And if nullmailer is not configured immediately after
installation, log files will grow to enormous sizes. (In just a few weeks, my
logs grew to well over 10GB and I ran out of disk space.)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 1092] might be nice to have cookie keep track of patron.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1092 Jared Camins-Esakov changed: What|Removed |Added CC|jcam...@cpbibliography.com | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 1092] might be nice to have cookie keep track of patron.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1092
--- Comment #5 from Michael Hafen ---
(In reply to Katrin Fischer from comment #4)
> Michael, could you explain a bit more how this should work?
Sure... I was going to use the cookie tracking from reserves, but I wasn't able
to find it. So I'll have to explain this using my own, very out-dated, code.
This would effect a few pages: circ/circulation.pl, circ/returns.pl,
circ/renew.pl, reserve/request.pl, members/moremember.pl
In circulation, request, and moremember you could have code like:
$borrowernumber = $query->param('borrowernumber') ||
$session->param('borrowernumber');
And in all the pages there would be code like:
if ( $borrower->{borrowernumber} != $session->param('borrowernumber') {
$session->param('borrowernumber', $borrower->{borrowernumber});
}
With code like this when a borrower's record is loaded through a search, that
borrower's number is stored in the session. After that any access to pages
that require a borrower's record to be loaded can present the most recently
found borrower by pulling their number from the session instead of the
librarian having to search for them. It's most useful in going into the
reserves/request.pl page, which is why there is/used to be code to do the same
thing using a cookie. I think there are links into moremember from return and
renew, so this feature isn't as useful there. Though I have added a link
directory to circulation to the top menu, and to the list on the return page so
that circulation is one click closer there.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13079] New: error en prestamo
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13079
Bug ID: 13079
Summary: error en prestamo
Change sponsored?: ---
Product: Koha
Version: 3.16
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: About
Assignee: neng...@gmail.com
Reporter: ernesto...@hotmail.com
QA Contact: testo...@bugs.koha-community.org
Software error:
Invalid local time for date in time zone: America/Santiago
For help, please send mail to the webmaster (webmaster@Biblioteca), giving this
error message and the time and date of the error.
Software error: en préstamo
[Fri Oct 10 12:30:54 2014] circulation.pl: Invalid local time for date in time
zone: America/Santiago
at /usr/share/perl5/CGI/Carp.pm line 379.
CGI::Carp::realdie('[Fri Oct 10 12:30:54 2014] circulation.pl: Invalid
local time...') called at /usr/share/perl5/CGI/Carp.pm line 475
CGI::Carp::die('Invalid local time for date in time zone:
America/Santiago\x{a}') called at /usr/local/share/perl5/DateTime/TimeZone.pm
line 198
DateTime::TimeZone::_span_for_datetime('DateTime::TimeZone::America::Santiago=HASH(0xbc0de30)',
'local', 'DateTime=HASH(0xbc05440)') called at
/usr/local/share/perl5/DateTime/TimeZone.pm line 157
DateTime::TimeZone::offset_for_local_datetime('DateTime::TimeZone::America::Santiago=HASH(0xbc0de30)',
'DateTime=HASH(0xbc05440)') called at /usr/local/lib/perl5/DateTime.pm line 930
DateTime::_offset_for_local_datetime('DateTime=HASH(0xbc05440)') called at
/usr/local/lib/perl5/DateTime.pm line 375
DateTime::_calc_utc_rd('DateTime=HASH(0xbc05440)') called at
/usr/local/lib/perl5/DateTime.pm line 263
DateTime::_new('DateTime', 'hour', 11, 'second', 54, 'month', 10, 'locale',
'DateTime::Locale::en_US=HASH(0xad33fd0)', ...) called at
/usr/local/lib/perl5/DateTime.pm line 299
DateTime::_new_from_self('DateTime=HASH(0xbc00da0)', 'hour', 0, 'minute',
0, 'second', 0, 'month', 10, ...) called at /usr/local/lib/perl5/DateTime.pm
line 1940
DateTime::truncate(undef, 'to', 'day') called at
/usr/share/koha/lib/Koha/Calendar.pm line 189
Koha::Calendar::is_holiday('Koha::Calendar=HASH(0xbc05130)',
'DateTime=HASH(0xbc057e0)') called at /usr/share/koha/lib/Koha/Calendar.pm line
226
Koha::Calendar::next_open_day('Koha::Calendar=HASH(0xbc05130)',
'DateTime=HASH(0xbc050f0)') called at /usr/share/koha/lib/Koha/Calendar.pm line
157
Koha::Calendar::addDays('Koha::Calendar=HASH(0xbc05130)',
'DateTime=HASH(0xbbfe680)', 'DateTime::Duration=HASH(0xbc05bb0)') called at
/usr/share/koha/lib/Koha/Calendar.pm line 110
Koha::Calendar::addDate('Koha::Calendar=HASH(0xbc05130)',
'DateTime=HASH(0xbbfe680)', 'DateTime::Duration=HASH(0xbc05bb0)', 'days')
called at /usr/share/koha/lib/C4/Circulation.pm line 3037
C4::Circulation::CalcDateDue('DateTime=HASH(0xbbfe680)', 'RF', 'TPL',
'HASH(0xbb39008)') called at /usr/share/koha/lib/C4/Circulation.pm line 715
C4::Circulation::CanBookBeIssued('HASH(0xbb39008)', 0506, undef, undef)
called at /usr/share/koha/intranet/cgi-bin/circ/circulation.pl line 284
For help, please send mail to the webmaster (webmaster@Biblioteca), giving this
error message and the time and date of the error.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13077] Error de devolucion
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13077 ernesto...@hotmail.com changed: What|Removed |Added CC||ernesto...@hotmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13078] New: Error de devolucion
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13078
Bug ID: 13078
Summary: Error de devolucion
Change sponsored?: ---
Product: Koha
Version: unspecified
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: About
Assignee: neng...@gmail.com
Reporter: ernesto...@hotmail.com
QA Contact: testo...@bugs.koha-community.org
Software error: Devolución
Can't call method "subfield" on an undefined value at
/usr/share/koha/lib/C4/Biblio.pm line 3008.
at /usr/share/koha/lib/C4/Biblio.pm line 3008.
C4::Biblio::_AddBiblioNoZebra(652, undef, 'biblioserver') called at
/usr/share/koha/lib/C4/Biblio.pm line 2769
C4::Biblio::ModZebra(652, 'specialUpdate', 'biblioserver', undef, undef)
called at /usr/share/koha/lib/C4/Items.pm line 552
C4::Items::ModItem('HASH(0xafee048)', 652, 1088) called at
/usr/share/koha/lib/C4/Circulation.pm line 1782
C4::Circulation::AddReturn(0774, 'TPL', 0) called at
/usr/share/koha/intranet/cgi-bin/reserve/renewscript.pl line 121
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13077] New: Error de devolucion
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13077
Bug ID: 13077
Summary: Error de devolucion
Change sponsored?: ---
Product: Koha
Version: unspecified
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: About
Assignee: neng...@gmail.com
Reporter: ernesto...@hotmail.com
QA Contact: testo...@bugs.koha-community.org
Software error: Devolución
Can't call method "subfield" on an undefined value at
/usr/share/koha/lib/C4/Biblio.pm line 3008.
at /usr/share/koha/lib/C4/Biblio.pm line 3008.
C4::Biblio::_AddBiblioNoZebra(652, undef, 'biblioserver') called at
/usr/share/koha/lib/C4/Biblio.pm line 2769
C4::Biblio::ModZebra(652, 'specialUpdate', 'biblioserver', undef, undef)
called at /usr/share/koha/lib/C4/Items.pm line 552
C4::Items::ModItem('HASH(0xafee048)', 652, 1088) called at
/usr/share/koha/lib/C4/Circulation.pm line 1782
C4::Circulation::AddReturn(0774, 'TPL', 0) called at
/usr/share/koha/intranet/cgi-bin/reserve/renewscript.pl line 121
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8337] System preferences for longoverdue cron
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8337 --- Comment #27 from M. de Rooy --- Created attachment 32290 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32290&action=edit Bug 8337 - Added prefs to sysprefs and updatedatabase Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8337] System preferences for longoverdue cron
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8337 --- Comment #29 from M. de Rooy --- Created attachment 32292 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32292&action=edit Bug 8337: Small typo in usage statement for longoverdue.pl The charge with the replacement price will only be made if the charge parameter matches the lost value. The given example is faulty (as well as some of the code, as it appears ;) Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8337] System preferences for longoverdue cron
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8337 --- Comment #28 from M. de Rooy --- Created attachment 32291 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32291&action=edit Bug 8337 - Follow-up to Comment 13 Fixed QA script issues. Syspref names are now camelcased and sorted correctly in sysprefs.sql. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8337] System preferences for longoverdue cron
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8337 M. de Rooy changed: What|Removed |Added Attachment #17393|0 |1 is obsolete|| Attachment #30944|0 |1 is obsolete|| Attachment #32288|0 |1 is obsolete|| --- Comment #26 from M. de Rooy --- Created attachment 32289 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32289&action=edit Bug 8337 System preferences for longoverdue cron Patch to follow that adds 3 new system preferences to control the parameters for the longoverdue script. New prefs are DefaultLongOverdueChargeValue, DefaultLongOverdueLostValue and DefaultLongOverdueDays. These preferences are used when you call the longoverdue.pl script without their parameters. Sponsored-By: CCSR Signed-off-by: Leila and Fridos help Signed-off-by: Kyle M Hall Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8337] System preferences for longoverdue cron
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8337 M. de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8337] System preferences for longoverdue cron
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8337 M. de Rooy changed: What|Removed |Added Attachment #30639|0 |1 is obsolete|| --- Comment #25 from M. de Rooy --- Created attachment 32288 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32288&action=edit Bug 8337 - Added the sysprefs to the database scripts. modified: installer/data/mysql/sysprefs.sql modified: installer/data/mysql/updatedatabase.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8337] System preferences for longoverdue cron
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8337 M. de Rooy changed: What|Removed |Added Patch complexity|--- |Small patch QA Contact||m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8337] System preferences for longoverdue cron
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8337 --- Comment #24 from M. de Rooy --- (In reply to Anthony Laquerre from comment #19) > In a context of school library systems such preferences are likely to change > on average 2-3 times per year. > Unfortulalty, many library does not have the money available to make > requests for changes to IT company. > > Unlike Jonathan, I beleive that each cronjob parameter useful for the end > user should be in the sys pref table. > This allows the librarian to make his own choix and not always having to go > through a process of change by the IT provider. In some command-line scripts preferences are used too (e.g. look at finesMode in fines.pl). So, an exception can always be made. Still, the principle is that cronjobs get their parameters on the command line. A lot of people may be able to access the preferences and change them by incident, the crontab file needs root privileges. So further away, but safe. If someone occassionally changes this pref, he may not even realize that a cron job will later use the value. The fact that you add them as fallback, makes it somewhat better. If you put them in the crontab, you should not fear the pref values anymore ;) Will look if the description of the prefs still needs some tweaking.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 M. de Rooy changed: What|Removed |Added Status|Signed Off |Failed QA CC||m.de.r...@rijksmuseum.nl --- Comment #17 from M. de Rooy --- QA Comment: I agree with Jonathan that we should move shared code into a module. That should not be so much work. If you would not have unit tests rightaway, I could live with that argumenting that we do not have these unit tests at this moment also and you are just moving code. If you could write them or at least a simple start, you would receive bonus points of course ;) Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11425] Search form for items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11425 M. de Rooy changed: What|Removed |Added Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11425] Search form for items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11425 --- Comment #35 from M. de Rooy --- CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/admin/admin-home.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/includes/admin-menu.inc Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Auto-merging installer/data/mysql/kohastructure.sql CONFLICT (content): Merge conflict in installer/data/mysql/kohastructure.sql Auto-merging C4/Items.pm Auto-merging C4/Installer/PerlDependencies.pm CONFLICT (content): Merge conflict in C4/Installer/PerlDependencies.pm -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12607] TestBuilder - Refactoring Acquisition/GetBasketsInfosByBookseller.t
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12607 M. de Rooy changed: What|Removed |Added Status|Signed Off |Patch doesn't apply CC||m.de.r...@rijksmuseum.nl --- Comment #3 from M. de Rooy --- CONFLICT (content): Merge conflict in t/db_dependent/Acquisition/GetBasketsInfosByBookseller.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12606] TestBuilder - Refactoring Acquisition/GetOrdersByBiblionumber.t
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12606 M. de Rooy changed: What|Removed |Added Status|Signed Off |Patch doesn't apply CC||m.de.r...@rijksmuseum.nl --- Comment #3 from M. de Rooy --- CONFLICT (content): Merge conflict in t/db_dependent/Acquisition/GetOrdersByBiblionumber.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12605] TestBuilder - Refactoring Acquisition/close_reopen_basket.t
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12605 M. de Rooy changed: What|Removed |Added Status|Signed Off |Patch doesn't apply --- Comment #3 from M. de Rooy --- CONFLICT (content): Merge conflict in t/db_dependent/Acquisition/close_reopen_basket.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12605] TestBuilder - Refactoring Acquisition/close_reopen_basket.t
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12605 M. de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl Version|unspecified |master QA Contact|gmcha...@gmail.com |m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12604] TestBuilder - Refactoring Category.t
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12604 M. de Rooy changed: What|Removed |Added Attachment #30088|0 |1 is obsolete|| --- Comment #3 from M. de Rooy --- Created attachment 32287 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32287&action=edit Bug 12604: refactoring Category.t with TestBuilder The tests have been refactored with the module TestBuilder. Test plan: 1/ Apply the patch 12603 2/ The command : prove t/db_dependent/Category.t has to be a success without error or warning : t/db_dependent/Category.t .. ok All tests successful. Files=1, Tests=3, 1 wallclock secs ( 0.03 usr 0.01 sys + 1.05 cusr 0.05 csys = 1.14 CPU) Result: PASS Signed-off-by: Kyle M Hall Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12604] TestBuilder - Refactoring Category.t
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12604 M. de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12604] TestBuilder - Refactoring Category.t
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12604 M. de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl Version|unspecified |master QA Contact|gmcha...@gmail.com |m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12603] TestBuilder - Module to simplify the writing of tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12603 M. de Rooy changed: What|Removed |Added Attachment #30087|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12603] TestBuilder - Module to simplify the writing of tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12603 M. de Rooy changed: What|Removed |Added Attachment #30086|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12603] TestBuilder - Module to simplify the writing of tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12603 M. de Rooy changed: What|Removed |Added QA Contact|martin.renvoize@ptfs-europe |m.de.r...@rijksmuseum.nl |.com| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12603] TestBuilder - Module to simplify the writing of tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12603 M. de Rooy changed: What|Removed |Added Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12603] TestBuilder - Module to simplify the writing of tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12603 --- Comment #17 from M. de Rooy --- Created attachment 32285 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32285&action=edit Bug 12603: creating TestBuilder to simplify tests This patch contains a new module t::lib::TestBuilder which allows to write tests easier and it contains the unit tests of this module. For more information, see the documentation of the module. This module uses the DBIx::Class schema and works with a clean DBIx::Class schema. In order to use it, you have to remove the current circular dependence (existing in the DBIx::Class) by applying the last patch of the bug 11518. Signed-off-by: Kyle M Hall Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12603] TestBuilder - Module to simplify the writing of tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12603
--- Comment #19 from M. de Rooy ---
General commment:
The comment on has_one should not block this patch imo (see comment16).
[Removing the belongs_to as in bug 11518 also addresses this problem.]
The code, including some less obvious things, contains very little comments
(see also the comment of Martin about documentation).
The composite foreign keys like in the overduerules_transport_type are handled
by a trick: copy the hash from the first composite key to the other one(s). The
code in build() looks at the first key of a composite one when searching for
values. Using TestBuilder with such a table is not (immediately) clear. (And
obviously, code with such trics may not be the easiest to maintain..)
I suppose that a table with multiple composite foreign keys sharing the same
key could present a problem. I could not find an example in Koha though ;)
Passes qa script.
I will pass QA on this code, but somewhat hesitant. Note that I do not view
TestBuilder as the only way to write a test now in Koha and would not per se
recommend refactoring of existing tests. It is just an alternative.
Small remarks:
+$my_overduerules_transport_type->{categorycode} =
$my_overduerules_transport_type->{branchcode};
+my $overduerules_transport_type = $builder->build({
+source => 'OverduerulesTransportType',
+value => $my_overduerules_transport_type,
+});
o my: my $overdue.. and $my_overdue.. Example of obscure variable naming?
+$source =~ s|(\w+)$|$1|;
What are you actually changing here?
+our $default_value = {
+UserPermission => {
TestBuilder.t contains the default value for UserPermission. Should not block
this patch, but I would rather have it somewhere else. Separate module perhaps?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12603] TestBuilder - Module to simplify the writing of tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12603 --- Comment #18 from M. de Rooy --- Created attachment 32286 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32286&action=edit Bug 12603 [QA Followup] * Fix syntax error * Remove Schema files for nonexistant tables * Fix circular dependency * Makes unpushed followup for bug 11518 unnessary Signed-off-by: Kyle M Hall Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12603] TestBuilder - Module to simplify the writing of tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12603 M. de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12630] Prioritizing "Hold starts on date" -holds causes all other holds to be prioritized as well!
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12630 --- Comment #13 from Olli-Antti Kivilahti --- Sorry I can't atm. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10993] Transfer limits should be checked when placing a hold/reservation in OPAC.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10993 Olli-Antti Kivilahti changed: What|Removed |Added Assignee|olli-antti.kivila...@jns.fi |koha-b...@lists.koha-commun ||ity.org --- Comment #13 from Olli-Antti Kivilahti --- Sorry, I cannot work on this currently. I will let this slide to the next one who encounters this issue and wants to fix it. Hopefully using some of my code :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12993] Add a default tax rate on item types
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12993
Julian Maurice changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--- Comment #10 from Julian Maurice ---
Could you test it again ?
Note that it works only when syspref item-level_itypes is OFF ("Use the item
type of the biblio record").
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12993] Add a default tax rate on item types
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12993 --- Comment #9 from Julian Maurice --- Created attachment 32284 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32284&action=edit Bug 12993: Select automatically itemtype on neworderempty.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12993] Add a default tax rate on item types
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12993 --- Comment #8 from Julian Maurice --- (In reply to Paola Rossi from comment #7) > Ordering from a BK suggestion [or from an empty record] I've seen 23% in the > tax rate of the order: it's the vendor' tax rate, instead of the expected > tax rate 5% of the BK' itemtype (ERROR). I think this is due to the fact that suggestion's itemtype is not being selected automatically. I'll provide a patch for that. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11926] HEA - Render community koha statistic usages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11926 Fridolin SOMERS changed: What|Removed |Added CC||fridolyn.som...@biblibre.co ||m --- Comment #24 from Fridolin SOMERS --- The patch needs something : Bug 11926: Add a cronjob It adds the cronjob script with permissions 644 instead of 755 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
