[Koha-bugs] [Bug 9859] C4::Charset - nsb_clean() remove Â

2014-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9859

--- Comment #14 from mathieu saby mathsaby...@gmail.com ---
Hello
That's pretty old, I don't remember this bug at all, and I won't test it again
;-)
Do you mean in your previous comment that for you the patch is OK?

If so, let's wait for QA.

Mathiue

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9859] C4::Charset - nsb_clean() remove Â

2014-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9859

--- Comment #15 from stephane.dela...@biblibre.com ---
(In reply to mathieu saby from comment #14)
 Hello
 That's pretty old, I don't remember this bug at all, and I won't test it
 again ;-)
 Do you mean in your previous comment that for you the patch is OK?
 
 If so, let's wait for QA.
 
 Mathiue

Yes the patch is ok

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13084] Prevent mixup of columns in deletedborrowers

2014-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13084

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13084] Prevent mixup of columns in deletedborrowers

2014-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13084

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

  Attachment #32378|0   |1
is obsolete||
  Attachment #32381|0   |1
is obsolete||

--- Comment #11 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Created attachment 32394
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32394action=edit
Bug 13084 - Improve t/db_dependent/Members.t test coverage

Added a MoveMemberToDeleted set of tests.

TEST PLAN
-
1) prove -v t/db_dependent/Members.t
   -- all should pass.
2) Run koha QA tests.

Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13084] Prevent mixup of columns in deletedborrowers

2014-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13084

--- Comment #12 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Created attachment 32395
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32395action=edit
Bug 13084: Mixup of columns in deletedborrowers (MASTER)

I could reproduce this problem in 3.14.4 where I wrote the patch.
Fields shifted like branchcode moved to B_phone.
Could not reproduce it for master.
But this code change seems to improve things on master too.

TEST PLAN
-
1) Alter the order of your deletedborrowers table.
   e.g. alter table deletedborrowers change column privacy privacy int(11)
after city;
2) Apply the 3.14.x test patch.
3) prove -v t/db_dependent/Members.t
   -- Will fail on the new test.
4) Apply the 3.14.x code change patch.
5) prove -v t/db_dependent/Members.t
   -- Will succeed on the new test.
6) run koha qa test tools.

Signed-off-by: Mark Tompsett mtomp...@hotmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13084] Prevent mixup of columns in deletedborrowers

2014-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13084

--- Comment #13 from M. de Rooy m.de.r...@rijksmuseum.nl ---
(In reply to M. Tompsett from comment #7)
 By the way, I only think the mix ups occur if your deletedborrowers and
 borrowers have the fields in different order. Mine were identical. I tested
 my tests on a plain master.

I compared the order of my 3.14 tables and had two differences:
| smsalertnumber  | varchar(50)  | YES  | | NULL|   |
| privacy | int(11)  | YES  | | NULL|   |
In deletedborrowers they were in the middle, in borrowers at the end.
I looked at kohastructure, but that is fine.
I looked in updatedatabase, and it also does not explain this phenomenon..

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13084] Prevent mixup of columns in deletedborrowers

2014-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13084

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

  Attachment #32379|0   |1
is obsolete||

--- Comment #14 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Created attachment 32396
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32396action=edit
Bug 13084 - Improve t/db_dependent/Members.t test coverage (3.14 Version)

Added a MoveMemberToDeleted set of tests.

TEST PLAN
-
1) prove -v t/db_dependent/Members.t
   -- all should pass.
2) Run koha QA tests.

Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13084] Prevent mixup of columns in deletedborrowers

2014-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13084

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13084] Prevent mixup of columns in deletedborrowers

2014-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13084

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

  Attachment #32380|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13084] Prevent mixup of columns in deletedborrowers

2014-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13084

--- Comment #15 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Created attachment 32397
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32397action=edit
Bug 13084: Mixup of columns in deletedborrowers (3.14 version)

I could reproduce this problem in 3.14.4 where I wrote the patch.
Fields shifted like branchcode moved to B_phone.
Could not reproduce it for master.
But this code change seems to improve things on master too.

NOTE: The callers of this routine should use the return value to check,
and not simply assume that it will be fine ;) Changing those places is
out of the scope of this report.

TEST PLAN
-
1) Alter the order of your deletedborrowers table.
   e.g. alter table deletedborrowers change column privacy privacy int(11)
after city;
2) Apply the 3.14.x test patch.
3) prove -v t/db_dependent/Members.t
   -- Will fail on the new test.
4) Apply the 3.14.x code change patch.
5) prove -v t/db_dependent/Members.t
   -- Will succeed on the new test.
6) run koha qa test tools.

Signed-off-by: Mark Tompsett mtomp...@hotmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13068] New feature for DB update and sandbox

2014-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

  Attachment #32300|0   |1
is obsolete||

--- Comment #18 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Created attachment 32398
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32398action=edit
[COUNTERPATCH] Bug 13068: Counterpatch using atomicupdate directory

This patch makes a distinction between atomicupdates belonging to an
official db revision and development updates.
It also keeps track of the dev updates since the last official db rev.
(This is done via a local pref; so easily accessible if needed.)

The db revs can be txt files, perl scripts or sql files.
Sql files are run via the installer.

A new db revision is now only a matter of dropping a file in atomicupdates
for the developer. The RM only adds one line to updatedatabase like:
ExecDBRev( $aupd, '13068', 'Refined dbrev', '13068.pl', '3.17.00.028');

Amended on Oct 16: Promoted the two debugging prints to actual prints. They
will be helpful for any developer. Added a sort for safety. Added some POD
comments.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13068] New feature for DB update and sandbox

2014-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068

--- Comment #19 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Created attachment 32399
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32399action=edit
Bug 13068: Counterpatch follow-up for controlling workflow

The workflow for dev updates can be altered with pref DevUpdateControl:
[1] DevUpdateControl= PROD for production machines: Do not execute
RunRemainingDevUpdates, so only official db revs. This is the default.
[2] DevUpdateControl= RESET: Reinstall dev updates after each official db rev.
[3] DevUpdateControl= ALWAYS: Run the dev updates at each upgrade.
[4] DevUpdateControl=TRACK: Only install new dev updates. It does not reset
the local pref listing all recently applied dev updates. ONLY use this
if you know what you are doing!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13068] New feature for DB update and sandbox

2014-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068

--- Comment #20 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Added the last patch to illustrate my comment17.
If we want to continue on this road, I will add a real db rev to insert this
pref and add it to admin.pref. And write some unit tests.
First I will wait for your comments and testing.
So to test the various devupdatecontrol modes, add it at the Local Use tab and
toggle between its different modes.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13050] Follow-up for bug 12371 on self-registration verification notice

2014-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13050

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

Summary|Follow-up for bug 12371 |Follow-up for bug 12371 on
   ||self-registration
   ||verification notice

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13082] tools/export.pl fix to forbid adding of all invalid records

2014-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13082

stephane.dela...@biblibre.com changed:

   What|Removed |Added

   Priority|P5 - low|P3
   Severity|enhancement |normal

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13085] bugfix : tools/export.pl don't works in commandline without id_list_file parameter

2014-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13085

stephane.dela...@biblibre.com changed:

   What|Removed |Added

   Priority|P5 - low|P2
   Severity|enhancement |critical

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12229] tools/export.pl fix to forbid adding of invalid records

2014-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12229

Fridolin SOMERS fridolyn.som...@biblibre.com changed:

   What|Removed |Added

 CC||fridolyn.som...@biblibre.co
   ||m

--- Comment #5 from Fridolin SOMERS fridolyn.som...@biblibre.com ---
Pushed to 3.14.x, will be in 3.14.12

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7442] Crash when selecting an authority with 200$x or 200$y

2014-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7442

Fridolin SOMERS fridolyn.som...@biblibre.com changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable

--- Comment #28 from Fridolin SOMERS fridolyn.som...@biblibre.com ---
Pushed to 3.14.x, will be in 3.14.12

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13023] Nonpublic note for items should be mapped to a database column like itemnotes

2014-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13023

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12005] Zebra searches sometimes fail silently under Plack

2014-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12005

--- Comment #23 from Jacek Ablewicz a...@biblos.pk.edu.pl ---
(In reply to Chris Cormack from comment #22)
 I have squashed the 2 patches and made it destroy any old connection before
 making a new one. Jacek could you please give it a test?

It's looking good so far; this modified patch version works fine for me while
testing both under plain CGI and under apache (prefork) + mod_perl. No apparent
side effects like before (not counting that some command line scripts are
runnig significantly slower when Zconn caching is not being used any longer).
Regarding those scripts: I'm wondering if something like that:

 my $cache_key = join ('::', (map { $_ // '' } ($server, $async )));
+if ( (!defined($ENV{GATEWAY_INTERFACE})) 
defined($context-{Zconn}-{$cache_key})  (0 ==
$context-{Zconn}-{$cache_key}-errcode()) ) {
+return $context-{Zconn}-{$cache_key};
+}

would be good (or at least good enough ;) solution for adressing performance
hit on the cmd line scripts? It seems to work OK under CGI and mod_perl, but
I'm not sure how reliable checking for GATEWAY_INTERFACE environment variable
(especially when being done in the module, and not in the script) may be for
other various persistent setups?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13023] Nonpublic note for items should be mapped to a database column like itemnotes

2014-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13023

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #31980|0   |1
is obsolete||

--- Comment #4 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 32400
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32400action=edit
Bug 13023 - Nonpublic note for items should be mapped to a database column like
itemnotes

An item's public notes are mapped to a db column, but the librarian only
notes are not. We need to map these so in the future we may display them
in places other than the editor.

Test Plan:
1) Create an item with a non-public note
2) Apply this patch
3) Run updatedatabase
4) Run misc/migration_tools/copy_item_xml_field_to_db.pl --subfield x --column
itemnotes_nonpublic -c -v
5) Inspect the database, note that your non-public note is now in
   items.itemnotes_nonpublic

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13023] Nonpublic note for items should be mapped to a database column like itemnotes

2014-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13023

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #32400|0   |1
is obsolete||

--- Comment #5 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 32401
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32401action=edit
Bug 13023 - Nonpublic note for items should be mapped to a database column like
itemnotes

An item's public notes are mapped to a db column, but the librarian only
notes are not. We need to map these so in the future we may display them
in places other than the editor.

Test Plan:
1) Create an item with a non-public note
2) Apply this patch
3) Run updatedatabase
4) Update your frameworks to map your nonpublic item note to
items.itemnotes_nonpublic
5) Run misc/migration_tools/copy_item_xml_field_to_db.pl --subfield x --column
itemnotes_nonpublic -c -v
6) Inspect the database, note that your non-public note is now in
   items.itemnotes_nonpublic

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13023] Nonpublic note for items should be mapped to a database column like itemnotes

2014-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13023

--- Comment #6 from Kyle M Hall k...@bywatersolutions.com ---
Thanks for testing! The script touch_all_items does not do quite what I thought
it did. We need a facility to copy data from more_subfields_xml to the
database. As far as I can tell Koha does not have one, so I've written a script
to do so and have included it in the patch. Please give it another try! Please
note I've updated the test plan to include this.

(In reply to Nick Clemens from comment #3)
 I tried testing
 
 created items with non-public notes
 apply patch
 upgrade database
 map itemnotes_nonpublic to 952x
 run touch_all_items.pl
 
 all non-public notes still seemed to be in more_sbfields_xml
 
 new notes worked as expected but I couldn't get old notes to transfer

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13095] New: An email will be sent shortly

2014-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13095

Bug ID: 13095
   Summary: An email will be sent shortly
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Notices
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: m.de.r...@rijksmuseum.nl
QA Contact: testo...@bugs.koha-community.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13095] An email will be sent shortly

2014-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13095

--- Comment #1 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Created attachment 32402
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32402action=edit
Bug 13095: An email will be sent shortly

This patch adjusts two instances where Koha says that an email has
been sent while it is just enqueued (put in the message queue). The
crontab example still suggests to run process_message_queue once an hour
and the manual even speaks about 1-4 hours.

In the process of selfregistration and sharing a shelf, I have adjusted
the text has been sent to will be sent shortly. This covers imo
the one-hour frequency.

When writing this patch, I have examined all calls of EnqueueLetter;
I only found these two occurrences to be of interest.

Note: I would recommend to increase this frequency in the documentation,
but consider that for now to be outside the scope of this report.

Test plan:
[1] Self-register a new user with verification by email required. Look at
the text when you submit your data.
[2] Share a list with someone else. Look at the text when you submit the
invitation.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13095] An email will be sent shortly

2014-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13095

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |String patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13095] An email will be sent shortly

2014-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13095

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

  Component|Notices |OPAC
   Assignee|koha-b...@lists.koha-commun |m.de.r...@rijksmuseum.nl
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13095] An email will be sent shortly

2014-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13095

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

   Severity|enhancement |trivial

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12005] Zebra searches sometimes fail silently under Plack

2014-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12005

--- Comment #24 from Chris Cormack ch...@bigballofwax.co.nz ---
(In reply to Jacek Ablewicz from comment #23)

 
 would be good (or at least good enough ;) solution for adressing performance
 hit on the cmd line scripts? It seems to work OK under CGI and mod_perl, but
 I'm not sure how reliable checking for GATEWAY_INTERFACE environment
 variable (especially when being done in the module, and not in the script)
 may be for other various persistent setups?

We would have to check that is passed through to plack, otherwise we will be
back where we started, with zebra connections dying and plack searches failing
until the thread respawns :) I'll see if I can test that now.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13027] Typo RoutlingListNote

2014-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13027

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

   Severity|enhancement |trivial

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13027] Typo RoutlingListNote

2014-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13027

--- Comment #4 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Of special interest for those using the German webinstaller files :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12005] Zebra searches sometimes fail silently under Plack

2014-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12005

--- Comment #25 from Paul Poulain paul.poul...@biblibre.com ---
another option, as those scripts are always run through command line : have a
local-made zoom connexion, not using C4 connector. Would it be possible ? (if
someone think it's QD, I agree)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12914] Wrong message 'Patron(..) is blocked for 2014-09-30 day(s).

2014-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12914

--- Comment #13 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Hi Marc,

I can't reproduce what I can see in your screenshot. The messages I get look
quite different and don't include the date (which they should?). I am attaching
a screenshot, could you take a look? How are you setting the restriction?
I have tested on top of bug 643.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12005] Zebra searches sometimes fail silently under Plack

2014-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12005

--- Comment #26 from Chris Cormack ch...@bigballofwax.co.nz ---
Yep, this works

$VAR1 = 'CGI/1.1'; at /home/vagrant/kohaclone/C4/Context.pm line 689. 

It is set under plack.

So I will attach an updated patch. Which should fix plack, but not slow down
the scripts from the commandline.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12914] Wrong message 'Patron(..) is blocked for 2014-09-30 day(s).

2014-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12914

--- Comment #14 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 32403
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32403action=edit
Screenshot showing messages when overriding debarment

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12914] Wrong message 'Patron(..) is blocked for 2014-09-30 day(s).

2014-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12914

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12005] Zebra searches sometimes fail silently under Plack

2014-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12005

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

  Attachment #32334|0   |1
is obsolete||

--- Comment #27 from Chris Cormack ch...@bigballofwax.co.nz ---
Created attachment 32404
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32404action=edit
Bug 12005 : Creating a new zebra connection for each time we need one

Zebra is not designed to have persistent connections, under cgi this
didn't matter the scripts would get a new connection each time, but
under plack we try to use dead connections

This patch changes it so plack works the same way that cgi did.

To test:
Apply this patch
Do some searches
Check everything still works

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13085] bugfix : tools/export.pl don't works in commandline without id_list_file parameter

2014-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13085

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13085] bugfix : tools/export.pl don't works in commandline without id_list_file parameter

2014-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13085

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

  Attachment #32333|0   |1
is obsolete||

--- Comment #2 from Chris Cormack ch...@bigballofwax.co.nz ---
Created attachment 32405
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32405action=edit
Bug 13085: bugfix to allow call of export.pl in commandline without
id_list_file parameter

Test plan
1/ run ./tools/export.pl
2/ notice an error like cannot open 0: No such file or directory at
./tools/export.pl line 209.
3/ apply patch
4/ run again
5/ no errors

Signed-off-by: Chris ch...@bigballofwax.co.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13085] bugfix : tools/export.pl don't works in commandline without id_list_file parameter

2014-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13085

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

 CC||ch...@bigballofwax.co.nz
   Severity|critical|major

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13035] Overdue notices send notices for due date in future.

2014-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13035

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

  Attachment #32324|0   |1
is obsolete||

--- Comment #3 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 32406
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32406action=edit
[PASSED QA] Bug 13035: Overdue notices send notices for due date in future.

Overdue notices, script uses method days_between which returns always
positive value of days, no mater if due_date is higher or lower from
date_to_run. This causes overdue notices to be send for real overdue and
for checkouts with due date in future, which have same days_between as
in notice triggers.

To reproduce:
1. Set up overdue notice triggers for eg. 2 day.
2. Checkout items for 2 borrowers first gets item with due date 2 days
in past and second gets 2 days in future.
3. run ./misc/cronjobs/overdue_notices.pl -n -t
4. watch that notices was generated for both of them.

To test:
1. Repeat steps 1,2
2. Apply patch
3. run ./misc/cronjobs/overdue_notices.pl -n -t
4. should be 1 notice for borrower with overdue item.

Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz
Signed-off-by: Katrin Fischer katrin.fischer...@web.de
Passes tests and QA script, just adds an additional test.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13035] Overdue notices send notices for due date in future.

2014-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13035

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12914] Wrong message 'Patron(..) is blocked for 2014-09-30 day(s).

2014-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12914

--- Comment #15 from Marc Véron ve...@veron.ch ---
Hi Katrin,

It seems that my test plan was not precise enough, sorry...

It should read:

Add manual restriction with expiration date to patron A
Add manual restriction without expiration date to patron B

For both:

Step a)
go to check out 

Step b)
override restriction (Bug 643)
Result of this step: like screenshot 2014-10-16 by Katrin

Step c)
check out an item 
Result: like Marc's screenshot 2014-10-14 with wrong text. This is fixed by the
patch.


The message for patron A should now be similar to:
Patron has a restriction until 04/12/2014.

The message for patron B should now read:
Patron has a restriction (no expiry date).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13081] Z39.50 servers administration bug

2014-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13081

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WONTFIX

--- Comment #1 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Hi Jesse,
Bug 12265 will solve your problem. It includes:
- Remove offset parameter, Next/Prev button and associated logic.

It will be in 3.18. Maybe you can apply these patches under 3.14?
As long as the big Next/Prev is working, you have a workaround ;)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12424] ddc sorting of call numbers truncates long Cutter parts

2014-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12424

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12424] ddc sorting of call numbers truncates long Cutter parts

2014-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12424

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

  Attachment #32364|0   |1
is obsolete||

--- Comment #17 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 32407
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32407action=edit
[PASSED QA] Bug 12424 - ddc sorting of call numbers truncates long Cutter parts

This patch increases the cn_sort field length to 255 chars.

Modified:

C4/ClassSortRoutine.pm- change the hardcoded cn_sort length
to 255
installer/data/mysql/kohastructure.sql- alter tables items and
deleteditems,
biblioitems and deletedbiblioitems
installer/data/mysql/updatedatabase.pl- alter tables items and
deleteditems,
biblioitems and deletedbiblioitems

Testing:

Before applying the patch:
0) Select an item
1) Edit the item selected
2) Change Full call number option to 530 F435_1996 v2p1
3) Save changes
4) Valide 530_000_F435_1996_ (table items - cn_sort column).

After applying the patch:
5) Edit again the item selected in 0
3) Save changes
4) Valide 530_000_F435_1996_V2P1 (table items - cn_sort column).

Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz
Signed-off-by: Katrin Fischer katrin.fischer...@web.de
Passes tests and QA script.
Works as described.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12424] ddc sorting of call numbers truncates long Cutter parts

2014-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12424

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

   Patch complexity|Trivial patch   |Small patch

--- Comment #18 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Thx for your patience!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13085] bugfix : tools/export.pl don't works in commandline without id_list_file parameter

2014-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13085

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

  Attachment #32405|0   |1
is obsolete||

--- Comment #3 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 32408
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32408action=edit
[PASSED QA] Bug 13085: bugfix to allow call of export.pl in commandline without
id_list_file parameter

Test plan
1/ run ./tools/export.pl
2/ notice an error like cannot open 0: No such file or directory at
./tools/export.pl line 209.
3/ apply patch
4/ run again
5/ no errors

Signed-off-by: Chris ch...@bigballofwax.co.nz
Signed-off-by: Katrin Fischer katrin.fischer...@web.de
Works as described, adding an additional check.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13085] bugfix : tools/export.pl don't works in commandline without id_list_file parameter

2014-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13085

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10126] C4::Reports::Guided is not Plack safe

2014-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10126

--- Comment #7 from Tomás Cohen Arazi tomasco...@gmail.com ---
Created attachment 32409
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32409action=edit
Bug 10126: (qa followup) fix tests

It seems the removal of global variables changes the behaviour
of Test::MockModule, and it now expects the namespace in front
of the statically called method.

Signed-off-by: Tomas Cohen Arazi tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11271] Serials table off the screen in smaller viewports

2014-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11271

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

  Attachment #31995|0   |1
is obsolete||

--- Comment #4 from Chris Cormack ch...@bigballofwax.co.nz ---
Created attachment 32410
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32410action=edit
Bug 11271 - Serials table off the screen in smaller viewports

When you search for serials in the Serials module the results table is
often too wide for the screen (depending on your browser window size).
This is partly due to the fixed width of the search fields in the table
footer.

This patch applies a flexible width to those inputs and reduces the
font size of their text.

This patch also moves the action links for each table row into an
action menu (similar to the change made by Bug 10615 in Reports) to
further conserve screen space.

This patch also revises the page's DataTables configuration to use table
header classes for sorting configuration.

To test you should be able to perform a search which returns multiple
open and closed subscriptions.

- Test that table sorting works correctly, including for titles with
  articles and for dates.
- Test that the Action menu items work correctly and that they correctly
  reflect the permissions of the logged-in user with regard to
  receive_serials and routing.
- Perform these tests on both the Open and Closed tabs.

Signed-off-by: Chris ch...@bigballofwax.co.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11271] Serials table off the screen in smaller viewports

2014-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11271

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13027] Typo RoutlingListNote

2014-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13027

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

  Attachment #32002|0   |1
is obsolete||

--- Comment #5 from Chris Cormack ch...@bigballofwax.co.nz ---
Created attachment 32411
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32411action=edit
Bug 13027: Typo RoutlingListNote

Trivial patch adjusts two occurrences of this typo in two installer sql
files.

Signed-off-by: Chris ch...@bigballofwax.co.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13027] Typo RoutlingListNote

2014-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13027

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10960] Holds Queue Report display loc code not description

2014-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10960

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8837] Dewey cn_sort inaccurate

2014-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8837

Paola Rossi paola.ro...@cineca.it changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||paola.ro...@cineca.it

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10960] Holds Queue Report display loc code not description

2014-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10960

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

  Attachment #31949|0   |1
is obsolete||

--- Comment #2 from Chris Cormack ch...@bigballofwax.co.nz ---
Created attachment 32412
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32412action=edit
Bug 10960 - Holds Queue Report display loc code not description

The holds queue report shows codes for item shelving location and for
library transfer location. This patch adds template plugin handling of
both these fields to display their full description.

To test, make sure you have one or more items in your holds queue which
have a shelving location. Rebuild your holds queue if necessary and view
it. Items which have a shelving location should show the description
instead of the code. The send to column should show the library name
instead of code.

Signed-off-by: Chris ch...@bigballofwax.co.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8837] Dewey cn_sort inaccurate

2014-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8837

Paola Rossi paola.ro...@cineca.it changed:

   What|Removed |Added

  Attachment #30554|0   |1
is obsolete||

--- Comment #2 from Paola Rossi paola.ro...@cineca.it ---
Created attachment 32413
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32413action=edit
Bug 8837 - Dewey cn_sort inaccurate

I've applied the patches against master 3.17.00.027

Everything is OK, as required.

So I pass the patch to Signed Off status.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13096] Send an ACCTDETAILS notice when staff changes user or password or ?

2014-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13096

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=9097

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9097] 'Welcome mail' for new library users

2014-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9097

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=13096

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9097] 'Welcome mail' for new library users

2014-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9097

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13097] New: Use of ampersands ( ) in holiday titles or descriptions breaks the calendar

2014-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13097

Bug ID: 13097
   Summary: Use of ampersands (  ) in holiday titles or
descriptions breaks the calendar
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: major
  Priority: P5 - low
 Component: Tools
  Assignee: gmcha...@gmail.com
  Reporter: k...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

Use of ampersands (  ) in holiday titles or descriptions breaks the calendar.
At that point, the only way to recover is to edit the database directly and
remove the offending characters.

See video for demonstration.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13097] Use of ampersands ( ) in holiday titles or descriptions breaks the calendar

2014-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13097

--- Comment #1 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 32414
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32414action=edit
Demonstration Video

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13097] Use of ampersands ( ) in holiday titles or descriptions breaks the calendar

2014-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13097

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13096] Send an ACCTDETAILS notice when staff changes user or password or ?

2014-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13096

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|koha-b...@lists.koha-commun |m.de.r...@rijksmuseum.nl
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9859] C4::Charset - nsb_clean() remove Â

2014-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9859

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

  Attachment #16469|0   |1
is obsolete||
 CC||katrin.fisc...@bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9859] C4::Charset - nsb_clean() remove Â

2014-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9859

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

  Attachment #17407|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9859] C4::Charset - nsb_clean() remove Â

2014-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9859

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9859] C4::Charset - nsb_clean() remove Â

2014-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9859

--- Comment #16 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 32415
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32415action=edit
0001-PASSED-QA-Bug-9859-fix-nsb_clean-side-effect.patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9859] C4::Charset - nsb_clean() remove Â

2014-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9859

--- Comment #17 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 32416
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32416action=edit
0002-Bug-9859-Follow-up-Adding-a-simple-unit-test-for-nsb.patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12005] Zebra searches sometimes fail silently under Plack

2014-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12005

Jacek Ablewicz ablew...@gmail.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12005] Zebra searches sometimes fail silently under Plack

2014-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12005

Jacek Ablewicz ablew...@gmail.com changed:

   What|Removed |Added

  Attachment #32404|0   |1
is obsolete||

--- Comment #28 from Jacek Ablewicz ablew...@gmail.com ---
Created attachment 32417
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32417action=edit
Bug 12005 : Creating a new zebra connection for each time we need one

Zebra is not designed to have persistent connections, under cgi this
didn't matter the scripts would get a new connection each time, but
under plack we try to use dead connections

This patch changes it so plack works the same way that cgi did.

To test:
Apply this patch
Do some searches
Check everything still works

Signed-off-by: Jacek Ablewicz a...@biblos.pk.edu.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10960] Holds Queue Report display loc code not description

2014-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10960

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

  Attachment #32412|0   |1
is obsolete||

--- Comment #3 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 32418
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32418action=edit
[PASSED QA] Bug 10960 - Holds Queue Report display loc code not description

The holds queue report shows codes for item shelving location and for
library transfer location. This patch adds template plugin handling of
both these fields to display their full description.

To test, make sure you have one or more items in your holds queue which
have a shelving location. Rebuild your holds queue if necessary and view
it. Items which have a shelving location should show the description
instead of the code. The send to column should show the library name
instead of code.

Signed-off-by: Chris ch...@bigballofwax.co.nz
Signed-off-by: Katrin Fischer katrin.fischer...@web.de
Works as described, making use of the TT plugins.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10960] Holds Queue Report display loc code not description

2014-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10960

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13055] Show budget name when editing it

2014-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13055

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

  Attachment #32090|0   |1
is obsolete||

--- Comment #2 from Chris Cormack ch...@bigballofwax.co.nz ---
Created attachment 32419
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32419action=edit
Bug 13055 - Show budget name when editing it

This patch adds the budget name to the page heading when editing a
budget. The patch also similarly corrects the page title during edit
operations and fixes some inconsistency in the breadcrumbs.

To test, edit an existing budget (Adminitration - Budgets) and confirm
that page title, breadcrumbs, and heading look correct.

Signed-off-by: Chris ch...@bigballofwax.co.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13055] Show budget name when editing it

2014-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13055

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11271] Serials table off the screen in smaller viewports

2014-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11271

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11271] Serials table off the screen in smaller viewports

2014-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11271

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

  Attachment #32410|0   |1
is obsolete||

--- Comment #5 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 32420
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32420action=edit
[PASSED QA] Bug 11271 - Serials table off the screen in smaller viewports

When you search for serials in the Serials module the results table is
often too wide for the screen (depending on your browser window size).
This is partly due to the fixed width of the search fields in the table
footer.

This patch applies a flexible width to those inputs and reduces the
font size of their text.

This patch also moves the action links for each table row into an
action menu (similar to the change made by Bug 10615 in Reports) to
further conserve screen space.

This patch also revises the page's DataTables configuration to use table
header classes for sorting configuration.

To test you should be able to perform a search which returns multiple
open and closed subscriptions.

- Test that table sorting works correctly, including for titles with
  articles and for dates.
- Test that the Action menu items work correctly and that they correctly
  reflect the permissions of the logged-in user with regard to
  receive_serials and routing.
- Perform these tests on both the Open and Closed tabs.

Signed-off-by: Chris ch...@bigballofwax.co.nz
Signed-off-by: Katrin Fischer katrin.fischer...@web.de
Works nicely and improves the display significantly.
Passes tests and QA script.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13080] Addition of noEnterSubmit class should not apply to textarea, only to input

2014-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13080

--- Comment #4 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Hi Bondiurbano,
thx for testing! - I have added a sing-off line for you on the patch. If you
are using the sandboxes for testing they can do that for you too.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13080] Addition of noEnterSubmit class should not apply to textarea, only to input

2014-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13080

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13080] Addition of noEnterSubmit class should not apply to textarea, only to input

2014-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13080

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

  Attachment #32363|0   |1
is obsolete||

--- Comment #5 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 32421
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32421action=edit
[PASSED QA] Bug 13080 - Addition of noEnterSubmit class should not apply to
textarea, only to input

The application of the noEnterSubmit class to textareas in the
cataloging editor prevents the user from being able to use the Enter key
to create line breaks. This is not intentional and should be corrected.

This patch adds more specific scoping to the relevant JavaScript.

To test, apply the patch and clear your browser cache if necessary. Open
up the MARC editor and locate a tag which uses a textarea for entry. Try
typing lines of text separated by line breaks. The enter key should work
correctly.

Signed-off-by: bondiurbano cost...@gmail.com
Signed-off-by: Katrin Fischer katrin.fischer...@web.de
Passes tests and fixes the problem.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13055] Show budget name when editing it

2014-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13055

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

  Attachment #32419|0   |1
is obsolete||

--- Comment #3 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 32422
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32422action=edit
[PASSED QA] Bug 13055 - Show budget name when editing it

This patch adds the budget name to the page heading when editing a
budget. The patch also similarly corrects the page title during edit
operations and fixes some inconsistency in the breadcrumbs.

To test, edit an existing budget (Adminitration - Budgets) and confirm
that page title, breadcrumbs, and heading look correct.

Signed-off-by: Chris ch...@bigballofwax.co.nz
Signed-off-by: Katrin Fischer katrin.fischer...@web.de
Nice improvement, works as described.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13055] Show budget name when editing it

2014-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13055

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13027] Typo RoutlingListNote

2014-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13027

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #7 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Thx for the patch, Marcel! And sorry for introducing the typos :(

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13027] Typo RoutlingListNote

2014-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13027

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13027] Typo RoutlingListNote

2014-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13027

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

  Attachment #32411|0   |1
is obsolete||

--- Comment #6 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 32423
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32423action=edit
[PASSED QA] Bug 13027: Typo RoutlingListNote

Trivial patch adjusts two occurrences of this typo in two installer sql
files.

Signed-off-by: Chris ch...@bigballofwax.co.nz
Signed-off-by: Katrin Fischer katrin.fischer...@web.de
Typo in sysprefs.sql is only in the description, so fixing
this without a database update seems ok.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11847] Display basketgroup closed date at OPAC

2014-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11847

--- Comment #15 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
This is currently blocked by its dependency on 11708 (Patch doesn't apply)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13098] New: Item lost multiple times by the same patron will create only be charged once

2014-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13098

Bug ID: 13098
   Summary: Item lost multiple times by the same patron will
create only be charged once
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: k...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

If a patron loses an item and is charged a lost fee, returns the item, and
loses it again, the patron will not be charged a new lost fee!

Steps to reproduce:
1) Check out item with a replacement fee to a patron
2) Mark the item as lost
3) Note the lost fee, write it off
4) Return the item
5) Check out item to the patron a second time
6) Mark the item as lost a second time
7) Note there is no second lost item fee

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9859] C4::Charset - nsb_clean() remove Â

2014-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9859

--- Comment #18 from stephane.dela...@biblibre.com ---
Thanks Katrin

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12726] Show RDA tag 264 on OPAC Results XSLT view

2014-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12726

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

  Attachment #31050|0   |1
is obsolete||

--- Comment #6 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 32424
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32424action=edit
[PASSED QA] Bug 12726: Show RDA tag 264 on OPAC Results XSLT view (MARC21)

This patch adds the same information to the Publisher line of OPAC Results
as bug 12724 did on OPAC Detail.
To accomplish this and reduce repeated code, two XSLT routines (named
templates) are moved from OPACDetail to MARC21slimUtils.

Test plan (see also bug 12742 and the rules mentioned there):
[1] Add tag 260 and some 264s to your MARC21 record.
[2] Check the display of OPAC Details. Should not have changed.
[3] Now check also the display of this record in OPAC Results.
[4] Change some indicators in the record. Check OPAC Results again.

Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com
On top of 12724, no change on detail, more data on results.
No koha-qa errors

Signed-off-by: Katrin Fischer katrin.fischer...@web.de
Change moves display logic to Utils, 260 will display as
before and 264 will only display if there is no 260.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/



[Koha-bugs] [Bug 12726] Show RDA tag 264 on OPAC Results XSLT view

2014-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12726

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13071] Currency page shows perl error under some circumstances

2014-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13071

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12914] Wrong message 'Patron(..) is blocked for 2014-09-30 day(s).

2014-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12914

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13018] Static fine should apply only once for a given borrower

2014-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13018

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13018] Static fine should apply only once for a given borrower

2014-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13018

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

  Attachment #32295|0   |1
is obsolete||

--- Comment #3 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 32425
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32425action=edit
[PASSED QA] Bug 13018 : Static fine should be charged only once

Test plan (see Bug 6858 for using staticfine.pl) :

For a user (of a given category and library) with several overdues, launch the
script :

staticfines.pl --category CAT,AMOUNT --library LIB --delay DELAY

Then, check that the user has been charged of AMOUNT if the due date of the
most late item plus the delay is *before* today.

One day later, re-execute the script with the same parameters and check that
the fine has not been charged twice.

Without patch, the fine is charged twice, with patch the user already charged
is skipped (see output in debug mode)

Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz
Signed-off-by: Katrin Fischer katrin.fischer...@web.de
Without the patch, the fine will be applied every time the script is run.
With the patch the fine will only be applied once.
Passes tests and QA script.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8446] Shibboleth authentication patch

2014-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446

--- Comment #124 from Tomás Cohen Arazi tomasco...@gmail.com ---
Created attachment 32426
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32426action=edit
Bug 8446: (qa followup) Tests should be conditional on Test::DBIx::Class

Signed-off-by: Tomas Cohen Arazi tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8446] Shibboleth authentication patch

2014-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8446

--- Comment #125 from Tomás Cohen Arazi tomasco...@gmail.com ---
Created attachment 32427
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32427action=edit
Bug 8446: (qa followup) Patch reintroduces SolR stuff

Signed-off-by: Tomas Cohen Arazi tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13099] New: Item hasn't been transferred yet shows pickup branch rather than holding branch

2014-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13099

Bug ID: 13099
   Summary: Item hasn't been transferred yet shows pickup branch
rather than holding branch
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Hold requests
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: k...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

The Item hasn't been transferred yet message on circulation.pl and
moremember.pl in the holds table shows the pickup branch rather than holding
branch.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13099] Item hasn't been transferred yet shows pickup branch rather than holding branch

2014-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13099

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com
   |ity.org |
   Severity|enhancement |minor

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13099] Item hasn't been transferred yet shows pickup branch rather than holding branch

2014-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13099

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >