[Koha-bugs] [Bug 3977] MARC21 Tag 321b
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3977 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com --- Comment #7 from Martin Renvoize --- Works as expected, no regressions. Passing QA -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3977] MARC21 Tag 321b
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3977 Martin Renvoize changed: What|Removed |Added Attachment #32616|0 |1 is obsolete|| --- Comment #6 from Martin Renvoize --- Created attachment 32657 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32657&action=edit [PASSED QA] Bug 3977: MARC21 321$b has wrong description Fixing descriptions in all frameworks for consistency. Changed frameworks are: - es-ES, default framework - fr-FR, default and simple frameworks - nb-NO, default and simple frameworks - pl-PL, default and simple frameworks To test: - verify changes by reading them - or verify by running the web installers of those languages and checking the description appears correctly - or verify by loading the sql files manually and check they still load correctly Signed-off-by: Chris Cormack Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 3977] MARC21 Tag 321b
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3977 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11362] increase zebra AUTH register sizes, from 4G to 20G
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11362 Martin Renvoize changed: What|Removed |Added Attachment #32606|0 |1 is obsolete|| -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11362] increase zebra AUTH register sizes, from 4G to 20G
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11362 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA CC||martin.renvoize@ptfs-europe ||.com --- Comment #7 from Martin Renvoize --- Works as expected, cause's no regressions. Passing QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11362] increase zebra AUTH register sizes, from 4G to 20G
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11362 --- Comment #6 from Martin Renvoize --- Created attachment 32656 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32656&action=edit [PASSED QA] Bug 11362 - increase zebra AUTH register sizes, from 4G to 20G To test... - apply patch - build and install a new Koha .deb from patched codebase - create a new Koha instance - add some authority records to instance - do a full zebra reindex - do an authorities search, and get some results note: this patch does not fix existing Koha instances, just new ones Signed-off-by: Chris Cormack Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11982] Show local cover images in the biblio details page in the intranet.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11982 --- Comment #15 from Katrin Fischer --- Working on this! I noticed that the "IE Hack" was changed, could someone verify this displays ok in IE? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13115] Holidays.t will fail some unit tests on Sundays
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13115 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Severity|enhancement |major -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13123] Duplicate label ids for language and opaclanguages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13123 Katrin Fischer changed: What|Removed |Added Attachment #32613|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 32655 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32655&action=edit [PASSED QA] Bug 13123 - Duplicate label ids for language and opaclanguages When enabling or disabling a OPAC language choice clicking the label triggers the checkbox under the language preference instead. This is because both s have the same id. This patch adds a modifier to each label and corresponding id attribute in order to make them unique. To test, go to Administration -> System preferences -> I18N/L10N. Clicking the "English (en)" label under the "language" system preference should toggle the corresponding checkbox. Clicking the "English (en)" label under the "opaclanguages" system preference should toggle the correct checkbox. Further tests: - Install an English 'sub-language' like en-GB and confirm that checkbox labels work correctly. - Install a non-English language and confirm that checkbox labels work correctly. Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Works as described, template changes only. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13123] Duplicate label ids for language and opaclanguages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13123 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12995] script update_totalissues.pl stops on corrupted record
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12995 Katrin Fischer changed: What|Removed |Added Attachment #32629|0 |1 is obsolete|| Attachment #32630|0 |1 is obsolete|| --- Comment #11 from Katrin Fischer --- Created attachment 32654 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32654&action=edit [PASSED QA] Bug 12995 - script update_totalissues.pl stops on corrupted record - UT This patch adds an unit test on C4::Biblio::UpdateTotalIssues method call on non existing record Signed-off-by: Owen Leonard I can't comment on the correctness of the test other than to say it ran successfully. Signed-off-by: Katrin Fischer Improves CLI script, works as described. Note: A small improvement would be to output the problematic biblionumber. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12995] script update_totalissues.pl stops on corrupted record
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12995 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13131] Remove Solr file left behind
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13131 Katrin Fischer changed: What|Removed |Added Attachment #32620|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 32653 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32653&action=edit [PASSED QA] Bug 13131 - remove Solr config file This file should have been removed as part of Bug 12538. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13131] Remove Solr file left behind
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13131 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13087] Add a notice for use_zebra_facets problems in about page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13087 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13087] Add a notice for use_zebra_facets problems in about page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13087 Katrin Fischer changed: What|Removed |Added Attachment #32628|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 32652 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32652&action=edit [PASSED QA] Bug 13087: Add a notice for use_zebra_facets problems in about page This patch adds two checks to about.pl: - use_zebra_facets entry presence in koha-conf.xml - use_zebra_facets==1 and zebra_bib_index_mode==dom The idea is to alert the user if it has conflicting or wrong settings. Even if there's a fallback to a working configuration. To test: - On clean master install, go to the about page => SUCCESS: No warnings regarding use_zebra_facets - Comment out the use_zebra_facets entry, reload => SUCCESS: The about page mentions the use_zebra_facets entry is missing - Uncomment the use_zebra_facets entry, make sure it is set to 1 - Change zebra_bib_index_mode to 'grs1', reload => SUCCESS: The about page says zebra_bib_index_mode is not set to DOM even though you have use_zebra_facets set. - Sign off :-D Regards To+ Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Owen Leonard Followed test plan with success Signed-off-by: Katrin Fischer Works as described, tested by changing the koha-conf.xml file. Note: There is no warning if use_zebra_facets is 0. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13103] No checkouts count on member details page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13103 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13103] No checkouts count on member details page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13103 Katrin Fischer changed: What|Removed |Added Attachment #32631|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 32651 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32651&action=edit [PASSED QA] Bug 13103: No checkouts count on member details page On member details page, number of issues are not shown. It's caused by, old variable name for issue count in Moremember.tt template. To test: Apply patch go to member details page and check if there's number alongside "Checkout(s)" tab. Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Small template change for more consistency. Works nicely. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12068] label-create-pdf.pl Add support for RTL languages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12068 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #20 from Katrin Fischer --- Switching to "PQA" as the patch was intended to be QA follow-up and only changes one character. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13141] Add ability for biblio_framework to be a dropdown in Guided Reports
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13141
--- Comment #1 from M. Tompsett ---
Created attachment 32650
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32650&action=edit
Bug 13141 - Add ability for biblio_framework to be a dropdown in Guided Reports
By tweaking the GetReservedAuthorisedValues function in
C4::Reports::Guided, biblio_framework can be added as a dropdown
list into the guided reports parameters.
The change in C4/Reports/Guided.pm required a test, which is
found in t/db_dependent/ReportsGuided.t
Code was then added to reports/guided_reports.pl to build the
appropriate hash to trigger the proper dropdown list.
TEST PLAN
-
1) Apply patch
2) prove -v t/db_dependent/ReportsGuided.t
-- all should pass, this confirms that both
C4/Reports/Guided.pm and this test file work.
3) Log into staff client
4) Reports
5) Create from SQL
6) Enter appropriate information like:
Report name: Test 13141
-- no need to change Report group or Report is public or Notes or Type
SQL:
SELECT CONCAT('',biblio.biblionumber,'')
AS BiblioNumbers,
title, author, frameworkcode
FROM biblio
WHERE frameworkcode=<>
7) Save report
8) Run report
-- The parameter entry page should have a drop down of
framework codes.
9) Select a framework code, and click Run the report
-- The displayed SQL should have a "frameworkcode=" portion
matching the selected framework.
10) Run the koha qa test tool.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13141] Add ability for biblio_framework to be a dropdown in Guided Reports
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13141 M. Tompsett changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13141] New: Add ability for biblio_framework to be a dropdown in Guided Reports
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13141 Bug ID: 13141 Summary: Add ability for biblio_framework to be a dropdown in Guided Reports Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: gmcha...@gmail.com Reporter: mtomp...@hotmail.com QA Contact: testo...@bugs.koha-community.org By tweaking the GetReservedAuthorisedValues function in C4::Reports::Guided, biblio_framework can be added as a dropdown list into the guided reports parameters. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11559] Professional cataloger's interface
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13140] Add a notice on the About page about GRS-1 deprecated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13140 Tomás Cohen Arazi changed: What|Removed |Added Keywords||rel_3_18_candidate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13140] Add a notice on the About page about GRS-1 deprecated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13140 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 32649 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32649&action=edit Bug 13140: Add a notice on the About page about GRS-1 deprecated This patch changes the text for zebra_auth_index_mode and zebra_bib_index_mode entries missing on koha-conf.xml telling the user GRS-1 is deprecated. It also adds another check for those preferences set to GRS-1, and shows a warning message if set to grs1. To test: - Apply the patch and try all combinations: - zebra_auth_index_mode and zebra_bib_index_mode missing - zebra_auth_index_mode and zebra_bib_index_mode set to grs1 - Sign off :-D Regards -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13140] Add a notice on the About page about GRS-1 deprecated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13140 Tomás Cohen Arazi changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5010] Fix OPACBaseURL to include protocol
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 M. Tompsett changed: What|Removed |Added Status|Needs Signoff |ASSIGNED --- Comment #76 from M. Tompsett --- (In reply to Owen Leonard from comment #75) > So an additional patch is required here? Yes, an additional patch is required here. I'm working on it. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12651] DOM indexing should be the default
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12651 Tomás Cohen Arazi changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12651] DOM indexing should be the default
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12651 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 32648 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32648&action=edit Bug 12651: DOM indexing is the default On the 23 July development meeting it was decided to formally deprecate GRS-1 indexing mode for Zebra. This patch makes code fallback to DOM on the remaining places. No behaviour change should be noticed, as DOM has been the default for a while. Regards -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13140] Add a notice on the About page about GRS-1 deprecated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13140 Tomás Cohen Arazi changed: What|Removed |Added Patch complexity|--- |Small patch Blocks||12641 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13140] Add a notice on the About page about GRS-1 deprecated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13140 Tomás Cohen Arazi changed: What|Removed |Added Assignee|neng...@gmail.com |tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12641] Formally deprecate the GRS-1 indexing mode
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12641 Tomás Cohen Arazi changed: What|Removed |Added Depends on||13140 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13140] New: Add a notice on the About page about GRS-1 deprecated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13140 Bug ID: 13140 Summary: Add a notice on the About page about GRS-1 deprecated Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Documentation Assignee: neng...@gmail.com Reporter: tomasco...@gmail.com QA Contact: testo...@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12651] DOM indexing should be the default
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12651 Tomás Cohen Arazi changed: What|Removed |Added Keywords||rel_3_18_candidate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12651] DOM indexing should be the default
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12651 Tomás Cohen Arazi changed: What|Removed |Added Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12689] Search.t fails to run on Squeeze
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12689 Robin Sheat changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #1 from Robin Sheat --- Added a newer version of Test::Simple to the repo which fixes this. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13095] An email will be sent shortly
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13095 Katrin Fischer changed: What|Removed |Added Attachment #32640|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 32647 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32647&action=edit [PASSED QA] Bug 13095: An email will be sent shortly This patch adjusts two instances where Koha says that an email has been sent while it is just enqueued (put in the message queue). The crontab example still suggests to run process_message_queue once an hour and the manual even speaks about 1-4 hours. In the process of selfregistration and sharing a shelf, I have adjusted the text "has been sent" to "will be sent shortly". This covers imo the one-hour frequency. When writing this patch, I have examined all calls of EnqueueLetter; I only found these two occurrences to be of interest. Note: I would recommend to increase this frequency in the documentation, but consider that for now to be outside the scope of this report. Test plan: [1] Self-register a new user with verification by email required. Look at the text when you submit your data. [2] Share a list with someone else. Look at the text when you submit the invitation. Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Works as described, small string change. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13095] An email will be sent shortly
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13095 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13028] Remove uninitialized value warning and add partial flag to cmp_sysprefs script
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13028 --- Comment #7 from Katrin Fischer --- Created attachment 32646 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32646&action=edit [PASSED QA] Bug 13028: Followup adding a -partial flag for partial compares If you compare the database with a partial pref file, you may not be interested in lots of lines saying that a pref is not in the file. You were already aware of that ;) If you add the -partial flag, these lines will be skipped. Test plan: Do as described above. Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Works as described, passes tests and QA script. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13028] Remove uninitialized value warning and add partial flag to cmp_sysprefs script
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13028 Katrin Fischer changed: What|Removed |Added Attachment #32641|0 |1 is obsolete|| Attachment #32643|0 |1 is obsolete|| --- Comment #6 from Katrin Fischer --- Created attachment 32645 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32645&action=edit [PASSED QA] Bug 13028: Resolve uninitialized value in string eq at cmp_sysprefs.pl line 194 If you use the restore option with a partial pref file not containing a version, you will have this error. Also the count of updated prefs will be one too high. This is corrected by a better test of the hash value in the CheckVersionPref subroutine. Test plan: [1] Create a small pref file and remove the version pref (if present). You could for instance do a pref backup and remove most lines. [2] Use the restore option with and without this patch. So, something like: maintclone/misc/maintenance/cmp_sysprefs.pl -c r -f crucial.pref [3] Check on the error message and the pref count. Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13028] Remove uninitialized value warning and add partial flag to cmp_sysprefs script
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13028 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13028] Remove uninitialized value warning and add partial flag to cmp_sysprefs script
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13028 --- Comment #5 from M. de Rooy --- Thanks, Chris. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11586] Better default framework for UNIMARC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11586 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||tomasco...@gmail.com --- Comment #25 from Tomás Cohen Arazi --- Patches pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10467] Package dependency updates for master
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10467 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||tomasco...@gmail.com --- Comment #2 from Tomás Cohen Arazi --- Patch pushed to master. Thanks Robin! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13084] Prevent mixup of columns in deletedborrowers
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13084 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||tomasco...@gmail.com --- Comment #28 from Tomás Cohen Arazi --- Patches pushed to master. Thanks Marcel! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13139] Move treeview jQuery plugin outside of language-specific directory
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13139 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13139] Move treeview jQuery plugin outside of language-specific directory
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13139 --- Comment #1 from Owen Leonard --- Created attachment 32644 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32644&action=edit Bug 13139 - Move treeview jQuery plugin outside of language-specific directory This patch moves the treeview plugin in the staff client from the language-specific lib/jquery/plugins directory to the one outside the theme directory. To test, apply the patch and view the "Set permissions" page for a patron. The list of permissions should display in an expandable list as usual. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13139] New: Move treeview jQuery plugin outside of language-specific directory
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13139 Bug ID: 13139 Summary: Move treeview jQuery plugin outside of language-specific directory Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org The jquery.treeview.pack.js jQuery plugin used by the patron permissions template should be moved to intranet-tmpl/lib/jquery/plugins -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13028] Remove uninitialized value warning and add partial flag to cmp_sysprefs script
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13028 Chris Cormack changed: What|Removed |Added Attachment #32062|0 |1 is obsolete|| --- Comment #4 from Chris Cormack --- Created attachment 32643 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32643&action=edit Bug 13028: Followup adding a -partial flag for partial compares If you compare the database with a partial pref file, you may not be interested in lots of lines saying that a pref is not in the file. You were already aware of that ;) If you add the -partial flag, these lines will be skipped. Test plan: Do as described above. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13028] Remove uninitialized value warning and add partial flag to cmp_sysprefs script
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13028 Chris Cormack changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13134] Add patron category to returns confirmation dialogs
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13134 Kyle M Hall changed: What|Removed |Added Attachment #32618|0 |1 is obsolete|| --- Comment #5 from Kyle M Hall --- Created attachment 32642 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32642&action=edit Bug 13134 - Add patron category to returns confirmation dialogs Some librarians find it useful to know what category a patron is before confirming a reserve or transfer from the checkin screen. This patch adds the patron category to the hold and transfer popups to the patron information already displayed. The li tags that contain the patron category have the class "patron-category" to allow this data to be easily hidden. Test Plan: 1) Apply this patch 2) Trap a hold for a patron, note the patron category is now displayed 3) Trap a hold for pickup at another loation, note the patron category is now displayed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13028] Remove uninitialized value warning and add partial flag to cmp_sysprefs script
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13028 Chris Cormack changed: What|Removed |Added Attachment #32005|0 |1 is obsolete|| --- Comment #3 from Chris Cormack --- Created attachment 32641 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32641&action=edit Bug 13028: Resolve uninitialized value in string eq at cmp_sysprefs.pl line 194 If you use the restore option with a partial pref file not containing a version, you will have this error. Also the count of updated prefs will be one too high. This is corrected by a better test of the hash value in the CheckVersionPref subroutine. Test plan: [1] Create a small pref file and remove the version pref (if present). You could for instance do a pref backup and remove most lines. [2] Use the restore option with and without this patch. So, something like: maintclone/misc/maintenance/cmp_sysprefs.pl -c r -f crucial.pref [3] Check on the error message and the pref count. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13134] Add patron category to returns confirmation dialogs
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13134 --- Comment #4 from Kyle M Hall --- (In reply to Owen Leonard from comment #3) > My inclination is to add this to the line with the patron name, similar to > the way we do it on the screen where you submit a partial name for checkout > and are presented with a multi-select. For example: > > > [% borsurname %], [% borfirstname %] > ([% borcnum %] - [% borcategory %]) > > > Which would like something like this: > > - Leonard, Owen (012345 - Adult) > > Seems more compact and logical to me. I agree. I think that's a much better idea. I'll update the patch as soon as I can. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13095] An email will be sent shortly
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13095 Chris Cormack changed: What|Removed |Added Attachment #32402|0 |1 is obsolete|| --- Comment #2 from Chris Cormack --- Created attachment 32640 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32640&action=edit Bug 13095: An email will be sent shortly This patch adjusts two instances where Koha says that an email has been sent while it is just enqueued (put in the message queue). The crontab example still suggests to run process_message_queue once an hour and the manual even speaks about 1-4 hours. In the process of selfregistration and sharing a shelf, I have adjusted the text "has been sent" to "will be sent shortly". This covers imo the one-hour frequency. When writing this patch, I have examined all calls of EnqueueLetter; I only found these two occurrences to be of interest. Note: I would recommend to increase this frequency in the documentation, but consider that for now to be outside the scope of this report. Test plan: [1] Self-register a new user with verification by email required. Look at the text when you submit your data. [2] Share a list with someone else. Look at the text when you submit the invitation. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13095] An email will be sent shortly
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13095 Chris Cormack changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13138] Remove jQuery plugins which were used by Solr
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13138 --- Comment #1 from Owen Leonard --- Created attachment 32639 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32639&action=edit Bug 13138 - Remove jQuery plugins which were used by Solr This patch removes two jQuery plugins which were used only by Solr-related templates. With the removal of Solr these plugins are obsolete. To test, search the Koha code for references to the two plugins: jquery.textarea-expander.js tablednd.js There should be none. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13138] Remove jQuery plugins which were used by Solr
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13138 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13138] New: Remove jQuery plugins which were used by Solr
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13138 Bug ID: 13138 Summary: Remove jQuery plugins which were used by Solr Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org Two jQuery plugins are included in the staff client templates which were only used by Solr-related templates. They can be removed: jquery.textarea-expander.js tablednd.js -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11982] Show local cover images in the biblio details page in the intranet.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11982 Owen Leonard changed: What|Removed |Added Attachment #30627|0 |1 is obsolete|| --- Comment #14 from Owen Leonard --- Created attachment 32638 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32638&action=edit [SIGNED-OFF] Bug 11982 - Images now display properly in the details section. If the a cover image exists, it will be displayed on the details page. Nothing is displayed of there is no cover available. modified: koha-tmpl/intranet-tmpl/prog/en/js/localcovers.js modified: koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11982] Show local cover images in the biblio details page in the intranet.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11982 Owen Leonard changed: What|Removed |Added Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11982] Show local cover images in the biblio details page in the intranet.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11982 Owen Leonard changed: What|Removed |Added Attachment #30625|0 |1 is obsolete|| --- Comment #12 from Owen Leonard --- Created attachment 32636 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32636&action=edit [SIGNED-OFF] Bug 11982 - Show local cover image in the intranet biblio details page Also, fix useless "No cover image" block when using Amazon and local cover images at the same time. http://bugs.koha-community.org/show_bug.cgi?id=11982 Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11982] Show local cover images in the biblio details page in the intranet.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11982 Owen Leonard changed: What|Removed |Added Attachment #30626|0 |1 is obsolete|| --- Comment #13 from Owen Leonard --- Created attachment 32637 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32637&action=edit [SIGNED-OFF] Bug 11982 - Fixed the amazon no image icon. A no image icon will only be displayed if both the amazon and local images are missing. Added hyperlink to details on the local image in the search result page. modified: koha-tmpl/intranet-tmpl/prog/en/js/localcovers.js modified: koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt modified: koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11982] Show local cover images in the biblio details page in the intranet.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11982 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13075] Use of uninitialized value while proving db_dependent/Holds.t
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13075 M. Tompsett changed: What|Removed |Added Status|ASSIGNED|Needs Signoff --- Comment #9 from M. Tompsett --- Nope. All good. Less speed, more haste. :) This needs testing as per the test plan in comment #6. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13075] Use of uninitialized value while proving db_dependent/Holds.t
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13075 M. Tompsett changed: What|Removed |Added Status|Needs Signoff |ASSIGNED --- Comment #8 from M. Tompsett --- Oops. Still working on it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13075] Use of uninitialized value while proving db_dependent/Holds.t
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13075 M. Tompsett changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff --- Comment #7 from M. Tompsett --- Rebased. Another bug fix had added an additional test. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13075] Use of uninitialized value while proving db_dependent/Holds.t
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13075 M. Tompsett changed: What|Removed |Added Attachment #32326|0 |1 is obsolete|| --- Comment #6 from M. Tompsett --- Created attachment 32635 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32635&action=edit Bug 13075 - Silence warnings and improve Charset testing. Calls to C4/Charset.pm's NormalizeString function with an undefined string were triggering warnings when running: prove -v t/db_dependent/Holds.t Sadly, t/Charset.t was also lacking calls to NormalizeString. TEST PLAN - 1) prove -v t/db_dependent/Holds.t -- This should generate the uninitialized string warnings. Make sure CPL and MPL are in your branches to save yourself from headaches due to expected data. 2) cat t/Charset.t -- note there are no function calls to NormalizeString. You can see other shortfalls in the tests beyond NormalizeString with: grep ^sub C4/Charset.pm 3) prove -v t/Charset.t 4) Apply patch 5) prove -v t/Charset.t -- Run as before with more tests. 6) cat t/Charset.t -- note there are now function calls to NormalizeString. 7) prove -v t/db_dependent/Holds.t -- Nice and clean run! :) 8) koha-qa.pl -v 2 -c 1 -- all should be Ok. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9858] Add button in "Search Engine Configuration" is not working.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9858 Katrin Fischer changed: What|Removed |Added Status|In Discussion |RESOLVED CC||katrin.fisc...@bsz-bw.de Resolution|--- |WONTFIX --- Comment #6 from Katrin Fischer --- The solr code has been removed from Koha. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9862] Cart image and footer are removed when i search for something in opac using Solr
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9862 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Resolution|LATER |WONTFIX -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9861] Solr: HTTP 404 when i click on title or author in search results
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9861 Katrin Fischer changed: What|Removed |Added Status|In Discussion |RESOLVED CC||katrin.fisc...@bsz-bw.de Resolution|--- |WONTFIX --- Comment #9 from Katrin Fischer --- The solr search code has been removed from Koha. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9862] Cart image and footer are removed when i search for something in opac using Solr
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9862 Bug 9862 depends on bug 9861, which changed state. Bug 9861 Summary: Solr: HTTP 404 when i click on title or author in search results http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9861 What|Removed |Added Status|In Discussion |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13137] New: Tabbing in the items editor for serials does not behave correctly
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13137 Bug ID: 13137 Summary: Tabbing in the items editor for serials does not behave correctly Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials Assignee: koha-bugs@lists.koha-community.org Reporter: k...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: colin.campb...@ptfs-europe.com Any attempt to tab between fields in the item editor in the serials module will not tab through the fields as expected. See video demonstration: http://screencast.com/t/1JtEn1Yg3xG -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10363] There is no package for authorised values.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 Kyle M Hall changed: What|Removed |Added Attachment #32633|0 |1 is obsolete|| --- Comment #43 from Kyle M Hall --- Created attachment 32634 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32634&action=edit Bug 10363 - There is no package for authorised values. Test Plan: 1) Apply this patch 2) run updatedatabase.pl 3) prove t/db_dependent/AuthorisedValues.t -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10363] There is no package for authorised values.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 Kyle M Hall changed: What|Removed |Added Depends on||13019 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13019] Add base classes on which to build Koha objects
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13019 Kyle M Hall changed: What|Removed |Added Blocks||10363 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10992] Error using solr search engine
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10992 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Resolution|FIXED |WONTFIX -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10363] There is no package for authorised values.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 Kyle M Hall changed: What|Removed |Added Attachment #32632|0 |1 is obsolete|| --- Comment #42 from Kyle M Hall --- Created attachment 32633 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32633&action=edit Bug 10363 - There is no package for authorised values. Test Plan: 1) Apply this patch 2) run updatedatabase.pl 3) prove t/db_dependent/AuthorisedValues.t -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10363] There is no package for authorised values.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 Kyle M Hall changed: What|Removed |Added Attachment #30710|0 |1 is obsolete|| Attachment #30711|0 |1 is obsolete|| Attachment #30712|0 |1 is obsolete|| Attachment #31565|0 |1 is obsolete|| --- Comment #41 from Kyle M Hall --- Created attachment 32632 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32632&action=edit Bug 10363 - There is no package for authorised values. Test Plan: 1) Apply this patch 2) run updatedatabase.pl 3) prove t/db_dependent/AuthorisedValues.t -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12248] Error when using course reserves with item-level_itypes set to biblio
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12248 Owen Leonard changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7380] Can't filter patron search on detail page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7380 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply --- Comment #7 from Owen Leonard --- I tried to apply this on top of biblibre/ft/bug_11944 and still got the same error Heather did. Am I testing this incorrectly? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11573] change description of charges in account fines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573 --- Comment #16 from Owen Leonard --- What is the status of this bug? It is just waiting for a signoff on attachment 27824? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12346] False patron modification alerts on members-home.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12346 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #7 from Owen Leonard --- Still can't reproduce this. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13040] Improve exporter to allow multiple branch selections
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13040 Paola Rossi changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #5 from Paola Rossi --- Thanks, Robin Sheat, for the answer in comment 3. I've made some further tests. I agree with you: the problem is the same on MASTER. And the error managed by Bug 12860 happens when the MARC field XXX occurs at least in one of the records selected for the export. Otherwise, no abort occurs. Today I've applied the patch against master 3.17.00.030. I've found the following problems. 1) I selected no branch [so all branches were selected]. Then I've selected a value for the two input fields: >From item call number To item call number Koha has answered only about the current selected library, not about all the libraries as required. 2) > By default all branches will be selected. No, the default was the current selected library (that I could uncheck, anyway). 3) There were some records biblio in my DB, all the biblios had at least one item. Exporting all records [no branch checked, item type ALL, the other input fields empty] was OK. Then I catalogued a new biblio record [Default framework] without items. And then I edited an old item changing the barcode, inventory and something else. Exporting in the same way as above, not all the records were exported, but only some of them: in particular, the biblio record of the changed item was not exported. [I went back to master on the same DB. Exporting [ALL Library selected, item type ALL, the other input fields empty], all the records were exported: the biblio record without items too, as well as the biblio record whose item I changed.] So I pass the patch to "Failed QA" status. NB-1. On the template of export, "Accession date" is shown, but the field is shown as the item's "d - Date acquired" on CAT. NB-2. If I didn't selected "From biblio number" and "To biblio number", in some cases the export file is not sorted on biblio number. This seemed strange to me: the sort of the export file could be an important information for me, but I didn't recognize what it was. NB-3. If no record was selected, an output file was created, empty. Perhaps the answer could be given to the user in intranet. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13075] Use of uninitialized value while proving db_dependent/Holds.t
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13075 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply --- Comment #5 from Owen Leonard --- Auto-merging t/Charset.t CONFLICT (content): Merge conflict in t/Charset.t Auto-merging C4/Charset.pm Failed to merge in the changes. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5010] Fix OPACBaseURL to include protocol
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 --- Comment #75 from Owen Leonard --- (In reply to M. Tompsett from comment #74) > The _get_uri function will need to be amended in bug 8446, if this passes > first, or a patch added afterwards if passes later. So an additional patch is required here? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13103] No checkouts count on member details page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13103 Owen Leonard changed: What|Removed |Added Attachment #32498|0 |1 is obsolete|| --- Comment #2 from Owen Leonard --- Created attachment 32631 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32631&action=edit [SIGNED-OFF] Bug 13103: No checkouts count on member details page On member details page, number of issues are not shown. It's caused by, old variable name for issue count in Moremember.tt template. To test: Apply patch go to member details page and check if there's number alongside "Checkout(s)" tab. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13103] No checkouts count on member details page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13103 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12995] script update_totalissues.pl stops on corrupted record
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12995 Owen Leonard changed: What|Removed |Added Attachment #32535|0 |1 is obsolete|| --- Comment #10 from Owen Leonard --- Created attachment 32630 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32630&action=edit [SIGNED-OFF] Bug 12995 - script update_totalissues.pl stops on corrupted record - UT This patch adds an unit test on C4::Biblio::UpdateTotalIssues method call on non existing record Signed-off-by: Owen Leonard I can't comment on the correctness of the test other than to say it ran successfully. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12995] script update_totalissues.pl stops on corrupted record
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12995 Owen Leonard changed: What|Removed |Added Attachment #32536|0 |1 is obsolete|| --- Comment #9 from Owen Leonard --- Created attachment 32629 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32629&action=edit [SIGNED-OFF] Bug 12995 - script update_totalissues.pl stops on corrupted record When running update_totalissues.pl cronjob, it will stop on a corrupted record. This patch changes UpdateTotalIssues so that it return 1 if processing record has succeded. Also, if mapping with biblioitems.totalissues does not exist, the method has nothing to do so it stops and returns 1. When processing a corrupted record, script now alerts about the error on this biblionumber (if script is verbose) and process next record. A total number of records with error will be printed at the end of the script. Test plan : - Create a dabase with a few biblios and some issues - Modify first biblio record (use direct sql update) : set empty value in biblioitems.marcxml - Launch script : misc/cronjobs/update_totalissues.pl --use-stats --commit=1000 -v => Without patch : the script stops at first record => With patch : the script prints error for first record and processes all records Signed-off-by: Owen Leonard I was able to confirm the problem before the patch and successfully follow the test plan. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12995] script update_totalissues.pl stops on corrupted record
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12995 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10412] The ability to update Acquisitions with credit notes, with the option to link to an existing invoice
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10412 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com --- Comment #10 from Martin Renvoize --- Amit, could you rebase this again please.. We have a few people attempting to test and signoff ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13087] Add a notice for use_zebra_facets problems in about page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13087 Owen Leonard changed: What|Removed |Added Attachment #32603|0 |1 is obsolete|| --- Comment #2 from Owen Leonard --- Created attachment 32628 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32628&action=edit [SIGNED-OFF] Bug 13087: Add a notice for use_zebra_facets problems in about page This patch adds two checks to about.pl: - use_zebra_facets entry presence in koha-conf.xml - use_zebra_facets==1 and zebra_bib_index_mode==dom The idea is to alert the user if it has conflicting or wrong settings. Even if there's a fallback to a working configuration. To test: - On clean master install, go to the about page => SUCCESS: No warnings regarding use_zebra_facets - Comment out the use_zebra_facets entry, reload => SUCCESS: The about page mentions the use_zebra_facets entry is missing - Uncomment the use_zebra_facets entry, make sure it is set to 1 - Change zebra_bib_index_mode to 'grs1', reload => SUCCESS: The about page says zebra_bib_index_mode is not set to DOM even though you have use_zebra_facets set. - Sign off :-D Regards To+ Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Owen Leonard Followed test plan with success -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13087] Add a notice for use_zebra_facets problems in about page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13087 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13134] Add patron category to returns confirmation dialogs
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13134 --- Comment #3 from Owen Leonard --- My inclination is to add this to the line with the patron name, similar to the way we do it on the screen where you submit a partial name for checkout and are presented with a multi-select. For example: [% borsurname %], [% borfirstname %] ([% borcnum %] - [% borcategory %]) Which would like something like this: - Leonard, Owen (012345 - Adult) Seems more compact and logical to me. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13113] Prevent juvenile/children from reserving ageRestricted material
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13113 Olli-Antti Kivilahti changed: What|Removed |Added Attachment #32621|0 |1 is obsolete|| --- Comment #5 from Olli-Antti Kivilahti --- Created attachment 32626 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32626&action=edit Bug 13113 - Prevent juvenile/children from reserving ageRestricted material There is no reason for underage borrowers to reserve ageRestricted material and then be denied it's check-out due to ageRestriction. This patch prevents reserving material for borrowers not suitably aged. # # # # # # # A PRIORI # # # # # # # BOTH THE STAFF CLIENT AND THE OPAC 1. Find a Record with Items, update the MARC Subfield 521a to "PEGI 16". 2. Get a Borrower who is younger than 16 years. 3. Place a hold for the underage Borrower for the ageRestricted Record. 4. You can reserve an ageRestricted Record with ease. STAFF CLIENT ONLY 5. Check-in an Item from the ageRestricted Record and catch the reservation. 6. Check-out the ageRestricted Item for this underage Borrower. 7. You get a notification about being unable to check-out due to age restriction. How lame is that for a 12 year old? # # # # # # # # # A POSTERIORI # # # # # # # # # STAFF CLIENT 1. Find a Record with Items, update the MARC Subfield 521a to "PEGI 16". 2. Get a Borrower who is younger than 16 years. 3. Check-out an ageRestricted Item for this underage Borrower. 4. You get a notification about having the maximum amount of reserves. 5. Place a hold for the underage Borrower for the ageRestricted Record. 6. You get a notification, that placing a hold on ageRestricted material is forbidden. Includes Unit tests. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13116] Make it possible to propagate errors from C4::Reserves::CanItemBeReserved() to the web-templates.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13116 Olli-Antti Kivilahti changed: What|Removed |Added Attachment #32552|0 |1 is obsolete|| --- Comment #8 from Olli-Antti Kivilahti --- Created attachment 32627 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32627&action=edit Bug 13116 - Make it possible to propagate errors from C4::Reserves::CanItemBeReserved() to the web-templates. This patch changes the way CanBookBeReserved() and CanItemBeReserved() return error messages and how they are dealt with in the templates. This change makes it possible to distinguish between different types of reservation failure. Currently only two types of errors are handled, all the way to the user, from the CanItemBeReserved(): -ageRestricted -tooManyReserves which translates to maxreserves # - TEST PLAN - # ((-- AGE RESTRICTION --)) STAFF CLIENT 1. Find a Record with Items, update the MARC Subfield 521a to "PEGI 16". 2. Get a Borrower who is younger than 16 years. 3. Place a hold for the underage Borrower for the ageRestricted Record. 4. You get a notification, that placing a hold on ageRestricted material is forbidden. (previously you just got a notification about maximum amount of reserves reached) ((-- MAXIMUM RESERVES REACHED --)) 0. Set the maxreserves -syspref to 3 (or any low value) STAFF CLIENT AND OPAC 1. Make a ton of reserves for one borrower. 2. Observe the notification about maximum reserves reached blocking your reservations. ((-- MULTIPLE HOLDS STAFF CLIENT --)) 3. Observe the error notification "Cannot place hold on some items" ((-- MULTIPLE HOLDS OPAC --)) 1. Make a search with many results, of which atleast one is age restricted to the current borrower. 2. Select few results and "Place hold" from to result summary header element. (Not individual results "Place hold") 3. Observe individual Biblios getting the "age restricted"-notification, where others can be reserved just fine. Updated the unit tests to match the new method return values. t/db_dependent/Holds.t & Reserves.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13106] Encapsulate Circulation::GetAgeRestriction() and modify it to check borrowers age as well.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13106 Olli-Antti Kivilahti changed: What|Removed |Added Attachment #32548|0 |1 is obsolete|| --- Comment #6 from Olli-Antti Kivilahti --- Created attachment 32625 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32625&action=edit Bug 13106 - Encapsulate Circulation::GetAgeRestriction() and modify it to check borrowers age as well. This patch moves the logic of deciding whether or not a borrower is old enough to access this material to its own function GetAgeRestriction. This makes it easier to use AgeRestriction elsewhere, like with placing holds. Unit tests included. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 1807] search () give odd results
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1807
Christopher Brannon changed:
What|Removed |Added
CC||cbran...@cdalibrary.org
--- Comment #9 from Christopher Brannon ---
(In reply to Jesse Maseto from comment #8)
>
> //Fix subject search by striping parenthesis from url links
> $('#catalogue_detail_biblio a[href*="su:"]').attr('href', function(_,v){
> return v.replace(/(\(|\))/g,'')
> });
>
> This works for both the staff search and OPAC.
Actually had to update this jquery to catch more. Simply striping the
parenthesis isn't enough, because sometimes it will mash words together. And
sometimes replacing it with a space throws off the search as well. This
modification seems to work better at fixing the issue:
//Fix subject search by striping parenthesis from url links
$('#catalogue_detail_biblio a[href*="su:"]').attr('href', function(_,v){
return v.replace(/(\w)(\(|\))(\w)/g,'$1 $3')
}).attr('href', function(_,v){
return v.replace(/(\(|\))/g,'')
});
//End fix subject search
I don't know if it addresses all situations, but I've been tweaking it as I
come across new situations.
Christopher
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5685] Validation of email address field
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5685 Owen Leonard changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5685] Validation of email address field
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5685 --- Comment #11 from Owen Leonard --- Created attachment 32624 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32624&action=edit Bug 5685 [OPAC follow-up] Validation of email address field This patch makes a few changes to the way errors are handled in the OPAC: - The validation plugin has been moved from the global include file to the template itself. Since we aren't doing form validation on any other page yet it doesn't make sense to include it globally at this time. - The error message which appears if you have JavaScript disabled and have submitted invalid emails was styled in a non-standard way. - I have added in-page links to the error message which appears if you have JavaScript disabled so that you can click to jump to the field which contains the error. - I have modified the error message language slightly to make it (I hope) read better. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
