[Koha-bugs] [Bug 9312] strict perl for picture-upload.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9312 --- Comment #50 from Katrin Fischer --- Created attachment 33365 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33365&action=edit [PASSED QA] Bug 9312: Followup for one tab character To satisfy qa tools, removing one tab somewhere.. Signed-off-by: Marcel de Rooy Signed-off-by: Chris Cormack Sometimes our QA tools are pretty annoying, in cases like this, when its a tab in a comment, .. I don't think we really need to hold up a patch set for it Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9312] strict perl for picture-upload.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9312 --- Comment #48 from Katrin Fischer --- Created attachment 33363 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33363&action=edit [PASSED QA] Bug 9312: Perltidying picture-upload.pl Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9312] strict perl for picture-upload.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9312 --- Comment #49 from Katrin Fischer --- Created attachment 33364 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33364&action=edit [PASSED QA] Bug 9312: fix a couple more uninitialized variable warnings Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9312] strict perl for picture-upload.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9312 --- Comment #47 from Katrin Fischer --- Created attachment 33362 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33362&action=edit [PASSED QA] Bug 9312: strict perl for picture-upload.pl Testing - this is a code-cleanup patch, so the purpose of testing is to ensure that patron image upload functionality still works. To test: - Turn on the patronimages system preference - Go to Tools | Upload patron images and import a suitable image for a test patron. - Bring up the test patron and verify that the image is attached. - From the patron details page, upload a replacement image. - Create a patron image ZIP file containing at least two images ( per the documentation of the patron image feature) and load it via the patron image import tool. - Verfiy that the test patrons now have images. - Verify that tools/picture-upload.pl didn't report any errors in the Apache error log. Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9312] strict perl for picture-upload.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9312 --- Comment #51 from Katrin Fischer --- Created attachment 33366 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33366&action=edit [PASSED QA] Bug 9312: Resolve error triggered by mutli-type return value. $results is 1 upon success or a hash on failure. Rather than check %$results || %error, I changed it to $results!=1 || %error. Strangely, this works without messy warnings. I believe this resolves the problem Katrin mentions in comment #43. TEST PLAN - 0) Make sure the system preference patronimages is set to Allow. 1) Apply all the patches 2) Login to staff client 3) Tools -> Upload patron images (it's in the bottom left) 4) Choose an image file, browse for a photo, enter a patron #. 5) Click Upload 6) Click the card number link -- the uploaded photo should be visible on the left side of the screen. 7) Run koha qa test tools. Signed-off-by: Bernardo Gonzalez Kriegel Image uploaded without problems No koha-qa errors Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9312] strict perl for picture-upload.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9312 Katrin Fischer changed: What|Removed |Added Attachment #33355|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9312] strict perl for picture-upload.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9312 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9312] strict perl for picture-upload.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9312 Katrin Fischer changed: What|Removed |Added Attachment #32759|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9312] strict perl for picture-upload.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9312 Katrin Fischer changed: What|Removed |Added Attachment #32760|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9312] strict perl for picture-upload.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9312 Katrin Fischer changed: What|Removed |Added Attachment #32762|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9312] strict perl for picture-upload.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9312 Katrin Fischer changed: What|Removed |Added Attachment #32761|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13199] Incoherence between 'en' sample notices and translated notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13199 --- Comment #16 from Katrin Fischer --- Thx Frederic and Bernardo! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13199] Incoherence between 'en' sample notices and translated notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13199 --- Comment #15 from Katrin Fischer --- Created attachment 33361 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33361&action=edit [PASSED QA] Bug 13199: follow up to fix Licence and some koha-qa errors Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13199] Incoherence between 'en' sample notices and translated notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13199 --- Comment #13 from Katrin Fischer --- Created attachment 33359 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33359&action=edit [PASSED QA] Bug 13199: Test incoherence between 'en' sample notices and translated notices This test identifies incoherences between translated sample notices and the 'en' reference file. Koha sample notices are loaded to 'letter' table from a text SQL file during Koha installation by web installer. The reference file is the one provided for English (en) installation : /installer/data/mysql/en/mandatory/sample_notices.sql Alternatives files are provided for other languages. Those files are difficult to keep synchronized with reference file. This could be an functional issue since some Koha operation depend on notice existence, for example Print Slip in Circulation. Signed-off-by: Bernardo Gonzalez Kriegel Test works and identify missing notices A few koha-qa errors fixed in followup Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13199] Incoherence between 'en' sample notices and translated notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13199 --- Comment #14 from Katrin Fischer --- Created attachment 33360 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33360&action=edit [PASSED QA] Bug 13199: Add missing notices for several installations prove xt/sample_notices.sql identifies missing notices. This patch add those missing notices: - fr-FR ISSUEQSLIP, ISSUESLIP, OPAC_REG_VERIFY, RESERVESLIP, TRANSFERSLIP - it-IT/necessari/notices.sql: OPAC_REG_VERIFY, RENEWAL - pl-PL/mandatory/sample_notices.sql: ISSUEQSLIP, ISSUESLIP, OPAC_REG_VERIFY, RESERVESLIP, TRANSFERSLIP - ru-RU/mandatory/sample_notices.sql: ISSUEQSLIP, ISSUESLIP, OPAC_REG_VERIFY, RESERVESLIP, TRANSFERSLIP - uk-UA/mandatory/sample_notices.sql: ISSUEQSLIP, ISSUESLIP, OPAC_REG_VERIFY, RESERVESLIP, TRANSFERSLIP TO TEST: (1) Without this patch, but with the patch adding xt/sample_notices.sql: prove xt/sample_notices.sql list all the above missing notices. (2) Apply this patch. And do prove again: nothing is reported. Signed-off-by: Bernardo Gonzalez Kriegel Work as described, test stop failing No koha-qa errors Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13199] Incoherence between 'en' sample notices and translated notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13199 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13199] Incoherence between 'en' sample notices and translated notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13199 Katrin Fischer changed: What|Removed |Added Attachment #33354|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13199] Incoherence between 'en' sample notices and translated notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13199 Katrin Fischer changed: What|Removed |Added Attachment #33353|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13199] Incoherence between 'en' sample notices and translated notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13199 Katrin Fischer changed: What|Removed |Added Attachment #33352|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11592] opac detail scripts do not respect MARC tag visibility
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592 M. Tompsett changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11592] opac detail scripts do not respect MARC tag visibility
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592 M. Tompsett changed: What|Removed |Added Attachment #32383|0 |1 is obsolete|| --- Comment #56 from M. Tompsett --- Created attachment 33358 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33358&action=edit Bug 11592 - MARC Visibility settings not respected The advanced constraints section while editing subfield structure for a particular MARC bibliographic framework allow the user to set visibility settings for OPAC and Intranet. These settings are not fully respected. This was first discovered while comparing the information displayed on the opac-MARCdetail and opac-detail pages. To this end, this patch will provide the ability to correct this problem across the board as desired, but will focus primarily on the OPAC interface. This was accomplished by adding 3 functions to C4/Biblio.pm: - ShouldDisplayOnInterface - ShouldHideMARC - GetFilteredBiblio And also by modifying GetMarcBiblio to filter or not based on parameter style and parameter values passed. ShouldDisplayOnInterface is a wrapper routine which just returns a hash of hashes which let us know if something is visible (1) or not (0 or undef) for a given interface (opac or intranet). This allows us to add/remove to the advance constraints section and then not have to update multiple routines to keep the filtering working properly, though if it is a drastic refactoring that would be necessary. ShouldHideMARC takes a field from marc_subfield_structure, and determines if it should be hidden. It does this for all the fields for a given framework code on a particular interface. If no framework code is given, the framework code used is the default one. If not interface is specified, OPAC is assumed. This routine returns a hash reference to the corresponding hash that was built. GetFilteredBiblio takes a MARC::Record, clones it, and then strips all the fields that should not be visible for a given framework code and interface. If no framework code is specied, it assumes the default one. If no interface is given, OPAC is assumed. The routine then returns the filtered record. GetMarcBiblio was modified to accept a hash style parameter. This allowed for filtering if the new convention was used, and no apparent change if the old convention is used. These functions allowed for filtering, but frequently there were problems with titles, subjects, etc. This required other tweaks. In C4/Biblio.pm, GetMarcSubjects was returning the subject, even it was supposed to be hidden. C4/XSLT.pm tried to replace a field with no field, rather than properly delete it. With the filtering being implemented based on the parameter style, it just required a minor tweak in opac-ISDBdetail to filter. The title needed to be purposefully not set if it was supposed to be hidden in opac-MARCdetail. However, opac-detail was interesting challenge. First, changing the parameter style did filtering, but the output still was leaking things which should be hidden. This is the main reason ShouldHideMARC was written, because there is an insidious little loop that runs through a set of keys and sets template parameters to values. Second, By skipping to the next key based on the hash ref returned by ShouldHideMARC, the template parameter is not set, and thus the value is properly hidden. Third, the subtitle was grabbed by GetRecordValue. This was refactored so filtering worked properly. Then opac-MARCdetail's 'view plain' was still showing details. This required converting the XML record to a MARC::Record, filtering it, and then converting it back. By tweaking opac-export and opac-showmarc to use the new parameter calling convention, records were filtered properly. And of course, with modifications and additions to C4/Biblio.pm, tests were required. t/Biblio.t has been modified to check the new function ShouldDisplayOnInterface. t/db_dependent/Biblio.t has also been modified. It confirms that both old and new calling conventions work. It also tests hiding the title field (200$a UNIMARC, 245$a MARC). It includes tests for ShouldHideMARC, GetFilteredBiblio, and GetMarcBiblio. TEST PLAN - 1) Back up your DB 2) Go to any OPAC detail page and note the biblio number. 3) Log into the staff client and determine the framework code for that biblio number. 4) The steps should be done with OPACXSLTDetailsDisplay set to blank. 5) Home -> Koha administration -> MARC bibliographic framework -> MARC structure (for the matching framework) 6) On the OPAC detail page, click MARC view 7) In the staff client, for every tag listed in the OPAC -> Subfields -> click the first link Then running through all the tabs, click Advanced constraints and uncheck OPAC visibility. Then click Save Changes 8)
[Koha-bugs] [Bug 11592] opac detail scripts do not respect MARC tag visibility
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592 M. Tompsett changed: What|Removed |Added Attachment #33356|0 |1 is obsolete|| --- Comment #55 from M. Tompsett --- Created attachment 33357 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33357&action=edit Bug 11592 - Updated License Text and use Modern::Perl Why not clean up the License Agreement stuff while the files are being changed? Used the current one found at: http://wiki.koha-community.org/wiki/Coding_Guidelines#Licence Changed the strict and warning lines into just a Modern::Perl. Signed-off-by: Robin Sheat Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11592] opac detail scripts do not respect MARC tag visibility
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592 M. Tompsett changed: What|Removed |Added Attachment #32382|0 |1 is obsolete|| --- Comment #54 from M. Tompsett --- Created attachment 33356 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33356&action=edit Bug 11592 - Updated License Text and use Modern::Perl Why not clean up the License Agreement stuff while the files are being changed? Used the current one found at: http://wiki.koha-community.org/wiki/Coding_Guidelines#Licence Changed the strict and warning lines into just a Modern::Perl. Signed-off-by: Robin Sheat Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9312] strict perl for picture-upload.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9312 Bernardo Gonzalez Kriegel changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||bgkrie...@gmail.com --- Comment #46 from Bernardo Gonzalez Kriegel --- First 4 patches were signed, I tested all and signed the last one -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9312] strict perl for picture-upload.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9312 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #32781|0 |1 is obsolete|| --- Comment #45 from Bernardo Gonzalez Kriegel --- Created attachment 33355 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33355&action=edit [SIGNED-OFF] Bug 9312: Resolve error triggered by mutli-type return value. $results is 1 upon success or a hash on failure. Rather than check %$results || %error, I changed it to $results!=1 || %error. Strangely, this works without messy warnings. I believe this resolves the problem Katrin mentions in comment #43. TEST PLAN - 0) Make sure the system preference patronimages is set to Allow. 1) Apply all the patches 2) Login to staff client 3) Tools -> Upload patron images (it's in the bottom left) 4) Choose an image file, browse for a photo, enter a patron #. 5) Click Upload 6) Click the card number link -- the uploaded photo should be visible on the left side of the screen. 7) Run koha qa test tools. Signed-off-by: Bernardo Gonzalez Kriegel Image uploaded without problems No koha-qa errors -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13217] fix koha-upgrade-schema to work with git/dev installs
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13217 --- Comment #2 from Mason James --- > # koha-upgrade-schema -v master > Upgrading database schema for -v oops, typo ^ root@xen1:~# sh -x /usr/sbin/koha-upgrade-schema master + set -e + update=/usr/share/koha/intranet/cgi-bin/installer/data/mysql/updatedatabase.pl + echo Upgrading database schema for master Upgrading database schema for master + KOHA_CONF=/etc/koha/sites/master/koha-conf.xml PERL5LIB=/usr/share/koha/lib /usr/share/koha/intranet/cgi-bin/installer/data/mysql/updatedatabase.pl this is a similar issue to 13216, where PERL5LIB is assumed be '/usr/share/koha' -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13217] fix koha-upgrade-schema to work with git/dev installs
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13217 --- Comment #1 from Mason James --- here's an example of a failed attempt... # koha-create --create-db master # koha-gitify master /path/to/my/koha # apachectl restart # koha-upgrade-schema -v master Upgrading database schema for -v unable to locate Koha configuration file koha-conf.xml at /usr/share/koha/lib/C4/Context.pm line 373. unable to locate Koha configuration file koha-conf.xml at /usr/share/koha/lib/C4/Context.pm line 373. unable to locate Koha configuration file koha-conf.xml at /usr/share/koha/lib/C4/Context.pm line 373. Can't call method "config" on unblessed reference at /usr/share/koha/lib/C4/Context.pm line 796. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13217] New: fix koha-upgrade-schema to work with git/dev installs
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13217 Bug ID: 13217 Summary: fix koha-upgrade-schema to work with git/dev installs Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: gmcha...@gmail.com Reporter: m...@kohaaloha.com QA Contact: testo...@bugs.koha-community.org koha-upgrade-schema seems to currently not work with git/dev koha-gitify installs this patch attempts to fix this issue -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13199] Incoherence between 'en' sample notices and translated notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13199 Bernardo Gonzalez Kriegel changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||bgkrie...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11592] opac detail scripts do not respect MARC tag visibility
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592 --- Comment #53 from M. Tompsett --- (In reply to M. Tompsett from comment #52) > Bug 11912 and other related bugs which touched > t/db_dependent/Biblio.t affected this as well. > I'm working on a rebase. Oops. Bug 12570, because it was t/Biblio.t :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13199] Incoherence between 'en' sample notices and translated notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13199 --- Comment #12 from Bernardo Gonzalez Kriegel --- Created attachment 33354 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33354&action=edit Bug 13199: follow up to fix Licence and some koha-qa errors -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13199] Incoherence between 'en' sample notices and translated notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13199 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #33217|0 |1 is obsolete|| --- Comment #10 from Bernardo Gonzalez Kriegel --- Created attachment 33352 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33352&action=edit [SIGNED-OFF] Bug 13199: Test incoherence between 'en' sample notices and translated notices This test identifies incoherences between translated sample notices and the 'en' reference file. Koha sample notices are loaded to 'letter' table from a text SQL file during Koha installation by web installer. The reference file is the one provided for English (en) installation : /installer/data/mysql/en/mandatory/sample_notices.sql Alternatives files are provided for other languages. Those files are difficult to keep synchronized with reference file. This could be an functional issue since some Koha operation depend on notice existence, for example Print Slip in Circulation. Signed-off-by: Bernardo Gonzalez Kriegel Test works and identify missing notices A few koha-qa errors fixed in followup -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13199] Incoherence between 'en' sample notices and translated notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13199 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #6|0 |1 is obsolete|| --- Comment #11 from Bernardo Gonzalez Kriegel --- Created attachment 33353 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33353&action=edit [SIGNED-OFF] Bug 13199: Add missing notices for several installations prove xt/sample_notices.sql identifies missing notices. This patch add those missing notices: - fr-FR ISSUEQSLIP, ISSUESLIP, OPAC_REG_VERIFY, RESERVESLIP, TRANSFERSLIP - it-IT/necessari/notices.sql: OPAC_REG_VERIFY, RENEWAL - pl-PL/mandatory/sample_notices.sql: ISSUEQSLIP, ISSUESLIP, OPAC_REG_VERIFY, RESERVESLIP, TRANSFERSLIP - ru-RU/mandatory/sample_notices.sql: ISSUEQSLIP, ISSUESLIP, OPAC_REG_VERIFY, RESERVESLIP, TRANSFERSLIP - uk-UA/mandatory/sample_notices.sql: ISSUEQSLIP, ISSUESLIP, OPAC_REG_VERIFY, RESERVESLIP, TRANSFERSLIP TO TEST: (1) Without this patch, but with the patch adding xt/sample_notices.sql: prove xt/sample_notices.sql list all the above missing notices. (2) Apply this patch. And do prove again: nothing is reported. Signed-off-by: Bernardo Gonzalez Kriegel Work as described, test stop failing No koha-qa errors -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11592] opac detail scripts do not respect MARC tag visibility
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592 --- Comment #52 from M. Tompsett --- The removal of the prog theme broke this, specifically bug 13170. Bug 11912 and other related bugs which touched t/db_dependent/Biblio.t affected this as well. I'm working on a rebase. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13216] fix koha-shell to work with git/dev installs
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13216 --- Comment #1 from Mason James --- (In reply to Mason James from comment #0) > koha-shell assumes PERL5LIB is '/usr/share/koha', which if often incorrect > in a git/dev install > > this patch attempts to fix this issue, by using the correct path oops, which *is* often incorrect in a git/dev install -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13216] New: fix koha-shell to work with git/dev installs
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13216 Bug ID: 13216 Summary: fix koha-shell to work with git/dev installs Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: gmcha...@gmail.com Reporter: m...@kohaaloha.com QA Contact: testo...@bugs.koha-community.org koha-shell assumes PERL5LIB is '/usr/share/koha', which if often incorrect in a git/dev install this patch attempts to fix this issue, by using the correct path -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12792] C4::Reserves breaks my vim syntax color
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12792 --- Comment #12 from M. Tompsett --- (In reply to M. Tompsett from comment #11) > The prove currently fails on test 8, but the other succeeding > tests prove that this change is fine. Oops. Test 11. Still, the change is good and worthy of QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12792] C4::Reserves breaks my vim syntax color
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12792
M. Tompsett changed:
What|Removed |Added
Attachment #33350|0 |1
is obsolete||
--- Comment #11 from M. Tompsett ---
Created attachment 33351
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33351&action=edit
[SIGNED OFF] Bug 12792: C4::Reserves breaks my vim syntax color
C4/Reserves.pm is unreadable with my vim configuration.
It appears I am the only one having this problem.
For an incomprehensible reason, a string constructs with
qq/my string/;
completely breaks the syntax color for all the rest of the file (~2300l).
If I replace it with
qq{my string};
all is fine!
Test plan:
launch
git show HEAD
and verify this patch won't break anything.
Additionally, prove t/db_dependent/Reserves.t
This will trigger the three functions that were modified.
The prove currently fails on test 8, but the other succeeding
tests prove that this change is fine.
Signed-off-by: Mark Tompsett
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12792] C4::Reserves breaks my vim syntax color
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12792 M. Tompsett changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12792] C4::Reserves breaks my vim syntax color
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12792 M. Tompsett changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12792] C4::Reserves breaks my vim syntax color
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12792
M. Tompsett changed:
What|Removed |Added
Attachment #33268|0 |1
is obsolete||
--- Comment #10 from M. Tompsett ---
Created attachment 33350
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33350&action=edit
Bug 12792: C4::Reserves breaks my vim syntax color
C4/Reserves.pm is unreadable with my vim configuration.
It appears I am the only one having this problem.
For an incomprehensible reason, a string constructs with
qq/my string/;
completely breaks the syntax color for all the rest of the file (~2300l).
If I replace it with
qq{my string};
all is fine!
Test plan:
launch
git show HEAD
and verify this patch won't break anything.
Additionally, prove t/db_dependent/Reserves.t
This will trigger the three functions that were modified.
Sorry, but t/db_dependent/Reserves.t fails currently.
Checking why.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12792] C4::Reserves breaks my vim syntax color
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12792 --- Comment #9 from M. Tompsett --- Bug 11126 is what is causing the conflict. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11592] opac detail scripts do not respect MARC tag visibility
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply --- Comment #51 from Katrin Fischer --- The patches currently don't apply for me: Apply? [(y)es, (n)o, (i)nteractive] i Applying: Bug 11592 - MARC Visibility settings not respected fatal: sha1 information is lacking or useless (C4/Biblio.pm). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12792] C4::Reserves breaks my vim syntax color
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12792 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Patch doesn't apply CC||katrin.fisc...@bsz-bw.de --- Comment #8 from Katrin Fischer --- Jonathan, the patch doesn't apply cleanly - can you take a look? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13201] GetSuggestion takes suggestionid
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13201 Katrin Fischer changed: What|Removed |Added Attachment #33282|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 33349 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33349&action=edit [PASSED QA] Bug 13201: GetSuggestion takes suggestionid Having $ordernumber as the parameter in a function which is handling suggestions and it is used as a suggestion id is confusing to the coder and person trying to read the code. This patch corrects the confusion. REVISED TEST PLAN - 1) perldoc C4::Suggestions -- notice it says ordernumber for the GetSuggestions example. 2) Ensure you have CPL in your branches table. 3) prove -v t/db_dependent/Suggestions.t -- if you have more than 8 itemtypes in your database, two tests at the end will fail, but that is not relevant to the modified GetSuggestions code. 4) apply patch 5) perldoc C4::Suggestions -- notice it is corrected now. 6) prove -v t/db_dependent/Suggestions.t -- it should run with the same results as in step 3. That is, if you have 8 itemtypes, all pass, otherwise those two tests fail. 7) run koha qa test tool Signed-off-by: Mark Tompsett Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13201] GetSuggestion takes suggestionid
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13201 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12250] Update descriptions for languages, scripts and regions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12250 Katrin Fischer changed: What|Removed |Added Attachment #33329|0 |1 is obsolete|| --- Comment #8 from Katrin Fischer --- Created attachment 33348 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33348&action=edit [PASSED QA] Bug 12250: Update descriptions for languages, scripts and regions This patch adds/updates languages, scripts and regions to reflect what we currently have on translation server. Languages, scripts and regions are ordered by respective code To test: 1. Apply the patch 2. run updatedatabase.pl, must run without errors 3. Go to advanced search (opac/staff), more options, and check language pulldown (verify you have an empty AdvancedSearchLanguages syspref) 4. Remove contents from language_descriptions, language_rfc4646_to_iso639, language_script_bidi, language_script_mappin and language_subtag_registry 5. Load installer/data/mysql/mandatory/subtag_registry.sql, must load without errors 6. Repeat 3 Signed-off-by: Tomas Cohen Arazi Signed-off-by: Katrin Fischer Tested the SQL, no problems found. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12250] Update descriptions for languages, scripts and regions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12250 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13215] letter.code is considered as a primary key
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13215 --- Comment #7 from M. Tompsett --- (In reply to Katrin Fischer from comment #4) > This seems like a major > improvement of the code in terms of coding guidelines. It is. I'm not critiquing that. Frankly, the code is beautiful. > Also, there is a > difference between new features and trying to improve old code. &GetLettersAvailableForALibrary &GetLetterTemplates &DelLetter These are new functions, which is why I was asking about DBIx. Thank you for the reply, Tomas. I'll work on signing these off if needed, just let me know. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8753] Add forgot password link to OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #69 from Owen Leonard --- opac/opac-password-recovery.pl line 163: warn "INLIBRO username $username"; The script contains a lot of SQL, which is a violation of coding guidelines: http://wiki.koha-community.org/wiki/Coding_Guidelines#SQL8:_SQL_code_in_.pl_scripts The template contains a check for the variable "errTooManyEmailFound" but I don't see where that variable is created. In fact there doesn't seems to be any handling of multiple identical email addresses. This is a problem for my library where parents often put their email addresses on their kids' accounts. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13154] The webinstaller should offer all available languages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13154 Bernardo Gonzalez Kriegel changed: What|Removed |Added CC||bgkrie...@gmail.com --- Comment #1 from Bernardo Gonzalez Kriegel --- Web installer states: "Please pick your language from the following list. If your language is not listed, please inform your systems administrator." Perhaps the message can be changed, suggesting a way to add more languages before proceed. Bug 12017 adds proper description to "present" (i.e. installed) languages on web installer. But to show a complete list without using database you will need a hardcoded TT list of language codes, it's doable. An then a JS validity check for selected vs. present language. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13203] Plugin housekeeping: UNIMARC field 123i, 123j, 210c
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13203 Katrin Fischer changed: What|Removed |Added Attachment #33299|0 |1 is obsolete|| --- Comment #14 from Katrin Fischer --- Created attachment 33347 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33347&action=edit [PASSED QA] Bug 13203: Plugin housekeeping: UNIMARC field 123i, 123j, 210c In working on bug 10480, I noticed that these plugins needed some attention: [2] unimarc_field_123i.pl: added missing template [3] unimarc_field_123j.pl: resolved missing template with same file [4] unimarc_field_210c_bis.pl: removed a warn, corrected some POD lines Note about UNIMARC field 123i and 123j: Subfields $i and $j are each 8 characters long and contain the same components as subfields $f and $g except that character position 0 contains a plus sign (for the northern celestial hemisphere) or a minus sign (for the southern celestial hemisphere). Test plan: Connect unimarc_field_123i and 123j to some field. Look especially at changing + or - for the hemisphere in the popup. Check left-padding with zeroes for the other positions. Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer Passes tests and QA script. Checked plugin in a UNIMARC installation. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13203] Plugin housekeeping: UNIMARC field 123i, 123j, 210c
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13203 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12017] Move language description out of database
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017 --- Comment #53 from Bernardo Gonzalez Kriegel --- Rebased & updated -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12017] Move language description out of database
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #29906|0 |1 is obsolete|| --- Comment #51 from Bernardo Gonzalez Kriegel --- Created attachment 33345 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33345&action=edit Bug 12017 - 9 - Remove use of language_get_description function This patch removes every use of language_get_description function. This function retrieves lang names from database To test: 1. Functionality removed by this patch do not affect anything, because previous patches are only using rfc4646_subtag value, not values stored in database. 2. Removed import from Templates.pm, not used there -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12017] Move language description out of database
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #29905|0 |1 is obsolete|| --- Comment #50 from Bernardo Gonzalez Kriegel --- Created attachment 33344 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33344&action=edit Bug 12017 - 8 - Remove use of getAllLanguages from installer getAllLanguages is only used on installer/install.pl, and some tests. Result parameters are passed to C4/Install.pm, but its use is futile, language check on Installer.pm uses parameters that are not present on return value of getAllLanguages, and returned value fwk_code is undefined To test: 1. Apply the patch 2. Do translated install (eg using de-DE or es-ES) a. translate first, b. then create a new database, c. grant permissions, d. change koha-conf to use new db, e. reload staff, f. proceed to web install, g. select translated language, h. use marc21, i. finish, 3. Login and check that marc frameworks are translated The translated install must proceed without problems. Removed only the very first occurence of template parameter fwk_language because of it's null value. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12017] Move language description out of database
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #29904|0 |1 is obsolete|| --- Comment #49 from Bernardo Gonzalez Kriegel --- Created attachment 33343 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33343&action=edit Bug 12017 - 7 - Remove function getFrameworkLanguages [ Note: From now on dependence on language descriptions in database is about to be removed, also some code cleaning.] This must be an old relic, not used anymore. To test: 1. Check use of getFrameworkLanguages egrep -Rl getFrameworkLanguages * No result save for definition file 2. Apply the patch 3. check again, no results Reason for removing this function is that it's not used and tries to send languages descriptions from database -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12017] Move language description out of database
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #29907|0 |1 is obsolete|| --- Comment #52 from Bernardo Gonzalez Kriegel --- Created attachment 33346 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33346&action=edit Bug 12017 - 10 - Remove description from getLanguage This patch rewrites getLanguage function. This function is of not much use, but is rewrited to takes its data from language_rfc4646_to_iso639 table. To test: 1. Apply the patch 2. Only place that use this function is t/db_dependent/Languages.t so run the test and check that it pass 3. To compare the output pre and post patch you can run perl -e 'use C4::Languages; use Data::Dumper; $a = getLanguages(); print Dumper $a;' -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12017] Move language description out of database
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #29902|0 |1 is obsolete|| --- Comment #47 from Bernardo Gonzalez Kriegel --- Created attachment 33341 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33341&action=edit Bug 12017 - 5 - Change local use syspref type Language This patch changes local use syspref of type Language Currently this type of syspref is not used, and shows currently translated staff languages. It's values can't be changed. To make something useful, this kind of syspref is changed to show all langs and save iso639_2 codes. And they not use descriptions on database, only rfc4646 codes from templates. It's easy to add new kinds that save rfc4646 codes, or only show translated languages. To test: 1. Apply the patch 2. Go to system preferences, local use 3. Define a new syspref, any name/description, type 'Language', Save 4. New syspref is showed as a multiple selection of iso639_2 codes with current lang and native names. Check that 5. Select some values, save, check they are saved and restored 6. Edit, similar view, change values, save, check 7. Delete test syspref Values are stored as ',' separated values Verify in database -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12017] Move language description out of database
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #29903|0 |1 is obsolete|| --- Comment #48 from Bernardo Gonzalez Kriegel --- Created attachment 33342 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33342&action=edit Bug 12017 - 6 - Change syspref AdvancedSearchLanguages Bug 10986 introduces a way of limiting advanced search languages list. It's a good feature, but to fill the preference you need to list iso639_2 codes. And there is no way to get the list of all codes again as before, and language descriptions are taken from database. This patch changes that preference so it's now a Local syspref, to present an interface to set it's value. Also adds another syspref to control if language chooser is limited at all, recovering previous behavior. As per comments on Bug 10986 language list shows translated and native names and is ordered by iso639_2 code To test: 1. Apply the patch 2. Run updatedatabase.pl 3. Go to system preferences, Searching, new syspref LimitAdvancedSearchLanguages, on by default 4. Go to Local use sysprefs, AdvancedSearchLanguages is now here with interface to set it's values 5. Check language limit on advanced search on staff and opac (any theme) 6. Disable limit and chech language list 7. Enable limit and set different languages on syspref, check language list -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12017] Move language description out of database
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #29901|0 |1 is obsolete|| --- Comment #46 from Bernardo Gonzalez Kriegel --- Created attachment 33340 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33340&action=edit Bug 12017 - 4 - Change language changers This patch modifies language changers on staff/opac Only parameter used is rfc4646 To test: 1. Apply the patch 2. Reload staff and opac (prog/ccsr/bootstrap) 3. Check display of language changers 4. Do a real translation and check language change works Do not change language unless you did a real translation Only change in display is showing only regions for sublanguages. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12017] Move language description out of database
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #29900|0 |1 is obsolete|| --- Comment #45 from Bernardo Gonzalez Kriegel --- Created attachment 9 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9&action=edit Bug 12017 - 3 - Change lang display on sysprefs I18N This patch change the display of languages on sysprefs to set translated languages on I18N Only parameter used is rfc4646 subtag To test: 1. Apply the patch 2. Go to I18N syspref, look language descriptions Following steps are for next patch 3. Set a bunch of languages for staff/opac, save, reload Inlude vi-VN for which there is no current description in databasse 4. Set opaclanguagesdisplay to Allow Current display is preserved, native description for languages outside group, and script/region for language groups Only change is languages ordered by rfc4646 subtag -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12017] Move language description out of database
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #29899|0 |1 is obsolete|| --- Comment #44 from Bernardo Gonzalez Kriegel --- Created attachment 8 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8&action=edit Bug 12017 - 2 - Enable languages on web installer This patch modifies installer/step1.tt to use new language descriptions. Only parameter used is rfc4646 code. To test: 1. Do some fake translations, for example all langs for l in $(cd misc/translator/po; ls *-pref.po | sed 's/-pref.po//'); do mkdir koha-tmpl/intranet-tmpl/prog/$l; mkdir koha-tmpl/opac-tmpl/bootstrap/$l; mkdir koha-tmpl/opac-tmpl/prog/$l; mkdir koha-tmpl/opac-tmpl/ccsr/$l; done or make some lang dirs on intranet-tmpl/prog 2. Apply the patch 3. Edit your koha-conf.xml, change database name to a new name, create that database and grant access, reload staff page, log in with database user, you will be redirected to step1 of web installer. 4. Check names and codes for installed languages. Revert to your old database before proceed, but left dirs. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12017] Move language description out of database
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #29898|0 |1 is obsolete|| --- Comment #43 from Bernardo Gonzalez Kriegel --- Created attachment 7 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7&action=edit Bug 12017 - 1 - Move language description out of database This patch adds identical copies of languages.inc file on include dirs, and modifies include files to process it. To test: 1. No change on current behavior must be observer, any page staff/opac -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13199] Incoherence between 'en' sample notices and translated notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13199 Frédéric Demians changed: What|Removed |Added Attachment #33216|0 |1 is obsolete|| --- Comment #9 from Frédéric Demians --- Created attachment 6 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6&action=edit Bug 13199 Add missing notices for several installations prove xt/sample_notices.sql identifies missing notices. This patch add those missing notices: - fr-FR ISSUEQSLIP, ISSUESLIP, OPAC_REG_VERIFY, RESERVESLIP, TRANSFERSLIP - it-IT/necessari/notices.sql: OPAC_REG_VERIFY, RENEWAL - pl-PL/mandatory/sample_notices.sql: ISSUEQSLIP, ISSUESLIP, OPAC_REG_VERIFY, RESERVESLIP, TRANSFERSLIP - ru-RU/mandatory/sample_notices.sql: ISSUEQSLIP, ISSUESLIP, OPAC_REG_VERIFY, RESERVESLIP, TRANSFERSLIP - uk-UA/mandatory/sample_notices.sql: ISSUEQSLIP, ISSUESLIP, OPAC_REG_VERIFY, RESERVESLIP, TRANSFERSLIP TO TEST: (1) Without this patch, but with the patch adding xt/sample_notices.sql: prove xt/sample_notices.sql list all the above missing notices. (2) Apply this patch. And do prove again: nothing is reported. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13211] Added: GoogleIndicTransliteration as a System Preference
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13211 --- Comment #12 from Katrin Fischer --- Created attachment 5 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5&action=edit [PASSED QA] Bug 13211: (followup) remove 'masthead' reference Signed-off-by: Tomas Cohen Arazi Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13211] Added: GoogleIndicTransliteration as a System Preference
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13211 Katrin Fischer changed: What|Removed |Added Attachment #33303|0 |1 is obsolete|| Attachment #33304|0 |1 is obsolete|| --- Comment #11 from Katrin Fischer --- Created attachment 4 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4&action=edit [PASSED QA] Bug-13211: Added Google Indic Transliteration as a System Preference Test scenario: 1. Apply the patch 2. Run updatedatabase.pl 3. Login to Koha and go to Adminstration. 4. Click on Global system preferences. 5. Search GoogleIndicTransliteration and choose value "Show". 6. Apply patches on bug 13144 7. Go to OPAC and see GoogleIndicTransliteration coming on Masthead. Signed-off-by: Mark Tompsett Signed-off-by: Tomas Cohen Arazi Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13211] Added: GoogleIndicTransliteration as a System Preference
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13211 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8753] Add forgot password link to OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #68 from Owen Leonard --- If you use the same password recover link twice you get an error which is inaccurate: "We could not authenticate you as the account owner Be sure to use the link you received in your email." It might make sense to retain entries in the borrower_password_recovery table for a certain amount of time after they have been "used" so that we can accurately tell the user that they have followed a link which is out of date. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13215] letter.code is considered as a primary key
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13215 --- Comment #6 from Tomás Cohen Arazi --- (In reply to M. Tompsett from comment #5) > (In reply to Katrin Fischer from comment #4) > > I am not sure how the discussion on bug 8753 relates to this patch - I think > > the point there was to not have SQL in the .pl files? > > So, SQL in .pm files is okay? I thought we were trying to move to DBIx as > much as possible. Mark, you are right about using DBIx. I'll talk to Jonathan about it. I might push it as-is if the release date approaches, because it is important to have it ASAP integrated for the beta. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12896] Move the bookseller-related code into its own module
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12896 --- Comment #29 from Katrin Fischer --- Created attachment 3 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3&action=edit [PASSED QA] Bug 12896: Remove 2 occurrences in comments Signed-off-by: Katrin Fischer Passes tests and QA script. Full test report on the bug report. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12896] Move the bookseller-related code into its own module
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12896 Katrin Fischer changed: What|Removed |Added Attachment #33164|0 |1 is obsolete|| Attachment #33298|0 |1 is obsolete|| --- Comment #28 from Katrin Fischer --- Created attachment 2 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=2&action=edit [PASSED QA] Bug 12896: Move the bookseller-related code into Koha::Acquisition::Bookseller The C4::Acquisition module should be exploded in order to add readability and maintainability to this part of the code. This patch is a POC, it introduces a new Koha::Acquisition::Bookseller module and put in it the code from GetBookSeller and GetBookSellerFromId. Test plan: 1/ Create a bookseller, modify it. 2/ Add contacts for this bookseller 3/ Create an order, receive it, transfer it 4/ Launch the prove command on all unit tests modified by this patch and verify that all pass. Signed-off-by: Paola Rossi Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12896] Move the bookseller-related code into its own module
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12896 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8836] Resurrect Rotating Collections
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836 --- Comment #122 from Tomás Cohen Arazi --- Created attachment 1 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=1&action=edit Bug 8836: Update DBIx Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8836] Resurrect Rotating Collections
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836 --- Comment #121 from Tomás Cohen Arazi --- Created attachment 0 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=0&action=edit Bug 8836: (RM followup) fix updatedatabase.pl rebase problem Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12896] Move the bookseller-related code into its own module
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12896 --- Comment #27 from Katrin Fischer --- C4/Acquisition.pm | 4 +- C4/Bookseller.pm | 53 + Koha/Acquisition/Bookseller.pm | 124 + acqui/addorderiso2709.pl | No regression found. acqui/basket.pl| No regression found. acqui/basketgroup.pl | No regression found. acqui/basketheader.pl | No regression found. acqui/booksellers.pl | No regression found. acqui/finishreceive.pl | No regression found. acqui/invoice.pl | No regression found. acqui/invoices.pl | No regression found. acqui/modordernotes.pl | No regression found. acqui/neworderbiblio.pl| No regression found. acqui/neworderempty.pl | No regression found. acqui/newordersubscription.pl | No regression found. acqui/newordersuggestion.pl| No regression found. acqui/orderreceive.pl | No regression found. acqui/parcel.pl| No regression found. acqui/parcels.pl | No regression found. acqui/supplier.pl | No regression found. acqui/transferorder.pl | No regression found. acqui/uncertainprice.pl| No regression found. acqui/z3950_search.pl | No regression found. admin/aqcontract.pl| No regresison found. catalogue/moredetail.pl| No regression found. serials/acqui-search-result.pl | No regression found. serials/subscription-detail.pl | No regression found. t/db_dependent/Acquisition.t | Pass t/db_dependent/Acquisition/Invoices.t | Pass t/db_dependent/Acquisition/OrderFromSubscription.t | Pass t/db_dependent/Bookseller.t| Pass t/db_dependent/Letters.t | Pass Serials - Subscription search - Subscription detail - vendor shows - Subscription edit - vendor can be searched and linked Acquisitons - vendors - searching for vendors - vendor details, editing a vendors Acquisitions - baskets & basket groups - adding a new basket group - printing PDF Acquisitons - uncertain prices - viewing uncertain prices list Acquisitions - contracts - adding, editing, deleting a contract Acquisition - baskets - adding a new basket - changing basket header details - order from z39.50 - order from 'new' - order from existing - order from staged - order from subscription - order from suggestion - transferring an order - adding vendor and internal note Acquisition - receive shipment - receive a new shipment - reveiving orders - undo receipt - canceling an order - giving a reason (new) - finish receiving Acquisitions - invoices - Searching for invoices - Closing an invoice - Viewing an invoice Catalog - detail page - Acquisition tab - Items tab - display of bookseller and acquisition information Also: git grep GetBookSeller - no references found. git grep GetBookSellerFromId - no references found. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13215] letter.code is considered as a primary key
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13215 --- Comment #5 from M. Tompsett --- (In reply to Katrin Fischer from comment #4) > I am not sure how the discussion on bug 8753 relates to this patch - I think > the point there was to not have SQL in the .pl files? So, SQL in .pm files is okay? I thought we were trying to move to DBIx as much as possible. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13215] letter.code is considered as a primary key
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13215 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #4 from Katrin Fischer --- I am not sure how the discussion on bug 8753 relates to this patch - I think the point there was to not have SQL in the .pl files? Joubu moved a lot of the logic into the module and wrote tests. This seems like a major improvement of the code in terms of coding guidelines. Also, there is a difference between new features and trying to improve old code. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13215] letter.code is considered as a primary key
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13215 M. Tompsett changed: What|Removed |Added CC||mtomp...@hotmail.com --- Comment #3 from M. Tompsett --- I'm wondering if this would pass QA. Marcel suggested that things with SQL in them might not pass QA here: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753#c64 Just thought I'd note this here to, perhaps, get clarification of whether the added functions should have explicit SQL queries in them like they do. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8836] Resurrect Rotating Collections
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8836 Tomás Cohen Arazi changed: What|Removed |Added Keywords||rel_3_18_candidate CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12250] Update descriptions for languages, scripts and regions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12250 Tomás Cohen Arazi changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12250] Update descriptions for languages, scripts and regions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12250 Tomás Cohen Arazi changed: What|Removed |Added Attachment #33127|0 |1 is obsolete|| --- Comment #7 from Tomás Cohen Arazi --- Created attachment 33329 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33329&action=edit Bug 12250: Update descriptions for languages, scripts and regions This patch adds/updates languages, scripts and regions to reflect what we currently have on translation server. Languages, scripts and regions are ordered by respective code To test: 1. Apply the patch 2. run updatedatabase.pl, must run without errors 3. Go to advanced search (opac/staff), more options, and check language pulldown (verify you have an empty AdvancedSearchLanguages syspref) 4. Remove contents from language_descriptions, language_rfc4646_to_iso639, language_script_bidi, language_script_mappin and language_subtag_registry 5. Load installer/data/mysql/mandatory/subtag_registry.sql, must load without errors 6. Repeat 3 Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13183] Improve visibility of automatic on-site checkout rule when OnSiteCheckoutsForce is on
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13183 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||tomasco...@gmail.com --- Comment #5 from Tomás Cohen Arazi --- Patch pushed to master. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13043] Remove incorrect link to unused DataTables columnFilter plugin on staff client search history page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13043 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||tomasco...@gmail.com --- Comment #4 from Tomás Cohen Arazi --- Patch pushed to master. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10582] Koha OPAC URL shows Perl error message before web installer was run
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10582 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #5 from Tomás Cohen Arazi --- Patch pushed to master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13215] letter.code is considered as a primary key
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13215 Tomás Cohen Arazi changed: What|Removed |Added Keywords||rel_3_18_candidate CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 --- Comment #33 from Martin Renvoize --- Created attachment 33328 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33328&action=edit Bug 12904 [Followup] - Add to Intranet for Dev Install I managed to miss the intranet vhost directive first time around.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 Martin Renvoize changed: What|Removed |Added Attachment #33317|0 |1 is obsolete|| --- Comment #28 from Martin Renvoize --- Created attachment 33323 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33323&action=edit Bug 12904 - Force browser to load new javascript files after upgrade A common issue with Koha seems to be that the web browsers continue to use cached js files after an upgrade. If we append the version as a parameter, we can force the browser to update the javascript files. 1) Apply this patch on a new branch based on master. 2) In a separate branch check out a previous version of Koha and go through the installation process on an empty database. 3) After logging into Koha, turn on Firebug's Net panel (or Chrome's Network panel) and turn on the filter for JavaScript files. 4) Clear the browser cache and navigate to a page, for instance Circulation. In Firebug the Net panel should show a status of "200 OK" for all files, indicating that the file was downloaded, not loaded from the cache. In Chrome the "size" column will show a file size if the file was downloaded. 5) Navigate to another page and confirm that scripts are being loaded from the cache: Scripts like jquery.js and jquery-ui.js which are loaded on every page should have a status in the Firebug Net panel of "304 Not Modified." In Chrome the "size" columns should show "from cache." 6) Check out the branch you created for testing this patch. 7) In order to preserve the state of your browser cache for accurate testing, open a different browser from the one you were previously testing with, load Koha, and run through the database update. 8) Return to your original testing browser and navigate to another Koha page. Firebug's Net panel should show that script files are now being downloaded with a "koha_version" query string. These files should have a status of "200 OK" indicating that they are being downloaded, not loaded from the cache. 9) Navigate to another page and conifrm that the new versions of the scripts are being loaded from the cache. To confirm that all affected JavaScripts links are working correctly, test these pages by checking the Firebug Net panel for errors: - Administration -> Currencies and exchange rates (jquery.dataTables.colvis.js) - Tools -> Stage MARC records for import (ajaxfileupload.js) or another page which performs a file upload. - Catalog -> Detail page -> MARC Preview (greybox JS) - Help -> Any help page - Any page which loads DataTables (Circulation in the staff client, for instance, and a title's detail page in the OPAC) - Bonus points if you check the various conditional JS includes controlled by the many OPAC feature preferences -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 Martin Renvoize changed: What|Removed |Added Attachment #33318|0 |1 is obsolete|| --- Comment #29 from Martin Renvoize --- Created attachment 33324 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33324&action=edit Bug 12904 [Followup] - Increase JS Cache Timeout With the addition of a method for explicetly forcing a cache refresh, we should make the sue of much large cache times for such files. This patch increases the ache time for javascript files from 12 hours to 60 days. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 Martin Renvoize changed: What|Removed |Added Attachment #33319|0 |1 is obsolete|| --- Comment #30 from Martin Renvoize --- Created attachment 33325 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33325&action=edit Bug 12904 [Followup] - Give same treatment to CSS We should really do this for other static files too, else you'll still get strange results when mismtaches of resource versions happen This patch applies the same logic to CSS files -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 Martin Renvoize changed: What|Removed |Added Attachment #33321|0 |1 is obsolete|| --- Comment #32 from Martin Renvoize --- Created attachment 33327 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33327&action=edit Bug 12904 [Followup] - Catch remaining JS files -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 Martin Renvoize changed: What|Removed |Added Attachment #33320|0 |1 is obsolete|| --- Comment #31 from Martin Renvoize --- Created attachment 33326 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33326&action=edit Bug 12904 [Followup] - Increase CSS Cache Timeout With the addition of a method for explicetly forcing a cache refresh, we should make the sue of much large cache times for such files. This patch increases the ache time for css files from 12 hours to 60 days. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13215] letter.code is considered as a primary key
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13215 --- Comment #2 from Jonathan Druart --- (In reply to Jonathan Druart from comment #1) > The patches submitted on bug 11742 tried to fix an issue based on a > (very) assertion: letter.code should be considered as a primary key and > should be uniq. ...based on a (very) *bad* assertion... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13214] Improve performance of acqui/addorderiso2709.pl, stop fetching all import_records needlessly
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13214 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13214] Improve performance of acqui/addorderiso2709.pl, stop fetching all import_records needlessly
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13214 Jonathan Druart changed: What|Removed |Added Attachment #33314|0 |1 is obsolete|| --- Comment #4 from Jonathan Druart --- Created attachment 33322 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33322&action=edit Bug 13214 - Improve performance of acqui/addorderiso2709.pl, stop fetching all import_records needlessly TEST PLAN: 1. Load 167 staged files to Koha. 2. Try to make an acquisiton from a staged file. 3. Wait 16s for the acqui/addorderiso2709.pl -view to load. AFTER PATCH: 1. Load 167 staged files to Koha. 2. Try to make an acquisiton from a staged file. 3. Wait 1.6s for the acqui/addorderiso2709.pl -view to load. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 Martin Renvoize changed: What|Removed |Added Attachment #33315|0 |1 is obsolete|| --- Comment #27 from Martin Renvoize --- Created attachment 33321 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33321&action=edit Bug 12904 [Followup] - Catch remaining JS files -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 Martin Renvoize changed: What|Removed |Added Attachment #33297|0 |1 is obsolete|| --- Comment #26 from Martin Renvoize --- Created attachment 33320 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33320&action=edit Bug 12904 [Followup] - Increase CSS Cache Timeout With the addition of a method for explicetly forcing a cache refresh, we should make the sue of much large cache times for such files. This patch increases the ache time for css files from 12 hours to 60 days. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 Martin Renvoize changed: What|Removed |Added Attachment #33296|0 |1 is obsolete|| --- Comment #25 from Martin Renvoize --- Created attachment 33319 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33319&action=edit Bug 12904 [Followup] - Give same treatment to CSS We should really do this for other static files too, else you'll still get strange results when mismtaches of resource versions happen This patch applies the same logic to CSS files -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 Martin Renvoize changed: What|Removed |Added Attachment #33287|0 |1 is obsolete|| --- Comment #23 from Martin Renvoize --- Created attachment 33317 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33317&action=edit Bug 12904 - Force browser to load new javascript files after upgrade A common issue with Koha seems to be that the web browsers continue to use cached js files after an upgrade. If we append the version as a parameter, we can force the browser to update the javascript files. 1) Apply this patch on a new branch based on master. 2) In a separate branch check out a previous version of Koha and go through the installation process on an empty database. 3) After logging into Koha, turn on Firebug's Net panel (or Chrome's Network panel) and turn on the filter for JavaScript files. 4) Clear the browser cache and navigate to a page, for instance Circulation. In Firebug the Net panel should show a status of "200 OK" for all files, indicating that the file was downloaded, not loaded from the cache. In Chrome the "size" column will show a file size if the file was downloaded. 5) Navigate to another page and confirm that scripts are being loaded from the cache: Scripts like jquery.js and jquery-ui.js which are loaded on every page should have a status in the Firebug Net panel of "304 Not Modified." In Chrome the "size" columns should show "from cache." 6) Check out the branch you created for testing this patch. 7) In order to preserve the state of your browser cache for accurate testing, open a different browser from the one you were previously testing with, load Koha, and run through the database update. 8) Return to your original testing browser and navigate to another Koha page. Firebug's Net panel should show that script files are now being downloaded with a "koha_version" query string. These files should have a status of "200 OK" indicating that they are being downloaded, not loaded from the cache. 9) Navigate to another page and conifrm that the new versions of the scripts are being loaded from the cache. To confirm that all affected JavaScripts links are working correctly, test these pages by checking the Firebug Net panel for errors: - Administration -> Currencies and exchange rates (jquery.dataTables.colvis.js) - Tools -> Stage MARC records for import (ajaxfileupload.js) or another page which performs a file upload. - Catalog -> Detail page -> MARC Preview (greybox JS) - Help -> Any help page - Any page which loads DataTables (Circulation in the staff client, for instance, and a title's detail page in the OPAC) - Bonus points if you check the various conditional JS includes controlled by the many OPAC feature preferences -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904 Martin Renvoize changed: What|Removed |Added Attachment #33288|0 |1 is obsolete|| --- Comment #24 from Martin Renvoize --- Created attachment 33318 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33318&action=edit Bug 12904 [Followup] - Increase JS Cache Timeout With the addition of a method for explicetly forcing a cache refresh, we should make the sue of much large cache times for such files. This patch increases the ache time for javascript files from 12 hours to 60 days. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
