[Koha-bugs] [Bug 13223] Plugin housekeeping: do not redefine wrapper
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13223 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13223] Plugin housekeeping: do not redefine wrapper
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13223 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added CC||jonathan.dru...@biblibre.co ||m --- Comment #18 from Jonathan Druart jonathan.dru...@biblibre.com --- We must be careful that Koha::Util does not get messy. IMO we should not use it at all, that force developers to use something else. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13233] Patron search by birth date tooltip broken
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13233 Frédéric Demians frede...@tamil.fr changed: What|Removed |Added Attachment #33500|0 |1 is obsolete|| --- Comment #3 from Frédéric Demians frede...@tamil.fr --- Created attachment 33549 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33549action=edit Bug 13233 - Patron search by birth date tooltip broken When the user selects a patron search by birth date a tooltip is supposed to appear showing the date format requirement. Bug 9811 (Patron search improvement) changed the ID on which the tooltip depended to function. This patch corrects it. To test, apply the patch and go to the Patrons home page in the staff client. In the header search form select Date of birth from the search fields dropdown. This should trigger a tooltip showing the required date format. Signed-off-by: Frederic Demians f.demi...@tamil.fr I confirm the tooltip comeback with this patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13233] Patron search by birth date tooltip broken
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13233 Frédéric Demians frede...@tamil.fr changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13223] Plugin housekeeping: do not redefine wrapper
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13223 --- Comment #19 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Jonathan - where would you put it? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13223] Plugin housekeeping: do not redefine wrapper
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13223 --- Comment #20 from M. de Rooy m.de.r...@rijksmuseum.nl --- (In reply to Jonathan Druart from comment #18) We must be careful that Koha::Util does not get messy. IMO we should not use it at all, that force developers to use something else. I agree on the first line. But the four line wrapper thing is a typical example of a util. (Note that I initially left it in cataloguing/value_builder, but was asked to move it to a util folder.) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13195] Regression: Circulation checkouts table no longer shows item type description
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13195 Frédéric Demians frede...@tamil.fr changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13195] Regression: Circulation checkouts table no longer shows item type description
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13195 Frédéric Demians frede...@tamil.fr changed: What|Removed |Added Attachment #33525|0 |1 is obsolete|| --- Comment #2 from Frédéric Demians frede...@tamil.fr --- Created attachment 33550 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33550action=edit Bug 13195 - Regression: Circulation checkouts table no longer shows item type description Another regression caused by Bug 11703: The list of checkouts on the circulation and patron detail page shows item type codes instead of the full description. Test Plan: 1) View a patron's checkouts, note the Item type column displays the code rather than the description. 2) Apply this patch 3) Refresh the page, note the description is now displayed Signed-off-by: Frederic Demians f.demi...@tamil.fr Works as described. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13167] Stage MARC for Import hangs for biblio containing valid 979* ISBN-13
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13167 --- Comment #8 from Frédéric Demians frede...@tamil.fr --- (In reply to Tiburce Euphrasie from comment #7) Aloha, Yes, it works, I tried it on a Koha 3.16.03 and there's no problem : I can import both records, I can find them and the ISBN are preserved. Thanks for confirming it works for you. It will help to get this patch back to Koha main code repository. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13230] Bug 12995 causes test case failures
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13230 Fridolin SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added Depends on||12995 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12995] script update_totalissues.pl stops on corrupted record
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12995 Fridolin SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added Blocks||13230 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13242] Slow checkin for patrons restricted indefinitely
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13242
--- Comment #5 from Jonathan Druart jonathan.dru...@biblibre.com ---
(In reply to Frédéric Demians from comment #4)
It seems to come from here:
https://metacpan.org/pod/DateTime#Determining-the-Local-Time-Zone-Can-Be-Slow
Why is it necessary to use timezone for DateTime conversion process in the
first place?
Salut Frédéric,
I don't understand, what is the first place?
we use DateTime::Format::DateParse-parse_datetime, not DateTime-new (maybe it
calls it, I didn't deep into the code).
All what I know is that it is useless to specify timezone for -12-31 :)
Note that $ENV{TZ} is not set on my local instance.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13223] Plugin housekeeping: do not redefine wrapper
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13223 --- Comment #21 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to Katrin Fischer from comment #19) Jonathan - where would you put it? I don't know :) Koha::Cataloguing::Plugin? (In reply to M. de Rooy from comment #20) I agree on the first line. But the four line wrapper thing is a typical example of a util. (Note that I initially left it in cataloguing/value_builder, but was asked to move it to a util folder.) At some points, all can be considered as a util :) It was just a quick note, I did not want to block this patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13223] Plugin housekeeping: do not redefine wrapper
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13223 --- Comment #22 from M. de Rooy m.de.r...@rijksmuseum.nl --- (In reply to Jonathan Druart from comment #21) (In reply to Katrin Fischer from comment #19) Jonathan - where would you put it? I don't know :) Koha::Cataloguing::Plugin? No please, bug 10480 will add a real object for plugins. Work in progress.. At some points, all can be considered as a util :) It was just a quick note, I did not want to block this patch. Great. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13151] staff marc preview not wrapping
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13151 Frédéric Demians frede...@tamil.fr changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13151] staff marc preview not wrapping
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13151 Frédéric Demians frede...@tamil.fr changed: What|Removed |Added Attachment #33529|0 |1 is obsolete|| --- Comment #2 from Frédéric Demians frede...@tamil.fr --- Created attachment 33551 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33551action=edit Bug 13151 - staff marc preview not wrapping The MARC preview available on the staff client detail page doesn't wrap long lines of text because it uses a huge block of whitespace-formatted text in a pre tag. The OPAC doesn't have this problem because the MARC preview is formated in a table. This patch copies the OPAC's plainMARC.xsl file for use in the staff client. The preview modal has been converted to use Bootstrap following the method used in Bug 12755 To test, apply the patch and clear your browser cache. View the detail page for a bibliographic record in the staff client. Click the link to show the MARC preview. Confirm that the modal looks correct, works correctly, and adapts gracefully to different browser widths. Confirm that the MARC preview and Card links still work from Z39.50 searches. Note: This patch assumes that UNIMARC records display correctly using xslt/plainMARC.xsl. Please let me know if that is wrong. Signed-off-by: Frederic Demians f.demi...@tamil.fr I confirm it works: nice modal dialog box; display aligned on opac display; works also with Unimarc biblios. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11814] Serial statuses should be stored in constants
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11814 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #33514|0 |1 is obsolete|| --- Comment #11 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 33552 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33552action=edit Bug 11814 - (follow-up) Use constants to describe statuses This patch deals with all hard-coded status codes in the C4::Serials module. Test plan: Test a complete workflow in the serial module (create, order, receive, generate next) trying to use all statuses. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11814] Serial statuses should be stored in constants
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11814 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11814] Serial statuses should be stored in constants
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11814
--- Comment #12 from Jonathan Druart jonathan.dru...@biblibre.com ---
(In reply to Paola Rossi from comment #10)
I've applied the patch against master 3.17.00.054
I've created a subscription [length 1 issues].
Selecting Serial collection of the subscription, I checked the EXPECTED
issue and selected Edit serials.
I changed the issue from the EXPECTED status to the ARRIVED status.
A new issue in the EXPECTED status should have been created [the next
issue], but it was not.
Paola,
Sorry for that, 1 replacement was wrong!
I checked all of them and it should be good now.
The new expected issue is now generated.
Changes are:
@@ -1245,7 +1245,7 @@ sub ModSerialStatus {
}
$missinglist .= ; $serialseq
-if ( ( grep { $_ == $status } ( MISSING_STATUSES, NOT_ISSUED )
) ( $missinglist !~/(^|;)\s*$serialseq(?=;|$)/ ) );
+if ( ( grep { $_ == $status } ( MISSING_STATUSES ) ) (
$missinglist !~/(^|;)\s*$serialseq(?=;|$)/ ) );
$missinglist .= ; not issued $serialseq
if ( $status == NOT_ISSUED $missinglist !~
/(^|;)\s*$serialseq(?=;|$)/ );
@@ -1258,7 +1258,7 @@ sub ModSerialStatus {
}
# create new waited entry if needed (ie : was a waited and has changed)
-if ( $oldstatus == ARRIVED $status != ARRIVED ) {
+if ( $oldstatus == EXPECTED $status != EXPECTED ) {
my $subscription = GetSubscription($subscriptionid);
my $pattern =
C4::Serials::Numberpattern::GetSubscriptionNumberpattern($subscription-{numberpattern});
The first one is a bad merge conflict.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13223] Plugin housekeeping: do not redefine wrapper
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13223 --- Comment #23 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Bit worried about adding 'plugin' confusion, as we also have the younger plugin system and TT plugins... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12973] Allow passing code to XSLT_Handler instead of filename
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12973 Martin Renvoize martin.renvo...@ptfs-europe.com changed: What|Removed |Added Attachment #31864|0 |1 is obsolete|| --- Comment #3 from Martin Renvoize martin.renvo...@ptfs-europe.com --- Created attachment 33553 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33553action=edit [Signed Off] Bug 12973: Allow passing code to XSLT_Handler instead of filename This patch adds the option to pass a code string to the XSLT handler object instead of passing a filename. This is achieved by a change to parameter hashref. The old style parameters are also allowed. Note that this patch should not change behavior but will be used in future development: see bug 12758 or bug 12754. Test plan: Verify that behavior did not change in the following steps. [1] Edit OPACXSLTResultsDisplay in order to use XSLT. [2] Check search results page in OPAC. [3] Edit OPACXSLTDetailsDisplay in order to use XSLT. [4] Check detail page in OPAC. Signed-off-by: Martin Renvoize martin.renvo...@ptfs-europe.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12973] Allow passing code to XSLT_Handler instead of filename
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12973 Martin Renvoize martin.renvo...@ptfs-europe.com changed: What|Removed |Added Attachment #31865|0 |1 is obsolete|| --- Comment #4 from Martin Renvoize martin.renvo...@ptfs-europe.com --- Created attachment 33554 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33554action=edit [Signed Off] Bug 12973: Additional unit tests for XSLT_Handler.t The additional way of parameter passing is tested in three additional tests. Test plan: Verify if XSLT_Handler.t passes. Signed-off-by: Martin Renvoize martin.renvo...@ptfs-europe.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12973] Allow passing code to XSLT_Handler instead of filename
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12973 Martin Renvoize martin.renvo...@ptfs-europe.com changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||martin.renvoize@ptfs-europe ||.com --- Comment #5 from Martin Renvoize martin.renvo...@ptfs-europe.com --- Works for me, no regressions. Tests all pass, and code passes qa scripts, happy to sign off. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13223] Plugin housekeeping: do not redefine wrapper
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13223 --- Comment #24 from M. de Rooy m.de.r...@rijksmuseum.nl --- (In reply to Katrin Fischer from comment #23) Bit worried about adding 'plugin' confusion, as we also have the younger plugin system and TT plugins... Thats why I renamed to FrameworkPlugin. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13242] Slow checkin for patrons restricted indefinitely
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13242 --- Comment #6 from Frédéric Demians frede...@tamil.fr --- I don't understand, what is the first place? I mean: Is it really necessary to use timezone in dt_from_string function? Otherwise, I fully agree that your patch solve the bug (ugly one). I would add a FIXME comment in the code to point to bug number, in order to avoid that someone else reintroduce the bug in the future. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13242] Slow checkin for patrons restricted indefinitely
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13242 --- Comment #7 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to Frédéric Demians from comment #6) I don't understand, what is the first place? I mean: Is it really necessary to use timezone in dt_from_string function? I don't know. Otherwise, I fully agree that your patch solve the bug (ugly one). I would add a FIXME comment in the code to point to bug number, in order to avoid that someone else reintroduce the bug in the future. Maybe a test based on localtime_before - localtime_after should be 3 sec. But it's not really clean, it could depend on the load of the machine. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13242] Slow checkin for patrons restricted indefinitely
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13242 --- Comment #8 from Frédéric Demians frede...@tamil.fr --- Maybe a test based on localtime_before - localtime_after should be 3 sec. But it's not really clean, it could depend on the load of the machine. Very good suggestion. I'd try to add a test to t/DateUtils.t before signing your patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11413] Marc modification template has not the expected behavior if the condition and source fields are on the same field
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11413 --- Comment #46 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 33556 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33556action=edit Bug 11413: UT to show up the issue These UT reflect this change: - deletion of the field 245 if 245$a='Bad title' - move of the 650 field to 651 if 650$9=499 Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Brendan Gallagher bren...@bywatersolutions.com Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11413] Marc modification template has not the expected behavior if the condition and source fields are on the same field
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11413 --- Comment #48 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 33558 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33558action=edit Bug 11413: Fix return for ModifyRecordWithTemplate Make sure the ModifyRecordWithTemplate routine returns undef. This patch also removes a warning if GetModificationTemplates is called without parameter. Verify prove t/db_dependent/MarcModificationTemplates.t returns green. Signed-off-by: Brendan Gallagher bren...@bywatersolutions.com Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11413] Marc modification template has not the expected behavior if the condition and source fields are on the same field
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11413 --- Comment #49 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 33559 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33559action=edit Bug 11413: Fix field_numbers This fix is a global fix for the MarcModificationTemplate feature. Some unit tests were missing and some behaviors were wrong. For instance, if you tried to update a non existent field, the script crashed. The following line was completely stupid: if $from_field ne $to_subfield The field_number equals 1 if the user wants to update the first field and 0 for all fields. The field_numbers (note the s) variable contains the field numbers to update. This array is filled if a condition exists (field exists or field equals). Signed-off-by: Brendan Gallagher bren...@bywatersolutions.com Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11413] Marc modification template has not the expected behavior if the condition and source fields are on the same field
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11413 --- Comment #47 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 33557 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33557action=edit Bug 11413: Reflect the changes to the interface Test plan: - add/edit an action on the marc modification templates tools - choose an action and define a condition - define the source field as same as the condition field - verify the All/1st dropdown list is changed to Every/1st Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Brendan Gallagher bren...@bywatersolutions.com Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11413] Marc modification template has not the expected behavior if the condition and source fields are on the same field
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11413 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Attachment #33213|0 |1 is obsolete|| Attachment #33214|0 |1 is obsolete|| Attachment #33215|0 |1 is obsolete|| Attachment #33482|0 |1 is obsolete|| Attachment #33483|0 |1 is obsolete|| --- Comment #45 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 33555 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33555action=edit Bug 11413: Change the field number logic This patch series is a bugfix for the Marc modification templates tool. Bug description: If you want to do an action (delete/update/move/...) on a multivalued field and if a condition is defined on the same field, it is highly probable the resulted record will not be what you expect. For example: Deleting All (or the first) fields 650 if 245$a=Bad title works with the current code. BUT if you want to delete All (or the first) fields 650 with a condition on 650$9=42, and if at least one field matches the condition : - if you have selected all, all fields 650 will be deleted, even the ones who do not match the condition. - if you have selected first, the first 650 field will be deleted, even if it does not match the condition. The expected behavior is to delete the fields matching the condition (and not all the 650 fields). What this patch does: This patch introduces 2 changes in the logic of Koha::SimpleMARC. The first change is a change of the prototypes for the 2 routines field_exists and field_equals. Now they return the field number of the matching fields. The second change is the type of the n parameter for all routines using it in Koha::SimpleMARC. Before this patch, the n parameter was a boolean in most cases. If 0, the action was done on all fields, if 1 on the first one only. Now it is possible to specify the field numbers (so the array of field numbers which is returned by field_exists or field_equals) for all routines which had the n parameter. Test plan for the patch series: Note: This test plan describes a specific example, feel free to create your own one. 0/ Define a marc modification template with the following action: Delete field 245 if 245$9 = 42 1/ choose and export a record with several 245 fields. For ex: 245 $a The art of computer programming $c Donald E. Knuth. $9 41 245 $a Bad title $c Bad author $9 42 2/ import it using the Stage MARC for import tool. 3/ verify the imported record does not contain any 245 field. 4/ apply all the patches from this bug report 5/ do again steps 2 and 3 6/ verify the imported record contains only one 245 field, the one with 245$9=41 7/ verify the unit tests passed: prove t/SimpleMARC.t prove t/db_dependent/MarcModificationTemplates.t Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Brendan Gallagher bren...@bywatersolutions.com Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11413] Marc modification template has not the expected behavior if the condition and source fields are on the same field
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11413
M. de Rooy m.de.r...@rijksmuseum.nl changed:
What|Removed |Added
Status|Signed Off |Passed QA
--- Comment #50 from M. de Rooy m.de.r...@rijksmuseum.nl ---
QA Comment:
Great work!
No complaints from qa tools.
Adjusted tests pass.
Problem reported earlier has been resolved.
Thanks for improving variable names. This illustrates that bad variable naming
is a bug source.
Also thanks for adding tests.
Small note: Lines (without comment) like
@values = map { $_ = @values ? $values[ $_ - 1 ] : () } @$field_numbers;
might be marked as somewhat obfuscating ;)
The All/Every change is not really needed imo, and does not seem to work always
when changing a condition. But np ;)
This report does not deal with (nor introduce) this warning, but I just note
that I would really like to get rid of it ;)
Maybe, Kyle could resolve that one in least time.. Something with forks and
STDOUT etc.
stage-marc-import.pl: Filehandle STDOUT reopened as FH only for input at
/usr/local/lib64/perl5/Template/Provider.pm line 964., referer:
http://libdevelop.rijksmuseum.nl:8009/cgi-bin/koha/tools/stage-marc-import.pl
Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13242] Slow checkin for patrons restricted indefinitely
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13242 --- Comment #9 from Frédéric Demians frede...@tamil.fr --- Created attachment 33560 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33560action=edit Bug 13242 Add a UT to t/DateUtils.t for testing DateTime bug A bug in DateTime slow down drastically date parsing when the dates are in the far distant future: https://metacpan.org/pod/DateTime#Determining-the-Local-Time-Zone-Can-Be-Slow This UT tests this situation. TO TEST: - Apply the patch containing the UT - prove -v t/DateUtils.t - You see that parsing a -01-01 that take forever (ie more than 1s) - Apply Jonathan patch - prove -v t/DateUtils.t - No more complain. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13242] Slow checkin for patrons restricted indefinitely
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13242
Frédéric Demians frede...@tamil.fr changed:
What|Removed |Added
Attachment #33511|0 |1
is obsolete||
--- Comment #10 from Frédéric Demians frede...@tamil.fr ---
Created attachment 33561
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33561action=edit
Bug 13242: DateUtils should manage separately -* dates
On bug 13226, we have seen that
my $date = DateTime-new(year = , month = 12, day = 31);
= OK
DateTime::Format::DateParse-parse_datetime( '-12-31' );
= OK
DateTime::Format::DateParse-parse_datetime( '-12-31',
'America/Los_Angeles' );
= KO (~20sec on my laptop)
For instance if you try to check in items for a patron which is
restricted indefinitely (and there is no overdue on the item), the code
in C4::Circulation::AddReturn l~1948
my $borrower_debar_dt = dt_from_string( $borrower-{debarred} );
will be called.
dt_from_string should not called
DateTime::Format::DateParse-parse_datetime with the time zone parameter
in this case.
Test plan:
Create an indefinitely restriction for a patron and check an item in.
Without this patch, it should take ~20 sec.
With, ~2 or 3 sec.
Signed-off-by: Frederic Demians f.demi...@tamil.fr
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13242] Slow checkin for patrons restricted indefinitely
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13242 Frédéric Demians frede...@tamil.fr changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13242] Slow checkin for patrons restricted indefinitely
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13242 --- Comment #11 from Jonathan Druart jonathan.dru...@biblibre.com --- Comment on attachment 33560 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33560 Bug 13242 Add a UT to t/DateUtils.t for testing DateTime bug Review of attachment 33560: -- (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.htmlbug=13242attachment=33560) - ::: t/DateUtils.t @@ +7,2 @@ use Test::MockModule; +use Time::HiRes qw/ gettimeofday /; Time::HiRes seems to be a new dependency. Is not it possible to do the same without adding it? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12505] Variable aqorders.listprice from 'Tools' - 'Notices and Slips' Does not work
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12505 --- Comment #12 from Paola Rossi paola.ro...@cineca.it --- (In reply to simith.doliveira from comment #11) The problem described in the comment 9: Can't use an undefined value as an ARRAY reference at /usr/lib/perl5/DBI.pm line 2054. I could verify even before applying the patch, but I corrected it in the second patch Kind Simith, I'm very sorry, the error is mine. I should not have considered that behaviour in this bug, I beg your pardon. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12505] Variable aqorders.listprice from 'Tools' - 'Notices and Slips' Does not work
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12505 Paola Rossi paola.ro...@cineca.it changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13242] Slow checkin for patrons restricted indefinitely
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13242 --- Comment #12 from Frédéric Demians frede...@tamil.fr --- Time::HiRes seems to be a new dependency. Is not it possible to do the same without adding it? I see Time::HiRes in core dependencies: http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=C4/Installer/PerlDependencies.pm;h=09be2cda3e3ccc84777d1e50b9d2054d778d6a0f;hb=HEAD#l490 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12505] Variable aqorders.listprice from 'Tools' - 'Notices and Slips' Does not work
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12505 Paola Rossi paola.ro...@cineca.it changed: What|Removed |Added Attachment #31034|0 |1 is obsolete|| --- Comment #13 from Paola Rossi paola.ro...@cineca.it --- Created attachment 33562 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33562action=edit Bug 12505 31034: This patch removes the unnecessary join I've applied the patch against master 3.17.00.054 head 11634 IMO the second patch Variable aqorders.listprice from 'Tools' - 'Notices and Slips' is not needed. I pass the patch This patch removes the unnecessary join to Signed Off status. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12432] Saved reports tabs not working
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12432 Koha Team AMU koha.aixmarsei...@gmail.com changed: What|Removed |Added CC||koha.aixmarsei...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12043] Popup when reserved item checked in at wrong branch should generate transfer slip
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12043 Benjamin Rokseth benjamin.roks...@kul.oslo.kommune.no changed: What|Removed |Added Attachment #28609|0 |1 is obsolete|| --- Comment #7 from Benjamin Rokseth benjamin.roks...@kul.oslo.kommune.no --- Created attachment 33563 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33563action=edit Bug 12043 - Popup when reserved item checked in at wrong branch should generate transfer slip This patch corrects some wrong popups in Returns.tt handling transfers of reserved items. Instead of using hold-transfer-slip.pl with param transfer=1 (which seems to be silently ignored) it uses transfer-slip.pl with itemnumber and destination branch, which allows for printing correct slips. It also removes the non-used param $tranfer in hold-transfer-slip.pl. Test plan: ( see cases in bug description ) 1) Make a reservation on item with homebranch A to branch B 2) checkin item at its homebranch A 3) press 'Print slip and confirm transfer' 4) verify that slip uses template RESERVESLIP 5) apply patch 6) repeat steps 1-3 7) verify that slip now uses template TRANSFERSLIP Signed-off-by: Nick Clemens n...@quecheelibrary.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12043] Popup when reserved item checked in at wrong branch should generate transfer slip
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12043 Benjamin Rokseth benjamin.roks...@kul.oslo.kommune.no changed: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13242] Slow checkin for patrons restricted indefinitely
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13242 --- Comment #13 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to Frédéric Demians from comment #12) Time::HiRes seems to be a new dependency. Is not it possible to do the same without adding it? I see Time::HiRes in core dependencies: http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=C4/Installer/ PerlDependencies.pm;h=09be2cda3e3ccc84777d1e50b9d2054d778d6a0f;hb=HEAD#l490 Oops yes, sorry. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13242] Slow checkin for patrons restricted indefinitely
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13242 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #33560|0 |1 is obsolete|| Attachment #33561|0 |1 is obsolete|| --- Comment #14 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 33564 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33564action=edit Bug 13242: Add a UT to t/DateUtils.t for testing DateTime bug A bug in DateTime slow down drastically date parsing when the dates are in the far distant future: https://metacpan.org/pod/DateTime#Determining-the-Local-Time-Zone-Can-Be-Slow This UT tests this situation. TO TEST: - Apply the patch containing the UT - prove -v t/DateUtils.t - You see that parsing a -01-01 that take forever (ie more than 1s) - Apply Jonathan patch - prove -v t/DateUtils.t - No more complain. Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13245] Send Cart via Email corrupts some Unicode characters
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13245 Frédéric Demians frede...@tamil.fr changed: What|Removed |Added CC||frede...@tamil.fr --- Comment #1 from Frédéric Demians frede...@tamil.fr --- - Enter your email address and enter ออ as the comment. - View your email, you will get something like �¸ � as comment. This is a known bug from HTML-Format used by html2text TT filter which was used to format email message: https://rt.cpan.org/Public/Bug/Display.html?id=9700 It works on master with French accented characters. Could your provide the culprit characters in an attached text file, and in a screenshot? We may also fix this problem on Koha side as well by not using html2text and turn the template into plain text (or turn the email into HTML). It's not an option. The template is in HTML in order to be translatable: see bug 8062. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13242] Slow checkin for patrons restricted indefinitely
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13242
--- Comment #15 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 33565
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33565action=edit
Bug 13242: DateUtils should manage separately -* dates
On bug 13226, we have seen that
my $date = DateTime-new(year = , month = 12, day = 31);
= OK
DateTime::Format::DateParse-parse_datetime( '-12-31' );
= OK
DateTime::Format::DateParse-parse_datetime( '-12-31',
'America/Los_Angeles' );
= KO (~20sec on my laptop)
For instance if you try to check in items for a patron which is
restricted indefinitely (and there is no overdue on the item), the code
in C4::Circulation::AddReturn l~1948
my $borrower_debar_dt = dt_from_string( $borrower-{debarred} );
will be called.
dt_from_string should not called
DateTime::Format::DateParse-parse_datetime with the time zone parameter
in this case.
Test plan:
Create an indefinitely restriction for a patron and check an item in.
Without this patch, it should take ~20 sec.
With, ~2 or 3 sec.
Signed-off-by: Frederic Demians f.demi...@tamil.fr
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13242] Slow checkin for patrons restricted indefinitely
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13242 --- Comment #16 from Jonathan Druart jonathan.dru...@biblibre.com --- I added my sign off on your patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12778] Regression: Item lost status doesn't show in list of checkouts
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12778 --- Comment #5 from Kyle M Hall k...@bywatersolutions.com --- (In reply to Owen Leonard from comment #4) Only the lost status should display. Available should not display for items which are not lost. Checking out 3.14.x and looking at the way it used to look is helpful. I notice that in 3.14.x the damaged status of items also appeared in that column the same way the lost status did. I didn't take into account the possibility that the description for lost value 0 would be filled in ( it's not in the default data ). I will correct that and see if I can't do the same for the damaged status. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12778] Regression: Item lost status doesn't show in list of checkouts
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12778 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #33526|0 |1 is obsolete|| --- Comment #6 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 33566 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33566action=edit Bug 12778 - Regression: Item lost status doesn't show in list of checkouts When using the longoverdue script it's possible that items marked lost remain on the patron account. I think it's important for staff to see that some items are marked lost - currently the list of checkouts doesn't show any sign of the lost status. Test Plan: 1) Find a patron with a checked out lost item 2) Note the lost status is not displayed in the checkouts table 3) Apply this patch 4) Refresh the page, note the lost status now displays 5) Repeat this test plan for a damaged item -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12778] Regression: Item lost status doesn't show in list of checkouts
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12778 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13253] Unnecessary white space above checkouts table in circulation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13253 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||tomasco...@gmail.com --- Comment #4 from Tomás Cohen Arazi tomasco...@gmail.com --- Patch pushed to master. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13232] patron letter browse not working
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13232 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #6 from Tomás Cohen Arazi tomasco...@gmail.com --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6681] Provide a way for removing authority links and holdings on Z39.50 record import
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6681 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Summary|When importing a biblio |Provide a way for removing |record via Z39.50, |authority links and |authority links and items |holdings on Z39.50 record |also get imported |import Severity|major |enhancement -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6681] Provide a way for removing authority links and holdings on Z39.50 record import
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6681 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #32 from Tomás Cohen Arazi tomasco...@gmail.com --- Patches pushed to master. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13075] Use of uninitialized value while proving db_dependent/Holds.t
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13075 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||tomasco...@gmail.com --- Comment #15 from Tomás Cohen Arazi tomasco...@gmail.com --- Patches pushed to master. Thanks Mark! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12779] Capitalization: strings on subscription add page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12779 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||tomasco...@gmail.com --- Comment #5 from Tomás Cohen Arazi tomasco...@gmail.com --- Patch pushed to master. Thanks Katrina! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12122] TransferSlip should accept both itemnumber and barcode
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12122 Benjamin Rokseth benjamin.roks...@kul.oslo.kommune.no changed: What|Removed |Added Status|In Discussion |Signed Off --- Comment #8 from Benjamin Rokseth benjamin.roks...@kul.oslo.kommune.no --- Resetting this to signed off and awaiting QA as the discussion never came and tests are still passing. It was already tagged for release candidate 3.16 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13085] bugfix : tools/export.pl don't works in commandline without id_list_file parameter
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13085 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added CC||k...@bywatersolutions.com --- Comment #5 from Kyle M Hall k...@bywatersolutions.com --- *** Bug 13197 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13197] Export.pl errors out on command line if --id_list_file is not provided
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13197 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Failed QA |RESOLVED Resolution|--- |DUPLICATE --- Comment #5 from Kyle M Hall k...@bywatersolutions.com --- It looks like I jumped the gun with this. It was already fixed in master when I posted this patch by bug 13085. *** This bug has been marked as a duplicate of bug 13085 *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13254] New: Delete record don't wait for confirmation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13254 Bug ID: 13254 Summary: Delete record don't wait for confirmation Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Templates Assignee: rkopac...@afm.edu.pl Reporter: rkopac...@afm.edu.pl QA Contact: testo...@bugs.koha-community.org In some cases (eg. when Staf Client Search is active), when user choose Edit-Delete record on record tool bar, browser don't wait for confirmation and goes immediately to delete record. To reproduce: 1. Search for some biblio records and choose one without items attached. 2. Note that there, must be Return to search results box on left side, bug works in that case, when in normal view everything work fine. 3. Click Edit-Delete record, watch that confirmation box shows, but don't wait for OK and runs immediately. If you are fast enough to click OK, then you get error as below, because record was deleted earlier. Software error: Can't call method title on an undefined value at /home/koha/kohaclon/cataloguing/addbiblio.pl line 826. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12778] Regression: Item lost status doesn't show in list of checkouts
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12778 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Attachment #33566|0 |1 is obsolete|| --- Comment #7 from Owen Leonard oleon...@myacpl.org --- Created attachment 33567 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33567action=edit [SIGNED-OFF] Bug 12778 - Regression: Item lost status doesn't show in list of checkouts When using the longoverdue script it's possible that items marked lost remain on the patron account. I think it's important for staff to see that some items are marked lost - currently the list of checkouts doesn't show any sign of the lost status. Test Plan: 1) Find a patron with a checked out lost item 2) Note the lost status is not displayed in the checkouts table 3) Apply this patch 4) Refresh the page, note the lost status now displays 5) Repeat this test plan for a damaged item Signed-off-by: Owen Leonard oleon...@myacpl.org Tested successfully with damaged and multiple lost values. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12778] Regression: Item lost status doesn't show in list of checkouts
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12778 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13254] Delete record don't wait for confirmation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13254 --- Comment #1 from Owen Leonard oleon...@myacpl.org --- This sounds like Bug 11817 which I thought was fixed. Are you testing in master? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13254] Delete record don't wait for confirmation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13254 --- Comment #3 from Rafal Kopaczka rkopac...@afm.edu.pl --- Created attachment 33568 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33568action=edit Bug 13254 - Delete record don't wait for confirmation In some cases (eg. when Staf Client Search is active), when user choose Edit-Delete record on record tool bar, browser don't wait for confirmation and goes immediately to delete record. To reproduce: 1. Search for some biblio records and choose one without items attached. 2. Note that there, must be Return to search results box on left side, bug works in that case, when in normal view everything work fine. 3. Click Edit-Delete record, watch that confirmation box shows, but don't wait for OK and runs immediately. If you are fast enough to click OK, then you get error as below, because record was deleted earlier. To test: 1. Apply patch. 2. Follow reproduce steps. 3. Check if waits for confirmation in all cases. 4. Check if deletes record after confirm. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13254] Delete record don't wait for confirmation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13254 --- Comment #2 from Rafal Kopaczka rkopac...@afm.edu.pl --- (In reply to Owen Leonard from comment #1) This sounds like Bug 11817 which I thought was fixed. Are you testing in master? Yes, today's master. It's maybe similar but removing (unnecessary) href from delete link in cat-toolbar.inc fixes problem. I'll attach patch for a while. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13254] Delete record don't wait for confirmation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13254 Rafal Kopaczka rkopac...@afm.edu.pl changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13237] Regression: List of previous checkouts should be ordered by due date ascending
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13237 --- Comment #3 from Owen Leonard oleon...@myacpl.org --- Created attachment 33569 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33569action=edit Broken table ordering after apply the patch I'm getting broken table ordering after applying this patch. I applied the patch, cleared the browser cache, and checked out some items. Then I reloaded the page and got this result. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13237] Regression: List of previous checkouts should be ordered by due date ascending
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13237 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13255] New: On-site checkout due date wrong if SpecifyDueDate is disabled
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13255 Bug ID: 13255 Summary: On-site checkout due date wrong if SpecifyDueDate is disabled Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com If you have the SpecifyDueDate preference disabled and check something out as an on-site checkout the due date seems to follow the default circulation rule rather than restricted the checkout to that day. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13255] On-site checkout due date wrong if SpecifyDueDate is disabled
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13255 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Depends on||10860 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10860] On-site checkouts (was In-House Use)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Blocks||13255 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13255] On-site checkout due date wrong if SpecifyDueDate is disabled
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13255 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Keywords||rel_3_18_candidate CC||tomasco...@gmail.com Severity|normal |blocker -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13220] Shipment date not saved when creating an invoice which has a duplicated number
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13220 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||tomasco...@gmail.com --- Comment #4 from Tomás Cohen Arazi tomasco...@gmail.com --- Patch pushed to master. Thanks Jacek! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13226] Significant slowdown of checkins with fix for notices ignoring the dateformat preference
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13226 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||tomasco...@gmail.com --- Comment #17 from Tomás Cohen Arazi tomasco...@gmail.com --- Fix pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11401] Add support for Norwegian national library card
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11401 --- Comment #29 from Tomás Cohen Arazi tomasco...@gmail.com --- Created attachment 33570 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33570action=edit Bug 11401: dependency updates Signed-off-by: Tomas Cohen Arazi tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11401] Add support for Norwegian national library card
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11401 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #30 from Tomás Cohen Arazi tomasco...@gmail.com --- Patches pushed to master. Thanks Magnus and everyone involved in testing! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6030] Allow for html in letters in overdue notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6030 Sophie MEYNIEUX sophie.meyni...@biblibre.com changed: What|Removed |Added Assignee|stephane.delaune@biblibre.c |jonathan.dru...@biblibre.co |om |m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13256] New: Typographical error on item search template
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13256 Bug ID: 13256 Summary: Typographical error on item search template Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: hector.hecax...@gmail.com QA Contact: testo...@bugs.koha-community.org CC: bgkrie...@gmail.com, tomasco...@gmail.com Typo error found in the new template itemsearch.tt line 363 _ matches only a single charcter -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13257] New: update_dbix_class_files.pl need a POD
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13257 Bug ID: 13257 Summary: update_dbix_class_files.pl need a POD Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Developer documentation Assignee: gmcha...@gmail.com Reporter: tomasco...@gmail.com QA Contact: testo...@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13255] On-site checkout due date wrong if SpecifyDueDate is disabled
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13255
--- Comment #1 from Owen Leonard oleon...@myacpl.org ---
Tying the on-site checkout due date to the template doesn't look like it can
work if the SpecifyDueDate preference is turned off. circulation.pl won't even
consider the date which gets passed if SpecifyDueDate is off:
circulation.pl line 160:
my $duedatespec_allow = C4::Context-preference('SpecifyDueDate');
if($duedatespec_allow){
if ($duedatespec) {
if ($duedatespec =~ C4::Dates-regexp('syspref')) {
$datedue = dt_from_string($duedatespec);
Because of this it's probably better to calculate the custom due date for
on-site checkouts in circulation.pl based on the onsite_checkout checkbox
value.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13257] update_dbix_class_files.pl need a POD
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13257 --- Comment #1 from Tomás Cohen Arazi tomasco...@gmail.com --- Created attachment 33571 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33571action=edit Bug 13257: update_dbix_class_files.pl need a POD Signed-off-by: Tomas Cohen Arazi tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13257] update_dbix_class_files.pl need a POD
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13257 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13257] update_dbix_class_files.pl need a POD
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13257 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13256] Typographical error on item search template
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13256 --- Comment #1 from Héctor Eduardo Castro Avalos hector.hecax...@gmail.com --- Test plan: 1) Go to url 'intranet-tmpl/prog/en/modules/catalogue/itemsearch.tt' line 363 and check the typo _ matches only a single charcter and change for _ matches only a single character 2) Apply the patch 3) Repeat step 1 and chek if the typo is fixed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13257] update_dbix_class_files.pl need a POD
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13257 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Assignee|gmcha...@gmail.com |tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12970] Refactor VAT and price calculation - basket page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12970 --- Comment #9 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 33572 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33572action=edit Bug 12970: Fix the footer if several tax rate exist If more that 1 tax rate exist, 1 total ligne should be display in the footer. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13257] update_dbix_class_files.pl need a POD
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13257 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13257] update_dbix_class_files.pl need a POD
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13257 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #2 from Tomás Cohen Arazi tomasco...@gmail.com --- Patch pushed to master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13207] Branch: on basket page should read Library:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13207 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||tomasco...@gmail.com --- Comment #5 from Tomás Cohen Arazi tomasco...@gmail.com --- Patch pushed to master. Thanks Katrina! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10136] misc/translator/translator_doc.html outdated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10136 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||tomasco...@gmail.com --- Comment #7 from Tomás Cohen Arazi tomasco...@gmail.com --- Patch pushed to master. Thanks Katrina! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7988] warning on authorized values confusing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7988 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||tomasco...@gmail.com --- Comment #6 from Tomás Cohen Arazi tomasco...@gmail.com --- Patch pushed to master. Thanks Katrina! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13082] tools/export.pl fix to forbid adding of all invalid records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13082 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||tomasco...@gmail.com --- Comment #5 from Tomás Cohen Arazi tomasco...@gmail.com --- Patch pushed to master. Thanks Stéphane! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12976] Refactor VAT and price calculation - invoice page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12976 --- Comment #7 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 33573 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33573action=edit Bug 12976: Fix the footer if several tax rate exist If more that 1 tax rate exist, 1 total ligne should be display in the footer. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13256] Typographical error on item search template
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13256 --- Comment #2 from Héctor Eduardo Castro Avalos hector.hecax...@gmail.com --- Created attachment 33574 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33574action=edit Proposed fix -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13215] letter.code is considered as a primary key
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13215 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Severity|major |critical -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11169] OPAC: Display acquisition details
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11169 --- Comment #50 from Paola Rossi paola.ro...@cineca.it --- I've created the case of comment 49 against master 3.17.00.054. I hope the following steps be the right ones, and all needed. 1 - I set the syspref OPACAcquisitionDetails to Display 2 - I set the syspref AcqCreateItem to cataloguing the record as required 3 - I created a new vendor, with a basket. 4 - I ordered a book from an external source, setting the quantity to X 5 - I closed the basket [either with or without closing also the basketgroup] 6 - [I reindexed zebra to find the book on OPAC] On OPAC I saw X items are on order. below the Holdings ( 0 ) tag of the book. Then I also repeated 1,2,3,5 changing the 4-th step with this one: 4B - I catalogued another book without items, [I reindexed zebra], and I ordered this book From an existing record, setting the quantity to Y. Again, on OPAC I saw Y items are on order. below the Holdings ( 0 ) tag of the second book. NB. if I reopened the basket, or if I didn't close it, on OPAC I saw No physical items for this record. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10480] Cataloging plugins without redefining
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10480 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=12176 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12176] Remove HTML from additem.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12176 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=10480 --- Comment #11 from M. de Rooy m.de.r...@rijksmuseum.nl --- Adding a see also on this one to bug 10480 (work in progress). It will touch this part of code too in particular to item plugins. Not a hard rebase on either side.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
