[Koha-bugs] [Bug 13019] Add base classes on which to build Koha objects
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13019
David Cook changed:
What|Removed |Added
CC||dc...@prosentient.com.au
--- Comment #48 from David Cook ---
Looking over this again... I don't know if we're implementing Koha::Objects in
the best way possible.
After all, every Koha::Objects subclass is basically just going to consist of
the following:
44sub type {
45return 'Borrower';
46}
47
48sub object_class {
49return 'Koha::Borrower';
50}
That seems like unnecessary duplication in my mind. Why not follow the DBIC
model, and go with something like the following?
my $Borrowers= Koha::Objects->new('Borrower');
my @objects = $Borrowers->search({surname => 'Jones'});
I suppose the limitation of that is that you can't have custom methods for the
group of objects, but would you need them? I imagine all the custom methods are
going to be at the individual object level.
--
I must admit, after looking through DBIC more and more, I'm less sure of the
encapsulation method.
I wonder how much functionality we'll use by encapsulating the DBIC objects in
Koha objects.
Yet, DBIC objects on their own don't have enough functionality to be all we
need.
Or do they?
Maybe we should keep DBIC objects as data objects, and then have other
modules/objects for applying business logic to those objects.
In terms of CRUD, DBIC is fine the way it is.
But let's think about a Koha::Biblio object... it could have methods for
importing, exporting, filtering, extracting data from a Koha::Schema::Biblio
object or a Koha::Schema::Deletedbiblio object.
Koha::Biblio::new($biblionumber);
or maybe
Koha::Biblio::new($dbic_object); #not dissimilar to using inheritance, except
that you can use Biblio or Deletedbiblio in this case
my $output = Koha::Biblio::format("opac","marcxml"); #detail view
my $output = Koha::Biblio::format("opac","isomarc"); #exporting as isomarc
my $output = Koha::Biblio::format("intranet","marcxml"); #detail view
my $output = Koha::Biblio::format("intranet","dc"); #detail view as dublin core
--
In my latest OAI stuff, I have DBIC objects for OAI records and OAI
repositories. I then have a Harvester.pm (which has methods for getting active
repositories, querying the repositories, queueing the records, etc.) and an
Importer.pm (gets the queued records, analyzes them, transforms metadata, calls
the internal C4::Biblio API for adding records to the database).
Biblio is actually pretty interesting... because you can get biblios in all
sorts of ways. From Zebra, from MySQL, from Z39.50, from OAI, from importing
through other tools. You should be able to feed ISOMARC or MARCXML into
Koha::Biblio and have that take care of everything thereafter.
Actually, Koha::Biblio might not even be the most appropriate name in that
case. Maybe it should be Koha::Record, and that becomes the one and only access
point for that record.
I suppose though... if you were doing a DBIC search, you'd have to feed your
result into Koha::Record before you could work on it... and you might be
tempted to avoid Koha::Record. Whereas if you're using Koha::Records or
Koha::Biblios and that returns the DBIC object wrapped in a Koha object... then
you're forced to use that (unless you bypass Koha::Biblios and just use DBIC on
its own).
But what is a "biblio"... when do we use it...
1) We add biblios to the catalogue.
We might do this by hand, by Z39.50, from OAI, or some other means. But
basically, we have a metadata record in MARC format.
2) We search for biblios in the catalogue
We query Zebra and it returns biblio records. We see a list of search results.
3) We examine individual records
We click on the results and look at the records
4) We edit the metadata records
We load the MARCXML into a form that can be edited by humans, and then save it
again into the relational database (where it gets stored in
biblioitems.marcxml, and processed into the biblio and biblioitems tables)
5) We export records (to Zebra, to browsers for download, via OAI, via Z39.50,
etc)
We output the MARCXML to other sources
--
I'm sure there are other use cases of biblios, but the thing I continually
notice is that most of these probably wouldn't need the DBIC object. Adding and
editing would, as the MARCXML would need to be stored in biblioitems.marcxml,
and the MARCXML would need to be parsed into the other database fields.
Most of the `biblio` and `biblioitems` fields are calculated fields rather than
data in their own right.
--
That all being said... I like the idea of the code being more DRY.
So maybe it does make sense to have a Koha::Object base class that defines
methods for adding, modifying, and deleting database data.
Hmm... but I'm not sure that can work either.
Thinking about "Biblio" or "Borrower", when you delete one of these,
[Koha-bugs] [Bug 13019] Add base classes on which to build Koha objects
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13019
--- Comment #47 from David Cook ---
Comment on attachment 33846
--> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33846
Bug 13019 - Add base classes on which to build Koha objects
Review of attachment 33846:
-->
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=13019&attachment=33846)
-
::: Koha/Object.pm
@@ +136,5 @@
> +=head3 $object->delete();
> +
> +Removes the object from storage.
> +
> +Returns:
I can see returning true on success, but shouldn't we throw an exception if the
deletion fails or if the object was never in storage?
I would think it would make more sense to try a proper exception using die(),
and then catch that when deleting an object using eval() or Try::Tiny (which I
think is a prereq of DBIC anyway).
Mind you, off the top of my head, I'm not sure what exceptions DBIC throws if a
delete fails or if the object was never there to begin with...
::: Koha/Objects.pm
@@ +187,5 @@
> +
> +sub _wrap {
> +my ( $self, @dbic_rows ) = @_;
> +
> +my @objects = map { $self->object_class()->new_from_dbic( $_ ) }
> @dbic_rows;
Mmm, I see... so you use Koha::Objects for fetching objects from the
database... and it wraps the resultset with the applicable object based on
Koha::Object...
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10363] There is no package for authorised values.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #57 from David Cook --- Ahh, I see now that type() is used in the Koha::Object constructor... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10363] There is no package for authorised values.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 --- Comment #56 from David Cook --- Comment on attachment 33860 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33860 [SIGNED-OFF] Bug 10363 - There is no package for authorised values. Review of attachment 33860: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=10363&attachment=33860) - ::: Koha/AuthorisedValue.pm @@ +144,5 @@ > + > +return $self->lib_opac() || $self->lib(); > +} > + > +=head3 Koha::Objects->_resultset Copy/paste error? ::: Koha/AuthorisedValues.pm @@ +22,5 @@ > +use Carp; > + > +use Koha::Database; > + > +use Koha::Borrower; Copy/paste error? @@ +28,5 @@ > +use base qw(Koha::Objects); > + > +=head1 NAME > + > +Koha::Borrower - Koha Borrower Object class Copy/paste error? @@ +68,5 @@ > +} > + > +=head3 type > + > +=cut Why do we need type() and object_class() methods? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13331] Subfield does not show in cataloging editor - if subfield is disabled in OPAC/enabled in Staff, via frameworks
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13331 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #1 from David Cook --- (In reply to Mason James from comment #0) > Subfield does not show in cataloging editor - if subfield is disabled in > OPAC/enabled in Staff, via frameworks Do you have a specific example that can be tested? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13329] Can't make new suggestion with AllowPurchaseSuggestionBranchChoice turned on
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13329 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #4 from David Cook --- Yay team! That was lightning fast! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 Liz Rea changed: What|Removed |Added Attachment #33885|0 |1 is obsolete|| --- Comment #9 from Liz Rea --- Created attachment 33888 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33888&action=edit Bug 12123 - [Alternative patch] HTML notices can break the notice viewer Depending on the content of an html notice, it can cause the notice to either not be collapsible, be uncollapsible, or to be permanently collapsed. Test Plan: 1) Set your CHECKOUT notice to the following ( with HTML Message checked ) : The following items have been checked out: <> Thank you for visiting the <> of HMCPL. 2) Check out some items to a patron 3) View the patrn's notices 4) Note the notice viewer is broken ( message is not collapsed, and con't be collapsed ). 5) Apply this patch 6) Reload the page 7) Note the notice viewer is no longer broken -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 David Cook changed: What|Removed |Added Attachment #33885|1 |0 is obsolete|| --- Comment #10 from David Cook --- Comment on attachment 33885 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33885 Bug 12123 - [Alternative patch] HTML notices can break the notice viewer Review of attachment 33885: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=12123&attachment=33885) - I definitely prefer Liz's patch over Kyle's. I don't think iframes are needed at all. It looks like the problem is that we were trying to stuff HTML into a "p" element which couldn't take them as children. The only thing stopping my sign off would be the inline CSS. I find the CSS isn't necessary when I test it, and I suppose if it is necessary for other browsers, I would just prefer it to be in a stylesheet somewhere else so we can control our styles better. ::: koha-tmpl/intranet-tmpl/prog/en/modules/members/notices.tt @@ +41,4 @@ > Sent notices for [% INCLUDE 'patron-title.inc' %] > > [% IF ( QUEUED_MESSAGES ) %] > + Using Chrome on Windows, I don't find this CSS does anything. If anything, it makes the presentation slightly worse. However, if we do include it, my only request would be to not use inline CSS and to put this in a separate stylesheet somewhere like staff-global.css or something like that. @@ +55,4 @@ > > > [% QUEUED_MESSAGE.subject %] > + Switching to a div fixes this problem nicely. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13314] Fixes to .mailmap for the 3.18 release
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13314 --- Comment #20 from Tomás Cohen Arazi --- Created attachment 33887 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33887&action=edit Bug 13314: (QA followup) fix for Charles Farmer Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13314] Fixes to .mailmap for the 3.18 release
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13314 --- Comment #19 from Tomás Cohen Arazi --- Created attachment 33886 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33886&action=edit Bug 13314: (QA followup) fix for Maxime Beaulieu Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13262] Add parameters to XSLT Handler transform method
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13262 --- Comment #6 from David Cook --- (In reply to M. de Rooy from comment #5) > Maybe we should just be pragmatic here and replace the lines: > > require XML::LibXML; > my $dom = XML::LibXML->load_xml(string => $output); > my $result = $dom->find( '/just_a_tagname' ); > > by a simple test like index($output,'this is a test')>0 > > LibXML uses overloading in XML::LibXML::Literal (and others) called from > XML::LibXML::Node. Debugging this stuff seems much harder than just > simplifying the test.. Maybe. Using index(), while not as exact, might be "good enough". However, I'm rather intrigued that Kyle is getting errors while you (Marcel) and I are not. I have no idea why it warned "left argument in overloaded package XML::LibXML::NodeList" when it should've been a XML::LibXML::Literal which would've magically stringified. Maybe rather than using index(), we should look into why Kyle is getting that problem though. The answer will determine the solution. If it's an issue of the overloading not working as expected, it would probably be an idea to go with: ok($result->value() eq 'this is a test', 'test name'); However, that still won't work if Kyle really is getting a NodeList back instead of a Literal. Kyle: Could you do a Data::Dumper($result) and tell us what you get? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 Liz Rea changed: What|Removed |Added Attachment #33876|0 |1 is obsolete|| --- Comment #8 from Liz Rea --- Created attachment 33885 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33885&action=edit Bug 12123 - [Alternative patch] HTML notices can break the notice viewer Depending on the content of an html notice, it can cause the notice to either not be collapsible, be uncollapsible, or to be permanently collapsed. Also changes the layout of the table a bit to be a little more user friendly. Test Plan: 1) Set your CHECKOUT notice to the following ( with HTML Message checked ) : The following items have been checked out: <> Thank you for visiting the <> of HMCPL. 2) Check out some items to a patron 3) View the patrn's notices 4) Note the notice viewer is broken ( message is not collapsed, and con't be collapsed ). 5) Apply this patch 6) Reload the page 7) Note the notice viewer is no longer broken -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 Liz Rea changed: What|Removed |Added Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13068] New feature for DB update and sandbox
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 --- Comment #49 from David Cook --- Thanks for the explanations and further work, Marcel :). My plate is pretty full today, but I'm definitely interested in testing this. Will take a look as soon as I can :). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9165] Allow preventing passwords from being stored locally when using LDAP
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9165 Robin Sheat changed: What|Removed |Added Attachment #33873|0 |1 is obsolete|| --- Comment #13 from Robin Sheat --- Created attachment 33884 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33884&action=edit Bug 12831 [Followup]: Clear existing sync A small enhancement to clear existing synced passowrd should this config option be enbled. This followup is related to bug 12831 http://bugs.koha-community.org/show_bug.cgi?id=9165 Signed-off-by: Robin Sheat (signed off as part of Bug 9165) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9165] Allow preventing passwords from being stored locally when using LDAP
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9165 Robin Sheat changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12505] Make variable aqorders.listprice in acq claim notice work and improve error handling
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12505 --- Comment #26 from Katrin Fischer --- <> <> <> Ordernumber <> (<>) (<> ordered) ($<> each) has not been received. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12505] Make variable aqorders.listprice in acq claim notice work and improve error handling
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12505 --- Comment #25 from Katrin Fischer --- I tested again and have definitely fields from aqbooksellers showing up in my notice. I tested with postal address and phone. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13330] All overdue items with fines returned via checkouts table will have fines forgiven!
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13330 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13330] All overdue items with fines returned via checkouts table will have fines forgiven!
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13330 Katrin Fischer changed: What|Removed |Added Attachment #33881|0 |1 is obsolete|| --- Comment #4 from Katrin Fischer --- Created attachment 33883 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33883&action=edit [PASSED QA] Bug 13330 - All overdue items with fines returned via checkouts table will have fines forgiven! Due to a disconnect between how booleans are handled in Perl vs JSON, all checkins done from the checkouts table will have fines forgiven! This is because the parameters sent to svc/checkin are coded in JSON and the JSON false is treated in Perl as the string 'false' which evaluates to true! Test Plan: 1) Find a patron with an overdue item that has a fine 2) Return the item via the checkouts table on circulation.pl or moremember.pl 3) Note the fine is forgiven 4) Apply this patch 5) Repeat steps 1-2 6) Note the fine is no longer forgiven Signed-off-by: Liz Rea Verified bug, fix corrects the problem. Signed-off-by: Katrin Fischer Also tested waiving fines form the check-in page still works. Passes tests and QA script. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12831] local only logins should still work when ldap authentication is enabled
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12831 --- Comment #19 from Katrin Fischer --- Please, we need testing on this ASAP. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13332] Items disappear from staff detail page when there is an on-site checkout
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13332 Katrin Fischer changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=5304 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13332] New: Items disappear from staff detail page when there is an on-site checkout
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13332 Bug ID: 13332 Summary: Items disappear from staff detail page when there is an on-site checkout Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: blocker Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com To test: - Turn on OnSiteCheckouts - Check out any item using on-site checkout mode - Go to the detail page of the record, verify, that all items have disappeared - Check the item back in - Go to the detail page again - the items are back This seems to be a side effect of bug 5304, when I revert it, the display is ok: http://git.koha-community.org/gitweb/?p=koha.git;a=commit;h=421761e2743ab260092a5234b7b8b1c33c64107f The logs show some errors: [Mon Nov 24 22:25:48.527426 2014] [cgi:error] [pid 24936] [client 127.0.0.1:41712] AH01215: [Mon Nov 24 22:25:48 2014] detail.pl: DBD::mysql::st execute failed: Not unique table/alias: 'issues' at /home/katrin/kohaclone/C4/Items.pm line 1332., referer: http://localhost:8080/cgi-bin/koha/circ/circulation.pl [Mon Nov 24 22:25:48.527536 2014] [cgi:error] [pid 24936] [client 127.0.0.1:41712] AH01215: [Mon Nov 24 22:25:48 2014] detail.pl: DBD::mysql::st fetchrow_hashref failed: fetch() without execute() at /home/katrin/kohaclone/C4/Items.pm line 1339., referer: http://localhost:8080/cgi-bin/koha/circ/circulation.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5304] Too many post find queries for items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5304 Katrin Fischer changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=13332 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13312] Fines forgiven automatically: accountlines.accounttype FFOR is set without user input.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13312 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #2 from Katrin Fischer --- Is this a duplicate to bug 13330? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #7 from Katrin Fischer --- Created attachment 33882 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33882&action=edit Screenshot I am not sure about this - it seems to work, but should it look like on the screenshot? Do we really need an iframe here? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13330] All overdue items with fines returned via checkouts table will have fines forgiven!
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13330 Liz Rea changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13330] All overdue items with fines returned via checkouts table will have fines forgiven!
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13330 Liz Rea changed: What|Removed |Added Attachment #33875|0 |1 is obsolete|| --- Comment #3 from Liz Rea --- Created attachment 33881 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33881&action=edit Bug 13330 - All overdue items with fines returned via checkouts table will have fines forgiven! Due to a disconnect between how booleans are handled in Perl vs JSON, all checkins done from the checkouts table will have fines forgiven! This is because the parameters sent to svc/checkin are coded in JSON and the JSON false is treated in Perl as the string 'false' which evaluates to true! Test Plan: 1) Find a patron with an overdue item that has a fine 2) Return the item via the checkouts table on circulation.pl or moremember.pl 3) Note the fine is forgiven 4) Apply this patch 5) Repeat steps 1-2 6) Note the fine is no longer forgiven Signed-off-by: Liz Rea Verified bug, fix corrects the problem. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13314] Fixes to .mailmap for the 3.18 release
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13314 Katrin Fischer changed: What|Removed |Added Attachment #33858|0 |1 is obsolete|| --- Comment #18 from Katrin Fischer --- Created attachment 33880 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33880&action=edit [PASSED QA] Bug 13314: attribute Oslo Public Library Signed-off-by: Tomas Cohen Arazi Signed-off-by: Magnus Enger Fixes names and mappings for contributors from Oslo Public Library. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13314] Fixes to .mailmap for the 3.18 release
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13314 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13157] Fix holdingbranch facet for UNIMARC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13157 --- Comment #11 from Katrin Fischer --- Created attachment 33879 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33879&action=edit [PASSED QA] Bug 13157: (QA followup) homebranch is 995$b on UNIMARC frameworks Signed-off-by: Tomas Cohen Arazi Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13157] Fix holdingbranch facet for UNIMARC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13157 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13157] Fix holdingbranch facet for UNIMARC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13157 Katrin Fischer changed: What|Removed |Added Attachment #33825|0 |1 is obsolete|| Attachment #33826|0 |1 is obsolete|| --- Comment #10 from Katrin Fischer --- Created attachment 33878 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33878&action=edit [PASSED QA] Bug 13157: UNIMARC holdingbranch facet is 995$c not 995$b Fix a typo. Not test plan required, just a look at default UNIMARC framework. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13329] Can't make new suggestion with AllowPurchaseSuggestionBranchChoice turned on
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13329 Katrin Fischer changed: What|Removed |Added Attachment #33854|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13329] Can't make new suggestion with AllowPurchaseSuggestionBranchChoice turned on
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13329 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA CC||katrin.fisc...@bsz-bw.de Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13329] Can't make new suggestion with AllowPurchaseSuggestionBranchChoice turned on
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13329 --- Comment #3 from Katrin Fischer --- Created attachment 33877 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33877&action=edit [PASSED QA] Bug 13329: Fix create a suggestion at the OPAC The suggestion table does not contain a 'branch' column name. The script should pass 'branchcode' to C4::Suggestion::NewSuggestion. Test plan: 0/ Enable the AllowPurchaseSuggestionBranchChoice pref 1/ Create a suggestion at the OPAC should not raise a DBIx::Class error. I could reproduce the bug. With patch bug is gone. Signed-off-by: Marc Véron Signed-off-by: Katrin Fischer Works as described, thx for the quick fix. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11354] NewItemsDefaultLocation Override in Cataloging
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11354
--- Comment #3 from Owen Leonard ---
It sounds to me like you don't want to have anything set in the
NewItemsDefaultLocation preference, because the shelving location you set there
isn't intended to be permanent. It's intended to be temporary ("When items are
created, give them the *temporary* location of...").
You should only use NewItemsDefaultLocation if you want to set a temporary
shelving location which indicates a central processing location or something
like that. The intention of the preference is that whatever shelving location
you specify is replaced with the permanent shelving location upon check-in.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13330] All overdue items with fines returned via checkouts table will have fines forgiven!
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13330 Kyle M Hall changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13068] New feature for DB update and sandbox
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 M. de Rooy changed: What|Removed |Added Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 Owen Leonard changed: What|Removed |Added Attachment #33863|0 |1 is obsolete|| --- Comment #6 from Owen Leonard --- Created attachment 33876 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33876&action=edit [SIGNED-OFF] Bug 12123 - HTML notices can break the notice viewer Depending on the content of an html notice, it can cause the notice to either not be collapsible, be uncollapsible, or to be permanently collapsed. Test Plan: 1) Set your CHECKOUT notice to the following ( with HTML Message checked ) : The following items have been checked out: <> Thank you for visiting the <> of HMCPL. 2) Check out some items to a patron 3) View the patrn's notices 4) Note the notice viewer is broken ( message is not collapsed, and con't be collapsed ). 5) Apply this patch 6) Reload the page 7) Note the notice viewer is no longer broken Signed-off-by: Owen Leonard I followed the test plan successfully. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13309] opac-search.pl Holds count incorrect
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13309 --- Comment #2 from Christopher Brannon --- (In reply to Katrin Fischer from comment #1) > Could the difference be that the result list show the number of items > 'waiting' - while the opac detail shows the number of holds? It does, indeed, appear to be the case. :/ This is extremely confusing. If I am getting confused, I can't imagine patrons are doing any better with this. I'm not sure how much of the information on that line in the results is helpful to patrons. At least for US public library patrons, patrons would want to know how many copies there are, how many are available (and MAYBE where), and how many holds are on the item. I doubt they care about how many items are in transit, or how many are waiting for people. Frankly, I would ditch the transit info and change the holds to total holds. Christopher -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13331] New: Subfield does not show in cataloging editor - if subfield is disabled in OPAC/enabled in Staff, via frameworks
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13331 Bug ID: 13331 Summary: Subfield does not show in cataloging editor - if subfield is disabled in OPAC/enabled in Staff, via frameworks Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: gmcha...@gmail.com Reporter: m...@kohaaloha.com QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl Subfield does not show in cataloging editor - if subfield is disabled in OPAC/enabled in Staff, via frameworks -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13330] All overdue items with fines returned via checkouts table will have fines forgiven!
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13330 Kyle M Hall changed: What|Removed |Added Attachment #33874|0 |1 is obsolete|| --- Comment #2 from Kyle M Hall --- Created attachment 33875 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33875&action=edit Bug 13330 - All overdue items with fines returned via checkouts table will have fines forgiven! Due to a disconnect between how booleans are handled in Perl vs JSON, all checkins done from the checkouts table will have fines forgiven! This is because the parameters sent to svc/checkin are coded in JSON and the JSON false is treated in Perl as the string 'false' which evaluates to true! Test Plan: 1) Find a patron with an overdue item that has a fine 2) Return the item via the checkouts table on circulation.pl or moremember.pl 3) Note the fine is forgiven 4) Apply this patch 5) Repeat steps 1-2 6) Note the fine is no longer forgiven -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13330] All overdue items with fines returned via checkouts table will have fines forgiven!
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13330 Kyle M Hall changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13330] All overdue items with fines returned via checkouts table will have fines forgiven!
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13330 --- Comment #1 from Kyle M Hall --- Created attachment 33874 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33874&action=edit Bug 13330 - All overdue items with fines returned via checkouts table will have fines forgiven! Due to a disconnect between how booleans are handled in Perl vs JSON, all checkins done from the checkouts table will have fines forgiven! This is because the parameters sent to svc/checkin are coded in JSON and the JSON false is treated in Perl as the string 'false' which evaluates to true! Test Plan: 1) Find a patron with an overdue item that has a fine 2) Return the item via the checkouts table on circulation.pl or moremember.pl 3) Note the fine is forgiven 4) Apply this patch 5) Repeat steps 1-2 6) Note the fine is no longer forgiven -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12831] local only logins should still work when ldap authentication is enabled
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12831 Martin Renvoize changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=9165 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9165] Allow preventing passwords from being stored locally when using LDAP
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9165 Martin Renvoize changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=12831 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9165] Allow preventing passwords from being stored locally when using LDAP
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9165 Martin Renvoize changed: What|Removed |Added Attachment #27380|0 |1 is obsolete|| CC||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13330] New: All overdue items with fines returned via checkouts table will have fines forgiven!
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13330 Bug ID: 13330 Summary: All overdue items with fines returned via checkouts table will have fines forgiven! Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: blocker Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: k...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Due to a disconnect between how booleans are handled in Perl vs JSON, all checkins done from the checkouts table will have fines forgiven! This is because the parameters sent to svc/checkin are coded in JSON and the JSON false is treated in Perl as the string 'false' which evaluates to true! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9165] Allow preventing passwords from being stored locally when using LDAP
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9165 --- Comment #12 from Martin Renvoize --- Created attachment 33873 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33873&action=edit Bug 12831 [Followup]: Clear existing sync A small enhancement to clear existing synced passowrd should this config option be enbled. This followup is related to bug 12831 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9165] Allow preventing passwords from being stored locally when using LDAP
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9165 --- Comment #11 from Martin Renvoize --- Created attachment 33872 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33872&action=edit [Signed Off] Bug 9165 - Prevent LDAP passwords being stored locally This adds a configuration option to LDAP that prevents it from storing user's passwords in the local database. This is useful when users of hosted Koha wish to prevent any form of offsite password storage for security reasons. Notes: * if the option is not included in the koha-conf.xml file, then the current default behaviour of saving the password locally is retained. * this has no impact on passwords that are already in the database. They will not be erased. To use: * edit the koha-conf.xml for a system that uses LDAP for authentication. * in the configuration, add: 0 * feel a greater sense of security. To test: 1) have a Koha system that authenticates using LDAP. 2) note that when a user logs in, their password is saved (hashed) in the database. 2.5) it is important to note that, for whatever reason, a user's password is not stored on a login where their account is created, only when they log in after being created. Thus perhaps log in and log out a couple of times to be sure. 3) add the 0 option to the section of koha-conf.xml. 4) login with a new user (or erase the password from the database for an existing user) and note that the password field is not populated. 5) log out and log back in just to be sure, check the password field again. Sponsored-By: National Institute of Water and Atmospheric Research (NIWA) Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11814] Serial statuses should be stored in constants
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11814 Paola Rossi changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #13 from Paola Rossi --- Thanks, Jonathan. Today I've applied the patches against master 3.17.00.058 head 13297. I think that the status codes in claims.pl had to be still patched. On koha/serials/claims.pl: Home › Serials › Claims I've tried to claim 2 issues which were in late for a certain subscription. The mail was received correctly, but: a) the "Claims counts" remained 0 for one of the issues (whose serial.serialid was X): ERROR b) the Claim date was not set for the same issue (whose serial.serialid was X): ERROR c) the status of the other issue, whose Claim count and Claim date were set rightly, didn't become "Claimed" 7 (ERROR) [but X, I think]. So I pass the patch to "Failed QA" status. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13323] Change the tax rate on receiving
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13323 --- Comment #2 from Jonathan Druart --- Created attachment 33870 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33870&action=edit Bug 13323: Tax rate can change on receiving This commit permits to update the tax rate on receiving. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13323] Change the tax rate on receiving
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13323 --- Comment #1 from Jonathan Druart --- Created attachment 33869 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33869&action=edit Bug 13323: Tax rate can change on receiving - DB changes This patch adds 4 new DB fields to the aqorders table: * tax_rate_on_ordering * tax_rate_on_receiving * tax_value_on_ordering * tax_value_on_receiving -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13323] Change the tax rate on receiving
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13323 --- Comment #3 from Jonathan Druart --- Created attachment 33871 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33871&action=edit Bug 13323: [DO NOT PUSH] Tax rate can change on receiving - DBIC changes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12831] local only logins should still work when ldap authentication is enabled
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12831 --- Comment #18 from Martin Renvoize --- My attached patch 'should' fix this for the case where a library is using auth_by_bind and not anonymous_bind. Reading the code, I believe this was the only case that needed fixing in this way. To re-introduce the functionality of bug 8148 fully however, we should also take a careful look at bug 9165 as suggested by cait, as with some minor adjustments with would allow for the functionality we're looking for for all three major LDAP configurations. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12831] local only logins should still work when ldap authentication is enabled
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12831 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12831] local only logins should still work when ldap authentication is enabled
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12831 --- Comment #17 from Martin Renvoize --- Created attachment 33868 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33868&action=edit BUG 12831: Local Only logins with LDAP Local only logins should continue to function when LDAP is enabled. This was not the case after bug 8148 [LDAP Auth should FAIL when ldap contains a NEW password]. For this case, we need to diferentiate between local accounts and ldap accounts. This is somewhat challenging and thus this patch is only part of the story. The other half can be achieved with bug 9165 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12831] local only logins should still work when ldap authentication is enabled
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12831 Martin Renvoize changed: What|Removed |Added Status|In Discussion |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12718] Show extended patron attributes in the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12718 --- Comment #7 from Nicole C. Engard --- Will this be backported to 3.16.x ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7882] Add ability to move and reorder fields in MARC editor
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 Marjorie Barry-Vila changed: What|Removed |Added CC||marjorie.barry-v...@ccsr.qc ||.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13323] Change the tax rate on receiving
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13323 Jonathan Druart changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|koha-b...@lists.koha-commun |jonathan.dru...@biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11858] RFID for circulation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11858 Indranil Das Gupta changed: What|Removed |Added CC||indr...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13157] Fix holdingbranch facet for UNIMARC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13157 --- Comment #9 from Frédéric Demians --- (In reply to Tomás Cohen Arazi from comment #8) > Please feel free to obsolete my followup if you think it is wrong. But in > that case please check > > installer/data/mysql/fr-FR/marcflavour/unimarc_complet/Obligatoire/ > framework_DEFAULT.sql > > and fill a new bug for it. No, your followup is correct! and required. Mine was incomplete. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12802] Sent notices using several email addresses
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Jonathan Druart changed: What|Removed |Added Attachment #31382|0 |1 is obsolete|| Attachment #31383|0 |1 is obsolete|| Attachment #31384|0 |1 is obsolete|| Attachment #31833|0 |1 is obsolete|| --- Comment #12 from Jonathan Druart --- Created attachment 33864 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33864&action=edit Bug 12802: DB changes - Set type multiple for AutoEmailPrimaryAddress -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12802] Sent notices using several email addresses
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 --- Comment #16 from Jonathan Druart --- Last patch set fixes conflicts with bug 9530. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12802] Sent notices using several email addresses
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 --- Comment #13 from Jonathan Druart --- Created attachment 33865 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33865&action=edit Bug 12802: Sent notices using several email addresses Currently it is not possible to select several email addresses to notify a patron. The only place where the mechanism exists is in the overdue_notices.pl script. This patch reuses the AutoEmailPrimaryAddress syspref and changes its type to "multiple". Like that it is now possible to select several email addresses. Note that there is no sense to select OFF and another value for this pref. So if the 'OFF' (first valid) value exist, it takes the priority. It will add the ability to choose the email addresses to use to notify patrons. The option is "email", "emailpro" and "B_email". If "OFF" is selected, the first valid address will be returned (same behavior as before this patch). This patch also adds a new routine C4::Branch::GetBranchEmailFromBorrowernumber (UT provided). Note for the QA step: I found a possible regression, but IMO it's not a big deal: Before this patch if a letter did not contain a "to_address", the C4::Letters::_send_message_by_email subroutine retrieve the email from the given borrowernumber. This is now done in the EnqueueMessage subroutine. What it means: If a borrower didn't have an email address when the notice was sent to the queue, the email address won't be check again when the notice will really sent to the patron. This change permits to sent a letter to the queue (EnqueueLetter) without any information (from_address, to_address), only the borrowernumber is mandatory to retrieve them. The _send_message_by_email subroutine should not contain any useful code, only sent the letter we ask it to sent. The _update_message_to_address becomes useless since the to_address is retrieved previously. What this patch does: The GetNoticeEmailAddress subroutine has been renamed to GetNoticeEmailAddresses (reflect the plural). It only gets the patron' emails defined in the AutoEmailPrimaryAddress pref. If no 'to_address' parameter is given to EnqueueMessage, the emails will be retrieved at this moment. In C4::Message: An old form was found. The AutoEmailPrimaryAddress was not check. The smsalertnumber was sent for the to_address param, which is wrong. C4::Reserves: AddReserve and _koha_notify_reserve: The from address is built in the QueueLetter. It is useless to do it here. overdue_notices.pl: The script could be cleaned a little bit if we remove the --email parameter. Indeed it is redundant with this new enhancement. I can propose another patch with a die statement and a message: "you should use the pref AutoEmailPrimaryAddress" if the --email is provided. opac/opac-shareshelf.pl and opac/opac-memberentry.pl: just remove the from and to address. They will be filled on sending to the queue (because of the borrowernumber). Test plan: 1/ Apply this patch without updating the pref AutoEmailPrimaryAddress (or fill it with a single value if it is not done yet). 2/ Try the different way to sent notices to a patron (check the following letter code: HOLD, CHECKIN, CHECKOUT, PREDUE, RENEW, DUE). 3/ Verify the email is correctly sent to the message_queue. 4/ Fill the pref with email and emailpro (for instance) 5/ Verify that 2 notices are sent to the message_queue: 1 with the email and 1 with the emailpro. 6/ You can also verify that only 1 notice is generated if the emailpro is empty. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12802] Sent notices using several email addresses
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 --- Comment #14 from Jonathan Druart --- Created attachment 33866 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33866&action=edit Bug 12802: FIX use the first valid email address if noemail is needed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12802] Sent notices using several email addresses
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 --- Comment #15 from Jonathan Druart --- Created attachment 33867 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33867&action=edit Bug 12802: Fix if AutoEmailOpacUser is enabled Test plan: Verify that the behavior of AutoEmailOpacUser still works as before. Note that now the email can receive several emails if AutoEmailPrimaryAddress has several values. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12802] Sent notices using several email addresses
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 Kyle M Hall changed: What|Removed |Added Attachment #27403|0 |1 is obsolete|| --- Comment #5 from Kyle M Hall --- Created attachment 33863 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33863&action=edit Bug 12123 - HTML notices can break the notice viewer Depending on the content of an html notice, it can cause the notice to either not be collapsible, be uncollapsible, or to be permanently collapsed. Test Plan: 1) Set your CHECKOUT notice to the following ( with HTML Message checked ) : The following items have been checked out: <> Thank you for visiting the <> of HMCPL. 2) Check out some items to a patron 3) View the patrn's notices 4) Note the notice viewer is broken ( message is not collapsed, and con't be collapsed ). 5) Apply this patch 6) Reload the page 7) Note the notice viewer is no longer broken -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 Kyle M Hall changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10363] There is no package for authorised values.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363
--- Comment #55 from Jonathan Druart ---
Comment on attachment 33862
--> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33862
Bug 10363 [QA Followup]
Review of attachment 33862:
-->
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=10363&attachment=33862)
-
Hi Kyle,
Thanks for the followup!
::: admin/authorised_values.pl
@@ +113,4 @@
> $av->imageurl( $imageurl );
> eval{
> $av->store;
> +$av->replace_branch_limitations( \@branches );
Could you explain what was wrong here?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10363] There is no package for authorised values.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 --- Comment #53 from Kyle M Hall --- Created attachment 33861 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33861&action=edit [SIGNED-OFF] Bug 10363: Use Koha::AuthorisedValue[s] in the admin page Now we have packages, we need use them in the pl script. Test plan: Verify there are no regression on addind/editing/deleting authorised values. Done forget to test the branch limitation. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10363] There is no package for authorised values.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 --- Comment #54 from Kyle M Hall --- Created attachment 33862 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33862&action=edit Bug 10363 [QA Followup] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10363] There is no package for authorised values.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 Kyle M Hall changed: What|Removed |Added Attachment #33422|0 |1 is obsolete|| Attachment #33423|0 |1 is obsolete|| --- Comment #52 from Kyle M Hall --- Created attachment 33860 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33860&action=edit [SIGNED-OFF] Bug 10363 - There is no package for authorised values. Test Plan: 1) Apply this patch 2) run updatedatabase.pl 3) prove t/db_dependent/AuthorisedValues.t Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10363] There is no package for authorised values.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363 Kyle M Hall changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11211] Move calculation code out of C4::Calendar
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11211 Magnus Enger changed: What|Removed |Added Status|Signed Off |Patch doesn't apply --- Comment #31 from Magnus Enger --- I get conflicts now: $ git bz apply 11211 Bug 11211 - Move calculation code out of C4::Calendar 32978 - Bug 11211 - Move calculation code out of C4::Calendar 32992 - Bug 11211 [QA Followup] - Remove use of dt_add_type_uk_date Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 11211 - Move calculation code out of C4::Calendar Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Removing tools/newHolidays.pl Removing tools/holidays.pl Removing tools/exceptionHolidays.pl Removing tools/copy-holidays.pl Auto-merging misc/cronjobs/staticfines.pl Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/tools/tools-home.tt CONFLICT (modify/delete): koha-tmpl/intranet-tmpl/prog/en/modules/tools/holidays.tt deleted in Bug 11211 - Move calculation code out of C4::Calendar and modified in HEAD. Version HEAD of koha-tmpl/intranet-tmpl/prog/en/modules/tools/holidays.tt left in tree. Auto-merging koha-tmpl/intranet-tmpl/prog/en/includes/tools-menu.inc Auto-merging Koha/Calendar.pm Auto-merging C4/Overdues.pm Auto-merging C4/Installer/PerlDependencies.pm CONFLICT (content): Merge conflict in C4/Installer/PerlDependencies.pm Auto-merging C4/Circulation.pm Failed to merge in the changes. Patch failed at 0001 Bug 11211 - Move calculation code out of C4::Calendar When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-11211---Move-calculation-code-out-of-C4Calenda-SuvqdA.patch The first one is probably caused by bug 13289: http://git.koha-community.org/gitweb/?p=koha.git;a=commit;h=c474b0f645fecb2c1663907904c6b9aa583e4513 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13068] New feature for DB update and sandbox
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 M. de Rooy changed: What|Removed |Added Assignee|paul.poul...@biblibre.com |m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13068] New feature for DB update and sandbox
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 --- Comment #48 from M. de Rooy --- OK Two against one: I moved it to koha-conf.xml Please test and sign-off.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13068] New feature for DB update and sandbox
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 M. de Rooy changed: What|Removed |Added Attachment #32843|0 |1 is obsolete|| Attachment #32921|0 |1 is obsolete|| --- Comment #47 from M. de Rooy --- Created attachment 33859 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33859&action=edit Bug 13068: Counterpatch follow-up for controlling workflow The workflow for dev updates can be altered with devupdatecontrol: [1] devupdatecontrol= PROD for production machines: Do not execute RunRemainingDevUpdates, so only official db revs. This is the default. [2] devupdatecontrol= RESET: Reinstall dev updates after an official db rev. [3] devupdatecontrol= ALWAYS: Run the dev updates at each upgrade. [4] devupdatecontrol=TRACK: Only install new dev updates. It does not reset the local pref listing all recently applied dev updates. ONLY use this if you know what you are doing! Note: devupdatecontrol is a configuration variable from koha-conf.xml. If it does not exist or is empty, we fall back to PROD (safest). If it differs from PROD, ALWAYS or TRACK, it falls back to RESET. Note2: Initially, devupdatecontrol was a preference. It has been moved to koha-conf.xml as requested by several developers (Nov 24). Test plan: [1] Add a few lines calling ExecDBRev to updatedatabase with corresponding files in atomicupdate like (insert the correct version!!): ExecDBRev( $aupd, '13068', 'My test', '13068.pl', '3.17.00.028'); Do not forget to update kohaversion.pl accordingly. Add some other files in atomicupdate as dev updates. [2] Repeat for the various modes of devupdatecontrol (see above): Reset the database version. You could edit Version in local preferences. Optionally clear/delete the _LocalAtomicUpdates pref. Run updatestructure and check which db revs and dev updates are run or skipped. Run it again and check which dev updates are run or skipped. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13314] Fixes to .mailmap for the 3.18 release
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13314 Magnus Enger changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13314] Fixes to .mailmap for the 3.18 release
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13314 Magnus Enger changed: What|Removed |Added Attachment #33851|0 |1 is obsolete|| Attachment #33853|0 |1 is obsolete|| Attachment #33857|0 |1 is obsolete|| --- Comment #17 from Magnus Enger --- Created attachment 33858 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33858&action=edit Bug 13314: attribute Oslo Public Library Signed-off-by: Tomas Cohen Arazi Signed-off-by: Magnus Enger Fixes names and mappings for contributors from Oslo Public Library. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13019] Add base classes on which to build Koha objects
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13019 --- Comment #46 from Jonathan Druart --- (In reply to M. de Rooy from comment #45) > I think we should push this now and first build a object on it, used in real > Koha code (not just some tests). After evaluating that "exercise", we can > think of adapting the coding guidelines. See bug 10363. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13314] Fixes to .mailmap for the 3.18 release
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13314 --- Comment #16 from Tomás Cohen Arazi --- Created attachment 33857 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33857&action=edit Bug 13314: OPL followup - Benjamin Rokseth Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13001] Refactor VAT and price calculation - parcel page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13001 --- Comment #12 from Jonathan Druart --- I rebased patches on bug 12896. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12896] Move the bookseller-related code into its own module
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12896 --- Comment #32 from Jonathan Druart --- Patches rebased. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12896] Move the bookseller-related code into its own module
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12896 Jonathan Druart changed: What|Removed |Added Attachment #2|0 |1 is obsolete|| Attachment #3|0 |1 is obsolete|| --- Comment #30 from Jonathan Druart --- Created attachment 33855 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33855&action=edit Bug 12896: Move the bookseller-related code into Koha::Acquisition::Bookseller The C4::Acquisition module should be exploded in order to add readability and maintainability to this part of the code. This patch is a POC, it introduces a new Koha::Acquisition::Bookseller module and put in it the code from GetBookSeller and GetBookSellerFromId. Test plan: 1/ Create a bookseller, modify it. 2/ Add contacts for this bookseller 3/ Create an order, receive it, transfer it 4/ Launch the prove command on all unit tests modified by this patch and verify that all pass. Signed-off-by: Paola Rossi Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12896] Move the bookseller-related code into its own module
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12896 --- Comment #31 from Jonathan Druart --- Created attachment 33856 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33856&action=edit Bug 12896: Remove 2 occurrences in comments Signed-off-by: Katrin Fischer Passes tests and QA script. Full test report on the bug report. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13329] Can't make new suggestion with AllowPurchaseSuggestionBranchChoice turned on
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13329 Marc Véron changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||ve...@veron.ch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13329] Can't make new suggestion with AllowPurchaseSuggestionBranchChoice turned on
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13329 Marc Véron changed: What|Removed |Added Attachment #33830|0 |1 is obsolete|| --- Comment #2 from Marc Véron --- Created attachment 33854 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33854&action=edit Bug 13329: Fix create a suggestion at the OPAC The suggestion table does not contain a 'branch' column name. The script should pass 'branchcode' to C4::Suggestion::NewSuggestion. Test plan: 0/ Enable the AllowPurchaseSuggestionBranchChoice pref 1/ Create a suggestion at the OPAC should not raise a DBIx::Class error. I could reproduce the bug. With patch bug is gone. Signed-off-by: Marc Véron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13001] Refactor VAT and price calculation - parcel page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13001 --- Comment #11 from Paola Rossi --- Today I've tried to apply the patches against master 3.17.00.058 head 13297 I should have applied this sequence: 12852 PQA (32275, 32276, 32277) 12896 PQA (2 3) 12969 SO (31920 31921) 12976 SO (31983 33573 33613) 13001 (31982 33677) But : Applying: Bug 12896: Move the bookseller-related code into Koha::Acquisition::Bookseller Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging acqui/newordersuggestion.pl CONFLICT (content): Merge conflict in acqui/newordersuggestion.pl Auto-merging acqui/addorderiso2709.pl Failed to merge in the changes. Patch failed at 0001 Bug 12896: Move the bookseller-related code into Koha::Acquisition::Bookseller [I keep this patch 13001 in the "Signed Off" status.] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13314] Fixes to .mailmap for the 3.18 release
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13314 --- Comment #15 from Tomás Cohen Arazi --- Created attachment 33853 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33853&action=edit Bug 13314: OPL followup - Petter Goksoyr Asen Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13019] Add base classes on which to build Koha objects
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13019 M. de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #45 from M. de Rooy --- QA Comment: Some minor concerns have been addressed in the meantime. This topic waits for some time now and has been discussed at various times, but without too much progress. I think this set of patches is an interesting starting point now. The Borrower example submitted now is too small to really show the advantages/disadvantages of this approach. The code looks good. No complaints from qa tools. I think we should push this now and first build a object on it, used in real Koha code (not just some tests). After evaluating that "exercise", we can think of adapting the coding guidelines. Note that the object still need some further documentation, but I do not mind doing that in follow-ups later. Let's get this further now. Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13314] Fixes to .mailmap for the 3.18 release
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13314 Tomás Cohen Arazi changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13314] Fixes to .mailmap for the 3.18 release
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13314 Tomás Cohen Arazi changed: What|Removed |Added CC||mag...@enger.priv.no -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13314] Fixes to .mailmap for the 3.18 release
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13314 --- Comment #14 from Tomás Cohen Arazi --- Created attachment 33851 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33851&action=edit Bug 13314: attribute Oslo Public Library Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13019] Add base classes on which to build Koha objects
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13019 M. de Rooy changed: What|Removed |Added Status|Passed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13019] Add base classes on which to build Koha objects
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13019 M. de Rooy changed: What|Removed |Added Attachment #33850|0 |1 is obsolete|| --- Comment #44 from M. de Rooy --- Created attachment 33852 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33852&action=edit Bug 13019 [QA Followup] - Remove use of encode Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
