[Koha-bugs] [Bug 13381] RDA: 245 field changes in XSLT
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13381 --- Comment #11 from Katrin Fischer --- (In reply to Winona Salesky from comment #9) > Just for clarification, there is currently no "Media type" in the record. We > want to add a test to check for 337, if no 337, show 245$h? > > Thank you. > -Winona The logic sounds right to me -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13381] RDA: 245 field changes in XSLT
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13381 --- Comment #10 from David Cook --- (In reply to Winona Salesky from comment #9) > Just for clarification, there is currently no "Media type" in the record. We > want to add a test to check for 337, if no 337, show 245$h? > > Thank you. > -Winona I'm not sure I understand. Do you mean that the XSLT doesn't currently show the 337? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13431] Shared FastMmap file causes issues
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13431 --- Comment #21 from Jacek Ablewicz --- (In reply to Robin Sheat from comment #20) > Looking at Cache::FastMmap now, it might be that you can't set the expiry > timeout on individual writes, you can only set it globally. There seems to be a lot of confusing reports on the net regarding this subject, but setting expiry timeout separately for individual cache entries is supported since version 1.23 or so (although this particular feature is still apparently not documented in any meaningful way). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 David Cook changed: What|Removed |Added Status|In Discussion |ASSIGNED --- Comment #10 from David Cook --- (In reply to Koha Team Lyon 3 from comment #9) > I'm interrested by this feature, if you need someone to test, I'm volunteer. > > Sonia BOUIS Great! Thanks, Sonia :). I think that I have the main engine working, but I got distracted by DBIx::Class::Schema and some local work projects, so I haven't finished the UI, the documentation, or the unit tests yet. At the moment, I have another project taking priority over this one, but the OAI-PMH harvester is #2 on my list of projects. Hopefully, I'll be able to look at this soon. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5377] Database fields too small for multiple ISBN and ISSN
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5377 vimal kumar changed: What|Removed |Added CC||vimal0...@gmail.com Version|master |3.16 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13443] DBD::mysql::db do failed: Table 'koha_library.roadtype' doesn't exist
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13443
vimal kumar changed:
What|Removed |Added
Status|NEW |In Discussion
--- Comment #1 from vimal kumar ---
I have solved the problem. Please follow the steps,
Open a terminal
sudo su
leafpad /usr/share/koha/intranet/cgi-bin/installer/data/mysql/updatedatabase.pl
Search > Jump To > 7985
Find the line
$dbh->{RaiseError} = 0;
Change the value 1 to 0.
Save file.
Go back to koha and refresh the page.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13381] RDA: 245 field changes in XSLT
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13381 --- Comment #9 from Winona Salesky --- Just for clarification, there is currently no "Media type" in the record. We want to add a test to check for 337, if no 337, show 245$h? Thank you. -Winona -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13431] Shared FastMmap file causes issues
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13431 --- Comment #20 from Robin Sheat --- (In reply to Jacek Ablewicz from comment #19) > That comment in Koha/Cache.pm "fastmmap .. doesn't support expiry in a > useful way" is quite puzzling; I'm unable to find anything specific anywhere > regarding what exactly is wrong with it's expiry mechanism - ? I can't remember now, there is/was something it doesn't do that we needed for consistency, but I'm unsure of the details. Looking at Cache::FastMmap now, it might be that you can't set the expiry timeout on individual writes, you can only set it globally. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13381] RDA: 245 field changes in XSLT
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13381 --- Comment #8 from Winona Salesky --- Okay. I think a reasonable approach would be to leave off subfield c, and add a test if a record accidentally has a 245$h and a 337 and only show one. -Winona -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 David Cook changed: What|Removed |Added Attachment #21954|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13416] Typo in marc21_leader.pl position 5 (record status)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13416 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13416] Typo in marc21_leader.pl position 5 (record status)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13416 Katrin Fischer changed: What|Removed |Added Attachment #34452|0 |1 is obsolete|| --- Comment #7 from Katrin Fischer --- Created attachment 34520 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34520&action=edit [PASSED QA] Bug 13416: Typo in marc21_leader.pl position 5 (record status) Instead of a space in the leader on this position, it should be an a. Test plan: 1) Log in to staff client 2) Find a record in the catalog 3) Edit the record 4) Click the on builder popup icon. 5) View the page source -- the option is " " for the 'a- Increase in encoding level' entry. It really should be 'a'. 6) Apply patch. 7) Repeat steps 1-5 -- the option should be 'a' this time. 8) Run koha qa test tools. -- Discovered it failed. Provided a patch to fix this. It does, however, solve the major problem of ' ' vs. 'a'. Signed-off-by: Mark Tompsett Signed-off-by: Katrin Fischer Works as described. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13465] Fields controlled by authorized values cannot be unset (Lost, damaged, not for loan status, ...)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13465 Katrin Fischer changed: What|Removed |Added Attachment #34511|0 |1 is obsolete|| --- Comment #10 from Katrin Fischer --- Created attachment 34519 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34519&action=edit [PASSED QA] Bug 13465: Correct the field prefix ambiguity This is introduced by Bug 12874. Without this patch, it's not possible to clear (set to an empty string) an item field. This appended for field linked to an AV list but even if it's not. The regex tried to prefix 'my_field' with 'items.' to have 'items.my_field'. It wanted to take care of the case where the prefix already exists (Actually only 1: 'items.cn_source'). The regex is changed to: "add the prefix only if the string does not contain a dot". Moreover an ambiguity existed on the prefix: in marc_subfield_structure, the kohafield is prefixed, but not in the key of the hash sent to ModItemFromMarc. Test plan: - edit an item, set a status that is controlled by an authorized value examples tested: damaged, not for loan - check the status saved correctly - edit the item again, reset the status to empty - check the status saved correctly - edit the item again, reset fields, edit fields - check the fields saved correctly Signed-off-by: Mirko Tietgen Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13465] Fields controlled by authorized values cannot be unset (Lost, damaged, not for loan status, ...)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13465 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13476] Item Search feature gets datatables error and doesn't complete search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13476 --- Comment #2 from Katrin Fischer --- Also confirmed on current master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11425] Search form for items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11425 Katrin Fischer changed: What|Removed |Added Blocks||13476 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13476] Item Search feature gets datatables error and doesn't complete search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13476 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Depends on||11425 --- Comment #1 from Katrin Fischer --- I can confirm the bug on 3.18.1, the search is currently not working. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13476] Item Search feature gets datatables error and doesn't complete search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13476 Katrin Fischer changed: What|Removed |Added Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13296] error when using z3950 with UNIMARC authorities
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13296 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #7 from Katrin Fischer --- This doesn't work for me on current master, I retested, but I only get an empty datatable showing lots of pages. There is lots of noise in the logs, not sure what's wrong. Can you please retest your patch on current master? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6590] Removing hyphens from isbn and issn when cataloging a biblio
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6590 Marjorie Barry-Vila changed: What|Removed |Added CC||marjorie.barry-v...@ccsr.qc ||.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13431] Shared FastMmap file causes issues
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13431 --- Comment #19 from Jacek Ablewicz --- (In reply to Robin Sheat from comment #17) > Yeah, it's not recommended to use fastmmap_cache unless you have good cause > to due to it not supporting expiry. That comment in Koha/Cache.pm "fastmmap .. doesn't support expiry in a useful way" is quite puzzling; I'm unable to find anything specific anywhere regarding what exactly is wrong with it's expiry mechanism - ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13431] Shared FastMmap file causes issues
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13431
--- Comment #18 from Jacek Ablewicz ---
(In reply to Chris Cormack from comment #16)
> > +use C4::Context;
>
> We can't do this. We just added a big circular dependency if we do.
>
> Because C4::Context uses Koha::Cache
Not in the current master (?), but it indeed will be used after bug 11998 (I
was under the impression that bug got already pushed). But it looks like this
line is not even necessary: in all places where Koha::Cache is used so far,
C4::Context is already loaded. Making such assumption is probably not very good
practice, but this code part (which includes database name etc. in the
sharefile name) is intended only as temporary (= until namespace configuration
issue gets dealt with properly) solution for severely misconfigured
multi-instance setups. So maybe we can live with that ;) if some extra
precautions will be taken (like putting that code part in the eval {} block +
some warn "Unable to determine database name due to .." maybe ?).
> @@ +162,5 @@
> > sub _initialize_fastmmap {
> > my ($self) = @_;
> > +my $share_file = join( '-',
> > +"/tmp/sharefile-koha", $self->{'namespace'},
> > +C4::Context->config('hostname'), C4::Context->config('database'),
>
> A better way to do this is is to change the places that call
> Koha::Cache->new()
> To set the namespace.
>
> EG my $cache = Koha::Cache-new({cache_type => 'memcached_cache', namespace
> => C4::Context->config('hostname') . '-' .C4::Context->config('database')});
That would make Koha::Cache usage a bit inconvenient IMO, especially as
Koha::Cache->new() is currently never called outside of Koha::Cache itself,
Koha::Cache->get_instance() is always used instead.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13481] New: if single library don't have libraries option on circ & fine rules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13481 Bug ID: 13481 Summary: if single library don't have libraries option on circ & fine rules Change sponsored?: --- Product: Koha Version: master Hardware: All URL: cgi-bin/koha/admin/smart-rules.pl?branch=* OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: neng...@gmail.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com If the system has only 1 library I don't think we should have Library pull down at the top of the circ & fine rules page. It just confuses things because single libraries don't realize that there are 2 places where they might have rules. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4148] Advanced Search not sorting by author
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4148 Marc Véron changed: What|Removed |Added CC||ve...@veron.ch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13419] Add filters and server-side processing to the shelves list view
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13419 Marc Véron changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13419] Add filters and server-side processing to the shelves list view
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13419 --- Comment #14 from Marc Véron --- Created attachment 34518 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34518&action=edit [Signed-off] Bug 13419: (follow-up) Add tests - remove existing shelves Works as expected. Signed-off-by: Marc Véron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13419] Add filters and server-side processing to the shelves list view
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13419 Marc Véron changed: What|Removed |Added Attachment #34517|Bug 13419: Add tests|[Signed-off] Bug 13419: Add description||tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13419] Add filters and server-side processing to the shelves list view
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13419 Marc Véron changed: What|Removed |Added Attachment #34243|0 |1 is obsolete|| --- Comment #13 from Marc Véron --- Created attachment 34517 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34517&action=edit Bug 13419: Add tests Test plan: prove t/db_dependent/Utils/Datatables_Virtualshelves.t should return green Tested together with follow-up, works as expected Signed-off-by: Marc Véron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13419] Add filters and server-side processing to the shelves list view
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13419 --- Comment #12 from Jonathan Druart --- (In reply to Marc Véron from comment #10) > For patch #3 "Add tests" I get errors Good catch Marc, thanks for testing! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13419] Add filters and server-side processing to the shelves list view
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13419 --- Comment #11 from Jonathan Druart --- Created attachment 34516 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34516&action=edit Bug 13419: (follow-up) Add tests - remove existing shelves -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8096] Card number twice on patron search results
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8096 --- Comment #8 from Marc Véron --- Patch still applies with current master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13480] Add ActionLog for changes to System Preferences
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13480 Barton Chittenden changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #1 from Barton Chittenden --- It turns out this is already logged. Never mind. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13480] New: Add ActionLog for changes to System Preferences
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13480 Bug ID: 13480 Summary: Add ActionLog for changes to System Preferences Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Transaction logs Assignee: koha-bugs@lists.koha-community.org Reporter: bar...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org For support purposes, it would be helpful to be able to track which user made changes to system preferences. I have a systems librarian who is trying to track down who made changes to their sysprefs, and I don't have any answers to who did it or when. This would involve adding a 'SysprefLog' system preference, as well as code that would log the actions of changing system preferences. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13419] Add filters and server-side processing to the shelves list view
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13419 --- Comment #10 from Marc Véron --- For patch #3 "Add tests" I get errors # Failed test 'There should be 12 public shelves in total' # at t/db_dependent/Utils/Datatables_Virtualshelves.t line 199. # got: '15' # expected: '12' # Failed test 'There should be 12 private shelves' # at t/db_dependent/Utils/Datatables_Virtualshelves.t line 202. # got: '15' # expected: '12' # Failed test 'There should be 12 public shelves in total' # at t/db_dependent/Utils/Datatables_Virtualshelves.t line 214. # got: '15' # expected: '12' # Failed test 'There should be 12 public shelves in total' # at t/db_dependent/Utils/Datatables_Virtualshelves.t line 230. # got: '15' # expected: '12' # Looks like you failed 4 tests of 13. However if I remove all public lists, it passes OK -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13419] Add filters and server-side processing to the shelves list view
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13419 Marc Véron changed: What|Removed |Added Attachment #34241|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13419] Add filters and server-side processing to the shelves list view
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13419 Marc Véron changed: What|Removed |Added Attachment #34515|Bug 13419: Add filters on |[Signed-off] Bug 13419: Add description|the list table |filters on the list table -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13419] Add filters and server-side processing to the shelves list view
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13419 Marc Véron changed: What|Removed |Added Attachment #34242|0 |1 is obsolete|| --- Comment #9 from Marc Véron --- Created attachment 34515 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34515&action=edit Bug 13419: Add filters on the list table Tested together with patch #1, works as expected Signed-off-by: Marc Véron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13419] Add filters and server-side processing to the shelves list view
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13419 --- Comment #8 from Marc Véron --- Created attachment 34514 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34514&action=edit [Signed-off] Bug 13419: Add server-side processing for lists This patch adds DataTables using a server-side processing to display lists (virtual shelves). Test plan: 1/ Go on virtualshelves/shelves.p 2/ Play with the table functions (sort, filter, pagination, etc.) 3/ Go with the Public lists tab and verify the table is correctly filtered. Tested together with patch #2, works as expected. Signed-off-by: Marc Véron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 Koha Team Lyon 3 changed: What|Removed |Added CC||k...@univ-lyon3.fr --- Comment #9 from Koha Team Lyon 3 --- I'm interrested by this feature, if you need someone to test, I'm volunteer. Sonia BOUIS -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13479] Add option to add/remove biblios from list of books with forced item holds
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13479 M. de Rooy changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=13478 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13478] Force item holds only for specific biblios
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13478 M. de Rooy changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=13479 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13479] Add option to add/remove biblios from list of books with forced item holds
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13479 --- Comment #1 from M. de Rooy --- Some ideas to start with: Option for specific biblio can be set/unset on staff catalog detail page. Might be interesting to add the option for item types too. For some item types you may want to force item holds. Add a script that allows you to incidentally add or remove books from the list under specified conditions. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13479] New: Add option to add/remove biblios from list of books with forced item holds
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13479 Bug ID: 13479 Summary: Add option to add/remove biblios from list of books with forced item holds Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: m.de.r...@rijksmuseum.nl QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com This report is a follow-up for bug 13478. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13407] Remove methods which are included in the 0.36 release of PDF::Reuse
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13407 M. Tompsett changed: What|Removed |Added CC||mtomp...@hotmail.com --- Comment #6 from M. Tompsett --- It should be noted, I actually attempted to find the individual tests that triggered it. t/Label* t/Patron* t/Creator* if I recall correctly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13263] Printing Callnumber in Koha 3.16.04.000.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13263 Jerwyn changed: What|Removed |Added Priority|P5 - low|P1 - high -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13478] Force item holds only for specific biblios
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13478 M. de Rooy changed: What|Removed |Added Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13478] Force item holds only for specific biblios
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13478 --- Comment #2 from M. de Rooy --- I will open a new report to add the option of adding to the list. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13478] Force item holds only for specific biblios
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13478 --- Comment #1 from M. de Rooy --- Created attachment 34513 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34513&action=edit Bug 13478: Force item holds only for specific biblios This patch adds the option to selectively force item holds for specific biblionumbers. These numbers are saved in a separate table. The patch adds routine C4::Reserves::CheckBiblioForceItemHolds. It is tested in Reserves.t. The preference OPACItemHolds gets a new choice: selectiveforce. The description of the pref is adjusted. Please note that this option is specifically targeted for the OPAC. Staff users still have both possibilities. A follow-up patch adds the possibility for staff users to add or remove a biblio from the list of books with forced item holds. TEST PLAN: [ 1] Run the database revision. [ 2] Run the unit test t/db_dependent/Reserves.t. [ 3] Set OPACItemHolds to force. [ 4] Add a hold in the OPAC; verify that you cannot place a next/av hold. [ 5] Set OPACItemHolds to Allow. [ 6] Add a hold in the OPAC; verify that you can place both hold types. [ 7] Set OPACItemHolds to Do not allow. [ 8] Add a hold in the OPAC; verify that you can only place next/av holds. [ 9] Add two biblio numbers into table biblio_force_item_holds. [10] Set OPACItemHolds to Selectively force. [11] Add a hold on three biblionumbers at once (including these two). Verify that you have two hold types for the single biblio and that you have only item holds for the two other biblios. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13478] Force item holds only for specific biblios
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13478 M. de Rooy changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13407] Remove methods which are included in the 0.36 release of PDF::Reuse
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13407 M. Tompsett changed: What|Removed |Added Attachment #34173|0 |1 is obsolete|| --- Comment #5 from M. Tompsett --- Created attachment 34512 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34512&action=edit Bug 13407: Removing depricated code included in PDF::Reuse http://bugs.koha-community.org/show_bug.cgi?id=13407 See test plan in comment #3. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13407] Remove methods which are included in the 0.36 release of PDF::Reuse
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13407 M. Tompsett changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13428] Fix facet deletion
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13428 --- Comment #10 from Chris Cormack --- (In reply to Jonathan Druart from comment #9) > This should not have been pushed before bug 13425, because now the facets > deletion is broken :) Yep 13425 opac changes are pushed to master, 3.18.x and 3.16.x and this only changes the opac, so needed to be pushed. > > It should be pushed to 3.16.x, the patch applies cleanly. > > ping Mason :) So yep just to 3.16.x now -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12252] OAI-PMH GetRecord result doesn't include item data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12252 --- Comment #23 from M. de Rooy --- (In reply to Jonathan Druart from comment #22) > I would like to get other QA point of view here. > > The changes in GetMarcBiblio does not provided any tests. But none of > GetMarcBiblio and EmbedItemsInMarcBiblio have tests! > It would be very good nice to see these 2 subroutines tested, but should we > block this patch set for this reason? >From a glance, it looks like adding some tests for at least EmbedItems would not be a bad thing here. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13478] Force item holds only for specific biblios
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13478 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13478] Force item holds only for specific biblios
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13478 M. de Rooy changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |m.de.r...@rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13478] Force item holds only for specific biblios
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13478 M. de Rooy changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13478] Force item holds only for specific biblios
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13478 M. de Rooy changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=7825 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7825] Change OPACItemHolds syspref to be of type Choice, choices being "no", "yes", "force"
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7825 M. de Rooy changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=13478 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13478] New: Force item holds only for specific biblios
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13478 Bug ID: 13478 Summary: Force item holds only for specific biblios Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: m.de.r...@rijksmuseum.nl QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13477] New: On order detail not showing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13477 Bug ID: 13477 Summary: On order detail not showing Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: imingc...@yahoo.com.au QA Contact: testo...@bugs.koha-community.org In 3.18.01, on order detail no longer showing on "Holdings" tab. This detail was showing in 3.18. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12252] OAI-PMH GetRecord result doesn't include item data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12252 Jonathan Druart changed: What|Removed |Added CC||k...@bywatersolutions.com, ||m.de.r...@rijksmuseum.nl --- Comment #22 from Jonathan Druart --- I would like to get other QA point of view here. The changes in GetMarcBiblio does not provided any tests. But none of GetMarcBiblio and EmbedItemsInMarcBiblio have tests! It would be very good nice to see these 2 subroutines tested, but should we block this patch set for this reason? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12252] OAI-PMH GetRecord result doesn't include item data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12252
--- Comment #21 from Jonathan Druart ---
Comment on attachment 33121
--> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33121
Bug 12252 - OAI-PMH items respect OpacHiddenItems
Review of attachment 33121:
-->
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=12252&attachment=33121)
-
::: C4/Biblio.pm
@@ +1263,5 @@
> +=item C<$embeditems>
> +
> +set to true to include item information.
> +
> +=item C<$opac>
This new parameter will be used in all opac scripts where we want to embed
items.
@@ +2928,5 @@
> my @item_fields;
> my ( $itemtag, $itemsubfield ) = GetMarcFromKohaField(
> "items.itemnumber", $frameworkcode );
> +my @items;
> +my $opachiddenitems = $opac
> + && ( C4::Context->preference('OpacHiddenItems') !~ /^\s*$/ );
It would have been better to use /\S/ to match the existing test.
::: opac/oai.pl
@@ +280,4 @@
>
> # We fetch it using this method, rather than the database directly,
> # so it'll include the item data
> +my $record = GetMarcBiblio($biblionumber, 1, 1);
We really want to avoid this kind of calls, it's not readable.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13465] Fields controlled by authorized values cannot be unset (Lost, damaged, not for loan status, ...)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13465 Mirko Tietgen changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13465] Fields controlled by authorized values cannot be unset (Lost, damaged, not for loan status, ...)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13465 Mirko Tietgen changed: What|Removed |Added Attachment #34508|0 |1 is obsolete|| --- Comment #9 from Mirko Tietgen --- Created attachment 34511 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34511&action=edit Bug 13465: Correct the field prefix ambiguity This is introduced by Bug 12874. Without this patch, it's not possible to clear (set to an empty string) an item field. This appended for field linked to an AV list but even if it's not. The regex tried to prefix 'my_field' with 'items.' to have 'items.my_field'. It wanted to take care of the case where the prefix already exists (Actually only 1: 'items.cn_source'). The regex is changed to: "add the prefix only if the string does not contain a dot". Moreover an ambiguity existed on the prefix: in marc_subfield_structure, the kohafield is prefixed, but not in the key of the hash sent to ModItemFromMarc. Test plan: - edit an item, set a status that is controlled by an authorized value examples tested: damaged, not for loan - check the status saved correctly - edit the item again, reset the status to empty - check the status saved correctly - edit the item again, reset fields, edit fields - check the fields saved correctly Signed-off-by: Mirko Tietgen -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12252] OAI-PMH GetRecord result doesn't include item data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12252 --- Comment #20 from Jonathan Druart --- *** Bug 13475 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13475] OAI does not return items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13475 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff |RESOLVED Resolution|--- |DUPLICATE --- Comment #3 from Jonathan Druart --- (In reply to Katrin Fischer from comment #2) > Hi Jonathan, I think this is duplicate to 12252 - can you check the other > implementation? It's waiting for QA :) Yes it is, thanks. *** This bug has been marked as a duplicate of bug 12252 *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13419] Add filters and server-side processing to the shelves list view
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13419 --- Comment #7 from Jonathan Druart --- (In reply to Marc Véron from comment #4) > Change selection in drop box 'Sort by' > Result: No change in list. You have to change 'List name' or 'Author' to > trigger filtering. - This is confusing. Looks good here. Did you see the "processing" message? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13436] Add more options to UsageStatsLibraryType
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13436 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13436] Add more options to UsageStatsLibraryType
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13436 Jonathan Druart changed: What|Removed |Added Attachment #34500|0 |1 is obsolete|| --- Comment #10 from Jonathan Druart --- Created attachment 34510 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34510&action=edit Bug 13436: Adding more options to UsageStatsLibraryType syspref Added options: - research - private - society or association - corporate - government - religious organization - subscription - school Also changed 'university' to 'academic' To test: 1) Go on to Global System Preferences and find UsageStatsLibraryType under Administration 2) Click drop-down menu and see all new options described above, as well as 'academic' instead of 'university' Signed-off-by: Jonathan Druart Amended patch: replace tab with spaces -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13428] Fix facet deletion
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13428 --- Comment #9 from Jonathan Druart --- This should not have been pushed before bug 13425, because now the facets deletion is broken :) It should be pushed to 3.16.x, the patch applies cleanly. ping Mason :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4283] Merge bibliographic records
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4283 --- Comment #4 from Olli-Antti Kivilahti --- Created attachment 34509 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34509&action=edit Bug 4283 - Merge bibliographic records. Followup. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13465] Fields controlled by authorized values cannot be unset (Lost, damaged, not for loan status, ...)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13465 --- Comment #8 from Jonathan Druart --- (In reply to Mirko Tietgen from comment #6) > With this patch applied, situation is worse. I can't save most fields. > »damaged« does stay when set, other fields forget/ delete the value on save. > > But deleting a value that has been set before applying the patch works ;) Sorry, Mirko, it's was a quick fix and I did not test it deeply. This one should be better. Thanks for testing! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13465] Fields controlled by authorized values cannot be unset (Lost, damaged, not for loan status, ...)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13465 Jonathan Druart changed: What|Removed |Added Attachment #34478|0 |1 is obsolete|| --- Comment #7 from Jonathan Druart --- Created attachment 34508 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34508&action=edit Bug 13465: Correct the field prefix ambiguity This is introduced by Bug 12874. Without this patch, it's not possible to clear (set to an empty string) an item field. This appended for field linked to an AV list but even if it's not. The regex tried to prefix 'my_field' with 'items.' to have 'items.my_field'. It wanted to take care of the case where the prefix already exists (Actually only 1: 'items.cn_source'). The regex is changed to: "add the prefix only if the string does not contain a dot". Moreover an ambiguity existed on the prefix: in marc_subfield_structure, the kohafield is prefixed, but not in the key of the hash sent to ModItemFromMarc. Test plan: - edit an item, set a status that is controlled by an authorized value examples tested: damaged, not for loan - check the status saved correctly - edit the item again, reset the status to empty - check the status saved correctly - edit the item again, reset fields, edit fields - check the fields saved correctly -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13465] Fields controlled by authorized values cannot be unset (Lost, damaged, not for loan status, ...)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13465 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
