[Koha-bugs] [Bug 12671] Guess next serial date when there are several issues per unit
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12671 Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed: What|Removed |Added Attachment #30291|0 |1 is obsolete|| --- Comment #5 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi --- Created attachment 34659 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34659action=edit Bug 12671: Refactor GetNextDate A much needed refactoring. Thanks for seeing the effort through. Signed-off-by: Olli-Antti Kivilahti olli-antti.kivila...@jns.fi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12671] Guess next serial date when there are several issues per unit
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12671 Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed: What|Removed |Added Attachment #30292|0 |1 is obsolete|| --- Comment #6 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi --- Created attachment 34660 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34660action=edit Bug 12671: Guess next serial date when there are several issues per unit This guess uses the following algorithm 1/ Get the number of days remaining from first issue of this unit of time until the end of the unit of time (using 7 days for week, 28 for month and 365 for year) 2/ Divide it by the number of issues per unit 3/ Take the integer part of the result, this is the number of days to add to previous serial published date This patch also try to guess the date of the first issue of a unit of time. Before that, it was: - for week: monday of week - for month: 1st day of month - for year: 1st day of year Now it uses firstacquidate. Example: firstacquidate = 1970-01-07 (wednesday) unit = week issuesperunit = 2 (2 issues per week) From wednesday to sunday, there are 4 days so we add 2 days to get the next date. The next dates should be: - 1970-01-09 (+ 2 days) - 1970-01-14 (wednesday of next week) - 1970-01-16 (+ 2 days) - ... and so on Test plan: 1/ Go to numbering pattern creation page (Serials - Manager numbering patterns - New numbering pattern) 2/ In Test prediction pattern fieldset, set subscription length to 50 issues (this avoid to compute the next 1000 dates, which can take time) 3/ Fill first issue publication date 4/ Choose the frequency you want to test 5/ click on Test pattern button 6/ Check that the dates are correct 7/ Repeat steps 3-7 until you think you have tested enough cases Interesting frequencies to test: - 1/day - 1/week - 2/week - 6/week (firstacquidate should be monday or tuesday, or the generated dates will be the same for all the week) - 1/month - 2/month - 3/month - 1/year - 2/year - 3/year Sign off report: -Followed the test plan. Unit tests work. Also trying some more strange frequencies with our librarians: 5/year, 43/year, 10/year. -Received all serials for a subscription and found no errors. -Received some serials with frequency 2/month pre-patch, getting publication date as 1st of every month for each magazine. Having applied the patch, publication dates started working mid-subscription for new magazines. -Works well and fine! Signed-off-by: Olli-Antti Kivilahti olli-antti.kivila...@jns.fi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13471] When editing a subscription, the subscription length type disregards the stored value, also make SLT translateable.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13471 Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed: What|Removed |Added Attachment #34506|0 |1 is obsolete|| --- Comment #4 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi --- Created attachment 34661 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34661action=edit Bug 13471 - When editing a subscription, the subscription length type disregards the stored value, also make SLT translateable. This issue causes loss of data when the subscription length type (SLT) is other than issues. TO REPLICATE: We make an subscription with SLT of months = 12. Later make an arbitrary edit to the subscription, and miss out the fact that the SLT selection is set to issues. Save the changes. Serial subscription end date is set to 12 issues since the start date, instead of 12 months which it used to be. This causes a myriad of issues :=) AFTER THIS PATCH: SLT defaults to the value initially saved instead of always being issues. Now the selection can be translated! HOTFIX 1: Added span elements to showSubscriptionLengthType.inc so the translation tool can catch them. HOTFIX 2: Fixed serials/showpredictionpattern.pl to use the db columns instead of issues,weeks,months. HOTFIX 3: Fixed serials/subscription-numberpatterns.pl to use the db columns instead of issues,weeks,months. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12814] KOHA Cataloging (Authorities) Problem
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12814 Jonathan Smith jonathan_sm...@mail.com changed: What|Removed |Added CC||jonathan_sm...@mail.com Version|3.16|master Severity|normal |major --- Comment #1 from Jonathan Smith jonathan_sm...@mail.com --- Hello, This is a serious problem, when CatalogModuleRelink is on when entering a new record gets a incorrectly auhtid for a text in different terms of authority. I also noticed in link_bibs_to_authorities.pl that regardless of the setting CatalogModuleRelink also have this problem. Cheers, Jonathan Librarian ULS -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13491] New: make Selfcheck follow the CircAutoPrintQuickSlip
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13491 Bug ID: 13491 Summary: make Selfcheck follow the CircAutoPrintQuickSlip Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: neng...@gmail.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Selfcheck should follow the CircAutoPrintQuickSlip system preference - or maybe we need another sys pref to control which slip prints via self check. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13492] New: Add location to the checkouts tables
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13492 Bug ID: 13492 Summary: Add location to the checkouts tables Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.dru...@biblibre.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com The patch set will add the location column to the checkouts tables (circ/circulation.pl and members/moremember.pl). On the way, it will also add the column settings for these tables. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13492] Add location to the checkouts tables
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13492 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|NEW |ASSIGNED Depends on||10212 Assignee|koha-b...@lists.koha-commun |jonathan.dru...@biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10212] Columns configuration for tables
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10212 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Blocks||13492 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13492] Add location to the checkouts tables
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13492 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13492] Add location to the checkouts tables
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13492 --- Comment #1 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 34662 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34662action=edit Bug 13492: Add the column configuration for the checkouts table - circulation.pl Test plan: 1/ Verify that you can show/hide columns on the checkouts table (circulation.pl). 2/ Play with the column configuration admin page (admin/columns_settings.pl), and confirm the behavior is correct (depends on what you have selected). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13492] Add location to the checkouts tables
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13492 --- Comment #2 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 34663 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34663action=edit Bug 13492: Add the column configuration for the checkouts table - morember.pl Test plan: 1/ Verify that you can show/hide columns on the checkouts table (moremember.pl). 2/ Play with the column configuration admin page (admin/columns_settings.pl), and confirm the behavior is correct (depends on what you have selected). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13492] Add location to the checkouts tables
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13492 --- Comment #3 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 34664 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34664action=edit Bug 13492: Add the location column to the checkouts tables Test plan: 1/ Verify that the location column is correctly displayed on the checkouts tables (circ/circulation.pl and members/moremember.pl). 2/ Verify that you can hide/show this column (using the admin page and/or the ColVis DT plugin). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13442] Facet links broken when collection code limit is used
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13442 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added CC||jonathan.dru...@biblibre.co ||m --- Comment #4 from Jonathan Druart jonathan.dru...@biblibre.com --- Does this work if the facet contain a simple quote? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677 Paola Rossi paola.ro...@cineca.it changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #44 from Paola Rossi paola.ro...@cineca.it --- I've applied the patches against master 3.19.00.002 The first patch requires: prove t/db_dependent/Serials_2.t t/db_dependent/Serials_2.t .. Global symbol $subscriptionid requires explicit package name at t/db_dependent/Serials_2.t line 208. Global symbol $subscriptionid requires explicit package name at t/db_dependent/Serials_2.t line 209. Global symbol $subscriptionid requires explicit package name at t/db_dependent/Serials_2.t line 210. Global symbol $subscriptionid requires explicit package name at t/db_dependent/Serials_2.t line 212. Global symbol $subscriptionid requires explicit package name at t/db_dependent/Serials_2.t line 213. Global symbol $subscriptionid requires explicit package name at t/db_dependent/Serials_2.t line 214. Global symbol $subscriptionid requires explicit package name at t/db_dependent/Serials_2.t line 215. Execution of t/db_dependent/Serials_2.t aborted due to compilation errors. # Looks like your test exited with 255 before it could output anything. t/db_dependent/Serials_2.t .. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 36/36 subtests Test Summary Report --- t/db_dependent/Serials_2.t (Wstat: 65280 Tests: 0 Failed: 0) Non-zero exit status: 255 Parse errors: Bad plan. You planned 36 tests but ran 0. Files=1, Tests=0, 1 wallclock secs ( 0.00 usr 0.01 sys + 0.72 cusr 0.05 csys = 0.78 CPU) Result: FAIL I pass the patch to Failed QA status. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9580] Cover image from Coce, a remote image URL cache
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9580 --- Comment #60 from Jonathan Druart jonathan.dru...@biblibre.com --- I tried to host the webservice, and it worked until I got this error: % node webservice.js /home/koha/tools/coce/node_modules/aws-lib/lib/aws.js:78 if (err) throw err; ^ Error: metadata API response undefined at ClientRequest.anonymous (/home/koha/tools/coce/node_modules/aws-lib/lib/aws.js:37:49) at ClientRequest.g (events.js:180:16) at ClientRequest.emit (events.js:92:17) at Socket.emitTimeout (http.js:1797:10) at Socket.g (events.js:180:16) at Socket.emit (events.js:92:17) at Socket._onTimeout (net.js:326:8) at Timer.unrefTimeout [as ontimeout] (timers.js:418:13) Did you already get it? Could you please provide a followup for the [% USE Koha %]? I think you need to move it, not to remove it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13040] Improve exporter to allow multiple branch selections
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13040 Paola Rossi paola.ro...@cineca.it changed: What|Removed |Added Status|Failed QA |Patch doesn't apply --- Comment #6 from Paola Rossi paola.ro...@cineca.it --- I've tried to apply the patch against master 3.19.00.002 Applying: Bug 13040 - multiple branch selections in exporter Using index info to reconstruct a base tree... stdin:28: new blank line at EOF. + warning: 1 line adds whitespace errors. Falling back to patching base and 3-way merge... Auto-merging tools/export.pl Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/tools/export.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css Failed to merge in the changes. Patch failed at 0001 Bug 13040 - multiple branch selections in exporter I pass the patch to Patch doesn't apply status. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677 --- Comment #45 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 34665 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34665action=edit Bug 7677: Fix tests They don't pass since bug 12098 has been pushed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7677] New area in subscriptions and new function when receiving
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7677 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Paola Rossi paola.ro...@cineca.it changed: What|Removed |Added Status|Failed QA |Patch doesn't apply --- Comment #93 from Paola Rossi paola.ro...@cineca.it --- I've tried to apply the patch against master 3.19.00.002 Applying: Bug 8367 - How long is a hold waiting for pickup at a more granular level Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging t/db_dependent/Holds.t Auto-merging svc/holds Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/circ/waitingreserves.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/circ/waitingreserves.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref Auto-merging koha-tmpl/intranet-tmpl/prog/en/js/holds.js Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Auto-merging installer/data/mysql/sysprefs.sql Auto-merging installer/data/mysql/kohastructure.sql Auto-merging circ/waitingreserves.pl Auto-merging C4/Reserves.pm Auto-merging C4/Letters.pm Failed to merge in the changes. Patch failed at 0001 Bug 8367 - How long is a hold waiting for pickup at a more granular level So I pass the patch to Patch doesn't apply status. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13458] Add new patron shows default / hardcoded patron categories after search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13458 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #1 from Katrin Fischer katrin.fisc...@bsz-bw.de --- We can confirm this bug still appears in 3.18.2. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
