[Koha-bugs] [Bug 13425] There is an xss vulnerability in 3.16, 3.18 and master in the opac and intranet facets
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13425 Chris Cormack changed: What|Removed |Added Group|Koha security | Component|Koha|Searching Version|unspecified |3.18 Product|Koha security |Koha QA Contact||testo...@bugs.koha-communit ||y.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13493] More enduser-friendly Koha version on About Koha page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13493 Chris Cormack changed: What|Removed |Added Status|NEW |RESOLVED CC||ch...@bigballofwax.co.nz Resolution|--- |INVALID -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13264] Test about UTF-8 (bug 11944)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264 --- Comment #44 from Tomás Cohen Arazi --- Created attachment 34694 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34694&action=edit Bug 13264: (QA followup) prevent double-encoding on the tests Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11431] Add additional sound options for warnings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #54 from Nick Clemens --- Still can't test, after applying 13019 and 11431 OPAC functions but I cannot access any pages in staff client, I only get the error below: Software error: Template process failed: undef error - hash- or arrayref expected (not a simple scalar, use allow_nonref to allow this) at /home/nick/kohaclone/Koha/Template/Plugin/Koha.pm line 52. For help, please send mail to the webmaster ([no address given]), giving this error message and the time and date of the error. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11431] Add additional sound options for warnings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Nick Clemens changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff --- Comment #53 from Nick Clemens --- forgot the depends -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11431] Add additional sound options for warnings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 Nick Clemens changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply --- Comment #52 from Nick Clemens --- Applying: Bug 11431 [4] - Add additional sound options fatal: sha1 information is lacking or useless (Koha/Object.pm). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 11431 [4] - Add additional sound options When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-11431-4---Add-additional-sound-options-7v_z2F.patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12895] Dropbox mode doesn't work correctly
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12895 Nick Clemens changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12895] Dropbox mode doesn't work correctly
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12895 Nick Clemens changed: What|Removed |Added Attachment #34137|0 |1 is obsolete|| --- Comment #9 from Nick Clemens --- Created attachment 34693 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34693&action=edit [SIGNED OFF]Bug 12895 repair dropbox mode One day late patrons were restricted even with dropbox mode activated Signed-off-by: Nick Clemens -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12428] "OPAC info" is not displayed in the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12428 Nick Clemens changed: What|Removed |Added Attachment #34094|0 |1 is obsolete|| --- Comment #14 from Nick Clemens --- Created attachment 34692 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34692&action=edit [SIGNED OFF]Bug 12428 [3.16.x] "OPAC info" is not displayed in the OPAC This patch changes the footer include, adding an alias for the jQueryUI tooltip function to prevent conflict with Bootstrap's function of the same name. To test, you must have at least two libraries configured with "OPAC info" for display in the OPAC. Modify the holdings of a title so that there is at least one item which has different holding and home branches matching your library configured above. View the detail page for that record. Hovering your cursor over the library name in the "Location" column should display the branch information you configured for that library in a tooltip. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12428] "OPAC info" is not displayed in the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12428 Nick Clemens changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13167] Stage MARC for Import hangs for biblio containing valid 979* ISBN-13
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13167 Nick Clemens changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||n...@quecheelibrary.org --- Comment #10 from Nick Clemens --- Marking as signed off, it looks like that was Colin's intention -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12823] Add some hints for Host, Database and SRU search fields mappings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12823 Nick Clemens changed: What|Removed |Added Attachment #33982|0 |1 is obsolete|| --- Comment #15 from Nick Clemens --- Created attachment 34691 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34691&action=edit [SIGNED OFF] Bug 12823: Alert about defining the SRU search field mappings This is a follow-up for report 6536 (SRU search targets). It will alert a user that saves a SRU server without field mappings. Test plan: Add a Z39.50 server. No confirm message. Add a SRU server without field mappings. Cancel the confirm. Add one field mapping. No confirm message. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12823] Add some hints for Host, Database and SRU search fields mappings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12823 Nick Clemens changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12823] Add some hints for Host, Database and SRU search fields mappings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12823 Nick Clemens changed: What|Removed |Added Attachment #33981|0 |1 is obsolete|| --- Comment #14 from Nick Clemens --- Created attachment 34690 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34690&action=edit [SIGNED OFF] Bug 12823: Add some hints for Host and Database When adding or editing a SRU server, this patch adds a hint, positioned under the Hostname field. It also moves similar information for SRU options and XSLT into hints. Test plan: Add/Edit SRU server. Look at Hostname, SRU options and XSLT. Add/Edit Z39.50 server. No hints for Hostname and SRU options. Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8909] MARC21 240$a (Uniform title) is not a URL
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8909 Nick Clemens changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8909] MARC21 240$a (Uniform title) is not a URL
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8909 Nick Clemens changed: What|Removed |Added Attachment #34025|0 |1 is obsolete|| --- Comment #3 from Nick Clemens --- Created attachment 34689 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34689&action=edit [SIGNED OFF]Bug 8909: MARC21 240$a (Uniform title) is not a URL Patch removes the 'isUrl' attribute from all 240$a fields in the various frameworks. The change removes the broken link from the staff detail MARC tab view. Changes are a little easier to spot with: git diff --color-words HEAD^ To test: - Load some or all of the frameworks - Verify that 240$a is no longer marked as being an URL Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13493] More enduser-friendly Koha version on About Koha page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13493 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #1 from Katrin Fischer --- Hi, actually 3.17.00.008 is a development version and not a 3.18.2. The about page will show 3.18.02 once the demo has been updated. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13493] New: More enduser-friendly Koha version on About Koha page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13493 Bug ID: 13493 Summary: More enduser-friendly Koha version on About Koha page Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: About Assignee: neng...@gmail.com Reporter: bibli...@gmail.com QA Contact: testo...@bugs.koha-community.org As of Dec 26, 2014, the About Koha page for the ByWater Solutions demo returns 3.17.00.008 for the Koha version. I assume this is 3.18.2, but I'm not sure. I would suggest either a parenthetical reference to the more commonly referenced release number, or an additional line with the same information. Thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11607] items.content does not contain any formatting when HTML message is selected.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11607 Chris Cormack changed: What|Removed |Added Attachment #34677|0 |1 is obsolete|| --- Comment #3 from Chris Cormack --- Created attachment 34688 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34688&action=edit Bug 11607: Don't display all items in a single line If the *DGST notices are sent in HTML, the items are displayed in a single line. To reproduce: 1/ Define a *DGST notice using the <> pattern. 2/ Checkout at least 2 items to a patron and set the due date as today. 3/ Launch the advance_notices.pl and process_message_queue.pl cronjobs. 4/ Verify the email you will receive separates the items with a line break. Verify you don't find a regression for non-html letters. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11607] items.content does not contain any formatting when HTML message is selected.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11607 Chris Cormack changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13270] On receiving, "vendor note" label should not be displayed if nothing to display
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13270 Chris Cormack changed: What|Removed |Added Attachment #33618|0 |1 is obsolete|| --- Comment #2 from Chris Cormack --- Created attachment 34687 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34687&action=edit Bug 13270: Don't display "vendor note" label if nothing to display Bug 12111 removes the vendor note edition on receiving. The label should not be displayed when it's empty. Test plan: 1/ Receive an order without a vendor note and verify that the label is not displayed. 2/ Receive an order with a vendor note and verify that the note is displayed. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13270] On receiving, "vendor note" label should not be displayed if nothing to display
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13270 Chris Cormack changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13319] On inserting an order, the parent_ordernumber attribute is not set to the object
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13319 Chris Cormack changed: What|Removed |Added Attachment #33775|0 |1 is obsolete|| --- Comment #2 from Chris Cormack --- Created attachment 34686 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34686&action=edit Bug 13319: Fix Koha::Acq::Order should set parent_ordernumber The tests highligh the problem: if the parent_ordernumber attribute is not set on inserting an order, the object returned by the method does not contain the value (undef). Test plan: Verify the tests are consistent and prove t/db_dependent/Acquisition/CancelReceipt.t should return green. You can also verify that receive partially an order and cancel the receipt work as expected. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13319] On inserting an order, the parent_ordernumber attribute is not set to the object
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13319 Chris Cormack changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13487] DataTables pagination needs some fixes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13487 Chris Cormack changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13487] DataTables pagination needs some fixes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13487 Chris Cormack changed: What|Removed |Added Attachment #34628|0 |1 is obsolete|| --- Comment #8 from Chris Cormack --- Created attachment 34685 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34685&action=edit Bug 13487: Fix pagination for the item search Test plan: Go on the catalogue/itemsearch.pl page and verify that the pagination button (First, Prev, PAGES, Next, Last) is now correctly styled. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13487] DataTables pagination needs some fixes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13487 Chris Cormack changed: What|Removed |Added Attachment #34627|0 |1 is obsolete|| --- Comment #7 from Chris Cormack --- Created attachment 34684 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34684&action=edit Bug 13487: Fix pagination for basketgroup Test plan: Go on the acqui/basketgroup.pl page and verify that the pagination button (First, Prev, Next, Last) is now correctly styled. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13487] DataTables pagination needs some fixes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13487 Chris Cormack changed: What|Removed |Added Attachment #34626|0 |1 is obsolete|| --- Comment #6 from Chris Cormack --- Created attachment 34683 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34683&action=edit Bug 13487: DT pagination contains '...' for the full_numbers form Since the DT upgrade (bug 12986), the full_numbers pagination adds a span (containing '...'). It is not managed by the css file and is put at the end of the page numbers ( "1 2 3 4 5 20 NEXT LAST ...", we expect "1 2 3 4 5 ... 20 NEXT LAST"). Test plan: 1/ Go on the member search and launch a search which will return more than 7 pages 2/ Without this patch, the '...' span is put at the end of the pagination bar. 3/ With the patch it should be better placed. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13458] Add new patron shows default / hardcoded patron categories after search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13458 Chris Cormack changed: What|Removed |Added Attachment #34680|0 |1 is obsolete|| --- Comment #3 from Chris Cormack --- Created attachment 34682 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34682&action=edit Bug 13458: Display the correct patron categories Bug 9811 removes useful code. Actually the AddPatronLists pref is not sent to the template from members/member.pl. To fix this issue, we can use the existing not clean way, or compare the syspref value directly in the template. This second solution is implemented in this patch. Test plan: 1/ Set the AddPatronLists pref to 'specific' 2/ On the patron home page (members/members-home/pl), the patron search result page (members/member.pl after launching a search) and on the checkouts page/patron search result (circ/circulation.pl after searching a patron using the check out), verify that the patron category list is the specific ones. 3/ Test there are no regression with the AddPatronLists pref set to 'general'. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13458] Add new patron shows default / hardcoded patron categories after search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13458 Chris Cormack changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13264] Test about UTF-8 (bug 11944)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264 --- Comment #43 from Jonathan Druart --- Zeno, could you confirm/infirm that my new tests pass for you? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13068] New feature for DB update and sandbox
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068
--- Comment #55 from Jonathan Druart ---
Marcel, all looks good to me but I have few questions:
1/ Could you please detail when the RESET mode should be used?
2/ ExecDBRev takes 5 parameters, but you use only 3, the idea is to call this
routine for each db rev in updatedatabase.pl?
3/ What means the $rv flag?
4/ Don't you think we should move the 2 files to skip into another directory
(and use this one exclusively for this use)?
5/
9691 $rv = 1 if !$! && !$@; #apparently, the file does not end with
1;
I tested with a file without 1; and I don't get any error.
6/ From http://perldoc.perl.org/functions/do.html, it seems that
9690 print "ERROR: $!\n" if $!;
should be
9690 print "ERROR: $!\n" if $! and not $@;
7/ In TRACK mode, given the following file:
1 use Modern::Perl;
2 use C4::Context;
3 my $dbh = C4::Context->dbh;
4 $dbh->do("delete from foo");
I executed
perl installer/data/mysql/updatedatabase.pl
and I got
DBD::mysql::db do failed: Table 'koha.foo' doesn't exist at
/home/koha/src/installer/data/mysql/atomicupdate/test3.pl line 4.
Dev upgrade test3.pl done
The filename is appended to _localatomicupdates, it seems it should not, could
you confirm?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11944] Cleanup Koha UTF-8
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 --- Comment #256 from Tomás Cohen Arazi --- Guys, can u please take a look at the tests from 13264? It seems that the latest refactoring of the tests yield a situation where the tests don't pass. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937 --- Comment #49 from M. Tompsett --- (In reply to Jonathan Druart from comment #48) > There are occurrences of hideatopac in the code, maybe it's better than > hideinopac. Need to be confirmed by English native speaker. I can see how both might be used. The idea being that something is hidden at display time by OPAC vs. OPAC is being used an something is hidden in the output. Personally, hide in OPAC is clearer to Canadian, Anglophone me. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937
--- Comment #48 from Jonathan Druart ---
Comment on attachment 34667
--> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34667
[Signed-off] Bug 10947 - Grouped ItemTypes - Patch should apply properly on
latest master.
Review of attachment 34667:
-->
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=10937&attachment=34667)
-
Quick code review.
::: C4/Koha.pm
@@ +283,5 @@
> +The categories must be part of Authorized Values (DOCTYPECAT)
> +
> +=cut
> +
> +sub GetItemTypesCategorized {
Why don't you use C4::ItemType?
@@ +287,5 @@
> +sub GetItemTypesCategorized {
> +my $dbh = C4::Context->dbh;
> +# Order is important, so that partially hidden (some items are not
> visible in OPAC) search
> +# categories will be visible. hideinopac=0 must be last.
> +my $query = qq|
There are no string interpolation here, limit to q||
@@ +312,5 @@
> +
> +my %itemtypes;
> +while ( my $IT = $sth->fetchrow_hashref ) {
> +$itemtypes{ $IT->{'itemtype'} } = $IT;
> +}
useless while, have a look at selectall_hashref.
@@ +324,5 @@
> +Returns the itemtype code of all itemtypes included in a searchcategory.
> +
> +=cut
> +
> +sub GetItemTypesByCategory {
Why don't you use C4::ItemType?
@@ +334,5 @@
> +$sth->execute($category);
> +
> +while ( my $data = $sth->fetchrow ) {
> +push ( @results, $data );
> +}
useless while, have a look at selectall_arrayref
::: installer/data/mysql/kohastructure.sql
@@ +1276,4 @@
>checkinmsg VARCHAR(255), -- message that is displayed when an item with
> the given item type is checked in
>checkinmsgtype CHAR(16) DEFAULT 'message' NOT NULL, -- type (CSS class)
> for the checkinmsg, can be "alert" or "message"
>sip_media_type VARCHAR(3) DEFAULT NULL, -- SIP2 protocol media type for
> this itemtype
> + hideinopac tinyint(1) NOT NULL DEFAULT 0, -- Hide the item type from the
> search options in OPAC
There are occurrences of hideatopac in the code, maybe it's better than
hideinopac. Need to be confirmed by English native speaker.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Failed QA CC||jonathan.dru...@biblibre.co ||m --- Comment #47 from Jonathan Druart --- This patch needs a little bit more work to be readable by QAers. There is not decent commit message, please read http://wiki.koha-community.org/wiki/Commit_messages Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13357] Untranslatable strings on itemsearch.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13357 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #6 from Jonathan Druart --- Great improvement! All looks good. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13357] Untranslatable strings on itemsearch.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13357 Jonathan Druart changed: What|Removed |Added Attachment #34666|0 |1 is obsolete|| CC||jonathan.dru...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13357] Untranslatable strings on itemsearch.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13357 --- Comment #5 from Jonathan Druart --- Created attachment 34681 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34681&action=edit Bug 13357: Untranslatable strings on itemsearch.tt This patch enable translation of labels on itemsearch.tt To test: 1) Translate for a fairly complete language (es-ES de-DE) 2) On staff, go to Search > Item search 3) Check there are many untranslated strings e.g. Text before pulldowns on first and second box All options on third box 4) Apply the patch 5) Repeat 1 & 2 6) Check there are now some strings translated 7) Update translation file, check there are some new strings to translate (may be they are fuzzy) e.g. "All statuses", "All collection codes" Patch works as expected. Signed-off-by: Marc Véron Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Failed QA CC||jonathan.dru...@biblibre.co ||m --- Comment #15 from Jonathan Druart --- QA comment: I am quite confuse by this patch. IMO there are some inconsistencies: 1/ I don't understand the usefulness to pass by the template plugin to know if a borrower has overdues or not. 2/ Why did you move parse_letter to the pm file? A subroutine with the same name exists in advance_notices.pl cronjob script (which uses C4::Overdues too, so introduces a redefinion of it)? 3/ Same for C4::Members::GetOverdues, we already have a GetOverdues subroutine in C4::Overdues. 4/ Tests are missing for changes in packages. Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13458] Add new patron shows default / hardcoded patron categories after search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13458 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@biblibre.co ||m Version|3.18|master Depends on||9811 Assignee|koha-b...@lists.koha-commun |jonathan.dru...@biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9811] Patrons search improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811 Jonathan Druart changed: What|Removed |Added Blocks||13458 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13458] Add new patron shows default / hardcoded patron categories after search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13458 --- Comment #2 from Jonathan Druart --- Created attachment 34680 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34680&action=edit Bug 13458: Display the correct patron categories Bug 9811 removes useful code. Actually the AddPatronLists pref is not sent to the template from members/member.pl. To fix this issue, we can use the existing not clean way, or compare the syspref value directly in the template. This second solution is implemented in this patch. Test plan: 1/ Set the AddPatronLists pref to 'specific' 2/ On the patron home page (members/members-home/pl), the patron search result page (members/member.pl after launching a search) and on the checkouts page/patron search result (circ/circulation.pl after searching a patron using the check out), verify that the patron category list is the specific ones. 3/ Test there are no regression with the AddPatronLists pref set to 'general'. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13458] Add new patron shows default / hardcoded patron categories after search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13458 Jonathan Druart changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13408] Tell librarians they may continue scanning while checkouts table is loading
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13408 Jonathan Druart changed: What|Removed |Added Assignee|k...@bywatersolutions.com |jonathan.dru...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937 Katrin Fischer changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937 --- Comment #46 from Katrin Fischer --- I am not sure if the change to the schema files is mandatory yet, but if you do it, please put it in a separate patch to avoid conflicts. http://wiki.koha-community.org/wiki/Database_updates -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12053] Borrower attributes not visible anymore at OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12053 Jonathan Druart changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #2 from Jonathan Druart --- Frido confirmed me that it's not a bug. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9580] Cover image from Coce, a remote image URL cache
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9580 Jonathan Druart changed: What|Removed |Added Severity|enhancement |new feature -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9580] Cover image from Coce, a remote image URL cache
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9580 --- Comment #64 from Jonathan Druart --- (In reply to Frédéric Demians from comment #62) > (In reply to Jonathan Druart from comment #60) > > I tried to host the webservice, and it worked until I got this error: > > > > % node webservice.js > > > > /home/koha/tools/coce/node_modules/aws-lib/lib/aws.js:78 > > if (err) throw err; > > ^ > > Error: metadata API response undefined > > at ClientRequest. > > (/home/koha/tools/coce/node_modules/aws-lib/lib/aws.js:37:49) > > at ClientRequest.g (events.js:180:16) > > at ClientRequest.emit (events.js:92:17) > > at Socket.emitTimeout (http.js:1797:10) > > at Socket.g (events.js:180:16) > > at Socket.emit (events.js:92:17) > > at Socket._onTimeout (net.js:326:8) > > at Timer.unrefTimeout [as ontimeout] (timers.js:418:13) > > > > Did you already get it? > > No. To track down this bug, it is required to have the ISBN/EAN which is > sent to AWS. I got it again, but it's completely random (I have got it with the same url I use). I don't know where it can come from. However, it's the only problem I got, the code is clean and all works great. Nice feature! Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9580] Cover image from Coce, a remote image URL cache
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9580 Jonathan Druart changed: What|Removed |Added Attachment #34678|0 |1 is obsolete|| --- Comment #63 from Jonathan Druart --- Created attachment 34679 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34679&action=edit Bug 9580 Cover images from Coce, a remote image URL cache Add to Koha support for displaying Book cover requested to Coce, a remote image URL cache: https://github.com/fredericd/coce With this enhancement, cover images are not fetched directly from Amazon, Google, and so on. Their URL are requested via a web service to Coce which manages a cache of URLs. Three cover image providers are now available: Google Books (gb), Amazon (aws), and Open Library (ol). Two system preferences enable this service: - CoceHost - URL of Coce server - CoceProviders - Ordered list of requested providers. For example gb,aws,ol, will return the first available URL from those providers. Several advantages to this architecture: - If a book cover is not available from a provider, but is available from another one, Koha will be able to display a book cover, which isn't the case now - Since URLs are cached, it isn't necessary for each book cover to request, again and again, the provider, and several of them if necessary. - Amazon book covers are retrieved with Amazon Product Advertising API, which means that more covers are retrieved (ISBN13). Test plan: - Apply this patch, and test with 'Bootstrap' themes - You can verify that nothing has changed on OPAC result and detail page, since new syspref haven't been filled - Install Code: https://github.com/fredericd/coce Or ask me directly for the URL of a Coce server - In sysprefs, tab Enhanced content, modify: CoceHost -- enter the URL of your Coce server CoceProviders -- fill with: gb,aws,ol - Do a search. On result page, and detail page, you will see cover images originating from the 3 providers: fly over the image to see its URL. Try to compare with a Koha with just GoogleJacket or Amazon cover to confirm that you have more images. Verify that it's quick, and even quicker for cached images URLs. - Check that Browse Shelf functionnality works properly. - The ID sent to Coce is EAN or ISBN. Try with various type of biblios. DVD have often EAN, but no ISBN. - You can try with those sysprefs: CoceProviders: aws,gb CoceHost: http://coce.tamil.fr:8080 and this EAN (or ISBN): 297517744 => OPACAmazonCoverImages enabled doesn't display a cover because, it's a DVD => Coce find and display the DVD cover. Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart Amended patch: replaced 1 tab with spaces in C4/Shelfbrowser.pm -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9580] Cover image from Coce, a remote image URL cache
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9580 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
