[Koha-bugs] [Bug 13407] Remove methods which are included in the 0.36 release of PDF::Reuse

2014-12-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13407

--- Comment #16 from Robin Sheat  ---
(In reply to Robin Sheat from comment #15)
> Not yet, it'll happen very soon. Hopefully today. I'm lining it up for
> inclusion in Debian at the same time, and so it takes a little longer to
> make sure I get it right.

And, done. Hopefully it'll be accepted for debian with no more changes too.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13407] Remove methods which are included in the 0.36 release of PDF::Reuse

2014-12-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13407

--- Comment #15 from Robin Sheat  ---
Not yet, it'll happen very soon. Hopefully today. I'm lining it up for
inclusion in Debian at the same time, and so it takes a little longer to make
sure I get it right.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13496] Wrong Koha version on installer title

2014-12-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13496

Tomás Cohen Arazi  changed:

   What|Removed |Added

   Assignee|oleon...@myacpl.org |tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13496] Wrong Koha version on installer title

2014-12-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13496

--- Comment #2 from Tomás Cohen Arazi  ---
Created attachment 34778
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34778&action=edit
Bug 13496: make auth.tt use a template plugin to get the Koha version

This patch makes the installer login template use the new Koha.Version
template plugin to get the correct Koha version. This way we don't need
to maintain the auth.tt file on each version change, and are sure screen
readers tell the correct version.

To test:
- Create a situation where the login screen from the installer shows
- Navigate the HTML code (Ctrl+u)
=> FAIL: "Koha 3.0 Installer" shows on the HTML code
- Apply the patch
- Reload the page
=> SUCCESS: The correct version number is shown.
- Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13496] Wrong Koha version on installer title

2014-12-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13496

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13496] Wrong Koha version on installer title

2014-12-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13496

--- Comment #1 from Tomás Cohen Arazi  ---
Created attachment 34777
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34777&action=edit
Bug 13496: add a method for the templates to print Koha version as desired

This patch introduces a simple template plugin function that returns
the Koha version number in different suitable formats.

It introduces unit tests for the new function. They are run with

To test:
- Apply the patch
- Run
  $ prove t/Koha_Template_Plugin_Koha.t
=> SUCCESS: the tests pass.
- Sign off :-D

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13496] New: Wrong Koha version on installer title

2014-12-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13496

Bug ID: 13496
   Summary: Wrong Koha version on installer title
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: tomasco...@gmail.com
QA Contact: testo...@bugs.koha-community.org

Steps to reproduce:

- Launch the webinstaller (I deleted my DB to do it)
- The login screen shows
=> FAIL: "Koha 3.0 Installer" is hidden inside the code. It seems to be
intended for screen readers to tell it (I cannot test that feature) but I think
it is showing the wrong version, and it shouldn't.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8848] 'make test' fails on Barcodes_ValueBuilder.t (upgrading from 3.08.04)

2014-12-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8848

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 CC||tomasco...@gmail.com
 Resolution|--- |WORKSFORME

--- Comment #1 from Tomás Cohen Arazi  ---
Missing dependency.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13252] SIP2 server should accept IPv6 connections

2014-12-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13252

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #15 from Tomás Cohen Arazi  ---
Patch pushed to master.

Thanks Benjamin, and congratulations for your first patch pushed!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13341] Hard-coded "Preview" text in OPAC openlibrary.js

2014-12-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13341

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||tomasco...@gmail.com

--- Comment #4 from Tomás Cohen Arazi  ---
Patch pushed to master.

Thanks Owen!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13447] runreport.pl html email fails

2014-12-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13447

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||tomasco...@gmail.com

--- Comment #5 from Tomás Cohen Arazi  ---
Patch pushed to master.

Thanks Martin!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12895] Dropbox mode doesn't work correctly

2014-12-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12895

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||tomasco...@gmail.com

--- Comment #12 from Tomás Cohen Arazi  ---
Patch pushed to master.

Thanks Koha Team Lyon 3!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13458] Add new patron shows default / hardcoded patron categories after search

2014-12-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13458

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||tomasco...@gmail.com

--- Comment #5 from Tomás Cohen Arazi  ---
Patch pushed to master.

Thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9958] RoutingSerials description misleading

2014-12-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9958

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #7 from Tomás Cohen Arazi  ---
Patch pushed to master.

Thanks Katrina!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13285] updatedatabase throws an error if opacthemes is not set

2014-12-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13285

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||tomasco...@gmail.com

--- Comment #6 from Tomás Cohen Arazi  ---
Patch pushed to master.

Good catch Colin!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13252] SIP2 server should accept IPv6 connections

2014-12-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13252

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com
   Severity|minor   |enhancement

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13407] Remove methods which are included in the 0.36 release of PDF::Reuse

2014-12-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13407

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||ro...@catalyst.net.nz,
   ||tomasco...@gmail.com

--- Comment #14 from Tomás Cohen Arazi  ---
I expect to have the .deb file on the squeeze-dev pocket for pushing, otherwise
we should feed the jenkins nodes by hand using CPAN. Robin?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9958] RoutingSerials description misleading

2014-12-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9958

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com
Summary|RoutingSerials desription   |RoutingSerials description
   |misleading  |misleading

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13124] Record titles with parentheses causing label weirdness

2014-12-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13124

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||tomasco...@gmail.com

--- Comment #15 from Tomás Cohen Arazi  ---
Patch pushed to master.

Thanks Kyle!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13357] Untranslatable strings on itemsearch.tt

2014-12-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13357

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||tomasco...@gmail.com

--- Comment #7 from Tomás Cohen Arazi  ---
Patch pushed to master.

Thanks Bernardo!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13360] C4::Ris considers that hashes are ordered

2014-12-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13360

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||tomasco...@gmail.com

--- Comment #4 from Tomás Cohen Arazi  ---
Patch pushed to master.

Thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13453] Koha.t daily quote tests assume sample data

2014-12-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13453

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||tomasco...@gmail.com

--- Comment #4 from Tomás Cohen Arazi  ---
Patch pushed to master.

Thanks Mark!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 1861] Unique patrons logins not (totally) enforced

2014-12-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1861

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Pushed by Module Maintainer |Pushed to Master
 CC||tomasco...@gmail.com

--- Comment #24 from Tomás Cohen Arazi  ---
Patches pushed to master.

Thanks Kyle!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11982] Show local cover images in the biblio details page in the intranet.

2014-12-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11982

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Patch doesn't apply
 CC||tomasco...@gmail.com

--- Comment #20 from Tomás Cohen Arazi  ---
Hi, it seems some rebasing is needed. Will be watghing this one to push it
ASAP.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13264] Test about UTF-8 (bug 11944)

2014-12-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264

--- Comment #57 from Zeno Tajoli  ---
To correct the problem of comment #45 I duplicate the records in the files  
data/mar21utf8record.mrc
data/unimarcutf8reco.mrc

So the server shows always the 'Many records' display.

In auth_values_input_www.t I added also test for chars utf-8/latin-1 like
'tòmas'.

To test:
prove search_utf8.t
prove auth_values_input_www.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13264] Test about UTF-8 (bug 11944)

2014-12-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264

Zeno Tajoli  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13264] Test about UTF-8 (bug 11944)

2014-12-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264

--- Comment #56 from Zeno Tajoli  ---
Created attachment 34776
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34776&action=edit
Add a test for Auth values to check chars that could be utf-8 or latin-1

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13264] Test about UTF-8 (bug 11944)

2014-12-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264

--- Comment #55 from Zeno Tajoli  ---
Created attachment 34775
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34775&action=edit
Duplicate record in marc21 and unimarc files to show more than one result

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13264] Test about UTF-8 (bug 11944)

2014-12-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264

Zeno Tajoli  changed:

   What|Removed |Added

  Attachment #34694|0   |1
is obsolete||

--- Comment #54 from Zeno Tajoli  ---
Created attachment 34774
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34774&action=edit
QA followup - prevent double-encoding on the tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13264] Test about UTF-8 (bug 11944)

2014-12-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264

Zeno Tajoli  changed:

   What|Removed |Added

  Attachment #34117|0   |1
is obsolete||

--- Comment #53 from Zeno Tajoli  ---
Created attachment 34773
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34773&action=edit
Refactor search utf8 tests and add some more

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13264] Test about UTF-8 (bug 11944)

2014-12-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264

Zeno Tajoli  changed:

   What|Removed |Added

  Attachment #34116|0   |1
is obsolete||

--- Comment #52 from Zeno Tajoli  ---
Created attachment 34772
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34772&action=edit
Additional test for search in intranet calatogue

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13264] Test about UTF-8 (bug 11944)

2014-12-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264

Zeno Tajoli  changed:

   What|Removed |Added

  Attachment #34115|0   |1
is obsolete||

--- Comment #51 from Zeno Tajoli  ---
Created attachment 34771
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34771&action=edit
Follow up: in opac_utf8.t insert also delete of biblio

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13264] Test about UTF-8 (bug 11944)

2014-12-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264

Zeno Tajoli  changed:

   What|Removed |Added

  Attachment #34114|0   |1
is obsolete||

--- Comment #50 from Zeno Tajoli  ---
Created attachment 34770
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34770&action=edit
Make opac_utf8.t launch its own helper processes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13264] Test about UTF-8 (bug 11944)

2014-12-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264

Zeno Tajoli  changed:

   What|Removed |Added

  Attachment #34113|0   |1
is obsolete||

--- Comment #49 from Zeno Tajoli  ---
Created attachment 34769
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34769&action=edit
no need to test for MySQL

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13264] Test about UTF-8 (bug 11944)

2014-12-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264

Zeno Tajoli  changed:

   What|Removed |Added

  Attachment #34112|0   |1
is obsolete||

--- Comment #48 from Zeno Tajoli  ---
Created attachment 34768
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34768&action=edit
Test for utf-8 on authorised values input/display/delete

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13264] Test about UTF-8 (bug 11944)

2014-12-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264

Zeno Tajoli  changed:

   What|Removed |Added

  Attachment #34111|0   |1
is obsolete||

--- Comment #47 from Zeno Tajoli  ---
Created attachment 34767
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34767&action=edit
Test for utf-8 on Opac search

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13264] Test about UTF-8 (bug 11944)

2014-12-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264

Zeno Tajoli  changed:

   What|Removed |Added

  Attachment #34110|0   |1
is obsolete||

--- Comment #46 from Zeno Tajoli  ---
Created attachment 34766
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34766&action=edit
UNIMARC and MARC21 records to test UTF-8

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13471] When editing a subscription, the "subscription length type" disregards the stored value, also make SLT translateable.

2014-12-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13471

Aleisha Amohia  changed:

   What|Removed |Added

  Attachment #34661|0   |1
is obsolete||

--- Comment #5 from Aleisha Amohia  ---
Created attachment 34765
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34765&action=edit
Bug 13471 - When editing a subscription, the "subscription length type"
disregards the stored value, also make SLT translateable.

This issue causes loss of data when the subscription length type (SLT) is other
than issues.

TO REPLICATE:

We make an subscription with SLT of months = 12.
Later make an arbitrary edit to the subscription, and miss out the fact that
the SLT selection is set to issues.
Save the changes.
Serial subscription end date is set to 12 issues since the start date, instead
of 12 months which it used to be.
This causes a myriad of issues :=)

AFTER THIS PATCH:

SLT defaults to the value initially saved instead of always being issues.
Now the selection can be translated!

HOTFIX 1: Added  elements to showSubscriptionLengthType.inc so the
translation tool can catch them.

HOTFIX 2: Fixed serials/showpredictionpattern.pl to use the db columns instead
of issues,weeks,months.

HOTFIX 3: Fixed serials/subscription-numberpatterns.pl to use the db columns
instead of issues,weeks,months.

Signed-off-by: Aleisha 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13471] When editing a subscription, the "subscription length type" disregards the stored value, also make SLT translateable.

2014-12-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13471

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13450] Title and breadcrumb of Patron form can look weird in translations

2014-12-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13450

--- Comment #10 from Marc Véron  ---
No problem,I think the whole code is rather complicated. Please have a look at
the proposition in my 2nd screenshot:

The idea is to have both Category TYPE and category NAME, something like

Modify patron Hansli Testmann (Child:Juvenile)
([TYPE]:[NAME])

If you think this would be OK I will provide a new patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13450] Title and breadcrumb of Patron form can look weird in translations

2014-12-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13450

--- Comment #9 from Katrin Fischer  ---
That's not what I saw - I will have to go back and retest, but right now not
sure where I went wrong :(

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13450] Title and breadcrumb of Patron form can look weird in translations

2014-12-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13450

--- Comment #8 from Marc Véron  ---
Created attachment 34764
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34764&action=edit
How it looks after patch (use "Edit" below Date of birth) and proposition how
it should be for all kinds of editing (from toolbar or from links on page)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13450] Title and breadcrumb of Patron form can look weird in translations

2014-12-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13450

--- Comment #7 from Marc Véron  ---
Created attachment 34763
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34763&action=edit
How it works now: Different Edit buttons show different titels / bradcrumbs for
same patron

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13450] Title and breadcrumb of Patron form can look weird in translations

2014-12-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13450

--- Comment #6 from Katrin Fischer  ---
I checked the 'edit' in the toolbar and 'duplicate'

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13450] Title and breadcrumb of Patron form can look weird in translations

2014-12-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13450

--- Comment #5 from Marc Véron  ---
Hi Katrin,

Did you test with the "Edit" links on the page, e.g. below "Date of birth" or
"Library use"?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13264] Test about UTF-8 (bug 11944)

2014-12-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13264

Zeno Tajoli  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #45 from Zeno Tajoli  ---
Hi,

in fact for there are problems with new format in search_utf8.t, not in
auth_values_input_www.t.
The problems:

/t/db_dependent/www$ prove search_utf8.t 
search_utf8.t .. 19/32 
#   Failed test 'Base is like
"(?^u:search.pl\?idx=kw&q=%CE%91%CE%B8%CE%AE%CE%BD%CE%B1)"'
#   at search_utf8.t line 218.
#  got: "http://192.168.216.128:8080/cgi-bin/koha/catalogue";...
#   length: 75
# doesn't match '(?^u:search.pl\?idx=kw&q=%CE%91%CE%B8%CE%AE%CE%BD%CE%B1)'
search_utf8.t .. 26/32 
#   Failed test 'Base is like
"(?^u:opac-search.pl\?idx=&q=%CE%91%CE%B8%CE%AE%CE%BD%CE%B1)"'
#   at search_utf8.t line 241.
#  got: "http://192.168.216.128/cgi-bin/koha/opac-detail.pl";...
#   length: 65
# doesn't match
'(?^u:opac-search.pl\?idx=&q=%CE%91%CE%B8%CE%AE%CE%BD%CE%B1)'
search_utf8.t .. 32/32 # Looks like you failed 2 tests of 32.
search_utf8.t .. Dubious, test returned 2 (wstat 512, 0x200)
Failed 2/32 subtests 

Motivation: I use a MySQL db completly clear, so when I start test at test 19 I
have only 1 record into db and zebra (zebra records are coming fromm db).
So the search finds 1 result and it display a FULL RECORD display, not a MANY
RESULTS display.

The full record display has a url base DIFFERENT from a many result display.
The test 19 wants a base as a MANY RESULTS display.

In fact if test 2-3 times WITHOUT purge (because you stop the debug) you have
two o more time the same test record uploaded in to db and so the search gives
you a MANY RESULTS display.

So the first question is: WHERE we want to testt the display of utf-8 chars ?
In the  FULL RECORD display or in the  MANY RESULTS display ?

My original code was on testing uft-8 chars into FULL RECORD display but we can
change anch test on MANY RESULTS display.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13017] Login page image replacement technique fails when browser width exceeds 2000 pixels

2014-12-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13017

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||tomasco...@gmail.com

--- Comment #6 from Tomás Cohen Arazi  ---
Patch pushed to master.

Thanks Owen!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13346] The type of the OpacExportOptions pref should be multiple

2014-12-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13346

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #3 from Katrin Fischer  ---
The new list is much nicer, but it adds a small regression - you can no longer
change the sequence the options are displayed in. I think if someone really
wanted to, they can do so via SQL, so probably not worth holding this up.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13477] On order detail not showing

2014-12-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13477

Katrin Fischer  changed:

   What|Removed |Added

 Resolution|FIXED   |INVALID

--- Comment #10 from Katrin Fischer  ---
Thx for the feedback Iming, glad it could be resolved.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13477] On order detail not showing

2014-12-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13477

Iming Chan  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13477] On order detail not showing

2014-12-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13477

--- Comment #9 from Iming Chan  ---
(In reply to Katrin Fischer from comment #6)
> Created attachment 34733 [details]
> OPAC: acq information display with AcqCreateItem != on order
> 
> I retested on master and the information displays. Note: the quantity must
> be >1 and AcqCreateItem not set to 'on order'.

Problem solved!  After I changed AcqCreateItem from "on order" to "receive
order", order information now displayed in OPAC.  Therefore, I have marked this
issued resolved.  Thanks for your help Katrin.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13477] On order detail not showing

2014-12-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13477

--- Comment #8 from Iming Chan  ---
Created attachment 34762
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34762&action=edit
"OPACAcquisitionDetails" setting

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13477] On order detail not showing

2014-12-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13477

--- Comment #7 from Iming Chan  ---
(In reply to Katrin Fischer from comment #5)
> Displaying acquisition information in the OPAC was only added to 3.18.
> 
> Die you see the change updating from 3.18 to 3.18.1? 
> Are you referring to the OPACAcquisitionDetails system preference?

Yes, I saw change made in 3.18. I'm unsure what you're referring to "... change
updating from 3.18 to 3.18.1"?

As for "OPACAcquisitionDetails" in System Preference, it shows "Display ...". 
See screen image attached.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12954] Questionable logic regarding session handling in C4::Auth::checkauth()

2014-12-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12954

Katrin Fischer  changed:

   What|Removed |Added

   Assignee|oleon...@myacpl.org |a...@biblos.pk.edu.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13360] C4::Ris considers that hashes are ordered

2014-12-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13360

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #34742|0   |1
is obsolete||

--- Comment #3 from Katrin Fischer  ---
Created attachment 34761
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34761&action=edit
[PASSED QA] Bug 13360: C4::Ris assumes that hash keys are ordered - KW

This patch only fixes the KW order.

Test plan:
1/ Choose/create a record with several 6XX (for KW), see the code source
to know which fields you can use
2/ Export this record in RIS format
3/ Verify that the KW lines are ordered following the marc record fields
order.

Signed-off-by: Chris Cormack 

We really should refactor this whole thing into Koha::RIS sometime, it's
a horrible module at the moment.

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13360] C4::Ris considers that hashes are ordered

2014-12-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13360

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13320] Some prices calculation are done in template side

2014-12-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13320

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13320] Some prices calculation are done in template side

2014-12-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13320

--- Comment #6 from Katrin Fischer  ---
Created attachment 34760
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34760&action=edit
parcel - patch applied

Both screenshots show the parcel page.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13320] Some prices calculation are done in template side

2014-12-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13320

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #5 from Katrin Fischer  ---
Created attachment 34759
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34759&action=edit
invoice - master

Hi Jonathan, 

I hope I applied all the dependencies correctly:
12896
12969
13001
13320

I see a difference in the total, the actual cost seems not to be used for the
total amount, I am attaching 2 screenshots - one for master and one with the
patches applied.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13450] Title and breadcrumb of Patron form can look weird in translations

2014-12-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13450

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA
 CC||katrin.fisc...@bsz-bw.de

--- Comment #4 from Katrin Fischer  ---
Hm, bit confused - the description says it moves the category to the end, but
that doesn't match what I see in the templates:

When I edit an existing patron:

Title: Modify Child patron 
Breadcrumb: Home › Patrons ›  › Modify Child patron 

Modify Adult patron Nicole Schneider 
Home › Patrons › Nicole Schneider › Modify Adult patron 

Double checked patch is applied and looking at the English templates. The
categoryname at the end doesn't show up for me.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13268] biblioitems.size value not correctly displayed (more)

2014-12-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13268

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #34740|0   |1
is obsolete||
  Attachment #34741|0   |1
is obsolete||

--- Comment #11 from Katrin Fischer  ---
Created attachment 34757
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34757&action=edit
[PASSED QA] Bug 13268 - biblioitems.size value not correctly displayed (more)

Bug partially corrected by Bug 11357.

The size column in biblioitems is a bit problematic when used in TT, because
instead of the size value from the biblio column it will give you the size of
the variable or current loop.

It's currently used in the templates like opac-topissues.tt :
[% IF results_loo.size %][% results_loo.size %][% END %]

This patch corrects by using item() TT method.
See
http://stackoverflow.com/questions/2311303/how-can-i-handle-hash-keys-containing-illegal-identifier-characters-in-template.

Test plan :
- Be sure there is a mapping between a MARC field and biblioitems.size
- Create a record A with biblioitems.size defined : like "10x12"
- Create a record B with no value in biblioitems.size
- Check each modified page :
=> Without this patch : you see a number (loop size) for both records
=> With this patch : you only see the correct value for A and nothing for B

Signed-off-by: Jonathan Druart 
Signed-off-by: Chris Cormack 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13268] biblioitems.size value not correctly displayed (more)

2014-12-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13268

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13268] biblioitems.size value not correctly displayed (more)

2014-12-28 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13268

--- Comment #12 from Katrin Fischer  ---
Created attachment 34758
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34758&action=edit
[PASSED QA] Bug 13268: the size should not be emptied in pl script

It duplicates what the first patch does.

Signed-off-by: Jonathan Druart 
Signed-off-by: Chris Cormack 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/