[Koha-bugs] [Bug 10480] Improvements for framework plugins in cataloguing/item editor
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10480 --- Comment #27 from M. de Rooy --- Created attachment 35287 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35287&action=edit Bug 10480: Follow-up for unimarc_field_686a/_700-4.pl This patch fixes the pod errors on those two files by removing the pod section that actually does not add anything useful. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10480] Improvements for framework plugins in cataloguing/item editor
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10480 M. de Rooy changed: What|Removed |Added Attachment #35190|0 |1 is obsolete|| Attachment #35191|0 |1 is obsolete|| --- Comment #26 from M. de Rooy --- Created attachment 35286 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35286&action=edit Bug 10480: Remove useless routines and irrelevant pod lines This patch makes the following cleanup actions for all plugins: 1- Remove sub plugin_parameters. This function is not used. 2- Remove empty plugin or empty plugin_javascript subs. 3- Remove empty Blur, Clic or Focus routines from javascript. 4- Remove pod lines (copy-pasta) only referring to the 3 plugin subs. 5- Remove the last 1; line. It is no longer needed. Test plan: Run the unit test t/db_dependent/FrameworkPlugins.t Test some cataloguing plugins in addbiblio. Test some item plugins in additem and neworderempty. Signed-off-by: Marcel de Rooy I also checked the syntax of all plugins with perl -c. And checked the pod (if any) with podchecker: Two files still produce a warning; the follow-up deals with them: unimarc_field_686a/_700-4.pl. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13564] Items search: rename Stock number to Inventory number
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13564 --- Comment #7 from Katrin Fischer --- Jonathan found some more occurrences, probably in the CSV export (comment#5) - can we get another patch for those? :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13584] Able to view menu for Purchase Suggestions even when user does not have permission
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13584 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #4 from Katrin Fischer --- Currently there is a second file for building the navigation that could be changed too, but this patch is correct and an improvement. / koha-tmpl / intranet-tmpl / prog / en / includes / circ-menu.tt There is a bug report to remove the file in favor of the .inc, as both have some differences right now. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13584] Able to view menu for Purchase Suggestions even when user does not have permission
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13584 Katrin Fischer changed: What|Removed |Added Attachment #35267|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 35285 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35285&action=edit [SIGNED OFF] Bug 13584 - Able to view menu for Purchase Suggestions even when user does not have permission Added check for borrowers that stops the Purchase Suggestions link being shown. This could be done through the css but that function currently appears to be broken Testing Plan: -Search for a patron with an account that does not have the 'borrowers' permission *Purchase suggestions item should not be seen in the menu. -Change the accounts permissions so they have the 'borrowers' permission *Purchase suggestions item should be present in the menu. Signed-off-by: Katrin Fischer The page requires borrowers permission, so the link should act accordingly. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13584] Able to view menu for Purchase Suggestions even when user does not have permission
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13584 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10241] Easy analyticals creates two 773 fields. Search/link from host to children is broken
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10241 Katrin Fischer changed: What|Removed |Added Attachment #35270|0 |1 is obsolete|| --- Comment #9 from Katrin Fischer --- Created attachment 35284 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35284&action=edit [SIGNED OFF] Bug 10241 - Easy analyticals creates two 773 fields. Search/link from host to children is broken Hidden 'New child record' if 'EasyAnalytics' is set to display. Testing plan: -Turn on 'EasyAnalytics'. Check the drop down menu from the records page *The drop down menu should include 'Analyze items' and not include 'New child record' -Turn off 'EasyAnalytics'. Again check the drop down menu from the records page *The drop down menu should include 'New child record' and not inlucde 'Analyze items' Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10241] Easy analyticals creates two 773 fields. Search/link from host to children is broken
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10241 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13570] koha-conf.xml mentions win32
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13570 Katrin Fischer changed: What|Removed |Added Attachment #35173|0 |1 is obsolete|| --- Comment #7 from Katrin Fischer --- Created attachment 35283 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35283&action=edit [PASSED QA] Bug 13570 - koha-conf.xml mentions win32 Issue existed in koha-conf.xml of /etc. The following lines were removed from the file: This section was located on lines 9, 10, 11, 12 and 13 of the koha-conf.xml file. Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13570] koha-conf.xml mentions win32
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13570 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13570] koha-conf.xml mentions win32
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13570
Katrin Fischer changed:
What|Removed |Added
CC||katrin.fisc...@bsz-bw.de
--- Comment #6 from Katrin Fischer ---
Should we remove the bits about Windows from Makefile.PL as well? (git grep
MSWin32):
Makefile.PL:if ( $^O eq 'MSWin32' ) {
...
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11345] self registration captcha
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11345 --- Comment #6 from Katrin Fischer --- Thx for the patch, but a special thanks for fixing "git-bz attach -e" to work with a commit message including non-ascii characters! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11358] Use Amazon's HTTPS URLs for covers when using HTTPS in Koha.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11358 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11345] self registration captcha
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11345 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10177] Koha Accepts Seven "Space" Characters as a Valid Password
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10177 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11345] self registration captcha
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11345 Katrin Fischer changed: What|Removed |Added Attachment #35183|0 |1 is obsolete|| --- Comment #5 from Katrin Fischer --- Created attachment 35282 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35282&action=edit [PASSED QA] Bug - 11345 - Self registration captcha Test Plan - Open the opac site - Navigate to the self registration page (Home -> Register here) - Notice that there is no note stating that the verification box is case-sensitive - Apply patch - Refresh page - Notice that there is now an extra note stating that the verification box is case-sensitive. Followed test plan. Hint displays as expected. Signed-off-by: Marc Véron Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12702] Suggestions still accessible in OPAC when deactivated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12702 Katrin Fischer changed: What|Removed |Added Attachment #35175|0 |1 is obsolete|| --- Comment #11 from Katrin Fischer --- Created attachment 35281 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35281&action=edit [PASSED QA] Bug 12702 - Suggestions still accessible in OPAC when deactivated Added check for suggestions turned off. If off user is redirected to 404 error. If patron suggestions are off guest sugestions will also redirect to 404 Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12702] Suggestions still accessible in OPAC when deactivated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12702 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13571] koha-conf.xml.in has fallen out of sync with koha-conf.xml
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13571
M. Tompsett changed:
What|Removed |Added
CC||mtomp...@hotmail.com
--- Comment #6 from M. Tompsett ---
When did Koha lose the ability to be installed in a home directory?
This hard coded path and __KOHASITE__ instead of __ZEBRA{WHATEVER}__ seems like
a step backwards. When did that come in?
$ cd ~/kohaclone
$ diff etc/koha-conf.xml debian/templates/koha-conf-site.xml.in > ~/file.txt
$ cat ~/file.txt
1d0
<
3,13c2,4
<
<
<
<
< unix:__ZEBRA_RUN_DIR__/bibliosocket
< unix:__ZEBRA_RUN_DIR__/authoritysocket
<
<
---
>
> >unix:/var/run/koha/__KOHASITE__/bibliosocket
> >unix:/var/run/koha/__KOHASITE__/authoritysocket
16c7
< Also uncomment the and sections for id
'publicserver'
---
> Also uncomment the and sections for id
> 'publicserver'
18,20c9,11
<
---
> __START_SRU_PUBLICSERVER__
> tcp:@:__SRU_BIBLIOS_PORT__
> __END_SRU_PUBLICSERVER__
26c17
< __PAZPAR2_TOGGLE_XML_PRE__
---
>
> /var/lib/koha/__KOHASITE__/biblios
> /etc/koha/sites/__KOHASITE__/__ZEBRA_BIBLIOS_CFG__
> /var/lib/koha/__KOHASITE__/pqf.properties
33c24
< __PAZPAR2_TOGGLE_XML_POST__
---
> -->
36,41c27,96
<
< __ZEBRA_DATA_DIR__/biblios
< __ZEBRA_CONF_DIR__/__ZEBRA_BIB_CFG__
< __ZEBRA_CONF_DIR__/pqf.properties
< http://www.w3.org/2001/XInclude"/>
< http://www.w3.org/2001/XInclude"/>
---
>
> /var/lib/koha/__KOHASITE__/biblios
> /etc/koha/sites/__KOHASITE__/__ZEBRA_BIBLIOS_CFG__
> /etc/koha/zebradb/pqf.properties
>
> __START_BIBLIOS_RETRIEVAL_INFO__
>
>
>
>
> identifier="info:srw/schema/1/marcxml-v1.1">
>
> inputcharset="utf-8"/>
>
>
>
>
> inputcharset="utf-8"/>
> stylesheet="/usr/share/koha/intranet/htdocs/intranet-tmpl/prog/en/xslt/MARC21slim2DC.xsl"/>
>
>
>
>
> inputcharset="utf-8"/>
> stylesheet="/usr/share/koha/intranet/htdocs/intranet-tmpl/prog/en/xslt/MARC21slim2MODS.xsl"/>
>
>
>
>
> inputcharset="utf-8"/>
> stylesheet="/usr/share/koha/intranet/htdocs/intranet-tmpl/prog/en/xslt/MARC21slim2RDFDC.xsl"/>
>
>
>
>
> inputcharset="utf-8"/>
> stylesheet="/usr/share/koha/intranet/htdocs/intranet-tmpl/prog/en/xslt/MARC21slim2RSS2.xsl"/>
>
>
>
>
> inputcharset="utf-8"/>
> stylesheet="/usr/share/koha/intranet/htdocs/intranet-tmpl/prog/en/xslt/MARC21slimUtils.xsl"/>
>
>
> __END_BIBLIOS_RETRIEVAL_INFO__
>
>
44,45c99,100
< __ZEBRA_CONF_DIR__/ccl.properties
< __ZEBRA_USER__
---
> /etc/koha/zebradb/ccl.properties
> kohauser
51,55c106,165
< __ZEBRA_DATA_DIR__/authorities
< __ZEBRA_CONF_DIR__/__ZEBRA_AUTH_CFG__
< __ZEBRA_CONF_DIR__/pqf.properties
< http://www.w3.org/2001/XInclude"/>
< http://www.w3.org/2001/XInclude"/>
---
> /var/lib/koha/__KOHASITE__/authorities
> /etc/koha/sites/__KOHASITE__/__ZEBRA_AUTHORITIES_CFG__
> /etc/koha/zebradb/pqf.properties
>
> __START_AUTHORITIES_RETRIEVAL_INFO__
>
>
> identifier="info:srw/schema/1/marcxml-v1.1">
>
> inputcharset="utf-8"/>
>
>
>
>
> inputcharset="utf-8"/>
> stylesheet="/usr/share/koha/intranet/htdocs/intranet-tmpl/prog/en/xslt/MARC21slim2DC.xsl"/>
>
>
>
>
> inputcharset="utf-8"/>
> stylesheet="/usr/share/koha/intranet/htdocs/intranet-tmpl/prog/en/xslt/MARC21slim2MODS.xsl"/>
>
>
>
>
> inputcharset="utf-8"/>
> stylesheet="/usr/share/koha/intranet/htdocs/intranet-tmpl/prog/en/xslt/MARC21slim2RDFDC.xsl"/>
>
>
>
>
> inputcharset="utf-8"/>
> stylesheet="/usr/share/koha/intranet/htdocs/intranet-tmpl/prog/en/xslt/MARC21slimUtils.xsl"/>
>
>
> __END_AUTHORITIES_RETRIEVAL_INFO__
>
>
58,59c168,169
< __ZEBRA_CONF_DIR__/ccl.properties
< __ZEBRA_USER__
---
> /etc/koha/zebradb/ccl.properties
> kohauser
64,70c174,241
<
> __START_SRU_PUBLICSERVER__
>
> /var/lib/koha/__KOHASITE__/biblios
> /etc/koha/sites/__KOHASITE__/__ZEBRA_BIBLIOS_CFG__
> /etc/koha/zebradb/pqf.properties
>
> __START_BIBLIOS_RETRIEVAL_INFO__
>
>
>
>
[Koha-bugs] [Bug 13528] Ability to search on the different isbn variations
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13528 the.invinnysible@gmail.com changed: What|Removed |Added CC||the.invinnysible.one@gmail. ||com Status|Needs Signoff |In Discussion --- Comment #2 from the.invinnysible@gmail.com --- I am currently working on this but I am having a conflict with the git commit. It should be able to sign off on this soon. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6473] Test bug for Git-bz
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Justin Vos changed: What|Removed |Added Attachment #35279|0 |1 is obsolete|| --- Comment #154 from Justin Vos --- Created attachment 35280 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35280&action=edit Bug 6473 - Test bug for Git-bz utf-8 Test message (｡･ω･｡)ﾉ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13040] Improve exporter to allow multiple branch selections
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13040 Thomas Wright changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||tomsst...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6473] Test bug for Git-bz
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Justin Vos changed: What|Removed |Added Attachment #35277|0 |1 is obsolete|| --- Comment #153 from Justin Vos --- Created attachment 35279 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35279&action=edit Bug 6473 - Test bug for Git-bz utf-8 Test message (｡･ω･｡)ﾉ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13040] Improve exporter to allow multiple branch selections
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13040 Thomas Wright changed: What|Removed |Added Attachment #34924|0 |1 is obsolete|| --- Comment #12 from Thomas Wright --- Created attachment 35278 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35278&action=edit Bug 13040 - multiple branch selections in exporter This allows the exporter (Tools -> Export) to have any combination of branches selected, rather than it being all or only one. Test Plan: * Apply the patch * Go to the exporter, see that instead of a dropdown you now have an elegently laid out grid of branches you can select from * Select some branches, run the export * Note that only records with items in the selected branches are returned. * Repeat this with the item related options (as that code was refactored slightly) and make sure everything is sane. Sponsored-By: South Taranaki District Libraries Signed-off-by: Thomas -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6473] Test bug for Git-bz
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Justin Vos changed: What|Removed |Added Attachment #35276|0 |1 is obsolete|| --- Comment #152 from Justin Vos --- Created attachment 35277 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35277&action=edit Bug 6473 - Test bug for Git-bz utf-8 Test message (｡･ω･｡)ﾉ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6473] Test bug for Git-bz
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Justin Vos changed: What|Removed |Added Attachment #35275|0 |1 is obsolete|| --- Comment #151 from Justin Vos --- Created attachment 35276 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35276&action=edit Bug 6473 - Test bug for Git-bz utf-8 Test message (\xef\xbd\xa1\xef\xbd\xa5\xcf\x89\xef\xbd\xa5\xef\xbd\xa1)\xef\xbe\x89 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6473] Test bug for Git-bz
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Justin Vos changed: What|Removed |Added Attachment #35274|0 |1 is obsolete|| --- Comment #150 from Justin Vos --- Created attachment 35275 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35275&action=edit Bug 6473 - Test bug for Git-bz utf-8 Test message (｡･ω･｡)ﾉ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6473] Test bug for Git-bz
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Justin Vos changed: What|Removed |Added Attachment #35273|0 |1 is obsolete|| --- Comment #149 from Justin Vos --- Created attachment 35274 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35274&action=edit Bug 6473 - Test bug for Git-bz utf-8 Test message (\xef\xbd\xa1\xef\xbd\xa5\xcf\x89\xef\xbd\xa5\xef\xbd\xa1)\xef\xbe\x89 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6473] Test bug for Git-bz
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Justin Vos changed: What|Removed |Added Attachment #35269|0 |1 is obsolete|| --- Comment #148 from Justin Vos --- Created attachment 35273 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35273&action=edit Bug 6473 - Test bug for Git-bz utf-8 Test message (\xef\xbd\xa1\xef\xbd\xa5\xcf\x89\xef\xbd\xa5\xef\xbd\xa1)\xef\xbe\x89 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13571] koha-conf.xml.in has fallen out of sync with koha-conf.xml
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13571 Robin Sheat changed: What|Removed |Added Status|Passed QA |Signed Off --- Comment #5 from Robin Sheat --- Actually, I'll remove my Passed QA in favour of a second look-over, just to be on the safe side. Martin, can you have a look and mark it as Passed QA if it seems good to you? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13571] koha-conf.xml.in has fallen out of sync with koha-conf.xml
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13571 --- Comment #4 from Robin Sheat --- Created attachment 35272 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35272&action=edit Bug 13571: followup to remove some now-unused options The memcache parameters aren't used by anything (except C4::SQLHelper, but that's a cancer on the face of the earth) anymore, so they can go. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13571] koha-conf.xml.in has fallen out of sync with koha-conf.xml
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13571 Robin Sheat changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13571] koha-conf.xml.in has fallen out of sync with koha-conf.xml
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13571 Robin Sheat changed: What|Removed |Added Attachment #35268|0 |1 is obsolete|| --- Comment #3 from Robin Sheat --- Created attachment 35271 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35271&action=edit Bug 13571: Koha-conf.xml.in has fallen out of sync with koha-conf.xml To test: 1- Build new koha packages 2- Check that the conflist file contains the changes we have made Signed-off-by: Robin Sheat -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13571] koha-conf.xml.in has fallen out of sync with koha-conf.xml
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13571 Robin Sheat changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13572] Add onlyactives parameter to force_borrower_messaging_defaults script
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13572 Abby changed: What|Removed |Added CC||abbyrobertson.student@wegc. ||school.nz Status|Needs Signoff |In Discussion --- Comment #3 from Abby --- I followed the test plan but I can't verify the patch fixes it. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10241] Easy analyticals creates two 773 fields. Search/link from host to children is broken
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10241 Thomas Wright changed: What|Removed |Added Status|NEW |Needs Signoff CC||tomsst...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10241] Easy analyticals creates two 773 fields. Search/link from host to children is broken
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10241 --- Comment #8 from Thomas Wright --- Created attachment 35270 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35270&action=edit Bug 10241 - Easy analyticals creates two 773 fields. Search/link from host to children is broken Hidden 'New child record' if 'EasyAnalytics' is set to display. Testing plan: -Turn on 'EasyAnalytics'. Check the drop down menu from the records page *The drop down menu should include 'Analyze items' and not include 'New child record' -Turn off 'EasyAnalytics'. Again check the drop down menu from the records page *The drop down menu should include 'New child record' and not inlucde 'Analyze items' -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6473] Test bug for Git-bz
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 --- Comment #147 from Justin Vos --- Created attachment 35269 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35269&action=edit Bug 6473 - Test bug for Git-bz utf-8 Test message (\xef\xbd\xa1\xef\xbd\xa5\xcf\x89\xef\xbd\xa5\xef\xbd\xa1)\xef\xbe\x89 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12889] Improving documentation in C4::Members.pm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12889 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||tomasco...@gmail.com --- Comment #6 from Tomás Cohen Arazi --- Patch pushed to master. Thanks and congratulations! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12442] Query... variables should be defined within loop in Search.pm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12442 David Cook changed: What|Removed |Added Assignee|gmcha...@gmail.com |dc...@prosentient.com.au --- Comment #1 from David Cook --- This is still a thing last time I checked... should fix this one of these days... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12441] search.pl has incorrect reference to OPACdefaultSortField and OPACdefaultSortOrder
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12441 --- Comment #1 from David Cook --- This may or may not be fixed... will have to double-check this one of these days... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13537] Focus should move to barcode after renewing via checkouts table
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13537 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||tomasco...@gmail.com --- Comment #4 from Tomás Cohen Arazi --- Patch pushed to master. Thanks Kyle! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12850] C4::Serials::GetLateIssues is not used
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12850 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com Status|Passed QA |Pushed to Master --- Comment #4 from Tomás Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13564] Items search: rename Stock number to Inventory number
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13564 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||tomasco...@gmail.com --- Comment #6 from Tomás Cohen Arazi --- Patch pushed to master. Thanks Rochelle, and congratulations! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13290] Add better feedback for returns to the checkouts table
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13290 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||tomasco...@gmail.com --- Comment #16 from Tomás Cohen Arazi --- Patch pushed to master. Thanks Kyle! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13222] Accessors for import_record.status have variable names suggesting overlay_status
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13222 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com Status|Passed QA |Pushed to Master --- Comment #4 from Tomás Cohen Arazi --- Patch pushed to master. Thanks Olli! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13204] Plugin housekeeping: Remove labs_theses.pl plugin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13204 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||tomasco...@gmail.com --- Comment #15 from Tomás Cohen Arazi --- Patch pushed to master. Thanks Marcel! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12868] GetMemberDetails calls GetMemberAccountRecords incorrectly
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12868 Chris Cormack changed: What|Removed |Added CC||ch...@bigballofwax.co.nz Status|Passed QA |Pushed to Stable --- Comment #15 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.3 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13235] Revise layout of patron search form
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13235 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Patch doesn't apply CC||tomasco...@gmail.com --- Comment #10 from Tomás Cohen Arazi --- Please rebase! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12922] Do not DIE the advance_notices.pl -cronjob if "no letter of * type" is found
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12922 Chris Cormack changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||ch...@bigballofwax.co.nz --- Comment #9 from Chris Cormack --- Pushed to 3.18.x will be in 3.18.3 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12845] C4::Output::FormatData is unused
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12845 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Patch doesn't apply CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13571] koha-conf.xml.in has fallen out of sync with koha-conf.xml
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13571 --- Comment #2 from Rochelle Healy --- Created attachment 35268 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35268&action=edit Bug 13571: Koha-conf.xml.in has fallen out of sync with koha-conf.xml To test: 1- Build new koha packages 2- Check that the conflist file contains the changes we have made -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10177] Koha Accepts Seven "Space" Characters as a Valid Password
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10177 Brandon changed: What|Removed |Added Status|NEW |Needs Signoff CC||brandon_...@hotmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13265] Still too many search cursor cookies
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13265 --- Comment #4 from David Cook --- (In reply to Abby from comment #3) > The search cookie is no longer used in master, search history is stored in > the database. > > Have we missed anything? Interesting! I haven't looked at master recently, so I'm not sure. I wonder which commit changed the use of the search cookie... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13522] tools/viewlog.pl does not compile in older perls
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13522 Chris Cormack changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||ch...@bigballofwax.co.nz --- Comment #10 from Chris Cormack --- Pushed to 3.18.x, will be in 3.18.3 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13584] Able to view menu for Purchase Suggestions even when user does not have permission
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13584 Thomas Wright changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13584] Able to view menu for Purchase Suggestions even when user does not have permission
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13584 --- Comment #2 from Thomas Wright --- Created attachment 35267 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35267&action=edit Bug 13584 - Able to view menu for Purchase Suggestions even when user does not have permission Added check for borrowers that stops the Purchase Suggestions link being shown. This could be done through the css but that function currently appears to be broken Testing Plan: -Search for a patron with an account that does not have the 'borrowers' permission *Purchase suggestions item should not be seen in the menu. -Change the accounts permissions so they have the 'borrowers' permission *Purchase suggestions item should be present in the menu. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13584] Able to view menu for Purchase Suggestions even when user does not have permission
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13584 Thomas Wright changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment #1 from Thomas Wright --- I'm working on this. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13584] New: Able to view menu for Purchase Suggestions even when user does not have permission
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13584 Bug ID: 13584 Summary: Able to view menu for Purchase Suggestions even when user does not have permission Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: tomsst...@gmail.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Same problem as Bug 10943. The page requires borrowers to access but the menu item is still shown to users who do not have the borrowers permission. >From purchase-suggestions.pl we can see there is no check for which permissions are required to visit the linked page. Yet in the include the only thing checked is: [% IF ( suggestionsview ) %] So a user who doesn't have permission to access Purchase suggestions can still see the menu item. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13571] koha-conf.xml.in has fallen out of sync with koha-conf.xml
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13571 Rochelle Healy changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10943] Impossible to manage fines without borrowers permission
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10943 Thomas Wright changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13583] Able to view menu for Statistics even when user does not have permission
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13583 Thomas Wright changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13583] Able to view menu for Statistics even when user does not have permission
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13583 --- Comment #2 from Thomas Wright --- Created attachment 35266 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35266&action=edit Bug 13583 - Able to view menu for Statistics even when user does not have permission Added check for borrowers that stops the Statistics link being shown. This could be done through the css but that function currently appears to be broke Testing Plan: -Search for a patron with an account that does not have the 'borrowers' permission *Statistics should not be seen in the menu. -Change the accounts permissions so they have the 'borrowers' permission *Statistics should be present in the menu. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13583] Able to view menu for Statistics even when user does not have permission
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13583 Thomas Wright changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment #1 from Thomas Wright --- Working on this. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13583] New: Able to view menu for Statistics even when user does not have permission
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13583
Bug ID: 13583
Summary: Able to view menu for Statistics even when user does
not have permission
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Patrons
Assignee: koha-bugs@lists.koha-community.org
Reporter: tomsst...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com
Same problem as Bug 10943. The page requires borrowers to access but the menu
item is still shown to users who do not have the borrowers permission.
>From statistics.pl we see:
flagsrequired => {borrowers => 1},
No permissions are currently checked.
So a user who doesn't have permission to access Statistics can still see the
menu item.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11358] Use Amazon's HTTPS URLs for covers when using HTTPS in Koha.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11358 Justin Vos changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff CC||justin...@live.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13571] koha-conf.xml.in has fallen out of sync with koha-conf.xml
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13571 Robin Sheat changed: What|Removed |Added CC||ro...@catalyst.net.nz Component|Architecture, internals,|Packaging |and plumbing| Assignee|gmcha...@gmail.com |koha-b...@lists.koha-commun ||ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10177] Koha Accepts Seven "Space" Characters as a Valid Password
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10177 --- Comment #4 from Brandon --- Created attachment 35265 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35265&action=edit Bug 10177 - whitespace is a valid password causing pernicious perturbations. Test plan: Go to your patron, go to change username and/or password. change password to whitespace, notice it is accepted, apply this patch, change password again, to whitespace, notice password is not valid. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13582] Able to view menu for Circulation History even when user does not have permission
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13582 Thomas Wright changed: What|Removed |Added Status|ASSIGNED|Needs Signoff --- Comment #3 from Thomas Wright --- After discussion with Chris the decision has been made to hide the unnavigable menu items. This could be done with the CSS and greying out the unavailable options but currently that appears to be broken. This may in fact be a better solution as it removes any confusion users may have as to why when they click on things they don't work. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11358] Use Amazon's HTTPS URLs for covers when using HTTPS in Koha.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11358 --- Comment #8 from Justin Vos --- Created attachment 35264 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35264&action=edit Bug: 11358 - Use HTTPS Amazon images when Koha is using HTTPS. We've tried to fix the conflicts, not entirely sure if correct, please test thoroughly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13582] Able to view menu for Circulation History even when user does not have permission
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13582 --- Comment #2 from Thomas Wright --- Created attachment 35263 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35263&action=edit Bug 13582 - Able to view menu for Circulation History even when user does not have permission Added check for borrowers that stops the Circulation History link being shown. This could be done through the css but that function currently appears to be broke Testing Plan: -Search for a patron with an account that does not have the 'borrowers' permission *Circulation history should not be seen in the menu. -Change the accounts permissions so they have the 'borrowers' permission *Circulation history should be present in the menu. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7996] Patron Modification Log Requires Parameters Permission
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7996 Rochelle Healy changed: What|Removed |Added Status|NEW |Needs Signoff CC||rochellehealy.student@wegc. ||school.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7996] Patron Modification Log Requires Parameters Permission
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7996 --- Comment #3 from Rochelle Healy --- Created attachment 35262 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35262&action=edit Bug 7996: Patron Modification Log Requires Parameters Permission To test 1- Open 'set permissions' on patron page and uncheck '(parameters) Set koha system parameters' 2- Open patron page and notice that there is no 'modification log' tab 3- Apply patch 4- Refresh page and notice 'modification log' tab is there -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12352] Update patron records -page should have a link to patron details
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12352 Katrin Fischer changed: What|Removed |Added Status|In Discussion |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12352] Update patron records -page should have a link to patron details
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12352 --- Comment #3 from Katrin Fischer --- Hi Justin, try the following: - go to the patron account from the OPAC - enter an address change request from the details page there - see that a note appears in the patron module and on the start page of the staff client - the entry asking to moderate the modification is the one to change -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12352] Update patron records -page should have a link to patron details
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12352 Justin Vos changed: What|Removed |Added Status|ASSIGNED|In Discussion --- Comment #2 from Justin Vos --- I'm not sure what is required here. While editing a patron's details in the staff client, there is already a link back to the patron's details page in the left side-bar named "Details". Is the link needed somewhere else? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13265] Still too many search cursor cookies
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13265 Abby changed: What|Removed |Added CC||abbyrobertson.student@wegc. ||school.nz Status|Needs Signoff |In Discussion --- Comment #3 from Abby --- The search cookie is no longer used in master, search history is stored in the database. Have we missed anything? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13582] Able to view menu for Circulation History even when user does not have permission
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13582 Thomas Wright changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment #1 from Thomas Wright --- I'm working on this. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13582] New: Able to view menu for Circulation History even when user does not have permission
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13582
Bug ID: 13582
Summary: Able to view menu for Circulation History even when
user does not have permission
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Patrons
Assignee: koha-bugs@lists.koha-community.org
Reporter: tomsst...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com
Same problem as Bug 10943. The page requires borrowers to access but the menu
item is still shown to users who do not have the borrowers permission.
>From readingrec.pl we see:
flagsrequired => {borrowers => 1},
Yet in the include the only thing checked is:
[% IF ( readingrecordview ) %]
So a user who doesn't have permission to access Circulation history can still
see the menu item.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10943] Impossible to manage fines without borrowers permission
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10943 --- Comment #5 from Thomas Wright --- Created attachment 35261 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35261&action=edit Bug 10943 - Impossible to manage fines without borrowers permission Added check for borrowers permission as that is also required when accessing fines. Test Plan: -Search for a patron from an account without the 'borrowers' permission and with the 'updatecharges' permission. *The fines tab should not be present. -Update the account's permissions to include the 'borrowers' permission *The fines tab should now be present. -Update the account's permissions so it has neither 'borrowers' or 'updatecharges' *The fines tab should not be present -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12461] Add patron clubs feature
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12461 Justin Vos changed: What|Removed |Added CC||justin...@live.com --- Comment #5 from Justin Vos --- In my test, I applied the patch and ran updatedatabase.pl. However I received this error message: DBD::mysql::db do failed: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '' at line 13 at ./updatedatabase.pl line 9735. DBD::mysql::db do failed: Can't create table 'koha_kohadev.#sql-a48_3a' (errno: 150) at ./updatedatabase.pl line 9776. DBD::mysql::db do failed: Can't create table 'koha_kohadev.#sql-a48_3a' (errno: 150) at ./updatedatabase.pl line 9782. DBD::mysql::db do failed: Table 'koha_kohadev.club_templates' doesn't exist at ./updatedatabase.pl line 9801. DBD::mysql::db do failed: Can't create table 'koha_kohadev.#sql-a48_3a' (errno: 150) at ./updatedatabase.pl line 9806. DBD::mysql::db do failed: Can't create table 'koha_kohadev.#sql-a48_3a' (errno: 150) at ./updatedatabase.pl line 9811. Upgrade to 3.19.00.XXX done (Bug 12461 - Add patron clubs feature) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13571] koha-conf.xml.in has fallen out of sync with koha-conf.xml
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13571 Rochelle Healy changed: What|Removed |Added Status|NEW |ASSIGNED CC||rochellehealy.student@wegc. ||school.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13531] bulkmarcimport bombs if no match is found
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13531 Thomas Wright changed: What|Removed |Added Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13531] bulkmarcimport bombs if no match is found
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13531
--- Comment #7 from Thomas Wright ---
Created attachment 35260
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35260&action=edit
Bug 13531: QA follow up
A minor QA comment.
::: misc/migration_tools/bulkmarcimport.pl
@@ +271,5 @@
> my ( $error, $results, $totalhits ) = C4::Search::SimpleSearch(
> $query, 0, 3, [$server] );
> +# changed to warn so able to continue with one broken record
> +if ( defined $error ) {
> +warn "unable to search the database for duplicates : $error";
> +next;
For consistency with the rest of the script, should this perhaps be:
next RECORD;
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12702] Suggestions still accessible in OPAC when deactivated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12702 --- Comment #10 from Katrin Fischer --- I think not a blocker for your patch - just some thoughts about how we could handle things better. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12702] Suggestions still accessible in OPAC when deactivated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12702 --- Comment #9 from Thomas Wright --- (In reply to Martin Renvoize from comment #8) > OK, I'm happy with the logic here. I had to go digging a little to prove to > mysefl that the assumption was valid. (Lines 530 -> 539 in commit > http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=koha-tmpl/opac- > tmpl/bootstrap/en/modules/opac-results.tt; > hb=544520d6bdfacada4eba4caefedf42864db4b3a0#l529) > > So, this patch does indeed fix the problem.. however as a side note, I > really don't like seeing this kind of logic at the template level.. it's not > testable and leads to repetative code :'(. > > I'de rather see the template just ask the question 'to display, or not to > display?', and have the actual logic involved in that question handled > further up in the code, perferably in either C4/Suggestions.pm or as part of > the Koha.preference plugin somehow. That way, we'd have a testable fix. > Just a thought Should I work on this? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13581] New: item circ history has 'last seen' labeled wrong
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13581 Bug ID: 13581 Summary: item circ history has 'last seen' labeled wrong Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: neng...@gmail.com QA Contact: testo...@bugs.koha-community.org On this page: cgi-bin/koha/circ/bookcount.pl?&biblionumber=106124&bi=106124&itm=140197 the 'last seen' column is actually the timestamp - not the date last seen so it's confusing. The label should be changed or the value should be changed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6758] Capture membership renewal date for reporting purposes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6758 Cab Vinton changed: What|Removed |Added CC||direc...@plaistowlibrary.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7380] Can't filter patron search on detail page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7380 Marc Véron changed: What|Removed |Added Status|Needs Signoff |Signed Off Patch complexity|--- |Medium patch CC||ve...@veron.ch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7380] Can't filter patron search on detail page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7380 Marc Véron changed: What|Removed |Added Attachment #35222|0 |1 is obsolete|| --- Comment #14 from Marc Véron --- Created attachment 35259 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35259&action=edit Bug 7380: Refactor the patron search box header A lot of page uses the patron search box header include (git grep patron-search.inc for the list) and the branch and category lists are not generated for all of them. For instance, on a patron detail page, there is a [+] link, but nothing append on clicking on it. This patch add a new template plugin "Categories" to get all patron categories from the templates. Test plan: 1/ Verify the [+] is working on all patron page (if that works for 2, that should work for all). 2/ Launch a search from the header box and verify the library and category dropdown lists select the correct value. 3/ Launch a search on the patron search page (patron home) and verify the search is working correctly on selecting a category and/or a library Followed test plan. Works as expected. Signed-off-by: Marc Véron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13450] Title and breadcrumb of Patron form can look weird in translations
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13450 Marc Véron changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 1807] search () give odd results
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1807 --- Comment #15 from Christopher Brannon --- Sorry. I wish I could figure out what's stopping it from working. I guess someone will actually need to fix this. :/ Christopher -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13450] Title and breadcrumb of Patron form can look weird in translations
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13450 Marc Véron changed: What|Removed |Added Attachment #34862|0 |1 is obsolete|| --- Comment #13 from Marc Véron --- Created attachment 35258 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35258&action=edit Bug 13450 - Title and breadcrumb of Patron form can look weird in translations This patch moves the patron category name or category type at the end of title and breadcrumb for better translatability. Note: It does not change anything in functionallity, it only changes display of strings. To test: Apply patch Search a patron and edit it in all possible ways: 'Edit' button on top of details page, 'Edit' links in details page, 'Edit' links in search result table if multiple patrons are found) Duplicate a patron Create a new patron Make sure that title and breadcrumb appear in a meaningful way with pattern similar to the following: Modify patron Hansli Meier (Juvenile) (Missing added) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 1807] search () give odd results
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1807 --- Comment #14 from John Andrews --- Have tried various searches -- links with no parentheses work fine, all links I've found with parentheses return the broken search results. Cache cleared, and double-checked to make sure I copied the full script -- everything *looks* like it should be working correctly, but we still only get parentheses removed in the opac and not the staff client. John -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 1807] search () give odd results
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1807 --- Comment #13 from Christopher Brannon --- (In reply to John Andrews from comment #12) > We're on 3.16.03.000. > > There are no other scripts in intranetuserjs that should affect details > pages at all so I'm not sure where to even begin looking for a conflict. There may be conditions it is not able to catch. Have you tried other searches? Christopher -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 1807] search () give odd results
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1807 --- Comment #12 from John Andrews --- We're on 3.16.03.000. There are no other scripts in intranetuserjs that should affect details pages at all so I'm not sure where to even begin looking for a conflict. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12632] Hold limits ignored for record level holds with item level itemtypes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12632 Kyle M Hall changed: What|Removed |Added Attachment #35255|0 |1 is obsolete|| --- Comment #14 from Kyle M Hall --- Created attachment 35257 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35257&action=edit Bug 12632 - Unit Tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12632] Hold limits ignored for record level holds with item level itemtypes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12632 --- Comment #13 from Kyle M Hall --- Created attachment 35256 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35256&action=edit Bug 12632 - Hold limits ignored for record level holds with item level itemtypes The crux of the issue is that if you are using item level itemtypes, but are allowing biblio levels holds, those holds do not have items. So, in CanItemBeReserved, when Koha counts the number of holds to compare against the given rule, it will always give 0 ( except of course for found holds, and the occasional item-level hold ). So the query is saying "link each of these reserves to the reserved item, and count the number of reserves this patron where the itemtype is DVD". However, since these are all record level reserves, there are no items to link to, and so when it looks for all reserves this and item whose itemtype is DVD, it finds zero reserves! This patch solves the problem by looking first at the item level itemtype, and if it does not exist, then it looks at the record level itemtype. For installations using record level itemtypes, the behavior remains unchanged. Test plan: 1) Enable item level itemtypes 2) Create two records with one item each of a given itemtype 3) Create a single issuing rule and limit the holds allowed for that itemtype to 1 4) Place a record level hold on your first record 5) Attempt to place a record level hold for the same patron on your second record. You should not be able to but you can! 6) Apply this patch 7) Repeat step 5, note you can no longer place the hold! Signed-off-by: Paola Rossi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12632] Hold limits ignored for record level holds with item level itemtypes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12632 Kyle M Hall changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12632] Hold limits ignored for record level holds with item level itemtypes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12632 Kyle M Hall changed: What|Removed |Added Attachment #32788|0 |1 is obsolete|| --- Comment #12 from Kyle M Hall --- Created attachment 35255 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35255&action=edit Bug 12632 - Unit Tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
