[Koha-bugs] [Bug 5144] Duplicate holds allowed if patron clicks back button after placing hold

2015-01-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144

Aleisha Amohia aleishaamo...@hotmail.com changed:

   What|Removed |Added

  Attachment #35093|0   |1
is obsolete||

--- Comment #19 from Aleisha Amohia aleishaamo...@hotmail.com ---
Created attachment 35451
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35451action=edit
Bug 5144 [4] [QA Followup] - Fix message error and language used

Signed-off-by: Aleisha aleishaamo...@hotmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5144] Duplicate holds allowed if patron clicks back button after placing hold

2015-01-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5144

Aleisha Amohia aleishaamo...@hotmail.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13603] autoBarcode setting hbyymmincr not taking month into account when looking up next increment

2015-01-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13603

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13603] autoBarcode setting hbyymmincr not taking month into account when looking up next increment

2015-01-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13603

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #35409|0   |1
is obsolete||

--- Comment #2 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 35450
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35450action=edit
[SIGNED-OFF] Bug 13603 - autoBarcode setting hbyymmincr not taking month into
account when looking up next increment

The hbyymmincr autoBarcode builder looks up all barcodes that begin with
any number of letters ( the branchcode ) and a two-digit year directly
afterward ( e.g. MPL15 ), then grabs the last four digits as the
increment counter. The problem is, this does not take months into
account, so unlike the description that says the system is limited to
10,000 items a month, it is limited to 10,000 items per *year*.

This situation can easily be corrected my adding the month into the
lookup ( e.g. MPL1501 ).

Test Plan:
1) Enable autoBarcode, set to hbyymmincr
2) Catalog an item, let the barcode.pl plugin generate
   the next barcode.
3) Catalog an item with the barcode MPL1500
4) Catalog another item, use the barcode.pl plugin to
   generate the next barcode.
5) Note the barcode is generated ends with '0001' instead of the
   correct increment
6) Apply this patch
7) Repeat step 4
8) Note the barcode now ends with the correct increment

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

Signed-off-by: Jeanne Heicher nppub...@pa.net

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11927] Add greek support to CHR

2015-01-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11927

Fridolin SOMERS fridolyn.som...@biblibre.com changed:

   What|Removed |Added

 Status|Pushed to Master|ASSIGNED

--- Comment #28 from Fridolin SOMERS fridolyn.som...@biblibre.com ---
last patch needs SO.
It should fix UT t/db_dependant/Search.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5501] Improve the 'do not notify' option

2015-01-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5501

Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

--- Comment #8 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi ---
Zeno, this feature is ready to be tested regarding the patches I made, but this
is still missing a lot more message types.

I need to take a look at our acquisitions department as they report severe
slowdowns in the acquisitions process (and a ton of stuff) so I'll let you sign
off these if you want. But followups need to be provided for the other
message_types.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7904] SIP modules handling of @INC is confused

2015-01-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7904

--- Comment #7 from Martin Renvoize martin.renvo...@ptfs-europe.com ---
Test Plan

This patch is all about plumbing.. basically having a working SIP server config
before the patches, should work exactly the same after a service restart after
the patches :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7904] SIP modules handling of @INC is confused

2015-01-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7904

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com

--- Comment #10 from Kyle M Hall k...@bywatersolutions.com ---
Tested by launching sip server with just

./C4/SIP/SIPServer.pm /path/to/SIPconfig.xml

Used sip_cli_emulator to make some SIP requests, everything looks good!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11927] Add greek support to CHR

2015-01-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11927

--- Comment #27 from Fridolin SOMERS fridolyn.som...@biblibre.com ---
Created attachment 35446
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35446action=edit
Bug 11927 - Add greek support to CHR (followup)

Small error in word-phrase-utf.chr.
It generates this logs :
17:03:25-21/01 zebraidx(10636) [warn] Map: 'ς' has no mapping
17:03:25-21/01 zebraidx(10636) [warn] duplicate entry for charmap from 'Σ'

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10855] Additional fields for subscriptions

2015-01-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855

Paola Rossi paola.ro...@cineca.it changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #189 from Paola Rossi paola.ro...@cineca.it ---
Thanks, Jonathan.
I've applied the [13] patches against master 3.19.00.006 head 13526 (!).

As required in comment 172 [but I think that this step could also be added 
to the test plan in comment 171]
- try filters on columns.
a particular problem arose on FILTERING. See below.

Moreover, being this patch closely related to authorized values and categories, 
I was in doubt about the displaying of the branch-limited additional values, as 
it is described by 3.18 manual. I've provided a possible solution. Please 
see all in the NB.1 below.

I think that on FILTERING there can be an error.
For now I pass the patch in the Failed QA status.

If FILTERING is not an error, and displaying AV is not a problem, and no other 
follow up is needed, I can sign off this patch attaching the 13 patches as 
usual.

 FILTERING
RIGHT:
Some subscriptions had periodicals in a field of theirs. I've selected all of
 them in some way.
Filtering by perioa at once no subscription was expected to be selected.
It happened in 1 second (RIGHT) [subscriptions disappeared]
I cancelled all the filter value: all those subscriptions were expected to be 
selected.
It happened in 1 second (RIGHT) [subscriptions appeared again]
[Now there was no filter value]
Filtering by perioà at once [CTRL v] no subscription were expected to
selected.
It happened in 1 second (RIGHT).
RIGHT Incremental filtering:
Filtering by perio at once all those subscriptions were expected to be 
selected.
It happened (RIGHT): nothing changed in the table.
I added a at the right of the value, so I was incrementally filtering by
perioa.
No subscription were expected to selected.
It happened in 1 second (RIGHT).

ERROR: Incremental filtering by adding diacritics exited in ERROR:
Some subscriptions had periodicals in a field of theirs. I've selected all of 
them in some way.
Filtering by perio all subscriptions were filtered (OK, like above RIGHT).
I added à at the right of the value, so I was incrementally filtering by
perioà.
No limitation happened in the resulting table in 30 seconds (ERROR).
After 30 sec, I added ò at the right of the value, so I was incrementally
filtering by perioàò.
No limitation happened in the resulting table in 30 seconds (ERROR).

This error didn't happened adding incrementally to perio:
a Japanese (会) char, 
a number,
a Greek (γ) char.

This error occurred either on searching subscriptions' table or on serials 
claims' one.
 FILTERING's ERROR END

NB1. A special case of authorized values is about categories with 
branches-limited AV. See:
http://manual.koha-community.org/3.18/en/basicparams.html#authorizedvalues
At point 232, [3.18] manual says about their setting:
If you would like to limit this authorized value category to only specific 
libraries you can choose them from the 'Branches limitation' menu. To have it 
show for all libraries just choose 'All branches' at the top of the list.

This patch's behaviour about the branches-limited AVs was OK (RIGHT).
At my tests, patch is OK [=as plan require] on a category whose AVs are all
branch-limited, and 
also on a category whose AVs are a mixture of limited and not-limited.
As desired and required by this patch's test plans:
branches-limited AV are displayed on viewing a subscription,
(subscription-detail.pl)
(B) categories names [not the limited AVs' drop down list, like manual says]
are shown on editing a subscription (subscription-add.pl)
branches-limited AV are all displayed in the resulting tables,
branches-limited AV are all filter-able in the resulting tables,
(A) categories names [not the limited AVs' drop down list, like manual says]
are shown among search fields on the left on searching subscriptions.

IMO these branches-limited AV could also be displayed in the (A) drop down list
(A), to be available to the selecting user.
Assigning an attribute is not modifying/adding a value to a category. So IMO 
the (B) drop down list could also be shown.
In simple terms the limit in 3.18 manual would be updated from:
To have it show
to:
A branch-limited AV is always shown to all libraries. To have it added and
modified

Otherwise, if the current manual prevales, the part of this patch requiring to 
show AdVs could need to be reviewed. 
[Or Additional Values are not exactly a kind of Authorized Values.]

Anyway, now this sentence of the manual:
If you would like to limit this authorized value category to only specific
libraries you can choose them from the 'Branches limitation' menu.
appears a little generic to me, not enough to let understand the limit. 
The sentence could also be changed into:
If you would like to limit this 

[Koha-bugs] [Bug 7904] SIP modules handling of @INC is confused

2015-01-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7904

Colin Campbell colin.campb...@ptfs-europe.com changed:

   What|Removed |Added

  Attachment #35447|0   |1
is obsolete||

--- Comment #11 from Colin Campbell colin.campb...@ptfs-europe.com ---
Created attachment 35449
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35449action=edit
Rebase main path

rebased original patch against current master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7904] SIP modules handling of @INC is confused

2015-01-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7904

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7904] SIP modules handling of @INC is confused

2015-01-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7904

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #33057|0   |1
is obsolete||
  Attachment #33400|0   |1
is obsolete||

--- Comment #8 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 35447
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35447action=edit
[SIGNED-OFF] Bug 7904 Change SIP modules to use standard LIB path

For historical reasons the SIPServer and SIP modules
have used an extra module path in addition to the
standard Koha one. This has caused numerous irritants
in attempting to set up scripts and basic tests. It
does not help in attempting to modify or debug
this code

This patch changes the package value in the modules
under the C4/SIP directory and makes calls to
them use the full package name.

Where the export mechanism was being short circuited
routines have been explicitly exported and imported
declarations of 'use ILS' when that module was
not being used and which only generated warnings
have been removed.

As a lot of the changes affect lines where
an object is instantiated with new. The opportunity
has been taken to replace the ambiguous indirect
syntax with the preferred direct call

In intializing ILS the full path is added as this
will not require any changes to existing configs.
I suspect this feature is unused, and adds
obfuscation rather than flexibility but have kept
the feature as we need this change in order to
rationalize and extend the testing of the server.

The visible difference is that with the normal Koha
PERL5LIB setting. Compilation of Modules under C4/SIP
should be successful and not fail with unlocated modules,
allowing developers to see any perl warnings

All the SIP modules can now be run through the tests
in t/00-load.t now except for SIPServer itself

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7904] SIP modules handling of @INC is confused

2015-01-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7904

--- Comment #9 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 35448
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35448action=edit
[SIGNED-OFF] Bug 7904 - remove unnecessary path from SIP script

With the fixing of the namespace in the SIP code, we don't need to
modify the PERL5LIB to have the old one.

To test:
* do a package install using this and the other patches on bug 7904
* enable SIP
* make sure koha-start-sip and koha-stop-sip work

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7710] multiple holds per title

2015-01-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7710

--- Comment #77 from M. de Rooy m.de.r...@rijksmuseum.nl ---
(In reply to Jonathan Druart from comment #75)
 I rebased this patch manually (using git apply --reject) and recreated the
 patch.
 Note that I did *not* test it!

Thanks for doing so. I would be interested too in seeing this get further.
The current patch suggest that Kyle wrote it and Maxime signed off. Could you
add a comment about your rebase; I assume that it was not a trivial one?

Of course, it would be great if you also tested [as second author]. This
feature cannot be tested enough in a part of Koha (circulation/holds) that is
sensible to bugs.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11927] Add greek support to CHR

2015-01-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11927

Fridolin SOMERS fridolyn.som...@biblibre.com changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5501] Improve the 'do not notify' option

2015-01-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5501

--- Comment #9 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi ---
But I feel like this is a good start for improving on this feature.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11315] Add support for subfield deletion when doing authority merges.

2015-01-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11315

Ahmed Sfayhi ahmed.sfa...@inlibro.com changed:

   What|Removed |Added

 CC||ahmed.sfa...@inlibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11055] Add 'minutes' as a load period unit

2015-01-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11055

Ahmed Sfayhi ahmed.sfa...@inlibro.com changed:

   What|Removed |Added

 CC||ahmed.sfa...@inlibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search

2015-01-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937

Ahmed Sfayhi ahmed.sfa...@inlibro.com changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff
 CC||ahmed.sfa...@inlibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13431] Shared FastMmap file causes issues

2015-01-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13431

Magnus Enger mag...@enger.priv.no changed:

   What|Removed |Added

 CC||mag...@enger.priv.no

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search

2015-01-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937

--- Comment #50 from Ahmed Sfayhi ahmed.sfa...@inlibro.com ---
Created attachment 35452
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35452action=edit
Bug 10937 - Grouped ItemTypes - Patch should apply properly on latest master.

This allows to group certain item types in a category, to be displayed (and
searched) as such in OPAC's advanced search.  For example, you can group
Reserve 2h and Reserve 12h into a Reserve category.  The 2 and 12h types won't
appear anymore.
This also allows to simply prevent an item type from displaying as a search
option.

TEST PLAN
--
0) Back up database, so you can reset and retest easily. ;)
1) Apply the patch
2) Run Koha QA tool.
3) prove -v t/db_dependent/Koha.t
  -- all tests should pass.
  4) run ./installer/data/mysql/updatedatabase.pl to add the
  two columns to itemtypes
  -- Does a meaningful message get printed?
  Are the columns added?
  DESCRIBE itemtypes; should list hideinopac and searchcategory.
  5) You need to add a category to group your item types:
  a) In Intranet/Koha Admin/Authorized values,
  select DOCTYPECAT in the 'Show category:' dropdown
  i) If you do not have a DOCTYPECAT category, create one.
  b) Click button New authorized value for DOCTYPECAT
  c) Enter
  Authorized value: HARDWARE
  Description : Hardware
  Description (OPAC): Hardware
  6) Group your items under that new category
  a) In Intranet/Koha Admin/Item types, choose (at least)
  two item types and for each:
  - Click action/Edit on the right column
  - Third row (below Description) is the Search category list box, select
Hardware
  - click Save changes at the bottom
  7) Select at least one item to be hidden in the OPAC search
  a) In Intranet/Koha Admin/Item types (again), choose a different item type:
  -  Click action/Edit
  -  Click the checkbox Hide in OPAC below the list of icons.
  8) Go test your modifications
  a) Go to OPAC/Adv search.
  b) Validate that all items modified above (hidden or grouped) do not appear
in Item type list
  c) Validate that new item type Hardware does appear instead.
  d) Select item Hardware, start Search.
  ) Validate returned items are the of the two types that were grouped into the
Hardware category in step 4.

  Sponsored-by: Vanier college

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13517] Show waiting date on reserve/request.pl

2015-01-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13517

Aleisha Amohia aleishaamo...@hotmail.com changed:

   What|Removed |Added

  Attachment #34959|0   |1
is obsolete||

--- Comment #3 from Aleisha Amohia aleishaamo...@hotmail.com ---
Created attachment 35454
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35454action=edit
Bug 13517 - Show waiting date on reserve/request.pl

The holds table should show the waiting date for a hold in s similar
manner to the way it does on catalogue/detail.pl

Test Plan:
1) Apply this patch
2) Find a waiting hold
3) Browse to reserve/request.pl for that record
4) Notice the Item waiting message now has since waitingdate

Signed-off-by: Aleisha aleishaamo...@hotmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13517] Show waiting date on reserve/request.pl

2015-01-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13517

Aleisha Amohia aleishaamo...@hotmail.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13607] Patron management API

2015-01-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13607

Robin Sheat ro...@catalyst.net.nz changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|koha-b...@lists.koha-commun |ro...@catalyst.net.nz
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13607] New: Patron management API

2015-01-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13607

Bug ID: 13607
   Summary: Patron management API
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Patrons
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: ro...@catalyst.net.nz
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

Koha needs an API that allows creation, updating, and deleting of patrons.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13492] Add location to the checkouts tables

2015-01-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13492

Aleisha Amohia aleishaamo...@hotmail.com changed:

   What|Removed |Added

 CC||aleishaamo...@hotmail.com
 Status|Needs Signoff   |Patch doesn't apply

--- Comment #4 from Aleisha Amohia aleishaamo...@hotmail.com ---
Tried to test but got the following errors when applying patch it depends on
from Bug 10212:

Using index info to reconstruct a base tree...
Falling back to patching base and 3-way merge...
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/columns_settings.tt
CONFLICT (add/add): Merge conflict in
koha-tmpl/intranet-tmpl/prog/en/modules/admin/columns_settings.tt
Auto-merging koha-tmpl/intranet-tmpl/prog/en/includes/columns_settings.inc
CONFLICT (add/add): Merge conflict in
koha-tmpl/intranet-tmpl/prog/en/includes/columns_settings.inc
Auto-merging admin/columns_settings.yml
CONFLICT (add/add): Merge conflict in admin/columns_settings.yml
Auto-merging C4/Utils/DataTables/ColumnsSettings.pm
CONFLICT (add/add): Merge conflict in C4/Utils/DataTables/ColumnsSettings.pm
Failed to merge in the changes.
Patch failed at 0001 Bug 10212: Columns configuration for tables

Setting to Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11927] Add greek support to CHR

2015-01-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11927

Robin Sheat ro...@catalyst.net.nz changed:

   What|Removed |Added

 CC||ro...@catalyst.net.nz

--- Comment #29 from Robin Sheat ro...@catalyst.net.nz ---
(In reply to Manos PETRIDIS from comment #25)
 Will the option to use gr as Primary language for Zebra indexing be
 available to current (package) installations when they are upgraded to
 versions incorporating Bug 11927? 
 I understand there is no such system preference and any changes will have to
 be applied manually.

It's already available:

  --zebralang lang  Choose the primary language for Zebra indexing.
Valid
values are en (default), es, fr, gr, nb, ru and uk.

assuming that's the same as what you're talking about.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12478] Elasticsearch support for Koha

2015-01-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478

--- Comment #23 from Robin Sheat ro...@catalyst.net.nz ---
(In reply to Jonathan Druart from comment #21)
 $ perl misc/search_tools/rebuild_elastic_search.pl -h
 Can't locate Elasticsearch.pm in @INC (you may need to install the
 Elasticsearch module) (@INC contains: blablabla)
 
 $ apt-cache search elasticsearch | grep perl
 libcatmandu-perl - metadata toolkit

In comment #6 I added a link to the dependencies needed. It's a bit old now,
I've been working on making some new ones, but that archive may still work.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13537] Focus should move to barcode after renewing via checkouts table

2015-01-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13537

Mason James m...@kohaaloha.com changed:

   What|Removed |Added

   Keywords||rel_3_16_candidate
 CC||m...@kohaaloha.com

--- Comment #6 from Mason James m...@kohaaloha.com ---
Pushed to 3.16.x, patch will be in 3.16.7

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13290] Add better feedback for returns to the checkouts table

2015-01-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13290

Mason James m...@kohaaloha.com changed:

   What|Removed |Added

 CC||m...@kohaaloha.com
   Keywords||rel_3_16_candidate

--- Comment #19 from Mason James m...@kohaaloha.com ---
Pushed to 3.16.x, patch will be in 3.16.7

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13408] Tell librarians they may continue scanning while checkouts table is loading

2015-01-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13408

Mason James m...@kohaaloha.com changed:

   What|Removed |Added

   Keywords||rel_3_16_candidate
 CC||m...@kohaaloha.com

--- Comment #11 from Mason James m...@kohaaloha.com ---
Pushed to 3.16.x, patch will be in 3.16.7

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13607] Patron management API

2015-01-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13607

David Cook dc...@prosentient.com.au changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13607] Patron management API

2015-01-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13607

--- Comment #1 from Robin Sheat ro...@catalyst.net.nz ---
Created attachment 35455
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35455action=edit
Bug 13607: patron management API

This provides a patron management API. It allows a remote service to:
* add patrons
* update patron details
* delete patrons

It presents a simple POST-based API and returns its results as XML.
This API supports fields available in the borrower table, and extended
attribute types also.

Full documentation will be on a wiki page linked to from the bug.

To test:
* construct a sequence of API requests, make sure it works.
* ensure that no side effects of these changes came about, particularly
  dealing with unrelated things (default_messageprefs.pl,
  sco-patron-image.pl, systempreferences.)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13607] Patron management API

2015-01-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13607

Robin Sheat ro...@catalyst.net.nz changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

--- Comment #2 from Robin Sheat ro...@catalyst.net.nz ---
Documentation of the API is currently here:

http://wiki.koha-community.org/wiki/Talk:Koha_/svc/_HTTP_API#Patron_Management_API

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13536] Date due without time on CHECKOUT alert

2015-01-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13536

Aleisha Amohia aleishaamo...@hotmail.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13536] Date due without time on CHECKOUT alert

2015-01-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13536

Aleisha Amohia aleishaamo...@hotmail.com changed:

   What|Removed |Added

  Attachment #35443|0   |1
is obsolete||

--- Comment #5 from Aleisha Amohia aleishaamo...@hotmail.com ---
Created attachment 35453
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35453action=edit
Bug 13536: Follow-up for adding date_due_without_time in column list

This patch adds the (virtual) column date_due_without_time to the
list of available columns when editing a notice (for the issues table).

Test plan:
Add the column to the CHECKOUT notice.
Verify that the actual notice at checkout now contains the expected data.

Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl
I also tested this by adding the field to DUE and running the overdues
cron job.
Note that in that case it must be included in an item section. (This
is a restriction imposed by the code in the overdue_notices.pl script.)

Signed-off-by: Aleisha aleishaamo...@hotmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9848] SIP tests : fix in 10renew_all.t (additionnal checkin)

2015-01-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9848

--- Comment #9 from Colin Campbell colin.campb...@ptfs-europe.com ---
(In reply to Katrin Fischer from comment #8)
 Does noone know how to run these tests?

The only documentation is the README in the directory. I took a look ages ago
but a lot of the tests have hardcoded references to a test setup on a Liblime
test system. As a whole they need rewitten as part of the test suite and to
handle dependencies in a reproduceable way.

 They arnt a test suite they are a reminder that one needs to be written

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13601] Get rid of DateTime::Format::DateParse

2015-01-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601

--- Comment #8 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 35433
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35433action=edit
Bug 13601: Fix special case in basket.pl

There is a badly managed date in acqui/basket.pl:
if the date is 15/01/2015 (metric format), it will become
2015-1-15 after the following line:
  $estimateddeliverydate = $year-$month-$day;
Add_Delta_Days is used at several place, and the ouput is forced to
display date on 4 digits and month/day on 2 digits.
This patch does the same thing for $estimateddeliverydate.

Note that I previously developed a patch to take this format into account (with
missing 0)
in Koha::DateUtils::dt_from_string, but I don't think it's a good idea
to manage bad formated dates.
We will certainly find some issues after previous patches, but it will permit
to catch
them!
IMO it's preferable than to keep them hidden.

The patch was:

diff --git a/Koha/DateUtils.pm b/Koha/DateUtils.pm
index 5fe2653..4434a67 100644
--- a/Koha/DateUtils.pm
+++ b/Koha/DateUtils.pm
@@ -72,17 +72,17 @@ sub dt_from_string {
 my $fallback_re = qr|
 (?year\d{4})
 -
-(?month\d{2})
+(?month\d{1,2})
 -
-(?day\d{2})
+(?day\d{1,2})
 |xms;

 if ( $date_format eq 'metric' ) {
 # metric format is dd/mm/[ hh:mm:ss]
 $regex = qr|
-(?day\d{2})
+(?day\d{1,2})
 /
-(?month\d{2})
+(?month\d{1,2})
 /
 (?year\d{4})
 |xms;
@@ -90,9 +90,9 @@ sub dt_from_string {
 elsif ( $date_format eq 'us' ) {
 # us format is mm/dd/[ hh:mm:ss]
 $regex = qr|
-(?month\d{2})
+(?month\d{1,2})
 /
-(?day\d{2})
+(?day\d{1,2})
 /
 (?year\d{4})
 |xms;
diff --git a/t/DateUtils.t b/t/DateUtils.t
index 886e1d6..0877240 100755
--- a/t/DateUtils.t
+++ b/t/DateUtils.t
@@ -189,3 +189,8 @@ is( output_pref( { dt = $dt } ), '31/01/2015 12:34',
'dt_from_string should mat
 # date before 1900
 $dt = dt_from_string('01/01/1900');
 is( output_pref( { dt = $dt, dateonly = 1 } ), '01/01/1900', 'dt_from_string
should manage date  1900' );
+
+# missing 0
+$dt = dt_from_string('1/1/2015');
+is( output_pref( { dt = $dt, dateonly = 1 } ), '01/01/2015', 'dt_from_string
should generate a DT object even if 0 are missing' );

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11120] The date option for the overdue_notices cronjob is broken

2015-01-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11120

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off
   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=13601

--- Comment #26 from Jonathan Druart jonathan.dru...@biblibre.com ---
With bug 13601, the wrong date format will be correctly caught.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13601] Get rid of DateTime::Format::DateParse

2015-01-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=11120

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9848] SIP tests : fix in 10renew_all.t (additionnal checkin)

2015-01-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9848

--- Comment #10 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Ouch. What do you suggest for this bug? Should we push it to the 'reminder'?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11120] The date option for the overdue_notices cronjob is broken

2015-01-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11120

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #34981|0   |1
is obsolete||

--- Comment #25 from Jonathan Druart jonathan.dru...@biblibre.com ---
Comment on attachment 34981
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34981
Bug 11120: Should this test fail?

This is fixed by bug 13601.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13601] Get rid of DateTime::Format::DateParse

2015-01-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601

--- Comment #9 from Jonathan Druart jonathan.dru...@biblibre.com ---
 display date on 4 digits and month/day on 2 digits.

It was

display *year* on 4 digits and month/day on 2 digits.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13320] Some prices calculation are done in template side

2015-01-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13320

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #34755|0   |1
is obsolete||

--- Comment #13 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 35429
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35429action=edit
Bug 13320: Move price calculation from tt to pl

In parcel.tt, total are calculated for subtotal.

This could be done in the pl script for more consistency.

Test plan:
Go on a parcel page with several already received orders.
Orders must be linked to different funds.
If possible ecost and unitprice (price on ordering and on receiving)
should changed (different values will be displayed in the table).

The values displayed before and after the patch must be the same.

Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13320] Some prices calculation are done in template side

2015-01-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13320

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #34756|0   |1
is obsolete||

--- Comment #14 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 35430
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35430action=edit
Bug 13320: Fix Tax inc. vs Tax exc.

The parcel page always displayes Tax exc. even when values don't
include taxes.

Test plan:
On the parcel page, verify that the string Tax * is correct.
This appears in the already received order table.

Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13605] New: _AUTHOR_ not replaced in relatives checkouts

2015-01-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13605

Bug ID: 13605
   Summary: _AUTHOR_ not replaced in relatives checkouts
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Patrons
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: fridolyn.som...@biblibre.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

In members/moremember.pl, in relatives checkouts tab, by _AUTHOR_ appears
before author.
This code sould be replaced in JS.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13001] Refactor VAT and price calculation - parcel page

2015-01-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13001

--- Comment #25 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 35428
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35428action=edit
Bug 13001: The total for received order should be based on the unitprice

For already received orders, the total should be calculated with the
unitprice, not the estimated cost.

Signed-off-by: Paola Rossi paola.ro...@cineca.it

Signed-off-by: Katrin Fischer katrin.fischer...@web.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13001] Refactor VAT and price calculation - parcel page

2015-01-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13001

--- Comment #24 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 35427
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35427action=edit
Bug 13001: Refactor VAT and price calculation - parcel page

Bug 12969 introduces a subroutine to centralize VAT and prices
calculation.
It should be use in the acqui/parcel.pl script.

Test plan:
1/ Create 4 suppliers with the different configurations
2/ Create a basket and create several orders
3/ Go on the parcel page
4/ You should see, on the pending orders table, the same prices as
before this patch.
Note that the prices are now correctly formated.

You could see one change for the supplier configuration 3 (1 0):
If the cost of the item is 82, discount 10% and vat 5%:
The Order cost = 140.58 instead of 140.57.
Indeed, before this patch, the order cost was wrong, now you should have
70.29*2 = 140.58

( before: 140.58 + 7.03 = 147.61
  now:140.58 + 7.02 = 147.60 )

5/ Receive the items and return on the parcel page
Now the Already received table with the same prices as before this
patch.
Note some differences too:
- There was a td tag missing, the table was badly formated, it's now
fixed (column below the Cancel receipt link).
- The prices are now correctly formated.
- For the configuration 2 (1 1), if the cost of the item is 82, discount
  10% and vat 5%:

( before: 140.57 + 7.03 = 147.60
  now:140.58 + 7.02 = 147.60 )

Note that 7.03 is the correct value, but on all other pages, 7.02 is
displayed.
To be consistent, we should display the same prices everywhere.

Signed-off-by: Paola Rossi paola.ro...@cineca.it

Signed-off-by: Katrin Fischer katrin.fischer...@web.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13320] Some prices calculation are done in template side

2015-01-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13320

--- Comment #15 from Jonathan Druart jonathan.dru...@biblibre.com ---
Conflicts with bug 11944 fixed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9580] Cover image from Coce, a remote image URL cache

2015-01-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9580

Fridolin SOMERS fridolyn.som...@biblibre.com changed:

   What|Removed |Added

 CC||fridolyn.som...@biblibre.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13605] _AUTHOR_ not replaced in relatives checkouts

2015-01-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13605

Fridolin SOMERS fridolyn.som...@biblibre.com changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13605] _AUTHOR_ not replaced in relatives checkouts

2015-01-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13605

Fridolin SOMERS fridolyn.som...@biblibre.com changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13605] _AUTHOR_ not replaced in relatives checkouts

2015-01-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13605

--- Comment #1 from Fridolin SOMERS fridolyn.som...@biblibre.com ---
Created attachment 35431
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35431action=edit
Bug 13605 - _AUTHOR_ not replaced in relatives checkouts

In members/moremember.pl, in relatives checkouts tab, by _AUTHOR_ appears
before author.
This code sould be replaced in JS.

Test plan :
- Go to a borrower with relative's checkouts
= without patch : you see by _AUTHOR_ string before author name
= with patch : you see by string before author name

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12892] Holds Waiting: not showing from check out screen

2015-01-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12892

Fridolin SOMERS fridolyn.som...@biblibre.com changed:

   What|Removed |Added

 CC||fridolyn.som...@biblibre.co
   ||m
 Status|Pushed to Master|Pushed to Stable

--- Comment #52 from Fridolin SOMERS fridolyn.som...@biblibre.com ---
I set to pushed to stable since its in 3.16.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13001] Refactor VAT and price calculation - parcel page

2015-01-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13001

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #34973|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13001] Refactor VAT and price calculation - parcel page

2015-01-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13001

--- Comment #26 from Jonathan Druart jonathan.dru...@biblibre.com ---
Conflict with bug 11944 fixed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13001] Refactor VAT and price calculation - parcel page

2015-01-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13001

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #34974|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13001] Refactor VAT and price calculation - parcel page

2015-01-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13001

--- Comment #23 from Jonathan Druart jonathan.dru...@biblibre.com ---
Tomas, This is *not* in master.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13320] Some prices calculation are done in template side

2015-01-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13320

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Patch doesn't apply |Signed Off

--- Comment #12 from Jonathan Druart jonathan.dru...@biblibre.com ---
Bug 13001 is not in master, the status seems to be wrong.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13596] Prevent updatedatabase.pl from reverting utf8_mb4 databases to utf8

2015-01-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13596

Martin Renvoize martin.renvo...@ptfs-europe.com changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13596] Prevent updatedatabase.pl from reverting utf8_mb4 databases to utf8

2015-01-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13596

Martin Renvoize martin.renvo...@ptfs-europe.com changed:

   What|Removed |Added

  Attachment #35395|0   |1
is obsolete||

--- Comment #5 from Martin Renvoize martin.renvo...@ptfs-europe.com ---
Created attachment 35432
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35432action=edit
BUG 13596: Prevent utf8mb4 - utf8 convertion

utf8mb4 is a superset of utf8 and thus is compatible.  We should not
force an entire db change upon people who have proactively set utf8mb4
encoding before now.

This patch also removed the deprecated use of -tables stanza in favour
of the table_info stanza.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11193] Update Queryparser conf file to take into account changes made by bug 8252

2015-01-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11193

--- Comment #10 from M. de Rooy m.de.r...@rijksmuseum.nl ---
(In reply to David Cook from comment #9)
 Why are there two patches at the moment? Is one with a correct indentation
 level and the other is not?

No, old one is obsolete.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11193] Update Queryparser conf file to take into account changes made by bug 8252

2015-01-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11193

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

  Attachment #22673|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7143] Bug for tracking changes to the about page

2015-01-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

  Attachment #35420|0   |1
is obsolete||

--- Comment #223 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Created attachment 35434
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35434action=edit
Bug 7143: Adding back version numbers

Adding back version numbers to the former release team members
in the list of developers.

Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl
Added prefix 3.16 to Galen's Release Maintainer. (See Roles for 3.18)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7143] Bug for tracking changes to the about page

2015-01-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 Status|In Discussion   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13602] Username/password already exists when editing borrower attributes and messaging preferences

2015-01-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13602

Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed:

   What|Removed |Added

  Attachment #35435|0   |1
is obsolete||

--- Comment #5 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi ---
Created attachment 35436
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35436action=edit
Bug 13602 - Username/password already exists when editing borrower attributes
and messaging preferences

When editing a Patron's messaging preferences or borrower attributes, one
cannot
save changes because 'userid' is not given as a parameter.

It shouldn't, but the
Check_Userid($newdata{'userid'},$borrowernumber) -check must have it.

REPLICATE THE ISSUE:
1. Find a Borrower.
2. Go to the details-tab.
3. Under Patron messaging preferences click edit to edit just the messaging
   preferences.
4. Just save, no need to make any modifications.
5. Observe the error Username/password already exists
   This happens to all/most of the sub-forms in the Borrower's Details-view.

AFTER THIS PATCH:
Check_Userid() get the $userid from the new parameters, or if not present, from
the koha.borrowers-table.

TEST FOR REGRESSION:
1. Edit a borrower normally. Notice no errors.
2. Edit a sub-form (Alternate address/Patron messaging preferences). Notice no
   errors.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13418] The C4::VirtualShelves::Page needs some cleaning

2015-01-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13418

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

  Attachment #35388|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13418] The C4::VirtualShelves::Page needs some cleaning

2015-01-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13418

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13418] The C4::VirtualShelves::Page needs some cleaning

2015-01-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13418

--- Comment #8 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Created attachment 35438
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35438action=edit
Bug 13418: Clean C4::VirtualShelves::Page - Part 2

I don't understand at all the usefulness of $privshelflist and
$privtotshelves in C4::VirtualShelves::Page
They look useless.

If you deep in the git history, you will find
commit 25eb36f21fe952118327d2c84dfef5d38eee31a7
Bug #2531 Cannot delete private shelf

I am not able to reproduce this issue after this patch

Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13602] Username/password already exists when editing borrower attributes and messaging preferences

2015-01-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13602

Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed:

   What|Removed |Added

  Attachment #35436|0   |1
is obsolete||

--- Comment #6 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi ---
Created attachment 35437
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35437action=edit
Bug 13602 - Username/password already exists when editing borrower attributes
and messaging preferences

When editing a Patron's messaging preferences or borrower attributes, one
cannot
save changes because 'userid' is not given as a parameter.

It shouldn't, but the
Check_Userid($newdata{'userid'},$borrowernumber) -check must have it.

REPLICATE THE ISSUE:
1. Find a Borrower.
2. Go to the details-tab.
3. Under Patron messaging preferences click edit to edit just the messaging
   preferences.
4. Just save, no need to make any modifications.
5. Observe the error Username/password already exists
   This happens to all/most of the sub-forms in the Borrower's Details-view.

AFTER THIS PATCH:
Check_Userid() get the $userid from the new parameters, or if not present, from
the koha.borrowers-table.

TEST FOR REGRESSION:
1. Edit a borrower normally. Notice no errors.
2. Edit a sub-form (Alternate address/Patron messaging preferences). Notice no
   errors.

DISCLAIMER: You are free to steal/rip/modify/hack this patch to your soul's
extent without my permission. As long as it makes to Koha I am happy.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13602] Username/password already exists when editing borrower attributes and messaging preferences

2015-01-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13602

Olli-Antti Kivilahti olli-antti.kivila...@jns.fi changed:

   What|Removed |Added

  Attachment #35404|0   |1
is obsolete||

--- Comment #4 from Olli-Antti Kivilahti olli-antti.kivila...@jns.fi ---
Created attachment 35435
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35435action=edit
Bug 13602 - Username/password already exists when editing borrower attributes
and messaging preferences

When editing a Patron's messaging preferences or borrower attributes, one
cannot
save changes because 'userid' is not given as a parameter.

It shouldn't, but the
Check_Userid($newdata{'userid'},$borrowernumber) -check must have it.

AFTER THIS PATCH:
Check_Userid() get the $userid from the new parameters, or if not present, from
the koha.borrowers-table.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10754] HomeOrHoldingBranch and CircControl are described identically in the system preference editor

2015-01-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10754

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com

--- Comment #3 from Kyle M Hall k...@bywatersolutions.com ---
For the most part the system goes like this for selecting circulation rules:
If CircControl is set to the library you are logged in at circ rules will be
selected based on the logged in branchcode
If CircControl is set to the library the patron is from circ rules will be
selected based on the patron's branchcode
If CircControl is set to the library the item is from circ rules will be
selected based on the items branchcode where HomeOrHoldingBranch chooses if
items.homebranch is used or items.holdingbranch is used.

Also, from my reading of master, it appears that the system preference in
question is HomeOrHoldingBranch, not CircControl. That is, if
IndependentBranches is enabled, and the item's branchcode does not match the
logged in library branchcode ( the choosing of which is via HomeOrHoldingBranch
), the item cannot be issued ( unless you are a super-librarian ).


Really, what we should do is remove the the library the item is from option
from CircControl and add the library that owns the item and the library that
is holding the item so we can remove HomeOrHoldingBranch from the circulation
rules logic altogether. Then, we can identify what HomeOrHoldingBranch still
does, and rename it to something more descriptive and accurate.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10754] HomeOrHoldingBranch and CircControl are described identically in the system preference editor

2015-01-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10754

--- Comment #4 from Kyle M Hall k...@bywatersolutions.com ---
For the most part the system goes like this for selecting circulation rules:

1) If CircControl is set to the library you are logged in at circ rules will
be selected based on the logged in branchcode

2) If CircControl is set to the library the patron is from circ rules will be
selected based on the patron's branchcode

3) If CircControl is set to the library the item is from circ rules will be
selected based on the items branchcode where HomeOrHoldingBranch chooses if
items.homebranch is used or items.holdingbranch is used.

Also, if IndependentBranches is enabled, and the item's branchcode ( the
choosing of which is via HomeOrHoldingBranch ) does not match the logged in
library branchcode , the item cannot be issued ( unless you are a
super-librarian ).

Really, what we should do is remove the the library the item is from option
from CircControl and add the library that owns the item and the library that
is holding the item so we can remove HomeOrHoldingBranch from the circulation
rules logic altogether. Then, we can identify what HomeOrHoldingBranch still
does, and rename it to something more descriptive and accurate.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10754] HomeOrHoldingBranch and CircControl are described identically in the system preference editor

2015-01-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10754

--- Comment #5 from Kyle M Hall k...@bywatersolutions.com ---
Ignore comment 3, I rewrote it as comment 4 to make it more readable.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7143] Bug for tracking changes to the about page

2015-01-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #228 from Tomás Cohen Arazi tomasco...@gmail.com ---
I think I'm allowed to pass this one :-D

The about page is really important in the sense it is the only place where we
acknowledge people's involvement in the Koha project, and I think Katrina's
followup is pertinent.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13536] Date due without time on CHECKOUT alert

2015-01-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13536

--- Comment #3 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Created attachment 35443
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35443action=edit
Bug 13536: Follow-up for adding date_due_without_time in column list

This patch adds the (virtual) column date_due_without_time to the
list of available columns when editing a notice (for the issues table).

Test plan:
Add the column to the CHECKOUT notice.
Verify that the actual notice at checkout now contains the expected data.

Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl
I also tested this by adding the field to DUE and running the overdues
cron job.
Note that in that case it must be included in an item section. (This
is a restriction imposed by the code in the overdue_notices.pl script.)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13536] Date due without time on CHECKOUT alert

2015-01-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13536

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13239] MySQL Character encoding utf8

2015-01-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13239

--- Comment #3 from Tomás Cohen Arazi tomasco...@gmail.com ---
Martin, do u plan to provide a patch for this one?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7143] Bug for tracking changes to the about page

2015-01-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143

--- Comment #229 from M. de Rooy m.de.r...@rijksmuseum.nl ---
(In reply to Tomás Cohen Arazi from comment #228)
 I think I'm allowed to pass this one :-D
I would be happy to pass you some more numbers :)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13606] Batch modification for records is limited to ~500

2015-01-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13606

--- Comment #2 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 35445
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35445action=edit
Bug 13606: Upgrade sessions.a_session to MEDIUMTEXT

The previous patch fixed partially the problem.
If you try to update more that 1000 records, you will get the same
error.

This patch change the type of sessions.a_session from TEXT (64kb) MEDIUMTEXT
(32mb).

Test plan:
1/ Try to modify a huge amount of records (1000 should be enough)
2/ Confirm it worked!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13606] Batch modification for records is limited to ~500

2015-01-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13606

--- Comment #1 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 35444
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35444action=edit
Bug 13606: Remove previous job data from the session

Bug 11395 uses the session to store the report sent to the interface
(update on biblio XX OK, etc.).

If the session is stored in mysql, the max size of the
sessions.a_session will be reached easily (TEXT field).

To reproduce:
0/ Set SessionStorage to 'mysql'
1/ Create a file with 500 biblionumbers:
  mysql -e select biblionumber from biblio limit 500; | tail -n 500 
/tmp/biblionumbers.txt
2/ Define a marc modification template (something like delete field 99$9 is
nice)
3/ Load the /tmp/biblionumbers.txt in the batch biblio modification tool
4/ Repeat 3
You will get:
  Syck parser (line 1534, column 6): syntax error at
  /usr/lib/i386-linux-gnu/perl5/5.20/YAML/Syck.pm line 75.
None Koha page is reachable.

It comes from get_template_and_user  checkauth  get_session 
l.1595 $session = new CGI::Session(driver:MySQL;serializer:yaml;id:md5,
$sessionID, {Handle=$dbh});

5/ Get your sessionID contained in your CGISESSID cookie
Have a look at the value a_session in the sessions table:
mysql select a_session from sessions where id=YOUR_SESSIONID;

You should see that the yaml is not correctly ended.
The size of the DB field has been reached and the yaml is truncated.

Test plan:
0/ Delete your CGISESSID cookie
1/ Try to reproduce the previous issue
2/ After the second batch, have a look at the sessions table and confirm
that only one job_$JOB_ID exist in the yaml

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13606] Batch modification for records is limited to ~500

2015-01-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13606

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10601] Add a counter on batch items modifications

2015-01-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10601

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=13606

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13606] Batch modification for records is limited to ~500

2015-01-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13606

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=10601

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13536] Date due without time on CHECKOUT alert

2015-01-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13536

--- Comment #4 from M. de Rooy m.de.r...@rijksmuseum.nl ---
(In reply to Aleisha Amohia from comment #2)
 Can't see issues.date_due_without_time to replace issues.date_due
 when editing the notice - setting to Failed QA

Thanks, Aleisha for testing. Hopefully, you still have the time to check the
follow-up ..

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10754] HomeOrHoldingBranch and CircControl are described identically in the system preference editor

2015-01-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10754

--- Comment #6 from Nicole C. Engard neng...@gmail.com ---
I updated the manual (changes will be available tomorrow) to note these
differences - please let me know if I should edit them:

http://manual.koha-community.org/3.18/en/administration.html#CircControl
http://manual.koha-community.org/3.18/en/administration.html#HomeOrHoldingBranch
http://manual.koha-community.org/3.18/en/patscirc.html#circfinerules

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7143] Bug for tracking changes to the about page

2015-01-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

  Attachment #35194|0   |1
is obsolete||

--- Comment #226 from Tomás Cohen Arazi tomasco...@gmail.com ---
Created attachment 35441
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35441action=edit
[PASSED QA] Bug 7143: QA Follow-up for abbrev PM

Replacing PM by Packaging Manager

Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl
Signed-off-by: Tomas Cohen Arazi tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7143] Bug for tracking changes to the about page

2015-01-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

  Attachment #35434|0   |1
is obsolete||

--- Comment #227 from Tomás Cohen Arazi tomasco...@gmail.com ---
Created attachment 35442
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35442action=edit
[PASSED QA] Bug 7143: Adding back version numbers

Adding back version numbers to the former release team members
in the list of developers.

Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl
Added prefix 3.16 to Galen's Release Maintainer. (See Roles for 3.18)

Signed-off-by: Tomas Cohen Arazi tomasco...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13606] Batch modification for records is limited to ~500

2015-01-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13606

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |jonathan.dru...@biblibre.co
   ||m
 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11395] Batch modifications for records

2015-01-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11395

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Blocks||13606

--- Comment #97 from Jonathan Druart jonathan.dru...@biblibre.com ---
This is limited to 500, see bug 13606 for more information.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13606] New: Batch modification for records is limited to ~500

2015-01-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13606

Bug ID: 13606
   Summary: Batch modification for records is limited to ~500
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Tools
  Assignee: gmcha...@gmail.com
  Reporter: jonathan.dru...@biblibre.com
QA Contact: testo...@bugs.koha-community.org

Bug 11395 uses the session to store the report sent to the interface (update on
biblio XX OK, etc.).

If the session is stored in mysql, the max size of the sessions.a_session will
be reached easily (TEXT field).

I found a first problem:
The C4::BackgroundJob module append to the session each job information.
Example for 2 jobs launched during the same session:

 --- 
_SESSION_ATIME: '1421843399'
_SESSION_CTIME: '1421843222'
_SESSION_ID: a5ffa813fc694706245cfe51dedc7697
_SESSION_REMOTE_ADDR: 192.168.113.2
branch: NO_LIBRARY_SET
branchname: NO_LIBRARY_SET
cardnumber: koha
emailaddress: k...@exampe.org
firstname: koha
flags: 1
id: koha
ip: 1.2.3.4
job_94357aff68a60dee98819f627c8a7f57: !!perl/hash:C4::BackgroundJob 
  extra_values: 
messages: 
  - 
biblionumber: 1
code: biblio_modified
type: success
  - 
biblionumber: 2
code: biblio_modified
type: success
  - 
biblionumber: 3
code: biblio_modified
type: success
  - 
biblionumber: 4
code: biblio_modified
type: success
  - 
biblionumber: 5
code: biblio_modified
type: success
report: 
  total_records: 5
  total_success: 5
view: report
  invoker: /cgi-bin/koha/tools/batch_record_modification.pl
  jobID: 94357aff68a60dee98819f627c8a7f57
  name: FIXME
  progress: 5
  results: ~
  sessionID: a5ffa813fc694706245cfe51dedc7697
  size: 5
  status: completed
job_98a251e034eec15b87027ea9c5c0a8cd: !!perl/hash:C4::BackgroundJob 
  extra_values: 
messages: 
  - 
biblionumber: 6
code: biblio_modified
type: success
  - 
biblionumber: 7
code: biblio_modified
type: success
  - 
biblionumber: 8
code: biblio_modified
type: success
  - 
biblionumber: 9
code: biblio_modified
type: success
  - 
biblionumber: 10
code: biblio_modified
type: success
report: 
  total_records: 5
  total_success: 5
view: report
  invoker: /cgi-bin/koha/tools/batch_record_modification.pl
  jobID: 98a251e034eec15b87027ea9c5c0a8cd
  name: FIXME
  progress: 5
  results: ~
  sessionID: a5ffa813fc694706245cfe51dedc7697
  size: 5
  status: completed

It's useless to keep old job information.

To reproduce:
1/ Create a file with 500 biblionumbers:
mysql -e select biblionumber from biblio limit 500; | tail -n 500 
/tmp/biblionumbers.txt
2/ Define a marc modification template
3/ Load the /tmp/biblionumbers.txt in the batch biblio modification tool
4/ Repeat 3
You will get:
  Syck parser (line 1534, column 6): syntax error at
/usr/lib/i386-linux-gnu/perl5/5.20/YAML/Syck.pm line 75.

The sessions.a_session field has reach its maximum size and the yaml stored in
it is not complete and not well formed.

To fix that I would like to
1/ Remove previous job information on creating a new one
2/ Increase the size of sessions.a_session from TEXT (64kb) to MEDIUMTEXT
(32mb)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13606] Batch modification for records is limited to ~500

2015-01-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13606

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Depends on||11395

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13333] Basket group is not displayed for already received orders

2015-01-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

 Status|Passed QA   |Patch doesn't apply

--- Comment #5 from Tomás Cohen Arazi tomasco...@gmail.com ---
It is not applying on master, could you please rebase?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13001] Refactor VAT and price calculation - parcel page

2015-01-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13001

--- Comment #27 from Tomás Cohen Arazi tomasco...@gmail.com ---
NOw, patches REALLY pushed to master.

Sorry for that Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13525] Date sorting on accounts (fines) tab doesn't work correctly

2015-01-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13525

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||tomasco...@gmail.com

--- Comment #7 from Tomás Cohen Arazi tomasco...@gmail.com ---
Patch pushed to master.

Thanks Owen!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13333] Basket group is not displayed for already received orders

2015-01-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #34152|0   |1
is obsolete||

--- Comment #6 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 35439
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35439action=edit
Bug 1: Fix Display basket group for already received orders

Bug 1 adds a basket group column on the parcel page.
But it seems that the already received orders never contain the value
(always 'no basket group').

Test plan:
Receive an order which is in a basket group and verify the basket group
column is correctly filled.

Signed-off-by: Paola Rossi paola.ro...@cineca.it

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13333] Basket group is not displayed for already received orders

2015-01-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Patch doesn't apply |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7143] Bug for tracking changes to the about page

2015-01-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

  Attachment #35192|0   |1
is obsolete||

--- Comment #225 from Tomás Cohen Arazi tomasco...@gmail.com ---
Created attachment 35440
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35440action=edit
[PASSED QA] Bug 7143: Release team 3.20

Updated the release team with the roles for 3.20 pages on the wiki and
checked with the votes on the IRC meeting log.
Simplified the section on Former release team members by moving that
information (in a compressed format) to the Developers section.
If someone had a role for multiple releases, I used constructs as 3.X.
Sorted the Additional thanks-section.

Signed-off-by: Justin justin...@live.com

Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl
2015-01-14: Amended. Replaced abbreviations like RM by Release Manager.
Replaced one occurrence of 3.x by 3.X (for Owen).

Signed-off-by: Tomas Cohen Arazi tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13584] Able to view menu for Purchase Suggestions even when user does not have permission

2015-01-21 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13584

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||tomasco...@gmail.com

--- Comment #7 from Tomás Cohen Arazi tomasco...@gmail.com ---
Patch pushed to master.

Thanks Thomas!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

  1   2   >