[Koha-bugs] [Bug 12858] Syndetics index apreciably slow page load for items without result at Syndetics
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12858 Chris Cormack changed: What|Removed |Added Attachment #31318|0 |1 is obsolete|| --- Comment #4 from Chris Cormack --- Created attachment 36010 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36010&action=edit Bug 12858: Add error handling to Syndetics Index * Syndetics routines include a statement to check that the returned content from Syndetics is xml. The get_syndetics_index routine was missing this check and so when a 'not found' html page was returned the opac-detail page would take a long time to load whilst xml::simple attempted to parse the large html document. Test Plan 1. Enable Syndetics indexes on opac. 2. Head over to an opac-detail page on the opac. 3. Remove the ISBN from the same item in the staff client. 4. Reload the opac-detail page for the item noticeing a much slower page load. 5. Apply the patch 6. Reload the opac-detail page for the item and note that it now laods in a reasonable timescale again. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12858] Syndetics index apreciably slow page load for items without result at Syndetics
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12858 Chris Cormack changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12669] "Template process failed: undef error - Invalid local time for date in time zone"
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12669 Chris Cormack changed: What|Removed |Added Attachment #35389|0 |1 is obsolete|| --- Comment #22 from Chris Cormack --- Created attachment 36011 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36011&action=edit Bug 12669: Use floating timezone when handling dates without hours, minutes and seconds. Test plan: 1. Create a new serial record or pick an existing one; 2. Add a "New subscription" and set the "First issue publication date" and "Frequency" values so that the "Planned date" for a given issue hits a day where a transition to Daylight Saving Time (DST) occurs ex:. 1979-04-01 in Europe/Lisbon (http://www.timeanddate.com/time/change/portugal/lisbon?year=1979) ... use this website page as a source http://www.timeanddate.com/time/dst/2014.html to find a suitable transition to DST in your timezone in the current year. 3. From the "Subscription detail" page in Koha for the given record click the "Serial collection" link on the left side context menu. Expected result: Prior to applying the patch the error described in this bug report should occur. After the patch is applied the "Serial collection" page should load correctly. Signed-off-by: Colin Campbell Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12669] "Template process failed: undef error - Invalid local time for date in time zone"
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12669 Chris Cormack changed: What|Removed |Added Attachment #35390|0 |1 is obsolete|| --- Comment #23 from Chris Cormack --- Created attachment 36012 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36012&action=edit Bug 12669: Centralize the timezone handle into Koha::DateUtils This patch adds unit tests for the previous changes and centralize the timezone handle into the Koha::DateUtils module. Like that the behavior will affect all date manipulations using this module (should be all dates in Koha). Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12669] "Template process failed: undef error - Invalid local time for date in time zone"
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12669 Chris Cormack changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13728] koha-translate -l -a shows po files instead of language codes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13728 Chris Cormack changed: What|Removed |Added Attachment #35993|0 |1 is obsolete|| --- Comment #2 from Chris Cormack --- Created attachment 36013 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36013&action=edit Bug 13728: koha-translate -l -a shows po files instead of language codes This patch corrects the call to 'basename' inside the script so it correctly shows the language code when asked to list the available languages. To test: - On a packages install, run: $ koha-translate --list --available => FAIL: It shows: am-Ethi-opac-bootstrap.po ar-Arab-opac-bootstrap.po az-AZ-opac-bootstrap.po be-BY-opac-bootstrap.po ben-opac-bootstrap.po ... - Apply the patch - Copy the patched debian/scripts/koha-translate script to your packages setup. - Run: $ koha-translate --list --available => SUCCESS: It shows: am-Ethi ar-Arab az-AZ be-BY ben ... - Sign off :-D Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13728] koha-translate -l -a shows po files instead of language codes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13728 Chris Cormack changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13687] ILS-DI services HoldItem and HoldTitle don't consider hold policy by item type
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13687 Chris Cormack changed: What|Removed |Added Attachment #35777|0 |1 is obsolete|| --- Comment #2 from Chris Cormack --- Created attachment 36014 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36014&action=edit Bug 13687: Move hold policy check into CanItemBeReserved This way ILS-DI HoldItem and HoldTitle services also benefit from this check Test plan: 1/ Define some default holds policies by item type in /admin/smart-rules.pl 2/ Use ILS-DI HoldItem service and check that those rules are respected 3/ Check that staff and opac hold behaviour is unchanged regarding these rules. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13687] ILS-DI services HoldItem and HoldTitle don't consider hold policy by item type
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13687 Chris Cormack changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12976] Refactor VAT and price calculation - invoice page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12976 --- Comment #20 from Jonathan Druart --- Tomas, this is *not* in master yet. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11400] Show "Login as a different user" instead of "Logout" if not enough premissions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11400 Chris Cormack changed: What|Removed |Added Attachment #23952|0 |1 is obsolete|| --- Comment #12 from Chris Cormack --- Created attachment 36015 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36015&action=edit Bug 11400: Show "Log in as a different user" in the error message instead of the "Logout" button Bug 11146 introduced a way to go back, and have a logout link for the "Not enough permissions" message page. I belive the logout button is redundant. And also "Log in as a different user" tells the user more about its options on the scenario. Simple and disputable usability/string change. Regards To+ Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11400] Show "Login as a different user" instead of "Logout" if not enough premissions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11400 Chris Cormack changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11400] Show "Login as a different user" instead of "Logout" if not enough premissions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11400 Chris Cormack changed: What|Removed |Added Attachment #36001|0 |1 is obsolete|| --- Comment #13 from Chris Cormack --- Created attachment 36016 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36016&action=edit Bug 11400 - Follow-up for nicer design This patch tries to get the Bug out of "In discussion" by changing the design a little bit. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12970] Refactor VAT and price calculation - basket page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12970 --- Comment #15 from Jonathan Druart --- Tomas, this is *not* in master yet. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7843] Create RSS for OPAC news
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7843 Chris Cormack changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7843] Create RSS for OPAC news
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7843 Chris Cormack changed: What|Removed |Added Attachment #35733|0 |1 is obsolete|| --- Comment #10 from Chris Cormack --- Created attachment 36017 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36017&action=edit Bug 7843 Create an RSS feed for news in Opac Test plan: * Install the patch * Make shure there is news in the Opac * Go to the Opac (opac-main.pl) * Make shure you see an RSS icon below the news and a short text. * Click the RSS icon and verify that you get an RSS feed that validates. Signed-off-by: Chris Cormack I took the liberty of fixing the copyright statement when signing it off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13455] Members/AddEnrolmentFeeIfNeeded.t requires sample data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13455 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@biblibre.co ||m --- Comment #3 from Jonathan Druart --- I still completely disagree with this kind of patch, see my comments on bug 13457. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13568] OAI Server doesn't handle properly resumption token
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13568 Jonathan Druart changed: What|Removed |Added Attachment #35962|0 |1 is obsolete|| --- Comment #7 from Jonathan Druart --- Created attachment 36018 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36018&action=edit Bug 13568 OAI Server doesn't handle properly resumption token When responding to ListRecords and ListIdentifiers verbs, OAI server doesn't return proper resumption token. At the end of a result set, OAI server generates a resumption token even if there isn't anymore records. Consequently, OAI harverster will send a new request, based on this invalid resumption, token. OAI Server responds with an empty resultset, which is considered as an invalid response by most of the harvesters. TO TEST: - Find in your DB, a day where a few biblio records have been created. The number of created biblios must inferior to OAI-PMH:MaxCount. - Let say this day is 2014-01-09. Send an OAI-PMH request to Koha OAI Server: /cgi-bin/koha/oai.pl?verb=ListRecords&metadataPrefix=marcxml&from=2014-01-09&until=2014-01-09 - At the end of the result, you will see a resumption token which looks like that: marcxml/47/2014-01-09/2014-01-09/ This is wrong. No resumptiion token should be sent since there isn't anymore records to harvest. - Apply the patch. - Resend the OAI-PMH request. There is no resumption token at the end of the result. - You could test also with ListIdenfiers verb in place of ListRecord. Signed-off-by: Christophe Brocquet Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13568] OAI Server doesn't handle properly resumption token
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13568 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13645] DBIx connection needs to be cached
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13645 Jonathan Druart changed: What|Removed |Added Assignee|gmcha...@gmail.com |jonathan.dru...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13596] Prevent updatedatabase.pl from reverting utf8_mb4 databases to utf8
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13596 Jonathan Druart changed: What|Removed |Added Assignee|gmcha...@gmail.com |martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13730] New: Install required when using web-based installer
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13730 Bug ID: 13730 Summary: Install required when using web-based installer Change sponsored?: --- Product: Koha Version: 3.18 Hardware: PC OS: Linux Status: NEW Severity: major Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs@lists.koha-community.org Reporter: ravijoshi9...@yahoo.co.in QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com Created attachment 36019 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36019&action=edit koha error log file after inserting kohastructure.sql and systempreference.sql within koha databse it showing me error in the context.pm that indicates username and password issue i inserted manually within the context.pm. after restarting the services i have getting below errors. in the log let me know the correct steps for the web installer. [Thu Feb 19 16:08:37 2015] [error] [client 192.168.1.104] [Thu Feb 19 16:08:37 2015] mainpage.pl: Install required, redirecting to Installer at /usr/share/koha/lib/C4/Auth.pm line 627. [Thu Feb 19 16:08:37 2015] [error] [client 192.168.1.104] [Thu Feb 19 16:08:37 2015] Context.pm: Subroutine C4::Context::confess redefined at /usr/local/share/perl5/Exporter.pm line 66. [Thu Feb 19 16:08:37 2015] [error] [client 192.168.1.104] [Thu Feb 19 16:08:37 2015] Context.pm: Subroutine C4::Context::croak redefined at /usr/local/share/perl5/Exporter.pm line 66. [Thu Feb 19 16:08:37 2015] [error] [client 192.168.1.104] [Thu Feb 19 16:08:37 2015] Context.pm: Subroutine C4::Context::carp redefined at /usr/local/share/perl5/Exporter.pm lin -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13679] There is a bug in overdues if you have overdues that match a rule, and have some items due in the future they are included in the list of overdues
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13679 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13679] There is a bug in overdues if you have overdues that match a rule, and have some items due in the future they are included in the list of overdues
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13679 Jonathan Druart changed: What|Removed |Added Attachment #35986|0 |1 is obsolete|| --- Comment #8 from Jonathan Druart --- Created attachment 36020 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36020&action=edit Bug 13679 : Bug in listing overdues To test 1/ Create some overdues and some issues due in the future 2/ Run the overdues script 3/ Notice item due in the future is in the list 4/ Apply patch 5/ Run script again 6/ Notice in the future not in the list Signed-off-by: Nick Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13679] There is a bug in overdues if you have overdues that match a rule, and have some items due in the future they are included in the list of overdues
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13679 Jonathan Druart changed: What|Removed |Added Severity|normal |major --- Comment #9 from Jonathan Druart --- I am raising the severity of this bug. I confirm it could affect the -t parameter also. For instance, if you have a trigger at day = X and you have 2 overdue items due at today - X and today + X, both will be marked as late. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13497] The pref AddPatronLists should be removed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13497 Jonathan Druart changed: What|Removed |Added Attachment #34817|0 |1 is obsolete|| --- Comment #3 from Jonathan Druart --- Created attachment 36021 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36021&action=edit Bug 13497: Remove the pref AddPatronsLists The pref AddPatronLists does not work as expected if 'generic' is selected. Indeed a patron should be linked to a valid patron category (see the constraint borrowers_ibfk_1 in the DB structure). Test plan: 0/ Confirm that the AddPatronLists does not work as expected if you choose the generic patron types. 1/ Delete all you patron categories and check that the interface invites you to create one. 2/ Confirm that you are able to create a patron and to link it to a patron category you have created. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13719] Store list of objects as needed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13719 --- Comment #3 from Kyle M Hall --- (In reply to Tomás Cohen Arazi from comment #2) > Kyle, what would "Store list of objects" mean? I'm sorry but it is too > generic for my idiomatic limitations! Sorry, I was just posting the code to get it out there. I will be writing up a better explanation and a test plan shortly! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13719] Store list of objects as needed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13719
--- Comment #4 from Kyle M Hall ---
We can both simplify and improve the functioning of Koha::Objects by removing
out reliance on DBIC for set iteration ( first(), next(), reset(), etc ). The
problem is that DBIC destroys and refetches results every time reset() is
called. For example, take the following code:
my $borrowers = Koha::Borrowers->search({ firstname => 'Kyle' }).
my $kyle1 = $borrowers->next();
$borrowers->reset();
my $kyle2 = $borrowers->next();
In this case, we would expect $kyle1 and $kyle2 to refer to the exact same
object in memory, but they do *not*. This is simply a limitation of
DBIx::Class.
However, by handling this issue ourselves, we not only solve the problem, but I
believe we also reduce the complexity of our code.
This is all accomplished without changing the external behavior of the
Koha::Objects module.
Test Plan:
1) Apply this patch
2) prove t/db_dependent/Borrowers.t
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13719] Make Koha::Objects store list of resultant objects on an as needed basis
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13719 Kyle M Hall changed: What|Removed |Added Summary|Store list of objects as|Make Koha::Objects store |needed |list of resultant objects ||on an as needed basis -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13731] New: Suggestions reason
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13731 Bug ID: 13731 Summary: Suggestions reason Change sponsored?: --- Product: Koha Version: 3.18 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: josef.mora...@gmail.com QA Contact: testo...@bugs.koha-community.org When you, as librarian make decisions about purchase suggestions, you can choose one of the SUGGEST authorized value, which describes, why do you decide this way. But, unfortunetely, this reason isn't presented anywhere, it looks like it isn't saved into database either... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13719] Make Koha::Objects store list of resultant objects on an as needed basis
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13719 Kyle M Hall changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13719] Make Koha::Objects store list of resultant objects on an as needed basis
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13719
Kyle M Hall changed:
What|Removed |Added
Attachment #35985|0 |1
is obsolete||
--- Comment #5 from Kyle M Hall ---
Created attachment 36022
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36022&action=edit
Bug 13719 - Make Koha::Objects store list of resultant objects on an as needed
basis
We can both simplify and improve the functioning of Koha::Objects by
removing out reliance on DBIC for set iteration ( first(), next(),
reset(), etc ). The problem is that DBIC destroys and refetches
results every time reset() is called. For example, take the following
code:
my $borrowers = Koha::Borrowers->search({ firstname => 'Kyle' }).
my $kyle1 = $borrowers->next();
$borrowers->reset();
my $kyle2 = $borrowers->next();
In this case, we would expect $kyle1 and $kyle2 to refer to the exact
same object in memory, but they do *not*. This is simply a limitation of
DBIx::Class.
However, by handling this issue ourselves, we not only solve the
problem, but I believe we also reduce the complexity of our code.
This is all accomplished without changing the external behavior of the
Koha::Objects module.
Test Plan:
1) Apply this patch
2) prove t/db_dependent/Borrowers.t
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13595] Checking out an issued item doesn't return it after confirmation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13595 Josef Moravec changed: What|Removed |Added Resolution|--- |WORKSFORME Status|NEW |RESOLVED --- Comment #3 from Josef Moravec --- I can't reproduce it now, so closing this bug. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13413] Koha::Log - an attempt to have sane logging in Koha
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13413
--- Comment #12 from Jonathan Druart ---
Actually this patch is stuck in NSO without any test plan.
Since I really would like to see a logging module integrated into Koha, I just
try to make this moving forward.
So let's test this lazily:
$ git bz apply 13413 # ok
Try to use the module:
diff --git a/C4/Context.pm b/C4/Context.pm
index c5f92ee..9a88758 100644
--- a/C4/Context.pm
+++ b/C4/Context.pm
@@ -107,6 +107,8 @@ use DateTime::TimeZone;
use Module::Load::Conditional qw(can_load);
use Carp;
+use Koha::Log qw(:log with_debug);
+
=head1 NAME
C4::Context - Maintain and manipulate the context of a Koha script
@@ -564,6 +566,7 @@ sub preference {
}
$sysprefs{lc $var} = $value;
+log_debug{"pref $var = $value"};
return $value;
}
diff --git a/mainpage.pl b/mainpage.pl
index ab3a7ab..635a233 100755
--- a/mainpage.pl
+++ b/mainpage.pl
@@ -30,6 +30,8 @@ use C4::Suggestions qw/CountSuggestion/;
use C4::Tags qw/get_count_by_tag_status/;
use Koha::Borrower::Modifications;
+use Koha::Log qw(:log with_debug);
+
my $query = new CGI;
my ( $template, $loggedinuser, $cookie, $flags ) = get_template_and_user(
@@ -42,6 +44,8 @@ my ( $template, $loggedinuser, $cookie, $flags ) =
get_template_and_user(
}
);
+log_debug{'User on the mainpage!'};
+
my $homebranch;
if (C4::Context->userenv) {
$homebranch = C4::Context->userenv->{'branch'};
$ tail -f koha_logs
Go on the mainpage.
boom, module is missing
ok let's install it (no mention in the commit messages)
$ sudo apt-get install liblog-contextual-perl
Go on the mainpage, nothing in the logs.
Ha, debug no defined, let's replace with log_info
Go on the mainpage.
The messages appear in the logs \o/
So the question is: How can I configure a log level for all the application?
perldoc Koha/Log.pm mentions 3 levels: debug, info, warn. What about others?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13413] Koha::Log - an attempt to have sane logging in Koha
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13413
--- Comment #13 from Jonathan Druart ---
Did you read the discussion on bug 8190? There are a lot of ideas on it.
The way to use it is:
my $logger = C4::Context->logger();
$logger->info("OPAC: Search for $query");
You can have a look at the tests for more information.
All the job is mainly done in the constructor (Koha::Utils::Logger->new) and
the write method.
And a syspref controls the log level.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12847] Date comparisons in C4::Members::IssueSlip are broken
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12847 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@biblibre.co ||m Status|Signed Off |ASSIGNED --- Comment #13 from Jonathan Druart --- (In reply to Katrin Fischer from comment #11) > I think the other problem blocking this is that people haven't been able to > see the issue, could we get a more detailed test plan? > Maybe with an example date? Could we get an answer? Please add the syspref value + the dates to reproduce the issue. Confirm the issue is still on master. Back to assigned. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13431] Shared FastMmap file causes issues
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13431 Lennon Mazonde changed: What|Removed |Added CC||okay7...@gmail.com --- Comment #40 from Lennon Mazonde --- (In reply to Martin Renvoize from comment #1) > I'm seeing this issue more and more on IRC as people upgrade their package > installs. > > The symptom is the appearance of the below error when searching, or looking > at MRC Framework pages and a few other places: > > Open of share file /tmp/sharefile-koha-koha failed: Permission denied at > /usr/lib/perl5/Cache/FastMmap.pm line 640. > > The fastest fix I've found to get your system back up and running whilst I > work on a longer term fix, is to: > > 1) Add/Set 'SetEnv MEMCACHED_NAMESPACE="instancename"' per instance you have > running in the apache virtual host configuration > 2) Delete the existing temp file /tmp/somthing-koha-koha > > This will ensure koha creates a seperate temp file for caching pursposes on > a epr instance basis, and the deletion will ensure it happens upon the next > request per instance. Hello, this seems to have worked for me. I have two instances of koha running on my server. After making the adjustments as suggested above, two temp files are now being created- sharefile-koha-xxa, sharefile-koha-xxb. Thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13730] Install required when using web-based installer
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13730 Ravi Joshi changed: What|Removed |Added Priority|P5 - low|P1 - high -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7843] Create RSS for OPAC news
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7843 --- Comment #12 from Jonathan Druart --- Created attachment 36024 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36024&action=edit Bug 7843: Remove the useless use of casAuthentication Certainly a c/p error from opac-main.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7843] Create RSS for OPAC news
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7843 Jonathan Druart changed: What|Removed |Added Attachment #36017|0 |1 is obsolete|| --- Comment #11 from Jonathan Druart --- Created attachment 36023 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36023&action=edit Bug 7843 Create an RSS feed for news in Opac Test plan: * Install the patch * Make shure there is news in the Opac * Go to the Opac (opac-main.pl) * Make shure you see an RSS icon below the news and a short text. * Click the RSS icon and verify that you get an RSS feed that validates. Signed-off-by: Chris Cormack I took the liberty of fixing the copyright statement when signing it off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7843] Create RSS for OPAC news
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7843 --- Comment #13 from Jonathan Druart --- Created attachment 36025 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36025&action=edit Bug 7843: (qa-followup) Create an RSS feed for news in Opac 1/ use strict and warnings are useless, Modern::Perl is used 2/ Prefer to use the interface and theme TT var instead of the hard coded path -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7843] Create RSS for OPAC news
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7843 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13729] Give news in Opac a unique anchor
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13729 Jonathan Druart changed: What|Removed |Added Attachment #36009|0 |1 is obsolete|| --- Comment #3 from Jonathan Druart --- Created attachment 36026 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36026&action=edit Bug 13729 - Give news in Opac a unique anchor This patch introduces the use of the idnew-value from the opac_news table as a base for a unique anchor on each newsitem in Opac. The anchor can be used for linking to specific newsitems and also for improving bug 7843 (RSS stream for news) with a unique link to each item in the RSS stream. Test plan: * Make shure you have a few news in the opac. Best is if it's enough to hide a few beneath the bottom of the window. * Install the patch. * Verify that you can access newitems with links like mykoha/cgi-bin/koha/opac-main.pl#newsitem4 * Experiment with removing newsitems and verify that that the newsitem-id stay unique to each newsitem. Signed-off-by: Magnus Enger Works as advertised. Nice enhancement! Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13729] Give news in Opac a unique anchor
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13729 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10276] Extend IndependentBranches to support groups of libraries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 Kyle M Hall changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10276] Extend IndependentBranches to support groups of libraries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 Kyle M Hall changed: What|Removed |Added Attachment #28358|0 |1 is obsolete|| Attachment #28359|0 |1 is obsolete|| Attachment #28360|0 |1 is obsolete|| Attachment #28361|0 |1 is obsolete|| Attachment #28367|0 |1 is obsolete|| --- Comment #63 from Kyle M Hall --- Created attachment 36027 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36027&action=edit Bug 10276 - Extend IndependentBranches to support groups of libraries This patch adds the ability to have independent library groups. To enable this feature, enable the IndependentBranches system preference. If no libraries are in any independent library groups, IndependentBranches will behave as it always have. If a library is part of an independent library group with one or more libraries, that library will be able to access and modify patrons and items from any library in that group. Let's say we have 3 groups: Group1: LibA LibB LibC Group1: LibD LibE LibF Group3: LibG LibH LibA Note how LibA is in two groups ( Group1 and Group3 ). With this configuration, if IndependentBranches is enabled, libraries will be able to access and edit patrons and items in the following configuration: LibA => LibB, LibC, LibG, LibH LibB => LibA, LibC LibC => LibA, LibB LibD => LibE, LibF LibF => LibD, LibE LibG => LibH, LibA LibH => LibG, LibA Furthermore, let us assume there is a library LibI, which does not belong to any group. That library will only be able to view and edit patrons and items from it's own library. Imagine a library consortium consisting of multiple library systems. This feature would allow a consortium to group libraries by system such that those systems could work independently from one another on a single installation. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Enable IndependentBranches 4) Test independent branches, no changes should be noted 5) Navigate to admin/branches.pl 6) Create a new Independent library group 7) Add your library and some other libraries to that group 8) Re-test IndependentBranches, everything should work as previously, but instead of being limited to just your library, you should have access to everything within your library group. Example: Try to edit an item. If the item is owned by a library in your group, you should be able to edit it. Signed-off-by: Joel Sasse Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10276] Extend IndependentBranches to support groups of libraries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 Kyle M Hall changed: What|Removed |Added Attachment #36027|0 |1 is obsolete|| --- Comment #64 from Kyle M Hall --- Created attachment 36028 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36028&action=edit Bug 10276 - Extend IndependentBranches to support groups of libraries This patch adds the ability to have independent library groups. To enable this feature, enable the IndependentBranches system preference. If no libraries are in any independent library groups, IndependentBranches will behave as it always have. If a library is part of an independent library group with one or more libraries, that library will be able to access and modify patrons and items from any library in that group. Let's say we have 3 groups: Group1: LibA LibB LibC Group1: LibD LibE LibF Group3: LibG LibH LibA Note how LibA is in two groups ( Group1 and Group3 ). With this configuration, if IndependentBranches is enabled, libraries will be able to access and edit patrons and items in the following configuration: LibA => LibB, LibC, LibG, LibH LibB => LibA, LibC LibC => LibA, LibB LibD => LibE, LibF LibF => LibD, LibE LibG => LibH, LibA LibH => LibG, LibA Furthermore, let us assume there is a library LibI, which does not belong to any group. That library will only be able to view and edit patrons and items from it's own library. Imagine a library consortium consisting of multiple library systems. This feature would allow a consortium to group libraries by system such that those systems could work independently from one another on a single installation. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Enable IndependentBranches 4) Test independent branches, no changes should be noted 5) Navigate to admin/branches.pl 6) Create a new Independent library group 7) Add your library and some other libraries to that group 8) Re-test IndependentBranches, everything should work as previously, but instead of being limited to just your library, you should have access to everything within your library group. Example: Try to edit an item. If the item is owned by a library in your group, you should be able to edit it. Signed-off-by: Joel Sasse Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10276] Extend IndependentBranches to support groups of libraries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 --- Comment #65 from Kyle M Hall --- Created attachment 36029 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36029&action=edit Bug 10276 [QA Followup] - Extend IndependentBranches to support groups of libraries Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10276] Extend IndependentBranches to support groups of libraries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 --- Comment #68 from Kyle M Hall --- Created attachment 36032 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36032&action=edit Bug 10276 [QA Followup 4] - Fix edit links on catalogue/detail.pl Bug 11746 has been pushed to master, which is good. However, this means that the links displayed in the catalogue/details.pl page are displaying Edit on items which the user should not have edit links for. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10276] Extend IndependentBranches to support groups of libraries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 --- Comment #67 from Kyle M Hall --- Created attachment 36031 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36031&action=edit Bug 10276 [QA Followup 3] - Fix inability to change patron's branch Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10276] Extend IndependentBranches to support groups of libraries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 --- Comment #66 from Kyle M Hall --- Created attachment 36030 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36030&action=edit Bug 10276 [QA Followup 2] - Remove stringify, use placeholders for db queries Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12976] Refactor VAT and price calculation - invoice page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12976 --- Comment #21 from Tomás Cohen Arazi --- Oh, sorry for that. I think it was a typo using git-bz. Will test right now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10278] Add ability to hide items and records from search results for Independent Branches
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10278 Kyle M Hall changed: What|Removed |Added Attachment #23638|0 |1 is obsolete|| --- Comment #12 from Kyle M Hall --- Created attachment 36033 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36033&action=edit Bug 10278 - Add ability to hide items and records from search results for Independent Branches For the staff intranet, enabling IndependentBranchesRecordsAndItems will automatically add a branch limit filter to the search results thus hiding all records without one or more items owned by the logged in library. In add addition, all items whose homebranch is not that libraries will be filtered and hidden from the search results and record details. This system preference will not affect the OPAC, unless the environment variable BRANCHCODE is defined in the koha-httpd.conf file. If it is defined, the same filters are applied to the OPAC, but based on the branchcode value of the environment variable BRANCHCODE, rather than the logged in branch. Test Plan: 1) Apply patch 2) Run updatedatabase.pl 3) Perform a search that will give results for both records which have items owned by the logged in library, and records which have no items owned by the logged in library. 4) Enable the new system preference IndependentBranchesRecordesAndItems 5) Perform the same search again, any records without items owned by the currently logged in library should not appear. Signed-off-by: Joel Sasse -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12976] Refactor VAT and price calculation - invoice page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12976 --- Comment #22 from Tomás Cohen Arazi --- I'm sorry Jonathan. It is now pushed. I might have messed up some of my working branches at some point. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12970] Refactor VAT and price calculation - basket page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12970 --- Comment #16 from Tomás Cohen Arazi --- I'm sorry Jonathan. It is now pushed. I might have messed up some of my working branches at s ome point. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13568] OAI Server doesn't handle properly resumption token
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13568 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||tomasco...@gmail.com --- Comment #8 from Tomás Cohen Arazi --- Patch pushed to master. Thanks Frederic! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13712] Missing newline in DB update 3.19.00.010
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13712 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #4 from Tomás Cohen Arazi --- Patch pushed to master. Thanks Magnus! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13244] GetCancelledOrders and GetOrders can be merged
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13244 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Patch doesn't apply CC||tomasco...@gmail.com --- Comment #19 from Tomás Cohen Arazi --- Unfortunately this one is not cleanly applying after I pushed 12976 and 12970. Please rebase. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10276] Extend IndependentBranches to support groups of libraries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276
--- Comment #69 from M. Tompsett ---
Comment on attachment 36030
--> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36030
Bug 10276 [QA Followup 2] - Remove stringify, use placeholders for db queries
Review of attachment 36030:
-->
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=10276&attachment=36030)
-
::: C4/Acquisition.pm
@@ +2401,5 @@
> +my @branches = GetIndependentGroupModificationRights();
> +$query .=
> + " AND ( borrowers.branchcode = ? OR borrowers.branchcode IN ( "
> + . join( ',', ('?') x @branches ) . " ) ) ";
> +push( @query_params, @branches );
There is @branches+1 ?'s, but only @branches parameters.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13244] GetCancelledOrders and GetOrders can be merged
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13244 Jonathan Druart changed: What|Removed |Added Attachment #35624|0 |1 is obsolete|| Attachment #35625|0 |1 is obsolete|| Attachment #35626|0 |1 is obsolete|| --- Comment #20 from Jonathan Druart --- Created attachment 36034 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36034&action=edit Bug 13244: Merge GetOrders and GetCancelledOrders These two subroutines did the same job (same select, same join, etc.) Test plan: Go on the basket list page and verify you see the pending and the cancelled baskets. Signed-off-by: Marcel de Rooy Two small things are adjusted in separate follow-ups. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13244] GetCancelledOrders and GetOrders can be merged
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13244 Jonathan Druart changed: What|Removed |Added Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13244] GetCancelledOrders and GetOrders can be merged
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13244 --- Comment #22 from Jonathan Druart --- Rebased, second patch skipped (not used anymore). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13244] GetCancelledOrders and GetOrders can be merged
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13244 --- Comment #21 from Jonathan Druart --- Created attachment 36035 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36035&action=edit Bug 13244: (follow-up) fix mixup to and from in the sql query Signed-off-by: Marcel de Rooy Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13722] Titles with articles not sorting correctly in lists
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13722 Owen Leonard changed: What|Removed |Added Version|3.16|master --- Comment #1 from Owen Leonard --- This bug could just as easily be titled "Teach Koha how to ignore nonfiling characters," because Koha doesn't take nonfiling characters into account at all. As far as I understand it, Zebra can be configured to ignore certain stop words, and some tables which are sorted by JavaScript are configured to ignore articles on titles. Anything which is sorted by MySQL is going to be ignorant of stop words or nonfiling characters. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13728] koha-translate -l -a shows po files instead of language codes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13728 Jonathan Druart changed: What|Removed |Added Attachment #36013|0 |1 is obsolete|| --- Comment #3 from Jonathan Druart --- Created attachment 36036 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36036&action=edit Bug 13728: koha-translate -l -a shows po files instead of language codes This patch corrects the call to 'basename' inside the script so it correctly shows the language code when asked to list the available languages. To test: - On a packages install, run: $ koha-translate --list --available => FAIL: It shows: am-Ethi-opac-bootstrap.po ar-Arab-opac-bootstrap.po az-AZ-opac-bootstrap.po be-BY-opac-bootstrap.po ben-opac-bootstrap.po ... - Apply the patch - Copy the patched debian/scripts/koha-translate script to your packages setup. - Run: $ koha-translate --list --available => SUCCESS: It shows: am-Ethi ar-Arab az-AZ be-BY ben ... - Sign off :-D Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Chris Cormack Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13728] koha-translate -l -a shows po files instead of language codes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13728 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13732] New: Incorrect total charges on the checkouts table in a patron record
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13732 Bug ID: 13732 Summary: Incorrect total charges on the checkouts table in a patron record Change sponsored?: --- Product: Koha Version: 3.18 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: david.robe...@ptfs-europe.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Created attachment 36037 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36037&action=edit Screenshot showing 0.00 total under the charges column The patron checkouts table contains a column for charges. The total at the bottom of this column is the total fines, not total charges. Therefore, the situation can arise where the list of charges each contains 0.00 in the charge column, but the total contains a different value entirely, for example: Item 1 : 0.00 Item 2 : 0.00 Total : 8.00 The charges column is not the same as fines, so the charges total shouldn't be displaying the fines total. A possible solution might be to include a column for fines in addition to the charges column (possibly instead of the replacement price field, which is of little use in this table). The attached screenshot is from a 3.10.13 system, but the problem is still apparent on a 3.18.x system. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11847] Display basketgroup closed date at OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11847 Jonathan Druart changed: What|Removed |Added Summary|[DEPENDS ON 11708] Display |Display basketgroup closed |basketgroup closed date at |date at OPAC |OPAC| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11431] Add additional sound options for warnings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431
Jonathan Druart changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #69 from Jonathan Druart ---
(In reply to paxed from comment #68)
> (In reply to Kyle M Hall from comment #67)
> > Created attachment 35846 [details] [review] [review]
>
> Just wondering if http:// vs https:// matters for this:
>
> +// This is way faster than substring
> +if ( ! ( sound.charAt(4) == ':' && sound.charAt(5) == '/' &&
> sound.charAt(6) == '/' ) ) {
Good catch, maybe a regex is much more appropriate here.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13686] Add a hint about collation to the "alphabet" syspref
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13686 Jonathan Druart changed: What|Removed |Added Attachment #35958|0 |1 is obsolete|| --- Comment #14 from Jonathan Druart --- Created attachment 36038 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36038&action=edit Bug 13686 Add a hint about collation to the alphabet syspref New attempt from a fresh branch. Test plan: * Look at the alphabet syspref. * Install the patch. * Look again at the alphabet syspref and you should see a short hint about collation. Thanks for the patience - I already learned a few new things about Git with this patch. Text appears as expected. Signed-off-by: Marc Véron Signed-off-by: Jonathan Druart Amended patch: add a br tag -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13686] Add a hint about collation to the "alphabet" syspref
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13686 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13682] Capitalization: Holds Queue
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13682 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13682] Capitalization: Holds Queue
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13682 Jonathan Druart changed: What|Removed |Added Attachment #35955|0 |1 is obsolete|| --- Comment #3 from Jonathan Druart --- Created attachment 36039 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36039&action=edit Bug 13682 - Capitalization: Holds Queue This patch changes capitalization of Holds Queue to Holds queue in koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueu$ To test: Apply patch Go to Circulation > Holds queue page Verify that the capitalization is correct Signed-off-by: Magnus Enger Works as advertised. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13728] koha-translate -l -a shows po files instead of language codes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13728 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||tomasco...@gmail.com --- Comment #4 from Tomás Cohen Arazi --- Patch pushed to master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11400] Show "Login as a different user" instead of "Logout" if not enough premissions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11400 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@biblibre.co ||m, oleon...@myacpl.org --- Comment #14 from Jonathan Druart --- It does not look much nicer for me :) Ccing Owen to get his opinion. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 Jonathan Druart changed: What|Removed |Added Assignee|oleon...@myacpl.org |hector.hecax...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Failed QA CC||jonathan.dru...@biblibre.co ||m --- Comment #37 from Jonathan Druart --- Hello Héctor, Please have a look at the patch, it adds a massive chmod on a big part (all) of the Koha code :) 2310 files changed, 1370 insertions(+), 611 deletions(-) and 1.56Mb -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13686] Add a hint about collation to the "alphabet" syspref
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13686 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@biblibre.co ||m --- Comment #15 from Jonathan Druart --- oleonard: Joubu: I suggest "Changing collation in the database for the 'surname' column of the 'borrowers' table is helpful to make browsing by last name work in members-home.pl when using an alphabet outside of A-Z" oleonard: I don't like referring to "members-home.pl" but I don't know a better way to say it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13686] Add a hint about collation to the "alphabet" syspref
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13686 --- Comment #16 from Jonathan Druart --- Created attachment 36040 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36040&action=edit Bug 13686: Change wording Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13732] Incorrect total charges on the checkouts table in a patron record
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13732 David Roberts changed: What|Removed |Added CC||david.roberts@ptfs-europe.c ||om -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13593] 'Stock number' should be 'Inventory number'
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13593 Jonathan Druart changed: What|Removed |Added Attachment #35998|0 |1 is obsolete|| --- Comment #6 from Jonathan Druart --- Created attachment 36041 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36041&action=edit Bug 13593: 'stock number' should be 'inventory number' To make Koha easier to use, we should use terms consistently. This patch fixes some occurrences of 'stock number' to be 'inventory number' as this is also the term used in the frameworks. Item search, accessible via the link from staff's advanced search 1) Do a search for items, but choose CSV as output 2) Verify that the header row says 'inventory number' Acquisition 3) Set AcqCreateItem to 'order' 4) Create a new order, check the labels on the item table in the order 5) Receive the order, check the labels on the item table on receive 6) Set AcqCreateItem to 'receive' 7) Check the item table on receiving an order Followed test plan (including item search with JavaScipt disabled). Headers / labels display as expected. Signed-off-by: Marc Véron Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13593] 'Stock number' should be 'Inventory number'
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13593 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13593] 'Stock number' should be 'Inventory number'
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13593 --- Comment #7 from Jonathan Druart --- Created attachment 36042 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36042&action=edit Bug 13593: (follow-up) 'stock number' should be 'inventory number' Add one more. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12272] Refactor C4::Service API into Koha::Service class
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12272 --- Comment #1 from Kyle M Hall --- Created attachment 36043 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36043&action=edit Bug 12272 - Add new Koha::Service class -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13733] New: Give librarians the ability to add messages to an item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13733 Bug ID: 13733 Summary: Give librarians the ability to add messages to an item Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: k...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com Some librarians would like the ability to leave messages attached to an item ( outside the scope of itemnotes and itemnotes_nonpublic ). This feature would give the librarians the ability to add and remove messages of arbitrary types defined in an authorised value list. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13733] Give librarians the ability to add messages to an item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13733 Kyle M Hall changed: What|Removed |Added Depends on||13563, 12272 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13733] Give librarians the ability to add messages to an item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13733 --- Comment #1 from Kyle M Hall --- Created attachment 36044 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36044&action=edit Bug 13733 - Give librarians the ability to add messages to an item Some librarians would like the ability to leave messages attached to an item ( outside the scope of itemnotes and itemnotes_nonpublic ). This feature would give the librarians the ability to add and remove messages of arbitrary types defined in an authorised value list. Test Plan: 1) Apply this patch set 2) Run updatedatabase.pl 3) Create some ITEM_MESSAGE authorised values 4) View an item's details 5) Try adding and deleting messages on an item -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13563] AngularJS
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13563 Kyle M Hall changed: What|Removed |Added Blocks||13733 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12272] Refactor C4::Service API into Koha::Service class
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12272 Kyle M Hall changed: What|Removed |Added Blocks||13733 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13733] Give librarians the ability to add messages to an item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13733 Kyle M Hall changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13733] Give librarians the ability to add messages to an item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13733 Kyle M Hall changed: What|Removed |Added Attachment #36044|0 |1 is obsolete|| --- Comment #2 from Kyle M Hall --- Created attachment 36045 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36045&action=edit Bug 13733 - Give librarians the ability to add messages to an item Some librarians would like the ability to leave messages attached to an item ( outside the scope of itemnotes and itemnotes_nonpublic ). This feature would give the librarians the ability to add and remove messages of arbitrary types defined in an authorised value list. Test Plan: 1) Apply this patch set 2) Run updatedatabase.pl 3) Create some ITEM_MESSAGE authorised values 4) View an item's details 5) Try adding and deleting messages on an item -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11193] Update Queryparser conf file to take into account changes made by bug 8252
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11193 Paola Rossi changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #20 from Paola Rossi --- I've applied the patches against master 3.19.00.011 head 7741. My installation is a MARC21 one. The QP-file was the one in the $KOHA_KONF's XML element: /.-dev/etc/searchengine/queryparser.yaml which I had linked to the truly patched QP-file [not in the dev library]: //etc/searchengine/queryparser.yaml via a symb link. I've set the syspref "UseQueryParser" to "Do not try" and to "Try", as required, to test. The following 5 search test cases had been submitted to the intranet catalog's simple search. To the log activated by: >zebrasrv -f $KOHA_KONF these were these differences between "Try" and "Do not try": 1) bio:a try: RPN @attrset Bib-1 @attr 4=6 @attr 5=1 @attr 1=8834 @attr 2=102 a dnt: RPN @attrset Bib-1 @attr 1=8834 a 2) aceee [i.e. a single word in simple search...] try: RPN @attrset Bib-1 @or @or @attr 4=6 @attr 5=1 @attr 1=1016 @attr 2=102 aceee @attr 4=6 @attr 5=1 @attr 9=20 @attr 2=102 aceee @attr 4=6 @attr 5=1 @attr 9=34 @attr 2=102 aceee dnt: RPN @attrset Bib-1 @attr 1=1016 @attr 4=6 @attr 5=1 ACEEE 3) tpubdate:c try: RPN @attrset Bib-1 @attr 4=6 @attr 5=1 @attr 1=8806 @attr 2=102 c dnt: RPN @attrset Bib-1 @attr 1=1016 @attr 4=6 @attr 5=1 tpubdate:c 4) pn:rossi try: RPN @attrset Bib-1 @attr 4=6 @attr 5=1 @attr 1=Personal-name @attr 2=102 rossi dnt: RPN @attrset Bib-1 @attr 1=Personal-name rossi For documentation, no differences about these other searching cases: 5) pn,wrdl:rossi [on simple search] RPN @attrset Bib-1 @attr 1=Personal-name @attr 4=6 rossi 6) Personal Name rossi [on advanced search]: RPN @attrset Bib-1 @attr 1=Personal-name @attr 4=6 @attr 5=1 rossi IMO in 1), 3) and 4) desc rilevance has been added. In 3) on dnt the index "tpubdate" has not been recognized (IMO RIGHT) and so it has become the keyword index 1016. Are those differences real errors? I'm not sure. For now I pass the patch to "Failed QA" status. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13727] Validation of authorized values
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13727 Owen Leonard changed: What|Removed |Added Version|3.18|master Assignee|gmcha...@gmail.com |koha-b...@lists.koha-commun ||ity.org Severity|enhancement |normal Component|Cataloging |System Administration CC||gmcha...@gmail.com OS|Linux |All Hardware|PC |All -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13733] Give librarians the ability to add messages to an item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13733 Kyle M Hall changed: What|Removed |Added Status|Needs Signoff |BLOCKED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10276] Extend IndependentBranches to support groups of libraries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276 M. Tompsett changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #70 from M. Tompsett --- For reason given in comment #69. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13730] Install required when using web-based installer
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13730 Owen Leonard changed: What|Removed |Added Resolution|--- |INVALID Status|NEW |RESOLVED --- Comment #1 from Owen Leonard --- This sounds like a support request rather than a bug report. Support requests should be made on the Koha mailing list, on IRC, or by contracting with a support vendor. All these options are linked to here: http://koha-community.org/support/ Be sure to include details about the version of Koha you're using and the method of installation. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13731] Suggestions reason
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13731 Owen Leonard changed: What|Removed |Added Version|3.18|master Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10344] Omnibus: add RDA support to Koha
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10344 Nicole C. Engard changed: What|Removed |Added Blocks||13734 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13734] New: RDA: Display 33xs
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13734 Bug ID: 13734 Summary: RDA: Display 33xs Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: neng...@gmail.com QA Contact: testo...@bugs.koha-community.org Depends on: 10344 Created attachment 36046 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36046&action=edit example It would be nice to have the option to see the new 33x fields in the staff and the OPAC. They should have their own ID tag though so they can be hidden by those who don't want to see them. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13731] Suggestions reason
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13731 --- Comment #1 from Owen Leonard --- When viewing accepted suggestions in the staff client you should see a "status" column which includes the reason which was specified when the suggestion was accepted. The information is stored in the "reason" column in the suggestions table. Are you not seeing it like that, or are you expecting it to display somewhere else? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
