[Koha-bugs] [Bug 7290] new permission for receiving
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7290 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Patch doesn't apply --- Comment #53 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Sorry. patch no longer applies and conflicts are not trivial - please fix! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13414] Enable right truncation with search by relevance
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13414 --- Comment #15 from David Cook dc...@prosentient.com.au --- (In reply to Katrin Fischer from comment #13) David, Team Lyon3, how do we proceed here? Would you be ok with me changing the sysprefs.sql file back to the old label? It doesn't really matter too much what's in sysprefs.sql, since it won't show up in the web UI, but I figure keeping the original label is probably the best idea. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13889] Add information about cron jobs to system log
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13889 --- Comment #1 from Marc Véron ve...@veron.ch --- Created attachment 37082 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37082action=edit Bug 13889 - Add information about cron jobs to system log This patch adds information about cron jobs performed and make it viewable under Home Tools Logs (Browse system logs) To test: Apply patch - Got to system preferences and set 'CronjobLog' to: [Log] information from cron jobs. - Run some cron jobs - Go to Home Tools Logs - Verify that you have a selection 'Cron jobs' in drop-down 'Module'. Select it with Action All and Submit. - Output should show Dae/time and info about Cron jobs -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13889] Add information about cron jobs to system log
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13889 Marc Véron ve...@veron.ch changed: What|Removed |Added Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13417] New permission to allow staff to remove public lists
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417 --- Comment #44 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Hm, have added bug 13888 with my thoughts. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13888] New: 'Lists' permission should allow/disallow using the lists module in staff
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13888 Bug ID: 13888 Summary: 'Lists' permission should allow/disallow using the lists module in staff Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Lists Assignee: gmcha...@gmail.com Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl With bug 13417 a new permission was added to allow/disallow deletion of public lists. The lists permission doesn't work like other module level permissions as turning it off won't disallow use of the lists module. It would be nice if this could be added. It might need a 'remaining lists permissions' permission, so that you can only disallow the deletion of public lists but allow general use of the module. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13889] New: Add information about cron jobs to system log
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13889 Bug ID: 13889 Summary: Add information about cron jobs to system log Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: ve...@veron.ch QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com The system log should contain information about cron jobs performed and make it viewable under Home Tools Logs (Browse system logs) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13417] New permission to allow staff to remove public lists
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13417 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #43 from Katrin Fischer katrin.fisc...@bsz-bw.de --- I think it would be more clean to say 'lists' is general list permission with 'manage public lists' and 'remaining list permissions' as the sub permissions - that way it would work like the other module permissions. There is a mismatch there now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13743] Primary key for issues-table
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13743 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13743] Primary key for issues-table
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13743 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13872] Typographical error on columns_settings.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13872 --- Comment #6 from Nicole C. Engard neng...@gmail.com --- This is a-ok the way it was, just wanted you to know that you don't have to go through every help file and fix it because with the next release they'll probably get put back since I just copy from the manual and paste to the help files. Nicole -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13888] 'Lists' permission should allow/disallow using the lists module in staff
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13888 Nicole C. Engard neng...@gmail.com changed: What|Removed |Added CC||neng...@gmail.com --- Comment #1 from Nicole C. Engard neng...@gmail.com --- I agree! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13878] Typo in help file (aqbudgets.tt)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13878 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13878] Typo in help file (aqbudgets.tt)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13878 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #37025|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 37084 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37084action=edit [PASSED QA] Bug 13878 - Typo in help file (aqbudgets.tt) Test plan: 1) Go to url 'koha-tmpl/intranet-tmpl/prog/en/modules/help/admin/aqbudgets.tt:15' and check the typo wan or go to Administration Acquisition parameters Funds Help 2) Apply the patch 3) Repeat step 1 and check if the typo is fixed. Sponsored-by: Universidad de El Salvador Signed-off-by: Hector Eduardo Castro Avalos hector.hecax...@gmail.com Typo is fixed. Signed-off-by: Marc Véron ve...@veron.ch Signed-off-by: Katrin Fischer katrin.fischer...@web.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13822] Patron autocomplete search is severly limited
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13822 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Status|Signed Off |In Discussion --- Comment #6 from Katrin Fischer katrin.fisc...@bsz-bw.de --- I am not sure about this change. With the patch applied a search for sch will bring up Fischer - so it does a 'contains' search. I think on a big system this will make the autocomplete harder to handle - it might bring up a lot of unrelated searches. There might be reasons to make the autocomplete more strict than the normal patron search, where you can pick your options. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13876] Permission issues on updating via installer - dev installations
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13876 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #12 from Katrin Fischer katrin.fisc...@bsz-bw.de --- This fixes the problem for me, my database updates are working again! As the QA follow-up has more lines than the initial patch ;) I'd like to get another QA view from Jonathan or another QA person on this. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13872] Typographical error on columns_settings.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13872 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #37026|0 |1 is obsolete|| --- Comment #7 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 37083 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37083action=edit [PASSED QA] Bug 13872 - Typographical error on columns_settings.tt Test plan: 1) Go to url 'koha-tmpl/intranet-tmpl/prog/en/modules/help/admin/columns_settings.tt' line 9 and check the typo columsn and change for columns. 2) See also changes for Column settings to Columns settings at lines 3 and 15 3) Apply the patch 4) Repeat step 1 and chek if the typo is fixed or go to Administration Additional parameters Configure columns and go to Help page. Sponsored-by: Universidad de El Salvador Signed-off-by: Hector Eduardo Castro Avalos hector.hecax...@gmail.com Typo is fixed Signed-off-by: Marc Véron ve...@veron.ch Signed-off-by: Katrin Fischer katrin.fischer...@web.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13872] Typographical error on columns_settings.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13872 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13855] Fastadd framework has 2x 100$c, missing 100$a
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13855 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Severity|enhancement |normal --- Comment #3 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Updating this to a bug fix. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13601] Get rid of DateTime::Format::DateParse
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #36746|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13601] Get rid of DateTime::Format::DateParse
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #36747|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13601] Get rid of DateTime::Format::DateParse
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #36756|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13601] Get rid of DateTime::Format::DateParse
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #36933|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13601] Get rid of DateTime::Format::DateParse
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #36745|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13601] Get rid of DateTime::Format::DateParse
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11999] Add two checks in CanBookBeReserved and CanItemBeReserved
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11999 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #23 from Katrin Fischer katrin.fisc...@bsz-bw.de --- This seems to break one of the existing tests, please check: not ok 52 - Reserving a 'PEGI 16' Biblio by a 15 year old borrower fails # Failed test 'Reserving a 'PEGI 16' Biblio by a 15 year old borrower fails' # at t/db_dependent/Reserves.t line 498. # got: 'none_available' # expected: 'ageRestricted' ok 53 - Reserving a 'PEGI 16' Biblio by a 30 year old borrower succeeds # Looks like you failed 1 test of 53. Please also include a short explanation in your new tests: ok 35 - cannot request item if policy that matches on bib-level item type forbids it (bug 9532) ok 36 ok 37 ok 38 ok 39 - Waiting reserve beyond max pickup delay *not* canceled on holiday -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13876] Permission issues on updating via installer - dev installations
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13876 --- Comment #11 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 37095 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37095action=edit [SIGNED OFF] Bug 13876: [QA Follow-up] Resolve updatedatabase logfile issues This patch removes the test on write permissions of the logdir. It uses File::Temp to generate a file in the logdir or otherwise in a system tmp dir. This resolves issues with both write permissions as well as SELinux denials. Note that after generating an empty file, we are appending to it in the system statement. Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl Signed-off-by: Katrin Fischer katrin.fischer...@web.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13876] Permission issues on updating via installer - dev installations
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13876 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #37052|0 |1 is obsolete|| Attachment #37053|0 |1 is obsolete|| --- Comment #10 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 37094 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37094action=edit [SIGNED OFF] Bug 13876: Fallback to /tmp if logdir is not writable If the logdir directory is not writable by the koha user, the installer should not explode. This patch uses a temporary directory as a fallback. That means that the history won't be kept. Test plan: 0/ Generate an update (modify updatedatabase.pl and kohaversion) 1/ Make sure the permission are not correct on $logdir 2/ Go on the interface and execute the update entry. 3/ Confirm that the log has been created in a temporaty directory. Retry with correct permissions and confirm the log will be created in $logdir. Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl Adding a follow-up for completely resolving encountered issues. Signed-off-by: Katrin Fischer katrin.fischer...@web.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12197] Exceeding the maxreserves preference does not prevent librarian from placing the hold
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12197 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #13 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Kyle, can you please look into Jonathan's last comment? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13863] Datatables paging for cities and search history pages is broken
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13863 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #36985|0 |1 is obsolete|| --- Comment #7 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 37097 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37097action=edit [3.18.x] Bug 13863: Fix Datatables paging on the cities and search history pages Test plan: Go on admin/cities.pl and catalogue/search-history.pl and confirm the pagination is not broken anymore. Signed-off-by: Brendan Gallagher bren...@bywatersolutions.com Signed-off-by: Katrin Fischer katrin.fisc...@bsz-bw.de Fixed conflict so patch applies on 3.18.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13601] Get rid of DateTime::Format::DateParse
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601 --- Comment #43 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 37093 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37093action=edit [PASSED QA] Bug 13601: The fallback regex should contain the time part On displaying a sql date, if the dateformat is not set to sql, the output should contain the date. In the previous version, the fallback regex (used for sql format) did not included the time part (hh:mm:ss). Checked out an item with due date an ddue time. Time displays as expected. Signed-off-by: Marc Véron ve...@veron.ch Signed-off-by: Katrin Fischer katrin.fischer...@web.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13601] Get rid of DateTime::Format::DateParse
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #36748|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13601] Get rid of DateTime::Format::DateParse
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #37023|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13601] Get rid of DateTime::Format::DateParse
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601 --- Comment #42 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 37092 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37092action=edit [PASSED QA] Bug 13601: t/Letters.t needs to mock the dateformat pref Test passes OK. Signed-off-by: Marc Véron ve...@veron.ch Signed-off-by: Katrin Fischer katrin.fischer...@web.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13601] Get rid of DateTime::Format::DateParse
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601 --- Comment #40 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 37090 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37090action=edit [PASSED QA] Bug 13601: Add a fallback check for compability with existing code There are a lot of places where the date comes from the DB but the dateformat parameter is not set to 'sql'. dt_from_string needs to fallback with this format if the pref format does not match. Signed-off-by: Marc Véron ve...@veron.ch Signed-off-by: Katrin Fischer katrin.fischer...@web.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13601] Get rid of DateTime::Format::DateParse
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601 --- Comment #37 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 37087 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37087action=edit [PASSED QA] Bug 13601: Add tests to highlight the problems with DateTime::Format::DateParse Test behaves as expected (Fail as expected with first patch only, OK after 3rd patch) Signed-off-by: Marc Véron ve...@veron.ch Signed-off-by: Katrin Fischer katrin.fischer...@web.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13601] Get rid of DateTime::Format::DateParse
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601
--- Comment #41 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 37091
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37091action=edit
[PASSED QA] Bug 13601: Fix special case in basket.pl
There is a badly managed date in acqui/basket.pl:
if the date is 15/01/2015 (metric format), it will become
2015-1-15 after the following line:
$estimateddeliverydate = $year-$month-$day;
Add_Delta_Days is used at several place, and the ouput is forced to
display date on 4 digits and month/day on 2 digits.
This patch does the same thing for $estimateddeliverydate.
Note that I previously developed a patch to take this format into account (with
missing 0)
in Koha::DateUtils::dt_from_string, but I don't think it's a good idea
to manage bad formated dates.
We will certainly find some issues after previous patches, but it will permit
to catch
them!
IMO it's preferable than to keep them hidden.
The patch was:
diff --git a/Koha/DateUtils.pm b/Koha/DateUtils.pm
index 5fe2653..4434a67 100644
--- a/Koha/DateUtils.pm
+++ b/Koha/DateUtils.pm
@@ -72,17 +72,17 @@ sub dt_from_string {
my $fallback_re = qr|
(?year\d{4})
-
-(?month\d{2})
+(?month\d{1,2})
-
-(?day\d{2})
+(?day\d{1,2})
|xms;
if ( $date_format eq 'metric' ) {
# metric format is dd/mm/[ hh:mm:ss]
$regex = qr|
-(?day\d{2})
+(?day\d{1,2})
/
-(?month\d{2})
+(?month\d{1,2})
/
(?year\d{4})
|xms;
@@ -90,9 +90,9 @@ sub dt_from_string {
elsif ( $date_format eq 'us' ) {
# us format is mm/dd/[ hh:mm:ss]
$regex = qr|
-(?month\d{2})
+(?month\d{1,2})
/
-(?day\d{2})
+(?day\d{1,2})
/
(?year\d{4})
|xms;
diff --git a/t/DateUtils.t b/t/DateUtils.t
index 886e1d6..0877240 100755
--- a/t/DateUtils.t
+++ b/t/DateUtils.t
@@ -189,3 +189,8 @@ is( output_pref( { dt = $dt } ), '31/01/2015 12:34',
'dt_from_string should mat
# date before 1900
$dt = dt_from_string('01/01/1900');
is( output_pref( { dt = $dt, dateonly = 1 } ), '01/01/1900',
'dt_from_string should manage date 1900' );
+
+# missing 0
+$dt = dt_from_string('1/1/2015');
+is( output_pref( { dt = $dt, dateonly = 1 } ), '01/01/2015',
'dt_from_string should generate a DT object even if 0 are missing' );
Works as expected.
Signed-off-by: Marc Véron ve...@veron.ch
Signed-off-by: Katrin Fischer katrin.fischer...@web.de
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13601] Get rid of DateTime::Format::DateParse
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601 --- Comment #39 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 37089 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37089action=edit [PASSED QA] Bug 13601: get rid of DateTime::Format::DateParse This module is used in C4::Members::GetPendingIssues too, but we can use dt_from_string. Test plan: 1/ Verify that prove t/db_dependent/Members/GetPendingIssues.t returns green 2/ On the patron pending issue list, verify that the issue and the due dates are correctly displayed. Tested together with other patches (except Fix special cases). Worked as expected. Signed-off-by: Marc Véron ve...@veron.ch Signed-off-by: Katrin Fischer katrin.fischer...@web.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13601] Get rid of DateTime::Format::DateParse
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13601
--- Comment #38 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 37088
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37088action=edit
[PASSED QA] Bug 13601: Make dt_from_string not using
DateTime::Format::DateParse
For a couple of reasons, dt_from_string should not use
DateTime::Format::DateParse:
1/ It does not manage date 1900, certainly caused by l.47 of this
module:
$p{ year } = $year ? $year + 1900 : DateTime-now-year;
2/ It considers 31/01/2015 as a valid us date, which is not.
Test plan:
1/ Verify that
prove t/DateUtils.t
returns green
2/ Play with dates in Koha (yes I know, it's vague...)
3/ Try to find a regression with dates
4/ Create a date with year = 1900 and confirm it works
QA comment:
Why the sql format switch was:
-$date_string =~
-s/(\d{4})(\d{2})(\d{2})\s+(\d{2})(\d{2})(\d{2})/$1-$2-$3T$4:$5:$6/;
From where a date like mmdd hhmmss can come?
Tested patches 1 - 3 together. Worked as expected.
Signed-off-by: Marc Véron ve...@veron.ch
Signed-off-by: Katrin Fischer katrin.fischer...@web.de
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #103 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Hi Julian, I think the common entry page to subscriptions for parons in the OPAC is opac-detail subscriptions tab. This view is labelled as 'Normal view' when you look at it from the the full history page. I think adding the information there the same way we have it on the full history page would make sense to me. I am a bit torn about the feature still, but I think with that follow-up it would make enough sense to me to pass QA. Patches tested ok so far. :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13841] Returns via backdating or SIP2 can create new fines with an amount outstanding of 0
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13841 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13841] Returns via backdating or SIP2 can create new fines with an amount outstanding of 0
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13841 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #36964|0 |1 is obsolete|| Attachment #36965|0 |1 is obsolete|| --- Comment #7 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 37085 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37085action=edit [PASSED QA] Bug 13841 - Unit Test Signed-off-by: Jen DeMuth jdem...@roseville.ca.us Signed-off-by: Katrin Fischer katrin.fischer...@web.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13841] Returns via backdating or SIP2 can create new fines with an amount outstanding of 0
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13841 --- Comment #8 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 37086 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37086action=edit [PASSED QA] Bug 13841 - Returns via backdating or SIP2 can create new fines with an amount outstanding of 0 Due to the way AddReturn and UpdateFine work, if you pass in a return date to AddReturn, and that item has a calculated fine of 0, Koha will insert the 0 amount fine into accountlines. This is good behavior when we want to update an existing fine, but bad behavior if there was no fine to begin with! Test Plan: 1) Apply the unit test patch 2) prove t/db_dependent/Circulation.t 3) Note the test fails 4) Apply this patch 5) prove t/db_dependent/Circulation.t 6) Note the test passes Signed-off-by: Jen DeMuth jdem...@roseville.ca.us Signed-off-by: Katrin Fischer katrin.fischer...@web.de Confirmed the problem in the staff interface and that the patch fixes it. Also tested that fines still get calculated. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13890] New: Full serial permission is needed to change sequence on a routing list
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13890
Bug ID: 13890
Summary: Full serial permission is needed to change sequence on
a routing list
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Serials
Assignee: koha-bugs@lists.koha-community.org
Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org
CC: colin.campb...@ptfs-europe.com
For changing the sequence of patrons on a routing list by changing one of the
numbers via the pull downs, full serial permission is needed:
reorder_members.pl:
checkauth( $query, 0, { serials = 1 }, 'intranet' );
To test:
- Give your patron full serial permissions
- Create a subscription and a routing list for it
- Change the sequence on the routing list using the pull downs
- Verify this works
- Remove any of the serial sub permissions
- Verify changing the sequence now results in a permission error
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13890] Full serial permission is needed to change sequence on a routing list
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13890 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13890] Full serial permission is needed to change sequence on a routing list
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13890 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Severity|enhancement |normal Assignee|koha-b...@lists.koha-commun |katrin.fisc...@bsz-bw.de |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13890] Full serial permission is needed to change sequence on a routing list
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13890 --- Comment #1 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 37096 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37096action=edit Bug 13890 - Switch from full serials permission to 'routing' permission for reordering routing lists For changing the sequence of patrons on a routing list by changing one of the numbers via the pull downs, full serial permission is needed: To test: - Give your patron full serial permissions - Create a subscription and a routing list for it - Change the sequence on the routing list using the pull downs - Verify this works - Remove any of the serial sub permissions (claim serials or similar) - Verify changing the sequence now results in a permission error - Apply patch - Verify that the permission error is gone now - Remove the routing permission - Verify the permission error is back (but this seems to make sense) In general more fixes would be required to make all routing related features depend on the routing permission, but I think this fixes the bug making it depend on the correct permission. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13888] 'Lists' permission should allow/disallow using the lists module in staff
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13888 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7290] new permission for receiving
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7290 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7290] new permission for receiving
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7290 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Patch doesn't apply |Signed Off --- Comment #54 from Katrin Fischer katrin.fisc...@bsz-bw.de --- My branch was not on current master... sorry! Switching back to signed off, continuing work on this later. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7290] new permission for receiving
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7290 --- Comment #55 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Some first findings: Can you please amend your tests to have some explanations? 1..18 ok 1 ok 2 ... ... and while you are on it, fix the little tab that crept into koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt? +h3Error receiving items:/h3 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8436] Add branch limit on checkexpiration.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8436 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8436] Add branch limit on checkexpiration.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8436
--- Comment #17 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Comment on attachment 35166
-- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35166
[SIGNED OFF] Bug 8436: Add limit on branch in checkexpiration.pl
Review of attachment 35166:
--
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.htmlbug=8436attachment=35166)
-
::: serials/checkexpiration.pl
@@ +106,5 @@
}
+
+my $branchname;
+my @branches_loop;
+if ( $flags-{superlibrarian}
I think we should be using C4::Context-IsSuperLibrarian() here - please check!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8436] Add branch limit on checkexpiration.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8436 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9303] relative's checkouts in the opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #204 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Please see 13743 and 13790. Also there is a mismatch in this patch - auto_increment for old_issues is in kohastructure.sql but not in the database update. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9303] relative's checkouts in the opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=13790, ||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=13743 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13743] Primary key for issues-table
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13743 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=9303 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13790] Add unique id issue_id to issues and oldissues tables
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13790 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=9303 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13743] Primary key for issues-table
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13743 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=13790 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13790] Add unique id issue_id to issues and oldissues tables
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13790 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=13743 CC||katrin.fisc...@bsz-bw.de --- Comment #3 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Hi Kyle, Olli has another patch for this on bug 13743, also this doesn't seem to take into account the changes we made after testing on bug 9303. I am wondering about the auto_increment on old_issues and the renumbering of the old entries especially. Could you try and figure this out together? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13743] Primary key for issues-table
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13743 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #5 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Hi Olli, I think this doesn't look quite right - the database update instance is in the wrong place in the file and I feel the old_issues should not auto_increment. Also I think this wouldn't renumber the old entries? Please take a look at Kyle's patch on bug 13790 and also my comments on bug 9303. We did a similar patch for reserves and old_reserves in the past, maybe that could be helpful to look at as well. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13869] Wrong capitalization on guided reports page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13869 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7290] new permission for receiving
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7290 --- Comment #56 from Katrin Fischer katrin.fisc...@bsz-bw.de --- ... please also fix the databaes update to say XXX - it will make testing this easier! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13881] Add desk management
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13881 David Cook dc...@prosentient.com.au changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #108 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Some first findings from the code review: 1) Database update removes closed column, but it's still in kohastructure.sql. 2) I wonder if Basket groups should go first in the side navigation, as in the workflow the basket group happens before the orders are late or invoices can be done. 3) Why no paging on the basket groups datatable? 4) The database update statement is missing the version XXX - so it cannot be run from commandline. Mostly small things, please fix. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13331] Subfield does not show in cataloging editor - if subfield is disabled in OPAC/enabled in Staff, via frameworks
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13331 --- Comment #18 from Mason James m...@kohaaloha.com --- (In reply to Tomás Cohen Arazi from comment #17) (In reply to Mason James from comment #15) (In reply to Tomás Cohen Arazi from comment #13) Patch pushed to master. Thanks Mason! PS. try to tidy your commit messages a bit next time :-D can you show me an example of an untidy commit message from me? Sorry, I meant the subject! aah, yes - my mistake :0) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
