[Koha-bugs] [Bug 13810] Prevent updatedatabase.pl from breaking because of case insensitive utf8 collation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13810 --- Comment #16 from Katrin Fischer --- A first thought: Should we also take care of the auth_subfield_structure table? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13516] Display issue for search results with items both checkout out and lost
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13516 Katrin Fischer changed: What|Removed |Added Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10913] non executed code in acqui/basket.pl ?
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10913 Katrin Fischer changed: What|Removed |Added Attachment #38712|0 |1 is obsolete|| --- Comment #4 from Katrin Fischer --- Created attachment 38714 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38714&action=edit [PASSED QA] Bug 10913: The delete basket confirmation page is never displayed This condition is never reached, the confirmation to delete a basket is done with a popup in the template. Test plan: Confirm you don't find any regression when creation/editing and deleting a basket. Signed-off-by: Mark Tompsett NOTE: I didn't create or edit. However, the only perl script that uses the template is acqui/basket.pl and the only place delete_confirm is set in acqui/basket.pl is in that code which is only called if del_basket actually existed anywhere else, which it doesn't. I did have two baskets, one with two transfers from the first, so I transferred one back, and then proceeded to test the two delete buttons in the modal. No issues. Cancel (to close the modal) works too. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10913] non executed code in acqui/basket.pl ?
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10913 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12192] Template toolkit code in HTML attributes is picked up into po-files
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12192
Katrin Fischer changed:
What|Removed |Added
Attachment #38646|0 |1
is obsolete||
--- Comment #6 from Katrin Fischer ---
Created attachment 38713
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38713&action=edit
Bug 12192: Template toolkit code in HTML attributes is picked up into po-files
This patch gives a partial solution for this problem.
It ignores strings like "[% something %]", but not
"[% IF ( value ) %][% value %][% END %]"
We get 100+ strings less to translate
To test:
1) Update translation files for your preferred language
2) Apply the patch
3) Update again
4) Compare, you must find 100+ strings removed from
translation files
eg.
-msgid "[% SEARCH_RESULT.biblionumber |url %]"
-msgid "[% accepteddate | $KohaDates %]"
-msgid "[% amountoutstanding | format('%.2f') %]"
-msgid "[% authtypetext |html %]"
-msgid "[% barcode_llx |html %]"
-msgid "[% barcode_lly |html %]"
-msgid "[% biblio.quantity.length ? biblio.quantity : 1 %]"
-msgid "[% billingdate | $KohaDates %]"
-msgid "[% borname |html %]"
...
Signed-off-by: Jonathan Druart
Signed-off-by: Katrin Fischer
Verified all strings removed from the po files were
pure TT.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12192] Template toolkit code in HTML attributes is picked up into po-files
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12192 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11843] Manual subscription history doesn't seem to work as expected
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11843 Katrin Fischer changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=12369 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12369] serial history notes not editable
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12369 Katrin Fischer changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=11843 --- Comment #3 from Katrin Fischer --- See. bug 11843. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12369] serial history notes not editable
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12369 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #2 from Katrin Fischer --- Still valid. It used to be that you could edit the manual history anytime. Now it's that you have to have checked the checkbox in the subscription and then you can edit it from the tabs in the subscription detail view. BUT: it will no longer update automatically then in my tests :( I think this changed with the changes to the serial module and is quite a change of behaviour compared to 3.12? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10913] non executed code in acqui/basket.pl ?
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10913 M. Tompsett changed: What|Removed |Added Attachment #38316|0 |1 is obsolete|| --- Comment #3 from M. Tompsett --- Created attachment 38712 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38712&action=edit Bug 10913: The delete basket confirmation page is never displayed This condition is never reached, the confirmation to delete a basket is done with a popup in the template. Test plan: Confirm you don't find any regression when creation/editing and deleting a basket. Signed-off-by: Mark Tompsett NOTE: I didn't create or edit. However, the only perl script that uses the template is acqui/basket.pl and the only place delete_confirm is set in acqui/basket.pl is in that code which is only called if del_basket actually existed anywhere else, which it doesn't. I did have two baskets, one with two transfers from the first, so I transferred one back, and then proceeded to test the two delete buttons in the modal. No issues. Cancel (to close the modal) works too. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10913] non executed code in acqui/basket.pl ?
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10913 M. Tompsett changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5685] Validation of email address field
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5685 M. Tompsett changed: What|Removed |Added Attachment #38065|0 |1 is obsolete|| --- Comment #25 from M. Tompsett --- Created attachment 38710 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38710&action=edit Bug 5685 [OPAC follow-up] Validation of email address field This patch makes a few changes to the way errors are handled in the OPAC: - The validation plugin has been moved from the global include file to the template itself. Since we aren't doing form validation on any other page yet it doesn't make sense to include it globally at this time. - The error message which appears if you have JavaScript disabled and have submitted invalid emails was styled in a non-standard way. - I have added in-page links to the error message which appears if you have JavaScript disabled so that you can click to jump to the field which contains the error. - I have modified the error message language slightly to make it (I hope) read better. Signed-off-by: Nicole Engard -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5685] Validation of email address field
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5685 M. Tompsett changed: What|Removed |Added Attachment #38064|0 |1 is obsolete|| --- Comment #24 from M. Tompsett --- Created attachment 38709 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38709&action=edit Bug 5685 [Compiled CSS] Validation of email address field This patch contains the recompiled opac.css file based on changes made to opac.less in the previous patch. Signed-off-by: Nicole Engard FIXED the compress. - mtompset -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5685] Validation of email address field
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5685 M. Tompsett changed: What|Removed |Added Attachment #38707|0 |1 is obsolete|| --- Comment #26 from M. Tompsett --- Created attachment 38711 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38711&action=edit Bug 5685: Add missing about information In comment #20, Katrin requested the about page be updated to reflect the addition of a jquery plugin. TEST PLAN - 1) Apply all patches 2) Log in to Staff Client 3) Home -> About Koha -> Licenses -- jQuery Validation Plugin is now listed nicely. 4) Run koha qa test tools -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5685] Validation of email address field
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5685 M. Tompsett changed: What|Removed |Added Attachment #38063|0 |1 is obsolete|| --- Comment #23 from M. Tompsett --- Created attachment 38708 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38708&action=edit Bug 5685: Validation of email address field This patch adds server-side & client-side validation for email form fields in the members/memberentry -view and in the opac/memberentry-view (bootstrap). I recently added simple validation for phone number and email address fields for our in-house koha and saw this old bug: I'm open to any ideas on how to do this better. Validation for phone numbers would be easy to add on top of this but I left it out since this bug is only about the email fields. To test: 1) Select a member and go to any of the edit forms with email fields (Primary info, "Library use", "Alternate address", "Alternative contact"). 2) Disable javascript in the browser in order to test server-side validation and try to input invalid emails in each of the email form fields. 3) Confirm that an invalid address is catched from any of the email fields, an alert shown for each invalid address and that the member's information was not updated with invalid data. 4) Enable javascript in the browser. 5) Confirm that the jquery validation plugin caches invalid addresses from any of the email fields and that you cannot send the form before correcting the problem. 6) Perform the same tests for the opac-memberentry-view. Note: as the jQuery validation plugin doesn't exist in the bootstrap folder, I just copied it over from the staff-client folder -how to deal with this? Signed-off-by: Owen Leonard I have undone the changes to opac.css so that they can be submitted as a separate patch. I have some other follow-ups to make as well. Signed-off-by: Nicole Engard -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5685] Validation of email address field
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5685 M. Tompsett changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5685] Validation of email address field
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5685 --- Comment #22 from M. Tompsett --- Created attachment 38707 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38707&action=edit Bug 5685: Add missing about information In comment #20, Katrin requested the about page be updated to reflect the addition of a jquery plugin. TEST PLAN - 1) Apply all patches 2) Log in to Staff Client 3) Home -> About Koha -> Licenses -- jQuery Validation Plugin is now listed nicely. 4) Run koha qa test tools -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5685] Validation of email address field
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5685
--- Comment #21 from M. Tompsett ---
Comment on attachment 38063
--> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38063
Bug 5685: Validation of email address field
Review of attachment 38063:
-->
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=5685&attachment=38063)
-
::: koha-tmpl/opac-tmpl/bootstrap/lib/jquery/plugins/jquery.validate.min.js
@@ +1,4 @@
> +/*! jQuery Validation Plugin - v1.10.0 - 9/7/2012
> +* https://github.com/jzaefferer/jquery-validation
> +* Copyright (c) 2012 Jörn Zaefferer; Licensed MIT, GPL */
> +(function(a){a.extend(a.fn,{validate:function(b){if(!this.length){b&&b.debug&&window.console&&console.warn("nothing
> selected, can't validate, returning nothing");return}var
> c=a.data(this[0],"validator");return
> c?c:(this.attr("novalidate","novalidate"),c=new
> a.validator(b,this[0]),a.data(this[0],"validator",c),c.settings.onsubmit&&(this.validateDelegate(":submit","click",function(b){c.settings.submitHandler&&(c.submitButton=b.target),a(b.target).hasClass("cancel")&&(c.cancelSubmit=!0)}),this.submit(function(b){function
> d(){var d;return c.settings.submitHandler?(c.submitButton&&(d=a(" type='hidden'/>").attr("name",c.submitButton.name).val(c.submitButton.value).appendTo(c.currentForm)),c.settings.submitHandler.call(c,c.currentForm,b),c.submitButton&&d.remove(),!1):!0}return
>
> c.settings.debug&&b.preventDefault(),c.cancelSubmit?(c.cancelSubmit=!1,d()):c.form()?c.pendingRequest?(c.formSubmitted=!0,!1):d():(c.focusInvalid(),!1)})),c)},valid:function(){if(a(this[0]).is("form"))return
> this.validate().form();var b=!0,c=a(this[0].form).validate();return
> this.each(function(){b&=c.element(this)}),b},removeAttrs:function(b){var
> c={},d=this;return
> a.each(b.split(/\s/),function(a,b){c[b]=d.attr(b),d.removeAttr(b)}),c},rules:function(b,c){var
> d=this[0];if(b){var
> e=a.data(d.form,"validator").settings,f=e.rules,g=a.validator.staticRules(d);switch(b){case"add":a.extend(g,a.validator.normalizeRule(c)),f[d.name]=g,c.messages&&(e.messages[d.name]=a.extend(e.messages[d.name],c.messages));break;case"remove":if(!c)return
> delete f[d.name],g;var h={};return
> a.each(c.split(/\s/),function(a,b){h[b]=g[b],delete g[b]}),h}}var
> i=a.validator.normalizeRules(a.extend({},a.validator.metadataRules(d),a.validator.classRules(d),a.validator.attributeRules(d),a.validator.staticRules(d)),d);if(i.required){var
> j=i.required;delete i.required,i=a.extend({required:j},i)}return
> i}}),a.extend(a.expr[":"],{blank:function(b){return!a.trim(""+b.value)},filled:function(b){return!!a.trim(""+b.value)},unchecked:function(a){return!a.checked}}),a.validator=function(b,c){this.settings=a.extend(!0,{},a.validator.defaults,b),this.currentForm=c,this.init()},a.validator.format=function(b,c){return
> arguments.length===1?function(){var c=a.makeArray(arguments);return
> c.unshift(b),a.validator.format.apply(this,c)}:(arguments.length>2&&c.constructor!==Array&&(c=a.makeArray(arguments).slice(1)),c.constructor!==Array&&(c=[c]),a.each(c,function(a,c){b=b.replace(new
>
> RegExp("\\{"+a+"\\}","g"),c)}),b)},a.extend(a.validator,{defaults:{messages:{},groups:{},rules:{},errorClass:"error",validClass:"valid",errorElement:"label",focusInvalid:!0,errorContainer:a([]),errorLabelContainer:a([]),onsubmit:!0,ignore:":hidden",ignoreTitle:!1,onfocusin:function(a,b){this.lastActive=a,this.settings.focusCleanup&&!this.blockFocusCleanup&&(this.settings.unhighlight&&this.settings.unhighlight.call(this,a,this.settings.errorClass,this.settings.validClass),this.addWrapper(this.errorsFor(a)).hide())},onfocusout:function(a,b){!this.checkable(a)&&(a.name
> in
> this.submitted||!this.optional(a))&&this.element(a)},onkeyup:function(a,b){if(b.which===9&&this.elementValue(a)==="")return;(a.name
> in
> this.submitted||a===this.lastActive)&&this.element(a)},onclick:function(a,b){a.name
> in this.submitted?this.element(a):a.parentNode.name in
> this.submitted&&this.element(a.parentNode)},highlight:function(b,c,d){b.type==="radio"?this.findByName(b.name).addClass(c).removeClass(d):a(b).addClass(c).removeClass(d)},unhighlight:function(b,c,d){b.type==="radio"?this.findByName(b.name).removeClass(c).addClass(d):a(b).removeClass(c).addClass(d)}},setDefaults:function(b){a.extend(a.validator.defaults,b)},messages:{required:"This
> field is required.",remote:"Please fix this field.",email:"Please enter a
> valid email address.",url:"Please enter a valid URL.",date:"Please enter a
> valid date.",dateISO:"Please enter a valid date (ISO).",number:"Please enter
> a valid number.",digits:"Please enter only digits.",creditcard:"Please enter
> a valid credit card number.",equalTo:"Please enter the same value
> again.",maxlength:a.validator.format("Please enter no more than {0}
> characters."),minlength:a.validator.format("Please enter at least {0}
> characters.")
[Koha-bugs] [Bug 14095] New: Automatic Renewal Enhancements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14095 Bug ID: 14095 Summary: Automatic Renewal Enhancements Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: cbran...@cdalibrary.org QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Automatic renewals should put the focus back on checkout barcode textbox after being checked or unchecked. It should also stay on until turned off again or a new patron is pulled up. It would be courteous to show automatic renewal has been applied on the slips. My two cents. Christopher -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11890] Control-Click/Command-Click to open a link in a new tab not consistently working
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11890 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #10 from Katrin Fischer --- OPAC view: Open in new window. still opens in the same tab for me :( -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14094] New: Add separators for DDC classification in detail pages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14094 Bug ID: 14094 Summary: Add separators for DDC classification in detail pages Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org The DDC classification shows the entries separated by space. We should use | to make them better readable. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11925] patron category not checking ages limits
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11925 Katrin Fischer changed: What|Removed |Added Attachment #38690|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 38706 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38706&action=edit [PASSED QA] Bug 11925: Check ages limits when creating/updating patrons The check on the ages limits is only done when the dateofbirth field is mandatory, which does not make any sense. This check should be done when the field is filled. Test plan: 1/ Remove the dateofbirth field from the BorrowerMandatoryField pref 2/ Create a patron category for teenager (say between 12-17y) 3/ Try to create a patron in this category outside the range of the ages limits. You should not be able to do it. Signed-off-by: Christopher Brannon Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11925] patron category not checking ages limits
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11925 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14093] New: way for course and course items to expire
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14093 Bug ID: 14093 Summary: way for course and course items to expire Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Course reserves Assignee: koha-bugs@lists.koha-community.org Reporter: neng...@gmail.com QA Contact: testo...@bugs.koha-community.org CC: sfa...@roseman.edu It would be nice if a course had an expiration date so you didn't have to disable it manually. Also if you could have certain items expire from reserve automatically. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13423] Unused code in serials-edit.tt and serials-recieve.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13423 Katrin Fischer changed: What|Removed |Added Attachment #38649|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13423] Unused code in serials-edit.tt and serials-recieve.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13423 Katrin Fischer changed: What|Removed |Added Attachment #38648|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13423] Unused code in serials-edit.tt and serials-recieve.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13423 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13423] Unused code in serials-edit.tt and serials-recieve.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13423 Katrin Fischer changed: What|Removed |Added Attachment #38647|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13423] Unused code in serials-edit.tt and serials-recieve.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13423
--- Comment #18 from Katrin Fischer ---
Created attachment 38704
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38704&action=edit
[PASSED QA] Bug 13423: Remove unused serials-recieve
This patch removes two files, serials-recieve.pl and serial-recieve.tt
serials-recieve.pl is not called anyware
(it's recieve!)
Also removes the sub removeMissingIssue called only from serials-recieve.pl
git grep serials-recieve.pl .
C4/Serials.pm:called when a missing issue is found from the serials-recieve.pl
file
koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-recieve.tt:
koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-recieve.tt:
serials/serials-recieve.pl:serials-recieve.pl
Just a POD entry and self reference.
After removing of files
git grep removeMissingIssue .
C4/Serials.pm: &check_routing &updateClaim &removeMissingIssue
C4/Serials.pm:=head2 removeMissingIssue
C4/Serials.pm:removeMissingIssue($subscriptionid)
C4/Serials.pm:sub removeMissingIssue {
t/db_dependent/Serials.t:is(C4::Serials::removeMissingIssue(), undef, 'test
removing a missing issue');
Not used anymore
To test:
1) Apply the patch
2) Check serials workflow, no changes must be noted
Signed-off-by: Jonathan Druart
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13423] Unused code in serials-edit.tt and serials-recieve.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13423 --- Comment #17 from Katrin Fischer --- Created attachment 38703 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38703&action=edit [PASSED QA] Bug 13423: Remove unused JS function in serials-edit.tt This patch removes unused code: * barcode_check() function, with untranslatable strings * commented call to this function To test: 1. Apply the patch 2. Check serials receive, no changes shall be detected NOTE: I did not run this test plan. Verification steps -- 1. Find out where barcode_check is used. $ git grep barcode_check -- This is only in serials-edit.tt and serials-receive.tt 2. This patch only affects serials-edit.tt, so check who put the $ git blame -L130 koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt -- note the commit related number. 3. Check out the commit. $ git show 77b64098 -- should show bug 5917, but the patches on bugzilla don't have the change nicely, so... 4. Hunt through the pages to find the change. -- Note: it is part of a "new file" diff! 5. Since this code hasn't been running since it was added... 6. apply the patch 7. run koha-qa test tools Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13423] Unused code in serials-edit.tt and serials-recieve.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13423 --- Comment #19 from Katrin Fischer --- Created attachment 38705 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38705&action=edit [PASSED QA] Bug 13423: Fix number of tests in Serials.t Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14083] new acq date field
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14083 --- Comment #2 from Nicole C. Engard --- Nope, that's not the date I placed the order with the vendor. So the way it works is this: 1. go to vendor site and place order 2. go to koha and enter order info again 3. close the basket So there is no way to get the date I ordered from the vendor. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10285] Error 500 in staff client displays old start page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10285 Chris Cormack changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable --- Comment #13 from Chris Cormack --- Applied to 3.18.x will be in 3.18.7 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9742] Confirm overlay prompt always appears on creating record from Z39.50
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9742 --- Comment #12 from Chris Cormack --- Applied to 3.18.x will be in 3.18.7 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14092] New: order search doesn't allow for all statuses
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14092 Bug ID: 14092 Summary: order search doesn't allow for all statuses Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: neng...@gmail.com QA Contact: testo...@bugs.koha-community.org CC: sfa...@roseman.edu Created attachment 38702 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38702&action=edit status pull down You can do all statuses except cancelled or individual statuses but not all statuses. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9742] Confirm overlay prompt always appears on creating record from Z39.50
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9742 Chris Cormack changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable --- Comment #11 from Chris Cormack --- Applied to 3.18.x will be in 3.18.7 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13315] Add feedback for last item checked out to circulation.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13315 Chris Cormack changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable --- Comment #24 from Chris Cormack --- Applied on 3.18.x will be in 3.18.7 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6911] Log viewer should remember search terms
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6911 Chris Cormack changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable --- Comment #13 from Chris Cormack --- Applied on 3.18.x will be in 3.18.7 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6007] Checking 'Display only used Tags/Subfields' on MARC framework page results in unusable output
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6007 Chris Cormack changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable --- Comment #10 from Chris Cormack --- Applied on 3.18.x will be in 3.18.7 -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12109] Authority subfield configuration page for controlled fields is broken
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12109 Katrin Fischer changed: What|Removed |Added Attachment #38635|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 38701 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38701&action=edit [PASSED QA] Bug 12109: Fix tab on the auth subfield configuration page There is a condition in the template to not display the "New" tab if the user is editing a control field. But it results in a broken template. Looking at the biblio frameworks, the New tab exists even for control fields. This patch only fixes the html structure, but a complete fix should be provide, for auth and biblio, if we want not to let the ability to create subfields for control fields. Test plan: Edit subfields for a control field (admin/marc_subfields_structure.pl?op=add_form&tagfield=001&frameworkcode= for instance) and confirm that the view is now fixed. Signed-off-by: Mark Tompsett NOTE: Checked LDR, 001, and 008. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12109] Authority subfield configuration page for controlled fields is broken
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12109 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8796] patron cards not starting on designated card
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8796 --- Comment #23 from Chris Cormack --- Theres a conflict in patroncards/create-pdf.pdf .. please rebase on 3.18.x if you want it in 3.18.7 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11385] C4::SQLHelper should be removed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11385 Katrin Fischer changed: What|Removed |Added Attachment #37752|0 |1 is obsolete|| Attachment #38699|0 |1 is obsolete|| --- Comment #6 from Katrin Fischer --- Created attachment 38700 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38700&action=edit [SIGNED OFF] Bug 11385: Remove SQL::Helper At this point, no occurrence of SQL::Helper should exist. Let's remove the package and tests. Test plan: git grep SQLHelper and git grep InTable Should not return anything in the Koha code. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11385] C4::SQLHelper should be removed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11385 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #36 from Katrin Fischer --- It's getting too late... this is PASSED QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633 Katrin Fischer changed: What|Removed |Added Status|Passed QA |Signed Off --- Comment #35 from Katrin Fischer --- Habits.. this was only a sign off, fixing. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11385] C4::SQLHelper should be removed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11385 --- Comment #5 from Katrin Fischer --- Created attachment 38699 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38699&action=edit [PASSED QA] Bug 11385: Remove SQL::Helper At this point, no occurrence of SQL::Helper should exist. Let's remove the package and tests. Test plan: git grep SQLHelper and git grep InTable Should not return anything in the Koha code. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758 Nicole C. Engard changed: What|Removed |Added CC||sfa...@roseman.edu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14091] New: way to distinguish deleted versus cancelled in acq
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14091 Bug ID: 14091 Summary: way to distinguish deleted versus cancelled in acq Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: neng...@gmail.com QA Contact: testo...@bugs.koha-community.org CC: sfa...@roseman.edu It would be nice if in Acq you could distinguish between things that were cancelled and things that were deleted due an error. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14090] New: add link to basket from invoice and vice versa
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14090 Bug ID: 14090 Summary: add link to basket from invoice and vice versa Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: neng...@gmail.com QA Contact: testo...@bugs.koha-community.org CC: sfa...@roseman.edu It would be nice to have a link to the basket from the invoice (right now it's just the receipt page) and a link from the basket to the invoice. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633 Katrin Fischer changed: What|Removed |Added Attachment #38284|0 |1 is obsolete|| Attachment #38285|0 |1 is obsolete|| --- Comment #33 from Katrin Fischer --- Created attachment 38697 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38697&action=edit [PASSED QA] Bug 12633: Remove SQLHelper in C4::Members This is the only places where SQLHelper is still called. The C4::Members::Search is not used anymore, but ModMember and AddMember. This patch replaced the calls to SQLHelper to use DBIX::Class. TODO: Move them to Koha::Borrower. Test plan: 1/ Make sure the patron search still works (no changes expected since the code was not in used). 2/ Add a patron with all fields filled 3/ Add another patron with some fields filled 4/ Update them with other values 5/ Delete them You should not get any errors. Signed-off-by: Mirko Tietgen Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12633] SQLHelper replacement - C4::Members
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12633 --- Comment #34 from Katrin Fischer --- Created attachment 38698 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38698&action=edit [PASSED QA] Bug 12633: Fix specific default values The dates should be set to undef if defined but empty, otherwise with an empty string, '-00-00' will be inserted into the DB. Signed-off-by: Mirko Tietgen Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14089] New: show reason for cancellation on order search results
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14089 Bug ID: 14089 Summary: show reason for cancellation on order search results Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: neng...@gmail.com QA Contact: testo...@bugs.koha-community.org CC: sfa...@roseman.edu It would be nice to see the cancellation reason on the order search results. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14088] New: Show qty on order search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14088 Bug ID: 14088 Summary: Show qty on order search Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: neng...@gmail.com QA Contact: testo...@bugs.koha-community.org CC: sfa...@roseman.edu It would be nice to see the qty ordered on the order search results. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14087] New: show all price fields on order search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14087 Bug ID: 14087 Summary: show all price fields on order search Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: neng...@gmail.com QA Contact: testo...@bugs.koha-community.org CC: sfa...@roseman.edu It would be nice if all the price costs showed on the acquisitions order search - right now it's just unit cost. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14086] date ordered on ordered fund search doesn't match order date
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14086 --- Comment #1 from Nicole C. Engard --- Created attachment 38696 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38696&action=edit dates on order -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14086] New: date ordered on ordered fund search doesn't match order date
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14086 Bug ID: 14086 Summary: date ordered on ordered fund search doesn't match order date Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: neng...@gmail.com QA Contact: testo...@bugs.koha-community.org CC: sfa...@roseman.edu Created attachment 38695 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38695&action=edit ordered date When you click to see what orders make up the total ordered in your fund you see a 'date ordered' it however does not seem to match any date in the order. It should be the date the basket was created since that's the order date. The date received seems closest to the date showing in the images and that's not the order date. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14085] New: search biblionumber in acquisitions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14085 Bug ID: 14085 Summary: search biblionumber in acquisitions Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: neng...@gmail.com QA Contact: testo...@bugs.koha-community.org CC: sfa...@roseman.edu It would be nice if the order search in Acquisitions allowed searching on biblionumber. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14038] SQLHelper replacement - C4::Members::Search - nl-search.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14038 --- Comment #5 from Katrin Fischer --- Code touched by this patch is specific to the Norwegian library card feature - no regressions found and trusting Magnus as a tester here (have to... ;) ) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14038] SQLHelper replacement - C4::Members::Search - nl-search.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14038 Katrin Fischer changed: What|Removed |Added Attachment #38665|0 |1 is obsolete|| --- Comment #4 from Katrin Fischer --- Created attachment 38694 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38694&action=edit [PASSED QA] Bug 14038: Make nl-search.pl not using C4::Members::Search To get rid of SQLHelper, we should not use this C4::Members::Search anymore. Test plan for Magnus :) 0/ Enable the pref you need to use the Norwegian national library card ft 1/ Go on the members/nl-search.pl page and search for patrons. 2/ Make sure you search by card number and by "social security number" Signed-off-by: Magnus Enger Searching works the same with and without the patch. Thanks Jonathan! Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14038] SQLHelper replacement - C4::Members::Search - nl-search.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14038 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8417] date acquired is shipping date
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8417 Nicole C. Engard changed: What|Removed |Added CC||sfa...@roseman.edu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14084] New: order date language in Koha inconsistent
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14084 Bug ID: 14084 Summary: order date language in Koha inconsistent Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: neng...@gmail.com QA Contact: testo...@bugs.koha-community.org CC: sfa...@roseman.edu In Koha when you create a basket there is a basket opened date, on other pages it's called the order date, on other pages it's called the placed on date and in some places it's the creation date - they should all be consistent which ever they use. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14083] new acq date field
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14083 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #1 from Katrin Fischer --- Hi Nicole, I think the aqorders.closedate is the one you are looking for. The moment you close the basket the status switches from new to ordered and the date is set. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14083] New: new acq date field
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14083 Bug ID: 14083 Summary: new acq date field Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: neng...@gmail.com QA Contact: testo...@bugs.koha-community.org CC: sfa...@roseman.edu It would be nice if there were another date field in Acq. There is no field to enter the date the item was actually ordered from the vendor. There is the date the basket was created in Koha and the date the item shipped and was received - but not the date you placed the order with the vendor. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13061] filters on invoices not clearing after results found
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13061 Nicole C. Engard changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=14079 --- Comment #1 from Nicole C. Engard --- I think it's possible that this request is counter to this other request: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14079 Nicole PS. I entered both on behalf of library partners so we might need feedback here. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14079] performing actions on invoices refreshes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14079 Nicole C. Engard changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=13061 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14038] SQLHelper replacement - C4::Members::Search - nl-search.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14038 Katrin Fischer changed: What|Removed |Added Severity|enhancement |normal CC||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13061] filters on invoices not clearing after results found
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13061 Nicole C. Engard changed: What|Removed |Added CC||sfa...@roseman.edu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14044] Backslashes ( and possibly other characters ) break patron search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14044 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #12 from Katrin Fischer --- Sorry, I found another something - try adding a " to the address data - it will display as " on the patron result list. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14082] can't edit vendor notes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14082 --- Comment #1 from Nicole C. Engard --- Created attachment 38693 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38693&action=edit receipt summary - can add but not edit -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14082] New: can't edit vendor notes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14082 Bug ID: 14082 Summary: can't edit vendor notes Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: neng...@gmail.com QA Contact: testo...@bugs.koha-community.org Created attachment 38692 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38692&action=edit receive page - not editable vendor note When receiving you can add vendor notes on the receipt page but you can't edit them. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14082] can't edit vendor notes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14082 Nicole C. Engard changed: What|Removed |Added CC||sfa...@roseman.edu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12253] MARCURLS not showing in OPAC basket
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12253 Katrin Fischer changed: What|Removed |Added Attachment #38634|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 38691 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38691&action=edit [PASSED QA] Bug 12253: Fix MARCUrls in basket At the OPAC and the intranet, the urls don't be displayed anymore. The variables used in the templates are not the good ones (MARCurlS vs MARCURLS). Test plan: 1/ On the intranet side, add some urls to some records 2/ Add these records to the basket 3/ Add records without urls defined 4/ Go on the basket view, click "more details" 5/ You should see the urls displayed 6/ Repeat steps 4-5 at the OPAC Signed-off-by: Mark Tompsett NOTE: 856$u displays now in intranet and OPAC. :) Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13270] On receiving, "vendor note" label should not be displayed if nothing to display
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13270 Nicole C. Engard changed: What|Removed |Added CC||neng...@gmail.com, ||sfa...@roseman.edu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12253] MARCURLS not showing in OPAC basket
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12253 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11925] patron category not checking ages limits
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11925 Christopher Brannon changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14080] cancelled orders should show on invoice
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14080 Nicole C. Engard changed: What|Removed |Added CC||sfa...@roseman.edu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11925] patron category not checking ages limits
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11925 Christopher Brannon changed: What|Removed |Added Attachment #38599|0 |1 is obsolete|| --- Comment #2 from Christopher Brannon --- Created attachment 38690 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38690&action=edit [SIGNED OFF]Bug 11925: Check ages limits when creating/updating patrons The check on the ages limits is only done when the dateofbirth field is mandatory, which does not make any sense. This check should be done when the field is filled. Test plan: 1/ Remove the dateofbirth field from the BorrowerMandatoryField pref 2/ Create a patron category for teenager (say between 12-17y) 3/ Try to create a patron in this category outside the range of the ages limits. You should not be able to do it. Signed-off-by: Christopher Brannon -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14079] performing actions on invoices refreshes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14079 Nicole C. Engard changed: What|Removed |Added CC||sfa...@roseman.edu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14081] price labels are not consistent in acq
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14081 --- Comment #8 from Nicole C. Engard --- I think: Unit cost = vendor price est = budgeted = estimated unit price replacement cost = rrp Etc etc. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14081] price labels are not consistent in acq
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14081 --- Comment #7 from Nicole C. Engard --- Created attachment 38689 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38689&action=edit spent fund search -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14081] price labels are not consistent in acq
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14081 --- Comment #6 from Nicole C. Engard --- Created attachment 38688 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38688&action=edit ordered search labels -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14081] price labels are not consistent in acq
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14081 --- Comment #5 from Nicole C. Engard --- Created attachment 38687 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38687&action=edit price labels on item -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14033] Capitalization: confirmation message on deleting an authority type
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14033 Katrin Fischer changed: What|Removed |Added Attachment #38633|0 |1 is obsolete|| --- Comment #8 from Katrin Fischer --- Created attachment 38686 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38686&action=edit [PASSED QA] Bug 14033 - Capitalization: confirmation message on deleting an authority type This bug fixes capitalization of "No, Do Not Delete" in following templates: koha-tmpl/intranet-tmpl/prog/en/modules/admin/authtypes.tt koha-tmpl/intranet-tmpl/prog/en/modules/admin/classsources.tt koha-tmpl/intranet-tmpl/prog/en/modules/admin/currency.tt koha-tmpl/intranet-tmpl/prog/en/modules/admin/marctagstructure.tt koha-tmpl/intranet-tmpl/prog/en/modules/admin/matching-rules.tt koha-tmpl/intranet-tmpl/prog/en/modules/admin/patron-attr-types.tt koha-tmpl/intranet-tmpl/prog/en/modules/admin/stopwords.tt To test: Verify that the strings are properly replaced. Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer Fixed some tabs. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14033] Capitalization: confirmation message on deleting an authority type
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14033 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14025] Fix display of links from 856$u in the OPAC for NORMARC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14025 Magnus Enger changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14077] Remove unused AUTH_UPDATE_FAILED from moremember.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14077 Katrin Fischer changed: What|Removed |Added Attachment #38654|0 |1 is obsolete|| --- Comment #3 from Katrin Fischer --- Created attachment 38685 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38685&action=edit [PASSED QA] Bug 14077 - Remove unused AUTH_UPDATE_FAILED from moremember.tt 'AUTH_UPDATE_FAILED' in moremember.tt is never set and should be removed (see comment #6 on Bug 13910). To verify: git grep 'AUTH_UPDATE_FAILED' Result: Only one occurence (in moremember.tt) Test plan: - Apply patch (on top of Bug 13910) - Verify that the part with AUTH_UPDATE_FAILED is removed from moremember.tt - Go to a patron's detail page and verify that nothing is broken (Home > Patrons > Patrons details for...) Signed-off-by: Jonathan Druart This has been introduced by commit 1a91801b06607ee9e5f8c21d531a7b7a3ca3b683 Date: Sat Dec 1 20:56:27 2007 -0600 Add Staff member type. Add permissions checks for bug# 1269 and related permissions on memberentry and mods. But was already not used... Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14077] Remove unused AUTH_UPDATE_FAILED from moremember.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14077 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14081] price labels are not consistent in acq
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14081 --- Comment #4 from Nicole C. Engard --- Created attachment 38684 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38684&action=edit order search labels -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14081] price labels are not consistent in acq
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14081 --- Comment #2 from Nicole C. Engard --- Created attachment 38682 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38682&action=edit fund management view -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14081] price labels are not consistent in acq
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14081 --- Comment #3 from Nicole C. Engard --- Created attachment 38683 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38683&action=edit invoice labels -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14081] price labels are not consistent in acq
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14081 --- Comment #1 from Nicole C. Engard --- Created attachment 38681 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38681&action=edit fund list labels -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14025] Fix 865u-links in the OPAC for NORMARC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14025 Magnus Enger changed: What|Removed |Added Summary|Fix display of links from |Fix 865u-links in the OPAC |856$u in the OPAC for |for NORMARC |NORMARC | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14081] New: price labels are not consistent in acq
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14081 Bug ID: 14081 Summary: price labels are not consistent in acq Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: neng...@gmail.com QA Contact: testo...@bugs.koha-community.org Created attachment 38680 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38680&action=edit order screen labels In acquisitions the price fields are inconsistently labeled. There are 4 price fields: vendor price estimated cost replacement cost actual cost However as you can see in the screenshots it says it differently everywhere. Some phrases: * Unit price * RRP * EST * Budgeted cost * Actual cost * Base-level And more. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14036] "Date::Calc::Add_Delta_YM(): not a valid date" error when accessing subscription detail
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14036 --- Comment #25 from Katrin Fischer --- If you or Rolando can tell me how to alter the data in order to make the problem appear that would work for me for now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13910] Prevent delete of one's own patron account
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13910 Katrin Fischer changed: What|Removed |Added Attachment #38651|0 |1 is obsolete|| Attachment #38652|0 |1 is obsolete|| --- Comment #11 from Katrin Fischer --- Created attachment 38678 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38678&action=edit [PASSED QA] Bug 13910 - Prevent delete of one's own patron account This patch adds a check to prevent deleting the user's own account. Additionali it fixes a "missing link" in moremember.pl and wrong comparisions in moremember.tt regarding other forbidden deleting. To test: - Apply patch - Create a user with sufficient privileges to delete users - Log in as this new user - Try to delete this user. Confirm message box "Are you sure..." - Confirm that you get a message "Not allowed to delete own account" and that the user still exists. Bonus test: Try to trigger other forbidden deletions (see members/deletemem.pl): 'CANT_DELETE_STAFF', 'CANT_DELETE_OTHERLIBRARY', 'CANT_DELETE' (You can fake it by using an URL like: /cgi-bin/koha/members/moremember.pl?borrowernumber=115&error=CANT_DELETE_STAFF etc.) Without patch, no message appears. With patch, messages appear as appropriate. Signed-off-by: Mark Tompsett NOTE: Attempted all CANT combinations. From reading the code, this is kind of an important patch, because I'm not sure deleting error messages work at all right now based on what I read. Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13910] Prevent delete of one's own patron account
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13910 --- Comment #12 from Katrin Fischer --- Created attachment 38679 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38679&action=edit [PASSED QA] Bug 13910 - Line with AUTH_UPDATE_FAILED restored As of comment #6 Signed-off-by: Jonathan Druart This should be fixed in a separate patch, this error is not sent to the template and the related code could be removed. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13910] Prevent delete of one's own patron account
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13910 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
