[Koha-bugs] [Bug 12412] Add ability for plugins to convert arbitrary files to MARC from record staging tool

2015-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12412

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Blocks||14148

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14148] Bug 12412 breaks import if plugins are not enabled

2015-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14148

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 CC||dpav...@rot13.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14148] New: Bug 12412 breaks import if plugins are not enabled

2015-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14148

Bug ID: 14148
   Summary: Bug 12412 breaks import if plugins are not enabled
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: blocker
  Priority: P5 - low
 Component: Tools
  Assignee: gmcha...@gmail.com
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org

Dobrica reported on bug 12412:

This bug will break Koha installation if there is no enable_plugins in
koha-conf.xml with following error:

Can't call method GetPlugins on an undefined value at
/srv/koha_ffzg/tools/stage-marc-import.pl line 206, DATA line 603.

This is not ideal, since it will break old installations.

Problem is line:

Koha::Plugins-new()-GetPlugins('to_marc');

where Koha::Plugins-new() will return undef is plugins are not enabled.

It seems we also have same syntax in plugins/plugins-home.pl so it should
probably be fixed also.

--

It's a little bit worse: plugins had to be enabled. Even adding

 enable_plugins0/enable_plugins

to koha-conf.xml won't help.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14147] Add unit tests to C4::External::OverDrive

2015-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14147

Julian FIOL julian.f...@biblibre.com changed:

   What|Removed |Added

  Attachment #38843|0   |1
is obsolete||

--- Comment #2 from Julian FIOL julian.f...@biblibre.com ---
Created attachment 38847
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38847action=edit
Bug 14147 : Add unit tests to C4::External::OverDrive

This patch test 'IsOverDriveEnabled' subroutine

TEST PLAN
-
1. Apply patch
2. prove -v t/External/OverDrive.t
-- All tests should run successfully without
any error or warning

TEST PLAN OPTIONAL
--

Check with bug 13899 to see the coverage of this module.

Coverage BEFORE this patch :
Statement  :  47,5%
Branch :   0,0%
Condition  :   0,0%
Subroutine :  75,0%

Coverage AFTER this patch :
Statement  :  49,1%
Branch :   0,0%
Condition  :  33,3%
Subroutine :  83,3%

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12412] Add ability for plugins to convert arbitrary files to MARC from record staging tool

2015-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12412

Dobrica Pavlinusic dpav...@rot13.org changed:

   What|Removed |Added

 CC||dpav...@rot13.org

--- Comment #12 from Dobrica Pavlinusic dpav...@rot13.org ---
This bug will break Koha installation if there is no enable_plugins in
koha-conf.xml with following error:

Can't call method GetPlugins on an undefined value at
/srv/koha_ffzg/tools/stage-marc-import.pl line 206, DATA line 603.

This is not ideal, since it will break old installations.

Problem is line:

Koha::Plugins-new()-GetPlugins('to_marc');

where Koha::Plugins-new() will return undef is plugins are not enabled.

It seems we also have same syntax in plugins/plugins-home.pl so it should
probably be fixed also.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14107] Patron cards: Make barcode width and height scaling editable

2015-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14107

--- Comment #11 from Chris Nighswonger cnighswon...@foundations.edu ---
Marc, would it be possible for you to add this to the label tool as well?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14149] New: Labels: Make barcode width and height scaling editable

2015-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14149

Bug ID: 14149
   Summary: Labels: Make barcode width and height scaling editable
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Label/patron card printing
  Assignee: cnighswon...@foundations.edu
  Reporter: cnighswon...@foundations.edu
QA Contact: testo...@bugs.koha-community.org

Provide an extension of Bug 14107 to apply to barcodes on label layouts as
well.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14128] Capitalization: Guided Reports - step 2 - Build A Report

2015-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14128

Héctor Eduardo Castro Avalos hector.hecax...@gmail.com changed:

   What|Removed |Added

  Attachment #38802|1   |0
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10877] Add Order Record processing

2015-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10877

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #35677|0   |1
is obsolete||

--- Comment #36 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 38849
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38849action=edit
Bug 10877 - Add Order Record processing

Order Record Processing will allow a library to stage an order record
file which is a standard marc file with some additional information in
it about how to create items automatically ( quantity, itemtype, etc ).
The location of these fields is defined in the system preference
MarcFieldsToOrder from bug 7180.

The workflow is thus:
1) A librarian uploads an order record file, and marks the batch as an
order file during the staging process.
2) The librarian selects an acquisitions basket and chooses from a
staged order file
3) From here, the librarian can view all the records that will be
created, along with quantity and other data ( from bug 7180 ). The
librarian will *not* see the item fields, as those are automatically
created using the minimum data needed ( branches, itype ).
4) The librarian hits save and the items are automatically generated
on order.

Later ( using features not directly tied to this feature ), the
librarian will receive a new marc batch file with items attached
( including itemnumbers ). The vendor will have this information
because it was sent via EDI ( bug 7736 ). The librarian will then use
the marc record staging feature to overlay those bare bones item records
with the full data ( via bug 7131 ).

Signed-off-by: Aaron Sakovich asakov...@hmcpl.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10877] Add Order Record processing

2015-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10877

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|In Discussion   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10877] Add Order Record processing

2015-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10877

--- Comment #37 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 38850
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38850action=edit
Bug 10877 [QA Followup]

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14148] Bug 12412 breaks import if plugins are not enabled

2015-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14148

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Depends on||12412

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14107] Patron cards: Make barcode width and height scaling editable

2015-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14107

--- Comment #13 from Marc Véron ve...@veron.ch ---
(In reply to Chris Nighswonger from comment #11)
 Marc, would it be possible for you to add this to the label tool as well?

Chris, I think so.
Can you open a separate Bug for the label tool and put me on the cc?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14149] Labels: Make barcode width and height scaling editable

2015-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14149

Chris Nighswonger cnighswon...@foundations.edu changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=14107
 CC||ve...@veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14107] Patron cards: Make barcode width and height scaling editable

2015-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14107

Chris Nighswonger cnighswon...@foundations.edu changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=14149

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14098] Regression in Marc Modification Templates

2015-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14098

--- Comment #1 from Jonathan Druart jonathan.dru...@biblibre.com ---
(In reply to Kyle M Hall from comment #0)
 In previous versions of Koha, a marc modfication rules like Copy field
 XXX$Y to 952$x would add the field to an existing 952 field if there was
 one already, and only create a 952 field if none existed. Now an entirely
 new 952 field is created to store the subfield even if there is already one!

Hello Kyle,
I would say it's the way it should work.
Or maybe should we create a new action and let the choice to the user?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14107] Patron cards: Make barcode width and height scaling editable

2015-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14107

Chris Nighswonger cnighswon...@foundations.edu changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14107] Patron cards: Make barcode width and height scaling editable

2015-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14107

Chris Nighswonger cnighswon...@foundations.edu changed:

   What|Removed |Added

  Attachment #38764|0   |1
is obsolete||

--- Comment #12 from Chris Nighswonger cnighswon...@foundations.edu ---
Created attachment 38848
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38848action=edit
[SIGNED OFF] Bug 14107: Patron cards: Make barcode width and height scaling
editable

The size of the barcode in patron card creator was hardcoded to 1% of the card
height and 80% of the card width.
This patch exposes both values in the layout editor. If no values are given,
the previousely hard coded values (0.01 / 0.8) are used in order to work with
existing card definitions.

To test:
- Go to Home  Tools  Patron card creator
- Export a patron card (PDF) from en existing definition
- Apply patch
- Export patron card again, compare results (should be the same)
- Go to Home  Tools  Patron card creator  Manage card layouts
- Edit the layout you use for testing and set barcode scaling values e.g. to
0.03 for height and 0.4 for widht
- Export patron card again, verify that barcode size changed

Signed-off-by: Chris Nighswonger cnighswon...@foundations.edu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14059] Fully testing C4::Creators::Lib

2015-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14059

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

 Status|Signed Off  |Needs Signoff

--- Comment #10 from M. Tompsett mtomp...@hotmail.com ---
Patch added by comment #9 needs sign off.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13767] Readonly::XS (1:02) is not installed

2015-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13767

--- Comment #14 from M. Tompsett mtomp...@hotmail.com ---
Bug 14066 passed QA, and I believe Katrin has gotten the remaining tiny pieces
we missed all cleaned up. Once pushed to master, this should be
resolved/closed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11941] Patron lists are not easily accessible

2015-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11941

Liz Rea l...@catalyst.net.nz changed:

   What|Removed |Added

  Attachment #38878|0   |1
is obsolete||

--- Comment #5 from Liz Rea l...@catalyst.net.nz ---
Created attachment 38879
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38879action=edit
Bug 11941: Add link to patron lists from the patron home page

The patron lists are only accessible from the tools module, which is not
easily accessible when you are in the patron module.

Test plan:
Go on the patron home page.
In the toolbar, you should see a link to the patron lists.

NOTE: Tweaked button to a to get the click to work.

Signed-off-by: Mark Tompsett mtomp...@hotmail.com
Signed-off-by: Liz Rea l...@catalyst.net.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14103] Discharge management: Software error on main page after upgrade - Missing dependencies on About page

2015-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14103

--- Comment #9 from Robin Sheat ro...@catalyst.net.nz ---
(In reply to Tomás Cohen Arazi from comment #8)
 Thanks Robin. Can you point me to some reference docs on how to build the
 package from source (for testing purposees)? I'm only familiar with
 dh-make-perl and always used --cpan.

I wrote a getting-started wiki page:

http://wiki.koha-community.org/wiki/Building_Debian_Dependencies

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14149] Labels: Make barcode width and height scaling editable

2015-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14149

--- Comment #2 from Chris Nighswonger cnighswon...@foundations.edu ---
(In reply to Marc Véron from comment #1)

 This is commented in line 41 of :
 # FIXME: all layouts should be stored in xml format to greatly simplify
 handling -chris_n
 

WOW! Its been a long time since I added that note, but I do remember that
appearing to be a much easier method.

Thanks for looking.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11941] Patron lists are not easily accessible

2015-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11941

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11941] Patron lists are not easily accessible

2015-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11941

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

  Attachment #38598|0   |1
is obsolete||

--- Comment #4 from M. Tompsett mtomp...@hotmail.com ---
Created attachment 38878
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38878action=edit
Bug 11941: Add link to patron lists from the patron home page

The patron lists are only accessible from the tools module, which is not
easily accessible when you are in the patron module.

Test plan:
Go on the patron home page.
In the toolbar, you should see a link to the patron lists.

NOTE: Tweaked button to a to get the click to work.

Signed-off-by: Mark Tompsett mtomp...@hotmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14103] Discharge management: Software error on main page after upgrade - Missing dependencies on About page

2015-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14103

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com

--- Comment #11 from M. Tompsett mtomp...@hotmail.com ---
I have provided a counter patch, which I think is better. :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14153] Noisy warns in admin/transport-cost-matrix.pl

2015-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14153

Aleisha Amohia aleishaamo...@hotmail.com changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14153] Noisy warns in admin/transport-cost-matrix.pl

2015-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14153

--- Comment #1 from Aleisha Amohia aleishaamo...@hotmail.com ---
Created attachment 38880
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38880action=edit
Bug 14153: Noisy warns in admin/transport-cost-matrix.pl

This patch silences the warn by putting curly braces around the
$input-param('op') code, to kind of group this as a variable. I don't know
that this is the best solution for this but the warn is no longer there.

To test:

1) Go to Admin - Transport cost matrix
2) Notice the warns in the error log
3) Apply the patch and refresh page
4) Notice page still works but no warns in error log

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14103] Discharge management: Software error on main page after upgrade - Missing dependencies on About page

2015-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14103

--- Comment #10 from M. Tompsett mtomp...@hotmail.com ---
Created attachment 38881
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38881action=edit
Bug 14103 - PDF::FromHTML is conditionally required on UseDischarge
systempreference

Since this is only in generate_as_pdf of Koha::Borrowers::Discharge, it made
sense to change it from a use to a require (avoiding a compile time error),
and placing it inside the eval where the PDF is generated, thus capturing the
problem in the koha error log.

TEST PLAN
-
1) Log in to staff client
2) Koha Administration - Global system preferences - Local Use
3) Lower the Version number by 1, but DO NOT CLICK SAVE.
4) At the command line, sudo apt-get purge libpdf-fromhtml-perl
5) Back in the staff client, click save.
6) Every looks great until you attempt to log in. KABOOM!
7) Apply patch
8) Log in to staff client
   -- YAY!
9) Koha Administration - Global system preferences - Patrons
10) Make use the useDischarge is set to Allow
11) Find a patron with nothing checked out.
12) There is now a Discharge tab on the left at the bottom.
13) Click the 'Generate Discharge' button.
-- nice error message
-- check koha error log file for the ugly @INC missing message
14) At the command line, reinstall PDF::FromHTML
(I built my own with cpan2deb: sudo dpkg -i
/path/to/libpdf-fromhtml-perl_...)
15) In the staff client, click the 'Generate Discharge' button again.
-- PDF is created as expected. All is well.
16) run koha qa test tools.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14153] New: Noisy warns in admin/transport-cost-matrix.pl

2015-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14153

Bug ID: 14153
   Summary: Noisy warns in admin/transport-cost-matrix.pl
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: System Administration
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: aleishaamo...@hotmail.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

my $update = $input-param('op') eq 'set-cost-matrix';

The above code (line 45) causes a warn 'Use of unintialized value in string eq'

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14138] Patroncard: Prevent errors if create-pdf.pl gets wrong parameters

2015-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14138

Marc Véron ve...@veron.ch changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=14131

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14131] Patroncard: Add possibility to print from patron lists

2015-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14131

Marc Véron ve...@veron.ch changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=14138

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14138] Patroncard: Prevent errors if create-pdf.pl gets wrong parameters

2015-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14138

Marc Véron ve...@veron.ch changed:

   What|Removed |Added

   Assignee|cnighswon...@foundations.ed |ve...@veron.ch
   |u   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14138] Patroncard: Prevent errors if create-pdf.pl gets wrong parameters

2015-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14138

Marc Véron ve...@veron.ch changed:

   What|Removed |Added

  Component|I18N/L10N   |Label/patron card printing
   Assignee|koha-b...@lists.koha-commun |cnighswon...@foundations.ed
   |ity.org |u

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14128] Capitalization: Guided Reports - step 2 - Build A Report

2015-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14128

Héctor Eduardo Castro Avalos hector.hecax...@gmail.com changed:

   What|Removed |Added

  Attachment #38802|0   |1
is obsolete||
  Attachment #38831|0   |1
is obsolete||

--- Comment #4 from Héctor Eduardo Castro Avalos hector.hecax...@gmail.com ---
Created attachment 38851
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38851action=edit
[SIGNED-OFF]Bug 14128 - Capitalization: Guided Reports - step 2 - Build A
Report

To verify and test:
Go to Home  Reports
Click on 'Build new'
Verify that the title in Step 1 and to display with correct capitalization

Sponsored-by: Universidad de El Salvador

Signed-off-by: Hector Castro hector.hecax...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14148] Bug 12412 breaks import if plugins are not enabled

2015-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14148

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14148] Bug 12412 breaks import if plugins are not enabled

2015-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14148

--- Comment #1 from Tomás Cohen Arazi tomasco...@gmail.com ---
Created attachment 38853
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38853action=edit
Bug 14148: marc import broken if plugins are not enabled

Bug 12412 introduced a way to use plugins to generate MARC records
out of any arbitrary format. But failed to properly check for
a valid configuration (plugins_enabled entry on koha-conf.xml, and
even the UseKohaPlugins syspref).

This patch makes tools/stage-marc-import.pl test for the required
configuration before attempting to create the Koha::Plugins object.

To test:
1/ Make sure you don't have a plugins_enabled entry on your koha-conf.xml file
2/ On master, browse to tools/stage-marc-import.pl
= FAIL: You get a nasty Can't call method GetPlugins... error
3/ Apply the patch and reload
= SUCCESS: Stage MARC for import page renders correctly

Repeat with plugins_enabled == 0 and == 1. Also UseKohaPlugins
enabled/disabled.
It should work as expected.

Regards
Tomas

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14138] Patroncard: Prevent errors if create-pdf.pl gets wrong parameters

2015-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14138

--- Comment #1 from Marc Véron ve...@veron.ch ---
Created attachment 38854
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38854action=edit
Bug 14138 - Patroncard: POC for pre-testing parameters for create-pdf.pl

If wrong parameters are given, create-pdf.pl displays a Software error or
creates an invalid PDF (it is a text file containing  Software error).

This patch is a proof of concept with the aim to prevent such a situation.

It implements pre-testing the parameters provided for create-pdf.pl.
If wrong parameters are given, a error message is displayed instead of creating
the PDF.
The user has then the possibility to go back to the page she came from. (Patron
card tool, maybe later patron's detail page? )

To test:

1)
Apply on top of Bug 14122 (otherwise it is not possible to test for borrower)

2)
Test with links similar to the following
...cgi-bin/koha/patroncards/create-pdf.pl?borrower_number=61template_id=24layout_id=21start_card=1
or:
...cgi-bin/koha/patroncards/create-pdf.pl?batch_id=8template_id=24layout_id=21start_card=1

3)
Change values for existing / not existing Ids. If a parameter is not valid, a
new HTML page is displayed with a JavaScript alert.
(This will need optimization. Ideas and/or patterns for doing this part are
highly welcome).

Comments are welcome - is this the way to go?

Marc

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14098] Regression in Marc Modification Templates

2015-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14098

Gaetan Boisson gaetan.bois...@biblibre.com changed:

   What|Removed |Added

 CC||gaetan.bois...@biblibre.com

--- Comment #2 from Gaetan Boisson gaetan.bois...@biblibre.com ---
That seems quite tricky. We certainly should let the user decide, but it then
becomes quite complicated to take into account all the possibilities.

Copying the value to a new 952 subfield sounds like a good default to me, right
now i cannot think of a case where the result would be unclear/unexpected.

On the other hand copying to an existing field raises the question of what
happens when we have multiple such fields in the record.

I can think of quite a few options from the top of my head:
- Add the subfield to all of the existing fields
- Do nothing
- Add only to the first such field that exists (probably not a very interesting
option...)
- Add to the field matching this and this criteria on this other subfield
- Create a new field with a subfield having the given value (current behaviour)

In the end the process would be something like:

If the record has no such field already, choose between:
- Create the field with the subfield and the wanted value
- Do nothing

If the record has exactly one field of this type, choose between:
- Add the subfield to the existing field
- Create a new field with the subfield and the wanted value
- Do nothing

If the record has multiple fields of this type, choose between:
- Add the subfield to all the existing fields
- Create a new field with the subfield and the wanted value
- Add to the field matching this and this criteria on this other subfield
- Do nothing

Else:
- Timewarp

I feel like this is a bug, since existing templates are not working as they
were before. But it seems to me that this action is very unclear in itself and
probably deserves some enhancement to let users choose more clearly what will
happen.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14128] Capitalization: Guided Reports - step 2 - Build A Report

2015-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14128

--- Comment #5 from Héctor Eduardo Castro Avalos hector.hecax...@gmail.com ---
Created attachment 38852
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38852action=edit
[SIGNED-OFF] Bug 14128 - Capitalization: Guided Reports - step 2 - Build A
Report Title 'Build a report' should display with all steps

The tile displayed only with steps #1 and #2

This patch adds the title to the following steps.

To test:
Home  Reports
Click on 'Build new'
Step through steps 1 - 6
Verify that title displays with each step.

Sponsored-by: Universidad de El Salvador

Signed-off-by: Hector Castro hector.hecax...@gmail.com
Works as advertised.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14150] Field issues.date_due does not display in ISSUESLIP or ISSUEQSLIP

2015-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14150

--- Comment #1 from Barton Chittenden bar...@bywatersolutions.com ---
Note that items.onloan *will* print correctly; this is an acceptable
work-around.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13664] Add password strength plugin

2015-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13664

--- Comment #3 from David Roberts david.robe...@ptfs-europe.com ---
Created attachment 38857
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38857action=edit
Change formatting and correct spelling mistakes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13664] Add password strength plugin

2015-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13664

--- Comment #1 from David Roberts david.robe...@ptfs-europe.com ---
Created attachment 38855
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38855action=edit
Add jquery-complexify library

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13664] Add password strength plugin

2015-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13664

--- Comment #2 from David Roberts david.robe...@ptfs-europe.com ---
Created attachment 38856
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38856action=edit
Added complexify display to opac-passwd page

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11057] Bootstrap theme: Don't hide language chooser below the fold

2015-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11057

Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13664] Add password strength plugin

2015-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13664

--- Comment #14 from David Roberts david.robe...@ptfs-europe.com ---
Created attachment 38868
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38868action=edit
Put staff client password strength meter under syspref control

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11057] Bootstrap theme: Don't hide language chooser below the fold

2015-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11057

--- Comment #8 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com ---
Created attachment 38870
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38870action=edit
Bug 11057: Bootstrap theme: Don't hide language chooser below the fold

This patch removes one attribute from one class on opac.less
Generated css files show language changer all the time

To test:
1) Update and translate for a anguage of your choice
2) Enable lang on OPAC, also allow opaclanguagesdisplay
3) Go to OPAC, note language changer 'hidden', scroll to view
4) Apply the patch
5) Check you have node.js and lessc
(nodejs and node-less packeages)
6) Compile and replace new opac.css
lessc --compress koha-tmpl/opac-tmpl/bootstrap/less/opac.less 
koha-tmpl/opac-tmpl/bootstrap/css/opac.css
7) Reload OPAC, check language changer is visible without scrolling.
8) Check Advanced search, Authority search, Tag cloud, Login page, etc
Language changer must be visible without scroll

I do not provide a new opac.css
Hope Owen could take a look

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13664] Add password strength plugin

2015-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13664

--- Comment #13 from David Roberts david.robe...@ptfs-europe.com ---
Created attachment 38867
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38867action=edit
Add code to updatedatabase.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13664] Add password strength plugin

2015-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13664

--- Comment #11 from David Roberts david.robe...@ptfs-europe.com ---
Created attachment 38865
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38865action=edit
Add complexify includes file to staff client

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13664] Add password strength plugin

2015-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13664

--- Comment #5 from David Roberts david.robe...@ptfs-europe.com ---
Created attachment 38859
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38859action=edit
Add SQL for OPACPasswordStrength syspref

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13664] Add password strength plugin

2015-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13664

--- Comment #6 from David Roberts david.robe...@ptfs-europe.com ---
Created attachment 38860
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38860action=edit
Add default OPACPasswordStrength syspref to updatedatabase.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13664] Add password strength plugin

2015-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13664

--- Comment #10 from David Roberts david.robe...@ptfs-europe.com ---
Created attachment 38864
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38864action=edit
Add jquery plugins to staff client

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13664] Add password strength plugin

2015-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13664

--- Comment #12 from David Roberts david.robe...@ptfs-europe.com ---
Created attachment 38866
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38866action=edit
Add new PasswordStrength syspref

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13664] Add password strength plugin

2015-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13664

--- Comment #9 from David Roberts david.robe...@ptfs-europe.com ---
Created attachment 38863
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38863action=edit
Add password strength meter to staff client

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13664] Add password strength plugin

2015-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13664

--- Comment #8 from David Roberts david.robe...@ptfs-europe.com ---
Created attachment 38862
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38862action=edit
Put password meter under syspref control

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13664] Add password strength plugin

2015-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13664

--- Comment #7 from David Roberts david.robe...@ptfs-europe.com ---
Created attachment 38861
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38861action=edit
Add OPACPasswordStrength System Preference to Auth.pm

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13664] Add password strength plugin

2015-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13664

--- Comment #4 from David Roberts david.robe...@ptfs-europe.com ---
Created attachment 38858
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38858action=edit
Add OPACPasswordStrength syspref to staff client

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13664] Add password strength plugin

2015-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13664

David Roberts david.robe...@ptfs-europe.com changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

--- Comment #16 from David Roberts david.robe...@ptfs-europe.com ---
To Test:

This patch adds two new system preferences: PasswordStrength which works in the
staff client, and OPACPasswordStrength which controls the OPAC.

1) Install patches
2) Enable both system preferences.
3) Log into the OPAC
4) Go to Change your Password
5) Type a new password into the new password field - the meter should indicate
how strong the password is based on the length of the password and whether or
not any part of the password appears in a ban list of some 500 bad passwords
(e.g. qwerty, password, 1234 etc)

6) Log into the staff client
7) Create a new patron - the meter should display next to the password field.
8) Check that it also displays when editing or duplicating a patron.

Check that typing into the field moves the meter appropriately, and that you
are still able to save passwords / edits to the user record when this system
preference is enabled.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13664] Add password strength plugin

2015-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13664

David Roberts david.robe...@ptfs-europe.com changed:

   What|Removed |Added

 CC||david.roberts@ptfs-europe.c
   ||om

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13664] Add password strength plugin

2015-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13664

--- Comment #15 from David Roberts david.robe...@ptfs-europe.com ---
Created attachment 38869
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38869action=edit
Add password strength meter to add and duplicate user in staff client

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12412] Add ability for plugins to convert arbitrary files to MARC from record staging tool

2015-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12412

--- Comment #13 from Dobrica Pavlinusic dpav...@rot13.org ---
It's a little bit worse: plugins had to be enabled. Even adding

 enable_plugins0/enable_plugins

to koha-conf.xml won't help.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14151] SIP2 Checkouts file in Koha 3.18

2015-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14151

--- Comment #1 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 38872
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38872action=edit
Bug 14151 - SIP2 Checkouts file in Koha 3.18

When Bug 12820 was added to Koha 3.18, the namespace was not altered.
This causes checkouts to fail via SIP2.

Test Plan:
1) Attempt to check out an item via SIP2
2) Note you never get back a response
3) Apply this patch
4) Repeat step 1
5) Note it now works!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14151] SIP2 Checkouts file in Koha 3.18

2015-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14151

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14103] Discharge management: Software error on main page after upgrade - Missing dependencies on About page

2015-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14103

Chris Nighswonger cnighswon...@foundations.edu changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=14152

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14152] Check for required dependencies during upgrades

2015-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14152

Chris Nighswonger cnighswon...@foundations.edu changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=14103

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14152] Check for required dependencies during upgrades

2015-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14152

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

 CC||tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14131] Patroncard: Add possibility to print from patron lists

2015-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14131

Chris Nighswonger cnighswon...@foundations.edu changed:

   What|Removed |Added

 CC||cnighswon...@foundations.ed
   ||u

--- Comment #2 from Chris Nighswonger cnighswon...@foundations.edu ---
When attempting to create a patron list (running master), I receive an error
which states:

An error occurred.

See the attached screenshot.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14131] Patroncard: Add possibility to print from patron lists

2015-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14131

Chris Nighswonger cnighswon...@foundations.edu changed:

   What|Removed |Added

  Attachment #38875|0   |1
is obsolete||

--- Comment #4 from Chris Nighswonger cnighswon...@foundations.edu ---
Created attachment 38876
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38876action=edit
Error when attempting to build a patron list

And now the shot with the error showing...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14152] Check for required dependencies during upgrades

2015-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14152

Chris Nighswonger cnighswon...@foundations.edu changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|gmcha...@gmail.com  |cnighswon...@foundations.ed
   ||u

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14152] New: Check for required dependencies during upgrades

2015-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14152

Bug ID: 14152
   Summary: Check for required dependencies during upgrades
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: gmcha...@gmail.com
  Reporter: cnighswon...@foundations.edu
QA Contact: testo...@bugs.koha-community.org

When performing upgrades, the code should re-check for required dependencies.
This is particularly important for those installations which are not
package-based.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14152] Check for required dependencies during upgrades

2015-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14152

--- Comment #1 from Chris Nighswonger cnighswon...@foundations.edu ---
Created attachment 38874
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38874action=edit
Bug 14152: Re-check required dependencies during upgrade process

This code causes the installer to re-check dependencies during the
upgrade process.

Test Plan:

1.  Remove a required dependency. (Such as the recently added
PDF::FromHTML and associated HTML::Tidy.)

2.  Run the installer and note that it does not catch the missing
dependency.

3.  Also note that things break badly due to the missing dependency.

4.  Apply this patch.

5.  Under Global System Preferences  Local Use  Version change the
dev revision number back one unit and save.

6.  The updater will run and catch the missing dependency.

7.  Install the missing dependency.

8.  Return to the updater and continue with the update.

9.  The update should complete successfully.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14152] Check for required dependencies during upgrades

2015-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14152

Chris Nighswonger cnighswon...@foundations.edu changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14131] Patroncard: Add possibility to print from patron lists

2015-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14131

--- Comment #3 from Chris Nighswonger cnighswon...@foundations.edu ---
Created attachment 38875
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38875action=edit
Error when attempting to build a patron list

This may be a tangential bug not directly related to this enhancement, but I'll
wait for confirmation before opening a separate bug report.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14152] Check for required dependencies during upgrades

2015-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14152

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10105] Gate register module

2015-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10105

--- Comment #9 from Indranil Das Gupta indr...@gmail.com ---
(In reply to Nabakumar from comment #7)
 First of all thanks a lot for this valuable information.Can i have a video
 regarding this?

The client I was writing this for ran short on funds. So, presently looking for
sponsors.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12412] Add ability for plugins to convert arbitrary files to MARC from record staging tool

2015-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12412

David Cook dc...@prosentient.com.au changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10105] Gate register module

2015-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10105

Indranil Das Gupta indr...@gmail.com changed:

   What|Removed |Added

  Change sponsored?|Sponsored   |---

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14132] suggestions table is missing indexes

2015-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14132

Fridolin SOMERS fridolyn.som...@biblibre.com changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14132] suggestions table is missing indexes

2015-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14132

--- Comment #7 from Fridolin SOMERS fridolyn.som...@biblibre.com ---
Ready for signoff.

I've spitted each alter table in a unique line because if one key already
exists the all line fails.
If the key alreeady exists, it will still return an error even with ALTER
IGNORE. Looks like the is only useful for unique keys.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14132] suggestions table is missing indexes

2015-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14132

--- Comment #4 from Fridolin SOMERS fridolyn.som...@biblibre.com ---
(In reply to Marc Véron from comment #3)
 Should this have the status Needs sign-off?
Indeed.
I've used git bz without -e.

 
 For the second patch: 
 Instead of
 ALTER TABLE `suggestions`...
 maybe better:
 ALTER IGNORE TABLE `suggestions`...
 
 http://wiki.koha-community.org/wiki/Database_updates

Ok thanks. I did not knew that INGORE can be used with ALTER TABLE.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14059] Fully testing C4::Creators::Lib

2015-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14059

--- Comment #9 from Julian FIOL julian.f...@biblibre.com ---
Created attachment 38840
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38840action=edit
Bug 14059 : Deleting 'issues' table before processing the tests

It's suppose to avoid foreign key trouble

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14059] Fully testing C4::Creators::Lib

2015-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14059

Julian FIOL julian.f...@biblibre.com changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14132] suggestions table is missing indexes

2015-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14132

Fridolin SOMERS fridolyn.som...@biblibre.com changed:

   What|Removed |Added

  Attachment #38807|0   |1
is obsolete||

--- Comment #6 from Fridolin SOMERS fridolyn.som...@biblibre.com ---
Created attachment 38842
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38842action=edit
Bug 14132 - suggestions table is missing indexes - atomicupdate

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14132] suggestions table is missing indexes

2015-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14132

Fridolin SOMERS fridolyn.som...@biblibre.com changed:

   What|Removed |Added

  Attachment #38806|0   |1
is obsolete||

--- Comment #5 from Fridolin SOMERS fridolyn.som...@biblibre.com ---
Created attachment 38841
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38841action=edit
Bug 14132 - suggestions table is missing indexes

Suggestions table is missing some indexes.

Index on biblionumber will speed up
C4::Suggestions::GetSuggestionInfoFromBiblionumber(), often called in a loop.
Index on status and branchcode will speed up many queries.
Note that an index on budgetid is automatically added by the creation of the
foreign key constraint.

Test plan :
- Check performance with an invoice containing a lot of orders.
- Check suggestions pages are faster or at least not slower.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11057] Bootstrap theme: Don't hide language chooser below the fold

2015-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11057

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #7 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
This is still a problem we experience in Koha 3.18.5.1 - even for an almost
empty Koha start page the language chooser is hiding. This is a problem as
people have problems locating it as they don't expect it to be hidden below.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14146] New: Additional days are not added to restriction period when checking-in several overdues for same patron

2015-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14146

Bug ID: 14146
   Summary: Additional days are not added to restriction period
when checking-in several overdues for same patron
 Change sponsored?: ---
   Product: Koha
   Version: 3.16
  Hardware: PC
OS: Windows
Status: NEW
  Severity: minor
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: carol.and...@masmedios.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

We've noticed that when checking in some items with overdues Koha only takes
the first checked-in item to apply the restriction period to that borrower.

A borrower has three overdue items. We check-in the first of them, and Koha
automatically sets a restriction period for that borrower. We check-in second
and third item, but restriction period remains the same number of days,
additional days of suspension are not accumulated to the restriction period.

The expected behaviour would be that Koha added days to the restriction period
for every single overdue the borrower checked-in, whether the check-in date of
the overdue items was.

Build 2015-03-27 on Windows 7, running Google Chrome and also tested with
Mozilla Firefox and Internet Explorer.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14152] Check for required dependencies during upgrades

2015-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14152

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

  Attachment #38874|0   |1
is obsolete||

--- Comment #2 from M. Tompsett mtomp...@hotmail.com ---
Created attachment 38877
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38877action=edit
Bug 14152: Re-check required dependencies during upgrade process

This code causes the installer to re-check dependencies during the
upgrade process.

Test Plan
-
1) Log in to staff client
2) Koha Administration - Global system preferences - Local
3) Change Version to previous version -- DO NOT HIT SAVE YET!
4) In command line: sudo apt-get purge libpdf-fromhtml-perl
   NOTE: This could be ANY required library. I chose
 PDF::FromHTML, because it has been a thorn in my side.
5) NOW! Hit the 'Save' button.
6) Log in, etc. etc...
   -- Blows up on redirect to log in.
7) In command line, add it back (I had to compile my own so,
   I used sudo dpkg -i /path/to/libpdf-fromhtml-perl...)
8) Apply patch
9) Edit the C4/Installer/PerlDependencies.pm to make
   PDF::FromHTML required. See also bug 14103.
10) Log in to staff client
11) Koha Administration - Global system preferences - Local
12) Change Version to previous version -- DO NOT HIT SAVE YET!
13) In command line: sudo apt-get purge libpdf-fromhtml-perl
14) NOW! Hit the 'Save' button.
15) Log in, etc. etc...
16) Once warned you are missing it, add it back at the command line.
17) Click 'Recheck'
-- Proceeds as expected now.

Signed-off-by: Mark Tompsett mtomp...@hotmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14152] Check for required dependencies during upgrades

2015-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14152

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com

--- Comment #3 from M. Tompsett mtomp...@hotmail.com ---
With libxml-libxslt-perl, there is no kaboom, but somehow it let's you proceed.
Once the patch is applied, it is properly caught.

Don't let the test case I gave with PDF::FromHTML stop this from passing QA. :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14152] Check for required dependencies during upgrades

2015-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14152

--- Comment #4 from Tomás Cohen Arazi tomasco...@gmail.com ---
Thanks for taking cara of this, Chris.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14149] Labels: Make barcode width and height scaling editable

2015-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14149

--- Comment #1 from Marc Véron ve...@veron.ch ---
Hi Chris,
I'm sorry but it is not as easy as with the patron cards.

Reason: 
Patron cards store the layout values as xml in the table creator_layouts in
field layout_xml, while labels store their values in separate columns.

This is commented in line 41 of :
# FIXME: all layouts should be stored in xml format to greatly simplify
handling -chris_n

To expose scaling for editing it would be necessary to first move store the
values in the xml field. For exsting installations the values of defined labels
would have to be transferred to xml as well and after that the obsolete columns
could be removed.

We would then have the same situation as with patron cards and could implement
the scaling editing following the same pattern.

Link to schema:
http://schema.koha-community.org/tables/creator_layouts.html

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14152] Check for required dependencies during upgrades

2015-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14152

--- Comment #5 from M. Tompsett mtomp...@hotmail.com ---
(In reply to M. Tompsett from comment #3)
 With libxml-libxslt-perl, there is no kaboom,

-- the staff client, but OPAC will barf nicely when you try to search for
something.

 but somehow it lets you proceed.
 Once the patch is applied, it is properly caught.

YAY! Please Pass QA this. :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14151] SIP2 Checkouts file in Koha 3.18

2015-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14151

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14103] Discharge management: Software error on main page after upgrade - Missing dependencies on About page

2015-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14103

--- Comment #8 from Tomás Cohen Arazi tomasco...@gmail.com ---
(In reply to Robin Sheat from comment #7)
 I've added some patches using quilt that fix the encoding issues. For an
 intro to using quilt, go here:
 
 http://pkg-perl.alioth.debian.org/howto/quilt.html

Thanks Robin. Can you point me to some reference docs on how to build the
package from source (for testing purposees)? I'm only familiar with
dh-make-perl and always used --cpan.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14151] New: SIP2 Checkouts file in Koha 3.18

2015-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14151

Bug ID: 14151
   Summary: SIP2 Checkouts file in Koha 3.18
 Change sponsored?: ---
   Product: Koha
   Version: 3.18
  Hardware: All
OS: All
Status: NEW
  Severity: critical
  Priority: P5 - low
 Component: SIP2
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: k...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: colin.campb...@ptfs-europe.com

When Bug 12820 was added to Koha 3.18, the namespace was not altered. This
causes checkouts to fail via SIP2.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14148] Bug 12412 breaks import if plugins are not enabled

2015-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14148

Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed:

   What|Removed |Added

  Attachment #38853|0   |1
is obsolete||

--- Comment #2 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com ---
Created attachment 38873
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38873action=edit
[SIGNED.OFF] Bug 14148: marc import broken if plugins are not enabled

Bug 12412 introduced a way to use plugins to generate MARC records
out of any arbitrary format. But failed to properly check for
a valid configuration (plugins_enabled entry on koha-conf.xml, and
even the UseKohaPlugins syspref).

This patch makes tools/stage-marc-import.pl test for the required
configuration before attempting to create the Koha::Plugins object.

To test:
1/ Make sure you don't have a plugins_enabled entry on your koha-conf.xml file
2/ On master, browse to tools/stage-marc-import.pl
= FAIL: You get a nasty Can't call method GetPlugins... error
3/ Apply the patch and reload
= SUCCESS: Stage MARC for import page renders correctly

Repeat with plugins_enabled == 0 and == 1. Also UseKohaPlugins
enabled/disabled.
It should work as expected.

Regards
Tomas

Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com
Works as described, no koha-qa errors

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14006] about.pl checks the wrong zebra index mode

2015-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14006

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #5 from Tomás Cohen Arazi tomasco...@gmail.com ---
Fix pushed to master.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12671] Guess next serial date when there are several issues per unit

2015-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12671

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

 CC||tomasco...@gmail.com
 Status|Passed QA   |Pushed to Master

--- Comment #17 from Tomás Cohen Arazi tomasco...@gmail.com ---
Patches pushed to master.

Good job Julian!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9089] show suggestion number on suggestion management

2015-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9089

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

 CC||tomasco...@gmail.com
 Status|Passed QA   |Pushed to Master

--- Comment #10 from Tomás Cohen Arazi tomasco...@gmail.com ---
Patch pushed to master.

Thanks Nicolas!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14150] New: Field issues.date_due does not display in ISSUESLIP or ISSUEQSLIP

2015-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14150

Bug ID: 14150
   Summary: Field issues.date_due does not display in ISSUESLIP or
ISSUEQSLIP
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Patrons
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: bar...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

Created attachment 38871
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38871action=edit
SAMPLE ISSUESLIP (may be used for testing).

The field issues.date_due will not display in the ISSUESLIP or ISSUEQSLIP
notices, when printed inside checkedout or overdue tags.

Steps to replicate:

1) Go to tools-notices and slips, edit ISSUESLIP for all branches.
2) Put the following text in the EMAIL template:

checkedout
Checked out: Date Due: issues.date_due
/checkedout

overdue
Overdue: Date Due: issues.date_due
/overdue

3) Set the following fields in ISSUESLIP (I don't know that any of these
matter)
   Name: Issue Slip
   HTML Message: [checked]
   Message Subject: Issue Slip
4) Check out an item
5) Click Print Issue Slip

You will see that the issue slip does not print issues.date_due

the same problem affects ISSUEQSLIP.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14148] Bug 12412 breaks import if plugins are not enabled

2015-05-05 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14148

Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed:

   What|Removed |Added

 CC||bgkrie...@gmail.com
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >