[Koha-bugs] [Bug 14128] Capitalization: Guided Reports - step 2 - Build A Report
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14128 Marcel de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14128] Capitalization: Guided Reports - step 2 - Build A Report
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14128 --- Comment #7 from Marcel de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 38963 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38963action=edit Bug 14128 - Capitalization: Guided Reports - step 2 - Build A Report Title 'Build a report' should display with all steps The tile displayed only with steps #1 and #2 This patch adds the title to the following steps. To test: Home Reports Click on 'Build new' Step through steps 1 - 6 Verify that title displays with each step. Sponsored-by: Universidad de El Salvador Signed-off-by: Hector Castro hector.hecax...@gmail.com Works as advertised. Signed-off-by: Hector Castro hector.hecax...@gmail.com Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14128] Capitalization: Guided Reports - step 2 - Build A Report
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14128 Marcel de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Attachment #38851|0 |1 is obsolete|| Attachment #38852|0 |1 is obsolete|| --- Comment #6 from Marcel de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 38962 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38962action=edit Bug 14128 - Capitalization: Guided Reports - step 2 - Build A Report To verify and test: Go to Home Reports Click on 'Build new' Verify that the title in Step 1 and to display with correct capitalization Sponsored-by: Universidad de El Salvador Signed-off-by: Hector Castro hector.hecax...@gmail.com Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14160] typo in AddressFormat preference
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14160 Marcel de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14160] typo in AddressFormat preference
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14160 Marcel de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Attachment #38896|0 |1 is obsolete|| --- Comment #3 from Marcel de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 38966 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38966action=edit Bug 14160: Fix typo in AddressFormat preference The preference was missing a 'd' in the word address. To test: * Visit preferences * Visit I18N/L10N tab * Confirm spelling of options in Addressformat preference Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com Spelling is right, no errors Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14160] typo in AddressFormat preference
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14160 Marcel de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14128] Capitalization: Guided Reports - step 2 - Build A Report
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14128 Marcel de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | CC||m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11941] Patron lists are not easily accessible
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11941 Marcel de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | CC||gmcha...@gmail.com, ||kyle.m.h...@gmail.com Component|Lists |Patrons Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11941] Patron lists are not easily accessible
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11941 Marcel de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11941] Patron lists are not easily accessible
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11941 Marcel de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Attachment #38879|0 |1 is obsolete|| --- Comment #6 from Marcel de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 38964 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38964action=edit Bug 11941: Add link to patron lists from the patron home page The patron lists are only accessible from the tools module, which is not easily accessible when you are in the patron module. Test plan: Go on the patron home page. In the toolbar, you should see a link to the patron lists. NOTE: Tweaked button to a to get the click to work. Signed-off-by: Mark Tompsett mtomp...@hotmail.com Signed-off-by: Liz Rea l...@catalyst.net.nz Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11576] Untranslatable manage in serials-collection
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11576 Marcel de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Attachment #38891|0 |1 is obsolete|| --- Comment #5 from Marcel de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 38965 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38965action=edit Bug 11576: Make manage translatable - serials-collection If a subscription is irregular, a tab with manage is displayed on the serial collection page. But this string is not translatable. Test plan: 1/ Go on the serial collection page of an irregular subscription (or create one). 2/ Note that the first tab was named managed, it's now Manage. 3/ Update a po lang file and confirm you see the string and you are able to translate it. Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com Work as described, no koha-qa errors Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11576] Untranslatable manage in serials-collection
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11576 Marcel de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | CC||m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11576] Untranslatable manage in serials-collection
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11576 Marcel de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9892] export_borrowers.pl cannot handle tab-separated output
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9892 Marcel de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Attachment #38967|0 |1 is obsolete|| Attachment #38968|0 |1 is obsolete|| --- Comment #7 from Marcel de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 38969 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38969action=edit Bug 9892: Make export_borrowers.pl using the delimiter pref The original concern of bug 9892 was that this borrowers export script cannot handle tabulation to separate columns. With this patch, the delimiter preference is used as separator for the output, to be consistent with others scripts. This should be highlighted on the release, it can produce change in behaviors. Test plan: Confirm that the 'delimiter' pref is used for the output, but you are able to overwrite it with the 'separator' parameter Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com Works as expected, respect preference but is supeseeded by cmd line No koha-qa errors Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9892] export_borrowers.pl cannot handle tab-separated output
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9892 --- Comment #8 from Marcel de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 38970 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38970action=edit Bug 9892: [QA Follow-up] Typo and updated usage Corrected specifield. Updated usage statement on use of delimiter pref. Clarified the CONDITION explanation somewhat.. Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9892] export_borrowers.pl cannot handle tab-separated output
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9892 --- Comment #9 from Marcel de Rooy m.de.r...@rijksmuseum.nl --- QA Comment: The problem in Comment1 has not yet been fully addressed. You can now choose tabulation in the delimiter pref but it is hard to pass a tab via the command line. But it is an improvement imo. The commit message says: [This should be highlighted on the release, it can produce change in behaviors.] This only pertains to the situation that someone does not pass a separator parameter and has a delimitercomma. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9892] export_borrowers.pl cannot handle tab-separated output
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9892 Marcel de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Attachment #38895|0 |1 is obsolete|| --- Comment #5 from Marcel de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 38967 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38967action=edit Bug 9892: Make export_borrowers.pl using the delimiter pref The original concern of bug 9892 was that this borrowers export script cannot handle tabulation to separate columns. With this patch, the delimiter preference is used as separator for the output, to be consistent with others scripts. This should be highlighted on the release, it can produce change in behaviors. Test plan: Confirm that the 'delimiter' pref is used for the output, but you are able to overwrite it with the 'separator' parameter Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com Works as expected, respect preference but is supeseeded by cmd line No koha-qa errors -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9892] export_borrowers.pl cannot handle tab-separated output
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9892 --- Comment #6 from Marcel de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 38968 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38968action=edit Bug 9892: [QA Follow-up] Typo and updated usage Corrected specifield. Updated usage statement on use of delimiter pref. Clarified the CONDITION explanation somewhat.. Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9892] export_borrowers.pl cannot handle tab-separated output
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9892 Marcel de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13758] KOHAVERSION should be statically set
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13758 Marcel de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13758] KOHAVERSION should be statically set
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13758 --- Comment #18 from Marcel de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 38971 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38971action=edit Bug 13758: Correct KOHA::VERSION in OverDrive.pm Correct $KOHA::VERSION to $Koha::VERSION. Also, passing this string to LWP::UserAgent is wrong. It expects key/value pairs. Since this string is apparently intended as an agent, this patch passes it as such. Note: The OverDrive has unfortunately no unit tests. Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl Tested this change in the perl debugger with just these lines: use C4::External::OverDrive; C4::External::OverDrive::_request(); Printed $ua-agent while stepping into sub _request. Without the agent change, the adjusted Koha string would just be ignored and I would still have libwww-perl/6.04 as agent. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13758] KOHAVERSION should be statically set
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13758 Marcel de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13758] KOHAVERSION should be statically set
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13758 Marcel de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13758] KOHAVERSION should be statically set
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13758 --- Comment #19 from Marcel de Rooy m.de.r...@rijksmuseum.nl --- Tomas: Please see the last QA follow-up. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13758] KOHAVERSION should be statically set
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13758 Marcel de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl Status|Pushed to Master|ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14147] Add unit tests to C4::External::OverDrive
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14147 Marcel de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl --- Comment #4 from Marcel de Rooy m.de.r...@rijksmuseum.nl --- Hey Julian, I am not sure about passing QA on this patch. You only actually do some trivial tests for IsOverDriveEnabled. The real stuff with requests, UserAgent etc. (probably mocking OverDrive behavior somehow) is not there. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9892] export_borrowers.pl cannot handle tab-separated output
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9892 Marcel de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added QA Contact||m.de.r...@rijksmuseum.nl CC||m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14172] Acq: Spent lists incorrect titles and wrong total in some cases
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14172 --- Comment #1 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Hm, the problem seems to be that there is an entry in aqorders_items, but the corresponding item has since been deleted. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14167] Add Koha::Logger based on Log4perl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14167 --- Comment #4 from Kyle M Hall k...@bywatersolutions.com --- (In reply to M. Tompsett from comment #3) Comment on attachment 38954 [details] [review] Bug 14167 - Add Koha::Logger based on Log4perl Review of attachment 38954 [details] [review]: - ::: Koha/Logger.pm @@ +58,5 @@ +my ( $class, $category ) = @_; + +croak(No category passed in!) unless $category; + +my $interface = C4::Context-interface(); What if it isn't set? The idea is that we want the category to be required. That is absolutely no reason to log a line without specifying a category. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14172] New: Acq: Spent lists incorrect titles and wrong total in some cases
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14172 Bug ID: 14172 Summary: Acq: Spent lists incorrect titles and wrong total in some cases Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org In the acquisition module the spent and ordered amounts are linked to separate pages which show the records and freight costs that build up to the amount seen in the table. The page showing the ordered records appearst to be always correct, but there are problems with the spent page. At the moment, the problem always seems to occur for the 'serials' fund in each library (subscription order workflow?) The list is missing records in this case and the total is incorrect and not matching the value shown on the acq start page. We see this behaviour in several databases using acquisitons + serials with 3.18.5.1. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13969] Testing C4::Review
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13969 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #38982|0 |1 is obsolete|| Attachment #38983|0 |1 is obsolete|| Attachment #38984|0 |1 is obsolete|| --- Comment #11 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 38985 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38985action=edit Bug 13969 : Testing C4::Review Testing C4::Review in t/db_dependent/Review.t Adding a pod for every sub TEST PLAN - 1. Apply patch 2. prove -v t/db_dependent/Review.t -- All 117 tests should run successfully without any error or warning TEST PLAN OPTIONAL -- Go check bug 13899 and see that coverage is 100% for this module. Coverage BEFORE this patch : Statement : 21,9% Branch : 0,0% Condition : 0,0% Subroutine : 33,3% Pod: 33,3% Coverage AFTER this patch : Statement : 100,0% Branch : 100,0% Condition :N/A Subroutine : 100,0% Pod: 100,0% Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com All tests run -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13969] Testing C4::Review
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13969 --- Comment #16 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 38990 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38990action=edit [PASSED QA] Bug 13969 [QA Followup] - Delete issues before borrowers Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14173] New: Paging on 'recent comments' page in OPAC is not displaying correctly
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14173 Bug ID: 14173 Summary: Paging on 'recent comments' page in OPAC is not displaying correctly Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org Created attachment 38992 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38992action=edit Screenshot of broken paging The recent comments paging is displayig the 'current' page to the right side of the paging list. (see screenshot) In order to test this you need to activate the page via system preference and then add 21+ comments to different records in your catalog. There is also a small bug, as we are missing a space before the 'by' in each entry. Verified on a somewhat recent master and a 3.18.5.1 installation. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14147] Add unit tests to C4::External::OverDrive
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14147 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14147] Add unit tests to C4::External::OverDrive
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14147 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #38949|0 |1 is obsolete|| --- Comment #6 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 38991 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38991action=edit [PASSED QA] Bug 14147: Add unit tests to C4::External::OverDrive This patch test 'IsOverDriveEnabled' subroutine TEST PLAN - 1. Apply patch 2. prove -v t/External/OverDrive.t -- All tests should run successfully without any error or warning TEST PLAN OPTIONAL -- Check with bug 13899 to see the coverage of this module. Coverage BEFORE this patch : Statement : 47,5% Branch : 0,0% Condition : 0,0% Subroutine : 75,0% Coverage AFTER this patch : Statement : 49,1% Branch : 0,0% Condition : 33,3% Subroutine : 83,3% Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com Tests tun, no koha-qa errors Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14167] Add Koha::Logger based on Log4perl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14167 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #38954|0 |1 is obsolete|| --- Comment #5 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 38980 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38980action=edit Bug 14167 - Add Koha::Logger based on Log4perl Koha needs a better logger, and it seems like the best solution would be to take advantage of Log4perl which is already a fully featured logger. We use Log4perl to selectively decide what statements should be logged, and where they should go! Test plan: 0) Install Log::Log4perl via packages or cpan 1) Apply this patch 2) Copy etc/log4perl.conf to your koha conf directory, edit the paths to match your current error logs 3) Edit your koha-conf file and add the log4perl_conf/path/to/log4perl.conf/log4perl_conf line 4) Watch your intranet and opac error logs 5) Perform a renewal via the staff interface, note there is nothing new in the log file 7) Update the log4perl.conf, change the log level from DEBUG to TRACE for both the staff and opac sides 8) Perform a renewal via the staff interface, note the logged lines 9) Perform a renewal via the opac, note the logged lines -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13969] Testing C4::Review
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13969 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #38985|0 |1 is obsolete|| Attachment #38986|0 |1 is obsolete|| Attachment #38987|0 |1 is obsolete|| --- Comment #14 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 38988 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38988action=edit [PASSED QA] Bug 13969 : Testing C4::Review Testing C4::Review in t/db_dependent/Review.t Adding a pod for every sub TEST PLAN - 1. Apply patch 2. prove -v t/db_dependent/Review.t -- All 117 tests should run successfully without any error or warning TEST PLAN OPTIONAL -- Go check bug 13899 and see that coverage is 100% for this module. Coverage BEFORE this patch : Statement : 21,9% Branch : 0,0% Condition : 0,0% Subroutine : 33,3% Pod: 33,3% Coverage AFTER this patch : Statement : 100,0% Branch : 100,0% Condition :N/A Subroutine : 100,0% Pod: 100,0% Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com All tests run Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13969] Testing C4::Review
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13969 --- Comment #10 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 38984 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38984action=edit Bug 13969 [QA Followup] - Delete issues before borrowers -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13969] Testing C4::Review
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13969 --- Comment #13 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 38987 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38987action=edit Bug 13969 [QA Followup] - Delete issues before borrowers -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13969] Testing C4::Review
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13969 --- Comment #12 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 38986 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38986action=edit Bug 13969 : Replace calls to $sth-fetchrow* with a call to $dbh-selectrow* and Cleaning files 1. Replace all calls to $sth-fetchrow_array with a call to $dbh-selectrow_array 2. Cleaning Review.t file with perltiny 3. Cleaning Review.t Review.pl files with koha-qa tool Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com No koha-qa errors -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13899] Adding misc/devel/coverage.pl, a script making a cover on all modules to see which ones are not tested yet.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13899 --- Comment #18 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 38979 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38979action=edit [PASSED QA] Bug 13899: Changing license to GPLv3 koha-qa should be good : OKmisc/devel/coverage.pl OK critic OK forbidden patterns OK pod OK valid OKC4/Installer/PerlDependencies.pm OK critic OK forbidden patterns OK pod OK valid Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com No koha-qa errors. Test plan not explicitly stated, script run and generates a lot of data :) Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13899] Adding misc/devel/coverage.pl, a script making a cover on all modules to see which ones are not tested yet.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13899 --- Comment #17 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 38978 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38978action=edit [PASSED QA] Bug 13899: Add changes as asked in Comment 5 Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com Fixed a small conflict on PerlDependencies.pm Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13899] Adding misc/devel/coverage.pl, a script making a cover on all modules to see which ones are not tested yet.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13899 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #3|0 |1 is obsolete|| Attachment #38889|0 |1 is obsolete|| Attachment #38890|0 |1 is obsolete|| --- Comment #16 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 38977 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38977action=edit [PASSED QA] Bug 13899: Adding misc/devel/coverage.pl It's a script making a cover on all modules to see which ones are not tested yet. It uses Devel::Cover Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13899] Adding misc/devel/coverage.pl, a script making a cover on all modules to see which ones are not tested yet.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13899 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13969] Testing C4::Review
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13969 --- Comment #9 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 38983 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38983action=edit Bug 13969 : Testing C4::Review Testing C4::Review in t/db_dependent/Review.t Adding a pod for every sub TEST PLAN - 1. Apply patch 2. prove -v t/db_dependent/Review.t -- All 117 tests should run successfully without any error or warning TEST PLAN OPTIONAL -- Go check bug 13899 and see that coverage is 100% for this module. Coverage BEFORE this patch : Statement : 21,9% Branch : 0,0% Condition : 0,0% Subroutine : 33,3% Pod: 33,3% Coverage AFTER this patch : Statement : 100,0% Branch : 100,0% Condition :N/A Subroutine : 100,0% Pod: 100,0% Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com All tests run -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13969] Testing C4::Review
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13969 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #38897|0 |1 is obsolete|| Attachment #38898|0 |1 is obsolete|| --- Comment #8 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 38982 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38982action=edit Bug 13969 : Replace calls to $sth-fetchrow* with a call to $dbh-selectrow* and Cleaning files 1. Replace all calls to $sth-fetchrow_array with a call to $dbh-selectrow_array 2. Cleaning Review.t file with perltiny 3. Cleaning Review.t Review.pl files with koha-qa tool Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com No koha-qa errors -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13969] Testing C4::Review
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13969 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14147] Add unit tests to C4::External::OverDrive
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14147 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added CC||k...@bywatersolutions.com --- Comment #5 from Kyle M Hall k...@bywatersolutions.com --- (In reply to Marcel de Rooy from comment #4) Hey Julian, I am not sure about passing QA on this patch. You only actually do some trivial tests for IsOverDriveEnabled. The real stuff with requests, UserAgent etc. (probably mocking OverDrive behavior somehow) is not there. While I agree, I say any coverage is better than no coverage! This won't stop additional tests from being added later. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14172] Acq: Spent lists incorrect titles and wrong total in some cases
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14172 --- Comment #2 from Katrin Fischer katrin.fisc...@bsz-bw.de --- The big problem is the 'missing' item, independent of the existence of an entry in aqorders.items. As this is a very normal thing for serial orders (no items, but a subscription instead) we need to make the SQL query for the spent page more flexible to include those as well. Haven't succeeded there so far, but maybe someone else wants to give it a try. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14167] Add Koha::Logger based on Log4perl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14167 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #38980|0 |1 is obsolete|| --- Comment #7 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 38981 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38981action=edit Bug 14167 - Add Koha::Logger based on Log4perl Koha needs a better logger, and it seems like the best solution would be to take advantage of Log4perl which is already a fully featured logger. We use Log4perl to selectively decide what statements should be logged, and where they should go! Test plan: 0) Install Log::Log4perl via packages or cpan 1) Apply this patch 2) Copy etc/log4perl.conf to your koha conf directory, edit the paths to match your current error logs 3) Edit your koha-conf file and add the log4perl_conf/path/to/log4perl.conf/log4perl_conf line 4) Watch your intranet and opac error logs 5) Perform a renewal via the staff interface, note there is nothing new in the log file 7) Update the log4perl.conf, change the log level from DEBUG to TRACE for both the staff and opac sides 8) Perform a renewal via the staff interface, note the logged lines 9) Perform a renewal via the opac, note the logged lines -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13969] Testing C4::Review
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13969 --- Comment #15 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 38989 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38989action=edit [PASSED QA] Bug 13969 : Replace calls to $sth-fetchrow* with a call to $dbh-selectrow* and Cleaning files 1. Replace all calls to $sth-fetchrow_array with a call to $dbh-selectrow_array 2. Cleaning Review.t file with perltiny 3. Cleaning Review.t Review.pl files with koha-qa tool Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com No koha-qa errors Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14167] Add Koha::Logger based on Log4perl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14167 --- Comment #6 from Kyle M Hall k...@bywatersolutions.com --- ::: Koha/Logger.pm @@ +58,5 @@ +my ( $class, $category ) = @_; + +croak(No category passed in!) unless $category; + +my $interface = C4::Context-interface(); What if it isn't set? I think I missed your meaning. That's a very good question. By default if the interface isn't 'staff' it's 'opac'. I think maybe we should be able to pass in an interface parameter as well so we can set the interface to 'cli' or 'cron' or other such things. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14174] New: Home suspension and / or in situ
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14174 Bug ID: 14174 Summary: Home suspension and / or in situ Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: hectore...@yahoo.com.ar QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Currently the library where I work applies two types of sanctions: per household or per room (in situ). If the sanction is per household, the borrower may check-out a book only by room. If the sanction is in situ, the borrower is completely penalized, unable to borrow any of the two forms. (Sorry for my bad english) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14167] Add Koha::Logger based on Log4perl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14167 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #38981|0 |1 is obsolete|| --- Comment #8 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 38993 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38993action=edit Bug 14167 - Add Koha::Logger based on Log4perl Koha needs a better logger, and it seems like the best solution would be to take advantage of Log4perl which is already a fully featured logger. We use Log4perl to selectively decide what statements should be logged, and where they should go! Test plan: 0) Install Log::Log4perl via packages or cpan 1) Apply this patch 2) Copy etc/log4perl.conf to your koha conf directory, edit the paths to match your current error logs 3) Edit your koha-conf file and add the log4perl_conf/path/to/log4perl.conf/log4perl_conf line 4) Watch your intranet and opac error logs 5) Perform a renewal via the staff interface, note there is nothing new in the log file 7) Update the log4perl.conf, change the log level from DEBUG to TRACE for both the staff and opac sides 8) Perform a renewal via the staff interface, note the logged lines 9) Perform a renewal via the opac, note the logged lines -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14151] SIP2 Checkouts file in Koha 3.18
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14151 jdem...@roseville.ca.us jdem...@roseville.ca.us changed: What|Removed |Added CC||jdem...@roseville.ca.us -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14136] Remove superfluous template parameters from members/member-flags.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14136 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Signed Off |Failed QA CC||k...@bywatersolutions.com --- Comment #3 from Kyle M Hall k...@bywatersolutions.com --- Those parameters are used in circ-menu.inc which is used by this template. Without them that data does not display. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12787] Unit test files should be better organized
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12787
M. Tompsett mtomp...@hotmail.com changed:
What|Removed |Added
CC||mtomp...@hotmail.com
--- Comment #1 from M. Tompsett mtomp...@hotmail.com ---
I agree with this idea.
If it is in C4::Context...
and is not database dependent:
t/C4/Context/{function or method}.t
and is database dependent:
t/db_dependent/C4/Context/{function or method}.t
I know that would eventually mean splitting large tests up, but in the meantime
we could use 00-default.t for the large test everything ones.
Thoughts?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14150] Field issues.date_due does not display in ISSUESLIP or ISSUEQSLIP
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14150 jdem...@roseville.ca.us jdem...@roseville.ca.us changed: What|Removed |Added CC||jdem...@roseville.ca.us -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9303] relative's checkouts in the opac
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9303
--- Comment #231 from Nick Clemens n...@quecheelibrary.org ---
I am still having issues making this work correctly, I cannot see option to
show to guarantor when OPACPrivacy is enabled and I can see but not edit (on
opac-memberentry.pl) when disabled
Digging into it a bit, the line in opac-privacy.tt:
[% SET b = Koha.Find('Borrower', borrower.borrowernumber) %]
doesn't seem to be returning anything into 'b' for me.
Am I missing something?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14175] Update explanation of publication and expiration dates in newstool
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14175 --- Comment #1 from Indranil Das Gupta indr...@gmail.com --- Created attachment 38994 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38994action=edit Bug 14175 Update explanation of newstool in the manual Minor doc patch to expand upon existing explanation Using the publication and expiration date fields you can control how long your item appears. Adds examples of publication date being set differently. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14175] New: Update explanation of publication and expiration dates in newstool
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14175 Bug ID: 14175 Summary: Update explanation of publication and expiration dates in newstool Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Documentation Assignee: indr...@gmail.com Reporter: indr...@gmail.com QA Contact: testo...@bugs.koha-community.org Minor patch to expand upon existing explanation Using the publication and expiration date fields you can control how long your item appears -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13673] Remove warnings from t/db_dependent/Barcodes.t
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13673 --- Comment #2 from M. Tompsett mtomp...@hotmail.com --- Created attachment 38995 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38995action=edit Bug 13673: Fix whitespace issues Indentation was horrible. Fixed to meet 4 space standard. TEST PLAN - 1) Notice tabs in t/db_dependent/Barcodes.t 2) prove t/db_dependent/Barcodes.t 3) apply patch 4) prove t/db_dependent/Barcodes.t -- same output as before. -- code is identical except for indentations. 5) koha qa test tools -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13673] Remove warnings from t/db_dependent/Barcodes.t
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13673 --- Comment #4 from M. Tompsett mtomp...@hotmail.com --- Created attachment 38997 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38997action=edit Bug 13673: Remove diags TEST PLAN - 1) Apply first two patches 2) $ prove t/db_dependent/Barcodes.t -- Diags have been removed, just noisy warnings left. 3) $ git diff -w origin/master -- only excess print's and diag's removed. 4) koha qa test tools -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13673] Remove warnings from t/db_dependent/Barcodes.t
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13673 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13673] Remove warnings from t/db_dependent/Barcodes.t
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13673 --- Comment #5 from M. Tompsett mtomp...@hotmail.com --- Created attachment 38998 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38998action=edit Bug 13673: Silence noisy warnings in t/db_dependent/Barcodes.t This last patch catches all the warning messages in tests. TEST PLAN - 1) Apply first two patches 2) $ prove t/db_dependent/Barcodes.t -- still noisy warnings. 3) apply last patch 4) $ prove t/db_dependent/Barcodes.t -- All noisy warnings are caught. 5) koha qa test tools. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13673] Remove warnings from t/db_dependent/Barcodes.t
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13673 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Assignee|ch...@bigballofwax.co.nz|mtomp...@hotmail.com CC||mtomp...@hotmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13673] Remove warnings from t/db_dependent/Barcodes.t
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13673 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Attachment #38995|0 |1 is obsolete|| --- Comment #3 from M. Tompsett mtomp...@hotmail.com --- Created attachment 38996 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38996action=edit Bug 13673: Fix whitespace issues Indentation was horrible. Fixed to meet 4 space standard. TEST PLAN - 1) Notice tabs in t/db_dependent/Barcodes.t 2) $ prove t/db_dependent/Barcodes.t 3) apply patch 4) $ prove t/db_dependent/Barcodes.t -- same output as before. 5) $ git diff -w origin/master -- code is identical except for indentations. 6) koha qa test tools -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13591] Rss sample templates have hardcoded urls
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13591 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13591] Rss sample templates have hardcoded urls
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13591 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #38902|0 |1 is obsolete|| --- Comment #4 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 38972 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38972action=edit [PASSED QA] Bug 13591 Pass OPACBaseURL to rss creation process Links in rss templates were hardcoded to library.org.nz. Should pass and use the system's OPACBaseURL. Tested and verified. Signed-off-by: Eivin Giske Skaaren eskaa...@yahoo.no Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14152] Check for required dependencies during upgrades
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14152 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #38877|0 |1 is obsolete|| --- Comment #6 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 38973 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38973action=edit [PASSED QA] Bug 14152: Re-check required dependencies during upgrade process This code causes the installer to re-check dependencies during the upgrade process. Test Plan - 1) Log in to staff client 2) Koha Administration - Global system preferences - Local 3) Change Version to previous version -- DO NOT HIT SAVE YET! 4) In command line: sudo apt-get purge libpdf-fromhtml-perl NOTE: This could be ANY required library. I chose PDF::FromHTML, because it has been a thorn in my side. 5) NOW! Hit the 'Save' button. 6) Log in, etc. etc... -- Blows up on redirect to log in. 7) In command line, add it back (I had to compile my own so, I used sudo dpkg -i /path/to/libpdf-fromhtml-perl...) 8) Apply patch 9) Edit the C4/Installer/PerlDependencies.pm to make PDF::FromHTML required. See also bug 14103. 10) Log in to staff client 11) Koha Administration - Global system preferences - Local 12) Change Version to previous version -- DO NOT HIT SAVE YET! 13) In command line: sudo apt-get purge libpdf-fromhtml-perl 14) NOW! Hit the 'Save' button. 15) Log in, etc. etc... 16) Once warned you are missing it, add it back at the command line. 17) Click 'Recheck' -- Proceeds as expected now. Signed-off-by: Mark Tompsett mtomp...@hotmail.com Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14152] Check for required dependencies during upgrades
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14152 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added CC||k...@bywatersolutions.com Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7976] Borrow Permission is not used and can be removed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7976 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #38901|0 |1 is obsolete|| --- Comment #12 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 38974 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38974action=edit [PASSED QA] Bug 7976: Update borrowers.flags The borrowers.flags values need to be updated to prevent side effects. Test plan: Set the borrow permission flags for some borrowers Execute the updatedb entry and verify the flags has been updated (-128) only for borrowers with this permission set. Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com Moved updatedatabase entry (was in wrong position) to atomicupdate with commented copy of orignal No koha-qa errors Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7976] Borrow Permission is not used and can be removed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7976 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14132] suggestions table is missing indexes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14132 --- Comment #11 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 38976 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38976action=edit [PASSED QA] Bug 14132: suggestions table is missing indexes - atomicupdate Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com Sorry but removed backticks No errors Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14132] suggestions table is missing indexes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14132 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14168] enhance streaming cataloging to include youtube
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14168 Mirko Tietgen mi...@abunchofthings.net changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment #2 from Mirko Tietgen mi...@abunchofthings.net --- I have a prototype that uses https://metacpan.org/pod/WWW::YouTube::Download to resolve the webm video link on the fly from a regular youtube link catalogued in 856$u. I will upload it when I had some more time for testing. Two things: - WWW::YouTube::Download is packaged for Debian Jessie, but not Wheezy. It depends on libxml-treepp-perl which is available on both systems. Have not checked Ubuntu. Probably have to ask Robin what to do about that. I rolled a package for Wheezy to test, I will upload it or link to it so the patch can be tested. - I have no idea if this is compliant to Youtube TOS. It does the same thing as your browser would if you opened the Youtube link: check for the file in a desired format and then play it. Link is generated on the fly, nothing is downloaded and stored anwhere on the Koha server. The video file is sent directly to the person opening the record. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14132] suggestions table is missing indexes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14132 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #38937|0 |1 is obsolete|| Attachment #38938|0 |1 is obsolete|| --- Comment #10 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 38975 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38975action=edit [PASSED QA] Bug 14132: suggestions table is missing indexes Suggestions table is missing some indexes. Index on biblionumber will speed up C4::Suggestions::GetSuggestionInfoFromBiblionumber(), often called in a loop. Index on status and branchcode will speed up many queries. Note that an index on budgetid is automatically added by the creation of the foreign key constraint. Test plan : - Check performance with an invoice containing a lot of orders. - Check suggestions pages are faster or at least not slower. Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14145] Noisy warns in admin/preferences.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14145 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added CC||mtomp...@hotmail.com --- Comment #4 from M. Tompsett mtomp...@hotmail.com --- To sign off this bug either: 1) sign off the first two and obsolete my counter patch OR 2) sign off my counter patch and obsolete the first two. Though, I personally am confused by some of the changes in the first two patches, so that is why I wrote the counter patch. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14145] Noisy warns in admin/preferences.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14145
--- Comment #5 from M. Tompsett mtomp...@hotmail.com ---
Comment on attachment 38838
-- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38838
Bug 14145: Noisy warns in admin/preferences.pl
Review of attachment 38838:
--
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.htmlbug=14145attachment=38838)
-
::: admin/preferences.pl
@@ +46,4 @@
my $tab_template = C4::Templates::gettemplate( 'admin/preferences/' .
$tab . '.pref', 'intranet', $input );
my $active_currency = GetCurrency();
+my $local_currency;;
Double ;;'s?
@@ +112,5 @@
sort { $a-{'text'} cmp $b-{'text'} }
map {
my $option_value = $_;
{
+text = $options{type}-{$option_value},
This works, because the $options{type} doesn't exist, so two undefs reduces the
list size by an even number for the failed grep too. There is no reason to
change 'multiple' to 'type'.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14145] Noisy warns in admin/preferences.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14145 --- Comment #3 from M. Tompsett mtomp...@hotmail.com --- Created attachment 38999 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38999action=edit Bug 14145: Nicer counter-patch The problem with the odd number of hashes happens when not everything is selected. The grep returns undef, because it isn't found in @values. By turning the grep into a ternary-operator truth value, we can set a value (1 or 0) expressly. The next problem is when nothing is selected in these multiple lists, $value is undefined, so you can't split it. By splitting the definition of @values from the actual splitting, we can split only if $value is defined, thus eliminating the warning message. TEST PLAN - 1) back up your koha error log file 2) blank your koha error log file 3) log in to the staff client 4) Home - Koha administration - Global system preferences 5) Click on every tab, EXCEPT local use. 6) notice the koha error log file has warnings. 7) blank the koha error log file again 8) apply this patch 9) Click on every tab, EXCEPT local use, again. 10) notice the koha error log file has no warnings. 11) koha qa test tools. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14145] Noisy warns in admin/preferences.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14145 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Severity|enhancement |minor Assignee|koha-b...@lists.koha-commun |mtomp...@hotmail.com |ity.org | Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14145] Noisy warns in admin/preferences.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14145
--- Comment #6 from M. Tompsett mtomp...@hotmail.com ---
Comment on attachment 38839
-- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38839
Bug 14145: Noisy warns in admin/preferences.pl on Enhanced Content tab
Review of attachment 38839:
--
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.htmlbug=14145attachment=38839)
-
::: admin/preferences.pl
@@ +62,4 @@
my $name = $options{'pref'};
my $chunk = { name = $name, value = $value, type = $options{'type'}
|| 'input', class = $options{'class'} };;
+$value //= '';
If $value is undef, then the question is what else is undef in the list above?
$options{'pref'}? $options{'class'}? Because otherwise line 64 would be barfing
errors too about uneven lists.
Perhaps there is something here to fix? Neither my counter patch nor this would
fix it.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13799] Add base for building RESTful API
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 --- Comment #34 from Julian Maurice julian.maur...@biblibre.com --- (In reply to Robin Sheat from comment #33) All this said, I just downgraded tar in my package building VM to the version from squeeze, and uscan succeeds. So there is hope yet. Yay! \o/ About 5.54 vs 6.0, maybe we could ask the author of Swagger2 to change the required version of Mojolicious (if Swagger2 is proven to work with 5.54 of course). What do you think ? Will that make things easier ? On the other hand, having the latest version of Mojolicious into Debian would be great if this doesn't require extra work. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
