[Koha-bugs] [Bug 11464] Saving preferences - Nothing to Save

2015-05-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11464

Chris Cormack  changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable
 CC||ch...@bigballofwax.co.nz

--- Comment #5 from Chris Cormack  ---
Pushed to 3.18.x will be in 3.18.7

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11890] Control-Click/Command-Click to open a link in a new tab not consistently working

2015-05-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11890

Chris Cormack  changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable
 CC||ch...@bigballofwax.co.nz

--- Comment #17 from Chris Cormack  ---
Pushed to 3.18.x will be in 3.18.7

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13516] Display issue for search results with items both checkout out and lost

2015-05-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13516

Chris Cormack  changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable
 CC||ch...@bigballofwax.co.nz

--- Comment #13 from Chris Cormack  ---
Pushed to 3.18.x will be in 3.18.7

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14065] Typo in opac self registration form

2015-05-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14065

Chris Cormack  changed:

   What|Removed |Added

 CC||ch...@bigballofwax.co.nz
 Status|Pushed to Master|Pushed to Stable

--- Comment #5 from Chris Cormack  ---
Pushed to 3.18.x will be in 3.18.7

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14018] Ordering from suggestion shows 'copy. year:2014'

2015-05-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14018

Chris Cormack  changed:

   What|Removed |Added

 CC||ch...@bigballofwax.co.nz
 Status|Pushed to Master|Pushed to Stable

--- Comment #9 from Chris Cormack  ---
Pushed to 3.18.x will be in 3.18.7

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14075] Undefined value creates noisy warns in C4::AuthoritiesMarc

2015-05-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14075

Chris Cormack  changed:

   What|Removed |Added

 CC||ch...@bigballofwax.co.nz
 Status|Pushed to Master|Pushed to Stable

--- Comment #10 from Chris Cormack  ---
Pushed to 3.18.x will be in 3.18.7

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12135] Pending suggestions table width is wrong

2015-05-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12135

Chris Cormack  changed:

   What|Removed |Added

 CC||ch...@bigballofwax.co.nz
 Status|Pushed to Master|Pushed to Stable

--- Comment #8 from Chris Cormack  ---
Pushed to 3.18.x will be 3.18.7

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10976] the assistant for reports uses the wrong value for the list of item types

2015-05-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10976

Chris Cormack  changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable
 CC||ch...@bigballofwax.co.nz

--- Comment #10 from Chris Cormack  ---
Pushed to 3.18.x will be in 3.18.7

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14129] templates.readme is outdated

2015-05-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14129

Chris Cormack  changed:

   What|Removed |Added

 CC||ch...@bigballofwax.co.nz
 Status|Pushed to Master|Pushed to Stable

--- Comment #6 from Chris Cormack  ---
Pushed to 3.18.x will be in 3.18.7

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12253] MARCURLS not showing in OPAC basket

2015-05-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12253

Chris Cormack  changed:

   What|Removed |Added

 CC||ch...@bigballofwax.co.nz
 Status|Pushed to Master|Pushed to Stable

--- Comment #5 from Chris Cormack  ---
Pushed to 3.18.x will be in 3.18.7

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13982] Checkouts table not sorting on correct column

2015-05-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13982

Chris Cormack  changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable
 CC||ch...@bigballofwax.co.nz

--- Comment #7 from Chris Cormack  ---
Pushed to 3.18.x will be in 3.18.7

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14056] Small punctuation error in description for deleting a holiday

2015-05-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14056

Chris Cormack  changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable
 CC||ch...@bigballofwax.co.nz

--- Comment #7 from Chris Cormack  ---
Pushed to 3.18.x will be in 3.18.7

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12192] Template toolkit code in HTML attributes is picked up into po-files

2015-05-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12192

Chris Cormack  changed:

   What|Removed |Added

 CC||ch...@bigballofwax.co.nz
 Status|Pushed to Master|Pushed to Stable

--- Comment #8 from Chris Cormack  ---
Pushed to 3.18.x will be in 3.18.7

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14122] Patron card: Software error when creating using borrower_number as parameter from URL

2015-05-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14122

Chris Cormack  changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable
 CC||ch...@bigballofwax.co.nz

--- Comment #10 from Chris Cormack  ---
Pushed to 3.18.x will be 3.18.7

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14127] Typo in message preference form - "mesage"

2015-05-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14127

Chris Cormack  changed:

   What|Removed |Added

 CC||ch...@bigballofwax.co.nz
 Status|Pushed to Master|Pushed to Stable

--- Comment #5 from Chris Cormack  ---
Pushed to 3.18.x will be in 3.18.7

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14033] Capitalization: confirmation message on deleting an authority type

2015-05-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14033

Chris Cormack  changed:

   What|Removed |Added

 CC||ch...@bigballofwax.co.nz
 Status|Pushed to Master|Pushed to Stable

--- Comment #10 from Chris Cormack  ---
Pushed to 3.18.x will be in 3.18.7

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11574] Clean up printing of lists in OPAC

2015-05-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11574

Chris Cormack  changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable

--- Comment #31 from Chris Cormack  ---
Pushed to 3.18.x will be in 3.18.7

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14006] about.pl checks the wrong zebra index mode

2015-05-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14006

Chris Cormack  changed:

   What|Removed |Added

 CC||ch...@bigballofwax.co.nz
 Status|Pushed to Master|Pushed to Stable

--- Comment #6 from Chris Cormack  ---
Pushed to 3.18.x will be in 3.18.7

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10388] acq edited items showing 'null's

2015-05-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10388

Chris Cormack  changed:

   What|Removed |Added

 CC||ch...@bigballofwax.co.nz
 Status|Pushed to Master|Pushed to Stable

--- Comment #8 from Chris Cormack  ---
Pushed to 3.18.x will be in 3.18.7

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6059] Problem with changing quantity on uncertain prices list

2015-05-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6059

Chris Cormack  changed:

   What|Removed |Added

 CC||ch...@bigballofwax.co.nz
 Status|Pushed to Master|Pushed to Stable

--- Comment #8 from Chris Cormack  ---
Pushed to 3.18.x will be in 3.18.7

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13984] CardnumberLength missing in sysprefs.sql

2015-05-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13984

Chris Cormack  changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable
 CC||ch...@bigballofwax.co.nz

--- Comment #7 from Chris Cormack  ---
Pushed to 3.18.x will be in 3.18.7

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13109] Serial failure for received and general viewing

2015-05-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13109

Chris Cormack  changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable

--- Comment #13 from Chris Cormack  ---
Pushed to 3.18.x will be in 3.18.7

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10752] Impossible to add 2 identical suggestions, but without any explanation

2015-05-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10752

Chris Cormack  changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable
 CC||ch...@bigballofwax.co.nz

--- Comment #20 from Chris Cormack  ---
Pushed to 3.18.x will be in 3.18.7

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13919] Renewal possible with item level hold on item

2015-05-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13919

Chris Cormack  changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable
 CC||ch...@bigballofwax.co.nz

--- Comment #21 from Chris Cormack  ---
Pushed to 3.18.x will be in 3.18.7

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9878] Flag display is inconsistent between circulation.pl and memberentry.pl

2015-05-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9878

Chris Cormack  changed:

   What|Removed |Added

 CC||ch...@bigballofwax.co.nz
 Status|Pushed to Master|Pushed to Stable

--- Comment #6 from Chris Cormack  ---
Pushed to 3.18.x will be in 3.18.7

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10423] Date not well formatted on 'print summary' from patron account

2015-05-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10423

Chris Cormack  changed:

   What|Removed |Added

 CC||ch...@bigballofwax.co.nz
 Status|Pushed to Master|Pushed to Stable

--- Comment #9 from Chris Cormack  ---
Pushed to 3.18.x will be in 3.18.7

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10971] Hide EAN search option for MARC21 when 'ordering from subscription'

2015-05-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10971

Chris Cormack  changed:

   What|Removed |Added

 CC||ch...@bigballofwax.co.nz
 Status|Pushed to Master|Pushed to Stable

--- Comment #7 from Chris Cormack  ---
Pushed to 3.18.x will be in 3.18.7

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13992] Software error in reports if field or table does not exist

2015-05-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13992

Chris Cormack  changed:

   What|Removed |Added

 CC||ch...@bigballofwax.co.nz

--- Comment #5 from Chris Cormack  ---
Doesn't apply on 3.18.x please rebase if you think it is needed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13606] Batch modification for records is limited to ~500

2015-05-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13606

Chris Cormack  changed:

   What|Removed |Added

 CC||ch...@bigballofwax.co.nz

--- Comment #45 from Chris Cormack  ---
Doesn't apply and I think is not needed on 3.18.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14076] Noisy warns in opac-authorities-home.pl

2015-05-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14076

M. Tompsett  changed:

   What|Removed |Added

 Status|In Discussion   |Needs Signoff

--- Comment #6 from M. Tompsett  ---
Test with a newer version of Perl. This was Perl 5.20.2 under Debian. CGI is a
core module.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7806] Illegal dates are used to signal non existing dates.

2015-05-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7806

--- Comment #4 from Marc Balmer  ---
Using a valid date like 1.1.1970 to denote an invalid date is so obviously a
bad idea.  I suggest to go the NULL route.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14121] Silence warnings t/db_dependent/Auth_with_cas.t

2015-05-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14121

M. Tompsett  changed:

   What|Removed |Added

 Status|In Discussion   |Needs Signoff

--- Comment #7 from M. Tompsett  ---
I attempted to test with Ubuntu 14.04 LTS which has Perl 5.18.2, and I did not
get noise either. This is clearly a newer perl (hence newer CGI) issue.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14121] Silence warnings t/db_dependent/Auth_with_cas.t

2015-05-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14121

--- Comment #6 from M. Tompsett  ---
mtompset@debian:~/kohaclone$ git reset --hard origin/master
HEAD is now at 607b224 Bug 13591: Pass OPACBaseURL to rss creation process
mtompset@debian:~/kohaclone$ prove t/db_dependent/Auth_with_cas.t
t/db_dependent/Auth_with_cas.t .. 1/4 CGI::param called in list context from
package C4::Auth_with_cas line 217, this can lead to vulnerabilities. See the
warning in "Fetching the value or values of a single named parameter" at
/usr/share/perl5/CGI.pm line 436.
CGI::param called in list context from package C4::Auth_with_cas line 217, this
can lead to vulnerabilities. See the warning in "Fetching the value or values
of a single named parameter" at /usr/share/perl5/CGI.pm line 436.
t/db_dependent/Auth_with_cas.t .. ok
All tests successful.
Files=1, Tests=4,  1 wallclock secs ( 0.02 usr  0.00 sys +  0.16 cusr  0.01
csys =  0.19 CPU)
Result: PASS
mtompset@debian:~/kohaclone$ git bz apply 14121
Bug 14121 - Silence warnings t/db_dependent/Auth_with_cas.t

38763 - Bug 14121: Silence warnings t/db_dependent/Auth_with_cas.t

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 14121: Silence warnings t/db_dependent/Auth_with_cas.t
mtompset@debian:~/kohaclone$ prove t/db_dependent/Auth_with_cas.t
t/db_dependent/Auth_with_cas.t .. ok
All tests successful.
Files=1, Tests=4,  0 wallclock secs ( 0.01 usr  0.00 sys +  0.16 cusr  0.00
csys =  0.17 CPU)
Result: PASS


mtompset@debian:~/dhmake$ cpan2deb CGI
== dh-make-perl 0.84 ==
CGI is a standard module. Will not build without --core-ok.
mtompset@debian:~/dhmake$ perl -v

This is perl 5, version 20, subversion 2 (v5.20.2) built for
x86_64-linux-gnu-thread-multi
(with 40 registered patches, see perl -V for more detail)

Copyright 1987-2015, Larry Wall

Perl may be copied only under the terms of either the Artistic License or the
GNU General Public License, which may be found in the Perl 5 source kit.

Complete documentation for Perl, including FAQ lists, should be found on
this system using "man perl" or "perldoc perl".  If you have access to the
Internet, point your browser at http://www.perl.org/, the Perl Home Page.

I'm testing Debian Jessie with perl 5.20.2
Both of you were testing Ubuntu.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14212] New: Add 'oldip' and 'newip' to different_ip message in auth.tt

2015-05-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14212

Bug ID: 14212
   Summary: Add 'oldip' and 'newip' to different_ip message in
auth.tt
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: bar...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

When IP addresses are changing frequently, users will be logged out and the
login screen will have the warning message "Error: IP address has changed.
Please log in again"

This is confusing  to users, and it is often unclear to the users that this is
a network issue, not a problem with with Koha. Furthermore, the library's IT
staff may claim that the IP addresses have not changed, which puts the user in
a very difficult position.

C4/Auth.pm defines the variables 'oldip' and 'newip' in addition to
'different_ip'.

I would suggest changing

[% IF ( different_ip ) %]
Error: IP address has changed, please
log in again 
[% END %]

to

[% IF ( different_ip ) %]
Error: IP address has changed from '[%
oldip %]' to '[% newip %]', please log in again 
[% END %]

This message gives users (and anyone supporting them) the evidence to back up
the claim that the IP address has changed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14076] Noisy warns in opac-authorities-home.pl

2015-05-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14076

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

 Status|Needs Signoff   |In Discussion

--- Comment #5 from Bernardo Gonzalez Kriegel  ---
(In reply to Bernardo Gonzalez Kriegel from comment #4)
> (In reply to M. Tompsett from comment #3)
> ...
> > Greetings, I do. I should have also mentioned. This will require Apache 2.4.
> 
> Ah! I have 2.2, will try in another machine


Tried, Server version: Apache/2.4.7 (Ubuntu)
No warns

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13948] Add ability to dump template toolkit variables to html comment

2015-05-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13948

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

  Attachment #39097|0   |1
is obsolete||

--- Comment #16 from Bernardo Gonzalez Kriegel  ---
Created attachment 39246
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39246&action=edit
[SIGNED-OFF] Bug 13948 [QA Followup] - Make dependency optional

Signed-off-by: Bernardo Gonzalez Kriegel 

http://bugs.koha-community.org/show_bug.cgi?id=13848

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13948] Add ability to dump template toolkit variables to html comment

2015-05-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13948

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

  Attachment #39205|0   |1
is obsolete||

--- Comment #17 from Bernardo Gonzalez Kriegel  ---
Created attachment 39247
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39247&action=edit
[SIGNED-OFF] Bug 13948: Prevent explosion when Template::Plugin::Stash not
installed

TEST PLAN
-
1) Install first two patches
2) do not install, or uninstall Template::Plugin::Stash
3) Upgrade to make sure system preference is added.
4) Set the system preference to turn it on for Staff and OPAC
5) Refresh staff -- kaboom
6) Load OPAC -- kaboom
7) Apply this patch
8) Reload staff and OPAC
   -- nice HTML comment about what is wrong.
9) run koha qa test tools.

Signed-off-by: Bernardo Gonzalez Kriegel 

Neat, runs well. Tested with/without sysprefs and Template::Plugin::Stash
No koha-qa errors

http://bugs.koha-community.org/show_bug.cgi?id=13848

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13948] Add ability to dump template toolkit variables to html comment

2015-05-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13948

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||bgkrie...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13948] Add ability to dump template toolkit variables to html comment

2015-05-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13948

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

  Attachment #39096|0   |1
is obsolete||

--- Comment #15 from Bernardo Gonzalez Kriegel  ---
Created attachment 39245
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39245&action=edit
[SIGNED-OFF] Bug 13948: Add ability to dump template toolkit variables to html
comment

It would be incredibly helpful if we could easily enable Koha to dump
all Template Toolkit variables to a comment for debugging purposes.

Test Plan:
1) Apply this patch
2) Run updatedatabase
3) Enable the new system preferences DumpTemplateVarsIntranet and
   DumpTemplateVarsOpac
4) Load a page in the staff intranet, view the html source
5) Note the template toolkit variables are embedded in an html comment
6) Load a page in the opac, view the html source
7) Note the template toolkit variable are embedded in an html comment

NOTE: I had to cpan2deb Template::Plugin::Stash to test.
  This is not optimal. Additionally:
  http://www.template-toolkit.org/docs/modules/Template/Plugin/index.html
  does not contain Stash. I suspect this was how it was
  introduced initially by TT.

Signed-off-by: Mark Tompsett 
Signed-off-by: Bernardo Gonzalez Kriegel 

http://bugs.koha-community.org/show_bug.cgi?id=13848

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13848] XSLT and OpacItemLocation sys pref

2015-05-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13848

--- Comment #4 from Bernardo Gonzalez Kriegel  ---
Sorry, wrong bug :(

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13848] XSLT and OpacItemLocation sys pref

2015-05-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13848

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

  Attachment #39244|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13848] XSLT and OpacItemLocation sys pref

2015-05-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13848

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

  Attachment #39243|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13848] XSLT and OpacItemLocation sys pref

2015-05-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13848

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

 CC||bgkrie...@gmail.com
  Attachment #39242|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13848] XSLT and OpacItemLocation sys pref

2015-05-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13848

--- Comment #3 from Bernardo Gonzalez Kriegel  ---
Created attachment 39244
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39244&action=edit
[SIGNED-OFF] Bug 13948: Prevent explosion when Template::Plugin::Stash not
installed

TEST PLAN
-
1) Install first two patches
2) do not install, or uninstall Template::Plugin::Stash
3) Upgrade to make sure system preference is added.
4) Set the system preference to turn it on for Staff and OPAC
5) Refresh staff -- kaboom
6) Load OPAC -- kaboom
7) Apply this patch
8) Reload staff and OPAC
   -- nice HTML comment about what is wrong.
9) run koha qa test tools.

Signed-off-by: Bernardo Gonzalez Kriegel 

Neat, runs well. Tested with/without sysprefs and Template::Plugin::Stash
No koha-qa errors

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13848] XSLT and OpacItemLocation sys pref

2015-05-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13848

--- Comment #2 from Bernardo Gonzalez Kriegel  ---
Created attachment 39243
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39243&action=edit
[SIGNED-OFF] Bug 13948 [QA Followup] - Make dependency optional

Signed-off-by: Bernardo Gonzalez Kriegel 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13848] XSLT and OpacItemLocation sys pref

2015-05-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13848

--- Comment #1 from Bernardo Gonzalez Kriegel  ---
Created attachment 39242
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39242&action=edit
[SIGNED-OFF] Bug 13948: Add ability to dump template toolkit variables to html
comment

It would be incredibly helpful if we could easily enable Koha to dump
all Template Toolkit variables to a comment for debugging purposes.

Test Plan:
1) Apply this patch
2) Run updatedatabase
3) Enable the new system preferences DumpTemplateVarsIntranet and
   DumpTemplateVarsOpac
4) Load a page in the staff intranet, view the html source
5) Note the template toolkit variables are embedded in an html comment
6) Load a page in the opac, view the html source
7) Note the template toolkit variable are embedded in an html comment

NOTE: I had to cpan2deb Template::Plugin::Stash to test.
  This is not optimal. Additionally:
  http://www.template-toolkit.org/docs/modules/Template/Plugin/index.html
  does not contain Stash. I suspect this was how it was
  introduced initially by TT.

Signed-off-by: Mark Tompsett 
Signed-off-by: Bernardo Gonzalez Kriegel 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13904] unimarc_field_4XX plugin doesn't display volume info, neither link to biblio

2015-05-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13904

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13904] unimarc_field_4XX plugin doesn't display volume info, neither link to biblio

2015-05-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13904

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

  Attachment #37212|0   |1
is obsolete||

--- Comment #2 from Bernardo Gonzalez Kriegel  ---
Created attachment 39241
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39241&action=edit
[SIGNED-OFF] Bug 13904: unimarc_field_4XX plugin doesn't display volume info,
neither link to biblio

When searching for multivolumes titles, UNIMARC 4xx field plugin displays the
title of the biblios (200$a), without giving info about volumes (200 $h $i).

The displayed title is supposed to link to a biblio record view (MARC /
normal). It doesn't work.

TO TEST:

- On a UNIMARC Koha, add a new biblio record
- Call the 4XX plugin from 461/463 field
- Search for a biblio record which contains 200$h and/or 200$i subfields.
- You get a result list, with two issues:
  1. $h & $i aren't displayed
  2. Biblio title is not a link
- Apply the patch, and repeat previous steps.

Signed-off-by: Bernardo Gonzalez Kriegel 
I can see 200$h and 200$i on search results, but not on result list from
4XX plugin, but they are copied into 46X.
The title is now a link, so I think could be my example record.
At last one of the problems is fixed :)
No koha-qa errors

Tested on UNIMARC setup, french files.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14025] Fix 865u-links in the OPAC for NORMARC

2015-05-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14025

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14025] Fix 865u-links in the OPAC for NORMARC

2015-05-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14025

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

  Attachment #38677|0   |1
is obsolete||

--- Comment #4 from Bernardo Gonzalez Kriegel  ---
Created attachment 39240
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39240&action=edit
[SIGNED-OFF] Bug 14025 - Fix 865u-links in the OPAC for NORMARC

The display of links found in 856$u for NORMARC has not been keeping up with
the one for MARC21, and several sysprefs have not been implemented. This
patch tries to fix that.

Affected sysprefs:
- OPACURLOpenInNewWindow
- URLLinkText
- OPACDisplay856uAsImage
- OPACTrackClicks

To test:
- Make sure you have a record with a URL in 856$u and marcflavor = NORMARC.
  (It does not have to be a full NORMARC setup or a NORMARC record, just make
  sure you are viewing the record through the NORMARC XSLT files.)
- View the record both in a result list and in detail view
- Check that the 4 involved sysprefs affect the display in the expected ways

Signed-off-by: Bernardo Gonzalez Kriegel 
Tested on NORMARC setup and XSLTs
Works as described, each syspref works
No koha-qa errors

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13916] NORMARC can have analytics with leader 07 = a, b or p

2015-05-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13916

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

 CC||bgkrie...@gmail.com
 Status|Needs Signoff   |In Discussion

--- Comment #3 from Bernardo Gonzalez Kriegel  ---
Same as Mirko, some 773 subfields does not save 
Only this

773 ## - Vertsdokument (R)
  7 Type hovedordningsord i delfelt $a 7
  a Hovedordningsord for posten det lenkes til, hvis dette er et personnavn,
korporasjonsnavn eller en standardtittel a
  b Utgave b
  d Sted, forlag og dato (år) for utgivelse d
  e Språkkode e
  f Landekode f
  g Relasjonsopplysninger (R) g
  h Materialbetegnelse h

NORMARC setup

Don't know...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14172] Acq: Orders without items missing from 'Spent' list

2015-05-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14172

Martin Persson  changed:

   What|Removed |Added

 CC||xarra...@gmail.com

--- Comment #5 from Martin Persson  ---
I have tried the patch, it applied cleanly to current master. I have tested the
subscription aquisition bug and can confirm both the bug and that the patch
fixes that particular issue. I have not yet tested the 'Delete Item' bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11790] C4::Charset should not depend on C4::Context

2015-05-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11790

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

  Attachment #38494|0   |1
is obsolete||

--- Comment #3 from Bernardo Gonzalez Kriegel  ---
Created attachment 39239
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39239&action=edit
[SIGNED-OFF] Bug 11790: Remove dependency C4::Context from C4::Charset

C4::Context is only used to retrieve a syspref value.
This patch moves the use of C4::Context to a require.

Test plan:
Try to reach the SetMarcUnicodeFlag subroutine (batchmod, add/update a biblio,
etc.)

Signed-off-by: Bernardo Gonzalez Kriegel 
Tested on French UNIMARC install
No errors adding/editing biblios
No koha-qa errors

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11790] C4::Charset should not depend on C4::Context

2015-05-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11790

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12054] It’s possible to make order from an inactive vendor

2015-05-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12054

--- Comment #7 from Indranil Das Gupta  ---
Created attachment 39238
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39238&action=edit
Bug 12054: Inactive vendors should be inactive

This patch make inactive vendors really inactive.
That means an inactive vendor would not be able to receive / add a
basket / add an order.

Revised test plan
=

1/ In the acquisition module create 2 vendors: 1 active and 1 inactive.
2/ On the acqui/booksellers.pl, acqui/uncertainprice.pl,
   admin/aqcontract.pl and acqui/supplier.pl (pages which include the
   acq toolbar), you should be able to, for both the 'active' as well
   as the inactive vendor :
 (a) add new basket
 (b) add order items to the basket
 (c) receive shipment and enter invoice details and files
   Remark: This is *wrong*. You should be able to do so only for active
   vendor.
3/ Apply the patch
4/ Go to the links in step #2 above and select the inactive vendor
   you should no longer be able to:
   (a) add new basket
   (b) add order items to the basket
   (c) receive shipment and enter invoice details and files
   Remark: This is the *correct* behaviour
5/ No change should be noted for vendor marked "active", and should
   be able to undertake operations 4 (a), 4 (b) and 4 (c).
   Remark: This is the *correct* behaviour.
6/ run koha qa tests tool

Signed-off-by: Indranil Das Gupta (L2C2 Technologies) 

Remarks: Testing result match expected test plan output. The QA tests
 pass with "OK" for the commit.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12054] It’s possible to make order from an inactive vendor

2015-05-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12054

Indranil Das Gupta  changed:

   What|Removed |Added

  Attachment #39237|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12054] It’s possible to make order from an inactive vendor

2015-05-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12054

Indranil Das Gupta  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12054] It’s possible to make order from an inactive vendor

2015-05-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12054

--- Comment #6 from Indranil Das Gupta  ---
Created attachment 39237
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39237&action=edit
Bug 12054: Inactive vendors should be inactive

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12054] It’s possible to make order from an inactive vendor

2015-05-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12054

Indranil Das Gupta  changed:

   What|Removed |Added

  Attachment #39236|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12054] It’s possible to make order from an inactive vendor

2015-05-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12054

Indranil Das Gupta  changed:

   What|Removed |Added

  Attachment #38594|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12054] It’s possible to make order from an inactive vendor

2015-05-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12054

--- Comment #5 from Indranil Das Gupta  ---
Created attachment 39236
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39236&action=edit
Signed off patch for bug 12054

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12054] It’s possible to make order from an inactive vendor

2015-05-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12054

--- Comment #4 from Indranil Das Gupta  ---
(In reply to Indranil Das Gupta from comment #3)
> I have problems applying this patch with git bz

CORRECTION: s/applying/attaching

Patch applies and works correctly as per test plan

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14121] Silence warnings t/db_dependent/Auth_with_cas.t

2015-05-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14121

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

 Status|Needs Signoff   |In Discussion

--- Comment #5 from Bernardo Gonzalez Kriegel  ---
(In reply to M. Tompsett from comment #3)
> (In reply to Bernardo Gonzalez Kriegel from comment #2)
> > No warns on current master...
> 
> Apache 2.4 issue.

Server version: Apache/2.4.7 (Ubuntu)

HEAD: 607b224 Bug 13591: Pass OPACBaseURL to rss creation process

prove t/db_dependent/Auth_with_cas.t
t/db_dependent/Auth_with_cas.t .. ok   
All tests successful.
Files=1, Tests=4,  1 wallclock secs ( 0.04 usr  0.00 sys +  0.29 cusr  0.01
csys =  0.34 CPU)
Result: PASS

No noise for me!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12054] It’s possible to make order from an inactive vendor

2015-05-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12054

Indranil Das Gupta  changed:

   What|Removed |Added

 CC||indr...@gmail.com

--- Comment #3 from Indranil Das Gupta  ---
I have problems applying this patch with git bz

Traceback (most recent call last):
  File "/usr/local/bin/git-bz", line 2633, in 
do_attach(*args)
  File "/usr/local/bin/git-bz", line 1999, in do_attach
attach_commits(bug, commits, edit_comments=global_options.edit)
  File "/usr/local/bin/git-bz", line 1914, in attach_commits
description, body, obsoletes, statuses, patch_complexities, depends =
edit_attachment_comment(bug, commit.subject, body)
  File "/usr/local/bin/git-bz", line 1867, in edit_attachment_comment
lines = edit_template(template.getvalue())
  File "/usr/local/bin/git-bz", line 811, in edit_template
f.write(template)
UnicodeEncodeError: 'ascii' codec can't encode character u'\u2019' in position
30: ordinal not in range(128)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14121] Silence warnings t/db_dependent/Auth_with_cas.t

2015-05-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14121

Indranil Das Gupta  changed:

   What|Removed |Added

 CC||indr...@gmail.com

--- Comment #4 from Indranil Das Gupta  ---
(In reply to Bernardo Gonzalez Kriegel from comment #2)
> No warns on current master...

this is what I have (gitified install):

l2c2technologies@gadfly:~/koha$ apache2 -v
Server version: Apache/2.4.7 (Ubuntu)
Server built:   Mar 10 2015 13:05:59

test result

l2c2technologies@gadfly:~/koha$ prove t/db_dependent/Auth_with_cas.t
t/db_dependent/Auth_with_cas.t .. ok   
All tests successful.
Files=1, Tests=4,  1 wallclock secs ( 0.01 usr  0.01 sys +  0.18 cusr  0.00
csys =  0.20 CPU)
Result: PASS

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14111] Silence warnings t/Auth_with_shibboleth.t

2015-05-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14111

Indranil Das Gupta  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14111] Silence warnings t/Auth_with_shibboleth.t

2015-05-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14111

Indranil Das Gupta  changed:

   What|Removed |Added

  Attachment #38832|0   |1
is obsolete||

--- Comment #11 from Indranil Das Gupta  ---
Created attachment 39235
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39235&action=edit
Bug 14111 - More t/Auth_with_shibboleth.t silencing

TEST PLAN
-
1) Apply first patch
2) prove t/Auth_with_shibboleth.t
   -- failed?!
3) apply this patch
4) prove t/Auth_with_shibboleth.t
   -- success. *whew*
5) koha-qa test tools.

Signed-off-by: Indranil Das Gupta (L2C2 Technologies) 

Test remarks: Expected outcome as per test plan. No anomaly noted.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14111] Silence warnings t/Auth_with_shibboleth.t

2015-05-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14111

Indranil Das Gupta  changed:

   What|Removed |Added

  Attachment #38752|0   |1
is obsolete||

--- Comment #10 from Indranil Das Gupta  ---
Created attachment 39234
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39234&action=edit
Bug 14111: Silence warnings in t/Auth_with_shibboleth.t

Poorly capturing warnings_exist test cases generated noise.
This patch fixes that.

TEST PLAN
-
1) $ prove t/Auth_with_shibboleth.t
   -- There are messages about lines 132 and 133. Noise.
2) Apply patch
3) $ prove t/Auth_with_shibboleth.t
   -- No messages. YAY!
4) koha qa test tools

Signed-off-by: Indranil Das Gupta (L2C2 Technologies) 

Test remarks: Expected outcome as per test plan. No anomaly noted.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/