[Koha-bugs] [Bug 14198] RDA: Indexing 264 field (Zebra)

2015-05-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14198

Josef Moravec  changed:

   What|Removed |Added

 CC||josef.mora...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14231] Package updates for 3.20 release

2015-05-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14231

Robin Sheat  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14231] Package updates for 3.20 release

2015-05-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14231

Robin Sheat  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14231] Package updates for 3.20 release

2015-05-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14231

Robin Sheat  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14231] Package updates for 3.20 release

2015-05-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14231

--- Comment #1 from Robin Sheat  ---
Created attachment 39319
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39319&action=edit
Bug 14231: changes required for 3.20 release

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14232] New: Biblio records are not showing after zebra indexing from cronjob

2015-05-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14232

Bug ID: 14232
   Summary: Biblio records are not showing after zebra indexing
from cronjob
 Change sponsored?: ---
   Product: Koha
   Version: 3.18
  Hardware: All
OS: Linux
Status: NEW
  Severity: critical
  Priority: P5 - low
 Component: Z39.50 / SRU / OpenSearch Servers
  Assignee: gmcha...@gmail.com
  Reporter: nishantsin...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

Hi,

I have upgrade koha3.6 to Koha3.18 from Tarball. Everything is working fine but
while rebuild_zebra.pl is executing via cronjob, records is not showing. When
we run manual this script, we are getting the records. We checked the cronjob
logs also, but it shows 
Record exported(No. of Records)
=
Reindexing Zebra. 

Cleaning. 
===

Zebra Version 2.60 is running.

Please give some steps to resolve this issue.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14231] New: Package updates for 3.20 release

2015-05-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14231

Bug ID: 14231
   Summary: Package updates for 3.20 release
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Packaging
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: ro...@catalyst.net.nz
QA Contact: testo...@bugs.koha-community.org
CC: ro...@catalyst.net.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8007] Discharge management

2015-05-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007

--- Comment #121 from Robin Sheat  ---
(In reply to Robin Sheat from comment #120)
> libpdf-writer-perl is currently in the Debian NEW queue, and in the Koha
> repository. libpdf-fromhtml-perl is being a more recalcitrant. I'm hoping
> that by spending some time on it today, I'll succeed it making it build
> correctly, and if I'm really lucky it'll work in wheezy too.

...and after days of wailing and gnashing of teeth, both modules are in a
releasable state.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14230] New: fund list show percentage

2015-05-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14230

Bug ID: 14230
   Summary: fund list show percentage
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Acquisitions
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: neng...@gmail.com
QA Contact: testo...@bugs.koha-community.org

It would be nice (since you can set warnings at percentages) to add a column to
the fund list on the acq homepage that shows the percentage spent.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14229] New: fines clickable on patron results to pay

2015-05-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14229

Bug ID: 14229
   Summary: fines clickable on patron results to pay
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Patrons
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: neng...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

Would be nice if on the patron search results the fine amount was clickable so
you could jump to the patron's pay screen.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14227] New: rda toolkit integration

2015-05-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14227

Bug ID: 14227
   Summary: rda toolkit integration
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: new feature
  Priority: P5 - low
 Component: Cataloging
  Assignee: gmcha...@gmail.com
  Reporter: neng...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

Would be nice if there was RDA toolkit integration in Koha and/or a way to
convert records to RDA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14228] New: fill in patron info by scanning an ID

2015-05-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14228

Bug ID: 14228
   Summary: fill in patron info by scanning an ID
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: new feature
  Priority: P5 - low
 Component: Patrons
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: neng...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

It would be nice if you could scan a barcode on a drivers license and get the
name, address, birthday info

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11559] Professional cataloger's interface

2015-05-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559

Nicole C. Engard  changed:

   What|Removed |Added

 Blocks||14226

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14226] New: LC help in professional cataloging interface

2015-05-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14226

Bug ID: 14226
   Summary: LC help in professional cataloging interface
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Cataloging
  Assignee: gmcha...@gmail.com
  Reporter: neng...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl
Depends on: 11559

It would be nice if the professional cataloging interface had built in LC help
links - like with the basic editor

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13970] Remove related code to category_type

2015-05-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13970

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

 CC||bgkrie...@gmail.com,
   ||mag...@libriotech.no

--- Comment #3 from Bernardo Gonzalez Kriegel  ---
Adding magnus in cc

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13970] Remove related code to category_type

2015-05-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13970

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

  Attachment #37578|0   |1
is obsolete||

--- Comment #2 from Bernardo Gonzalez Kriegel  ---
Created attachment 39318
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39318&action=edit
[SIGNED-OFF] Bug 13970: Remove category_type related code

Working on bug 13497 and bug 9314, I run into some Koha vestiges.
The category_type parameter should not be passed to memberentry.
On creating a new patron, the categorycode should be passed, and on
editing, it's useless. We can work with the borrowernumber and retrieve
these values.

Details of the changes:
- members-toolbar.inc: Remove the category_type parameter passed to
memberentry.pl
- memberentrygen.tt: Just remove the useless category_type parameter on
  editing a patron. Also remove the unused one passed to
  guarantor_search.pl.
- tables/members_results.tt: the borrowernumber is enough to edit a
  patron.
- memberentry.pl: check_categorytype is never used in the template, all
  the process to calculate/retrieve it is unnecessary.
- members/nl-search.tt: The borrowernumber is enough to edit a patron.

Test plan:
Try to create and edit patrons and verify that
- the guarantor search still work
- the form (memberentry) behave as before

Edit a patron from the nl-search.pl script (Magnus?)

Signed-off-by: Bernardo Gonzalez Kriegel 

On top of 9314 (13497 already pushed)

No evident regressions found, add/edit patron works,
search/set guarantor works.

Cant test nl-patron.pl save for exec it.
prove -v t/NorwegianPatronDB.t runs

No koha-qa errors

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13970] Remove related code to category_type

2015-05-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13970

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12191] Items with not for loan status shouldn't trigger a transfer

2015-05-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12191

Heather Braum  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEW |RESOLVED

--- Comment #2 from Heather Braum  ---
With the new UpdateNotForLoanStatusOnCheckin sys pref in 3.18, this is no
longer an issue. I hope it's okay, I'm marking this resolved.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14198] RDA: Indexing 264 field (Zebra)

2015-05-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14198

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

  Attachment #39301|0   |1
is obsolete||

--- Comment #3 from Bernardo Gonzalez Kriegel  ---
Created attachment 39317
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39317&action=edit
[SIGNED-OFF] Bug 14198: RDA: Indexing 264 field (Zebra)

This patch add zebra indexes to RDA 264 field.
The new Provider index is added too.
The XSLT for staff and OPAC has been updated to reflect the index.

To test:
1) Download RDA records with 264 fields from this attachment
. Import the
file and re-index/rebuild zebra. These records contain 260 and 264 fields per
record.
2) Do a search with pb:Bethany two records will appear with title The guardian.
Search with pl:Minneapolis too, the two records will appear. Notice that 264
not show the link for Publisher in the record detail page.
3) Select one record of both records and delete the 260 field keeping the 264
field and save, rebuild your zebra.
4) Search again with pb:Bethany and just one record will appear. Thats mean 264
is not indexed.
5) Apply patch.
6) Rebuild your zebra but this time all biblio records.
7) Search again with pb:Bethany, this time will appear the two records, 264 is
indexed.
8) This patch add three new indexes Provider, Provider-date and Provider-place
for 260 and 264 fields.
9) Do a search with the three new indexes for Bethany publisher.
10) Search with copydate:2013 and Provider-date:2013 both searches will give
the same result.
11) Get access to record detail page of one record and notice that the link for
Publisher in 264 field appear.

Sponsored-by: Universidad de El Salvador

Signed-off-by: Bernardo Gonzalez Kriegel 
Work as described following test plan.

Only comment is that if 260 and 264 are present, link only shows
for 260 value.

No koha-qa errors.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14198] RDA: Indexing 264 field (Zebra)

2015-05-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14198

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8007] Discharge management

2015-05-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8007

--- Comment #120 from Robin Sheat  ---
libpdf-writer-perl is currently in the Debian NEW queue, and in the Koha
repository. libpdf-fromhtml-perl is being a more recalcitrant. I'm hoping that
by spending some time on it today, I'll succeed it making it build correctly,
and if I'm really lucky it'll work in wheezy too.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14206] notices using non email templates can't be deleted from the staff client

2015-05-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14206

Indranil Das Gupta  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |indr...@gmail.com
   |ity.org |
Summary|notice using only the   |notices using non email
   |'print' template can't be   |templates can't be deleted
   |deleted |from the staff client
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14151] SIP2 Checkouts fail in Koha 3.18

2015-05-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14151

Katrin Fischer  changed:

   What|Removed |Added

Summary|SIP2 Checkouts file in Koha |SIP2 Checkouts fail in Koha
   |3.18|3.18

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11858] RFID for circulation

2015-05-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11858

--- Comment #3 from Viktor Sarge  ---
Nicole - I very much suspect that the relevant projekt is over at
https://github.com/digibib/koha-rfidhub. But I'm not shure whether it's near
getting the full workflow with the necessary parts in Koha done even if the
RFIDhub seems done. 

The way Hylte does RFID now is that the vendor created a workflow with the
RFID-reader posting codes at a certain pace and relying on focus being set to
the barcode box. That's not very pretty even if it works and for the staff side
I'm looking forward to batch checkout since that lets them checkout the whole
bunch at the same time which works perfectly with how the reader wants to work.
I guess running the RFIDhub would be even better :) But at least it works for
now (and I guess some RFID-vendors might use SIP2 instead(?)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14221] Error: Not for Loan doesn't save.

2015-05-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14221

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #1 from Katrin Fischer  ---
Hi Isabela, did you change the authorised value for authorized value? Please
check that the codes are numeric - otherwise it won't save.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14206] notice using only the 'print' template can't be deleted

2015-05-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14206

Indranil Das Gupta  changed:

   What|Removed |Added

 Status|In Discussion   |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14206] notice using only the 'print' template can't be deleted

2015-05-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14206

--- Comment #8 from Indranil Das Gupta  ---
Created attachment 39316
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39316&action=edit
Bug 14206 Adds delete function for non email templates

This patch adds deletion capability for notices that do not use email
template, but uses any/all of the other templates i.e. sms, print or
phone.

Test plan (Continued)
=

3/ Go to Tools -> Notices & Slips. Add a new notice only for print,
   leave 'Library' and 'Koha module' options as default selections.
   Enter 'KOHA_14206' and 'Koha Test 14206' against Code and Name
   respectively, and 'Test' and 'Test Message' for subject and body.
   Leave the Email, Phone and SMS tabs blank. Save the notice.
4/ On the notices listing page the new notice will be listed. Try to
   delete it. It will load the 'Delete notice' dialog form, but the
   table will not show any data under s - 'Library', 'Module',
   'Code' or 'Name'.
5/ Click the "Yes, delete" button. The page will be submitted and the
   Notices listing reloaded. The print-only KOHA_14206 notice should
   continue to exist. This is *wrong*.
6/ Apply this patch
7/ Reload the listings page and click on the 'Delete' link for Notice
   KOHA_14206. This time, it should show the data under 'Module',
   'Code' or 'Name' at least.
8/ Click on 'Yes, delete'. The page should submit and the listing page
   reload. This time KOHA_14206 will be gone.
9/ Re-run prove -v t/db_dependent/Letters.t
   This time all tests should PASS without any error.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14206] notice using only the 'print' template can't be deleted

2015-05-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14206

Indranil Das Gupta  changed:

   What|Removed |Added

  Attachment #39283|0   |1
is obsolete||

--- Comment #7 from Indranil Das Gupta  ---
Created attachment 39315
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39315&action=edit
Bug 14206 Adds two tests to t/db_dependent/Letters.t

C4::Letters::getletter is called in tools/letter.pl by the function
delete_confirm() to display the selected notice for deletion. Due to
current implementation of getletter(), a notice that does not use
the 'email' template (but uses any/all of the other templates - sms,
print or phone) can't be deleted from the staff client.

This patch adds 2 tests to t/db_dependent/Letters.t to test the bug.

Test plan
=

1/ Apply the patch and run prove -v t/db_dependent/Letters.t
2/ Test 38 should pass demonstrating unpatched getletter() behaviour
   Test 39 should FAIL, highlighting the problem

 #   Failed test 'Bug 14206 - returns actual message_transport_type'
 #   at t/db_dependent/Letters.t line 181.
 #  got: undef
 # expected: 'print'

(Test plan continues in the second commit)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14206] notice using only the 'print' template can't be deleted

2015-05-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14206

Indranil Das Gupta  changed:

   What|Removed |Added

 Status|Needs Signoff   |In Discussion

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9314] Messaging preferences not updated to category defaults on patron edit

2015-05-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9314

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||bgkrie...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9314] Messaging preferences not updated to category defaults on patron edit

2015-05-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9314

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

  Attachment #37577|0   |1
is obsolete||

--- Comment #6 from Bernardo Gonzalez Kriegel  ---
Created attachment 39314
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39314&action=edit
[SIGNED-OFF] Bug 9314: Remove useless code related to the type_only parameter

Since the pref AddPatronLists has been removed in bug 13497, the code
related to type_only and category_type in memberentry.pl is useless.

Test plan:
Confirm you don't the information message.
You can also confirm that the message was wrong and nothing was saved.

Signed-off-by: Bernardo Gonzalez Kriegel 
Dead code removed, no errors

Think that bug description can be updated to commit message

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11057] Bootstrap theme: Don't hide language chooser below the fold

2015-05-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11057

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

 Status|Needs Signoff   |In Discussion

--- Comment #13 from Bernardo Gonzalez Kriegel  ---
(In reply to Indranil Das Gupta from comment #9)
> Created attachment 39289 [details]
> "Powered by Koha" getting cut into
> 
> Hi Bernardo,
> 
> Ran the tests (both pre and post patching). The switcher panel *does* stay
> visible in place after patch. But I'm having the "Powered by Koha" cut away.
> 'opaccredits' is not impacted,
> 
> -idg

I can reproduce, so it's not ready and needs more work.
Thanks for testing :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11057] Bootstrap theme: Don't hide language chooser below the fold

2015-05-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11057

--- Comment #12 from Bernardo Gonzalez Kriegel  ---
(In reply to Katrin Fischer from comment #10)
> Hm, I only see a difference with and without the patch with a recompiled css
> file - attaching as a follow-up.

Yeah, that's point 6) in test plan :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12017] Move language description out of database

2015-05-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

--- Comment #66 from Bernardo Gonzalez Kriegel  ---
Rebased and updated

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12017] Move language description out of database

2015-05-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

  Attachment #33345|0   |1
is obsolete||

--- Comment #64 from Bernardo Gonzalez Kriegel  ---
Created attachment 39312
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39312&action=edit
Bug 12017 - 9 - Remove use of language_get_description function

This patch removes every use of language_get_description
function. This function retrieves lang names from database

To test:
1. Functionality removed by this patch do not
affect anything, because previous patches are
only using rfc4646_subtag value, not values stored
in database.
2. Removed import from Templates.pm, not used there

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12017] Move language description out of database

2015-05-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

  Attachment #33346|0   |1
is obsolete||

--- Comment #65 from Bernardo Gonzalez Kriegel  ---
Created attachment 39313
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39313&action=edit
Bug 12017 - 10 - Remove description from getLanguage

This patch rewrites getLanguage function.
This function is of not much use, but is
rewrited to takes its data from language_rfc4646_to_iso639
table.

To test:
1. Apply the patch
2. Only place that use this function is t/db_dependent/Languages.t
so run the test and check that it pass
3. To compare the output pre and post patch you can run
perl -e 'use C4::Languages; use Data::Dumper; $a = getLanguages(); print Dumper
$a;'

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12017] Move language description out of database

2015-05-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

  Attachment #9|0   |1
is obsolete||

--- Comment #58 from Bernardo Gonzalez Kriegel  ---
Created attachment 39306
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39306&action=edit
Bug 12017 - 3 - Change lang display on sysprefs I18N

This patch change the display of languages on sysprefs
to set translated languages on I18N

Only parameter used is rfc4646 subtag

To test:
1. Apply the patch
2. Go to I18N syspref, look language descriptions

Following steps are for next patch

3. Set a bunch of languages for staff/opac, save, reload
Inlude vi-VN for which there is no current description
in databasse
4. Set opaclanguagesdisplay to Allow

Current display is preserved, native description for
languages outside group, and script/region for language
groups

Only change is languages ordered by rfc4646 subtag

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12017] Move language description out of database

2015-05-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

  Attachment #33343|0   |1
is obsolete||

--- Comment #62 from Bernardo Gonzalez Kriegel  ---
Created attachment 39310
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39310&action=edit
Bug 12017 - 7 - Remove function getFrameworkLanguages

[ Note: From now on dependence on language descriptions
in database is about to be removed, also some code
cleaning.]

This must be an old relic, not used anymore.

To test:
1. Check use of getFrameworkLanguages
egrep -Rl getFrameworkLanguages *

No result save for definition file
2. Apply the patch
3. check again, no results

Reason for removing this function is that it's not
used and tries to send languages descriptions from database

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12017] Move language description out of database

2015-05-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

  Attachment #33340|0   |1
is obsolete||

--- Comment #59 from Bernardo Gonzalez Kriegel  ---
Created attachment 39307
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39307&action=edit
Bug 12017 - 4 - Change language changers

This patch modifies language changers on staff/opac
Only parameter used is rfc4646

To test:
1. Apply the patch
2. Reload staff and opac (prog/ccsr/bootstrap)
3. Check display of language changers
4. Do a real translation and check language change works

Do not change language unless you did a real translation

Only change in display is showing only regions for sublanguages.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12017] Move language description out of database

2015-05-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

  Attachment #33342|0   |1
is obsolete||

--- Comment #61 from Bernardo Gonzalez Kriegel  ---
Created attachment 39309
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39309&action=edit
Bug 12017 - 6 - Change syspref AdvancedSearchLanguages

Bug 10986 introduces a way of limiting advanced search
languages list. It's a good feature, but to fill the
preference you need to list iso639_2 codes. And there
is no way to get the list of all codes again as
before, and language descriptions are taken from database.

This patch changes that preference so it's now
a Local syspref, to present an interface to set
it's value. Also adds another syspref to control
if language chooser is limited at all, recovering
previous behavior.

As per comments on Bug 10986 language list shows
translated and native names and is ordered by
iso639_2 code

To test:
1. Apply the patch
2. Run updatedatabase.pl
3. Go to system preferences, Searching, new syspref
LimitAdvancedSearchLanguages, on by default
4. Go to Local use sysprefs, AdvancedSearchLanguages
is now here with interface to set it's values
5. Check language limit on advanced search on
staff and opac (any theme)
6. Disable limit and chech language list
7. Enable limit and set different languages
on syspref, check language list

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12017] Move language description out of database

2015-05-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

  Attachment #8|0   |1
is obsolete||

--- Comment #57 from Bernardo Gonzalez Kriegel  ---
Created attachment 39305
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39305&action=edit
Bug 12017 - 2 - Enable languages on web installer

This patch modifies installer/step1.tt to use new
language descriptions.
Only parameter used is rfc4646 code.

To test:
1. Do some fake translations, for example all langs
for l in $(cd misc/translator/po; ls *-pref.po | sed 's/-pref.po//'); do
mkdir koha-tmpl/intranet-tmpl/prog/$l;
mkdir koha-tmpl/opac-tmpl/bootstrap/$l;
mkdir koha-tmpl/opac-tmpl/prog/$l;
mkdir koha-tmpl/opac-tmpl/ccsr/$l;
done

or make some lang dirs on intranet-tmpl/prog

2. Apply the patch

3. Edit your koha-conf.xml, change database name to a
new name, create that database and grant access, reload
staff page, log in with database user, you will be
redirected to step1 of web installer.

4. Check names and codes for installed languages.

Revert to your old database before proceed,
but left dirs.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12017] Move language description out of database

2015-05-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

  Attachment #33344|0   |1
is obsolete||

--- Comment #63 from Bernardo Gonzalez Kriegel  ---
Created attachment 39311
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39311&action=edit
Bug 12017 - 8 - Remove use of getAllLanguages from installer

getAllLanguages is only used on installer/install.pl,
and some tests.

Result parameters are passed to C4/Install.pm, but
its use is futile, language check on Installer.pm uses
parameters that are not present on return value of
getAllLanguages, and returned value fwk_code is
undefined

To test:
1. Apply the patch
2. Do translated install (eg using de-DE or es-ES)
a. translate first,
b. then create a new database,
c. grant permissions,
d. change koha-conf to use new db,
e. reload staff,
f. proceed to web install,
g. select translated language,
h. use marc21,
i. finish,
3. Login and check that marc frameworks are translated

The translated install must proceed without problems.

Removed only the very first occurence of template parameter
fwk_language because of it's null value.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12017] Move language description out of database

2015-05-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

  Attachment #33341|0   |1
is obsolete||

--- Comment #60 from Bernardo Gonzalez Kriegel  ---
Created attachment 39308
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39308&action=edit
Bug 12017 - 5 - Change local use syspref type Language

This patch changes local use syspref of type Language
Currently this type of syspref is not used, and shows
currently translated staff languages. It's values
can't be changed.

To make something useful, this kind of syspref is
changed to show all langs and save iso639_2 codes.
And they not use descriptions on database, only
rfc4646 codes from templates.

It's easy to add new kinds that save rfc4646 codes,
or only show translated languages.

To test:
1. Apply the patch
2. Go to system preferences, local use
3. Define a new syspref, any name/description, type
'Language', Save

4. New syspref is showed as a multiple selection of
iso639_2 codes with current lang and native names.
Check that

5. Select some values, save, check they are saved
and restored

6. Edit, similar view, change values, save, check

7. Delete test syspref

Values are stored as ',' separated values
Verify in database

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12017] Move language description out of database

2015-05-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12017

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

  Attachment #7|0   |1
is obsolete||

--- Comment #56 from Bernardo Gonzalez Kriegel  ---
Created attachment 39304
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39304&action=edit
Bug 12017 - 1 - Move language description out of database

This patch adds identical copies of languages.inc
file on include dirs, and modifies include files
to process it.

To test:
1. No change on current behavior must be observer,
any page staff/opac

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14036] "Date::Calc::Add_Delta_YM(): not a valid date" error when accessing subscription detail

2015-05-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14036

--- Comment #27 from M. Tompsett  ---
(In reply to Katrin Fischer from comment #25)
> If you or Rolando can tell me how to alter the data in order to make the
> problem appear that would work for me for now.

I have looked further, and believe the only way to trigger this problem is bad
data.

However, as I just posted, there are validation failures at the template level
which end up calling these functions in exploding ways.

GetNextSeq and GetNextDate in C4::Serials both call GetFictiveIssueNumber, and
it is the second parameter as -00-00 which causes the explosion.

This is easy to trigger as tests apart from the interface.

However, some validation on the template pages actually prevents such
explosions. Though, as demonstrated in comment #26, there needs to be an
improvement in validations done.

Would adding those validations to solve comment #26 be sufficient to pass all
of this?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12176] Remove HTML from additem.pl

2015-05-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12176

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12176] Remove HTML from additem.pl

2015-05-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12176

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

  Attachment #31138|0   |1
is obsolete||

--- Comment #15 from Bernardo Gonzalez Kriegel  ---
Created attachment 39303
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39303&action=edit
Bug 12176: Remove HTML from additem.pl

This patch removes HTML code from additem.pl

To test:
1. Chech no regressions on Add/Edit/Save items
2. Update translation files for a language,
check new strings "Tag editor" & "No popup" on staff PO file
3. Check it pass xt/tt_valid.t

Patch partially rebased, part rewrite

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5338] Serials in guided reports

2015-05-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5338

--- Comment #37 from Tomás Cohen Arazi  ---
Created attachment 39302
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39302&action=edit
Bug 5338: (QA followup) update the tests for the new reports

This patch fixes the unit tests related to guided reports.
It is needed now that there are more options available.

It also fixes a wrong 'savedsql' key (should be 'sql') that
caused the tests to print warnings.

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14198] RDA: Indexing 264 field (Zebra)

2015-05-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14198

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

 CC||bgkrie...@gmail.com,
   ||j...@bywatersolutions.com,
   ||m.de.r...@rijksmuseum.nl,
   ||neng...@gmail.com,
   ||tomasco...@gmail.com,
   ||wsale...@gmail.com

--- Comment #2 from Héctor Eduardo Castro Avalos  ---
I add here maybe some interested in RDA development for Koha

Regards

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14198] RDA: Indexing 264 field (Zebra)

2015-05-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14198

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |hector.hecax...@gmail.com
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14198] RDA: Indexing 264 field (Zebra)

2015-05-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14198

--- Comment #1 from Héctor Eduardo Castro Avalos  ---
Created attachment 39301
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39301&action=edit
Bug 14198: RDA: Indexing 264 field (Zebra) This patch add zebra indexes to RDA
264 field. The new Provider index is added too. The XSLT for staff and OPAC has
been updated to reflect the index.

To test:
1) Download RDA records with 264 fields from this attachment
. Import the
file and re-index/rebuild zebra. These records contain 260 and 264 fields per
record.
2) Do a search with pb:Bethany two records will appear with title The guardian.
Search with pl:Minneapolis too, the two records will appear. Notice that 264
not show the link for Publisher in the record detail page.
3) Select one record of both records and delete the 260 field keeping the 264
field and save, rebuild your zebra.
4) Search again with pb:Bethany and just one record will appear. Thats mean 264
is not indexed.
5) Apply patch.
6) Rebuild your zebra but this time all biblio records.
7) Search again with pb:Bethany, this time will appear the two records, 264 is
indexed.
8) This patch add three new indexes Provider, Provider-date and Provider-place
for 260 and 264 fields.
9) Do a search with the three new indexes for Bethany publisher.
10) Search with copydate:2013 and Provider-date:2013 both searches will give
the same result.
11) Get access to record detail page of one record and notice that the link for
Publisher in 264 field appear.

Sponsored-by: Universidad de El Salvador

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11858] RFID for circulation

2015-05-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11858

Nicole C. Engard  changed:

   What|Removed |Added

 CC||neng...@gmail.com

--- Comment #2 from Nicole C. Engard  ---
I have a library that likes this idea a lot - what's the status of this? Is it
sponsored or looking for sponsors?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14225] New: calendar results in Koha

2015-05-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14225

Bug ID: 14225
   Summary: calendar results in Koha
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: new feature
  Priority: P5 - low
 Component: Searching
  Assignee: gmcha...@gmail.com
  Reporter: neng...@gmail.com
QA Contact: testo...@bugs.koha-community.org

If the library has a calendar (in this example a wordpress events plugin) it
would be awesome to be able to search it from the catalog.  So if you search
for Knitting you get at the top of the results the knitting event that is
happening at the library before the bib record results.

This is a suggestion from a patron I met today.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14224] New: patron notes about item shown at check in

2015-05-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224

Bug ID: 14224
   Summary: patron notes about item shown at check in
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: new feature
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: neng...@gmail.com
QA Contact: testo...@bugs.koha-community.org

It would be nice (per a patron) if there was a way for patrons to enter a note
about the item they have checked out - this DVD is scratched - the binding was
torn - etc. Then this note emails to the library and shows up at check in so
the librarian knows that the item is damages or has an issue.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14223] New: show comments on reading history

2015-05-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14223

Bug ID: 14223
   Summary: show comments on reading history
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: neng...@gmail.com
QA Contact: testo...@bugs.koha-community.org

I got this feedback from a patron today: Allow commenting from reading history
- and see my comments and star rating on the reading history

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11944] Cleanup Koha UTF-8

2015-05-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944

--- Comment #294 from Tomás Cohen Arazi  ---
*** Bug 10075 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10075] Extend CGI to provide a param_utf8_decode method

2015-05-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10075

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|In Discussion   |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #5 from Tomás Cohen Arazi  ---
This is not needed, as we patched all cgi files to have 'use CGI qw (-utf8)'
instead.

*** This bug has been marked as a duplicate of bug 11944 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14222] New: sort holds in OPAC by priority

2015-05-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14222

Bug ID: 14222
   Summary: sort holds in OPAC by priority
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: neng...@gmail.com
QA Contact: testo...@bugs.koha-community.org

I got this feedback from a patron today: It would be nice if the patron's holds
list in the OPAC was sorted by priority by default so that the waiting items
show at the top.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14221] New: Error: Not for Loan doesn't save.

2015-05-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14221

Bug ID: 14221
   Summary: Error: Not for Loan doesn't save.
 Change sponsored?: ---
   Product: Koha
   Version: 3.18
  Hardware: All
OS: Linux
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Cataloging
  Assignee: gmcha...@gmail.com
  Reporter: isabelate...@cp2.g12.br
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

Hi guys.

I created a server with 3:18 Koha installed.
After creating the records, I saw that when creating copies it does not save
the field "Not for loan", getting empty.
Someone went through it?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13687] ILS-DI services HoldItem and HoldTitle don't consider hold policy by item type

2015-05-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13687

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #6 from Tomás Cohen Arazi  ---
Patch pushed to master.

Thanks Julian!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14036] "Date::Calc::Add_Delta_YM(): not a valid date" error when accessing subscription detail

2015-05-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14036

--- Comment #26 from M. Tompsett  ---
(In reply to Katrin Fischer from comment #25)
> If you or Rolando can tell me how to alter the data in order to make the
> problem appear that would work for me for now.

Haven't triggered the exact problem, but a similar one:
1) Set up stuff.
a) Home -> Acquisitions
b) Add Vendor
c) Add Budget
d) Add Fund for that Budget
   -- not all these steps may be necessary, but they are a good idea.
2) Home -> Serials
3) New Subscription
4) Fill in first page nicely, click Next
5) Fill in second page nicely, click 'Test prediction pattern'
6) EVIL STEP: Change the publication date to 00/00/
7) Click 'Save'
   -- KABOOM!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5338] Serials in guided reports

2015-05-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5338

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com
 Status|Passed QA   |Pushed to Master

--- Comment #36 from Tomás Cohen Arazi  ---
Patches pushed to master.

Thanks Jonathan!

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10299] authorities plugin putting values in reverse order

2015-05-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10299

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com
 Status|Passed QA   |Pushed to Master

--- Comment #6 from Tomás Cohen Arazi  ---
Patch pushed to master.

Thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14101] auto renewal is tied to 'no renewal before'

2015-05-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14101

--- Comment #6 from Holger Meißner  ---
(In reply to Kyle M Hall from comment #3)
> This seems to happen even if I set a no renewal before value.

Hi Kyle, which values did you test? It should work with values equal to or
greater than 1. Maybe the feature broke. I am going to re-test, but this is how
it used to work. The cronjob calls CanBookBeRenewed. There "no renewal before"
is calculated like this:

if ( $issuingrule->{norenewalbefore} ) {

# Get current time and add norenewalbefore.
# If this is smaller than date_due, it's too soon for renewal.
if (
DateTime->now( time_zone => C4::Context->tz() )->add(
$issuingrule->{lengthunit} => $issuingrule->{norenewalbefore}
) < $itemissue->{date_due}
  )
{
return ( 0, "auto_too_soon" ) if $itemissue->{auto_renew};
return ( 0, "too_soon" );
}
}

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11361] Add a Z39.50 search page in the OPAC to let members search for records on remote Koha instances.

2015-05-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11361

--- Comment #3 from vinod  ---
This feature may be provided as a new feature called federated search via
z39.5/SRU servers. The function may be same as at the time of data entry via
z39.5 only the format of result display needs to be changes. With this facility
libraries may search the remote z39.5/SRU enabled OPAC as well as they can
configure their Institutional repositories also like in DSpace and eprints.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6685] circ rules by groups of items

2015-05-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6685

Marjorie Barry-Vila  changed:

   What|Removed |Added

 CC||marjorie.barry-v...@ccsr.qc
   ||.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11361] Add a Z39.50 search page in the OPAC to let members search for records on remote Koha instances.

2015-05-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11361

vinod  changed:

   What|Removed |Added

 CC||vinod_librarian@rediffmail.
   ||com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14101] auto renewal is tied to 'no renewal before'

2015-05-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14101

--- Comment #5 from Holger Meißner  ---
(In reply to Nicole C. Engard from comment #0)
> It seems as though the autorenewal feature needs to have the column "no
> renewal before" filled in or it will auto renew everyday after the duedate

Hello Nicole. Yes, this is intentional. The "no renewal before" setting is the
only way for the cronjob to know whether it is too soon for renewal or not. So
without it, it will just renew every time it runs. Unless another restriction
is met.

> I'm not sure (haven't had time to test) how this effects auto renewals that
> happen from the check box on the check out screen.

There is a flag in the database called issues.auto_renew. If automatic renewal
is scheduled by issing rule, this flag will be set for all issues where the
rule applies. By checkbox the same flag is set, just for one issue. It makes no
difference for the automatic renewal cronjob. It just tries to renew every
flagged issue and uses the "no renewal before" settig from the issuing rule
that applies.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14195] TestBuilder does not generate the good length for text fields

2015-05-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14195

--- Comment #6 from Jonathan Druart  ---
(In reply to Marcel de Rooy from comment #5)
> Small question before passing QA: why do you decrement $size here:
> 
> +if ( defined $size and $size > 1 ) {
> +$size--;

Because the regex, in this case, is
[A-Za-z][A-Za-z0-9_]*
And the max size passed to String::Random is related to the wild card, not the
the size of the complete string.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12768] Replacement cost and processing fee management

2015-05-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12768

M. Tompsett  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff
 CC||mtomp...@hotmail.com

--- Comment #28 from M. Tompsett  ---
I set this back to Needs Signoff, as resolving the conflict was relatively
trivial.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12768] Replacement cost and processing fee management

2015-05-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12768

M. Tompsett  changed:

   What|Removed |Added

  Attachment #38375|0   |1
is obsolete||

--- Comment #27 from M. Tompsett  ---
Created attachment 39300
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39300&action=edit
Bug 12768 [QA Followup] - Fix unit tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12768] Replacement cost and processing fee management

2015-05-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12768

M. Tompsett  changed:

   What|Removed |Added

  Attachment #38368|0   |1
is obsolete||

--- Comment #26 from M. Tompsett  ---
Created attachment 39299
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39299&action=edit
Bug 12768 - Replacement cost and processing fee management

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12768] Replacement cost and processing fee management

2015-05-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12768

M. Tompsett  changed:

   What|Removed |Added

  Attachment #38367|0   |1
is obsolete||

--- Comment #25 from M. Tompsett  ---
Created attachment 39298
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39298&action=edit
Bug 12768 - Updated schema files

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13242] Slow checkin for patrons restricted indefinitely

2015-05-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13242

--- Comment #38 from Sophie MEYNIEUX  ---
Would it be possible to have it in 3.16.x ? Thanx

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13242] Slow checkin for patrons restricted indefinitely

2015-05-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13242

Sophie MEYNIEUX  changed:

   What|Removed |Added

 CC||m...@kohaaloha.com,
   ||sophie.meyni...@biblibre.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7380] Can't filter patron search on detail page

2015-05-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7380

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||tomasco...@gmail.com

--- Comment #32 from Tomás Cohen Arazi  ---
Patches pushed to master.

Good one Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14195] TestBuilder does not generate the good length for text fields

2015-05-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14195

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl
   Patch complexity|--- |Small patch
 QA Contact|gmcha...@gmail.com  |m.de.r...@rijksmuseum.nl

--- Comment #5 from Marcel de Rooy  ---
Small question before passing QA: why do you decrement $size here:

+if ( defined $size and $size > 1 ) {
+$size--;

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14200] GetNormalizedISBN failing to normalize valid ISBNs in some cases

2015-05-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14200

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com
 Status|Passed QA   |Pushed to Master

--- Comment #7 from Tomás Cohen Arazi  ---
Patches pushed to master.

Good work Kyle!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14200] GetNormalizedISBN failing to normalize valid ISBNs in some cases

2015-05-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14200

Marcel de Rooy  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
   |y.org   |
   Patch complexity|Trivial patch   |Small patch
Version|3.18|master
 CC||m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14200] GetNormalizedISBN failing to normalize valid ISBNs in some cases

2015-05-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14200

--- Comment #6 from Marcel de Rooy  ---
Created attachment 39297
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39297&action=edit
Bug 14200 - GetNormalizedISBN failing to normalize valid ISBNs in some cases

For some reason the regular expression used to split the multiple ISBN
fields can fail which keeps Business::ISBN from being able to parse out
and return a valid isbn. Using split() instead of the regex fixes the
issue.

Test Plan:
1) Apply the unit test patch first
2) prove t/Koha.t
3) Note the failures
4) Apply the second patch
5) prove t/Koha.t
6) Note all tests pass

Signed-off-by: Kyle M Hall 
Signed-off-by: Karen Bryant 
Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14200] GetNormalizedISBN failing to normalize valid ISBNs in some cases

2015-05-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14200

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #39197|0   |1
is obsolete||
  Attachment #39198|0   |1
is obsolete||

--- Comment #5 from Marcel de Rooy  ---
Created attachment 39296
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39296&action=edit
Bug 14200 - Unit Tests

Signed-off-by: Kyle M Hall 
Signed-off-by: Karen Bryant 
Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14200] GetNormalizedISBN failing to normalize valid ISBNs in some cases

2015-05-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14200

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14213] Cataloging plugin in cloned field does not work

2015-05-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14213

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com
 Status|Passed QA   |Pushed to Master

--- Comment #4 from Tomás Cohen Arazi  ---
Patch pushed to master.

Good catch Marcel!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7143] Bug for tracking changes to the about page

2015-05-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Pushed to Master|ASSIGNED

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11607] items.content does not contain any formatting when HTML message is selected.

2015-05-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11607

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||tomasco...@gmail.com

--- Comment #5 from Tomás Cohen Arazi  ---
Patch pushed to master.

Thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9892] export_borrowers.pl separator should default to the 'delimiter' syspref value

2015-05-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9892

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #10 from Tomás Cohen Arazi  ---
Patches pushed to master.

Thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10947] Default framework for authorities can't be edited

2015-05-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10947

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com
 Status|Passed QA   |Pushed to Master

--- Comment #4 from Tomás Cohen Arazi  ---
Patch pushed to master.

Thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10011] Branch limitiations are not saved on creating a new patron category

2015-05-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10011

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com
 Status|Passed QA   |Pushed to Master

--- Comment #6 from Tomás Cohen Arazi  ---
Patch pushed to master.

Thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7143] Bug for tracking changes to the about page

2015-05-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #248 from Tomás Cohen Arazi  ---
Update pushed.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7143] Bug for tracking changes to the about page

2015-05-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #39295|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7143] Bug for tracking changes to the about page

2015-05-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #39294|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7143] Bug for tracking changes to the about page

2015-05-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143

--- Comment #247 from Marcel de Rooy  ---
Created attachment 39295
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39295&action=edit
Bug 7143: [QA Follow-up] Restoring lost  tag

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7143] Bug for tracking changes to the about page

2015-05-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7143] Bug for tracking changes to the about page

2015-05-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #39091|0   |1
is obsolete||

--- Comment #246 from Marcel de Rooy  ---
Created attachment 39294
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39294&action=edit
Bug 7143: Small fix on the 3.20 release team

Signed-off-by: Tomas Cohen Arazi 

Signed-off-by: Bernardo Gonzalez Kriegel 
Magnus is alone, no errors

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10299] authorities plugin putting values in reverse order

2015-05-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10299

Marcel de Rooy  changed:

   What|Removed |Added

 QA Contact||m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10299] authorities plugin putting values in reverse order

2015-05-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10299

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #39199|0   |1
is obsolete||

--- Comment #5 from Marcel de Rooy  ---
Created attachment 39293
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39293&action=edit
Bug 10299: authority plugin - authority field are reversed

If you click the plugin next to an authority field that is already
populated it takes the values from the field and puts them in the search
in the reverse order.

Test plan:
1/ Edit a biblio
2/ Fill the subfield for an authority field (for instance 650$v, 650$x,
650$y, etc.)
3/ Click on the authority plugin
Before this patch, the values were concatenated in the reverse order.
With this patch, it should not.

Signed-off-by: Bernardo Gonzalez Kriegel 
Work as described, no koha-qa errors

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10299] authorities plugin putting values in reverse order

2015-05-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10299

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14220] Bugzilla Not sending emails in other than gmail account

2015-05-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14220

Owen Leonard  changed:

   What|Removed |Added

 Resolution|--- |INVALID
 Status|NEW |RESOLVED

--- Comment #1 from Owen Leonard  ---
Bugzilla bugs should be reported to Bugzilla developers, not Koha developers:

https://www.bugzilla.org/developers/reporting_bugs.html

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14191] Noisy warns in C4/XSLT.pm

2015-05-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14191

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #4 from Bernardo Gonzalez Kriegel  ---
Aleisha,
seems that your second patch needs the first!
You need to un-obsolete first patch

fatal: sha1 information is lacking or useless (C4/XSLT.pm).
Repository lacks necessary blobs to fall back on 3-way merge.
Cannot fall back to three-way merge.

Comments:
1) You wrote

my $itemtypes = "" unless GetItemTypes();

here I think you can use //

my $itemtypes = GetItemTypes() // "";

2) About ~~, as per Bug 12151 we can't use smartmatch operator

3) Which Linux/Perl/Apache version are you using?
I don't see those warnings, but on Debian weezy there are warnings
that do not appear on Ubuntu 14.04

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14214] Automatic renewal to renew at end of due date

2015-05-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14214

Holger Meißner  changed:

   What|Removed |Added

 CC||h.meissner...@web.de

--- Comment #1 from Holger Meißner  ---
(In reply to Fiona Borthwick from comment #0)
> If an item is set to automatically renew, then there should be a
> straightforward way to set the value so that it will renew at the end of the
> due date.

Hi Fiona, there is a global syspref RenewalPeriodBase. It can be set to base
the new due date on the current date or on the old due date. So the time the
renewal happens doesn't have to be exactly at the end of the loan period.

The automatic renewal feature uses the No renewal before setting, but No
renewal before also is a feature in its own right. I didn't consider values
smaller than 1, because that would mean users cannot renew before the item is
already due. But maybe this could be changed.

It should definitely work with values equal to or greater than 1. I will look
into this more deeply.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

  1   2   >