[Koha-bugs] [Bug 14113] Silence warnings t/Date.t
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14113 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14249] discharge letter edits
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14249 --- Comment #3 from Nicole C. Engard neng...@gmail.com --- Something like either of these: headingDischarge Confirmation/heading rightTODAYS DATE/right BRANCH NAME certifies that the following borrower: FIRSTNAME SURNAME, Cardnumber: CARDNUMBER currently has no items checked out. Or headingDischarge Confirmation/heading rightTODAYS DATE/right BRANCH NAME certifies that the following borrower: FIRSTNAME SURNAME, Cardnumber: CARDNUMBER has returned all items. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14113] Silence warnings t/Date.t
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14113 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Attachment #39431|0 |1 is obsolete|| --- Comment #8 from M. Tompsett mtomp...@hotmail.com --- Created attachment 39546 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39546action=edit Bug 14113: Silence t/Dates.t warnings and cleanup output. The expectation of a user not freaking out over 'Illegal date' messages is not sensible. Catch the messages, give a nicer message. Also, compress the veritical spacing on the output. TEST PLAN - 1) $ prove t/Dates.t -- notice Illegal date messages, and extra lines between some sectional messages. 2) Apply patch 3) $ prove t/Dates.t -- Notice how nice and clean it is? Try it with -v to see all the output, including the expected warning type messages. 4) run koha qa test tools. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14113] Silence warnings t/Date.t
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14113 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 --- Comment #67 from Héctor Eduardo Castro Avalos hector.hecax...@gmail.com --- (In reply to Katrin Fischer from comment #66) Hi Hector, can you confirm that this is the only new dependency needed here now? 'RDF::Trine' = { +'usage'= 'Core', +'required' = '1', +'min_ver' = '1.000', +}, Hi Katrin, sorry about my lateness in get in touch with you. I had an accident in a motorcycle and my clavicle is cracked. The first several days was painful. :( Yes, is the only dependency since the problem of packaging in deb like happened in bug related to PDF::FromHTML. I have used instead C4::Record and the subroutine _entity_encode(). This eliminate HTML::Entities and, HTML::Entities::Numbered and fit very well with Koha without having a lot of problems. The last patch that I sent, fix the last change in PerlDependencies.pm due to new PDF::FromHTML was added. Regards -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14186] Noisy warns in opac-reserve.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14186 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added CC||ch...@bigballofwax.co.nz Severity|enhancement |minor Status|Pushed to Master|Pushed to Stable --- Comment #12 from Chris Cormack ch...@bigballofwax.co.nz --- Pushed to 3.20.x will be in 3.20.1 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14130] column.def should be updated with descriptions for new columns
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14130 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||ch...@bigballofwax.co.nz --- Comment #6 from Chris Cormack ch...@bigballofwax.co.nz --- Pushed to 3.20.x will be in 3.20.1 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14121] Silence warnings t/db_dependent/Auth_with_cas.t
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14121 --- Comment #9 from M. Tompsett mtomp...@hotmail.com --- (In reply to Aleisha Amohia from comment #8) t/db_dependent/Auth_with_cas.t .. 1/4 # Failed test 'Intranet URL should be returned when using intranet login (Bug 13507)' # at t/db_dependent/Auth_with_cas.t line 60. # got: 'localhost/cgi-bin/koha/opac-user.pl?bar=baz' # expected: 'localhost:8080?bar=baz' # Looks like you failed 1 test of 4. t/db_dependent/Auth_with_cas.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/4 subtests I can't replicate this failure. If I can't replicate, I can't fix. Could you retest on a fresh branch after a git pull? Thanks. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13799] Add base for building RESTful API
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 --- Comment #47 from Robin Sheat ro...@catalyst.net.nz --- libmojolicious-perl_5.54+dfsg-1~koha1_all.deb (etc.) and libjs-prettify_2013.03.04+dfsg-4~koha1_all.deb (etc.) are now in the repo. I had to install Java on my build vm to get that last one to build. I hope you're happy! ;) Now to look into swagger2. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13799] Add base for building RESTful API
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 --- Comment #48 from Robin Sheat ro...@catalyst.net.nz --- And, libswagger2-perl is in the repo now too. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13664] Add password strength plugin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13664 tadeas.mora...@gmail.com changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 --- Comment #68 from Marc Véron ve...@veron.ch --- Sorry, I got conflicts while applying: Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt Auto-merging debian/control CONFLICT (content): Merge conflict in debian/control Auto-merging C4/Installer/PerlDependencies.pm CONFLICT (content): Merge conflict in C4/Installer/PerlDependencies.pm Failed to merge in the changes. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13664] Add password strength plugin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13664 tadeas.mora...@gmail.com changed: What|Removed |Added Attachment #39333|0 |1 is obsolete|| --- Comment #46 from tadeas.mora...@gmail.com --- Created attachment 39557 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39557action=edit Add complexify includes file to staff client http://bugs.koha-community.org/show_bug.cgi?id=13664 Signed-off-by: Tadeasm tadeas.mora...@gmail.com Signed-off-by: Tadeasm tadeas.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13664] Add password strength plugin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13664 tadeas.mora...@gmail.com changed: What|Removed |Added Attachment #39332|0 |1 is obsolete|| --- Comment #45 from tadeas.mora...@gmail.com --- Created attachment 39556 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39556action=edit Add jquery plugins to staff client http://bugs.koha-community.org/show_bug.cgi?id=13664 Signed-off-by: Tadeasm tadeas.mora...@gmail.com Signed-off-by: Tadeasm tadeas.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13664] Add password strength plugin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13664 tadeas.mora...@gmail.com changed: What|Removed |Added Attachment #39327|0 |1 is obsolete|| --- Comment #40 from tadeas.mora...@gmail.com --- Created attachment 39551 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39551action=edit Add SQL for OPACPasswordStrength syspref http://bugs.koha-community.org/show_bug.cgi?id=13664 Signed-off-by: Tadeasm tadeas.mora...@gmail.com Signed-off-by: Tadeasm tadeas.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13664] Add password strength plugin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13664 tadeas.mora...@gmail.com changed: What|Removed |Added Attachment #39323|0 |1 is obsolete|| --- Comment #36 from tadeas.mora...@gmail.com --- Created attachment 39547 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39547action=edit Add jquery-complexify library http://bugs.koha-community.org/show_bug.cgi?id=13664 Signed-off-by: Tadeasm tadeas.mora...@gmail.com Signed-off-by: Tadeasm tadeas.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13664] Add password strength plugin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13664 tadeas.mora...@gmail.com changed: What|Removed |Added Attachment #39326|0 |1 is obsolete|| --- Comment #39 from tadeas.mora...@gmail.com --- Created attachment 39550 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39550action=edit Add OPACPasswordStrength syspref to staff client http://bugs.koha-community.org/show_bug.cgi?id=13664 Signed-off-by: Tadeasm tadeas.mora...@gmail.com Signed-off-by: Tadeasm tadeas.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13664] Add password strength plugin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13664 tadeas.mora...@gmail.com changed: What|Removed |Added Attachment #39330|0 |1 is obsolete|| --- Comment #43 from tadeas.mora...@gmail.com --- Created attachment 39554 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39554action=edit Put password meter under syspref control http://bugs.koha-community.org/show_bug.cgi?id=13664 Signed-off-by: Tadeasm tadeas.mora...@gmail.com Signed-off-by: Tadeasm tadeas.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13664] Add password strength plugin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13664 tadeas.mora...@gmail.com changed: What|Removed |Added Attachment #39331|0 |1 is obsolete|| --- Comment #44 from tadeas.mora...@gmail.com --- Created attachment 39555 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39555action=edit Add password strength meter to staff client http://bugs.koha-community.org/show_bug.cgi?id=13664 Signed-off-by: Tadeasm tadeas.mora...@gmail.com Signed-off-by: Tadeasm tadeas.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13664] Add password strength plugin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13664 tadeas.mora...@gmail.com changed: What|Removed |Added Attachment #39329|0 |1 is obsolete|| --- Comment #42 from tadeas.mora...@gmail.com --- Created attachment 39553 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39553action=edit Add OPACPasswordStrength System Preference to Auth.pm http://bugs.koha-community.org/show_bug.cgi?id=13664 Signed-off-by: Tadeasm tadeas.mora...@gmail.com Signed-off-by: Tadeasm tadeas.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13664] Add password strength plugin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13664 tadeas.mora...@gmail.com changed: What|Removed |Added Attachment #39325|0 |1 is obsolete|| --- Comment #38 from tadeas.mora...@gmail.com --- Created attachment 39549 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39549action=edit Change formatting and correct spelling mistakes http://bugs.koha-community.org/show_bug.cgi?id=13664 Signed-off-by: Tadeasm tadeas.mora...@gmail.com Signed-off-by: Tadeasm tadeas.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13664] Add password strength plugin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13664 tadeas.mora...@gmail.com changed: What|Removed |Added Attachment #39324|0 |1 is obsolete|| --- Comment #37 from tadeas.mora...@gmail.com --- Created attachment 39548 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39548action=edit Added complexify display to opac-passwd page http://bugs.koha-community.org/show_bug.cgi?id=13664 Signed-off-by: Tadeasm tadeas.mora...@gmail.com Signed-off-by: Tadeasm tadeas.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13664] Add password strength plugin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13664 tadeas.mora...@gmail.com changed: What|Removed |Added Attachment #39328|0 |1 is obsolete|| --- Comment #41 from tadeas.mora...@gmail.com --- Created attachment 39552 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39552action=edit Add default OPACPasswordStrength syspref to updatedatabase.pl http://bugs.koha-community.org/show_bug.cgi?id=13664 Signed-off-by: Tadeasm tadeas.mora...@gmail.com Signed-off-by: Tadeasm tadeas.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13664] Add password strength plugin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13664 tadeas.mora...@gmail.com changed: What|Removed |Added Attachment #39337|0 |1 is obsolete|| --- Comment #50 from tadeas.mora...@gmail.com --- Created attachment 39561 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39561action=edit Add password strength meter to add and duplicate user in staff client http://bugs.koha-community.org/show_bug.cgi?id=13664 Signed-off-by: tadeasm tadeas.mora...@gmail.com Works as expected Signed-off-by: Tadeasm tadeas.mora...@gmail.com Signed-off-by: Tadeasm tadeas.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13664] Add password strength plugin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13664 tadeas.mora...@gmail.com changed: What|Removed |Added Attachment #39336|0 |1 is obsolete|| --- Comment #49 from tadeas.mora...@gmail.com --- Created attachment 39560 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39560action=edit Put staff client password strength meter under syspref control http://bugs.koha-community.org/show_bug.cgi?id=13664 Signed-off-by: Tadeasm tadeas.mora...@gmail.com Signed-off-by: Tadeasm tadeas.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13664] Add password strength plugin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13664 tadeas.mora...@gmail.com changed: What|Removed |Added Attachment #39334|0 |1 is obsolete|| --- Comment #47 from tadeas.mora...@gmail.com --- Created attachment 39558 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39558action=edit Add new PasswordStrength syspref http://bugs.koha-community.org/show_bug.cgi?id=13664 Signed-off-by: Tadeasm tadeas.mora...@gmail.com Signed-off-by: Tadeasm tadeas.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13664] Add password strength plugin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13664 tadeas.mora...@gmail.com changed: What|Removed |Added Attachment #39335|0 |1 is obsolete|| --- Comment #48 from tadeas.mora...@gmail.com --- Created attachment 39559 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39559action=edit Add code to updatedatabase.pl http://bugs.koha-community.org/show_bug.cgi?id=13664 Signed-off-by: Tadeasm tadeas.mora...@gmail.com Signed-off-by: Tadeasm tadeas.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13664] Add password strength plugin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13664 tadeas.mora...@gmail.com changed: What|Removed |Added Attachment #39544|0 |1 is obsolete|| --- Comment #51 from tadeas.mora...@gmail.com --- Created attachment 39562 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39562action=edit Add password strength to member-password screen http://bugs.koha-community.org/show_bug.cgi?id=13664 Signed-off-by: Tadeasm tadeas.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11490] Deleting Batch Items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11490 --- Comment #3 from Jonathan Druart jonathan.dru...@biblibre.com --- Not sure to know what you should do here. MaxItemsForBatch has been added because 1000 was hardcoded in the code. In the batch item deletion tool it does not block the deletion, but does not display the item info. In the batch item mod tool it completely blocks the modification. This behavior seems to exist previous to bug 11343. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10858] Browse selected biblios
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12176] Remove HTML from additem.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12176 --- Comment #36 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 39503 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39503action=edit Edit item highlight yellow -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13946] Change order status 'Pending' to ordered like in database
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13946 sandbo...@biblibre.com sandbo...@biblibre.com changed: What|Removed |Added Attachment #39475|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13946] Change order status 'Pending' to ordered like in database
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13946 sandbo...@biblibre.com sandbo...@biblibre.com changed: What|Removed |Added CC||sandbo...@biblibre.com Status|Needs Signoff |Signed Off --- Comment #2 from sandbo...@biblibre.com sandbo...@biblibre.com --- Patch tested with a sandbox, by Cédric Vita cedric.v...@dracenie.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13946] Change order status 'Pending' to ordered like in database
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13946 --- Comment #3 from sandbo...@biblibre.com sandbo...@biblibre.com --- Created attachment 39500 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39500action=edit Bug 13946: Change order status 'Pending' to 'Ordered' The order status after closing the basket is 'ordered' in the database, but displays as 'pending' in the staff interface. As we use 'pending' when you have to review a suggestion, this clashes in translations and the meaning is different. The patch renames 'pending' for the order status to 'Ordered' to be more clear. To test: - Verfiy 'Ordered' shows in the pull down on the acq advanced search and search still works correctly - Verify the results table also display 'Ordered' as the status Signed-off-by: C -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13171] Check box for email is missing for hold notifications in patron messaging preferences.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13171 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Severity|critical|normal --- Comment #6 from Jonathan Druart jonathan.dru...@biblibre.com --- Ok, lowering the priority but let it open to try and get more information. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11064] batch import ignoring framework choice
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11064 --- Comment #7 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to Jacek Ablewicz from comment #6) (In reply to Jonathan Druart from comment #1) Created attachment 38319 [details] [review] [review] Bug 11064: Hide the framework choice when importing biblio This choice is ignored, it's preferable to hide it. Test plan: 0/ Before to apply the patch, confirm the issue I'm unable to replicate such issue - framework choice seems to work for me as expected, and it doesn't appear to be ignored (at least not always / not in the cases when it shouldn't be ignored). Can you provide some more details regarding the circumstances when this issue still occurs? Hum, weird. I don't remember what I tested, but I am pretty sure something was wrong. I have just retested: FW1 : 300$a in tab 1 FW2 : ignore 300$a Create a record with 300$a = test, export it, import it using the FW2. On editing the imported record, it used FW2 and 300$a is not displayed. If I select FW1, 300$a does not exist. This seems to be the expected behavior. Bernardo, how did you confirm the issue? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11620] Add dissertation-information index for non-UNIMARC installations
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11620 --- Comment #3 from Magnus Enger mag...@libriotech.no --- NORMARC also has a dissertation note in 502, but I can add that in a separate bug when Katrin has gotten approval of her patch here. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13610] delete_patrons.pl crashes on debian squeeze
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13610 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #7 from Jonathan Druart jonathan.dru...@biblibre.com --- Looks good yes. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12176] Remove HTML from additem.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12176 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #37 from Jonathan Druart jonathan.dru...@biblibre.com --- And I confirm that it does not work with this patch set. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14248] Optionally display authorship for news items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14248 --- Comment #9 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to Viktor Sarge from comment #7) Jonathan - glad to hear we could have done all three in one thread. That was my fault. I recalled guidelines being to separate different types of changes in different threads (database change, syspref to use it and display logic in different patches). But that might be for larger patches or all together wrong(?) Not really, we split big feature/enh in small bug reports if we can split it, and if it makes sense. Most of the time the DB and sysprefs changes are attached to the same bug report. I would prefer to see them managed in a separate patch, but not everybody does it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10858] Browse selected biblios
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added CC||claire.hernandez@biblibre.c ||om Assignee|jonathan.dru...@biblibre.co |julian.maur...@biblibre.com |m | Status|Signed Off |Failed QA --- Comment #80 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to Katrin Fischer from comment #78) Some of the other problems went away after making sure my browser cache was cleared. But I still see a problem when both cart and list are turned off: the text browse selected records still shows up, but there are no checkboxes to select a record. This is still valid. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7651] Updating currency exchange rates should not require 'parameters' permission
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7651 --- Comment #3 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to Katrin Fischer from comment #2) Hm, I'd like to work on this, but not sure about 2 things: - Do we really need to separate adding and editing? I would say no. - Should the new permission(s) be under acquisitions or under administration? Heh :) Since budget permissions are listed under acq, I would say acq. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14252] Moving the OPAC language switcher to masthead navbar
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14252 --- Comment #26 from Marc Véron ve...@veron.ch --- (In reply to Katrin Fischer from comment #22) Hm, I think flags are problematic in other ways, because picking one is not always easy for any language. (...) E.g. for Switzerland: We have German, French, Italian languages and it always looks a bit odd to see them symbolized by foreign flags (Germany, France, Italy)... (In reply to Mirko Tietgen from comment #24) A switcher in the header should be an addition, not a replacement for the one in the footer. (...) Why not having a syspref (Language selection in header or footer with footer as default)? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12176] Remove HTML from additem.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12176 --- Comment #35 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to Marcel de Rooy from comment #33) (In reply to Jonathan Druart from comment #32) Sorry but I have found something else. Before this patch, the item line which is currently edited was highlighted in yellow. After this patch, it does not anymore. Jonathan: I also remember the yellow line. But when I am testing in current clean master now, I do not see it anymore ! I am looking where it is triggered in the template/js ? By item line I meant the tr tag in the items table. Screenshot coming. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14163] Show all on order page confusing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14163 tadeas.mora...@gmail.com changed: What|Removed |Added Attachment #39473|0 |1 is obsolete|| --- Comment #2 from tadeas.mora...@gmail.com --- Created attachment 39501 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39501action=edit Bug 14163: Acq order form: rename 'Show all' to 'Show inactive' On the order form there is a checkbox next to the fund list labelled 'show all'. Checking the checkbox will result in the inactive funds showing in the pull down list as well. The patch renames the label to 'Show inactive' to make the purpose more clear. To test: - Create a new order - Verify the label has changed as described above - Decide if the change makes sense Signed-off-by: tadeasm tadeas.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14163] Show all on order page confusing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14163 tadeas.mora...@gmail.com changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10858] Browse selected biblios
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 --- Comment #79 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 39502 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39502action=edit Bug 10858: Replace the unique jQuery function with our own -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10945] Make Z39.50 work for queries that contain Norwegian vowels
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10945 --- Comment #2 from Magnus Enger mag...@libriotech.no --- (In reply to Katrin Fischer from comment #1) Magnus, is this still valid? Still a problem, as far as I can see. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14117] Silence warnings t/Search_PazPar2.t
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14117 --- Comment #8 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to M. Tompsett from comment #7) (In reply to Jonathan Druart from comment #6) yes Because of yaz client? Or is there something else I'm missing? Sorry I don't get it. I have just said that the file does not make sense, the tests are not really useful. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10172] Some links and blocks could be hidden when printing a record
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10172 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14163] Show all on order page confusing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14163 Josef Moravec josef.mora...@gmail.com changed: What|Removed |Added CC||josef.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14267] How active is active in additem.tt?
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14267 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14267] How active is active in additem.tt?
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14267 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #39492|0 |1 is obsolete|| --- Comment #3 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 39508 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39508action=edit Bug 14267: How active is active? git grep on function active in additem.tt: koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt:function active(n koha-tmpl/intranet-tmpl/prog/en/modules/serials/serial-issues-full.tt:active([% koha-tmpl/intranet-tmpl/prog/en/modules/serials/serial-issues-full.tt:function a koha-tmpl/intranet-tmpl/prog/en/modules/serials/serial-issues-full.tt: t/Cache.t: unless ( $cache-is_cache_active() defined $cache ); t/Cache.t: unless ( $cache-is_cache_active() ); Conclusion: active in additem seems to be quite inactive. Test plan: Add, edit or delete items and verify that you did not miss active :) NOTE: The active function has a loop which is always run. Inside that loop 'ong' would always be defined as some number concatenated with XX. Both sides of the if/else reference document.getElementById(ong), but there is only one occurence of XX in the file: the concatenation! Similarly, the 'link' logic does not correspond to any of the id= or name= strings in the file. koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc_subfields_structure.tt is the only file with id=\link that matches the logic. This is likely a cut-and-paste remnant made useless by datatable upgrades and HTML/CSS class changes. Signed-off-by: Mark Tompsett mtomp...@hotmail.com Signed-off-by: Jonathan Druart jonathan.dru...@koha-community.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 4925] Remove Smithsonian as a delivered z39.50 target
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4925 --- Comment #5 from Marc Véron ve...@veron.ch --- Removing +1 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14189] Make text persist/populate hidden fields for the Staff searchbox
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14189 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #39112|0 |1 is obsolete|| Attachment #39462|0 |1 is obsolete|| --- Comment #12 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 39505 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39505action=edit Bug 14189 - Made text persist when clicking the tabs under the searchbox To test: Apply the patch and see that the text now is there in the search box when clicking the tabs: check in, check out etc.. (More files changed for persistent text in searchbox) Sponsored-by: Halland County Library http://bugs.koha-community.org/show_bug.cgi?id=14189 Signed-off-by: Magnus Enger mag...@enger.priv.no This is something I have wanted quite a few times over the years... Tested by going to every main area of Koha, entering some random text into the search box and then clicking on all the available tabs to check that the entered text is carried over to all the boxes. There are a couple of places where text is not carried over, but I guess that might be because one of the boxes is structurally different to the others. These are: - Vendor search and Orders search in Acquisitions - Search subscriptions in Serials I have not looked at how this is implemented, just that it works as it should. Bug 14189 refactor after failed QA. Signed-off-by: Jonathan Druart jonathan.dru...@koha-community.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14246] Add borrowernumber to koha_news
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14246 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Failed QA CC||jonathan.dru...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12176] Remove HTML from additem.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12176 --- Comment #38 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com --- (In reply to Jonathan Druart from comment #37) And I confirm that it does not work with this patch set. Hey, it works... half of the time :) Only highlights even items, odd ones remains un-highligthed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7981] Remove HomeOrHoldingBranchReturn syspref
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7981 --- Comment #50 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 39504 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39504action=edit Bug 7981: Reintroduce dropboxdate The parameter was lost in previous commit. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7981] Remove HomeOrHoldingBranchReturn syspref
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7981 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14189] Make text persist/populate hidden fields for the Staff searchbox
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14189 --- Comment #13 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 39506 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39506action=edit Bug 14189: Use keep_text for the authority header includes/authorities-search.inc already used the same behavior but with another method. For consistency it's better to have only 1 way to do that. Test plan: Go on the authority home page Fill the input in the header and click on tab 'search all headings' and 'keyword search' and confirm that the text you have filled is kept. Signed-off-by: Jonathan Druart jonathan.dru...@koha-community.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14189] Make text persist/populate hidden fields for the Staff searchbox
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14189 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14100] Generic solution for language overlay
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14100 --- Comment #5 from Jonathan Druart jonathan.dru...@biblibre.com --- Yes true, I would have said I don't plan to go further without any *other* feedbacks ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14100] Generic solution for language overlay
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14100 --- Comment #3 from Jonathan Druart jonathan.dru...@biblibre.com --- I don't plan to go further without any feedbacks. Please test. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14100] Generic solution for language overlay
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14100 --- Comment #4 from Marc Véron ve...@veron.ch --- (In reply to Jonathan Druart from comment #3) I don't plan to go further without any feedbacks. Please test. Hi Jonathan, I tested the proof of concept. It works as described and I think it is really the way to go. (See comment #2) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14189] Make text persist/populate hidden fields for the Staff searchbox
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14189 --- Comment #14 from Jonathan Druart jonathan.dru...@biblibre.com --- Elvin, Thanks for your followup. I have squashed the 2 first patches to avoid too many add/del lines in the same patch set (same lines were added in the 1st and removed in the 2nd). Could you please test my patch for the authority header? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14252] Moving the OPAC language switcher to masthead navbar
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14252 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |In Discussion --- Comment #27 from Jonathan Druart jonathan.dru...@biblibre.com --- Set to In Discussion. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10172] Some links and blocks could be hidden when printing a record
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10172 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #38231|0 |1 is obsolete|| --- Comment #7 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 39507 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39507action=edit Bug 10172: Hide some uneeded stuffs on printing a record When printing a record from the OPAC or the staff interface, some uneeded blocks are displayed. OPAC: 1/ Browse results 2/ The view tags (Normal, MARC, ISBD) Intranet: 1/ Marc view link 2/ The Please upload one image link Test plan: On a record detail page (staff and OPAC), print the page and confirm these blocks no longer appear. Signed-off-by: Nick Clemens n...@quecheelibrary.org Signed-off-by: Katrin Fischer katrin.fischer...@web.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14267] How active is active in additem.tt?
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14267 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added CC||jonathan.dru...@biblibre.co ||m --- Comment #4 from Jonathan Druart jonathan.dru...@biblibre.com --- Yes it's definitely dead code. It was used to select active tab. But actually I suspect a c/p at the creation of the template. Note that this active function is still defined on serials/serial-issues-full.tt but I did not manage to reach this template... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14266] Replace trim() with $.trim() in opac-shareshelf.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14266 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added CC||jonathan.dru...@biblibre.co ||m --- Comment #6 from Jonathan Druart jonathan.dru...@biblibre.com --- David, could you please have a look at my counter patch? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14266] Replace trim() with $.trim() in opac-shareshelf.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14266 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14266] Replace trim() with $.trim() in opac-shareshelf.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14266 --- Comment #5 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 39509 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39509action=edit [COUNTER-PATCH] Bug 14266: Trim the email address in the pl script The original concern of bug 14266 was to provide a compatibility for IE9. But actually we don't need to trim the email address template side. It will even better to trim it in the perl script, so that the email will be trimed even if JS is disabled. Test plan: 1/ Share a list and does not provide any email address 2/ Submit = The form is not submited, no alert/message is displayed (same as before this patch). 3/ Share a list and provide an email address with spaces before and after 4/ Submit = You should receive the email -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7923] Performance omnibus
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7923 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Blocks|14207 | Depends on||14207 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14207] Improving circulation performance by caching yaml file
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14207 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Depends on|7923| Blocks||7923 CC||jonathan.dru...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13946] Change order status 'Pending' to ordered like in database
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13946 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13946] Change order status 'Pending' to ordered like in database
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13946 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #39500|0 |1 is obsolete|| --- Comment #4 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 39510 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39510action=edit Bug 13946: Change order status 'Pending' to 'Ordered' The order status after closing the basket is 'ordered' in the database, but displays as 'pending' in the staff interface. As we use 'pending' when you have to review a suggestion, this clashes in translations and the meaning is different. The patch renames 'pending' for the order status to 'Ordered' to be more clear. To test: - Verfiy 'Ordered' shows in the pull down on the acq advanced search and search still works correctly - Verify the results table also display 'Ordered' as the status Signed-off-by: Cédric Vita cedric.v...@dracenie.com Signed-off-by: Jonathan Druart jonathan.dru...@koha-community.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7143] Bug for tracking changes to the about page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed: What|Removed |Added Attachment #39482|0 |1 is obsolete|| --- Comment #252 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com --- Created attachment 39511 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39511action=edit [SIGNED-OFF] Bug 7143: Release team for 3.22 See: http://wiki.koha-community.org/wiki/Roles_for_3.22 The 3.20 roles are moved to the Development section. Note that we did not add the Bug wranglers role under Development until now. If that should change, please provide a follow-up. Test plan: Verify that all roles are covered correctly. Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com Seems correct for me, no errors. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7143] Bug for tracking changes to the about page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12176] Remove HTML from additem.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12176 --- Comment #39 from Marcel de Rooy m.de.r...@rijksmuseum.nl --- OK One misunderstanding resolved.. The items table highlight should not be that hard to fix. Will have a look. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 1985] Email notification of new OPAC comments
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985 --- Comment #44 from Jonathan Druart jonathan.dru...@biblibre.com --- Comment on attachment 38909 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38909 Bug 1985 - tweak License and lots of cleanup Review of attachment 38909: -- (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.htmlbug=1985attachment=38909) - ::: t/db_dependent/Review.t @@ +21,5 @@ +$biblionumber = $row-{'biblionumber'} if $row; + +SKIP: { +skip Missing borrowers or biblios,13 + unless $biblionumber and $borrowernumber; You have to generate the data you want! Try TestBuilder, it will do that for you. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14206] notices using non email templates can't be deleted from the staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14206 --- Comment #22 from Marc Véron ve...@veron.ch --- Created attachment 39512 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39512action=edit [Signed-off] Bug 14206 - Adds test for getletter() call from overdue_notices.pl Adds missing test for getletter() when called from overdue_notices.pl Test plan = 1/ apply this patch 2/ run prove -v t/db_dependent/Letters.t all tests should pass, especially test #40 which tests call from overdue_notices.pl Signed-off-by: Marc Véron ve...@veron.ch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12176] Remove HTML from additem.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12176 --- Comment #40 from Marcel de Rooy m.de.r...@rijksmuseum.nl --- (In reply to Jonathan Druart from comment #37) And I confirm that it does not work with this patch set. I have the strong impression that it does not work without this patch set too :) It only works on the even items. So imo this should not interfere with this report. But let me add a small followup for changing behavior (it should go on another report). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12176] Remove HTML from additem.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12176 --- Comment #41 from Marcel de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 39513 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39513action=edit Highlight -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12176] Remove HTML from additem.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12176 --- Comment #42 from Marcel de Rooy m.de.r...@rijksmuseum.nl --- (In reply to Marcel de Rooy from comment #41) Created attachment 39513 [details] [review] Highlight Would this resolve your highlight problem, Jonathan? No clean patch btw.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14207] Improving circulation performance by caching yaml file
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14207 Julian FIOL julian.f...@biblibre.com changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14207] Improving circulation performance by caching yaml file
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14207 Julian FIOL julian.f...@biblibre.com changed: What|Removed |Added Attachment #39233|0 |1 is obsolete|| --- Comment #4 from Julian FIOL julian.f...@biblibre.com --- Created attachment 39514 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39514action=edit Bug 14207 - Improving circulation performance by caching yaml file This patch improve circulation performance by caching yaml file With this patch we saved between 300ms and 500ms on circulation page. Following Comment #3 : No useless warn No tidy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14262] Versioning updates for master
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14262 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Attachment #39453|0 |1 is obsolete|| --- Comment #2 from Tomás Cohen Arazi tomasco...@gmail.com --- Created attachment 39515 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39515action=edit [PASSED QA] Bug 14262: change the build-git-snapshot version to 3.21 Signed-off-by: Tomas Cohen Arazi tomasco...@gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12176] Remove HTML from additem.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12176 --- Comment #45 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 39518 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39518action=edit Bug 12176: [QA Follow-up] Small additem adjustments Adjusting a few small things and making qa tools happy: [1] Remove .hidden after [% avalue %] in additem.tt. (Typo) [2] A closer look revealed that mv.avalue is useless too. An input element does not contain any content. Putting it after the hidden element in a non-visible context has no meaning. [3] Change handling of select attributes readonly and disabled. [4] Remove unused variable $attributes_no_value_textarea [5] Removed a comment with TODO referring to this report. [6] Moving a duplicated TT variable (mv.javascript) outside IF statement. [7] And finally could not resist this one: Moving strings Tag editor and No popup from script to template. Plugins++ NOTE: Most item plugins redirect click to focus. In that case there is no popup, but unfortunately the text Tag editor comes up. When you remove or rename function Click, No popup comes up. So it works. Sorry that this small list kept growing :) Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com Signed-off-by: Jonathan Druart jonathan.dru...@koha-community.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12176] Remove HTML from additem.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12176 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12176] Remove HTML from additem.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12176 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #39346|0 |1 is obsolete|| Attachment #39450|0 |1 is obsolete|| Attachment #39451|0 |1 is obsolete|| Attachment #39452|0 |1 is obsolete|| Attachment #39516|0 |1 is obsolete|| --- Comment #44 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 39517 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39517action=edit Bug 12176: Remove HTML from additem.pl This patch removes HTML code from additem.pl. To test: 1. Check no regressions on Add/Edit/Save items 2. Update translation files for a language, check new strings Tag editor No popup on staff PO file 3. Check it passes xt/tt_valid.t Patch partially rebased, part rewritten. Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl Signed-off-by: Jonathan Druart jonathan.dru...@koha-community.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12176] Remove HTML from additem.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12176 --- Comment #46 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 39519 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39519action=edit Bug 12176: [QA Follow-up] Capitalization typo after eleventh hour While cleaning up, still found this super tiny string typo :) Yes, Tag Editor should now be Tag editor. Test plan :) Git grep on Tag editor and Tag Editor Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com Signed-off-by: Jonathan Druart jonathan.dru...@koha-community.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12176] Remove HTML from additem.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12176 Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12176] Remove HTML from additem.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12176 Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed: What|Removed |Added Attachment #39513|0 |1 is obsolete|| --- Comment #43 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com --- Created attachment 39516 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39516action=edit [SIGNED-OFF] Bug 12176: Highlight edited item http://bugs.koha-community.org/show_bug.cgi?id=12176 Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com Now edited item is correctly highlighted No errors -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12176] Remove HTML from additem.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12176 --- Comment #47 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 39520 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39520action=edit Bug 12176: Fix for missing field_value in select As Jonathan Druart discovered, we were still missing an important attribute in the selects. Var mv.name was not filled, so the name was empty with nice side-effects :) While fixing this, it was also possible to delete some unused vars that Bernardo already mentioned before: $attributes and $attributes_no_value. Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com For me the simptom was different, when saving an edited item fields were mangled beyond repear :( No alert for empty mandatory fields. But this last patch fix the problem. Tested add/edit items Cleaner pl file :) No errors Signed-off-by: Jonathan Druart jonathan.dru...@koha-community.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12176] Remove HTML from additem.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12176 --- Comment #48 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to Marcel de Rooy from comment #40) (In reply to Jonathan Druart from comment #37) And I confirm that it does not work with this patch set. I have the strong impression that it does not work without this patch set too :) It only works on the even items. So imo this should not interfere with this report. But let me add a small followup for changing behavior (it should go on another report). Yes you are right, it does not work as expected on master. So let's move it to its own bug report. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12743] Allow default values from the ACQ framework to be used when creating a record in acquisitions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12743 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #14 from Tomás Cohen Arazi tomasco...@gmail.com --- Patch pushed to master. Thanks Jonathan! Note: I forgot to mark it Pushed to master but it is already on 3.20. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12743] Allow default values from the ACQ framework to be used when creating a record in acquisitions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12743 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Resolution|--- |FIXED Status|Pushed to Master|RESOLVED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14207] Improving circulation performance by caching yaml file
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14207 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Failed QA CC||tomasco...@gmail.com --- Comment #3 from Jonathan Druart jonathan.dru...@biblibre.com --- Julian, I think it's a really good idea to cache the yaml file. Could you please resubmit a patch without the useless warnings and without the tidy up (alignment, superfluous carriage return). You should not tidy lines if you don't modify them. Tomas, could you confirm me there is a best practice to restart the memcache server on upgrading? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14206] notices using non email templates can't be deleted from the staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14206 Marc Véron ve...@veron.ch changed: What|Removed |Added Attachment #39467|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14206] notices using non email templates can't be deleted from the staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14206 Marc Véron ve...@veron.ch changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14252] Moving the OPAC language switcher to masthead navbar
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14252 --- Comment #28 from Indranil Das Gupta indr...@gmail.com --- Hi Marc (In reply to Marc Véron from comment #26) (In reply to Katrin Fischer from comment #22) Hm, I think flags are problematic in other ways, because picking one is not always easy for any language. (...) E.g. for Switzerland: We have German, French, Italian languages and it always looks a bit odd to see them symbolized by foreign flags (Germany, France, Italy)... The Swiss have 3, well think about India, 22 officially recognised languages, all well-represented in Unicode. :) As for the flag bit, IMHO the better way to go about it is to use the flag of the country the language is representing e.g. pt-PT should use Portugal's flag, whereas pt-BR should use Brazil's flag. That way all 3 languages of Switzerland should be tagged against the Swiss flag. (In reply to Mirko Tietgen from comment #24) A switcher in the header should be an addition, not a replacement for the one in the footer. (...) Why not having a syspref (Language selection in header or footer with footer as default)? +1 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/