[Koha-bugs] [Bug 14275] Remove CGI::scrolling_list from guided_reports.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14275 Marc Véron changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14275] Remove CGI::scrolling_list from guided_reports.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14275 --- Comment #2 from Marc Véron --- Created attachment 39563 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39563&action=edit [Signed-off] Bug 14275: Remove CGI::scrolling_list from guided_reports.pl Remove an instance of CGI::scrolling_list from this file To test: 1) Go to Reports, Guided report wizard, New SQL report 2) Create a report with some auth value list, e.g. SELECT surname,firstname FROM borrowers WHERE branchcode=<> Save 3) Clic on 'Run this report", look at the dropdown, that will be changed 4) Apply the patch 5) Reload, check dropdown and any regression Followed test plan, works as expected. Signed-off-by: Marc Véron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14275] Remove CGI::scrolling_list from guided_reports.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14275 Marc Véron changed: What|Removed |Added CC||ve...@veron.ch Attachment #39530|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12824] Create a general purpose koha-config script?
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12824 Marc Véron changed: What|Removed |Added CC||ve...@veron.ch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14246] Add borrowernumber to koha_news
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14246 Martin Persson changed: What|Removed |Added Attachment #39521|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11668] Untranslatable "Total" in borrowers stats and other reports
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11668 Marc Véron changed: What|Removed |Added Assignee|ve...@veron.ch |koha-b...@lists.koha-commun ||ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8992] Add an interfacing with the idref webservice
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8992 --- Comment #73 from Jonathan Druart --- Nicole, IdRef is a French service for Sudoc autorities. Using the Sudoc database, it allows to request / modify / add authorities. If a record comes from the Sudoc (so 009 is filled with an integer), at the OPAC you will see "Author: Idref" if a 7..$3 (unimarc author) if filled with a ppn. On clicking on the Idref link, a popup will display. The Idref webservice is requested and all records (by roles) for this author will be displayed (see screenshot). There is 1 line / record and 2 links at the end. 1 will request Koha (cgi-bin/koha/opac-search.pl?q=ident:003381862), the other one will redirect to the sudoc page (http://www.sudoc.fr/003381862). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8992] Add an interfacing with the idref webservice
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8992 --- Comment #74 from Jonathan Druart --- Created attachment 39564 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39564&action=edit idref_roles -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8992] Add an interfacing with the idref webservice
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8992 --- Comment #75 from Jonathan Druart --- Created attachment 39565 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39565&action=edit idref_detail -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14252] Moving the OPAC language switcher to masthead navbar
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14252 --- Comment #29 from Mirko Tietgen --- (In reply to Marc Véron from comment #26) > Why not having a syspref (Language selection in header or footer with footer > as default)? Because I would like both. :P So a third option (»both«) would be nice. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14185] Noisy warns in opac-readingrecord.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14185 Chris Cormack changed: What|Removed |Added CC||ch...@bigballofwax.co.nz Severity|enhancement |minor Status|Pushed to Master|Pushed to Stable --- Comment #8 from Chris Cormack --- Pushed to 3.20.x will be in 3.20.1 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14184] Noisy warns in C4/CourseReserves.pm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14184 Chris Cormack changed: What|Removed |Added Severity|enhancement |minor CC||ch...@bigballofwax.co.nz Status|Pushed to Master|Pushed to Stable --- Comment #5 from Chris Cormack --- Pushed to 3.20.x will be in 3.20.1 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14279] Remove CGI::scrolling_list from issues_avg_stats.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14279 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12993] Add a default tax rate on item types
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12993 Jonathan Druart changed: What|Removed |Added Attachment #33305|0 |1 is obsolete|| Attachment #33307|0 |1 is obsolete|| Attachment #34797|0 |1 is obsolete|| Attachment #35394|0 |1 is obsolete|| --- Comment #24 from Jonathan Druart --- Created attachment 39566 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39566&action=edit Bug 12993: Add a default tax rate on item types This enhancement permits to set a default tax rate for item types. If a default tax rate is defined for an item type, the tax rate will be automatically selected when the librarian choose the type of the item to order. Test plan: 0/ Execute the updatedb entry. 1/ Define a default tax rate for some item types. 2/ Create an order and verify the tax rate is selected after you have chosen the item type. Note that the item type is only displayed if defined at the biblio level. Signed-off-by: Paola Rossi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12993] Add a default tax rate on item types
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12993 --- Comment #26 from Jonathan Druart --- Created attachment 39568 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39568&action=edit Attachment to Bug 12993 - Add a default tax rate on item types Bug 12993: Add a default tax rate on item types - DB changes This patch adds a new DB field: itemtypes.gstrate Signed-off-by: Paola Rossi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12993] Add a default tax rate on item types
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12993 --- Comment #25 from Jonathan Druart --- Created attachment 39567 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39567&action=edit Bug 12993: Select automatically itemtype on neworderempty.pl Signed-off-by: Paola Rossi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14203] koha-translate error string for non-existent lang removal
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14203 Chris Cormack changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||ch...@bigballofwax.co.nz --- Comment #7 from Chris Cormack --- Pushed to 3.20.x will be in 3.20.1 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12993] Add a default tax rate on item types
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12993 --- Comment #27 from Jonathan Druart --- Created attachment 39569 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39569&action=edit Bug 12993: (qa-follow-up) Display the column only when it is useful As mention by comment 19, the default tax rate defined for item types is only useful when the items are created on ordering and the item type is defined at the biblio level. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14025] Fix 856u-links in the OPAC for NORMARC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14025 Chris Cormack changed: What|Removed |Added CC||ch...@bigballofwax.co.nz Status|Pushed to Master|Pushed to Stable --- Comment #7 from Chris Cormack --- Pushed to 3.20.x will be in 3.20.1 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14112] Silence warnings t/Charset.t
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14112 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14112] Silence warnings t/Charset.t
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14112 Jonathan Druart changed: What|Removed |Added Attachment #39545|0 |1 is obsolete|| --- Comment #7 from Jonathan Druart --- Created attachment 39570 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39570&action=edit Bug 14112 - Silence warnings in t/Charset.t After Jonathan said this was the wrong way to correct the issue, www.utf8-chartable.de made it clear to me that the \c3\a9 were missing x's. TEST PLAN - 1) prove t/Charset.t -- noise 2) apply patch 3) prove t/Charset.t -- no noise 4) koha qa test tools Signed-off-by: Aleisha Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679
--- Comment #223 from Jonathan Druart ---
This has not been reverted.
Tomas,
I would say you could quickly patch with
diff --git a/C4/Dates.pm b/C4/Dates.pm
index 6ed9588..d7be584 100644
--- a/C4/Dates.pm
+++ b/C4/Dates.pm
@@ -105,7 +105,7 @@ sub dmy_map {
my $xsub= $dmy_subs{$dformat};
$debug and print STDERR "xsub: $xsub \n";
if ( $val =~ /$re/ ) {
-my $aref = eval {$xsub};
+my $aref = eval $xsub;
In a first time.
You can blame me because I get the error too (5.20.1), sorry about that.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14280] New: Add branches fields to discharges letters
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14280 Bug ID: 14280 Summary: Add branches fields to discharges letters Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: matthias.meusbur...@biblibre.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Currently, when generating a discharge letter, branches fields are not translated in the letter (<>, <>, etc.) This patch fixes that. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14280] Add branches fields to discharges letters
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14280 --- Comment #1 from Matthias Meusburger --- Created attachment 39571 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39571&action=edit Bug 14280: Add branches fields to discharges letters Currently, when generating a discharge letter, branches fields are not translated in the letter (<>, <>, etc.) This patch fixes that. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13799] Add base for building RESTful API
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 --- Comment #50 from Olli-Antti Kivilahti --- Wow! Awesome work! Good karma! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14045] Add specific quotas to on-site checkout
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14045
Nicolas Legrand changed:
What|Removed |Added
Attachment #39147|0 |1
is obsolete||
--- Comment #12 from Nicolas Legrand ---
Created attachment 39572
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39572&action=edit
Bug 14045: Add specific quotas to on-site checkouts
This patch set adds the ability to defined independent quotas for on-site
checkouts.
This will be done using the circulation rules matrix where a new column
“Current on-site checkouts allow” will be added.
This feature is going to use the same method as the existing fields maxissueqty
("Current checkouts allowed"), the new fields will be added to the
different tables (see the "DB changes" patch) and will be named
maxonsiteissueqty (for consistency).
In order to keep the existing behavior and to let more flexibility,
a new system preference is added (ConsiderOnSiteCheckoutsAsNormalCheckouts).
This syspref will let the liberty to the library to decide if an on-site
checkout should be considered as a "normal" checkout or not.
To keep the existing behavior, the syspref will be disabled (i.e. an on-site
checkout is considered as a normal checkout) and the number of on-site
checkouts will be the same as the number of checkout (maxissueqty ==
maxonsiteissueqty).
Technically:
There are only very few tests for the Circulation module, and the 2
subroutines impacted by this patch set were not tested at all.
It is necessary to introduce non-regression tests for this area.
The 2 subroutines are: C4::Circulation::GetBranchBorrowerCircRule
and C4::Circulation::TooMany (only called by
C4::Circulation::CanBookBeIssued, so we will take the liberty to change
the prototype to raise a better warning to the end user).
Test plan:
I. Confirm there is no regression and the existing behavior is kept
0/ Let the syspref disabled
1/ Set a rule to limit to 2 the number of checkouts allowed
2/ Do a normal checkout
3/ Do an on-site checkout
4/ Try to checkout (on-site or normal) an item again.
You should not be allowed.
II. Test the new feature - pref disabled
0/ Let the syspref disabled
1/ Set a rule to limit to 2 the number of checkouts allowed and to 1
the number of on-site checkouts allowed.
2/ Do an on-site checkout
3/ Try to do another one, you should not be allowed to do it.
4/ A normal checkout should pass successfully
Note that it does not make sense to have the number of on-site checkouts
alowed > number of checkouts allowed.
III. Test the new feature - pref enabled
0/ Enable the syspref
Now an on-site checkout is *not* counted as a normal checkout.
This means you can have the number of on-site checkouts > number of
checkouts allowed.
1/ Set the values you want for the 2 types of checkouts (normal vs
on-site).
2/ Even if a patron has reached the maximum of checkouts allowed, he
will be allowed to do a on-site checkout (vice versa).
IV. Stress the developper
Using the different configurations available in the circulation matrix,
try to find one where the checkout is allowed and not should be.
Sponsored-by: BULAC - http://www.bulac.fr/
Signed-off-by: Nicolas Legrand
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14045] Add specific quotas to on-site checkout
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14045 Nicolas Legrand changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14045] Add specific quotas to on-site checkout
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14045
Nicolas Legrand changed:
What|Removed |Added
Attachment #39572|0 |1
is obsolete||
--- Comment #13 from Nicolas Legrand ---
Created attachment 39573
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39573&action=edit
Bug 14045: Add specific quotas to on-site checkouts
This patch set adds the ability to defined independent quotas for on-site
checkouts.
This will be done using the circulation rules matrix where a new column
“Current on-site checkouts allow” will be added.
This feature is going to use the same method as the existing fields maxissueqty
("Current checkouts allowed"), the new fields will be added to the
different tables (see the "DB changes" patch) and will be named
maxonsiteissueqty (for consistency).
In order to keep the existing behavior and to let more flexibility,
a new system preference is added (ConsiderOnSiteCheckoutsAsNormalCheckouts).
This syspref will let the liberty to the library to decide if an on-site
checkout should be considered as a "normal" checkout or not.
To keep the existing behavior, the syspref will be disabled (i.e. an on-site
checkout is considered as a normal checkout) and the number of on-site
checkouts will be the same as the number of checkout (maxissueqty ==
maxonsiteissueqty).
Technically:
There are only very few tests for the Circulation module, and the 2
subroutines impacted by this patch set were not tested at all.
It is necessary to introduce non-regression tests for this area.
The 2 subroutines are: C4::Circulation::GetBranchBorrowerCircRule
and C4::Circulation::TooMany (only called by
C4::Circulation::CanBookBeIssued, so we will take the liberty to change
the prototype to raise a better warning to the end user).
Test plan:
I. Confirm there is no regression and the existing behavior is kept
0/ Let the syspref disabled
1/ Set a rule to limit to 2 the number of checkouts allowed
2/ Do a normal checkout
3/ Do an on-site checkout
4/ Try to checkout (on-site or normal) an item again.
You should not be allowed.
II. Test the new feature - pref disabled
0/ Let the syspref disabled
1/ Set a rule to limit to 2 the number of checkouts allowed and to 1
the number of on-site checkouts allowed.
2/ Do an on-site checkout
3/ Try to do another one, you should not be allowed to do it.
4/ A normal checkout should pass successfully
Note that it does not make sense to have the number of on-site checkouts
alowed > number of checkouts allowed.
III. Test the new feature - pref enabled
0/ Enable the syspref
Now an on-site checkout is *not* counted as a normal checkout.
This means you can have the number of on-site checkouts > number of
checkouts allowed.
1/ Set the values you want for the 2 types of checkouts (normal vs
on-site).
2/ Even if a patron has reached the maximum of checkouts allowed, he
will be allowed to do a on-site checkout (vice versa).
IV. Stress the developper
Using the different configurations available in the circulation matrix,
try to find one where the checkout is allowed and not should be.
Sponsored-by: BULAC - http://www.bulac.fr/
Signed-off-by: Nicolas Legrand
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14045] Add specific quotas to on-site checkout
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14045 Nicolas Legrand changed: What|Removed |Added Attachment #39148|0 |1 is obsolete|| --- Comment #15 from Nicolas Legrand --- Created attachment 39575 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39575&action=edit Bug 14045: Change prototype of TooMany to raise a better warning With this patch, the user will know why the checkout is refused. Signed-off-by: Nicolas Legrand -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14045] Add specific quotas to on-site checkout
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14045 Nicolas Legrand changed: What|Removed |Added Attachment #39149|0 |1 is obsolete|| --- Comment #16 from Nicolas Legrand --- Created attachment 39576 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39576&action=edit Bug 14045: Introduce the maxonsiteissueqty field as a copy of maxissueqty This patch adds the new fields maxonsiteissueqty as a copy of the existing maxissueqty field. There is no brainy code here, it only adds the ability to fill the new field from the admin interface (admin/smart-rules.pl). Signed-off-by: Nicolas Legrand -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14045] Add specific quotas to on-site checkout
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14045 Nicolas Legrand changed: What|Removed |Added Attachment #39150|0 |1 is obsolete|| --- Comment #17 from Nicolas Legrand --- Created attachment 39577 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39577&action=edit Bug 14045: Make GetBranchBorrowerCircRule return maxonsiteissueqty GetBranchBorrowerCircRule should return the value for maxissueqty and maxonsiteissueqty. It's what this patch does. Signed-off-by: Nicolas Legrand -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14045] Add specific quotas to on-site checkout
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14045 Nicolas Legrand changed: What|Removed |Added Attachment #39151|0 |1 is obsolete|| --- Comment #18 from Nicolas Legrand --- Created attachment 39578 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39578&action=edit Bug 14045: DB Changes This patch is the DB changes for the feature. It adds 5 new columns named 'maxonsiteissueqty' to the following tables: - branch_borrower_circ_rules - default_borrower_circ_rules - default_branch_circ_rules - default_circ_rules - issuingrules It also adds the pref ConsiderOnSiteCheckoutsAsNormalCheckouts. See main patch for more details. Signed-off-by: Nicolas Legrand -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14045] Add specific quotas to on-site checkout
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14045 Nicolas Legrand changed: What|Removed |Added Attachment #39152|0 |1 is obsolete|| --- Comment #19 from Nicolas Legrand --- Created attachment 39579 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39579&action=edit Bug 14045: DBIC Changes Signed-off-by: Nicolas Legrand -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14045] Add specific quotas to on-site checkout
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14045
Nicolas Legrand changed:
What|Removed |Added
Attachment #39573|0 |1
is obsolete||
--- Comment #14 from Nicolas Legrand ---
Created attachment 39574
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39574&action=edit
Bug 14045: Add specific quotas to on-site checkouts
This patch set adds the ability to defined independent quotas for on-site
checkouts.
This will be done using the circulation rules matrix where a new column
“Current on-site checkouts allow” will be added.
This feature is going to use the same method as the existing fields maxissueqty
("Current checkouts allowed"), the new fields will be added to the
different tables (see the "DB changes" patch) and will be named
maxonsiteissueqty (for consistency).
In order to keep the existing behavior and to let more flexibility,
a new system preference is added (ConsiderOnSiteCheckoutsAsNormalCheckouts).
This syspref will let the liberty to the library to decide if an on-site
checkout should be considered as a "normal" checkout or not.
To keep the existing behavior, the syspref will be disabled (i.e. an on-site
checkout is considered as a normal checkout) and the number of on-site
checkouts will be the same as the number of checkout (maxissueqty ==
maxonsiteissueqty).
Technically:
There are only very few tests for the Circulation module, and the 2
subroutines impacted by this patch set were not tested at all.
It is necessary to introduce non-regression tests for this area.
The 2 subroutines are: C4::Circulation::GetBranchBorrowerCircRule
and C4::Circulation::TooMany (only called by
C4::Circulation::CanBookBeIssued, so we will take the liberty to change
the prototype to raise a better warning to the end user).
Test plan:
I. Confirm there is no regression and the existing behavior is kept
0/ Let the syspref disabled
1/ Set a rule to limit to 2 the number of checkouts allowed
2/ Do a normal checkout
3/ Do an on-site checkout
4/ Try to checkout (on-site or normal) an item again.
You should not be allowed.
II. Test the new feature - pref disabled
0/ Let the syspref disabled
1/ Set a rule to limit to 2 the number of checkouts allowed and to 1
the number of on-site checkouts allowed.
2/ Do an on-site checkout
3/ Try to do another one, you should not be allowed to do it.
4/ A normal checkout should pass successfully
Note that it does not make sense to have the number of on-site checkouts
alowed > number of checkouts allowed.
III. Test the new feature - pref enabled
0/ Enable the syspref
Now an on-site checkout is *not* counted as a normal checkout.
This means you can have the number of on-site checkouts > number of
checkouts allowed.
1/ Set the values you want for the 2 types of checkouts (normal vs
on-site).
2/ Even if a patron has reached the maximum of checkouts allowed, he
will be allowed to do a on-site checkout (vice versa).
IV. Stress the developper
Using the different configurations available in the circulation matrix,
try to find one where the checkout is allowed and not should be.
Sponsored-by: BULAC - http://www.bulac.fr/
Signed-off-by: Nicolas Legrand
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14045] Add specific quotas to on-site checkout
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14045 --- Comment #20 from Nicolas Legrand --- Works perfectly. We just add a problem with the new syspref: ConsiderOnSiteCheckoutsAsNormalCheckouts. The explanation puzzled a tester: "If enabled, the number of checkouts allowed will be normal checkouts + on-site checkouts. If disabled, both values will be checked separately." As the syspref is not enabled but set on “consider” or “don't consider”, I propose a wording less ambiguous: "If set on “consider”, the number of checkouts allowed will be normal checkouts + on-site checkouts. Otherwise, both values will be checked separately." I didn't patch it because maybe a native english speaker will find a better wording or find the first one was best :). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14268] Change Localsyspref type entry to dropdown
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14268 tadeas.mora...@gmail.com changed: What|Removed |Added Attachment #39494|0 |1 is obsolete|| --- Comment #8 from tadeas.mora...@gmail.com --- Created attachment 39580 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39580&action=edit Bug 14268: counter-patch -- dropdown for Variable type The information needed to build the dropdown is already passed. This patch uses it to build the variable type dropdown correctly. TEST PLAN - 1) Apply 14135 2) In the staff client: Home -> Global system preferences -> Local use 3) Click 'Edit' on any system preference. 4) Note all the types listed. 5) Click 'Cancel' 6) Apply this patch 7) Click '+New Preference' 8) Enter data to have a decent 'Free' type preference. 9) Click 'Save' 10) For each type noted in step 4 (do 'Free' again last) a) Click 'Edit' for the added system preference -- it should be the last saved variable type. b) Change the variable type to the next type. c) Click 'Save' d) Repeat steps (a) through (c) until all the types have been done. -- NOTE: Yes, there are other strange things here, but those are beyond the scope of this bug. 11) Run koha qa test tools Signed-off-by: Indranil Das Gupta (L2C2 Technologies) Signed-off-by: Tadeasm -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14268] Change Localsyspref type entry to dropdown
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14268 tadeas.mora...@gmail.com changed: What|Removed |Added Attachment #39496|0 |1 is obsolete|| --- Comment #9 from tadeas.mora...@gmail.com --- Created attachment 39581 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39581&action=edit Followup - instruction for preftype selection removes the now redundant instruction "Note: you should have no reasons to modify the following default values" and replaces it with "Note: change the variable type to one of the dropdown values as needed" http://bugs.koha-community.org/show_bug.cgi?id=14268 Signed-off-by: Tadeasm -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14268] Change Localsyspref type entry to dropdown
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14268 tadeas.mora...@gmail.com changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14252] Moving the OPAC language switcher to masthead navbar
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14252 --- Comment #30 from Marc Véron --- (In reply to Mirko Tietgen from comment #29) > (In reply to Marc Véron from comment #26) > > > Why not having a syspref (Language selection in header or footer with footer > > as default)? > > Because I would like both. :P So a third option (»both«) would be nice. Yes, indeed :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14252] Moving the OPAC language switcher to masthead navbar
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14252 Viktor Sarge changed: What|Removed |Added CC||viktor.sarge@regionhalland. ||se --- Comment #31 from Viktor Sarge --- Interesting. Both have their merits. What I like about the current solution is that it's visible (if we fix that bug...) and that switching language is a one off thing that you don't need to waste screen space in the top on mobile devices for. Using a drop down seems reasonable when you have many languages, but it does waste screen space on the top of pages (having to scroll extra on every page in mobile because of a one off language switcher is no fun). Also it's hard to make it obvious that it's there. Perhaps a hybrid with a drop down showing when there's too many languages installed to display the all? I still vote for the footer however. For a drop down I would solve identifying it with using the language names in their own alphabet. If I see a drop down on an english web that displays arabic my first thought it that it will also have french, german, hungarian and swedish (etcetera) :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13849] Introduce acceptance tests with cucumber
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13849 Julian FIOL changed: What|Removed |Added CC||julian.f...@biblibre.com --- Comment #7 from Julian FIOL --- To test: 0/ * Install the selenium server (have a look at bug 13691) * Install libtest-bdd-cucumber-perl (pkg) and App::pherkin (cpan) * Edit t/db_dependent/cucumber/features/step_definitions/basic_steps.pl and fill the login and password of a superlibrarian user. Maybe you should also change the address of the selenium server (search for 'remote_server_addr'). 1/ Start the selenium server and launch the tests: $ cd t/db_dependent/cucumber $ pherkin or $ prove tests.t Hi Jonathan, I tried your patch using pherkin and prove, and I have the same issue at both times : Create a Category is OK [...] But create a patron crash after submit : Create a patron As a librarian I want to create a new patron Scenario: Create a patron Given I am logged in as a library admin Given I have gone to the new patron page When I have filled the field surname with "test_patron_surname" And I have filled the field cardnumber with "4242424242" And I have filled the field userid with "test_username" And I have filled the field password with "password" And I have filled the field password2 with "password" And I have clicked on the submit button Then The patron "test_username" should have been created step defined at features/1-patron.feature line 22. ok 1 - Starting to execute step: The patron "test_username" should have been created not ok 2 - The patron test_username should exist # Failed test 'The patron test_username should exist' # at features/step_definitions/1-patron_steps.pl line 12. # got: '0' # expected: '1' 1..2 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14098] Regression in Marc Modification Templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14098 --- Comment #10 from Jonathan Druart --- Created attachment 39584 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39584&action=edit Bug 14098: Add copy_and_replace action to MMT This patch add the new value for the MTT action. It updates the marc_modification_template_actions.action DB field to allow 'copy_and_replace_field'. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14098] Regression in Marc Modification Templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14098 --- Comment #11 from Jonathan Druart --- Created attachment 39585 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39585&action=edit Bug 14098: Implement the copy_and_replace action for MTT This patch implements the copy and replace action for the marc modification templates. Instead of copying a field/subfield, it will erase the destination fields/subfields. Test plan: Find it yourself. Compare the differences between the copy and the copy_and_replace actions. The easier way to test is to 1/ create a complete record, 2/create some modification templates and 3/ use the batch record modification with the "preview" function. QA note: I kept the same tests as "copy" and, if no change were expected, I noted them "(same as copy)", to be sure this new action won't introduce regression on these tests. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14098] Regression in Marc Modification Templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14098 Jonathan Druart changed: What|Removed |Added Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14098] Regression in Marc Modification Templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14098 --- Comment #8 from Jonathan Druart --- Created attachment 39582 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39582&action=edit Bug 14098: FIX Copy a subfield should not update the original field There is an inconsistency in the copy action: Given the following control sample: 245_aThe art of computer programming _cDonald E. Knuth. 300_aA_exists _bB_exists If we apply action (a) Copy the whole field 245 to 300, we get: 245_aThe art of computer programming _cDonald E. Knuth. 300_aA_exists _bB_exists 300_aThe art of computer programming _cDonald E. Knuth. If we apply action (b) Copy the subfield 245$a to 300$a, we get: 245_aThe art of computer programming _cDonald E. Knuth. 300_aThe art of computer programming _bB_exists In (a) the field is copied but in (b) the subfield is erased. We should be consistent and don't erase the destination field. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14098] Regression in Marc Modification Templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14098 --- Comment #9 from Jonathan Druart --- Created attachment 39583 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39583&action=edit Bug 14098: Remove unedeed subroutines Just some cleaning before to continue, _copy_field and _copy_subfield did not do anything useful. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14252] Moving the OPAC language switcher to masthead navbar
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14252 --- Comment #32 from Viktor Sarge --- Oh... please disregard the note about scrolling past language chooser on every page of mobile device. That was me being to quick when looking at the screenshots :) But if I (now finally) understand the issue correctly we would indeed need a way to better communicate where you choose the language. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14281] New: text notices include tags
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14281 Bug ID: 14281 Summary: text notices include tags Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: neng...@gmail.com QA Contact: testo...@bugs.koha-community.org When you don't have HTML selected on overdues the notices that are sent to the library as an attachment have tags in them. This is causing issues with some mail filters that see HTML in the notice but a TXT extension. If you don't want HTML for your notices you should only have text in them - no coding. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14098] Regression in Marc Modification Templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14098 --- Comment #12 from Jonathan Druart --- Important note: IMO this should be backported to 3.20.x with a warning in the updatedatabase entry if select count(*) from marc_modification_template_actions where action="copy_field"; returns > 0 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7793] redefine the field message_id as PRIMARY KEY of message_queue
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7793 Tomás Cohen Arazi changed: What|Removed |Added Version|unspecified |master CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14275] Remove CGI::scrolling_list from guided_reports.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14275 Jonathan Druart changed: What|Removed |Added Attachment #39563|0 |1 is obsolete|| --- Comment #3 from Jonathan Druart --- Created attachment 39586 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39586&action=edit Bug 14275: Remove CGI::scrolling_list from guided_reports.pl Remove an instance of CGI::scrolling_list from this file To test: 1) Go to Reports, Guided report wizard, New SQL report 2) Create a report with some auth value list, e.g. SELECT surname,firstname FROM borrowers WHERE branchcode=<> Save 3) Clic on 'Run this report", look at the dropdown, that will be changed 4) Apply the patch 5) Reload, check dropdown and any regression Followed test plan, works as expected. Signed-off-by: Marc Véron Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14275] Remove CGI::scrolling_list from guided_reports.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14275 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14205] Deleting an Item/Record does not remove link to course reserve
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14205 --- Comment #1 from Tom Misilo --- I believe it is deleting the item from course_items per the CASCADE DELETE in the Model, however the http://schema.koha-community.org/tables/course_reserves.html course_reserves table is not being cleaned up via a cascade delete (No contraint defined) course_reserves.ci_id -> course_items.ci_id -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14189] Make text persist/populate hidden fields for the Staff searchbox
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14189 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14189] Make text persist/populate hidden fields for the Staff searchbox
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14189 --- Comment #17 from Jonathan Druart --- Created attachment 39588 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39588&action=edit Bug 14189: Use keep_text for the authority header includes/authorities-search.inc already used the same behavior but with another method. For consistency it's better to have only 1 way to do that. Test plan: Go on the authority home page Fill the input in the header and click on tab 'search all headings' and 'keyword search' and confirm that the text you have filled is kept. I tested after applying the patch and the text is kept after removing the part from authorities-search.inc. I also tried applying that jQuery solution instead of my JS loop but could not get it to work for the other pages with a reasonable ammount of effort. Signed-off-by: Jonathan Druart Signed-off-by: Eivin Giske Skaaren -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14252] Moving the OPAC language switcher to masthead navbar
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14252 Gaetan Boisson changed: What|Removed |Added CC||gaetan.bois...@biblibre.com --- Comment #33 from Gaetan Boisson --- Interesting topic! My 2 cents: - I like the icon used by Indranil in his first suggestions (a very generic flag), i think a lot of people will associate a flag with a language selector on a website. There are other interesting options using language characters, but i have the feeling they need more space to be readable. - Flags as languages sound like a bad idea, France is not the French language and so on, but it seems we all agree on this. - They could be used for sub-languages next to the language name itself, it works for de-DE and de-CH for instance. But i am not 100% sure it works everywhere, so we could still end up in political territory. (If we had an Euskara translation for instance, a language spoken in the southwest of France and a part of Spain, where a number of claims for independence have been made. Choosing one flag over another will be a political choice...) - I think we should keep links at the bottom, things at the bottom don't waste space, and some users will find them there. All in all i think we are very close to it: a language picker at the top, with a generic flag icon, sub-languages listed one after another, and links at the bottom where they used to be. I am not even sure we need another syspref, if we have a css id for the top picker unhappy people will be able to hide it easily. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14268] Change Localsyspref type entry to dropdown
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14268 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14268] Change Localsyspref type entry to dropdown
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14268 --- Comment #11 from Jonathan Druart --- Created attachment 39590 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39590&action=edit Bug 14268: Followup - instruction for preftype selection removes the now redundant instruction "Note: you should have no reasons to modify the following default values" and replaces it with "Note: change the variable type to one of the dropdown values as needed" Signed-off-by: Tadeasm Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14268] Change Localsyspref type entry to dropdown
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14268 Jonathan Druart changed: What|Removed |Added Attachment #39580|0 |1 is obsolete|| Attachment #39581|0 |1 is obsolete|| --- Comment #10 from Jonathan Druart --- Created attachment 39589 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39589&action=edit Bug 14268: Use dropdown for variable types The information needed to build the dropdown is already passed. This patch uses it to build the variable type dropdown correctly. TEST PLAN - 1) Apply 14135 2) In the staff client: Home -> Global system preferences -> Local use 3) Click 'Edit' on any system preference. 4) Note all the types listed. 5) Click 'Cancel' 6) Apply this patch 7) Click '+New Preference' 8) Enter data to have a decent 'Free' type preference. 9) Click 'Save' 10) For each type noted in step 4 (do 'Free' again last) a) Click 'Edit' for the added system preference -- it should be the last saved variable type. b) Change the variable type to the next type. c) Click 'Save' d) Repeat steps (a) through (c) until all the types have been done. -- NOTE: Yes, there are other strange things here, but those are beyond the scope of this bug. 11) Run koha qa test tools Signed-off-by: Indranil Das Gupta (L2C2 Technologies) Signed-off-by: Tadeasm Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14189] Make text persist/populate hidden fields for the Staff searchbox
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14189 Jonathan Druart changed: What|Removed |Added Attachment #39505|0 |1 is obsolete|| Attachment #39543|0 |1 is obsolete|| --- Comment #16 from Jonathan Druart --- Created attachment 39587 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39587&action=edit Bug 14189 - Made text persist when clicking the tabs under the searchbox To test: Apply the patch and see that the text now is there in the search box when clicking the tabs: check in, check out etc.. (More files changed for persistent text in searchbox) Sponsored-by: Halland County Library Signed-off-by: Magnus Enger This is something I have wanted quite a few times over the years... Tested by going to every main area of Koha, entering some random text into the search box and then clicking on all the available tabs to check that the entered text is carried over to all the boxes. There are a couple of places where text is not carried over, but I guess that might be because one of the boxes is structurally different to the others. These are: - "Vendor search" and "Orders search" in Acquisitions - "Search subscriptions" in Serials I have not looked at how this is implemented, just that it works as it should. Bug 14189 refactor after failed QA. Signed-off-by: Jonathan Druart Amended patch: replace tabs with spaces -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13849] Introduce acceptance tests with cucumber
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13849 --- Comment #8 from Jonathan Druart --- All works perfectly here. Make sure you have a superlibrarian user "koha" with pwd "koha" or edit features/step_definitions/basic_steps.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14282] New: Add configurable http headers for retrievable uploads (see 6874)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14282 Bug ID: 14282 Summary: Add configurable http headers for retrievable uploads (see 6874) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcha...@gmail.com Reporter: m.de.r...@rijksmuseum.nl QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 --- Comment #338 from Marcel de Rooy --- Please bear with me; still working on this one.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14282] Add configurable http headers for retrievable uploads (see 6874)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14282 Marcel de Rooy changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=6874 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6874] Attach a file to a MARC record (Was: File upload in MARC)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 Marcel de Rooy changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=14282 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13664] Add password strength plugin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13664 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@biblibre.co ||m Status|Signed Off |Patch doesn't apply --- Comment #52 from Jonathan Druart --- Applying: Put staff client password strength meter under syspref control fatal: sha1 information is lacking or useless (C4/Auth.pm). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13619] Acq home: ensure 'manage suggestions' goes to pending suggestions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13619 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13619] Acq home: ensure 'manage suggestions' goes to pending suggestions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13619 Jonathan Druart changed: What|Removed |Added Attachment #39542|0 |1 is obsolete|| --- Comment #5 from Jonathan Druart --- Created attachment 39591 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39591&action=edit Bug 13619: Acq home: ensure 'manage suggestions' goes to pending suggestions The link on the start page of Koha goes to the pending suggestions tab explicitly. The link on the acquisition start page doesn't do that so when you have your own status it might show another tab first. Patch links to be the same and explicitly target the pending tab. To test: - create a new suggestion - verify link from the acq start page leads to the pending tab - verify link from the Koha start page does the same Signed-off-by: Marjorie Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7143] Bug for tracking changes to the about page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7143] Bug for tracking changes to the about page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Jonathan Druart changed: What|Removed |Added Attachment #39511|0 |1 is obsolete|| --- Comment #253 from Jonathan Druart --- Created attachment 39592 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39592&action=edit Bug 7143: Release team for 3.22 See: http://wiki.koha-community.org/wiki/Roles_for_3.22 The 3.20 roles are moved to the Development section. Note that we did not add the Bug wranglers role under Development until now. If that should change, please provide a follow-up. Test plan: Verify that all roles are covered correctly. Signed-off-by: Bernardo Gonzalez Kriegel Seems correct for me, no errors. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14187] branchtransfer needs a primary key (id) for DBIx and common sense.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14187 --- Comment #5 from Olli-Antti Kivilahti --- What do you mean with atomicupdate? All existing unit tests pass and this doesn't include any new testable behaviour. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14187] branchtransfer needs a primary key (id) for DBIx and common sense.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14187 --- Comment #6 from Olli-Antti Kivilahti --- The primary key is needed if you want to do anything with DBIx. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14265] Use $.trim instead of trim() in admin/categorie.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14265 Jonathan Druart changed: What|Removed |Added Attachment #39486|0 |1 is obsolete|| --- Comment #3 from Jonathan Druart --- Created attachment 39593 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39593&action=edit Bug 14265 - Use $.trim instead of trim() in admin/categorie.tt This patch replaces trim() with $.trim() in admin/categorie.tt, as $.trim() is more cross-platform (ie it is supported in "< IE9"). _TEST PLAN_ Before applying patch: 0) Use IE 8 or use Document Mode 8 in a newer IE using F12 Developer Tools 1) Go to Administration > Patron categories 2) Click "Edit" next to a category 3) Click "Save" at the bottom 4) Note the form doesn't submit (you can also notice the error in the console log) Apply the patch: 5) Hold down shift + refresh the page 6) Click "Save" at the bottom" 7) Note that the form does submit and there are no errors reported Signed-off-by: Indranil Das Gupta Signed-off-by: Jonathan Druart No regression found using iceweasel. I did not know the staff interface was IE compatible. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14265] Use $.trim instead of trim() in admin/categorie.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14265 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14252] Moving the OPAC language switcher to masthead navbar
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14252 --- Comment #34 from M. Tompsett --- (In reply to Gaetan Boisson from comment #33) > - I like the icon used by Indranil in his first suggestions (a very generic > flag), i think a lot of people will associate a flag with a language > selector on a website. There are other interesting options using language > characters, but i have the feeling they need more space to be readable. Yes, when I said flag, I didn't mean it had to be a country flag. A generic language selector icon of some sort (whether a flag, globe, etc.). > [SNIP] Choosing one flag over another will be a political choice...) Hence, a generic icon of some sort. Flag shaped? Perhaps. Globe. Whatever, some graphic that screams, "Hey, this is where the language can be changed." > - I think we should keep links at the bottom, things at the bottom don't > waste space, and some users will find them there. Some users will not scroll below the current screen visual. :( > All in all i think we are very close to it: a language picker at the top, > with a generic flag icon, sub-languages listed one after another, and links > at the bottom where they used to be. Generally, perhaps. Yes. > I am not even sure we need another syspref, if we have a css id for the top > picker unhappy people will be able to hide it easily. I always prefer a system preference option over a CSS option. The former requires less technical expertise. Someone playing around with Koha for evaluation purposes is not necessarily going to have CSS expertise or such available to them. Don't force librarians to learn HTML, CSS, Perl, Linux, etc. in order to use Koha. Let's keep the technical level required for customizations low if possible. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13664] Add password strength plugin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13664 David Roberts changed: What|Removed |Added Attachment #39551|0 |1 is obsolete|| --- Comment #57 from David Roberts --- Created attachment 39598 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39598&action=edit Add SQL for OPACPasswordStrength syspref -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13664] Add password strength plugin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13664 David Roberts changed: What|Removed |Added Attachment #39549|0 |1 is obsolete|| --- Comment #55 from David Roberts --- Created attachment 39596 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39596&action=edit Change formatting and correct spelling mistakes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13664] Add password strength plugin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13664 David Roberts changed: What|Removed |Added Attachment #39553|0 |1 is obsolete|| --- Comment #59 from David Roberts --- Created attachment 39600 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39600&action=edit Add OPACPasswordStrength System Preference to Auth.pm -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13664] Add password strength plugin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13664 David Roberts changed: What|Removed |Added Attachment #39550|0 |1 is obsolete|| --- Comment #56 from David Roberts --- Created attachment 39597 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39597&action=edit Add OPACPasswordStrength syspref to staff client -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13664] Add password strength plugin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13664 David Roberts changed: What|Removed |Added Attachment #39555|0 |1 is obsolete|| --- Comment #61 from David Roberts --- Created attachment 39602 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39602&action=edit Add password strength meter to staff client -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13664] Add password strength plugin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13664 David Roberts changed: What|Removed |Added Attachment #39547|0 |1 is obsolete|| --- Comment #53 from David Roberts --- Created attachment 39594 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39594&action=edit Add jquery-complexify library -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13664] Add password strength plugin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13664 David Roberts changed: What|Removed |Added Attachment #39552|0 |1 is obsolete|| --- Comment #58 from David Roberts --- Created attachment 39599 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39599&action=edit Add default OPACPasswordStrength syspref to updatedatabase.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13664] Add password strength plugin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13664 David Roberts changed: What|Removed |Added Attachment #39548|0 |1 is obsolete|| --- Comment #54 from David Roberts --- Created attachment 39595 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39595&action=edit Added complexify display to opac-passwd page -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13664] Add password strength plugin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13664 David Roberts changed: What|Removed |Added Attachment #39556|0 |1 is obsolete|| --- Comment #62 from David Roberts --- Created attachment 39603 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39603&action=edit Add jquery plugins to staff client -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13664] Add password strength plugin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13664 David Roberts changed: What|Removed |Added Attachment #39554|0 |1 is obsolete|| --- Comment #60 from David Roberts --- Created attachment 39601 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39601&action=edit Put password meter under syspref control -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13664] Add password strength plugin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13664 David Roberts changed: What|Removed |Added Attachment #39558|0 |1 is obsolete|| --- Comment #64 from David Roberts --- Created attachment 39605 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39605&action=edit Add new PasswordStrength syspref -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13664] Add password strength plugin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13664 David Roberts changed: What|Removed |Added Attachment #39560|0 |1 is obsolete|| --- Comment #66 from David Roberts --- Created attachment 39607 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39607&action=edit Put staff client password strength meter under syspref control -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13664] Add password strength plugin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13664 David Roberts changed: What|Removed |Added Attachment #39559|0 |1 is obsolete|| --- Comment #65 from David Roberts --- Created attachment 39606 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39606&action=edit Add code to updatedatabase.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13664] Add password strength plugin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13664 David Roberts changed: What|Removed |Added Attachment #39561|0 |1 is obsolete|| --- Comment #67 from David Roberts --- Created attachment 39608 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39608&action=edit Add password strength meter to add and duplicate user in staff client -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13664] Add password strength plugin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13664 David Roberts changed: What|Removed |Added Attachment #39557|0 |1 is obsolete|| --- Comment #63 from David Roberts --- Created attachment 39604 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39604&action=edit Add complexify includes file to staff client -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14098] Regression in Marc Modification Templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14098 Kyle M Hall changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14098] Regression in Marc Modification Templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14098 Kyle M Hall changed: What|Removed |Added Attachment #39582|0 |1 is obsolete|| Attachment #39583|0 |1 is obsolete|| Attachment #39584|0 |1 is obsolete|| Attachment #39585|0 |1 is obsolete|| --- Comment #13 from Kyle M Hall --- Created attachment 39610 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39610&action=edit [SIGNED-OFF] Bug 14098: FIX Copy a subfield should not update the original field There is an inconsistency in the copy action: Given the following control sample: 245_aThe art of computer programming _cDonald E. Knuth. 300_aA_exists _bB_exists If we apply action (a) Copy the whole field 245 to 300, we get: 245_aThe art of computer programming _cDonald E. Knuth. 300_aA_exists _bB_exists 300_aThe art of computer programming _cDonald E. Knuth. If we apply action (b) Copy the subfield 245$a to 300$a, we get: 245_aThe art of computer programming _cDonald E. Knuth. 300_aThe art of computer programming _bB_exists In (a) the field is copied but in (b) the subfield is erased. We should be consistent and don't erase the destination field. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14098] Regression in Marc Modification Templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14098 --- Comment #16 from Kyle M Hall --- Created attachment 39613 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39613&action=edit [SIGNED-OFF] Bug 14098: Implement the copy_and_replace action for MTT This patch implements the copy and replace action for the marc modification templates. Instead of copying a field/subfield, it will erase the destination fields/subfields. Test plan: Find it yourself. Compare the differences between the copy and the copy_and_replace actions. The easier way to test is to 1/ create a complete record, 2/create some modification templates and 3/ use the batch record modification with the "preview" function. QA note: I kept the same tests as "copy" and, if no change were expected, I noted them "(same as copy)", to be sure this new action won't introduce regression on these tests. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14098] Regression in Marc Modification Templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14098 --- Comment #15 from Kyle M Hall --- Created attachment 39612 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39612&action=edit [SIGNED-OFF] Bug 14098: Add copy_and_replace action to MMT This patch add the new value for the MTT action. It updates the marc_modification_template_actions.action DB field to allow 'copy_and_replace_field'. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14098] Regression in Marc Modification Templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14098 --- Comment #14 from Kyle M Hall --- Created attachment 39611 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39611&action=edit [SIGNED-OFF] Bug 14098: Remove unedeed subroutines Just some cleaning before to continue, _copy_field and _copy_subfield did not do anything useful. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13664] Add password strength plugin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13664 David Roberts changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff --- Comment #69 from David Roberts --- I've resubmitted the patch, and it seems to apply OK for me now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14098] Regression in Marc Modification Templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14098 Kyle M Hall changed: What|Removed |Added Status|Signed Off |In Discussion --- Comment #17 from Kyle M Hall --- Copy and replace appears to work as expected. Tried origin copy with 952$a to 952$b which created a second $b subfield on the 952$a. I'm not sure if this was the previous behavior or not. Jonathan, can you reset the status to signed-off or failed qa? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13664] Add password strength plugin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13664 David Roberts changed: What|Removed |Added Attachment #39562|0 |1 is obsolete|| --- Comment #68 from David Roberts --- Created attachment 39609 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39609&action=edit Add password strength to member-password screen -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14098] Regression in Marc Modification Templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14098 --- Comment #18 from Jonathan Druart --- (In reply to Kyle M Hall from comment #17) > Copy and replace appears to work as expected. > > Tried origin copy with 952$a to 952$b which created a second $b subfield on > the 952$a. I'm not sure if this was the previous behavior or not. > > Jonathan, can you reset the status to signed-off or failed qa? It's what I expect :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14098] Regression in Marc Modification Templates
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14098 Kyle M Hall changed: What|Removed |Added Status|In Discussion |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
