[Koha-bugs] [Bug 13600] XSLT: 8xx not showing if there is no 4xx
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13600 Winona Salesky wsale...@gmail.com changed: What|Removed |Added CC||wsale...@gmail.com --- Comment #1 from Winona Salesky wsale...@gmail.com --- How about if there is 490$0 or 490$# ? Should the 8xx display in that case as well? (In reply to Nicole C. Engard from comment #0) In records with series field(s) 800/810/830 only (no 4XX series), no series are displayed. The MARC21 rules say: An 810 field is usually justified by a series statement (field 490) or a general note (field 500) relating to the series. usually means it should show even if there is no 490 http://www.loc.gov/marc/bibliographic/bd810.html -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14334] DBI fighting DBIx over Autocommit in tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14334 --- Comment #15 from M. Tompsett mtomp...@hotmail.com --- Created attachment 39882 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39882action=edit Bug 14334: t/db_dependent/Borrower_Discharge.t AutoCommit fix There is no easy way to trigger an obvious problem. TEST PLAN - 1) apply patch 2) git diff origin/master -- Are the additions/subtractions similar to http://paste.lisp.org/display/149194? 3) run koha qa test tools NOTE: I am uncertain of what yohann.duf...@biblibre.com means in his FIXME comments. No problems experienced under Debian Jessie. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13383] RDA: 100/110/111 changes to XSLT
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13383 Winona Salesky wsale...@gmail.com changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14334] DBI fighting DBIx over Autocommit in tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14334
--- Comment #11 from M. Tompsett mtomp...@hotmail.com ---
I was not expecting to see: $dbh-{AutoCommit} = 1;
in t/db_dependent/BackgroundJob.t at all.
Is this correct? Why even include it then?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13383] RDA: 100/110/111 changes to XSLT
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13383 Winona Salesky wsale...@gmail.com changed: What|Removed |Added Attachment #37424|0 |1 is obsolete|| --- Comment #20 from Winona Salesky wsale...@gmail.com --- Created attachment 39878 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39878action=edit Attachment to Bug 13383 - RDA: 100/110/111 changes to XSLT Bug 13383 - RDA: 100/110/111 changes to XSLT Test plan: 1) Apply this patch 2) Ensure you are using the default XSLT setting for the staff and opac search results and record details 3) Find or create a record with MARC tags 100,110,111 4) Perform an opac search that would show the record in the search results. 5) Click title to review record. 6) Note the fields updates 100,110,111 to show subfields a,b,c,d,q and t.Multiple fields are separated by span class=separator |. Includes 100$j and handles multiple relator terms/codes. 7) Repeat steps 4 - 6 for the staff interface -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14334] DBI fighting DBIx over Autocommit in tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14334 --- Comment #12 from M. Tompsett mtomp...@hotmail.com --- Created attachment 39879 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39879action=edit Bug 14334: t/db_dependent/Biblio.t AutoCommit fix There is no easy way to trigger an obvious problem. TEST PLAN - 1) apply patch 2) git diff origin/master -- Are the additions/subtractions similar to http://paste.lisp.org/display/149194? -- this is a special case, in that the transaction rollbacks seem to terminate the transaction in DBIx. So there needs to be a transaction for each subtest. 3) run koha qa test tools -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14334] DBI fighting DBIx over Autocommit in tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14334 --- Comment #14 from M. Tompsett mtomp...@hotmail.com --- Created attachment 39881 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39881action=edit Bug 14334: t/db_dependent/Borrower_Debarments.t AutoCommit fix There is no easy way to trigger an obvious problem. TEST PLAN - 1) apply patch 2) git diff origin/master -- Are the additions/subtractions similar to http://paste.lisp.org/display/149194? 3) run koha qa test tools -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14334] DBI fighting DBIx over Autocommit in tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14334 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added CC||yohann.duf...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14334] DBI fighting DBIx over Autocommit in tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14334 --- Comment #18 from M. Tompsett mtomp...@hotmail.com --- Created attachment 39885 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39885action=edit Bug 14334: t/db_dependent/Branch.t AutoCommit fix There is no easy way to trigger an obvious problem. TEST PLAN - 1) apply patch 2) git diff origin/master -- Are the additions/subtractions similar to http://paste.lisp.org/display/149194? 3) run koha qa test tools -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14054] 246 XSLT Improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14054 Winona Salesky wsale...@gmail.com changed: What|Removed |Added CC||wsale...@gmail.com --- Comment #3 from Winona Salesky wsale...@gmail.com --- We could do that. Should the display force subfield i to occur at the end as with the titles generated by the indicator? (Makes the most sense to me.) (In reply to Nick Clemens from comment #2) Yay! It works! Thank you! And now a question: Should subfield i also go into brackets when it overrides the 2nd indicator? I think that would make it easier to read too. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14334] DBI fighting DBIx over Autocommit in tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14334 --- Comment #17 from M. Tompsett mtomp...@hotmail.com --- Created attachment 39884 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39884action=edit Bug 14334: t/db_dependent/Borrowers.t AutoCommit fix There is no easy way to trigger an obvious problem. TEST PLAN - 1) apply patch 2) git diff origin/master -- Are the additions/subtractions similar to http://paste.lisp.org/display/149194? 3) run koha qa test tools -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14334] DBI fighting DBIx over Autocommit in tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14334 --- Comment #16 from M. Tompsett mtomp...@hotmail.com --- Created attachment 39883 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39883action=edit Bug 14334: t/db_dependent/Borrower_Files.t AutoCommit fix There is no easy way to trigger an obvious problem. TEST PLAN - 1) apply patch 2) git diff origin/master -- Are the additions/subtractions similar to http://paste.lisp.org/display/149194? 3) run koha qa test tools -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14334] DBI fighting DBIx over Autocommit in tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14334 --- Comment #13 from M. Tompsett mtomp...@hotmail.com --- Created attachment 39880 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39880action=edit Bug 14334: t/db_dependent/Borrower.t AutoCommit fix There is no easy way to trigger an obvious problem. TEST PLAN - 1) apply patch 2) git diff origin/master -- Are the additions/subtractions similar to http://paste.lisp.org/display/149194? -- I added explicit rollback, since I do not know the default behaviour of DBIx. 3) run koha qa test tools -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14334] DBI fighting DBIx over Autocommit in tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14334 --- Comment #6 from M. Tompsett mtomp...@hotmail.com --- t/db_dependent/Acquisition/FillWithDefaultValues.t seems to only read from the DB. I think the removal of the dbh code in the test file is the correct solution, and add a comment about how to do AutoCommit = 0 stuff if a test needs to write. Thoughts? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14334] DBI fighting DBIx over Autocommit in tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14334 --- Comment #8 from M. Tompsett mtomp...@hotmail.com --- Created attachment 39875 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39875action=edit Bug 14334: t/db_dependent/Auth_with_cas.t AutoCommit fix There is no easy way to trigger an obvious problem. TEST PLAN - 1) apply patch 2) git diff origin/master -- Are the additions/subtractions similar to http://paste.lisp.org/display/149194? 3) run koha qa test tools -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14334] DBI fighting DBIx over Autocommit in tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14334 --- Comment #9 from M. Tompsett mtomp...@hotmail.com --- Created attachment 39876 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39876action=edit Bug 14334: t/db_dependent/Auth_with_ldap.t AutoCommit fix There is no easy way to trigger an obvious problem. TEST PLAN - 1) apply patch 2) git diff origin/master -- Are the additions/subtractions similar to http://paste.lisp.org/display/149194? 3) run koha qa test tools -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12478] Elasticsearch support for Koha
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #60 from Robin Sheat ro...@catalyst.net.nz --- (In reply to Jonathan Druart from comment #59) Basic searching there should be working, anything else may explode or otherwise fail. Does it mean we can make you some feedbacks or you know where bugs are? :) Feedback is welcome :) I'll add things to my todo list. (for instance a search result for harry sorted by author az is not the reverse of author za. Strictly speaking, the way it does it now is the most correct. But what I'm probably going to do based on this thread: https://lists.katipo.co.nz/pipermail/koha/2015-May/042746.html is have it sort only on the 1x0$a (primary author) field. However I need to figure out a way to try to be as consistent as possible with that, as it causes a problem in that now author search will use a different field than author sort. Hmm, I wonder if I can add named sort fields to my database mapping sorta like I do with facets... The more link does not do anything.) I assume you mean the more link on facets? Yeah, that's known. It's because it's not currently truncating the list to 5 or whatever the default is. I don't think that's on my todo list though, I should add it... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14334] DBI fighting DBIx over Autocommit in tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14334 --- Comment #10 from M. Tompsett mtomp...@hotmail.com --- Created attachment 39877 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39877action=edit Bug 14334: t/db_dependent/AuthoritiesMarc.t AutoCommit fix There is no easy way to trigger an obvious problem. TEST PLAN - 1) apply patch 2) git diff origin/master -- Are the additions/subtractions similar to http://paste.lisp.org/display/149194? 3) run koha qa test tools -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14334] DBI fighting DBIx over Autocommit in tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14334 --- Comment #7 from M. Tompsett mtomp...@hotmail.com --- t/db_dependent/Auth.t seems to only read from the DB. I think the removal of the dbh code in the test file is the correct solution, and add a comment about how to do AutoCommit = 0 stuff if a test needs to write. Thoughts? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14334] DBI fighting DBIx over Autocommit in tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14334 Indranil Das Gupta indr...@gmail.com changed: What|Removed |Added CC||indr...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10020] Remove old code related to 'ethnicity'
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10020 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Status|Passed QA |Failed QA --- Comment #15 from Tomás Cohen Arazi tomasco...@gmail.com --- I agree with Galen here: I think we need to create extended patron attributes for storing this. It can be linked to an authorized value category or not, but I don't think we should leave cruft on the database (even with a warning message: the users will read it, but won't be capable of doing anything). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14333] New: Update MARC21 frameworks to Update No. 20 (April 2015)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14333 Bug ID: 14333 Summary: Update MARC21 frameworks to Update No. 20 (April 2015) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Cataloging Assignee: gmcha...@gmail.com Reporter: bgkrie...@gmail.com QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl New update: few new subfields and one new field (884) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14333] Update MARC21 frameworks to Update No. 20 (April 2015)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14333 Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed: What|Removed |Added Assignee|gmcha...@gmail.com |bgkrie...@gmail.com Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14334] DBI fighting DBIx over Autocommit in tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14334 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14334] DBI fighting DBIx over Autocommit in tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14334 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14334] DBI fighting DBIx over Autocommit in tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14334 --- Comment #3 from M. Tompsett mtomp...@hotmail.com --- Created attachment 39872 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39872action=edit Bug 14334: t/db_dependent/Budgets.t AutoCommit fix TEST PLAN -- 1) git reset --hard origin/master 2) prove t/db_dependent/Budgets.t -- horrible failure about transaction 3) apply this patch 4) prove t/db_dependent/Budgets.t -- no issues 5) koha qa test tools. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14334] DBI fighting DBIx over Autocommit in tests
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14334 --- Comment #4 from M. Tompsett mtomp...@hotmail.com --- Created attachment 39873 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39873action=edit Bug 14334: t/db_dependent/Letters.t AutoCommit fix TEST PLAN -- 1) git reset --hard origin/master 2) prove t/db_dependent/Letters.t -- horrible failure about transaction 3) apply this patch 4) prove t/db_dependent/Letters.t -- no issues 5) koha qa test tools. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11190] sitemap.pl -- Generate a Catalog sitemap
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11190 --- Comment #39 from Frédéric Demians frede...@tamil.fr --- (In reply to Jonathan Druart from comment #38) Frédéric, Could you please provide tests Do you mean more tests than the minimalist t/Sitemapper.t? and add the new deps to C4/Installer/PerlDependencies.pm? Which one other than Moo XML::Writer? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14332] Skip title articles on Opac using ind2 of tag 245 (MARC21 only)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14332 --- Comment #1 from Zeno Tajoli z.taj...@cineca.it --- Created attachment 39870 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39870action=edit skip article (only marc21) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14332] Skip title articles on Opac using ind2 of tag 245 (MARC21 only)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14332 Zeno Tajoli z.taj...@cineca.it changed: What|Removed |Added Status|ASSIGNED|In Discussion --- Comment #2 from Zeno Tajoli z.taj...@cineca.it --- My proposal to fix the problem -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11190] sitemap.pl -- Generate a Catalog sitemap
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11190 --- Comment #40 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to Frédéric Demians from comment #39) (In reply to Jonathan Druart from comment #38) Frédéric, Could you please provide tests Do you mean more tests than the minimalist t/Sitemapper.t? Yes, if possible. and add the new deps to C4/Installer/PerlDependencies.pm? Which one other than Moo XML::Writer? Oops, sorry I missed it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5010] Fix OPACBaseURL to include protocol
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5010 --- Comment #110 from M. Tompsett mtomp...@hotmail.com --- (In reply to Tomás Cohen Arazi from comment #109) Patches pushed to master. Thanks Mark and everyone involved in QA, this one has been a big effort for everyone involved! *whew* with Bug 13967 getting pushed, I was worried I'd need to rebase this. :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14252] Make the OPAC language switcher available in the masthead navbar, footer, or both.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14252
--- Comment #61 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 39858
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39858action=edit
Bug 14252: (followup) fix lang chooser for sublanguages
This quick fix disables sublanguages dropdown,
show all sublanguages on same level.
To test:
1) Apply both patches
2) Translate to have sublanguages (en-NZ, de-DE, de-CH)
3) Go to opac, confirm you can select any lang/sublang
4) Check on movil device
4th version.
Removed rfc4646 subtag on sublanguages, think it's cleaner.
Currently on master all translated languages/regions have
valid description ('en' at least)
Added language sort using rfc4646 subtag
Signed-off-by: Indranil Das Gupta indr...@gmail.com
Followup fixes the issue with lang group dropdowns. Works well
across standard desktop as well as mobile device with small screens
(checked on 4.3 / 4.7 / 5)
Works as expected.
Signed-off-by: Marc Véron ve...@veron.ch
Signed-off-by: Mark Tompsett mtomp...@hotmail.com
Signed-off-by: Jonathan Druart jonathan.dru...@koha-community.org
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14252] Make the OPAC language switcher available in the masthead navbar, footer, or both.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14252 --- Comment #67 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 39864 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39864action=edit Bug 14252: Add sort by rfc4646_subtag in footer This patch sort by rfc4646_subtag the languages in the footer. Same as in the header. Signed-off-by: Jonathan Druart jonathan.dru...@koha-community.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14142] Holds queue viewer only displays first subtitle from marc keyword mappings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14142 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added CC||tomasco...@gmail.com Status|Passed QA |Pushed to Master --- Comment #5 from Tomás Cohen Arazi tomasco...@gmail.com --- Patch pushed to master. Thanks Kyle! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13815] plack loose CGI qw(-utf8) flag creating incorrect utf-8 encoding everywhere
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13815 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||tomasco...@gmail.com --- Comment #8 from Tomás Cohen Arazi tomasco...@gmail.com --- Patch pushed to master. Thanks Dobrica! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14330] Remove unused email_sender from sendbasket/sendshelf
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14330 Marc Véron ve...@veron.ch changed: What|Removed |Added CC||ve...@veron.ch Attachment #39844|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14330] Remove unused email_sender from sendbasket/sendshelf
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14330 --- Comment #2 from Marc Véron ve...@veron.ch --- Created attachment 39867 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39867action=edit [Signed-off] Bug 14330: Remove unused email_sender from sendbasket/sendshelf The sendbasket/sendshelf scripts and templates do not use email_sender as a cgi parameter or as a template var. Probably a leftover from previous changes. Let's make Koha cleaner :) Test plan: [1] Send your cart from opac or staff. [2] Send a shelf from opac or staff. [3] Git grep email_sender. No results. Followed test plan. Works as expected. Signed-off-by: Marc Véron ve...@veron.ch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14029] Provide link to clear reports search filters
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14029 --- Comment #8 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 39866 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39866action=edit [COUNTER-PATCH] Bug 14029: Provide 'clear' link to empty Patch adds a 'clear' link next to the 'Apply filters' button to empty out the form fields. To test: - go to the reports module - make sure you have some saved reports - search your saved reports using the author, keyword and date filters - verify searching works as expected - verify the new 'clear' link works as expected -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14029] Provide link to clear reports search filters
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14029 --- Comment #9 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to Marc Véron from comment #7) Created attachment 39856 [details] [review] [PATCH FOR TESTING] Bug 14029 Try to clear filter and reload page using a link only (comment #6) Ha yes, the filters are stored in the session! What about my counter-patch? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14029] Provide link to clear reports search filters
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14029 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14331] Order Records from staged file missing option to choose currency to use
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14331 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Version|3.18|master CC||katrin.fisc...@bsz-bw.de Summary|Order Records from staged |Order Records from staged |file|file missing option to ||choose currency to use -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14024] Add reports to action logs
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14024 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added CC||tomasco...@gmail.com Summary|add reports to action logs |Add reports to action logs -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14024] Add reports to action logs
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14024 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #18 from Tomás Cohen Arazi tomasco...@gmail.com --- Enhancement pushed to master. Thanks Marc! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14252] Make the OPAC language switcher available in the masthead navbar, footer, or both.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14252 --- Comment #63 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 39860 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39860action=edit Bug 14252: (Followup) Fixed issues pointed to in comment #40 Based on Mark's inputs in comment #40 - [1] selected 'mast' (short of 'masthead') and updated : (a) bug_14252-OpacLangSelectorMode_syspref.sql (b) sysprefs.sql (c) opac.pref [2] Reduced the calls to Koha.Preference() from : (a) masthead.inc (b) opac-bottom.inc After applying this patch, update the database once for it to pick up the new option values -'both|mast|foot'. Signed-off-by: Mark Tompsett mtomp...@hotmail.com Signed-off-by: Jonathan Druart jonathan.dru...@koha-community.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14252] Make the OPAC language switcher available in the masthead navbar, footer, or both.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14252 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #39728|0 |1 is obsolete|| Attachment #39729|0 |1 is obsolete|| Attachment #39730|0 |1 is obsolete|| Attachment #39731|0 |1 is obsolete|| Attachment #39732|0 |1 is obsolete|| Attachment #39734|0 |1 is obsolete|| Attachment #39749|0 |1 is obsolete|| --- Comment #60 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 39857 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39857action=edit Bug 14252 - Move OPAC lang switcher to masthead navbar The OPAC language switcher takes up a lot of space at the bottom of the browser. It also has issues of being not always visible. This patch adds the switcher to the masthead navbar and removes from the opac-bottom.inc navbar. Test plan = 1/ Apply patch 2/ Set opaclanguagesdisplay syspref to 'show'. 3/ Add a few languages i.e. es-ES, fr-FR and de-DE $ cd misc/translator $ perl translate langcode 4/ Enable installed languages for OPAC use by checking on 'opaclanguages' under I18N/L10N sysprefs 5/ Go to the OPAC, you should have a Languages dropdown on the masthead navbar, the opac-bottom.inc navbar should no longer be there. Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com Works, no koha-qa errors. Followup fix language chooser for sublanguages Signed-off-by: Mark Tompsett mtomp...@hotmail.com Signed-off-by: Jonathan Druart jonathan.dru...@koha-community.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14252] Make the OPAC language switcher available in the masthead navbar, footer, or both.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14252
--- Comment #66 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 39863
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39863action=edit
Bug 14252: (followup) addresses the QA Manager comments
Addresses Katrin's comments in comment# 56
TEST PLAN
-
1) Back up your DB
2) Ensure you have multiple languages, including
some that have sub-languages (e.g. de-DE, de-CH)
-- cd misc/translator
-- perl translate install {language code}
3) Ensure that you have all the languages enabled
-- Staff client - Home - Global system preferences
-- I18N/L10N
Check all the languages in opaclanguages.
Ensure that opaclanguagesdisplay is 'Allow'
4) Open OPAC
-- should only have languages in footer.
Annoyingly below the fold.
5) Drop your koha database, and create a blank one.
6) Apply all patches
7) Reinstall all the known languages, so the templates
are appropriately updated.
8) Go to staff client and do an install of koha, with
all the dummy data.
9) Ensure you have all the languages enabled (see (3))
10) Refresh your OPAC page
-- language selector position should be in both
the footer and at the top as expected.
-- this confirms the sysprefs.sql change.
11) Restore your DB
12) run the updatedatabase.pl script
13) Ensure you have all the languages enabled (see (3))
14) Refresh the OPAC page
-- should still only have languages in the footer.
-- this confirms that upgrade won't change anything.
-- this confirms the atomic update.
15) git diff origin/master
-- the opac-bottom.inc difference should only
have changes around a SET, IF, and END.
This confirms the noprint was fixed.
16) In the staff client, change the OPAC system preference,
OpacLangSelectorMode, to all three values.
For each value, refresh the OPAC page, and confirm the
position of the language selector.
-- should work as expected.
17) run koha qa test tools
NOTE: Tested as a single batch together.
Signed-off-by: Mark Tompsett mtomp...@hotmail.com
Signed-off-by: Jonathan Druart jonathan.dru...@koha-community.org
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14252] Make the OPAC language switcher available in the masthead navbar, footer, or both.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14252 --- Comment #65 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 39862 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39862action=edit Bug 14252: Follow up noprint and default values TEST PLAN - 0) Back up your DB 1) open OPAC -- should only have languages in footer. Annoyingly below the fold. 2) Drop your koha database, and create a blank one. 3) Apply all patches 4) Go to staff client and do an install of koha, with all the dummy data. 5) Once installed, refresh your OPAC page -- language selector position should be in footer still as expected. -- this confirms the sysprefs.sql change. 6) Restore your DB 7) run the updatedatabase.pl script 8) Refresh the OPAC page -- should still only have languages in the footer. -- this confirms that upgrade won't change anything. -- this confirms the atomic update. 9) git diff origin/master -- the opac-bottom.inc difference should only have changes around a SET, IF, and END. This confirms the noprint was fixed. 10) In the staff client, change the OPAC system preference, OpacLangSelectorMode, to all three values. For each value, refresh the OPAC page, and confirm the position of the language selector. -- should work as expected. 11) run koha qa test tools Signed-off-by: Mark Tompsett mtomp...@hotmail.com Signed-off-by: Indranil Das Gupta (L2C2 Technologies) indr...@gmail.com Signed-off-by: Jonathan Druart jonathan.dru...@koha-community.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13815] plack loose CGI qw(-utf8) flag creating incorrect utf-8 encoding everywhere
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13815 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #38162|0 |1 is obsolete|| --- Comment #7 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 39865 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39865action=edit Bug 13815 - plack loose CGI qw(-utf8) flag creating incorrect utf-8 encoding everywhere This is major problem for plack installations with utf-8 encoding. In this case, we are overriding CGI-new to setup utf-8 flag and get correctly decoded $cgi-params, and reset syspref cache using C4::Context-clear_syspref_cache Test scenario: 1. under plack try to search with utf-8 charactes 2. try to find patron with utf-8 characters Signed-off-by: Gaetan Boisson gaetan.bois...@biblibre.com Signed-off-by: Jonathan Druart jonathan.dru...@koha-community.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14252] Make the OPAC language switcher available in the masthead navbar, footer, or both.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14252 --- Comment #62 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 39859 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39859action=edit Bug 14252: (followup) Adds OpacLangSelectorMode syspref Based on discussion, this followup does the following: 1/ brings back the switcher on opac-bottom.inc 2/ adds a syspref OpacLangSelectorMode to toggle between the three modes: (a) show switcher both on masthead and footer (default) (b) footer only (b) masthead only Test plan = 1/ apply earlier patches attached to this bug in their correct order 2/ apply this followup patch 3/ run updatedatabase.pl to add in the atomic update 4/ goto admin/preferences.pl?tab=opac 5/ look up OpacLangSelectorMode, it should be set with default value both masthead and footer 6/ check OPAC to see if both locations show the selectors 7/ change OpacLangSelectorMode to 'only header' and 'only footer' at each iteration, and check if the selection has correctly toggled the selectors. It should Note: make sure you do not have the patch 11057 applied on the branch from before, otherwise merge conflict might happen. http://bugs.koha-community.org/show_bug.cgi?id=14252 Followed test plan. Works as expected. Signed-off-by: Marc Véron ve...@veron.ch Signed-off-by: Mark Tompsett mtomp...@hotmail.com Signed-off-by: Jonathan Druart jonathan.dru...@koha-community.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14252] Make the OPAC language switcher available in the masthead navbar, footer, or both.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14252 --- Comment #64 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 39861 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39861action=edit Bug 14252: (fix) address the indentation for the lang loop tidy the indentation for that lang selector loop code. Signed-off-by: Mark Tompsett mtomp...@hotmail.com Signed-off-by: Jonathan Druart jonathan.dru...@koha-community.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14331] New: Order Records from staged file
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14331 Bug ID: 14331 Summary: Order Records from staged file Change sponsored?: --- Product: Koha Version: 3.18 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: ed.v...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org When using the from staged file option in acquisitions to order a batch of order records from a vendor there is no currency choice. The feature automatically uses the default currency. This can be a problem when a library is ordering from a vendor that is using different currency than the libraries default because what is recorded against the fund/budget is the default value and this would be incorrect due to exchange rates. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14332] Skip title articles on Opac using ind2 of tag 245 (MARC21 only)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14332 Zeno Tajoli z.taj...@cineca.it changed: What|Removed |Added Assignee|gmcha...@gmail.com |z.taj...@cineca.it -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14332] New: Skip title articles on Opac using ind2 of tag 245 (MARC21 only)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14332 Bug ID: 14332 Summary: Skip title articles on Opac using ind2 of tag 245 (MARC21 only) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: gmcha...@gmail.com Reporter: z.taj...@cineca.it QA Contact: testo...@bugs.koha-community.org With specific setup of Zebra is possible to skip articles of titles only on sorting. In MARC21 we can use indicator n. 2 of field 245. There suggestion from indexdata here: http://www.indexdata.com/zebra/doc/record-model-domxml-conf.html -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14313] OPAC: Adding a comment makes result browser disappear
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14313 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added CC||tomasco...@gmail.com Status|Passed QA |Pushed to Master --- Comment #5 from Tomás Cohen Arazi tomasco...@gmail.com --- Patch pushed to master. Thanks Marc! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13815] plack loose CGI qw(-utf8) flag creating incorrect utf-8 encoding everywhere
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13815 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14269] OPAC: Small template improvements to full serial history page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14269 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||tomasco...@gmail.com --- Comment #4 from Tomás Cohen Arazi tomasco...@gmail.com --- Patch pushed to master. Thanks Katrina! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14267] How active is active in additem.tt?
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14267 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added CC||tomasco...@gmail.com Status|Passed QA |Pushed to Master --- Comment #5 from Tomás Cohen Arazi tomasco...@gmail.com --- Patch pushed to master. Thanks Marcel! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14029] Provide link to clear reports search filters
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14029 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #39866|0 |1 is obsolete|| --- Comment #10 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 39868 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39868action=edit [COUNTER-PATCH] Bug 14029: Provide 'clear' link to empty reports search filters Patch adds a 'clear' link next to the 'Apply filters' button to empty out the form fields. To test: - go to the reports module - make sure you have some saved reports - search your saved reports using the author, keyword and date filters - verify searching works as expected - verify the new 'clear' link works as expected -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14330] Remove unused email_sender from sendbasket/sendshelf
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14330 Marc Véron ve...@veron.ch changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14029] Provide link to clear reports search filters
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14029 --- Comment #7 from Marc Véron ve...@veron.ch --- Created attachment 39856 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39856action=edit [PATCH FOR TESTING] Bug 14029 Try to clear filter and reload page using a link only (comment #6) This patch follows comment #6 for testing a solution without JavaScript. It adds a link as proposed in comment #6. However filter does not change. To verify: Apply this patch only Got to saved reports Apply a filter, e.g. 'Test' for Keyword. Table reloads with filtered reports. Click Clear Result: Page reloads, but filter is still active. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13815] plack loose CGI qw(-utf8) flag creating incorrect utf-8 encoding everywhere
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13815 --- Comment #9 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to Gaetan Boisson from comment #6) Works and solved a large number of issues for us! Is the syspref cache clearing also involved in encoding problems? Actually you are right, this should not be done here. We should remove this call. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14252] Make the OPAC language switcher available in the masthead navbar, footer, or both.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14252 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14029] Provide link to clear reports search filters
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14029 Marc Véron ve...@veron.ch changed: What|Removed |Added Attachment #39856|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14029] Provide link to clear reports search filters
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14029 Marc Véron ve...@veron.ch changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14029] Provide link to clear reports search filters
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14029 Marc Véron ve...@veron.ch changed: What|Removed |Added Attachment #39868|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13967] System preferences need a package
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13967 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #28 from Tomás Cohen Arazi tomasco...@gmail.com --- Enhancement pushed to master. Thanks Kyle and Jonathan! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14029] Provide link to clear reports search filters
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14029 Marc Véron ve...@veron.ch changed: What|Removed |Added Attachment #39736|0 |1 is obsolete|| --- Comment #11 from Marc Véron ve...@veron.ch --- Created attachment 39869 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39869action=edit [Signed-off] Bug 14029: Provide 'clear' link to empty reports search filters Patch adds a 'clear' link next to the 'Apply filters' button to empty out the form fields. To test: - go to the reports module - make sure you have some saved reports - search your saved reports using the author, keyword and date filters - verify searching works as expected - verify the new 'clear' link works as expected Tested couner patch, followed test plan, works as expected. QA tools ok. Signed-off-by: Marc Véron ve...@veron.ch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14332] Skip title articles on Opac using ind2 of tag 245 (MARC21 only)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14332 Zeno Tajoli z.taj...@cineca.it changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12478] Elasticsearch support for Koha
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 Josef Moravec josef.mora...@gmail.com changed: What|Removed |Added CC||josef.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14327] Fix js error TypeError: events is null in additem.js
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14327 Marcel de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=10480 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10480] Improvements for framework plugins in cataloguing/item editor
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10480 Marcel de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=14327 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10480] Improvements for framework plugins in cataloguing/item editor
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10480
--- Comment #54 from Marcel de Rooy m.de.r...@rijksmuseum.nl ---
(In reply to Jonathan Druart from comment #53)
I found a bug:
1/ Open the console
2/ Go on the new order page
3/ TypeError: events is null
for(i=0; ievents.length; i++) {
additem.js (ligne 176, col. 13)
I suppose it happens when none of the fields use a plugin
Thanks for reporting. See bug 14327.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14327] Fix js error TypeError: events is null in additem.js
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14327 Marcel de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added CC||jonathan.dru...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14327] Fix js error TypeError: events is null in additem.js
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14327 Marcel de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Assignee|gmcha...@gmail.com |m.de.r...@rijksmuseum.nl Patch complexity|--- |Trivial patch Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14327] New: Fix js error TypeError: events is null in additem.js
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14327
Bug ID: 14327
Summary: Fix js error TypeError: events is null in additem.js
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: minor
Priority: P5 - low
Component: Cataloging
Assignee: gmcha...@gmail.com
Reporter: m.de.r...@rijksmuseum.nl
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl
As reported by Jonathan on report 10480:
I found a bug:
1/ Open the console
2/ Go on the new order page
3/ TypeError: events is null
for(i=0; ievents.length; i++) {
additem.js (ligne 176, col. 13)
I suppose it happens when none of the fields use a plugin.
Patch forthcoming.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14327] Fix js error TypeError: events is null in additem.js
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14327 --- Comment #1 from Marcel de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 39832 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39832action=edit Bug 14327: Fix js error TypeError: events is null in additem.js If you have no item plugins, the events variable in BindPluginEvents of additem.js will be null. So testing events.length will generate the described error. This patch adds a check to prevent that from happening again. Test plan: [1] Do not yet apply this patch ! [2] Temporarily remove framework plugins from your items (in ACQ or default framework). Probably you have to clear dateaccessioned.pl and barcode.pl. [3] Open js console in your browser. [4] Go to Acquisition. Open a basket and add an order from a new empty record. [5] You should see js error: TypeError: events is null (additem.js:176) [6] Apply this patch and reload the page (make sure that you refresh so that the new javascript code is read). [7] The TypeError should be gone. [8] Restore the framework plugins from step 2. Refresh the page again and verify that they still work as expected. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14327] Fix js error TypeError: events is null in additem.js
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14327 Marcel de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14325] Test calls C4::Context::set_userenv
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14325 Marcel de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl Attachment #39826|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14325] Test calls C4::Context::set_userenv
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14325 Marcel de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14325] Test calls C4::Context::set_userenv
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14325 Marcel de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14325] Test calls C4::Context::set_userenv
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14325 Marcel de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Attachment #39828|0 |1 is obsolete|| --- Comment #3 from Marcel de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 39833 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39833action=edit Bug 14325: Test calls C4::Context::set_userenv This is a case of works by accident. This patch corrects the set_userenv call. TEST PLAN - 1) prove t/db_dependent/Borrower_Discharge.t -- works 2) git grep :set_userenv -- only this one file. 3) Confirm the the C4/Context.pm has a set_userenv which shifts the first parameter, as intended for a - call and not a :: call. 4) apply patch 5) prove t/db_dependent/Borrower_Discharge.t -- still works 6) git grep :set_userenv -- nothing now. 7) run koha qa test tools Signed-off-by: Indranil Das Gupta (L2C2 Technologies) indr...@gmail.com Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14256] Tests for TestBuilder fail randomly
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14256
--- Comment #17 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 39836
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39836action=edit
Bug 14256: (follow-up) Check for unique constraint to regenerate random data
There were some issues in the previous patch. This patch fixes the
following:
- rename $value with $original_value
- remove $at_least_one_constraint_failed and $values_ok which make the
code unnecessarily complicated
- the constraints have to be checked only if no original value is passed
- _buildColumnValue created a key to the default value hashref, it broke
the test:
last BUILD_VALUE if exists( $default_value-{$source} );
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14256] Tests for TestBuilder fail randomly
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14256 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #39788|0 |1 is obsolete|| Attachment #39825|0 |1 is obsolete|| --- Comment #16 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 39835 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39835action=edit Bug 14256: Check for unique constraint to regenerate random data Unique constraints should be checked when creating random data. Otherwise we get failures when the generated data already exists on the DB. This patch takes advantage of -unique_constraints() to do the job, looping through all the unique constraints defined for the source. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13881] Add desk management
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13881 --- Comment #4 from Nicolas Legrand nicolas.legr...@bulac.fr --- Created attachment 39837 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39837action=edit Bug 13881: Select desk in an intranet session the selected Desk appears in the header. The desk can be selecting in the menu beside username, branchname. Test plan : 1/ Go to the intranet administration, remove all desks if you have any. The desks should not appear in the header. 2/ add some desks in administration, without selecting some. The message « NO DESK SET » should appear at the left of the branchname. 3/ set a desk for your session. The desk deskcode should appear beside the branchname. 4/ change desk, the new name should appear also. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14024] add reports to action logs
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14024 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14024] add reports to action logs
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14024 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #38420|0 |1 is obsolete|| Attachment #38421|0 |1 is obsolete|| --- Comment #15 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 39841 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39841action=edit Bug 14024 - add reports to action logs This patch sets adds the possibility to log new, update and delete actions for saved reports. To test: -Apply patch -Run updatedatabase.pl -Enable system preference ReportsLog -Create, duplicate, edit and delete saved reports -Go to Home Tools Logs -Verify that you can select Reports in Modules list -Verify that your actions were logged Signed-off-by: Nicole Engard neng...@bywatersolutions.com Signed-off-by: Nicole Engard neng...@bywatersolutions.com Signed-off-by: Jonathan Druart jonathan.dru...@koha-community.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14024] add reports to action logs
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14024 --- Comment #16 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 39842 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39842action=edit Bug 14024 - add reports to action logs See QA comment #5 - new reports log their Id instead of 0 - format info: name | sql Signed-off-by: Nicole Engard neng...@bywatersolutions.com Signed-off-by: Jonathan Druart jonathan.dru...@koha-community.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598 --- Comment #44 from Jonathan Druart jonathan.dru...@biblibre.com --- Kyle, Would you mind if I squash the patches? Don't you think it would make more sense to have Koha::Import::Patrons instead of Koha::Patrons::Import? I can imagine easily a Koha::Import module with some useful subroutines to import some kind of stuffs. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13382] RDA: 700/710/711 display in XSLT
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13382 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13382] RDA: 700/710/711 display in XSLT
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13382 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #38501|0 |1 is obsolete|| --- Comment #43 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 39843 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39843action=edit [PASSED QA] Bug 13382 - RDA: 700/710/711 display in XSLT Test Plan: 1) Apply this patch 2) Ensure you are using the default XSLT setting for the staff and opac record details 3) Find or create a record with MARC tags 700,710,711 4) Perform an opac search that would show the record in the search results. 5) Click title to review record. 6) Note the fields updates 700,710,711 to show subfields a, b, c, d, e, f, g, h, i, k, l, m, n, o, p, r, s, t, u, x. Multiple fields are separated by span class=separator |. Adds Related and Contained Works as new headings. 7) Repeat steps 4 - 6 for the staff interface Signed-off-by: Nick Clemens n...@quecheelibrary.org Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14142] Holds queue viewer only displays first subtitle from marc keyword mappings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14142 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com |ity.org | CC||jonathan.dru...@biblibre.co ||m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14269] OPAC: Small template improvements to full serial history page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14269 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #39690|0 |1 is obsolete|| --- Comment #3 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 39846 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39846action=edit Bug 14269: OPAC: Some template improvements for the full serial history page - Fix filter labels: Library : - Library: Subscription : - Subscription: - Make '(All)' entry in filter pull downs translatable - Show branch name instead of branchcode in table and filter To test: - Verify changes as described above - Verify filters still work as expected Followed test plan. Works as expected. Signed-off-by: Marc Véron ve...@veron.ch Signed-off-by: Jonathan Druart jonathan.dru...@koha-community.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14024] add reports to action logs
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14024 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added CC||jonathan.dru...@biblibre.co ||m --- Comment #17 from Jonathan Druart jonathan.dru...@biblibre.com --- It would be good to track the executed reports, don't you think? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14330] New: Remove unused email_sender from sendbasket/sendshelf
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14330 Bug ID: 14330 Summary: Remove unused email_sender from sendbasket/sendshelf Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: m.de.r...@rijksmuseum.nl QA Contact: testo...@bugs.koha-community.org The sendbasket/sendshelf scripts and templates do not use email_sender as a cgi parameter or as a template var. Probably a leftover from previous changes. Let's make Koha cleaner :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14330] Remove unused email_sender from sendbasket/sendshelf
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14330 Marcel de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Assignee|oleon...@myacpl.org |m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14330] Remove unused email_sender from sendbasket/sendshelf
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14330 Marcel de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14142] Holds queue viewer only displays first subtitle from marc keyword mappings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14142 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #39809|0 |1 is obsolete|| --- Comment #4 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 39845 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39845action=edit Bug 14142 - Holds queue viewer only displays first subtitle from marc keyword mappings Despite the point of the Keyword to MARC Mappings being to simplify the handling and display of repeated values from multiple subfields, the holds queue viewer will only display the first value found. What it should be doing instead is displaying all fields that match the subtitle keyword. Test Plan: 1) Apply this patch 2) Define multiple Keyword to MARC mappings for the subtitle keyword 3) Place a hold on a record using those subtitle fields 4) View the hold in the holds queue viewer 5) Note that all the subtitles now appear Signed-off-by:Heather Braum hbr...@nekls.org Signed-off-by: Jonathan Druart jonathan.dru...@koha-community.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14330] Remove unused email_sender from sendbasket/sendshelf
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14330 --- Comment #1 from Marcel de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 39844 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39844action=edit Bug 14330: Remove unused email_sender from sendbasket/sendshelf The sendbasket/sendshelf scripts and templates do not use email_sender as a cgi parameter or as a template var. Probably a leftover from previous changes. Let's make Koha cleaner :) Test plan: [1] Send your cart from opac or staff. [2] Send a shelf from opac or staff. [3] Git grep email_sender. No results. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14142] Holds queue viewer only displays first subtitle from marc keyword mappings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14142 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
