[Koha-bugs] [Bug 10067] decreaseLoanHighHolds messes with specify due date
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067 --- Comment #13 from Eivin Giske Skaaren --- Obviuously I am rather new to Koha but I actually thought it was the other way. Since you have the "Remember for session" checkbox and also probably a default due date in the system (perhaps even on item level? have not checked/can not remember right now) I found it strange that the value was not cleared. Do we want the default behavior to be that the value is cleared only when the due date is shortened? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12252] OAI-PMH GetRecord result doesn't include item data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12252 --- Comment #45 from Jonathan Druart --- (In reply to Tomás Cohen Arazi from comment #43) > I definitely think this might not be a feature for some institutions and we > should make it opt-in. Because as Galen mentioned, it is not obvious that > everyone will want to include items data. I am pretty sure it's a bug and a regression introduced by bug 5579. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10020] Remove old code related to 'ethnicity'
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10020 --- Comment #18 from Jonathan Druart --- (In reply to Jonathan Druart from comment #16) > The patch removes the tables/fields if data exist (which is certainly not > the case), or leave them. Hum, trying again... The patch removes the tables/fields when they don't contain any data (which is certainly the case) or keep them if they are not empty. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14388] add sorting to funds
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14388 Jonathan Druart changed: What|Removed |Added Attachment #40765|0 |1 is obsolete|| --- Comment #4 from Jonathan Druart --- Created attachment 40855 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40855&action=edit Bug 14388: Funds should be sorted by budget_code Before this patch, the funds were sorted by budget_id, which does not make any sense. This patch adds a sort by budget_code on the fund list (acqui/acqui-home.pl and admin/aqbudgets.pl) Test plan: On both pages (acqui/acqui-home.pl and admin/aqbudgets.pl) confirm that the funds are now sorted by fund code (DB column budget_code) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14388] add sorting to funds
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14388 --- Comment #5 from Jonathan Druart --- (In reply to M. Tompsett from comment #2) > second child, not first. Please fix typo. Fixed, thanks (In reply to M. Tompsett from comment #3) > I was not able to duplicate issue with Debian Jessie on Master. Though, this > patch clearly forces sorting. They are currently sorted by budget_id. > Additionally, tests failed to run with my initial data set. Requires CPL. Which is the case for almost all tests. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14445] Noisy warns in Notices (letter.tt) module
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14445 Jonathan Druart changed: What|Removed |Added Attachment #40545|0 |1 is obsolete|| Attachment #40743|0 |1 is obsolete|| --- Comment #7 from Jonathan Druart --- Created attachment 40856 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40856&action=edit Bug 14445: Silences warn in letter.pl When changing Koha module to 'Circulation', there is a warn saying that $code is uninitialized. This patch sets $code to an empty string to silence the warn. To test: 1) Go to Tools, the Notices & Slips 2) Click 'new notice' (This will trigger warns, but ignore these as they will be corrected in the next patch) 3) Change Koha module to 'Circulation' 4) Notice warn about uninitialized $code variable 5) Apply patch and reload page, change Koha module to 'Circulation' 6) Notice page still works and warns are gone Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14445] Noisy warns in Notices (letter.tt) module
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14445 --- Comment #8 from Jonathan Druart --- Created attachment 40857 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40857&action=edit Bug 14445: Silences warns in letter.tt When creating a new notice, warn is triggered "Argument "" isn't numeric in numeric gt (>) at line 400". Same warn is triggered when changing Koha module option to any other module. To test: 1) Go to Tools, then Notices & Slips 2) Click 'new notice'. Notice warn in intranet-error.log 3) Change Koha module to another module. Notice warn is triggered for every change 4) Apply patch and reload page 5) Change Koha module to another module. Notice there are no longer warns 6) Go back to Notices & Slips and click 'new notice' again. Notice there are no warns Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14445] Noisy warns in Notices (letter.tt) module
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14445 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14445] Noisy warns in Notices (letter.tt) module
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14445 --- Comment #9 from Jonathan Druart --- (In reply to Aleisha Amohia from comment #6) > (In reply to Jonathan Druart from comment #5) > > > > This is wrong, we want to display the length of the content. > > With your patch, the string displayed is always > >"Message body: 0/160 characters" > > Hi Jonathan, this tests correctly for me, but do you know a better way to > silence this warn? You should have used letter.content.length. I have amended your 2 patches, please have a look. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14485] HTML comment disables translation in cataloguing/addbooks.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14485 Jonathan Druart changed: What|Removed |Added Attachment #40789|0 |1 is obsolete|| --- Comment #7 from Jonathan Druart --- Created attachment 40858 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40858&action=edit Bug 14485 - HTML comment disables translation in cataloguing/addbooks.tt In cataloguing/addbooks.tt, the line : [% total %] result(s) found in catalog, is not present in PO files even after an update. I've found that the cause is the previous HTML comment line. This patch converts HTML comment into TT comment and adds a div to have a more comprehensive string to translate. Test plan : - without patch - go into /misc/translator - run PO update for example in french : translate update fr-FR => the text "result(s) found in catalog" is missing from PO file : fr-FR-staff-prog.po - restore default PO files - apply patch - go into /misc/translator - run PO update for example in french : translate update fr-FR => You find text "result(s) found in catalog" in PO file : fr-FR-staff-prog.po Sponsored-by: Universidad de El Salvador Signed-off-by: Hector Eduardo Castro Avalos Works as advertised. Just one msgid appear with msgid "%s result(s) found in catalog," Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14485] HTML comment disables translation in cataloguing/addbooks.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14485 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14494] Terribly slow checkout caused by DateTime->new in far future
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14494 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@biblibre.co ||m Assignee|gmcha...@gmail.com |jonathan.dru...@biblibre.co ||m Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14197] Warning raised by TestBuilder
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14197 --- Comment #2 from Jonathan Druart --- Created attachment 40859 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40859&action=edit Bug 14197: TestBuilder - Remove the error on starting the transaction DBD::mysql::db begin_work failed: Already in a transaction at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1560. DBIx::Class::Storage::DBI::txn_rollback(): Storage transaction_depth 0 does not match false AutoCommit of DBI::db=HASH(0xa429648), attempting ROLLBACK anyway at t/lib/TestBuilder.pm line 363 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10067] decreaseLoanHighHolds messes with specify due date
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067 Chris Cormack changed: What|Removed |Added CC||ch...@bigballofwax.co.nz --- Comment #14 from Chris Cormack --- The rule for developing on Koha is that we don't change behaviour that people will have been using for years. (The specify due date feature is about 8 years old, so suddenly changing the way it works will most definitely catch some people out) The reason we have this rule is so people won't be scared to upgrade (it's also the rule why new features go in switched off by default on upgrade) Hope this makes sense -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14494] Terribly slow checkout caused by DateTime->new in far future
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14494 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14494] Terribly slow checkout caused by DateTime->new in far future
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14494 --- Comment #1 from Jonathan Druart --- Created attachment 40860 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40860&action=edit Bug 14494: Prevent slow checkout if the patron does not have an expiry date If a patron has a expiry date set to -12-31 (for organizations for instance), the checkouts are very slow. It's caused by 2 different calls to DateTime in CanBookBeIssued: 1/ DateTime->new( year => , month => 12, day => 31, time_zone => C4::Context->tz ); The time_zone should not be set (as it's done in Koha::DateUtils), set to UTC or floating tz. 2/ DateTime->compare($today, $expiry_dt) The comparaison of 2 DT with 1 related to is very slow, as you can imagine. For 1/ we need to call Koha::DateUtils::dt_from_string (actually, we should never call DateTime directly). For 2/ we just need to test if the date is != , no need to compare it in this case. Test plan: Before this patch, confirm that the checkouts are slow if the patron has a dateexpiry set to -12-31. update borrowers set dateexpiry="-12-31" where borrowernumber=42; After this patch, you should not see any regression when checking out items to an expired patron and to a valid patron. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14494] Terribly slow checkout caused by DateTime->new in far future
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14494 Jonathan Druart changed: What|Removed |Added Blocks||14197 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14197] Warning raised by TestBuilder
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14197 Jonathan Druart changed: What|Removed |Added Depends on||14494 --- Comment #3 from Jonathan Druart --- (In reply to Jonathan Druart from comment #1) > To see the warning see patches on bug 14045. And the errors with the patch on bug 14494. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14197] Warning raised by TestBuilder
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14197 Jonathan Druart changed: What|Removed |Added Blocks||14494 Depends on|14494 | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14494] Terribly slow checkout caused by DateTime->new in far future
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14494 Jonathan Druart changed: What|Removed |Added Blocks|14197 | Depends on||14197 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14494] Terribly slow checkout caused by DateTime->new in far future
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14494 --- Comment #2 from Katrin Fischer --- Hm, I feel a bit like this builds in a secret feature - if I use 9998 it will be slow, but if I use it will be faster? When we fixed the same thing for debarments it made more sense, as the 'ulimited' debarment uses automatically, without the user entering a date. For the patron expiry the date is defined by the library and could be anything. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14494] Terribly slow checkout caused by DateTime->new in far future
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14494 --- Comment #3 from Jonathan Druart --- (In reply to Katrin Fischer from comment #2) > Hm, I feel a bit like this builds in a secret feature - if I use 9998 it > will be slow, but if I use it will be faster? > > When we fixed the same thing for debarments it made more sense, as the > 'ulimited' debarment uses automatically, without the user entering a > date. For the patron expiry the date is defined by the library and could be > anything. As I understood the description, the feature has existed. Anyway we should call Koha::DateUtils here and not directly DateTime. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14494] Terribly slow checkout caused by DateTime->new in far future
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14494 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #4 from Katrin Fischer --- I don't think it's a feature - it has to be typed in manually in the configuration. I think it would make sense to me if we introduced an option to have an 'unlimited' expiry date in the GUI - then the check on would make more sense to me. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14404] Checkouts default sort order for Self Checkout (SCO) confusing for patrons
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14404 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14404] Checkouts default sort order for Self Checkout (SCO) confusing for patrons
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14404 --- Comment #6 from Jonathan Druart --- Created attachment 40862 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40862&action=edit Bug 14404: Rename class no-show to noshow for consistency with nosort Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14404] Checkouts default sort order for Self Checkout (SCO) confusing for patrons
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14404 --- Comment #7 from Jonathan Druart --- (In reply to Kyle M Hall from comment #4) > Created attachment 40832 [details] [review] > Bug 14404 [QA Followup] - Rename class nosort to no-sort for readability and > consistency I am against this patch, the "nosort" already exists in other places. Tomas, either 1/ you push my patch to get consistency between nosort (existented before this patch and in other places) or 2/ don't push it for readability and we will need to fix the existent occurrences of nosort. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14404] Checkouts default sort order for Self Checkout (SCO) confusing for patrons
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14404 Jonathan Druart changed: What|Removed |Added Attachment #40249|0 |1 is obsolete|| Attachment #40832|0 |1 is obsolete|| --- Comment #5 from Jonathan Druart --- Created attachment 40861 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40861&action=edit Bug 14404 - Checkouts default sort order for Self Checkout (SCO) confusing for patrons Libraries are reporting that patrons are very confused during self-checkout. The problem is they are expecting the list of checkouts to be in the order they checked out the items ( first checkout on the bottom, last item checked out on top ). However, the checkouts table is sorted by title ( ascending ) then due date ( descending ). This is not intuitive. Test Plan: 1) Enable Koha's self checkout 2) Use the SCO to check out a random assortment of items, make sure you don't check them out in alphabetical order 3) Note the order of the items in the list is not based on the order you checked them out in 4) Apply this patch 5) Refresh the page 6) Note the items are now in the order you checked them out with the last on top and the first on bottom Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14027] Add TableTools plugin for DataTables
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14027 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Status|Signed Off |BLOCKED --- Comment #6 from Katrin Fischer --- I think pushing this without it being use makes no sense - there is a dependency on 6427 - marking this blocked for now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14424] Update Help Files for 3.20
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14424 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14424] Update Help Files for 3.20
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14424 --- Comment #27 from Jonathan Druart --- Created attachment 40865 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40865&action=edit Bug 14424: Update Discharge Help for 3.20 This patch adds the missing discharge help file and updates the moremember file with info on discharges. To test: * Visit a patron * View and confirm help is right * Visit the discharge page on the patron * Confirm help file loads and is right Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14424] Update Help Files for 3.20
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14424 --- Comment #26 from Jonathan Druart --- Created attachment 40864 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40864&action=edit Bug 14424: Update cataloging help for 3.20 This patch updates 3 help files for catalolging in 3.20 To test: * Visit * cataloging home * cataloging a new record * mergin bib records * Confirm text is right and visible Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14424] Update Help Files for 3.20
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14424 --- Comment #28 from Jonathan Druart --- Created attachment 40866 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40866&action=edit Bug 14424: Update Acq Help for 3.20 This patch adds the missing order from subscription help and updates basket help. To test: * Visit a basket, review the help * Click order from a subscrption, review the help Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14424] Update Help Files for 3.20
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14424 Jonathan Druart changed: What|Removed |Added Attachment #40476|0 |1 is obsolete|| Attachment #40477|0 |1 is obsolete|| Attachment #40833|0 |1 is obsolete|| Attachment #40834|0 |1 is obsolete|| Attachment #40835|0 |1 is obsolete|| Attachment #40836|0 |1 is obsolete|| Attachment #40837|0 |1 is obsolete|| --- Comment #25 from Jonathan Druart --- Created attachment 40863 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40863&action=edit Bug 14424 : Patron Help Files for 3.20 This patch updates the help files for 3.20 To test: * Visit * Main patron page * Patron search page * Patron permissions page * Confirm the text is right on all three Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14424] Update Help Files for 3.20
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14424 Jonathan Druart changed: What|Removed |Added Attachment #40864|0 |1 is obsolete|| --- Comment #31 from Jonathan Druart --- Created attachment 40869 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40869&action=edit Bug 14424: Update cataloging help for 3.20 This patch updates 3 help files for catalolging in 3.20 To test: * Visit * cataloging home * cataloging a new record * mergin bib records * Confirm text is right and visible Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14424] Update Help Files for 3.20
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14424 --- Comment #29 from Jonathan Druart --- Created attachment 40867 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40867&action=edit Bug 14424: Add on site checkouts help for 3.20 There is no help for the pending on site checkouts report. This patch adds it. To test: * visit pending on site checkouts * click help * confirm help is there and correct Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14424] Update Help Files for 3.20
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14424 Jonathan Druart changed: What|Removed |Added Attachment #40866|0 |1 is obsolete|| --- Comment #33 from Jonathan Druart --- Created attachment 40871 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40871&action=edit Bug 14424: Update Acq Help for 3.20 This patch adds the missing order from subscription help and updates basket help. To test: * Visit a basket, review the help * Click order from a subscrption, review the help Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14424] Update Help Files for 3.20
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14424 Jonathan Druart changed: What|Removed |Added Attachment #40865|0 |1 is obsolete|| --- Comment #32 from Jonathan Druart --- Created attachment 40870 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40870&action=edit Bug 14424: Update Discharge Help for 3.20 This patch adds the missing discharge help file and updates the moremember file with info on discharges. To test: * Visit a patron * View and confirm help is right * Visit the discharge page on the patron * Confirm help file loads and is right Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14424] Update Help Files for 3.20
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14424 Jonathan Druart changed: What|Removed |Added Attachment #40863|0 |1 is obsolete|| --- Comment #30 from Jonathan Druart --- Created attachment 40868 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40868&action=edit Bug 14424 : Patron Help Files for 3.20 This patch updates the help files for 3.20 To test: * Visit * Main patron page * Patron search page * Patron permissions page * Confirm the text is right on all three Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14424] Update Help Files for 3.20
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14424 Jonathan Druart changed: What|Removed |Added Attachment #40867|0 |1 is obsolete|| --- Comment #34 from Jonathan Druart --- Created attachment 40872 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40872&action=edit Bug 14424: Add on site checkouts help for 3.20 There is no help for the pending on site checkouts report. This patch adds it. To test: * visit pending on site checkouts * click help * confirm help is there and correct Signed-off-by: Mark Tompsett Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14424] Update Help Files for 3.20
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14424 --- Comment #35 from Jonathan Druart --- Sorry for the flood, I forgot my signed-off-by line. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14388] add sorting to funds
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14388 --- Comment #6 from M. Tompsett --- I wrote: > I was not able to duplicate issue with Debian Jessie on Master. > Though, this patch clearly forces sorting. (In reply to Jonathan Druart from comment #5) > They are currently sorted by budget_id. My screen says otherwise. I'm wondering if this is a hashes are stored in a random order issue, because it ordered 2,1,3 on my screen without the patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14494] Terribly slow checkout caused by DateTime->new in far future
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14494 --- Comment #5 from Marcel de Rooy --- Created attachment 40873 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40873&action=edit Bug 14494: Terribly slow checkout caused by DateTime->new in far future An expiry date like -12-31 in the local timezone will make DateTime spend a lot of time (maybe 60 seconds) on date calculation. See the DateTime documention on CPAN. A calculation in floating (or alternatively in UTC) would only take a few milliseconds. This patch makes two changes in this regard: [1] The compare between expiry date and today in CanBookBeIssued is now done in the floating timezone. [2] If ReturnBeforeExpiry is enabled, CalcDateDue compares the normal due date with the expiry date. The comparison is now done in the floating timezone. If the expiry date is before the due date, it is returned in the user context's timezone. NOTE: The calls to set_time_zone moving to or from floating do not adjust the local time. TEST PLAN: First without this patch: [1] Set expiry date to -12-31 for a patron. [2] Enable ReturnBeforeExpiry. [3] Checkout a book to this patron. This will be (very) slow. Continue now with this patch applied: [4] Check in the same book. [5] Check it out again. Should be much faster. Bonus test: [6] Set borrower expiry date to today. Change relevant circulation rule to loan period of 21 hours. Test checking out with a manual due date /time just before today 23:59 and after that. In the second case the due date/time should become today 23:59 (note that 23:59 is not shown on the checkout form). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14494] Terribly slow checkout caused by DateTime->new in far future
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14494 --- Comment #6 from Marcel de Rooy --- Typical example of patch collision. Can we get the best of both? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14494] Terribly slow checkout caused by DateTime->new in far future
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14494 --- Comment #7 from Marcel de Rooy --- (In reply to Katrin Fischer from comment #2) > Hm, I feel a bit like this builds in a secret feature - if I use 9998 it > will be slow, but if I use it will be faster? > > When we fixed the same thing for debarments it made more sense, as the > 'ulimited' debarment uses automatically, without the user entering a > date. For the patron expiry the date is defined by the library and could be > anything. We should not do hardcoded tests on . -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8438] Users should only claim for serials related to their branch.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8438 Katrin Fischer changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment #44 from Katrin Fischer --- Sadly, there was no reaction on the mailing list to the e-mail Marcel sent (thx for that!) I suggest moving this back into the queue - I personally see no cleaner way to do that, the only additions I can think of is a small warning in Release notes. To me this kind of fixes a bug - I can't search for other branches subscriptions without superserials/superlibrarian, but I can claim their late issues... that appears illogical to me. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14494] Terribly slow checkout caused by DateTime->new in far future
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14494 --- Comment #8 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #6) > Typical example of patch collision. > Can we get the best of both? As I already said, IMO we should not use DateTime outside of Koha::DateUtils. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14447] Show the vol./ no. on the child record based from the host entry
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14447 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #1 from Katrin Fischer --- Hi Jill, which feature are you using for creating your analytical records? The EasyAnalytics feature or the "New > New child record" link from the staff detail screen? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14420] bulkmarcimport.pl - Some problems
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14420 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14494] Terribly slow checkout caused by DateTime->new in far future
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14494 --- Comment #9 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #8) > (In reply to Marcel de Rooy from comment #6) > > Typical example of patch collision. > > Can we get the best of both? > > As I already said, IMO we should not use DateTime outside of Koha::DateUtils. That is fine. My patch also touches CalcDateDue. I will rework it now. Can we prevent another duplication of effort? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14494] Terribly slow checkout caused by DateTime->new in far future
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14494 --- Comment #10 from Marcel de Rooy --- btw I will also remove the Note that I am having trouble now with the Circulation test. It fails with me on test 49 already. not ok 49 - No items due in less than one day (0 days in advance) # Failed test 'No items due in less than one day (0 days in advance)' # at t/db_dependent/Circulation.t line 527. # got: '2' # expected: '0' -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14494] Terribly slow checkout caused by DateTime->new in far future
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14494 Marcel de Rooy changed: What|Removed |Added Assignee|jonathan.dru...@biblibre.co |m.de.r...@rijksmuseum.nl |m | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14464] Add ability to cancel waiting holds from checkin screen
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14464
--- Comment #5 from Jonathan Druart ---
Comment on attachment 40752
--> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40752
Bug 14464 - Add ability to cancel waiting holds from checkin screen
Review of attachment 40752:
-->
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=14464&attachment=40752)
-
::: circ/returns.pl
@@ +30,5 @@
> use strict;
> use warnings;
>
> +use Carp 'verbose';
> +$SIG{ __DIE__ } = sub { Carp::confess( @_ ) };
Why do you need that?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14494] Terribly slow checkout caused by DateTime->new in far future
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14494 Marcel de Rooy changed: What|Removed |Added Attachment #40873|0 |1 is obsolete|| --- Comment #11 from Marcel de Rooy --- Created attachment 40874 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40874&action=edit Bug 14494: Terribly slow checkout caused by DateTime->new in far future An expiry date like -12-31 in the local timezone will make DateTime spend a lot of time (maybe 60 seconds) on date calculation. See the DateTime documention on CPAN. A calculation in floating (or alternatively in UTC) would only take a few milliseconds. This patch makes two changes in this regard: [1] The compare between expiry date and today in CanBookBeIssued has been adjusted in Jonathan's patch. I am moving the compare to the floating timezone (as was done in my original patch). This removes a hardcoded . [2] If ReturnBeforeExpiry is enabled, CalcDateDue compares the normal due date with the expiry date. The comparison is now done in the floating timezone. If the expiry date is before the due date, it is returned in the user context's timezone. NOTE: The calls to set_time_zone moving to or from floating do not adjust the local time. TEST PLAN: First without this patch (and the one from Jonathan): [1] Set expiry date to -12-31 for a patron. [2] Enable ReturnBeforeExpiry. [3] Checkout a book to this patron. This will be (very) slow. Continue now with this patch applied: [4] Check in the same book. [5] Check it out again. Should be much faster. Bonus test: [6] Set borrower expiry date to today. Change relevant circulation rule to loan period of 21 hours. Test checking out with a manual due date /time just before today 23:59 and after that. In the second case the due date/time should become today 23:59 (note that 23:59 is not shown on the checkout form). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14452] Remember if user used more/fewer options on advanced search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14452 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@biblibre.co ||m --- Comment #1 from Jonathan Druart --- I'd tempt to remove the pref and use sessionStorage, but it won't work at the OPAC if JS is disabled. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14452] Remember if user used more/fewer options on advanced search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14452 --- Comment #2 from Katrin Fischer --- Thinking of our libraries there seems to be a difference in what people like to be the default - so I am not sure about removing the pref. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14494] Terribly slow checkout caused by DateTime->new in far future
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14494 --- Comment #12 from Marcel de Rooy --- not ok 49 - No items due in less than one day (0 days in advance) # Failed test 'No items due in less than one day (0 days in advance)' # at t/db_dependent/Circulation.t line 527. # got: '2' # expected: '0' Resolved this one now. The staff expiry was too quick :) Still looking now at: ok 61 - Calling UpdateFine on non-existant fine with an amount of 0 does not result in an empty fine DBD::mysql::db begin_work failed: Already in a transaction at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1339. DBIx::Class::Schema::txn_begin(): DBD::mysql::db begin_work failed: Already in a transaction at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1339. at /home/koha/testclone/t/lib/TestBuilder.pm line 75 DBIx::Class::Schema::txn_rollback(): Storage transaction_depth 0 does not match false AutoCommit of DBI::db=HASH(0xb24823c), attempting ROLLBACK anyway at /home/koha/testclone/t/lib/TestBuilder.pm line 360 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14387] Merge reference selection has no effect when merging authorities.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14387 Jonathan Druart changed: What|Removed |Added Attachment #40695|0 |1 is obsolete|| --- Comment #3 from Jonathan Druart --- Created attachment 40875 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40875&action=edit Bug 14387 - Merge reference selection has no effect when merging authorities. This patch swaps the authority records according to the refenrece record selection. To TEST: Merge two authority records, select the second as merge reference. The reference authority is always the first. Apply the patch. Repeat previous steps, the authority is now merged using the selected reference record. modified: authorities/merge.pl Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14387] Merge reference selection has no effect when merging authorities.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14387 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14303] Fix item search CSV export - obsolete "by" and display of publication year for MARC21
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14303 Jonathan Druart changed: What|Removed |Added Attachment #40029|0 |1 is obsolete|| --- Comment #5 from Jonathan Druart --- Created attachment 40876 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40876&action=edit Bug 14303: Fix item search CSV export - obsolete "by" and display of publication year for MARC21 The exported CSV file from the item search didn't display the publication year in MARC21 installations and the title always contained 'by' even if there was no author information to display. Also the by is not needed by MARC21 as the data should include punctuation. This basically copies the changes done to the JSON format on bug 13859 to the CSV include. To test: Switch from 'Screen' to 'CSV' - Check publication date always displays (MARC21 and UNIMARC) - Check that for MARC21 the 'by' has been removed from the title information - Check that for UNIMARC the 'by' only displays when there is also an author to display Tested for MARC21, works as expected. Signed-off-by: Marc Véron Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14303] Fix item search CSV export - obsolete "by" and display of publication year for MARC21
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14303 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12919] Automate collecting all records added and deleted from the catalogue
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12919 --- Comment #14 from Jonathan Druart --- (In reply to Liz Rea from comment #13) > Created attachment 40505 [details] [review] > Bug 12919 - perltidy and consistent sub naming Liz, could you confirm this one can leave the FQA queue? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11693] Default emailing preferences not loaded for self registering patron
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11693 Jonathan Druart changed: What|Removed |Added Attachment #40793|0 |1 is obsolete|| --- Comment #6 from Jonathan Druart --- Created attachment 40877 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40877&action=edit Bug 11693: Default emailing preferences not loaded for self registering patron The call to AddMember_Opac does not take care of the messaging prefs when enhanced messaging is enabled. This patch adds the call to handle_form_action to do that. Test plan: Enable self registering patrons and enhanced messaging. Check the (default) message prefs for the relevant patron category. At least enable email for one notice. Self-register a user with and without verification email enabled. Check in both cases that the message prefs of the user conform to those in the patron category. (So at least one enabled.) Followed test plan, works as expected. Signed-off-by: Marc Véron Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11693] Default emailing preferences not loaded for self registering patron
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11693 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13540] Item's permanent_location is set to CART|PROC if an Item is edited when it's location is CART|PROC.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13540 Katrin Fischer changed: What|Removed |Added Attachment #40214|0 |1 is obsolete|| --- Comment #27 from Katrin Fischer --- Created attachment 40878 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40878&action=edit Bug 13540 - Item's permanent_location is set to CART|PROC when... - Unit tests Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13452] Average checkout report always uses biblioitems.itemtype
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13452
Jonathan Druart changed:
What|Removed |Added
CC||jonathan.dru...@bugs.koha-c
||ommunity.org
Status|Signed Off |Failed QA
--- Comment #6 from Jonathan Druart
---
I won't use the splinter review, it will be confusing.
1/ There are 2 different ways to do the same thing:
247 if ( $line=~/itemtype/ ) { $line = $itype; }
257 $linefilter[0] = @$filters[9] if ($line =~ /itemtype/ ) ;
and
263 if ( $column=~/itemtype/ ) { $column = $itype; }
274 $colfilter[0] = @$filters[9] if ($column =~ $itype ) ;
2/ Please use sql placeholders for "issuingrules.itemtype=$itype" (x3)
3/
if (( @colfilter ) and ($colfilter[1])){
$sth2->execute("'".$colfilter[0]."'","'".$colfilter[1]."'");
} elsif ($colfilter[0]) {
$sth2->execute;
} else {
$sth2->execute;
}
Could be :
if (( @colfilter ) and ($colfilter[1])){
$sth2->execute("'".$colfilter[0]."'","'".$colfilter[1]."'");
} else {
$sth2->execute;
}
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13540] Item's permanent_location is set to CART|PROC if an Item is edited when it's location is CART|PROC.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13540 --- Comment #28 from Katrin Fischer --- I have rebased the last patch hopefully correctly and fixed problems with the POD in the test file noted by the QA script. But: $ prove t/db_dependent/Circulation.t t/db_dependent/Circulation.t .. 25/69 # Failed test 'ReturnToShelvingCart: Modifying the whole Item doesn't overwrite permanent_location!' # at t/db_dependent/Circulation.t line 684. # Failed test 'ReturnToShelvingCart: Adding a new Item with location also sets the permanent_location.'$ prove t/db_dependent/Circulation.t t/db_dependent/Circulation.t .. 25/69 # Failed test 'ReturnToShelvingCart: Modifying the whole Item doesn't overwrite permanent_location!' # at t/db_dependent/Circulation.t line 684. # Failed test 'ReturnToShelvingCart: Adding a new Item with location also sets the permanent_location.' # at t/db_dependent/Circulation.t line 704. # Looks like you failed 2 tests of 69. t/db_dependent/Circulation.t .. Dubious, test returned 2 (wstat 512, 0x200) Failed 2/69 subtests Test Summary Report --- t/db_dependent/Circulation.t (Wstat: 512 Tests: 69 Failed: 2) Failed tests: 67, 69 Non-zero exit status: 2 Files=1, Tests=69, 2 wallclock secs ( 0.03 usr 0.00 sys + 1.50 cusr 0.08 csys = 1.61 CPU) Result: FAIL # at t/db_dependent/Circulation.t line 704. # Looks like you failed 2 tests of 69. t/db_dependent/Circulation.t .. Dubious, test returned 2 (wstat 512, 0x200) Failed 2/69 subtests Test Summary Report --- t/db_dependent/Circulation.t (Wstat: 512 Tests: 69 Failed: 2) Failed tests: 67, 69 Non-zero exit status: 2 Files=1, Tests=69, 2 wallclock secs ( 0.03 usr 0.00 sys + 1.50 cusr 0.08 csys = 1.61 CPU) Result: FAIL Leaving this in Failed QA for now - but would love to see this fixed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13881] Add desk management
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13881 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #9 from Katrin Fischer --- Hi Nicolas, are the patches in the right order? Could they be squashed? I am not sure how they are divided up and the first seems to refer +use C4::Desks;, which is only added by the third patch. Also, should this be needs sign-off? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13501] Allow autocompletion on drop-down lists
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13501 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Needs Signoff CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #13 from Jonathan Druart --- I would like to get another signoff to confirm that the concerns raised in comment 11 are fixed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937 --- Comment #61 from Blou --- All those comments are perfectly valid. I'll correct them all (the use Dumper are most probably something forgotten by the dev, no excuse). Regarding the name, which one would you prefer "ITYPECAT or ITEMTYPECAT? Or a bit different: ITYPEGROUP" If no response, I'll go with ITYPEGROUP (of course, I'll do a patch's patch. I'm not messing with a passed qa) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14494] Terribly slow checkout caused by DateTime->new in far future
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14494 Marcel de Rooy changed: What|Removed |Added Attachment #40874|0 |1 is obsolete|| --- Comment #14 from Marcel de Rooy --- Created attachment 40880 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40880&action=edit Bug 14494: Terribly slow checkout caused by DateTime->new in far future An expiry date like -12-31 in the local timezone will make DateTime spend a lot of time (maybe 60 seconds) on date calculation. See the DateTime documention on CPAN. A calculation in floating (or alternatively in UTC) would only take a few milliseconds. This patch makes two changes in this regard: [1] The compare between expiry date and today in CanBookBeIssued has been adjusted in Jonathan's patch. I am moving the compare to the floating timezone (as was done in my original patch). This removes a hardcoded . [2] If ReturnBeforeExpiry is enabled, CalcDateDue compares the normal due date with the expiry date. The comparison is now done in the floating timezone. If the expiry date is before the due date, it is returned in the user context's timezone. NOTE: The calls to set_time_zone moving to or from floating do not adjust the local time. TEST PLAN: First without this patch (and the one from Jonathan): [1] Set expiry date to -12-31 for a patron. [2] Enable ReturnBeforeExpiry. [3] Checkout a book to this patron. This will be (very) slow. Continue now with this patch applied: [4] Check in the same book. [5] Check it out again. Should be much faster. Bonus test: [6] Set borrower expiry date to today. Change relevant circulation rule to loan period of 21 hours. Test checking out with a manual due date /time just before today 23:59 and after that. In the second case the due date/time should become today 23:59 (note that 23:59 is not shown on the checkout form). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14197] Warning raised by TestBuilder
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14197 Marcel de Rooy changed: What|Removed |Added Blocks|14494 | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14494] Terribly slow checkout caused by DateTime->new in far future
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14494 Marcel de Rooy changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=14197 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14494] Terribly slow checkout caused by DateTime->new in far future
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14494 Marcel de Rooy changed: What|Removed |Added Attachment #40860|0 |1 is obsolete|| --- Comment #13 from Marcel de Rooy --- Created attachment 40879 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40879&action=edit Bug 14494: Prevent slow checkout if the patron does not have an expiry date If a patron has a expiry date set to -12-31 (for organizations for instance), the checkouts are very slow. It's caused by 2 different calls to DateTime in CanBookBeIssued: 1/ DateTime->new( year => , month => 12, day => 31, time_zone => C4::Context->tz ); The time_zone should not be set (as it's done in Koha::DateUtils), set to UTC or floating tz. 2/ DateTime->compare($today, $expiry_dt) The comparaison of 2 DT with 1 related to is very slow, as you can imagine. For 1/ we need to call Koha::DateUtils::dt_from_string (actually, we should never call DateTime directly). For 2/ we just need to test if the date is != , no need to compare it in this case. Test plan: Before this patch, confirm that the checkouts are slow if the patron has a dateexpiry set to -12-31. update borrowers set dateexpiry="-12-31" where borrowernumber=42; After this patch, you should not see any regression when checking out items to an expired patron and to a valid patron. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14197] Warning raised by TestBuilder
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14197 Marcel de Rooy changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=14494 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14494] Terribly slow checkout caused by DateTime->new in far future
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14494 Marcel de Rooy changed: What|Removed |Added Depends on|14197 | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14494] Terribly slow checkout caused by DateTime->new in far future
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14494 --- Comment #15 from Marcel de Rooy --- Created attachment 40881 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40881&action=edit Bug 14494: Unit test Signed-off-by: Marcel de Rooy Moved the test on its own. Nicer than adding TestBuilder in the final part of the test. No warnings/errors from TestBuilder, no dependency.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13881] Add desk management
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13881 Indranil Das Gupta changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |nicolas.legr...@bulac.fr |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14468] Remove warnings when creating Labels
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14468 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #9 from Jonathan Druart --- (In reply to Chris Nighswonger from comment #6) > That all sounds good. I wish I had time to sign off! Chris, I am not confident with part of code, it would be great to get your signoff on this one :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14494] Terribly slow checkout caused by DateTime->new in far future
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14494 --- Comment #16 from Marcel de Rooy --- Needs a signoff on the second path to get this into SO queue. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13881] Add desk management
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13881 Indranil Das Gupta changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14494] Terribly slow checkout caused by DateTime->new in far future
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14494 Marcel de Rooy changed: What|Removed |Added Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14494] Terribly slow checkout caused by DateTime->new in far future
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14494 Marcel de Rooy changed: What|Removed |Added Attachment #40881|0 |1 is obsolete|| --- Comment #17 from Marcel de Rooy --- Created attachment 40882 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40882&action=edit Bug 14494: Unit test Signed-off-by: Marcel de Rooy Moved the test on its own. Nicer than adding TestBuilder in the final part of the test. No warnings/errors from TestBuilder, no dependency.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12395] Save order line's creator
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #67 from Katrin Fischer --- I think the last new patch is ok as a QA follow-up - shifting back to signed off. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13622] Display a datetime without time in a notice
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13622 --- Comment #18 from Katrin Fischer --- Patches look ok to me on first glance, thx Indranil! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14420] bulkmarcimport.pl - Some problems
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14420 --- Comment #2 from Katrin Fischer --- Hi Vitor, can you please add a test plan? Some sample records might also be helpful to make this easier to test. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14420] bulkmarcimport.pl - Some problems
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14420 --- Comment #3 from Katrin Fischer --- Ah, also make sure test plan and problem description are part of your commit message! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14494] Terribly slow checkout caused by DateTime->new in far future
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14494 Marcel de Rooy changed: What|Removed |Added Attachment #40882|0 |1 is obsolete|| --- Comment #18 from Marcel de Rooy --- Created attachment 40883 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40883&action=edit Bug 14494: Unit tests for CanBookBeIssued related to dateexpiry Signed-off-by: Marcel de Rooy Moved the test on its own. Nicer than adding TestBuilder in the final part of the test. No warnings/errors from TestBuilder, no dependency.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12252] OAI-PMH GetRecord result doesn't include item data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12252 --- Comment #46 from Katrin Fischer --- (In reply to Gaetan Boisson from comment #38) > Adding a note to the OAI-PMH preference so that it reads like the following > would be ok for me: > > able/disable Koha's OAI-PMH server. The data exposed will not include items > hidden through the OpacHiddenItems system preference, but everything else > will be available for harvest. If you need to hide some data, look into > extended mode and the OAI-PMH:ConfFile system preference. > > (It does look to me as enabling extended mode with a configuration file > allowing only one type of metadata that would result from a custom xslt > removing the confidential fields would be enough.) I liked this idea from Gaetan. But thinking about it more I am still torn: This is a change in behaviour. People might have built things assuming the item data is not there and might suddenly expose more data, than they wanted to. I know that Jonathan is probably right in that this was initially a regression from bug 5579, but we missed to fix this for a really long time now :( Would it be really bad to make the items a configuration option? I know some people hate new prefs... but the Web Services tab still has plenty of room... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14511] New: Allow zebra search for MARC 027 tag
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14511 Bug ID: 14511 Summary: Allow zebra search for MARC 027 tag Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Bibliographic data support Assignee: gmcha...@gmail.com Reporter: amitddng...@gmail.com QA Contact: testo...@bugs.koha-community.org MARC21 027 tag Standard technical report number should be indexed by Zebra. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14511] Allow zebra search for MARC 027 tag
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14511 Amit Gupta changed: What|Removed |Added Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14511] Allow zebra search for MARC 027 tag
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14511 Amit Gupta changed: What|Removed |Added CC||indr...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14511] Allow zebra search for MARC 027 tag
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14511 Amit Gupta changed: What|Removed |Added Assignee|gmcha...@gmail.com |amitddng...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10756] Carousel Display of New Titles on OPAC home page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10756 Jerwyn changed: What|Removed |Added CC||os.jerwynfernan...@gmail.co ||m --- Comment #2 from Jerwyn --- Oh yeah! This is a nice feature! Its been almost 2 years any update on this? Thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 --- Comment #119 from Jonathan Druart --- (In reply to Kyle M Hall from comment #115) > As far as I can tell there is no way around this. I tried to use a left join > but you cannot use a group by in an update statement. Kyle, Just a quick thought: wouldn't it be possible to execute another update statement after the existing one, instead of adding complexity to it? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937 --- Comment #62 from Blou --- Created attachment 40884 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40884&action=edit Bug 10937 - cleanup and rename DOCTYPECAT to ITEMTYPECAT - "Item" and not "Document" is the word used throughout Koha. - Moved the updates to an atomic update - changed searchcategory from varchar(20) to (80) - cleanup -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937 --- Comment #63 from Blou --- Since the word "category" was used throughout the patch, I kept it instead of using "group". updatedatabase.pl doesn't apply anymore with the first patch, but since it's PassedQA, I'm not touching it. The second patch puts it all in atomicupdate, to help in case it all falls apart and someone recreate a new squashed patch from 0. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14511] Allow zebra search for MARC 027 tag
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14511 --- Comment #1 from Indranil Das Gupta --- (In reply to Amit Gupta from comment #0) > MARC21 027 tag Standard technical report number should be indexed by Zebra. so what are you proposing to do here? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11584] Add wysiwyg editor to system preferences dealing with HTML
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11584 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Patch doesn't apply CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #6 from Jonathan Druart --- Hi David, Could you please add tinyMCE to the about page? Idea: why don't you add a pref to enable/disable the wysiwyg editor to all textarea pref? Please rebase, there is a conflict: CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/admin/systempreferences.tt -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10756] Carousel Display of New Titles on OPAC home page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10756 Eugene Espinoza changed: What|Removed |Added CC||eugen...@yahoo.com --- Comment #3 from Eugene Espinoza --- This will be a nice feature added into Koha ILS, instead of trying out different technologies just to make this work, which can be a migration headache. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14121] Silence warnings t/db_dependent/Auth_with_cas.t
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14121 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #15 from Jonathan Druart --- % more /etc/debian_version jessie/sid % perl --version | grep version This is perl 5, version 20, subversion 2 (v5.20.2) built for i586-linux-gnu-thread-multi-64int % git reset --hard origin/master % prove t/db_dependent/Auth_with_cas.t t/db_dependent/Auth_with_cas.t .. ok All tests successful. Files=1, Tests=4, 1 wallclock secs ( 0.02 usr 0.00 sys + 0.96 cusr 0.02 csys = 1.00 CPU) Result: PASS No warn here. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
