[Koha-bugs] [Bug 13263] Printing Callnumber in Koha 3.16.04.000.

2015-07-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13263

Chris Nighswonger  changed:

   What|Removed |Added

 Resolution|--- |INVALID
 Status|NEW |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14199] Unify all organization code plugins

2015-07-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14199

--- Comment #2 from Marcel de Rooy  ---
Created attachment 40944
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40944&action=edit
Bug 14199: Modify webinstaller sql files for marc21_orgcode plugin

This patch updates the sql installer files for new installations.
Occurrences to the three plugins marc21_field_003, 040c and 040d are
replaced by marc21_orgcode.pl.
This has been generated by one sed statement.

Test plan:
[1] Run a new installation or run some of the changed sql files manually.
[2] Verify that marc21_orgcode is linked to fields previously linked to
the three old plugins.
[3] Do a git grep on the three plugin file names. No occurrences expected.

Signed-off-by: Marcel de Rooy 
Have tested the three english sql files:
authorities_normal_marc21.sql: 18 rows with marc21_orgcode (003 and 040a
for 9 auth codes)
marc21_framework_DEFAULT.sql: 1 row with marc21_orgcode (003) -- this patch
does not add them to 040c or 040d; no behavior change..
marc21_simple_bib_frameworks.sql: 8 rows (003 for 8 frameworks)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14199] Unify all organization code plugins

2015-07-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14199

--- Comment #3 from Marcel de Rooy  ---
Created attachment 40945
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40945&action=edit
Bug 14199: Database revision for marc21_orgcode.pl

This patch adds the dbrev in atomicupdate, updating the marc structure
for existing installations. (New installation in previous patch.)
And it removes the obsolete plugin files.

Test plan:
Run upgrade. Verify that new plugin is linked (for bib and auth).
Check plugin in editor.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14199] Unify all organization code plugins

2015-07-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14199

--- Comment #1 from Marcel de Rooy  ---
Created attachment 40943
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40943&action=edit
Bug 14199: Unify marc orgcode plugins, not overwriting existing values

This patch copies code from marc21_field_003.pl to create marc21_orgcode.pl
for more generic use. Other fields like 040c or 040d should use it too.
Note: The plugin is used for authorities too (003, 040a).

One behaviour change is added: If the corresponding field is already
filled, it will not be overwritten.

In the unit test marc21_orgcode already replaces marc21_field_003.

Test plan:
[1] Attach plugin marc21_orgcode to a field (e.g. 003) and test it in
the MARC editor of Cataloguing or Authorities.
[2] Check if a value is not overwritten any more.
[3] Run unit test t/db_dependent/FrameworkPlugin.t; don't be distracted by
the noisy warnings of marc21_field_007.pl. They will be addressed on
another report.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14199] Unify all organization code plugins

2015-07-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14199

Marcel de Rooy  changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |m.de.r...@rijksmuseum.nl
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14199] Unify all organization code plugins

2015-07-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14199

Marcel de Rooy  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13444] OPACFallback has option 'Prog'

2015-07-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13444

Indranil Das Gupta  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 CC||indr...@gmail.com
 Resolution|--- |DUPLICATE

--- Comment #1 from Indranil Das Gupta  ---


*** This bug has been marked as a duplicate of bug 13291 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13291] Suppress OPACFallback syspref - its use and itself

2015-07-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13291

Indranil Das Gupta  changed:

   What|Removed |Added

 CC||mi...@abunchofthings.net

--- Comment #2 from Indranil Das Gupta  ---
*** Bug 13444 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13291] Suppress OPACFallback syspref - its use and itself

2015-07-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13291

Indranil Das Gupta  changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |koha-b...@lists.koha-commun
   ||ity.org
  Component|Architecture, internals,|System Administration
   |and plumbing|
 Status|NEW |ASSIGNED
 CC||gmcha...@gmail.com,
   ||indr...@gmail.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13291] Suppress OPACFallback syspref - its use and itself

2015-07-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13291

Indranil Das Gupta  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |indr...@gmail.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13291] Suppress OPACFallback syspref - its use and itself

2015-07-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13291

Indranil Das Gupta  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13291] Suppress OPACFallback syspref - its use and itself

2015-07-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13291

--- Comment #3 from Indranil Das Gupta  ---
Created attachment 40946
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40946&action=edit
Bug 13291 - remove prog as fallback theme

The 'prog' theme for OPAC was removed from Koha. The OPACFallback
syspref was added in 3.18.0 with prog|bootstrap options. This patch
proposes to remove the prog option, but still maintain the syspref
for reasons outlined in Bug 13291 comment #1.

Test plan : run updatedatabase.pl and check the value of OpacFallback
under OPAC sysprefs.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13291] Suppress OPACFallback syspref - its use and itself

2015-07-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13291

Indranil Das Gupta  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13291] Remove prog option from OPACFallback syspref

2015-07-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13291

Indranil Das Gupta  changed:

   What|Removed |Added

Summary|Suppress OPACFallback   |Remove prog option from
   |syspref - its use and   |OPACFallback syspref
   |itself  |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13291] Remove prog option from OPACFallback syspref

2015-07-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13291

--- Comment #4 from M. Tompsett  ---
Comment on attachment 40946
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40946
Bug 13291 - remove prog as fallback theme

Review of attachment 40946:
 --> 
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=13291&attachment=40946)
-

:::
installer/data/mysql/atomicupdate/bug_13291-remove-prog-as-listed-fallback-theme.sql
@@ +1,1 @@
> +INSERT IGNORE INTO systempreferences 
> (variable,value,explanation,options,type) VALUES ('OPACFallback', 
> 'bootstrap', 'Define the fallback theme for the OPAC interface.', 
> 'bootstrap', 'Themes');

Works fine for systems lacking the system preference, but where's the UPDATE
for those which already have it set?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10756] Carousel Display of New Titles on OPAC home page

2015-07-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10756

--- Comment #4 from Nicole C. Engard  ---
The coverflow plugin : http://bywatersolutions.com/koha-plugins/ uses the
public reports to generate a responsive carousel of books.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13291] Remove prog option from OPACFallback syspref

2015-07-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13291

Indranil Das Gupta  changed:

   What|Removed |Added

  Attachment #40946|0   |1
is obsolete||

--- Comment #5 from Indranil Das Gupta  ---
Created attachment 40947
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40947&action=edit
Bug 13291 - remove prog as fallback theme

The 'prog' theme for OPAC was removed from Koha. The OPACFallback
syspref was added in 3.18.0 with prog|bootstrap options. This patch
proposes to remove the prog option, but still maintain the syspref
for reasons outlined in Bug 13291 comment #1.

Test plan : run updatedatabase.pl and check the value of OpacFallback
under OPAC sysprefs.



Current patch-complexity: Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13291] Remove prog option from OPACFallback syspref

2015-07-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13291

Indranil Das Gupta  changed:

   What|Removed |Added

  Attachment #40947|0   |1
is obsolete||

--- Comment #6 from Indranil Das Gupta  ---
Created attachment 40948
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40948&action=edit
Bug 13291 - remove prog as fallback theme

The 'prog' theme for OPAC was removed from Koha. The OPACFallback
syspref was added in 3.18.0 with prog|bootstrap options. This patch
proposes to remove the prog option, but still maintain the syspref
for reasons outlined in Bug 13291 comment #1.

Test plan : run updatedatabase.pl and check the value of OpacFallback
under OPAC sysprefs.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13291] Remove prog option from OPACFallback syspref

2015-07-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13291

--- Comment #7 from Indranil Das Gupta  ---
(In reply to M. Tompsett from comment #4)
> Comment on attachment 40946 [details] [review]
> Bug 13291 - remove prog as fallback theme
> Works fine for systems lacking the system preference, but where's the UPDATE
> for those which already have it set?

Addressed. Also adds the missing edits to opac.pref.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13291] Remove prog option from OPACFallback syspref

2015-07-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13291

M. Tompsett  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13291] Remove prog option from OPACFallback syspref

2015-07-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13291

M. Tompsett  changed:

   What|Removed |Added

  Attachment #40948|0   |1
is obsolete||

--- Comment #8 from M. Tompsett  ---
Created attachment 40949
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40949&action=edit
Bug 13291 - remove prog as fallback theme

The 'prog' theme for OPAC was removed from Koha. The OPACFallback
syspref was added in 3.18.0 with prog|bootstrap options. This patch
proposes to remove the prog option, but still maintain the syspref
for reasons outlined in Bug 13291 comment #1.

TEST PLAN
-
 1) back up DB
 2) in sql client:
> select * from systempreferences where variable like '%OPACFallback%';
-- 1 record, should have bootstrap and prog choices,
   and likely prog fallback.
 3) at command line:
./installer/data/mysql/updatedatabase.pl
 4) in sql client:
> select * from systempreferences where variable like '%OPACFallback%';
-- 1 record, should have bootstrap and bootstrap values now.
 5) in sql client:
> delete from systempreferences where variable like '%OPACFallback%';
-- now there should be no OPACFallback system preference.
 6) at command line:
./installer/data/mysql/updatedatabase.pl
 7) in sql client:
   > select * from systempreferences where variable like '%OPACFallback%';
-- 1 record, should have bootstrap and bootstrap values now.
 8) in sql client (substitute your koha database name!):
> drop database koha_library;
> create database koha_library;
> use koha_library;
 9) Run web installer
10) in sql client:
> select * from systempreferences where variable like '%OPACFallback%';
-- 1 record, should have bootstrap and bootstrap values now.
11) run koha qa test tools

Signed-off-by: Mark Tompsett 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11904] Proposal for a uniform way to send messages to user interface

2015-07-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11904

M. Tompsett  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

--- Comment #32 from M. Tompsett  ---
There are a couple of things that I just don't have the time to check.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/