[Koha-bugs] [Bug 14649] fund names not displayed in budget planning
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14649 --- Comment #2 from Jonathan Druart --- Created attachment 41396 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41396&action=edit Bug 14649: Fix regression - display fund name on budget planning A patch from bug 11714 removes 'budget_name_indent', which was useless. The script and the template should use the budget_name value. Note that this patch impacts the CSV export, which does not work, so it cannot be tested. Test plan: Edit a fund and click on one of the Planning value (by months, etc.) The "Fund name" column should be correctly populated with the fund names. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14649] fund names not displayed in budget planning
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14649 Jonathan Druart changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14652] Change gender option N/A to None specified
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14652 Liz Rea changed: What|Removed |Added Attachment #41394|0 |1 is obsolete|| --- Comment #2 from Liz Rea --- Created attachment 41395 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41395&action=edit Bug 14652 - change gender specification from "N/A" to "None specified" To test: Edit a patron in the intranet, note that the gender options are "Female," "Male," and "None specified" Setting "None specified" should result in the gender not being shown on the patron detail page (unchanged functionality) In the opac, log in and click the "your personal details" tab, and note that the gender options are "Female," "Male," and "None specified" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14652] Change gender option N/A to None specified
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14652 Liz Rea changed: What|Removed |Added Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14652] Change gender option N/A to None specified
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14652 Liz Rea changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14652] New: Change gender option N/A to None specified
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14652 Bug ID: 14652 Summary: Change gender option N/A to None specified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: l...@catalyst.net.nz QA Contact: testo...@bugs.koha-community.org We should do this because it is more respectful to people who do not wish to specify a gender. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14652] Change gender option N/A to None specified
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14652 --- Comment #1 from Liz Rea --- Created attachment 41394 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41394&action=edit Bug 14652 - change gender specification from "N/A" to "None specified" To test: Edit a patron in the intranet, note that the gender options are "Female," "Male," and "None specified" Setting "None specified" should result in the gender not being shown on the patron detail page (unchanged functionality) In the opac, log in and click the "your personal details" tab, and note that the gender options are "Female," "Male," and "None specified" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14527] zebra error 114 when searching for items added before or after a specific date
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14527
--- Comment #20 from Robin Sheat ---
(In reply to Katrin Fischer from comment #17)
> I am adding Robin because I think he can tell what happens for a package
> installation. To my knowledge the index definitions are updated there as
> well - we build our own packages with some additional indexes and that seems
> to work perfectly fine. But I think local changes might create problems and
> even keep the files from updating.
It should be OK. I haven't tested this, but I would expect it would warn you
that it's changed and ask you if you want to keep your own version or if you
want to install the packaged version. Either way, it'll keep the other version
named with the extension .dpkg-{dist,orig}
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14607] Baker & Taylor cover images should be accessible by UPC as well as ISBN
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14607 --- Comment #1 from Jesse Weaver --- Created attachment 41393 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41393&action=edit Bug 14607: Baker & Taylor cover images should be accessible by UPC as well as ISBN Test plan (requires Baker and Taylor cover images to be set up and enabled): 1. Create a record with an ISBN that does not have a cover and a UPC that does. 141985934X/085391174929 is one set that works well. 2. Verify that the record shows up as "No image available" in the following OPAC locations: shelf browser, reviews, lists, search and reading record. This will require adding reviews/checkouts/etc. for the record in question. 3. Apply patch. 4. Check the locations again, and verify that the record now has a valid cover image. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14646] Koha::RecordProcessor only accepts one filter at a time
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14646 M. Tompsett changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||mtomp...@hotmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14646] Koha::RecordProcessor only accepts one filter at a time
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14646
M. Tompsett changed:
What|Removed |Added
Attachment #41388|0 |1
is obsolete||
--- Comment #3 from M. Tompsett ---
Created attachment 41391
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41391&action=edit
Bug 14646: (regression test) Koha::RecordProcessor only accepts one filter at a
time
This patch introduces new tests to t/RecordProcessor.t so it tests for
creating processors with more than one filter. It does so by running
my $processor = new Koha::RecordProcessor({
filters => ['Null','Dummy']
});
and testing the results.
To test:
- Apply the patch
- Run:
$ prove t/RecordProcessor.t
=> FAIL: tests related to multiple filters fail.
Signed-off-by: Mark Tompsett
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14646] Koha::RecordProcessor only accepts one filter at a time
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14646 M. Tompsett changed: What|Removed |Added Attachment #41389|0 |1 is obsolete|| --- Comment #4 from M. Tompsett --- Created attachment 41392 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41392&action=edit Bug 14646: Koha::RecordProcessor should accept more than one filter The docs say that Koha::RecordProcessor accepts more than one filter at a time. But as the regression tests show it doesn't. This is really important to extend its usage in record processing (either to enforce policy, transform, etc). This patch makes ->new evaluate the reference type of the passed filters and builds an array with a single item if a scalar has been passed. The loop now explicitly casts the filters as an array. To test: - Apply the test patch - Run $ prove t/RecordProcessor.t => FAIL: tests fail because Koha::RecordProcessor doesn't hanlde more than one filter at a time. - Apply this patch - Run $ prove t/RecordProcessor.t => SUCCESS: tests now pass - Easy, right? Sign off :-D NOTE: Read code. Don't like the ? operator logic, but it is functional despite readability issues. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14205] Deleting an Item/Record does not remove link to course reserve
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14205 M. Tompsett changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14205] Deleting an Item/Record does not remove link to course reserve
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14205 M. Tompsett changed: What|Removed |Added Attachment #41335|0 |1 is obsolete|| --- Comment #5 from M. Tompsett --- Created attachment 41390 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41390&action=edit Bug 14205: Deleting an Item/Record does not remove link to course reserve A constraint is missing on the course_reserves.ci_id field. This patch adds it and removes orphan rows. Test plan: 0/ Don't apply the patch 1/ Login to Staff Site. 2/ Go to Course Reserves 3/ Create Course 4/ Add Reserve 5/ Go to item added (delete item/record) 6/ Refresh Course (see no items attached) 7/ Delete Course 8/ See course still listed in the courses (Not deleted) 9/ Apply the patch and execute the updatedatabase entry. 10/ Delete the Course Note that the course has correctly been removed. NOTE: Make sure to set the UseCourseReserves system preference to test. Tested before (problem existed) and after (problem solved) update. Dropped DB, web installed, and put in dummy data and retested. Problem solved. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8753] Add forgot password link to OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #107 from Tim Hannah --- Had a look at this, first time using kohadevbox and git bz, so could be something I did or didn't do. Looked good, no stray text, but when I tried resetting a password I got error message DBIx::Class::ResultSet::next(): Table koha_kohadev.borrower_password_recovery' doesn't exist at /home/vagrant/kohaclone/C4/Passwordrecovery.pm line 70 Any clues? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14646] Koha::RecordProcessor only accepts one filter at a time
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14646 Tomás Cohen Arazi changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14646] Koha::RecordProcessor only accepts one filter at a time
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14646 --- Comment #2 from Tomás Cohen Arazi --- Created attachment 41389 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41389&action=edit Bug 14646: Koha::RecordProcessor should accept more than one filter The docs say that Koha::RecordProcessor accepts more than one filter at a time. But as the regression tests show it doesn't. This is really important to extend its usage in record processing (either to enforce policy, transform, etc). This patch makes ->new evaluate the reference type of the passed filters and builds an array with a single item if a scalar has been passed. The loop now explicitly casts the filters as an array. To test: - Run $ prove t/RecordProcessor.t => FAIL: tests fail because Koha::RecordProcessor doesn't hanlde more than one filter at a time. - Apply the patch - Run $ prove t/RecordProcessor.t => SUCCESS: tests now pass - Easy, right? Sign off :-D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14646] Koha::RecordProcessor only accepts one filter at a time
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14646
--- Comment #1 from Tomás Cohen Arazi ---
Created attachment 41388
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41388&action=edit
Bug 14646: (regression test) Koha::RecordProcessor only accepts one filter at a
time
This patch introduces new tests to t/RecordProcessor.t so it tests for
creating processors with more than one filter. It does so by running
my $processor = new Koha::RecordProcessor({
filters => ['Null','Dummy']
});
and testing the results.
To test:
- Apply the patch
- Run:
$ prove t/RecordProcessor.t
=> FAIL: tests related to multiple filters fail.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14639] Extend Koha::MetadataRecord to handle serialization format
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14639 M. Tompsett changed: What|Removed |Added Attachment #41361|0 |1 is obsolete|| --- Comment #8 from M. Tompsett --- Created attachment 41387 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41387&action=edit Bug 14639: Extend Koha::MetadataRecord to handle serialization format and record id The description of this changes is on the regression tests commit message. To test: - Apply the test patch - Run $ prove t/Koha_MetadataRecord.t => FAIL: Tests fail because changes are not implemented - Apply this patch - Run $ prove t/Koha_MetadataRecord.t => SUCCESS: tests pass - Run $ prove t/Koha_Util_MARC.t => SUCCESS: it still passes - Sign off :-D NOTE: Tested as above. Read code. Seems to cover all cases. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14639] Extend Koha::MetadataRecord to handle serialization format
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14639 M. Tompsett changed: What|Removed |Added CC||mtomp...@hotmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14639] Extend Koha::MetadataRecord to handle serialization format
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14639 M. Tompsett changed: What|Removed |Added Attachment #41360|0 |1 is obsolete|| --- Comment #7 from M. Tompsett --- Created attachment 41386 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41386&action=edit Bug 14639: (regression tests) Extend Koha::MetadataRecord to handle serialization format and record id In order to use Koha::MetadataRecord as a container for moving records around it is important to let it carry the serialization format of the record object it was built with, so it is easier and cheaper to make decisions about records. This patch introduces regression tests for the changes to be made. The 'format' param is introduced, and also sets default values: schema => 'marc21' format => 'MARC' A new (optional) 'id' param is added so the record carries its own id outside of it. The default behaviour is preserved, and no changes are needed in places Koha::MetadataRecord is used. ->new also returns undef if no record is passed, and raises a carped warning. To test: - Apply this test patch - Run the new tests $ prove t/Koha_MetadataRecord.t => FAIL: Tests shoud fail as the changes are not implemented on Koha::MetadataRecord Edit: made serialization format be upper-case to match what is used on Koha::Filter's Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14531] Check-in statistical report broken
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14531 Tomás Cohen Arazi changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #5 from Tomás Cohen Arazi --- *** This bug has been marked as a duplicate of bug 14598 *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14598] itemtype is not set on statistics by C4::Circulation::AddReturn
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 Tomás Cohen Arazi changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14598] itemtype is not set on statistics by C4::Circulation::AddReturn
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 --- Comment #14 from Tomás Cohen Arazi --- *** Bug 14531 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14598] itemtype is not set on statistics by C4::Circulation::AddReturn
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 --- Comment #13 from Tomás Cohen Arazi --- *** Bug 9351 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14598] itemtype is not set on statistics by C4::Circulation::AddReturn
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 Tomás Cohen Arazi changed: What|Removed |Added Status|Signed Off |Needs Signoff Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14598] itemtype is not set on statistics by C4::Circulation::AddReturn
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 Tomás Cohen Arazi changed: What|Removed |Added Attachment #41205|0 |1 is obsolete|| --- Comment #12 from Tomás Cohen Arazi --- Created attachment 41385 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41385&action=edit Bug 14598: (QA followup) Don't die on bad barcode Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14598] itemtype is not set on statistics by C4::Circulation::AddReturn
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 Tomás Cohen Arazi changed: What|Removed |Added Attachment #41204|0 |1 is obsolete|| --- Comment #11 from Tomás Cohen Arazi --- Created attachment 41384 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41384&action=edit Bug 14598: Make C4::Circulation::AddReturn store the right itemtype This patch makes C4::Circulation::AddReturn correctly store the itemtype on the 'statistics' table. To reproduce: - Checkout master. - Make a checkout. - Check the 'statistics' table and notice the itemtype is correctly set > SELECT * FROM statistics; - Check the item in. - Check the 'statistics' table and notice the itemtype is not set > SELECT * FROM statistics WHERE type="return"; => FAIL: itemtype is set to NULL To test: - Apply the regression tests patch - Run the tests: $ prove t/db_dependent/Circulation/Returns.t => FAIL: Tests fail - Apply this patch - Run the regression tests: $ prove t/db_dependent/Circulation/Returns.t => SUCCESS: Tests now pass. - Repeat the 'To reproduce' steps => SUCCESS: itemtype is now correctly set (in real life) - Happily sign off :-D Sponsored-by: Universidad Empresarial Siglo 21 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9351] item type not recorded correctly in statistics for returns and some local use
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351 Tomás Cohen Arazi changed: What|Removed |Added Status|Failed QA |RESOLVED Resolution|--- |DUPLICATE --- Comment #59 from Tomás Cohen Arazi --- *** This bug has been marked as a duplicate of bug 14598 *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14598] itemtype is not set on statistics by C4::Circulation::AddReturn
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 Tomás Cohen Arazi changed: What|Removed |Added Attachment #41203|0 |1 is obsolete|| --- Comment #10 from Tomás Cohen Arazi --- Created attachment 41383 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41383&action=edit Bug 14598: (regression tests) AddReturn should store itemtype on 'statistics' table This patch adds tests for C4::Circulation::AddReturn(). Both tests are wrapped inside a subtest, and look for AddReturn storing the right itemtype on the 'statistics' table. Note: It also refactors the file a bit, to avoid side effects. And uses TestBuilder to make it independent on already-present db data. It also removes warnings by mocking C4::Context::userenv To test: - Apply the patch - Run the tests: $ prove t/db_dependent/Circulation/Returns.t => FAIL: Tests fail bacause AddReturn is not storing the itemtype - Sign off :-D Sponsored-by: Universidad Empresarial Siglo 21 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14651] New: Koha::Item::effective_itemtype should fallback to biblio-level if no item-level itemtype
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14651 Bug ID: 14651 Summary: Koha::Item::effective_itemtype should fallback to biblio-level if no item-level itemtype Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcha...@gmail.com Reporter: tomasco...@gmail.com QA Contact: testo...@bugs.koha-community.org I fill this bug to start a conversation about this issue. It seems the codebase has several ways of determining the itemtype. For example, C4::Circulation::AddReturn used the biblio-level itemtype (until bug 14598) and C4::Circulation::CanBookBeIssued just sticks to item-level itemtype. At first sight, it seems clear to me that we should start moving into using Koha::Item objects, that even provide an ->effective_itemtype method! Having talked about this on IRC there seems to be a consensus that if the item doesn't have an itemtype, then there should be a fallback to biblio-level itemtype. This means we should add that check to the ->effective_itemtype method. But it would mean including Koha::Biblios. Thoughts? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13886] Add ability to merge records directly from cataloging search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13886 Heather Braum changed: What|Removed |Added CC||hbr...@nekls.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13885] Cataloging search header should include more options
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13885 Heather Braum changed: What|Removed |Added CC||hbr...@nekls.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14650] Public/Staff notes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14650 Tom Misilo changed: What|Removed |Added CC||misi...@fit.edu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14650] New: Public/Staff notes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14650 Bug ID: 14650 Summary: Public/Staff notes Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcha...@gmail.com Reporter: je...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org Public/Staff notes should show up on the Batch item modification page -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9351] item type not recorded correctly in statistics for returns and some local use
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351
--- Comment #58 from Fridolin SOMERS ---
(In reply to Tomás Cohen Arazi from comment #57)
> But I'm not happy with this patchset, as it seems to touch CanBookBeIssued
This code has the same problem as AddReturn since it calls UpdateStats with
$item->{'itemtype'} instead of $item->{'itype'}. Only it works because there is
a dirty hack $item->{'itemtype'}=$item->{'itype'};.
One day maybe this hack will be removed.
Once there is a full abstraction layer with datas surely.
> So, I propose we stick with bug 14598 (which is missing the DB update step)
> and mark this one as duplicate.
+1
Since AddReturn part is much more important.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14527] zebra error 114 when searching for items added before or after a specific date
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14527 --- Comment #19 from Katrin Fischer --- Hi Fridolin, I think the dateaccessioned in MARC21 is a item field related to acquisitions - does UNIMARC have no dateaccessioned or similar in 995? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13023] Nonpublic note for items should be mapped to a database column like itemnotes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13023 Tom Misilo changed: What|Removed |Added CC||misi...@fit.edu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13024] Nonpublic note not appearing in the staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13024 Tom Misilo changed: What|Removed |Added CC||misi...@fit.edu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14527] zebra error 114 when searching for items added before or after a specific date
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14527 --- Comment #18 from Fridolin SOMERS --- In UNIMARC, Date-of-acquisition is usually defined in 099$c, this is the default Zebra configuration. One must use the script misc/maintenance/UNIMARC_sync_date_created_with_marc_biblio.pl to copy creation date from database to 099$c. We usually set it nightly to only update daily modified/created records : misc/maintenance/UNIMARC_sync_date_created_with_marc_biblio.pl --run --where "TO_DAYS(NOW()) - TO_DAYS(biblio.datecreated) <= 1 OR TO_DAYS(NOW()) - TO_DAYS(DATE(biblio.timestamp)) <= 1" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14649] fund names not displayed in budget planning
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14649 Fridolin SOMERS changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |fridolin.som...@biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11714] GetBudgetHierarchy needs optimization
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11714 Fridolin SOMERS changed: What|Removed |Added Blocks||14649 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14649 [Bug 14649] fund names not displayed in budget planning -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14649] fund names not displayed in budget planning
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14649 Fridolin SOMERS changed: What|Removed |Added Depends on||11714 --- Comment #1 from Fridolin SOMERS --- This is a side effect of Bug 11714 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11714 [Bug 11714] GetBudgetHierarchy needs optimization -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14649] New: fund names not displayed in budget planning
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14649 Bug ID: 14649 Summary: fund names not displayed in budget planning Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: fridolin.som...@biblibre.com QA Contact: testo...@bugs.koha-community.org In a budget planning, cgi-bin/koha/admin/aqplan.pl, the fund names are not displayed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10276] Extend IndependentBranches to support groups of libraries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276
--- Comment #82 from Jonathan Druart
---
Comment on attachment 41066
--> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41066
Bug 10276 - Extend IndependentBranches to support groups of libraries
Review of attachment 41066:
-->
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=10276&attachment=41066)
-
::: C4/Acquisition.pm
@@ +1912,5 @@
> +C<@results> is sorted alphabetically by book title.
> +
> +=cut
> +
> +sub GetParcel {
Has been removed by Bug 13318
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14031] Itemnumber should be a numeric search in ccl.properties
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14031 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14031] Itemnumber should be a numeric search in ccl.properties
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14031 Jonathan Druart changed: What|Removed |Added Attachment #39897|0 |1 is obsolete|| --- Comment #10 from Jonathan Druart --- Created attachment 41382 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41382&action=edit Bug 14031 - Itemnumber should be a numeric search in ccl.properties This patch changes the "itemnumber" alias so that it acts like "itemnumber,st-numeric". That is, it always does a numeric search. _TEST PLAN_ The best way to test this patch is to apply the patch and then run "make upgrade", I suspect. As this will refresh your "ccl.properties". However, this patch is actually really small, so you can just apply it manually to an existing "ccl.properties" if you rather save time. Basically, you just need to do the following steps: 0) Do a search for "itemnumber:" 1) Note that you can't retrieve any results 2) Change your ccl.properties to say "itemnumber 1=8010 4=109" 3) Repeat the search for "itemnumber:" 4) Note that you now retrieve your result Signed-off-by: Magnus Enger Tested on a gitified package install. Made the change to /etc/koha/zebradb/ccl.properties manually. After this change I can successfully search for "itemnumber:1". Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11431] Add additional sound options for warnings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431
Jonathan Druart changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #81 from Jonathan Druart
---
QA comments:
1/ There are no tests for new modules
2/ I really would like to see Koha::Template::Plugin::Koha::AudioAlerts moved
somewhere else
3/ SyntaxError: missing ) after condition
ndexOf('http://') == 0 || sound.indexOf('https://') == 0 ) {
Marked as Failed QA.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9936] SIP2 should use C4/Auth.pm for user authentication
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9936 --- Comment #2 from Colin Campbell --- Patch for 9611 switches to callingC4::Auth for password validation but still bypasses ldap & CAS -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14644] SIP2 terminal authentication via telnet transport broken
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14644 Galen Charlton changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9351] item type not recorded correctly in statistics for returns and some local use
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com --- Comment #57 from Tomás Cohen Arazi --- I tried this patchset along with the regression tests I wrote on bug 14598 (because I missed this bug on my first search). The regression tests pass with this patchset. But I'm not happy with this patchset, as it seems to touch CanBookBeIssued which is out of the scope of this bug, without regression tests for it (too). Also, I'm not sure about the DB update, as it seems to update all returns item types, and it should only touch those with NULL values. So, I propose we stick with bug 14598 (which is missing the DB update step) and mark this one as duplicate. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14648] New: Batch Remove Reserve Items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14648 Bug ID: 14648 Summary: Batch Remove Reserve Items Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Course reserves Assignee: koha-bugs@lists.koha-community.org Reporter: misi...@fit.edu QA Contact: testo...@bugs.koha-community.org Hi, It would be great to see the ability to mass remove course reserves. For example, if given a list of Barcodes have the option to remove the items from any course they are tied to. This would be useful at the end of an academic semester, when books are returned to their original shelving location. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13663] offline circ permission issue
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13663 --- Comment #16 from Jonathan Druart --- Created attachment 41381 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41381&action=edit Bug 13663: (followup) fixes tab char QA test fails Fixes the tab char qa test suite fails in the following files: 1/ tools/upload-file-progress.pl 2/ tools/upload-file.pl Signed-off-by: Jonathan Druart Amended patch: tidy whitespaces -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13663] offline circ permission issue
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13663 Jonathan Druart changed: What|Removed |Added Attachment #40123|0 |1 is obsolete|| Attachment #40124|0 |1 is obsolete|| --- Comment #15 from Jonathan Druart --- Created attachment 41380 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41380&action=edit Bug 13663 - Fix permissions in upload-file.pl and upload-file-progress.pl Test plan: Verify that the circulate_remaining_permissions perm is enough to upload .koc file. Signed-off-by: Indranil Das Gupta (L2C2 Technologies) Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13663] offline circ permission issue
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13663 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14507] SIP Authentication broken when LDAP Auth Enabled
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14507 Colin Campbell changed: What|Removed |Added Assignee|gmcha...@gmail.com |colin.campbell@ptfs-europe. ||com Status|NEW |Needs Signoff --- Comment #4 from Colin Campbell --- Created attachment 41379 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41379&action=edit Potential patch This patch changes the Auth routine to one that takes account of authentication sources other than simple pw in the database. I have only tested this in the context of a password authenticating database NB the patron information request/response pair's function is not primarily authentication and supplying a password is optional, the sip process returns a password OK for an empty password field, this is done because some clients have traditionally sent an empty field rather than skipping it completely Please test if this enables authentication using LDAP -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11625] Default to logged in library for circ rules and notices & slips
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11625 Jonathan Druart changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com, ||paul.poul...@biblibre.com --- Comment #48 from Jonathan Druart --- Ccing some QAers since we are waiting for feedbacks for 3 months now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13485] Add a page to display links to restricted sites
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13485 --- Comment #21 from Jonathan Druart --- Created attachment 41378 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41378&action=edit Bug 13485: Use the Koha template plugin to access syspref values And remove the useless use of the KohaDates plugin Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13485] Add a page to display links to restricted sites
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13485 Jonathan Druart changed: What|Removed |Added Attachment #40820|0 |1 is obsolete|| Attachment #40821|0 |1 is obsolete|| Attachment #40822|0 |1 is obsolete|| --- Comment #20 from Jonathan Druart --- Created attachment 41377 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41377&action=edit Bug 13485 - Add a proxy page To test: I) Apply the patch II) Run updatedatabase.pl scenario I) 1) Add some content in ProxyPageContent and ProxyPageTitle sysprefs. 2) Add your machine ip (ex. 127.0.0) 3) Validate cgi-bin/koha/opac-proxypage.pl shows a page with ProxyPageContent and ProxyPageTitle contents. scenario II) 1) Logout opac page 2) Add some content in ProxyPageContent and ProxyPageTitle sysprefs. 3) Add other ip that your machine ip. 4) Validate: cgi-bin/koha/opac-proxypage.pl shows a login page. 5) Validate: cgi-bin/koha/opac-proxypage.pl shows a page with ProxyPageContent and ProxyPageTitle contents after login. Followed both scenarios, works as expected. Signed-off-by: Marc Veron Signed-off-by: Kyle M Hall Bug 13485 [QA Followup] Signed-off-by: Kyle M Hall Bug 13485 - Atomic Update + Rename Proxy page to Restricted page Test plan: I) Apply the patch II) Run updatedatabase.pl scenario I) 1) Add some content in RestrictedPageContent and RestrictedPageTitle sysprefs. 2) Add your machine ip (ex. 127.0.0) 3) Validate cgi-bin/koha/opac-restrictedpage.pl shows a page with RestrictedPageContent and RestrictedPageTitle contents. scenario II) 1) Logout opac page 2) Add some content in RestrictedPageContent and RestrictedPageTitle sysprefs. 3) Add a diffrent ip. 4) Validate: cgi-bin/koha/opac-restrictedpage.pl shows a login page. 5) Validate: cgi-bin/koha/opac-restrictedpage.pl shows a page with RestrictedPageContent and RestrictedPageTitle contents after login. new file: installer/data/mysql/atomicupdate/Bug13485_RestrictedSitesPage.sql modified: installer/data/mysql/sysprefs.sql modified: koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref renamed:koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-proxypage.tt -> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-restrictedpage.tt renamed:opac/opac-proxypage.pl -> opac/opac-restrictedpage.pl Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13485] Add a page to display links to restricted sites
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13485 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org Status|Signed Off |Passed QA --- Comment #19 from Jonathan Druart --- I think it would have been better to use network list (192.168.1.255) instead of the start of the ips to allow. Note that superlibrarian can access to the page, even if the user is not connected from the ips allowed, is it expected? I will submit a follow-up to access pref from the templates, squash the patches (not to add and remove files in the same patch set). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #10 from Jonathan Druart --- I have the same feeling as David, it sounds a bit hacky. I understand your problem, but you have to provide something useful for others, not a specific stuffs for you. I would like to see some docs on the help page to explain what it is possible to do with this new fields. As David said, I don't think it's a good idea to add this field at the server level, we could have the need to use 4=109 and 4=1 in the same query. A dropdown list in front of each field sounds more useful and flexible. I don't mark it as failed, I would like to get another QAer's opinion. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14306] Show URL from MARC21 field 555$u under Title Notes (OPAC) or Descriptions (Staff)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14306 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |BLOCKED --- Comment #9 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #8) > What is this second patch, there is no signoff on it? Hm. I rebased the patch but forgot to take the one with the signoff.. I will resubmit. > I don't think generating html in the module is a good idea. But it's > certainly the quickest fix and will avoid to copy/paste code in the > different templates. I will still have a look for a simple follow-up. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11194] Add a new index for "Edition Statement" of a MARC Record
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11194 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14310] Add ability to suspend and resume individual holds from the patron holds table
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14310 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #11 from Jonathan Druart --- Kyle, I am afraid that there is a lack of tests for the 2 new methods added to Koha::Hold -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11194] Add a new index for "Edition Statement" of a MARC Record
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11194 Jonathan Druart changed: What|Removed |Added Attachment #40321|0 |1 is obsolete|| --- Comment #11 from Jonathan Druart --- Created attachment 41376 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41376&action=edit Bug 11194: Add a new index for "Edition Statement" of a MARC Record Adds the "Edition Statement" MARC-field as a sortable search index in Koha. This Field is also used by the MARC::Record->edition(). It is mapped to search keyword "edition" and it targets the following MARC-fields: UNIMARC: all 205-subfields concatenated MARC21 : all 250-subfields concatenated NORMARC: all 250-subfields concatenated After applying this patch a full biblio reindexing needs to be done to make old records searchable. New Biblios, and Biblios that are part of some operations (checkin/out/hold/...), are searchable. These generate good test data to test this feature without fully reindexing the search index. TEST PLAN: 0. Move the search index and search word definitions from the koha source code to the directory where Zebra uses them. This is most easiest to do by reinstalling Koha, but can be manually moved as well. 1. Find a record with some data in the "Edition Statement" -field. 2. Modify that Record and reindex it. 3. Search with the keyword "edition=''" where is the stuff you wrote in the MARC-field. 4. Observe the found record. Signed-off-by: Bernardo Gonzalez Kriegel Tested on MARC21 and UNIMARC, works No errors Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14468] Remove warnings when creating Labels
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14468 Jonathan Druart changed: What|Removed |Added Attachment #40741|0 |1 is obsolete|| --- Comment #12 from Jonathan Druart --- Created attachment 41375 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41375&action=edit Bug 14468: Remove warnings when creating Labels This patch removes 2 types of warnings when creating Labels a) Using '0' as filling char is not to the like of prStrWidth On C4/Creators/Layout.pm b) A RM followup from Galen on Bug 8375 to C4/Creators/PDF.pm makes impossible to find properly a font :( (http://git.koha-community.org/gitweb/?p=koha.git;a=commit;h=f7ef93e758850e991091e7268b8d1b1453082df4) on C4/Labels/Label.pm To test: Pre patch 1) Go to Tools > Labels 2) Create a new layout, name ABC, type 'Barcode/Biblio' 3) Create a new batch, add 2 items 4) Export as PDF using the new layout 5) Look at logs, you will find something like a) label-create-pdf.pl: Use of uninitialized value $strwidth in numeric lt (<) at /home/bgkriegel/kohaclone/C4/Creators/Layout.pm line 233., referer: http://staffdev.koha-community.org.ar/cgi-bin/koha/labels/label-print.pl (Only one of this kind) b) Two related lines similar to this examples label-create-pdf.pl: Use of uninitialized value in -e at /home/bgkriegel/kohaclone/C4/Creators/PDF.pm line 226., referer: http://staffdev.koha-community.org.ar/cgi-bin/koha/labels/label-print.pl label-create-pdf.pl: ERROR in koha-conf.xml -- missing /path/to/font.ttf at /home/bgkriegel/kohaclone/C4/Creators/PDF.pm line 229., referer: http://staffdev.koha-community.org.ar/cgi-bin/koha/labels/label-print.pl (many many lines x number of items on batch) 6) Apply the patch 7) Export the same PDF, no more warnings 8) Bonus 1: change main font to Courier and Helvetica and check results 9) Bonus 2: check using arabic records Many hours to find :( Easy to fix Signed-off-by: Nick Clemens Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14468] Remove warnings when creating Labels
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14468 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #11 from Jonathan Druart --- (In reply to Bernardo Gonzalez Kriegel from comment #10) > (In reply to Jonathan Druart from comment #9) > > (In reply to Chris Nighswonger from comment #6) > > > That all sounds good. I wish I had time to sign off! > > > > Chris, > > I am not confident with part of code, it would be great to get your signoff > > on this one :) > > Hi Jonathan, > while waiting to Chris, which part of the code is giving you trouble? > I can review it if you want Hum, all C4::Creators? :) It works as expected but I cannot be sure the patch won't introduce regressions. Looking at it again and all looks good. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10253] tax rate only takes 1 decimal point
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10253 Jonathan Druart changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=14541 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14541] Tax rate should not be forced to an arbitrary precision
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14541 Jonathan Druart changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=10253 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14541] Tax rate should not be forced to an arbitrary precision
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14541 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Failed QA CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #5 from Jonathan Druart --- Kyle, The tax rate is displayed at several places, at least acqui/supplier.tt. The change should affect all the places where it is displayed. You should also have a look at how I display them on bug 13323 using a template plugin: [% order.gstrate * 100 | $Price %] I can provide a patch on top of bug 13323 if you can wait for it to be pushed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14534] Stop overdue_notices.pl from issuing the warning: Use of uninitialized value $borrowernumber
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14534 Jonathan Druart changed: What|Removed |Added Attachment #41094|0 |1 is obsolete|| --- Comment #4 from Jonathan Druart --- Created attachment 41374 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41374&action=edit Bug 14534: Stop overdue_notices.pl from issuing the warning: Use of uninitialized value $borrowernumber Signed-off-by: Chris Cormack To test: 1/ Run the overdue_notices.pl script (don't do this on production obviously :)) 2/ Notice the warns 3/ Apply patch 4/ Run again 5/ Notice no warns, but notices are still generated ok Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14534] Stop overdue_notices.pl from issuing the warning: Use of uninitialized value $borrowernumber
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14534 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9011] Add the ability to store the last patron to return an item
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9011 Jonathan Druart changed: What|Removed |Added Status|Signed Off |In Discussion -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11937] opac link doesn't open in new window
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11937 Mason James changed: What|Removed |Added CC||m...@kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14297] Holds Queue building ignoring holds where pickup & home branch don't match and item is not from least cost branch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14297 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #5 from Jonathan Druart --- Any chances to get some tests to highlight this change? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13895] Add API routes for issues retrieval and renewal
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org Status|Signed Off |BLOCKED --- Comment #6 from Jonathan Druart --- Blocked by bug 13799. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9351] item type not recorded correctly in statistics for returns and some local use
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9351 Jonathan Druart changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=14598 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14598] itemtype is not set on statistics by C4::Circulation::AddReturn
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=9351 --- Comment #9 from Jonathan Druart --- Is it a duplicate of bug 9351? I would say we need to update existing rows. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14644] SIP2 terminal authentication via telnet transport broken
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14644 Colin Campbell changed: What|Removed |Added Attachment #41359|0 |1 is obsolete|| --- Comment #2 from Colin Campbell --- Created attachment 41373 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41373&action=edit Signed Off patch Signed off - works as described -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14527] zebra error 114 when searching for items added before or after a specific date
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14527 Katrin Fischer changed: What|Removed |Added CC||ro...@catalyst.net.nz --- Comment #17 from Katrin Fischer --- (In reply to David Cook from comment #16) > Typically, it's not a good idea to patch individual files, and instead wait > for bug fix updates, but since this is a configuration file stored in > /etc... I don't think bug fix updates will touch it. > > I think if it were fixed in master, it would only be fixed for new > installs... perhaps someone else can correct me... I don't think that's quite correct and depending on how you installed it different things might happen. For an older standard installation, rerunning the Makefile.pl during the update process will update your index definitions as well: perl Makefile.PL --prev-install-log make make test sudo make upgrade I am adding Robin because I think he can tell what happens for a package installation. To my knowledge the index definitions are updated there as well - we build our own packages with some additional indexes and that seems to work perfectly fine. But I think local changes might create problems and even keep the files from updating. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14601] Cardnumber should not be required for patron import
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14601 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org, ||stephane.delaune@biblibre.c ||om --- Comment #6 from Jonathan Druart --- CCing Stéphane, I would like to get your opinion on this point. Do you have the same problem when you migrate/import patrons to Koha? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14586] Update 3.18 Koha team with new release maintainers
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14586 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14586] Update 3.18 Koha team with new release maintainers
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14586 Jonathan Druart changed: What|Removed |Added Attachment #41116|0 |1 is obsolete|| Attachment #41211|0 |1 is obsolete|| --- Comment #5 from Jonathan Druart --- Created attachment 41372 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41372&action=edit Bug 14586 - Update about page with new 3.18 release team To test: Look at more -> about koha in the staff client, Koha team tab. It should list the correct names for the release maintainers. Signed-off-by: Mirko Tietgen Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14605] The description on pay/write off individual fine is wrong
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14605 --- Comment #7 from Jonathan Druart --- And what about existing rows in the DB? Do you think it's possible to update them? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14605] The description on pay/write off individual fine is wrong
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14605 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #6 from Jonathan Druart --- I would say that the expected behavior was to display the description (what you did) and the title of the biblio, don't you think? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12748] Serials - two issues with status of "Expected"
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12748 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Failed QA --- Comment #5 from Jonathan Druart --- Rémi, Could you please provide some tests for the changes you have done to ModSerialStatus? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12748] Serials - two issues with status of "Expected"
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12748 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12748] Serials - two issues with status of "Expected"
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12748 Jonathan Druart changed: What|Removed |Added Attachment #41230|0 |1 is obsolete|| --- Comment #4 from Jonathan Druart --- Created attachment 41371 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41371&action=edit Bug 12748: QA Fixes - Use the constant instead of the code (1 vs EXPECTED) - Avoid interpolation in query - use selectall_arrayref instead of fetchall_arrayref -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12748] Serials - two issues with status of "Expected"
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12748 Jonathan Druart changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |remi.mayrand-provencher@inL |ity.org |ibro.com CC||jonathan.dru...@bugs.koha-c ||ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14364] Allow automatically canceled expired waiting holds to fill the next hold
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14364 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Needs Signoff CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #3 from Jonathan Druart --- I would like to get another signoff on this one please. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9809] Get rid of reserveconstraints
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9809 Jonathan Druart changed: What|Removed |Added Assignee|jonathan.dru...@bugs.koha-c |k...@bywatersolutions.com |ommunity.org| --- Comment #12 from Jonathan Druart --- Yes it is! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14557] Add holds count to holds tab
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14557 Jonathan Druart changed: What|Removed |Added Attachment #41239|0 |1 is obsolete|| Attachment #41240|0 |1 is obsolete|| --- Comment #8 from Jonathan Druart --- Created attachment 41369 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41369&action=edit Bug 14557 - Clean up biblio-view-menu.inc Signed-off-by: Jason Robb Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14557] Add holds count to holds tab
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14557 --- Comment #9 from Jonathan Druart --- Created attachment 41370 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41370&action=edit Bug 14557 - Add holds count to holds tab Some librarians have expressed that it would be helpful if the holds tab displayed the count of holds for a record. Test Plan: 1) Apply this patch 2) Note the Holds tab for a record now displays the number of holds for that record Signed-off-by: Jason Robb Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10612] Add ability to delete patrons with batch patron deletion tool
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 --- Comment #41 from Katrin Fischer --- Hi Jonathan, thx for testing! - I will rerun my test and see if I did something differently. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14557] Add holds count to holds tab
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14557 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org Status|Signed Off |Passed QA --- Comment #7 from Jonathan Druart --- I am not a fan of using template plugins for this kind of usage, but I don't see another good and easy way to do this job. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12372] Make koha-mysql handle arbitrary mysql arguments
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12372 --- Comment #22 from Jonathan Druart --- Created attachment 41367 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41367&action=edit Bug 12372: (QA followup) Standardized argument parsing for koha-mysql. http://bugs.koha-community.org/show_bug.cgi?id=12372 Signed-off-by: Liz Rea Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12372] Make koha-mysql handle arbitrary mysql arguments
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12372 --- Comment #23 from Jonathan Druart --- Created attachment 41368 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41368&action=edit Updated man pages for koha-mysql http://bugs.koha-community.org/show_bug.cgi?id=12372 Signed-off-by: Liz Rea Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12372] Make koha-mysql handle arbitrary mysql arguments
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12372 Jonathan Druart changed: What|Removed |Added Attachment #41245|0 |1 is obsolete|| Attachment #41246|0 |1 is obsolete|| Attachment #41247|0 |1 is obsolete|| --- Comment #21 from Jonathan Druart --- Created attachment 41366 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41366&action=edit Bug 12372: koha-mysql: process any mysql args Signed-off-by: Ian Bays Signed-off-by: Liz Rea Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12372] Make koha-mysql handle arbitrary mysql arguments
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12372 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14337] AllowRenewalIfOtherItemsAvailable counts holdable not for loan items when checking renewability
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14337 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Failed QA CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #4 from Jonathan Druart --- Kyle, please provide tests for this change. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
