[Koha-bugs] [Bug 12356] Stay in advanced search and keep settings when it returns no results.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12356 Viktor Sarge changed: What|Removed |Added Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #1 from Viktor Sarge --- Don't know who to thank but this one is done now :) I guess it should be marked as a duplicate, but I don't know of what bug. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14672] Payment is not able to done, when the patron has credit balance
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14672 Joonas Kylmälä changed: What|Removed |Added Attachment #41612|0 |1 is obsolete|| --- Comment #4 from Joonas Kylmälä --- Created attachment 41647 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41647&action=edit Bug 14672 - Payment is not able to done, when the patron has credit balance This is fixed version of the yesterday's patch, the credit was calculated wrongly and now it's fixed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14691] Can't delete patron with ' character in cardnumber
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14691 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #4 from David Cook --- I encountered this a while ago and thought about fixing it as well, but then Chris Cormack pointed me to http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 which should fix this problem everywhere I think? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13235] Revise layout of patron search form
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13235 Heather Braum changed: What|Removed |Added CC||hbr...@nekls.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14690] Patron import tool page missing extra search patron options
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14690 Liz Rea changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14690] Patron import tool page missing extra search patron options
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14690 --- Comment #2 from Liz Rea --- Created attachment 41646 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41646&action=edit Bug 14690 - [3.18.x] Patron import tool page missing extra search patron options To test, apply the patch and navigate to the Patrons home page. Expand the hidden search fields in the search header and confirm that the layout looks correct. Perform some searches and check that the results are correct and that the modified search fields retain their state. Also please be sure to check the patron import page. Owen is listed as the author of this, because that's mostly true - I just resolved the conflict for 3.18.x (LR) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14690] Patron import tool page missing extra search patron options
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14690 Liz Rea changed: What|Removed |Added CC||l...@catalyst.net.nz --- Comment #1 from Liz Rea --- This is not an issue in 3.20, because of bug 13235. I'm about to attach a modified version of the patch for 3.18. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14691] Can't delete patron with ' character in cardnumber
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14691 --- Comment #3 from Liz Rea --- Created attachment 41645 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41645&action=edit Bug 14691 - Can't delete patron with ' character in cardnumber Test plan: 1. Create patron account with cardnumber sss' and save the account. 2. Try to delete the account. Nothing happens. 3. Apply the patch, refresh the page. 4. Try to delete the account; note the Delete pop-up message that now appears. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14691] Can't delete patron with ' character in cardnumber
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14691 Liz Rea changed: What|Removed |Added CC||l...@catalyst.net.nz Attachment #41644|0 |1 is obsolete|| --- Comment #2 from Liz Rea --- Comment on attachment 41644 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41644 Bug 14691 - Can't delete patron with ' character in cardnumber Oops, typo. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14691] Can't delete patron with ' character in cardnumber
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14691 --- Comment #1 from Liz Rea --- Created attachment 41644 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41644&action=edit Bug 14691 - Can't delete patron with ' character in cardnumber Test plan: 1. Create patron account with cardnumber sss' and save the account. 2. Try to delete the account. Nothing happens. 3. Apply the patch, refresh the page. 4. Try to delete the account; note the Delete pop-up message that now appears. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14691] Can't delete patron with ' character in cardnumber
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14691 Liz Rea changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14658] Split PatronSelfRegistrationBorrowerUnwantedField into two preferences for creating and editing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14658 --- Comment #1 from Jesse Weaver --- Created attachment 41643 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41643&action=edit Bug 14658 - Split PatronSelfRegistrationBorrowerUnwantedField into two preferences for creating and editing Test plan: 1) Make sure there is at least one field in PatronSelfRegistrationBorrowerUnwantedField. 2) Apply patch, and update database. 3) Check to make sure that the new system preference PatronSelfModificationBorrowerUnwantedField has the same value as PatronSelfRegistrationBorrowerUnwantedField. 4) Verify that the same fields are hidden for self-registering a new borrower and edting a new one (both on the OPAC). 5) Change PatronSelfModificationBorrowerUnwantedField, and verify that the two preferences correctly apply to editing vs. creating. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14658] Split PatronSelfRegistrationBorrowerUnwantedField into two preferences for creating and editing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14658 Jesse Weaver changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14667] Label creator UI/UX revamp
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14667 --- Comment #12 from Liz Rea --- :) I can totally understand where you're coming from there. I have observed, when watching librarians learn this tool, that they just don't read it, and the wall of text distracts them from what they are supposed to do. Possibly though, that's because I emphasize the help in the upper right hand corner so they get it drilled into them to look there for help. Certainly the decision to remove it isn't scientific by any stretch, just based on my observations of people using the tool. :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14667] Label creator UI/UX revamp
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14667 --- Comment #11 from Chris Nighswonger --- On the other hand, I thought it was cool and that every tool should have a solid intro page which gives a brief overview of its purpose and usage. But that's just my opinion. And pretty biased at that since I created it. ;-) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14367] History for MARC records. Roll back changes on a timeline or per field.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14367 Nick Clemens changed: What|Removed |Added CC||n...@quecheelibrary.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14367] History for MARC records. Roll back changes on a timeline or per field.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14367 --- Comment #1 from Martin Persson --- Created attachment 41642 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41642&action=edit Bug 14367: Add MARC record history This is a proof-of-concept implementation for adding history support to MARC records. Every time a change is made a complete copy of the record is stored along with the date/time and user identity. The changes are listed under each field in the MARC record editor and can be reverted with a click. The changes are stored as a JSON array in a new column named 'history' in the database. The array is re-read from the database before updating the record to prevent old data lingering in the session from overwriting newer changes made by other users. If we decide to implement this feature it might be better to simply create a new table altogether and link it rather than the clumsy JSON solution. That would eliminate a lot of bulky code that transforms MARC-KOHA-JSON and back while ensuring data integrity. Also, there are plans to add permissions to the MARC records; this likely requires more complex interactions that will scale badly with the current JSON solution. At present, the history is hardcoded to 10 entries. This can easily be made into a syspref. The current implementation should probably be refactored into a 'BiblioHistory' class before deploying. Documentation of the functions/methods are also needed. Icon is ugly and needs to be improved. Sponsored-By: Halland County Library Test plan: * Log into OPAC, search for a title, chose to edit it's MARC record. * Chose a MARC field and modify it, press Save. * Open the MARC editor again for the same title. * Next to the edited field a new icon should appear, looking like a clock face with a encircling arrow; the history icon. * Clicking the icon should open a table showing all changes done to the record, including value change, date/time and user name. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14685] Cannot set guarantor for a child account
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14685 Liz Rea changed: What|Removed |Added Attachment #41577|0 |1 is obsolete|| --- Comment #6 from Liz Rea --- Created attachment 41640 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41640&action=edit Bug 14685: Fix set guarantor for a child or professional accounts Bug 13970 removed some useful code to automatically set the guarantor when creating a child. But finally there is a better way to do the job, we just need to assume that only children or professional can have a guarantor. Test plan: 1/ Create an adult patron and add a child. 2/ The guarantor info should be retrieved and set on the child creation page. 3/ Create an organization and add a child 4/ The guarantor info should be retrieved and set on the adult creation page. Signed-off-by: Liz Rea This patch catches both cases, thanks Jonathan! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14584] Encoding broken with system preferences
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14584 Tomás Cohen Arazi changed: What|Removed |Added Attachment #41632|0 |1 is obsolete|| --- Comment #7 from Tomás Cohen Arazi --- Created attachment 41641 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41641&action=edit [SIGNED OFF] Bug 14584: Encoding broken with system preferences The pref are double encoded. From bug 12411: "This will fix the encoding issues existing in 3.14 and 3.16. The issue still appear in master but is fixed by bug 11944." They should not have been pushed together. Test plan: 1) You need an accentuated language installed. 2) Go to NoLoginInstructions pref, and add some accentuated message like "Hélo médames é mècieüx" 3) refresh opac home page, message should be gibberish 4) apply patch. Message should be ok now. Signed-off-by: Tomas Cohen Arazi Works as expected. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14685] Cannot set guarantor for a child account
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14685 Liz Rea changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14584] Encoding broken with system preferences
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14584 Tomás Cohen Arazi changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14667] Label creator UI/UX revamp
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14667 --- Comment #10 from Liz Rea --- I didn't - the reason I didn't is because it is not like any other page. That help should be in the upper right hand help menu, in my opinion. Also thank you very much for helping out with the translation stuff. :) Cheers, Liz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14305] Public way to look at the Opac of different branches
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14305 --- Comment #2 from Martin Persson --- Created attachment 41639 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41639&action=edit Bug 14305: View arbitrary branch's news, RSS fix This fix changes the RSS link to reflect the URL paramter override. This is less elegant than the existing solution which uses the Branches TT module, perhaps there is a better way? Sponsored-By: Halland County Library Test plan: * Follow instructions in the original patch but also check the URLs and contents of the RSS link at the bottom the OPAC page. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14305] Public way to look at the Opac of different branches
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14305 Martin Persson changed: What|Removed |Added Change sponsored?|--- |Sponsored CC||xarra...@gmail.com Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14305] Public way to look at the Opac of different branches
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14305 --- Comment #1 from Martin Persson --- Created attachment 41638 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41638&action=edit Bug : View arbitrary branch's news This patch adds an input named 'branch' to opac-main.pl that allows overriding the home library to view news from any branch. This is part of the 'Use Koha as a CMS' development. To reviewers: Does this create any security implications? The column is text; it is possbile to push SQL statemens into the DB via the opac-membership.pl page, but all the code there seems to use DBIx::Class and prepared statements. When attemped, accepting the changes were rejected because of the foreign key constraint placed on the main borrowers table. It is recommended to use this patch in conjunction with 11584 which adds a WYSIWYG editor to System Preferences. Test plan: * Make sure your Koha installation has multiple branches: * Log in to the Staff interface and select 'Koha administration' * Select 'Libraries and groups', the first item in the list * Add an extra branch named 'BRANCH1': * Press the 'New library' button * Set 'Library code' to 'BRANCH1' * Enter an arbitrary name * Press 'Submit' * Add at least two news items with different branches: * Log in to the Staff interface and select 'Tools' * Under 'Additional tools' select 'News' * On the 'Koha news' page, create a news item for all libraries: * Press the 'New entry' button * Set 'Library' to 'All libraries' and enter a title. * Press 'Submit' * On the 'Koha news' page, create a news item for one library: * Press the 'New entry' button * Set 'Library' to 'BRANCH1' and enter a title * Press 'Submit' * Add links to OPAC to select branch: * Select 'System preferences' and then the 'OPAC' tab * Scroll down to the 'OpacNav' preference and click 'Click to Edit' * Create two hyperlinks with a parameter named 'branch': * 'BRANCH1' * 'none' * Click 'Save all OPAC preferences' * Test OPAC: * By default, global news and news for home branch should show. * When clicking the 'BRANCH1' link, you should see global news plus news for the BRANCH1 branch. * When the parameter 'branch' is set but has no value, news from the home branch should be shown. Issues: Tricky to create a link to the same page which removes existing paramters. The user normally has a home branch set. We can override it with the parameter. If undefined, the home branch should be shown. Sponsored-by: Halland County Library -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14691] New: Can't delete patron with ' character in cardnumber
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14691 Bug ID: 14691 Summary: Can't delete patron with ' character in cardnumber Change sponsored?: --- Product: Koha Version: 3.18 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: hbr...@nekls.org QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com If a patron cardnumber has a ' character in it, and you try to delete the account, nothing happens -- the delete pop-up message doesn't appear. This appears to not affect cards with any other special character, and I've tested " & - so far]. It's only cardnumbers with the ' character in them. Test plan: 1. Create patron account with cardnumber sss' and save the account. 2. Try to delete the account. Nothing happens. 3. Edit the account, and remove the ' character. Save the acccount. 4. Try to delete the account; note the Delete pop-up message that now appears. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14690] New: Patron import tool page missing extra search patron options
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14690 Bug ID: 14690 Summary: Patron import tool page missing extra search patron options Change sponsored?: --- Product: Koha Version: 3.18 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: hbr...@nekls.org QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com The Search Patrons box at the top of import_borrowers.pl has a + sign so you can reveal the extra options to search by library and/or categorycode. All that happens when you click on the [+] link, the [+] changes to a [-], and vice versa. No extra line is revealed. Test plan: 1.) Go to Tools --> Import Patrons. 2.) Click on the Search Patrons box (if it isn't activated already). 3.) Click on the [+] link next to the search box. 4.) Note that it changes to [-], but no extra line is revealed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5771] Better error handling for import borrowers - Provide a download file of errors
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5771 Heather Braum changed: What|Removed |Added CC||hbr...@nekls.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14689] Marc field 648 does not appear in the subject index
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14689 Tomás Cohen Arazi changed: What|Removed |Added Component|OPAC|Searching Assignee|tomasco...@gmail.com|gmcha...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14689] Marc field 648 does not appear in the subject index
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14689 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com Assignee|oleon...@myacpl.org |tomasco...@gmail.com Severity|major |normal -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14689] Marc field 648 does not appear in the subject index
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14689 Tomás Cohen Arazi changed: What|Removed |Added Version|3.20|master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14598] itemtype is not set on statistics by C4::Circulation::AddReturn
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 --- Comment #19 from Tomás Cohen Arazi --- Created attachment 41637 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41637&action=edit Bug 14598: (DB update) fix NULL itemtypes in statistics on 'return' rows This patch introduces an updatedatabase.pl block that updates the rows that lack itemtype. It relies on Koha::Item->effective_itemtype() to choose the rigt one. I wrote it using SQL because the statistics table lacks PKs. Note: I'm not sure about making this dependent on 14651, I need a QA POV on this, and I'm biased as I wrote all the related patches... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14598] itemtype is not set on statistics by C4::Circulation::AddReturn
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 Tomás Cohen Arazi changed: What|Removed |Added Depends on||14651 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14651 [Bug 14651] Koha::Item::effective_itemtype should fallback to biblio-level if no item-level itemtype -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14651] Koha::Item::effective_itemtype should fallback to biblio-level if no item-level itemtype
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14651 Tomás Cohen Arazi changed: What|Removed |Added Blocks||14598 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 [Bug 14598] itemtype is not set on statistics by C4::Circulation::AddReturn -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14651] Koha::Item::effective_itemtype should fallback to biblio-level if no item-level itemtype
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14651 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14651] Koha::Item::effective_itemtype should fallback to biblio-level if no item-level itemtype
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14651 --- Comment #2 from Tomás Cohen Arazi --- Created attachment 41636 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41636&action=edit Bug 14651: Koha::Item->effective_itemtype fallback to bib-level In some situations (bad migrations, old bugs that introduced bad data, people having bib-level itypes for ages and switching to item level...) the user ends with undex itype values for items. The current code, if the user has item_level-itype set, just returns undef. It should fallback to bib-level. To test: - Run the regression tets: $ prove t/db_dependent/Items.t => FAIL: tests fail. - Apply the patch - Run the tests again => SUCCESS: The tests now pass. - Sign off :-D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14651] Koha::Item::effective_itemtype should fallback to biblio-level if no item-level itemtype
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14651 --- Comment #1 from Tomás Cohen Arazi --- Created attachment 41635 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41635&action=edit Bug 14651: (regression test) fallback to bib-level if itype is undef Koha::Item->effective_itemtype should fallback to biblio-level itemtype even if item-level item types are set, in the case the item has no itemtype set (bad migration, bad old code). To test: - Run $ prove t/db_dependent/Items.t => FAIL: Koha::Item->effective_itemtype doesn't work properly -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14689] New: Marc field 648 does not appear in the subject index
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14689 Bug ID: 14689 Summary: Marc field 648 does not appear in the subject index Change sponsored?: --- Product: Koha Version: 3.20 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: OPAC Assignee: oleon...@myacpl.org Reporter: verolenci...@yahoo.com.ar QA Contact: testo...@bugs.koha-community.org Actually you cannot search content stored in the Marc21 648 field (Subject Added Entry - Chronological Term). Terms stored in the $a subfield of this field should be searchable through the normal subject index. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14509] Koha still allows spaces at the end, beginning or as your password
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14509 --- Comment #7 from Joonas Kylmälä --- (In reply to Jonathan Druart from comment #6) > (In reply to Joonas Kylmälä from comment #5) > > (In reply to Owen Leonard from comment #4) > > > (In reply to Joonas Kylmälä from comment #3) > > > > Shouldn't we change it to server side > > > > as it looks like all the other fields are checked that way. > > > > > > There are changes to the template and to opac-passwd.pl. To confirm, > > > disable > > > JavaScript and see if the server-side check is working correctly as well. > > > > opac-passwd.pl is for the end user server side check, right? I disabled > > JavaScript in the staff side and there wasn't any check from the server > > side, it allowed to change the password (this was also mentioned in the test > > plan). So should we change the code so that it checks for the whitespaces in > > the server side when the password is changed from the staff view? > > If you like, you can provide it. > But I don't know why a librarian will force a password if the application > denies it. Librarian doesn't need to force the password, only use a browser where the JavaScript is disabled. So I give one vote for the server side check. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14607] Baker & Taylor cover images should be accessible by UPC as well as ISBN
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14607 Nick Clemens changed: What|Removed |Added CC||n...@quecheelibrary.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11431] Add additional sound options for warnings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431 --- Comment #82 from Kyle M Hall --- Created attachment 41634 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41634&action=edit Bug 11431 [QA Followup] - Fix js error -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14607] Baker & Taylor cover images should be accessible by UPC as well as ISBN
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14607 Jesse Weaver changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14607] Baker & Taylor cover images should be accessible by UPC as well as ISBN
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14607 Jesse Weaver changed: What|Removed |Added Attachment #41393|0 |1 is obsolete|| --- Comment #2 from Jesse Weaver --- Created attachment 41633 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41633&action=edit Bug 14607: Baker & Taylor cover images should be accessible by UPC as well as ISBN Test plan (requires Baker and Taylor cover images to be set up and enabled): 1. Create a record with an ISBN that does not have a cover and a UPC that does. 141985934X/085391174929 is one set that works well. 2. Verify that the record shows up as "No image available" in the following OPAC locations: shelf browser, reviews, lists, search and reading record. This will require adding reviews/checkouts/etc. for the record in question. 3. Apply patch. 4. Check the locations again, and verify that the record now has a valid cover image. Signed-off-by: Alexis Rodegerdts -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14607] Baker & Taylor cover images should be accessible by UPC as well as ISBN
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14607 Nicole C. Engard changed: What|Removed |Added Status|NEW |Needs Signoff CC||neng...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14584] Encoding broken with system preferences
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14584
--- Comment #4 from Jonathan Druart
---
(In reply to Blou from comment #3)
> Well, I'm fine with that, but isn't it just making this function useless? I
> think what you're suggesting is what it was before the latest change. I
> just presumed there had been a need for that "encode('UTF-8'" call...
Not useless, it can be called from the templates.
Back 1 year ago, from bug 12411:
"This will fix the encoding issues existing in 3.14 and 3.16.
The issue still appear in master but is fixed by bug 11944."
So bug 12411 should not have been pushed to master or 11944 should have
reverted the changes.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14584] Encoding broken with system preferences
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14584 --- Comment #6 from Jonathan Druart --- Should be backported to 3.20, not 3.18! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14584] Encoding broken with system preferences
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14584 Jonathan Druart changed: What|Removed |Added Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14584] Encoding broken with system preferences
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14584 Jonathan Druart changed: What|Removed |Added Attachment #41113|0 |1 is obsolete|| --- Comment #5 from Jonathan Druart --- Created attachment 41632 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41632&action=edit Bug 14584: Encoding broken with system preferences The pref are double encoded. From bug 12411: "This will fix the encoding issues existing in 3.14 and 3.16. The issue still appear in master but is fixed by bug 11944." They should not have been pushed together. Test plan: 1) You need an accentuated language installed. 2) Go to NoLoginInstructions pref, and add some accentuated message like "Hélo médames é mècieüx" 3) refresh opac home page, message should be gibberish 4) apply patch. Message should be ok now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14584] Encoding broken with system preferences
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14584 Jonathan Druart changed: What|Removed |Added Status|In Discussion |Needs Signoff Assignee|philippe.blo...@inlibro.com |jonathan.dru...@bugs.koha-c ||ommunity.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9472] subfields in order when cataloging
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9472 Marjorie Barry-Vila changed: What|Removed |Added CC||marjorie.barry-v...@ccsr.qc ||.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12770] Notice template tool enhancement
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12770 Jonathan Druart changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=14666 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14666] adds fixed_fines for overdues
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14666 Jonathan Druart changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=12770 CC||jonathan.dru...@bugs.koha-c ||ommunity.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14509] Koha still allows spaces at the end, beginning or as your password
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14509 --- Comment #6 from Jonathan Druart --- (In reply to Joonas Kylmälä from comment #5) > (In reply to Owen Leonard from comment #4) > > (In reply to Joonas Kylmälä from comment #3) > > > Shouldn't we change it to server side > > > as it looks like all the other fields are checked that way. > > > > There are changes to the template and to opac-passwd.pl. To confirm, disable > > JavaScript and see if the server-side check is working correctly as well. > > opac-passwd.pl is for the end user server side check, right? I disabled > JavaScript in the staff side and there wasn't any check from the server > side, it allowed to change the password (this was also mentioned in the test > plan). So should we change the code so that it checks for the whitespaces in > the server side when the password is changed from the staff view? If you like, you can provide it. But I don't know why a librarian will force a password if the application denies it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14598] itemtype is not set on statistics by C4::Circulation::AddReturn
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 --- Comment #18 from Jonathan Druart --- (In reply to Jonathan Druart from comment #9) > Is it a duplicate of bug 9351? > > I would say we need to update existing rows. What about existing rows? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14655] Cannot checkin without Anonymous Patron
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14655 Jonathan Druart changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14655] Cannot checkin without Anonymous Patron
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14655 --- Comment #12 from Jonathan Druart --- Created attachment 41631 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41631&action=edit Bug 14655: Add a warning on the about page if patrons have requested privacy New warning on the about page if at least a patron has requested a privacy on checkin but the AnonymousPatron is not set to a valid patron. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14655] Cannot checkin without Anonymous Patron
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14655 --- Comment #11 from Jonathan Druart --- Created attachment 41630 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41630&action=edit Bug 14655: Add a warning if the checkin will fail On the checkin and checkout page, the checkin will fail if the patron has requested the privacy and the AnonymousPatron is not correctly set. This patch adds a warning message on both pages. Test plan: 0/ Be sure you don't have any patron with privacy=2 (Never) 1/ Set OPACPrivacy, not AnonymousPatron 2/ Go on the checkin, you should a warning (same as before this patch). 3/ Set the privacy=2 for a patron 4/ Go on the circulation page, a warning should appear (for this specific patron) 5/ Check an item out to this patron 6/ Check the item in on the checkin page. The item is not checked in and you get a specific message for this patron. Confirm other/correct situations don't trigger the messages. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14655] Cannot checkin without Anonymous Patron
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14655 Jonathan Druart changed: What|Removed |Added Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14598] itemtype is not set on statistics by C4::Circulation::AddReturn
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 --- Comment #17 from Kyle M Hall --- Created attachment 41629 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41629&action=edit [SIGNED-OFF] Bug 14598: (QA followup) Don't die on bad barcode Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14598] itemtype is not set on statistics by C4::Circulation::AddReturn
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 --- Comment #16 from Kyle M Hall --- Created attachment 41628 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41628&action=edit [SIGNED-OFF] Bug 14598: Make C4::Circulation::AddReturn store the right itemtype This patch makes C4::Circulation::AddReturn correctly store the itemtype on the 'statistics' table. To reproduce: - Checkout master. - Make a checkout. - Check the 'statistics' table and notice the itemtype is correctly set > SELECT * FROM statistics; - Check the item in. - Check the 'statistics' table and notice the itemtype is not set > SELECT * FROM statistics WHERE type="return"; => FAIL: itemtype is set to NULL To test: - Apply the regression tests patch - Run the tests: $ prove t/db_dependent/Circulation/Returns.t => FAIL: Tests fail - Apply this patch - Run the regression tests: $ prove t/db_dependent/Circulation/Returns.t => SUCCESS: Tests now pass. - Repeat the 'To reproduce' steps => SUCCESS: itemtype is now correctly set (in real life) - Happily sign off :-D Sponsored-by: Universidad Empresarial Siglo 21 Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14598] itemtype is not set on statistics by C4::Circulation::AddReturn
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 Kyle M Hall changed: What|Removed |Added Attachment #41383|0 |1 is obsolete|| Attachment #41384|0 |1 is obsolete|| Attachment #41385|0 |1 is obsolete|| --- Comment #15 from Kyle M Hall --- Created attachment 41627 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41627&action=edit [SIGNED-OFF] Bug 14598: (regression tests) AddReturn should store itemtype on 'statistics' table This patch adds tests for C4::Circulation::AddReturn(). Both tests are wrapped inside a subtest, and look for AddReturn storing the right itemtype on the 'statistics' table. Note: It also refactors the file a bit, to avoid side effects. And uses TestBuilder to make it independent on already-present db data. It also removes warnings by mocking C4::Context::userenv To test: - Apply the patch - Run the tests: $ prove t/db_dependent/Circulation/Returns.t => FAIL: Tests fail bacause AddReturn is not storing the itemtype - Sign off :-D Sponsored-by: Universidad Empresarial Siglo 21 Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14598] itemtype is not set on statistics by C4::Circulation::AddReturn
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 Kyle M Hall changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14667] Label creator UI/UX revamp
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14667
Jonathan Druart changed:
What|Removed |Added
CC||jonathan.dru...@bugs.koha-c
||ommunity.org
--- Comment #9 from Jonathan Druart
---
Liz, don't you think the help on the label home page was helpful ("Welcome to
Koha's label creator module")?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14667] Label creator UI/UX revamp
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14667 --- Comment #8 from Jonathan Druart --- Created attachment 41626 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41626&action=edit Bug 14667: Make some strings translatable This patch 1/ Fixes a regression introduced by the previous patch: the "Are you sure to delete..." strings was translatable and 2/ Make the table headers translatable. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14667] Label creator UI/UX revamp
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14667 Jonathan Druart changed: What|Removed |Added Attachment #41466|0 |1 is obsolete|| --- Comment #7 from Jonathan Druart --- Created attachment 41625 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41625&action=edit Bug 14667 - UI/UX improvements for the Label creator Signed-off-by: Chris Nighswonger Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14667] Label creator UI/UX revamp
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14667 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14639] Extend Koha::MetadataRecord to handle serialization format
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14639
--- Comment #10 from Tomás Cohen Arazi ---
(In reply to Jonathan Druart from comment #9)
> Comment on attachment 41387 [details] [review]
> Bug 14639: Extend Koha::MetadataRecord to handle serialization format and
> record id
>
> Review of attachment 41387 [details] [review]:
> -
>
> ::: Koha/MetadataRecord.pm
> @@ +84,5 @@
> > +
> > +my $record = $params->{ record };
> > +my $schema = $params->{ schema } // 'marc21';
> > +my $format = $params->{ format } // 'MARC';
> > +my $id = $params->{ id };
>
> Don't you think these 4 params should be mandatory?
> I would raise an exception if one of them is not given to the constructor.
I agree. But my plan was to do that on a later stage, so the transition into
using this is more smooth. So for now I just fallback to the current behaviour.
Once this is in, I will provide the relevant regression tests for an API
change.
Also, we need to get the exception handling code pushed before that too.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11229] makepayment and makepartialpayment (C4::Accounts) don't log branch to statistics table
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11229 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #18 from Tomás Cohen Arazi --- Patches pushed to master. Thanks everyone! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14529] Cannot delete a list even if the permission is set
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14529 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #11 from Tomás Cohen Arazi --- Patches pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14517] Private lists browsing broken in translated staff interface
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14517 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #10 from Tomás Cohen Arazi --- Patches pushed to master. Great job Jonathan! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14574] Correcting messages on intranet error pages so they make more sense
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14574 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||tomasco...@gmail.com --- Comment #4 from Tomás Cohen Arazi --- Patch pushed to master. Thanks Aleisha! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11229] makepayment and makepartialpayment (C4::Accounts) don't log branch to statistics table
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11229 Tomás Cohen Arazi changed: What|Removed |Added Attachment #41623|0 |1 is obsolete|| --- Comment #17 from Tomás Cohen Arazi --- Comment on attachment 41623 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41623 Bug 11229: Remove error rollback ineffective with AutoCommit enabled The problem is generated by how TestBuilder is coded. We should fix it instead. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14517] Private lists browsing broken in translated staff interface
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14517 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14517] Private lists browsing broken in translated staff interface
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14517
Kyle M Hall changed:
What|Removed |Added
Attachment #41467|0 |1
is obsolete||
--- Comment #9 from Kyle M Hall ---
Created attachment 41624
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41624&action=edit
[PASSED QA] Bug 14517: List shelves list is broken for translated interfaces
The translation script adds quotes ("") around translated string (Edit
for instance).
Which breaks the json structure.
Example:
"dt_action": ""
Test plan:
1/ On the staff interface create a private list
2/ Go to More > Lists ('Your lists' tab)
3/ Translate the templates to any language like:
$ cd misc/translator/
$ perl translate install es-ES
4/ Enable the translated templates on the sysprefs
5/ Switch to the translated language
6/ Go to the lists page (Mas > Listas in es-ES)
The list should be displayed correctly.
Note: There is a limitation. If a translated string contains a simple
quote ('), it will also break the json.
Signed-off-by: Chris Cormack
Signed-off-by: Kyle M Hall
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11229] makepayment and makepartialpayment (C4::Accounts) don't log branch to statistics table
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11229 --- Comment #16 from Jonathan Druart --- (In reply to Jonathan Druart from comment #15) > (In reply to Jonathan Druart from comment #14) > > Created attachment 41623 [details] [review] [review] > > Bug 11229: Remove error rollback ineffective with AutoCommit enabled > > > > The full error is: > > rollback ineffective with AutoCommit enabled at > > /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1621. > > > > Signed-off-by: Jonathan Druart > > RM: Feel free to skip this one if you disagree. As usual ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11229] makepayment and makepartialpayment (C4::Accounts) don't log branch to statistics table
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11229 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #15 from Jonathan Druart --- (In reply to Jonathan Druart from comment #14) > Created attachment 41623 [details] [review] > Bug 11229: Remove error rollback ineffective with AutoCommit enabled > > The full error is: > rollback ineffective with AutoCommit enabled at > /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1621. > > Signed-off-by: Jonathan Druart RM: Feel free to skip this one if you disagree. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11229] makepayment and makepartialpayment (C4::Accounts) don't log branch to statistics table
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11229 --- Comment #13 from Jonathan Druart --- Created attachment 41622 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41622&action=edit Bug 11229: Make the tests pass even if issues exist in the DB This is not introduced by the previous patches of this patchset. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11229] makepayment and makepartialpayment (C4::Accounts) don't log branch to statistics table
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11229 --- Comment #12 from Jonathan Druart --- Created attachment 41621 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41621&action=edit Bug 11229: (followup) makepartialpayment fix makepartialpayment() wasn't logging the branch either. This patch fixes that too. To test: - Run (with the regression tests applied) $ prove t/db_dependent/Accounts.t => FAIL: tests fail because makepartialpayment is not logging the branch code - Apply the patch - Run $ prove t/db_dependent/Accounts.t => SUCCESS: tests pass - Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11229] makepayment and makepartialpayment (C4::Accounts) don't log branch to statistics table
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11229 --- Comment #14 from Jonathan Druart --- Created attachment 41623 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41623&action=edit Bug 11229: Remove error rollback ineffective with AutoCommit enabled The full error is: rollback ineffective with AutoCommit enabled at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1621. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11229] makepayment and makepartialpayment (C4::Accounts) don't log branch to statistics table
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11229 --- Comment #11 from Jonathan Druart --- Created attachment 41620 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41620&action=edit Bug 11229: makepayment doesn't log branch in statistics correctly This patch fixes makepayment() so it correctly logs the branch code to the statistics table. To test: - Run (with the regression tests applied) $ prove t/db_dependent/Accounts.t => FAIL: makepayment() tests fail because logging is wrong - Apply the patch - Run $ prove t/db_dependent/Accounts.t => SUCCESS: tests for makepayment now pass (Note: makepartialpayment tests still fail as they need the next patch) Original commit message relying on the UI to test: There are several ways of paying fines, not all of them recorded the branch the payment was made at correctly: 1) Pay button next to an individual fine 2) Checkbox + pay amount 3) Checkbox + pay selected For each of those, check if the payment registered in the table statistics contains the branchcode before and after the patch. The patch should fix 1). 2) and 3) are ok with and without the patch. Important: Don't change the amount, pay individual fines. Signed-off-by: Tomas Cohen Arazi Note: i fixed the commit message, because this is a fix for makepayment Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11229] makepayment and makepartialpayment (C4::Accounts) don't log branch to statistics table
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11229 Jonathan Druart changed: What|Removed |Added Attachment #41473|0 |1 is obsolete|| Attachment #41474|0 |1 is obsolete|| Attachment #41475|0 |1 is obsolete|| --- Comment #10 from Jonathan Druart --- Created attachment 41619 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41619&action=edit Bug 11229: (regression tests) makepayment and makepartialpayment should log correctly This patch introduces tests for makepayment and makepartialpayment to check they are correctly logging to the statistics table. To test: - Run $ prove t/db_dependent/Accounts.t => FAIL: tests fail because statistics are not correctly logged. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11229] makepayment and makepartialpayment (C4::Accounts) don't log branch to statistics table
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11229 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297 --- Comment #13 from Blou --- Actually, I said that because the old patch (which was waaay impossible to apply anymore) would have replaced one 4= by another. In this new patch, Maxime prepends the 4=1 to whatever is there by default (4=109, let say), so I figure both are sent. small characters: But I might be wrong. :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14297] Holds Queue building ignoring holds where pickup & home branch don't match and item is not from least cost branch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14297 Jonathan Druart changed: What|Removed |Added Status|Signed Off |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Josef Moravec changed: What|Removed |Added CC||josef.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14517] Private lists browsing broken in translated staff interface
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14517 --- Comment #8 from Jonathan Druart --- (In reply to Chris Cormack from comment #7) > I just noticed that our To plugin, we just use to do JSON .. In future we > could maybe use this? But this is a just a comment. No reason to hold the bug > > http://search.cpan.org/~nuffin/Template-Plugin-JSON-0.06/lib/Template/Plugin/ > JSON.pm The idea was to avoid another dependency. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14529] Cannot delete a list even if the permission is set
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14529 Tomás Cohen Arazi changed: What|Removed |Added Attachment #41578|0 |1 is obsolete|| --- Comment #8 from Tomás Cohen Arazi --- Created attachment 41616 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41616&action=edit [SIGNED OFF] Bug 14529: The new list permission is 'lists', not 'shelves' Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14529] Cannot delete a list even if the permission is set
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14529 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14529] Cannot delete a list even if the permission is set
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14529 --- Comment #10 from Kyle M Hall --- Created attachment 41618 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41618&action=edit [PASSED QA] Bug 14529: The new list permission is 'lists', not 'shelves' Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14529] Cannot delete a list even if the permission is set
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14529 Kyle M Hall changed: What|Removed |Added Attachment #41615|0 |1 is obsolete|| Attachment #41616|0 |1 is obsolete|| --- Comment #9 from Kyle M Hall --- Created attachment 41617 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41617&action=edit [PASSED QA] Bug 14529: Allow user to delete lists Bug 13417 allows a librarian to delete any lists if he has the permission (delete_public_lists). There is a mismatch in the perm check. A user can delete a list with the ability to edit (manage) it. Test plan: 1/ Create a list A with user A 2/ Create a list B with user B 3/ A should be able to manage and delete the list A. He cans delete B only if he is superlibrarian or has the delete_public_lists permission. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14529] Cannot delete a list even if the permission is set
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14529 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14529] Cannot delete a list even if the permission is set
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14529 Tomás Cohen Arazi changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14529] Cannot delete a list even if the permission is set
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14529 Tomás Cohen Arazi changed: What|Removed |Added Attachment #40976|0 |1 is obsolete|| --- Comment #7 from Tomás Cohen Arazi --- Created attachment 41615 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41615&action=edit [SIGNED OFF] Bug 14529: Allow user to delete lists Bug 13417 allows a librarian to delete any lists if he has the permission (delete_public_lists). There is a mismatch in the perm check. A user can delete a list with the ability to edit (manage) it. Test plan: 1/ Create a list A with user A 2/ Create a list B with user B 3/ A should be able to manage and delete the list A. He cans delete B only if he is superlibrarian or has the delete_public_lists permission. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14529] Cannot delete a list even if the permission is set
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14529 Kyle M Hall changed: What|Removed |Added Attachment #41614|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14529] Cannot delete a list even if the permission is set
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14529 Kyle M Hall changed: What|Removed |Added Attachment #40976|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14639] Extend Koha::MetadataRecord to handle serialization format
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14639
--- Comment #9 from Jonathan Druart
---
Comment on attachment 41387
--> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41387
Bug 14639: Extend Koha::MetadataRecord to handle serialization format and
record id
Review of attachment 41387:
-->
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=14639&attachment=41387)
-
::: Koha/MetadataRecord.pm
@@ +84,5 @@
> +
> +my $record = $params->{ record };
> +my $schema = $params->{ schema } // 'marc21';
> +my $format = $params->{ format } // 'MARC';
> +my $id = $params->{ id };
Don't you think these 4 params should be mandatory?
I would raise an exception if one of them is not given to the constructor.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14529] Cannot delete a list even if the permission is set
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14529 --- Comment #6 from Kyle M Hall --- Created attachment 41614 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41614&action=edit [SIGNED-OFF] Bug 14529: The new list permission is 'lists', not 'shelves' Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14529] Cannot delete a list even if the permission is set
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14529 Kyle M Hall changed: What|Removed |Added CC||kyle.m.h...@gmail.com Attachment #41613|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14529] Cannot delete a list even if the permission is set
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14529 Kyle M Hall changed: What|Removed |Added Attachment #41578|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14529] Cannot delete a list even if the permission is set
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14529 Kyle M Hall changed: What|Removed |Added Attachment #40976|0 |1 is obsolete|| Attachment #41578|0 |1 is obsolete|| --- Comment #5 from Kyle M Hall --- Created attachment 41613 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41613&action=edit [SIGNED-OFF] Bug 14529: Allow user to delete lists Bug 13417 allows a librarian to delete any lists if he has the permission (delete_public_lists). There is a mismatch in the perm check. A user can delete a list with the ability to edit (manage) it. Test plan: 1/ Create a list A with user A 2/ Create a list B with user B 3/ A should be able to manage and delete the list A. He cans delete B only if he is superlibrarian or has the delete_public_lists permission. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
