[Koha-bugs] [Bug 14337] AllowRenewalIfOtherItemsAvailable counts holdable not for loan items when checking renewability

2015-08-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14337

--- Comment #10 from Jonathan Druart jonathan.dru...@bugs.koha-community.org 
---
(In reply to Kyle M Hall from comment #9)
 I just wanted to publicly observe that these unit tests are such a mess that
 I'm spending hours writing unit tests for a patch that took minutes to
 complete. We really need to think about how to clean these tests up.

I totally agree with that.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14590] Checkboxes should be disabled without valid contact information in messaging preferences

2015-08-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14590

Lari Taskula la...@student.uef.fi changed:

   What|Removed |Added

  Attachment #41528|0   |1
is obsolete||

--- Comment #5 from Lari Taskula la...@student.uef.fi ---
Created attachment 41700
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41700action=edit
Bug 14590 - Checkboxes should be disabled without valid contact information in
messaging preferences

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14505] single quotes in journal number cause print routing list window to not appear

2015-08-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14505

Joonas Kylmälä j.kylm...@gmail.com changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13791] Plack - Out of the box support on packages

2015-08-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13791

--- Comment #34 from Tomás Cohen Arazi tomasco...@gmail.com ---
(In reply to Jonathan Druart from comment #33)
 root@koha-deb:/usr/sbin# koha-plack --disable library
 Plack disabled for library
 root@koha-deb:/usr/sbin# koha-plack --enable library
 Plack already enabled for library
 
 hum?
 
 Not sure I have tested correctly, back on this one tomorrow.

Hi Jonathan!

1) It seems to me that the script is not catching the absense of the relevant
line on your site's virtualhosts definition. This could be a bug in
koha-functions.sh (is_plack_enabled). Probably not using the right
koha-functions.sh (look at (4).

2) You should be looking  at /var/log/koha/instance/plack-output.log to know
if you are on plack. But you should notice, you know... it is slightly super
faster. When you have plack enabled a line like this is uncommented in
/etc/apache2/sites-enabled/instance.conf:

OPAC:
# Include /etc/koha/apache-shared-opac-plack.conf

Intranet:
# Include /etc/koha/apache-shared-intranet-plack.conf

Those files need to be present in those dirs (look at (4) for details).

3) You need to know that koha-plack --enable instance is not starting the
daemon for now, so you need to issue koha-plack --start instance to have it
running. This is independent from the Apache conf hook, so Plack might be
running but not being used. You can ps waux | grep starman (there should be a
master process with two workers).

4) Where the files are put is really important because they are picked to
generate a suitable apache configuration, otherwise it won't work.:

debian/templates/apache-shared-*-plack.conf - /etc/koha
debian/templates/apache-site.conf.in - /etc/koha
debian/koha-common.bash-completion - /etc/bash_completion.d/koha-common
debian/scripts/koha-functions.sh - /usr/share/koha/bin
debian/scripts/koha-* - /usr/sbin

The template files need to be put in place BEFORE the instance is created.

I think I'll build the packages for this so testing is pretty easier. Also note
that you need to install
- starman
- libplack-middleware-reverseproxy-perl

Thanks for your time testing this!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13324] [DEPENDS_ON_13321] The fund values must be based on tax included values

2015-08-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13324

Marcel de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

Summary|The fund values must be |[DEPENDS_ON_13321] The fund
   |based on tax included   |values must be based on tax
   |values  |included values
 CC||m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13321] [DEPENDS 12826] Tax and prices calculation need to be fixed

2015-08-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13321

Marcel de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl
Summary|Tax and prices calculation  |[DEPENDS 12826] Tax and
   |need to be fixed|prices calculation need to
   ||be fixed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 4888] pre-set of field indicators value

2015-08-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4888

João Pinto joao.pi...@ua.pt changed:

   What|Removed |Added

 CC||joao.pi...@ua.pt

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14582] OPAC detail shows an unuseful link to add tag when user is not logged in

2015-08-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14582

Joonas Kylmälä j.kylm...@gmail.com changed:

   What|Removed |Added

 CC||j.kylm...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14375] DBIx::Connector should be stored in C4::Context instead of dbh

2015-08-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14375

--- Comment #16 from Fridolin SOMERS fridolin.som...@biblibre.com ---
(In reply to Jonathan Druart from comment #15)
 (In reply to Fridolin SOMERS from comment #14)
  Created attachment 41439 [details]
  test module
  
  Test module.
  
  It saves a record and tries to get it each 15 minutes 4 times.
  Without patch, it fails with : database has run away.
 
 Why 900sec?

It is to loose the DB connexion.
Maybe a few minutes is enought.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13734] RDA: Display 33xs

2015-08-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13734

Marcel de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl
 QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13734] RDA: Display 33xs

2015-08-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13734

Marcel de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6499] MARC21 035 -- Other-control-number -- Indexing Matching

2015-08-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6499

Marcel de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl
 QA Contact|koha-b...@lists.koha-commun |m.de.r...@rijksmuseum.nl
   |ity.org |

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6499] MARC21 035 -- Other-control-number -- Indexing Matching

2015-08-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6499

Marcel de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14505] single quotes in journal number cause print routing list window to not appear

2015-08-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14505

--- Comment #1 from Joonas Kylmälä j.kylm...@gmail.com ---
Created attachment 41705
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41705action=edit
Bug 14505: single quotes in journal number cause print routing list window to
not appear

Escapes single quotes from serial.serialseq string.

Test plan:

1. Have a serial with a number which has single quote in it.
2. Go to Serials - Find some serial subscription - Serial collection.
3. Set up a routing list for this serial.
4. Click on Print list under the column Routing.
5. Notice that the print window doesn't open.
6. Apply patch.
7. Notice that the print window opens.

Sponsored-by: Vaara-kirjastot

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14589] Adjust authorities_merge_ajax and replace some indirect syntax

2015-08-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14589

Marcel de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

  Attachment #41675|0   |1
is obsolete||

--- Comment #7 from Marcel de Rooy m.de.r...@rijksmuseum.nl ---
Created attachment 41691
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41691action=edit
Bug 14589: Adjust authorities_merge_ajax and replace some indirect syntax

This patch does the following:
[1] Adjust authorities_merge_ajax just as in bug 14588.
[2] Replace some indirect syntax for fetch GGI::Cookie.
[3] Along the way replace some new CGI's. Note that I am not aiming to
replace them Koha wide. The fetch class variant is less readable.

Test plan:
[1] Run the URL authorities/merge_ajax.pl in staff.
[2] Upload a file with Stage MARC records for import.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 3333] item status for not for loan by item type / item is different

2015-08-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=

--- Comment #18 from Marcel de Rooy m.de.r...@rijksmuseum.nl ---
Joubu:  $status = reference;   see XSLT.pm sub  buildKohaItemsNamespace  
(why did I forget that :)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13775] software error when choosing authority via plugin

2015-08-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13775

Joonas Kylmälä j.kylm...@gmail.com changed:

   What|Removed |Added

 CC||j.kylm...@gmail.com

--- Comment #3 from Joonas Kylmälä j.kylm...@gmail.com ---
I get also similar error:
Can't call method subfields on an undefined value at
~/kohaclone/authorities/blinddetail-biblio-search.pl line 88.

First I edit marc record's field 648 - chronological term, then I try to add
there one by clicking a link on the left side of the field. From there it opens
me to a new window: cgi-bin/koha/authorities/auth_finder.pl. In that window I
click Create a new authority, I click on the authority creating fields
randomly, I don't input there anything but the window puts there some randomly
looking data itself, and after that I try to save the new authority and it
gives the error.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14649] fund names not displayed in budget planning

2015-08-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14649

--- Comment #8 from Fridolin SOMERS fridolin.som...@biblibre.com ---
(In reply to Mirko Tietgen from comment #7)
 (In reply to Fridolin SOMERS from comment #5)
 
  = You see in URL that budget_id is empty :
 
  /cgi-bin/koha/admin/aqbudgets.pl?op=add_formbudget_id=6budget_period_id=
 
  = you see in URL that budget_id is defined like in planning page :
 
  /cgi-bin/koha/admin/aqbudgets.pl?op=add_formbudget_id=6budget_period_id=2
 
 Do you mean »budget_period_id is empty/defined« (not budget_id) in both
 cases?

Yes indeed, thanks for this

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14675] Updating personal details on OPAC - request sent even if no changes are made

2015-08-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14675

Aleisha Amohia aleishaamo...@hotmail.com changed:

   What|Removed |Added

  Attachment #41605|0   |1
is obsolete||

--- Comment #2 from Aleisha Amohia aleishaamo...@hotmail.com ---
Created attachment 41690
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41690action=edit
Bug 14675: Don't update details if no changes made

if no changes has been made for personal details, bring user back to details
page and inform them that no changes has been made.

Signed-off-by: Aleisha aleishaamo...@hotmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14675] Updating personal details on OPAC - request sent even if no changes are made

2015-08-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14675

Aleisha Amohia aleishaamo...@hotmail.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13073] Search in Russian and in Armenian

2015-08-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13073

--- Comment #2 from Joonas Kylmälä j.kylm...@gmail.com ---
I couldn't replicate this in 3.16 nor newer releases. What type the search
string was?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13321] Tax and prices calculation need to be fixed

2015-08-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13321

Jonathan Druart jonathan.dru...@bugs.koha-community.org changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

--- Comment #34 from Jonathan Druart jonathan.dru...@bugs.koha-community.org 
---
Back to the needs QA queue.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11759] Batch checkout

2015-08-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11759

Marcel de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl
 Status|Signed Off  |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11759] Batch checkout

2015-08-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11759

--- Comment #58 from Jonathan Druart jonathan.dru...@bugs.koha-community.org 
---
Created attachment 41697
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41697action=edit
Bug 11759: (follow-up) Some fixes

This is a squash of the following patches:

Bug 11759: (follow-up) Prevent access to the batch checkout if not allowed

If a user pass 'batch=1' to the url, he was allowed to access to the
batch checkout page even if the patron is not in an authorised
category.

This patch also fixes the link to Batch check out from the Details
tab (cf changes in circ-menu.inc).

Bug 11759: FIX Javascript error

The following JS error occurred:
  ReferenceError: MSG_ADD_MESSAGE is not defined

The circulation.js file is useless and should not be included.

Bug 11759: FIX the alert message if an item is on hold.

If an item is on hold, the hold is not cancelled.
This patch corrects the message displayed in this case.

Bug 11759: FIX issue list is empty

The issue list is empty after checking an item out to a patron without
existing checkout.

To reproduce:
- Search for a patron without checkout.
- Check an item out using the normal checkout.
- Verify the checkout list contain the checkout.

Signed-off-by: Josef Moravec josef.mora...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11759] Batch checkout

2015-08-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11759

--- Comment #59 from Jonathan Druart jonathan.dru...@bugs.koha-community.org 
---
Created attachment 41698
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41698action=edit
Bug 11759 [QA Followup] - Fix koha-qa errors

Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14696] useless use of String::Random in catalogue/search.pl

2015-08-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14696

Joonas Kylmälä j.kylm...@gmail.com changed:

   What|Removed |Added

  Attachment #41680|0   |1
is obsolete||

--- Comment #2 from Joonas Kylmälä j.kylm...@gmail.com ---
Created attachment 41699
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41699action=edit
Looks like there is no dependencies to that module.

Signed-off-by: Joonas Kylmälä j.kylm...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14696] useless use of String::Random in catalogue/search.pl

2015-08-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14696

Joonas Kylmälä j.kylm...@gmail.com changed:

   What|Removed |Added

 CC||j.kylm...@gmail.com
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14649] fund names not displayed in budget planning

2015-08-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14649

Fridolin SOMERS fridolin.som...@biblibre.com changed:

   What|Removed |Added

  Attachment #41398|0   |1
is obsolete||

--- Comment #9 from Fridolin SOMERS fridolin.som...@biblibre.com ---
Created attachment 41703
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41703action=edit
Bug 14649: Followup - correct budget_period_id in fund name link

Now that fund name is displayed in the table as a link, you see that arg
budget_period_id is never defined in this link.

This is because the template var is [% budget_line.budget_period_id %] instead
of [% budget_period_id %].
This looks like a mistake when converting from tmpl to tt.

Test plan :
- Without patch
- Look for a planning with funds :
/cgi-bin/koha/admin/aqplan.pl?budget_period_id=2authcat=MONTHS
- Click on a fund name
= You see in URL that budget_period_id is empty :
/cgi-bin/koha/admin/aqbudgets.pl?op=add_formbudget_id=6budget_period_id=
- Apply patch
- Look for a planning with funds :
/cgi-bin/koha/admin/aqplan.pl?budget_period_id=2authcat=MONTHS
- Click on a fund name
= you see in URL that budget_period_id is defined like in planning page :
/cgi-bin/koha/admin/aqbudgets.pl?op=add_formbudget_id=6budget_period_id=2

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13775] software error when choosing authority via plugin

2015-08-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13775

--- Comment #4 from Jonathan Druart jonathan.dru...@bugs.koha-community.org 
---
Debug: It's because the field 148 is not filled

# If 148 is not set, @fields = ();
 82 my @fields = $record-field( $auth_type-{auth_tag_to_report} );
# Repet is never set, so $repet = 0
 83 my $repet = ($query-param('repet') || 1) - 1;
 84 my $field = $fields[$repet];
 85 
 86 # Get all values for each distinct subfield
 87 my %subfields;
if 148 is not set, boom here
 88 for ( $field-subfields ) {

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 3333] item status for not for loan by item type / item is different

2015-08-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=

Jonathan Druart jonathan.dru...@bugs.koha-community.org changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10363] There is no package for authorised values.

2015-08-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10363

Jonathan Druart jonathan.dru...@bugs.koha-community.org changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8753] Add forgot password link to OPAC

2015-08-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

--- Comment #119 from Jonathan Druart jonathan.dru...@bugs.koha-community.org 
---
Does the status should be Signoff?

I would say we should not provide any information if the user does not fill
correct login or email.
The message should be generic Bad info instead of Bad login or Bad email.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14590] Checkboxes should be disabled without valid contact information in messaging preferences

2015-08-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14590

Lari Taskula la...@student.uef.fi changed:

   What|Removed |Added

  Attachment #41700|0   |1
is obsolete||

--- Comment #6 from Lari Taskula la...@student.uef.fi ---
Created attachment 41701
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41701action=edit
Bug 14590 - Checkboxes should be disabled without valid contact information in
messaging preferences

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13734] RDA: Display 33xs

2015-08-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13734

Marcel de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #17 from Marcel de Rooy m.de.r...@rijksmuseum.nl ---
QA Comment:
Had to make these fields visible, but works fine. Note that delimeter looks
like a spelling error, but it is already there..

Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 3333] item status for not for loan by item type / item is different

2015-08-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=

Jonathan Druart jonathan.dru...@bugs.koha-community.org changed:

   What|Removed |Added

  Attachment #40599|0   |1
is obsolete||

--- Comment #19 from Jonathan Druart jonathan.dru...@bugs.koha-community.org 
---
Created attachment 41704
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41704action=edit
Bug : Confusing item status for not-for-loans

Signed-off-by: Nick Clemens n...@quecheelibrary.org

Signed-off-by: Jonathan Druart jonathan.dru...@bugs.koha-community.org

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13624] Remove columns branchcode, categorytype from table overduerules_transport_types

2015-08-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624

--- Comment #31 from Jonathan Druart jonathan.dru...@bugs.koha-community.org 
---
(In reply to Blou from comment #20)
 4) Took me a while to remember WHY we want it out.  I guess it's premature,
 but this is the first step to allow for unlimited steps, and as such that
 combo cannot be unique.  BUT this being the first step, I cannot justify
 removing it yet, only that it will be more complicated to remove later.
 I WILL LEAVE IT IN, you being QA and all ;)

Sorry, but I think that the constraint should not be removed in this patchset.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10468] patron print summary should show more

2015-08-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10468

Aleisha Amohia aleishaamo...@hotmail.com changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10468] patron print summary should show more

2015-08-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10468

--- Comment #2 from Aleisha Amohia aleishaamo...@hotmail.com ---
Created attachment 41689
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41689action=edit
Bug 10468: Adding holds table to summary print

To test:
1) Add a hold to a patron
2) Go to patron page
3) Click Print Summary
4) Confirm that 'Pending Holds' table displays with correct information under
appropriate headings (should be Title, Author, Placed on (reserve date),
Expires on (expiration date), and Pick up library)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 3333] item status for not for loan by item type / item is different

2015-08-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=

--- Comment #17 from Marcel de Rooy m.de.r...@rijksmuseum.nl ---
(In reply to Jonathan Druart from comment #16)
 Using an existing record, I get 1 item available for loan and 1 available
 for reference.
 The one available for reference is the one with an item type not for loan.
 
 The display is the same before and after the patch.
 I don't manage to know why it has this status.

Without the patch
===
staff catalogue results: 2 items, 2 available
opac xslt results: 1 for loan, 1 for reference
opac non-xslt results: Available: branch(1), branch(1)

With the patch:
===
staff catalogue results: 2 items, 1 available
opac xslt results: 1 for loan, 1 for reference
opac non-xslt results: Available: branch(1)

So, your test confirms my opac xslt results. But note the results in opac
non-xslt and staff catalogue. See commit message.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11747] Default to logged in library for Overdue notice/status triggers

2015-08-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11747

Marcel de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 Status|Patch doesn't apply |Signed Off

--- Comment #24 from Marcel de Rooy m.de.r...@rijksmuseum.nl ---
(In reply to Marcel de Rooy from comment #23)
 Applying: Bug 11747 - Add system preference
 DefaultToLoggedInLibraryOverdueTriggers
 /home/koha/testclone/.git/rebase-apply/patch:50: trailing whitespace.
 - When editing overdue notice/status triggers show the
 fatal: sha1 information is lacking or useless
 (installer/data/mysql/sysprefs.sql).
 Repository lacks necessary blobs to fall back on 3-way merge.
 Cannot fall back to three-way merge.

oops, dependency

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11747] Default to logged in library for Overdue notice/status triggers

2015-08-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11747

Marcel de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl
 Status|Signed Off  |Patch doesn't apply

--- Comment #23 from Marcel de Rooy m.de.r...@rijksmuseum.nl ---
Applying: Bug 11747 - Add system preference
DefaultToLoggedInLibraryOverdueTriggers
/home/koha/testclone/.git/rebase-apply/patch:50: trailing whitespace.
- When editing overdue notice/status triggers show the
fatal: sha1 information is lacking or useless
(installer/data/mysql/sysprefs.sql).
Repository lacks necessary blobs to fall back on 3-way merge.
Cannot fall back to three-way merge.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12825] GST / VAT rewrite

2015-08-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12825
Bug 12825 depends on bug 12826, which changed state.

Bug 12826 Summary: GST / VAT rewrite - plumbing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12826

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13321] Tax and prices calculation need to be fixed

2015-08-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13321

Jonathan Druart jonathan.dru...@bugs.koha-community.org changed:

   What|Removed |Added

Summary|[DEPENDS 12826] Tax and |Tax and prices calculation
   |prices calculation need to  |need to be fixed
   |be fixed|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13318] C4::Acq::GetParcel is not used and can be removed

2015-08-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13318
Bug 13318 depends on bug 12826, which changed state.

Bug 12826 Summary: GST / VAT rewrite - plumbing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12826

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13321] [DEPENDS 12826] Tax and prices calculation need to be fixed

2015-08-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13321
Bug 13321 depends on bug 12826, which changed state.

Bug 12826 Summary: GST / VAT rewrite - plumbing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12826

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5262] authority plugin doesn't copy indicators

2015-08-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5262

João Pinto joao.pi...@ua.pt changed:

   What|Removed |Added

 CC||joao.pi...@ua.pt

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11759] Batch checkout

2015-08-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11759

Jonathan Druart jonathan.dru...@bugs.koha-community.org changed:

   What|Removed |Added

 Status|Patch doesn't apply |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12826] GST / VAT rewrite - plumbing

2015-08-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12826

Jonathan Druart jonathan.dru...@bugs.koha-community.org changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|ASSIGNED|RESOLVED

--- Comment #5 from Jonathan Druart jonathan.dru...@bugs.koha-community.org 
---
The plumbing is done!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8753] Add forgot password link to OPAC

2015-08-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

--- Comment #120 from Jonathan Druart jonathan.dru...@bugs.koha-community.org 
---
From perldoc rand:

rand() is not cryptographically secure. You should not rely on it in
security-sensitive situations. As of this writing, a number of third-party CPAN
modules offer random number generators intended by their authors to be
cryptographically secure, including: Data::Entropy, Crypt::Random,
Math::Random::Secure, and Math::TrulyRandom.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14588] Simplify merge_ajax.pl

2015-08-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14588

Jonathan Druart jonathan.dru...@bugs.koha-community.org changed:

   What|Removed |Added

  Attachment #41683|0   |1
is obsolete||

--- Comment #12 from Jonathan Druart jonathan.dru...@bugs.koha-community.org 
---
Created attachment 41707
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41707action=edit
Bug 14588: Simplify merge_ajax.pl

This script does not need a few modules:
IO::File; CGI::Session; C4::UploadedFile.
Warnings can be enabled (with Modern::Perl).
Indirect object syntax replaced for CGI and CGI::Cookie.
Moved the $reply line upwards (not needed twice anymore).

Test plan:
[1] Log in as staff user. Run the URL cataloguing/merge_ajax.pl.
You should see the JSON reponse in the browser.
[2] Logout. Run the URL again. Blank screen.
[3] Go to addbooks.pl (Cataloging Search). Search something, select two
biblios and click Merge selected, etc.

Signed-off-by: Joonas Kylmala j.kylm...@gmail.com

Signed-off-by: Mark Tompsett mtomp...@hotmail.com

Signed-off-by: Jonathan Druart jonathan.dru...@bugs.koha-community.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14588] Simplify merge_ajax.pl

2015-08-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14588

Jonathan Druart jonathan.dru...@bugs.koha-community.org changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14133] Print notices generated in special case do not use print template

2015-08-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14133

Jonathan Druart jonathan.dru...@bugs.koha-community.org changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #1 from Jonathan Druart jonathan.dru...@bugs.koha-community.org 
---
Sophie, what do you suggest?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14634] Warns when placing hold on record with no items

2015-08-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14634

Jonathan Druart jonathan.dru...@bugs.koha-community.org changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |aleishaamo...@hotmail.com
   |ity.org |
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
   Severity|enhancement |minor

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14622] Add fr-CA data folder in the web installer

2015-08-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14622

--- Comment #2 from Jonathan Druart jonathan.dru...@bugs.koha-community.org 
---
How did you generate this list?

Be care, userpermissions.sq is not up-to-date.

Why did you create fr-CA/obligatoire? (we have a fr-FR/1-Obligatoire).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14690] Patron import tool page missing extra search patron options

2015-08-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14690

Jonathan Druart jonathan.dru...@bugs.koha-community.org changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
   Assignee|koha-b...@lists.koha-commun |l...@catalyst.net.nz
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14693] t/db_dependent/Contract.t fails do to fixed date

2015-08-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14693

--- Comment #2 from Jonathan Druart jonathan.dru...@bugs.koha-community.org 
---
Comment on attachment 41682
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41682
Bug 14693: Contract.t should generate dates based on current date

Review of attachment 41682:
 -- 
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.htmlbug=14693attachment=41682)
-

::: t/db_dependent/Contract.t
@@ +72,5 @@
  is( $contract-{contractdescription}, $my_contract1-{contractdescription}, 
 'AddContract stores the contract description correctly.' );
  is( $contract-{booksellerid}, $my_contract1-{booksellerid}, 'AddContract 
 stores the bookseller id correctly.' );
  
 +my $now = dt_from_string;
 +my $three_more_days = $now + DateTime::Duration-new( days = 3 );

1/ DateTime::Duration should be imported
2/ Are you sure this works ? There are the 2 add_duration or subtract_duration
methods, which is certainly better.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14649] fund names not displayed in budget planning

2015-08-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14649

Jonathan Druart jonathan.dru...@bugs.koha-community.org changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
   Severity|minor   |normal

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14379] Batch item modification tool - Can't change custom subfields

2015-08-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14379

Joonas Kylmälä j.kylm...@gmail.com changed:

   What|Removed |Added

 CC||j.kylm...@gmail.com

--- Comment #1 from Joonas Kylmälä j.kylm...@gmail.com ---
Can you list the steps of how to reproduce this bug. I have had hard time
trying to figure out how to reproduce this bug.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices

2015-08-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961

Joonas Kylmälä j.kylm...@gmail.com changed:

   What|Removed |Added

 CC||j.kylm...@gmail.com

--- Comment #1 from Joonas Kylmälä j.kylm...@gmail.com ---
Koha - Tools - Notices, you mean? Would there be one one row per patron and
there would be all the info? I'm not sure if I understood right what you
suggested.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 6499] MARC21 035 -- Other-control-number -- Indexing Matching

2015-08-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6499

Marcel de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14641] Warns in subscription-add.pl

2015-08-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14641

Jonathan Druart jonathan.dru...@bugs.koha-community.org changed:

   What|Removed |Added

   Severity|enhancement |minor
 Status|Needs Signoff   |Failed QA
   Assignee|koha-b...@lists.koha-commun |aleishaamo...@hotmail.com
   |ity.org |
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #3 from Jonathan Druart jonathan.dru...@bugs.koha-community.org 
---
The brackets should be kept, for consistency at least.

I haven't tested, but this patch is certainly wrong.
Moreover, tests should be provided.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14654] Add desk filter in Holds awaiting pickup list

2015-08-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14654

Jonathan Druart jonathan.dru...@bugs.koha-community.org changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |nicolas.legr...@bulac.fr
   |ity.org |
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14687] Patron's transaction history changes items' order after paying fines.

2015-08-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14687

Jonathan Druart jonathan.dru...@bugs.koha-community.org changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
   Assignee|koha-b...@lists.koha-commun |j.kylm...@gmail.com
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14337] AllowRenewalIfOtherItemsAvailable counts holdable not for loan items when checking renewability

2015-08-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14337

--- Comment #13 from Kyle M Hall kyle.m.h...@gmail.com ---
(In reply to Jonathan Druart from comment #10)
 (In reply to Kyle M Hall from comment #9)
  I just wanted to publicly observe that these unit tests are such a mess that
  I'm spending hours writing unit tests for a patch that took minutes to
  complete. We really need to think about how to clean these tests up.
 
 I totally agree with that.

Success! I created a new block of tests at the end of the file and by starting
from scratch ( mostly ) I believe I have now crafted a correct unit test!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14608] HEA : add possibility of sharing usage statistics in Administration page and Web installer

2015-08-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14608

--- Comment #8 from Julian FIOL julian.f...@biblibre.com ---
Created attachment 41713
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41713action=edit
Big 14608 : Hide UsageStatsLastDisplay syspref

In response of Joubu comment #5

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14693] t/db_dependent/Contract.t fails do to fixed date

2015-08-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14693

--- Comment #3 from Tomás Cohen Arazi tomasco...@gmail.com ---
(In reply to Jonathan Druart from comment #2)
 Comment on attachment 41682 [details] [review]
 1/ DateTime::Duration should be imported

I agree. Will fix it now.

 2/ Are you sure this works ? There are the 2 add_duration or
 subtract_duration methods, which is certainly better.

It is just syntax sugar. Using the plus symbol is correctly documented on
DateTime:

$dt2 = $dt + $duration_object;
$dt3 = $dt - $duration_object;

I think it provides better readability.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7957] Routing lists: manage several routing list for each subscription, and export them as CSV

2015-08-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957

Jonathan Druart jonathan.dru...@bugs.koha-community.org changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
 Status|Signed Off  |Patch doesn't apply

--- Comment #42 from Jonathan Druart jonathan.dru...@bugs.koha-community.org 
---
Julian, please rebase, I will try to have a look.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14608] HEA : add possibility of sharing usage statistics in Administration page and Web installer

2015-08-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14608

--- Comment #7 from Julian FIOL julian.f...@biblibre.com ---
Created attachment 41712
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41712action=edit
Bug 14608 : Adding the new syspref UsageStatsLastDisplay to the updatedb
(atomicupdate dir)

In response of Joubu comment #4

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8753] Add forgot password link to OPAC

2015-08-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

Jonathan Druart jonathan.dru...@bugs.koha-community.org changed:

   What|Removed |Added

  Attachment #41688|0   |1
is obsolete||

--- Comment #121 from Jonathan Druart jonathan.dru...@bugs.koha-community.org 
---
Created attachment 41706
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41706action=edit
Bug 8753 - [followup] POD cleanup

Check to make sure the messages from the qa checker are gone.

Note I'm not sure about this one because my test tools are apparently broken,
and I can't get the error to manifest.

Amended patch by Jonathan Druart: Add a blank line before =head2
It now passes.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8753] Add forgot password link to OPAC

2015-08-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

--- Comment #122 from Jonathan Druart jonathan.dru...@bugs.koha-community.org 
---
1/ Receive the email
2/ Click on the link
3/ Change the pwd
4/ Click again on the link
5/ Change the pwd
6/ You get an error

The error should appear at step 5

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10832] Multi transport types for overdue notices

2015-08-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10832

delaye stephane.del...@biblibre.com changed:

   What|Removed |Added

 CC||stephane.del...@biblibre.co
   ||m

--- Comment #34 from delaye stephane.del...@biblibre.com ---
In 3.18

 - if a user don't have an email defined and an email is
  required and print is not required, a print notice is generated with the
content of email.

- if a user don't have an email defined and an email is
  required and print is required, a print notice is generated with the content
of print.

Print required ou not not required , we must have a print notice with content
of print not content of email with a message_transport_type=print

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8753] Add forgot password link to OPAC

2015-08-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

--- Comment #123 from Jonathan Druart jonathan.dru...@bugs.koha-community.org 
---
comment 21 did not get an answer. For instance tests are still missing.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6499] MARC21 035 -- Other-control-number -- Indexing Matching

2015-08-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6499

--- Comment #20 from Marcel de Rooy m.de.r...@rijksmuseum.nl ---
QA Comment:
Works for me, added a followup.
The test plan includes an addition to intranetuserjs to use this field. But
many users will miss that of course. If you really would need it in the menu,
you could do that on a separate report. Full-text search will find it too of
course now.

Instead of Other-control-number perhaps System-control-number would still 
have been closer to the LOC naming :) No problem for me.

Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10832] Multi transport types for overdue notices

2015-08-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10832

--- Comment #35 from Jonathan Druart jonathan.dru...@bugs.koha-community.org 
---
(In reply to delaye from comment #34)
 In 3.18
 
  - if a user don't have an email defined and an email is
   required and print is not required, a print notice is generated with the
 content of email.
 
 - if a user don't have an email defined and an email is
   required and print is required, a print notice is generated with the
 content of print.
 
 Print required ou not not required , we must have a print notice with
 content of print not content of email with a message_transport_type=print

It looks the same as bug 14133.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14622] Add fr-CA data folder in the web installer

2015-08-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14622

Jonathan Druart jonathan.dru...@bugs.koha-community.org changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |francois.charbonnier@inlibr
   |ity.org |o.com
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13572] Add onlyactives parameter to force_borrower_messaging_defaults script

2015-08-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13572

Jonathan Druart jonathan.dru...@bugs.koha-community.org changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
   Assignee|koha-b...@lists.koha-commun |remi.mayrand-provencher@inL
   |ity.org |ibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14497] Add warning to patron details page if patron's fines exceed noissuescharge

2015-08-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14497

Jonathan Druart jonathan.dru...@bugs.koha-community.org changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com
   |ity.org |
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14337] AllowRenewalIfOtherItemsAvailable counts holdable not for loan items when checking renewability

2015-08-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14337

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #41263|0   |1
is obsolete||
  Attachment #41569|0   |1
is obsolete||

--- Comment #11 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 41708
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41708action=edit
Bug 14337 - Add Unit Tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14337] AllowRenewalIfOtherItemsAvailable counts holdable not for loan items when checking renewability

2015-08-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14337

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14337] AllowRenewalIfOtherItemsAvailable counts holdable not for loan items when checking renewability

2015-08-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14337

--- Comment #12 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 41709
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41709action=edit
Bug 14337 - AllowRenewalIfOtherItemsAvailable counts holdable not for loan
items when checking renewability

AllowRenewalIfOtherItemsAvailable checks
C4::Reserves::IsAvailableForItemLevelRequest to see if the item is
holdable, which catches not for loan values less than 0 ( i.e. holdable,
but not circ-able ). However, since this feature is about
actually checking out items to patrons, we should not count *any* not
for loan items when deciding if the available items will satisfy all
current holds.

Test Plan:
 1) Enable AllowRenewalIfOtherItemsAvailable
 2) Create a record with two items
 3) Check out one item to a patron
 4) Ensure the item is renewable
 5) Place a hold on the record
 6) The item should now be non-renewable
 7) Add a second item to the record, but with a not for loan value  0
 8) Note the checkout is still renewable
 9) Apply this patch
10) Note the checkout is now non-renewable

Works ok.

Signed-off-by: Amit Gupta amit.gu...@informaticsglobal.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11388] Error exporting records to non-Unicode/MARC-8

2015-08-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11388

Joonas Kylmälä j.kylm...@gmail.com changed:

   What|Removed |Added

 CC||j.kylm...@gmail.com
   Assignee|oleon...@myacpl.org |j.kylm...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11759] Batch checkout

2015-08-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11759

Marcel de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

   Patch complexity|--- |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14691] Can't delete patron with ' character in cardnumber

2015-08-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14691

Jonathan Druart jonathan.dru...@bugs.koha-community.org changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=14505

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14505] single quotes in journal number cause print routing list window to not appear

2015-08-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14505

Jonathan Druart jonathan.dru...@bugs.koha-community.org changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=14691

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14505] single quotes in journal number cause print routing list window to not appear

2015-08-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14505

Jonathan Druart jonathan.dru...@bugs.koha-community.org changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |j.kylm...@gmail.com
   |ity.org |
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14378] koha-run-backups should check disk usage first

2015-08-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14378

Joonas Kylmälä j.kylm...@gmail.com changed:

   What|Removed |Added

 CC||j.kylm...@gmail.com

--- Comment #1 from Joonas Kylmälä j.kylm...@gmail.com ---
(In reply to Pablo AB from comment #0)
 + option to backup indefinitely until destination dir/partition grow up to a
 given percentage (lets say 95 (%)).

The size of backups  free space could vary then quite a lot if there is a
huge/small storage in use. I suggest to leave there some nMb/nGb of space.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14698] New: AtomicUpdater - Keeps track of which updates have been applied to a database

2015-08-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14698

Bug ID: 14698
   Summary: AtomicUpdater - Keeps track of which updates have been
applied to a database
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Installation and upgrade (command-line installer)
  Assignee: gmcha...@gmail.com
  Reporter: olli-antti.kivila...@jns.fi
QA Contact: testo...@bugs.koha-community.org

We need to know which atomicupdates have been deployed to various test
databases. This feature adds a database table to keep track of the deployed
updates.

There is also a cronjob to easily interface with the atomicupdate database log
to revert entries and show them.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6499] MARC21 035 -- Other-control-number -- Indexing Matching

2015-08-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6499

Marcel de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

  Attachment #39099|0   |1
is obsolete||

--- Comment #18 from Marcel de Rooy m.de.r...@rijksmuseum.nl ---
Created attachment 41710
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41710action=edit
Bug 6499: Add Zebra index Other-control-number covering MARC21 035$a, 035$z
and 035 (entire tag)

1) Apply patch
2) Make sure that you have a bib that has MARC21 035$a (and possibly also
035$z) populated.

pre 3) Replace all modified zebra files and restart zebra server

3) Rebuild zebra: misc/migration_tools/rebuild_zebra.pl -x -b -z
4) Add the following to the intranetuserjs syspref:

$(document).ready(function(){
// Add Other Control Number to advanced search
if (window.location.href.indexOf(catalogue/search.pl)  -1) {
$(.advsearch).append('option value=Other-control-numberOther
Control Number/option');
}
});

5) Do an advanced search, select Other Control Number from the search menu,
then add the Other Control Number in 035$a for the bib specified in step 1.

Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com
Works, no koha-qa errors

Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 6499] MARC21 035 -- Other-control-number -- Indexing Matching

2015-08-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6499

--- Comment #19 from Marcel de Rooy m.de.r...@rijksmuseum.nl ---
Created attachment 41711
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41711action=edit
Bug 6499: [QA Follow-up] Trivial adjustments

Removes commented line from bib1.att.
Adjust OCLC-number to Other-control-number in comment of ccl properties.
No need to explicitly add 035$a and $z if you index 035 completely in
record.abs as well as biblio-koha-indexdefs.xml.
Rerun koha-indexdefs-to-zebra.xsl on index defs.

Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC

2015-08-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618

--- Comment #45 from Liz Rea l...@catalyst.net.nz ---
On memberentrygen.tt, all of the cases for *popup are broken, they show the
html we're sending in that variable instead of the dropdown. Most of them are
conditional, the main reason I noticed was because of the Patron title: field.

Suspect there will be heaps of stuff like this.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14691] Can't delete patron with ' character in cardnumber

2015-08-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14691

--- Comment #8 from Liz Rea l...@catalyst.net.nz ---
Yeah I was looking at that - I wasn't sure (didn't test, actually) whether
|html or |uri or |url would work here - the manual for TT doesn't indicate that
' is an escaped character in uri/url, and it will convert it to an entity in
html which I didn't test, but certainly could.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC

2015-08-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618

--- Comment #44 from Liz Rea l...@catalyst.net.nz ---
Created attachment 41746
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41746action=edit
Bug 13618 - memberentrygen.tt errors Not a GLOB reference

Like Jonathan said:
The interpolation of a variable on including a file caused an unexpected
error:
Template process failed: undef error - Not a GLOB reference at
/usr/lib/i386-linux-gnu/perl5/5.20/Template/Provider.pm line 619.

Replaced it with a SWITCH, like the other patch for this similar error.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14691] Can't delete patron with ' character in cardnumber

2015-08-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14691

--- Comment #7 from David Cook dc...@prosentient.com.au ---
(In reply to Liz Rea from comment #6)
 Right, ok. So, bug 13618 is nowhere near ready - I think if it isn't ready
 by shortly before string freeze we should go with this one in the meantime
 (and same for bug 14505) because even though we have a workaround (delete
 the '), it still shouldn't break like this.

When I originally mentioned bug 13618, I didn't realize that it wasn't ready
yet, so I think you're totally right about moving ahead with something else in
the meantime.

Another idea would be to upgrade Template Toolkit from version 2.24 to 2.26 and
use the uri or url filter:

As of version 2.26 of the Template Toolkit, the uri and url filters use the
unsafe character set defined by RFC3986. This means that certain characters
((, ), ~, *, ! and the single quote ') are now deemed unsafe and
will be escaped as hex character sequences. The double quote character ('') is
now deemed safe and will not be escaped.*
(http://template-toolkit.org/docs/manual/Filters.html#section_uri)

But it seems like Debian is still using 2.24 and only moved to 2.24 in the
Squeeze-Wheezy move...
(https://packages.debian.org/search?keywords=libtemplate-perl)

*I suppose double quote characters could cause problems if the Javascript was
using double quotes instead of single quotes... another idea is to roll our own
TT::Filter...

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14181] MARC21 773 -- Display when ind1 = 0 or blank

2015-08-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14181

--- Comment #9 from Winona Salesky wsale...@gmail.com ---
Great! Thanks. 
-Winona

(In reply to Tomás Cohen Arazi from comment #8)
 Patch pushed to master.
 
 Thanks Winona!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14691] Can't delete patron with ' character in cardnumber

2015-08-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14691

--- Comment #9 from Liz Rea l...@catalyst.net.nz ---
Yeah ok, I've tested those filters and none of them actually work, where this
one does.

If someone has a better solution, I'm happy to know it because then I'll learn
something. Otherwise... yeah lets test this one.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC

2015-08-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618

Liz Rea l...@catalyst.net.nz changed:

   What|Removed |Added

  Attachment #41746|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC

2015-08-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618

--- Comment #46 from Liz Rea l...@catalyst.net.nz ---
Created attachment 41747
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41747action=edit
Bug 13618 - memberentrygen.tt errors Not a GLOB reference

Like Jonathan said:
The interpolation of a variable on including a file caused an unexpected
error:
Template process failed: undef error - Not a GLOB reference at
/usr/lib/i386-linux-gnu/perl5/5.20/Template/Provider.pm line 619.

Replaced it with a SWITCH, like the other patch for this similar error.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11190] sitemap.pl -- Generate a Catalog sitemap

2015-08-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11190

--- Comment #41 from Frédéric Demians frede...@tamil.fr ---
Created attachment 41744
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41744action=edit
Bug 11190 sitemap.pl -- Generate a Catalog sitemap

Add a script sitemap.pl to process all biblio records from a Koha
instance and generate Sitemap files complying with this protocol as
described on http://sitemaps.org. The goal of this script is to be able
to provide to search engines direct access to biblio records. It avoid
leaving search engine browsing Koha OPAC and so generating a lot of
traffic, and workload, for a bad result.

Thanks Magnus for testing, and helping to improve the script design.

[2015.04.16] Switch from Moose to Moo.

[2015.08.20] Add complere (more) UT.

Signed-off-by: Magnus Enger mag...@enger.priv.no
All options to the script work as expected and the output looks
good. Nice enhancement!

Signed-off-by: Frederic Demians f.demi...@tamil.fr

I signed-of my own patch after fixing various QA errors.

Signed-off-by: Martin Renvoize martin.renvo...@ptfs-europe.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11190] sitemap.pl -- Generate a Catalog sitemap

2015-08-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11190

--- Comment #43 from Frédéric Demians frede...@tamil.fr ---
I have set back this patch status to 'Signed off'. The UT should suit QA needs.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11190] sitemap.pl -- Generate a Catalog sitemap

2015-08-20 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11190

Frédéric Demians frede...@tamil.fr changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

  1   2   >