[Koha-bugs] [Bug 14602] Fix failing t/Creators.t test, when using koha-shell
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14602 Mason James changed: What|Removed |Added Summary|Fix failing t/Creators.t|Fix failing t/Creators.t |test|test, when using koha-shell -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14602] Fix failing t/Creators.t test
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14602 Mason James changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14602] Fix failing t/Creators.t test
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14602 Mason James changed: What|Removed |Added Status|REOPENED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14602] Fix failing t/Creators.t test
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14602 Mason James changed: What|Removed |Added Resolution|INVALID |--- Status|RESOLVED|REOPENED --- Comment #6 from Mason James --- (In reply to Jonathan Druart from comment #4) > It passes for me (using a dev install from git). if you use koha-shell to run tests (and you should be!), it will fail so, bug still exists for some situations -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14567] Browse interface for OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14567 Heather changed: What|Removed |Added CC||heather_hernan...@nps.gov --- Comment #7 from Heather --- I tried it out here: http://browse.koha.catalystdemo.net.nz It seems nice, but it doesn't seem like a true browse to me--what I look for in a browse is to enter a search term, and have the results returned to be what is exactly before my searched term in the given index, then where the searched term is/would be, then what is exactly after the searched term in the index. So there would be no need for "exact, fuzzy, really fuzzy," because when I browse an index, I want the results to be what is before and after that term in the given index. That said, when I searched "exact" for "Author": Rowling I get: Rowling, J. K. Rowling, J.K. This is nice, but, again, it doesn't seem like a "browse" to me--these are just search results. When I click the names, I get the exact same search results as I do via Advanced Search, Author Phrase: http://browse.koha.catalystdemo.net.nz/cgi-bin/koha/opac-search.pl?idx=au%2Cphr&q=rowling&op=and&idx=kw&op=and&idx=kw&do=Search&sort_by=relevance&limit= If I Browse via "Fuzzy" with: Rowling I get these results: Rollins, Henry, Rowland, Sarah-Jane. Rowlands, David. Rowlands, Gena. Rowling, J. K. Rowling, J.K. Which does show me some results which should be in the author index above Rowling, but I get no results that should be in the author index after Rowling. "Really fuzzy" is the same. I would like to see the searched for term in the middle of hits that occur before and after it in the index, e.g. something like this (an author "Browse" result, with made up examples below Rowling, J.K.): Rollins, Henry, Rowland, Sarah-Jane. Rowlands, David. Rowlands, Gena. Rowling, J. K. Rowling, J.K. Rowlins, Fred. Rozalind, Sue. Rualla, Max. Ruscha, Ed. Ruther, Martin. Quahog, Amir. Quaker Alliance for Peace. I hope this is helpful! --h2 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14754] New: save fail safe
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14754 Bug ID: 14754 Summary: save fail safe Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: neng...@gmail.com QA Contact: testo...@bugs.koha-community.org Every page with 'save' on it should warn before leaving and not saving - cause you can do back button or click home at any time and lose your info -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14292] Add --category and --skip-category options to longoverdue.pl to include or exclude borrower categories.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14292 Nicole C. Engard changed: What|Removed |Added Status|NEW |ASSIGNED CC||neng...@gmail.com Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14753] New: Show accession date on checkin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14753 Bug ID: 14753 Summary: Show accession date on checkin Change sponsored?: Sponsored Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Circulation Assignee: jwea...@bywatersolutions.com Reporter: jwea...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com, nic...@bywatersolutions.com This will have a CSS class for easy hiding. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12663] SCOUserCSS and SCOUserJS ignored on selfcheck login page.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12663 Jesse Weaver changed: What|Removed |Added Change sponsored?|--- |Sponsored Status|NEW |ASSIGNED Assignee|koha-b...@lists.koha-commun |jwea...@bywatersolutions.co |ity.org |m CC||jwea...@bywatersolutions.co ||m, ||nic...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12544] Send scheduled reports as an attachment
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12544 Jesse Weaver changed: What|Removed |Added Assignee|gmcha...@gmail.com |jwea...@bywatersolutions.co ||m Status|NEW |ASSIGNED CC||jwea...@bywatersolutions.co ||m, ||nic...@bywatersolutions.com Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14752] New: Add multiple copies to a basket at once
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14752 Bug ID: 14752 Summary: Add multiple copies to a basket at once Change sponsored?: Sponsored Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: jwea...@bywatersolutions.com Reporter: jwea...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: nic...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918 --- Comment #20 from Jonathan Druart --- (In reply to Jonathan Druart from comment #19) > (In reply to Kyle M Hall from comment #18) > > Question, I see in the code that there is a "Waiting" tab for only waiting > > holds, yet I don't see it in the opac ( while on master ). Is this dead > > code? > > It looks like more than a bug :) After a deep dive into the code, it seems broken for a while! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918 --- Comment #19 from Jonathan Druart --- (In reply to Kyle M Hall from comment #18) > Question, I see in the code that there is a "Waiting" tab for only waiting > holds, yet I don't see it in the opac ( while on master ). Is this dead code? It looks like more than a bug :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961 Marc Véron changed: What|Removed |Added Attachment #42077|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961 --- Comment #10 from Marc Véron --- Created attachment 42089 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42089&action=edit [Follow-up] Remove whitespace from line 648 in C4/Letters.pm White space in 'empty' line removed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11247] Fix calls of TransformHtmlToXml
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11247 Marcel de Rooy changed: What|Removed |Added Attachment #41972|0 |1 is obsolete|| --- Comment #18 from Marcel de Rooy --- Created attachment 42088 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42088&action=edit Bug 11247: Add a simple unit test for TransformHtmlToXml The unit test is db dependent (as Jonathan correctly remarked), since the sub checks a preference. Test plan: Run t/db_dependent/Biblio/TransformHtmlToXml.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11247] Fix calls of TransformHtmlToXml
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11247 Marcel de Rooy changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11247] Fix calls of TransformHtmlToXml
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11247
--- Comment #17 from Marcel de Rooy ---
(In reply to Jonathan Druart from comment #16)
> % sudo service mysql stop
>
> % prove t/Biblio_TransformHtmlToXml.t
> t/Biblio_TransformHtmlToXml.t .. DBI
> connect('dbname=koha_ut;host=localhost;port=3306','koha_',...) failed: Can't
> connect to local MySQL server through socket '/var/run/mysqld/mysqld.sock'
> (2) at /usr/share/perl5/DBIx/Connector.pm line 32.
Oops, forgot that it checks a preference..
> We already have a t/Biblio/TransformKohaToMarc.t, it makes much more sense
> to put this new file in the t/Biblio dir, don't you think?
Will move it to t/db_dependent somewhere..
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Joonas Kylmälä changed: What|Removed |Added Attachment #42079|0 |1 is obsolete|| --- Comment #59 from Joonas Kylmälä --- Created attachment 42087 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42087&action=edit Bug 13618: Fix escape on sending baskets or shelves by email Test plan: Send baskets and shelves by email. With or without this patch, you should not see any changes. Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11084] Delete biblios on Leader 05 =d
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11084 Nicole C. Engard changed: What|Removed |Added CC||nic...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10855] Additional fields for subscriptions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10855 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Failed QA Assignee|jonathan.dru...@bugs.koha-c |julian.maur...@biblibre.com |ommunity.org| --- Comment #224 from Jonathan Druart --- Julian, there is a bug here. The additional_field_values entries are not deleted when a subscription is deleted. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13799] Add base for building RESTful API
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 --- Comment #138 from Alex Arnaud --- reattached the patch because i've changed the webservices url in the commit message (http://(OPAC|INTRANET)/api/v1/borrowers instead of http://(OPAC|INTRANET)/v1/borrowers) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13799] Add base for building RESTful API
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799
Alex Arnaud changed:
What|Removed |Added
Attachment #42085|0 |1
is obsolete||
--- Comment #137 from Alex Arnaud ---
Created attachment 42086
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42086&action=edit
Bug 13799: RESTful API with Mojolicious and Swagger2
Actual routes are:
/borrowers
Return a list of all borrowers in Koha
/borrowers/{borrowernumber}
Return the borrower identified by {borrowernumber}
(eg. /borrowers/1)
There is a test file you can run with:
$ prove t/db_dependent/rest/borrowers.t
All API stuff is in /api/v1 (except Perl modules)
So we have:
/api/v1/script.cgi CGI script
/api/v1/swagger.json Swagger specification
Change both OPAC and Intranet VirtualHosts to access the API,
so we have:
http://OPAC/api/v1/swagger.json Swagger specification
http://OPAC/api/v1/{path} API endpoint
http://INTRANET/api/v1/swagger.json Swagger specification
http://INTRANET/api/v1/{path} API endpoint
Add a (disabled) virtual host in Apache configuration api.HOSTNAME,
so we have:
http://api.HOSTNAME/api/v1/swagger.json Swagger specification
http://api.HOSTNAME/api/v1/{path} API endpoint
Add 'unblessed' subroutines to both Koha::Objects and Koha::Object to be
able to pass it to Mojolicious
Test plan:
1/ Install Perl modules Mojolicious and Swagger2
2/ perl Makefile.PL
3/ make && make install
4/ Change etc/koha-httpd.conf and copy it to the right place if needed
5/ Reload Apache
6/ Check that http://(OPAC|INTRANET)/api/v1/borrowers and
http://(OPAC|INTRANET)/api/v1/borrowers/{borrowernumber} works
Optionally, you could verify that http://(OPAC|INTRANET)/vX/borrowers
(where X is an integer greater than 1) returns a 404 error
Signed-off-by: Alex Arnaud
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13799] Add base for building RESTful API
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799
Alex Arnaud changed:
What|Removed |Added
Attachment #42044|0 |1
is obsolete||
--- Comment #136 from Alex Arnaud ---
Created attachment 42085
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42085&action=edit
Bug 13799: RESTful API with Mojolicious and Swagger2
Actual routes are:
/borrowers
Return a list of all borrowers in Koha
/borrowers/{borrowernumber}
Return the borrower identified by {borrowernumber}
(eg. /borrowers/1)
There is a test file you can run with:
$ prove t/db_dependent/rest/borrowers.t
All API stuff is in /api/v1 (except Perl modules)
So we have:
/api/v1/script.cgi CGI script
/api/v1/swagger.json Swagger specification
Change both OPAC and Intranet VirtualHosts to access the API,
so we have:
http://OPAC/api/v1/swagger.json Swagger specification
http://OPAC/api/v1/{path} API endpoint
http://INTRANET/api/v1/swagger.json Swagger specification
http://INTRANET/api/v1/{path} API endpoint
Add a (disabled) virtual host in Apache configuration api.HOSTNAME,
so we have:
http://api.HOSTNAME/api/v1/swagger.json Swagger specification
http://api.HOSTNAME/api/v1/{path} API endpoint
Add 'unblessed' subroutines to both Koha::Objects and Koha::Object to be
able to pass it to Mojolicious
Test plan:
1/ Install Perl modules Mojolicious and Swagger2
2/ perl Makefile.PL
3/ make && make install
4/ Change etc/koha-httpd.conf and copy it to the right place if needed
5/ Reload Apache
6/ Check that http://(OPAC|INTRANET)/v1/borrowers and
http://(OPAC|INTRANET)/v1/borrowers/{borrowernumber} works
Optionally, you could verify that http://(OPAC|INTRANET)/vX/borrowers
(where X is an integer greater than 1) returns a 404 error
Signed-off-by: Alex Arnaud
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14651] Koha::Item::effective_itemtype should fallback to biblio-level if no item-level itemtype
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14651 Tomás Cohen Arazi changed: What|Removed |Added Attachment #41636|0 |1 is obsolete|| --- Comment #5 from Tomás Cohen Arazi --- Created attachment 42084 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42084&action=edit Bug 14651: Koha::Item->effective_itemtype fallback to bib-level In some situations (bad migrations, old bugs that introduced bad data, people having bib-level itypes for ages and switching to item level...) the user ends with undex itype values for items. The current code, if the user has item_level-itype set, just returns undef. It should fallback to bib-level. In order to avoid hiding the problem a warning is raised. To test: - Run the regression tets: $ prove t/db_dependent/Items.t => FAIL: tests fail. - Apply the patch - Run the tests again => SUCCESS: The tests now pass. - Sign off :-D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14651] Koha::Item::effective_itemtype should fallback to biblio-level if no item-level itemtype
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14651 Tomás Cohen Arazi changed: What|Removed |Added Attachment #41635|0 |1 is obsolete|| --- Comment #4 from Tomás Cohen Arazi --- Created attachment 42083 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42083&action=edit Bug 14651: (regression test) fallback to bib-level if itype is undef Koha::Item->effective_itemtype should fallback to biblio-level itemtype even if item-level item types are set, in the case the item has no itemtype set (bad migration, bad old code). To test: - Run $ prove t/db_dependent/Items.t => FAIL: Koha::Item->effective_itemtype doesn't work properly Edit: Added a test for a warning when falling back as per QA request and because it made a lot of sense :-D -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918
--- Comment #18 from Kyle M Hall ---
Thanks, I understand what you were asking now.
> > t/db_dependent/BiblioObject.t
>
> I would prefer a better filename, but nothing in mind to suggest.
I feel the same way, but have nothing better to suggest either.
> > +my $field_mappings =
> > Koha::Database->new()->schema()->resultset('Fieldmapping');
>
> Could be better to have a Koha::Fieldmapping[s]
I can do this if you'd like. It was just a quick way to create a field mapping,
so I went with dbic directly. Just let me know if you want me to go ahead an
add a followup to add and use Koha::Fieldmapping[s]
>
> > -waiting_count => $wcount,
>
> This variable is still used in the template.
>
> > +WAITING=> $reserves->waiting()
>
> Why not remove this one and access to the waiting holds using
> RESERVES.waiting in the template?
I'm working on these ones right now.
Question, I see in the code that there is a "Waiting" tab for only waiting
holds, yet I don't see it in the opac ( while on master ). Is this dead code?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14602] Fix failing t/Creators.t test
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14602 Jonathan Druart changed: What|Removed |Added Resolution|--- |INVALID Status|Signed Off |RESOLVED --- Comment #5 from Jonathan Druart --- ping Mason! % git checkout -b bug_14602 3b23fb8 Switched to a new branch 'bug_14602' % prove t/Creators.t t/Creators.t .. ok All tests successful. Files=1, Tests=16, 1 wallclock secs ( 0.04 usr 0.00 sys + 0.60 cusr 0.02 csys = 0.66 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14598] itemtype is not set on statistics by C4::Circulation::AddReturn
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14598 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14590] Checkboxes should be disabled without valid contact information in messaging preferences
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14590 Lari Taskula changed: What|Removed |Added Status|NEW |Needs Signoff --- Comment #9 from Lari Taskula --- This patch makes both client and server side validations, both in OPAC and Staff client. Depends on Bug 14620. Test plan for Staff client: 1. Login to Staff client 2. Enable syspref ValidateEmailAddress and set ValidatePhoneNumber to "ipn" 3. Enable syspref TalkingTechItivaPhoneNotification and SMSSendDriver (write anything), and allow syspref EnhancedMessagingPreferences 4. Navigate to modify patron's information at memberentry.pl 5. Insert valid primary phone number, primary email address and SMS number 6. Check all messaging preferences and submit changes 7. Navigate to modify patron's information at memberentry.pl 8. Clear primary email, primary phone and SMS number fields and submit changes 9. Observe that the messaging preferences are disabled Test plan for OPAC: -1. Make sure sysprefs are set like in Staff client test step 2-3 1. Login to OPAC 2. Navigate to "your personal details" 3. Insert valid primary phone number, primary email address and SMS number 4. Submit changes 5. Login to Staff client 5.1. Navigate to Patrons 5.2. Approve information modification request 6. Back in OPAC, Navigate to "your messaging" 7. Check all messaging preferences and submit changes 8. Navigate to "your personal details" 9. Clear primary email, primary phone and submit changes 10. Repeat step 5 and 6 11. Observe that the messaging preferences are disabled for "Phone" and "Email" columns 12. Clear SMS number field and submit changes 13. Observe that all the messaging preferences are disabled This patch also includes a maintenance script at misc/maintenance/deleteMisconfiguredMessagingPrefs.pl that goes through all borrowers and automatically deletes their misconfigured messaging preferences. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14621] Messaging preferences table needs to be sorted
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14621 Lari Taskula changed: What|Removed |Added Assignee|oleon...@myacpl.org |la...@student.uef.fi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14541] Tax rate should not be forced to an arbitrary precision
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14541 Kyle M Hall changed: What|Removed |Added CC||kyle.m.h...@gmail.com --- Comment #11 from Kyle M Hall --- (In reply to Jonathan Druart from comment #5) > Kyle, > The tax rate is displayed at several places, at least acqui/supplier.tt. > The change should affect all the places where it is displayed. > You should also have a look at how I display them on bug 13323 using a > template plugin: [% order.gstrate * 100 | $Price %] > > I can provide a patch on top of bug 13323 if you can wait for it to be > pushed. That works for me Jonathan! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13411] Koha's SIP server returns not ok for checking in items that are not checked out
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411 Kyle M Hall changed: What|Removed |Added CC||kyle.m.h...@gmail.com --- Comment #28 from Kyle M Hall --- (In reply to Colin Campbell from comment #25) > Patch not working as advertised - in the rebasings it looks like we've lost > the check of the config value to pass to checkin so the checked_in_ok > variable is never passed Thanks for catching that! I've re-rebased the patch to correct that omission! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13411] Koha's SIP server returns not ok for checking in items that are not checked out
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411 Kyle M Hall changed: What|Removed |Added Attachment #42035|0 |1 is obsolete|| Attachment #42036|0 |1 is obsolete|| --- Comment #26 from Kyle M Hall --- Created attachment 42081 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42081&action=edit Bug 13411 - Koha's SIP server returns not ok for checking in items that are not checked out If an item is not checked out when a checkin via SIP2 is attempted, Koha's SIP server sends back an "ok" of 0, and the AF message "Item not checked out". I am not entirely sure this is good and correct behavior by the SIP2 protocol. In particular, this will cause SIP2 book sorting devices to fail on all items that are not checked out, causing them all to be put into the "special handling" been that should be reserved for things like items checked in at the wrong library and items on hold. Test Plan: 1) Apply the patch for bug 13159 so you can use the new enhanced SIP2 command line emulator 2) Use a command similar to the following to check in an item: sip_cli_emulator.pl -a localhost -su -sp -l --item -m checkin 3) Note the 3rd character is 0, and there is an AF field saying the item is not checked out 4) Apply this patch 5) Restart the SIP server 6) Repeat steps 2-3, note that nothing has changed 7) In the SIP config file, Add the parameter checked_in_ok="1" to the SIP account you are using. 8) Restart the SIP server 9) Repeat steps 2-3, note that this time the 4rd character is 1, and you do not recieve the item not checked out message. Signed-off-by: Benjamin Rokseth -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13411] Koha's SIP server returns not ok for checking in items that are not checked out
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411 --- Comment #27 from Kyle M Hall --- Created attachment 42082 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42082&action=edit Bug 13411 [QA Followup] - Add logging -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13411] Koha's SIP server returns not ok for checking in items that are not checked out
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411 Kyle M Hall changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14543] Order lines updated that have a tax rate not in gist will have tax rate set to 0!
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14543 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #2 from Jonathan Druart --- I would be happy to test this patch if it was not dependent on bug 14541. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14620] Contact information validations
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14620
Joonas Kylmälä changed:
What|Removed |Added
Attachment #41502|0 |1
is obsolete||
Attachment #41527|0 |1
is obsolete||
--- Comment #10 from Joonas Kylmälä ---
Created attachment 42080
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42080&action=edit
Bug 14620 - Contact information validations
I'm thinking we should centralize all patron's contact information validators
into one module. Currently we only have validations for e-mail addresses, using
the Email::Valid module. In our local library we also want to validate phone
numbers with a regex that only recognizes phone numbers from my country. So I
suggest we create a phone number validation as well, with an option to easily
create custom regex for your local use.
If a library does not wish to use validations, we should give them an option to
turn them off. If more local validators are implemented, we should also give
the library an option to select which validator they wish to use.
With this method we could implement phone number validators from around the
world and add them into our module. Then we would make the validations simply
by calling our validator. The validator would know by system preference which
one of the implemented phone number validators it should use.
Validations should be both client and server side.
Test plan:
1. Apply the patches (and run updatedatabase.pl).
2. Set system preferences ValidateEmailAddress to "Enable" and
ValidatePhoneNumber to "International Phone Numbers".
3. Make sure JavaScript is enabled.
4. Navigate to edit user contact informations in Staff client and OPAC.
5. Clear email and phone fields.
6. Insert whitespaces to email and phone fields and submit the form.
7. Edit patron.
8. Observe that there are no longer whitespaces in email and phone fields.
9. Insert invalid email (e.g. "invalid") and invalid phone number
("+123invalid") and send the form.
10. Confirm that form will not be submitted and errors will be given.
11. Disable JavaScript.
12. Insert invalid email and invalid phone number
13. Try sending the form again.
14. Confirm that form will be submitted but errors will be given on top of the
form.
15. Observe that none of the changes are accepted.
16. Set system preferences ValidateEmailAddress to "Disable" and
ValidatePhoneNumber to "none".
17. Repeat step 3-9 but observe that errors will not be given and changes will
be submitted and saved.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11247] Fix calls of TransformHtmlToXml
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11247
Jonathan Druart changed:
What|Removed |Added
CC||jonathan.dru...@bugs.koha-c
||ommunity.org
Status|Signed Off |Failed QA
--- Comment #16 from Jonathan Druart
---
% sudo service mysql stop
% prove t/Biblio_TransformHtmlToXml.t
t/Biblio_TransformHtmlToXml.t .. DBI
connect('dbname=koha_ut;host=localhost;port=3306','koha_',...) failed: Can't
connect to local MySQL server through socket '/var/run/mysqld/mysqld.sock' (2)
at /usr/share/perl5/DBIx/Connector.pm line 32.
We already have a t/Biblio/TransformKohaToMarc.t, it makes much more sense to
put this new file in the t/Biblio dir, don't you think?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14620] Contact information validations
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14620 Lari Taskula changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14610] Add ability to place document delivery / article requests in Koha
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 Nicole C. Engard changed: What|Removed |Added CC||neng...@gmail.com, ||nic...@bywatersolutions.com Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #58 from Jonathan Druart --- Created attachment 42079 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42079&action=edit Bug 13618: Fix escape on sending baskets or shelves by email Test plan: Send baskets and shelves by email. With or without this patch, you should not see any changes. variables - intra -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961 --- Comment #9 from Joonas Kylmälä --- (In reply to Joonas Kylmälä from comment #8) > (In reply to Marc Véron from comment #7) > > Created attachment 42077 [details] > > Screenshot from diff view - white chars in empty line 648 in C4/letters.pm > > > > Hi Joonas, > > > > There are some space chars in an empty line, see screenshot from diff view. > > > > Marc > > When I apply the patch and try to edit with Gedit, Atom, Nano none of these > editors see the whitespace. Can you please make a follow-up where you remove > it because I'm not able to. I think the problem is with the bugzilla's diff shower because in my patch I didn't even modify that line. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14337] AllowRenewalIfOtherItemsAvailable counts holdable not for loan items when checking renewability
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14337 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com Status|Passed QA |Pushed to Master --- Comment #25 from Tomás Cohen Arazi --- Patches pushed to master. Thanks Kyle and Jonathan! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14703] Holidays description shows \r\n for every new line
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14703 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com Status|Passed QA |Pushed to Master --- Comment #11 from Tomás Cohen Arazi --- Patch pushed to master. Thanks Joonas! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11584] Add wysiwyg editor to system preferences dealing with HTML
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11584 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||tomasco...@gmail.com --- Comment #27 from Tomás Cohen Arazi --- Enhancement pushed to master. Nice one David! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961 --- Comment #8 from Joonas Kylmälä --- (In reply to Marc Véron from comment #7) > Created attachment 42077 [details] > Screenshot from diff view - white chars in empty line 648 in C4/letters.pm > > Hi Joonas, > > There are some space chars in an empty line, see screenshot from diff view. > > Marc When I apply the patch and try to edit with Gedit, Atom, Nano none of these editors see the whitespace. Can you please make a follow-up where you remove it because I'm not able to. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813 --- Comment #152 from Marc Véron --- Hi Marcel, Thanks a lot for QAing. I really appreciate. Question: Can we remove the 'problematic' patches from this huge patch set and then do a second round (maybe with a new bug number) after the 'unproblematic' patches have been pushed? Marc -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11880] Select the barcode index by default then searching for label items.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11880 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||tomasco...@gmail.com --- Comment #14 from Tomás Cohen Arazi --- Patches pushed to master. Thanks Frederick and Jonathan! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13697] Syspref to not add a fee when a patron changes to a category with enrolment fee
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13697 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com Status|Passed QA |Pushed to Master --- Comment #9 from Tomás Cohen Arazi --- Patches pushed to master. Thanks Christophe and Kyle! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13383] RDA: 100/110/111 changes to XSLT
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13383 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||tomasco...@gmail.com --- Comment #25 from Tomás Cohen Arazi --- Patch pushed to master. Thanks Winona! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14737] Can't use cn_browser.pl cataloguing plugin without superlibrarian permissions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14737 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com Status|Passed QA |Pushed to Master --- Comment #4 from Tomás Cohen Arazi --- Fix pushed to master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Joonas Kylmälä changed: What|Removed |Added Attachment #42078|Fixed the plain texts. |Bug 13618: Specific places description||where we don't need to ||escape || variables - intra -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Joonas Kylmälä changed: What|Removed |Added Attachment #41350|0 |1 is obsolete|| --- Comment #57 from Joonas Kylmälä --- Created attachment 42078 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42078&action=edit Fixed the plain texts. Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961 --- Comment #7 from Marc Véron --- Created attachment 42077 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42077&action=edit Screenshot from diff view - white chars in empty line 648 in C4/letters.pm Hi Joonas, There are some space chars in an empty line, see screenshot from diff view. Marc -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13697] Syspref to not add a fee when a patron changes to a category with enrolment fee
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13697 --- Comment #8 from Tomás Cohen Arazi --- Created attachment 42076 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42076&action=edit Bug 13697: (QA followup) idiomatic fix add > charge Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14723] Additional delivery notes to messages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 Lari Taskula changed: What|Removed |Added Depends on||14536 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14536 [Bug 14536] PageObject-pattern base implementation -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14536] PageObject-pattern base implementation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14536 Lari Taskula changed: What|Removed |Added Blocks||14723 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 [Bug 14723] Additional delivery notes to messages -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Joonas Kylmälä changed: What|Removed |Added Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Joonas Kylmälä changed: What|Removed |Added Attachment #42073|0 |1 is obsolete|| --- Comment #56 from Joonas Kylmälä --- Created attachment 42075 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42075&action=edit Bug 13618: Specific for XSLTBloc Fixes the raw text nicely Signed-off-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14217] Add a DOM syntax for specifying conditions on indexes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14217 --- Comment #8 from Tomás Cohen Arazi --- (In reply to Marcel de Rooy from comment #6) > This is certainly an interesting development! > > But it might need some further (broader) discussion before getting in. > In the first place: Why do we really need it? Can you elaborate/illustrate? > If we add conditions, what kind of conditions do we want? Syntax? Etc. A > broader design may be easier to maintain.. > How do comparable systems implement this? There are some situations where you need to add conditions as Barton told you. Possible conditions (the ones I had in mind are conditions on the indicator values, as I stated on the commit message). As Barton wrote, if you want to send a field/subfield to a different index depending on the value of the indicators, you can do it with this. If you look at it, we already do it for authority records, but with a more complex syntax. Look at authority-koha-indexdefs.xml: Previous-heading-see-from:p the whole syntax is similar to the one i implement, but you need to add a new tag name if you want conditional indexing, while i just overload the current syntax, which is really convenient. > If we add this for Zebra, what about other search engines? Each search engine provides means to specify what/how to index. I guess stuff like ES are more flexible than Zebra, for sure. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14217] Add a DOM syntax for specifying conditions on indexes
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14217 --- Comment #7 from Barton Chittenden --- (In reply to Marcel de Rooy from comment #6) > This is certainly an interesting development! > > But it might need some further (broader) discussion before getting in. > In the first place: Why do we really need it? Can you elaborate/illustrate? > If we add conditions, what kind of conditions do we want? Syntax? Etc. A > broader design may be easier to maintain.. > How do comparable systems implement this? > If we add this for Zebra, what about other search engines? Marcel, The functionality definitely *is* needed -- see, for instance bug 14277, where the meaning of 521$a varies drastically based on the value of ind1. The 'condition=' syntax feels like overkill to me -- before work with the inicators, I assumed that the arguments to the xml tag were essentially limits that were ANDed together... I guess they're not, but I think that we could pull a 'convention over configuration' fast one and pretend that they are: 'tag' and 'subfield' are required attributes, specifying the marc field and subfield, alll other attributes are limits -- if not present, all matching tags/subfields will be used. ...or we could go with the 'condition=' syntax, and make it explicit. I'm fine either way, as long as I can limit by indicator. :-) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14723] Additional delivery notes to messages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723
--- Comment #3 from Lari Taskula ---
Created attachment 42074
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42074&action=edit
Bug 14723: (follow-up) Example of handling custom SMS::Send Driver reports
This patch presents an example of how SMS::Send driver can be configured to
receive reports from your SMS Gateway provider if they support such feature.
With Bug 14723 adding a delivery note column to message_queue, you are now
able to update the error status provided by your SMS gateway provider
to the message.
It uses REST API, so make sure to include dependencies.
Koha conf gets a new block "smsProviders", where you are able to define
your SMS Gateway login data and the report URL that our provider will use.
Koha httpd conf gets an example for blocking all traffic to the REST API
address for modifying the message status, apart from our provider IPs.
Here is a description of the protocol and common actions with the example
driver.
1. message_queue gets processed as usual.
2. Letters.pm calls our example driver with phone number, content and
message_id (new!).
3. Our example driver sends a POST request to the SMS Gateway provider as
follows:
- user: username, loaded from koha conf smsProviders->labyrintti
- password: password, loaded from koha conf smsProviders->labyrintti
- dests: destination phone number
- text: content of the message
- report: the URL that SMS Gateway provider will update the status of this
delivery,
loaded from koha conf (with REST API, it should be
http://yourhost.com/v1/messages)
smsProviders->labyrintti
4. We get (hopefully) an OK message from our SMS provider. It will already let
us know
if there was an error with the phone number. If so, we return it to
Letters.pm via HASH:
{ status => 1/0, delivery_note => the message of error/success }
5. When the delivery is complete, our SMS Gateway will contact us via the
report URL we provided.
6. Via Swagger definitions, we will use Koha::REST::V1::Messages
delivery_report to handle the
report. If the given status is "ERROR" (this is our example provider's
protocol), we will
update the message status (and add delivery note) in message_queue for the
given message_id.
7. All done, we have now handled the report given by our SMS Gateway provider
:)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14723] Additional delivery notes to messages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 --- Comment #2 from Lari Taskula --- To test template modifications: 1. Find a borrower with notices at members/notices.pl 2. Observe that there is no column for Delivery notes 3. Apply patch and run the given database update 4. Repeat step 1. 5. Observe that there is now a column for Delivery notes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #55 from Jonathan Druart --- (In reply to Joonas Kylmälä from comment #52) > (In reply to Joonas Kylmälä from comment #51) > > Created attachment 42054 [details] [review] [review] > > Bug 13618: Use Template::Stash::AutoEscaping to use the html filter > > > > Test plan done and worked. I deleted the commits from 13609, and then > > applied this and it also solved the xss vulnerability. > > > > Signed-off-by: Joonas Kylmälä > > Thought it worked, but now noticed it broked the html in > /cgi-bin/koha/opac-tags.pl?mine=1 (my tags in opac). Under the title column > it only shows html as plain text. "Bug 13618: Specific for other prefs" reuploaded, OPACMySummaryNote was not correctly managed. New patch "Specific for XSLTBloc" should fix your issue -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #54 from Jonathan Druart --- Created attachment 42073 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42073&action=edit Bug 13618: Specific for XSLTBloc -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart changed: What|Removed |Added Attachment #41776|0 |1 is obsolete|| --- Comment #53 from Jonathan Druart --- Created attachment 42072 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42072&action=edit Bug 13618: Specific for other prefs opacmainuserblock opacnav opacnavright opaccredits opacheader opaccustomsearch opacmysummaryhtml opacmysummarynote opacnavbottom opacnoresultsfound opacresultssidebar opacsearchfortitlein restrictedpagecontent PatronSelfRegistrationAdditionalInstructions intranetmainuserblock intranetnav intranetslipprinterjs OpacSuppressionMessage SCOUserCSS SCOUserJS SelfCheckHelpMessage NoLoginInstructions -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10181] Improve message shown for deleted records in basket summary page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10181 --- Comment #5 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #2) > Applying: Bug 10181: Acq - Improve message for deleted records > fatal: sha1 information is lacking or useless > (koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt). > Repository lacks necessary blobs to fall back on 3-way merge. Oops, I have forgotten a patch! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10181] Improve message shown for deleted records in basket summary page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10181 --- Comment #4 from Jonathan Druart --- Created attachment 42071 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42071&action=edit Bug 10181: Acq - Improve message for deleted records There are some issues here: 1/ Message not translatable (set in the pl file) 2/ ' by 'displayed even if no author defined 3/ Message not the same every where 4/ Nothing displayed on the invoice page Test plan: 1/ Create a basket 2/ Add 4 orders A, B, C, D 3/ On the basket, you see "$title by $author", or "$title" if no author defined 4/ Delete order A, B 5/ Close the basket 6/ Receive B, C 7/ Delete record created for A, C 8/ Go on the basket page, you should see the title and "Deleted bibliographic record, can't find title" for the deleted record 9/ Go on the invoice page, you should see the title and "Deleted bibliographic record, can't find title" for the deleted record -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10181] Improve message shown for deleted records in basket summary page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10181 Jonathan Druart changed: What|Removed |Added Attachment #37894|0 |1 is obsolete|| --- Comment #3 from Jonathan Druart --- Created attachment 42070 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42070&action=edit Bug 10181: Make string translatable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10181] Improve message shown for deleted records in basket summary page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10181 Jonathan Druart changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12478] Elasticsearch support for Koha
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #90 from Jonathan Druart --- Something else, there is a sort issue in the facets: [Some entries] Zeitoun, Ariel, Ó Cadhain, Máirtín. Ślez, Ts.. Ó should be after O, not after Z. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12478] Elasticsearch support for Koha
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #85 from Jonathan Druart --- Created attachment 42065 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42065&action=edit Bug 12478: Fix pod in the rebuild_ES.pl script -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12478] Elasticsearch support for Koha
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #88 from Jonathan Druart --- Created attachment 42068 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42068&action=edit Bug 12478: Do not display the 'Show more' links if no more facet available -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12478] Elasticsearch support for Koha
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #87 from Jonathan Druart --- Created attachment 42067 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42067&action=edit Bug 12478: Display the correct number of facets (5 instead of 6) The loop on facet entries was wrong, it should stop after 5 iterations. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12478] Elasticsearch support for Koha
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478
--- Comment #89 from Jonathan Druart
---
Created attachment 42069
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42069&action=edit
Bug 12478: Fix encoding issue on facets
Filer on "Ślez, Ts." => Can't escape \x{015A}, try uri_escape_utf8()
instead at
/home/koha/src/Koha/SearchEngine/Elasticsearch/QueryBuilder.pm line 221.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12478] Elasticsearch support for Koha
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #86 from Jonathan Druart --- Created attachment 42066 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42066&action=edit Bug 12478: Remove Solr occurrences reintroduced by a previous patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12478] Elasticsearch support for Koha
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #83 from Jonathan Druart --- Created attachment 42063 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42063&action=edit Bug 12478: Change the commit count to 5k It will improve the indexing time. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12478] Elasticsearch support for Koha
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #82 from Jonathan Druart --- Created attachment 42062 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42062&action=edit Bug 12478: Fix the UNIMARC and NORMARC indexing 1/ This patch fixes a major issue on UNIMARC and NORMARC installations (Compulsive c/p on insert into insert into search_marc_to_field for unimarc and normarc) 2/ After fixing that, I got invalid marc path at /usr/share/perl5/Catmandu/Fix/marc_map.pm line 35. on reindexing. It was caused by some "" values instead of NULL. 3/ Then, a "duplicate entry" error was caused by 3 lines for Local-number. It seems to be an error, 1 is enough (I suppose 0909 was an error too). Note that the following is not fixed by this patch: MariaDB [koha_es_unimarc]> insert into search_field (name, type) select distinct mapping, type from elasticsearch_mapping; Query OK, 73 rows affected, 57 warnings (0.05 sec) Records: 73 Duplicates: 0 Warnings: 57 MariaDB [koha_es_unimarc]> show warnings; +-+--++ | Level | Code | Message| +-+--++ | Warning | 1265 | Data truncated for column 'type' at row 1 | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12478] Elasticsearch support for Koha
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #84 from Jonathan Druart --- Created attachment 42064 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42064&action=edit Bug 12478: Fix the verbose flag on reindexing -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13618] Prevent XSS in the Staff Client and the OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Joonas Kylmälä changed: What|Removed |Added CC||j.kylm...@gmail.com --- Comment #52 from Joonas Kylmälä --- (In reply to Joonas Kylmälä from comment #51) > Created attachment 42054 [details] [review] > Bug 13618: Use Template::Stash::AutoEscaping to use the html filter > > Test plan done and worked. I deleted the commits from 13609, and then > applied this and it also solved the xss vulnerability. > > Signed-off-by: Joonas Kylmälä Thought it worked, but now noticed it broked the html in /cgi-bin/koha/opac-tags.pl?mine=1 (my tags in opac). Under the title column it only shows html as plain text. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14751] Allow C4::Context->interface to be set to 'sip' or 'commandline'
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14751 Kyle M Hall changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14751] Allow C4::Context->interface to be set to 'sip' or 'commandline'
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14751 --- Comment #1 from Kyle M Hall --- Created attachment 42061 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42061&action=edit Bug 14751 - Allow C4::Context->interface to be set to 'sip' or 'commandline' Koha::Logger allows us to split up logging to separate files based on the interface. However, right now the interface is limited to just 'opac' or 'intranet'. We should extend this to allow the interface to also be set to 'sip' for SIP server logging, and to 'commandline' for cronjobs and all other command line scripts. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14751] Allow C4::Context->interface to be set to 'sip' or 'commandline'
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14751 Kyle M Hall changed: What|Removed |Added Assignee|gmcha...@gmail.com |kyle.m.h...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14751] New: Allow C4::Context->interface to be set to 'sip' or 'commandline'
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14751 Bug ID: 14751 Summary: Allow C4::Context->interface to be set to 'sip' or 'commandline' Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcha...@gmail.com Reporter: kyle.m.h...@gmail.com QA Contact: testo...@bugs.koha-community.org Koha::Logger allows us to split up logging to separate files based on the interface. However, right now the interface is limited to just 'opac' or 'intranet'. I propose we extend this to allow the interface to also be set to 'sip' for SIP server logging, and to 'commandline' for cronjobs and all other command line scripts. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12478] Elasticsearch support for Koha
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478
--- Comment #81 from Jonathan Druart
---
(In reply to Robin Sheat from comment #80)
> (In reply to Jonathan Druart from comment #79)
> > The first problem I got was to find a MARC21 DB (since the UNIMARC mappings
> > are not defined, I cannot test with an UNIMARC DB).
>
> The UNIMARC mappings should be defined, though not tested.
Well, it's defined yes, but does not work at all (the marc21 mappings are used)
:)
It is caused by some errors in the sql file. Patch's coming.
Note the following:
MariaDB [koha_es_unimarc]> insert into search_field (name, type) select
distinct mapping, type from elasticsearch_mapping;
Query OK, 73 rows affected, 57 warnings (0.05 sec)
Records: 73 Duplicates: 0 Warnings: 57
MariaDB [koha_es_unimarc]> show warnings;
+-+--++
| Level | Code | Message|
+-+--++
| Warning | 1265 | Data truncated for column 'type' at row 1 |
and 72 others.
> > I have used the one created for the sandboxes
> > (http://git.koha-community.org/gitweb/?p=contrib/global.git;a=blob;f=sandbox/
> > sql/sandbox1.sql.gz;h=19268bccb43b2a33d5644b7d86cbb1abb323016b;hb=HEAD). But
> > there are only 436 biblios, it's not enough to test some stuffs (facets for
> > instance).
> > Or maybe you can share your DB?
>
> I could, but I think we'll get more useful results from different databases.
Yes of course, but I am not a real tester, I am a developer, and it would be
useful to share info on specific data.
I am fine to use the sandbox DB, if it's ok for you.
> > Here some notes:
> >
> > 1/ Add deps to C4/Installer/PerlDependencies.pm
>
> Yeah, I'm mostly waiting for things to settle (which they have now.)
>
> > 2/ The number of tests provided is very low.
>
> Yes, I've been meaning to go back and add a pile more.
Ok, I let it that for you :)
> > 6/ Verbose does not work as expected, it could be fixed with
>
> Oops. TODOed.
Patch is coming.
> > 7/ perl -e "use
> > Pod::Checker;podchecker('misc/search_tools/rebuild_elastic_search.pl')";
> > *** WARNING: empty section in previous paragraph at line 36 in file
> > misc/search_tools/rebuild_elastic_search.pl
> > *** ERROR: =over on line 38 without closing =back at line EOF in file
> > misc/search_tools/rebuild_elastic_search.pl
>
> TODOed.
Patch is coming.
> > 8/ 2 occurrences of "Solr" reintroduced in installer/data/mysql/sysprefs.sql
> > and koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref
>
> Must have come about when merging. TODOed.
Patch is coming.
> > 9/ Test!
> > c. Search for 'harry', sort by title AZ (screenshot
> > opac_search_for_harry_sort_by_title.png)
> > - 'Show more' links is displayed even if only 2 entries for a facet are
> > available
>
> Thought I'd fixed that, I'll have to have a look again.
Patch is coming.
> > - The order is still different ("The discovery of heaven" should be sorted
> > either before Dollhouse (if the is a stopword) either after "Hareios*"
>
> Dollhouse probably has another title field that's actually being used, as
> noted above.
Yes it has:
title":["Dollhouse"],["Seasons one & two."]]
245$a Dollhouse
490$a Seasons one & two.
But 245$a should be used for sorting :)
> > - The availability is wrong for ES (The item for Dollhouse is not for loan)
>
> Why is it not for loan? Is it by policy, because there are no items, or
> because all items are issued?
The item is a "Visual Materials" which has a itemtype.notforloan flag set.
> > d. Search for Books (limit by item type in the adv search), sort by pubdate
> > (screenshot limit_by_book_sort_by_pubdate.png)
> > - "Return to the last advanced search" link is not displayed
>
> I wonder how it knows to show that...
>
> I can't actually find that string in my checkout at all.
Yes sorry, introduced by Bug 13307: Create a link to the last advanced search
in search result page (OPAC).
Which is not in your branch yet.
> > - The item types facet contains several entries, which does not make sense
>
> Curious. Are there situations where you have a biblio-level itemtype that
> differs from the item-level item type, or where one biblio might have
> multiple items with different item types? At the moment, I think they're all
> being thrown into one facet pot.
It comes from biblioitems.itemtype=2WEEK
Not sure if the data I used are correct...
> > - The number of results highly differ (395 vs 364)
>
> Probably due to biblio-vs-item itemtype selection not being supported yet.
> If you can find it giving you a record that plain shouldn't match though,
> that'd be interesting.
Outch, not sure how I could find that easily.
> > - The order is still completely different. I had a look in the index and
> > found:
> > "Pictura murală*" has "pubdate":"" (/_search?q=_id:39&pretty)
> > The Korean Go
[Koha-bugs] [Bug 14723] Additional delivery notes to messages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 Lari Taskula changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |la...@student.uef.fi |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14536] PageObject-pattern base implementation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14536 --- Comment #12 from Lari Taskula --- Created attachment 42060 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42060&action=edit Bug 14536: (follow-up) Add PageObject for members/notices.pl This patch adds a new PageObject Notices for members/notices.pl page. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13799] Add base for building RESTful API
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 Lari Taskula changed: What|Removed |Added Blocks||14723 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 [Bug 14723] Additional delivery notes to messages -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14723] Additional delivery notes to messages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723 Lari Taskula changed: What|Removed |Added Depends on||13799 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 [Bug 13799] Add base for building RESTful API -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14197] Warning raised by TestBuilder
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14197 Marcel de Rooy changed: What|Removed |Added Attachment #42059|Used to test the change |[DO_NOT_PUSH] Used to test description|with/without first two |the change with/without |patches |first two patches -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14197] Warning raised by TestBuilder
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14197 Marcel de Rooy changed: What|Removed |Added Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14197] Warning raised by TestBuilder
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14197 Marcel de Rooy changed: What|Removed |Added Attachment #42056|0 |1 is obsolete|| --- Comment #12 from Marcel de Rooy --- Created attachment 42059 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42059&action=edit Used to test the change with/without first two patches -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14197] Warning raised by TestBuilder
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14197 Marcel de Rooy changed: What|Removed |Added Attachment #39146|0 |1 is obsolete|| --- Comment #10 from Marcel de Rooy --- Created attachment 42057 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42057&action=edit Bug 14197: Remove the warning on destroying TestBuilder objects This module will be called by db_dependent tests, which already create a transaction. TestBuilder creates a new one (which is certainly useless) and the rollback does not do anything. To see the warning see patches on bug 14045. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14197] Warning raised by TestBuilder
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14197 Marcel de Rooy changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14197] Warning raised by TestBuilder
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14197 Marcel de Rooy changed: What|Removed |Added Attachment #40859|0 |1 is obsolete|| --- Comment #11 from Marcel de Rooy --- Created attachment 42058 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42058&action=edit Bug 14197: TestBuilder - Remove the error on starting the transaction DBD::mysql::db begin_work failed: Already in a transaction at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1560. DBIx::Class::Storage::DBI::txn_rollback(): Storage transaction_depth 0 does not match false AutoCommit of DBI::db=HASH(0xa429648), attempting ROLLBACK anyway at t/lib/TestBuilder.pm line 363 Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14197] Warning raised by TestBuilder
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14197 --- Comment #9 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #8) > Only this question: Why does the test abort with the DESTROY and does it > only warn when I undef $builder ? Because the second DESTROY crashes the test :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14197] Warning raised by TestBuilder
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14197 --- Comment #8 from Marcel de Rooy --- Only this question: Why does the test abort with the DESTROY and does it only warn when I undef $builder ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14197] Warning raised by TestBuilder
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14197 Marcel de Rooy changed: What|Removed |Added Attachment #42055|0 |1 is obsolete|| --- Comment #7 from Marcel de Rooy --- Created attachment 42056 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42056&action=edit Used to test the change This seems to work like it should not.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14197] Warning raised by TestBuilder
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14197 --- Comment #6 from Marcel de Rooy --- Oops, I lost some changes in that test file. But what exactly should trigger the error on txn_begin or end in testbuilder? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
