[Koha-bugs] [Bug 14673] Renewals cause Sipserver to crash
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14673 Magnus Enger changed: What|Removed |Added CC||mag...@libriotech.no --- Comment #5 from Magnus Enger --- Colin: What do you think of the proposal from Jonathan? Jonathan: Could you provide a counter patch? Avoiding copypasta sounds like a good idea. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11039] SIP Server responds with valid CHECKIN to SC but fails to checkin item on Koha
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11039 Katrin Fischer changed: What|Removed |Added Version|3.12|3.18 CC||katrin.fisc...@bsz-bw.de --- Comment #1 from Katrin Fischer --- We are seeing this behaviour as well it seems in a 3.18.8 installation. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14903] Remove C4::Dates from circ/circulation.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14903 Marc Véron changed: What|Removed |Added Attachment #42895|0 |1 is obsolete|| --- Comment #4 from Marc Véron --- Created attachment 42989 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42989&action=edit Bug 14903 - Remove C4::Dates from circ/circulation.pl Patch to remove deprectated C4::Dates from circ/circulation.pl To test: - Apply patch - Go to the checkout site (Home > Circulation > Checkouts) - Verify that data displays properly (including for users with a card that expires in the near future, see syspref 'NotifyBorrowerDeparture') - Verify that due date works as before (with syspref 'SpecifyDueDate' on and off (Amended following comment #3) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14903] Remove C4::Dates from circ/circulation.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14903 Marc Véron changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14861] Accession date comparison does not work in advanced search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14861 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #19 from Jonathan Druart --- I am not familiar with ccl.properties, but there is a st-numeric 4=109 r=o Does - st-date-normalized 4=5 + st-date-normalized 4=5 r=o could do the trick for all date indexes? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14673] Renewals cause Sipserver to crash
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14673 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de, ||ulrich.klei...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14922] Remove C4::Dates from cataloguing/additem.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14922 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #6 from Jonathan Druart --- Marc, What about using Koha::DateUtils to replace ->today? Something like my $today = dt_from_string; my $month = $today->month; my $day = $today->day; do what you want. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14924] Remove C4::Dates from members/memberentry.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14924 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14924] Remove C4::Dates from members/memberentry.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14924
--- Comment #3 from Jonathan Druart
---
Comment on attachment 42964
--> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42964
[SIGNED-OFF]Bug 14924 - Remove C4::Dates from members/memberentry.pl
Review of attachment 42964:
-->
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=14924&attachment=42964)
-
::: members/memberentry.pl
@@ +170,5 @@
> foreach (qw(dateenrolled dateexpiry dateofbirth)) {
> next unless exists $newdata{$_};
> my $userdate = $newdata{$_} or next;
> +if ( $userdate ) {
> +$newdata{$_} = output_pref({ dt => dt_from_string( $userdate ),
> dateformat => 'iso', dateonly => 1 });
You have to care of bad formatted dates, otherwise the user will get a software
error.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14924] Remove C4::Dates from members/memberentry.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14924 --- Comment #4 from Marc Véron --- Hi Jonathan, I tried to enter an invalid date, but we have the date picker for this date - it seems no longer to be possible to enter invalid dates for the due date. Or do I miss a way to enter an invalid date? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14923] Remove C4::Dates from labels/label-item-search.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14923 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org Status|Signed Off |Failed QA --- Comment #3 from Jonathan Druart --- Marc, sorry but I get a software error if the date is not correctly formatted. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14929] Fix missing display of help page in contract management
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14929 --- Comment #3 from Marc Véron --- Created attachment 42990 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42990&action=edit Bug 14929 - Fix missing display of help page in contract management This patch renames / moves the file koha-tmpl/intranet-tmpl/prog/en/modules/help/acqui/acqcontract.tt to koha-tmpl/intranet-tmpl/prog/en/modules/help/admin/aqcontract.tt To test: - Go to Home > Acquisition > [Vendor] > Contracts (/cgi-bin/koha/admin/aqcontract.pl?booksellerid=) - Verify that Help displays as appropriate. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14929] Fix missing display of help page in contract management
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14929 Marc Véron changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |ve...@veron.ch |ity.org | Patch complexity|--- |Trivial patch Blocks|14870 | Status|NEW |Needs Signoff Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 [Bug 14870] Delete C4/Dates.pm from System -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14870] Delete C4/Dates.pm from System
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870 Marc Véron changed: What|Removed |Added Depends on|14929 | Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14929 [Bug 14929] Fix missing display of help page in contract management -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14149] Labels: Make barcode width and height scaling editable
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14149 Theodoros Theodoropoulos changed: What|Removed |Added CC||th...@lib.auth.gr -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14928] Remove C4::Dates from files acqui/pdfformat/layout*.pm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14928 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org Attachment #42975|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14928] Remove C4::Dates from files acqui/pdfformat/layout*.pm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14928 --- Comment #3 from Jonathan Druart --- Wrong bug report, sorry about that. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14928] Remove C4::Dates from files acqui/pdfformat/layout*.pm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14928 Jonathan Druart changed: What|Removed |Added Attachment #42975|0 |1 is obsolete|| --- Comment #2 from Jonathan Druart --- Created attachment 42991 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42991&action=edit [COUNTER-PATCH] Bug 14928: Remove C4::Dates from circ/pendingreserves.pl This patch uses Koha::DateUtils instead of C4::Dates and Date::Calc. It also sent DateTime objects to the template, which use the TT plugin to display them. If an invalid dates is entered, the default date is picked. Test plan: 1/ Go to Home > Circulation > Holds to pull 2/ Verify that the the filter and the list behave as before 3/ Enter invalid dates and confirm that you do not get a software error -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14928] Remove C4::Dates from files acqui/pdfformat/layout*.pm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14928 Jonathan Druart changed: What|Removed |Added Attachment #42991|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14918] Remove C4::Dates from circ/pendingreserves.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14918 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14918] Remove C4::Dates from circ/pendingreserves.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14918 Jonathan Druart changed: What|Removed |Added Attachment #42959|0 |1 is obsolete|| --- Comment #3 from Jonathan Druart --- Created attachment 42992 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42992&action=edit Bug 14918: Remove C4::Dates from circ/pendingreserves.pl This patch uses Koha::DateUtils instead of C4::Dates and Date::Calc. It also sent DateTime objects to the template, which use the TT plugin to display them. If an invalid dates is entered, the default date is picked. Test plan: 1/ Go to Home > Circulation > Holds to pull 2/ Verify that the the filter and the list behave as before 3/ Enter invalid dates and confirm that you do not get a software error -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14918] Remove C4::Dates from circ/pendingreserves.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14918 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #4 from Jonathan Druart --- I suggest this counter-patch, the badly formatted dates are caught and don't make Koha explodes with a software error. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14402] Add --fees option to cleanup_database.pl to purge all 0 balance fees and payments older than the given number of days
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14402 --- Comment #31 from Jonathan Druart --- Created attachment 42994 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42994&action=edit Bug 14402: Add unit tests for purge_zero_balance_fees() The function C4::Accounts::purge_zero_balance_fees() should delete rows in accountlines where amountoutstanding is 0 and accountlines.date is less than the current date minus '$days', i.e a number of days passed to the function. Tests were added to prove the following: * accountlines.amountoutstanding is 0, and date is set to CURRENT_DATE. The accountlines row should not be deleted. This is merely a sanity check, because difference between today's date and the fee date cannot be greater than $days. * 'Before', 'On' and 'After' tests for accountlines.amountoutstanding = 0 * accountlines.amountoutstanding is 0, and date is set to $days - 1 days ago. The accountlines row should not be deleted. * accountlines.amountoutstanding is 0, and date is set to $days days ago. the accountlines row should not be deleted, because the difference must be *greater* than $days. * accountlines.amountoutstanding is 0, and date is set to $days + 1 days ago. The accountlines row *will* be deleted in this case. * 'Before', 'On' and 'After' tests for accountlines.amountoutstanding > 0. (3 tests). The accountlines row will never be deleted, because amountoutstanding is not 0. * 'Before', 'On' and 'After' tests for accountlines.amountoutstanding < 0. (3 testes) This tests credits. Again, the accountlines row will never be deleted, because amountoutstanding is not 0. http://bugs.koha-community.org/show_bug.cgi?id=14402 Signed-off-by: Nancy Keener Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14402] Add --fees option to cleanup_database.pl to purge all 0 balance fees and payments older than the given number of days
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14402 --- Comment #34 from Jonathan Druart --- Created attachment 42997 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42997&action=edit Bug 14402: - QA Followup Added notes to usage in misc/cronjobs/cleanup_database.pl that --fees DAYS requires DAYS to be greater than or equal to 1. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14402] Add --fees option to cleanup_database.pl to purge all 0 balance fees and payments older than the given number of days
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14402 --- Comment #32 from Jonathan Druart --- Created attachment 42995 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42995&action=edit Bug 14402: Add option --fees to /misc/cronjobs/cleanup_database.pl This will call C4::Accounts::purge_zero_balance_fees to remove all rows from accountlines which have 0 balance, and are more than DAYS old. Test plan: Run: t/db_dependent/Accounts.t If all unit tests pass, the --fees option to /misc/cronjobs/cleanup_database.pl should act as documented, because it is a straight pass-through to C4::Accounts::purge_zero_balance_fees(). http://bugs.koha-community.org/show_bug.cgi?id=14402 Signed-off-by: Nancy Keener Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14402] Add --fees option to cleanup_database.pl to purge all 0 balance fees and payments older than the given number of days
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14402 --- Comment #33 from Jonathan Druart --- Created attachment 42996 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42996&action=edit Bug 14402: Make purge_zero_balance_fees() delete fees with NULL balance. Also, add notes to perldocs and usage that payments and credits are not linked to fines and may be deleted independently of the associated fine. Signed-off-by: Nancy Keener Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14402] Add --fees option to cleanup_database.pl to purge all 0 balance fees and payments older than the given number of days
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14402 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14402] Add --fees option to cleanup_database.pl to purge all 0 balance fees and payments older than the given number of days
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14402 Jonathan Druart changed: What|Removed |Added Attachment #42816|0 |1 is obsolete|| Attachment #42817|0 |1 is obsolete|| Attachment #42818|0 |1 is obsolete|| Attachment #42819|0 |1 is obsolete|| Attachment #42820|0 |1 is obsolete|| --- Comment #30 from Jonathan Druart --- Created attachment 42993 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42993&action=edit Bug 14402: Add function purge_zero_balance_fees to C4/Accounts.pm http://bugs.koha-community.org/show_bug.cgi?id=14402 Signed-off-by: Nancy Keener Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14045] Add specific quotas to on-site checkout
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14045 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #28 from Jonathan Druart --- Everything is signed off here. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14929] Fix missing display of help page in contract management
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14929 Magnus Enger changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14929] Fix missing display of help page in contract management
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14929 Magnus Enger changed: What|Removed |Added Attachment #42990|0 |1 is obsolete|| --- Comment #4 from Magnus Enger --- Created attachment 42998 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42998&action=edit Bug 14929 - Fix missing display of help page in contract management This patch renames / moves the file koha-tmpl/intranet-tmpl/prog/en/modules/help/acqui/acqcontract.tt to koha-tmpl/intranet-tmpl/prog/en/modules/help/admin/aqcontract.tt To test: - Go to Home > Acquisition > [Vendor] > Contracts (/cgi-bin/koha/admin/aqcontract.pl?booksellerid=) - Verify that Help displays as appropriate. Signed-off-by: Magnus Enger Works as advertised. All the tabs similar to "Contracts" have working help pages. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13816] Set Overdue letter fine to the overduerules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13816 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=12770, ||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=14666 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14666] adds fixed_fines for overdues
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14666 Jonathan Druart changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=13816 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12770] Notice template tool enhancement
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12770 Jonathan Druart changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=13816 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14910] Renew a patron does not redirect to the correct module
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14910 Jonathan Druart changed: What|Removed |Added Attachment #42937|0 |1 is obsolete|| --- Comment #5 from Jonathan Druart --- Created attachment 42999 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42999&action=edit Bug 14910: Redirect to the circulation module after a renew iIf a patron is renewed from the circulation module, the librarian should be redirected to the circulation module. This works correctly if the renew is done from the patron module (members). This is caused by a typo in the template: desintation vs destination. This patch also removes the cardnumber parameter to the setstatus.pl script, it is not needed given that borrowernumber is always passed. This has a good side-effect, it will fix bug 14691. The cardnumber does not exist anymore, so no need to escape it :) Test plan: 0/ Do not apply this patch 1/ Create a patron with a cardnumber with a quote (rm'me) and another one without a quote (rmme) 2/ Go on the checkouts page (circ/circulation.pl) 3/ Renew the 2 patrons => With rm'me you are redirected to the circ module - ok => With rmme you are redirected to the member module - nok 4/ Go on the patron detail page (members/moremember.pl) 5/ Renew the 2 patrons => you are redirected to the member module - ok 6/ Delete the patrons => Nothing happend with rm'me, there is a JS error on the page - nok => rmme is deleted - ok 7/ Apply the patch and recreate rmme 8/ Repeat 2, 3, 4, 5 => You are redirected to the correct module 9/ Delete the patrons => They are successfully deleted -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14910] Renew a patron does not redirect to the correct module
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14910 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14910] Renew a patron does not redirect to the correct module
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14910 --- Comment #6 from Jonathan Druart --- (In reply to Katrin Fischer from comment #4) > I think there is a bug hiding in this patch - I try renewing a patron from > the sample database: > > localhost:8080/cgi-bin/koha/members/moremember.pl?borrowernumber=41 > Gloria Odom (2352954503) > > it works ok without this patch, but with the patch I get redirected to: > http://localhost:8080/cgi-bin/koha/members/moremember.pl?41&was_renewed=1 > With the message: This patron does not exist. > Looks like we are missing the borrowernumber part in the URL? Erk, last minute change! Thanks for catching that! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14924] Remove C4::Dates from members/memberentry.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14924 --- Comment #5 from Jonathan Druart --- (In reply to Marc Véron from comment #4) > Hi Jonathan, > > I tried to enter an invalid date, but we have the date picker for this date > - it seems no longer to be possible to enter invalid dates for the due date. > > Or do I miss a way to enter an invalid date? I have tried with the date of birth on creating/updating a patron. You get a JS alert box but are able to submit the form. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14832] Encoding issues when exporting in RIS
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14832 Magnus Enger changed: What|Removed |Added Attachment #42573|0 |1 is obsolete|| --- Comment #4 from Magnus Enger --- Created attachment 43000 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43000&action=edit Bug 14832: Fix encoding issues when exporting in RIS Test plan: 1/ Make sure you have non ASCII chars in the title and the authors. 2/ Export the record in RIS You should not see any encoding problems. Signed-off-by: Magnus Enger Before patch: RIS file has wrongly encoded chars After patch: RIS file has no endcoding problems Tested on a NORMARC setup. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13382] RDA: 700/710/711 display in XSLT
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13382 Jonathan Druart changed: What|Removed |Added Blocks|14359 | --- Comment #50 from Jonathan Druart --- *** Bug 14359 has been marked as a duplicate of this bug. *** Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14359 [Bug 14359] RDA: 700/710/711 display in XSLT Bug fix for Contributors -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14832] Encoding issues when exporting in RIS
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14832 Magnus Enger changed: What|Removed |Added Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14917] RDA: 700/710/711 fix path for icon in XSLT
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14917 Jonathan Druart changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=14359 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14359] RDA: 700/710/711 display in XSLT Bug fix for Contributors
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14359 Jonathan Druart changed: What|Removed |Added Resolution|--- |DUPLICATE See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=14917 Status|Failed QA |RESOLVED Depends on|13382 | --- Comment #7 from Jonathan Druart --- *** This bug has been marked as a duplicate of bug 13382 *** Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13382 [Bug 13382] RDA: 700/710/711 display in XSLT -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14149] Labels: Make barcode width and height scaling editable
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14149
--- Comment #3 from Theodoros Theodoropoulos ---
This proposed addition to have the user define the size of the barcode is very
useful indeed!
But until then, with the current situation, we realized that the hardcoded
relative values in Label.pm were very conservative for 'normal'-sized labels
For our needs, we found out that a default value of 20% of the label height and
90% of the label width (compared to the original values of 10% and 80%
respectably) produce taller barcodes that are easier to read.
In case it helps anyone, the relevant patch to achieve this is:
--- ./src/C4/Labels/Label.pm 2015-10-01 10:35:54.414837999 +0300
+++ ./src/C4/Labels/Label.pm.orig 2015-10-01 10:34:38.470837999 +0300
@@ -282,8 +282,8 @@
my $self = shift;
my $barcode_llx = $self->{'llx'} + $self->{'left_text_margin'}; # this
places the bottom left of the barcode the left text margin distance to right of
the left edge of the label ($llx)
my $barcode_lly = $self->{'lly'} + $self->{'top_text_margin'}; # this
places the bottom left of the barcode the top text margin distance above the
bottom of the label ($lly)
-my $barcode_width = 0.8 * $self->{'width'}; # this
scales the barcode width to 80% of the label width
-my $barcode_y_scale_factor = 0.01 * $self->{'height'}; # this
scales the barcode height to 10% of the label height
+my $barcode_width = 0.9 * $self->{'width'}; # this
scales the barcode width to 90% of the label width
+my $barcode_y_scale_factor = 0.02 * $self->{'height'}; # this
scales the barcode height to 20% of the label height
return 0, 0, 0, $barcode_llx, $barcode_lly, $barcode_width,
$barcode_y_scale_factor;
}
(Needless to say again that the best approach would be to make it selectable by
the user in the template screen!)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14812] Help could not be displayed in the correct language
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14812 Magnus Enger changed: What|Removed |Added Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14812] Help could not be displayed in the correct language
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14812 Magnus Enger changed: What|Removed |Added Attachment #42509|0 |1 is obsolete|| --- Comment #2 from Magnus Enger --- Created attachment 43001 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43001&action=edit Bug 14812: Display the help in the correct language If opaclanguages != language, the language of the help page is the default one (en). Test plan: 1/ Set language to en, fr-FR, ar-Arab and opaclanguages to en, fr-FR 2/ Translate the fr-FR and ar-Arab templates. 3/ Go on the mainpage, switch to ar-Arab, go to the help page. The help page content should be in Arabian, not English. Signed-off-by: Magnus Enger Set language = en, sv-SE, nb-NO. opaclanguage = en, nb-NO Went to the intranet main page, selected Swedish and clicked on help Without the patch, help was displayed in English With the patch, help was displayed in Swedish. Yay! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739 --- Comment #22 from Jonathan Druart --- (In reply to Josef Moravec from comment #21) > I have VM with Debian Jessie, but with MariaDB instead of MySQL... I'll try > it on another machine with MySQL tomorow... Using MariaDB I don't get the issue you have described. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14910] Renew a patron does not redirect to the correct module
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14910 Magnus Enger changed: What|Removed |Added Status|Needs Signoff |Failed QA CC||mag...@libriotech.no --- Comment #7 from Magnus Enger --- (In reply to Jonathan Druart from comment #5) > Test plan: > 0/ Do not apply this patch > 1/ Create a patron with a cardnumber with a quote (rm'me) and another > one without a quote (rmme) > 2/ Go on the checkouts page (circ/circulation.pl) > 3/ Renew the 2 patrons > => With rm'me you are redirected to the circ module - ok > => With rmme you are redirected to the member module - nok I can reproduce this without the patch. But after I apply the patch, I get this: rm'me: No JS popup confirmation, but redirected to the circ module rmme: JS popup confirmation, but redirected to the member module For rmme I get this error in the Firebug Console: SyntaxError: expected expression, got ',' firstDay: , For rm'me I get two errors: SyntaxError: expected expression, got ',' firstDay: , SyntaxError: missing ; before statement ...owernumber=6450&cardnumber=rm'me&desintation=circ&reregistration=y' -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739 --- Comment #23 from Josef Moravec --- Hm, on another machine everything works perfect... So probably some problem with my specific data, or something on that one VM. So please, ignore me ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14101] auto renewal is tied to 'no renewal before'
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14101
--- Comment #24 from Jonathan Druart
---
Comment on attachment 39800
--> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39800
Bug 14101: Automatic renewals exactly on due date
Review of attachment 39800:
-->
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=14101&attachment=39800)
-
::: C4/Circulation.pm
@@ +2737,4 @@
> return ( 0, "too_many" )
>if $issuingrule->{renewalsallowed} <= $itemissue->{renewals};
>
> +if ( defined $issuingrule->{norenewalbefore} ) {
What about the empty string? I am not sure it's relevant, but I would like to
be sure.
@@ +2751,5 @@
> return ( 0, "too_soon" );
> }
> +else {
> +return ( 0, "auto_renew" ) if $itemissue->{auto_renew};
> +return ( 1, undef );
This last return is not needed, the process should continue I think.
Imagine someone else adds a new check in the futur.
@@ +2759,5 @@
> +# Fallback for automatic renewals:
> +# If norenewalbefore is undef, don't renew before due date.
> +elsif ( $itemissue->{auto_renew} ) {
> +return ( 0, "auto_renew" )
> + if DateTime->now( time_zone => C4::Context->tz() ) >=
Prefer dt_from_string to get a DateTime object.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14395] Two different ways to calculate 'No renewal before' (days or hours)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395
--- Comment #29 from Jonathan Druart
---
Comment on attachment 41054
--> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41054
Bug 14395: Code changes
Review of attachment 41054:
-->
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=14395&attachment=41054)
-
Please provide a better commit description.
::: C4/Circulation.pm
@@ +2772,5 @@
> +{
> +$soonestrenewal->truncate( to => 'day' );
> +}
> +
> +if ( $soonestrenewal > DateTime->now( time_zone => C4::Context->tz()
> ) )
Prefer dt_from_string to get a DateTime object (yes this already existed before
your patch, but it's worth to make things consistent).
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5371] Back-button in OPAC shows previous user's details, after LOGOUT
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5371 --- Comment #21 from Jonathan Druart --- Created attachment 43002 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43002&action=edit Bug 5371: (follow-up) Force no caching for private pages at the OPAC Same as previous patch for opac-messaging.pl and opac-readingrecord.pl -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5371] Back-button in OPAC shows previous user's details, after LOGOUT
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5371 --- Comment #22 from Jonathan Druart --- Marc, Thanks for testing. I have added the trick on the messaging and circulation history page. I have not changed the lists/shelves page, the module and script are going to be rewritten on another bug (bug 14544) and I don't want to introduce conflicts. I am not sure we should add the no-store value for the cache policy on other pages. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14673] Renewals cause Sipserver to crash
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14673 --- Comment #6 from Jonathan Druart --- (In reply to Magnus Enger from comment #5) > Colin: What do you think of the proposal from Jonathan? > Jonathan: Could you provide a counter patch? Avoiding copypasta sounds like > a good idea. No, I would like to keep my QA token. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14842] Wrong call to GetBranchItemRule in circ/returns.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14842 --- Comment #4 from Jonathan Druart --- If I remember correctly you must use an itemtype with a return policy. Whatever the value of the policy, the return branch will always be the homebranch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14910] Renew a patron does not redirect to the correct module
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14910 --- Comment #8 from Jonathan Druart --- Magnus, could you confirm you have correctly cleared your browser cache? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739 --- Comment #24 from Jonathan Druart --- Josef, if you are still able to reproduce the issue, with the last patches against master, I think we should try to understand what is the problem :) Could you confirm you got the issue even with a non-empty creator_batches table? I have not tried with en empty table. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14918] Remove C4::Dates from circ/pendingreserves.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14918 --- Comment #5 from Marc Véron --- Created attachment 43003 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43003&action=edit [Signed-off] Bug 14918: Remove C4::Dates from circ/pendingreserves.pl This patch uses Koha::DateUtils instead of C4::Dates and Date::Calc. It also sent DateTime objects to the template, which use the TT plugin to display them. If an invalid dates is entered, the default date is picked. Test plan: 1/ Go to Home > Circulation > Holds to pull 2/ Verify that the the filter and the list behave as before 3/ Enter invalid dates and confirm that you do not get a software error Counter patch works as expected and is a much cleaner solution. Signed-off-by: Marc Véron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14918] Remove C4::Dates from circ/pendingreserves.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14918 Marc Véron changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14915] Use Font Awesome instead of Glyphicons for the staff intranet
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14915 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #4 from Jonathan Druart --- I think this needs small tweaks. For instance, compare the "+" icon on /cgi-bin/koha/serials/serials-home.pl Before this patch, it was correctly aligned, now it's not. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5371] Back-button in OPAC shows previous user's details, after LOGOUT
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5371 --- Comment #23 from Marc Véron --- Created attachment 43004 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43004&action=edit [Signed-off] Bug 5371: Force no caching for private pages at the OPAC In order no to slow too much the browsing, it is certainly not a good idea to add this cache-control value for all pages at the OPAC. This patch just adds where the author found it could be useful. Test plan: 1/ Login at the OPAC 2/ Go on the account page (opac/opac-account.pl) 3/ Click log out 4/ Use the back button of your browser Without this patch you will see the previous page. With this patch, the previous page will be reloaded and you will be redirected to the login form. Signed-off-by: Marc Véron -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14910] Renew a patron does not redirect to the correct module
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14910 --- Comment #9 from Magnus Enger --- (In reply to Jonathan Druart from comment #8) > Magnus, could you confirm you have correctly cleared your browser cache? Ah, not necessarily. I'll have another go. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5371] Back-button in OPAC shows previous user's details, after LOGOUT
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5371 Marc Véron changed: What|Removed |Added Attachment #42911|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5371] Back-button in OPAC shows previous user's details, after LOGOUT
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5371 --- Comment #24 from Marc Véron --- Created attachment 43005 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43005&action=edit [Signed-off] Bug 5371: (follow-up) Force no caching for private pages at the OPAC Same as previous patch for opac-messaging.pl and opac-readingrecord.pl Signed-off-by: Marc Véron -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5371] Back-button in OPAC shows previous user's details, after LOGOUT
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5371 Marc Véron changed: What|Removed |Added Attachment #43002|0 |1 is obsolete|| -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5371] Back-button in OPAC shows previous user's details, after LOGOUT
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5371 Marc Véron changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739 --- Comment #25 from Josef Moravec --- I tried it on non-empty table, but have the same issue... I am not able to figure out where is the problem -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14918] Remove C4::Dates from circ/pendingreserves.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14918 Marc Véron changed: What|Removed |Added Attachment #42992|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8483] Borrower reading history should include deleted items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #26 from Jonathan Druart --- I was afraid of the complexity in the call stack, so did some tests: $ more bug_8483.pl use Modern::Perl; use C4::Members; my $borrowernumber=42; my $issues = GetAllIssues( $borrowernumber, 'date_due desc' ); > select count(*) from old_issues where borrowernumber=42; 43 > select count(*) from issues where borrowernumber=42; 7 $ git checkout master; git reset --hard origin/master $ git checkout -b bug_8483; git bz apply 8483 $ git checkout master; time perl bug_8483.pl perl bug_8483.pl 1.23s user 0.04s system 99% cpu 1.270 total $ git checkout bug_8483; time perl bug_8483.pl perl bug_8483.pl 1.50s user 0.05s system 99% cpu 1.560 total # => Ok we get the old_issues in addition of # Adding some issues to the patron > select count(*) from issues where borrowernumber=42; 49 # master perl bug_8483.pl 1.21s user 0.08s system 99% cpu 1.280 total # bug_8483 perl bug_8483.pl 1.82s user 0.07s system 97% cpu 1.933 total 210 # master perl bug_8483.pl 1.21s user 0.07s system 98% cpu 1.293 total # bug_8483 perl bug_8483.pl 2.73s user 0.09s system 95% cpu 2.959 total 600 # master perl bug_8483.pl 1.28s user 0.03s system 97% cpu 1.340 total # bug_8483 perl bug_8483.pl 4.78s user 0.10s system 94% cpu 5.154 total -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14927] OAI-PMH listRecords result should include item data when using a resumption token
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14927 Christophe Brocquet changed: What|Removed |Added CC||christophe.brocquet@obspm.f ||r -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14910] Renew a patron does not redirect to the correct module
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14910 Magnus Enger changed: What|Removed |Added Attachment #42999|0 |1 is obsolete|| --- Comment #10 from Magnus Enger --- Created attachment 43006 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43006&action=edit Bug 14910: Redirect to the circulation module after a renew iIf a patron is renewed from the circulation module, the librarian should be redirected to the circulation module. This works correctly if the renew is done from the patron module (members). This is caused by a typo in the template: desintation vs destination. This patch also removes the cardnumber parameter to the setstatus.pl script, it is not needed given that borrowernumber is always passed. This has a good side-effect, it will fix bug 14691. The cardnumber does not exist anymore, so no need to escape it :) Test plan: 0/ Do not apply this patch 1/ Create a patron with a cardnumber with a quote (rm'me) and another one without a quote (rmme) 2/ Go on the checkouts page (circ/circulation.pl) 3/ Renew the 2 patrons => With rm'me you are redirected to the circ module - ok => With rmme you are redirected to the member module - nok 4/ Go on the patron detail page (members/moremember.pl) 5/ Renew the 2 patrons => you are redirected to the member module - ok 6/ Delete the patrons => Nothing happend with rm'me, there is a JS error on the page - nok => rmme is deleted - ok 7/ Apply the patch and recreate rmme 8/ Repeat 2, 3, 4, 5 => You are redirected to the correct module 9/ Delete the patrons => They are successfully deleted Signed-off-by: Magnus Enger Followed the test plan, works as advertised. (I did have some problems initially, but that was caused by me not using the interface in English...) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8483] Borrower reading history should include deleted items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483 Jonathan Druart changed: What|Removed |Added Version|3.8 |master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14910] Renew a patron does not redirect to the correct module
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14910 Magnus Enger changed: What|Removed |Added Patch complexity|--- |Small patch Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14912] Sort Advanced Search Languages by priority
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14912 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Failed QA CC||jonathan.dru...@bugs.koha-c ||ommunity.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12756] Koha to MARC mapping 264$a, $b, and, $c
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12756 Zeno Tajoli changed: What|Removed |Added Patch complexity|--- |Medium patch Keywords|rel_3_16_candidate | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14895] We shouldn't be able to edit already added serials' items from serial receive/edit page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14895 Olli-Antti Kivilahti changed: What|Removed |Added CC||olli-antti.kivila...@jns.fi Assignee|koha-b...@lists.koha-commun |j.kylm...@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14932] New: serials/serials-collection.pl-page is very slow. GetFullSubscription* checks permission for each serial!
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14932 Bug ID: 14932 Summary: serials/serials-collection.pl-page is very slow. GetFullSubscription* checks permission for each serial! Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials Assignee: koha-bugs@lists.koha-community.org Reporter: olli-antti.kivila...@jns.fi QA Contact: testo...@bugs.koha-community.org CC: colin.campb...@ptfs-europe.com Currently we have subscriptions with 300+ serials received. It takes a lot of time to show serials-collection.pl (~20s). This is especially troublesome when receiving serials, since after receival we get redirected to that page. We no longer can receive daily serials in the allotted timeframe. This quick and dirty fix prevents checking the subscription editing for each serial, but instead checks it for the first serial only. This reduced page load time by ~18s TEST PLAN: 1. Receive ~300 serials (or just a bunch :) ) 2. Observe the gradual slowing of the receival action. AFTER THIS PATCH: 1. Receive ~300 serials more (or just a bunch) 2. Observe a significant performance improvement. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14932] serials/serials-collection.pl-page is very slow. GetFullSubscription* checks permission for each serial!
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14932 --- Comment #1 from Olli-Antti Kivilahti --- Created attachment 43007 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43007&action=edit Bug 14932 - serials/serials-collection.pl-page is very slow. GetFullSubscription* checks permission for each serial! Currently we have subscriptions with 300+ serials received. It takes a lot of time to show serials-collection.pl (~20s). This is especially troublesome when receiving serials, since after receival we get redirected to that page. We no longer can receive daily serials in the allotted timeframe. This quick and dirty fix prevents checking the subscription editing for each serial, but instead checks it for the first serial only. This reduced page load time by ~18s TEST PLAN: 1. Receive ~300 serials (or just a bunch :) ) 2. Observe the gradual slowing of the receival action. AFTER THIS PATCH: 1. Receive ~300 serials more (or just a bunch) 2. Observe a significant performance improvement. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14932] serials/serials-collection.pl-page is very slow. GetFullSubscription* checks permission for each serial!
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14932 Olli-Antti Kivilahti changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14673] Renewals cause Sipserver to crash
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14673 --- Comment #7 from Colin Campbell --- (In reply to Magnus Enger from comment #5) > Colin: What do you think of the proposal from Jonathan? > Jonathan: Could you provide a counter patch? Avoiding copypasta sounds like > a good idea. (In reply to Jonathan Druart from comment #6) > (In reply to Magnus Enger from comment #5) > > Colin: What do you think of the proposal from Jonathan? > > Jonathan: Could you provide a counter patch? Avoiding copypasta sounds like > > a good idea. > > No, I would like to keep my QA token. Its not really a transaction method but a utility but will attempt to test that solution -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14933] New: SIPserver should not use warn or die to log errors
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14933 Bug ID: 14933 Summary: SIPserver should not use warn or die to log errors Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: SIP2 Assignee: koha-bugs@lists.koha-community.org Reporter: colin.campb...@ptfs-europe.com QA Contact: testo...@bugs.koha-community.org CC: colin.campb...@ptfs-europe.com warn and die are used in various places in the SIPServer but the messages are lost as STDERR is closed by Net::Server in these cases the error message should be logged to syslog as with other error and debug messages and exit should be used -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14515] Add biblioitems table to notices in C4/Reserves.pm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14515 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org Status|Signed Off |Failed QA --- Comment #4 from Jonathan Druart --- Barton, to be consistent we should display the biblioitems fields when creating/editing a letter from the "reserves" module. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13517] Show waiting date on reserve/request.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13517 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Patch doesn't apply --- Comment #29 from Jonathan Druart --- To test bug 13918 I need to apply this patch set before but it does not apply anymore. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12756] Koha to MARC mapping 264$a, $b, and, $c
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12756 --- Comment #3 from Katrin Fischer --- Hm, there is also the other way around - if we make Koha-to-MARC-Mappings 1:n, we also need to change the procedures that are used for creating a record from a non-marc format, for example in acquisitions. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14504] Add command-line script to batch delete items based on lost/withdrawn statuses
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14504 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Failed QA CC||jonathan.dru...@bugs.koha-c ||ommunity.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14504] Add command-line script to batch delete items based on lost/withdrawn statuses
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14504
--- Comment #5 from Jonathan Druart
---
Comment on attachment 42978
--> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42978
[SIGNED-OFF] Bug 14504: Add delete_items.pl: a command line batch deletion tool
Review of attachment 42978:
-->
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=14504&attachment=42978)
-
FAIL misc/cronjobs/delete_items.pl
FAIL pod
*** WARNING: Verbatim paragraph in NAME section in file
misc/cronjobs/delete_items.pl
::: misc/cronjobs/delete_items.pl
@@ +1,4 @@
> +#! /usr/bin/perl
> +
> +use warnings;
> +use strict;
warnings and strict are useless when Modern::Perl is already used.
@@ +8,5 @@
> +use C4::Circulation;
> +use Modern::Perl;
> +use Pod::Usage;
> +
> +my $VERSION='1.0';
How this is useful? We usually don't use it in scripts.
@@ +30,5 @@
> + , help => ''
> + , manual=> ''
> + , version => ''
> + }
> +};
I am not really in favor of these 2 variables.
IMO it is preferable to stick to the structure of the already existing scripts
in misc/*
@@ +39,5 @@
> +, 'V|version' => sub { $OPTIONS->{flags}->{version} = 1 }
> +, 'h|help' => sub { $OPTIONS->{flags}->{help} = 1 }
> +, 'm|manual' => sub { $OPTIONS->{flags}->{manual}= 1 }
> +, 'c|commit' => sub { $OPTIONS->{flags}->{commit}= 1 } # aka
> DO-EET!
> +, 'dry-run'=> sub { $OPTIONS->{flags}->{commit}= 0;
I don't think dry-run is useful, it's in dry-run mode if commit is not given.
@@ +51,5 @@
> +exit;
> +}
> +
> +pod2usage( -verbose => 2 ) if $OPTIONS->{flags}->{manual};
> +pod2usage(1) if ( $OPTIONS->{flags}->{help} || scalar @criteria == 0 );
The script should not return 1 if help is specified.
It would be good to display on error for the @criteria==0 case (see msg option
of pod2usage).
@@ +65,5 @@
> +my $where_clause = ' where ' . join ( " and ", @criteria );
> +
> +verbose "Where statement: $where_clause";
> +
> +$GLOBAL->{sth}->{target_tiems} = $dbh->prepare( $query->{target_items} .
> $where_clause );
typo tiems vs items, I suppose.
@@ +71,5 @@
> +
> +DELITEM: while ( my $item =
> $GLOBAL->{sth}->{target_tiems}->fetchrow_hashref() ) {
> +my $issue = GetOpenIssue( $item->{itemnumber} );
> +if( defined $issue ) {
> +verbose "Cannot delete '$item->{itemnumber}' -- item is checked out."
Shouldn't we also search for holds?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11139] opac-topissues does not work with CCODE
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11139 Julian Maurice changed: What|Removed |Added CC||julian.maur...@biblibre.com --- Comment #11 from Julian Maurice --- Bug 14788 fixes the ccode problem, but not the "multiple values" problem. So here is a patch that try to fix it (depends on 14788): -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11139] opac-topissues does not work with CCODE
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11139 --- Comment #12 from Julian Maurice --- Created attachment 43008 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43008&action=edit Bug 11139: Add support for multiple values in AdvancedSearchTypes AdvancedSearchTypes syspref can be multivalued, opac-topissues.pl have to support that. AdvancedSearchTypes can have one or more of the following values: 'itemtypes', 'ccode', 'loc'. But this patch adds support only for itemtypes and ccode. AdvancedSearchTypes can still contain 'loc' but it will change nothing to the behaviour of opac-topissues.pl. This patch also removes duplicate code in template (the "Refine your search" form was written in two different places) This introduces a small behaviour change: when there is no results, instead of having the form in the center of the page, it remains in the left sidebar and we have a "No results" message in the main area. Depends on bug 14788 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14788] Move opac-topissues.pl code into C4::Circulation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14788 Julian Maurice changed: What|Removed |Added Blocks||11139 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11139 [Bug 11139] opac-topissues does not work with CCODE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11139] opac-topissues does not work with CCODE
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11139 Julian Maurice changed: What|Removed |Added Depends on||14788 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14788 [Bug 14788] Move opac-topissues.pl code into C4::Circulation -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11139] opac-topissues does not work with CCODE
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11139 Julian Maurice changed: What|Removed |Added Attachment #25956|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11139] opac-topissues does not work with CCODE
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11139 Julian Maurice changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14924] Remove C4::Dates from members/memberentry.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14924 --- Comment #6 from Marc Véron --- Ok, I can make it explode if I enter -00-00 for date of birth: --- Can't locate object method "ymd" via package "dateformat" (perhaps you forgot to load "dateformat"?) at /usr/share/kohaclone/Koha/DateUtils.pm line 206. --- I think we need a generic function in Koha::DateUtils to test a date string against the 'dateformat' syspref. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14927] OAI-PMH listRecords result should include item data when using a resumption token
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14927 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14927] OAI-PMH listRecords result should include item data when using a resumption token
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14927 Jonathan Druart changed: What|Removed |Added Attachment #42974|0 |1 is obsolete|| --- Comment #5 from Jonathan Druart --- Created attachment 43009 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43009&action=edit Bug 14927 Returns item info when resumptionToken is used To test: - activate OAI-PMH with the inclusion of items as explained on bug 12252 - set the OAI-PMH:MaxCount to a low number, 50 for instance - go to the OAI-PMH page to get the records : [your koha catalogue]/cgi-bin/koha/oai.pl?verb=ListRecords&metadataPrefix=marcxml - check that item data is included - get the resumptionToken at the end of the xml - got to the next page of records [your koha catalogue]/cgi-bin/koha/oai.pl?verb=ListRecords&resumptionToken=[your resumption token] - check that item data is now missing Apply the patch, and repeat previous steps: item data is back. Signed-off-by: Gaetan Boisson Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14929] Fix missing display of help page in contract management
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14929 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14927] OAI-PMH listRecords result should include item data when using a resumption token
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14927 Jonathan Druart changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |frede...@tamil.fr |ity.org | CC||jonathan.dru...@bugs.koha-c ||ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14929] Fix missing display of help page in contract management
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14929 Jonathan Druart changed: What|Removed |Added Attachment #42998|0 |1 is obsolete|| --- Comment #5 from Jonathan Druart --- Created attachment 43010 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43010&action=edit Bug 14929 - Fix missing display of help page in contract management This patch renames / moves the file koha-tmpl/intranet-tmpl/prog/en/modules/help/acqui/acqcontract.tt to koha-tmpl/intranet-tmpl/prog/en/modules/help/admin/aqcontract.tt To test: - Go to Home > Acquisition > [Vendor] > Contracts (/cgi-bin/koha/admin/aqcontract.pl?booksellerid=) - Verify that Help displays as appropriate. Signed-off-by: Magnus Enger Works as advertised. All the tabs similar to "Contracts" have working help pages. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14900] Add ability to pay all fees at once from circulation screen
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14900 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14900] Add ability to pay all fees at once from circulation screen
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14900 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org Assignee|koha-b...@lists.koha-commun |josef.mora...@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
