[Koha-bugs] [Bug 14871] Cannot search for patrons using second surname/firstname
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14871 Katrin Fischerchanged: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14871] Cannot search for patrons using second surname/firstname
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14871 Katrin Fischerchanged: What|Removed |Added Attachment #42938|0 |1 is obsolete|| --- Comment #4 from Katrin Fischer --- Created attachment 43044 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43044=edit [PASSED QA] Bug 14871: Extend the patrons search to search like %$term% (checkout tab) The patrons search used by the checkout tab and the autocomplete is not the same as the "search patrons" tab. The main difference is the "contain" vs "start with". So that if you have a patron with a patron with a surname "foo bar" and you search for "foo bar", the autocomplete and the result of a search by the checkout tab will search for "foo%" or "bar%" which won't return the patron you are search for. This patch replaces both autocomplete and checkout tab searches with a "contain" search. The search will be "%foo%" or "%bar%". Note that on big DB, this can cause unexpected results. Test plan: Create a patron with a surname "foo bar" Search for "bar" using the checkout tab. You should see the patron in the autocomplete result and the result page after submitting the search form. Followed test plan, works as expected. Signed-off-by: Marc Véron Signed-off-by: Tomas Cohen Arazi Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14871] Cannot search for patrons using second surname/firstname
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14871 Katrin Fischerchanged: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #5 from Katrin Fischer --- This works as described, but I am concerned about the consequences for big library systems with lots of patron data. The search is very wide now, so it might get really hard to spot the one you have been actually looking for between those that just contain your typed in 3-4 letters. Are there better ways we could achieve this? like "p%" or like " p%" or like "-p%" maybe? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14871] Cannot search for patrons using second surname/firstname
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14871 Katrin Fischerchanged: What|Removed |Added Status|Passed QA |In Discussion -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14861] Accession date comparison does not work in advanced search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14861 Katrin Fischerchanged: What|Removed |Added Severity|enhancement |normal CC||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14788] Move opac-topissues.pl code into C4::Circulation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14788 Marc Véronchanged: What|Removed |Added Status|Needs Signoff |Failed QA CC||ve...@veron.ch --- Comment #2 from Marc Véron --- Hi Julian, With the patch, the checkouts on the result table do no longer sort numerically but alpabetically, something like: 1 -14 - 2- 26- 89 instead of 1 -2 -14 -26- 89 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14788] Move opac-topissues.pl code into C4::Circulation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14788 --- Comment #3 from Julian Maurice--- Hi Marc, I have the same behaviour on master, I don't think the patch is responsible for that. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14939] New: OAI Server classes must be modularized
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14939 Bug ID: 14939 Summary: OAI Server classes must be modularized Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Web services Assignee: koha-bugs@lists.koha-community.org Reporter: frede...@tamil.fr QA Contact: testo...@bugs.koha-community.org Koha OAI server has been done in one unique .pl file because there wasn't any object model or rules in the Koha project when it has been coded. Its classes must be modularized : putting each class in a separate file in a Koha::OAI namespace. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739 Josef Moravecchanged: What|Removed |Added Attachment #43040|0 |1 is obsolete|| --- Comment #40 from Josef Moravec --- Created attachment 43060 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43060=edit Bug 14739 - Add several patrons to a new batch will create a new batch per patron added This patch changes the functionality of adding patrons to patroncard batches. Instead of using only the patron search, there is now a textarea which can either be manually populated with borrowernumbers, or can be populated using the patron-search To test: 1 - Create a new patron batch 2 - Click the add items button, if there is no data in the borrowrnumber form you should get a popup 3 - Add items to batch using the popup, borrowernumbers should populate to the form 4 - Click add items again and items should be added to a new batch 5 - Create a new batch 6 - Manually enter invalid borrowernumbers to the form 7 - Click add items, batch should return empty 8 - Manually enter valid borrowernumber 9 - Click add items, batch should be updated 10 - Edit an existing batch and confirm add items works as above 11 - Create a new label batch 12 - Click add items with no data, popup item search should appear 13 - Adding items by checking boxes or using 'Add' button - they should populate the text box on the edit batch page 14 - When adding using form the 'Enter by itemnumber' button should be marked automatically 15 - Submit items and confirm they are added to batch 16 - Create a new batch, enter by barcode manually and check 'Enter by itemnumber" 17 - Click add items, no items should be added 18 - Repopulate form with barcodes, check 'Enter by barcode' 19 - Click add items, items should be added correctly 20 - Test various combinations of radio buttons and numbers and using form or not Signed-off-by: Barton Chittenden -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739 Josef Moravecchanged: What|Removed |Added Attachment #43061|0 |1 is obsolete|| --- Comment #45 from Josef Moravec --- Created attachment 43063 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43063=edit Bug 14739: Fix plack compatibility perlcritic raised "Declare variables outside of the condition" Works as expected Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739 --- Comment #46 from Josef Moravec--- Is that better? I am sorry for this inconvenience... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14923] Remove C4::Dates from labels/label-item-search.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14923 Marc Véronchanged: What|Removed |Added CC||ve...@veron.ch --- Comment #5 from Marc Véron --- Comment on attachment 43030 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43030 Bug 14923 - (follow-up) Test for invalid date input Obsoleted to implement solution without using is_formatted_date_string -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14923] Remove C4::Dates from labels/label-item-search.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14923 --- Comment #6 from Marc Véron--- Created attachment 43064 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43064=edit Bug 14923 - (follow up) Add test for invalid dates using eval To test: - Apply patch - Go to Home > Tools > Labels home > Manage label batches - Click "Add item(s)" - Verify that selection with date after and date before works the same as without patch. - Verify that you can not trigger a software error using invalid dates as -00-00 or 32/01/1970 (copy/paste to date fields). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14936] Add validation for date strings to Koha::DateUtils
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14936 Marc Véronchanged: What|Removed |Added Blocks|14923 | Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14923 [Bug 14923] Remove C4::Dates from labels/label-item-search.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14923] Remove C4::Dates from labels/label-item-search.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14923 Marc Véronchanged: What|Removed |Added Status|BLOCKED |Needs Signoff Depends on|14936 | Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14936 [Bug 14936] Add validation for date strings to Koha::DateUtils -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14610] Add ability to place document delivery / article requests in Koha
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #14 from Katrin Fischer--- Thx Kyle! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14943] Calendar Gadget in Guided Reports wizard
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14943 Fiona Borthwickchanged: What|Removed |Added CC||fiona.borthwick@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14522] Use Koha::Cache for accessing single_holidays()
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14522 Tomás Cohen Arazichanged: What|Removed |Added CC||tomasco...@gmail.com Status|Passed QA |Failed QA --- Comment #27 from Tomás Cohen Arazi --- I like the implementation (overall) but I don't think we should introduce things like Koha::Calendar::add_dummy_holiday. Worse, it relies on the 'MPL' branch existing on the database. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13517] Show waiting date on reserve/request.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13517 --- Comment #31 from Kyle M Hall--- Created attachment 43067 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43067=edit Bug 13517 [QA Followup] - Add unit tests Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13517] Show waiting date on reserve/request.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13517 --- Comment #32 from Kyle M Hall--- Created attachment 43068 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43068=edit Bug 13517 [QA Followup] - Fix unit tests Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13517] Show waiting date on reserve/request.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13517 Kyle M Hallchanged: What|Removed |Added Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739 --- Comment #37 from Jonathan Druart--- There is something wrong in the first patch 59 my @item_numbers; #= $cgi->param('item_number') if $cgi->param('item_number'); Could someone re-upload a valid patch? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11559] Professional cataloger's interface
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 --- Comment #133 from Jonathan Druart--- (In reply to Jonathan Druart from comment #132) > 6/ I still have issue with mandatory/repeatable field. > From the editor: > 615 _ _ $a [Dropdown list] > Missing mandatory subfield: $m; Missing mandatory subfield: $n; Missing > mandatory subfield: $x > > From the (default) framework page: > 615 centre d'intérêt No No > 2 code du système d'indexation subfield ignored > 3 numéro de la notice d'autorité subfield ignored > a catégorie sujet Tab:1, Not repeatable, Not mandatory, | Auth > value:interet > m subdivision de la catégorie sujet sous forme codée subfield ignored > n catégorie sujet sous forme codée subfield ignored > x subdivision de la catégorie sujet subfield ignored Ok forget this one, the subfield are ignored but marked as mandatory. Not what we should do in this case. The checks done on the "normal" edition mode don't look to work correctly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739 --- Comment #43 from Jonathan Druart--- >From the first patch: -my $batch_id = $cgi->param('element_id') || $cgi->param('batch_id') || undef; +my $batch_id = $cgi->param('element_id') || $cgi->param('batch_id') || 0; >From the second patch: -my $batch_id = $cgi->param('element_id') || $cgi->param('batch_id') || 0; +my $batch_id = $cgi->param('element_id') || $cgi->param('batch_id') || undef; Initially my patch (the second one) didn't modify this line. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14923] Remove C4::Dates from labels/label-item-search.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14923 Marc Véronchanged: What|Removed |Added Attachment #43030|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14943] New: Calendar Gadget in Guided Reports wizard
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14943 Bug ID: 14943 Summary: Calendar Gadget in Guided Reports wizard Change sponsored?: --- Product: Koha Version: 3.18 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: gmcha...@gmail.com Reporter: fiona.borthw...@ptfs-europe.com QA Contact: testo...@bugs.koha-community.org When creating a report using the Guided Reports wizard, the calendar gadget does not work correctly for ending dates. To reproduce: Guided Reports Wizard - Build New Select Catalogue group Step 4 - select criteria to limit on There are 3 calendar gadgets - Creation Date, Modification Date, Due Date. Select a start date using the gadget. Click on End date and gadget is all greyed out. You can select a date in the past but you cannot move forward. The remaining months in the year are not visible in the pull down menu. For example, select start date of 1/9/2015. End date gadget defaults to September but it is all greyed out and October, November and December are not available to select. Can obviously manually type the date in to the field. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14494] Terribly slow checkout caused by DateTime->new in far future
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14494 Marjorie Barry-Vilachanged: What|Removed |Added CC||marjorie.barry-v...@ccsr.qc ||.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14936] Add validation for date strings to Koha::DateUtils
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14936 Marc Véronchanged: What|Removed |Added Blocks|14924 | Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14924 [Bug 14924] Remove C4::Dates from members/memberentry.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14610] Add ability to place document delivery / article requests in Koha
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #13 from Kyle M Hall--- Article Requests are somewhat similar to holds, but are not requests for an item to check out. Instead, article requests are requests for a photocopy of a particular section of a book ( most often ). This is very common in academic libraries where researchers may request a copy of a single article found in a journal. This patch set adds the ability to place article requests in Koha. It allows the control of what can be requested via the circulation rules. Since article requests of electronic resources are not outside the realm of possibility, the feature will check not only the items for requstability, but the record itself as well ( i.e. both items.itype and biblio.itemtype ). Article requests can be placed for patrons from the opac and staff intranet and can be viewed in most areas where holds are viewed ( e.g. patron details, record details, etc ). There is a script to view article requests in progress within the circulation module. Article requests can be Open ( i.e. new ), In Processing, Completed, or Canceled. The status of a given request can be updated from this script. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14922] Remove C4::Dates from cataloguing/additem.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14922 Marc Véronchanged: What|Removed |Added Attachment #42987|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739 Josef Moravecchanged: What|Removed |Added Attachment #43052|0 |1 is obsolete|| --- Comment #41 from Josef Moravec --- Created attachment 43061 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43061=edit Bug 14739: Fix plack compatibility perlcritic raised "Declare variables outside of the condition" Works as expected Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14922] Remove C4::Dates from cataloguing/additem.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14922 Marc Véronchanged: What|Removed |Added Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13517] Show waiting date on reserve/request.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13517 Kyle M Hallchanged: What|Removed |Added Attachment #42604|0 |1 is obsolete|| Attachment #42605|0 |1 is obsolete|| Attachment #42606|0 |1 is obsolete|| --- Comment #30 from Kyle M Hall --- Created attachment 43066 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43066=edit Bug 13517 - Show waiting date on reserve/request.pl The holds table should show the waiting date for a hold in s similar manner to the way it does on catalogue/detail.pl In addition, if the ReservesMaxPickUpDelay syspref is set, we should display the date when the waiting hold expires. Test Plan: 1) Apply this patch 2) Set ReservesMaxPickUpDelay to 7 3) Find a waiting hold 4) Browse to reserve/request.pl for that record 5) Notice the "Item waiting" message now has "since " 6) Notice the expiration field now has the date of + 7 days Signed-off-by: Kyle M Hall Signed-off-by: Cathi Wiggins Signed-off-by: Megan Wianecki Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14924] Remove C4::Dates from members/memberentry.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14924 Marc Véronchanged: What|Removed |Added Attachment #43028|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739 --- Comment #42 from Josef Moravec--- I rebased the patches in my local branch, could you please check if it's OK? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739 Josef Moravecchanged: What|Removed |Added Attachment #43060|0 |1 is obsolete|| --- Comment #44 from Josef Moravec --- Created attachment 43062 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43062=edit Bug 14739 - Add several patrons to a new batch will create a new batch per patron added This patch changes the functionality of adding patrons to patroncard batches. Instead of using only the patron search, there is now a textarea which can either be manually populated with borrowernumbers, or can be populated using the patron-search To test: 1 - Create a new patron batch 2 - Click the add items button, if there is no data in the borrowrnumber form you should get a popup 3 - Add items to batch using the popup, borrowernumbers should populate to the form 4 - Click add items again and items should be added to a new batch 5 - Create a new batch 6 - Manually enter invalid borrowernumbers to the form 7 - Click add items, batch should return empty 8 - Manually enter valid borrowernumber 9 - Click add items, batch should be updated 10 - Edit an existing batch and confirm add items works as above 11 - Create a new label batch 12 - Click add items with no data, popup item search should appear 13 - Adding items by checking boxes or using 'Add' button - they should populate the text box on the edit batch page 14 - When adding using form the 'Enter by itemnumber' button should be marked automatically 15 - Submit items and confirm they are added to batch 16 - Create a new batch, enter by barcode manually and check 'Enter by itemnumber" 17 - Click add items, no items should be added 18 - Repopulate form with barcodes, check 'Enter by barcode' 19 - Click add items, items should be added correctly 20 - Test various combinations of radio buttons and numbers and using form or not Signed-off-by: Barton Chittenden -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14924] Remove C4::Dates from members/memberentry.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14924 Marc Véronchanged: What|Removed |Added Status|BLOCKED |Needs Signoff Depends on|14936 | Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14936 [Bug 14936] Add validation for date strings to Koha::DateUtils -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14924] Remove C4::Dates from members/memberentry.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14924 --- Comment #9 from Marc Véron--- Created attachment 43065 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43065=edit Bug 14924 - (follow-up) Add date validation using eval This patch adds a date validation (see comment #3). To test: - Apply patch - Create a new user or edit an existing user - Try valid dates for date of birth - Try invalid dates as -00-00 or 32/01/1970. You can can copy/paste such strings to the date field, ignore the warning message and submit. Verify that after submit you get a message "Date of birth is invalid" - Try the same with enrollement /expiry dates -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14922] Remove C4::Dates from cataloguing/additem.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14922 --- Comment #7 from Marc Véron--- Created attachment 43069 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43069=edit Bug 14922 - Remove C4::Dates from cataloguing/additem.pl This patch removes C4::Dates from cataloguing/additem.pl To test: - In MARC bibliographic framework, define a default value for one of the in Tag 952 Subfield struture, e.g. for subfield x Non-public note. You can define it under 'Advancde constraints'. Define the value similar to the following: Year: Month:MM Day:DD - Create a new item for a biblio and verify that , MM and DD are replaced with today's values. - Apply patch and repeat that previous step behaves as before. - Verify that the overall functionality of the form is the same as before applying the patch. Signed-off-by: Hector Castro Works as advertised. With the last script not accept more than MMDD If you enter something else, the script sends to the end of line. This patch follow up the pattern in constraint default value Patch amended following comment #6 / mv -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14935] waiting and in transit items cannot be reserved
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14935 Nicolas Legrandchanged: What|Removed |Added CC||nicolas.legr...@bulac.fr -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14658] Split PatronSelfRegistrationBorrowerUnwantedField into two preferences for creating and editing
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14658 --- Comment #4 from Jonathan Druart--- Comment on attachment 43041 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43041 Bug 14658 - Split PatronSelfRegistrationBorrowerUnwantedField into two preferences for creating and editing Review of attachment 43041: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=14658=43041) - ::: opac/opac-memberentry.pl @@ +244,4 @@ > my %hidden_fields; > > my $BorrowerUnwantedField = > + C4::Context->preference( "PatronSelf" . ucfirst($action) . > "BorrowerUnwantedField" ); As a grep fan, I would prefer to see the entire name of the prefs. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739 Josef Moravecchanged: What|Removed |Added Attachment #43040|0 |1 is obsolete|| --- Comment #35 from Josef Moravec --- Created attachment 43052 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43052=edit [SIGNED-OFF] Bug 14739: Fix plack compatibility perlcritic raised "Declare variables outside of the condition" Works as expected Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13452] Average checkout report always uses biblioitems.itemtype
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13452 Julian Mauricechanged: What|Removed |Added Status|Failed QA |Needs Signoff CC||julian.maur...@biblibre.com --- Comment #8 from Julian Maurice --- QA fix #2 not needed due to the removal of joins QA fix #3: the whole 'if' block is unnecessary, and wrong, since there is no placeholders in query. Replaced by a simple $sth2->execute; -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14248] Optionally display authorship for news items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14248 --- Comment #11 from Martin Persson--- The last, updated patch has been rewritten to make use of the Koha Preferences system rather than the template variables. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14899] Mapping configuration page for Elastic search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14899 --- Comment #13 from Jonathan Druart--- Created attachment 43058 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43058=edit Bug 14899: Add a link to the new page in the admin -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14899] Mapping configuration page for Elastic search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14899 --- Comment #14 from Jonathan Druart--- Patches updated, they now apply against the up-to-date catalyst/elastic_search branch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14942] if there is no barcode, item level hold can become a biblio level hold
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14942 Joonas Kylmälächanged: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14941] Subfield defaults: Add information about substitutable values
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14941 Marc Véronchanged: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=10294 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14899] Mapping configuration page for Elastic search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14899 --- Comment #12 from Jonathan Druart--- Created attachment 43057 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43057=edit Bug 14899: Add the mapping configuration page in the admin module This new page (admin/searchengine/elasticsearch/mappings.pl) will permit to manage the ES mappings. For the biblios and authorities indexes, the different mappings can be managed from this single page. The interface let you add, remove and update mappings. It's also possible to reorder the mappings, as the order can be important in the indexation process. Note that the table can be displayed in a different order that the one it was before saving, but the mappings are grouped by search field and the order inside the search field is preserved. Limitations: - If something went wrong during the insertion/deletion/modification, the users will loose all these changes. - Using the interface the user can defined several labels for a same field. The script will retrieve the first change and apply it, next ones will be avoided. TODO: - Add a specific permission (?) - Add some data checks client side (JS) - Use checkboxes for facet and suggestible (lazy today...) - Understand the difference between the 3 values that sortable can have and improve the value for the options in the select box. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14899] Mapping configuration page for Elastic search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14899 --- Comment #11 from Jonathan Druart--- Created attachment 43056 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43056=edit Bug 14899: DB changes This patch applies several changes to the DB structure introduced by the previous ES patch set: 1/ Add a search_field.label column => It will be easier to understand what the search_field does. Indeed, some are not user friendly: acqdate, an, pl, ff8-23, ln, etc. TODO later: Update the labels with correct values (at the moment label=name) 2/ Update the foreign key search_marc_to_field.search_marc_map_id with on delete cascase. This will permit to automatically remove the entries in search_marc_to_field when they are deleted in search_marc_map. 3/ Remove the index_name_2 unique constraint on the search_marc_map table. I don't understand how this could be useful, it was defined like (index_name, marc_type, marc_field), so it means a mapping cannot be defined twice with different values for facet, suggestible and sort. This limitation does not seem to make sense. Robin, please correct me if I am wrong :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14899] Mapping configuration page for Elastic search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14899 Jonathan Druartchanged: What|Removed |Added Attachment #42882|0 |1 is obsolete|| Attachment #42883|0 |1 is obsolete|| Attachment #42884|0 |1 is obsolete|| Attachment #42885|0 |1 is obsolete|| Attachment #42886|0 |1 is obsolete|| --- Comment #9 from Jonathan Druart --- Created attachment 43054 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43054=edit Bug 14899: Add Koha::SearchField[s] and Koha::SearchMarcMap[s] classes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14899] Mapping configuration page for Elastic search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14899 --- Comment #10 from Jonathan Druart--- Created attachment 43055 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43055=edit Bug 14899: Add tableDND JS lib -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7045] Default-value substitution inconsistent
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7045 Marc Véronchanged: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=14941 -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14941] Subfield defaults: Add information about substitutable values
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14941 Marc Véronchanged: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=7045 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10294] when the word "user" is included in default in framework, surname of login creating record inserted
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10294 Marc Véronchanged: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=14941 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14106] koha-conf paths to zebra libraries are wrong in jessie
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14106 --- Comment #13 from Mason James--- (In reply to Liz Rea from comment #12) > Note to self to include "This makes Koha 3.18 compatible with Debian > (Jessie)" in the release notes. curious, would this be a problem in 3.16.x too? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11559] Professional cataloger's interface
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 --- Comment #132 from Jonathan Druart--- Quick feedback after some random tests: 1/ +console.dir( _framework_kohafields ); => to remove 2/ dependency UUID should be added 3/ Edit/create a record, modify it, click on "New record" (you just missed the Save button), everything is lost. Should ask for confirmation :) 4/ Search a. Click on 1 server launch a request, what if you want to select/deselect all? I think it would be better to have a "search" button here, to avoid useless queries. b. The number of results is different with the same search on cataloguing/z3950_search.pl (5 pages vs 25!) c. The link is "Import" even if the users search in the local catalogue. Maybe "edit" is more appropriate. 5/ The favicon is missing on cataloguing/editor.pl 6/ I still have issue with mandatory/repeatable field. From the editor: 615 _ _ $a [Dropdown list] Missing mandatory subfield: $m; Missing mandatory subfield: $n; Missing mandatory subfield: $x From the (default) framework page: 615 centre d'intérêt No No 2 code du système d'indexation subfield ignored 3 numéro de la notice d'autorité subfield ignored a catégorie sujet Tab:1, Not repeatable, Not mandatory, | Auth value:interet m subdivision de la catégorie sujet sous forme codée subfield ignored n catégorie sujet sous forme codée subfield ignored x subdivision de la catégorie sujet subfield ignored 7/ I don't understand why the default framework is used. 8/ Import record, then save. "Saving" is processing, nothing happen, browser freezes JS error: Error: Script terminated by timeout at: P@http://pro.koha-qa.vm/intranet-tmpl/lib/codemirror/codemirror-compressed.js:11:7546 [...] some others errors The record has 50 items. 9/ macro delete 200 # delete only the first 200, is it expected? Is there a doc somewhere with the commands available? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11559] Professional cataloger's interface
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559 Jonathan Druartchanged: What|Removed |Added Status|In Discussion |Needs Signoff --- Comment #131 from Jonathan Druart --- I don't understand the current "in discussion" status, back to needs signoff. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14942] New: if there is no barcode, item level hold can become a biblio level hold
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14942 Bug ID: 14942 Summary: if there is no barcode, item level hold can become a biblio level hold Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: j.kylm...@gmail.com Reporter: j.kylm...@gmail.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com In reserve/request.pl if you have a hold entry without a barcode and someone has added a new hold after the barcodeless hold, the barcodeless hold will get the new hold's itemnumber and the new hold will have no itemnumber and so the new hold will be set at biblio level. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739 Josef Moravecchanged: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #36 from Josef Moravec --- It works like a charm ;) Thank you Jonathan -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739 Josef Moravecchanged: What|Removed |Added Attachment #42474|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739 Josef Moravecchanged: What|Removed |Added Attachment #43050|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13452] Average checkout report always uses biblioitems.itemtype
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13452 --- Comment #7 from Julian Maurice--- Created attachment 43053 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43053=edit Bug 13452: Fix obvious issues in issues_avg_stats.pl - Remove joins with issuingrules which are not needed - Fix the SQL query so that $weight is now the value of COUNT(*) instead of a timestamp - QA fix: '$column eq $itype' instead of '$column =~ $itype' (same for $line) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12478] Elasticsearch support for Koha
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #117 from Jonathan Druart--- I am getting error on the DB update process: C4::Installer::load_sql returned the following errors while attempting to load /home/koha/src/installer/data/mysql/elasticsearch_mapping.sql: ERROR 1062 (23000) at line 294: Duplicate entry 'biblios-marc21-490a' for key 'index_name_2' ERROR 1062 (23000) at line 294: Duplicate entry 'biblios-marc21-490a' for key 'index_name_2' -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5371] Back-button in OPAC shows previous user's details, after LOGOUT
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5371 Kyle M Hallchanged: What|Removed |Added CC||kyle.m.h...@gmail.com --- Comment #30 from Kyle M Hall --- (In reply to Katrin Fischer from comment #29) > I tested a few times - maybe it's a firefox thing? I was using Firefox in > Ubuntu. It was described as a privacy measure to not request pages not > cached automatically again. I also was testing this patch using Chrome and Firefox on OS X. My experience is that some pages would give the "cache miss" error in both browsers and some would just redirect to the login screen. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5371] Back-button in OPAC shows previous user's details, after LOGOUT
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5371 --- Comment #31 from Marc Véron--- (In reply to Kyle M Hall from comment #30) > (In reply to Katrin Fischer from comment #29) > > I tested a few times - maybe it's a firefox thing? I was using Firefox in > > Ubuntu. It was described as a privacy measure to not request pages not > > cached automatically again. > > I also was testing this patch using Chrome and Firefox on OS X. My > experience is that some pages would give the "cache miss" error in both > browsers and some would just redirect to the login screen. I think that happens if the page where you crawl back to is a page that was the result of a (log-in)form. See first point on comment #19 To reproduce (Firefox 40.1 Win / Chrome 45.0.2454.101 m / ): - Close all browser windows to have a clear base line - Open OPAC main page - Log in as user with the login form at the right on the main page - You are now on opac-user.pl - Go to 'your fines' - Log out - You are redirected to the main page - Hit back button - You are now on opac-account.pl, it displays the login form - Hit back button again - In browser address field you have .../cgi-bin/koha/opac-user.pl and the browser displays a message "Document expired... Try again" - Hit "ry again" - Brower displays a pop-up, something like "Send data again..." with buttons 'Send again' / 'Cancel' - Hit 'Send again' Result: - Firefox: ...you are logged in with user AAA and can browse to other pages - Chrome: the message on .../cgi-bin/koha/opac-user.pl says something like "Confirm sendign data again" and the string ERR_CACHE_MISS - IE: the message on .../cgi-bin/koha/opac-user.pl says something like 'Webite expired... local copy no longer valid... Fazit: The patches are fine to fix things for Chrome and IE (at least the version I tested), but with FF 40.1 I was able to get back again to a page with a valid login. Since the browsers behave differently (maybe additionally depending on individual browser settings), I would like to repeat my proposition from comment #11 (in addition to the patches): After a logout, display a message similar to the following: "Logout privacy warning: Please close this browser window if other persons have access to this computer." -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14861] Accession date comparison does not work in advanced search
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14861 --- Comment #22 from Jonathan Druart--- Yep, if it works, let's do it for all date indexes :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072 Marc Véronchanged: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=14936 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14788] Move opac-topissues.pl code into C4::Circulation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14788 Marc Véronchanged: What|Removed |Added Attachment #42406|0 |1 is obsolete|| --- Comment #5 from Marc Véron --- Created attachment 43051 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43051=edit Bug 14788: Move opac-topissues.pl code into C4::Circulation Tested with syspref 'AdvancedSearchTypes' set to itemtypes an ccode (one at a time). No problems found. Signed-off-by: Marc Véron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739 --- Comment #38 from Josef Moravec--- Sorry, I did a mistake with obsoleting patches, now it should be OK, could you try it again please? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739 Josef Moravecchanged: What|Removed |Added Attachment #43040|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739 Josef Moravecchanged: What|Removed |Added Attachment #42474|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12478] Elasticsearch support for Koha
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #118 from Jonathan Druart--- (In reply to Jonathan Druart from comment #117) > I am getting error on the DB update process: > C4::Installer::load_sql returned the following errors while attempting to > load /home/koha/src/installer/data/mysql/elasticsearch_mapping.sql: > ERROR 1062 (23000) at line 294: Duplicate entry 'biblios-marc21-490a' for > key 'index_name_2' > ERROR 1062 (23000) at line 294: Duplicate entry 'biblios-marc21-490a' for > key 'index_name_2' Robin, have a look at the patch "DB changes" I have attached on bug 14899, maybe it should be integrated here. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14941] New: Subfield defaults: Add information about substitutable values
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14941 Bug ID: 14941 Summary: Subfield defaults: Add information about substitutable values Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcha...@gmail.com Reporter: ve...@veron.ch QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl If you add 'user', ', 'MM' and 'DD' as the default value for a subfield in the bibliographic frameworks, the field will be automatically filled with the data as appropriate. However, there is no information about this feature (hint in form, help page, manual). Related Bugs: - Bug 10294 - when the word "user" is included in default in framework, surname of login creating record inserted - Bug 7045 - Default-value substitution inconsistent -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14610] Add ability to place document delivery / article requests in Koha
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 Katrin Fischerchanged: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #12 from Katrin Fischer --- Kyle, is there a description of the feature available somewhere? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739 --- Comment #33 from Jonathan Druart--- Created attachment 43050 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43050=edit Bug 14739: Fix plack compatibility perlcritic raised "Declare variables outside of the condition" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739 --- Comment #34 from Jonathan Druart--- (In reply to Josef Moravec from comment #32) > Now I now where is the difference. It's plack! > > When I stop using plack, everything works as expected. hehe, thanks Josef! Here is a patch! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14788] Move opac-topissues.pl code into C4::Circulation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14788 Jonathan Druartchanged: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org Status|Signed Off |Failed QA --- Comment #6 from Jonathan Druart --- Julian, please provide tests. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12478] Elasticsearch support for Koha
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #119 from Jonathan Druart--- Does the authorities index is supposed to work? I get Use of uninitialized value $id in concatenation (.) or string at misc/search_tools/rebuild_elastic_search.pl line 173. after a perl misc/search_tools/rebuild_elastic_search.pl -a -v and on /koha-es_authorities/_search?q=* "_index" : "koha-es_authorities", "_type" : "data", "_id" : "7c8462c8-c813-4013-9ab7-1ca77069bbc4", -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12478] Elasticsearch support for Koha
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12478 --- Comment #120 from Jonathan Druart--- Robin, It seems that something was wrong during the rebase process. I have tried the updated branch without any success: $ git reset --hard catalyst/elastic_search $ installer/data/mysql/updatedatabase.pl # see error in previous comment, but I should not that the following is still true if I remove the unique key $ perl misc/search_tools/rebuild_elastic_search.pl -b -v # no error I can now only search for "*", other patterns return nothing, and /koha-es_biblios/_search?q=* shows entries like: { "_index" : "koha-es_biblios", "_type" : "data", "_id" : "11", "_score" : 1.0, "_source":{"record":[["LDR",null,null,"_","01199cam a22003134a 4500"],["001",null,null,"_","12011929"],["005",null,null,"_","20140507153623.0"],["008",null,null,"_","000518s2000 ch a b001 0 eng "],["010"," "," ","a"," 00041664 "],["020"," "," ","a","1565924193"],["040"," "," ","a","DLC","c","DLC","d","DLC"],["042"," "," ","a","pcc"],["050","0","0","a","QA76.73.P22","b","G84 2000"],["082","0","0","a","005.2/762","2","21"],["100","1"," ","a","Guelich, Scott.","9","8"],["245","1","0","a","CGI programming with Perl /","c","Scott Guelich, Shishir Gundavaram and Gunther Birznieks."],["250"," "," ","a","2nd ed."],["260"," "," ","a","Beijing ;","a","Cambridge, Mass. :","b","O'Reilly,","c","2000."],["300"," "," ","a","xv, 451 p.","b","ill.","c","24 cm."],["504"," "," ","a","Includes bibliographical references (p. 403-406) and index."],["650"," ","0","a","Perl (Computer program language)","9","35"],["650"," ","0","a","CGI (Computer network protocol)","9","37"],["650"," ","0","a","Internet programming.","9","7"],["700","1"," ","a","Birznieks, Gunther.","9","38"],["856","4","2","3","Publisher description","u","http://www.loc.gov/catdir/enhancements/fy0715/00041664-d.html"],["906",; "," ","a","7","b","cbc","c","orignew","d","1","e","ocip","f","20","g","y-gencatlg"],["942"," "," ","2","ddc","c","BK"],["955"," "," ","a","to ASCD pc16 05-18-00; jf05 (desc.) 05/18/00 ; jf11 to sl 5-19-00; jf12 to Dewey 05-23-00;aa03 5-24-00;CIP ver jf0504/10/01; jf12 to BCCD 04-11-01"],["952"," "," ","0","0","1","0","4","0","6","_","7","0","8","GEN","9","32","a","ALPHA","b","ALPHA","c","GEN","d","2014-09-04","p","300498","r","2014-09-04","w","2014-09-04","y","BK"],["999"," "," ","c","11","d","11"]],"_id":"11"} } There is something wrong when the tables are populated. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14739] Add several patrons to a new batch will create a new batch per patron added
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739 --- Comment #39 from Jonathan Druart--- The second patch does not apply anymore, but maybe it was not based on the good one. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14364] Allow automatically canceled expired waiting holds to fill the next hold
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14364 Katrin Fischerchanged: What|Removed |Added Status|Signed Off |Needs Signoff CC||katrin.fisc...@bsz-bw.de --- Comment #8 from Katrin Fischer --- See comment #3 - I agree as there is some discussion here, another sign-off would be good. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14936] Add validation for date strings to Koha::DateUtils
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14936 Marc Véronchanged: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=12072 --- Comment #6 from Marc Véron --- Hi Jonathan, Propositon 1/ changes the behaviour of dt_from_string. This function is spread all over the system, and we do not know what side effects it will have if we change the behavior regarding the return value. That's why I decided not to touch it at the moment. Proposition 2/ Catch a croak: Is that done by surrounding dt_from_string with an eval? (I simply do not know) My opinion is that it is much better to have a dedicated function to validate a date string. It works fine afak and it has tests. I know that it duplicates code, but that can easily be streamlined later, after we finally have added the long outstandig DD.MM. date format (Bug 12072). (In reply to Jonathan Druart from comment #5) > Marc, > This is not the way to go, for several reasons. > The main reason is that you c/p dt_from_string to create the new subroutine, > which is bad. > Then, if you have a look at dt_from_string, you will note 1 eval around the > first DateTime->new (l. 156), but not around the second one (l. 164). > So I think there are at least 2 better ways to know if a date is not > correctly formatted: > 1/ add an eval around the second DateTime->new call, the subroutine will > return undef and the caller will have to check if something has been > returned ; > 2/ or catch the croak raised by the DateTime in the callers > > I don't know what I would prefer (a bit early and not drank enough tea yet). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14788] Move opac-topissues.pl code into C4::Circulation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14788 Marc Véronchanged: What|Removed |Added Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14788] Move opac-topissues.pl code into C4::Circulation
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14788 Marc Véronchanged: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11139] opac-topissues does not work with CCODE
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11139 Marc Véronchanged: What|Removed |Added CC||ve...@veron.ch --- Comment #14 from Marc Véron --- Hi Julian and Fridolin, It might be a good idea to have a separate syspref for the behavior of the most popular list instead of the double use of 'AdvancedSearchTypes' It would make things much more clearer. What do you think? Marc -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14942] if there is no barcode, item level hold can become a biblio level hold
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14942 --- Comment #1 from Joonas Kylmälä--- Created attachment 43059 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43059=edit Bug 14942: add itemnumber even though there is no barcode Adding item number even though there's no barcode makes sure that some holds are not missing item number (and some won't have other hold's item numbers) and therefore not being changed to biblio level holds. Test plan: 1. Have a item level hold entry without a barcode 2. Add now a new item level hold request through OPAC 3. Go to edit that new hold request's pickup library through staff side. 4. Notice that the new hold request is now at biblio level 5. Apply patch 6. Do the same steps as before but now notice that the new hold request is still at item level. Sponsored-by: Vaara-kirjastot -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14522] Use Koha::Cache for accessing single_holidays()
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14522 Tomás Cohen Arazichanged: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #30 from Tomás Cohen Arazi --- Patches pushed to master. Thanks Mason and Kyle! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14939] OAI Server classes must be modularized
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14939 Frédéric Demianschanged: What|Removed |Added Attachment #43045|0 |1 is obsolete|| --- Comment #2 from Frédéric Demians --- Created attachment 43072 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43072=edit Bug 14939 Modularize OAI Server existing classes Koha OAI server has been done in one unique .pl file because there wasn't any object model or rules in the Koha project when it has been coded. This patch modularized existing classes, putting each class in a separate file in Koha::OAI namespace. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5371] Back-button in OPAC shows previous user's details, after LOGOUT
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5371 --- Comment #33 from Chris Cormack--- I agree with Marc that we need to also waen the users to close the browser, as I can confirm that this fix doesn't work for Firefox -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14522] Use Koha::Cache for accessing single_holidays()
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14522 Tomás Cohen Arazichanged: What|Removed |Added Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14929] Fix missing display of help page in contract management
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14929 Tomás Cohen Arazichanged: What|Removed |Added CC||tomasco...@gmail.com Status|Passed QA |Pushed to Master --- Comment #6 from Tomás Cohen Arazi --- Patch pushed to master. Thanks Marc! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14842] Wrong call to GetBranchItemRule in circ/returns.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14842 Tomás Cohen Arazichanged: What|Removed |Added Status|Passed QA |Pushed to Master CC||tomasco...@gmail.com --- Comment #6 from Tomás Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5371] Back-button in OPAC shows previous user's details, after LOGOUT
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5371 Tomás Cohen Arazichanged: What|Removed |Added Status|Passed QA |Pushed to Master CC||tomasco...@gmail.com --- Comment #32 from Tomás Cohen Arazi --- Patches pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14927] OAI-PMH listRecords result should include item data when using a resumption token
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14927 Tomás Cohen Arazichanged: What|Removed |Added CC||tomasco...@gmail.com Status|Passed QA |Pushed to Master --- Comment #6 from Tomás Cohen Arazi --- Patch pushed to master. Thanks Frederic! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14832] Encoding issues when exporting in RIS
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14832 Tomás Cohen Arazichanged: What|Removed |Added CC||tomasco...@gmail.com Status|Passed QA |Pushed to Master --- Comment #8 from Tomás Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14522] Use Koha::Cache for accessing single_holidays()
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14522 --- Comment #28 from Tomás Cohen Arazi--- Created attachment 43070 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43070=edit Bug 14522: (QA followup) tidy tests Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14522] Use Koha::Cache for accessing single_holidays()
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14522 --- Comment #29 from Kyle M Hall--- Created attachment 43071 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43071=edit Bug 14522 [QA Followup] * Change POD to a brief comment * Fix UT so it doesn't fail on Sundays -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10306] Publication information can only be mapped to either 260 or 264 (RDA)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10306 Galen Charltonchanged: What|Removed |Added CC||gmcha...@gmail.com --- Comment #5 from Galen Charlton --- To outline a way of dealing with this: One way of looking at the problem is that RDA and the 260/264 forces us to deal with the fact that some attributes that we might want to stick in a column in biblio or biblioitems needs to draw from multiple MARC fields. XSLT and XPath give ways to do that sort of parsing... so we can add it to Koha something like this: - Create a new table to store XSLT stylesheets. This could be a combination of standard stylesheets (e.g., the MARC21 to MODS transforming) and local ones. - Create a new table to specify mappings to columns, something like this: koha_attribute_map kohafield# name of table and column to store the results xslt # reference to the XSLT to use, if need be xpath# what to use to extract the value The process would then be, when saving a bib record, that for each attribute specified in koha_attribute_map, the XSLT (if specified) would be applied to the MARCXML, then the XPath used to extract a result, which is then placed in the column specified by kohafield. This process could be used to supplemnt the one-subfield-to-one-column mapping that the MARC frameworks already specify, or with a bit more work, replace it. I should note that this general idea is inspired largely by similar mechanisms in Evergreen. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12311] Batch modification of checked out and lost items checks them in
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12311 Tomás Cohen Arazichanged: What|Removed |Added CC||tomasco...@gmail.com Status|Passed QA |Pushed to Master --- Comment #9 from Tomás Cohen Arazi --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/