[Koha-bugs] [Bug 14915] Use Font Awesome instead of Glyphicons for the staff intranet

2015-10-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14915

--- Comment #7 from Jonathan Druart  
---
(In reply to Kyle M Hall from comment #6)
> Created attachment 43277 [details] [review]
> Bug 14915 [QA Followup] - Tweak '+' icon for serials-home

There are certainly some others I have not found.
I also tested for a few minutes.

I think we need either another signoff (the tester must test a lot of pages and
compare them with master) or wait for the beginning of the next release cycle.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14987] patron card creator not displaying correct cardnumber

2015-10-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14987

--- Comment #6 from Marc Véron  ---
I also was thinking about not displaying this column. Hmm, we can sort the
colums e.g. alphabetically by name (in the table only, not for printing), so it
might be needed to switch back to the order 'how I added items'.

It would be a big enhancement (and quite a task) 
- to have te possibility to print in different orders
- to be able to move an item inside the 'added' batch position

Hmm, at the moment I propose to change the template files only (string change
for the headers to avoid user confusion) and to postpone the rest.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13791] Plack - Out of the box support on packages

2015-10-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13791

Magnus Enger  changed:

   What|Removed |Added

 CC||mag...@libriotech.no

--- Comment #49 from Magnus Enger  ---
Traditionally, changes to the koha-*scripts have been backported to stable
releases, so that the tools around package installations are the same, no
matter what version they are running. Could/should this be considered for the
present bug too, or is it too big a leap to incorporate it into the stable
branches?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion

2015-10-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973

--- Comment #3 from Alex Arnaud  ---
Hello Marc,

I used C4::Search::FindDuplicate which seems to require almost the full title /
author.

Either we fix findDuplicate to make it more flexible or we create an other
subrutine (using simpleSearch ?)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14954] Remove C4::Dates from holiday related files in folder tools

2015-10-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14954

Marc Véron  changed:

   What|Removed |Added

 Status|Needs Signoff   |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11158] Authorities 'starts with' search returns the same as 'contains' when using ICU

2015-10-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11158

Gaetan Boisson  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m,
   ||gaetan.bois...@biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14925] Remove C4::Dates from members/moremember.pl

2015-10-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14925

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #43284|0   |1
is obsolete||

--- Comment #5 from Jonathan Druart  
---
Created attachment 43288
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43288&action=edit
Bug 14925 - Remove C4::Dates from members/moremember.pl

This patch removes C4::Dates from members/moremember.pl

To test:
- Go to Details page of several members
- Verify that all dates display OK, including restrictions

Signed-off-by: Hector Castro 
Works as advertised. All dates displayed OK

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14925] Remove C4::Dates from members/moremember.pl

2015-10-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14925

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14990] New: Make the date formatting template side - moremember.pl

2015-10-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14990

Bug ID: 14990
   Summary: Make the date formatting template side - moremember.pl
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: normal
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: jonathan.dru...@bugs.koha-community.org
  Reporter: jonathan.dru...@bugs.koha-community.org
QA Contact: testo...@bugs.koha-community.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14925] Remove C4::Dates from members/moremember.pl

2015-10-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14925

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||14990


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14990
[Bug 14990] Make the date formatting template side - moremember.pl
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14990] Make the date formatting template side - moremember.pl

2015-10-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14990

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||14925

--- Comment #1 from Jonathan Druart  
---
I wrote a qa followup for bug 14925, but I would like to get a signoff on it.


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14925
[Bug 14925] Remove C4::Dates from members/moremember.pl
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14990] Make the date formatting template side - moremember.pl

2015-10-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14990

--- Comment #2 from Jonathan Druart  
---
Created attachment 43289
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43289&action=edit
Bug 14990: Format the date template-side for moremember

Test plan:
print slip and show the member detail page, the 3 dates date of birth,
date enrolled and date of expiry should be displayed correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14990] Make the date formatting template side - moremember.pl

2015-10-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14990

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14926] Remove C4::Dates from members/printfeercpt.pl

2015-10-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14926

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
 Status|Signed Off  |Failed QA

--- Comment #5 from Jonathan Druart  
---
(In reply to Héctor Eduardo Castro Avalos from comment #4)
> Signed-off-by: Hector Castro 
> Works as advertised. Date displayed 2015-10-08

Yes but -MM-DD is the iso format.
If you change your pref to something else, it will be the iso format too.
So the patch does not work.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14926] Remove C4::Dates from members/printfeercpt.pl

2015-10-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14926

--- Comment #6 from Jonathan Druart  
---
Created attachment 43290
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43290&action=edit
Bug 14926: Format the date according to the dateformat syspref

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14926] Remove C4::Dates from members/printfeercpt.pl

2015-10-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14926

Jonathan Druart  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14926] Remove C4::Dates from members/printfeercpt.pl

2015-10-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14926

--- Comment #7 from Jonathan Druart  
---
Please try again with the last patch, and don't forget to change your
dateformat pref to something else than iso :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14928] Remove C4::Dates from files acqui/pdfformat/layout*.pm

2015-10-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14928

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14928] Remove C4::Dates from files acqui/pdfformat/layout*.pm

2015-10-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14928

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #43286|0   |1
is obsolete||

--- Comment #5 from Jonathan Druart  
---
Created attachment 43291
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43291&action=edit
Bug 14928 - Remove C4::Dates from files acqui/pdfformat/layout*.pm

This patch removes C4::Dates from:
- acqui/pdfformat/layout2pages.pm
- acqui/pdfformat/layout2pagesde.pm
- acqui/pdfformat/layout3pages.pm
- acqui/pdfformat/layout3pagesfr.pm

To test:
- Apply patch
- Go to Home > Acquisitions > [Vendor] > Basket groups
- Print a basket (order)
- Verify that the current date is formatted respects syspref 'dateformat'
- Do the same with syspref 'OrderPdfFormat' set to the four different choices

Signed-off-by: Hector Castro 
Works as advertised. Date printed in PDF Ok

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14804] Software error while removing duplicates

2015-10-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14804

Joonas Kylmälä  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |INVALID

--- Comment #2 from Joonas Kylmälä  ---
(In reply to Liz Rea from comment #1)
> Hi Joonas,
> 
> I'm not able to replicate this issue on current master.
> 
> Cheers,
> Liz

Me neither, anymore. I guess something fixed it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14991] New: Add search main heading ($a only) to authority search, reword and clarify

2015-10-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14991

Bug ID: 14991
   Summary: Add search main heading ($a only) to authority search,
reword and clarify
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Searching
  Assignee: gmcha...@gmail.com
  Reporter: gaetan.bois...@biblibre.com
QA Contact: testo...@bugs.koha-community.org

At the moment we can search authorities from two places: authorities-home.pl
and auth_finder.pl (while cataloguing).

The auth_finder.pl page offers searching specifically in the $a of the main
heading, while the authorities home page doesn't.

Additionally, the wording and order of the options is different.

authorities-home.pl has:
Search main heading
Search all headings
Keyword search

while auth_finder.pl has:
Main entry ($a only)
Main entry
Anywhere
Heading match

This patch will add some consistency so that both patches offer:
Search main heading ($a only)
Search main heading
Search all headings
Search entire record

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14991] Reword, clarify and add consistency to authority search

2015-10-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14991

Gaetan Boisson  changed:

   What|Removed |Added

Summary|Add search main heading ($a |Reword, clarify and add
   |only) to authority search,  |consistency to authority
   |reword and clarify  |search

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14711] We do no longer need bibitems in AddReserve

2015-10-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14711

Joonas Kylmälä  changed:

   What|Removed |Added

 Status|Needs Signoff   |In Discussion

--- Comment #3 from Joonas Kylmälä  ---
(In reply to Jonathan Druart from comment #2)
> Bug 9809 already updated all calls to AddReserve, to prevent a future change
> again it could worth to change the prototype of this subroutine to make it
> get a hashref.

Attachment 42198 is now obsolete, right? Shall we create a new bug report for
the hashref change?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11678] Gather print notices: send files by email

2015-10-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11678

Josef Moravec  changed:

   What|Removed |Added

 CC||josef.mora...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11340] make the 'print summary' a custom slip/notice

2015-10-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11340

Josef Moravec  changed:

   What|Removed |Added

 CC||josef.mora...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11274] Sent Notices Tab Not Working Correctly

2015-10-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11274

Josef Moravec  changed:

   What|Removed |Added

 CC||josef.mora...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14992] New: New options and clarification for authority search modes dropdown

2015-10-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14992

Bug ID: 14992
   Summary: New options and clarification for authority search
modes dropdown
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Searching
  Assignee: gmcha...@gmail.com
  Reporter: gaetan.bois...@biblibre.com
QA Contact: testo...@bugs.koha-community.org

Right now the options for searching in the authorities in the dropdown menu are
confusing a lot of users.

They are:
Contains
Starts with
Is exactly

What they actually do is:

"Contains" searches for all the terms entered, in any order, with a right
truncature.

"Starts with" searches for all the terms entered, in that order, with a right
truncature. The matching subfield itself doesn't have to start with the terms
entered. If you search for "John", "Cash, Johnny" will be a valid result. (This
is the most confusing option right now.)

"Is exactly" searches for all the terms entered, in that order, without a
truncature. The whole subfield doesn't have to match the phrase entered by the
user though, so if you search for "Johnny", "Cash, Johnny" will be a valid
result, more confusingly "Smith-Cash, Johnny" will be a valid result if you
search for "Cash, Johnny".

This patch will change the options offered so that they are:
"with truncature, in any order" (what "contains" does right now)
"without truncature, in any order" (new option, all the entered terms exactly
as they were entered, in any order)
"without truncature, in that order" (what "is exactly" does right now)
"Is exactly" (new option, there is a subfield that matches exactly the entered
sequence, the whole subfield has to match)

The current "Starts with" will be removed as there doesn't seem to be a way of
searching for "the subfield starts with" (See bug 11158). What it does right
now would be "with truncature, in that order" but i cannot think of  a useful
case for this. (It allows for searching for "Cas John" and finding "Cash,
Johnny".) If someone sees a reason to keep it, then we will reword it to "with
truncature, in that order".

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14992] New options and clarification for authority search modes dropdown

2015-10-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14992

Gaetan Boisson  changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=14991

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14991] Reword, clarify and add consistency to authority search

2015-10-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14991

Gaetan Boisson  changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=14992

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13029] Allow to pass additional parameters to SMS::Send drivers

2015-10-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13029

Magnus Enger  changed:

   What|Removed |Added

 CC||mag...@libriotech.no

--- Comment #6 from Magnus Enger  ---
Wouldn't it make sense to also document this new feature in the POD of
C4/SMS.pm?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13029] Allow to pass additional parameters to SMS::Send drivers

2015-10-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13029

--- Comment #7 from Magnus Enger  ---
How will this work for a Debian-package based installation that serves multiple
Koha instances? There will only be one YAML file, right? So it is not possible
to have different settings for different instances? 

For SMS::Send::Telenor (https://github.com/eskaaren/SMS-Send-Telenor) it is
possible to pass in a sender, but that will have to be a different sender for
each Koha instance.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14562] Patron with empty card number will be only result returned by patron datatables search

2015-10-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14562

Joonas Kylmälä  changed:

   What|Removed |Added

  Attachment #41436|0   |1
is obsolete||

--- Comment #6 from Joonas Kylmälä  ---
Created attachment 43292
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43292&action=edit
Bug 14562: All patrons returned if 1 has a cardnumber set to an empty string
(Fix conflict with bug 12833)

Works as expected

This patch is a backport of (Bug 12648 is in 3.20.x, not 3.18.x):
commit 481479fe627dcbabb3ef66df0724cc3fe75b110c
Bug 12648: Fix conflict with bug 12833

Test plan:
Set the cardnumber of one of the patron to an empty string
Do a patron search and use filters
The search will redirect to the patron detail page of the patron with
the empty string

Signed-off-by: Joonas Kylmälä 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14562] Patron with empty card number will be only result returned by patron datatables search

2015-10-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14562

Joonas Kylmälä  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14711] We do no longer need bibitems in AddReserve

2015-10-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14711

--- Comment #4 from Jonathan Druart  
---
no, just submit another patch with the call updated.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14993] rebuild_zebra.pl, when recreating Zebra-directory structure, mkdir doesn't fail/error/die

2015-10-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14993

--- Comment #1 from Olli-Antti Kivilahti  ---
Created attachment 43293
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43293&action=edit
Bug 14993 - rebuild_zebra.pl, when recreating Zebra-directory structure, mkdir
doesn't fail/error/die

This is due to implicit perl programming.
Avoid doing this!
mkdir $bdir || die "Error $!";

TO REPLICATE:

1. rm -r /home/koha/koha-dev/var/lib/zebradb (or whatever your zebradb location
is)
2. run rebuild_zebra.pl -b -a -r -x -v
3. Observe how rebuild_zebra.pl tells that it has rebuilt all the missing
   directories.
4. cd /home/koha/koha-dev/var/lib/zebradb/biblios
5. No such directory???
6. You wait for several hours to reindex your zebradb to find that nothing
   works :(

AFTER THIS PATCH:

1. rm -r /home/koha/koha-dev/var/lib/zebradb (or whatever your zebradb location
is)
2. run rebuild_zebra.pl -b -a -r -x -v
3. Observe how rebuild_zebra.pl tells that it couldn't create missing
directories.

A (possibly) better fix would be to recreate the top two directories from the
path, but no point patching a dead horse, since ElasticSearch will be here soon
:)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14993] New: rebuild_zebra.pl, when recreating Zebra-directory structure, mkdir doesn't fail/error/die

2015-10-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14993

Bug ID: 14993
   Summary: rebuild_zebra.pl, when recreating Zebra-directory
structure, mkdir doesn't fail/error/die
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Searching
  Assignee: gmcha...@gmail.com
  Reporter: olli-antti.kivila...@jns.fi
QA Contact: testo...@bugs.koha-community.org

This is due to implicit perl programming.
Avoid doing this!
mkdir $bdir || die "Error $!";

TO REPLICATE:

1. rm -r /home/koha/koha-dev/var/lib/zebradb (or whatever your zebradb location
is)
2. run rebuild_zebra.pl -b -a -r -x -v
3. Observe how rebuild_zebra.pl tells that it has rebuilt all the missing
   directories.
4. cd /home/koha/koha-dev/var/lib/zebradb/biblios
5. No such directory???
6. You wait for several hours to reindex your zebradb to find that nothing
   works :(

AFTER THIS PATCH:

1. rm -r /home/koha/koha-dev/var/lib/zebradb (or whatever your zebradb location
is)
2. run rebuild_zebra.pl -b -a -r -x -v
3. Observe how rebuild_zebra.pl tells that it couldn't create missing
directories.

A (possibly) better fix would be to recreate the top two directories from the
path, but no point patching a dead horse, since ElasticSearch will be here soon
:)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14993] rebuild_zebra.pl, when recreating Zebra-directory structure, mkdir doesn't fail/error/die

2015-10-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14993

Olli-Antti Kivilahti  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11298] Renewal due date won't take specified time into account

2015-10-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11298

--- Comment #10 from Jonathan Druart  
---
(In reply to Marjorie Barry-Vila from comment #9)
> (In reply to Jonathan Druart from comment #8)
> > Could you check the log file?
> > Looks good here.
> 
> Sorry Jonathan, I tested it again and it do not work.
> 
> I don't know if you want logs of action_logs or logs of browser?
> 
> I tested it with Firefox 41.0.1 and Chrome 45 and it's the same, i have an
> error in console like:
> Uncaught SynthaxError : Unexpected token   circulation.pl:180
> 
> Marjorie

I was asking for the Koha log file, on the server.
Could you confirm you don't get this error without the patch and that your pref
 IntranetUserJS is empty?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9097] 'Welcome mail' for new library users

2015-10-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9097

Fiona Borthwick  changed:

   What|Removed |Added

 CC||fiona.borthwick@ptfs-europe
   ||.com

--- Comment #3 from Fiona Borthwick  ---
One of our customers reported that they were not receiving these welcome email
messages either.  As it turns out they leave the username and password fields
blank and Koha generates them upon saving.

So in effect I suppose that this is a 2 stage registration too but it would be
nice if the email could be sent.  After all they want the username and password
generated automatically for a reason.

It also makes sense that an email is sent if username and password are
generated automatically as the borrower will need to know this information as
it is not entered manually.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14515] Add biblioitems table to notices in C4/Reserves.pm

2015-10-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14515

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #42979|0   |1
is obsolete||
  Attachment #43180|0   |1
is obsolete||

--- Comment #7 from Jonathan Druart  
---
Created attachment 43294
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43294&action=edit
Bug 14515: Add biblioitems to messages in C4/Reserves.pm

http://bugs.koha-community.org/show_bug.cgi?id=14515

Signed-off-by: Danielle Aloia 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14515] Add biblioitems table to notices in C4/Reserves.pm

2015-10-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14515

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14515] Add biblioitems table to notices in C4/Reserves.pm

2015-10-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14515

--- Comment #8 from Jonathan Druart  
---
Created attachment 43295
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43295&action=edit
Bug 14515 (QA Followup) fix letter.pl available fields.

Add bibliotiems to the 'available fields' list for
module 'Holds' (aka reserves).

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14966] Table header broken at detail.tt

2015-10-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14966

Jonathan Druart  changed:

   What|Removed |Added

 CC||ch...@bigballofwax.co.nz,
   ||l...@catalyst.net.nz

--- Comment #3 from Jonathan Druart  
---
This one fixes a regression on stable branches 3.20.x and 3.18.x and should be
backported on the next release.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14468] Remove warnings when creating Labels

2015-10-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14468

Theodoros Theodoropoulos  changed:

   What|Removed |Added

 CC||th...@lib.auth.gr

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves

2015-10-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544

--- Comment #170 from Marcel de Rooy  ---
Created attachment 43296
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43296&action=edit
Bug 14544: [QA Follow-up] Fix warning about transaction

When running Virtualshelves.t, you have this warning:
DBD::mysql::db begin_work failed: Already in a transaction at
/usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1339.

By moving the DBI lines after creating the TestBuilder object, the warning
will be gone.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13995] Proper Exception handling

2015-10-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13995

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl
   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=14544

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves

2015-10-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544

Marcel de Rooy  changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=13995

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13995] Proper Exception handling

2015-10-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13995

--- Comment #18 from Marcel de Rooy  ---
Bug 14544 also introduces a Koha::Exceptions module.
Has there been any interaction between the authors about the road to follow?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves

2015-10-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #171 from Marcel de Rooy  ---
QA Comment:
Great job !!! Lot of work involved.
Still have some points for consideration:

OPAC -- View contents of a list -- Send shelf - Crash
Can't call method "can_be_viewed" on an undefined value at
/home/koha/testclone/opac/opac-sendshelf.pl line 55.
*BLOCKER*

OPAC - View contents of a list - Sort by callnumber - Bang
DBIx::Class::ResultSet::next(): Unknown column 'itemcallnumber' in 'order
clause' at /home/koha/testclone/opac/opac-shelves.pl line 236
*BLOCKER*

OPAC - Lists- Open a shared list where you do not have permission to remove
items of someone else. Try to remove such an item. No success, but no warning
too! IIRC There was a warning in the past about some items not deleted..
Now try to remove a item you added yourself to that list while having
permission to remove your own entries. This does not work ! No items are
deleted, no message.
I am inclined to see this last point as a *BLOCKER* too.

OPAC - View list - Delete your own item while the perms are ADD or DDD. Should
not be possible. But the owner is able to now. This is change of behavior and
not consistent with the wording of those permissions "Do not allow anyone to
remove his own contributed entries" (including your own!). I would view it as a
sort of Readonly list
where you cannot accidentally delete your own items. (Note however that adding
is still possible.) 
I am inclined to see this last point as a *BLOCKER* too (but I may not be
completely neutral here :)
+# FIXME
+# This does not make sense, but it's has been backported
from DelFromShelf.
+# Why shouldn't we allow to remove his own contribution if
allow_delete_other is on?

Code Exceptions.pm module comes in now with a dependency Exception::Class.
The description => "poeut" still needs some attention apparently :) Not sure
what it means btw..
Although this looks good to me on itself, this dev should probably better have
gone on its own report. Note there is another report too (13995).
It kind of creeps in now.

OPAC - Share a list - Enter email address - Return to your lists: This list
does not exist ??  op=view && category=1. Adjust the URL? 

OPAC - I shared a list with AAD perms. The other user could add a few entries.
After that removed the share.
Now come back as owner of the list and try to remove one item of yourself and
one of the other user.
You will get the message: The item has been removed from the list. 
This is not completely true: You could only remove one item; the other is not
permitted. 

OPAC - Create a new list - Starts with permissions D D D - Would it not be
better to default to D A D ?
Note that if I create a list with save to new list, it does default to DAD. So
this is a minor inconsistency..

OPAC - View a list: For a list with ADD or DDD perms, the button Remove could
be hidden or disabled? Might be the case now too btw.

OPAC Detail - List(s) this item appears in: [nothing filled while expected] 
I click from view a (private) list on one entry. So go to opac detail. Should I
expect that list to be mentioned now? It is not.

Staff - View public lists [Related to another report]
With the delete public lists permission I can delete the public list of another
user. OK The staff user probably has a good reason to do so. 
Just noting that it would perhaps be more friendly to switch it to Private
instead of a rigourous Delete?

Code in opac-addbybiblionumber.pl: HandleSelectedShelf: Empty TODO in an else
branch. Noting for the record. 

Code  t/db_dependent/Utils/Datatables_Virtualshelves.t and
C4/Utils/DataTables/VirtualShelves.pm
This is only justified/used by svc/virtualshelves/search
Isn't this the time to move this svc script to Koha::Virtualshelves too ? Or at
least on another report ? 

Database design: Do we still need (or use) virtualshelfcontents.flags  ? Could
a dbrev remove it now?

An observation (which could be considered as outside the scope): Add an item to
the list with a barcode (in staff) is somewhat strange. You cannot add items,
only biblios. This is current situation already. Just for completeness :)

Moving the status to FQA now to reflect the need for some
adjustments/clarifications.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8483] Borrower reading history should include deleted items

2015-10-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8483

--- Comment #27 from Kyle M Hall  ---
With 540 checkouts I get the following with your script:

on master:
real0m1.023s
user0m0.980s
sys 0m0.044s

with bug 8483:
real0m1.032s
user0m0.980s
sys 0m0.052s

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13632] Use a translatable file instead of the database for managing permission descriptions

2015-10-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13632

Paul Poulain  changed:

   What|Removed |Added

 CC||paul.poul...@biblibre.com
   Severity|enhancement |normal

--- Comment #29 from Paul Poulain  ---
changing severity : this is a bug for non english Koha (and when you demo & try
to convince a library to choose Koha, this has a negative result)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14367] History for MARC records. Roll back changes on a timeline or per field.

2015-10-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14367

Martin Persson  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
 CC||xarra...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11250] "too many holds" message appears inappropriately

2015-10-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11250

Kyle M Hall  changed:

   What|Removed |Added

 CC||kyle.m.h...@gmail.com

--- Comment #12 from Kyle M Hall  ---
> There is a difference between none_available (but eventually some may) vs.
> comment #2's "{item} is not allowed to be placed on hold". Is there a way to
> check for this?

If I understand you correctly, the answer is no at this time. That would be
outside the scope of this bug.


> Similarly there is a minor difference between a borrower who has too many
> holds (non-zero), and one who isn't allowed to place any at all, as per my
> understanding of comment #1.

That is correct, and this patch deals with that situation. The patron will get
different messages if they exceed the maxreserves vs they can't place a hold on
any of the items.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14974] Use the REST API for cities

2015-10-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14974

--- Comment #7 from Kyle M Hall  ---
Thanks for your input Andrew! I'm sure any guidance and guidelines you may
suggest would be greatly appreciated!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14991] Reword, clarify and add consistency to authority search

2015-10-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14991

--- Comment #1 from Gaetan Boisson  ---
Created attachment 43297
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43297&action=edit
BUG 14991 Improve consistency of authority search

At the moment we can search authorities from two places: authorities-home.pl
and auth_finder.pl (while cataloguing).

The auth_finder.pl page offers searching specifically in the $a of the main
heading, while the authorities home page doesn't.

Additionally, the wording and order of the options is different.

authorities-home.pl has:
Search main heading
Search all headings
Keyword search

while auth_finder.pl has:
Main entry ($a only)
Main entry
Anywhere
Heading match

This patch will add some consistency so that both pages offer:
Search main heading ($a only)
Search main heading
Search all headings
Search entire record

Test plan:

- apply patch
- go to authorities home
- check that previous searches are still working
- check that the new ($a only) search is working
- go to auth finder (from cataloguing)
- check that searches are still working
- check that we do have the same wording in both pages and that forms are now
consistent

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14991] Reword, clarify and add consistency to authority search

2015-10-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14991

Gaetan Boisson  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13411] Koha's SIP server returns not ok for checking in items that are not checked out

2015-10-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411

Kyle M Hall  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

--- Comment #30 from Kyle M Hall  ---
(In reply to Colin Campbell from comment #29)
> having applied the patch against current master server terminates when
> processing an issue transaction

I have been unable to reproduce this on master. It seems unlikely to be related
to this patch since this patch only modifies the checkins, and not checkouts.
Can you please retest?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9129] Add the ability to set the maximum fine for an item to its replacement price

2015-10-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9129

Cindy Murdock Ames  changed:

   What|Removed |Added

  Attachment #43253|0   |1
is obsolete||

--- Comment #42 from Cindy Murdock Ames  ---
Created attachment 43298
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43298&action=edit
[SIGNED OFF] [patch] Bug 9129 - Add the ability to set the maximum fine for an
item to its replacement price

Patch applied without error and test plan produced expected result of a fine
equalling the replacement cost price.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9129] Add the ability to set the maximum fine for an item to its replacement price

2015-10-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9129

Cindy Murdock Ames  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9150] Add authorities search sorts by id and relevance

2015-10-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9150

Gaetan Boisson  changed:

   What|Removed |Added

 CC||gaetan.bois...@biblibre.com
Summary|Add authorities search sort |Add authorities search
   |by id   |sorts by id and relevance

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9150] Add authorities search sorts by id and relevance

2015-10-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9150

--- Comment #1 from Gaetan Boisson  ---
Sorting by id seems to be what the "none" choice for sorting does. It would be
practical to let the user choose this explicitly, and choose between older to
newer or newer to older. It would also be interesting to have a "relevance"
sorting option available, similar to what we have in bibliographic search.
Searching for "history" would then bring up the "History" record higher than
"European history".

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14992] New options and clarification for authority search modes dropdown

2015-10-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14992

Gaetan Boisson  changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |fridolin.som...@biblibre.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9150] Add authorities search sorts by id and relevance

2015-10-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9150

Gaetan Boisson  changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |fridolin.som...@biblibre.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14994] New: Add RSS/Atom feed proxy

2015-10-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14994

Bug ID: 14994
   Summary: Add RSS/Atom feed proxy
 Change sponsored?: ---
   Product: Koha
   Version: unspecified
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Web services
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: xarra...@gmail.com
QA Contact: testo...@bugs.koha-community.org

Some libraries uses a separate blog on an external site such as blogspot.com.
We are working on enhancements to make Koha a fully-featured blog in the
future, removing that need.

The external blogs publishes the content as RSS/Atom feeds which can then be
pulled to the OPAC via some Javascript and/or Yahoo Pipes. Pipes was recently
decomissioned and I am now trying to solve this issue. I do not have full
information yet.

At present I have created a small web proxy that pulls RSS/Atom from an
external source via LWP. This allows us to overcome the same-origin limitation.
There are security considerations for this that must be looked at.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14925] Remove C4::Dates from members/moremember.pl

2015-10-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14925

--- Comment #6 from Tomás Cohen Arazi  ---
Created attachment 43299
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43299&action=edit
Bug 14925: (QA followup) tidy code block

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14928] Remove C4::Dates from files acqui/pdfformat/layout*.pm

2015-10-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14928

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com
 Status|Passed QA   |Pushed to Master

--- Comment #6 from Tomás Cohen Arazi  ---
Patch pushed to master.

Thanks Marc!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14925] Remove C4::Dates from members/moremember.pl

2015-10-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14925

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com
 Status|Passed QA   |Pushed to Master

--- Comment #7 from Tomás Cohen Arazi  ---
Patch pushed to master.

Thanks Marc!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14926] Remove C4::Dates from members/printfeercpt.pl

2015-10-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14926

--- Comment #8 from Héctor Eduardo Castro Avalos  ---
(In reply to Jonathan Druart from comment #7)
> Please try again with the last patch, and don't forget to change your
> dateformat pref to something else than iso :)

Okidoki

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11298] Renewal due date won't take specified time into account

2015-10-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11298

--- Comment #11 from Marjorie Barry-Vila  ---
(In reply to Jonathan Druart from comment #10)
> (In reply to Marjorie Barry-Vila from comment #9)
> > (In reply to Jonathan Druart from comment #8)
> > > Could you check the log file?
> > > Looks good here.
> > 
> > Sorry Jonathan, I tested it again and it do not work.
> > 
> > I don't know if you want logs of action_logs or logs of browser?
> > 
> > I tested it with Firefox 41.0.1 and Chrome 45 and it's the same, i have an
> > error in console like:
> > Uncaught SynthaxError : Unexpected token   circulation.pl:180
> > 
> > Marjorie
> 
> I was asking for the Koha log file, on the server.
> Could you confirm you don't get this error without the patch and that your
> pref  IntranetUserJS is empty?

I don't know how see koha log file on the server, action_logs?
In my version 3.18.04, when I make a renewal, it works and I have no error in
console but hour of date is not considered.
Sorry.
Maybe someone else can test on a sandbox? The problem may come from me.

Regards,
Marjorie

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14954] Remove C4::Dates from holiday related files in folder tools

2015-10-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14954

Marc Véron  changed:

   What|Removed |Added

  Attachment #43098|0   |1
is obsolete||

--- Comment #2 from Marc Véron  ---
Created attachment 43300
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43300&action=edit
Bug 14954 - Remove C4::Dates from holiday related files in folder tools

This patch removes C4::Dates from:
Remove C4::Dates from:

- tools/exceptionHolidays.pl
- tools/holidays.pl
- tools/newHolidays.pl
- C4/Calendar.pm

To test:
- Go to Home > Tools > Calendar
- Add, edit, delete the different types of holidays and exceptions
- git grep 'C4::Calendar' and test such files
- prove t/Calendar.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14954] Remove C4::Dates from holiday related files in folder tools

2015-10-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14954

Marc Véron  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14926] Remove C4::Dates from members/printfeercpt.pl

2015-10-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14926

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

  Attachment #43290|0   |1
is obsolete||

--- Comment #9 from Héctor Eduardo Castro Avalos  ---
Created attachment 43301
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43301&action=edit
[SIGNED-OFF]Bug 14926: Format the date according to the dateformat syspref

Signed-off-by: Hector Castro 
Works as advertised. Tested with the three values from dateformat syspref

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14926] Remove C4::Dates from members/printfeercpt.pl

2015-10-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14926

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13805] Installer does not work under Plack

2015-10-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13805

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com

--- Comment #12 from Tomás Cohen Arazi  ---
This should be QAed please. It is not a blocker for 3.22 as the Plack
integration it introduces is at package-level, but worth having both in sync.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14931] Remove C4::Dates from files admin/aq*.pl

2015-10-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14931

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

  Attachment #42977|0   |1
is obsolete||

--- Comment #2 from Héctor Eduardo Castro Avalos  ---
Created attachment 43302
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43302&action=edit
[SIGNED-OFF]Bug 14931 - Remove C4::Dates from files admin/aq*.pl

This patch removes C4::Dates from:

- admin/aqbudgets.pl
- admin/aqplan.pl
- admin/aqcontract.pl

To test:

- Apply patch

- Go to Home > Adminstration > Budgets > All funds
  (admin/aqbudgets.pl)
- Verify that everything displays as before

- Edit one of the funds and click on 'Planning - Plan by months'
  (admin/aqplan.pl)
- Verify that planning works as before

- Go to Home > Acquisitions, search for an active vendor and view the vendor
- Click on 'Contracts' at the left
  (admin/aqcontract.pl)
- Create and edit contracts and verify that it works OK.
  (Note: there is no help for this page, see Bug 14929)

Signed-off-by: Hector Castro 
Works as advertised. Tested with dateformat syspref
Dates in planning by months not needed to be on iso format, aqplan.pl
uses instead Date::Calc

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14931] Remove C4::Dates from files admin/aq*.pl

2015-10-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14931

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

 CC||hector.hecax...@gmail.com
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14903] Remove C4::Dates from circ/circulation.pl

2015-10-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14903

Marc Véron  changed:

   What|Removed |Added

 Status|Needs Signoff   |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14903] Remove C4::Dates from circ/circulation.pl

2015-10-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14903

Marc Véron  changed:

   What|Removed |Added

  Attachment #42989|0   |1
is obsolete||

--- Comment #5 from Marc Véron  ---
Comment on attachment 42989
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42989
Bug 14903 - Remove C4::Dates from circ/circulation.pl

New patch will follow with C4/Dates.pm included.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14903] Remove C4::Dates from circ/circulation.pl

2015-10-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14903

--- Comment #6 from Marc Véron  ---
Created attachment 43303
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43303&action=edit
Bug 14903 - Remove C4::Dates from circ/circulation.pl (and more)

Patch to remove deprectated C4::Dates from:
- circ/circulation.pl
- C4/Circulation.pm
- koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt

To test:
- Apply patch
- Go to the checkout site (Home > Circulation > Checkouts)
- Verify that data displays properly (including for users with a card
  that expires in the  near future, see syspref 'NotifyBorrowerDeparture')
- Search for regressions
- prove -v t/db_dependent/Circulation.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14903] Remove C4::Dates from circ/circulation.pl

2015-10-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14903

Marc Véron  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13805] Installer does not work under Plack

2015-10-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13805

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Pushed for QA   |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13805] Installer does not work under Plack

2015-10-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13805

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Signed Off  |Pushed for QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14775] Plack::Middleware::ReverseProxy should not be required

2015-10-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14775

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Resolution|--- |WORKSFORME
 Status|Failed QA   |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7895] Add Plack/FastCGI/mod_perl server configuration and Zebra info to about

2015-10-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7895

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com
Version|3.8 |master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13805] Installer does not work under Plack

2015-10-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13805

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #13 from Tomás Cohen Arazi  ---
Patch pushed to master.

Thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12368] Rebuild Zebra improvement: allow to specify a DB table

2015-10-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12368

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #13 from Tomás Cohen Arazi  ---
Patches pushed to master.

Thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14292] Add --category and --skip-category options to longoverdue.pl to include or exclude borrower categories.

2015-10-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14292

Barton Chittenden  changed:

   What|Removed |Added

  Attachment #42614|0   |1
is obsolete||

--- Comment #9 from Barton Chittenden  ---
Created attachment 43304
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43304&action=edit
Bug 14292: Add patron category restrictions to longoverdue.pl

Add command line options --category and --skip-category

Convert usage() to pod2usage. (This was previous FIXME)

http://bugs.koha-community.org/show_bug.cgi?id=14292

Signed-off-by: hbr...@nekls.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14292] Add --category and --skip-category options to longoverdue.pl to include or exclude borrower categories.

2015-10-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14292

Barton Chittenden  changed:

   What|Removed |Added

  Attachment #42892|0   |1
is obsolete||

--- Comment #10 from Barton Chittenden  ---
Created attachment 43305
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43305&action=edit
Bug 14292: QA Follow-up

Make borrower category handling more user friendly:

Make --category and --skip-category mutally exclusive

Check that categories specified by --category
and --skip-category exist in categories table.

Add --list-categories opttion to show available
borrower categories.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11373] Add a "cash register" feature to the fine payment form.

2015-10-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11373

--- Comment #15 from M. Tompsett  ---
Comment on attachment 36875
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36875
Bug 11373: Add a "cash register" feature to the fine payment form.

Review of attachment 36875:
 --> 
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=11373&attachment=36875)
-

Changing the sign of what was there before would need something done during
upgrade to change it to a new way of processing. This wasn't done, so frankly,
I think the logic I highlighted is broken. Though, admittedly, I did not run
this code yet.

::: C4/Accounts.pm
@@ +722,5 @@
>  my $insert = 'INSERT INTO accountlines (borrowernumber, accountno, date, 
> amount, '
>  .  'description, accounttype, amountoutstanding, itemnumber, manager_id, 
> note) '
>  . ' VALUES (?, ?, now(), ?, ?, ?, 0, ?, ?, ?)';
>  
> +$dbh->do(  $insert, undef, $borrowernumber, $nextaccntno, $payment,

0-$amount is the negative of $amount. This is a vast change! Is this correct?

@@ +728,5 @@
>  
>  UpdateStats({
>  branch => $user,
>  type => 'payment',
> +amount => $payment,

This is 0-$amount which is the negative of what was put here before.

@@ +739,4 @@
>  action=> 'create_payment',
>  borrowernumber=> $user,
>  accountno => $nextaccntno,
> +amount=> $payment,

On a positive note, by putting $payment earlier, it can be used nicely here.

@@ +820,4 @@
>  UpdateStats({
>  branch => $branch,
>  type => 'writeoff',
> +amount => $payment,

Again, 0-$amount is negative of what was there before.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14993] rebuild_zebra.pl, when recreating Zebra-directory structure, mkdir doesn't fail/error/die

2015-10-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14993

--- Comment #2 from M. Tompsett  ---
Comment on attachment 43293
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43293
Bug 14993 - rebuild_zebra.pl, when recreating Zebra-directory structure, mkdir
doesn't fail/error/die

Review of attachment 43293:
 --> 
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=14993&attachment=43293)
-

::: misc/migration_tools/rebuild_zebra.pl
@@ -305,4 @@
>  my $bdir = $base . $dir;
>  if (! -d $bdir) {
>  $needed_repairing = 1;
> -mkdir $bdir || die "Unable to create '$bdir': $!\n";

oh my! What a nasty glob'ing issue. Thanks for this fix.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14903] Remove C4::Dates from circ/circulation.pl

2015-10-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14903

Marc Véron  changed:

   What|Removed |Added

 CC||koha.sek...@gmail.com

--- Comment #7 from Marc Véron  ---
*** Bug 7899 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14870] Delete C4/Dates.pm from System

2015-10-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870

Marc Véron  changed:

   What|Removed |Added

 Depends on|7899|


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7899
[Bug 7899] Remove C4::Dates from C4::Circulation
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy

2015-10-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072

Marc Véron  changed:

   What|Removed |Added

   See Also|http://bugs.koha-community. |
   |org/bugzilla3/show_bug.cgi? |
   |id=7899 |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7899] Remove C4::Dates from C4::Circulation

2015-10-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7899

Marc Véron  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
   See Also|http://bugs.koha-community. |
   |org/bugzilla3/show_bug.cgi? |
   |id=12072,   |
   |http://bugs.koha-community. |
   |org/bugzilla3/show_bug.cgi? |
   |id=13813|
 Blocks|14870   |
 Resolution|--- |DUPLICATE

--- Comment #1 from Marc Véron  ---
Bug 14903 removes deprectated C4::Dates from
- circ/circulation.pl
- C4/Circulation.pm
- koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt

*** This bug has been marked as a duplicate of bug 14903 ***


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870
[Bug 14870] Delete C4/Dates.pm from System
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13813] Remove deprecated module C4::Dates from system

2015-10-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13813

Marc Véron  changed:

   What|Removed |Added

   See Also|http://bugs.koha-community. |
   |org/bugzilla3/show_bug.cgi? |
   |id=7899 |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14995] New: Remove C4::Dates: Delete files reservereport.pl / reservereport.tt

2015-10-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14995

Bug ID: 14995
   Summary: Remove C4::Dates: Delete files reservereport.pl /
reservereport.tt
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: gmcha...@gmail.com
  Reporter: ve...@veron.ch
QA Contact: testo...@bugs.koha-community.org

The following files use C4::Dates, but they seem no longer to be in use:

- koha-tmpl/intranet-tmpl/prog/en/modules/reports/reservereport.tt
- reports/reservereport.pl

To verify, git grep 'reservereport'.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14995] Remove C4::Dates: Delete files reservereport.pl / reservereport.tt

2015-10-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14995

--- Comment #1 from Marc Véron  ---
Created attachment 43306
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43306&action=edit
Bug 14995 - Remove C4::Dates: Delete files reservereport.pl / reservereport.tt

The following files use C4::Dates, but they seem no longer to be in use:

- koha-tmpl/intranet-tmpl/prog/en/modules/reports/reservereport.tt
- reports/reservereport.pl

To verify: git grep 'reservereport'

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14870] Delete C4/Dates.pm from System

2015-10-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870

Marc Véron  changed:

   What|Removed |Added

 Depends on||14995


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14995
[Bug 14995] Remove C4::Dates: Delete files reservereport.pl / reservereport.tt
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14995] Remove C4::Dates: Delete files reservereport.pl / reservereport.tt

2015-10-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14995

Marc Véron  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
   Assignee|gmcha...@gmail.com  |ve...@veron.ch
 Blocks||14870
 Status|NEW |Needs Signoff


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870
[Bug 14870] Delete C4/Dates.pm from System
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14653] Acq planning filter and export always use default active period

2015-10-09 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14653

--- Comment #3 from Héctor Eduardo Castro Avalos  ---
Created attachment 43307
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43307&action=edit
[SIGNED-OFF]Bug 14653 - Acq planning export always use default active period

In Acq planning /cgi-bin/koha/admin/aqplan.pl, left side filter and export
forms have no parameter budget_period_id nor authcat, so the use the default
active period.
As said in code
- IF PERIOD_ID IS DEFINED,  GET THE PERIOD - ELSE GET THE ACTIVE PERIOD BY
DEFAULT
my $period = GetBudgetPeriod($budget_period_id);

This patch corrects the export form.

Test plan :
- Create an active budget "B_ACTIVE" with 1 fund
- Create an inactive budget "B_OLD" with 3 funds
- Go to "B_OLD" planning by libraries
- You see 3 funds
- Click on "Submit" in export form
=> Without patch, you get the planning of "B_ACTIVE" with 1 fund
=> Without patch, you get the planning of "B_OLD" with 3 funds by libraries

Signed-off-by: Hector Castro 
Works as advertised

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

  1   2   >