[Koha-bugs] [Bug 11559] Professional cataloger's interface

2015-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559

--- Comment #144 from Jesse Weaver  ---
I've pushed a major update that I think should fix most outstanding issues.

Specific things that weren't fixed:
  * Search results: because the search screen allows on-the-fly resorting, it
can only fetch so many records and be reasonably performant. The current cap is
100 records per server.
  * Favicon: I have literally no idea what's going on with this. It only seems
to display correctly after a forced reload (Ctrl-Shift-R). Rancor isn't doing
anything differently of note.

Also, there's finally proper documentation for the macro language:
http://wiki.koha-community.org/wiki/Rancor_Macro_Language

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11559] Professional cataloger's interface

2015-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559

--- Comment #143 from Jesse Weaver  ---
Created attachment 43547
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43547&action=edit
Bug 11559: (QA followup) switch to new delimiter, fix minor issues

This followup introduces a major change; instead of subfields starting
with '$', they now start with '‡'. The double-cross
character can be typed with Ctrl-D.

It also fixes the following:
  * Add UUID.pm dependency
  * Remove debugging call
  * Fix toLocaleFormat error reported by Nick Clemens
  * Ignore subfields that are marked as unrepeatable/mandatory AND
ignored (tab is -1)
  * Mention lack of support for UNIMARC/NORMARC fixed fields in system
preferences screen
  * Confirm when user creates new record and current record is modified
  * Perform better when importing gigantic record dump
  * Show "Edit" instead of "Import" and allow direct editing for local
catalog records in search screen
  * Add "Keyboard shortcuts" help button to toolbar

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata

2015-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642

--- Comment #85 from Héctor Eduardo Castro Avalos  
---
(In reply to Tomás Cohen Arazi from comment #84)
> I liked the Koha::Crosswalk::DublinCore package name. Can we keep it? :-D

Yes, Mr. Tomás

Tomorrow morning i'll make the changes.

Regards

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata

2015-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com

--- Comment #84 from Tomás Cohen Arazi  ---
I liked the Koha::Crosswalk::DublinCore package name. Can we keep it? :-D

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12768] Replacement cost and processing fee management

2015-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12768

Charles Farmer  changed:

   What|Removed |Added

 Status|Needs Signoff   |In Discussion

--- Comment #45 from Charles Farmer  ---
(In reply to Jonathan Druart from comment #38)
> It does not seem to work if item-level_itypes  is set to biblio.
> You should also provide tests for C4::Circulation::LostItem (I suspect that
> the problem comes from the query executed in this subroutine).

When you say "provide tests for LostItem", do you mean that a separate file
should be written under t/db_dependent/Circulation/ for that purpose, or would
you accept if the tests were added to everything else in Circulation.t ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12768] Replacement cost and processing fee management

2015-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12768

Charles Farmer  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12768] Replacement cost and processing fee management

2015-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12768

--- Comment #44 from Charles Farmer  ---
Created attachment 43546
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43546&action=edit
Bug 12768: Fixed tests 44 and 45 of t/db_dependant/Circulation.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata

2015-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642

--- Comment #83 from Héctor Eduardo Castro Avalos  
---
(In reply to Jonathan Druart from comment #81)
> No need to ask for a signoff for the tests.

Hi Jonathan

Unit test added for Koha::DublinCore

Regards

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata

2015-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata

2015-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642

--- Comment #82 from Héctor Eduardo Castro Avalos  
---
Created attachment 43545
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43545&action=edit
Bug 13642 - Unit Test for Koha::DublinCore.pm

To test
-Apply patches
-prove t/db_dependent/DublinCore.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14377] Indicate that a record is suppressed in staff client

2015-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14377

Karl Holten  changed:

   What|Removed |Added

 CC||khol...@switchinc.org

--- Comment #19 from Karl Holten  ---
Hi, we're the institution that requested the bibnumber show up. Our staff do a
lot of searching but standard numbers such as the bib record number, OCLC
number, barcode, ISSN. It's a more direct way to search in Koha which tends to
be very keyword heavy. Staff want to get fewer results, not more or even
multiple. Seeing the record number also helps identify it quickly versus the
title which can be more generic and/or be one of other similar titles. Anyway,
that's the reason we made that request.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14870] Delete C4/Dates.pm from System

2015-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870

Marc Véron  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14063] Implement language overlay for authorised values

2015-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14063

Marc Véron  changed:

   What|Removed |Added

 Status|In Discussion   |RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #11 from Marc Véron  ---


*** This bug has been marked as a duplicate of bug 14100 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14100] Generic solution for language overlay

2015-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14100

--- Comment #43 from Marc Véron  ---
*** Bug 14063 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 9026] Reject/approve a tag *one time* / (batch) edit tags

2015-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9026

Marjorie Barry-Vila  changed:

   What|Removed |Added

 CC||marjorie.barry-v...@ccsr.qc
   ||.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14131] Patroncard: Add possibility to print from patron lists

2015-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14131

Marc Véron  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14131] Patroncard: Add possibility to print from patron lists

2015-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14131

Marc Véron  changed:

   What|Removed |Added

  Attachment #43415|0   |1
is obsolete||

--- Comment #19 from Marc Véron  ---
Created attachment 43544
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43544&action=edit
Bug 14131 - Adding print patron cards to patron lists home page

To test:

Go to /cgi-bin/koha/patron-lists/lists.pl
Make a patron list
Click "Print patron cards"
Success: you get a pdf of cards to print.
Failure: you can't get a pdf of cards to print.

Note that you'll need to have a card layout, template, and printer profile
defined. The defaults should work.

Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14131] Patroncard: Add possibility to print from patron lists

2015-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14131

Marc Véron  changed:

   What|Removed |Added

  Attachment #42821|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14911] Serial Subscr. and Item search: Display additional 245 subfields in search results

2015-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14911

Marjorie Barry-Vila  changed:

   What|Removed |Added

 CC||marjorie.barry-v...@ccsr.qc
   ||.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14247] System preference for news author display

2015-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14247

Marc Véron  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14247] System preference for news author display

2015-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14247

Marc Véron  changed:

   What|Removed |Added

  Attachment #43541|0   |1
is obsolete||

--- Comment #22 from Marc Véron  ---
Comment on attachment 43541
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43541
Bug 14247: Add system preference for news display

Obsoleted because the same content is in second patch. 

@ Martin, can you please verify / confirm that the signed-off patches are the
correct ones?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14247] System preference for news author display

2015-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14247

Marc Véron  changed:

   What|Removed |Added

  Attachment #39527|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14645] Koha::RecordProcessor should deal with Koha::MetadataRecord objects

2015-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14645

Andreas Hedström Mace  changed:

   What|Removed |Added

 CC||andreas.hedstrom.mace@sub.s
   ||u.se

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15025] New: Regression: "print summary" does not display fines

2015-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15025

Bug ID: 15025
   Summary: Regression: "print summary" does not display fines
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Circulation
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: bar...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

Possibly a similar issue to bug 12971.

Patrons' fines should show on "print summary" (i.e. members/summary-print.pl),
and their outstanding balance should show in the "Total Due" row. No fines
show, and "Total Due" is always 0.

To replicate:

Find a patron who has unpaid fines, go to their patron detail page
(moremember.pl).

Click on the 'Print' button and choose 'Print Summary'

This *should* display the outstanding fines, and the total due; no fines
display, and the total due shows as 0.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14247] System preference for news author display

2015-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14247

--- Comment #21 from Marc Véron  ---
Created attachment 43543
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43543&action=edit
Bug 14247: Rename sysprefs atomic update file

This trivial patch changes the name of the SQL update
file to match the guidelines on the wiki.

Sponsored-by: Halland County Library
Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14247] System preference for news author display

2015-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14247

Marc Véron  changed:

   What|Removed |Added

  Attachment #39488|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14247] System preference for news author display

2015-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14247

--- Comment #20 from Marc Véron  ---
Created attachment 43542
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43542&action=edit
Bug 14247:  Add system preference for news display

Test plan:

* Apply dependant patch 14246 (if not done already).
* Apply current patch.
* Log into the Staff client, go to 'Administration' -> 'Global Preferences' ->
'Tools', a new section titled 'News' should appear with a single option named
'NewsAuthorDisplay'. Available values should be 'Not at all', 'OPAC only',
'Staff client only' and 'Both OPAC and staff client'. By default the value
should be 'Not at all' (to mimic existing behaviour, important!).
* Change the value to something different and save the changes.
* Use the mysql command line client to connect to the Koha database:
  $ mysql -u kohaadmin -p -D koha
* Enter the following query:
  SELECT * FROM systempreferences WHERE variable = 'NewsAuthorDisplay';
* Check to make sure that the 'value' column has changed to reflect the choice
you made in the above step.

Separate SQL testing (clean installation of Koha):
* Koha$ mysql -u root < create_koha_test_db.sql
* Koha$ mysql -u koha_test -D koha_test <
installer/data/mysql/kohastructure.sql
* Koha$ mysql -u koha_test -D koha_test < installer/data/mysql/sysprefs.sql

Testing the update script works the same way:
* Koha$ echo "DELETE FROM systempreferences WHERE variable =
'NewsAuthorDisplay';" | mysql -u koha_test -D koha_test
* Koha$ mysql -u koha_test -D koha_test <
installer/data/mysql/atomicupdate/add_news_prefs.sql

Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14247] System preference for news author display

2015-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14247

Marc Véron  changed:

   What|Removed |Added

  Attachment #43540|0   |1
is obsolete||

--- Comment #19 from Marc Véron  ---
Created attachment 43541
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43541&action=edit
Bug 14247: Add system preference for news display

Test plan:

* Apply dependant patch 14246 (if not done already).
* Apply current patch.
* Log into the Staff client, go to 'Administration' -> 'Global Preferences' ->
'Tools', a new section titled 'News' should appear with a single option named
'NewsAuthorDisplay'. Available values should be 'Not at all', 'OPAC only',
'Staff client only' and 'Both OPAC and staff client'. By default the value
should be 'Not at all' (to mimic existing behaviour, important!).
* Change the value to something different and save the changes.
* Use the mysql command line client to connect to the Koha database:
  $ mysql -u kohaadmin -p -D koha
* Enter the following query:
  SELECT * FROM systempreferences WHERE variable = 'NewsAuthorDisplay';
* Check to make sure that the 'value' column has changed to reflect the choice
you made in the above step.

Separate SQL testing (clean installation of Koha):
* Koha$ mysql -u root < create_koha_test_db.sql
* Koha$ mysql -u koha_test -D koha_test <
installer/data/mysql/kohastructure.sql
* Koha$ mysql -u koha_test -D koha_test < installer/data/mysql/sysprefs.sql

Testing the update script works the same way:
* Koha$ echo "DELETE FROM systempreferences WHERE variable =
'NewsAuthorDisplay';" | mysql -u koha_test -D koha_test
* Koha$ mysql -u koha_test -D koha_test <
installer/data/mysql/atomicupdate/add_news_prefs.sql

Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14247] System preference for news author display

2015-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14247

Marc Véron  changed:

   What|Removed |Added

  Attachment #43538|0   |1
is obsolete||

--- Comment #18 from Marc Véron  ---
Created attachment 43540
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43540&action=edit
Bug 14247: Add system preference for news display

Test plan:

* Apply dependant patch 14246 (if not done already).
* Apply current patch.
* Log into the Staff client, go to 'Administration' -> 'Global Preferences' ->
'Tools', a new section titled 'News' should appear with a single option named
'NewsAuthorDisplay'. Available values should be 'Not at all', 'OPAC only',
'Staff client only' and 'Both OPAC and staff client'. By default the value
should be 'Not at all' (to mimic existing behaviour, important!).
* Change the value to something different and save the changes.
* Use the mysql command line client to connect to the Koha database:
  $ mysql -u kohaadmin -p -D koha
* Enter the following query:
  SELECT * FROM systempreferences WHERE variable = 'NewsAuthorDisplay';
* Check to make sure that the 'value' column has changed to reflect the choice
you made in the above step.

Separate SQL testing (clean installation of Koha):
* Koha$ mysql -u root < create_koha_test_db.sql
* Koha$ mysql -u koha_test -D koha_test <
installer/data/mysql/kohastructure.sql
* Koha$ mysql -u koha_test -D koha_test < installer/data/mysql/sysprefs.sql

Testing the update script works the same way:
* Koha$ echo "DELETE FROM systempreferences WHERE variable =
'NewsAuthorDisplay';" | mysql -u koha_test -D koha_test
* Koha$ mysql -u koha_test -D koha_test <
installer/data/mysql/atomicupdate/add_news_prefs.sql

Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14247] System preference for news author display

2015-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14247

Marc Véron  changed:

   What|Removed |Added

  Attachment #43539|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14247] System preference for news author display

2015-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14247

--- Comment #17 from Marc Véron  ---
Created attachment 43539
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43539&action=edit
Bug 14246: Update NewsChannel tests

This commit adds the new 'borrowernumber' field to the existing
test framework to make it pass. It does not include new tests.

Sponsored-by: Halland County Library

Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14247] System preference for news author display

2015-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14247

Marc Véron  changed:

   What|Removed |Added

  Attachment #43093|0   |1
is obsolete||

--- Comment #16 from Marc Véron  ---
Created attachment 43538
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43538&action=edit
Bug 14247: Add system preference for news display

Added default value for system preference.

Test plan:

* Apply dependant patch 14246 (if not done already).
* Apply current patch.
* Log into the Staff client, go to 'Administration' -> 'Global Preferences' ->
'Tools', a new section titled 'News' should appear with a single option named
'NewsAuthorDisplay'. Available values should be 'Not at all', 'OPAC only',
'Staff client only' and 'Both OPAC and staff client'. By default the value
should be 'Not at all' (to mimic existing behaviour, important!).
* Change the value to something different and save the changes.
* Use the mysql command line client to connect to the Koha database:
  $ mysql -u kohaadmin -p -D koha
* Enter the following query:
  SELECT * FROM systempreferences WHERE variable = 'NewsAuthorDisplay';
* Check to make sure that the 'value' column has changed to reflect the choice
you made in the above step.

Separate SQL testing (clean installation of Koha):
* Koha$ mysql -u root < create_koha_test_db.sql
* Koha$ mysql -u koha_test -D koha_test <
installer/data/mysql/kohastructure.sql
* Koha$ mysql -u koha_test -D koha_test < installer/data/mysql/sysprefs.sql

Testing the update script works the same way:
* Koha$ echo "DELETE FROM systempreferences WHERE variable =
'NewsAuthorDisplay';" | mysql -u koha_test -D koha_test
* Koha$ mysql -u koha_test -D koha_test <
installer/data/mysql/atomicupdate/add_news_prefs.sql

Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14934] Add the barcode number in the description of all account lines both in the "Account" tab as in "Pay fines" tab.

2015-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14934

Marjorie Barry-Vila  changed:

   What|Removed |Added

 CC||marjorie.barry-v...@ccsr.qc
   ||.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15005] (Plack) Use of SCRIPT_NAME makes Koha generate wrong URIs

2015-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15005

--- Comment #23 from Kyle M Hall  ---
Created attachment 43535
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43535&action=edit
[PASSED QA] Bug 15005: Remove CGI->url calls from pl scripts

Same as previous patch for calls in pl scripts.

Test plan:
- delete an entry of your search history from intranet and opac
- with IndependentBranches=OFF, go on the waiting holds and confirm that the
link next to 'Holds awaiting pickup for your library on' is correct.
- search for items, the pagination should work correctly

Signed-off-by: Josef Moravec 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15005] (Plack) Use of SCRIPT_NAME makes Koha generate wrong URIs

2015-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15005

--- Comment #24 from Kyle M Hall  ---
Created attachment 43536
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43536&action=edit
[PASSED QA] Bug 15005: Fix pagination_bar calls

Test plan:
Create an order for an existing biblio, confirm that the pagination links work
correctly.

Signed-off-by: Josef Moravec 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15005] (Plack) Use of SCRIPT_NAME makes Koha generate wrong URIs

2015-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15005

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #43452|0   |1
is obsolete||
  Attachment #43453|0   |1
is obsolete||
  Attachment #43454|0   |1
is obsolete||
  Attachment #43484|0   |1
is obsolete||

--- Comment #22 from Kyle M Hall  ---
Created attachment 43534
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43534&action=edit
[PASSED QA] Bug 15005: Replace CGI->url with the corresponding url

CGI->url does not return the correct url on install using packages.

Test plan:
1/ Try to reproduce the bug from the description of bug 15005.
You should be able to login to the intranet and the OPAC
2/ Send a basket and a list from the intranet and the OPAC.

Signed-off-by: Josef Moravec 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15005] (Plack) Use of SCRIPT_NAME makes Koha generate wrong URIs

2015-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15005

Kyle M Hall  changed:

   What|Removed |Added

 CC||kyle.m.h...@gmail.com

--- Comment #26 from Kyle M Hall  ---
Note: SCRIPT_NAME is referenced in a number of templates and a few perl
scripts. In some cases it is passed to the template as a parameter. In others
it is not, which makes the form action submit to the current url. As far as I'm
aware this works fine and is non-detrimental, but I did want to make a note of
it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15005] (Plack) Use of SCRIPT_NAME makes Koha generate wrong URIs

2015-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15005

--- Comment #25 from Kyle M Hall  ---
Created attachment 43537
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43537&action=edit
[PASSED QA] Bug 15005: Replace $ENV{SCRIPT_NAME} with the hardcoded script
paths

Since I don't manage to make SCRIPT_NAME works directly with RequestHeader
and/or
ReverseProxyPath, the easier way it to fix all the different occurrences.

Test plan:
On the import patrons page, confirm that the "Import" button does not redirect
to a 'Not found' page.
You should stay on the import patrons page.

Note that if this change works, all others should work too.
Have a look at the diff of this patch and confirm there is no typo.

Signed-off-by: Josef Moravec 

Tested in patron import and item batch modification

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15005] (Plack) Use of SCRIPT_NAME makes Koha generate wrong URIs

2015-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15005

Kyle M Hall  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14504] Add command-line script to batch delete items based on lost/withdrawn statuses

2015-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14504

Barton Chittenden  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14504] Add command-line script to batch delete items based on lost/withdrawn statuses

2015-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14504

Barton Chittenden  changed:

   What|Removed |Added

  Attachment #43445|0   |1
is obsolete||

--- Comment #8 from Barton Chittenden  ---
Created attachment 43533
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43533&action=edit
Bug 14504 [QA Follow-up]

* Fix POD warning.
* Remove redundant 'use stric' and 'use warnings'
* Remove $VERSION and --version option.
* Remove --dry-run option
* Split test for --help and check for @criteria into two separate pod2usage
calls,
enabling -msg on the latter.
* Fix 'target_tiems' typo.
* Test for holds on items to be deleted.
* Fix whitespace
* Fix test for holds.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 5655] printing of fines should support more than one line

2015-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5655

--- Comment #2 from bondiurbano  ---
Nicole,

Please look at bugs #12769 and #12770. There's a discussion about issues that I
think have some contact points with your/my requirement.

By the way, I've opened bug #14934. Perhaps it may be included here...

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13632] Use a translatable file instead of the database for managing permission descriptions

2015-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13632

--- Comment #33 from Kyle M Hall  ---
Created attachment 43531
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43531&action=edit
[SIGNED-OFF] Bug 13632: Populate user_flags and permissions tables in the web
installer

Move the 2 specific 'en' files outside of the language directory.

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13632] Use a translatable file instead of the database for managing permission descriptions

2015-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13632

--- Comment #34 from Kyle M Hall  ---
Created attachment 43532
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43532&action=edit
[SIGNED-OFF] Bug 13632: Remove specific files

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13632] Use a translatable file instead of the database for managing permission descriptions

2015-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13632

--- Comment #32 from Kyle M Hall  ---
Created attachment 43530
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43530&action=edit
[SIGNED-OFF] Bug 13632: Do not use userflags.flagdesc and
permissions.description

These 2 fields are not used anymore, but we want to keep them anyway.

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13632] Use a translatable file instead of the database for managing permission descriptions

2015-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13632

--- Comment #31 from Kyle M Hall  ---
Created attachment 43529
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43529&action=edit
[SIGNED-OFF] Bug 13632: Use an include file to display permissions

This patch set moves the permissions' descriptions to the po files
instead of having them in the DB.

Test plan:
0/ Apply all patches
1/ Create a new installation
2/ Confirm the userflags and permissions tables are correctly populated
3/ Update the po file for a translated language
4/ Confirm you are able to translate the permissions descriptions
5/ Install the template files for this language
6/ Switch the interface to use this language and confirm the string are
correctly translated.

QA Note: At this point we could remove the userflags.flagdesc and
permissions.description DB fields, but I would prefer to keep them:
developers will know what the permission do without the need to go and
see the include file (we have it in the sql files and so, in the DB).

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13632] Use a translatable file instead of the database for managing permission descriptions

2015-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13632

Kyle M Hall  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13632] Use a translatable file instead of the database for managing permission descriptions

2015-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13632

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #42756|0   |1
is obsolete||
  Attachment #42757|0   |1
is obsolete||
  Attachment #42758|0   |1
is obsolete||
  Attachment #42759|0   |1
is obsolete||
  Attachment #42760|0   |1
is obsolete||

--- Comment #30 from Kyle M Hall  ---
Created attachment 43528
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43528&action=edit
[DO NOT PUSH] [SIGNED-OFF] Script to generate the permissions include file

perl build_permissions_file.pl >
koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc

http://bugs.koha-community.org/show_bug.cgi?id=13632

Signed-off-by: Kyle M Hall 

http://bugs.koha-community.org/show_bug.cgi?id=13622

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8417] date acquired is shipping date

2015-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8417

Kyle M Hall  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8417] date acquired is shipping date

2015-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8417

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #42772|0   |1
is obsolete||

--- Comment #12 from Kyle M Hall  ---
Created attachment 43527
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43527&action=edit
[PASSED QA] Bug 8417: Make the order receive date editable

Currently the date of the order reception is the date of shipping date,
which is wrong.
This patch makes this date editable (with default is today).

Test plan:
1/ Create an order and receive it
2/ Confirm that you can edit the reception date and it's take into
account as the datereceived.

Signed-off-by: Aleisha 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14310] Add ability to suspend and resume individual holds from the patron holds table

2015-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14310

Kyle M Hall  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14310] Add ability to suspend and resume individual holds from the patron holds table

2015-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14310

--- Comment #13 from Kyle M Hall  ---
Created attachment 43526
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43526&action=edit
Bug 14310 [QA Followup] - Add unit tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14310] Add ability to suspend and resume individual holds from the patron holds table

2015-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14310

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #40034|0   |1
is obsolete||

--- Comment #12 from Kyle M Hall  ---
Created attachment 43525
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43525&action=edit
Bug 14310 - Suspend and resume indvidual holds from patron holds table

This enhancment adds the ability to suspend and resume individual holds
from the holds table on circulation.pl and moremember.pl.

The interface is inspired/cribbed from the same feature already
available in the opac.

Test Plan:
1) Apply this patch
2) Find a patron with holds
3) Suspend a hold with no resume date
4) Resume the suspended hold
5) Suspend a hold with a resume date
6) Resume the suspended hold

Signed-off-by: Kyle M Hall 

Signed-off-by: Cathi Wiggins 

Signed-off-by: Megan Wianecki 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13624] Remove columns branchcode, categorytype from table overduerules_transport_types

2015-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624

--- Comment #35 from Charles Farmer  ---
Created attachment 43524
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43524&action=edit
Bug 13624 - renaming atomicupdate from .pl to .perl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13624] Remove columns branchcode, categorytype from table overduerules_transport_types

2015-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624

Charles Farmer  changed:

   What|Removed |Added

 Status|In Discussion   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13624] Remove columns branchcode, categorytype from table overduerules_transport_types

2015-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13624

Charles Farmer  changed:

   What|Removed |Added

 Status|Signed Off  |In Discussion

--- Comment #34 from Charles Farmer  ---
(In reply to Jonathan Druart from comment #33)

To better make progress, I would need to know precisely what you mean by "QA
concerns". After reading this thread through and through and opening the most
recent patches, I think the only concern that wasn't explicitly addressed,
about the UNIQUE key, was covered by the patch.

Also, prove was run against t/db_dependant/Overdues.t without errors.

There is, however, one odd thing: atomicupdates are only considered by
updatedatabase.pl if the file extension is .perl or .sql, not .pl. I'll follow
up this post with a new patch that fixes this problem.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13016] Add fine grace period by hour

2015-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13016

--- Comment #2 from Marjorie Barry-Vila  ---
(In reply to Kyle M Hall from comment #1)
> Grace periods for hourly checkouts are in hours. The column is just labeled
> wrong.

Hi Kyle,
Thank you for your response.
Do you mean that if hour is selected in Unit, grace period will be in hour?

Regards,

Marjorie

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user

2015-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918

Kyle M Hall  changed:

   What|Removed |Added

 Blocks||14310


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14310
[Bug 14310] Add ability to suspend and resume individual holds from the patron
holds table
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14310] Add ability to suspend and resume individual holds from the patron holds table

2015-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14310

Kyle M Hall  changed:

   What|Removed |Added

 CC||kyle.m.h...@gmail.com
 Depends on||13918


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918
[Bug 13918] Add waiting expiration date to opac list of holds for user
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet

2015-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933

--- Comment #52 from Kyle M Hall  ---
(In reply to Jonathan Druart from comment #41)
> There is something wrong in the second patch:
> 
> installer/data/mysql/updatedatabase.pl | 1157
> +---

Fixed!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet

2015-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933

--- Comment #51 from Kyle M Hall  ---
Created attachment 43523
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43523&action=edit
Bug 12933 [QA Followup] - Rename GetOverdues to GetOverduesForPatron

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet

2015-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933

--- Comment #49 from Kyle M Hall  ---
Created attachment 43521
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43521&action=edit
Bug 12933 [QA Followup] - Rename parse_letter to parse_overdues_letter

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet

2015-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #43514|0   |1
is obsolete||
  Attachment #43515|0   |1
is obsolete||
  Attachment #43516|0   |1
is obsolete||
  Attachment #43517|0   |1
is obsolete||
  Attachment #43518|0   |1
is obsolete||

--- Comment #47 from Kyle M Hall  ---
Created attachment 43519
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43519&action=edit
Bug 12933 - Add ability to print overdue slip from staff intranet

Some librarians would like to be able to print an overdues slip from the
staff intranet. This slip would be defined as the print transport
version of the ODUE slip.

Test Plan:
1) Apply this patch
2) Locate a patron with overdues
3) Define a print version of the OVERDUES_SLIP slip
4) Try Print > Print overdues

Signed-off-by: Amy Purvis 
Signed-off-by: Laurie McKee 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet

2015-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933

--- Comment #48 from Kyle M Hall  ---
Created attachment 43520
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43520&action=edit
Bug 12933 - Add new OVERDUES_SLIP letter

Signed-off-by: Amy Purvis 
Signed-off-by: Laurie McKee 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet

2015-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933

--- Comment #50 from Kyle M Hall  ---
Created attachment 43522
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43522&action=edit
Bug 12933 [QA Followup] - Add Unit Tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet

2015-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933

--- Comment #46 from Kyle M Hall  ---
Created attachment 43518
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43518&action=edit
Bug 12933 [QA Followup] - Rename GetOverdues to GetOverduesForPatron

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet

2015-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933

--- Comment #45 from Kyle M Hall  ---
Created attachment 43517
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43517&action=edit
Bug 12933 [QA Followup] - Add Unit Tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet

2015-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933

--- Comment #44 from Kyle M Hall  ---
Created attachment 43516
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43516&action=edit
Bug 12933 [QA Followup] - Rename parse_letter to parse_overdues_letter

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet

2015-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933

--- Comment #43 from Kyle M Hall  ---
Created attachment 43515
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43515&action=edit
Bug 12933 - Add new OVERDUES_SLIP letter

Signed-off-by: Amy Purvis 
Signed-off-by: Laurie McKee 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet

2015-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #41606|0   |1
is obsolete||
  Attachment #41607|0   |1
is obsolete||
  Attachment #41608|0   |1
is obsolete||
  Attachment #41609|0   |1
is obsolete||
  Attachment #41610|0   |1
is obsolete||

--- Comment #42 from Kyle M Hall  ---
Created attachment 43514
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43514&action=edit
Bug 12933 - Add ability to print overdue slip from staff intranet

Some librarians would like to be able to print an overdues slip from the
staff intranet. This slip would be defined as the print transport
version of the ODUE slip.

Test Plan:
1) Apply this patch
2) Locate a patron with overdues
3) Define a print version of the OVERDUES_SLIP slip
4) Try Print > Print overdues

Signed-off-by: Amy Purvis 
Signed-off-by: Laurie McKee 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet

2015-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933

Kyle M Hall  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14694] Make decreaseloanHighHolds more flexible

2015-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14694

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #43153|0   |1
is obsolete||

--- Comment #7 from Kyle M Hall  ---
Created attachment 43513
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43513&action=edit
Bug 14694 - Make decreaseloanHighHolds more flexible

This patch allows for more flexibility for determining when the number
of holds a record has should trigger the reduction of the loan length
for items on that record.

This patch adds a new system preference decreaseLoanHighHoldsControl,
which defaults to 'static', the original behavior of the feature.
It also has a new behavior 'dynamic' which makes the feature only
decrease the loan length if the number of holds on the record exceeds
the number of holdable items + decreaseLoanHighHoldsValue.

It also allows items to be filtered from the list of items based
on the damaged, lost, not for loan, and withdrawn values even if
those values would have allowed holds ( i.e. values < 0 )

Test Plan:
1) Apply this patch
2) Run updatedatabase.pl
3) Set decreaseLoanHighHolds to Enable
4) Set decreaseLoanHighHoldsControl to "over the number of items on the record"
5) Set decreaseLoanHighHoldsDuration to 1
6) Set decreaseLoanHighHoldsValue to 3
7) Create a record with 5 items
8) Please 8 or more holds on the record
9) Check out one of the items to a patron
10) Note the loan length is reduced to 1 day
11) Set decreaseLoanHighHoldsValue to 3 to 2
12) Check out one of the items to a patron
13) Note the loan length is *not* reduced
14) Enbale all the filters possible in decreaseLoanHighHoldsIgnoreStatuses
15) Set one item to be damaged
16) Note the loan length is reduced
17) Unset the damaged status
18) Repeat steps 15 - 17 for lost, not for loan, and withdrawn

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14694] Make decreaseloanHighHolds more flexible

2015-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14694

Kyle M Hall  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12803] Add ability to skip closed libraries when generating the holds queue

2015-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803

--- Comment #27 from Kyle M Hall  ---
Created attachment 43512
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43512&action=edit
Bug 12803 [QA Followup] - Allow holiday caching to be disabled for testing
purposes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12803] Add ability to skip closed libraries when generating the holds queue

2015-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #43509|0   |1
is obsolete||
  Attachment #43510|0   |1
is obsolete||

--- Comment #26 from Kyle M Hall  ---
Created attachment 43511
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43511&action=edit
Bug 12803 - Add ability to skip closed libraries when generating the holds
queue

The holds queue is typically generated many times a day in order to
select items to fill holds. Often these items are to be sent to a
different library. However, if the library whose item is picked to fill
a hold is closed, that hold will remain unfilled even if there are other
open libraries who own that item. It would be helpful if we could skip
closed libraries for the purpose of selecting items to fill holds.

Test Plan:
1) Apply this patch
2) Run updatedatabase.pl
3) Create a record with two items on it, one at Branch A, and one at
   Branch B
4) Place a hold for pickup at Branch C
5) Generate the holds queue
6) Note which branch's item is selected for the hold
7) Enable the new system preference HoldsQueueSkipClosed
8) Add today as a holiday for that branch noted in step 6
9) Regenerate the holds queue
10) View the holds queue, notice the item selected is not from
the closed branch!
11) prove t/db_dependent/HoldsQueue.t

Signed-off by: Jason Robb 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12803] Add ability to skip closed libraries when generating the holds queue

2015-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #31630|0   |1
is obsolete||
  Attachment #31631|0   |1
is obsolete||
  Attachment #32046|0   |1
is obsolete||
  Attachment #32271|0   |1
is obsolete||

--- Comment #24 from Kyle M Hall  ---
Created attachment 43509
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43509&action=edit
Bug 12803 - Add ability to skip closed libraries when generating the holds
queue

The holds queue is typically generated many times a day in order to
select items to fill holds. Often these items are to be sent to a
different library. However, if the library whose item is picked to fill
a hold is closed, that hold will remain unfilled even if there are other
open libraries who own that item. It would be helpful if we could skip
closed libraries for the purpose of selecting items to fill holds.

Test Plan:
1) Apply this patch
2) Run updatedatabase.pl
3) Create a record with two items on it, one at Branch A, and one at
   Branch B
4) Place a hold for pickup at Branch C
5) Generate the holds queue
6) Note which branch's item is selected for the hold
7) Enable the new system preference HoldsQueueSkipClosed
8) Add today as a holiday for that branch noted in step 6
9) Regenerate the holds queue
10) View the holds queue, notice the item selected is not from
the closed branch!
11) prove t/db_dependent/HoldsQueue.t

Signed-off by: Jason Robb 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12803] Add ability to skip closed libraries when generating the holds queue

2015-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803

Kyle M Hall  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12803] Add ability to skip closed libraries when generating the holds queue

2015-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803

--- Comment #25 from Kyle M Hall  ---
Created attachment 43510
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43510&action=edit
Bug 12803 [QA Followup] - Allow holiday caching to be disabled for testing
purposes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13269] not all 5xx fields show in the staff

2015-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13269

Marjorie Barry-Vila  changed:

   What|Removed |Added

 CC||marjorie.barry-v...@ccsr.qc
   ||.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15024] New: Add a link to add more than one title to another list in OPAC

2015-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15024

Bug ID: 15024
   Summary: Add a link to add more than one title to another list
in OPAC
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Lists
  Assignee: gmcha...@gmail.com
  Reporter: marjorie.barry-v...@ccsr.qc.ca
QA Contact: testo...@bugs.koha-community.org
CC: m.de.r...@rijksmuseum.nl

Hi,

It would be fine to have a link to add more than one title to another list in
OPAC.
Add a link like "Remove from list" which appears at the top of list and for
each individual title.

Regards,

Marjorie

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14670] add 'cite' option to detail page in OPAC

2015-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670

Nicole C. Engard  changed:

   What|Removed |Added

  Change sponsored?|--- |Sponsored

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14670] add 'cite' option to detail page in OPAC

2015-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670

Nicole C. Engard  changed:

   What|Removed |Added

  Attachment #42971|0   |1
is obsolete||

--- Comment #2 from Nicole C. Engard  ---
Created attachment 43508
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43508&action=edit
Bug 14670: Add Cite-option to detail page in OPAC

Adds a "cite" option in the tools menu in OPAC detail page for easy citations.

Test plan:
1. Apply this patch
2. Got to OPAC detail page
3. In the tools menu to the right, click the new "Cite" link
4. A modal should appear with four different citation styles (APA, Chicago,
   Harvard, MLA)

Sponsored-by: Regionbibliotek Halland / County library of Halland

Signed-off-by: Nicole Engard 
I love it, I'd recommend adding an icon to the menu next to it, but 
this patch works as described so I'm signing off.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14670] add 'cite' option to detail page in OPAC

2015-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670

Nicole C. Engard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14227] rda toolkit integration

2015-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14227

--- Comment #2 from Nicole C. Engard  ---
I'm actually not sure.  I was sharing an idea from a library.  This is the
tool: https://access.rdatoolkit.org/ and apparently it's in other ILSes, but
that's the limit of my knowledge.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13384] RDA: 655 display in XSLT

2015-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13384

Nicole C. Engard  changed:

   What|Removed |Added

   Assignee|neng...@gmail.com   |wsale...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13384] RDA: 655 display in XSLT

2015-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13384

Nicole C. Engard  changed:

   What|Removed |Added

 Status|In Discussion   |ASSIGNED

--- Comment #2 from Nicole C. Engard  ---
This was based on rules given to me by a library.  I'm fine with anything as
long as it's hideable using spans if need be.

Nicole

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user

2015-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918

--- Comment #52 from Jonathan Druart  
---
Created attachment 43503
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43503&action=edit
Bug 13918 [QA Followup] - Unit Tests

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user

2015-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14341] XSLT 773$x

2015-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14341

--- Comment #2 from Nicole C. Engard  ---
773 0#$tEntomologists' monthly magazine$pENTOMOL MON MAG$dWallingford : Gem
Publishing Company$x0013-8908$yFNMMA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13816] Set Overdue letter fine to the overduerules

2015-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13816

Charles Farmer  changed:

   What|Removed |Added

 CC||charles.far...@inlibro.com
 Status|NEW |In Discussion

--- Comment #2 from Charles Farmer  ---
Hi Olli-Antti,

Could you take a look at Bug 12769? The patch was developed in 2014 to address
the issue of adding a fee to any kind of notice, including overdue notices, and
from what I see, your needs could be covered by that patch.

Since we are all submitting patches that do relatively the same thing, we will
have to get behind one of them to have any chance of making it to the master
branch. Tell us what you think in Bug 12769.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14830] anonymous purchase suggestions are invisible/inaccessible in staff interface

2015-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14830

--- Comment #6 from Marc Véron  ---
One more finding: A suggestion ist not visible / manageable if created in staff
client with Library set to "Any"

The value for the library code in the database is en empty string in that case.
It is not visible in staff client, not even for superlibrarians (with and
without patch).

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14666] adds fixed_fines for overdues

2015-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14666

Charles Farmer  changed:

   What|Removed |Added

 Status|Needs Signoff   |In Discussion
 CC||charles.far...@inlibro.com

--- Comment #4 from Charles Farmer  ---
Hi Fridolin,

Could you take a look at Bug 12769? The patch was developed in 2014 to address
the issue of adding a fee to any kind of notice, including overdue notices, and
from what I see, your needs could be covered by that patch.

If we want to see this feature added to Koha someday, we will have to join our
efforts.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user

2015-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918

--- Comment #56 from Jonathan Druart  
---
Created attachment 43507
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43507&action=edit
Bug 13918 [QA Followup] - Remove unnecessary reference to $wcount

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user

2015-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918

--- Comment #55 from Jonathan Druart  
---
Created attachment 43506
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43506&action=edit
Bug 13918 [QA Followup] - Remove dead template code

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user

2015-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918

--- Comment #54 from Jonathan Druart  
---
Created attachment 43505
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43505&action=edit
Bug 13918 [QA Followup] - Improve $biblio->subtitles()

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user

2015-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918

--- Comment #53 from Jonathan Druart  
---
Created attachment 43504
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43504&action=edit
Bug 13918 [QA Followup] - Remove reserves_count

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13918] Add waiting expiration date to opac list of holds for user

2015-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13918

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #43429|0   |1
is obsolete||
  Attachment #43430|0   |1
is obsolete||
  Attachment #43431|0   |1
is obsolete||
  Attachment #43432|0   |1
is obsolete||
  Attachment #43433|0   |1
is obsolete||
  Attachment #43438|0   |1
is obsolete||

--- Comment #51 from Jonathan Druart  
---
Created attachment 43502
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43502&action=edit
Bug 13918 - Add waiting expiration date to opac list of holds for user

Waiting holds for patrons in the opac should display the hold expiration
date based on the max pickup delay if it is set.

Test Plan:
1) Ensure ReservesMaxPickUpDelay is set
2) Place a hold on a record
3) Check in the item, use it to fill the hold
4) Log into the opac as that user
5) View the holds list, note the 'until ' addition to the
   waiting hold line.

Signed-off-by: Kyle M Hall 

Signed-off-by: Cathi Wiggins 

Signed-off-by: Megan Wianecki 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11559] Professional cataloger's interface

2015-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559

--- Comment #142 from Nicole C. Engard  ---
I'll add here, that once this is in 3.22 I can guarantee many many testers and
since it doesn't hurt the existing cataloging tool I like the idea of adding it
in with an experimental warming.

Nicole

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10306] Publication information can only be mapped to either 260 or 264 (RDA)

2015-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10306

--- Comment #10 from Nicole C. Engard  ---
(In reply to David Cook from comment #9)
> Not very positive, because Keyword to Marc mapping only allows one mapping,
> when you theoretically might want to use 264 "or" 260 depending on which is
> available per record.

But, we could enhance it to do what we need ... couldn't we? Just spit balling
ideas here.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7663] batch add barcodes to a list

2015-10-16 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7663

Marjorie Barry-Vila  changed:

   What|Removed |Added

 CC||marjorie.barry-v...@ccsr.qc
   ||.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   3   >