[Koha-bugs] [Bug 14918] Remove C4::Dates from circ/pendingreserves.pl

2015-10-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14918

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #43796|0   |1
is obsolete||

--- Comment #12 from Marcel de Rooy  ---
Created attachment 43798
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43798&action=edit
Bug 14918: Remove C4::Dates from circ/pendingreserves.pl

This patch uses Koha::DateUtils instead of C4::Dates and Date::Calc. It
also sent DateTime objects to the template, which use the TT plugin to
display them.
If an invalid dates is entered, the default date is picked.

Test plan:
1/ Go to Home > Circulation > Holds to pull
2/ Verify that the the filter and the list behave as before
3/ Enter invalid dates and confirm that you do not get a software error

Counter patch works as expected and is a much cleaner solution.
Signed-off-by: Marc Veron 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14918] Remove C4::Dates from circ/pendingreserves.pl

2015-10-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14918

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #43797|0   |1
is obsolete||

--- Comment #13 from Marcel de Rooy  ---
Created attachment 43799
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43799&action=edit
Bug 14918: [QA Follow-up] Correct enddate and use constant

Corrected enddate (subtraction in the revised code must be an addition).
Replaced hardcoded 2 days by a constant.
Renamed the constant TWO_DAYS to PULL_INTERVAL.

Signed-off-by: Marcel de Rooy 
Tested all three date formats.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14918] Remove C4::Dates from circ/pendingreserves.pl

2015-10-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14918

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14918] Remove C4::Dates from circ/pendingreserves.pl

2015-10-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14918

Marcel de Rooy  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
   |y.org   |
   Patch complexity|Trivial patch   |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14918] Remove C4::Dates from circ/pendingreserves.pl

2015-10-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14918

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #43003|0   |1
is obsolete||

--- Comment #10 from Marcel de Rooy  ---
Created attachment 43796
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43796&action=edit
Bug 14918: Remove C4::Dates from circ/pendingreserves.pl

This patch uses Koha::DateUtils instead of C4::Dates and Date::Calc. It
also sent DateTime objects to the template, which use the TT plugin to
display them.
If an invalid dates is entered, the default date is picked.

Test plan:
1/ Go to Home > Circulation > Holds to pull
2/ Verify that the the filter and the list behave as before
3/ Enter invalid dates and confirm that you do not get a software error

Counter patch works as expected and is a much cleaner solution.
Signed-off-by: Marc Véron 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14918] Remove C4::Dates from circ/pendingreserves.pl

2015-10-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14918

--- Comment #11 from Marcel de Rooy  ---
Created attachment 43797
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43797&action=edit
Bug 14918: [QA Follow-up] Correct enddate and use constant

Corrected enddate (subtraction in the revised code must be an addition).
Replaced hardcoded 2 days by a constant.
Renamed the constant TWO_DAYS to PULL_INTERVAL.

Signed-off-by: Marcel de Rooy 
Tested all three date formats.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14918] Remove C4::Dates from circ/pendingreserves.pl

2015-10-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14918

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14915] Use Font Awesome instead of Glyphicons for the staff intranet

2015-10-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14915

Josef Moravec  changed:

   What|Removed |Added

 CC||josef.mora...@gmail.com

--- Comment #11 from Josef Moravec  ---
There are still some Glyphicons, probably from recent development in these
files:

koha-tmpl/intranet-tmpl/prog/en/modules/labels/label-edit-batch.tt
koha-tmpl/intranet-tmpl/prog/en/modules/labels/label-manage.tt
koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-batch.tt
koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/image-manage.tt
koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/manage.tt

koha-tmpl/intranet-tmpl/prog/en/includes/labels-toolbar.inc
koha-tmpl/intranet-tmpl/prog/en/includes/patroncards-toolbar.inc

Maybe we should update Coding Guidelines, what do you think?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15048] subject/genre (650/655) searches fail on searches with $x 'General subdivision' subfield values

2015-10-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15048

Mason James  changed:

   What|Removed |Added

 Status|NEW |In Discussion

--- Comment #7 from Mason James  ---
(In reply to Mason James from comment #6)
> (In reply to Mason James from comment #5)
> > my hunch is that the CCL syntax for the search query is incorrect
> > 
> > my example returns no results..
> >  (su,complete-subfield:"Family") AND (su,complete-subfield:"Fiction")
> 
> the other issue is that the 650$x and/or 655$x subfields don't seem to be
> configured to be indexed by Zebra in..
>  /etc/koha/zebradb/marc_defs/marc21/biblios/biblio-koha-indexdefs.xml (and
> others)
> 
> ..so a query for (su,complete-subfield:"Fiction") would be expected to fail,
> as that info is located in the unindexed 655$x subfield

good news, i have a fix for this...

i'll attach a patch soon

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11559] Professional cataloger's interface

2015-10-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559

--- Comment #173 from Nick Clemens  ---
(In reply to Jesse Weaver from comment #172)

>   a) Display an error when attempting to import MARC-8 records

I think this would be fine, Marcedit can transform from marc-8 in the case of
the error so I don't think it should be a huge deal.  I would then file the
marc-8 support as a separate bug

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15048] subject/genre (650/655) searches fail on searches with $x 'General subdivision' subfield values

2015-10-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15048

--- Comment #6 from Mason James  ---
(In reply to Mason James from comment #5)
> my hunch is that the CCL syntax for the search query is incorrect
> 
> my example returns no results..
>  (su,complete-subfield:"Family") AND (su,complete-subfield:"Fiction")

the other issue is that the 650$x and/or 655$x subfields don't seem to be
configured to be indexed by Zebra in..
 /etc/koha/zebradb/marc_defs/marc21/biblios/biblio-koha-indexdefs.xml (and
others)

..so a query for (su,complete-subfield:"Fiction") would be expected to fail, as
that info is located in the unindexed 655$x subfield

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14776] SCO/shelfcheck 'log out' option redirects to OPAC, not back to SCO

2015-10-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14776

Chris Kirby  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #11 from Chris Kirby  ---
Hi Marc,
>How is the behaviour without patch? It seems to me that it behaves the same 
>(redirect to a login page).
Without the patch, the behavior is the same.

>What would you expect to happen if AutoSelfCheckAllowed is DISABLED?
I was expect to have a login page for the selfcheck and then the SCO user's
information is hidden, just as your patch achieves.

>Maybe your finding is something for a separate bug?
Yes, this might make sense if there is a desire to use the selfcheck when
AutoSelfCheckAllowed  is DISABLED.

Signed off on patch:

Applied on top of Bug 15039
- Set AutoSelfCheckAllowed to ENABLED, and provided values for AutoSelfCheckID,
AutoSelfCheckPass
- Set OpacLangSelectorMode to 'top' or 'both'
- Went to SCO page
- Verified that the language menu does not display in the header
- Entered a card number to check out (this logs in the SCO user)
- Verified that you get text similar to "Welcome, checkout" with a link to the
sco user's account in the OPAC and a 'Logout' link
- Applied patch for 14776
- Verified that the language menu appears and the SCO user's information
disappears.
- Verified, that the language menu displays / does not display with
combinations of:
  - opaclanguagedisplay (Allow)
  - opaclanguages ( > 1 language selected)
  - OpacLangSelectorMode (top or both)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15048] subject/genre (650/655) searches fail on searches with $x 'General subdivision' subfield values

2015-10-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15048

Mason James  changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=15047

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15047] Genre/Form-655 URL not clickable in opac-detail.pl, with XSLT enabled

2015-10-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15047

Mason James  changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=15048

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15048] subject/genre (650/655) searches fail on searches with $x 'General subdivision' subfield values

2015-10-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15048

--- Comment #5 from Mason James  ---
my hunch is that the CCL syntax for the search query is incorrect

my example returns no results..
 (su,complete-subfield:"Family") AND (su,complete-subfield:"Fiction")

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13381] RDA: 245 field changes in XSLT

2015-10-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13381

--- Comment #35 from Winona Salesky  ---
The order in the for-each does not determine the order of the output. Subfields
are output in the order they appear in the marc record. They are in
alphabetical order in the for-each, purely for convenience sake. 

-Winona

(In reply to David Cook from comment #34)
> I suppose it's way too late for this so someday I'll make a different bug
> but...
> 
> I think the following:
> 
> 
> 

> Should actually be:
> 
> 
> 
> If you look at the LoC website
> (http://www.loc.gov/marc/bibliographic/bd245.html), you'll see that $h is
> always between $a and $b.
> 
> --
> 
> Ahh... interesting... in the "CONTENT DESIGNATOR HISTORY", you'll see an
> explanation for this:
> 
> "Prior to 1994, AACR2 cataloging rules required that the medium designator
> be recorded following other title information and all the title in works
> lacking a collective title. In Pre-1994 records, subfield $h generally
> follows subfield $b and even subfield $c in some cases."
> 
> However, in post-1994 records, that does not appear to be the case. If
> anyone has access to the AACR2*, they could verify this.
> 
> *Have to love closed standards in libraries. Terry Reese has a good post
> about this: http://blog.reeset.net/archives/1100

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15048] subject/genre (650/655) searches fail on searches with $x 'General subdivision' subfield values

2015-10-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15048

--- Comment #4 from Mason James  ---
Created attachment 43795
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43795&action=edit
FAILED search on 655$a and 655$x - 'Family -- Fiction'

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15048] subject/genre (650/655) searches fail on searches with $x 'General subdivision' subfield values

2015-10-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15048

--- Comment #3 from Mason James  ---
Created attachment 43794
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43794&action=edit
successful search on 655$a - 'speedy reads'

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15048] subject/genre (650/655) searches fail on searches with $x 'General subdivision' subfield values

2015-10-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15048

--- Comment #2 from Mason James  ---
Created attachment 43793
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43793&action=edit
successful search on 655$a - 'speedy reads'

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15048] subject/genre (650/655) searches fail on searches with $x 'General subdivision' subfield values

2015-10-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15048

Mason James  changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |m...@kohaaloha.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15048] subject/genre (650/655) searches fail on searches with $x 'General subdivision' subfield values

2015-10-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15048

--- Comment #1 from Mason James  ---
to test bug...

1/ define a 655$a value in a bib,  save, reindex

2/ in opac-detail.pl click on its genre/form url, the search should
successfully return a result (good!)


3/ next, define both a 655$a *and* 655$x value in a bib, save, reindex

4/ in opac-detail.pl click its genre/form url, the search should FAIL to return
a result (BAD!) :/

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10988] Allow login via Google OAuth2

2015-10-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10988

M. Tompsett  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Signed Off

--- Comment #46 from M. Tompsett  ---
Setting back to Signed Off after this rebasing.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10988] Allow login via Google OAuth2

2015-10-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10988

M. Tompsett  changed:

   What|Removed |Added

  Attachment #41663|0   |1
is obsolete||

--- Comment #45 from M. Tompsett  ---
Created attachment 43792
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43792&action=edit
Bug 10988: Fix the svc script path

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10988] Allow login via Google OAuth2

2015-10-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10988

M. Tompsett  changed:

   What|Removed |Added

  Attachment #40979|0   |1
is obsolete||

--- Comment #44 from M. Tompsett  ---
Created attachment 43791
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43791&action=edit
Bug 10988: Allow login via Google OAuth2

Adds googleoauth2 login to koha. Adds applicable system
preferences Modifies templates to support oauth2 login
failures changes the login links to use googleoauth2 when
oauth2 is enabled.

Updated patch to address the concerns in Comment 36.

Test Plan:
 0) Back up your database
 1) Apply this patch
 2) In your mysql client use your Koha database and execute:
> DELETE FROM systempreferences;
> SOURCE ~/kohaclone/installer/data/mysql/sysprefs.sql;
-- Should be no errors.
> SELECT * FROM systempreferences LIKE 'GoogleOAuth%';
-- Should see 4 entries.
> QUIT;
 3) Restore your database
 4) Run ./installer/data/mysql/updatedatabase.pl;
 5) In your mysql client use your Koha database and execute:
> SELECT * FROM systempreferences LIKE 'GoogleOAuth%';
-- Should see the same 4 entries.
 6) Log into the staff client
 7) Home -> Koha administration -> Global system preferences
 8) -> OPAC
-- make sure your OPACBaseURL is set (e.g. https://opac.koha.ca)
 9) -> Administration
-- There should be a 'Google OAuth2' section with the ability
   to set those 4 system preferences.
10) In a new tab, go to https://console.developers.google.com/project
11) Click 'Create Project'
12) Type in a project name that won't freak users out, like your
library name (e.g. South Pole Library).
13) Click the 'Create' button.
14) Click the 'APIs & auth' in the left frame.
15) Click 'Credentials'
16) Click 'Create new Client ID'
17) Select 'Web application' and click 'Configure consent screen'.
18) Select the Email Address.
19) Put it a meaningful string into the Product Name
(e.g. South Pole Library Authentication)
20) Fill in the other fields as desired (or not)
21) Click 'Save'
22) Change the 'AUTHORIZED JAVASCRIPT ORIGINS' to your OPACBaseURL.
(http://library.yourDNS.org)
23) Change the 'AUTHORIZED REDIRECT URIS' to point to the new
googleoauth2 script
(http://library.yourDNS.org/cgi-bin/koha/svc/auth/googleoauth2)
24) Click 'Create Client ID'
25) Copy and paste the 'CLIENT ID' into the GoogleOAuth2ClientID
system preference.
26) Copy and paste the 'CLIENT SECRET' into the GoogleOAuth2ClientSecret
system preference.
27) Change the GoogleOAuth2 preference to 'Use'.
28) Click 'Save all Administration preferences'
29) In the OPAC, click 'Log in to your account'.
-- You should get a confirmation request, if you are
already logged in, OR a login screen if you are not.
-- You need to have the primary email address set to one
   authenticated by Google in order to log in.
30) Run koha qa test tools

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13381] RDA: 245 field changes in XSLT

2015-10-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13381

--- Comment #34 from David Cook  ---
I suppose it's way too late for this so someday I'll make a different bug
but...

I think the following:



Should actually be:



If you look at the LoC website
(http://www.loc.gov/marc/bibliographic/bd245.html), you'll see that $h is
always between $a and $b.

--

Ahh... interesting... in the "CONTENT DESIGNATOR HISTORY", you'll see an
explanation for this:

"Prior to 1994, AACR2 cataloging rules required that the medium designator be
recorded following other title information and all the title in works lacking a
collective title. In Pre-1994 records, subfield $h generally follows subfield
$b and even subfield $c in some cases."

However, in post-1994 records, that does not appear to be the case. If anyone
has access to the AACR2*, they could verify this.

*Have to love closed standards in libraries. Terry Reese has a good post about
this: http://blog.reeset.net/archives/1100

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11559] Professional cataloger's interface

2015-10-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559

--- Comment #172 from Jesse Weaver  ---
(In reply to Nick Clemens from comment #167)
> Created attachment 43713 [details]
> Record with composed character that breaks import into rancor
> 
> When importing all fields after 518 containing {uml} have mangled indicators
> Could be another issue causing it, but that seemed to be the case

Ugh... this is a MARC-8 record. I _could_ add support for MARC-8, but it might
be a bit ugly at this late hour.

The current behavior (asplode) is non-ideal, so should I:
  a) Display an error when attempting to import MARC-8 records
  b) Add support for MARC-8 _import_

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14670] add 'cite' option to detail page in OPAC

2015-10-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
 Status|Failed QA   |Signed Off

--- Comment #6 from Katrin Fischer  ---
Hi Martin, it's usually ok to switch back to signed off once you have provided
patches fixing the QA issues - this way it will get reviewed again.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11431] Add additional sound options for warnings

2015-10-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11431

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #117 from Katrin Fischer  ---
Hi Kyle,

one small thing: If AudioAlerts is turned off the 'play' button on the
administration page won't work and save the entry instead. That was quite
confusing. I think independent of the AudioAlerts setting, you should be able
to 'preview' the sounds on the admin page. The second best solution would be to
not display the play button in this case.

Enhancement ideas:
- I'd really really like an option to play the sounds of saved entries for
easier testing and also the option of editing the entries - if you get your
selector wrong, it can be quite annoying to delete and start over.
- Adding an example to the help page would be great. The example on the bug
report is not quite so good, as it relies on the existence of an English string
in a certain place and would be hard to translate, but maybe another example
that is based on a class or id?

Can you please take a look?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11559] Professional cataloger's interface

2015-10-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559

--- Comment #171 from Jesse Weaver  ---
Created attachment 43790
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43790&action=edit
Bug 11559: (QA followup) fix pagination bar, add Ctrl-D to macro editor

Also, fix incredibly silly mistake with keyboard shortcuts popup.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches.

2015-10-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

--- Comment #22 from Katrin Fischer  ---
Hi David,
thx for the quick reply and the examples - I'll say that reasolved that point
in my list. Your examples would be great for the help page.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches.

2015-10-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

--- Comment #21 from David Cook  ---
(In reply to Katrin Fischer from comment #20)
> - Last but not least: I'd really like to see a second use case where this
> feature is helpful - so not only the one server causing problems, but maybe
> another good/clever idea on how to use this feature.

It's not just about the one server. It theoretically could be any server.

http://www.loc.gov/z3950/agency/bib1.html:

"Within an attribute list, each attribute type is optional.  However, if
a particular attribute type is not supplied, this document does not
address target behavior -- a given target might supply a default
attribute, dynamically select an appropriate attribute based on the
other attributes supplied, or fail the search because it requires that
the attribute type be supplied."

At the moment, we don't have a way for users to specify Bib-1 attributes, so
some servers will fail for all Z39.50 searches. 

Without this patch (or a similar one), I think the way we do Z39.50 searches is
short-sighted. 

While Zebra will provide default attributes, it's clear that not all Z39.50
targets do. 

I don't think there are any other good/clever ideas for other ways to use this
feature. It basically lets you provide attributes that are applied to the rest
of the query. I suppose in other use cases... it lets you specify new defaults.

For instance, Zebra will default to a Structure attribute of "phrase". Maybe
you would prefer to default to a Structure attribute of "word list" instead, so
you can specify that using this patch, and there you go. 

Or maybe you want to use a "relevance relation" for all your queries to a
target, so you specify @attr 2=102.

Or maybe you don't want to truncate anything in your queries so you supply
@attr 5=100.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11317] Add a way to access files from the intranet.

2015-10-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #30 from Katrin Fischer  ---
Some more notes:
- +use strict; +use warnings; > Please use Modern::Perl; instead
- The table should use a standard display format of Koha for the date and time
information. The information form the patch doesn't translate and can't be
configured with the dateformat/timeformat preferences: Thu Aug 2 16:41:30 2012
- I feel this would be better as a tool than as a link on the reports page - I
don't really see a connection to reports so much, as it's a very general tool.
- I am still in favor of renaming the directory to something less 'public' and
we should have some information on how to use this feature safely without
exposing data accidentally via your web server that should be kept safe.

Possible enhancements:
- As the kind of files presented can be quite different, it would be nice if
this had its own permission.
- Allow multiple directories - @Martin, maybe this could be added later?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14504] Add command-line script to batch delete items based on lost/withdrawn statuses

2015-10-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14504

--- Comment #15 from Barton Chittenden  ---
Jonathan,

The call to C4::Context->IsSuperLibrarian() in C4::Items::ItemSafeToDelete
(formerly in C4::Items::DelItemCheck) is throwing the following warning:

C4::Context->userenv not defined! at /var/lib/koha/nekls2/kohaclone/C4/Items.pm
line 2336.

I've gone ahead and attached the patches, because everything else works, but
thoughts about how to fix the "not_same_branch" code would be appreciated.

--Barton

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches.

2015-10-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #20 from Katrin Fischer  ---
Some first results:
- Please submit the Schema changes as a separate patch next time.
- The new attributes field should not show up on the "New SRU server" page - I
believe it does not apply there. Please fix.
- While validation would be nice, we don't provide it for the other fields here
and I am not sure how it could work. So I would not insist on it, but any help
we can give the user is of course always welcome. That's why I second
Jonathan's comment 10 - we need some end user documentation on how to use this.
Please provide an update to the help file.
- Last but not least: I'd really like to see a second use case where this
feature is helpful - so not only the one server causing problems, but maybe
another good/clever idea on how to use this feature.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14504] Add command-line script to batch delete items based on lost/withdrawn statuses

2015-10-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14504

--- Comment #14 from Barton Chittenden  ---
Created attachment 43789
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43789&action=edit
bug 14504: use C4::Items::DelItemCheck in delete_items.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14504] Add command-line script to batch delete items based on lost/withdrawn statuses

2015-10-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14504

--- Comment #13 from Barton Chittenden  ---
Created attachment 43788
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43788&action=edit
bug 14504: split logic from DelItemCheck() into ItemSafeToDelete()

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14504] Add command-line script to batch delete items based on lost/withdrawn statuses

2015-10-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14504

Barton Chittenden  changed:

   What|Removed |Added

 Status|In Discussion   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10988] Allow login via Google OAuth2

2015-10-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10988

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
 Status|Signed Off  |Patch doesn't apply

--- Comment #43 from Katrin Fischer  ---
Patch does not apply - please rebase!

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 10988: Allow login via Google OAuth2
Using index info to reconstruct a base tree...
M   C4/Auth.pm
M   installer/data/mysql/sysprefs.sql
M   koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref
M   koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth.tt
Falling back to patching base and 3-way merge...
Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth.tt
CONFLICT (content): Merge conflict in
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth.tt
Auto-merging
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref
Auto-merging installer/data/mysql/sysprefs.sql
Auto-merging C4/Auth.pm
CONFLICT (content): Merge conflict in C4/Auth.pm
Failed to merge in the changes.
Patch failed at 0001 Bug 10988: Allow login via Google OAuth2
The copy of the patch that failed is found in:
   /home/katrin/kohaclone/.git/rebase-apply/patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in /tmp/Bug-10988-Allow-login-via-Google-OAuth2-fFUW8a.patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10933] PurgeSearchHistory should be merged into the C4::Search::History module

2015-10-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10933

--- Comment #18 from Katrin Fischer  ---
Created attachment 43787
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43787&action=edit
[PASSED QA] Bug 10933: (follow-up) fix the previous patch to work with master

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10933] PurgeSearchHistory should be merged into the C4::Search::History module

2015-10-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10933

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #42114|0   |1
is obsolete||
  Attachment #42116|0   |1
is obsolete||

--- Comment #17 from Katrin Fischer  ---
Created attachment 43786
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43786&action=edit
[PASSED QA] Bug 10933: The PurgeSearchHistory should be merge into the
C4::Search::History module

Since bug 10803 adds a C4::Search::History module, the
PurgeSearchHistory routine should be moved.

Test plan:
- run misc/cronjobs/cleanup_database.pl with the searchhistory param and
verify behavior is the same as before applying this patch.
- run prove t/Search/History.t

Signed-off-by: Joonas Kylmälä 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10933] PurgeSearchHistory should be merged into the C4::Search::History module

2015-10-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10933

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12426] Allow resending of emails from the notices tab in the patron account

2015-10-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426

--- Comment #33 from Marc Véron  ---
I'm sorry, conflict with first patch:

CONFLICT (content): Merge conflict in t/db_dependent/Letters.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15030] Certain values in serials' items are lost on next edit

2015-10-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15030

--- Comment #3 from Blou  ---
Created attachment 43785
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43785&action=edit
Bug 15030 - continue.  The enumchron value was overwritten by 'header' even
when value supplied

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10933] PurgeSearchHistory should be merged into the C4::Search::History module

2015-10-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10933

Katrin Fischer  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

--- Comment #16 from Katrin Fischer  ---
Never mind - I fixed it, continuing with testing.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10933] PurgeSearchHistory should be merged into the C4::Search::History module

2015-10-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10933

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA
 CC||katrin.fisc...@bsz-bw.de

--- Comment #15 from Katrin Fischer  ---
Hi Jonathan, can you take a quick look at the failing test please?

not ok 16 - Calling delete without userid raises warning
#   Failed test 'Calling delete without userid raises warning'
#   at t/db_dependent/Search/History.t line 128.
# found warning: ERROR: userid, id or interval is required for history deletion
at /home/katrin/kohaclone/C4/Search/History.pm line 77.
# expected to find warning: (?^u:^ERROR: userid or id is required for history
deletion)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9129] Add the ability to set the maximum fine for an item to its replacement price

2015-10-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9129

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14964] Email notices will be queued for patrons with no email address

2015-10-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14964

--- Comment #5 from Katrin Fischer  ---
... but probably should be configurable - for some notices you might not want
to have a printed one

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14964] Email notices will be queued for patrons with no email address

2015-10-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14964

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #4 from Katrin Fischer  ---
Wondering... should we queue a message of the type 'print' if there is no
e-mail address? I think this might be what we do for overdues

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9129] Add the ability to set the maximum fine for an item to its replacement price

2015-10-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9129

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #43746|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9129] Add the ability to set the maximum fine for an item to its replacement price

2015-10-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9129

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #43747|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9129] Add the ability to set the maximum fine for an item to its replacement price

2015-10-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9129

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #43745|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9129] Add the ability to set the maximum fine for an item to its replacement price

2015-10-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9129

--- Comment #58 from Katrin Fischer  ---
Created attachment 43784
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43784&action=edit
[PASSED QA] Bug 9129 - Add the ability to set the maximum fine for an item to
its replacement price

This patch adds the ability to set the maximum fine for a given item to
its replacement price ( assuming the replacement price is set ). If
overduefinescap is also set, the fine will be the lesser of the two, if
both apply to the given overdue checkout.

To enable this new limit, create or edit your circulation rules and
check the checkbox for "Cap fines at replacement price"

Test Plan:
1) Apply this patch
2) Run updatedatabase.pl
3) Pick an item, and set it's replacement price to 3.99
4) Edit the circulation rule that would apply to this item
   and the patron you will check it out to.
5) Check out the item to the patron, and backdate the due date
   such that the fine generated would be more than 3.99
6) Enable CalculateFinesOnReturn
7) Return the item, and view the fine generated, it should be 3.99

Signed-off-by: Cindy Murdock Ames 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9129] Add the ability to set the maximum fine for an item to its replacement price

2015-10-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9129

--- Comment #57 from Katrin Fischer  ---
Created attachment 43783
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43783&action=edit
[PASSED QA] Bug 9129 - Update schema

Signed-off-by: Cindy Murdock Ames 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9129] Add the ability to set the maximum fine for an item to its replacement price

2015-10-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9129

--- Comment #55 from Katrin Fischer  ---
Created attachment 43781
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43781&action=edit
[PASSED QA] Bug 9129 - Update database

Signed-off-by: Cindy Murdock Ames 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9129] Add the ability to set the maximum fine for an item to its replacement price

2015-10-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9129

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #43781|0   |1
is obsolete||

--- Comment #56 from Katrin Fischer  ---
Created attachment 43782
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43782&action=edit
[PASSED QA] Bug 9129 - Update database

Signed-off-by: Cindy Murdock Ames 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14776] SCO/shelfcheck 'log out' option redirects to OPAC, not back to SCO

2015-10-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14776

--- Comment #10 from Marc Véron  ---
Hi Chris,

Thanks for testing.

Questions:

- How is the behaviour without patch? It seems to me that it behaves the same
(redirect to a login page).

- What would you expect to happen if AutoSelfCheckAllowed is DISABLED?

- Maybe your finding is something for a separate bug?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12426] Allow resending of emails from the notices tab in the patron account

2015-10-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426

--- Comment #32 from Katrin Fischer  ---
Would be really nice to see a sign-off for this asap! Please?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14964] Email notices will be queued for patrons with no email address

2015-10-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14964

Marc Véron  changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=12426
 CC||ve...@veron.ch

--- Comment #3 from Marc Véron  ---
This functionality could be in conflict with:

Bug 12426 - Allow resending of emails from the notices tab in the patron
account

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12426] Allow resending of emails from the notices tab in the patron account

2015-10-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12426

Marc Véron  changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=14964

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14824] Fix sorting of Norwegian vowels

2015-10-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14824

Mirko Tietgen  changed:

   What|Removed |Added

  Attachment #42549|0   |1
is obsolete||

--- Comment #2 from Mirko Tietgen  ---
Created attachment 43780
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43780&action=edit
Bug 14824 - Fix sorting of Norwegian vowels

Currently, Norwegian vowels are not sorted correctly, even when
you have chosen "nb" as the ZEBRA_LANGUAGE during installation.

To test:
- Make sure you have three records with titles that begin with ÆØÅ
  respectively
- Do a search that turns up those three records and some others, and
  sort the results by title, bot ascending and descending.
- Verify that ÆØÅ is shown in some weird order.
- Edit your sort-string-utf.chr* so it is in line with the current
  patch. It should include these two lines:
  lowercase {0-9}{a-z}æøå
  uppercase {0-9}{A-Z}ÆØÅ
- Restart Zebra and reindex all the records, e.g.:
  $ sudo koha-restart-zebra 
  $ sudo koha-rebuild-zebra -f -v 
- Do the search again, make sure you order by title and check that
  ÆØÅ are sorted in the order of 1. Æ 2. Ø 3. Å, and after all other
  characters

* = If you are on a gitified install, you need to edit this file:
/etc/koha/zebradb/lang_defs//sort-string-utf.chr
NOT the file in your git clone (yeah, i wasted some time there...)

Signed-off-by: Mirko Tietgen 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14824] Fix sorting of Norwegian vowels

2015-10-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14824

Mirko Tietgen  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||mi...@abunchofthings.net

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12803] Add ability to skip closed libraries when generating the holds queue

2015-10-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803

Kyle M Hall  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

--- Comment #36 from Kyle M Hall  ---
> % prove t/db_dependent/HoldsQueue.t
> t/db_dependent/HoldsQueue.t .. 13/24 
> #   Failed test 'Holds not filled with items from closed libraries'
> #   at t/db_dependent/HoldsQueue.t line 327.
> #  got: '1'
> # expected: '2'
> # Looks like you failed 1 test of 24.
> t/db_dependent/HoldsQueue.t .. Dubious, test returned 1 (wstat 256, 0x100)
> Failed 1/24 subtests 
> 
> Test Summary Report
> ---
> t/db_dependent/HoldsQueue.t (Wstat: 256 Tests: 24 Failed: 1)
>   Failed test:  23
>   Non-zero exit status: 1
> Files=1, Tests=24,  3 wallclock secs ( 0.04 usr  0.00 sys +  1.76 cusr  0.06
> csys =  1.86 CPU)
> Result: FAIL

So far I have been completely unable to reproduce this failure using my test
database or a fresh Koha db with all the sample data. Have you tested it with a
fresh sample data database?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12803] Add ability to skip closed libraries when generating the holds queue

2015-10-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803

--- Comment #35 from Kyle M Hall  ---
Created attachment 43779
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43779&action=edit
Bug 12803 [QA Followup] - Fix koha-qa.pl errors

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12194] Some fonts don't work on printing label

2015-10-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12194

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

 Status|Pushed to Master|ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7560] SIP Self Checkout Ignoring Fines Thresholds for Not Being able to Check Out Books

2015-10-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7560

Kyle M Hall  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12194] Some fonts don't work on printing label

2015-10-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12194

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

--- Comment #21 from Bernardo Gonzalez Kriegel  ---
Added followup, needs revision i think, so changed to Needs signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12194] Some fonts don't work on printing label

2015-10-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12194

--- Comment #20 from Bernardo Gonzalez Kriegel  ---
Created attachment 43778
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43778&action=edit
Bug 12194: followup to fix test

This patch adds new column 'oblique_title' to tested
data structure, and update number of tests

To test:
1) Run prove t/db_dependent/Labels/*, or specifically
prove t/db_dependent/Labels/t_Layout.t

It fails

2) apply the patch
3) Run test again, this time must pass

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7560] SIP Self Checkout Ignoring Fines Thresholds for Not Being able to Check Out Books

2015-10-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7560

--- Comment #43 from Kyle M Hall  ---
Created attachment 43777
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43777&action=edit
Bug 7560 [QA Followup] - Fix string name conflict, add screen message

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 7560] SIP Self Checkout Ignoring Fines Thresholds for Not Being able to Check Out Books

2015-10-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7560

Kyle M Hall  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14889] Move the framework related code to Koha::BiblioFramework[s]

2015-10-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14889

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

  Attachment #42846|0   |1
is obsolete||

--- Comment #3 from Bernardo Gonzalez Kriegel  ---
Created attachment 43775
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43775&action=edit
[SIGNED-OFF] Bug 14889: Add Koha::BiblioFramework[s] classes

Signed-off-by: Bernardo Gonzalez Kriegel 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14889] Move the framework related code to Koha::BiblioFramework[s]

2015-10-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14889

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

 CC||bgkrie...@gmail.com
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14889] Move the framework related code to Koha::BiblioFramework[s]

2015-10-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14889

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

  Attachment #42847|0   |1
is obsolete||

--- Comment #4 from Bernardo Gonzalez Kriegel  ---
Created attachment 43776
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43776&action=edit
[SIGNED-OFF] Bug 14889: Use Koha::BiblioFramework[s] in
admin/biblio_framework.pl

Test plan:
Add/edit/remove biblio frameworks from the administration module
(admin/biblio_framework.pl).
You should get message feedback after each action.

Signed-off-by: Bernardo Gonzalez Kriegel 
No problems found. Tested add/edit/delete
No koha-qa errors

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12194] Some fonts don't work on printing label

2015-10-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12194

--- Comment #19 from Tomás Cohen Arazi  ---
Patch authors: please check that tests are failing due to this patchset:

prove t/db_dependent/Labels/*

Might not be the only tests failing, so please check jenkins (D7 is fine)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14333] Update MARC21 frameworks to Update No. 20 (April 2015) and 21 (September 2015)

2015-10-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14333

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14333] Update MARC21 frameworks to Update No. 20 (April 2015) and 21 (September 2015)

2015-10-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14333

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

--- Comment #5 from Bernardo Gonzalez Kriegel  ---
One patch with cumulative changes from update 20 and 21
Other with label fixes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14333] Update MARC21 frameworks to Update No. 20 (April 2015)

2015-10-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14333

--- Comment #4 from Bernardo Gonzalez Kriegel  ---
Created attachment 43774
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43774&action=edit
Bug 14333: followup - Fix labels

This patch fixes same labels on bibliographic and
authority frameworks, and one typo.

To test:
1) Remove all your frameworks
2) Check mandatory bibliographic and authority files load without problem
3) Check fixed labels

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14333] Update MARC21 frameworks to Update No. 20 (April 2015) and 21 (September 2015)

2015-10-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14333

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

Summary|Update MARC21 frameworks to |Update MARC21 frameworks to
   |Update No. 20 (April 2015)  |Update No. 20 (April 2015)
   ||and 21 (September 2015)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14333] Update MARC21 frameworks to Update No. 20 (April 2015)

2015-10-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14333

--- Comment #3 from Bernardo Gonzalez Kriegel  ---
Created attachment 43773
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43773&action=edit
Bug 14333: Update MARC21 frameworks to Update No. 20 and 21

Default frameworks updated to update 20 (April 2015) and
21 (September 2015)

Update No. 20
Bibliographic
New field 884
New subfields 037$3, 037$5 and 382$e

Authority
New field 884
New subfields 046$q, 046$r and 382$e

Update No. 21
Bibliographic
New tag 348
New subfields 336$0, 337$0 and 338$0

Authority
New field 348
New sufields 336$0 and 670$w

To test:
1) Remove all your frameworks
2) Check mandatory bibliographic and authority files load without problem
3) Check new fields/subfields

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11559] Professional cataloger's interface

2015-10-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559

--- Comment #169 from Nicole C. Engard  ---
(In reply to Jonathan Druart from comment #168)
> The problem with the double-cross chars is that it's not directly
> accessible, except if you now the shortcut. I don't have a strong opinion on
> it, but would like to get other QAer opinions.

I think having the keyboard shortcuts button right there at the top makes it
pretty darn easy. Also I will of course document it in the manual. That's about
all we can do if we're not going to use the $ .

Nicole

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11559] Professional cataloger's interface

2015-10-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559

--- Comment #170 from Nicole C. Engard  ---
Created attachment 43772
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43772&action=edit
shortcuts image

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12904] Force browser to load new javascript files after upgrade

2015-10-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12904

Olli-Antti Kivilahti  changed:

   What|Removed |Added

 CC||olli-antti.kivila...@jns.fi

--- Comment #36 from Olli-Antti Kivilahti  ---
What a great idea!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10344] Omnibus: add RDA support to Koha

2015-10-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10344
Bug 10344 depends on bug 13384, which changed state.

Bug 13384 Summary: RDA: 655 display in XSLT
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13384

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |WONTFIX

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13384] RDA: 655 display in XSLT

2015-10-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13384

Nicole C. Engard  changed:

   What|Removed |Added

 Resolution|--- |WONTFIX
 Status|ASSIGNED|RESOLVED

--- Comment #3 from Nicole C. Engard  ---
On discussing this we have decided we don't need this.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15051] 245 Marc Field Order

2015-10-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15051

Nicole C. Engard  changed:

   What|Removed |Added

 CC||nic...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15051] New: 245 Marc Field Order

2015-10-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15051

Bug ID: 15051
   Summary: 245 Marc Field Order
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Templates
  Assignee: oleon...@myacpl.org
  Reporter: neng...@gmail.com
QA Contact: testo...@bugs.koha-community.org
Depends on: 13381

I have been informed that per marc rules the 245 should display the following
subfields in this order:

a, n, p, h, b, c

Right now we're showing them in 

a, b, c, k, n, p, s

I am unsure of where k and s fit in the scheme of things, but I thought I'd
bring this up to discussion and/or fixing.


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13381
[Bug 13381] RDA: 245 field changes in XSLT
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13381] RDA: 245 field changes in XSLT

2015-10-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13381

Nicole C. Engard  changed:

   What|Removed |Added

 Blocks||15051


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15051
[Bug 15051] 245 Marc Field Order
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14776] SCO/shelfcheck 'log out' option redirects to OPAC, not back to SCO

2015-10-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14776

--- Comment #9 from Chris Kirby  ---
Hi Marc,
I am testing here on Sandbox 8, and here is what I am finding:

testing with AutoSelfCheckAllowed DISABLED:
when one visits /cgi-bin/koha/sco/sco-main.pl there is an option to login. 
However, once logged in, you are redirected to  /cgi-bin/koha/opac-user.pl
If one has already logged into Koha with staff credentials, and then visits
/cgi-bin/koha/sco/sco-main.pl, the patch is successful.

testing with AutoSelfCheckAllowed ENABLED:
Your patch works when the AutoSelfCheckAllowed preference is enabled and login
credentials have been stored.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 9805] Lost items are un-lost if returned, but not if renewed.

2015-10-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9805

Karl Holten  changed:

   What|Removed |Added

 CC||khol...@switchinc.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11139] opac-topissues does not work with CCODE

2015-10-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11139

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com
 Status|Passed QA   |Pushed to Master

--- Comment #19 from Tomás Cohen Arazi  ---
Patch pushed to master.

Thanks Maurice!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14788] Move opac-topissues.pl code into C4::Circulation

2015-10-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14788

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||tomasco...@gmail.com

--- Comment #15 from Tomás Cohen Arazi  ---
Patches pushed to master.

Good job Julian!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15039] Move top language menu to include and streamline logic

2015-10-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15039

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com
 Status|Passed QA   |Pushed to Master

--- Comment #7 from Tomás Cohen Arazi  ---
Patch pushed to master.

Thanks Marc!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10937] Option to hide and group itemtypes from advanced search

2015-10-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com
 Status|Passed QA   |Pushed to Master

--- Comment #65 from Tomás Cohen Arazi  ---
Patches pushed to master.

Thanks Ahmed and Philippe!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14670] add 'cite' option to detail page in OPAC

2015-10-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670

--- Comment #5 from Martin Stenberg 
 ---
Created attachment 43771
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43771&action=edit
Bug 14670: add test for C4::Record::marc2cites

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14670] add 'cite' option to detail page in OPAC

2015-10-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670

--- Comment #4 from Martin Stenberg 
 ---
Created attachment 43770
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43770&action=edit
Bug 14670: add related css changes to opac.less

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14248] Optionally display authorship for news items

2015-10-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14248

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #20 from Katrin Fischer  ---
If you are ok with the tests, signing them off is perfectly fine. Just
important you don't sign your own things :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14248] Optionally display authorship for news items

2015-10-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14248

--- Comment #19 from Martin Persson  ---
Not sure if it is enough to sign off on tests for my own code made by a third
party, but there you go. Not touching status. All tests passes on a clean test
system.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14248] Optionally display authorship for news items

2015-10-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14248

Martin Persson  changed:

   What|Removed |Added

  Attachment #43766|0   |1
is obsolete||

--- Comment #18 from Martin Persson  ---
Created attachment 43769
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43769&action=edit
Bug 14248: Regression tests requested

TEST PLAN
-
1) apply patch
2) prove -v t/db_dependent/NewsChannels.t
3) run koha qa test tools.

Signed-off-by: Martin Persson 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15042] Barcode yymm0001 does not work when receiving serials

2015-10-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15042

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com
 Status|Passed QA   |Pushed to Master

--- Comment #9 from Tomás Cohen Arazi  ---
Patch pushed to master.

Thanks Magnus!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12194] Some fonts don't work on printing label

2015-10-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12194

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com
 Status|Passed QA   |Pushed to Master

--- Comment #18 from Tomás Cohen Arazi  ---
Patches pushed to master.

Thanks Dobrica, Bernardo and Joanthan!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15027] Typo in GetItemsForInventory POD

2015-10-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15027

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com
 Status|Passed QA   |Pushed to Master

--- Comment #5 from Tomás Cohen Arazi  ---
Patch pushed to master.

Thanks Mark!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

  1   2   >