[Koha-bugs] [Bug 14248] Optionally display authorship for news items

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14248

--- Comment #26 from Katrin Fischer  ---
I was not sure if it was from your specification that it showed up in the patch
- so I didn't want to remove it totally. We still could I guess - it will show
now by default until you remove it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14248] Optionally display authorship for news items

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14248

--- Comment #25 from Viktor Sarge  ---
Thanks Katrin! 

We don't use title either, but we solved that by removing the field in the "add
patron" form and without any value in the field things display ok without
having to mod other areas/reports that includes title. I like the span
approach.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11559] Professional cataloger's interface

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559

--- Comment #179 from Nicole Engard (ByWater)  ---
Great job Jesse and Katrin! Three years in the making - let's get this in to
3.22 for production testing!!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11559] Professional cataloger's interface

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559

--- Comment #178 from Jesse Weaver  ---
Created attachment 43969
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43969&action=edit
Bug 11559: (QA followup) fix QA issues

This fixes the following:
  * License of editor.pl
  * Remove tabs
  * Use [% interface %]
  * Re-order search fields like the old interface
  * Add license information for new libraries

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches.

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297

--- Comment #23 from David Cook  ---
(In reply to Katrin Fischer from comment #22)
> Hi David,
> thx for the quick reply and the examples - I'll say that reasolved that
> point in my list. Your examples would be great for the help page.

I keep meaning to update the manual and help pages in regards to Zebra and
Z39.50... I'll keep this on my to do list!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11559] Professional cataloger's interface

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559

--- Comment #177 from Katrin Fischer  ---
Some late (sorry!) first notes on this:

1) Please check with the QA script, it's noting several problems.
 FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/editor.tt
   FAIL   forbidden patterns
forbidden pattern: intranet-tmpl should certainly replaced with
[% interface %] (line 6)
 FAIL   koha-tmpl/intranet-tmpl/prog/en/includes/cateditor-ui.inc
   FAIL   forbidden patterns
forbidden pattern: tab char (line 48)
forbidden pattern: tab char (line 52)
forbidden pattern: tab char (line 43)
forbidden pattern: intranet-tmpl should certainly replaced with
[% interface %] (line 1)
forbidden pattern: tab char (line 45)
forbidden pattern: intranet-tmpl should certainly replaced with
[% interface %] (line 7)
forbidden pattern: tab char (line 50)
forbidden pattern: intranet-tmpl should certainly replaced with
[% interface %] (line 3)
forbidden pattern: intranet-tmpl should certainly replaced with
[% interface %] (line 4)
forbidden pattern: tab char (line 47)
forbidden pattern: intranet-tmpl should certainly replaced with
[% interface %] (line 2)
forbidden pattern: tab char (line 49)
forbidden pattern: tab char (line 46)
forbidden pattern: tab char (line 44)
forbidden pattern: tab char (line 51)
 FAIL   cataloguing/editor.pl
   FAIL   forbidden patterns
forbidden pattern: Koha is now under the GPLv3 license (line 9)
... and also some problems with tabs.

2) Please add the newly added Javascript libraries with their license to the
listing on the about page. I saw:
  codemirror-compressed.js 
  filesaver.js
  require.js

3) Pretty please: Resort in a logical way - for now copying the old sequence
would be nice. Alphabetic sorting doesn't work in I18N environments and it's
not very practical - author and title being far apart
Also... current sorting is not even alphabetical (publication date) :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15058] New: Update German web installer sample files for 3.22

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15058

Bug ID: 15058
   Summary: Update German web installer sample files for 3.22
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: I18N/L10N
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org
CC: frede...@tamil.fr, mi...@abunchofthings.net,
ve...@veron.ch

The same procedure as ... every 6 months... :)

We need to check the files are still all good and translate anything that was
added since last version.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14725] Searching by Author limited to 245$c on Koha 3.12.04.000

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14725

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
 Status|NEW |RESOLVED
 Resolution|--- |WORKSFORME

--- Comment #1 from Katrin Fischer  ---
Hi Jesus, I know this is working in current versions of Koha - please reopen if
you still experience problems in later versions.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4158] cannot create list whose title is '0'

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4158

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
 Status|Patch doesn't apply |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4158] cannot create list whose title is '0'

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4158

Katrin Fischer  changed:

   What|Removed |Added

 Status|ASSIGNED|NEW

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2601] Order fines by date and time

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2601

Katrin Fischer  changed:

   What|Removed |Added

 Status|ASSIGNED|NEW

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 2601] Order fines by date and time

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2601

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
 Status|Failed QA   |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3886] Can't print receipt w/out allowing "Add or modify borrowers" permission

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3886

Katrin Fischer  changed:

   What|Removed |Added

 Status|Patch doesn't apply |ASSIGNED
 CC||katrin.fisc...@bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 3886] Can't print receipt w/out allowing "Add or modify borrowers" permission

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3886

Katrin Fischer  changed:

   What|Removed |Added

 Status|ASSIGNED|NEW

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14915] Use Font Awesome instead of Glyphicons for the staff intranet

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14915

--- Comment #22 from Katrin Fischer  ---
Some comments about this:

- It looks like the patch assumed that the file names from Glyphicons and Font
Awesome would match. They do not. This led to a bit of silliness in QA
follow-ups... (7).

- Not always there is an equivalent icon available in Font Awesome. I have
tried to pick an icon close to our original one or come up with a good
alternative suggestion - the ones that changed most would be (Glyphicon name):
hdd, zoom-in, zoom-out, hold.

- Especially hold is a hard one - the best I could come up with was
sticky-note-o. But then I learned that this was only added in Font Awesome 4.4,
while bug bug 13696 adds 4.3. The patch is marked - the result is the same with
and without the patch currently - no icon shown.

- The git grep ... statements given in the first patch now come back
'non-empty' - as we have added more icons with some of the new features being
pushed. Most of the files seem to belong to the label creators. It would be
good to follow-up on those and others before release.

I like that the Font Awesome Icons look nicer - less pixelated than our current
ones, especially if you zoom in. But there are some catches like that we have
to replace some of the icons. Leaving to RM for final decision and
review/pushing back to QA :)

My recommendation would be to update to 4.4 (makes sense to start with the
newest set) and to do follow-ups once the new features have been pushed to fix
the remaining or newly introduced icons.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14915] Use Font Awesome instead of Glyphicons for the staff intranet

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14915

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #43959|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14915] Use Font Awesome instead of Glyphicons for the staff intranet

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14915

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #43277|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14915] Use Font Awesome instead of Glyphicons for the staff intranet

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14915

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #43275|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14915] Use Font Awesome instead of Glyphicons for the staff intranet

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14915

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14915] Use Font Awesome instead of Glyphicons for the staff intranet

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14915

--- Comment #21 from Katrin Fischer  ---
Created attachment 43968
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43968&action=edit
Bug 14915: QA Follow-up - Replace fa-time with fa-clock-o

Icon looks almost the same, just has a different name.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14915] Use Font Awesome instead of Glyphicons for the staff intranet

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14915

--- Comment #18 from Katrin Fischer  ---
Created attachment 43965
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43965&action=edit
Bug 14915: QA Follow-up - Replace fa-zoom-in and fa-zoom-out

Same icons don't appear to exist for Font awesome.
Replaced with fa-folder and fa-folder-open for now.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14915] Use Font Awesome instead of Glyphicons for the staff intranet

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14915

--- Comment #17 from Katrin Fischer  ---
Created attachment 43964
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43964&action=edit
Bug 14915: QA Follow-up - Replace fa-downlowd-alt with fa-download

Fixes non-existing fa-download-alt by using fa-download instead.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14915] Use Font Awesome instead of Glyphicons for the staff intranet

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14915

--- Comment #16 from Katrin Fischer  ---
Created attachment 43963
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43963&action=edit
Bug 14915: QA Follow-up - Replace fa-hdd with fa-save

Alternative patch to using hdd-o.

As the Font Awesome Icon is different to what we used before,
an alternative could be switching back to the 'classic' symbol
for save.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14915] Use Font Awesome instead of Glyphicons for the staff intranet

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14915

--- Comment #19 from Katrin Fischer  ---
Created attachment 43966
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43966&action=edit
Bug 14915: QA Folloq-up - Replace fa-merge with fa-compress

Another icon that doesn't quite exist in Font Awesome -
this is starting to get a bit troublesome.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14915] Use Font Awesome instead of Glyphicons for the staff intranet

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14915

--- Comment #20 from Katrin Fischer  ---
Created attachment 43967
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43967&action=edit
Bug 14915: [FA 4.4] QA Follow-up - Replace fa-hold with fa-sticky-note-o

Ok, this is a fun one: There is no icon like our current hold icon
in Font Awesome. So I picked fa-sticky-note-o for a replacement.

But since this is a new one, it doesn't exist in Koha yet.
I found no better match and the patch was already written...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14915] Use Font Awesome instead of Glyphicons for the staff intranet

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14915

--- Comment #14 from Katrin Fischer  ---
Created attachment 43961
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43961&action=edit
[PASSED QA] Bug 14915 [QA Followup] - Tweak '+' icon for serials-home

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14915] Use Font Awesome instead of Glyphicons for the staff intranet

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14915

--- Comment #13 from Katrin Fischer  ---
Created attachment 43960
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43960&action=edit
[PASSED QA] Bug 14915 - Use Font Awesome instead of Glyphicons for the staff
intranet

We should be using Font Awesome for our icons instead of Glyphicons, for
the reasons discussed on bug 13696.

Test Plan:
1) Apply this patch
2) Note all Glyphicons have been replaced with FA icons in the staff intranet
3) git grep "icon-" ./koha-tmpl/intranet-tmpl/prog/en/modules/
   should give no results
4) git grep "icon-" ./koha-tmpl/intranet-tmpl/prog/en/includes/
   should give no results

Signed-off-by: Marc Véron 
Signed-off-by: Katrin Fischer 
We need a follow-up to cover the files changes since this
patch was written. Especially to cover the changes in the
label creator modules.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14915] Use Font Awesome instead of Glyphicons for the staff intranet

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14915

--- Comment #12 from Katrin Fischer  ---
Created attachment 43959
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43959&action=edit
[PASSED QA] Bug 13696 [QA Followup] - Add Font Awesome license to the about
page

Signed-off-by: Jonathan Druart 
Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14915] Use Font Awesome instead of Glyphicons for the staff intranet

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14915

--- Comment #15 from Katrin Fischer  ---
Created attachment 43962
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43962&action=edit
Bug 14915: QA Follow-up - Replace fa-remove-sign with fa-times-circle

Noticed that an icon was missing in the templates.

Replaced fa-remove-sign with same-looking fa-times-circle.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072

--- Comment #36 from Marc Véron  ---
Depends on 13 bugs left to sign off as of today (see list in Bug 14870).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14870] Delete C4/Dates.pm from System

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870

--- Comment #3 from Marc Véron  ---
13 patches left to sign-off as of today

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14903] Remove C4::Dates from circ/circulation.pl

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14903

Marc Véron  changed:

   What|Removed |Added

   Patch complexity|Trivial patch   |Small patch
 Status|In Discussion   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14903] Remove C4::Dates from circ/circulation.pl

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14903

Marc Véron  changed:

   What|Removed |Added

  Attachment #43303|0   |1
is obsolete||

--- Comment #13 from Marc Véron  ---
Created attachment 43958
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43958&action=edit
Bug 14903 - Remove C4::Dates from circ/circulation.pl (and more)

Patch to remove deprectated C4::Dates from:
- circ/circulation.pl
- C4/Circulation.pm
- koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt

To test:
- Apply patch
- Go to the checkout site (Home > Circulation > Checkouts)
- Verify that data displays properly (including for users with a card
  that expires in the  near future, see syspref 'NotifyBorrowerDeparture')
- Search for regressions
- prove -v t/db_dependent/Circulation.t

(Amended following comment #9 / #11  25.10.2015 /mv)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14903] Remove C4::Dates from circ/circulation.pl

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14903

--- Comment #12 from Marc Véron  ---
(In reply to Mirko Tietgen from comment #9)
 (...)
> using wrong preset dates in the URL like
> circulation.pl?borrowernumber=51&duedatespec=10%2F30%2F2015+23%3A59
> 
> While the old version shows warnings or even breaks ("30" in the "month"
> position leads to a software error because it is not between 1 and 12), with
> your patch the wrong format passed by URL is displayed in the calendar, but
> no warnings or errors appear and the correct date is used when checking out. 
(...)

MV: Found, will be fixed in amended patch: Date will not be displayed if params
do not result in a correct date.

> (In reply to Marc Véron from comment #6)
> 
> > - Verify that data displays properly (including for users with a card
> >   that expires in the  near future, see syspref 'NotifyBorrowerDeparture')
> 
> That breaks it for me:
> 
> > Template process failed: undef error - KohaDates: filter not found at 
> > /home/mirko/koha/C4/Templates.pm line 121.

(...)
MV: Found, was due to a typo, will be fixed in amended patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14954] Remove C4::Dates from holiday related files in folder tools

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14954

Marc Véron  changed:

   What|Removed |Added

 Status|In Discussion   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14954] Remove C4::Dates from holiday related files in folder tools

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14954

Marc Véron  changed:

   What|Removed |Added

  Attachment #43410|0   |1
is obsolete||

--- Comment #8 from Marc Véron  ---
Created attachment 43957
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43957&action=edit
Bug 14954 - Remove C4::Dates from holiday related files in folder tools

This patch removes C4::Dates from:
Remove C4::Dates from:

- tools/exceptionHolidays.pl
- tools/holidays.pl
- tools/newHolidays.pl
- C4/Calendar.pm

To test:
- Go to Home > Tools > Calendar
- Add, edit, delete the different types of holidays and exceptions
- git grep 'C4::Calendar' and test such files
- prove t/Calendar.t

(Amended following comments #3 and #4 / mv)
(Amended following comment #7 / 25.10.2015 / mv

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14931] Remove C4::Dates from files admin/aq*.pl

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14931

Marc Véron  changed:

   What|Removed |Added

  Attachment #43427|0   |1
is obsolete||

--- Comment #8 from Marc Véron  ---
Created attachment 43956
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43956&action=edit
Bug 14931 - (Follow-up) Validate date entry in contracts

 Go to Home > Acquisitions, search for an active vendor and view the vendor
- Click on 'Contracts' at the left
  (admin/aqcontract.pl)
- Create and edit contracts and verify that it works OK.
  (Note: there is no help for this page, see Bug 14929)

Amended for comment #7  25.10.2015 / mv

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14931] Remove C4::Dates from files admin/aq*.pl

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14931

Marc Véron  changed:

   What|Removed |Added

 Status|In Discussion   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14985] Remove C4::Dates from 6 files in folder C4/*.pm

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14985

Marc Véron  changed:

   What|Removed |Added

Summary|Remove C4::Dates from files |Remove C4::Dates from 6
   |in folder C4/*.pm (part |files in folder C4/*.pm
   |one)|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14965] Remove C4::Dates from 'lists' in folder reports

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14965

Marc Véron  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14965] Remove C4::Dates from 'lists' in folder reports

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14965

Marc Véron  changed:

   What|Removed |Added

  Attachment #43163|0   |1
is obsolete||

--- Comment #4 from Marc Véron  ---
Created attachment 43955
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43955&action=edit
Remove C4::Dates from 'lists' in folder reports

Remove C4::Dates from:

- reports/bor_issues_top.pl
- reports/borrowers_out.pl
- reports/cat_issues_top.pl
- reports/itemslost.pl

To test:

- Go to Home > Reports
- Verify that following reports behave as before:
  - 'Patrons with the most checkouts (reports/bor_issues_top.pl)
  - 'Most circulated items' (reports/cat_issues_top.pl)
  - 'Patrons who haven't checked out (reports/borrowers_out.pl)
  - 'Items lost'

Amended to fix issue with reports/borrowers_out.pl / see comment #3

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14946] Remove C4::Dates from files acqui/*.pl

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14946

Marc Véron  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14946] Remove C4::Dates from files acqui/*.pl

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14946

Marc Véron  changed:

   What|Removed |Added

  Attachment #43144|0   |1
is obsolete||

--- Comment #4 from Marc Véron  ---
Created attachment 43954
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43954&action=edit
Bug 14946 - Remove C4::Dates from files acqui/*.pl

This patch removes C4::Dates from:
- acqui/histsearch.pl
- acqui/invoice.pl
- acqui/invoices.pl
- acqui/orderreceive.pl
- acqui/parcel.pl
- acqui/parcels.pl
- acqui/transferorder.pl

To test:

- Apply patch
- Go to Home > Acquisitions > Invoices
- Verify that Search filters work OK
- Edit an invoice
- Verify that Shipment date and Billing date display OK
  and edit / save is OK
- Receive shipment for a vendor
- Verify that Shipment date behaves OK and that you
  can filter list of shipents for this vendor
- Transfer an item from a basket to another vendor

Amended to make patch apply 25.10.2015/mv

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12803] Add ability to skip closed libraries when generating the holds queue

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #41 from Katrin Fischer  ---
Not much help here I am afraid, but adding to the weirdness.
Tests passed the second time I ran them, then they kept failing constantly.
Additional weirdness: it's not always the same tests failing:

Sometimes: perl t/db_dependent/HoldsQueue.t

...
not ok 23 - Holds not filled with items from closed libraries
#   Failed test 'Holds not filled with items from closed libraries'
#   at t/db_dependent/HoldsQueue.t line 337.
#  got: '1'
# expected: '2'


Other times: perl t/db_dependent/HoldsQueue.t
...
not ok 21 - Holds not filled with items from closed libraries
#   Failed test 'Holds not filled with items from closed libraries'
#   at t/db_dependent/HoldsQueue.t line 320.
#  got: '2'
# expected: '1'
ok 22 - Holds queue filling correct number for holds for default holds policy
'from any library'
not ok 23 - Holds not filled with items from closed libraries
#   Failed test 'Holds not filled with items from closed libraries'
#   at t/db_dependent/HoldsQueue.t line 337.
#  got: '3'
# expected: '2'
ok 24 - Bug 14297 - Holds Queue building ignoring holds where pickup & home
branch don't match and item is not from least cost branch
# Looks like you failed 2 tests of 24.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14310] Add ability to suspend and resume individual holds from the patron holds table

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14310

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA
 CC||katrin.fisc...@bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14310] Add ability to suspend and resume individual holds from the patron holds table

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14310

--- Comment #23 from Katrin Fischer  ---
Comment on attachment 43831
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43831
Bug 14310 - Suspend and resume indvidual holds from patron holds table

Review of attachment 43831:
 --> 
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=14310&attachment=43831)
-

Hi Kyle,

I have patches from the 2 dependent bugs and this one. QA script is clean, but
code review and testing showed 2 big problems:

1) Suspending holds doesn't work for me, clicking on Suspend with or without a
date - nothing happens.
Tested from /cgi-bin/koha/members/moremember.pl?borrowernumber=1
Firebug:
Post: reserve_id=407&suspend_until=31%2F10%2F2015
Response:  error page.

2) Almost all the new strings are not translatable, because they are trapped
inside the .js file.

::: koha-tmpl/intranet-tmpl/prog/en/js/holds.js
@@ +129,5 @@
> +if ( oObj.found ) {
> +return "";
> +} else if ( oObj.suspend == 1 ) {
> +return " id='resume" + oObj.reserve_id + "' style='display: inline; white-space: 
> nowrap;'>"
> + + " " + 
> _("Resume") + "";

.js files are not translatable - we need to move the strings to the templates
or find another solution to this.

@@ +132,5 @@
> +return " id='resume" + oObj.reserve_id + "' style='display: inline; white-space: 
> nowrap;'>"
> + + " " + 
> _("Resume") + "";
> +} else {
> +return " id='suspend" + oObj.reserve_id + "' style='display: inline; white-space: 
> nowrap;'>"
> + + " " + 
> _("Suspend") + "";

Same as above, and many more below.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14376] Allow the librarian to choose a patron when entering a purchase suggestion

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14376

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #17 from Katrin Fischer  ---
Hi Matthias, 

I've taken a look at the code and the GUI, but there are some small and some
bigger things bothering me:

1) Display of patron names (trivial)

+.append( "" + item.surname + ", " + item.firstname + ", " +
item.branch + "" )
Please also think about the case where the patron has no firstname
(organisations for example)

2) Logging

+my $member = GetMember(borrowernumber =>
$$suggestion_only{'suggestedby'});
+logaction('ACQUISITIONS', 'MODIFY', undef, 'Suggestion title: ' .
$$suggestion_only{'title'} . ", creator: " .
+   $member->{'surname'} . ', ' .
+   $member->{'firstname'} . ' (' .
+   $member->{'cardnumber'} . ')'
);

a) I think we need to make more clear about which action in acquisitions this
entry is about. I'd suggest to either add a new module 'SUGGESTIONS' 
or to be more clear about the action: 'MODIFY SUGG' or similar.

b) For privacy reasons I am also quite uncomfortable about adding the name 
in plain text to the logs. We don't need this information if we reference
the borrowernumber instead and it will also be better for privacy.
For me this is a (blocker).

c) Why are you leaving the object undef? I feel like this should be the
suggestion id. Then we could just have the borrowernumber in the
description. All other information can easily be found.

d) I think the new logging needs to be covered by a system preference 
to be consistent with current practice.

-- 
Don't misunderstand me - I really think we should do more nice logging!
But I think we should try to avoid some of the problems we had with it
in the past. One idea might even be to add a new column to action_logs to
be able to store another id in a better way (user, object, affected_user?)

3) GUI

I'd prefer the way patron search is done in other places taking place
in a separate pop-up or modal. Because it offers a better overview
for libraries with a lot of patrons and better options to limit search.
An example would be the way it's done for searching patrons to be
notified about an order (when creating an order line).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #43930|0   |1
is obsolete||

--- Comment #65 from Kyle M Hall  ---
Created attachment 43953
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43953&action=edit
Bug 12933: QA Followq-up - Add missing notice templates and other small fixes

- Fixes page title of slip print window: Members > Patrons
- Fixes error message if no notice template is found
- Fixes a stray template variable that resulted in the
  borrower number showing in the 'Print' pull down
- Fixes xt/sample_notices.t by adding the sample notice to
  it-IT and es-ES

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14694] Make decreaseloanHighHolds more flexible

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14694

--- Comment #21 from Kyle M Hall  ---
Created attachment 43952
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43952&action=edit
Bug 14694 [QA Followup] - Fix syspref order

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14694] Make decreaseloanHighHolds more flexible

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14694

--- Comment #20 from Kyle M Hall  ---
(In reply to Jonathan Druart from comment #18)
> (In reply to Kyle M Hall from comment #17)
> > > 6 vs 5
> > 
> > That is a purposeful change. The issue was that the logic of the unit test
> > was off by one. The assumption was that the number of holds must greater
> > than or equal to, but as per the code and sys pref definition, the number of
> > holds must be simply greater than. Thus adding one more hold fixes all the
> > tests.
> 
> (In reply to Jonathan Druart from comment #14)
> > > +if ( $holds->count() <= $threshold ) {
> > 
> > And an inclusive here.
> 
> So should this be < also?

No, that is the correct comparison. If you look at the descritions for the two
high holds behavior options you will see the static ( original ) version
requires a < comparison, and the new dynamic versions needs <=.

> > ::: Koha/Biblio.pm
> > @@ +41,5 @@
> > > +or list of Koha::Item objects in list context.
> > > +
> > > +=cut
> > > +
> > > +sub items {
> > 
> > Wouldn't be better to use a DBIx::Class relation?
> > Something like bug 14819.

No, we want to return a Koha::Object object, not a DBIC object. It would be
most confusing if a Koha::Object method were to return a DBIC object instead of
a Koha Object.

> 
> What about these 2 comments?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14694] Make decreaseloanHighHolds more flexible

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14694

Kyle M Hall  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14980] Add a page showing one news

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14980

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14980] Add a page showing one news

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14980

--- Comment #15 from Katrin Fischer  ---
Comment on attachment 43404
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43404
Bug 14980 - Add a page showing one news

Review of attachment 43404:
 --> 
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=14980&attachment=43404)
-

Some small issues, noted below, and 2 other things:

1) You can access internal news (staff interface) via guessing ids. (blocker)
2) The feature is too hidden for my taste as we don't even show the id
internally. A link 'Show in OPAC' or similar could be helpful.

I'd also like to encourage you to talk to Viktor Sarge - I know he has been
working on adding a 'Mini-CMS' feature to Koha and I think there are already
some patches for small steps in that direction available on bugzilla.

::: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-page.tt
@@ +29,5 @@
> +
> +
> +[% data.title | html %]
> +[% data.new %]
> +(published on [% 
> data.expirationdate %])

Please take a look at bugs 14246-14246 - it's a new feature that just passed QA
that will allow to also display the author of a news.

::: opac/opac-page.pl
@@ +15,5 @@
> +# You should have received a copy of the GNU General Public License
> +# along with Koha; if not, see .
> +
> +use strict;
> +use warnings;

Please always use Modern::Perl;

@@ +31,5 @@
> +{
> +template_name   => "opac-page.tt",
> +query   => $query,
> +type=> "opac",
> +authnotrequired => 1,

Please check if this should be:
authnotrequired => ( C4::Context->preference("OpacPublic") ? 1 : 0 ),

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14980] Add a page showing one news

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14980

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de,
   ||viktor.sarge@regionhalland.
   ||se

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12395] Save order line's creator

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #69 from Katrin Fischer  ---
1) xt/tt_valid.t was failing, I fixed it in my follo-up, please check.
1..3
ok 1 - TT syntax: not using TT directive within HTML tag
not ok 2 -  tag with id and class attributes
#   Failed test ' tag with id and class attributes'
#   at xt/tt_valid.t line 91.
# Files list: 
# intranet-tmpl/prog/en/modules/acqui/showorder.tt: 12
ok 3 - Token received same as original put on stack
# Looks like you failed 1 test of 3.

2) Some of the title="MARC" should be title="Card" - fixed in my follow-up,
please check.

3) t/db_dependent/Acquisition/NewOrder.t fails, please fix (blocker) :(
I think it's not only the test - in my testing the creator is not saved for
newly created orders. Only the 'migrated' orders have created_by set in the
database.
1..8
ok 1 - Inserting an order with no params returns undef and croaks
ok 2 - Inserting an order with no budget_id returns undef and croaks with
expected error message
ok 3 - Inserting an order with no biblionumber returns undef and croaks with
expected error message
ok 4 - Inserting an order with no basketno returns undef and croaks with
expected error message
ok 5 - Inserting an order with no quantity returns undef and croaks with
expected error message
ok 6 - Koha::Acquisition::Order->insert set quantityreceivedto 0 if undef is
given
ok 7 - Koha::Acquisition::Order->insert set entrydate to today
not ok 8 - Koha::Acquisition::Order->insert set created_by to logged in user if
not given
#   Failed test 'Koha::Acquisition::Order->insert set created_by to logged in
user if not given'
#   at t/db_dependent/Acquisition/NewOrder.t line 93.
#  got: undef
# expected: '42'
# Looks like you failed 1 test of 8.

4) The 'look' of the new modal for order information is slightly off,
especially font and font-size are unusual. Would be nice to be 
more consistent with Koha's look and feel here.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12395] Save order line's creator

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

--- Comment #68 from Katrin Fischer  ---
Created attachment 43951
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43951&action=edit
Bug 12395: QA follow-up - Add class/id to body tag and fix title description

- Fixes title attribute for some of the new links
- Adds a unique id and a class to the new modal (xt/tt_valid.t)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11881] Small improvements in OPAC results list.

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11881

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #43947|0   |1
is obsolete||

--- Comment #47 from Katrin Fischer  ---
Created attachment 43950
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43950&action=edit
[OPTIONAL] Bug 11881: QA follow-up - rename class

A suggestion for renaming the class to be a bit more "content" then
"appearance".
Strictly optional.

.ItemSummary {
display: block; # block - line breaks, inline - all one line
}

.LabelCallNumber {
display: inline; # inline - display, none - don't display
}

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11881] Small improvements in OPAC results list.

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11881

--- Comment #46 from Katrin Fischer  ---
Created attachment 43949
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43949&action=edit
[PASSED QA] Bug 11881 - Small improvements for Items available for reference

As said on comment #31, Items available for reference weren't displayed like
Items avaible for loan. Now, they are, I wrapped them in CommasWithLinebreaks
class and LabelCallNumber class

Signed-off-by: Nick Clemens 

Signed-off-by: Jonathan Druart 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11881] Small improvements in OPAC results list.

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11881

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #43946|0   |1
is obsolete||

--- Comment #45 from Katrin Fischer  ---
Created attachment 43948
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43948&action=edit
[PASSED QA] Bug 11881: Small improvements for the availability informations in
the search results list on the OPAC

This patch contains small modifications to the template of OPAC search results.
Theses modifications affect the "Availability" line :
* Add a linebreak after each location.
* Add the text "Call Number:" before call numbers.

To test:

I) Apply the patch

II) Include the following test in the OPACUserCSS preference:

.searchresults .CommasWithLinebreaks {
display: block; # block - line breaks, inline - all one line
}

.searchresults .LabelCallNumber {
display: inline; # inline - display, none - don't display
}

III) Do a search on the OPAC

IV) Validate : check the format of availability informations for each search
result (Breakline or "Call Number:" text).

Sponsored-by: CCSR ( http://www.ccsr.qc.ca )

Signed-off-by: Nick Clemens 

Signed-off-by: Jonathan Druart 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11881] Small improvements in OPAC results list.

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11881

--- Comment #44 from Katrin Fischer  ---
Created attachment 43947
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43947&action=edit
[OPTIONAL] Bug 11881: QA follow-up - rename class

A suggestion for renaming the class to be a bit more "content" then
"appearance".
Strictly optional.

.ItemSummary {
display: block; # block - line breaks, inline - all one line
}

.LabelCallNumber {
display: inline; # inline - display, none - don't display
}

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11881] Small improvements in OPAC results list.

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11881

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11881] Small improvements in OPAC results list.

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11881

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #42807|0   |1
is obsolete||
  Attachment #42808|0   |1
is obsolete||

--- Comment #43 from Katrin Fischer  ---
Created attachment 43946
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43946&action=edit
[PASSED QA] Bug 11881: Small improvements for the availability informations in
the search results list on the OPAC

This patch contains small modifications to the template of OPAC search results.
Theses modifications affect the "Availability" line :
* Add a linebreak after each location.
* Add the text "Call Number:" before call numbers.

To test:

I) Apply the patch

II) Include the following test in the OPACUserCSS preference:

.searchresults .CommasWithLinebreaks {
display: block; # block - line breaks, inline - all one line
}

.searchresults .LabelCallNumber {
display: inline; # inline - display, none - don't display
}

III) Do a search on the OPAC

IV) Validate : check the format of availability informations for each search
result (Breakline or "Call Number:" text).

Sponsored-by: CCSR ( http://www.ccsr.qc.ca )

Signed-off-by: Nick Clemens 

Signed-off-by: Jonathan Druart 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11881] Small improvements in OPAC results list.

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11881

--- Comment #42 from Katrin Fischer  ---
No problem with the patch itself, but I am not a fan of the name of the class:
CommasWithLinebreaks
A good rule is not to name classes on appearance, as appearance can change with
CSS, but according to what they contain - something that describes that it's
the item information for one branch maybe.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14190] Scale search boxes in staff head

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14190

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #7 from Katrin Fischer  ---
I think this is really a question of taste somehow. I am passing this, as it
can be easily changed back with a line in IntranetUserCSS and we can see how
people like it :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14190] Scale search boxes in staff head

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14190

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #43574|0   |1
is obsolete||

--- Comment #6 from Katrin Fischer  ---
Created attachment 43945
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43945&action=edit
[PASSED QA] Bug 14190: Scale search boxes in staff head

In this simple patch the width gets controlled by CSS and it becomes
easy to set it in just one place.

The exact width may need to be discussed but I thought 30em made it look ok on
my screen.
With this patch we get the wider search boxes with a very small change and
another bug may
be created if needed to do a bigger refactor and remove stuff not needed in the
html and
perhaps do this in a modern/responsive way. (Preferrably a UX/GUI developer
will do this)

To test:

Apply the patch and reload the staff client. Now the search box is a bit wider
and the border
etc has changed with it.

Some places with more than one search box like "Serials" will not be affected.

Signed-off-by: Marc Véron 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14190] Scale search boxes in staff head

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14190

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14889] Move the framework related code to Koha::BiblioFramework[s]

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14889

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
 Status|Signed Off  |Failed QA

--- Comment #6 from Katrin Fischer  ---
I have added a follow-up - but there are 2 things:

1) Please add some unit tests.
2) When you add a new framework with the same frameworkcode than an existing
framework, I think it should display the appropriate message, but instead, it
updates the existing framework description. On current master, you have a
silent SQL erorr in the logs, but the existing framework is left unchanged.
(not ideal either...)

Otherwise this works quite well, so almost there!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14889] Move the framework related code to Koha::BiblioFramework[s]

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14889

--- Comment #5 from Katrin Fischer  ---
Created attachment 43944
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43944&action=edit
Bug 14889: QA Follow-up

- Removes unused package from BiblioFramework.pm
- Makes framework table sortable
- Some small changes in wording of error messages

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15057] New: Exporting Default Framework results in empty file

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15057

Bug ID: 15057
   Summary: Exporting Default Framework results in empty file
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: System Administration
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

To test:
- Go to Administration > Bibliographic frameworks
- In the default framework line: Export > CSV > Open in 
- Note that the file is empty
- Repeat for another framework
- Note that the export works correctly

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14824] Fix sorting of Norwegian vowels

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14824

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #43780|0   |1
is obsolete||

--- Comment #3 from Katrin Fischer  ---
Created attachment 43943
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43943&action=edit
[PASSED QA] Bug 14824 - Fix sorting of Norwegian vowels

Currently, Norwegian vowels are not sorted correctly, even when
you have chosen "nb" as the ZEBRA_LANGUAGE during installation.

To test:
- Make sure you have three records with titles that begin with ÆØÅ
  respectively
- Do a search that turns up those three records and some others, and
  sort the results by title, bot ascending and descending.
- Verify that ÆØÅ is shown in some weird order.
- Edit your sort-string-utf.chr* so it is in line with the current
  patch. It should include these two lines:
  lowercase {0-9}{a-z}æøå
  uppercase {0-9}{A-Z}ÆØÅ
- Restart Zebra and reindex all the records, e.g.:
  $ sudo koha-restart-zebra 
  $ sudo koha-rebuild-zebra -f -v 
- Do the search again, make sure you order by title and check that
  ÆØÅ are sorted in the order of 1. Æ 2. Ø 3. Å, and after all other
  characters

* = If you are on a gitified install, you need to edit this file:
/etc/koha/zebradb/lang_defs//sort-string-utf.chr
NOT the file in your git clone (yeah, i wasted some time there...)

Signed-off-by: Mirko Tietgen 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14824] Fix sorting of Norwegian vowels

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14824

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15056] hold-transfer-slip.pl print "No hold found"

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15056

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #1 from Katrin Fischer  ---
mustageeem, please check that you have your notice templates correctly defined
- the error message can appear when the template is missing.

Tools > Notices and Slips > RESERVESLIP

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15056] New: hold-transfer-slip.pl print "No hold found"

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15056

Bug ID: 15056
   Summary: hold-transfer-slip.pl print "No hold found"
 Change sponsored?: ---
   Product: Koha
   Version: 3.20
  Hardware: All
OS: All
Status: NEW
  Severity: major
  Priority: P5 - low
 Component: Hold requests
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: mustaqeem...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

Created attachment 43942
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43942&action=edit
print no hold found

Hi,

When items are returned into library and there is a hold placed, after click
"Print slip and confirm", just appear "No hold found". No information at all on
the printed slip.

The example address: 

elib.usm.my:8000/cgi-bin/koha/circ/hold-transfer-slip.pl?borrowernumber=2581&biblionumber=724975
 

Thank you.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/