[Koha-bugs] [Bug 14578] Allow merging of records upon import match

2015-10-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14578

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #1 from Katrin Fischer  ---
Hi Jesse, I'd be very interested in more information about this! Do you have a
spec or can you describe the idea in a few sentences?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14504] Add command-line script to batch delete items based on lost/withdrawn statuses

2015-10-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14504

--- Comment #20 from Jonathan Druart  
---
Comment on attachment 44013
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44013
Bug 14504 QA Fixes -- use TestBuilder, remove do_not_commit

Review of attachment 44013:
 --> 
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=14504&attachment=44013)
-

::: C4/Items.pm
@@ +2378,2 @@
>  
> +DelItemCheck(  $dbh, $biblionumber, $itemnumber );

$dbh shouldn't pass as a parameter.

@@ +2381,4 @@
>  =cut
>  
>  sub DelItemCheck {
> +my ( $dbh, $biblionumber, $itemnumber ) = @_;

$dbh shouldn't pass as a parameter.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14504] Add command-line script to batch delete items based on lost/withdrawn statuses

2015-10-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14504

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #21 from Jonathan Druart  
---
140 "DelItemCheck should delete item if 'do_not_commit' not set"

=> 'do_not_commit' occurrence.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 1985] Email notification of new OPAC comments

2015-10-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4456] Enable addition of PO Number to order

2015-10-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4456

Marc Véron  changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=10454

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10454] Duplicate card numbers may be generated

2015-10-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10454

Marc Véron  changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=4456

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14310] Add ability to suspend and resume individual holds from the patron holds table

2015-10-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14310

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Patch doesn't apply

--- Comment #25 from Jonathan Druart  
---
CONFLICT (content): Merge conflict in t/db_dependent/Hold.t


I think the possible errors should be handle. For instance: An hold suspended
but has been deleted in the meantime, the suspend until date is not valid, etc.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15061] Can't add item to rotating collection

2015-10-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15061

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #1 from Jonathan Druart  
---
Josef,
It looks good here:
http://test-intra.plack.bywatersolutions.com/cgi-bin/koha/rotating_collections/addItems.pl
Could you please detail your issue?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15061] Can't add item to rotating collection

2015-10-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15061

--- Comment #2 from Josef Moravec  ---
Created attachment 44044
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44044&action=edit
rotating collection issue

I'm adding a screenshot of the problem I'm facing

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14977] Remove C4::Dates from files t/db_dependent/*.t

2015-10-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14977

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #6 from Jonathan Druart  
---
The NewsChannels.t test fail for me, with and without the last patch:

With:
#   Failed test 'got back expected news item via get_opac_new - ID 1'
#   at t/db_dependent/NewsChannels.t line 90.
# Structures begin differing at:
#  $got->{expirationdate} = '12/30/2999'
# $expected->{expirationdate} = '30/12/2999'

#   Failed test 'got back expected news item via get_opac_new - ID 2'
#   at t/db_dependent/NewsChannels.t line 112.
# Structures begin differing at:
#  $got->{expirationdate} = '12/31/2999'
# $expected->{expirationdate} = '31/12/2999'
# Looks like you failed 2 tests of 10.


Without:
#   Failed test 'got back expected news item via get_opac_new - ID 1'
#   at t/db_dependent/NewsChannels.t line 90.
# Structures begin differing at:
#  $got->{expirationdate} = '30/12/2999'
# $expected->{expirationdate} = '2999-12-30'

#   Failed test 'got back expected news item via get_opac_new - ID 2'
#   at t/db_dependent/NewsChannels.t line 112.
# Structures begin differing at:
#  $got->{timestamp} = '01/01/2000'
# $expected->{timestamp} = '2000-01-01'
# Looks like you failed 2 tests of 10.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15061] Can't add item to rotating collection

2015-10-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15061

--- Comment #3 from Josef Moravec  ---
I understand now, when I created a new collection, I tried to add items and
somehow was redirected on page addItems without colId parameter... so of course
adding items failed...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14468] Remove warnings when creating Labels

2015-10-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14468

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14468] Remove warnings when creating Labels

2015-10-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14468

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #44015|0   |1
is obsolete||

--- Comment #17 from Jonathan Druart  
---
Created attachment 44045
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44045&action=edit
Bug 14468: followup to fix tests

This patch fix an expected  test result.
Also changes a comparison for the return value to 'delete'
layout sub, in case of success it returns 'undef' and triggers
the message 'use of uninitialized value $del_results ...'

To test:
1) Whitout this patch

prove t/db_dependent/Labels/t_Layout.t

fails.

Also note the message
"Use of uninitialized value $del_results in string ne at
t/db_dependent/Labels/t_Layout.t line 110."
for using the return value of delete layout (undef on success!)

2) Apply the patch
3) Test pass and no more message

Signed-off-by: Marc Véron 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15019] Plack testing - Umbrella

2015-10-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15019

Josef Moravec  changed:

   What|Removed |Added

 Depends on||15066


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15066
[Bug 15066] Transfer rotating collection fails on plack
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15066] Transfer rotating collection fails on plack

2015-10-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15066

Josef Moravec  changed:

   What|Removed |Added

 Blocks||15019


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15019
[Bug 15019] Plack testing - Umbrella
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15066] New: Transfer rotating collection fails on plack

2015-10-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15066

Bug ID: 15066
   Summary: Transfer rotating collection fails on plack
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Tools
  Assignee: gmcha...@gmail.com
  Reporter: josef.mora...@gmail.com
QA Contact: testo...@bugs.koha-community.org

When I tried to transfer rotating collection, I saw "Internal server error",
collection was marked with new location, but items in that collection weren't
marked with new location.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata

2015-10-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642

--- Comment #103 from Frédéric Demians  ---
Here's what I can think of this.

There is already in Koha an inconsistency in the way DC is generated. (1) When
exporting, C4::Record::marc2dcxml() is used. (2) In OAI server, an XSLT
transformation is done using XSL file found in koha-tmpl/intranet-
tmpl/prog/en/xslt. The OAI approach seems more sensible since it allows to
have a transformation logic per MARC flavor, and even in OAI extended mode, a
transformation specific to a Koha installation.

Currently, C4::Record::marc2dcxml() delegates the semantic transformation from
MARC21 to XML DC to this module: MARC::Crosswalk::DublinCore. I don't think
this is a great idea. This is an old-unmaintained module (10 years old). And
it doesn't work for Unimarc. I haven't paid attention to that, but I can't see
how DC export could work with an Unimarc catalog. Your module
Koha::Crosswalk::DublinCore still wraps a call MARC::Crosswalk::DublinCore.

The MARC21 to Unimarc transformation on the fly isn't a good idea at all. This
would add complexity for an unreliable result. 

Why not just fixing XSL files transforming MARCXML biblios into DC and use
them in marc2dcxml()?

Side note about dependencies -- RDF::Trine have Moose as dependency. Aren't we
supposed to avoid that?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata

2015-10-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642

--- Comment #104 from Katrin Fischer  ---
Hi Frederick, thx for your comment! I like the idea of reusing the XSLT.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15061] Can't add item to rotating collection

2015-10-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15061

--- Comment #4 from Jonathan Druart  
---
Please provide a step by step plan to reproduce, I don't get it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14993] rebuild_zebra.pl, when recreating Zebra-directory structure, mkdir doesn't fail/error/die

2015-10-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14993

Olli-Antti Kivilahti  changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |olli-antti.kivila...@jns.fi

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15066] Transfer rotating collection fails on plack

2015-10-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15066

Jonathan Druart  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15066] Transfer rotating collection fails on plack

2015-10-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15066

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
   Assignee|gmcha...@gmail.com  |jonathan.dru...@bugs.koha-c
   ||ommunity.org
   Severity|enhancement |major

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15066] Transfer rotating collection fails on plack

2015-10-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15066

--- Comment #1 from Jonathan Druart  
---
Created attachment 44046
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44046&action=edit
Bug 15066: Make transfer rotating collection works under Plack

This patch the 2 following errors:
Undefined subroutine &C4::RotatingCollections::transferbook called at
C4/RotatingCollections.pm line 451.
Undefined subroutine &C4::RotatingCollections::GetTransfers called at
C4/RotatingCollections.pm line 450.

And this warning:
"my" variable $colId masks earlier declaration in same scope at
/home/koha/src/rotating_collections/transferCollection.pl line 75.

Test plan:
Create a rotating collection
Transfer it to another branch
It should work with this patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14155] Placing holds via ILSDI bypass some checks

2015-10-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14155

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #40175|0   |1
is obsolete||

--- Comment #18 from Alex Arnaud  ---
Created attachment 44047
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44047&action=edit
Add maxreserves and alreadyreserved checks when placing hold via ILSDI

http://bugs.koha-community.org/show_bug.cgi?id=14155

Signed-off-by: Indranil Das Gupta (L2C2 Technologies) 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14155] Placing holds via ILSDI bypass some checks

2015-10-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14155

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #40241|0   |1
is obsolete||

--- Comment #21 from Alex Arnaud  ---
Created attachment 44050
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44050&action=edit
(qa followup) variable declaration and cleanup

1/ running koha qa tools showed up valid FAIL. This patch fix
   that error.

   FAIL t/db_dependent/Reserves.t
 OKcritic
 OKforbidden patterns
 OKpod
 FAIL  valid
"my" variable $title masks earlier declaration in same scope
"my" variable $bibitemnum masks earlier declaration in same
scope

2/ the following redundant line was removed as it had no use:

   t::lib::Mocks::mock_preference('maxreserves', 15);

Signed-off-by: Alex Arnaud (Biblibre) 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14155] Placing holds via ILSDI bypass some checks

2015-10-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14155

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #40176|0   |1
is obsolete||

--- Comment #19 from Alex Arnaud  ---
Created attachment 44048
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44048&action=edit
Bug 14155 - Add tests in t/db_dependent/Reserves.t

- add tests for C4::Reserves::AlreadyReserved(),
- add tests for C4::Reserves::ReachedMaxReserves(),

Signed-off-by: Indranil Das Gupta (L2C2 Technologies) 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14155] Placing holds via ILSDI bypass some checks

2015-10-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14155

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #40240|0   |1
is obsolete||

--- Comment #20 from Alex Arnaud  ---
Created attachment 44049
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44049&action=edit
(fix typo) AddBiblio call in Reserves.t

Fix for the typo, it read :

my ($broken_id, $title, $bibitemnum) = AddBiblio($miniaturist, '');

it should read :

my ($broken_id, $title, $bibitemnum) = AddBiblio($broken, '');

Signed-off-by: Alex Arnaud (Biblibre) 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14078] converting from ISO5426 is not complete

2015-10-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14078

Frédéric Demians  changed:

   What|Removed |Added

  Attachment #38655|0   |1
is obsolete||

--- Comment #10 from Frédéric Demians  ---
Created attachment 44051
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44051&action=edit
Bug 14078 - converting from ISO5426 is not complete

Conversion of MARC from ISO5426 is defined in C4::Charset::char_decode5426().
Each character or combined characters conversion is defined in a map.

This patch changes some odd actual conversions.

In char_decode5426(), only characters between 0xC0 and 0xDF will be used for
combining with following charater :
  ($char >= 0xC0 && $char <= 0xDF)
So conversion like "$chars{0x81d1}=0x00b0" will never be used.
Rules for "h with breve below" use combining with 0xf9 but looks like the
correct caracter is 0xd5.

See http://www.gymel.com/charsets/MAB2.html

Signed-off-by: Frederic Demians 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14078] converting from ISO5426 is not complete

2015-10-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14078

Frédéric Demians  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14078] converting from ISO5426 is not complete

2015-10-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14078

Frédéric Demians  changed:

   What|Removed |Added

  Attachment #38656|0   |1
is obsolete||
  Attachment #44051|0   |1
is obsolete||
 CC||frede...@tamil.fr

--- Comment #11 from Frédéric Demians  ---
Created attachment 44052
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44052&action=edit
Bug 14078 - converting from ISO5426 is not complete

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14078] converting from ISO5426 is not complete

2015-10-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14078

--- Comment #12 from Frédéric Demians  ---
Created attachment 44053
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44053&action=edit
Bug 14078 - converting from ISO5426 is not complete followup1

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12488] bulkmarcimport.pl -d option should use DELETE instead of TRUNCATE

2015-10-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12488

--- Comment #7 from Magnus Enger  ---
Could it be an idea to introduce a command line switch, to let the user choose
between DELETE and TRUNCATE? With TRUNCATE (the current behaviour) as the
default if e.g. --use_delete is not provided?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15067] New: Add additional languages to advanced search language search

2015-10-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15067

Bug ID: 15067
   Summary: Add additional languages to advanced search language
search
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: katrin.fisc...@bsz-bw.de
QA Contact: testo...@bugs.koha-community.org

The language option list in the advanced search can now be configured now, but
not all languages are available. 3 of the missing that should be added are:

Estonian
Latvian
Lithuanian

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14821] Don't show item in checked in list, when it wasn't checked in

2015-10-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14821

Frédéric Demians  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14821] Don't show item in checked in list, when it wasn't checked in

2015-10-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14821

Frédéric Demians  changed:

   What|Removed |Added

  Attachment #42548|0   |1
is obsolete||

--- Comment #2 from Frédéric Demians  ---
Created attachment 44054
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44054&action=edit
Bug 14821: Do not list not returned items

On the checkin page, the table is always filled with info of the scanned
barcode, even if the checkin has failed.
When the checkin fails, there is already an error displayed, so there is
no need to keep a row for fails.

Test plan:
Confirm that the failed checkins don't appear anymore in the checkin
table.
- checkin an item which is not issued;
- BlockReturnOfWithdrawnItems is set and item is withdrawn;
- Not returned at the right place;
- privacy=2 and AnonymousPatron not correctly set;

Before this patch this behavior existed only for bad barcode.

Signed-off-by: Frederic Demians 
  I confirm that the checkin table hasn't to be populated with info on items
  which haven't been checked in.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15066] Transfer rotating collection fails on plack

2015-10-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15066

Josef Moravec  changed:

   What|Removed |Added

  Attachment #44046|0   |1
is obsolete||

--- Comment #2 from Josef Moravec  ---
Created attachment 44055
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44055&action=edit
Bug 15066: Make transfer rotating collection works under Plack

This patch the 2 following errors:
Undefined subroutine &C4::RotatingCollections::transferbook called at
C4/RotatingCollections.pm line 451.
Undefined subroutine &C4::RotatingCollections::GetTransfers called at
C4/RotatingCollections.pm line 450.

And this warning:
"my" variable $colId masks earlier declaration in same scope at
/home/koha/src/rotating_collections/transferCollection.pl line 75.

Test plan:
Create a rotating collection
Transfer it to another branch
It should work with this patch

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15066] Transfer rotating collection fails on plack

2015-10-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15066

Josef Moravec  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14844] Corrupted storable string. When adding/editing an Item, cookie LastCreatedItem might be corrupted.

2015-10-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14844

Frédéric Demians  changed:

   What|Removed |Added

 CC||frede...@tamil.fr

--- Comment #2 from Frédéric Demians  ---
I've already seen that. What web server do you use? and what browsers?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15061] Can't add item to rotating collection

2015-10-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15061

--- Comment #5 from Josef Moravec  ---
I can't reproduce it now as well... the problem was, I think, that collection
ID was lost... but only one way I can reproduce it now is to manually go to
address /cgi-bin/koha/rotating_collections/addItems.pl without any parameter...
but it's not the way used by normal work

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15068] New: Get rid of warnings in members/summary-print.pl

2015-10-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15068

Bug ID: 15068
   Summary: Get rid of warnings in members/summary-print.pl
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: trivial
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: gmcha...@gmail.com
  Reporter: ve...@veron.ch
QA Contact: testo...@bugs.koha-community.org

Printing a summary from a member's detail page can result in a lot of warnings
like:

- use of uninitialized value in sprintf at
/usr/share/kohaclone/members/summary-print.pl line 47

- Use of uninitialized value $roadtype in concatenation (.) or string at
/usr/share/kohaclone/members/summary-print.pl line 61

- Use of uninitialized value in addition (+) at
/usr/share/kohaclone/members/summary-print.pl line 87

- Argument "2015-11-03 23:59:00" isn't numeric in numeric comparison (<=>) at
/usr/share/kohaclone/members/summary-print.pl line 103

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import

2015-10-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

--- Comment #2 from Martin Stenberg 
 ---
Created attachment 44056
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44056&action=edit
Bug 14957: Rule based permission for MARC fields

This patch adds a rule based permission system for MARC field modifications.

Test plan:
1. Apply this patch
2. Apply related database patch
2. Apply related scripts update patch
3. Run updatedatabase.pl
5. Log in to staff client
4. Enable new syspref MARCPermissions
5. You should see a new link "MARC field permissions" in the "Catalog"
   section under "Koha administrtion".
6. Go to the "MARC field permissions" page
7. Next to the page heading ("Manage MARC field permissions") there is a
   button with a question mark, click this for more information about the
   rule system.
8. Add desired rules to the rule table, press the +-button to add.
9. Clicking the pen-icon (edit) should allow you to edit corresponding
rule.
10. Clicking the x-icon should remove corresponding rule after
confirmation.
11. Selecting one or more rules followed by clicking the trash-icon
should remove all selected rules after confirmation.
12. To test your rules, import or in other way modify a record.
13. Check that the record was modified as defined by your rules.

Sponsored-by: Halland County Library

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import

2015-10-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

--- Comment #4 from Martin Stenberg 
 ---
Created attachment 44058
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44058&action=edit
Bug 14957: Add filters to relevant scripts

Add MARCPermissions filters in scripts which modifies MARC records to enable
the
permission system for these scripts.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import

2015-10-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

--- Comment #3 from Martin Stenberg 
 ---
Created attachment 44057
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44057&action=edit
Bug 14957: Database changes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import

2015-10-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

Martin Stenberg  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14836] Move the patron categories related code to Koha::PatronCategories

2015-10-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14836

Frédéric Demians  changed:

   What|Removed |Added

  Attachment #42617|0   |1
is obsolete||

--- Comment #3 from Frédéric Demians  ---
Created attachment 44059
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44059&action=edit
Bug 14836: Use Koha::PatronCategor[y|ies] in admin/categories.pl

Test plan:
Add/edit/remove patron categories from the administration module
(admin/categories.pl).
You should get message feedback after each action.

Signed-off-by: Frederic Demians 
  Operations in admin/category is unchanged, and functionnal

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14836] Move the patron categories related code to Koha::PatronCategories

2015-10-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14836

Frédéric Demians  changed:

   What|Removed |Added

  Attachment #44059|0   |1
is obsolete||

--- Comment #4 from Frédéric Demians  ---
Created attachment 44060
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44060&action=edit
Bug 14836: Use Koha::PatronCategor[y|ies] in admin/categories.pl

Test plan:
Add/edit/remove patron categories from the administration module
(admin/categories.pl).
You should get message feedback after each action.

Signed-off-by: Frederic Demians 
  Operations in admin/category is unchanged, and functionnal

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14836] Move the patron categories related code to Koha::PatronCategories

2015-10-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14836

Frédéric Demians  changed:

   What|Removed |Added

  Attachment #42616|0   |1
is obsolete||

--- Comment #5 from Frédéric Demians  ---
Created attachment 44061
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44061&action=edit
Bug 14836: Add Koha::PatronCategor[y|ies] classes

Note that some of the routines are retrieved from bug 10363 (branch
limitations).
They are not all used in these patch set, but they will permit to
replace the subroutines in C4::Form::MessagingPreferences, in the next
step.

Signed-off-by: Frederic Demians 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14836] Move the patron categories related code to Koha::PatronCategories

2015-10-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14836

Frédéric Demians  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15068] Get rid of warnings in members/summary-print.pl

2015-10-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15068

--- Comment #1 from Marc Véron  ---
Created attachment 44062
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44062&action=edit
Bug 15068 - Get rid of warnings in members/summary-print.pl

This patch removes warnings when printing a summary from a member's detail
page, like:

- use of uninitialized value in sprintf
  at /usr/share/kohaclone/members/summary-print.pl line 47

- Use of uninitialized value $roadtype in concatenation (.) or string
  at /usr/share/kohaclone/members/summary-print.pl line 61

- Use of uninitialized value in addition (+)
  at /usr/share/kohaclone/members/summary-print.pl line 87

- Argument "2015-11-03 23:59:00" isn't numeric in numeric comparison (<=>) at
/usr/share/kohaclone/members/summary-print.pl line 103

To test:
- Apply patch
- Go to a detail page with a member who has a lot of fines
- Print summary
- Verify that warnings like the ones above do no longer appear.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14483] Warns when printing summary slip for patron

2015-10-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14483

Marc Véron  changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=15068

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15068] Get rid of warnings in members/summary-print.pl

2015-10-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15068

Marc Véron  changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=14483
 Status|NEW |Needs Signoff
   Patch complexity|--- |Trivial patch
   Assignee|gmcha...@gmail.com  |ve...@veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15068] Get rid of warnings in members/summary-print.pl

2015-10-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15068

Marc Véron  changed:

   What|Removed |Added

 CC||aleishaamo...@hotmail.com

--- Comment #2 from Marc Véron  ---
*** Bug 14483 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14483] Warns when printing summary slip for patron

2015-10-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14483

Marc Véron  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|Patch doesn't apply |RESOLVED
 CC||ve...@veron.ch

--- Comment #4 from Marc Véron  ---


*** This bug has been marked as a duplicate of bug 15068 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15032] Plack testing -- Stage MARC records for import -- Internal Server Error/Stalled Staged Import

2015-10-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15032

--- Comment #13 from Jonathan Druart  
---
I made it works on kohadevbox:ansible, using plackup, ports and the koha.psgi
from the source:


vagrant@kohadevbox:~$ sudo KOHA_CONF=/etc/koha/sites/kohadev/koha-conf.xml
PERL5LIB=/home/vagrant/kohaclone INTRANET=1 INTRANETDIR=/home/vagrant/kohaclone
plackup --port 5001 /home/vagrant/kohaclone/misc/plack/koha.psgi -E deployment  
and
/etc/koha/apache-shared-intranet-plack.conf
ProxyPass /cgi-bin/koha http://localhost:5001/cgi-bin/koha
ProxyPassReverse /cgi-bin/koha http://localhost:5001/cgi-bin/koha

Otherwise, trying with socket:

vagrant@kohadevbox:~$ sudo KOHA_CONF=/etc/koha/sites/kohadev/koha-conf.xml
PERL5LIB=/home/vagrant/kohaclone INTRANET=1 INTRANETDIR=/home/vagrant/kohaclone
plackup --socket /var/run/koha/kohadev/plack.sock
/home/vagrant/kohaclone/misc/plack/koha.psgi -E deployment
# using Koha intranet CGI from /home/vagrant/kohaclone
failed to listen to port 8080: Address already in use at
/usr/share/perl5/HTTP/Server/PSGI.pm line 94.

--socket does not seems to work here (??)

Note that it works if I use Starman:
sudo KOHA_CONF=/etc/koha/sites/kohadev/koha-conf.xml
PERL5LIB=/home/vagrant/kohaclone INTRANET=1 INTRANETDIR=/home/vagrant/kohaclone
plackup -s Starman --socket /var/run/koha/kohadev/plack.sock
/home/vagrant/kohaclone/misc/plack/koha.psgi -E deployment
# using Koha intranet CGI from /home/vagrant/kohaclone
2015/10/27-11:42:45 Starman::Server (type Net::Server::PreFork) starting!
pid(11966)
Binding to UNIX socket file "/var/run/koha/kohadev/plack.sock"
Setting gid to "0 0 0"

But when I try and access the interface:
[Tue Oct 27 11:45:11.077045 2015] [proxy_http:error] [pid 12238] (70008)Partial
results are valid but processing is incomplete: [client 192.168.50.1:47165]
AH01110: error reading response, referer: http://kohadev-intra.box.vm:8080/
and finish with a 503 Service Unavailable

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15032] Plack testing -- Stage MARC records for import -- Internal Server Error/Stalled Staged Import

2015-10-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15032

--- Comment #14 from Jonathan Druart  
---
Starman with ports:
 sudo KOHA_CONF=/etc/koha/sites/kohadev/koha-conf.xml
PERL5LIB=/home/vagrant/kohaclone INTRANET=1 INTRANETDIR=/home/vagrant/kohaclone
/usr/bin/starman -M FindBin --max-requests 50 --workers 2 --user=kohadev-koha
--group kohadev-koha --pid /var/run/koha/kohadev/plack.pid --port 5001
/home/vagrant/kohaclone/misc/plack/koha.psgi

Everyting looks fine, but the import tool is still broken (no progress bar).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15032] Plack testing -- Stage MARC records for import -- Internal Server Error/Stalled Staged Import

2015-10-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15032

--- Comment #15 from Jonathan Druart  
---
(In reply to Jonathan Druart from comment #8)
> This seems to be caused by bug 14321
> 
> The errors in the logs are:
> 
> binmode() on closed filehandle _GEN_2 at
> /home/vagrant/kohaclone/C4/Templates.pm line 120.
> seek() on closed filehandle _GEN_2 at /usr/share/perl5/CGI/Emulate/PSGI.pm
> line 32.
> Can't seek stdout handle: Bad file descriptor at
> /usr/share/perl5/Plack/App/WrapCGI.pm line 87.

Note that these errors always appear, even when the import and the progress bar
work correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15049] Add warning about "No active currency" to Acquisitions start page

2015-10-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15049

--- Comment #5 from Bernardo Gonzalez Kriegel  ---
(In reply to Marc Véron from comment #4)
> 
> However with GetCurrency()->{currency} I get:
> 
> Can't use an undefined value as a HASH reference at
> /usr/share/kohaclone/acqui/acqui-home.pl line 117.
> 
> The reason is that GetCurrency does a SELECT * FROM currency where active =
> '1'
> (C4/Budgets.pm, after line 932)
> 
> If no active currency is set the return value is not defined.

Yeap, but 'budgets-active-currency.inc' expects the currency and not a hashref.
Other files that use the include put "currency => $cur->{currency}"

Perhaps this code

my $cur = GetCurrency();
if ( $cur ) {
   $template->param(
currency  => $cur->{currency},
);
}

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14435] The table saved_reports is never populated

2015-10-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14435

Josef Moravec  changed:

   What|Removed |Added

 CC||josef.mora...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14578] Allow merging of records upon import match

2015-10-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14578

--- Comment #2 from Nicole C. Engard  ---
Work to be done:
1) For all staged records with found matches, add a 'merge editor' link. This
link will open a page similar to cataloguing/merge.pl
2) Within the merge editor you will be able to select fields to retain/remove
from each record
3) Saving the merge will update the staged record with the selected value
4) At this point, importing the record will replace the existing record with
the staged record that you modified with the merge values

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14578] Allow merging of records upon import match

2015-10-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14578

--- Comment #3 from Katrin Fischer  ---
Ah, thx Nicole that makes sense - just not quite what I was hoping for :)

We'd like to have something that happens automatically if certain conditions
are met.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15056] hold-transfer-slip.pl print "No hold found"

2015-10-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15056

--- Comment #2 from mustaqeem  ---
(In reply to Katrin Fischer from comment #1)
> mustageeem, please check that you have your notice templates correctly
> defined - the error message can appear when the template is missing.
> 
> Tools > Notices and Slips > RESERVESLIP

Dear Katrin, thank you so much..! that really solve that problem..!

I close my case..:)

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15056] hold-transfer-slip.pl print "No hold found"

2015-10-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15056

Katrin Fischer  changed:

   What|Removed |Added

 Resolution|--- |INVALID
 Status|NEW |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14468] Remove warnings when creating Labels

2015-10-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14468

--- Comment #18 from Tomás Cohen Arazi  ---
Created attachment 44063
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44063&action=edit
Bug 14468: (QA followup) remove useless diags

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13696] Add support for Font Awesome icons in Koha

2015-10-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13696

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||tomasco...@gmail.com

--- Comment #29 from Tomás Cohen Arazi  ---
Patches pushed to master.

Good job Kyle!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14915] Use Font Awesome instead of Glyphicons for the staff intranet

2015-10-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14915

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #25 from Tomás Cohen Arazi  ---
Patches pushed to master.

Thanks Kyle and Katrina!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14155] Placing holds via ILSDI bypass some checks

2015-10-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14155

--- Comment #22 from Alex Arnaud  ---
Created attachment 44064
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44064&action=edit
Bug 14155 - Update tests and fix failures

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14997] Remove C4::Dates from tools (import / export)

2015-10-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14997

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||tomasco...@gmail.com

--- Comment #6 from Tomás Cohen Arazi  ---
Patch pushed to master

Thanks Marc!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14949] Remove C4::Dates from admin/smart-rules.pl and admin/categorie.pl

2015-10-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14949

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||tomasco...@gmail.com

--- Comment #14 from Tomás Cohen Arazi  ---
Patches pushed to master.

Thanks Marc!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14995] Remove C4::Dates: Delete files reservereport.pl / reservereport.tt

2015-10-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14995

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||tomasco...@gmail.com

--- Comment #7 from Tomás Cohen Arazi  ---
Patch pushed to master.

Thanks Marc!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14468] Remove warnings when creating Labels

2015-10-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14468

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #19 from Tomás Cohen Arazi  ---
Parche aplicado en master.

¡Gracias Bernardo!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14578] Allow merging of records upon import match

2015-10-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14578

--- Comment #4 from Nicole C. Engard  ---
That would be AWESOME!!! I think this is a step in that direction though :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool

2015-10-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

--- Comment #57 from Kyle M Hall  ---
Created attachment 44067
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44067&action=edit
Bug 12598 - Move importing code to a subroutine

Signed-off-by: Benjamin Rokseth 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool

2015-10-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

--- Comment #56 from Kyle M Hall  ---
Created attachment 44066
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44066&action=edit
Bug 12598 - Tidy import_borrowers.pl

Signed-off-by: Benjamin Rokseth 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14155] Placing holds via ILSDI bypass some checks

2015-10-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14155

Alex Arnaud  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool

2015-10-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #41790|0   |1
is obsolete||
  Attachment #41791|0   |1
is obsolete||
  Attachment #41792|0   |1
is obsolete||
  Attachment #41793|0   |1
is obsolete||
  Attachment #41794|0   |1
is obsolete||

--- Comment #55 from Kyle M Hall  ---
Created attachment 44065
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44065&action=edit
Bug 12598: New misc/import_borrowers.pl command line tool

Test Plan:
1) Apply this patch
2) Test importing patrons from command line,
   options are availble with --help.

Signed-off-by: Bernardo Gonzalez Kriegel 

Tested with minimal csv
(cardnumber,surname,firstname,categorycode,branchcode,password,userid)

Overwrite does not change category or branch.
Patrons are loaded, userid & password works

Updated license to GPLv3
No other koha-qa errors.

Signed-off-by: Benjamin Rokseth 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool

2015-10-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

--- Comment #58 from Kyle M Hall  ---
Created attachment 44068
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44068&action=edit
Bug 12598 - Update command line script to use patron import subroutine

Signed-off-by: Benjamin Rokseth 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool

2015-10-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

--- Comment #59 from Kyle M Hall  ---
Created attachment 44069
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44069&action=edit
Bug 12598 [QA Followup]

* Fix copyright on import_borrowers.pl
* Changes -c --csv to -f --file
* Adds -c --confirm option
* Renames misc/import_borrowers.pl to misc/import_patrons.pl
* Restore userid matchpoint option

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14578] Allow merging of records upon import match

2015-10-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14578

--- Comment #5 from Katrin Fischer  ---
Yep of course - I think that will be helpful for everyone running the imports
manually.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool

2015-10-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

Kyle M Hall  changed:

   What|Removed |Added

 CC||kyle.m.h...@gmail.com

--- Comment #60 from Kyle M Hall  ---
I would really like to see this qa'ed for a fast push after the 3.22 release.
The longer this sits here the more likely the new subroutine will fall out of
sync with the current import code in master.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14996] Remove C4::Dates from tags/review.pl

2015-10-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14996

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||tomasco...@gmail.com

--- Comment #6 from Tomás Cohen Arazi  ---
Patch pushed to master.

Thanks Marc

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15049] Add warning about "No active currency" to Acquisitions start page

2015-10-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15049

--- Comment #6 from Marc Véron  ---
Additionaly there was an issue if an user had no permission to manage the
currencies table. In such case the warning message should not display a link to
the currencies.

Patch follows.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15049] Add warning about "No active currency" to Acquisitions start page

2015-10-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15049

Marc Véron  changed:

   What|Removed |Added

  Attachment #44017|0   |1
is obsolete||

--- Comment #7 from Marc Véron  ---
Created attachment 44070
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44070&action=edit
Bug 15049 - Add warning about "No active currency" to Acquisitions start page

If no active currency is defined, Acquisitions does not work properly and
software
can occur while receiving.
This patch adds the warning message about missing active currency to Home >
Acquisitions

To test:
- Apply patch
- Go to Home > Administration > Currencies & Exchange Rates > Currencies
- Make sure that no active currency is set
- Go to Home > Acquisitions
- Verify that a warning displays:
  - If user has at least permission for parameters_remaining_perissions,
the warning should display a link to Currencies and exchange rates
(currency.pl)
  - If the user has no permission to edit the Currencies and exchange rates,
no link is displayed.
- Set an active currency
- Veryfy that the warning no longer displays

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10933] PurgeSearchHistory should be merged into the C4::Search::History module

2015-10-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10933

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||tomasco...@gmail.com

--- Comment #19 from Tomás Cohen Arazi  ---
Patches pushed to master.

Thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15049] Add warning about "No active currency" to Acquisitions start page

2015-10-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15049

Marc Véron  changed:

   What|Removed |Added

  Attachment #44070|0   |1
is obsolete||

--- Comment #8 from Marc Véron  ---
Created attachment 44071
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44071&action=edit
Bug 15049 - Add warning about "No active currency" to Acquisitions start page

If no active currency is defined, Acquisitions does not work properly and
software
can occur while receiving.
This patch adds the warning message about missing active currency to Home >
Acquisitions

To test:
- Apply patch
- Go to Home > Administration > Currencies & Exchange Rates > Currencies
- Make sure that no active currency is set
- Go to Home > Acquisitions
- Verify that a warning displays:
  - If user has at least permission for parameters_remaining_perissions,
the warning should display a link to Currencies and exchange rates
(currency.pl)
  - If the user has no permission to edit the Currencies and exchange rates,
no link is displayed.
- Set an active currency
- Veryfy that the warning no longer displays

(Amended to remove superfluous line / mv)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14903] Remove C4::Dates from circ/circulation.pl

2015-10-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14903

Mirko Tietgen  changed:

   What|Removed |Added

  Attachment #43958|0   |1
is obsolete||

--- Comment #14 from Mirko Tietgen  ---
Created attachment 44072
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44072&action=edit
Bug 14903 - Remove C4::Dates from circ/circulation.pl (and more)

Patch to remove deprectated C4::Dates from:
- circ/circulation.pl
- C4/Circulation.pm
- koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt

To test:
- Apply patch
- Go to the checkout site (Home > Circulation > Checkouts)
- Verify that data displays properly (including for users with a card
  that expires in the  near future, see syspref 'NotifyBorrowerDeparture')
- Search for regressions
- prove -v t/db_dependent/Circulation.t

(Amended following comment #9 / #11  25.10.2015 /mv)

Signed-off-by: Mirko Tietgen 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14903] Remove C4::Dates from circ/circulation.pl

2015-10-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14903

Mirko Tietgen  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15049] Add warning about "No active currency" to Acquisitions start page

2015-10-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15049

Marc Véron  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12486] Appendix G (Resetting the Koha Database) using DELETE instead of TRUNCATE

2015-10-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12486

M. Tompsett  changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=12488

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12488] bulkmarcimport.pl -d option should use DELETE instead of TRUNCATE

2015-10-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12488

M. Tompsett  changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=12486

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13379] authorised_values.category is varchar(16)

2015-10-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13379

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||15069


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15069
[Bug 15069] items_search_fields.authorised_values_category is still a
varchar(32)
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15069] items_search_fields.authorised_values_category is still a varchar(32)

2015-10-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15069

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12488] bulkmarcimport.pl -d option should use DELETE instead of TRUNCATE

2015-10-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12488

--- Comment #8 from M. Tompsett  ---
(In reply to Magnus Enger from comment #7)
> Could it be an idea to introduce a command line switch, to let the user
> choose between DELETE and TRUNCATE? With TRUNCATE (the current behaviour) as
> the default if e.g. --use_delete is not provided?

I'd think that --use_truncate would be better, and default with DELETE, because
the original intent is almost always rollback, is it not?

Adding a command line option would make this somewhere between a fix and
enhancement (not going to make 3.22, is it?). Changing it to use DELETE would
just be a fix (could make it into 3.22), in my opinion.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15069] items_search_fields.authorised_values_category is still a varchar(32)

2015-10-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15069

--- Comment #1 from Jonathan Druart  
---
Created attachment 44073
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44073&action=edit
Bug 15069: Update items_search_fields.authorised_values_category to varchar(32)

This is a follow-up for bug 13379.
items_search_fields.authorised_values_category is now a varchar(32) but
the updatedatabase.pl did not modify it (changed only on
kohastructure.sql)

Test plan:
  SHOW CREATE TABLE items_search_fields
before and after this patch.
items_search_fields.authorised_values_category should be a varchar(32)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15069] items_search_fields.authorised_values_category is still a varchar(32)

2015-10-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15069

Jonathan Druart  changed:

   What|Removed |Added

 CC||ch...@bigballofwax.co.nz

--- Comment #2 from Jonathan Druart  
---
Should be backported to 3.20.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15069] items_search_fields.authorised_values_category is still a varchar(32)

2015-10-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15069

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7736] Edifact QUOTE and ORDER functionality

2015-10-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736

Zeno Tajoli  changed:

   What|Removed |Added

  Attachment #36738|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15069] items_search_fields.authorised_values_category is still a varchar(32)

2015-10-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15069

Tomás Cohen Arazi  changed:

   What|Removed |Added

  Attachment #44073|0   |1
is obsolete||

--- Comment #3 from Tomás Cohen Arazi  ---
Created attachment 44074
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44074&action=edit
Bug 15069: Update items_search_fields.authorised_values_category to varchar(32)

This is a follow-up for bug 13379.
items_search_fields.authorised_values_category is now a varchar(32) but
the updatedatabase.pl did not modify it (changed only on
kohastructure.sql)

Test plan:
  SHOW CREATE TABLE items_search_fields
before and after this patch.
items_search_fields.authorised_values_category should be a varchar(32)

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15069] items_search_fields.authorised_values_category is still a varchar(32)

2015-10-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15069

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com
 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11559] Professional cataloger's interface

2015-10-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11559

Karl Holten  changed:

   What|Removed |Added

 CC||khol...@switchinc.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15069] New: items_search_fields.authorised_values_category is still a varchar(32)

2015-10-27 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15069

Bug ID: 15069
   Summary: items_search_fields.authorised_values_category is
still a varchar(32)
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: ASSIGNED
  Severity: normal
  Priority: P5 - low
 Component: Architecture, internals, and plumbing
  Assignee: jonathan.dru...@bugs.koha-community.org
  Reporter: jonathan.dru...@bugs.koha-community.org
QA Contact: testo...@bugs.koha-community.org
Depends on: 13379

This is a follow-up for bug 13379.
items_search_fields.authorised_values_category is now a varchar(32) but the
updatedatabase.pl did not modify it (changed only on kohastructure.sql)


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13379
[Bug 13379] authorised_values.category is varchar(16)
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >