[Koha-bugs] [Bug 9762] way to track overrides

2015-11-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762

Tom Misilo  changed:

   What|Removed |Added

 CC||misi...@fit.edu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15210] New: Novelist js throws an error if no ISBN

2015-11-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15210

Bug ID: 15210
   Summary: Novelist js throws an error if no ISBN
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: OPAC
  Assignee: oleon...@myacpl.org
  Reporter: n...@bywatersolutions.com
QA Contact: testo...@bugs.koha-community.org

If novelist is enabled and a record has no ISBN the js throws an error which
subsequently breaks any custom code from opacuserjs.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8753] Add forgot password link to OPAC

2015-11-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

Jesse Weaver  changed:

   What|Removed |Added

 CC||jwea...@bywatersolutions.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction

2015-11-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236

Jenny Dallas  changed:

   What|Removed |Added

 CC||limbo...@gmail.com

--- Comment #96 from Jenny Dallas  ---
I love it! Excellent article. I need help with this too! If you ever need to
fill out a form, here is or http://www.tax.ny.gov/pdf/2003/et/tt86_5_103.pdf; >www.tax.ny.gov a
really useful tool. Very easy to navigate and use.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy

2015-11-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072

--- Comment #41 from Marc Véron  ---
Created attachment 44964
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44964=edit
Bug 12072: Make datepicker and templates to be aware of dmydot format

This patch is to display corrextly the new dmydot date format e.g. after
using the datepicker or in messages for the user, in following files:

- koha-tmpl/intranet-tmpl/prog/en/includes/calendar.inc
- koha-tmpl/intranet-tmpl/prog/en/includes/date-format.inc
- koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc
- koha-tmpl/intranet-tmpl/prog/en/modules/tools/holidays.tt
- koha-tmpl/opac-tmpl/bootstrap/en/includes/calendar.inc
- tools/holidays.pl

To test:
- Apply patch
- Make sure that you have syspref dateformat set to dmydot
- Use datepicker in OPAC (modify birth date), verify that after
  choosing a date, it is displayed correctly in the datepicker
- Use datepicker at several places in OPAC, verify that after choosing
  a date the date displays properly in datepicker and that the dater format
  is properly indicated (e.g. near birth date or near "Specify due date").

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15210] Novelist js throws an error if no ISBN

2015-11-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15210

--- Comment #1 from Nick Clemens  ---
Created attachment 44965
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44965=edit
Bug 15210 - Novelist throws an error if no ISBN

This patch makes opac-detail.tt check for an ISBN before attempting to load
Novelist content and prevents a js error which breaks other code.

To test:
1 - Enable novelist
2 - Add a visible change to OPACUserJS eg: $(document).ready(function()
{$("body").css("background-color","pink");});
3 - Load a record with no ISBN
4 - Note you do not see a color change in the body and that there is an error
in the console
5 - Apply patch
6 - Reload the record
7 - You should see the color change and no error in the js

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12072] New dateformat dd.mm.yyyy

2015-11-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12072

Marc Véron  changed:

   What|Removed |Added

  Attachment #44964|0   |1
is obsolete||

--- Comment #42 from Marc Véron  ---
Created attachment 44966
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44966=edit
Bug 12072: Make datepicker and templates to be aware of dmydot format

This patch is to display corrextly the new dmydot date format e.g. after
using the datepicker or in messages for the user, in following files:

- koha-tmpl/intranet-tmpl/prog/en/includes/calendar.inc
- koha-tmpl/intranet-tmpl/prog/en/includes/date-format.inc
- koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc
- koha-tmpl/intranet-tmpl/prog/en/modules/tools/holidays.tt
- koha-tmpl/opac-tmpl/bootstrap/en/includes/calendar.inc
- tools/holidays.pl

To test:
- Apply patch
- Make sure that you have syspref dateformat set to dmydot
- Use datepicker in OPAC (modify birth date), verify that after
  choosing a date, it is displayed correctly in the datepicker
- Use datepicker at several places in OPAC, verify that after choosing
  a date the date displays properly in datepicker and that the dater format
  is properly indicated (e.g. near birth date or near "Specify due date").
- Verify that datepicker works well with hoiday editing and that "From date:"
  displays properly

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10102] don't show empty novelist tab if no data

2015-11-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10102

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com

--- Comment #1 from Nick Clemens  ---
Tricky with the fact that Novelist is all js and loaded after the page, but
adding the below to OPACUserJS seems to accomplish it.  Something cleaner would
be nice but this works as a quick fix:

$(window).load(function(){
if( !$('#NovelistSelect').find('img').length ){
$("a[href=#NovelistSelect]").remove();
$("#NovelistSelect").remove();
}
});

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15163] Patron attributes with branch limiits are not saved when invisible

2015-11-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15163

--- Comment #2 from Jesse Weaver  ---
Steps to reproduce:

  1) Log in at library "A".
  2) Create a patron attribute type that is limited to only library "A".
  3) Edit a patron, and add data for that attribute type.
  4) Log in at library "B".
  5) Edit the same patron. The attribute should, of course, not be visible.
Save.
  6) Log in at library "A".
  7) Edit the same patron. The attribute data has disappeared.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14870] Delete C4/Dates.pm from System

2015-11-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870

--- Comment #31 from Héctor Eduardo Castro Avalos  
---
(In reply to Zeno Tajoli from comment #27)
> Hi, I found that in reports/guided_reports.pl C4:Dates is still present.
> 
> From lines 359 to 363:
> 
> # If the range values are dates
> if ($fromvalue =~ C4::Dates->regexp('syspref') && $tovalue =~ 
> C4::Dates->regexp('syspref')) {
> $fromvalue = C4::Dates->new($fromvalue)->output("iso");
> $tovalue = C4::Dates->new($tovalue)->output("iso");
> }
> 
> A new bug or you fix here ?

A previous attachment in this bug fixed it up


-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15209] C4::Koha routines expecting a MARC::Record object should check it is defined

2015-11-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15209

Colin Campbell  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Assignee|gmcha...@gmail.com  |colin.campbell@ptfs-europe.
   ||com

--- Comment #1 from Colin Campbell  ---
Created attachment 44963
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44963=edit
Proposed patch

routines now return undef rather than aborting if undefined record is passed to
them

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15206] Show patron's age when filling date of birth in memberentry.pl

2015-11-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15206

Alex Arnaud  changed:

   What|Removed |Added

 Status|Needs Signoff   |ASSIGNED

--- Comment #3 from Alex Arnaud  ---
(In reply to Marc Véron from comment #2)
> Hi Alex, I like thsi feature.
> 
> I played around with a 10 year old kid.
> 
> Today we have 18/11/2015
> 
> This are my results: 
> 18/11/2005 -> Age: 10 year(s) 2 day(s) 
> 18/11/2005 -> Age: 10 year(s) 1 day(s) 
> 20/11/2005 -> Age: 10 year(s)
> 21/11/2005 -> Age: 9 year(s) 11 month(s) 30 day(s)
> 22/11/2005 -> Age: 9 year(s) 11 month(s) 29 day(s)
> 
> There seems to be an offset of some days.

Hello Marc,

Tanks for testing. Indeed there's a problem and i understand why. Patch is
coming soon...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15198] Make OpacSuppression work even if there are no records suppressed

2015-11-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15198

Fridolin SOMERS  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #11 from Fridolin SOMERS  ---
Very nice catch.
I had seen this attribute type and had the same idea once (but then I forgot).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15198] Make OpacSuppression work even if there are no records suppressed

2015-11-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15198

Fridolin SOMERS  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11360] Disable barcode field and submit button when a hold is found

2015-11-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360

Kyle M Hall  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11360] Disable barcode field and submit button when a hold is found

2015-11-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #23511|0   |1
is obsolete||

--- Comment #15 from Kyle M Hall  ---
Created attachment 44967
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44967=edit
Bug 11360 - Disable barcode field and submit button when a hold is found

At the moment when scanning in returns, it can be easy to miss a hold
trap due to the fact that the barcode and submit are still active and
the barcode field is focused on. A librarian who is focused on scanning
can easily scan another item and pass over the form, which is equivalent
to clicking the "ignore" button.

Test Plan:
1) Apply this patch
2) Trap a hold, note the new modal
3) Check the hold in a second time
4) Note the new modal
5) For each modal, test each button

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11360] Disable barcode field and submit button when a hold is found

2015-11-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360

--- Comment #14 from Kyle M Hall  ---
> I agree about consistency, but from the other direction: namely, Bootstrap
> modals are only used in a couple places currently, but if folks generally
> think that they're a good direction to go in, then circulation is a good
> place to get started with adding more use of them: it's faster for a circ
> operator to dismiss a modal than to wait for a round-trip to the server with
> the current approach for dealing with blocking alerts during circ operations.

I concur!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15163] Patron attributes with branch limiits are not saved when invisible

2015-11-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15163

--- Comment #3 from Heather Braum  ---
Jonathan, Jesse's description is the behavior that I have seen also happen on
my system. 

Additionally, I have seen this same behavior happen with patron categories that
are limited to only certain branches (and maybe this needs to be a separate
bug), but it seems to be the same type of problematic behavior: 

1. Login at Library A.
2. Set a patron category to be visible to only Library A.
3. Edit a patron and change the patron category to one that is only visible to
Library A. 
4. Login at Library B.
5. Edit the same patron, and note that the patron category is now the first one
on the list, not the one set in step 3. 
6. Login at Library A. 
7. Edit the same patron again; note that the patron category is not set to what
was set in step 3.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15206] Show patron's age when filling date of birth in memberentry.pl

2015-11-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15206

--- Comment #1 from Alex Arnaud  ---
Created attachment 44953
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44953=edit
Bug 15206 - Show patron's age under date of birth in memberentry.pl

Test plan:

Create a new patron (members/memberentry.pl), enter a date of birth, patron'a
age should be shown under

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14870] Delete C4/Dates.pm from System

2015-11-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870

--- Comment #30 from Marc Véron  ---
Created attachment 44954
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44954=edit
Bug 14870: (followup) Remove superfluous C4::Dates from
fix_accountlines_rmdupfines_bug8253.pl

This patch removes C4::Dates from fix_accountlines_rmdupfines_bug8253.pl

To test:
- Apply patch
- Check code for uses of C4::Dates (date_format)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15076] Remove file misc/maintenance/fix_accountlines_date.pl

2015-11-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15076

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com

--- Comment #3 from Kyle M Hall  ---
I'd be inclined to remove it at this point.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15207] Error on upgrade from 3.20.5 to 3.22 beta

2015-11-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15207

Zeno Tajoli  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |z.taj...@cineca.it
   |ity.org |
 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14870] Delete C4/Dates.pm from System

2015-11-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870

Marc Véron  changed:

   What|Removed |Added

 Depends on|15076   |
   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=15076


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15076
[Bug 15076] Remove file misc/maintenance/fix_accountlines_date.pl
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15207] Error on upgrade from 3.20.5 to 3.22 beta

2015-11-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15207

--- Comment #1 from Zeno Tajoli  ---
Hi,

I try to do an update from 3.20.5 to master (3.22 beta at db level).

I have done a standard marc21 english install using all sql files, mandatory
and optional.

I receive two errors:

updatedatabase.pl: DBD::mysql::db do failed: Can't create table
'koha.#sql-3a4_7f' (errno: 121) [for Statement "
updatedatabase.pl: ALTER IGNORE TABLE course_reserves
updatedatabase.pl: add CONSTRAINT course_reserves_ibfk_2
updatedatabase.pl: FOREIGN KEY (ci_id) REFERENCES course_items (ci_id)
updatedatabase.pl: ON DELETE CASCADE ON UPDATE CASCADE
updatedatabase.pl: "] at
/production/koha/install/bug14960/installer/data/mysql/updatedatabase.pl line
10804.

updatedatabase.pl: DBD::mysql::db do failed: Duplicate entry '1-self_checkout'
for key 'PRIMARY' [for Statement "
updatedatabase.pl: INSERT INTO permissions (module_bit, code, description)
updatedatabase.pl: VALUES (1, 'self_checkout', 'Perform self checkout at the
OPAC. It should be used for the patron matching the AutoSelfCheckID')
updatedatabase.pl: "] at
/production/koha/install/bug14960/installer/data/mysql/updatedatabase.pl line
10871.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15207] New: Error on upgrade from 3.20.5 to 3.22 beta

2015-11-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15207

Bug ID: 15207
   Summary: Error on upgrade from 3.20.5 to 3.22 beta
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: critical
  Priority: P5 - low
 Component: Installation and upgrade (web-based installer)
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: z.taj...@cineca.it
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15207] Error on upgrade from 3.20.5 to 3.22 beta

2015-11-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15207

Zeno Tajoli  changed:

   What|Removed |Added

   Severity|critical|major

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client

2015-11-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662

--- Comment #36 from Andreas Hedström Mace  ---
(In reply to David Cook from comment #30)
> Thinking more about matching and how complex or even impossible it is.
> 
> Consider that you have 2 different OAI-PMH servers with 2 matching records
> and also 1 matching record locally on Koha.
> 
> Which is the source of truth? 
> 
> You might argue that the harvested records have a higher priority than the
> local record... so you can overwrite the local record.
> 
> However, what about the 2 harvested records? Which one takes precedence? 

I would think that this could be solved by adding a "priority option" when
adding new servers. Then the user would decide which source should be ranked
higher in terms of conflict/duplicates.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15207] Error on upgrade from 3.20.5 to 3.22 beta

2015-11-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15207

--- Comment #2 from Zeno Tajoli  ---
The first problem  (about change in table course_reserves, bug 14205) is not
a real problem for y test situation.
Course Reserve is not active and the new costraint,  course_reserves_ibfk_2,
it was added without problems

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15207] Error on upgrade from 3.20.5 to 3.22 beta

2015-11-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15207

--- Comment #3 from Zeno Tajoli  ---
The second error is present because the update 3.21.00.027 starts so:

dbh->do(q|
INSERT INTO permissions (module_bit, code, description)
VALUES (1, 'self_checkout', 'Perform self checkout at the OPAC. It
should be used for the patron matching the AutoSelfCheckID')
|);

But in 3.20.5 in file  installer/data/mysql/en/mandatory/userpermissions.sql I
see: 

INSERT INTO permissions (module_bit, code, description) VALUES
[...]   
( 1, 'self_checkout', 'Perform self checkout at the OPAC. It should be used for
the patron matching the AutoSelfCheckID'),

So in 3.20.x the code 'self_checkout' could be present.

I don't know if it is better to 'INSERT IGNORE' or other statement.
A discussion on the topic here:
http://stackoverflow.com/questions/548541/insert-ignore-vs-insert-on-duplicate-key-update

Tecnaly speaking also this error is not blocking, the code 'self_checkout' is
present in the table permissions with a correct value.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15076] Remove file misc/maintenance/fix_accountlines_date.pl

2015-11-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15076

--- Comment #4 from Marc Véron  ---
Created attachment 44955
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44955=edit
Bug 15076: Remove file misc/maintenance/fix_accountlines_date.pl

This patch removes the file misc/maintenance/fix_accountlines_date.pl

To test:
- Verify that the file is removed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client

2015-11-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662

--- Comment #37 from Viktor Sarge  ---

> > You might argue that the harvested records have a higher priority than the
> > local record... so you can overwrite the local record.
> > 
> > However, what about the 2 harvested records? Which one takes precedence? 
> 
> I would think that this could be solved by adding a "priority option" when
> adding new servers. Then the user would decide which source should be ranked
> higher in terms of conflict/duplicates.

Relevant to this discussion might be the fact that we built both tracking of
changes to MARC-records with the possibility to roll back changes + a system
for setting rules for who can change what fields in MARC records. I'll dig up
the relevant threads.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15076] Remove file misc/maintenance/fix_accountlines_date.pl

2015-11-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15076

Marc Véron  changed:

   What|Removed |Added

 Blocks|14870   |
   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=14870

--- Comment #5 from Marc Véron  ---
Independently on removal, the file does no longer block 14870, moved from
"Blocks" to "See also"


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870
[Bug 14870] Delete C4/Dates.pm from System
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14870] Delete C4/Dates.pm from System

2015-11-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870

--- Comment #24 from Marc Véron  ---
Created attachment 44943
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44943=edit
Bug 14969: (followup) Remove stray C4::Dates

(See comment #23)

This patch removes stray C4::Dates (date_fromat...) from
C4/Items.pm
C4/Log.pm
C4/Serials.pm
serials/acqui-search-result.pl
t/DateUtils.t
t/db_dependent/Items/GetItemsForInventory.t
tools/koha-news.pl

Some of them were inside comments etc.

To test:
- git grep 'C4::Dates' should give no result
- git grep 'format_d' should give no result
  Exception: in one cron job there exists an own sub format_date, and
occurences not
 related to C4::Dates
- Search for regressions

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14101] auto renewal is tied to 'no renewal before'

2015-11-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14101

Holger Meißner  changed:

   What|Removed |Added

  Attachment #43809|0   |1
is obsolete||

--- Comment #29 from Holger Meißner  ---
Created attachment 44949
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44949=edit
Bug 14101: Unit tests

This patch adds new test cases to check if CanBookBeRenewed provides
correct return values and error codes for premature renewals. Both manual
and automatic renewals and different settings for 'No renewal before'
are tested.

To test:
1) prove t/db_dependent/Circulation.t

Sponsored-by: Hochschule für Gesundheit (hsg), Germany

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14101] auto renewal is tied to 'no renewal before'

2015-11-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14101

Holger Meißner  changed:

   What|Removed |Added

  Attachment #43808|0   |1
is obsolete||

--- Comment #28 from Holger Meißner  ---
Created attachment 44948
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44948=edit
Bug 14101: Automatic renewals exactly on due date

If no value for 'no renewal before' is specified, automatic renewal now
falls back on the due date. Also 'no renewal before' can now be zero, so
both automatic and manual renewals can be delayed until due date.

Test plan:

1) Create some circulation rules with different settings for 'No renewal
   before' and 'Automatic renewal'. Both daily and hourly loans should
   work.

2) Try to renew both manually and automatically before and after a renewal
   should be possible. You can run misc/cronjobs/automatic_renewals.pl for
   automatic renewal.

3) Confirm that:
   * Both automatic and manual renewal with 'No renewal before' set
 to 0 do not happen before the due date (exact DateTime).
   * Manual renewal with 'No renewal before' set to undef (enter empty
 string) is unrestricted.
   * Automatic renewal with 'No renewal before' set to undef does not
 happen before the due date.

Sponsored-by: Hochschule für Gesundheit (hsg), Germany

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15206] New: Show patron's age when filling date of birth in memberentry.pl

2015-11-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15206

Bug ID: 15206
   Summary: Show patron's age when filling date of birth in
memberentry.pl
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Patrons
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: alex.arn...@biblibre.com
QA Contact: testo...@bugs.koha-community.org
CC: gmcha...@gmail.com, kyle.m.h...@gmail.com

When creating a new patron and filling the "dateofbirth" datepicker element, a
message under the element shows the patron's age.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14395] Two different ways to calculate 'No renewal before' (days or hours)

2015-11-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395

Holger Meißner  changed:

   What|Removed |Added

  Attachment #43811|0   |1
is obsolete||

--- Comment #40 from Holger Meißner  ---
Created attachment 44951
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44951=edit
Bug 14395: Code changes

This patch updates the calculation of 'No renewal before' to include the
new syspref NoRenewalBeforePrecision.

To test:

1) Check out an hour-based loan with 'No renewal before' set to 1.
   Switch syspref NoRenewalBeforePrecision between 'date' and 'exact
   time'. Confirm that with both settings the item cannot be renewed
   until exactly one hour before due.

2) Check out a day-based loan with 'No renewal before' set to 1 day.
   Confirm that:
   * with NoRenewalBeforePrecision set to 'date', renewal is possible
 at 12:00 AM on the day before due.
   * with NoRenewalBeforePrecision set to 'exact time', renewal is
 possible at 11:59 PM on the day before due.

Sponsored-by: Hochschule für Gesundheit (hsg), Germany

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14395] Two different ways to calculate 'No renewal before' (days or hours)

2015-11-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395

Holger Meißner  changed:

   What|Removed |Added

  Attachment #43812|0   |1
is obsolete||

--- Comment #41 from Holger Meißner  ---
Created attachment 44952
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44952=edit
Bug 14395: Unit tests

This patch adds test cases for the new syspref NoRenewalBeforePrecision.
Tests if GetSoonestRenewDate returns correct values for both 'date' and
'exact_time' settings.
Also adds a few comments related to bugs 7413 and 14101.

To test:

1) prove t/db_dependent/Circulation.t

Sponsored-by: Hochschule für Gesundheit (hsg), Germany

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14395] Two different ways to calculate 'No renewal before' (days or hours)

2015-11-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395

Holger Meißner  changed:

   What|Removed |Added

  Attachment #43810|0   |1
is obsolete||

--- Comment #39 from Holger Meißner  ---
Created attachment 44950
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44950=edit
Bug 14395: Add new syspref NoRenewalBeforePrecision

Currently the 'NoRenwalBefore' setting is always based on the exact
DateTime of the due date. This patch introduces a new global syspref for
choosing if 'NoRenewalBefore' should instead be calculated based on date
only. This is only relevant for loans caluclated in days. Hourly loans
are not affected.

To test:

1) Apply bug 14101, then apply this patch.

2) Run installer/data/mysql/updatedatabase.pl

3) Confirm that a new syspref NoRenewalBeforePrecision is available
   in administration. It should let you choose between 'date' (default)
   and 'exact time'.

Sponsored-by: Hochschule für Gesundheit (hsg), Germany

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14870] Delete C4/Dates.pm from System

2015-11-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870

--- Comment #27 from Zeno Tajoli  ---
Hi, I found that in reports/guided_reports.pl C4:Dates is still present.

>From lines 359 to 363:

# If the range values are dates
if ($fromvalue =~ C4::Dates->regexp('syspref') && $tovalue =~ 
C4::Dates->regexp('syspref')) {
$fromvalue = C4::Dates->new($fromvalue)->output("iso");
$tovalue = C4::Dates->new($tovalue)->output("iso");
}

A new bug or you fix here ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15205] New: Factor 'SyndeticsEnabled' out of Auth.pm

2015-11-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15205

Bug ID: 15205
   Summary: Factor 'SyndeticsEnabled' out of Auth.pm
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Authentication
  Assignee: gmcha...@gmail.com
  Reporter: martin.renvo...@ptfs-europe.com
QA Contact: testo...@bugs.koha-community.org
CC: dpav...@rot13.org, gmcha...@gmail.com,
testo...@bugs.koha-community.org
Depends on: 15204

Auth.pm should not handle Syndetics related template variables, they have
absolutely nothing to do with Authentication or Authorization!


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15204
[Bug 15204] Auth.pm does too much
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14895] We shouldn't be able to edit already added serials' items from serial receive/edit page

2015-11-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14895

Joonas Kylmälä  changed:

   What|Removed |Added

   Assignee|j.kylm...@gmail.com |koha-b...@lists.koha-commun
   ||ity.org

--- Comment #8 from Joonas Kylmälä  ---
(In reply to Katrin Fischer from comment #7)
> Or Joonas?

I'm not working on this bug anymore, so someone else feel free to assign this
to him- or herself.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14870] Delete C4/Dates.pm from System

2015-11-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870

Marc Véron  changed:

   What|Removed |Added

 Status|In Discussion   |Needs Signoff

--- Comment #29 from Marc Véron  ---
Switching back to NSO

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14999] Adding to basket orders from staged files mixes up the prices and quantities between different orders

2015-11-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14999

Joonas Kylmälä  changed:

   What|Removed |Added

 Status|Needs Signoff   |In Discussion

--- Comment #5 from Joonas Kylmälä  ---
(In reply to Lucio Moraes from comment #4)
> Hi Joonas,
> if you have a staged file to test, could you share with me?
> Thank you

Unfortunately I don't have one. And now I'm thinking if the patch I supplied
here is obsolete because this might only apply for the
https://github.com/KohaSuomi/kohasuomi version of Koha. I'll change the status
to "In Discussion" for now.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15030] Certain values in serials' items are lost on next edit

2015-11-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15030

Katrin Fischer  changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=14895

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14895] We shouldn't be able to edit already added serials' items from serial receive/edit page

2015-11-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14895

--- Comment #7 from Katrin Fischer  ---
Or Joonas?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14895] We shouldn't be able to edit already added serials' items from serial receive/edit page

2015-11-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14895

Katrin Fischer  changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=15030

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client

2015-11-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662

--- Comment #35 from Andreas Hedström Mace  ---
(In reply to David Cook from comment #29)

> I'm also tempted to change the existing system so that you define OAI-PMH
> servers, and then create OAI-PMH tasks for those servers. This information
> would all be stored in the database. Then, when you wanted to run a task,
> you could click "Run" on the Web UI, and it would send the task to the
> daemon. 

To me, this sounds like the way to go! In our case, we would set the task of
repeated harvest - and not look at it again unless there are problems. =)

> I haven't 100% thought out how the Web UI and the daemon will communicate
> yet. While that above paragraph sounds good, what happens if the daemon dies
> for some reason? If it requires a message from the Web UI, it'll need a
> human to restart it. 
> 
> Actually, another idea... the Web UI could send the task, and the daemon
> could write it away to a temporary file which it cleans up after it's
> finished a task. If it crashes and gets restarted, it can check its
> temporary files to see what it was in the middle of doing. Yeah... that's
> probably a better idea.

This too sounds like good approach to me. Some sort of fail-safe to have the
harvester pick up and continue what it was doing if it has crashed - but it
should be set from the UI to begin with!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14101] auto renewal is tied to 'no renewal before'

2015-11-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14101

--- Comment #30 from Holger Meißner  ---
Rebased on master.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14870] Delete C4/Dates.pm from System

2015-11-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870

Zeno Tajoli  changed:

   What|Removed |Added

 CC||z.taj...@cineca.it

--- Comment #26 from Zeno Tajoli  ---
Hi, I found that in reports/guided_reports.pl C4:Dates is still present:


359 # If the range values are dates
360  if ($fromvalue =~ C4::Dates->regexp('syspref') && $tovalue =~  
C4::Dates->regexp('syspref')) {
 361 $fromvalue = C4::Dates->new($fromvalue)->output("iso");
 362 $tovalue = C4::Dates->new($tovalue)->output("iso");
 363 }

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14870] Delete C4/Dates.pm from System

2015-11-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870

Marc Véron  changed:

   What|Removed |Added

  Attachment #44943|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14870] Delete C4/Dates.pm from System

2015-11-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870

--- Comment #25 from Marc Véron  ---
Created attachment 44944
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44944=edit
Bug 14870: (followup) Remove stray C4::Dates

(See comment #23)

This patch removes stray C4::Dates (date_fromat...) from
C4/Items.pm
C4/Log.pm
C4/Serials.pm
serials/acqui-search-result.pl
t/DateUtils.t
t/db_dependent/Items/GetItemsForInventory.t
tools/koha-news.pl

Some of them were inside comments etc.

To test:
- git grep 'C4::Dates' should give no result
- git grep 'format_d' should give no result
  Exception: in one cron job there exists an own sub format_date, and
occurences not
 related to C4::Dates
- Search for regressions

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 4502] Perl error in acq budget planning

2015-11-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4502

--- Comment #29 from Katrin Fischer  ---
Created attachment 44946
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44946=edit
[PASSED QA] Bug 4502: An attempt to make things more sensible.

The reason the budget_period_id was not defined was because in
two cases it was not passed! This patch adds those missing
parameters. And as a result, cuts out the attempt to default the
authcat to '' unless the budget_period_id is defined.

Additionally, the start and end months don't seem to be passed,
so rather than have it blow up, checking them forces the else
case logic.

budget_period_id is the budget id. If you have two budgets,
you can craft a URL to work with budget_period_id matching
those two ids. Anything else should trigger the new error which
was modified to reflect more of what the problem is.

Follow the test plan in comment #6. Feel free to also to attempt
crafting URLs and triggering errors.

Signed-off-by: Bernardo Gonzalez Kriegel 
Well, works and does not explode any more
No errors

To trigger the new message simply put /cgi-bin/koha/admin/aqplan.pl
on your staff page, an intriguing 'Planning for by Asort1' appears :)

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 4502] Perl error in acq budget planning

2015-11-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4502

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #44498|0   |1
is obsolete||
  Attachment #44499|0   |1
is obsolete||
  Attachment #44932|0   |1
is obsolete||

--- Comment #28 from Katrin Fischer  ---
Created attachment 44945
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44945=edit
[PASSED QA] Bug 4502: Catch software error if no active budget defined

TEST PLAN
-
0) Back up your database.
1) In mysql client:
   > DROP DATABASE {your koha database name};
   > CREATE DATABASE {your koha database name};
   > QUIT;
2) Go to the staff client, and install all the default
   and optional things -- except patrons. :)
3) Log into staff client.
4) Create a patron -> New Patron -> Staff
5) Enter data and Save
6) More -> Set Permissions
7) Make superlibrarian
8) Log out
9) Log in as new superlibrarian
10) Acquisitions -> Budgets -> New Budget
11) Enter a non-active budget with some funds.
-- Once saved, it should list in the inactive budgets.
12) Click on the name.
13) Click on one of the Planning submenu options.
14) Click the 'Submit' button in the Filter area.
-- This should trigger the blow up.
15) Apply the patch
16) Repeat steps 12-15
-- The kaboom is avoided and a nice message given.

NOTE: This does not solve all the problems in this ugly, ugly
  module area. It does solve the one thing it is meant to:
  that nasty kaboom.

Signed-off-by: Mark Tompsett 

Signed-off-by: Bernardo Gonzalez Kriegel 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 4502] Perl error in acq budget planning

2015-11-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4502

--- Comment #30 from Katrin Fischer  ---
Created attachment 44947
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44947=edit
[PASSED QA] Bug 4502: Changing wording again...

Signed-off-by: Bernardo Gonzalez Kriegel 
Just a string patch, others are signed.
No errors

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 4502] Perl error in acq budget planning

2015-11-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4502

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14895] We shouldn't be able to edit already added serials' items from serial receive/edit page

2015-11-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14895

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #6 from Katrin Fischer  ---
This appears similar to bug 15030 - which I think tries to fix the behaviour.
Liz, could you maybe take a look at the other bug too?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14395] Two different ways to calculate 'No renewal before' (days or hours)

2015-11-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395

--- Comment #42 from Holger Meißner  ---
Rebased on master.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14870] Delete C4/Dates.pm from System

2015-11-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870

Zeno Tajoli  changed:

   What|Removed |Added

 Status|Needs Signoff   |In Discussion

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14870] Delete C4/Dates.pm from System

2015-11-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870

--- Comment #28 from Marc Véron  ---
Hi Zeno, thakns for testing.

I can not find C4::Dates in reports/guided_reports.pl

Git grep 'C4::Dates' only gives results only in
misc/release_notes/release_notes_3_22_0.txt

I applyed the patches after a recent git pull:
HEAD is now at 87e7d55 Bug 15199: t/db_dependent/Review.t should not depend on
existing data

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15204] New: Auth.pm does too much

2015-11-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15204

Bug ID: 15204
   Summary: Auth.pm does too much
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P5 - low
 Component: Authentication
  Assignee: gmcha...@gmail.com
  Reporter: martin.renvo...@ptfs-europe.com
QA Contact: testo...@bugs.koha-community.org
CC: dpav...@rot13.org

As a first step to re-factoring Auth.pm for bug 7174 we need to limit the scope
of what Auth.pm does.

Currently C4::Auth.pm handles both Authentication and Authorization which is
the maximum of what it should do. 

Unfortunately it also handles in part the Context, the Session, and the
Templates.  For proper separation of concerns it should do none of these
things!

This bug should act as a central point for building a dependency tree of work
required to factor out these supplementary roles.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14870] Delete C4/Dates.pm from System

2015-11-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14870

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15204] Auth.pm does too much

2015-11-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15204

Martin Renvoize  changed:

   What|Removed |Added

 Blocks|15205   |
 Depends on||15205


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15205
[Bug 15205] Factor 'SyndeticsEnabled' out of Auth.pm
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15205] Factor 'SyndeticsEnabled' out of Auth.pm

2015-11-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15205

Martin Renvoize  changed:

   What|Removed |Added

 Blocks||15204
 Depends on|15204   |


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15204
[Bug 15204] Auth.pm does too much
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15204] Auth.pm does too much

2015-11-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15204

Martin Renvoize  changed:

   What|Removed |Added

 Blocks||15205


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15205
[Bug 15205] Factor 'SyndeticsEnabled' out of Auth.pm
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15206] Show patron's age when filling date of birth in memberentry.pl

2015-11-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15206

Alex Arnaud  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15206] Show patron's age when filling date of birth in memberentry.pl

2015-11-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15206

Alex Arnaud  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |alex.arn...@biblibre.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15208] New: Ease translation for shelves messages

2015-11-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15208

Bug ID: 15208
   Summary: Ease translation for shelves messages
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: trivial
  Priority: P5 - low
 Component: I18N/L10N
  Assignee: koha-bugs@lists.koha-community.org
  Reporter: bgkrie...@gmail.com
QA Contact: testo...@bugs.koha-community.org
CC: frede...@tamil.fr

Shelves messages give us a 'big' string to translate.
We need to split it up.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15091] Batch Checkout Doesn't Tell You it Failed

2015-11-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15091

Marc Véron  changed:

   What|Removed |Added

  Attachment #44491|0   |1
is obsolete||

--- Comment #18 from Marc Véron  ---
Created attachment 44958
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44958=edit
Bug 15091: Do not allow to use batch checkout if checkout is not allowed

If the noissue param is passed to the template, the batch checkout
should not be allowed.

This patch globally fixes the problem raised by bug 15091.
A generic message "cannot check out" is displayed and some more specific
ones could be added later.
For now it only trigger the "fine balance is over the limit" message.

Test plan:
Confirm there is no regression on the original behavior and that the
issue raised on bug 15091 is fixed.

Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15207] Error on upgrade from 3.20.5 to 3.22 beta

2015-11-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15207

Zeno Tajoli  changed:

   What|Removed |Added

 CC|gmcha...@gmail.com  |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15207] Error on upgrade from 3.20.5 to 3.22 beta

2015-11-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15207

--- Comment #5 from Zeno Tajoli  ---
Created attachment 44960
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44960=edit
patch for fix update

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15207] Error on upgrade from 3.20.5 to 3.22 beta

2015-11-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15207

Zeno Tajoli  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
  Change sponsored?|--- |Sponsored

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client

2015-11-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662

--- Comment #38 from Viktor Sarge  ---
Write protecting MARC fields based on source of import
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957

History for MARC records. Roll back changes on a timeline or per field.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14367


I'm not quite certain if this should be "See also" connections - what say ye?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15208] Ease translation for shelves messages

2015-11-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15208

--- Comment #1 from Bernardo Gonzalez Kriegel  ---
Created attachment 44956
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44956=edit
Bug 15208: Ease translation for shelves messages

This string patch only puts ...
around shelves messages. It split a monster
translation string into its components.
This kind of string to translate is error-prone.

Also fixed a typo on opac, 'deleteing'

To test:
1) Search for 'An error occurred when updating this list'
on your preferred language translation file for staff
or opac
(xx-YY-staff-prog.po or xx-YY-opac-bootstrap.po)
You will see a 'big' string to translate

2) Apply the patch

3) Update translation files for your language

4) Search again, big one is gone and there are
new individual strings to translate.

Sorry for not spotting this before string freeze

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15208] Ease translation for shelves messages

2015-11-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15208

--- Comment #4 from Kyle M Hall  ---
Created attachment 44962
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44962=edit
[SIGNED-OFF] Bug 15208: Followup to reorder words

It think it's better to put the shelf name first

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15208] Ease translation for shelves messages

2015-11-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15208

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #44956|0   |1
is obsolete||
  Attachment #44957|0   |1
is obsolete||

--- Comment #3 from Kyle M Hall  ---
Created attachment 44961
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44961=edit
[SIGNED-OFF] Bug 15208: Ease translation for shelves messages

This string patch only puts ...
around shelves messages. It split a monster
translation string into its components.
This kind of string to translate is error-prone.

Also fixed a typo on opac, 'deleteing'

To test:
1) Search for 'An error occurred when updating this list'
on your preferred language translation file for staff
or opac
(xx-YY-staff-prog.po or xx-YY-opac-bootstrap.po)
You will see a 'big' string to translate

2) Apply the patch

3) Update translation files for your language

4) Search again, big one is gone and there are
new individual strings to translate.

Sorry for not spotting this before string freeze

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15208] Ease translation for shelves messages

2015-11-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15208

Kyle M Hall  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15207] Error on upgrade from 3.20.5 to 3.22 beta

2015-11-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15207

Zeno Tajoli  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15091] Batch Checkout Doesn't Tell You it Failed

2015-11-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15091

Marc Véron  changed:

   What|Removed |Added

   Assignee|ve...@veron.ch  |jonathan.dru...@bugs.koha-c
   ||ommunity.org
 Status|Needs Signoff   |Signed Off

--- Comment #20 from Marc Véron  ---
Set Jonathan as assibnee because he made patches #2 and #3

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15207] Error on upgrade from 3.20.5 to 3.22 beta

2015-11-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15207

--- Comment #4 from Zeno Tajoli  ---
About the first error:

The motivation of the error is that in 3.20.5 the second constraint on the
table
 course_reserves is present in its version onf kohastructure.sql:

`course_reserves_ibfk_2` FOREIGN KEY (`ci_id`) REFERENCES `course_items`
(`ci_id`) ON DELETE CASCADE ON UPDATE CASCADE
in
http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=installer/data/mysql/kohastructure.sql;h=52eb88d1c35a3cfd825cd16412b49929ab6153ae;hb=refs/heads/3.20.x#l627

We can see here:
http://stackoverflow.com/questions/12623651/error-error-1005-cant-create-table-errno-121

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15209] New: C4::Koha routines expecting a MARC::Record object should check it is defined

2015-11-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15209

Bug ID: 15209
   Summary: C4::Koha routines  expecting a MARC::Record object
should check it is defined
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: MARC Bibliographic data support
  Assignee: gmcha...@gmail.com
  Reporter: colin.campb...@ptfs-europe.com
QA Contact: testo...@bugs.koha-community.org

This came to light when trying to get plack opac running. A number of routines
in C4::Koha return various identifiers from the marc record but do not check it
is valid before calling methods on it. The resulting errors cause the plack
instance to abort. It is good practice to handle these errors with minimum
inconvenience to the user

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15208] Ease translation for shelves messages

2015-11-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15208

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

   Patch complexity|--- |String patch
   Assignee|koha-b...@lists.koha-commun |bgkrie...@gmail.com
   |ity.org |
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15208] Ease translation for shelves messages

2015-11-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15208

--- Comment #2 from Bernardo Gonzalez Kriegel  ---
Created attachment 44957
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44957=edit
Bug 15208: Followup to reorder words

It think it's better to put the shelf name first

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15091] Batch Checkout Doesn't Tell You it Failed

2015-11-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15091

Marc Véron  changed:

   What|Removed |Added

  Attachment #44492|0   |1
is obsolete||

--- Comment #19 from Marc Véron  ---
Created attachment 44959
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44959=edit
Bug 15091: DEBT is IMPOSSIBLE, not NEEDSCONFIRMATION

Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15206] Show patron's age when filling date of birth in memberentry.pl

2015-11-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15206

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch

--- Comment #2 from Marc Véron  ---
Hi Alex, I like thsi feature.

I played around with a 10 year old kid.

Today we have 18/11/2015

This are my results: 
18/11/2005 -> Age: 10 year(s) 2 day(s) 
18/11/2005 -> Age: 10 year(s) 1 day(s) 
20/11/2005 -> Age: 10 year(s)
21/11/2005 -> Age: 9 year(s) 11 month(s) 30 day(s)
22/11/2005 -> Age: 9 year(s) 11 month(s) 29 day(s)

There seems to be an offset of some days.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15208] Ease translation for shelves messages

2015-11-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15208

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15198] Make OpacSuppression work even if there are no records suppressed

2015-11-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15198

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA
 CC||katrin.fisc...@bsz-bw.de

--- Comment #12 from Katrin Fischer  ---
I am sorry, but this isn't working for me.
I checked that no 942$n != "" existed in my database.
I did a full reindex (-b -v -r).
I checked that "de" returned results on master, then turned on OpacSuppression.
As expected, the search did not return any results after.
Applied patch.
Search is still not returning any results.

What could be wrong? something I can check? 
Running my git installation in Ubuntu 14.04 LTS.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15198] Make OpacSuppression work even if there are no records suppressed

2015-11-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15198

--- Comment #16 from Katrin Fischer  ---
Created attachment 44972
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44972=edit
[PASSED QA] Bug 15198: Change wording of OpacSuppression system preference

Signed-off-by: Hector Castro 
Paragraph rewording successfully

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15198] Make OpacSuppression work even if there are no records suppressed

2015-11-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15198

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15211] Label/patron card creators need to have Tools sidebar

2015-11-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15211

--- Comment #1 from Liz Rea  ---
Created attachment 44973
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44973=edit
Bug 15211 - adding Tools section sidebar to label creator

The label creator had a very sad sidebar, it needed to have the Tools area
sidebar on it.

To test:

Click through all "New" pages, verify that the sidebar appears
Click through all "Manage" pages, verify that the sidebar appears.

Also verify that "Label creator" is bolded in the toolbar while the label
creator is active.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15211] Label/patron card creators need to have Tools sidebar

2015-11-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15211

Liz Rea  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15212] New: Patron lists tool page needs Tools area sidebar

2015-11-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15212

Bug ID: 15212
   Summary: Patron lists tool page needs Tools area sidebar
 Change sponsored?: ---
   Product: Koha
   Version: master
  Hardware: All
OS: All
Status: NEW
  Severity: trivial
  Priority: P5 - low
 Component: Tools
  Assignee: gmcha...@gmail.com
  Reporter: l...@catalyst.net.nz
QA Contact: testo...@bugs.koha-community.org

The patron lists tool doesn't have a "tools" area sidebar. We should add it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15047] Genre/Form-655 URL not clickable in opac-detail.pl, with XSLT enabled

2015-11-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15047

Winona Salesky  changed:

   What|Removed |Added

 CC||wsale...@gmail.com

--- Comment #7 from Winona Salesky  ---
Sorry for the lack of communication. We actually submitted the patches at
nearly the same time. The only difference is my patch uses the named template
subfieldSelectSubject not subfieldSelect. The subfieldSelectSubject template
was developed to address issues with parentheses in subject searches. The 
subfieldSelectSubject template strips parentheses from the search string. RE:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13650

Hope that helps clarify. 
-Winona


(In reply to Mason James from comment #6)
> (In reply to Nick Clemens from comment #5)
> > The two patches conflict, 
> 
> I have marked my patch obsolete

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15211] Label/patron card creators need to have Tools sidebar

2015-11-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15211

--- Comment #3 from Liz Rea  ---
Note that the 2nd patch depends on the first one.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15190] Bad utf8 decode to unapi and fixing blank screen error status

2015-11-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15190

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |hector.hecax...@gmail.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15211] Label/patron card creators need to have Tools sidebar

2015-11-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15211

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

 CC||hector.hecax...@gmail.com
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15211] Label/patron card creators need to have Tools sidebar

2015-11-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15211

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

  Attachment #44973|0   |1
is obsolete||

--- Comment #4 from Héctor Eduardo Castro Avalos  ---
Created attachment 44975
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44975=edit
[SIGNED-OFF]Bug 15211: adding Tools section sidebar to label creator

The label creator had a very sad sidebar, it needed to have the Tools area
sidebar on it.

To test:

Click through all "New" pages, verify that the sidebar appears
Click through all "Manage" pages, verify that the sidebar appears.

Also verify that "Label creator" is bolded in the toolbar while the label
creator is active.

Signed-off-by: Hector Castro 
Sidebar displayed Ok. No errors

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15211] Label/patron card creators need to have Tools sidebar

2015-11-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15211

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

  Attachment #44974|0   |1
is obsolete||

--- Comment #5 from Héctor Eduardo Castro Avalos  ---
Created attachment 44976
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44976=edit
[SIGNED-OFF]Bug 15211: Patron card creator needs tools sidebar

The patron card creator should have the Tools area sidebar on its pages. This
patch adds it.

To test:
Go to More -> Tools -> Patron card creator

The home page should have the tools sidebar
Click through all of the "New" pages - they should all have the tools sidebar
Click through all of the "Manage" pages - they should all have the tools
sidebar

Also verify that on each page, the Patron card creator link in the sidebar is
bolded

Signed-off-by: Hector Castro 
Sidebar displayed Ok. No errors

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15211] Label/patron card creators need to have Tools sidebar

2015-11-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15211

--- Comment #2 from Liz Rea  ---
Created attachment 44974
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44974=edit
Bug 15211 - Patron card creator needs tools sidebar

The patron card creator should have the Tools area sidebar on its pages. This
patch adds it.

To test:
Go to More -> Tools -> Patron card creator

The home page should have the tools sidebar
Click through all of the "New" pages - they should all have the tools sidebar
Click through all of the "Manage" pages - they should all have the tools
sidebar

Also verify that on each page, the Patron card creator link in the sidebar is
bolded

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15208] Ease translation for shelves messages

2015-11-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15208

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #44961|0   |1
is obsolete||
  Attachment #44962|0   |1
is obsolete||

--- Comment #5 from Katrin Fischer  ---
Created attachment 44968
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44968=edit
Bug 15208: Ease translation for shelves messages

This string patch only puts ...
around shelves messages. It split a monster
translation string into its components.
This kind of string to translate is error-prone.

Also fixed a typo on opac, 'deleteing'

To test:
1) Search for 'An error occurred when updating this list'
on your preferred language translation file for staff
or opac
(xx-YY-staff-prog.po or xx-YY-opac-bootstrap.po)
You will see a 'big' string to translate

2) Apply the patch

3) Update translation files for your language

4) Search again, big one is gone and there are
new individual strings to translate.

Sorry for not spotting this before string freeze

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >