[Koha-bugs] [Bug 15256] Items table on detail page can be broken

2015-11-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15256

Frédéric Demians  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15256] Items table on detail page can be broken

2015-11-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15256

Frédéric Demians  changed:

   What|Removed |Added

  Attachment #45170|0   |1
is obsolete||

--- Comment #3 from Frédéric Demians  ---
Created attachment 45206
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45206=edit
Bug 15256: Fix items table display on the detail page

Bug 14966 fixed a bug but introduced another one: With
IndependentBranches set to 'prevent', if the librarian (without the
superlibrarian permission) can edit items but not all, the table is
broken.  DataTables raises the following warning: "DataTables warning:
table id=DataTables_Table_1 - Requested unknown parameter '8' for row0."
And does not display correctly.

Test plan:
1/ Create a biblio record with 1+ items located in different places.
2/ Create/use a patron with the permission to edit items
3/ Set the IndependentBranches pref to 'prevent'
4/ With this patron logged in, go on the record detail page.
Without this patch, the display is broken (only 1 edit link and 1 td
missing, DataTables raises a warning).
With this patch, the display is correct.

Signed-off-by: Frédéric Demians 
  See the warning, and the broken table. Solved by this patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15256] Items table on detail page can be broken

2015-11-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15256

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 8753] Add forgot password link to OPAC

2015-11-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753

Liz Rea  changed:

   What|Removed |Added

   Priority|P5 - low|P1 - high

--- Comment #146 from Liz Rea  ---
This is a must for 3.24.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15256] Items table on detail page can be broken

2015-11-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15256

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #45206|0   |1
is obsolete||

--- Comment #4 from Katrin Fischer  ---
Created attachment 45207
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45207=edit
[PASSED QA] Bug 15256: Fix items table display on the detail page

Bug 14966 fixed a bug but introduced another one: With
IndependentBranches set to 'prevent', if the librarian (without the
superlibrarian permission) can edit items but not all, the table is
broken.  DataTables raises the following warning: "DataTables warning:
table id=DataTables_Table_1 - Requested unknown parameter '8' for row0."
And does not display correctly.

Test plan:
1/ Create a biblio record with 1+ items located in different places.
2/ Create/use a patron with the permission to edit items
3/ Set the IndependentBranches pref to 'prevent'
4/ With this patron logged in, go on the record detail page.
Without this patch, the display is broken (only 1 edit link and 1 td
missing, DataTables raises a warning).
With this patch, the display is correct.

Signed-off-by: Frédéric Demians 
  See the warning, and the broken table. Solved by this patch.

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11358] Use Amazon's HTTPS URLs for covers when using HTTPS in Koha.

2015-11-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11358

Charles Farmer  changed:

   What|Removed |Added

 CC||charles.far...@inlibro.com

--- Comment #14 from Charles Farmer  ---
Test plan (do all these tests on HTTP)

To test the changes in staff-global.css, doc-head-close.inc and amazonimages.js
:

1) Go to your INTRANET
2) Under the search bar, click on "Search the catalog"
3) Enter a criteria for which you'll get more than one result
4) Documents without an amazon image should have a "No cover image
available" placeholder
5) (hard part) Somehow, disable javascript in your browser
1) Under firefox, click F12
2) Click the gear icon at the top right side of the developer
interface (4th item from the right)
3) Under "Advanced settings", you'll find "Disable javascript":
Click it.
6) After a forced page reload, instead of a placeholder image, you
should see a 1x1 image.

Intranet:

1) Go to your INTRANET
2) Under the search bar, click on "Search the catalog"
3) Enter a criteria for which you'll get more than one result
4) Click on an entry with a visible image
5) The *amazon-bookcoverimg* should come from
https://images-na.ssl-images-amazon.com/

OPAC:

1) Go to your OPAC
2) Search the library catalog for something
1) Images in the result page should be HTTPS
3) Click on anything with an amazon image
4) The opac-detail page should show an HTTPS image
5) On the bottom of the page, open the shelf browser
1) The image should be in HTTPS there too

===

1) Go to the page http:///cgi-bin/koha/opac-showreviews.pl
2) Book images should be in HTTPS

//

To be quite honest, I don't know where opac-results-grouped.tt is used. I will
leave this as an exercise for the reader.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14978] issues.itemnumber should be a unique key

2015-11-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14978

Frédéric Demians  changed:

   What|Removed |Added

 CC||frede...@tamil.fr

--- Comment #5 from Frédéric Demians  ---
Does this patch need to be backported to 3.20.x?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15081] TestBuilder should not handle the transaction

2015-11-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15081

Frédéric Demians  changed:

   What|Removed |Added

 CC||frede...@tamil.fr

--- Comment #10 from Frédéric Demians  ---
Is this patch needed on 3.20.x branch for its test suite?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13871] OverDrive message when user authentication fails

2015-11-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13871

--- Comment #20 from Bob Birchall  ---
Given Mason's comments, does this still need to be in Failed QA?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15216] Display Branch names and itemtype descriptions on the returns page

2015-11-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15216

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch

--- Comment #6 from Marc Véron  ---
Hi Katrin, I wanted to test but the patch does not apply. Could it be that
there is one patch to much that is obsoleted?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15216] Display Branch names and itemtype descriptions on the returns page

2015-11-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15216

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #45128|1   |0
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15216] Display Branch names and itemtype descriptions on the returns page

2015-11-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15216

--- Comment #7 from Katrin Fischer  ---
I restored the first patch - thx Marc!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15216] Display Branch names and itemtype descriptions on the returns page

2015-11-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15216

Marc Véron  changed:

   What|Removed |Added

  Attachment #45175|0   |1
is obsolete||

--- Comment #8 from Marc Véron  ---
Created attachment 45180
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45180=edit
Bug 15216: Returns - Show collection description

The table of returns displays the collection code
instead of the description. This patch fixes that.

Same as first patch:

To test:
- Check out some items
- Return the items
- Verify the changes in the table of returned items

Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15216] Display Branch names and itemtype descriptions on the returns page

2015-11-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15216

Marc Véron  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11280] Change Withdrawn toggle to drop down selection of authorized values

2015-11-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11280

Emma Perks  changed:

   What|Removed |Added

 CC||emma.perks@heartofengland.n
   ||hs.uk

--- Comment #2 from Emma Perks  ---
Still valid. Requested by library staff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10773] Add item-level descriptions for Label Printing

2015-11-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10773

Giannis Tsakonas  changed:

   What|Removed |Added

 CC||j...@lis.upatras.gr

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15259] New: Formatting spine labels

2015-11-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15259

Bug ID: 15259
   Summary: Formatting spine labels
 Change sponsored?: ---
   Product: Koha
   Version: 3.18
  Hardware: All
OS: All
Status: NEW
  Severity: enhancement
  Priority: P5 - low
 Component: Label/patron card printing
  Assignee: cnighswon...@foundations.edu
  Reporter: j...@lis.upatras.gr
QA Contact: testo...@bugs.koha-community.org

According to the manual it is possible, when creating spine labels from "Tools
> Labels home > Manage label layouts > Edit Label layout", to have static text
in single quote marks, such as "mytext".

It seems though that when placed in the layout editor and the "Bibliographic
data to print > Field list" the static text and a field/subfield name can not
go in one
comma delimited section, i.e. 'mytext' copy number = c. 1 (when 1 is taken by
852t). 

In order for static text to work it needs to be separated by another comma,
which breaks the line and it is not what exactly we would be ideal to have.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10076] Add Bcc syspref for claimacquisition and clamissues

2015-11-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10076

Charles Farmer  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10076] Add Bcc syspref for claimacquisition and clamissues

2015-11-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10076

Charles Farmer  changed:

   What|Removed |Added

  Attachment #40843|0   |1
is obsolete||
  Attachment #40844|0   |1
is obsolete||
  Attachment #40845|0   |1
is obsolete||

--- Comment #16 from Charles Farmer  ---
Created attachment 45181
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45181=edit
Bug 10076 - Add Bcc syspref for ClaimAcquisition and ClaimIssues

This is a squash of the previous three patches, with capitalization of the
syspref 'ClaimsBccCopy'

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10076] Add Bcc syspref for claimacquisition and clamissues

2015-11-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10076

Charles Farmer  changed:

   What|Removed |Added

 CC||charles.far...@inlibro.com
   Assignee|maxime.beaul...@inlibro.com |charles.far...@inlibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11358] Use Amazon's HTTPS URLs for covers when using HTTPS in Koha.

2015-11-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11358

Charles Farmer  changed:

   What|Removed |Added

  Attachment #35264|0   |1
is obsolete||

--- Comment #12 from Charles Farmer  ---
Created attachment 45182
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45182=edit
Bug: 11358 - Use HTTPS Amazon images everywhere

Tried to solve the conflicts. Additionnaly, edited files that were still using
"http://images.amazon.com;. Please test thoroughly.

Using HTTPS on an HTTP page shouldn't trigger security issues. I pruned some
templates to use HTTPS whenever we're fetching an image from Amazon instead of
switching on the using_https variable.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11358] Use Amazon's HTTPS URLs for covers when using HTTPS in Koha.

2015-11-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11358

Charles Farmer  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 10076] Add Bcc syspref for claimacquisition and clamissues

2015-11-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10076

Frédéric Demians  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 10076] Add Bcc syspref for claimacquisition and clamissues

2015-11-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10076

Frédéric Demians  changed:

   What|Removed |Added

  Attachment #45181|0   |1
is obsolete||

--- Comment #17 from Frédéric Demians  ---
Created attachment 45183
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45183=edit
Bug 10076 - Add Bcc syspref for ClaimAcquisition and ClaimIssues

There is already a syspref called "OverdueNoticeBcc" for sending Bcc
copies of mails sent for overdues and other notices. This patch add a
new syspref ClaimsBccCopy to bcc the claimacquisition and clamissues
alerts.

Signed-off-by: Frédéric Demians 
  Works as described.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12772] Overdue Notice/Status triggers tool

2015-11-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12772

Eivin Giske Skaaren  changed:

   What|Removed |Added

  Attachment #41477|0   |1
is obsolete||
  Attachment #41478|0   |1
is obsolete||
  Attachment #41479|0   |1
is obsolete||
  Attachment #41480|0   |1
is obsolete||
  Attachment #41855|0   |1
is obsolete||
  Attachment #42126|0   |1
is obsolete||

--- Comment #12 from Eivin Giske Skaaren  ---
Created attachment 45184
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45184=edit
Bug 12772: tmp commit rename db updatefile back to .pl for 12772

The file needs to be renamed so that the next patch can go through.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12772] Overdue Notice/Status triggers tool

2015-11-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12772

--- Comment #13 from Eivin Giske Skaaren  ---
Created attachment 45185
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45185=edit
Bug 12772 - Update Database (Based on Bug13624)

This patch applies to Bug13624.

Removes letter number from overduerules and overdurules_transport_types

modified:  
installer/data/mysql/atomicupdate/update_13624_overduerules_transport_type.pl
modified:   installer/data/mysql/kohastructure.sql

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12772] Overdue Notice/Status triggers tool

2015-11-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12772

--- Comment #14 from Eivin Giske Skaaren  ---
Created attachment 45186
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45186=edit
Bug 12772 - Overdue rules tool and backend library

modified:   C4/Overdues.pm
modified:  
koha-tmpl/intranet-tmpl/prog/en/modules/tools/overduerules.tt
modified:   tools/overduerules.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12772] Overdue Notice/Status triggers tool

2015-11-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12772

--- Comment #15 from Eivin Giske Skaaren  ---
Created attachment 45187
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45187=edit
Bug 12772 - Reworked overdue_notices.pl script

modified:   misc/cronjobs/overdue_notices.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12772] Overdue Notice/Status triggers tool

2015-11-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12772

--- Comment #18 from Eivin Giske Skaaren  ---
Created attachment 45190
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45190=edit
Bug 12772 - Fix rule updates

Overduerules ID was not sent correctly when editing rules, resulting in rule
being cleared instead of updated. This patch fixes this issue, and a couple of
uninitilized values as a bonus.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12772] Overdue Notice/Status triggers tool

2015-11-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12772

--- Comment #16 from Eivin Giske Skaaren  ---
Created attachment 45188
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45188=edit
Bug 12772 - Renames atomic update file, .pl -> .perl

renamed:update_13624_overduerules_transport_type.pl ->
update_13624_overduerules_transport_type.perl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12772] Overdue Notice/Status triggers tool

2015-11-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12772

--- Comment #17 from Eivin Giske Skaaren  ---
Created attachment 45189
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45189=edit
Bug 12772 - Fix warnings

This commit fixes a bunch of warnings for verbose
messages which would clutter up the output.
They should not affect normal excution.

Sponsored-By: Halland County Library

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12772] Overdue Notice/Status triggers tool

2015-11-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12772

Eivin Giske Skaaren  changed:

   What|Removed |Added

  Attachment #45184|0   |1
is obsolete||
  Attachment #45185|0   |1
is obsolete||

--- Comment #19 from Eivin Giske Skaaren  ---
Created attachment 45191
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45191=edit
Bug 12772 - Update Database (Based on Bug13624)

This patch applies to Bug13624.

Removes letter number from overduerules and overdurules_transport_types

modified:  
installer/data/mysql/atomicupdate/update_13624_overduerules_transport_type.pl
modified:   installer/data/mysql/kohastructure.sql

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12772] Overdue Notice/Status triggers tool

2015-11-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12772

Eivin Giske Skaaren  changed:

   What|Removed |Added

  Attachment #45188|0   |1
is obsolete||

--- Comment #22 from Eivin Giske Skaaren  ---
Created attachment 45194
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45194=edit
Bug 12772 - Renames atomic update file, .pl -> .perl

renamed:update_13624_overduerules_transport_type.pl ->
update_13624_overduerules_transport_type.perl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12772] Overdue Notice/Status triggers tool

2015-11-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12772

Eivin Giske Skaaren  changed:

   What|Removed |Added

  Attachment #45189|0   |1
is obsolete||

--- Comment #23 from Eivin Giske Skaaren  ---
Created attachment 45195
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45195=edit
Bug 12772 - Fix warnings

This commit fixes a bunch of warnings for verbose
messages which would clutter up the output.
They should not affect normal excution.

Sponsored-By: Halland County Library

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12772] Overdue Notice/Status triggers tool

2015-11-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12772

Eivin Giske Skaaren  changed:

   What|Removed |Added

  Attachment #45190|0   |1
is obsolete||

--- Comment #24 from Eivin Giske Skaaren  ---
Created attachment 45196
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45196=edit
Bug 12772 - Fix rule updates

Overduerules ID was not sent correctly when editing rules, resulting in rule
being cleared instead of updated. This patch fixes this issue, and a couple of
uninitilized values as a bonus.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12772] Overdue Notice/Status triggers tool

2015-11-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12772

Eivin Giske Skaaren  changed:

   What|Removed |Added

  Attachment #45186|0   |1
is obsolete||

--- Comment #20 from Eivin Giske Skaaren  ---
Created attachment 45192
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45192=edit
Bug 12772 - Overdue rules tool and backend library

modified:   C4/Overdues.pm
modified:  
koha-tmpl/intranet-tmpl/prog/en/modules/tools/overduerules.tt
modified:   tools/overduerules.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12772] Overdue Notice/Status triggers tool

2015-11-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12772

Eivin Giske Skaaren  changed:

   What|Removed |Added

  Attachment #45187|0   |1
is obsolete||

--- Comment #21 from Eivin Giske Skaaren  ---
Created attachment 45193
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45193=edit
Bug 12772 - Reworked overdue_notices.pl script

modified:   misc/cronjobs/overdue_notices.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12772] Overdue Notice/Status triggers tool

2015-11-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12772

--- Comment #25 from Eivin Giske Skaaren  ---
Created attachment 45197
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45197=edit
Bug 12772: Add back file so next patch does not fail

This file is needed so that Update Database (Based in Bug13624)
can succeed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12772] Overdue Notice/Status triggers tool

2015-11-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12772

Eivin Giske Skaaren  changed:

   What|Removed |Added

  Attachment #45195|0   |1
is obsolete||

--- Comment #31 from Eivin Giske Skaaren  ---
Created attachment 45203
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45203=edit
Bug 12772 - Fix warnings

This commit fixes a bunch of warnings for verbose
messages which would clutter up the output.
They should not affect normal excution.

Sponsored-By: Halland County Library

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12772] Overdue Notice/Status triggers tool

2015-11-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12772

Eivin Giske Skaaren  changed:

   What|Removed |Added

  Attachment #45192|0   |1
is obsolete||

--- Comment #28 from Eivin Giske Skaaren  ---
Created attachment 45200
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45200=edit
Bug 12772 - Overdue rules tool and backend library

modified:   C4/Overdues.pm
modified:  
koha-tmpl/intranet-tmpl/prog/en/modules/tools/overduerules.tt
modified:   tools/overduerules.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12772] Overdue Notice/Status triggers tool

2015-11-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12772

Eivin Giske Skaaren  changed:

   What|Removed |Added

  Attachment #45193|0   |1
is obsolete||

--- Comment #29 from Eivin Giske Skaaren  ---
Created attachment 45201
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45201=edit
Bug 12772 - Reworked overdue_notices.pl script

modified:   misc/cronjobs/overdue_notices.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12772] Overdue Notice/Status triggers tool

2015-11-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12772

Eivin Giske Skaaren  changed:

   What|Removed |Added

  Attachment #45196|0   |1
is obsolete||

--- Comment #32 from Eivin Giske Skaaren  ---
Created attachment 45204
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45204=edit
Bug 12772 - Fix rule updates

Overduerules ID was not sent correctly when editing rules, resulting in rule
being cleared instead of updated. This patch fixes this issue, and a couple of
uninitilized values as a bonus.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12772] Overdue Notice/Status triggers tool

2015-11-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12772

Eivin Giske Skaaren  changed:

   What|Removed |Added

  Attachment #45191|0   |1
is obsolete||

--- Comment #27 from Eivin Giske Skaaren  ---
Created attachment 45199
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45199=edit
Bug 12772 - Update Database (Based on Bug13624)

This patch applies to Bug13624.

Removes letter number from overduerules and overdurules_transport_types

modified:  
installer/data/mysql/atomicupdate/update_13624_overduerules_transport_type.pl
modified:   installer/data/mysql/kohastructure.sql

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12772] Overdue Notice/Status triggers tool

2015-11-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12772

Eivin Giske Skaaren  changed:

   What|Removed |Added

  Attachment #45194|0   |1
is obsolete||

--- Comment #30 from Eivin Giske Skaaren  ---
Created attachment 45202
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45202=edit
Bug 12772 - Renames atomic update file, .pl -> .perl

renamed:update_13624_overduerules_transport_type.pl ->
update_13624_overduerules_transport_type.perl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15225] Make HTML5Media work with file upload feature

2015-11-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15225

--- Comment #1 from Mirko Tietgen  ---
Created attachment 45205
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45205=edit
Bug 15225: Make HTML5Media work with file upload feature.

Koha::Upload allows files to be attached to bibliographic records.
HTML5Media streaming in Koha does not work with these files.

Test plan:
- apply patch
- make sure OPACBaseURL is set correctly
- enable HTML5MediaEnabled in OPAC and staff client
- connect upload.pl to 856$u in your framework
- upload a file with an extension set in HTML5MediaExtensions,
  make sure to set the codec correctly if you use WEBM (subfield c,
  eg. 'vp8, vorbis')
- save record, view in staff client and browser, check if 'Play
  media' option is available and works

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12772] Overdue Notice/Status triggers tool

2015-11-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12772

Eivin Giske Skaaren  changed:

   What|Removed |Added

  Attachment #45197|0   |1
is obsolete||

--- Comment #26 from Eivin Giske Skaaren  ---
Created attachment 45198
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45198=edit
Bug 12772: Add back file so next patch does not fail

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15225] Make HTML5Media work with file upload feature

2015-11-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15225

Mirko Tietgen  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11358] Use Amazon's HTTPS URLs for covers when using HTTPS in Koha.

2015-11-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11358

--- Comment #13 from M. Tompsett  ---
(In reply to Charles Farmer from comment #12)
> Please test thoroughly.

Can't test thoroughly WITHOUT A TEST PLAN.
See comment #3, comment #6, comment #11. I keep asking for one, and keep not
getting one. Post a thorough test plan, and I will test.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12772] Overdue Notice/Status triggers tool

2015-11-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12772

Eivin Giske Skaaren  changed:

   What|Removed |Added

 CC||ei...@sysmystic.com

--- Comment #33 from Eivin Giske Skaaren  ---
Sorry for the clutter of updates.
This was a bit of a tricky rebase but the patch now applies again.

Remember that applying 13624 is a prereq for applying this patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 14676] UI/UX enhancements for the patron card creator

2015-11-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14676

Frédéric Demians  changed:

   What|Removed |Added

 Blocks||15112


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15112
[Bug 15112] Make greybox consistent size across label and patron card creator
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15112] Make greybox consistent size across label and patron card creator

2015-11-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15112

Frédéric Demians  changed:

   What|Removed |Added

 CC||frede...@tamil.fr
 Depends on||14676

--- Comment #5 from Frédéric Demians  ---
Can't be backported to 3.20.x because depends on bug 14676.


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14676
[Bug 14676] UI/UX enhancements for the patron card creator
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/