[Koha-bugs] [Bug 15150] t/ tests should pass if Test::DBIx::Class is not available
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15150 Frédéric Demians changed: What|Removed |Added CC||frede...@tamil.fr --- Comment #5 from Frédéric Demians --- I don't understand whether this patch can/must be backported to 3.20.x. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15206] Show patron's age when filling date of birth in memberentry.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15206
Alex Arnaud changed:
What|Removed |Added
Status|Needs Signoff |In Discussion
--- Comment #7 from Alex Arnaud ---
(In reply to Frédéric Demians from comment #6)
> Code review:
>
> You have:
>
> function CalculateAge(dateofbirth) {
>
> Then, you don't use "dateofbirth".
>
> You have:
>
> onchange="CalculateAge(document.form.dateofbirth);"
>value="[% UNLESS opduplicate %][% dateofbirth %][% END %]" />
>
> You rather should use jQuery:
>
> $( "#dateofbirth" ).change(CalculateAge);
You are right. I forgot to remove the function parameter. Using
"$("#dateofbirth").datepicker( 'getDate' )" is bettre because it gives me the
correct date format
>
> From an UI point of view, it seems awkward to have displayed firstly
> "DD/MM/" under the Date of birth text box, and then having this info
> replaced by the age. This way, it's not possible to see the age without
> modifying the date of birth. Wouldn't it be better/simpler to display the age
> on the detail page (moremember.pl), rather than on the editing page
> (memberentry.pl)?
The main goal is to have directly the age under the datepiker while typing the
date of birth. This allows librarian, for example, to change the category
consequently
>
> Have you seen that there is already a Perl function calculating age in Koha?
> C4::Members::GetAge(). There is a risk that your javascript code and Perl
> GetAge() produce a different age.
So, i should make an Ajax call to a perl script to use this existing sub. But
why not
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15217] variables declared twice in in catalogue/search.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15217 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Attachment #45017|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10407] allow MARCXML records to be imported via Koha's GUI
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10407 Mirko Tietgen changed: What|Removed |Added CC||mi...@abunchofthings.net --- Comment #13 from Mirko Tietgen --- Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 10407 - allow MARCXML records to be imported via Koha's GUI fatal: sha1 information is lacking or useless (C4/ImportBatch.pm). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 10407 - allow MARCXML records to be imported via Koha's GUI -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15206] Show patron's age when filling date of birth in memberentry.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15206 --- Comment #8 from Frédéric Demians --- > The main goal is to have directly the age under the datepiker while typing > the date of birth. This allows librarian, for example, to change the > category consequently OK. Interesting for librarian, indeed. Would be great to have it also on borrower detail page. > > Have you seen that there is already a Perl function calculating age in Koha? > > C4::Members::GetAge(). There is a risk that your javascript code and Perl > > GetAge() produce a different age. > So, i should make an Ajax call to a perl script to use this existing sub. > But why not With Koha brand new REST API... Or you can alternatively do it JS but adding some tests to guaranty consistency. I even see in my crystal ball GetAge() modified to delegate to MySQL the age calculation for stability reason. For example: SELECT TIMESTAMPDIFF(YEAR,'2010-09-10',CURDATE()) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15217] variables declared twice in in catalogue/search.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15217 Katrin Fischer changed: What|Removed |Added Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15217] variables declared twice in in catalogue/search.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15217 Katrin Fischer changed: What|Removed |Added Attachment #45156|0 |1 is obsolete|| --- Comment #4 from Katrin Fischer --- Created attachment 45208 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45208&action=edit [PASSED QA] Bug 15217 Remove redundant duplicate var declaration remove superfluous second declaration of template, borrowernumber and cookie which are never used Also removed the variables @results and @results_array which are declared but not used Signed-off-by: Frédéric Demians As suggested by Colin, perl -wc catalogue/search.pl doesn't complain anymore after applying the patch. perlcritic confirms the 2 variables were unused. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7683] statistic wizard: cataloging
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7683 --- Comment #103 from Katrin Fischer --- Working on this again now... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8612] CSV export profile to have custom fields in export csv basket
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612 Josef Moravec changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply --- Comment #21 from Josef Moravec --- Could you please rebase and change the icon to Font Awesome icon? See http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13696 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15081] TestBuilder should not handle the transaction
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15081 --- Comment #11 from Tomás Cohen Arazi --- (In reply to Frédéric Demians from comment #10) > Is this patch needed on 3.20.x branch for its test suite? I don't think so. It is part of a bigger tests rewrite. If it applies, it shouldn't harm and could help make jenkins stable for 3.20. But maybe it is not worth the trouble. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8753] Add forgot password link to OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 Josef Moravec changed: What|Removed |Added Status|Signed Off |Patch doesn't apply --- Comment #147 from Josef Moravec --- I agree, but rebase needed... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8753] Add forgot password link to OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #148 from Blou --- Will be done today. We will never surrender... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15260] New: Option for extended loan with useDaysMode
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15260 Bug ID: 15260 Summary: Option for extended loan with useDaysMode Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Holidays Assignee: koha-bugs@lists.koha-community.org Reporter: sally.hea...@cheshiresharedservices.gov.uk QA Contact: testo...@bugs.koha-community.org Could an option be introduced for holiday closures where the due date is set to be the next matching open day? (Matching means Monday = Monday, Tuesday = Tuesday etc.) There are currently 3 options with holiday dates using useDaysMode syspref: 1) Circulation rules only = no change to expected due date 2) Calendar to push the due date to next open day = due date changed to next open day 3) Calendar to skip all days the library is closed = extra days - equivalent to closed days - added We use 21 days as our loan period. When a due date falls on a closed day, we would like to offer a loan on the next matching open day - e.g. a 28 day loan, not a 22 day loan. If an item is borrowed on Monday 1st June, it would ordinarily be due on Monday 22nd June (21 day loan as standard). If a library was closed on Monday 22nd June, we would like the due date to be Monday 29th June (28 day loan) - not Tuesday 23rd June (22 day loan). This isn't just a 7 day push on because of Christmas holidays. For example: Items borrowed on Friday 4th December should be due back Friday 25th December. Friday 25th December is closed. A 28 day loan would cause the items to be due back on Friday 1st January. Friday 1st January is closed. We would like the loan to be pushed to 35 days to the next Friday that the library is open = Friday 8th January, even though the library is open for business on non-matching (Monday, Tuesday, Wednesday etc) days between those dates. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15260] Option for extended loan with useDaysMode
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15260 Sally Healey changed: What|Removed |Added CC||sally.healey@cheshireshared ||services.gov.uk -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8753] Add forgot password link to OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 Charles Farmer changed: What|Removed |Added Attachment #44323|0 |1 is obsolete|| --- Comment #149 from Charles Farmer --- Created attachment 45209 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45209&action=edit Bug 8753 - Add forgot password link to OPAC I've addressed a lot of Liz Rea's points. 1. I have moved the code from updatedatabase.pl and kohastructure.sql to a file in the atomicupdates directory. 1a. The feature is now off by default when the atomicupdate is run. 2. The password reset link is now visible on the home page, in the modal box and on opac-user.pl . 3. The password recovery pages now use bootstrap markup. 4. I am unsure here. I see "New Password:" and "Confirm new password:". 5. This should still work :). 6. I could not reproduce. 7. I have added the userid field. You can now reset the password by submitting either your useid or email address. Both fields can be filled, but the email address must be one of the borrower's (email, emailpro or b_email). When entering only the email address and two borrowers use that same address, the system tells the user to try with another address or to specify his userid. 8. The text is in the atomicupdate file. Have at it, anyone. Concerning the email. It is inconvenient for the use to have to wait X minutes for the message queue the be processed. Maybe we could add a sub in Letters.pm that: Takes the same argments as EnqueueLetter Sends the letter. Saves the letter in the message queue with a 'sent' status. TEST PLAN: Setup) 1) apply the patch 2) go to system preferences OPAC>>Privacy and set 'OpacResetPassword' to ON. 2b) make sure that OpacPasswordChange is also ON. A) 1) refresh front page, click on 'Forgot your password' and enter a VALID address 1b) Also try an INVALID address (valid yet not in your koha db). An error message will show up. 2) An email should be received at that address with a link. 3) Follow the link in the mail to fill the new password. Until a satisfactory new password is entered, the old password is not reset. 4) Go to main page try the new password. B) 1) Repeat the password reset, this time use the userid (username) field. 2) Try to reset the password using a userid and an email not linked to the account. An error appears. 3) Make sure the borrower has many available email addresses. 4) For each email, reset the password using both the userid and the email. The link should be sent to the specified address C) 1) Make sure two borrowers use the same email. 2) Repeat the reset procedure in test case A). An error message appears http://bugs.koha-community.org/show_bug.cgi?id=13068 Author:Maxime Beaulieu Followed test plan. Works as described. Signed-off-by: Marc Véron New sign-off after testing all patches together Signed-off-by: Marc Véron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8753] Add forgot password link to OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 Charles Farmer changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8753] Add forgot password link to OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #152 from Charles Farmer --- Created attachment 45212 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45212&action=edit Bug 8753 - Use Koha::Borrowers instead of C4::Members Use the new library to search for borrowers. Changed how the $borrower variable is used since it is now a Koha::Borrower object. Removed the $protocol parameter from the generated link. It should be included in the OPACBaseURL syspref. modified: C4/Passwordrecovery.pm modified: opac/opac-password-recovery.pl Signed-off-by: Marc Véron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8753] Add forgot password link to OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #155 from Charles Farmer --- Created attachment 45215 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45215&action=edit Bug 8753 - Various little things - removing new dependency, changes to errors, textual updates Koha already has a sub that creates salts, so lets use that instead of math::Random::secure, so as not to add a new dependency. Made the references to "Forgotten password" consistent, including adding it to the title of the page. Also removed the individual error for "this email doesn't belong to this account" as that could expose the existence of a login, which I think we'd rather not do. Made some of the text more grammatically correct, and more library specific. To test: Apply on top of all of the other patches. All the usual checks, plus make sure there are no typos in any text references. Signed-off-by: Marc Véron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8753] Add forgot password link to OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #153 from Charles Farmer --- Created attachment 45213 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45213&action=edit Bug 8753 - [followup] POD cleanup Check to make sure the messages from the qa checker are gone. Note I'm not sure about this one because my test tools are apparently broken, and I can't get the error to manifest. Amended patch by Jonathan Druart: Add a blank line before =head2 It now passes. Signed-off-by: Marc Véron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8753] Add forgot password link to OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 Charles Farmer changed: What|Removed |Added Attachment #44324|0 |1 is obsolete|| Attachment #44325|0 |1 is obsolete|| Attachment #44326|0 |1 is obsolete|| Attachment #44327|0 |1 is obsolete|| Attachment #44329|0 |1 is obsolete|| Attachment #44330|0 |1 is obsolete|| --- Comment #150 from Charles Farmer --- Created attachment 45210 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45210&action=edit Bug 8753 - Followup - change value text on syspref Followup changes text from "The user can reset | can not reset their password on OPAC" to "Library users are allowed | not allowed to recover their password via e-mail in the OPAC" This change more clearly differentiates the purpose of this new preference from OpacPasswordChange. Bug 8753 - followup - update text for link to match common UI paradigms, fixes OpacPublic disabled view Also corrects OpacNav being included on the reset page on private catalogues. Updated the link for forgotten passwords to more closely match common UI paradigms, i.e. Facebook and Twitter To test: apply all patches, link should now be the less verbose "Forgot your password?" disable OpacPublic, anything in opacnav should not appear (you may need to add something to opacnav to test properly) Bug 8753 - [followup] fix the title on opac-password-recovery.tt The title stanza was missing a around it, causing the extra text to appear. To test, apply all patches and make sure it looks ok and there is no extra text at the top or bottom of the page. Bug 8753 - [followup} Correcting spelling mistakes Make sure it all still works Bug 8753 - [followup] fix error when no information is provided To test: All normal checks plus make sure that a nice error is displayed when no data is provided. fixing the deprecated thing Signed-off-by: Marc Véron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8753] Add forgot password link to OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #154 from Charles Farmer --- Created attachment 45214 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45214&action=edit Bug 8753 - Smartmatch substitute, Math::Random::Secure, Perltidy, Passwordrecovery.t This is a collection of changes taken from different comments (but mostly comment 21 and comment 122). Passes qa and prove, on my machine at least. There's also a new test file, Passwordrecovery.t, which covers every method of C4::Passwordrecovery. To test: All normal checks plus : 1/ Receive the email 2/ Click on the link 3/ Change the pwd 4/ Click again on the link 5/ You should immediately get an error message Problems with Math/Random/Secure.pm, is solved in following patch, signing off Signed-off-by: Marc Véron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8753] Add forgot password link to OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #151 from Charles Farmer --- Created attachment 45211 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45211&action=edit Bug 8753 - Fixed the forbidden pattern error in opac-auth.tt I could only reproduce the forbidden pattern error from jonathan Druart's comment#97 locally, so I fixed it. TEST PLAN 1)Apply all patches 2)Forbidden pattern error should not be there anymore Signed-off-by: Marc Véron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8753] Add forgot password link to OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #156 from Charles Farmer --- I had to resubmit every patches because the first one had the merge conflicts. If anybody knows how to obsolete the first patch of a queue without messing the queue order, let me know, it would be appreciated. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15150] t/ tests should pass if Test::DBIx::Class is not available
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15150 Tomás Cohen Arazi changed: What|Removed |Added CC||gmcha...@gmail.com --- Comment #6 from Tomás Cohen Arazi --- (In reply to Frédéric Demians from comment #5) > I don't understand whether this patch can/must be backported to 3.20.x. As I see it, this has been bothering the Packaging manager for a while. He did some trick on building so the process (which runs the tests in t/) doesn't break. If it applies on 3.20, it is a good thing to do (backporting it). But maybe ask Galen, the new packaging manager. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15261] New: Verify if checkouts or reserves requests periods overlap with existing reserves
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 Bug ID: 15261 Summary: Verify if checkouts or reserves requests periods overlap with existing reserves Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: alex.arn...@biblibre.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com When checking out or placing hold, we should check if an existing reserve whose period overlap exists. A user place an hold from opac whose requested period overlap an existing reserve period => prevent reserve, A librarian place an hold from staff whose requested period overlap an existing reserve period => Warn librarian (Ask for confirmation), A librarian make a checkout from staff whose requested period overlap an existing reserve period => Warn librarian (Ask for confirmation). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 Alex Arnaud changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |alex.arn...@biblibre.com |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15150] t/ tests should pass if Test::DBIx::Class is not available
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15150 --- Comment #7 from Frédéric Demians --- (In reply to Tomás Cohen Arazi from comment #6) > If it applies on 3.20, it is a good thing to do (backporting it). > But maybe ask Galen, the new packaging manager. This patch touches several tests that have changed (more tests). So the backporting is tricky. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 --- Comment #1 from Julian Maurice --- Created attachment 45216 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45216&action=edit Bug 15261: Verify if checkouts/reserves requests periods overlap... ... with existing reserves When checking out or placing hold, we should check if an existing reserve whose period overlap exists. A user place an hold from opac whose requested period overlap an existing reserve period => prevent reserve, A librarian place an hold from staff whose requested period overlap an existing reserve period => Warn librarian (Ask for confirmation), A librarian make a checkout from staff whose requested period overlap an existing reserve period => Warn librarian (Ask for confirmation). Test plan: Enable syspref: AllowHoldDateInFuture OPACAllowHoldDateInFuture 1 (staff side): Place a hold on title (which has only one items) level with start date and expiration date. Place another hold (also title level) with period overlaping this reserve. Check you are warned about an existing reserve 2 (staff side): Place a hold on title (which has more than one items) level with start date and expiration date. Place another hold (also title level) with period overlaping this reserve. Check you are NOT warned about an existing reserve. Because it remains at least one item not reserved. 3 (staff side): Place a hold on item level with start date and expiration date. Place another hold on item level with period overlaping this reserve. Check you are warned about an existing reserve. 4 (opac side): Do the same than for staff side. Instead of a warn, reserve is prevented. 5: Place a hold on title (which has only one items) level with start date and expiration date. Try to checkout the unique item from this title with period overlaping the reserve period. Check you are warned about an existing reserve 6: Place a hold on title (which has more than one items) level with start date and expiration date. Checkout an item from this title with period overlaping the reserve period. Check you are NOT warned about an existing reserve. 7: Place a hold on item level with start date and expiration date. Checkout this item period overlaping the reserve period. Check you are warned about an existing reserve -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 Julian Maurice changed: What|Removed |Added CC||julian.maur...@biblibre.com Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10468] patron print summary should show more
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10468 Héctor Eduardo Castro Avalos changed: What|Removed |Added Attachment #41689|0 |1 is obsolete|| Attachment #42133|0 |1 is obsolete|| --- Comment #5 from Héctor Eduardo Castro Avalos --- Created attachment 45217 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45217&action=edit Bug 10468: Adding holds table to summary print To test: 1) Add a hold to a patron 2) Go to patron page 3) Click Print Summary 4) Confirm that 'Pending Holds' table displays with correct information under appropriate headings (should be Title, Author, Placed on (reserve date), Expires on (expiration date), and Pick up library) Signed-off-by: Hector Castro Works as advertised -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10468] patron print summary should show more
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10468 Héctor Eduardo Castro Avalos changed: What|Removed |Added CC||hector.hecax...@gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10468] patron print summary should show more
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10468 --- Comment #6 from Héctor Eduardo Castro Avalos --- (In reply to Aleisha Amohia from comment #4) > Created attachment 42133 [details] [review] > Bug 10468: Fix for qa tools > > Hopefully this gets rid of those complaints! Hi Aleisha I squashed the two patches and I've signed-off also patches did not apply due the changes introduced by Bug 15068, but i fixed it up. Regards -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11299] Add a button that automatically links authority records to a biblio record during edition. (AJAX)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 Bouzid changed: What|Removed |Added Attachment #39477|0 |1 is obsolete|| Attachment #39478|0 |1 is obsolete|| Attachment #39479|0 |1 is obsolete|| Attachment #40831|0 |1 is obsolete|| Attachment #41229|0 |1 is obsolete|| --- Comment #22 from Bouzid --- Created attachment 45218 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45218&action=edit Bug 11299 - Add a button to the biblio edition page to automatically add authority links in the current biblio record via AJAX. Also adds a button to easily create missing authority records. add authority type in the form to create the missing authority. when authority was found, the 600$9 field have the authid. Testing scenario (Creating an authority record for a failed automatic link) : * In you system preferences, deactivate the "AutoCreateAuthorities" preference. * Go to the biblio record creation form to create a new biblio record. (koha/cataloguing/addbiblio.pl) * Click the "Link authorities automatically" button. A message should appear, telling the user "No authority link was changed." * Add random informations in field 600$a of the biblio record. * Click the "Link authorities automatically" button. * if matching authority was found, The message box should now show "600 - A matching authority was found in the local database". * if no matching authority was found, the message box should now show "600 - No matching authority found.". For this scenario, we want the authority match to have failed. * The 600$9 field should now be red and icons should have appeared next to it. Click on the "create authority" icon. * A popup will appear, containing a form to create the missing authority. The form should be pre-filled, a the informations in the 600$a field of the biblio shouldbe in the 100$a field of this new authority record. * Fill in the form and click the "Save" button * The 600$9 field in the biblio record should now be back to normal and have the authid of the authority record that was just created. * Click the "Link authorities automatically" button again. The message box should now show "No authority link was changed.". -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8753] Add forgot password link to OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8753 --- Comment #157 from Josef Moravec --- I think that files kohastructure.sql and sysprefs.sql, should be updated too, not only to add atomicupdate sql file... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
