[Koha-bugs] [Bug 15206] Show patron's age when filling date of birth in memberentry.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15206 --- Comment #15 from Frédéric Demians--- Otherwise, jQuery ajax call seem great :-) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14759] Replacement for Text::Unaccent
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14759 Yuval Hagerchanged: What|Removed |Added CC||yha...@yhager.com --- Comment #16 from Yuval Hager --- I ran the script from comment #5 on some more Hebrew text, I hope I did not forget any diacritic marks. I don't know what Text::Unaccent is doing. Text::Unaccent::PurePerl on the other hand seems to be doing too little, if at all. All the outputs from 'Strip NonspacingMark' seems correct - it's perfectly readable and have all the diacritics removed. I modified the script a bit, so it's easy to compare the three options: Text::Unaccent - קָמָץ => קָ×ָץ Text::Unaccent - פַתח => ×¤Ö·×ª× Text::Unaccent - עִבְרִית => ×¢Ö´×ְרִ×ת Text::Unaccent - חוֹלָם => ××Ö¹×Ö¸× Text::Unaccent - זָנָב, תָּכְנִית => ×Ö¸× Ö¸×, תָּ×Ö°× Ö´×ת Text::Unaccent - צָהֳרַיִם => צָ×ֳרַ×Ö´× Text::Unaccent - קַל => ×§Ö·× Text::Unaccent - חֲלוֹם => ×Ö²××Ö¹× Text::Unaccent - מֶלֶךְ => ×Ö¶×Ö¶×Ö° Text::Unaccent - נֶאֱמָן => × Ö¶×Ö±×Ö¸× Text::Unaccent - לֵב => ×Öµ× Text::Unaccent - יִכְתְּבוּ => ×Ö´×ְתְּ××Ö¼ Text::Unaccent - שִׁיר => שִ××ר Text::Unaccent - דֻּבִּים => ×Ö»Ö¼×Ö´Ö¼×× Text::Unaccent - חֹלִי => ×Ö¹×Ö´× Text::Unaccent - סוּס => ס×ּס Text::Unaccent - נוֹף => × ×Ö¹×£ Text::Unaccent - גַמּד => ×Ö·×Ö¼× Text::Unaccent - מְסַבֵּךְ => ×ְסַ×ÖµÖ¼×Ö° Text::Unaccent - שולחנהּ => ש ×Ö¼ Text::Unaccent - שֵׁם => שֵ×× Text::Unaccent - עֶשֶׂר => עֶשֶ×ר Text::Unaccent - אֵלֶּה, אָנָּא, הֵמָּה, לָמָּה, שָׁמָּה, בָּתִּים, שָׁבַרְתִּי, תַּלְתַּל, לְבַד, חַג, לַיְלָה => ×Öµ×Ö¶Ö¼×, ×Ö¸× Ö¸Ö¼×, ×Öµ×Ö¸Ö¼×, ×Ö¸×Ö¸Ö¼×, שָ××Ö¸Ö¼×, ×ָּתִּ××, שָ××ַרְתִּ×, תַּ×ְתַּ×, ×Ö°×Ö·×, ×Ö·×, ×Ö·×Ö°×Ö¸× Text::Unaccent::PurePerl - קָמָץ => קָמָץ Text::Unaccent::PurePerl - פַתח => פַתח Text::Unaccent::PurePerl - עִבְרִית => עִבְרִית Text::Unaccent::PurePerl - חוֹלָם => חוֹלָם Text::Unaccent::PurePerl - זָנָב, תָּכְנִית => זָנָב, תָּכְנִית Text::Unaccent::PurePerl - צָהֳרַיִם => צָהֳרַיִם Text::Unaccent::PurePerl - קַל => קַל Text::Unaccent::PurePerl - חֲלוֹם => חֲלוֹם Text::Unaccent::PurePerl - מֶלֶךְ => מֶלֶךְ Text::Unaccent::PurePerl - נֶאֱמָן => נֶאֱמָן Text::Unaccent::PurePerl - לֵב => לֵב Text::Unaccent::PurePerl - יִכְתְּבוּ => יִכְתְּבוּ Text::Unaccent::PurePerl - שִׁיר => שִׁיר Text::Unaccent::PurePerl - דֻּבִּים => דֻּבִּים Text::Unaccent::PurePerl - חֹלִי => חֹלִי Text::Unaccent::PurePerl - סוּס => סוּס Text::Unaccent::PurePerl - נוֹף => נוֹף Text::Unaccent::PurePerl - גַמּד => גַמּד Text::Unaccent::PurePerl - מְסַבֵּךְ => מְסַבֵּךְ Text::Unaccent::PurePerl - שולחנהּ => שולחנהּ Text::Unaccent::PurePerl - שֵׁם => שֵׁם Text::Unaccent::PurePerl - עֶשֶׂר => עֶשֶׂר Text::Unaccent::PurePerl - אֵלֶּה, אָנָּא, הֵמָּה, לָמָּה, שָׁמָּה, בָּתִּים, שָׁבַרְתִּי, תַּלְתַּל, לְבַד, חַג, לַיְלָה => אֵלֶּה, אָנָּא, הֵמָּה, לָמָּה, שָׁמָּה, בָּתִּים, שָׁבַרְתִּי, תַּלְתַּל, לְבַד, חַג, לַיְלָה Strip NonspacingMark - קָמָץ => קמץ Strip NonspacingMark - פַתח => פתח Strip NonspacingMark - עִבְרִית => עברית Strip NonspacingMark - חוֹלָם => חולם Strip NonspacingMark - זָנָב, תָּכְנִית => זנב, תכנית Strip NonspacingMark - צָהֳרַיִם => צהרים Strip NonspacingMark - קַל => קל Strip NonspacingMark - חֲלוֹם => חלום Strip NonspacingMark - מֶלֶךְ => מלך Strip NonspacingMark - נֶאֱמָן => נאמן Strip NonspacingMark - לֵב => לב Strip NonspacingMark - יִכְתְּבוּ => יכתבו Strip NonspacingMark - שִׁיר => שיר Strip NonspacingMark - דֻּבִּים => דבים Strip NonspacingMark - חֹלִי => חלי Strip NonspacingMark - סוּס => סוס Strip NonspacingMark - נוֹף => נוף Strip NonspacingMark - גַמּד => גמד Strip NonspacingMark - מְסַבֵּךְ => מסבך Strip NonspacingMark - שולחנהּ => שולחנה Strip NonspacingMark - שֵׁם => שם Strip NonspacingMark - עֶשֶׂר => עשר Strip NonspacingMark - אֵלֶּה, אָנָּא, הֵמָּה, לָמָּה, שָׁמָּה, בָּתִּים, שָׁבַרְתִּי, תַּלְתַּל, לְבַד, חַג, לַיְלָה => אלה, אנא, המה, למה, שמה, בתים, שברתי, תלתל, לבד, חג, לילה -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15240] Performance issue running overdue_notices.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15240 Jonathan Druartchanged: What|Removed |Added Attachment #45554|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15344] GetMemberDetails called unecessary
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15344 --- Comment #3 from Jonathan Druart--- Created attachment 45560 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45560=edit Bug 15344: Remove some other calls of GetMemberDetails from pl scripts Same as previously. For these files it's a bit less obvious. To make sure these changes won't introduce any regression, check that the variable returned by GetMember is never used to get something else than a borrower fields. The 'flags' should not be get neither. For opac-user.tt it's different, other keys are got but there are defined in the pl script. On the way: - 'showname' is removed (never used) - fix scope var issue in opac-user.tt (BORROWER_INF.OPACPatronDetails vs OPACPatronDetails) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15341] Performance - Retrieve all sysprefs at once
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15341 --- Comment #4 from Jonathan Druart--- (In reply to Frédéric Demians from comment #2) > Isn't plack supposed to bring some persistency? And so couldn't we have > preferences available somewhere from one page to the other? Both psgi files (debian/templates/plack.psgi and misc/plack/koha.psgi) disable the syspref cache (C4::Context->disable_syspref_cache();), see bug 13805. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15304] Norwegian patron database: translatable strings added to all po files
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15304 Jonathan Druartchanged: What|Removed |Added Status|Signed Off |In Discussion --- Comment #6 from Jonathan Druart --- Magnus suggested to add the string to the po and you suggest to remove them, it's not the same approach :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13136] No documentation for Home > Tools > Labels home > Manage label Layouts
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13136 Jonathan Druartchanged: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13136] No documentation for Home > Tools > Labels home > Manage label Layouts
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13136 Jonathan Druartchanged: What|Removed |Added Attachment #45536|0 |1 is obsolete|| --- Comment #11 from Jonathan Druart --- Created attachment 45561 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45561=edit Bug 13136: Add missing help file for label-manage.pl This patch adds in a help file for the new label-manage page. To test: * visit label creator * click manage and choose an option * click 'help' and confirm the file loads * repeat for all options under manage Signed-off-by: Hector Castro Works as advertised. Tab char corrected Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15304] Norwegian patron database: translatable strings added to all po files
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15304 --- Comment #7 from Magnus Enger--- In Norway, we have to versions of Norwegian: bokmål and nynorsk. Currently, only a bokmål translation of Koha is maintained, but hopefully the nynorsk translation will be revived in the not too distant future. I think the approach that makes the most sense is the one I have taken: To translate the humanly visible labels into English, so that they can be translated back into both bokmål and nynorsk. Hiding the labels from translation will mean they are stuck in bokmål, and the nynorsk users will be unhappy some time in the future. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15348] New: Change/Edit estimated delivery date per order line
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15348 Bug ID: 15348 Summary: Change/Edit estimated delivery date per order line Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org Currently the estimated delivery date appears to be calculated from the date of the basket was closed and the delivery time defined for the bookseller. Sometimes the library will want to change this date by order line, as it's known that the item will have a later delivery date and they don't want it to be shown on the late orders page. There is currently no way to achieve this as we don't store a delivery date in the order. It would be nice if there was a way to overwrite the calculated delivery date with a manual one. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12803] Add ability to skip closed libraries when generating the holds queue
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 --- Comment #48 from Jonathan Druart--- (In reply to Kyle M Hall from comment #47) > I'm not sure what I can possibly do to get this Passed QA. I get no unit > test failures. You aren't getting them with my "Fix unit tests" followup ( > iirc ). So there is not really anything I can do on my what. Jonthan, can > you please investigate this since you are getting the failures as well? > Thanks! If the tests fail using the same DB as you, it's not related to the patches or the DB. Alone I cannot do anything. Are you using the same version of mysql as me? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7012] Limit to available does not exclude in-transit items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7012 --- Comment #3 from Karl Holten--- (In reply to Owen Leonard from comment #2) > (In reply to comment #1) > > Actually it does work, but 'in transit' is considered 'available' why is > > that? > > Especially since the staff client considers "in transit" to be /unavailable/ > with regard to placing holds from the search results page. This is the main reason we reported it as a bug- so that students at our univerities wouldn't get confused when they tried either placing a hold or finding the material on the shelves and it wasn't available. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7012] Limit to available does not exclude in-transit items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7012 Karl Holtenchanged: What|Removed |Added CC||khol...@switchinc.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14759] Replacement for Text::Unaccent
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14759 --- Comment #17 from Katrin Fischer--- Thx Yuval! It looks to me like using the new method would be a big step in the right direction. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14049] Personalized OPAC purchase suggestion fields
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14049 Marjorie Barry-Vilachanged: What|Removed |Added CC||marjorie.barry-v...@ccsr.qc ||.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15305] KOHA SIP2 checkout doesn't update of the item holding status
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15305 --- Comment #17 from Liz Rea--- Yay! Glad you're sorted. :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14759] Replacement for Text::Unaccent
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14759 --- Comment #19 from David Cook--- (In reply to Katrin Fischer from comment #17) > Thx Yuval! It looks to me like using the new method would be a big step in > the right direction. I agree. Text::Unaccent and Text::Unaccent::PurePerl don't appear to be comprehensive enough to deal with many languages. While it seems to handle Latin and Greek characters, it doesn't do so well with Arabic and Hebrew. Note that nothing seems to happen with the (Japanese?) ideograms that Galen tested. I wonder if accents are even a thing with CJK languages... I've asked a friend who knows Chinese for her input on that one. Oh, I know some people with Japanese experience as well... I should ask them. I think we should also ask Vietnamese users, as Vietnamese has a lot of diacritics... and I think they might actually be quite significant. (https://en.wikipedia.org/wiki/Vietnamese_alphabet#Tone_marks) I'll update the listserv to ask for people with Vietnamese knowledge too... as that could potentially answer Galen's question about whether or not we should even be unaccenting userid values... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14759] Replacement for Text::Unaccent
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14759 --- Comment #18 from David Cook--- Way to go Yuval! Try replacing the following line: print "Text::Unaccent - $_ => " . Text::Unaccent::unac_string('utf-8', $_) . "\n"; with these lines: print "Text::Unaccent - $_ => "; print Text::Unaccent::unac_string('utf-8', $_)."\n"; -- I suspect that will make the output of Text::Unaccent and Text::Unaccent::PurePerl the same. The epic-length posts I wrote earlier were about how Perl wasn't handling the output of Text::Unaccent as expected. -- Replacing this line: use Text::Unaccent qw//; with these lines: use Text::Unaccent qw/unac_debug/; unac_debug($Text::Unaccent::DEBUG_HIGH); That will also tell you what Text::Unaccent is doing (or probably not doing). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13715] problem with "limit to items available" with a notice has multiple items
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13715 NancyK.changed: What|Removed |Added CC||nkee...@washoecounty.us --- Comment #1 from NancyK. --- We have experienced this same issue. It hides the record with multiple available copies. This is happening in the staff client also. NancyK -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14759] Replacement for Text::Unaccent
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14759 --- Comment #20 from Yuval Hager--- > I suspect that will make the output of Text::Unaccent and > Text::Unaccent::PurePerl the same. > Not really, it stays the same garbled mess. > unac_debug($Text::Unaccent::DEBUG_HIGH); > > That will also tell you what Text::Unaccent is doing (or probably not doing). I tested on one string: unac.c:13708: unac_data0[7] & unac_positions[0][8]: 0x05e7 => untouched unac.c:13708: unac_data0[24] & unac_positions[0][25]: 0x05b8 => untouched unac.c:13708: unac_data0[30] & unac_positions[0][31]: 0x05de => untouched unac.c:13708: unac_data0[24] & unac_positions[0][25]: 0x05b8 => untouched unac.c:13708: unac_data0[5] & unac_positions[0][6]: 0x05e5 => untouched Text::Unaccent - קָמָץ => קָ×ָץ > Note that nothing seems to happen with the (Japanese?) ideograms that Galen > tested. I wonder if accents are even a thing with CJK languages... I am definitely not an authoritative source, but I know a tiny bit of Japanese. The letters above are Kanji alphabet, and to the best of my knowledge do not have diacritics. BUT Japanese has two more alphabets, Hiragana and Katakana, both use diacritics, which CANNOT be removed, or they change the sound (and potentially the meaning). For example, in the word Hiragana, the first syllable is ひ (Hi, pronounce Hee). This same syllable, with two ticks is び, and it sounds like Bee. A circle makes it ぴ - sounds like Pee. Testing those three: Text::Unaccent - ひびぴ => ã²ã²ã² Text::Unaccent::PurePerl - ひびぴ => ひひひ Strip NonspacingMark - ひびぴ => ひひひ So we've changed 'Hee Bee Pee' to 'Hee Hee Hee'. The same result (and same syllables) for Katakana: Text::Unaccent - ヒビピ => ããã Text::Unaccent::PurePerl - ヒビピ => ヒヒヒ Strip NonspacingMark - ヒビピ => ヒヒヒ So diacritics, at least in those two alphabets, should not be removed, to the best of my knowledge. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13068] New feature for DB update and sandbox
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 Jonathan Druartchanged: What|Removed |Added Whiteboard|/perl | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13068] New feature for DB update and sandbox
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 Jonathan Druartchanged: What|Removed |Added Whiteboard||/perl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14705] Allow .pl too in atomicupdate
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14705 Jonathan Druartchanged: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #3 from Jonathan Druart --- The point of using .perl instead of .pl was to avoid executing the .pl files existing in the atomicupdate directory before 13068 removed them (it has been useful recently, see bug 14820 comment 8). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15288] Error pages: Code duplication removal and better translatability
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 Jonathan Druartchanged: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #12 from Jonathan Druart --- This patch could annoy people who have customized their template error pages. I don't know how popular is it, but I am not confident to pass QA on it without any feedbacks. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15336] Script for merging booksellers
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15336 --- Comment #5 from Jonathan Druart--- grep booksellerid installer/data/mysql/kohastructure.sql And look at the FK, there is none on these 3 tables, that's why you haven't found them. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15346] Translatability: fix sentence splitting issue in memberentrygen.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15346 Jonathan Druartchanged: What|Removed |Added Attachment #45559|0 |1 is obsolete|| --- Comment #3 from Jonathan Druart --- Created attachment 45562 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45562=edit Bug 15346: Translatability: fix sentence splitting issue in memberentrygen.tt Fix sentences in memberentrygen.tt that are split by tags, leading to wrong capitalization in German (because it can not be decided if a string is part of a sentence or a standalone sentence). Example: Es sind Keine Bibliotheken definiert. To test: - Apply patch - To trigger the messages, you have to edit a patron in a system where no libraries and no patron categories are defined - Alternatively, carefully review the changes in koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt Signed-off-by: Hector Castro Sentences fixed for translation purposes Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15336] Script for merging booksellers
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15336 --- Comment #3 from Jonathan Druart--- Comment on attachment 45530 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45530 Bug 15336 - New command-line script: merge_bookseller.pl Review of attachment 45530: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=15336=45530) - ::: misc/migration_tools/merge_booksellers.pl @@ +1,1 @@ > +#!/usr/bin/perl The copyright is missing. @@ +1,4 @@ > +#!/usr/bin/perl > +# Script that merge source bookseller (-f) into target bookseller (-t). > + > +use strict; use Modern::Perl; @@ +18,5 @@ > +'t:s' => \$mergeto, > +'c' => \$confirm, > +); > + > +if ($help || !$mergefrom || !$mergeto) { you could also test mergefrom == mergeto @@ +30,5 @@ > +my $to_bookseller = Koha::Acquisition::Bookseller->fetch({id => $mergeto}); > +die "Unknown bookseller id ($mergeto)" unless $to_bookseller; > + > +my $report; > +foreach (qw(Aqbasketgroup Aqbasket Aqcontract Aqcontact Aqinvoice)) { What about the tables items, deleteditems, subscription? @@ +31,5 @@ > +die "Unknown bookseller id ($mergeto)" unless $to_bookseller; > + > +my $report; > +foreach (qw(Aqbasketgroup Aqbasket Aqcontract Aqcontact Aqinvoice)) { > +my $rs = Koha::Database->new()->schema->resultset($_); Please don't use $_ @@ +47,5 @@ > +print "\n" if $verbose; > +print_report($report); > +print "Nothing done (test only). Use confirm option to commit changes in > database\n" unless $confirm; > + > +sub print_usage { use Pod::Usage; see misc/export_records.pl for an example. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15336] Script for merging booksellers
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15336 Jonathan Druartchanged: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15346] Translatability: fix sentence splitting issue in memberentrygen.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15346 Jonathan Druartchanged: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15342] Performance 3.22 - Omnibus
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15342 Jonathan Druartchanged: What|Removed |Added Depends on||15350 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15350 [Bug 15350] DBIx::Class Startup speed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15350] DBIx::Class Startup speed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15350 Jonathan Druartchanged: What|Removed |Added Blocks||15342 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15342 [Bug 15342] Performance 3.22 - Omnibus -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13592] Hold fee not being applied on placing a hold
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13592 Sally Healeychanged: What|Removed |Added Attachment #44838|0 |1 is obsolete|| --- Comment #19 from Sally Healey --- Created attachment 45563 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45563=edit Bug 13592: Add an option to charge for any hold placed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13592] Hold fee not being applied on placing a hold
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13592 --- Comment #18 from Sally Healey--- Test plan: 1) Execute the updatedb entry to insert the new pref 2) Confirm that the behavior is the same as before applying this patch 3) Change the HoldFeeMode pref to 'always' 4) Note that the fee is applied for any hold placed Sign off on Jonathan's patch. Signed-off-by: Sally Healey -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13805] Installer does not work under Plack
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13805 Jacek Ablewiczchanged: What|Removed |Added CC||a...@biblos.pk.edu.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12772] Overdue Notice/Status triggers tool
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12772 Jonathan Druartchanged: What|Removed |Added Status|Signed Off |Needs Signoff CC||jonathan.dru...@bugs.koha-c ||ommunity.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15304] Norwegian patron database: translatable strings added to all po files
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15304 --- Comment #9 from Magnus Enger--- (In reply to Jonathan Druart from comment #8) > But could you please rewrite it to avoid as much as possible new strings in > the po files? for instance "Birthdate:" should be "date of birth", so that > it will be automatically translated for other languages and translators > won't have to translate (unnecessarily) new strings. Will do! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15343] Allow patrons to choose their own password on self registration.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15343 Sally Healeychanged: What|Removed |Added CC||sally.healey@cheshireshared ||services.gov.uk -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15341] Performance - Retrieve all sysprefs at once
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15341 Jacek Ablewiczchanged: What|Removed |Added CC||a...@biblos.pk.edu.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15304] Norwegian patron database: translatable strings added to all po files
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15304 --- Comment #8 from Jonathan Druart--- (In reply to Magnus Enger from comment #7) > In Norway, we have to versions of Norwegian: bokmål and nynorsk. Currently, > only a bokmål translation of Koha is maintained, but hopefully the nynorsk > translation will be revived in the not too distant future. That's make a lot of sense and I agree with your patch. But could you please rewrite it to avoid as much as possible new strings in the po files? for instance "Birthdate:" should be "date of birth", so that it will be automatically translated for other languages and translators won't have to translate (unnecessarily) new strings. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15288] Error pages: Code duplication removal and better translatability
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15288 Jonathan Druartchanged: What|Removed |Added Status|Signed Off |In Discussion --- Comment #13 from Jonathan Druart --- Could you ask on koha[-devel] or irc please? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13805] Installer does not work under Plack
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13805 --- Comment #15 from Jacek Ablewicz--- (In reply to Jonathan Druart from comment #14) > This fix is not good for the performance. +1 And in some cases this is going to be _terrible_ for the performance - depending on the given script, and how many times it calls C4::Context->preference(), but there are some scripts and subroutines which tend to do it over and over and over again (1000+ calls per run being not all that uncommon, AFAIRC). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15341] Performance - Retrieve all sysprefs at once
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15341 Jonathan Druartchanged: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=15350 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15350] New: DBIx::Class Startup speed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15350 Bug ID: 15350 Summary: DBIx::Class Startup speed Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.dru...@bugs.koha-community.org Reporter: jonathan.dru...@bugs.koha-community.org QA Contact: testo...@bugs.koha-community.org (This follows 15341 comment 5) From https://metacpan.org/pod/distribution/DBIx-Class/lib/DBIx/Class/Manual/Cookbook.pod#STARTUP-SPEED There are some tips to follow to reduce the DBIx::Class startup delays. === 1 - Statically Define Your Schema If you are using DBIx::Class::Schema::Loader to build the classes dynamically based on the database schema then there will be a significant startup delay. For production use a statically defined schema (which can be generated using DBIx::Class::Schema::Loader to dump the database schema once - see make_schema_at and dump_directory for more details on creating static schemas from a database). 2 - Move Common Startup into a Base Class Typically DBIx::Class result classes start off with use base qw/DBIx::Class::Core/; __PACKAGE__->load_components(qw/InflateColumn::DateTime/); If this preamble is moved into a common base class:- package MyDBICbase; use base qw/DBIx::Class::Core/; __PACKAGE__->load_components(qw/InflateColumn::DateTime/); 1; and each result class then uses this as a base:- use base qw/MyDBICbase/; then the load_components is only performed once, which can result in a considerable startup speedup for schemas with many classes. 3 - Explicitly List Schema Result Classes The schema class will normally contain __PACKAGE__->load_classes(); to load the result classes. This will use Module::Find to find and load the appropriate modules. Explicitly defining the classes you wish to load will remove the overhead of Module::Find and the related directory operations: __PACKAGE__->load_classes(qw/ CD Artist Track /); If you are instead using the load_namespaces syntax to load the appropriate classes there is not a direct alternative avoiding Module::Find. 4 - MEMORY USAGE Cached statements DBIx::Class normally caches all statements with prepare_cached(). This is normally a good idea, but if too many statements are cached, the database may use too much memory and may eventually run out and fail entirely. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15341] Performance - Retrieve all sysprefs at once
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15341 --- Comment #7 from Jonathan Druart--- (In reply to Jacek Ablewicz from comment #6) > (In reply to Jonathan Druart from comment #4) > > (In reply to Frédéric Demians from comment #2) > > > Isn't plack supposed to bring some persistency? And so couldn't we have > > > preferences available somewhere from one page to the other? > > > > Both psgi files (debian/templates/plack.psgi and misc/plack/koha.psgi) > > disable the syspref cache (C4::Context->disable_syspref_cache();), see bug > > 13805. > > Not good ;). But in my tests, with this patch applied, it is even worse - > when syspref cache is disabled: > >#!/usr/bin/perl >use Modern::Perl; >use C4::Context; > >C4::Context->disable_syspref_cache(); > >my @sysprefs = qw/ > UseTransportCostMatrix > StaticHoldsQueueWeight > RandomizeHoldsQueueWeight/; > >for (my $i = 0; $i < 1000; $i++) { > for my $syspref_name (@sysprefs) { >my $syspref_val = C4::Context->preference($syspref_name); > } >} > > Runnig time - without patch: 4.4sec, with patch: 47.2 sec.. > > With syspref cache enabled, the difference is negglible (0.36 patched, 0.37 > sec unpatched), but the patched version still seems to be a bit slower (but > not much, <2 usec per call - hard to measure, in real life scenarios I guess > it will also depend on the mysql query_cache_limit/size/type settings etc.). Yes, I have tested *with* the syspref cache (I should have mentioned that in the commit msg!) What you described is expected, you are not running under Plack and for each call all pref are retrieved from the DB :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15349] New: Problem with email pattern check on forms
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15349 Bug ID: 15349 Summary: Problem with email pattern check on forms Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: katrin.fisc...@bsz-bw.de QA Contact: testo...@bugs.koha-community.org Sometimes you will want to use something like Library Xin your email settings in Koha. This works for example nicely for the branch email address and the emails are sent out correctly. The problem is, that you can't save the value in the staff interface, as the checks for valied entries in the form reports it as an invalid email address. It would be nice if the check on the form was more flexible or could be overwritten. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15341] Performance - Retrieve all sysprefs at once
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15341 --- Comment #5 from Frédéric Demians--- See comment 3. The main issue isn't in preferences by themselves, but in DBIx::Class startup. Let see that: https://metacpan.org/pod/distribution/DBIx-Class/lib/DBIx/Class/Manual/Cookbook.pod#STARTUP-SPEED Loading all Koha schema classes take more than 0.5 seconds on a recent server. With plack, schema shouldn't be reloaded for each page. That's where plack persistency will save time. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15336] Script for merging booksellers
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15336 --- Comment #4 from Alex Arnaud--- > @@ +30,5 @@ > > +my $to_bookseller = Koha::Acquisition::Bookseller->fetch({id => $mergeto}); > > +die "Unknown bookseller id ($mergeto)" unless $to_bookseller; > > + > > +my $report; > > +foreach (qw(Aqbasketgroup Aqbasket Aqcontract Aqcontact Aqinvoice)) { > > What about the tables items, deleteditems, subscription? I checked aqbooksellers relationship on this page: http://schema.koha-community.org/tables/aqbooksellers.html that doesn't mention items, deleteditems or subscription tables. Looks that the schema is not up to date. Is there any other tables i forgot to handle ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15350] DBIx::Class Startup speed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15350 --- Comment #1 from Jonathan Druart--- 1 - Already done 2 - We don't load any components at the moment 3 - In Koha::Schema, I have tried to replace __PACKAGE__->load_namespaces; with my $r = [ qw( Accountline Accountoffset ... Zebraqueue ) ]; __PACKAGE__->load_classes({ 'Koha::Schema::Result' => $r}); I have not noticed any gain using the following script use Koha::Database; Koha::Database->new()->schema()->resultset('Discharge'); Always between 0.85 and 0.90 second 4 - Something to try? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15341] Performance - Retrieve all sysprefs at once
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15341 --- Comment #6 from Jacek Ablewicz--- (In reply to Jonathan Druart from comment #4) > (In reply to Frédéric Demians from comment #2) > > Isn't plack supposed to bring some persistency? And so couldn't we have > > preferences available somewhere from one page to the other? > > Both psgi files (debian/templates/plack.psgi and misc/plack/koha.psgi) > disable the syspref cache (C4::Context->disable_syspref_cache();), see bug > 13805. Not good ;). But in my tests, with this patch applied, it is even worse - when syspref cache is disabled: #!/usr/bin/perl use Modern::Perl; use C4::Context; C4::Context->disable_syspref_cache(); my @sysprefs = qw/ UseTransportCostMatrix StaticHoldsQueueWeight RandomizeHoldsQueueWeight/; for (my $i = 0; $i < 1000; $i++) { for my $syspref_name (@sysprefs) { my $syspref_val = C4::Context->preference($syspref_name); } } Runnig time - without patch: 4.4sec, with patch: 47.2 sec.. With syspref cache enabled, the difference is negglible (0.36 patched, 0.37 sec unpatched), but the patched version still seems to be a bit slower (but not much, <2 usec per call - hard to measure, in real life scenarios I guess it will also depend on the mysql query_cache_limit/size/type settings etc.). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15350] DBIx::Class Startup speed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15350 Jacek Ablewiczchanged: What|Removed |Added CC||a...@biblos.pk.edu.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14156] add id tags to each marc note in the display
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14156 Katrin Fischerchanged: What|Removed |Added Version|unspecified |master CC||katrin.fisc...@bsz-bw.de --- Comment #1 from Katrin Fischer --- I agree - the notes as they are are not very useful. They are not labelled and it's impossible to hide a specific one. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15206] Show patron's age when filling date of birth in memberentry.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15206 Owen Leonardchanged: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #16 from Owen Leonard --- When I try setting a patron's birth date in the patron edit form I get a JavaScript error: "NetworkError: 404 Not Found - /cgi-bin/koha/svc/members/age?dateofbirth=2015-11-9" I also notice that the date I enter isn't the date which is passed in the AJAX call. With MM/DD/ as my system's dateformat preference, I've tried these: Typed 01/03/1990, date passed: 1990-0-3 Typed 12/13/1970, date passed: 1970-11-13 Typed 06/09/2003, date passed: 2003-5-9 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15206] Show patron's age when filling date of birth in memberentry.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15206 --- Comment #14 from Frédéric Demians--- Comment on attachment 45580 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45580 Bug 15206 - CalculateAge in memberentry use C4::Members::GetAge() Review of attachment 45580: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=15206=45580) - ::: koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt @@ +163,5 @@ > +data: 'dateofbirth=' + year + '-' + month + '-' + day, > +dataType: 'json', > +success : function(json, statut){ > +var age_string = "Age: "; > +if (json.years) { age_string += json.years + " year(s) "; } Translation issue here also. http://wiki.koha-community.org/wiki/Coding_Guidelines#JavaScript -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15206] Show patron's age when filling date of birth in memberentry.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15206 --- Comment #13 from Frédéric Demians--- Comment on attachment 45581 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45581 Bug 15206 - Show patron's age in moremenber page near date of birth Review of attachment 45581: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=15206=45581) - ::: koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt @@ +225,4 @@ > [% IF ( emailpro ) %]Secondary email: > mailto:[% emailpro %]">[% emailpro %][% END %] > [% END %] > [% IF ( initials ) %]Initials: [% > initials %][% END %] > +[% IF ( dateofbirth ) %]Date of birth:[% > dateofbirth | $KohaDates %] ([% age %])[% END %] I don't know how to have something translatable here. ::: members/moremember.pl @@ +140,5 @@ > $data->{'IS_ADULT'} = ( $data->{'categorycode'} ne 'I' ); > > +my @age; > +my ($years, $months) = GetAge($data->{dateofbirth}); > +push @age, "$years year(s)" if $years; This line, and the next one, will not be translatable. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15198] Make OpacSuppression work even if there are no records suppressed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15198 Liz Reachanged: What|Removed |Added CC||l...@catalyst.net.nz --- Comment #18 from Liz Rea --- Does this also require an update to the system preference text, now that we don't require there to be one record marked suppressed? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15198] Make OpacSuppression work even if there are no records suppressed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15198 --- Comment #19 from Liz Rea--- oh my gosh. Reading failure. ignore me. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14939] OAI Server classes must be modularized
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14939 --- Comment #45 from Jonathan Druart--- (In reply to Frédéric Demians from comment #28) > I'm open to any proposal to replace Tiny::Capture. What about this last patch? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14939] OAI Server classes must be modularized
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14939 --- Comment #44 from Jonathan Druart--- Created attachment 45567 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45567=edit Bug 14939: Remove the Capture::Tiny dependency It's possible to redirect the std output to a variable, it will avoid to add this new dependency. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14939] OAI Server classes must be modularized
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14939 Jonathan Druartchanged: What|Removed |Added Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14377] Indicate that a record is suppressed in staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14377 --- Comment #24 from Kyle M Hall--- Created attachment 45568 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45568=edit Bug 14377 [QA Followup] - Remove biblionumber, move message to below title for search results -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14395] Two different ways to calculate 'No renewal before' (days or hours)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 --- Comment #44 from Holger Meißner--- Don't worry, bondiurbano. Everything is okay. We're just waiting to pass QA. The QA team also has to check a lot of other bugs, so this may take some time. That's all. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14377] Indicate that a record is suppressed in staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14377 --- Comment #22 from Kyle M Hall--- Created attachment 45565 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45565=edit Bug 14377 [QA Followup] - Use true value description for authorised value Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14377] Indicate that a record is suppressed in staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14377 Kyle M Hallchanged: What|Removed |Added Attachment #43026|0 |1 is obsolete|| --- Comment #21 from Kyle M Hall --- Created attachment 45564 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45564=edit Bug #14377 Show "BIBNO - Suppressed in OPAC" for records with 942$n=1. Includes class="suppressed_opac" for library specific styles. Suggested css: .suppressed_opac { color:red; font-size:1.25em; font-weight:bold; float:right; margin-right:2em; clear:none; } Signed-off-by: Nick Clemens Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14377] Indicate that a record is suppressed in staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14377 Kyle M Hallchanged: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14673] Renewals cause Sipserver to crash
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14673 --- Comment #15 from Colin Campbell--- (In reply to Barton Chittenden from comment #14) > (In reply to Colin Campbell from comment #2) > > Upping priority as this needs applying to releases from 3.18.7 to stop > > communication errors on renew. The change causing the error was bug 13315 > > I see that this has been pushed to 3.20.x, can we get it back-ported to > 3.18.x? Patch as is should apply to 3.18.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14377] Indicate that a record is suppressed in staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14377 Kyle M Hallchanged: What|Removed |Added Attachment #45565|0 |1 is obsolete|| --- Comment #23 from Kyle M Hall --- Created attachment 45566 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45566=edit Bug 14377 [QA Followup] - Use true value description for authorised value Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15314] Use Bootstrap modal for cataloging merge MARC preview
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15314 --- Comment #4 from Owen Leonard--- (In reply to Jonathan Druart from comment #3) > Shouldn't we apply the same change as what you suggest on bug 15327? There are a few issues which need to be resolved before we can universally use the "viewas=html" paramter for showmarc.pl. I plan to address them in a future patch if you don't mind. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14395] Two different ways to calculate 'No renewal before' (days or hours)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14395 --- Comment #45 from bondiurbano--- (In reply to Holger Meißner from comment #44) > Don't worry, bondiurbano. Everything is okay. We're just waiting to pass QA. > The QA team also has to check a lot of other bugs, so this may take some > time. That's all. Thanks Holger! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10858] Browse selected biblios
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 Frédéric Demianschanged: What|Removed |Added CC||frede...@tamil.fr --- Comment #92 from Frédéric Demians --- On last patch, I don't understand that, the last test: [% IF ( Koha.Preference('opacbookbag') == 1 ) || ( Koha.Preference('virtualshelves') == 1 ) || ( Koha.Preference('OpacBrowseResults') == 1 ) || ( Koha.Preference('RequestOnOpac') == 1 && (not SEARCH_RESULT.norequests) && Koha.Preference('opacuserlogin') ) %] I think that it's rather: || ( Koha.Preference('RequestOnOpac') == 1 && (not SEARCH_RESULT.norequests) && (not Koha.Preference('opacuserlogin')) ) But I'm not sure... And When everything is disabled, no checkboxes at all, links 'check all' / 'clear all' are still displayed. This bug is also in master, but still... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15352] New: a way not to show the full url in the holdings
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15352 Bug ID: 15352 Summary: a way not to show the full url in the holdings Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: neng...@gmail.com QA Contact: testo...@bugs.koha-community.org Created attachment 45578 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45578=edit item with a url See the image. I would love a way to define text to display for the url in an item instead of showing the big long ugly url. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13642] Adding new features for Dublin Core metadata
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13642 --- Comment #148 from Héctor Eduardo Castro Avalos--- Still applies -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15206] Show patron's age when filling date of birth in memberentry.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15206 --- Comment #11 from Alex Arnaud--- Created attachment 45581 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45581=edit Bug 15206 - Show patron's age in moremenber page near date of birth -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15206] Show patron's age when filling date of birth in memberentry.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15206 --- Comment #9 from Alex Arnaud--- Created attachment 45579 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45579=edit Bug 15206 - C4::Member::GetAge returns years and months -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15206] Show patron's age when filling date of birth in memberentry.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15206 --- Comment #10 from Alex Arnaud--- Created attachment 45580 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45580=edit Bug 15206 - CalculateAge in memberentry use C4::Members::GetAge() -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15206] Show patron's age when filling date of birth in memberentry.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15206 Alex Arnaudchanged: What|Removed |Added Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15206] Show patron's age when filling date of birth in memberentry.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15206 --- Comment #12 from Alex Arnaud--- Test plan: Create a new patron (members/memberentry.pl), enter a date of birth, patron'a age should be shown under Got to a patron's detail page and check his age near date of birth. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15353] New: patron image disappears when on fines tab
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15353 Bug ID: 15353 Summary: patron image disappears when on fines tab Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: neng...@gmail.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Created attachment 45582 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45582=edit no patron image where there should be When you go to the patron's fine tab the patron's image goes away and replaces it with a ? image -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14759] Replacement for Text::Unaccent
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14759 --- Comment #21 from David Cook--- (In reply to Yuval Hager from comment #20) > > I suspect that will make the output of Text::Unaccent and > > Text::Unaccent::PurePerl the same. > > > > Not really, it stays the same garbled mess. > That's odd. In that case, you could try replacing the following line: print "Text::Unaccent - $_ => " . Text::Unaccent::unac_string('utf-8', $_) . "\n"; with these lines: use Encode; my $unaccented = Text::Unaccent::unac_string('utf-8', $_); $unaccented = encode("UTF-8",$unaccented); print "Text::Unaccent - $_ => $unaccented \n"; The garbled mess is, basically, because we're using "use utf8" and Text::Unaccent returns strings without a UTF8 flag. > > unac_debug($Text::Unaccent::DEBUG_HIGH); > > > > That will also tell you what Text::Unaccent is doing (or probably not > > doing). > > I tested on one string: > > unac.c:13708: unac_data0[7] & unac_positions[0][8]: 0x05e7 => untouched > unac.c:13708: unac_data0[24] & unac_positions[0][25]: 0x05b8 => untouched > unac.c:13708: unac_data0[30] & unac_positions[0][31]: 0x05de => untouched > unac.c:13708: unac_data0[24] & unac_positions[0][25]: 0x05b8 => untouched > unac.c:13708: unac_data0[5] & unac_positions[0][6]: 0x05e5 => untouched > Text::Unaccent - קָמָץ => קָ×ָץ > > > > Note that nothing seems to happen with the (Japanese?) ideograms that Galen > > tested. I wonder if accents are even a thing with CJK languages... > > I am definitely not an authoritative source, but I know a tiny bit of > Japanese. The letters above are Kanji alphabet, and to the best of my > knowledge do not have diacritics. BUT Japanese has two more alphabets, > Hiragana and Katakana, both use diacritics, which CANNOT be removed, or they > change the sound (and potentially the meaning). > For example, in the word Hiragana, the first syllable is ひ (Hi, pronounce > Hee). This same syllable, with two ticks is び, and it sounds like Bee. A > circle makes it ぴ - sounds like Pee. Testing those three: > I was just reading some comments from a friend who was suggesting the same thing. > Text::Unaccent - ひびぴ => ã²ã²ã² > Text::Unaccent::PurePerl - ひびぴ => ひひひ > Strip NonspacingMark - ひびぴ => ひひひ > > So we've changed 'Hee Bee Pee' to 'Hee Hee Hee'. The same result (and same > syllables) for Katakana: > > Text::Unaccent - ヒビピ => ããã > Text::Unaccent::PurePerl - ヒビピ => ヒヒヒ > Strip NonspacingMark - ヒビピ => ヒヒヒ > > So diacritics, at least in those two alphabets, should not be removed, to > the best of my knowledge. In that case, I really wonder whether we should actually be removing accents for any languages, and instead look at why we started stripping accents in the first place. Text::Unaccent is clearly not removing accents for many languages, so clearly it can't be that big of a problem, no? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12803] Add ability to skip closed libraries when generating the holds queue
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 Kyle M Hallchanged: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14939] OAI Server classes must be modularized
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14939 --- Comment #47 from Frédéric Demians--- Thanks for the solution. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15351] New: RDA fields in Authority Frameworks
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15351 Bug ID: 15351 Summary: RDA fields in Authority Frameworks Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcha...@gmail.com Reporter: neng...@gmail.com QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl We should be updating the default frameworks in Koha to include the new RDA fields: http://www.itsmarc.com/crs/mergedprojects/helpauth/helpauth/rda_in_marc_authority_data.htm -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14939] OAI Server classes must be modularized
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14939 Frédéric Demianschanged: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14939] OAI Server classes must be modularized
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14939 Frédéric Demianschanged: What|Removed |Added Attachment #45567|0 |1 is obsolete|| --- Comment #46 from Frédéric Demians --- Created attachment 45577 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45577=edit Bug 14939: Remove the Capture::Tiny dependency It's possible to redirect the std output to a variable, it will avoid to add this new dependency. Signed-off-by: Frédéric Demians OK. + code factorisation with a function call. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12803] Add ability to skip closed libraries when generating the holds queue
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 --- Comment #57 from Kyle M Hall--- Jonathan, Katrin, can you please try this new patch set? I think the last patch fixes the reason your tests are failing! I've removed the other 'fix' patch so you should be able to tell. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12803] Add ability to skip closed libraries when generating the holds queue
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 --- Comment #53 from Kyle M Hall--- Created attachment 45573 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45573=edit Bug 12803 [QA Followup] - Fix unit tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12803] Add ability to skip closed libraries when generating the holds queue
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 Kyle M Hallchanged: What|Removed |Added Attachment #43511|0 |1 is obsolete|| Attachment #43512|0 |1 is obsolete|| Attachment #43610|0 |1 is obsolete|| Attachment #43779|0 |1 is obsolete|| Attachment #43833|0 |1 is obsolete|| --- Comment #49 from Kyle M Hall --- Created attachment 45569 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45569=edit Bug 12803 - Add ability to skip closed libraries when generating the holds queue The holds queue is typically generated many times a day in order to select items to fill holds. Often these items are to be sent to a different library. However, if the library whose item is picked to fill a hold is closed, that hold will remain unfilled even if there are other open libraries who own that item. It would be helpful if we could skip closed libraries for the purpose of selecting items to fill holds. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Create a record with two items on it, one at Branch A, and one at Branch B 4) Place a hold for pickup at Branch C 5) Generate the holds queue 6) Note which branch's item is selected for the hold 7) Enable the new system preference HoldsQueueSkipClosed 8) Add today as a holiday for that branch noted in step 6 9) Regenerate the holds queue 10) View the holds queue, notice the item selected is not from the closed branch! 11) prove t/db_dependent/HoldsQueue.t Signed-off by: Jason Robb -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12803] Add ability to skip closed libraries when generating the holds queue
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 --- Comment #54 from Kyle M Hall--- Created attachment 45574 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45574=edit Bug 12803 [QA Followup] - Update unit tests due to changes in master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12803] Add ability to skip closed libraries when generating the holds queue
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 --- Comment #51 from Kyle M Hall--- Created attachment 45571 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45571=edit Bug 12803 [QA Followup] - Remove use of C4::Dates C4::Dates was being included, but not used in the code! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12803] Add ability to skip closed libraries when generating the holds queue
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 --- Comment #50 from Kyle M Hall--- Created attachment 45570 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45570=edit Bug 12803 [QA Followup] - Allow holiday caching to be disabled for testing purposes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12803] Add ability to skip closed libraries when generating the holds queue
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 --- Comment #52 from Kyle M Hall--- Created attachment 45572 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45572=edit Bug 12803 [QA Followup] - Fix koha-qa.pl errors -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12803] Add ability to skip closed libraries when generating the holds queue
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 Kyle M Hallchanged: What|Removed |Added Attachment #45573|0 |1 is obsolete|| Attachment #45574|0 |1 is obsolete|| --- Comment #55 from Kyle M Hall --- Created attachment 45575 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45575=edit Bug 12803 [QA Followup] - Update unit tests due to changes in master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12803] Add ability to skip closed libraries when generating the holds queue
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12803 --- Comment #56 from Kyle M Hall--- Created attachment 45576 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45576=edit Bug 12803 [QA Followup] - Fix to stop failing unit tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10858] Browse selected biblios
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 Marjorie Barry-Vilachanged: What|Removed |Added CC||marjorie.barry-v...@ccsr.qc ||.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11311] Browse selected authorities
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11311 Marjorie Barry-Vilachanged: What|Removed |Added CC||marjorie.barry-v...@ccsr.qc ||.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/